Friday, 2020-01-10

*** TxGirlGeek has joined #openstack-nova00:08
*** tetsuro has joined #openstack-nova00:39
*** Liang__ has joined #openstack-nova01:01
*** lvbin02 has joined #openstack-nova01:10
*** zbr|rover has quit IRC01:11
*** Liang__ is now known as LiangFang01:12
*** lvbin01 has quit IRC01:12
*** lvbin02 is now known as lvbin0101:12
*** awalende has joined #openstack-nova01:12
openstackgerritMerged openstack/nova master: Add missing parameter vdi_uuid in log message  https://review.opendev.org/70100401:16
*** awalende has quit IRC01:17
*** zhanglong has joined #openstack-nova01:19
*** threestrands has joined #openstack-nova01:19
*** zbr has joined #openstack-nova01:20
*** zbr has quit IRC01:24
*** zbr has joined #openstack-nova01:26
alex_xuefried: sean-k-mooney sorry, I was too sleepy last night, I didn't follow the end of dicussion for placement-ese and flavor-ese, I saw there are some vision in the irc log, but what should we do for mix instance spec in this release?01:29
*** yedongcan has joined #openstack-nova01:33
*** tbachman has joined #openstack-nova01:43
openstackgerritzhufl proposed openstack/nova master: Fix typos in nova doc  https://review.opendev.org/70187601:45
*** yedongcan has quit IRC01:49
*** threestrands has quit IRC01:50
*** TxGirlGeek has quit IRC01:51
*** brinzhang has joined #openstack-nova01:52
*** artom has quit IRC02:04
*** TxGirlGeek has joined #openstack-nova02:06
*** cz2 is now known as cz302:08
*** TxGirlGeek has quit IRC02:11
*** zbr has quit IRC02:16
*** zbr_ has joined #openstack-nova02:16
*** zbr_ has quit IRC02:17
*** yedongcan has joined #openstack-nova02:19
*** gyee has quit IRC02:23
*** brinzhang_ has joined #openstack-nova02:27
*** zbr has joined #openstack-nova02:29
*** brinzhang has quit IRC02:30
*** brinzhang has joined #openstack-nova02:31
*** ileixe has quit IRC02:32
*** brinzhang_ has quit IRC02:32
*** brinzhang has quit IRC02:33
*** brinzhang has joined #openstack-nova02:34
openstackgerritMerged openstack/nova master: Use Placement 1.35 (root_required)  https://review.opendev.org/69905002:44
*** yedongcan has quit IRC02:54
*** mkrai has joined #openstack-nova03:01
*** tbachman has quit IRC03:11
*** tbachman has joined #openstack-nova03:12
*** psachin has joined #openstack-nova03:22
*** lvbin02 has joined #openstack-nova03:37
*** lvbin01 has quit IRC03:39
*** lvbin02 is now known as lvbin0103:39
*** abaindur has quit IRC03:50
*** tbachman has quit IRC04:29
*** bhagyashris has joined #openstack-nova04:44
*** tetsuro has quit IRC04:44
*** tetsuro has joined #openstack-nova04:45
*** tetsuro has quit IRC04:49
*** brinzhang_ has joined #openstack-nova05:05
*** ratailor has joined #openstack-nova05:06
*** bhagyashris has quit IRC05:07
*** factor has quit IRC05:08
*** brinzhang has quit IRC05:08
*** factor has joined #openstack-nova05:08
*** bhagyashris has joined #openstack-nova05:19
*** LiangFang has quit IRC05:21
*** Liang__ has joined #openstack-nova05:21
*** Liang__ is now known as LiangFang05:23
*** tkajinam has quit IRC05:26
*** tkajinam has joined #openstack-nova05:29
LiangFangdansmith: happy new year:) Could you please help to review again: https://review.opendev.org/#/c/689070/05:29
*** links has joined #openstack-nova05:31
LiangFangrelated code implemetation are also ready except UT: https://review.opendev.org/#/c/663542/05:31
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:34
*** ratailor_ has joined #openstack-nova05:44
*** tetsuro has joined #openstack-nova05:45
*** ratailor has quit IRC05:47
*** tetsuro has quit IRC05:49
*** tetsuro has joined #openstack-nova05:53
*** brinzhang has joined #openstack-nova05:53
*** brinzhang_ has quit IRC05:56
*** tetsuro has quit IRC05:57
*** tetsuro_ has joined #openstack-nova05:57
*** tkajinam_ has joined #openstack-nova06:02
*** tkajinam has quit IRC06:04
*** macz has joined #openstack-nova06:04
*** lpetrut has joined #openstack-nova06:08
*** lpetrut has quit IRC06:09
*** lpetrut has joined #openstack-nova06:10
*** macz has quit IRC06:14
*** brinzhang_ has joined #openstack-nova06:26
*** brinzhang has quit IRC06:28
*** gregwork has quit IRC06:42
*** brinzhang has joined #openstack-nova06:54
*** brinzhang_ has quit IRC06:58
*** lvbin01 has quit IRC07:01
*** lvbin01 has joined #openstack-nova07:02
*** brinzhang_ has joined #openstack-nova07:04
*** yedongcan has joined #openstack-nova07:06
*** brinzhang has quit IRC07:07
*** brinzhang has joined #openstack-nova07:08
*** brinzhang_ has quit IRC07:09
*** brinzhang has quit IRC07:10
*** brinzhang has joined #openstack-nova07:10
*** jawad_axd has joined #openstack-nova07:12
*** rcernin has quit IRC07:15
*** bhagyashris has quit IRC07:17
*** bhagyashris has joined #openstack-nova07:17
*** slaweq has joined #openstack-nova07:18
*** crazik has joined #openstack-nova07:20
*** crazik has left #openstack-nova07:20
*** dpawlik has joined #openstack-nova07:41
*** rpittau|afk is now known as rpittau07:44
*** pcaruana has joined #openstack-nova07:53
*** awalende has joined #openstack-nova08:00
*** lvbin01 has quit IRC08:01
*** lvbin01 has joined #openstack-nova08:04
*** tetsuro_ has quit IRC08:10
*** tosky has joined #openstack-nova08:12
*** shilpasd has joined #openstack-nova08:18
*** tesseract has joined #openstack-nova08:22
*** tkajinam_ has quit IRC08:22
*** ratailor_ has quit IRC08:26
*** maciejjozefczyk has joined #openstack-nova08:27
*** brinzhang_ has joined #openstack-nova08:29
*** mkrai has quit IRC08:33
*** brinzhang has quit IRC08:33
*** awalende_ has joined #openstack-nova08:35
*** awalende has quit IRC08:38
*** dpawlik has quit IRC08:39
*** lvbin01 has quit IRC08:40
openstackgerritMerged openstack/nova master: Add a workaround config toggle to refuse ceph image upload  https://review.opendev.org/65707808:41
*** abhishekk is now known as abhishekk|lunch08:42
*** mkrai has joined #openstack-nova08:43
*** dpawlik has joined #openstack-nova08:45
*** lvbin01 has joined #openstack-nova08:45
shilpasdHi, thanks for review for DB patch for ignore root_gb08:46
*** lvbin01 has quit IRC08:46
shilpasdbrinzhang_: thanks for review for DB patch for ignore root_gb08:46
shilpasdregarding comment related to release note, IMO since its code level changes, we shouldn't have08:46
*** pcaruana has quit IRC08:46
brinzhang_shipasd: Yeah, I am ok.08:47
shilpasdbrinzhang_: thanks08:47
*** ratailor has joined #openstack-nova08:47
brinzhang_shilpasd: np :)08:48
*** xek__ has joined #openstack-nova08:49
brinzhang_alex_xu: I am reviewing this bug https://bugs.launchpad.net/nova/+bug/1663456, I think Vishakha Agarwal fix is available, can you restore https://review.opendev.org/#/c/580271/08:50
openstackLaunchpad bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,Confirmed]08:50
*** factor has quit IRC08:50
*** factor has joined #openstack-nova08:51
brinzhang_alex_xu: it's abandoned by matt because of the merge conflict, I will resolve the merge conflict, and let the bug continue08:51
*** lvbin01 has joined #openstack-nova08:51
*** pcaruana has joined #openstack-nova08:53
*** abhishekk|lunch is now known as abhishekk08:56
*** ralonsoh has joined #openstack-nova08:56
*** lvbin01 has quit IRC09:10
*** lvbin01 has joined #openstack-nova09:11
*** LiangFang has quit IRC09:18
*** zbr is now known as zbr|rover09:19
*** mlavalle has quit IRC09:20
*** damien_r has joined #openstack-nova09:31
*** derekh has joined #openstack-nova09:35
*** ratailor_ has joined #openstack-nova09:44
*** ratailor has quit IRC09:46
*** ociuhandu has joined #openstack-nova09:48
gibidansmith: thanks for starting the discussion on the conflicting ovo usage. I appreciate your effort. I was alway too lazy to start up such a discussion. I will comment your patches soon09:51
*** zhanglong has quit IRC09:54
*** martinkennelly has joined #openstack-nova09:56
ralonsohgibi, sorry, I updated the commit message at the same you +1 the patch https://review.opendev.org/#/c/701797/10:03
*** dtantsur|afk is now known as dtantsur10:05
*** damien_r has quit IRC10:08
*** damien_r has joined #openstack-nova10:11
*** lvbin01 has quit IRC10:16
*** lvbin02 has joined #openstack-nova10:16
*** lvbin02 is now known as lvbin0110:18
*** mkrai has quit IRC10:26
*** ratailor__ has joined #openstack-nova10:32
*** ratailor_ has quit IRC10:35
*** brinzhang has joined #openstack-nova10:35
*** damien_r has quit IRC11:09
*** damien_r has joined #openstack-nova11:10
*** damien_r has quit IRC11:12
*** mkrai has joined #openstack-nova11:14
*** damien_r has joined #openstack-nova11:15
*** tbachman has joined #openstack-nova11:19
*** tbachman has quit IRC11:21
*** rpittau is now known as rpittau|bbl11:21
gibiralonsoh: no worries11:28
gibiralonsoh: thanks for fixing the gatae11:28
gibigate11:28
*** yedongcan has left #openstack-nova11:30
*** mkrai has quit IRC11:32
*** lvbin01 has quit IRC11:36
*** links has quit IRC11:37
*** lvbin01 has joined #openstack-nova11:37
*** links has joined #openstack-nova11:37
*** bhagyashris has quit IRC11:39
*** mkrai has joined #openstack-nova11:41
openstackgerritLuyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory  https://review.opendev.org/69586311:41
*** brinzhang_ has quit IRC11:50
*** brinzhang_ has joined #openstack-nova11:50
brinzhanggibi: sean-k-mooney: could you please review these specs? https://review.opendev.org/#/c/699669/ and https://review.opendev.org/#/c/682302/12:04
brinzhanggibi, sean-k-moonkey: thanks~12:05
*** lvbin01 has quit IRC12:08
*** brinzhang_ has quit IRC12:11
*** brinzhang_ has joined #openstack-nova12:11
*** mkrai has quit IRC12:13
*** lvbin01 has joined #openstack-nova12:14
sean-k-mooneyefried: do you know if sundar has been testing his cyborg patches on centos 7 still. i have tried 3 different way to get python 3.6 running properly on centos and they all end up failing to stack with python errors so im swaping to ubunut just want to check if you know if he has tested ubuntu 18.0412:16
sean-k-mooneyi assume the tempest job proably used ubunut so it should work but just said i would ask12:19
gibibrinzhang: added to my review queue12:25
brinzhanggibi: thanks :)12:26
gibidansmith, efried: I commented both ovo improvement patch. I totally +2 on the EphemeralObject one, and I'm OK with the default_fn too but I don't see where I will use that in Nova12:31
brinzhanggibi: Today I was reviewed this bug https://bugs.launchpad.net/nova/+bug/1663456,and reviewed it's fixed patch, I think it's available, and it was abandoned by matt, could you please restore this patch?12:33
openstackLaunchpad bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,Confirmed] - Assigned to Brin Zhang (zhangbailin)12:33
brinzhanggibi: I will resolve that merge conflict, and continue work for it.12:33
*** pcaruana has quit IRC12:34
*** pcaruana has joined #openstack-nova12:38
*** mgariepy has joined #openstack-nova12:41
*** ratailor__ has quit IRC12:41
gibibrinzhang: restored the review https://review.opendev.org/#/c/580271/12:47
lyarwooddid someone track down a change in devstack-gate that's causing n-net to be dropped from stable/queens cells-v1 runs?12:48
* lyarwood is sure someone raised this in here a few days ago12:49
*** rpittau|bbl is now known as rpittau12:55
*** ociuhandu has quit IRC12:55
*** ociuhandu has joined #openstack-nova12:56
*** ociuhandu has quit IRC12:58
*** ociuhandu has joined #openstack-nova12:58
fricklerlyarwood: that should be fixed by https://review.opendev.org/70140413:01
frickleroh, n-net13:01
fricklerthat isn't fixed afaict, need to do something similar to the above probably if that's really still needed13:02
fricklerthe fix was for n-cauth13:02
lyarwoodyeah I think I'm confusing it with thast13:02
lyarwoodhttps://a2c2b9c0506b0b396571-e07636147bed59ede28bbdb888fbf884.ssl.cf1.rackcdn.com/700359/1/gate/nova-cells-v1/11412d4/logs/local.conf.txt.gz - n-net is missing from local.conf here on the nova-cells-v1 jobs that results in n-cpu trying to use neutron even when it isn't deployed. Trying to work out why now as this wasn't the case on the 23rd.13:03
fricklerlyarwood: this patch dropped it https://review.opendev.org/#/c/700217/13:04
fricklerso it's all mriedem's fault ;)13:04
lyarwood\o/13:05
lyarwoodI'll add it back in for queens now13:05
lyarwoodthanks :)13:05
*** links has quit IRC13:05
*** links has joined #openstack-nova13:05
*** links has quit IRC13:05
sean-k-mooneylyarwood: queens is em now right13:06
*** martinkennelly has quit IRC13:06
sean-k-mooneywe will eventually drop it and the cells v1 job im assuming but i guess not for a while13:06
lyarwoodsean-k-mooney: yup, it was passing prior to this change and as it's just infra I'll fix it13:07
sean-k-mooneyya im just not sure how many people are still running cellsv1 and queens13:08
sean-k-mooneyim sure there is some unfortunete that is but if it was an invovled fix rather then just enableing nova networks again i would question the merit more13:08
*** psachin has quit IRC13:09
lyarwoodyup indeed13:09
lyarwoodfrickler: FYI https://review.opendev.org/70195713:12
*** trident has quit IRC13:13
*** trident has joined #openstack-nova13:15
fricklerlyarwood: thx, added to my list, will review once the test results are in13:15
openstackgerritLee Yarwood proposed openstack/nova stable/queens: DNM Test devstack-gate n-net fix  https://review.opendev.org/70195813:17
*** ociuhandu has quit IRC13:22
*** ociuhandu_ has joined #openstack-nova13:22
*** mriedem has joined #openstack-nova13:37
*** tbachman has joined #openstack-nova13:40
*** tbachman has quit IRC13:45
*** tbachman has joined #openstack-nova13:46
*** mkrai has joined #openstack-nova13:46
*** mriedem is now known as hansmoleman13:50
*** davee___ has joined #openstack-nova13:51
*** davee_ has quit IRC13:52
*** davee__ has quit IRC13:53
*** davee_ has joined #openstack-nova13:53
*** mlavalle has joined #openstack-nova14:03
aarentsHi, kashyap: lyarwood I need your feedback from that: https://review.opendev.org/#/c/696084/ if you may have a look14:03
kashyapaarents: Hi14:03
* kashyap clicks14:03
kashyapaarents: Have queued it; once I flush my curent cache, will look.14:05
lyarwoodaarents: ack also looking14:05
lyarwoodhmm is gerrit dead for anyone else?14:06
lyarwoodnvm it's back14:06
aarentskashyap: lyarwood great, thks14:06
*** tbachman has quit IRC14:12
*** awalende_ has quit IRC14:13
*** awalende has joined #openstack-nova14:13
*** nweinber__ has joined #openstack-nova14:15
*** awalende has quit IRC14:18
*** shilpasd has quit IRC14:18
*** liuyulong has joined #openstack-nova14:25
*** dtantsur is now known as dtantsur|brb14:27
*** jawad_axd has quit IRC14:36
*** jawad_axd has joined #openstack-nova14:37
*** jawad_axd has quit IRC14:37
*** hansmoleman has quit IRC14:37
*** jawad_axd has joined #openstack-nova14:41
*** jawad_axd has quit IRC14:45
*** ociuhandu has joined #openstack-nova14:46
*** ociuhandu_ has quit IRC14:46
efriedalex_xu: gimme a second and I'll try to summarize the discussion...14:55
efriedsean-k-mooney: I don't know where/how Sundar has been testing, let me ask him.14:55
*** artom has joined #openstack-nova14:57
*** Sundar has joined #openstack-nova14:59
efriedSundar: sean-k-mooney was asking what OS you're using to test cyborg stuff...14:59
*** artom has quit IRC15:00
efriedSundar: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-01-10.log.html#t2020-01-10T12:16:0115:00
Sundarefried: sean-k-mooney: It is mostly Centos 7.6.15:00
*** artom has joined #openstack-nova15:01
*** macz has joined #openstack-nova15:02
*** dave-mccowan has joined #openstack-nova15:06
sean-k-mooneySundar: so the issue i have with centos 7.6 was gettign a working version of python 3.615:08
sean-k-mooneyyou cant deploy nova under python 2 anymore and i was getting issue with python 3.6 from eple15:09
*** jdillaman has joined #openstack-nova15:09
Sundarsean-k-mooney: I have installed Python 3.6 with Centos 7.6, and I am testing exclusively with Py3.15:09
sean-k-mooneyi have stacked on ubuntu now but without the nova changes ill restack with that after the meeting im on finishes up15:09
sean-k-mooneySundar: ok i was getting some trace back although it was runrelated to cyborg15:10
SundarI understand it is not a first class citizen yet. There are a few wrinkles.15:10
sean-k-mooneyi tried installing python3.6 3 different way so maybe one of the first two caussed issue when i installed it from epel15:10
sean-k-mooneySundar: well centos 7 is not going to be offically supported for ussuri15:11
sean-k-mooneypeopel are workign to move devstack to centos 815:11
sean-k-mooneyi used to be able to use py36 on centos fine but it broke for me back in august15:12
Sundarsean-k-mooney: Totally understand. Many Centos packages still assume Python 2, such as yum etc. Had some issues with pip2 etc. My main constraint is, I often work with FPGAs and that stack is validated with Centos 7.6 and old Ubuntu.15:13
SundarMeanwhile, many 'real world' deployments of the stack are with Centos, so I kinda prioritize that15:13
Sundarsean-k-mooney: "centos 7 is not going to be offically supported for ussuri" -- for devstack? Or more generally?15:15
sean-k-mooneyin general15:15
sean-k-mooneyhttps://github.com/openstack/governance/blob/master/reference/runtimes/ussuri.rst15:15
sean-k-mooneySundar: the RDO comuntiy are moveig to centos 8 at the moment and redhat move our product to rhel 8 for stien15:17
sean-k-mooneythe install poject like kolla and osa i belive are swapping in train or ussuri15:17
*** eharney has joined #openstack-nova15:17
*** zul has joined #openstack-nova15:20
SundarWe can test with the fake driver and Centos 8. That _should_ work now, but I haven't checked it yet.15:22
*** tbachman has joined #openstack-nova15:22
*** ociuhandu has quit IRC15:23
*** mriedem has joined #openstack-nova15:27
*** mriedem is now known as hansmoleman15:28
efriedalex_xu: We didn't really come to a firm agreement on the approach for placement-ese vs. flavor-ese with mixed CPUs.15:39
efrieddansmith and I have a slight disagreement about the long-term vision.15:39
efriedI don't like the idea of using placement-ese at all, because it's not going to be powerful enough to do everything we need, and if we're going to have to home-grow a syntax anyway, IMO it's less confusing to use that same home-grown syntax consistently vs. mixing syntaxes.15:39
efriedBut dansmith contends that the placement syntax is simple, strict, and consistent; and we want the main use cases to use *just* that syntax and make reasonable guesses/defaults for the complicated stuff.15:39
efriedSince we already have the precedent of using placement-ese for PCPUs from stephenfin's work in Train, I can get behind Dan's approach, but will reserve an "I told you so" for when we have to start mixing resources:$RC and hw:* e.g. for numa modeling.15:39
efriedSo in conclusion: if we say the mixed-CPU blueprint should *only* use placement-ese syntax, is it possible for the virt driver to do a reasonable thing wrt selecting which physical CPUs to pin and which to float; and which guest CPU IDs they should land on?15:39
efriedAnd will that work sanely even when hw:numa_nodes is >1?15:39
*** mkrai has quit IRC15:40
*** ociuhandu has joined #openstack-nova15:44
*** belmoreira has quit IRC15:47
openstackgerritMykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata  https://review.opendev.org/69804015:56
*** jangutter has quit IRC15:59
*** maciejjozefczyk is now known as mjozefcz|afk16:00
sean-k-mooneyefried: if we want as sane algorting i would propose spread floating cpus round robing aross numa nodes first then make all the rest pinned16:07
sean-k-mooneyso for a singel numa vm that will result in all the floating cores first and the pinned cores last16:07
sean-k-mooneyfor multin numa node guest then per numa node the first x cores will be floating and the rest will be pinned16:08
sean-k-mooneyand in any case we will report th pinned vs mixed in the metadta api and or toplogy api16:08
*** jawad_axd has joined #openstack-nova16:08
sean-k-mooneyefried: alex_xu ^16:08
*** artom has quit IRC16:08
*** dtantsur|brb is now known as dtantsur16:08
sean-k-mooney/algorting/algorithim16:09
* sean-k-mooney something like that16:09
sean-k-mooneyso you would do hw:numa_nodes=2 resouces=PCPU:6,VCPU:216:10
sean-k-mooneyand that would give you a 2 numa node vm with the first core in each numa node floatign and the rest pinned16:10
sean-k-mooneythe linux kernel has a preference for using the first core per numa node and socket to handel some housekeeping task hence the resoning behind that approch16:11
*** jawad_axd has quit IRC16:13
sean-k-mooneyby the way if we do that or something similar the detail of that should be considered private and subject to change and the tenant should always consume the info form the metadta api16:14
efriedyeah, that seems reasonable to me, but I want the spec owners to confirm it's workable for them.16:15
dansmithefried: I don't want to be the sole recipient of the told-you-so16:18
dansmithif I'm the only one that prefers that method, then of course it doesn't make sense to go down a path everyone else doesn't want16:18
efriedI think it's just you & me in the cage dansmith.16:19
dansmithit makes me sad, but I'm sad about a lot of things16:19
efriedAs usual, you're probably right and I'm probably wrong anyway.16:19
dansmithno, I'm sure you're right16:21
*** dviroel has joined #openstack-nova16:24
*** iurygregory has joined #openstack-nova16:29
openstackgerritIury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc  https://review.opendev.org/70199816:29
*** damien_r has quit IRC16:31
*** TxGirlGeek has joined #openstack-nova16:34
*** jawad_axd has joined #openstack-nova16:44
*** mkrai has joined #openstack-nova16:45
*** mkrai has quit IRC16:47
*** jawad_axd has quit IRC16:49
*** tbachman has quit IRC16:50
sean-k-mooneywell im not a fan of the group sysntax in the flavor or a direct mapping form flavor resource requets to placement query16:51
sean-k-mooneyso i do like the hw:* extra spec for that reason16:52
*** lpetrut has quit IRC16:52
*** brault has joined #openstack-nova16:52
sean-k-mooneybut if you just use the unnumbered groups in the flavor and hw:* for tweeking then i could buy that16:52
sean-k-mooneyi think think there is a midel ground16:52
dansmithefried: https://pastebin.com/zbHra4rr16:56
*** gyee has joined #openstack-nova16:56
*** ociuhandu has quit IRC16:57
dansmithservice is the outlier there. we break the rules specifically because version should *always* be overridden always16:57
dansmithso I'll have to figure out some way to copiously document why that is the case, if not already16:57
*** dpawlik has quit IRC16:57
*** mriedem has joined #openstack-nova17:01
*** hansmoleman has quit IRC17:04
*** mriedem has left #openstack-nova17:05
*** mriedem has joined #openstack-nova17:05
*** ociuhandu has joined #openstack-nova17:06
*** rpittau is now known as rpittau|afk17:10
efrieddansmith: Am I looking at the result of the test that we talked about yesterday?17:12
*** artom has joined #openstack-nova17:12
efriedSo after asserting that we should never ever overwrite the table cell, we found an example where we have to overwrite the table cell?17:12
dansmithyeah, just fyi, that's the list of objects that do naughty things17:12
*** brinzhang has quit IRC17:13
dansmithservice version is kinda special in that regard.. we want to overwrite it always and forever, kinda like how updated_at is always set outside of your control17:13
efriedyeah, updated_at was the example that came to mind yesterday, but I figured that was handled specially somehow.17:14
dansmithit is handled below the object layer17:14
dansmithsince service version is *implemented* at the object layer it can't be done in the db layer17:15
efriedmakes sense.17:15
* efried bbiab17:15
*** tbachman has joined #openstack-nova17:15
dansmithefried: hah, past me was on it: https://github.com/openstack/nova/blob/b0cae0750c3d9f9ebac33ee38cc1762fdd7fc138/nova/objects/service.py#L231-L23517:17
sean-k-mooneywhy am di not surprised that the numa and pci objects are on that list17:17
*** mriedem has left #openstack-nova17:17
dansmithsean-k-mooney: yeah they're *awful* unfortunately17:17
dansmithsean-k-mooney: would really appreciate you reviewing this patch to see if I'm breaking anything by making the changes I'm making17:17
dansmithwhen I post it that is17:17
sean-k-mooneyi was just going to ask which patch but sure add me to it and ill take a look17:18
*** tesseract has quit IRC17:19
*** jawad_axd has joined #openstack-nova17:20
*** mlavalle has quit IRC17:23
*** mjozefcz|afk is now known as maciejjozefczyk17:24
*** mlavalle has joined #openstack-nova17:24
*** liuyulong_ has joined #openstack-nova17:25
*** jawad_axd has quit IRC17:25
dansmithefried: Sundar: FYI, since I haven't seen much activity lately: I'm off in the wilderness week after next, completely unreachable most of the time17:26
*** liuyulong has quit IRC17:28
*** dtantsur is now known as dtantsur|afk17:30
*** maciejjozefczyk has quit IRC17:30
*** ociuhandu has quit IRC17:33
*** evrardjp has quit IRC17:33
*** evrardjp has joined #openstack-nova17:34
*** ociuhandu has joined #openstack-nova17:36
*** yan0s has quit IRC17:43
*** bbowen has quit IRC17:51
*** iurygregory has quit IRC17:54
*** derekh has quit IRC18:01
dansmithsean-k-mooney: hrm18:01
dansmithlooks like an os-vif object is leaking into nova's namespace18:02
dansmithnot sure how that's happening18:04
dansmithooh18:05
dansmithI wonder if it's because you have a "Network" object and we do too, and get_nova_objects() is only checking the first in the list18:06
sean-k-mooneymaybe18:09
*** pcaruana has quit IRC18:09
dansmithbut the repository is mixing the two, which seems, like bad.. but gawd I don't even want to think about that right now18:10
*** ociuhandu has quit IRC18:12
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove VIR_DOMAIN_BLOCK_REBASE_RELATIVE check  https://review.opendev.org/70202118:20
sean-k-mooneydansmith: sorry was on a call18:22
sean-k-mooneyam can you point me in the right direction and i can try an figure out how this is happenign.18:22
dansmithI was thinking it was something in os-vif but now I don't think it is18:23
dansmithso it'd be something for me to resolve if anything18:23
sean-k-mooneydansmith: we should be construciton the os-vif objects from nova ones but neither should contain the other. and the should in theory be in there own namespace but maybe that is not done correctly18:23
dansmithyeah the namespace stuff was added way late when we were spinning things out18:24
dansmithit's working right now, there's just a wrinkle in this test18:24
dansmithso I will work around that and then revisit the bigger picture, but yeah I think os-vif is doing the right thing now that I look18:25
*** brinzhang has joined #openstack-nova18:25
sean-k-mooneythis is where we set the os-vif namespace by the way https://github.com/openstack/os-vif/blob/master/os_vif/objects/base.py#L1818:26
dansmithyep, I dug in18:26
*** brinzhang_ has quit IRC18:28
dansmithbtw, when are we going to switch the functional tox target to be py37 by default? I hate having to type out functional-py37 each time18:29
sean-k-mooneyin nova you mean18:29
sean-k-mooneywe could do that now i guess18:29
dansmithyes18:29
sean-k-mooneyits after m118:29
sean-k-mooneydansmith: it looks like its already python318:30
sean-k-mooneyso tox -e functional will use your default system python 318:30
dansmithis it? why do we have functional-py37 then?18:30
sean-k-mooneythat is proably 3.618:31
sean-k-mooneywell functional-py37 will be expressly 3.7 regardless of your system default18:31
dansmithlast I checked, which has been a while, functional would use whatever env says "python" resolves to, which is 2.7 for me18:31
sean-k-mooneythe fucntioal target is inheriting basepython = python318:31
dansmithah okay18:32
dansmithhmm, from 201818:32
sean-k-mooneyos ya it will use whatever python3 point too18:32
sean-k-mooneyam no form https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed418:33
sean-k-mooneyit had python 2.7 explcitly before https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed4#diff-b91f3d5bd63fcd17221b267e851608e8L6918:33
dansmithoh good good, that explains it18:33
sean-k-mooneyi still kind of want to add a "unit" env so we can do the same thing with the unit tests18:34
sean-k-mooneyi.e. just run them with any python 3 and tell me if they pass18:34
dansmithyeah that would be nice18:35
dansmithhitting p-y-[2-3] is actually fairly error-prone for me18:35
*** mvkr has quit IRC18:36
sean-k-mooneyi use crtl-r to seach my history way to much but ya i dont mind it too much but it can be annoying at times18:37
dansmithyeah, but c-r tox doesn't work always, and otherwise I have to type the py37 bit anyway18:37
sean-k-mooneymy most common mistate is ttyring to change form 27 to 36 and ending up with 2618:37
dansmithsean-k-mooney: no, your most common mistake is any english word ever, but I'll concede that py26 is probably in the list somewhere too :P18:38
sean-k-mooneyhehe :) ya i noticed that after i hit enter.18:38
dansmithheh18:38
sean-k-mooneyi need to like bind enter to spell check and shift enter to send or somehting18:39
dansmithpre-send hook requiring aspell==018:40
dansmithpretty sure we'd never hear from you again though18:40
sean-k-mooneyactully i need to resinstall aspell i had it integreated but i broke it a while a go18:40
*** liuyulong_ has quit IRC18:41
sean-k-mooneyanyway im going to try restacking with the latest cyborg change so ill be back in a while when that is done. im currently trying to test with the fake driver18:41
dansmithscweet18:42
dansmither, schweet18:42
* sean-k-mooney hehe my plan to break everyone elses spelling is slowly working18:42
*** eharney has quit IRC18:54
*** TxGirlGeek has quit IRC18:55
*** pcaruana has joined #openstack-nova18:57
*** ralonsoh has quit IRC18:59
*** TxGirlGeek has joined #openstack-nova19:14
*** factor has quit IRC19:27
*** dklyle has quit IRC19:28
artomyeah is pell liek a tads now19:29
*** lpetrut has joined #openstack-nova19:30
*** TxGirlGeek has quit IRC19:32
*** dklyle has joined #openstack-nova19:37
*** TxGirlGeek has joined #openstack-nova19:38
*** TxGirlGeek has quit IRC19:50
*** macz has quit IRC19:51
*** eharney has joined #openstack-nova19:52
*** martinkennelly has joined #openstack-nova20:08
*** martinkennelly has quit IRC20:09
*** mriedem has joined #openstack-nova20:13
*** jawad_axd has joined #openstack-nova20:15
*** artom has quit IRC20:18
*** jawad_axd has quit IRC20:20
*** jawad_axd has joined #openstack-nova20:36
*** jawad_axd has quit IRC20:41
*** bbowen has joined #openstack-nova20:43
*** jawad_axd has joined #openstack-nova20:57
*** jawad_axd has quit IRC21:01
*** martinkennelly has joined #openstack-nova21:08
*** bbowen_ has joined #openstack-nova21:17
*** bbowen has quit IRC21:19
*** TxGirlGeek has joined #openstack-nova21:23
*** TxGirlGeek has quit IRC21:26
*** martinkennelly has quit IRC21:35
*** TxGirlGeek has joined #openstack-nova21:43
*** nweinber__ has quit IRC21:47
*** lbragstad has quit IRC21:54
*** lbragstad has joined #openstack-nova21:54
openstackgerritDan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects  https://review.opendev.org/70204922:09
efried\o/22:10
dansmithoops,22:14
dansmithI forgot to clean up your requestgroup thing22:14
dansmithbut, pretend this is you: https://review.opendev.org/#/c/702049/1/nova/objects/diagnostics.py22:14
openstackgerritDan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects  https://review.opendev.org/70204922:25
*** ivve has quit IRC22:26
mriedemooo did i provide the mixin idea?22:33
mriedemf yeah i did https://review.opendev.org/#/c/699050/5/nova/objects/request_spec.py@123122:33
dansmithmriedem: about 24 hours late :)22:41
mriedemi'm going to say there was some precog stuff at work here22:44
mriedemin order to still take credit22:44
dansmithhmm, okay :)22:45
*** KeithMnemonic has quit IRC22:46
*** dave-mccowan has quit IRC22:48
*** awalende has joined #openstack-nova23:14
*** awalende has quit IRC23:18
*** Sundar has quit IRC23:20
*** abaindur has joined #openstack-nova23:26
openstackgerritMerged openstack/nova master: Fix typos in nova doc  https://review.opendev.org/70187623:27
sean-k-mooneydansmith: ill take a look at that patch a little more in deail but i left a comment for you on the pci_device __init__23:29
*** pcaruana has quit IRC23:35
*** cyclaw has quit IRC23:47
*** gentoorax has joined #openstack-nova23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!