| *** avolkov has quit IRC | 00:03 | |
| *** zhanglong has joined #openstack-nova | 00:04 | |
| *** igordc has quit IRC | 00:12 | |
| *** Sundar has quit IRC | 00:17 | |
| *** brinzhang has joined #openstack-nova | 00:21 | |
| *** brinzhang has quit IRC | 00:22 | |
| *** brinzhang has joined #openstack-nova | 00:23 | |
| *** brinzhang_ has quit IRC | 00:23 | |
| *** dosaboy has joined #openstack-nova | 00:23 | |
| openstackgerrit | Merged openstack/nova stable/queens: Fix listing deleted servers with a marker https://review.opendev.org/690725 | 00:25 |
|---|---|---|
| openstackgerrit | Merged openstack/nova master: trivial: Remove dead code https://review.opendev.org/698703 | 00:25 |
| openstackgerrit | Merged openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | 00:25 |
| *** brinzhang has quit IRC | 00:25 | |
| *** brinzhang has joined #openstack-nova | 00:26 | |
| openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | 00:26 |
| brinzhang | efried: Thanks, I send this to the ML :) | 00:26 |
| *** mriedem has quit IRC | 00:32 | |
| *** tbachman has joined #openstack-nova | 00:32 | |
| *** brinzhang_ has joined #openstack-nova | 00:35 | |
| *** tobberydberg has quit IRC | 00:35 | |
| *** awalende has joined #openstack-nova | 00:36 | |
| *** johanssone has quit IRC | 00:36 | |
| *** tobberydberg has joined #openstack-nova | 00:37 | |
| *** brinzhang has quit IRC | 00:37 | |
| *** johanssone has joined #openstack-nova | 00:39 | |
| *** awalende has quit IRC | 00:41 | |
| *** rcernin has joined #openstack-nova | 00:48 | |
| *** zhanglong has quit IRC | 00:49 | |
| *** gyee has quit IRC | 00:52 | |
| *** zhanglong has joined #openstack-nova | 00:56 | |
| *** Liang__ has joined #openstack-nova | 00:59 | |
| *** ozzzo has joined #openstack-nova | 01:00 | |
| *** tbachman has quit IRC | 01:11 | |
| *** mlavalle has quit IRC | 01:31 | |
| *** zhanglong has quit IRC | 01:34 | |
| *** zhanglong has joined #openstack-nova | 01:37 | |
| *** larainema has joined #openstack-nova | 01:43 | |
| melwitt | jroll: thanks, I've started a ML thread to better organize my questions and get people's thoughts in one place http://lists.openstack.org/pipermail/openstack-discuss/2019-December/011558.html cc TheJulia | 01:56 |
| *** brinzhang has joined #openstack-nova | 01:59 | |
| *** brinzhang_ has quit IRC | 02:02 | |
| *** yikun has joined #openstack-nova | 02:15 | |
| *** lvbin02 has joined #openstack-nova | 02:16 | |
| luyao | mriedem, efried : we don't patch anything on Intel OpenStack CI, it should be zuul problem | 02:16 |
| *** lvbin01 has quit IRC | 02:19 | |
| *** lvbin02 is now known as lvbin01 | 02:19 | |
| *** lvbin01 has quit IRC | 02:47 | |
| *** lvbin01 has joined #openstack-nova | 02:47 | |
| *** ociuhandu has joined #openstack-nova | 02:52 | |
| *** ociuhandu has quit IRC | 02:58 | |
| *** mkrai has joined #openstack-nova | 03:00 | |
| *** jbernard has left #openstack-nova | 03:04 | |
| *** mkrai has quit IRC | 03:13 | |
| *** mkrai_ has joined #openstack-nova | 03:13 | |
| *** psachin has joined #openstack-nova | 03:32 | |
| *** brinzhang_ has joined #openstack-nova | 03:35 | |
| *** brinzhang has quit IRC | 03:38 | |
| *** tbachman has joined #openstack-nova | 03:39 | |
| openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Validate aggregate IDs before querying database https://review.opendev.org/698094 | 03:53 |
| *** bhagyashris has joined #openstack-nova | 03:54 | |
| *** zhanglong has quit IRC | 03:55 | |
| *** brinzhang has joined #openstack-nova | 04:09 | |
| *** zhanglong has joined #openstack-nova | 04:12 | |
| *** brinzhang_ has quit IRC | 04:12 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/698106 | 04:13 |
| openstack | bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,In progress] https://launchpad.net/bugs/1829479 - Assigned to Matt Riedemann (mriedem) | 04:13 |
| openstack | bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem) | 04:13 |
| *** zhanglong has quit IRC | 04:22 | |
| *** zhanglong has joined #openstack-nova | 04:24 | |
| *** udesale has joined #openstack-nova | 04:29 | |
| *** brinzhang_ has joined #openstack-nova | 04:32 | |
| *** brinzhang_ has quit IRC | 04:33 | |
| *** brinzhang_ has joined #openstack-nova | 04:34 | |
| *** zhanglong has quit IRC | 04:34 | |
| *** brinzhang has quit IRC | 04:35 | |
| *** brinzhang_ has quit IRC | 04:35 | |
| *** brinzhang_ has joined #openstack-nova | 04:36 | |
| *** zhanglong has joined #openstack-nova | 04:36 | |
| *** awalende has joined #openstack-nova | 04:36 | |
| *** brinzhang_ has quit IRC | 04:37 | |
| *** brinzhang_ has joined #openstack-nova | 04:38 | |
| *** awalende has quit IRC | 04:41 | |
| *** psachin has quit IRC | 04:48 | |
| *** zainub_wahid has joined #openstack-nova | 05:11 | |
| *** links has joined #openstack-nova | 05:44 | |
| *** yikun has quit IRC | 05:45 | |
| *** shilpasd has quit IRC | 05:59 | |
| *** pcaruana has joined #openstack-nova | 06:02 | |
| *** udesale has quit IRC | 06:25 | |
| *** zhanglong has quit IRC | 07:06 | |
| *** zhanglong has joined #openstack-nova | 07:08 | |
| *** logan- has quit IRC | 07:09 | |
| *** logan_ has joined #openstack-nova | 07:10 | |
| *** logan_ is now known as logan- | 07:10 | |
| *** lpetrut has joined #openstack-nova | 07:24 | |
| *** brinzhang_ has quit IRC | 07:26 | |
| *** damien_r has quit IRC | 07:28 | |
| *** mkrai_ has quit IRC | 07:37 | |
| *** rcernin has quit IRC | 07:41 | |
| *** tesseract has joined #openstack-nova | 07:43 | |
| *** mkrai has joined #openstack-nova | 07:53 | |
| *** zhanglong has quit IRC | 07:56 | |
| *** zhanglong has joined #openstack-nova | 07:58 | |
| *** andrewbogott has joined #openstack-nova | 08:00 | |
| *** zhanglong has quit IRC | 08:02 | |
| *** zhanglong has joined #openstack-nova | 08:04 | |
| *** zhanglong has quit IRC | 08:16 | |
| *** awalende has joined #openstack-nova | 08:19 | |
| *** slaweq has quit IRC | 08:21 | |
| *** tetsuro has quit IRC | 08:25 | |
| openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | 08:30 |
| openstackgerrit | Merged openstack/nova master: Follow up to I5b9d41ef34385689d8da9b3962a1eac759eddf6a https://review.opendev.org/698028 | 08:32 |
| *** jangutter has joined #openstack-nova | 08:33 | |
| *** iurygregory has joined #openstack-nova | 08:33 | |
| *** tosky has joined #openstack-nova | 08:40 | |
| *** damien_r has joined #openstack-nova | 08:41 | |
| *** slaweq has joined #openstack-nova | 08:42 | |
| *** FlorianFa has quit IRC | 08:49 | |
| *** ralonsoh has joined #openstack-nova | 08:49 | |
| *** spatel has joined #openstack-nova | 08:50 | |
| *** spatel has quit IRC | 08:54 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466 | 08:56 |
| *** FlorianFa has joined #openstack-nova | 09:01 | |
| *** maciejjozefczyk has joined #openstack-nova | 09:03 | |
| *** FlorianFa has quit IRC | 09:09 | |
| *** rcernin has joined #openstack-nova | 09:14 | |
| *** martinkennelly has joined #openstack-nova | 09:17 | |
| *** tkajinam has quit IRC | 09:19 | |
| *** FlorianFa has joined #openstack-nova | 09:22 | |
| *** mdbooth has joined #openstack-nova | 09:24 | |
| *** Liang__ has quit IRC | 09:28 | |
| *** derekh has joined #openstack-nova | 09:30 | |
| *** jmlowe has quit IRC | 09:35 | |
| *** jmlowe has joined #openstack-nova | 09:38 | |
| *** yoctozepto has joined #openstack-nova | 09:40 | |
| yoctozepto | morning | 09:42 |
| yoctozepto | I assigned https://bugs.launchpad.net/nova/+bug/1856296 to nova, mostly to let you know, not sure if you can do too much about it, other than letting users know they might be impacted on upgrades | 09:42 |
| openstack | Launchpad bug 1856296 in kolla-ansible "upgrade to Train might fail due to mariadb row format" [Critical,Triaged] | 09:42 |
| *** rcernin has quit IRC | 09:53 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421 | 09:54 |
| *** salmankhan has joined #openstack-nova | 10:06 | |
| *** salmankhan1 has joined #openstack-nova | 10:22 | |
| *** salmankhan has quit IRC | 10:25 | |
| *** salmankhan1 is now known as salmankhan | 10:25 | |
| *** chenhaw has quit IRC | 10:35 | |
| *** dpawlik has joined #openstack-nova | 10:51 | |
| *** dpawlik has quit IRC | 10:57 | |
| *** dpawlik has joined #openstack-nova | 10:58 | |
| *** ociuhandu has joined #openstack-nova | 11:14 | |
| *** mkrai has quit IRC | 11:14 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Drop tables for removed services, features https://review.opendev.org/698706 | 11:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: db: Remove placement tables https://review.opendev.org/698707 | 11:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove unused ec2 DB APIs https://review.opendev.org/698880 | 11:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove unused models https://review.opendev.org/698881 | 11:25 |
| *** ociuhandu has quit IRC | 11:26 | |
| *** ociuhandu has joined #openstack-nova | 11:27 | |
| *** mkrai has joined #openstack-nova | 11:30 | |
| *** ociuhandu has quit IRC | 11:31 | |
| *** tbachman has quit IRC | 11:45 | |
| *** jangutter has quit IRC | 11:47 | |
| *** jangutter_ has joined #openstack-nova | 11:47 | |
| *** zainub_wahid has quit IRC | 11:51 | |
| *** ociuhandu has joined #openstack-nova | 11:51 | |
| *** bhagyashris has quit IRC | 11:52 | |
| *** ociuhandu has quit IRC | 11:53 | |
| *** ociuhandu has joined #openstack-nova | 11:53 | |
| gibi | stephenfin: hi! what do you think about https://review.opendev.org/#/c/696574/10/nova/objects/instance.py@1239 ? shall I move this whole thing back to utils? | 11:58 |
| stephenfin | gibi: I guess if there's nowhere better, you've no choice :) | 11:59 |
| stephenfin | nova/compute/utils.py though, rather than nova/utils.py | 11:59 |
| *** dtantsur|afk is now known as dtantsur | 12:02 | |
| *** nicolasbock has joined #openstack-nova | 12:04 | |
| gibi | stephenfin: ack. moving | 12:07 |
| * gibi is sad to redo things but that is life | 12:07 | |
| *** kozhukalov has joined #openstack-nova | 12:22 | |
| *** mgoddard has quit IRC | 12:30 | |
| *** ociuhandu has quit IRC | 12:33 | |
| *** ociuhandu has joined #openstack-nova | 12:34 | |
| *** ociuhandu has quit IRC | 12:38 | |
| *** mgariepy has joined #openstack-nova | 12:40 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Revert "(Temporarily) readd bare support for py27" https://review.opendev.org/698890 | 12:42 |
| stephenfin | tosky: we're good to merge that now, right? ^ | 12:42 |
| sean-k-mooney | that drops support again since m1 was yesterday? | 12:43 |
| stephenfin | officially, yeah | 12:43 |
| stephenfin | it prevents you installing nova under python 2.7 | 12:43 |
| stephenfin | pip will spit the dummy out | 12:43 |
| sean-k-mooney | oh i know what the patch does | 12:43 |
| sean-k-mooney | i was just checking m1 was yesterday | 12:44 |
| sean-k-mooney | i was 99% sure it was | 12:44 |
| sean-k-mooney | also that is such an irish saying | 12:44 |
| *** ociuhandu has joined #openstack-nova | 12:46 | |
| *** kozhukalov has quit IRC | 12:48 | |
| *** ociuhandu has quit IRC | 12:48 | |
| *** kozhukalov has joined #openstack-nova | 12:48 | |
| *** spatel has joined #openstack-nova | 12:48 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Revert "(Temporarily) readd bare support for py27" https://review.opendev.org/698890 | 12:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove remaining Python 2.7-only dependencies https://review.opendev.org/698895 | 12:49 |
| *** ociuhandu has joined #openstack-nova | 12:49 | |
| sean-k-mooney | stephenfin: abandoned by typeing module fixes you flake 8 changes already cover that right | 12:49 |
| stephenfin | yup | 12:49 |
| sean-k-mooney | actully i really dont like the if False | 12:50 |
| sean-k-mooney | can you just convert the comments in the native form and import them normally | 12:50 |
| sean-k-mooney | or import them normally and add the #noqa | 12:50 |
| sean-k-mooney | to silence the unused import thing | 12:51 |
| stephenfin | Once we merge https://review.opendev.org/698890. yup | 12:51 |
| stephenfin | Feel free to -1 to remind me :) | 12:51 |
| sean-k-mooney | oh your right py27 | 12:51 |
| sean-k-mooney | ya we should merge that :) | 12:51 |
| stephenfin | and now, I'm nearly an hour late for lunch, but at least X-cell resize is reviewed finally. bbiab | 12:52 |
| *** ociuhandu has quit IRC | 12:52 | |
| *** ociuhandu has joined #openstack-nova | 12:52 | |
| *** ociuhandu has quit IRC | 12:52 | |
| *** lbragstad_ has quit IRC | 12:53 | |
| *** ociuhandu has joined #openstack-nova | 12:54 | |
| openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | 12:54 |
| *** spatel has quit IRC | 12:55 | |
| *** ociuhandu has quit IRC | 12:59 | |
| tosky | stephenfin: uhm, maybe | 13:06 |
| * tosky try to imagine possible unexpected side effects at this point | 13:06 | |
| *** tbachman has joined #openstack-nova | 13:06 | |
| *** tobiash has joined #openstack-nova | 13:18 | |
| *** nweinber has joined #openstack-nova | 13:18 | |
| *** Sundar has joined #openstack-nova | 13:19 | |
| *** gshippey has quit IRC | 13:20 | |
| *** mgoddard has joined #openstack-nova | 13:21 | |
| tobiash | hi, I'd like to revive discussion on this nova-spec which was proposed for rocky and abandoned: https://review.opendev.org/572805. What is the preferred way of doing this? Shall I create a new change or ask a nova-core to hit the restore button? | 13:21 |
| *** larainema has quit IRC | 13:21 | |
| gibi | tobiash: restored the spec. Please update it (e.g. move it to the ussuri dir at least) | 13:23 |
| tobiash | gibi: thank you very much! | 13:23 |
| sean-k-mooney | tobiash: you will need to add the new feature liason field at a minium to get it to pass the gate checks | 13:24 |
| sean-k-mooney | there is a description of that in the readme | 13:24 |
| tobiash | sean-k-mooney: thanks for the hint | 13:24 |
| sean-k-mooney | there may be some other template changes too but i think that is the main one since rocky | 13:24 |
| openstackgerrit | Eric Xie proposed openstack/nova master: Fix error when live-migrating instance cause of gic version https://review.opendev.org/698905 | 13:26 |
| *** jangutter_ is now known as jangutter | 13:30 | |
| openstackgerrit | Tobias Henkel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | 13:38 |
| *** awalende has quit IRC | 13:42 | |
| *** awalende has joined #openstack-nova | 13:42 | |
| *** maciejjozefczyk has quit IRC | 13:43 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:45 | |
| *** awalende has quit IRC | 13:46 | |
| *** awalende has joined #openstack-nova | 13:47 | |
| *** lbragstad has joined #openstack-nova | 13:48 | |
| *** awalende_ has joined #openstack-nova | 13:48 | |
| *** awalende_ has quit IRC | 13:51 | |
| *** nweinber has quit IRC | 13:51 | |
| *** awalende has quit IRC | 13:52 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't retry database connections from command line applications https://review.opendev.org/666892 | 13:54 |
| *** mriedem has joined #openstack-nova | 14:00 | |
| mriedem | efried: have you seen this? https://bugs.launchpad.net/nova/+bug/1856311 | 14:01 |
| openstack | Launchpad bug 1856311 in OpenStack Compute (nova) "server_external_events response status is always 'completed' instead of event status which requested as failed" [Undecided,New] | 14:01 |
| *** mlavalle has joined #openstack-nova | 14:02 | |
| efried | mriedem: nope, /me clicks | 14:03 |
| efried | what, now that I'm a server-external-events expert? | 14:04 |
| mriedem | yes you own it now | 14:04 |
| mriedem | but it looks like it's not what i thought they were complaining about | 14:04 |
| efried | I haven't looked at the novaclient shim at all yet | 14:04 |
| sean-k-mooney | is that valid? i would have assuemd that status faild for network-vif-plugged ment the pluggin failed | 14:05 |
| sean-k-mooney | and code 200 ment the event was sucessfully recieved? | 14:05 |
| sean-k-mooney | i dont actully know if that is how it works | 14:06 |
| sean-k-mooney | oh sorry read that wrong | 14:06 |
| mriedem | https://github.com/openstack/nova/blob/e6f742544432d6066f1fba4666580919eb7859bd/nova/api/openstack/compute/server_external_events.py#L133 | 14:09 |
| mriedem | it's working as designed | 14:09 |
| mriedem | completed == we got the event and we're sending it on for processing, thanks for calling | 14:09 |
| sean-k-mooney | ya i think so too was just readin the api ref | 14:09 |
| mriedem | dansmith: correct ^? | 14:09 |
| mriedem | laura did rub cbd oil all over my lower back this morning though so i might just be like super duper high | 14:09 |
| *** lpetrut has quit IRC | 14:11 | |
| sean-k-mooney | mellow maybe cbd does not have the more interesing sideeffects | 14:11 |
| mriedem | heh, i know, but it's a ruse i like to play on my wife like i have no idea and i'm 85 | 14:12 |
| *** mmethot has joined #openstack-nova | 14:13 | |
| *** awalende has joined #openstack-nova | 14:13 | |
| *** awalende has quit IRC | 14:17 | |
| efried | gibi, stephenfin: Will y'all have a chance to look at the vTPM spec today? | 14:18 |
| efried | https://review.opendev.org/#/c/686804/ | 14:18 |
| efried | I'm supposed to be vacationing starting next week... | 14:18 |
| *** ociuhandu has joined #openstack-nova | 14:19 | |
| gibi | efried: sorry. I will not have the chance today | 14:19 |
| gibi | efried: or at least I cannot promise | 14:20 |
| efried | okay. | 14:20 |
| stephenfin | Afraid I'm in the same boat. Stuck with internal stuff :( | 14:22 |
| efried | Okay. | 14:22 |
| *** ociuhandu has quit IRC | 14:24 | |
| sean-k-mooney | if i get this backport done soon ill try to look at it again that said i think its going to be pretty close jsut reading your comments | 14:24 |
| efried | thanks sean-k-mooney | 14:26 |
| *** ociuhandu has joined #openstack-nova | 14:27 | |
| dansmith | mriedem: completed in the return from the api means "got it dude" yes.. but status in the actual event body is the external service telling nova (i.e. compute) if something worked or not | 14:31 |
| mriedem | right | 14:32 |
| mriedem | hey nova, this event failed; ok, ack | 14:32 |
| *** links has quit IRC | 14:32 | |
| dansmith | yup | 14:32 |
| *** ociuhandu has quit IRC | 14:33 | |
| *** nweinber has joined #openstack-nova | 14:34 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 14:36 | |
| mriedem | stephenfin: thanks for hitting all of those cross-cell resize changes | 14:37 |
| *** lpetrut has joined #openstack-nova | 14:38 | |
| *** tbachman has quit IRC | 14:38 | |
| *** maciejjozefczyk has quit IRC | 14:39 | |
| *** igordc has joined #openstack-nova | 14:40 | |
| *** tbachman has joined #openstack-nova | 14:42 | |
| stephenfin | mriedem: np | 14:45 |
| stephenfin | It was pretty much just functional tests once I got past the remaining conductor tasks. Need to go find someone else now :) | 14:45 |
| *** dviroel has joined #openstack-nova | 14:47 | |
| *** derekh has quit IRC | 14:48 | |
| *** artom has joined #openstack-nova | 14:50 | |
| *** gshippey has joined #openstack-nova | 14:52 | |
| *** iurygregory has quit IRC | 14:52 | |
| *** tbachman has quit IRC | 14:55 | |
| *** kozhukalov has quit IRC | 14:56 | |
| *** links has joined #openstack-nova | 14:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | 15:02 |
| KeithMnemonic | dansmith: Thanks for pushing that patch through. Do you think you could please also do that last cherry pick in that set? https://review.opendev.org/#/c/690735/2 | 15:10 |
| dansmith | are we still doing stuff for pike? | 15:11 |
| dansmith | mriedem: | 15:11 |
| *** tbachman has joined #openstack-nova | 15:11 | |
| mriedem | it's in EM (as is queens) so we can if people have a need, | 15:13 |
| mriedem | i know suse cares about it and so does ericsson since they have products based on pike | 15:13 |
| mriedem | and as you know rhosp cares about queens (or at least the internal CI/CD stuff at RHOSP cares about queens) | 15:13 |
| dansmith | yeah, already did the queens one | 15:13 |
| dansmith | EM means "we can throw anything in there anyone cares about without inspecting it or worrying about breakage" right? | 15:14 |
| mriedem | heh, not really | 15:14 |
| mriedem | it just means it's there if people want a common place to backport, we can merge things, but we don't have to | 15:15 |
| dansmith | KeithMnemonic: can you please +1 those patches with "I stake my reputation on the fitness of this patch as I have tested it fully" ? | 15:15 |
| mriedem | https://docs.openstack.org/project-team-guide/stable-branches.html#extended-maintenance | 15:15 |
| dansmith | mriedem: right, I thought we said EM would be like a dumping ground, where we wouldn't try to keep tests working, etc | 15:15 |
| mriedem | "There is no statement about the level of testing and upgrades from Extended Maintenance are not supported within the Community." | 15:16 |
| mriedem | i wouldn't say we don't try, | 15:16 |
| mriedem | but we don't bend over backwards | 15:16 |
| mriedem | if tests are failing for some reason and there is a trivial way to fix, sure, but if things are chronically busted and no one is working on it or it's a lot of work then it's fine to EOL | 15:16 |
| *** links has quit IRC | 15:17 | |
| mriedem | iow, EM == best minimal effort, buyer beware | 15:17 |
| Sundar | efried: Re. https://review.opendev.org/#/c/631244/51/nova/conductor/manager.py@1578, when you say: "FWIW, I still don't like this.", what is 'this'? | 15:17 |
| mriedem | dansmith: i've also told KeithMnemonic that suse can just cherry-pick those for their internal pike series and not be blocked on us | 15:18 |
| dansmith | mriedem: yeah, it'd be nice if he'd at least +1 that he wants them and that they've confirmed they're good or something | 15:18 |
| KeithMnemonic | dansmith let me test in on a pike cloud i have and will update the bug. | 15:18 |
| KeithMnemonic | mriedem: we have that cherry pick ready locally if needed | 15:19 |
| dansmith | KeithMnemonic: you haven't actually tested these? | 15:19 |
| KeithMnemonic | but since the patch is still there and not pulled i figured it would be best to see if it can go in upstream | 15:19 |
| KeithMnemonic | i did | 15:19 |
| KeithMnemonic | on rocky | 15:19 |
| KeithMnemonic | let me go back and do pike as well | 15:20 |
| KeithMnemonic | it wont take me long | 15:20 |
| dansmith | yeah, that's not the same | 15:20 |
| mriedem | note that in at least one case i'm aware of, we had merged a backport to rocky and someone from canonical came back to me later saying it didn't actually fix the bug and they were right and we needed to follow up with a rocky only fix | 15:20 |
| KeithMnemonic | ok fair enough | 15:20 |
| mriedem | so, it happens | 15:20 |
| KeithMnemonic | so that is funny, sort of i just got merged a cheey pick for a missing "prev" button on the horzion instance panel, that is actually broken in master | 15:21 |
| efried | Sundar: I don't like "Hey, also send a required trait asserting that the compute is capable of accelerator stuff, because the fact that it's exposing inventory isn't sufficient" | 15:22 |
| dansmith | efried: it's not exposing inventory, cyborg is exposing the inventory, right? | 15:23 |
| KeithMnemonic | and mriedem they are telling me it is due to nova api behavior ;-) | 15:23 |
| efried | dansmith, Sundar: If a rogue external agent (whether it's cyborg, neutron, random $service, an admin) goes around adding shit to the provider tree, all bets are off as far as I'm concerned. | 15:23 |
| Sundar | efried: The trait can be used by Cyborg to not publish inventory. | 15:23 |
| efried | Yes, that ^ is cyborg not being rogue, and it is sufficient IMO. | 15:23 |
| efried | dansmith wants to not trust cyborg et al that far. | 15:24 |
| dansmith | efried: then we should do a service version check | 15:24 |
| *** iurygregory has joined #openstack-nova | 15:24 | |
| Sundar | efried: does that not apply to any trait? | 15:24 |
| efried | I'm not going to block on this. I appreciate the reasoning. I just don't like it. So you can ignore that part and focus on the "if you're going to do it, you need to do it this way" part of the comment. | 15:24 |
| dansmith | efried: we have gone a long way with not breaking our internal RPC APIs, please give that the credit due, and let's use the tools (any of them) that we have to keep those guarantees strong | 15:24 |
| Sundar | dansmith: We discussed 2 changes: A. Per-ARQ events B. Handling old compute nodes, one option being trait usage. I can do Part A now. Are you ok with that partial update? | 15:27 |
| Sundar | Part B perhaps requires more discussion, and Ill do that later | 15:28 |
| dansmith | Sundar: there are multiple parts of B that need to be done, the trait so that at least cyborg can tell, and then the second part is what we do on the nova side.. exposing the trait is not contentious, so you should do that | 15:28 |
| *** spatel has joined #openstack-nova | 15:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935 | 15:29 |
| dansmith | if you want to wait until january I will be glad to write the hard service version check | 15:29 |
| mriedem | this kind of hard service version check when the trait isn't available? https://review.opendev.org/#/c/695220/4/nova/compute/api.py@3938 | 15:31 |
| Sundar | dansmith: OK. Just to be clear, you don't see the point in reviewing A alone now? | 15:32 |
| stephenfin | smcginnis: Didn't you have a patch for the requirements tooling to allow me to do this? https://review.opendev.org/#/c/698895/1/doc/requirements.txt | 15:33 |
| stephenfin | I was sure you did but I can't find it | 15:33 |
| dansmith | Sundar: you can just do A and -W it if you want | 15:33 |
| dansmith | Sundar: today is my last day in the office so it won't likely get done until Jan anyway | 15:33 |
| openstackgerrit | Merged openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541 | 15:34 |
| dansmith | mriedem: yes, that's the sort of thing I'm trying to convince efried is important | 15:34 |
| dansmith | mriedem: the assertion is that cyborg should not add inventory for accels until the computes are upgraded, and that's enough to not break nova's internal and external APIs, and I'd rather us do our own internal check | 15:34 |
| dansmith | since we have the tools and it's trivial to do | 15:35 |
| smcginnis | stephenfin: Yes, that merged, but I think unfortunately you still need to keep the python_version marker. | 15:35 |
| dansmith | the cyborg logic could easily be wrong, removed, altered, etc | 15:35 |
| stephenfin | smcginnis: Ah, I thought it was fixed because [1] passed. Turned out that didn't run the requirements job /o\ [1] https://review.opendev.org/#/c/697004/ | 15:36 |
| smcginnis | Here's the requirements change: https://review.opendev.org/#/c/693631/ | 15:36 |
| efried | dansmith: in mriedem's example, he's going to remove the RPC version check once we can count on the compute exposing the trait. | 15:37 |
| stephenfin | smcginnis: Thanks. Would a change to make the 'python_version' things optional if 'python_version' > 3.x make sense? | 15:37 |
| stephenfin | Thinking out loud | 15:37 |
| efried | dansmith: But he only needs that because the thing he's checking was still possible in a previous version; it just wasn't advertised via the trait. | 15:38 |
| smcginnis | Yeah, I think so. That will give us a transition path away from py2 completely. | 15:38 |
| efried | dansmith: so in this case we actually only need the trait check there. | 15:38 |
| stephenfin | Kewl. I'll tackle that Monday | 15:38 |
| stephenfin | Cheers :) | 15:38 |
| smcginnis | stephenfin: +1 | 15:38 |
| dansmith | efried: as I said, I'm happy to check the trait | 15:39 |
| efried | My point is, if we do it that way, we don't need to muck with RPC at all. (For that reason -- we may still want to muck with it to pass the arqs across the wire.) | 15:39 |
| dansmith | efried: I think maybe there is some confusion going on | 15:40 |
| dansmith | efried: there are three things we could do here to provide an internal-to-nova check: | 15:40 |
| efried | The thing I was objecting to earlier was having to tack that same trait onto every GET /a_c. But meh, as long as you do it with root_required I'm content. | 15:40 |
| dansmith | 1. Check the trait, or just put that in the request to placement | 15:40 |
| dansmith | 2. Check the service version | 15:41 |
| dansmith | 3. Put it into the RPC request and depend on the RPC layer to not send if not allowed | 15:41 |
| *** spatel has quit IRC | 15:41 | |
| dansmith | I think #3 is the right answer, but I've already said that I won't block on it, but I think we should do either 1a, 1b, or 2 | 15:41 |
| dansmith | all of which are trivially easy because we have infrastructure to make it so | 15:41 |
| dansmith | if 1b (ask placement for the trait) is bad for some reason, then fine, although it seems like the least amount of overhead to me | 15:42 |
| efried | Yes, I agree with you. | 15:42 |
| efried | Are you also agreeing that 1b makes 1a/2/3 unnecessary? | 15:42 |
| efried | If we can agree on that, then I'll get fully behind 1b. | 15:43 |
| dansmith | I'm asking for one of those four options | 15:43 |
| efried | cool | 15:43 |
| dansmith | I thought you didn't want 1b? | 15:43 |
| efried | Sundar: I retract my objection to 1b. | 15:43 |
| efried | I didn't, but now I do. | 15:43 |
| dansmith | man I'm glad we're not local | 15:43 |
| efried | What, you gonna put clorox in my coffee? | 15:43 |
| dansmith | I'd smack you, you'd punch me, our lawyers would get boats | 15:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220 | 15:44 |
| efried | I don't punch. | 15:44 |
| efried | I thought you were asking for multiple redundant checks. | 15:44 |
| dansmith | karate chop | 15:44 |
| efried | now you're deliberately goading me | 15:44 |
| dansmith | mriedem can cue up a youtube of the final scene of karate kid | 15:44 |
| dansmith | efried: the only duplicity (which I don't consider duplicity) is us backing up the proper behavior of cyborg with a check, tht's all | 15:45 |
| mriedem | https://www.youtube.com/watch?v=oomCIXGzsR0 | 15:45 |
| *** kozhukalov has joined #openstack-nova | 15:46 | |
| dansmith | mriedem: right, thanks | 15:46 |
| Sundar | dansmith: efried: So, we are all agreed on 1b: Nova compute publishes a trait, Nova scheduler uses that in Placement query, we all party. Right? | 15:47 |
| dansmith | I'm not partying with either of you, but yes, I'm fine with that | 15:47 |
| *** lbragstad has quit IRC | 15:47 | |
| mriedem | it occurs to me that daniel's secret is the same as defeating bald bull in punch out | 15:48 |
| Sundar | dansmith: efried: Re. the idea that Cyborg should not publish inventory till n-c | 15:48 |
| Sundar | unrequited? ;) | 15:48 |
| *** lpetrut has quit IRC | 15:48 | |
| efried | Sundar: ...till n-c advertises the trait. And yes, 1b. | 15:50 |
| Sundar | efried: From an operator's POV, if the inventory gets published, she'd know at least that the devices are good and Cyborg is functioning, and they should look elsewhere to get the system functional. | 15:51 |
| efried | I can live with that. | 15:53 |
| Sundar | efried: dansmith: Ok I'll put in the trait definition. The changes for 1b presumably go in my current patch series. | 15:55 |
| efried | yes | 15:55 |
| dansmith | once the trait is there, it should be one line I'd think | 15:55 |
| efried | so you'll need the os-traits chain | 15:55 |
| efried | dansmith: I'm not actually sure where that line will go. But he also needs to bump the GET /a_c microversion. | 15:55 |
| efried | ...which is like 12 lines. | 15:55 |
| efried | (including test) | 15:56 |
| dansmith | efried: why does he need a bump? | 15:56 |
| *** kozhukalov has quit IRC | 15:56 | |
| efried | Because the trait needs to go into root_required. I'm not going to accept new code that hacks it into the unnumbered request group anymore. | 15:56 |
| dansmith | oh, okay.. we have traits requested now of course, but I guess the point is this is a complicated request | 15:57 |
| dansmith | well, service version check is pretty small and no external dependencies, but.. :) | 15:57 |
| *** eharney has joined #openstack-nova | 15:57 | |
| efried | the traits cyborg is requesting today are going into the device profile request groups, which isn't where this capability trait is. | 15:57 |
| efried | And the place those request groups are being built from is kinda far from where the root_required will need to be put in. | 15:58 |
| efried | which is why I said "not sure where that will go". | 15:58 |
| dansmith | aight | 15:58 |
| efried | but this is all very solvable, and moves the ball forward wrt using placement features for what we made them for. | 15:58 |
| dansmith | ack | 15:58 |
| efried | viz. string suffixes and rg/rp mappings | 15:59 |
| dansmith | efried: could we do the microversion bump early in the series and get that merged so we don't add a piece to Sundar's puzzle? | 15:59 |
| efried | for sure | 15:59 |
| efried | I can probably work on that. | 15:59 |
| efried | Sundar: ^ | 15:59 |
| dansmith | that would be good, and would be moving the ball a little instead of increasing the weight of the ball | 15:59 |
| efried | I'll try to hack it up this afternoon. | 15:59 |
| Sundar | efried: dansmith: Thanks | 16:00 |
| efried | sean-k-mooney: Are you about today? If not, I can fix up that func test on the image props sync patch and get that moving forward. | 16:00 |
| sean-k-mooney | im around for about an hour but i wont get to it before i head to a team dinner | 16:01 |
| efried | okay. It'll be trivial 1c changes to half a dozen test cases, so I'll still feel good about +2ing. | 16:01 |
| sean-k-mooney | oh i forgot to update the notification samples | 16:03 |
| sean-k-mooney | the notifiction really are a pain | 16:04 |
| *** bnemec is now known as beekneemech | 16:06 | |
| efried | yeah, I'm sure they're not worth the trouble. | 16:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Sync ImageMetaPropsPayload fields https://review.opendev.org/698613 | 16:08 |
| efried | sean-k-mooney: ^ | 16:08 |
| sean-k-mooney | :) i was just trying to run them locally to reporduce but ill go back to backporting. thanks | 16:08 |
| *** ociuhandu has joined #openstack-nova | 16:09 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | 16:11 |
| efried | sean-k-mooney: and ^ | 16:11 |
| dansmith | mriedem: are you about to push a change to this? https://review.opendev.org/#/c/638046/56/nova/conductor/tasks/cross_cell_migrate.py | 16:11 |
| efried | gibi, dansmith: That should be an easy win if you could take a quick look | 16:11 |
| efried | https://review.opendev.org/698803 | 16:11 |
| mriedem | dansmith: no those are fup'ed already https://review.opendev.org/#/c/698935/ | 16:11 |
| dansmith | ah okay | 16:11 |
| *** efried is now known as efried_afk | 16:12 | |
| mriedem | stephenfin: this is probably in your wheelhouse https://bugs.launchpad.net/oslo.config/+bug/1856312 | 16:14 |
| openstack | Launchpad bug 1856312 in oslo.config "RuntimeError during calling log_opts_values" [Undecided,New] | 16:14 |
| *** igordc has quit IRC | 16:15 | |
| *** dpawlik has quit IRC | 16:20 | |
| *** nweinber has quit IRC | 16:24 | |
| stephenfin | mriedem: 1856312 | 16:24 |
| stephenfin | whoops. https://review.opendev.org/698954 | 16:24 |
| stephenfin | oh yeah | 16:25 |
| *** stephenfin is now known as finucannot | 16:25 | |
| dansmith | mriedem: check my comment here: https://review.opendev.org/#/c/638046/56 | 16:26 |
| *** gyee has joined #openstack-nova | 16:26 | |
| *** damien_r has quit IRC | 16:32 | |
| *** tbachman has quit IRC | 16:32 | |
| mriedem | dansmith: replied | 16:33 |
| *** ociuhandu has quit IRC | 16:36 | |
| dansmith | mriedem: ack | 16:36 |
| *** ociuhandu has joined #openstack-nova | 16:36 | |
| *** mkrai has quit IRC | 16:40 | |
| *** ociuhandu has quit IRC | 16:40 | |
| *** kozhukalov has joined #openstack-nova | 16:41 | |
| openstackgerrit | Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961 | 16:49 |
| finucannot | dansmith: I'm heading off, but can you make sure you're happy with https://review.opendev.org/698890 before you leave for the year? | 16:49 |
| finucannot | gmann should probably look at it too, but I think the main concern about us breaking the DevStack default has been resolved now | 16:50 |
| dansmith | finucannot: I skimmed it earlier, it's just reverting the stuff now that the devstack default is py3 yeah/ | 16:50 |
| finucannot | 'zactly | 16:50 |
| dansmith | ack fine with me | 16:51 |
| finucannot | ta | 16:51 |
| dansmith | but yeah, gmann | 16:51 |
| *** nweinber has joined #openstack-nova | 16:51 | |
| mriedem | we might want to consider taking the boot_index part of this spec and doing it on its own https://specs.openstack.org/openstack/nova-specs/specs/train/approved/detach-boot-volume.html#proposed-change since there is some confusion going on in -sdks about knowing when a server is volume-backed or not | 16:51 |
| finucannot | agreed | 16:51 |
| mriedem | and twould be helpful if we exposed the boot_index of the attached volumes | 16:51 |
| finucannot | dansmith: have a good one đ | 16:51 |
| dansmith | o/ | 16:51 |
| * finucannot -> đ» | 16:51 | |
| *** finucannot is now known as stephenfin | 16:51 | |
| gmann | dansmith: stephenfin +1 | 16:52 |
| gmann | its m-1 also so is anyone is break its time foe them to merge the py2 drop patch. | 16:53 |
| *** mlavalle has quit IRC | 16:53 | |
| *** tesseract has quit IRC | 16:53 | |
| mriedem | dansmith: is there a standard way to check the type on a field? | 16:53 |
| dansmith | mriedem: isinstance | 16:53 |
| mriedem | heh yeah i was doing if isinstance(field, fields.ObjectField) but that didn't work | 16:53 |
| mriedem | so i did value = getattr(target_obj, field) and if isinstance(value, fields.ObjectField): but that doens't work either | 16:54 |
| dansmith | should work | 16:54 |
| dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L773 | 16:54 |
| mriedem | ok i'll tinker, got a call with HR in 5 minutes | 16:54 |
| dansmith | oh I see what you're doing | 16:54 |
| *** mlavalle has joined #openstack-nova | 16:54 | |
| dansmith | the actual data isn't in the field, the field is in obj_fields | 16:55 |
| mriedem | yeah http://paste.openstack.org/show/787566/ | 16:55 |
| mriedem | oh nvm | 16:55 |
| mriedem | i see | 16:55 |
| mriedem | obj_fields yields the field name | 16:56 |
| dansmith | obj_fields is a dict, | 16:56 |
| dansmith | so you need to either get the field by name or iterate over the values() | 16:56 |
| mriedem | @property | 16:57 |
| mriedem | def obj_fields(self): | 16:57 |
| mriedem | return list(self.fields.keys()) + self.obj_extra_fields | 16:57 |
| mriedem | fields is the dict | 16:57 |
| mriedem | so yeah i've got you | 16:57 |
| *** ociuhandu has joined #openstack-nova | 16:59 | |
| *** mkrai has joined #openstack-nova | 17:06 | |
| *** ociuhandu has quit IRC | 17:17 | |
| *** jangutter has quit IRC | 17:25 | |
| mriedem | huh, i was trying to use the test_objects.MyObj for my test and that was failing the 'field in target_obj' checks but changed to Instance with a nested Flavor and it's working now, so go figure | 17:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935 | 17:26 |
| *** dklyle has quit IRC | 17:26 | |
| *** david-lyle has joined #openstack-nova | 17:26 | |
| *** openstackgerrit has quit IRC | 17:29 | |
| *** dviroel has quit IRC | 17:30 | |
| *** mvkr has quit IRC | 17:34 | |
| *** sapd1 has quit IRC | 17:34 | |
| *** kozhukalov has quit IRC | 17:35 | |
| *** openstackgerrit has joined #openstack-nova | 17:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: avoid mushy wording around server.image description https://review.opendev.org/698976 | 17:37 |
| openstackgerrit | Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961 | 17:37 |
| *** lbragstad has joined #openstack-nova | 17:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: avoid mushy wording around server.image description https://review.opendev.org/698976 | 17:39 |
| *** dtantsur is now known as dtantsur|afk | 17:40 | |
| *** mriedem is now known as mriedem_away | 17:42 | |
| *** cmurphy is now known as cmorpheus | 17:43 | |
| *** Sundar is now known as DarthNau | 17:49 | |
| *** damien_r has joined #openstack-nova | 17:52 | |
| *** damien_r has quit IRC | 17:53 | |
| *** damien_r has joined #openstack-nova | 17:53 | |
| *** iurygregory has quit IRC | 17:55 | |
| *** melwitt is now known as jgwentworth | 17:57 | |
| *** DarthNau has quit IRC | 18:01 | |
| *** damien_r has quit IRC | 18:10 | |
| *** martinkennelly has quit IRC | 18:10 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574 | 18:13 |
| *** links has joined #openstack-nova | 18:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905 | 18:14 |
| *** tbachman has joined #openstack-nova | 18:18 | |
| *** lyarwood has quit IRC | 18:19 | |
| *** dviroel has joined #openstack-nova | 18:22 | |
| gibi | efried_afk: I'm +2 on the vtpm spec (thanks to my nephew who let me read the diff while watching back to the future 3) | 18:22 |
| *** eharney has quit IRC | 18:23 | |
| *** ralonsoh has quit IRC | 18:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: [ussuri][goal] Drop python 2.7 support https://review.opendev.org/698988 | 18:38 |
| *** lbragsta_ has joined #openstack-nova | 18:41 | |
| *** lbragstad has quit IRC | 18:41 | |
| *** links has quit IRC | 18:42 | |
| *** tosky has quit IRC | 18:57 | |
| *** awalende has joined #openstack-nova | 19:01 | |
| *** igordc has joined #openstack-nova | 19:05 | |
| *** awalende has quit IRC | 19:06 | |
| openstackgerrit | Merged openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075 | 19:14 |
| KeithMnemonic | dansmith I updated that change with my +1 after verifying the fix in Pike and added you as a reviewer. Thanks for your help! | 19:18 |
| *** eharney has joined #openstack-nova | 19:27 | |
| dansmith | ack | 19:29 |
| *** mriedem_away has quit IRC | 19:29 | |
| *** mriedem has joined #openstack-nova | 19:31 | |
| *** lbragsta_ is now known as lbragstad | 19:31 | |
| efried_afk | gibi: thanks! | 19:32 |
| *** efried_afk is now known as efried | 19:32 | |
| *** lbragsta_ has joined #openstack-nova | 19:40 | |
| *** maciejjozefczyk_ has quit IRC | 19:41 | |
| *** lbragstad has quit IRC | 19:43 | |
| *** nicolasbock has quit IRC | 19:43 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | 19:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: define boot from volume in the glossary https://review.opendev.org/699009 | 19:54 |
| efried | gmann: are you keeping up with your own drop-py27-support patches or are repo owners expected to pick them up? | 19:55 |
| efried | Specifically https://review.opendev.org/#/c/698988/ -- I don't mind editing it, just lmk | 19:56 |
| gmann | efried: owner first if they do not do then i push | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: [ussuri][goal] Drop python 2.7 support https://review.opendev.org/698988 | 19:57 |
| efried | gmann: okay, I updated ^ | 19:57 |
| efried | and +2ed | 19:57 |
| efried | oh | 19:58 |
| gmann | efried: that might fail. requirement check job is adjusted for py2 requirement matches only | 19:58 |
| efried | That was, apparently, wrong. | 19:58 |
| efried | I don't know that the nova-specs repo has requirements check tho | 19:58 |
| efried | I wouldn't expect it to. | 19:58 |
| efried | And dropping py2 "support" from nova-specs is a bit pro forma anyway :P | 19:58 |
| gmann | ah yeah. as long as it pass it is fine | 19:59 |
| *** mkrai has quit IRC | 19:59 | |
| gmann | at the end all py3 specifier will be cleanup too | 19:59 |
| efried | yeah, looking at the previous run, it's only pep8 and docs. | 19:59 |
| efried | so it ought to work. | 20:00 |
| *** salmankhan has quit IRC | 20:00 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add --dry-run option to heal_allocations CLI https://review.opendev.org/698525 | 20:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add --instance option to heal_allocations https://review.opendev.org/698529 | 20:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/698531 | 20:06 |
| *** kozhukalov has joined #openstack-nova | 20:10 | |
| *** gmann is now known as gmann_afk | 20:13 | |
| mriedem | efried: i replied for gibi on https://review.opendev.org/#/c/696574/ - see if that answers your question | 20:17 |
| efried | thanks mriedem, +A | 20:19 |
| efried | mriedem: wanna hit this trivial +A? https://review.opendev.org/698988 | 20:19 |
| *** tbachman has quit IRC | 20:19 | |
| *** salmankhan has joined #openstack-nova | 20:20 | |
| efried | dansmith: bikeshedding opportunity: | 20:23 |
| mriedem | done | 20:23 |
| efried | RequestSpec needs a field (possibly two) to store root_required (which can take required or forbidden (with !) just like regular required). This is parallel with requested_resources. | 20:24 |
| efried | It's what we always wanted to use from those request_filters rather than hacking into the flavor and doing obj_reset_changes(), which I'll fix up at the same time. | 20:25 |
| mriedem | that can't be hacked into the RequestGroup? | 20:25 |
| efried | No, specifically because it's not per request group. | 20:25 |
| dansmith | right, was just going to say.. why isn't it inside requested_resources? | 20:25 |
| efried | That's it's whole raison d'ĂȘtre | 20:26 |
| efried | requested_resources is a list of RequestGroup. | 20:26 |
| mriedem | the issue i always had with the RequestGroup for that traits-only stuff is the RequestGroup stuff in the scheduler made resources required | 20:26 |
| dansmith | oh because requested_resources is a list of requestgroup objects | 20:26 |
| dansmith | that field probably should have been an ObjectField('PlacementyShit') | 20:27 |
| efried | well a) pretty sure that's not a thing anymore, I think we did away with that on the placement side; but b) that's exactly what root_required is for: so you can specify required/forbidden traits that you *for sure* want to look for on the root RP, without association with any request groups | 20:27 |
| mriedem | can you have a root unnumbered group or something for modeling this? | 20:27 |
| mriedem | DictOfStringsField(put all the crap) | 20:27 |
| mriedem | so building on RequestGroup as an object would probably just be confusing for tihs right? | 20:27 |
| efried | would make no sense | 20:28 |
| efried | a request has N RequestGroup. It only has one root_required | 20:28 |
| efried | RequestGroup contains resources, traits, aggregates. root_required only traits. | 20:28 |
| dansmith | efried: what is your actual quesiton? | 20:28 |
| efried | what should we name those fields | 20:28 |
| dansmith | field or fields | 20:28 |
| dansmith | ? | 20:28 |
| efried | One for required, one for forbidden. SetOfStringsField. | 20:28 |
| efried | root_required, root_forbidden? | 20:29 |
| efried | root_required_traits, root_forbidden_traits? | 20:29 |
| mriedem | feels like a field explosion | 20:29 |
| efried | requested_root_traits_required, requested_root_traits_forbidden? | 20:29 |
| dansmith | how about we add PlacementyShit and put them on that object, so that when we have the next thing, we don't keep adding placementy fields to reqspec? | 20:29 |
| mriedem | throw it into a RootProviderConstraints objects? | 20:29 |
| dansmith | mriedem: PlacementyShit | 20:29 |
| * mriedem dials the tc | 20:30 | |
| dansmith | pretty sure the tc had to cancel their phone plan to pay the electric bill | 20:30 |
| efried | yeah, we could make ResourceRequest an OVO and make RequestSpec.resource_request. That's probably something we want to consolidate eventually anyway. | 20:30 |
| mriedem | ha | 20:31 |
| mriedem | RequestSpec.resource_request and RequestSpec.requested_resources | 20:31 |
| efried | that would mean we should drop requested_resources though. Deleting a field from an OVO sounds scary. | 20:31 |
| mriedem | very confusing | 20:31 |
| mriedem | it's a major version bump | 20:31 |
| *** kozhukalov has quit IRC | 20:31 | |
| mriedem | the likes of which only dan-o can navigate | 20:31 |
| efried | Course, everything OVO is scary to me. | 20:31 |
| efried | so what's the lesser evil here? | 20:31 |
| *** tbachman has joined #openstack-nova | 20:32 | |
| efried | placement_shit = DictOfStringsField? | 20:32 |
| dansmith | yep, don't do that right now, I'd just add a peer object next to requested_resources, leave the latter the same, put your flags and stuff in the new object | 20:32 |
| dansmith | no | 20:32 |
| dansmith | god no. | 20:32 |
| efried | new PlacementShit OVO and placement_shit = PlacementShitField()? | 20:32 |
| dansmith | no | 20:33 |
| dansmith | reqspec.PlacementShit = ObjectField('PlacementShit'), | 20:33 |
| dansmith | then in the PlacementShit object, whatever fields you need | 20:33 |
| dansmith | root_required is what, a boolean? | 20:33 |
| efried | set of traits | 20:33 |
| dansmith | or a list of traits | 20:33 |
| efried | prefer a set if poss, to squash dups | 20:34 |
| dansmith | so root_required = ListOfStringsField() | 20:34 |
| efried | We have a SetOfStringsField, any reason to avoid it? | 20:34 |
| mriedem | we do have a set of strings field, RequestGroup uses it | 20:34 |
| dansmith | not sure we have one of those, but seriously we don't have to use sets everywhere, just run it through a set somewhere | 20:34 |
| mriedem | sets or bust! | 20:34 |
| dansmith | no, if we have one that's fine | 20:34 |
| efried | cool | 20:34 |
| * efried is off to the races | 20:34 | |
| dansmith | it's silly, IMHO, but... :) | 20:34 |
| efried | thanks. | 20:34 |
| mriedem | BagODicts | 20:34 |
| *** gyee has quit IRC | 20:35 | |
| *** kozhukalov has joined #openstack-nova | 20:37 | |
| *** salmankhan has quit IRC | 20:40 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for qos live migration reschedule https://review.opendev.org/699015 | 20:41 |
| *** lbragstad has joined #openstack-nova | 20:42 | |
| efried | dansmith: and what's the accepted way to use default on a field? | 20:43 |
| efried | e.g. default=set(), does that help me not have to check if present => check if None => check if empty? | 20:44 |
| *** lbragsta_ has quit IRC | 20:44 | |
| openstackgerrit | Merged openstack/nova-specs master: [ussuri][goal] Drop python 2.7 support https://review.opendev.org/698988 | 20:46 |
| openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1849409 https://review.opendev.org/690734 | 20:48 |
| openstack | bug 1849409 in OpenStack Compute (nova) pike "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | 20:48 |
| dansmith | efried: default=set() isn't going to work anyway | 20:50 |
| *** nweinber has quit IRC | 20:50 | |
| efried | it's what RequestGroup is doing | 20:50 |
| efried | so, in what way not work? | 20:51 |
| *** tbachman has quit IRC | 20:51 | |
| dansmith | efried: IIRC, that will result in every object getting the same set(), potentially cross-polluting between requests | 20:51 |
| dansmith | because the field is once per definition, and done at import time | 20:51 |
| efried | oh, neat. | 20:51 |
| dansmith | I don't see request group doing that | 20:52 |
| dansmith | er, maybe I'm looking in the wrong place | 20:52 |
| dansmith | ah yeah I see | 20:53 |
| dansmith | oh, hmm, maybe we copy the field's definition in obj_set_defaults, hang on | 20:54 |
| dansmith | ISTR that coming up and we hacked around it that way | 20:54 |
| dansmith | yeah https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L588 | 20:54 |
| dansmith | alright, so ignore me I guess | 20:54 |
| dansmith | a little dangerous but probably not in practice | 20:55 |
| efried | then back to the original question, how should I manage this field? | 20:55 |
| dansmith | but no, it doesn't help you not have to check for setted-ness | 20:55 |
| dansmith | efried: you should always set it, or call obj_set_defaults() after you create it | 20:56 |
| efried | but not via __init__ | 20:56 |
| dansmith | I think you know the answer to that :) | 20:56 |
| efried | would this be a thing for __new__ somehow? | 20:56 |
| dansmith | it's less of a problem for a transient rpc-only object, but we really shouldn't create more examples for people to copy, not knowing the problems | 20:56 |
| dansmith | efried: no | 20:56 |
| mriedem | RequestGroup just sets defaults if it lazy-loads a field and i think all fields have defaults | 20:57 |
| mriedem | is how it works around have to check set-ness | 20:57 |
| mriedem | *having to | 20:57 |
| dansmith | sure, you can do that if you want | 20:57 |
| efried | So RequestSpec.from_components does obj_set_defaults(), meaning that if I define the field with a default, any code path that starts with from_components I can count on that field being set. | 20:59 |
| dansmith | is that a question? | 20:59 |
| efried | an assertion for you to refute if it's wrong | 20:59 |
| dansmith | if what you say is true, then yes | 21:00 |
| dansmith | however, I thought from_components is supposed to go away in the Z release when bauzas finally cleans it up | 21:00 |
| dansmith | so, not sure that's the best assumption to make, although the way things are going, it'll never happen :) | 21:00 |
| dansmith | I'll also note that in the G days, Z sounded like "forever", but that's becoming less true | 21:01 |
| efried | is obj_set_defaults recursive into an ObjectField? | 21:06 |
| mriedem | zzzeek: if/when you're around, it'd be nice if you could sniff out this simple join/filter query being proposed https://review.opendev.org/#/c/694462/2/nova/db/sqlalchemy/api.py@2005 just from an efficiency standpoint | 21:06 |
| mriedem | low priority though | 21:06 |
| efried | i.e. will RequestSpec.obj_set_defaults percolate into my new RequestSpec.placement_shit ObjectField and set the defaults inside that guy? | 21:06 |
| dansmith | no | 21:07 |
| mriedem | do not rely on from_components | 21:07 |
| dansmith | I gotta run out for a bit, and likely I won't be back | 21:07 |
| mriedem | i've been trying to burn all of that crap out the last several releases while sylvain is skiing | 21:07 |
| dansmith | mriedem: lol | 21:07 |
| dansmith | mriedem: as "a french" I believe it's his actual right to ski while others work :) | 21:08 |
| mriedem | https://review.opendev.org/#/q/project:openstack/nova+branch:master+topic:bp/request-spec-use-by-compute | 21:08 |
| *** mdbooth has quit IRC | 21:08 | |
| mriedem | oh btw, as my parting shot on all of that https://review.opendev.org/#/c/697697/, | 21:08 |
| mriedem | likely a lot of that crap can't be removed until we bump the major on the conductor rpc | 21:08 |
| mriedem | and by we i mean dadn | 21:09 |
| mriedem | *dan | 21:09 |
| efried | freudian | 21:09 |
| mriedem | i left details in https://review.opendev.org/#/c/697697/ | 21:09 |
| dansmith | lervely | 21:09 |
| dansmith | so, efried sounds like I'll review that in Jan | 21:09 |
| *** mdbooth has joined #openstack-nova | 21:09 | |
| efried | ack, enjoy your time off | 21:09 |
| dansmith | o/ | 21:10 |
| mriedem | talk to you monday | 21:10 |
| mriedem | o-) | 21:10 |
| zzzeek | mriedem: ugh jaypipes is gone? | 21:10 |
| mriedem | he's been gone | 21:11 |
| zzzeek | mriedem: so..."manual joins" means, list of things we load in a separate query and merge in Python ? | 21:12 |
| mriedem | yeah | 21:14 |
| *** gyee has joined #openstack-nova | 21:17 | |
| mriedem | i've never really been sure why we distinguish honestly | 21:17 |
| zzzeek | mriedem: if BlockDeviceMapping.instance_uuid is a foreign key to Instance, that would mean you don't actually have to include the Instance table in this query, right? | 21:17 |
| zzzeek | mriedem: unless the "model query" aspect of this makes that more complicated | 21:18 |
| mriedem | bdm.instance_uuid is a fkey to instances.uuid, i can confirm that - as for your question, idk | 21:18 |
| mriedem | but... | 21:19 |
| mriedem | yeah we shouldn't need the join | 21:19 |
| zzzeek | mriedem: OK ill put it in the comment, if model+_query needs to look at other cols on Instance that might be the issue | 21:19 |
| mriedem | select bdm.instance_uuid from bdms where instance_uuid in (instance_uuids) and boot_index=0 and destination_type=volume; | 21:19 |
| mriedem | yeah? | 21:19 |
| mriedem | the join seemed overly complicated to me for this | 21:19 |
| mriedem | but needed other eyes | 21:20 |
| zzzeek | mriedem: yes, but that's as long as model_Qeury is notlike "and instance.user_token_whatever == admin" or something | 21:20 |
| mriedem | i think in this case the query isn't scoped to a project | 21:21 |
| mriedem | so we should be ok | 21:21 |
| mriedem | project_only=False by default and read_deleted='yes' means we don't modify the query to filter on deleted | 21:21 |
| mriedem | so hell we likely don't even need model_query with this | 21:21 |
| mriedem | just normal sqla orm | 21:22 |
| zzzeek | woop | 21:22 |
| mriedem | thanks mike | 21:24 |
| mriedem | re nova-network removal series, bottom 2 are pretty easy and +2ed https://review.opendev.org/#/c/697151/ | 21:30 |
| mriedem | just removing dead code | 21:30 |
| *** igordc has quit IRC | 21:30 | |
| *** nweinber has joined #openstack-nova | 21:37 | |
| gibi | mriedem: kicked the deads | 21:38 |
| *** lbragstad has quit IRC | 21:40 | |
| *** lbragstad has joined #openstack-nova | 21:41 | |
| mriedem | pulling an all-nighter! | 21:43 |
| *** nweinber has quit IRC | 21:44 | |
| *** bbowen has quit IRC | 21:45 | |
| openstackgerrit | Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961 | 21:47 |
| gibi | mriedem: baby sitting | 21:48 |
| gibi | mriedem: but not for long | 21:48 |
| mriedem | back to the future 3 huh | 21:50 |
| gibi | it worked like a charm | 21:52 |
| mriedem | how old? | 21:54 |
| *** kozhukalov has quit IRC | 21:54 | |
| gibi | 7. I think he liked the first two too | 21:55 |
| gibi | he asked for the third so I complied | 21:56 |
| mriedem | heh | 21:56 |
| mriedem | is it time for star wars? you could keep him busy for an entire weekend | 21:56 |
| gibi | he has already consumed half (the better half) of star wars | 21:57 |
| gibi | and I'm not a star wars fan. I grew up on star trek instead | 21:57 |
| mriedem | then i will hold my tongue | 21:57 |
| gibi | but I accept that the general public does not agree with me :) | 21:59 |
| gibi | I think I stopped star wars when jar jar binks appeared | 22:01 |
| *** logan- has quit IRC | 22:04 | |
| *** logan- has joined #openstack-nova | 22:06 | |
| gibi | now the parents are back so I'm dropping. Have a nice evening | 22:07 |
| *** damien_r has joined #openstack-nova | 22:08 | |
| *** slaweq has quit IRC | 22:14 | |
| *** KeithMnemonic1 has joined #openstack-nova | 22:15 | |
| *** KeithMnemonic has quit IRC | 22:19 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix listing deleted servers with a marker https://review.opendev.org/690735 | 22:21 |
| openstackgerrit | Merged openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574 | 22:21 |
| openstackgerrit | Merged openstack/nova master: nova-net: Remove unused 'stub_out_db_network_api' https://review.opendev.org/697151 | 22:21 |
| *** damien_r has quit IRC | 22:26 | |
| *** ozzzo has quit IRC | 22:33 | |
| *** ozzzo has joined #openstack-nova | 22:33 | |
| *** mvkr has joined #openstack-nova | 22:38 | |
| *** lbragsta_ has joined #openstack-nova | 22:41 | |
| *** lbragstad has quit IRC | 22:43 | |
| *** pcaruana has quit IRC | 22:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add recreate test for bug 1855927 https://review.opendev.org/699045 | 22:52 |
| openstack | bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,New] https://launchpad.net/bugs/1855927 | 22:52 |
| *** lbragsta_ has quit IRC | 22:54 | |
| *** mriedem has quit IRC | 22:54 | |
| *** ganso has joined #openstack-nova | 23:17 | |
| *** KeithMnemonic1 has quit IRC | 23:19 | |
| *** dviroel has quit IRC | 23:21 | |
| *** tbachman has joined #openstack-nova | 23:34 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use Placement 1.35 (root_required) https://review.opendev.org/699050 | 23:36 |
| efried | dansmith: ^ | 23:37 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use reasonable name for provider mapping https://review.opendev.org/698735 | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!