Tuesday, 2019-12-03

*** jistr has quit IRC00:07
*** jistr has joined #openstack-nova00:08
*** ivve has quit IRC00:16
*** dpawlik has joined #openstack-nova00:23
*** dpawlik has quit IRC00:28
openstackgerritEric Fried proposed openstack/nova master: Tie requester_id to RequestGroup suffix  https://review.opendev.org/69694600:34
openstackgerritEric Fried proposed openstack/nova master: refactor: RequestGroup knows when it's empty  https://review.opendev.org/69699100:34
openstackgerritEric Fried proposed openstack/nova master: WIP: Use provider mappings from Placement (mostly)  https://review.opendev.org/69699200:34
*** sorrison has joined #openstack-nova01:02
*** tetsuro has joined #openstack-nova01:15
*** ociuhandu has joined #openstack-nova01:31
*** ociuhandu has quit IRC01:35
*** sorrison has quit IRC01:38
*** sorrison has joined #openstack-nova01:38
*** sorrison has quit IRC01:40
*** gyee has quit IRC01:48
*** sorrison has joined #openstack-nova01:55
*** sorrison has quit IRC01:58
*** awalende has joined #openstack-nova02:00
*** yikun has joined #openstack-nova02:01
*** sorrison has joined #openstack-nova02:02
*** awalende has quit IRC02:04
*** sorrison has quit IRC02:15
*** sorrison has joined #openstack-nova02:16
*** davee_ has quit IRC02:16
*** davee_ has joined #openstack-nova02:17
openstackgerritBoxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule  https://review.opendev.org/64996302:17
*** dpawlik has joined #openstack-nova02:24
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously  https://review.opendev.org/65196902:25
*** dpawlik has quit IRC02:28
*** yaawang has quit IRC02:36
*** yaawang has joined #openstack-nova02:36
*** macz has quit IRC02:37
*** chenhaw has joined #openstack-nova02:45
openstackgerritMerged openstack/nova master: Add new default rules and mapping in policy base class  https://review.opendev.org/64545202:53
*** mkrai has joined #openstack-nova03:27
*** Liang__ has joined #openstack-nova03:38
*** jbernard has quit IRC03:45
*** macz has joined #openstack-nova03:46
*** jbernard has joined #openstack-nova03:46
*** macz has quit IRC03:51
*** tetsuro has quit IRC03:58
*** jangutter has joined #openstack-nova03:59
*** yaawang has quit IRC04:01
*** yaawang has joined #openstack-nova04:02
*** jangutter has quit IRC04:03
*** tetsuro has joined #openstack-nova04:04
*** sorrison has quit IRC04:04
*** tetsuro has quit IRC04:05
*** bhagyashris has joined #openstack-nova04:09
*** sorrison has joined #openstack-nova04:10
*** udesale has joined #openstack-nova04:13
*** sorrison has quit IRC04:15
*** tetsuro has joined #openstack-nova04:16
*** tetsuro has quit IRC04:19
*** tetsuro_ has joined #openstack-nova04:19
*** tetsuro_ has quit IRC04:23
*** tetsuro has joined #openstack-nova04:23
*** dpawlik has joined #openstack-nova04:25
*** dpawlik has quit IRC04:29
*** igordc has quit IRC04:34
*** tetsuro has quit IRC04:36
*** sorrison has joined #openstack-nova04:45
*** jangutter has joined #openstack-nova04:46
*** jangutter has quit IRC04:51
*** sorrison has quit IRC04:52
*** sorrison has joined #openstack-nova04:57
*** tkajinam has quit IRC05:02
*** udesale has quit IRC05:15
*** udesale has joined #openstack-nova05:16
*** tkajinam has joined #openstack-nova05:33
*** mkrai has quit IRC05:36
*** boxiang has joined #openstack-nova05:36
*** boxiang has quit IRC05:38
*** boxiang has joined #openstack-nova05:38
*** tetsuro has joined #openstack-nova05:39
*** udesale has quit IRC05:42
*** boxiang_ has joined #openstack-nova05:43
*** tetsuro has quit IRC05:44
*** boxiang has quit IRC05:46
*** udesale has joined #openstack-nova05:51
*** links has joined #openstack-nova05:52
*** mkrai has joined #openstack-nova05:54
*** bhagyashris has quit IRC05:57
*** tetsuro has joined #openstack-nova05:57
*** bhagyashris has joined #openstack-nova05:58
*** ircuser-1 has joined #openstack-nova06:19
*** jkulik has joined #openstack-nova06:19
*** zhanglong has joined #openstack-nova06:22
*** sapd1_x has joined #openstack-nova06:23
*** dpawlik has joined #openstack-nova06:26
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/69471706:27
*** mkrai has quit IRC06:30
*** mkrai has joined #openstack-nova06:30
*** dpawlik has quit IRC06:30
*** mkrai has quit IRC06:35
*** mkrai_ has joined #openstack-nova06:36
*** ccamacho has quit IRC06:43
*** jangutter has joined #openstack-nova06:47
*** yaawang has quit IRC06:47
*** yaawang has joined #openstack-nova06:48
*** mkrai_ has quit IRC06:49
*** jangutter has quit IRC06:52
*** dpawlik has joined #openstack-nova07:00
*** brault has joined #openstack-nova07:05
*** tetsuro_ has joined #openstack-nova07:06
*** tetsuro has quit IRC07:08
*** sorrison has quit IRC07:14
*** tkajinam_ has joined #openstack-nova07:18
*** tkajinam_ has quit IRC07:19
*** tkajinam_ has joined #openstack-nova07:20
*** tkajinam has quit IRC07:21
*** sapd1_x has quit IRC07:23
*** mkrai_ has joined #openstack-nova07:24
*** sorrison has joined #openstack-nova07:25
*** slaweq has joined #openstack-nova07:45
*** yaawang has quit IRC07:46
*** yaawang has joined #openstack-nova07:48
*** trident has quit IRC07:51
*** johanssone has quit IRC07:51
*** trident has joined #openstack-nova07:51
*** johanssone has joined #openstack-nova07:52
*** sorrison has quit IRC07:53
*** sorrison has joined #openstack-nova07:54
*** maciejjozefczyk has joined #openstack-nova07:56
*** damien_r has joined #openstack-nova08:00
*** gibi has joined #openstack-nova08:03
*** jangutter has joined #openstack-nova08:04
*** macz has joined #openstack-nova08:12
*** awalende has joined #openstack-nova08:14
*** tesseract has joined #openstack-nova08:16
*** macz has quit IRC08:16
*** yedongcan has joined #openstack-nova08:21
*** Roamer` has joined #openstack-nova08:26
*** sorrison has quit IRC08:26
*** ccamacho has joined #openstack-nova08:27
*** sorrison has joined #openstack-nova08:27
*** tosky has joined #openstack-nova08:29
*** boxiang has joined #openstack-nova08:31
*** boxiang has quit IRC08:32
*** boxiang has joined #openstack-nova08:33
*** ralonsoh has joined #openstack-nova08:33
*** boxiang_ has quit IRC08:34
*** sorrison has quit IRC08:42
*** rpittau|afk is now known as rpittau08:43
*** sorrison has joined #openstack-nova08:43
*** udesale has quit IRC08:43
*** udesale has joined #openstack-nova08:44
*** sorrison has quit IRC08:48
*** ivve has joined #openstack-nova08:51
*** mkrai_ has quit IRC09:00
*** mkrai has joined #openstack-nova09:00
openstackgerritAkira KAMIO proposed openstack/nova master: VMware: disk_io_limits settings are not reflected when resize  https://review.opendev.org/68029609:02
*** martinkennelly has joined #openstack-nova09:03
*** tkajinam_ has quit IRC09:20
*** sorrison has joined #openstack-nova09:23
*** gshippey has joined #openstack-nova09:25
*** sorrison has quit IRC09:28
*** dpawlik has quit IRC09:34
*** dasp has quit IRC09:42
*** dasp has joined #openstack-nova09:43
*** yaawang has quit IRC09:45
*** yaawang has joined #openstack-nova09:46
*** abaindur has quit IRC09:47
*** mkrai has quit IRC09:54
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings  https://review.opendev.org/69624609:55
openstackgerritBalazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture  https://review.opendev.org/69624709:56
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec  https://review.opendev.org/69654109:58
*** sorrison has joined #openstack-nova09:58
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name  https://review.opendev.org/69657409:59
openstackgerritBalazs Gibizer proposed openstack/nova master: Support live migration with qos ports  https://review.opendev.org/69590509:59
*** dpawlik has joined #openstack-nova10:02
*** sorrison has quit IRC10:04
*** huaqiang has joined #openstack-nova10:05
*** Liang__ has quit IRC10:05
*** rcernin has quit IRC10:06
*** dpawlik has quit IRC10:07
openstackgerritMerged openstack/nova master: add [libvirt]/max_queues config option  https://review.opendev.org/69511810:08
*** pcaruana has joined #openstack-nova10:08
*** dtantsur|afk is now known as dtantsur10:19
*** chenhaw has quit IRC10:27
*** dpawlik has joined #openstack-nova10:29
*** lpetrut has joined #openstack-nova10:34
*** derekh has joined #openstack-nova10:35
*** sorrison has joined #openstack-nova10:40
*** udesale has quit IRC10:44
*** dpawlik has quit IRC10:46
*** sorrison has quit IRC10:48
*** sorrison has joined #openstack-nova10:49
*** sorrison has quit IRC10:53
*** sorrison has joined #openstack-nova10:54
*** udesale has joined #openstack-nova10:58
*** sorrison has quit IRC10:59
*** zhanglong has quit IRC10:59
*** sorrison has joined #openstack-nova11:00
*** ociuhandu has joined #openstack-nova11:02
*** dpawlik has joined #openstack-nova11:02
*** sorrison has quit IRC11:05
*** dpawlik has quit IRC11:06
*** sorrison has joined #openstack-nova11:09
*** dpawlik has joined #openstack-nova11:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend NeutronFixture to allow live migration with ports  https://review.opendev.org/69624511:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Make the binding:profile handling consistent in NeutronFixture  https://review.opendev.org/69652611:11
*** ociuhandu has quit IRC11:12
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings  https://review.opendev.org/69624611:12
*** sorrison has quit IRC11:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture  https://review.opendev.org/69624711:15
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec  https://review.opendev.org/69654111:17
*** rpittau is now known as rpittau|bbl11:18
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings  https://review.opendev.org/69624611:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture  https://review.opendev.org/69624711:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec  https://review.opendev.org/69654111:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name  https://review.opendev.org/69657411:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Support live migration with qos ports  https://review.opendev.org/69590511:25
*** sorrison has joined #openstack-nova11:26
*** dpawlik has quit IRC11:32
*** sorrison has quit IRC11:34
*** dpawlik has joined #openstack-nova11:36
*** awalende_ has joined #openstack-nova11:37
*** sorrison has joined #openstack-nova11:38
*** bhagyashris has quit IRC11:40
*** trident has quit IRC11:40
*** awalende has quit IRC11:41
*** sorrison has quit IRC11:42
*** trident has joined #openstack-nova11:43
*** sorrison has joined #openstack-nova11:44
*** tbachman has quit IRC11:48
*** sorrison has quit IRC11:49
*** ociuhandu has joined #openstack-nova11:50
*** sorrison has joined #openstack-nova11:52
*** lpetrut has quit IRC11:53
*** zbr_ has quit IRC11:55
*** sorrison has quit IRC11:56
*** zbr has joined #openstack-nova11:57
*** boxiang has quit IRC11:59
*** sorrison has joined #openstack-nova12:00
*** boxiang has joined #openstack-nova12:00
*** sorrison has quit IRC12:04
*** mkrai has joined #openstack-nova12:10
*** sorrison has joined #openstack-nova12:13
*** mkrai has quit IRC12:14
*** sorrison has quit IRC12:18
openstackgerritsean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image  https://review.opendev.org/67407212:24
*** sorrison has joined #openstack-nova12:24
*** ociuhandu has quit IRC12:26
openstackgerritHuachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance  https://review.opendev.org/66865612:27
*** ociuhandu has joined #openstack-nova12:28
*** sorrison has quit IRC12:28
*** yedongcan has left #openstack-nova12:32
*** macz has joined #openstack-nova12:33
*** sorrison has joined #openstack-nova12:37
*** macz has quit IRC12:38
*** sorrison has quit IRC12:42
*** udesale has quit IRC12:46
*** udesale has joined #openstack-nova12:47
*** shilpasd has joined #openstack-nova12:49
*** sorrison has joined #openstack-nova12:54
*** sorrison has quit IRC12:58
*** tbachman has joined #openstack-nova13:04
*** dasp has quit IRC13:12
*** dasp has joined #openstack-nova13:12
*** mgariepy has quit IRC13:12
*** sorrison has joined #openstack-nova13:13
*** mgariepy has joined #openstack-nova13:15
*** sorrison has quit IRC13:23
*** ociuhandu has quit IRC13:26
*** ociuhandu has joined #openstack-nova13:27
*** ociuhandu has quit IRC13:33
*** sorrison has joined #openstack-nova13:35
*** lpetrut has joined #openstack-nova13:40
*** rpittau|bbl is now known as rpittau13:46
*** sorrison has quit IRC13:46
*** nweinber has joined #openstack-nova13:48
*** ygk_12345 has joined #openstack-nova13:50
*** sorrison has joined #openstack-nova13:53
openstackgerritBalazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name  https://review.opendev.org/69657413:55
openstackgerritBalazs Gibizer proposed openstack/nova master: Support live migration with qos ports  https://review.opendev.org/69590513:55
*** sorrison has quit IRC13:58
*** eharney has quit IRC13:58
*** ygk_12345 has quit IRC13:59
*** dave-mccowan has joined #openstack-nova14:02
*** mlavalle has joined #openstack-nova14:04
*** ygk_12345 has joined #openstack-nova14:05
*** tbachman has quit IRC14:05
*** tbachman has joined #openstack-nova14:06
*** sorrison has joined #openstack-nova14:08
*** sorrison has quit IRC14:12
*** mriedem has joined #openstack-nova14:12
ygk_12345hi all14:13
ygk_12345i am seeing broken pipe errors in the spice nova console logs14:13
*** tinwood_ is now known as tinwood14:13
ygk_12345the vm console is not taking the keyboard input properly and it is gibberish14:13
ygk_12345can anyone hepl me please ?14:14
ygk_12345*help14:14
*** shilpasd has quit IRC14:14
*** liuyulong has joined #openstack-nova14:14
ygk_12345any expert here in the spice console service ?14:14
*** shilpasd has joined #openstack-nova14:17
*** bhagyashris has joined #openstack-nova14:23
*** sorrison has joined #openstack-nova14:23
ygk_12345can someone look into this please14:23
ygk_12345https://bugs.launchpad.net/nova/+bug/185495014:23
openstackLaunchpad bug 1854950 in OpenStack Compute (nova) "VM console not clear" [Undecided,New]14:23
*** trident has quit IRC14:24
roukim no expert but i dont know how a broken pipe would be the issue, broken pipe is usually client going away.14:25
*** trident has joined #openstack-nova14:25
ygk_12345the user input is breaking into lines and not clear what they are typing into the console14:26
*** tbachman_ has joined #openstack-nova14:26
*** jhesketh has quit IRC14:27
*** tbachman has quit IRC14:27
*** tbachman_ is now known as tbachman14:27
*** jhesketh has joined #openstack-nova14:28
mriedemdo we have any maintainers for the vmware driver anymore? if so, would be good for them to check https://review.opendev.org/#/c/696503/ which removes nova-net support from the driver.14:28
*** bhagyashris has quit IRC14:29
*** sorrison has quit IRC14:30
*** pcaruana has quit IRC14:33
ygk_12345thos who want to see the issue, I am pasting it here14:34
ygk_12345Uploaded file: https://uploads.kiwiirc.com/files/ee624c90d6211419f9c7f626d11e6aad/Screenshot%20from%202019-12-03%2020-03-58.png14:35
*** tbachman has quit IRC14:37
*** amodi has quit IRC14:37
*** tbachman has joined #openstack-nova14:37
*** dave-mccowan has quit IRC14:42
*** mdbooth has quit IRC14:43
*** sorrison has joined #openstack-nova14:44
*** mdbooth has joined #openstack-nova14:44
ygk_12345can anyone check my issue please ?14:45
ygk_12345https://bugs.launchpad.net/nova/+bug/185495014:45
openstackLaunchpad bug 1854950 in OpenStack Compute (nova) "VM spice console not clear" [Undecided,New]14:45
*** sorrison has quit IRC14:48
mriedemstephenfin: question in https://review.opendev.org/#/c/696505/ - the xenapi nova-net removal change; i think there is a firewall driver we can also remove but maybe handle it in a follow up14:50
*** artom has quit IRC14:50
stephenfinmriedem: You mean these firewall drivers? https://review.opendev.org/#/c/696514/14:50
mriedemyou cheeky monkey14:51
* mriedem assumes he used that properly14:51
sean-k-mooneyyes you did which is not something i associate with the us14:51
mriedemb/c it's not14:52
sean-k-mooneythats more of a british/irish thing that granparents say to little childeren when they got away with something14:52
ygk_12345is anyone here familiar with the nova spice console ?14:53
sean-k-mooneyi think we all have deployed it at different times. are you haveing a specific issue14:54
ygk_12345sean-k-mooney this one https://bugs.launchpad.net/nova/+bug/185495014:54
openstackLaunchpad bug 1854950 in OpenStack Compute (nova) "VM spice console not clear" [Undecided,New]14:54
sean-k-mooneythat is strange i dont think i have ever seen https://launchpadlibrarian.net/454102031/Screenshot%20from%202019-12-03%2020-03-58.png14:56
sean-k-mooneystephenfin: do you recall if we still use websockify with the spice console14:57
ygk_12345when a use presses even an ENTER key it is splitting into lines and dots14:57
stephenfinwe do14:57
ygk_12345*user14:57
*** mkrai has joined #openstack-nova14:57
*** igordc has joined #openstack-nova14:57
*** ociuhandu has joined #openstack-nova14:58
sean-k-mooneyygk_12345: it look like the data is being currpted and the broken pipes would lead me to belive this is why the console is currupted14:58
sean-k-mooneyim wondering if the could be a websockify issue14:58
sean-k-mooneywe had this bug back in august https://bugs.launchpad.net/nova/+bug/184078815:00
openstackLaunchpad bug 1840788 in OpenStack Compute (nova) "websockify-0.9.0 breaks tempest tests" [Undecided,In progress] - Assigned to melanie witt (melwitt)15:00
sean-k-mooneyygk_12345: what version of websockify do you have installed?15:00
ygk_12345sean-k-mooney how to check it ?15:00
sean-k-mooneyhow did you install15:00
ygk_12345sean-k-mooney openstack ansible rocky 18.1.9 branch15:01
sean-k-mooneyok did you do the package install or the souce install15:01
*** mlavalle has quit IRC15:01
ygk_12345sean-k-mooney how do I determine that ? I just ran the playbooks15:02
sean-k-mooneymnaser: what is the default install mode for openstack ansible in rocky?15:02
ygk_12345followed the deployment guide as usual15:02
*** martinkennelly has quit IRC15:02
mnasersean-k-mooney: default is source inside containers15:02
sean-k-mooneymnaser: so to check websockify version ygk_12345 would have to ssh into the lxc container then do a pip freeze in the virtual env?15:03
*** pcaruana has joined #openstack-nova15:04
ygk_12345mnaser exact command please15:04
*** sorrison has joined #openstack-nova15:04
mnaserright they can hop into the lxc container (using lxc-attach too) and /openstack/venvs/nova-$version/bin/pip freeze15:04
ygk_12345mnaser ok15:05
sean-k-mooneyygk_12345: that may not be the error but if you are using 0.9.0 then its possibel. resolving the broken pipes will likely fix the issue but first you need to figure out why that happens15:06
sean-k-mooneythat is outside the scope of nova15:06
ygk_12345sean-k-mooney websockify==0.8.015:07
sean-k-mooneyok so that should hopefully be ok15:07
ygk_12345sean-k-mooney how to proceed now ?15:08
*** eharney has joined #openstack-nova15:08
sean-k-mooneyyou need to determin what is causing the broken pipies15:08
ygk_12345any clues ?15:09
*** sorrison has quit IRC15:09
sean-k-mooneyother then looking at the websockify logs and journalctl not really but perhaps someone else has an idea15:10
*** udesale has quit IRC15:10
*** udesale has joined #openstack-nova15:10
mriedemstephenfin: i jumped a bit but there are some nits in https://review.opendev.org/#/c/696511/4 if you want to FUP or if you end up needing to rev the series15:13
*** sorrison has joined #openstack-nova15:14
*** bhagyashris has joined #openstack-nova15:14
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: log when loading security group driver  https://review.opendev.org/65278315:14
stephenfincoolness15:16
ygk_12345sean-k-mooney we have a another similar setup, there also I observer broke pipe errors but the console is functioning fine there15:17
*** igordc has quit IRC15:17
ygk_12345sean-k-mooney do u thin k the problem is with the netwrok issues ?15:17
*** bhagyashris has quit IRC15:19
sean-k-mooneydansmith: by the way after our conversation with sundar yesterday i decied to look at option of emulating pci device in the kernel again. we may be able ot use the PCI Endpoint Framework https://www.kernel.org/doc/html/latest/PCI/endpoint/index.html to create device we could use for pci passthough testing and cyborg testing15:19
dansmithsean-k-mooney: sweet15:19
sean-k-mooneyi need to play around with it as the test driver is not complied in to the ubunut kernel module extra so il need to see how to compile it but ill let you know how it goes15:20
dansmithcool15:20
sean-k-mooneyit should allow use to create pci devices by creating folders with in /sys15:20
*** sorrison has quit IRC15:20
sean-k-mooneyhttps://www.kernel.org/doc/html/latest/PCI/endpoint/pci-test-howto.html#creating-pci-epf-test-device15:21
sean-k-mooneyif it works we shoudl be able to set the vendor id and prodcut id ot like 1234:42 then assert that a pci deivce with that vendor and prodcit id is availabel and passed to the guest15:22
*** munimeha1 has joined #openstack-nova15:22
*** sorrison has joined #openstack-nova15:23
*** igordc has joined #openstack-nova15:25
stephenfinmriedem: Dumb question, but the 'device_id' in a neutron port response will always be the instance's UUID, not the ID, right?15:25
*** ygk_12345 has quit IRC15:25
*** bhagyashris has joined #openstack-nova15:25
*** awalende_ has quit IRC15:25
*** awalende has joined #openstack-nova15:26
sean-k-mooneystephenfin: yes it will never be the db short id15:28
*** sorrison has quit IRC15:28
stephenfinta15:28
*** igordc has quit IRC15:30
*** awalende has quit IRC15:30
dansmithstephenfin: if it were the db id we wouldn't be able to distinguish one instance over another across cells15:30
mriedemwe also don't expose the server primary key id out of the rest api15:31
sean-k-mooneyimpliying that if it was teh primary key id that neutron would not be able to use it in api queries15:31
sean-k-mooneywe did expose the hypervior primary key although i think that was by mistake.15:32
mriedemit wasn't by mistake for hypervisors,15:32
mriedemthey originally didn't have uuids15:32
mriedemsame with services and lots of other things15:32
sean-k-mooneyah ok15:32
*** bhagyashris has quit IRC15:35
*** tesseract has quit IRC15:37
*** sorrison has joined #openstack-nova15:40
*** ociuhandu has quit IRC15:42
*** ociuhandu has joined #openstack-nova15:43
*** artom has joined #openstack-nova15:46
*** tesseract has joined #openstack-nova15:48
*** ociuhandu has quit IRC15:48
*** ociuhandu has joined #openstack-nova15:49
*** sorrison has quit IRC15:50
*** jmlowe has quit IRC15:52
*** aloga has joined #openstack-nova15:55
openstackgerritMatt Riedemann proposed openstack/nova master: Cache security group driver  https://review.opendev.org/69712215:57
*** sorrison has joined #openstack-nova15:57
*** sorrison has quit IRC16:02
*** mkrai has quit IRC16:02
*** jmlowe has joined #openstack-nova16:09
*** sorrison has joined #openstack-nova16:09
*** sorrison has quit IRC16:14
*** ivve has quit IRC16:15
*** udesale has quit IRC16:17
*** gyee has joined #openstack-nova16:19
*** dave-mccowan has joined #openstack-nova16:19
*** jamesdenton has quit IRC16:25
dansmithanybody want to +W this so Sundar can just rebase on master? https://review.opendev.org/#/c/695985/16:26
dansmiths/rebase/rebase the cyborg stuff/16:26
mriedemgibi: i replied to your questions in https://review.opendev.org/#/c/637058/, thanks. i'll stack a change on top of the series to see what replacing that setup_networks_on_host hack would look like if we just implement port binding deleting in cleanup_instance_network_on_host16:27
*** dpawlik has quit IRC16:27
mriedemdansmith: looking16:28
*** sorrison has joined #openstack-nova16:29
gibimriedem: ack, thanks16:30
*** sorrison has quit IRC16:37
*** lpetrut has quit IRC16:38
*** damien_r has quit IRC16:40
*** ociuhandu has quit IRC16:41
*** sorrison has joined #openstack-nova16:44
openstackgerritThierry Carrez proposed openstack/nova master: Remove unused rootwrap filters  https://review.opendev.org/69713416:46
*** sorrison has quit IRC16:48
*** ccamacho has quit IRC16:48
*** hamzy has quit IRC16:53
*** sorrison has joined #openstack-nova16:54
*** sorrison has quit IRC17:02
*** tesseract has quit IRC17:03
*** jlvillal has joined #openstack-nova17:09
*** sorrison has joined #openstack-nova17:10
*** rpittau is now known as rpittau|afk17:12
*** jlvillal has quit IRC17:14
*** jlvillal has joined #openstack-nova17:14
*** sorrison has quit IRC17:15
*** sorrison has joined #openstack-nova17:21
*** mlavalle has joined #openstack-nova17:21
*** sorrison has quit IRC17:28
*** sorrison has joined #openstack-nova17:30
*** dtantsur is now known as dtantsur|afk17:31
*** sorrison has quit IRC17:36
dansmitheandersson: what perf improvements in nova specifically have shifted your scale focus away from nova?17:36
*** dpawlik has joined #openstack-nova17:37
*** sorrison has joined #openstack-nova17:37
efrieddansmith: Would you please have another look at the vTPM spec. I'd like to get your +2 before you bugger off til 2020. https://review.opendev.org/#/c/686804/17:40
*** links has quit IRC17:40
dansmithefried: I've skimmed it.. tbh, I'm really like -0.9 on it, so if you want me to review it, it's probably going to be not helpful to your effort17:40
dansmithI'm not sure I see the benefit outweighing the nightmare of users trying to predict the behavior17:41
*** dpawlik has quit IRC17:41
*** sorrison has quit IRC17:41
dansmithI was thinking it was required for secure boot, but talking with folks I realize it's not, so ... it's just hard to justify I think17:41
*** jhesketh has quit IRC17:42
*** jhesketh has joined #openstack-nova17:44
sean-k-mooneyfor what its worth the out of tree hyperv driver support vtpm for 3-4 years already17:45
sean-k-mooneyits part fo there sheilded vms thing but i have no idea how they solved any of the issues with move operations17:45
efrieddid they?17:45
sean-k-mooneyyep ill get the link. did i not send this to you already17:46
dansmithsean-k-mooney: given how hyperv moves things I expect it's tracked by the hypervisor and so it just works, but I could be wrong17:46
sean-k-mooneyhttps://github.com/openstack/compute-hyperv/commit/f37ce8b6bb0eb88a367239698ba7c3df3b64db3817:46
dansmiththe question is more about how things like snapshot works17:47
sean-k-mooneythey have an os_vtpm image property17:47
sean-k-mooneythey must have patches against nova because the ImageMetaProps object does not accept os_vtpm or os_shielded_vm17:50
*** sorrison has joined #openstack-nova17:52
dansmithlooks like maybe they're doing some mangling of instance.hostname to reference specific keys or something?17:53
dansmithand they're illegally stashing their own stuff in insance.metadata17:53
dansmithso all manner of hacks in that implementation17:53
sean-k-mooneyyep17:53
sean-k-mooneyand none of this is supported in the in tree one17:53
*** sorrison has quit IRC17:56
sean-k-mooneyim looking at there snapshot function now https://github.com/openstack/compute-hyperv/blob/cb203978f262f31790592b2a0692fc2acaaef33d/compute_hyperv/nova/snapshotops.py#L66 but i think its just of the image so they dont snapshot the tpm?17:56
dansmithI dunno, but since they've already broken many rules of user interaction, looking further into how they handle it doesn't seem like it would help guide us17:57
sean-k-mooneyit proably wont but it looks like they just ignored it17:57
sean-k-mooneyso i guess there stance was the tpm state would not be resoreted if you restored form a snapshot17:58
sean-k-mooneythe same way non root disks are not restored17:58
dansmithor there is magic in the hostname mangling stuff so that if you recreate an instance with the right magic hostname, it will re-get the tpm stored in the hypervisor?17:59
dansmithgiven that they basically implement features by bounty in that out of tree driver, I expect they implemented just the part of the solution that would  suffice for the one customer asking for it18:00
sean-k-mooneyi dont think they are manageling the path in the metatada but yes i would guess the custoemr did not ask for snapshotiing so they did not add it18:01
efriedTo me, the only severe issue is evacuate. The rest should be easy to understand with proper documentation.18:02
sean-k-mooneyi think they were using the vtpm soly for disk encryption18:02
efried"vTPM is tied to your instance. Don't expect to be able to snapshot and clone it."18:03
*** ociuhandu has joined #openstack-nova18:04
efried"You can back up and restore as long as you use 'backup'."18:04
sean-k-mooney? you use backup18:04
*** ociuhandu has quit IRC18:05
sean-k-mooneyyou mean as long as you rebuild form a snapshot and dont launch an new instance right18:05
efriedNo. I mean as long as you use rebuild from an image created via the createBackup server action18:05
sean-k-mooneyright but does that not just create a shapshot18:06
efried'snapshot' isn't a server action. There's createImage and createBackup. Both of them snapshot under the covers.18:06
sean-k-mooneyoh right18:06
sean-k-mooneybut createBackup uploads it as a snapshot to glance18:06
efriedpoint is, the image you get from createImage can be (non-awkwardly) used to clone your VM. Whereas createBackup is more tailored to rebuild.18:07
sean-k-mooneydoes createimage upload as a snapshot i though it flattened the image18:07
sean-k-mooneyok18:07
*** ociuhandu has joined #openstack-nova18:07
efriedrebuild is your same instance. Otherwise you're creating a new instance. If you're creating a new instance, it will get a new (or no) vTPM.18:07
efriedso the only quirk is that in order for rebuild to restore your vTPM, you have to use an image from createBackup.18:08
efriedwhich makes sense18:08
efriedif you use a random image from createImage, why would you expect your vTPM from your original instance to be restored?18:08
efriedconversely, if you're creating a brand new instance (from *any* image), why would you expect anything other than a fresh vTPM?18:09
sean-k-mooneyya so i said previously that the vtpm should be tied to the lifetime of the instace so i think that makes sense18:09
efriedwe've got an answer for all the move operations and shelve/unshelve.18:10
sean-k-mooneywe are explcitly saying the usecase of i create a vm snapshot and spawn 100 more is expresly out of scope (in that they wont all get the orginal vms vtpm)18:10
*** sorrison has joined #openstack-nova18:11
efriedI wouldn't phrase it as "out of scope". It's got clean, predictable behavior: you don't get the original VM's vTPM.18:11
sean-k-mooneyyes that is what i intened18:11
efriedwhich, for anyone using a vTPM, ought to make sense. "don't give my secure stuff to another instance"18:11
sean-k-mooneycopying the vtpm in that case is not supported intentionally18:11
*** ociuhandu has quit IRC18:12
efriedyeah, I'm just getting nitpicky about the language. "out of scope" and "not supported" imply "don't work".18:12
sean-k-mooneyso i would be ok with that set of constratits but im not really the person you have to convice18:12
eanderssondansmith so we jumped from mitaka to rocky18:12
eanderssonSo it's difficult to say exactly what part improved performance the most18:13
eanderssonbut we believe placement played a big role here18:13
dansmitheandersson: well, is it scheduling performance, instance listing performance, build time, etc?18:13
eanderssonscheduled is a lot better at least ~50%18:13
dansmithsweet, so that's likely placement yeah18:13
eanderssonAlso scaling computes18:13
dansmitheandersson: what does "scaling computes" mean?18:14
eanderssonWe initially limited ourself to 1000 computes per region18:14
eanderssonin Mitaka18:14
eanderssonbut now believe we can reach a much higher number than that18:14
dansmitheandersson: is that via cells or just in general? because I don't think we've done anything other than get *more* chatty to the db/mq since mitaka :)18:14
eanderssonAnd even if we do hit limitations we can now use cells18:14
*** jmlowe has quit IRC18:15
eanderssonscheduler used to be really heavy on rmq18:15
eanderssonin mitaka18:15
*** igordc has joined #openstack-nova18:15
sean-k-mooneyeandersson: do you run sepperate rmq instacne per openstack service18:15
*** jmlowe has joined #openstack-nova18:15
eanderssonWe do not18:16
*** sorrison has quit IRC18:16
eanderssonbut even at 1k computes we are barely putting any stress on rmq at the moment18:16
eanderssonOf course we are not using ceilometer18:16
sean-k-mooneyim surpirsed you are getting to 1000 nodes on one cluster with neutron and nova sharing it18:16
dansmitheandersson: so you're thinking that lowered load on rabbit from the scheduler lets you have more computes?18:16
sean-k-mooneyya not using ceilometer helps18:16
eanderssondansmith I think it helps18:17
dansmithack18:17
*** ociuhandu has joined #openstack-nova18:18
eanderssonWe were getting a lot of slow api calls in mitaka and they are all very consistent now18:18
*** maciejjozefczyk has quit IRC18:18
eanderssonThe only problems we have with nova now is getting our super custom scheduling logic to scale18:19
dansmiththat's what I'm interested in specifically,18:19
dansmithbut without knowing which calls those were I can't really attribute them to anything18:19
dansmith(that == slow api calls)18:19
eanderssonYea - unfortunately a lot of the research and testing we did was back in ~201618:20
eanderssonWe didn't do a great job tracking individual improvements when going from Mitaka to Rocky18:21
sean-k-mooneyeandersson: do you have a list of constraits you need to schduler on that are not supported cleanly upstream that could be shared perhaps we could accomadate some of your custom logic18:21
eanderssonWe do flavor stacking and what... we internally call "perfect fit".18:22
sean-k-mooneyusing the type affingity filter18:22
mriedemyou also have a variant of the old flavor affinity filter yeah?18:23
sean-k-mooneyso that each host only one flavor18:23
eanderssonSo we actually want to stack flavors on a compute18:23
eanderssonbecause these are game servers18:23
eanderssonSo each game server takes up one numa18:23
eanderssonbut we still want to be able to schedule other micro services on top18:24
*** jmlowe has quit IRC18:24
*** eharney has quit IRC18:24
eanderssonSince we don't want to have to divide the fleet18:24
sean-k-mooneyso you want to pack the large flavor and then fit the micof servces wehre tehy can18:24
eanderssonYep18:24
sean-k-mooneythat not really unresobaly to be fair18:25
sean-k-mooneythe main issue i guess you face right now is fragmenation18:25
eanderssonYea - if we go with the out of the box implementation18:26
sean-k-mooneye.g. a small instnace spawns preventing a large instnace18:26
eanderssonyep18:26
dansmithbut also...scheduler filters are the one place I think we *should* be pluggable, and so unless other people want *exactly* the same weird scheduling thing, it makes sense for them to do this on their own, IMHO18:26
eanderssonYep - I hate that I have to patch nova for this18:26
eanderssonI mean we have a super custom way of deploying, plus probably 20 custom nova patches at least18:26
sean-k-mooneythis is not the first time i have heard this requrest however18:27
*** awalende has joined #openstack-nova18:27
*** tbachman has quit IRC18:27
eanderssonSo it's not a big deal, but would be a lot easier for us to manage it if it was pluggable18:27
dansmithscheduler filters *are* pluggable18:27
sean-k-mooneyeandersson: as are the weighers18:27
dansmithpresumably you're dependent on other changes/18:27
eanderssonThey are?18:27
sean-k-mooneyyep18:27
sean-k-mooneybut its non ovious how to do it18:28
*** sorrison has joined #openstack-nova18:28
dansmithit's very obvious18:28
dansmithit may not be _documented_ :)18:28
eanderssonbtw we also have weights for upgrading computes (e.g. a compute that needs a OS upgrade would be moved into an aggregate to reduce the changes of it getting scheduled to)18:28
dansmithhttps://docs.openstack.org/nova/latest/user/filter-scheduler.html#writing-your-own-filter18:28
sean-k-mooneyeandersson: here is an example https://opendev.org/x/nfv-filters18:29
*** derekh has quit IRC18:29
eanderssonAh yea I see18:30
*** awalende has quit IRC18:31
sean-k-mooneyyou just do filter_scheduler.available_filters=nova.scheduler.filters.all_filters,nfv_filters.nova.scheduler.filters.aggregate_instance_type_filter18:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Kill it  https://review.opendev.org/69651818:31
openstackgerritStephen Finucane proposed openstack/nova master: Rename 'nova.network.neutronv2' -> 'nova.network'  https://review.opendev.org/69674518:31
openstackgerritStephen Finucane proposed openstack/nova master: Rename 'nova.network.security_group.neutron_driver' -> 'nova.network.security_group'  https://review.opendev.org/69674618:31
openstackgerritStephen Finucane proposed openstack/nova master: Remove unnecessary 'neutronv2' prefixes  https://review.opendev.org/69677618:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions  https://review.opendev.org/69714918:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove db methods for ProviderMethod  https://review.opendev.org/69715018:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unused 'stub_out_db_network_api'  https://review.opendev.org/69715118:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas  https://review.opendev.org/69715218:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object  https://review.opendev.org/69715318:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object  https://review.opendev.org/69715418:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object  https://review.opendev.org/69715518:31
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects  https://review.opendev.org/69715618:31
sean-k-mooneyyou can similary have out of tree weighers that you can load in a similar way18:32
*** sorrison has quit IRC18:32
sean-k-mooneydansmith: by the way this is actully a lot simpler then i rememeberd i was thinking of out of tree virt drivers which require you to reopen the nova namespace and do other things to make them work18:34
sean-k-mooneydansmith: be we dont really want that to be plugablle in the same way so it makes sense that is more work18:34
dansmithyup18:34
*** tbachman has joined #openstack-nova18:35
*** abaindur has joined #openstack-nova18:37
*** ociuhandu has quit IRC18:39
*** ociuhandu has joined #openstack-nova18:40
*** sorrison has joined #openstack-nova18:40
*** jmlowe has joined #openstack-nova18:40
*** abaindur has quit IRC18:42
*** sorrison has quit IRC18:44
*** ociuhandu has quit IRC18:44
artomDo we not reset the old flavor back on the instance if we fail a resize? Fail as in, something goes wrong during _prep_resize or resize_instance18:49
*** sorrison has joined #openstack-nova18:49
efriedgosh, I would hope we do18:49
artomI can't find it - maybe I'm looking in the wrong place...18:50
artomI mean, we must18:50
sean-k-mooneyin pre_resize i dont think we have saved the instace yet18:50
artomOh, is that how?18:51
sean-k-mooneyi have not looked at that in a while however. have we saved it since old_flavor was defined18:51
artomWe just don't persist until it's final18:51
sean-k-mooneywell we woudl presisti it before we go to resize verify18:51
*** abaindur has joined #openstack-nova18:51
*** abaindur has quit IRC18:52
sean-k-mooneyi would just check where it is saved first18:52
*** abaindur has joined #openstack-nova18:52
artomThat's what I'm looking for...18:53
dansmithnot just save, but save() after instance.flavor is set, unrelated to instance.old_flavor18:53
*** sorrison has quit IRC18:54
sean-k-mooneyi think this is where we revert it if we get to revert resize https://github.com/openstack/nova/blob/757fc03b78d542e7262343b65eacea02ce11dd04/nova/objects/instance.py#L1021-L103518:55
sean-k-mooneybut im not sure that is required if we fail early18:55
*** damien_r has joined #openstack-nova18:57
sean-k-mooneythis is where we update the instace i think https://github.com/openstack/nova/blob/757fc03b78d542e7262343b65eacea02ce11dd04/nova/compute/manager.py#L5260-L529218:58
sean-k-mooneyso assuming we call _prep_resize before _finish_resize if you fail in _prep_resize im not sure you need to do anything18:59
*** hamzy has joined #openstack-nova18:59
*** gmann is now known as gmann_afk19:00
*** jamesdenton has joined #openstack-nova19:00
sean-k-mooneyartom: is that what you were looking for?19:00
*** ralonsoh has quit IRC19:00
artomsean-k-mooney, I'm looking for where the request spec is reverted back to the old flavor19:02
artomI said instance dind't I?19:03
artomI meant request spec19:03
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Implement cleanup_instance_network_on_host for neutron API  https://review.opendev.org/69716219:03
dansmithartom: compute can't reset the reqspec, so if it happens late enough, that won't happen19:07
dansmither, s/happens/fails/19:07
dansmithI think the only downside to that is if we do something that looks at the reqspec and not the instance, not sure what that would be19:08
artomSorry, was on a call19:17
* artom reads scrollback19:17
artomContext is https://review.opendev.org/#/c/662522/1319:18
artomSo I guess scheduling looks at request spec19:19
*** awalende has joined #openstack-nova19:20
eanderssonbtw major annoyance at the moment is when instances get stuck in building19:21
eanderssonoften you don't know which compute they are stuck buidling against19:21
*** awalende has quit IRC19:24
mriedemcheck the launched_on field on the instance - that wasn't cleaned up until recently19:24
mriedemif instances are getting stuck in BUILD status somewhere when we failed, report a bug19:24
mriedemlike you did with bug 183795519:25
openstackbug 1837955 in OpenStack Compute (nova) stein "MaxRetriesExceeded sometime fails with messaging exception" [Medium,Fix committed] https://launchpad.net/bugs/1837955 - Assigned to Matt Riedemann (mriedem)19:25
mriedemefried: dustinc: what baremetal api version is used when we get a node's details now? https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L22619:26
mriedemsince we're not using the client_wrapper there i can't tell if it's 1.46 https://github.com/openstack/nova/blob/master/nova/virt/ironic/client_wrapper.py#L35 or something else19:27
efriednegotiated by sdk, no?19:27
dansmithartom: so you mean a failed resize followed by a migration would use the new flavor as part of scheduling yeah?19:27
mriedembased on the fields requested?19:27
efriedno, based on what's available19:28
efriedI think sdk does version discovery and uses the latest they mutually understand. mordred?19:28
mordreduh19:28
*** ivve has joined #openstack-nova19:28
mordredreading19:28
dustincI don't know, I never had to deal with it so I _assume_ it is the most recent common version19:28
mriedemis there a way to tell if the sdk will use 1.50+ to get the node.owner field?19:29
mriedemah yes19:29
mriedem_max_microversion = '1.52'19:29
mordredyes - that's right. it does discovery and gets the latest that sdk and the remote both understand19:29
mordredso yeah - shuold be 1.50+ - assuming the ironic supports that19:30
mriedemah but the sdk node object doesn't have an explicit owner property so i'd have to add that19:30
mordredyah. dtantsur|afk ^^19:30
efriedmriedem: right -- the sdk is kind of supposed to abstract away "microversion" and instead let you think about "feature" -- in this case node.owner.19:30
mriedemsure. i didn't know it hard-coded all of the properties though.19:31
efriedso if you want $feature at $microversion, sdk has to be plumbed to a) use $microversion, and b) expose $feature. Then nova has to require the release of sdk that does that, etc.19:31
efriedoh. Yeah :)19:31
mriedemmakes my little wip hackaroo i was going to do this afternoon not so simple, but anyway19:32
mriedemthanks19:32
artomdansmith, I think so19:33
dustinchttps://docs.openstack.org/openstacksdk/latest/user/microversions.html19:33
mordredmriedem: one day we'll get to the point where people will add support for a thing to sdk when they add it to a service and life will be magical19:33
artom(Sorry, got ADHD'ed away to another thing)19:33
mordredwe are not at that day today19:33
dansmithartom: might be valid to refresh the reqspec from the instance before we go into an operation like that19:33
mriedemmordred: and osc et al :)19:34
*** martinkennelly has joined #openstack-nova19:34
mriedemefried: note the ..note:: rendering at the bottom of https://docs.openstack.org/openstacksdk/latest/user/microversions.html - tickles your rst ocd?!19:34
efriedaaaaaagh!19:35
artomHey, so I'm backporting https://review.opendev.org/#/c/619953/10/nova/conf/libvirt.py@719 internally19:36
artomAnd wondering about changing the default to 'unique'19:36
efriedmordred: mriedem: https://review.opendev.org/69716819:36
*** eharney has joined #openstack-nova19:36
efried...and, you suck.19:36
artomCan't imagine Windows would appreciate its sysinfo_serial changing under it19:37
*** dpawlik has joined #openstack-nova19:37
artomAm I just being paranoid about this? mriedem, dansmith, ^^ you guys are the approvers do you recall talking about this at all?19:37
mordredefried: +A19:38
eanderssonmriedem I think there are at least a handful of bugs causing it for us19:40
eanderssondifficult to get a handle on the causes19:40
mriedemartom: backporting features huh19:41
artommriedem, only backportable ones19:41
mriedemare you asking about the serial changing on an existing guest?19:41
artommriedem, yeah19:41
mriedemso change the default to 'auto' like it was?19:42
*** dpawlik has quit IRC19:42
artommriedem, well, not sure it makes sense to go back at this point19:42
mriedemthere was quite a bit of discussion around that blueprint, including being able to override the host config with image meta or flavors but that was dropped19:42
eanderssonbtw launched_on is is always null19:42
artomBut... there's an impact, right? The default becomes 'unique', instance is hard-rebooted, boom, new serial19:42
artomLinux is probably OK, but Windows...19:42
artomSo lyarwood just updated our proposed backport to not change the default19:43
artomDo... do we need to do the same upstream?19:43
mriedemthere is an upgrade release note. i'd have to dig into all of the comments on that patch to determine if we changed the default later or not for good reason19:43
*** nweinber has quit IRC19:44
mriedemthat was released in stein19:44
mriedemchanging the default from 2 releases back would be weird19:44
artomRight, so it's already out there19:44
artomI know19:44
*** nweinber has joined #openstack-nova19:44
*** nweinber has quit IRC19:44
*** nweinber has joined #openstack-nova19:45
efriedmriedem: see gibi's comment at the bottom of https://review.opendev.org/#/c/696992/ -- is it possible the bw test was removed when you refactored to get rid of tempest-slow?19:45
eanderssonI think this is a new stuckin BUILD bug because I can't even find the instance in placement19:46
mriedemefried: it should be run in the nova-next job19:48
efriedokay, will look for it there19:49
mriedemi don't see it, checking something19:49
artomI guess there's less impact when it's in a new release19:49
mriedemartom: well we don't backport features upstream for a reason so sure19:49
artomBut in an existing release we definitely can't change the defaults19:50
mriedemhey, how you want to break your enterprise users on queens is up to you :)19:50
artomIn a way that we can fix for loads of $$19:50
mriedemjob security19:50
artom'zactly19:50
openstackgerritEric Fried proposed openstack/nova master: Use Placement 1.34 (string suffixes & mappings)  https://review.opendev.org/69641819:52
openstackgerritEric Fried proposed openstack/nova master: refactor: RequestGroup.is_empty() and .strip_zeros()  https://review.opendev.org/69699119:52
openstackgerritEric Fried proposed openstack/nova master: Tie requester_id to RequestGroup suffix  https://review.opendev.org/69694619:52
openstackgerritEric Fried proposed openstack/nova master: WIP: Use provider mappings from Placement (mostly)  https://review.opendev.org/69699219:52
mriedemefried: so nova-next should run tempest api compute and scenario tests:19:52
mriedemtempest_test_regex: ^tempest\.(scenario|api\.compute)19:52
mriedemexcept these scenario tests:19:53
mriedemtempest_black_regex: ^tempest.scenario.test_network19:53
mriedembut that shouldn't hit on tempest/scenario/test_minbw_allocation_placement19:53
mriedemit does get run in tempest-slow in train though yeah https://zuul.opendev.org/t/openstack/build/ddb1fb60455d4f7681a9a377aaef63ab/log/job-output.txt#7358319:54
eanderssonI am wondering if we are hitting some race conndition19:55
eanderssonBecause we create 2 VMs ever 10 minutes and never get VMs stuck in BUILDING.19:55
eanderssonbut our customers hit this very often with aggressive terraform deployments19:55
mriedemefried: so we went from this in tempest-slow:19:55
mriedemslow-serial run-test: commands[1] | tempest run --serial --regex '\[.*\bslow\b.*\]' --concurrency=2 --black-regex=19:55
mriedemto this in nova-next:19:55
mriedemall run-test: commands[1] | tempest run --regex '^tempest\.(scenario|api\.compute)' --concurrency=4 '--black-regex=^tempest.scenario.test_network'19:56
mriedemi'm not sure why test_minbw_allocation_placement would be filtered out19:56
mriedemoh i see19:56
mriedemhttps://zuul.opendev.org/t/openstack/build/66f29bf5f12449059e82d24db5aff47a/log/job-output.txt#7932819:56
mriedem{2} setUpClass (tempest.scenario.test_minbw_allocation_placement.MinBwAllocationPlacementTest) ... SKIPPED: Skipped as no physnet is available in config for placement based QoS allocation.19:57
efriedo19:57
efried"in config" like the devstack config?19:57
mriedemtempest config19:58
mriedemhttps://github.com/openstack/tempest/blob/3eb3c29e979fd3f13c205d62119748952d63054a/tempest/scenario/test_minbw_allocation_placement.py#L7219:58
mriedemhttps://zuul.opendev.org/t/openstack/build/ddb1fb60455d4f7681a9a377aaef63ab/log/controller/logs/tempest_conf.txt.gz#8119:58
mriedemthe tempest-slow job has that, the nova-next job does not19:59
mriedemhttps://github.com/openstack/tempest/blob/3eb3c29e979fd3f13c205d62119748952d63054a/.zuul.yaml#L29019:59
mriedemso we need that in the nova-next job20:00
efriedneat20:00
mriedemreport a bug and i can fix that up in a bit or push your own change20:00
efriedand probably the stuff above it too.20:01
mriedemyeah i suppose20:01
mriedemhttps://github.com/openstack/tempest/commit/c87a06b3c29427dc8f2513047c804e0410b4b99c20:01
mriedemwhatever was added in there20:01
mriedemactually you're in luck,20:02
eanderssonI created a bug, will add more info if/when I find it. https://bugs.launchpad.net/nova/+bug/185499220:02
openstackLaunchpad bug 1854992 in OpenStack Compute (nova) "Frequent instances stuck in BUILD with no apparent failure" [Undecided,New]20:02
mriedemthe nova-next job already sets that shit up b/c the post-test hook runs heal_allocations on a instance with a port that has bw20:02
mriedemyou just need tempest.conf updated20:02
*** ociuhandu has joined #openstack-nova20:03
eanderssonMy best guess at the moment is RabbitMQ related issues (e.g. we have hit bugs in RabbitMQ where bindings exists, but are broken)20:04
*** nweinber has quit IRC20:05
openstackgerritLee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue  https://review.opendev.org/69406320:07
efriedmriedem: https://bugs.launchpad.net/nova/+bug/185499320:07
openstackLaunchpad bug 1854993 in OpenStack Compute (nova) "QoS bandwidth tempest test no longer running" [Undecided,New]20:07
*** ociuhandu has quit IRC20:08
*** nweinber has joined #openstack-nova20:09
efriedfixing...20:09
openstackgerritMerged openstack/nova master: Add a way to exit early from a wait_for_instance_event()  https://review.opendev.org/69598520:09
artomdansmith, answering my own earlier question, looks like we actually save the request_spec in the conductor only if the resize/migration succeeded20:10
openstackgerritMerged openstack/nova master: docs: Change order of PCI configuration steps  https://review.opendev.org/69452120:10
openstackgerritMerged openstack/nova master: docs: Clarify configuration steps for PF devices  https://review.opendev.org/69452220:10
openstackgerritMerged openstack/nova master: Suppress policy deprecated warnings in tests  https://review.opendev.org/67667020:10
artomExcept... that doens't work, because the conductor then casts to the computes to do the work20:10
artomSo if something fails in prep_resize or resize_instance, we'll never know20:10
openstackgerritEric Fried proposed openstack/nova master: Add QoS tempest config so bw tests run  https://review.opendev.org/69718020:11
efriedmriedem: ^20:11
efriedgibi: ^20:11
mriedemefried: hammered you20:15
mriedemhttps://youtu.be/otCpCn0l4Wo?t=11020:16
mriedembreak it down!20:16
dansmithartom: right, that's why I said if it happens too late20:17
*** tbachman has quit IRC20:18
openstackgerritEric Fried proposed openstack/nova master: Add QoS tempest config so bw tests run  https://review.opendev.org/69718020:19
artomdansmith, right, just caught up with you20:19
artomMind you20:20
* artom is confuzzled20:21
mriedemdoing a thing in the api, failing in compute, and being out of whack isn't a new problem20:22
openstackgerritEric Fried proposed openstack/nova master: Use Placement 1.34 (string suffixes & mappings)  https://review.opendev.org/69641820:22
openstackgerritEric Fried proposed openstack/nova master: refactor: RequestGroup.is_empty() and .strip_zeros()  https://review.opendev.org/69699120:22
openstackgerritEric Fried proposed openstack/nova master: Tie requester_id to RequestGroup suffix  https://review.opendev.org/69694620:22
mriedems/api/controller/20:22
openstackgerritEric Fried proposed openstack/nova master: WIP: Use provider mappings from Placement (mostly)  https://review.opendev.org/69699220:22
artommriedem, so do we have a "best practice" kind of thing to handle it?20:22
artomOr it's all case by case?20:22
mriedemyou're worried that we change the request spec to use the new flavor in the api/conductor, cast to compute to do the resize, it fails and the instance is using the old flavor and the request spec is using the new flavor, right?20:23
mriedemand then when cold migrating that server, the request spec is incorrectly using the new flavor that the instance isn't actually using20:23
artommriedem, yes to both20:24
artomAnd really it's gibi that's worried - he brought it up on the review20:24
mriedemthere isn't really a best practice for that. the compute can't/shouldn't get an update the request spec. there is no periodic in the controller services that is healing the request spec for failed resizes.20:25
*** gmann_afk is now known as gmann20:25
mriedemnote that in revert_resize in the API, we also update the request spec to match the source host and then cast off to do the things in compute20:25
mriedemif those things fail, the request spec could be out of sync again20:25
mriedemas time has gone on we've persisted less and less of the original crap we used to store in the request spec20:26
mriedemso it was just a blob to pass things from the api to the scheduler20:26
mriedemthe flavor is tricky though since it is useful for things like down-cell api responses where we don't have the instance record20:26
mriedemtl;dr is there a best practice for avoiding split brain? heal things periodically? use etcd? :)20:27
artom(so what's in the api_db for instances? just a cell mapping?)20:27
mriedemcell/instance mappings and request spec20:27
dansmithmriedem: earlier I said it's probably legit to refresh the reqspec from the instance's flavor before we go into a scheduling operation for an existing instance20:27
mriedemserver group members20:27
dansmiththat would solve the problem I think20:28
dansmithleaving only cell down showing some outdated instance info guesses, which wouldn't be the end of the world20:28
artomdansmith, that's kinda where I'm leaning - if we take the definition of request spec to be what mriedem said "pass scheduling-related things from API  to scheduler"20:28
dansmithartom: yup20:28
artomThen yeah, "load it up from latest instance makes sense'20:28
dansmiththere's another much more edge case where that makes sense too,20:29
artomAlthough that makes one wonder "what's the point of request_spec in the first place, if everything it in instance anyways"20:29
dansmithwhich is you restore either database from a non-coordinated backup after a disaster or failed upgrade20:29
dansmithartom: you mean reqspec.flavor?20:29
dansmithartom: before an instance exists, that's where we hold the flavor,20:30
artomdansmith, yeah, and request_spec.numa_topology20:30
mriedemartom: it's not all instance20:30
mriedemscheduler hints, forced hosts/nodes, etc20:30
dansmithartom: and if the cell is down, then we use the stuff in reqspec as a cache20:30
mriedemrequested destinations20:30
artomI see20:30
dansmithmriedem: right, hence why I asked, I assume he meant the duplicative parts of reqspec, which is just flavor, AFAIK20:30
artomdansmith, numa_topology20:30
mriedemit's an objectified and persisted version of the old filter_properties stuff, and some of it getting persisted always has caused a lot of problems20:31
dansmithartom: I thought the instance numa topo ended up getting fleshed out by the virt driver,20:31
dansmithartom: where reqspec's copy was kinda the planned topo, which would still be valid to keep I tink20:31
artomdansmith, so there's 2 things there: 1 is the instance numa topology, which can be got from flavor and image meta20:31
mriedemthere are a few things, numa topo, flavor, image, az, pci requests20:31
artom2 is how it fits on a host - *that* part is virt driver20:31
artom1 is in reqest spec20:31
dansmithmriedem: yeah, fair20:32
artomUnfortunately, they're muddled in the same object :(20:32
dansmithwell, regardless,20:32
dansmithsome duplication gives us a bit of a backup in the case of cell downage as I said20:32
artomFair enough20:33
artomOK, gives me stuff to think about20:33
dansmithmriedem: doesn't pci_requests in the instance get fleshed out more than in the reqspec too?20:33
artomI'll also need to think about backportability20:34
mriedemmaybe, don't know off the top of my head20:35
artomBecause while https://bugzilla.redhat.com/show_bug.cgi?id=1715240 is Newton is at last EOL for HR20:35
openstackbugzilla.redhat.com bug 1715240 in openstack-nova "Resize ignores mem_page_size in new flavor" [High,On_dev] - Assigned to alifshit20:35
artom*RH20:35
mriedemi want to say that's Instance.pci_devices which is the allocated devices on the node20:35
artomWe'll probably want it in Queens as well20:35
artomNeed to bounce early to pick up 1/2 of my kids20:36
artomThank you gentlemen20:36
dansmithmriedem: I thought we updated some physnet stuff in instance_pci_requests at least, but anyway, doesn't matter20:36
mriedemwhat happened to the other half of the children?20:36
artommriedem, I have the other half of my marriage for that :D20:36
dansmithI assume that when you get divorced and you have an even number of children, you just split those like the bank and other assets/liabilities right?20:37
artomNo, the woman takes everything20:38
dansmithoh, okay20:38
artomAnd you're just left with alcoholism and depresseion20:38
artom(And those are not the names of the kids, btw)20:38
dansmithassuming those aren't the names of half your children.. gotcha20:38
dansmithhaha20:38
artom:D20:39
*** artom has quit IRC20:40
*** vesper11 has quit IRC20:49
*** vesper11 has joined #openstack-nova20:51
*** sorrison has joined #openstack-nova20:59
openstackgerritMatt Riedemann proposed openstack/nova master: ironic: report a custom trait for the node owner  https://review.opendev.org/69718421:01
*** sorrison has quit IRC21:04
*** abaindur has quit IRC21:08
*** francoisp has joined #openstack-nova21:12
eandersson> Unable to submit allocation for instance x (409 {"errors": [{"status": 409, "request_id": "reqz", "code": "placement.undefined_code", "detail": "There was a conflict when trying to complete your request.\n\n Unable to allocate inventory: Unable to create allocation for 'VCPU' on resource provider y'. The requested amount would exceed the21:16
eanderssoncapacity.  ", "title": "Conflict"}]})21:16
eanderssonThis was the cause of the latest instance stuck in BUILD21:16
mriedemthose instances should all be buried in cell0 in conductor21:17
mriedemscheduler should raise a NoValidHost21:17
mnaserdoes setting `hw:mem_page_size` = `any` enable memory tracking on the host inside nova?   reading the code leads to show that it does21:18
mriedemeandersson: NoValidHost should be handled by conductor here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L141821:18
mnaseri'm running into an issue where doing numa node pinning without `hw:mem_page_size` yields in nova packing too many instances into numa node 0, which then results in `oom-killer`21:18
eanderssonI see one more log line on that req-id in the scheduler21:19
eandersson>  Computed NUMA topology CPU pinning: usable pCPUs: [[18, 38]], vCPUs mapping: [(0, 18), (1, 38)]21:19
mriedemeandersson: and all of those build requests should result in creating instances in ERROR status in cell0 https://github.com/openstack/nova/blob/1c2b7d8f01814adfd6d28b97013a40cca51dfbdf/nova/conductor/manager.py#L134821:19
mriedemcheck your conductor logs21:19
eanderssonconductor logs are empty21:19
sean-k-mooneymnaser: just got back. hw:mem_page_size=any was intened to allow the image to choose if hugepage or small pages should be used21:19
sean-k-mooneymnaser: i belive it should enable the numa tracking but its the one policy that is least used21:20
mnasersean-k-mooney: but what if i dont want neither and i just want nova to be aware of memory per numa node?21:20
mnasercause that involves rebooting the machine and what not to enable those21:20
eanderssonand when I say empty, there are literately no log lines over the last 12 hours.21:20
mnasersean-k-mooney: according to virsh capabilities, the cell only has pages with size='4'21:21
sean-k-mooneywell you cant change an exitisng image to any with out a resize21:21
mnaserright but for newly booted instances flavor change21:21
*** tbachman has joined #openstack-nova21:21
mnaserupdate th flavor extra_specs and newly booted instances will do the right thing(tm)21:21
sean-k-mooneyright so hw:mem_page_size=small would use 4k pages21:21
eanderssonbtw placement failed 6 times with the same erroor before it pretty much just stopped trying21:22
sean-k-mooneyany should also use 4k pages but would allow the image to request 2mb21:22
mnasersean-k-mooney: ok cool, i see, so 'any' should technically make things work and make nova start tracking memory21:22
eanderssonIts probably RabbitMQ issues again, but we tested all queues and binding and none are failing.21:22
eanderssonLike we have seen in the past.21:22
sean-k-mooneyi need to triple check it but if hw:mem_page_size is defiend it is ment to enable the numa aware tracking21:23
sean-k-mooneyno mater what value you set it to21:23
mnasersean-k-mooney: ok ill check and report back, but my notes seem to add up to yours :>21:23
eanderssonThe most frustrating part is that there are no logs, and nothing in the database, so troubleshooting these usually requires looking into the database.21:23
eandersson*nothing from the api21:24
mnasereandersson: did you have any rabbitmq outage/issue?21:24
sean-k-mooneythe reason im a little less confident with hw:mem_page_size=any is i know we dont have tempest testing for it21:24
sean-k-mooneywhere as we did for large and small21:24
eanderssonmnaser in the past yea and we found bad bindings after that21:24
mnaserin this case the only reason i care about mem page size is to get nova to track memory so maybe ill try small after all21:24
eanderssonwe found a way to diagnose that21:24
mnasereandersson: in my experience anytime rabbitmq suffers .. anything .. you end up in that weird state and you have to restart the cloud21:25
eanderssonby pushing a fake message to the compute queues21:25
mnaserah gotcha21:25
eanderssonof course it might be something new with rmq21:25
eanderssonI know there is  a patch to add mandatory to nova21:25
eanderssonthe mandatory flag when publishing messages21:25
eanderssonSince if a message is lost you are stuck in buidling forever21:26
eanderssonwith no error21:26
mnasermy favorite :)21:27
*** sorrison has joined #openstack-nova21:27
eanderssonGonna wipe the rmq db and see if it goes away21:33
eanderssonIt's just odd that our synth tests are not hitting this21:34
*** martinkennelly has quit IRC21:34
eanderssonWe create 300 VMs per day and none end up in this state21:34
*** dpawlik has joined #openstack-nova21:38
*** dpawlik has quit IRC21:43
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add node owner pre-filter  https://review.opendev.org/69718721:49
mriedemdansmith: this is probably a blast from the past for you https://review.opendev.org/#/c/697122/21:54
mriedemmitaka era21:54
*** awalende has joined #openstack-nova22:00
*** nweinber has quit IRC22:01
*** awalende has quit IRC22:04
*** pcaruana has quit IRC22:06
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Implement cleanup_instance_network_on_host for neutron API  https://review.opendev.org/69716222:09
*** mriedem is now known as mriedem_away22:11
dansmithmriedem_away: I don't remember it, but I totes believe I did something awesome that someone else broke22:11
*** slaweq has quit IRC22:15
*** mriedem_away has quit IRC22:22
*** munimeha1 has quit IRC22:43
*** tkajinam has joined #openstack-nova22:56
*** rcernin has joined #openstack-nova22:57
sean-k-mooneyeandersson: the patch for the mandatory flag i think is more or less stalled i have not seen anything happen on the fron in a while23:00
eanderssonAwh that is too bad23:01
sean-k-mooneyit looks like all the oslo.messaging fixes are done https://review.opendev.org/#/q/status:merged+project:openstack/oslo.messaging+branch:master+topic:bp/transport-options23:02
sean-k-mooneybut i dont think anyone has gotten around to using that in nova yet23:02
eanderssonYea - and would probably not be easy to backport.23:02
eanderssonOr even possible.23:02
sean-k-mooneywell we need to do too things. frist start using it in master and second we need to figure out what the correct action is to take if we get an exception indicating it could not be delivered23:03
eanderssonI think I am going to add a log to nova just before it sends that notification to the computes.23:03
sean-k-mooneyfor example if we could not deliver a message to a compute queue should we disabel that compute node so we dont try to schdule to it agian?23:05
sean-k-mooneyshoudl we jsut retry?23:05
sean-k-mooneyi actully have no idea what the best path forward would be in that case but we kind of need to figure that out before we can fix the issue23:06
*** hamzy has quit IRC23:06
sean-k-mooneywe now have the feature that allows use to adress it however23:06
sean-k-mooneymelwitt: did you ever have time to talk to the oslo folks on how we could use this https://blueprints.launchpad.net/oslo.messaging/+spec/transport-options and specificly the mandaroty flag so we can adress the nova aspect of https://bugs.launchpad.net/oslo.messaging/+bug/166151023:11
openstackLaunchpad bug 1661510 in oslo.messaging "topic_send may loss messages if the queue not exists" [Medium,In progress] - Assigned to Gabriele Santomaggio (gsantomaggio)23:11
sean-k-mooneyi know i havent but it looks like all the patchs are in place on the oslo side23:12
*** tbachman has quit IRC23:16
*** slaweq has joined #openstack-nova23:25
melwittsean-k-mooney: I haven't talked to them bc like you said, their side is done. it's up to us (me) to figure out how to use it on the nova side and I haven't gotten a chance to dig in to it yet23:28
melwittI don't yet know where/how to pass it in the nova code23:28
sean-k-mooneyya i just asked on the bug if they could provdie an example23:29
*** ociuhandu has joined #openstack-nova23:30
sean-k-mooneyi know its something we shoudl be setting when we do a topic send which is i guess a call to a compute node primarly23:30
*** slaweq has quit IRC23:31
sean-k-mooneybut i dont know what we should do if we are not able to deliver it to the message queue23:31
*** ociuhandu has quit IRC23:36
*** dpawlik has joined #openstack-nova23:39
*** abaindur has joined #openstack-nova23:40
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies  https://review.opendev.org/64848023:40
*** dpawlik has quit IRC23:43
gmannjohnthetubaguy: this should be ready now. I was checking why project-admin and legacy admin can access the new system reader rule. which was correct because of old defaults(admin_api) are deprecated and still work. This make sure any old token will keep working for changed defaults also.23:44
*** abaindur has quit IRC23:45
gmannjohnthetubaguy:  once you are ok with this then it will complete the first set of change - https://review.opendev.org/64848023:45
*** ivve has quit IRC23:47
*** tbachman has joined #openstack-nova23:48
openstackgerritsean mooney proposed openstack/nova master: Block rebuild when NUMA topology changed  https://review.opendev.org/68795723:51
openstackgerritsean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/68986123:51
*** abaindur has joined #openstack-nova23:52
*** abaindur has joined #openstack-nova23:53
efriedhttps://bugs.launchpad.net/neutron/+bug/185501523:56
openstackLaunchpad bug 1855015 in OpenStack Compute (nova) "Intermittent fails since 11/23 with "Multiple possible networks found, use a Network ID to be more specific."" [Undecided,New]23:56
sean-k-mooneyhas that reappared23:56
sean-k-mooneythat is a tempset bug and or we have not confgiured tempet correctly23:57
eanderssonIf we can’t deliver to the queue I think we should just set to error or move to the next available compute23:58
sean-k-mooneyeandersson: set what to error?23:58
eanderssonThe instance23:58
sean-k-mooneythat would not be correct in all cases23:59
sean-k-mooneyif the call was to say the instace diagnostics endpoint23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!