| *** abaindur has quit IRC | 00:05 | |
| *** macz has quit IRC | 00:08 | |
| *** abaindur has joined #openstack-nova | 00:14 | |
| *** zhanglong has quit IRC | 00:14 | |
| *** abaindur has joined #openstack-nova | 00:14 | |
| *** zhanglong has joined #openstack-nova | 00:17 | |
| *** chenhaw has joined #openstack-nova | 00:39 | |
| *** chenhaw has quit IRC | 00:39 | |
| *** abaindur has quit IRC | 00:43 | |
| *** abaindur has joined #openstack-nova | 00:44 | |
| *** sapd1 has joined #openstack-nova | 00:54 | |
| *** brinzhang has joined #openstack-nova | 00:56 | |
| *** nanzha has joined #openstack-nova | 01:04 | |
| *** redrobot has quit IRC | 01:07 | |
| *** nanzha has quit IRC | 01:10 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** nanzha has joined #openstack-nova | 01:13 | |
| *** huaqiang has joined #openstack-nova | 01:14 | |
| *** slaweq has quit IRC | 01:15 | |
| *** mvkr has quit IRC | 01:18 | |
| *** gyee has quit IRC | 01:29 | |
| *** mdbooth has quit IRC | 01:30 | |
| *** ociuhandu has joined #openstack-nova | 01:31 | |
| *** mdbooth has joined #openstack-nova | 01:32 | |
| *** zhanglong has quit IRC | 01:33 | |
| *** ociuhandu has quit IRC | 01:36 | |
| *** ociuhandu has joined #openstack-nova | 01:44 | |
| *** ociuhandu has quit IRC | 01:48 | |
| *** ociuhandu has joined #openstack-nova | 01:49 | |
| *** ociuhandu has quit IRC | 01:57 | |
| *** factor has quit IRC | 02:03 | |
| *** ricolin has joined #openstack-nova | 02:04 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | 02:11 |
|---|---|---|
| ianw | with the drop python2 change @ https://review.opendev.org/#/c/687954/ ... it get that you got to switch at some point. but devstack doesn't default to python3, so this basically breaks the default case | 02:15 |
| ianw | i feel like it has been done in the wrong order | 02:16 |
| *** slaweq has quit IRC | 02:16 | |
| ianw | for example, https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/install-devstack doesn't work any more | 02:19 |
| *** igordc has quit IRC | 02:21 | |
| *** zhanglong has joined #openstack-nova | 02:25 | |
| openstackgerrit | Ian Wienand proposed openstack/nova master: Revert "Stop testing Python 2" https://review.opendev.org/694891 | 02:28 |
| *** brinzhang_ has joined #openstack-nova | 02:30 | |
| *** brinzhang has quit IRC | 02:33 | |
| *** zhanglong has quit IRC | 02:34 | |
| brinzhang_ | ianw: I met the same issue with you, an run many times, the devstack cannot up easily ... | 02:38 |
| *** jbernard_ has joined #openstack-nova | 02:48 | |
| sean-k-mooney | there are patches to change the default in devstack but we have to wait untill after m1 to change it | 02:52 |
| sean-k-mooney | devstack also has had support for python3 for years | 02:52 |
| sean-k-mooney | its trivial to set USE_PYTHON3=true | 02:52 |
| ianw | personally i don't see that as a good argument for breaking the defaults | 02:53 |
| sean-k-mooney | we have untill december to drop python 2 testing for non lib projects | 02:54 |
| sean-k-mooney | the only functional change in that patch is the lack of installing contextlib2 | 02:55 |
| sean-k-mooney | i guess the requirement for py36+ as well | 02:56 |
| *** ociuhandu has joined #openstack-nova | 02:56 | |
| ianw | yes, and that's the sticking point for mine | 02:56 |
| sean-k-mooney | leaving it work until december 12th? | 02:57 |
| sean-k-mooney | the Ussuri release is not expected to have python 2 support in general | 02:57 |
| brinzhang_ | Other project can do this until december 12th? it's not only exist in nova | 02:57 |
| ianw | brinzhang_: well, yes, but nova is probably the biggest target :) | 02:58 |
| ianw | sean-k-mooney: my suggestion would be to have devstacking using USE_PYTHON3 by default, then switch it | 02:58 |
| sean-k-mooney | nova is proably the most visable | 02:58 |
| ianw | switching to USE_PYTHON3 by default and waiting, say, a week, should probably give any issues time to shake out | 02:59 |
| sean-k-mooney | you mean merge https://review.opendev.org/#/c/649097/ | 02:59 |
| ianw | sean-k-mooney: yes, well work out the issues related to that and get it in | 03:00 |
| ianw | as you say, many (most) people won't even notice the default changing, probably | 03:00 |
| brinzhang_ | I agree | 03:00 |
| *** ociuhandu has quit IRC | 03:01 | |
| sean-k-mooney | i know most deveolpoer i have talked to moved there default a release or two ago | 03:01 |
| sean-k-mooney | not all but alot of devstack user have been using python3 since rocky or stien | 03:02 |
| *** ociuhandu has joined #openstack-nova | 03:03 | |
| brinzhang_ | I think there are problem need to consider, about the base environment. In older centos/ubuntu it's dafault python is py27 | 03:03 |
| ianw | sean-k-mooney: i think there's probably a long tail of gate jobs that people haven't converted | 03:03 |
| sean-k-mooney | yep proably | 03:04 |
| sean-k-mooney | we will find out shortly if they start exploding. | 03:04 |
| sean-k-mooney | i think there was a seperate patch up to swap the defualt in devstack gate and anoutther in zuul devstack base job but i dont know what the state of those are | 03:05 |
| brinzhang_ | at least, because of this change I have not build the devstack env now, it's terrible .. | 03:05 |
| sean-k-mooney | brinzhang_: unstack and stack with python3 enabled | 03:05 |
| *** abaindur has quit IRC | 03:05 | |
| *** abaindur has joined #openstack-nova | 03:06 | |
| sean-k-mooney | we proably could have watied to merge it for another week or too | 03:06 |
| sean-k-mooney | but we do need to complete this this cycle | 03:07 |
| *** ociuhandu has quit IRC | 03:07 | |
| sean-k-mooney | and as far as i am aware this is inline with the tc plan for the dropping of python 2 support | 03:07 |
| ianw | not going to argue about the overall dropping of it at all. just it seems a gentler approach to have devstack defaulting to python3, then switch projects to stop supporting python2 | 03:08 |
| ianw | i mean, realistically, with nova refusing to install on py2 it's not even a configuration option in devstack after that point | 03:09 |
| *** ociuhandu has joined #openstack-nova | 03:10 | |
| sean-k-mooney | that is fair. althoguh all project were ment to have gate jobs running on python 3 last cycle so all project shoudl be able to at least run on python 3 | 03:10 |
| sean-k-mooney | also not all porject or jobs deploy nova | 03:10 |
| sean-k-mooney | alot do but not all | 03:10 |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** mvkr has joined #openstack-nova | 03:12 | |
| sean-k-mooney | projects like keysone, swift and glance wont need nova in ther gate jobs in many cases. although i suspect in many cases they get it by default | 03:12 |
| sean-k-mooney | anyway night o/ we proably coudl revert it temporailly but i would personally prefer to fix the broken jobs | 03:13 |
| *** slaweq has quit IRC | 03:16 | |
| *** ociuhandu has quit IRC | 03:18 | |
| brinzhang_ | sean-k-mooney: can you provide some guide how to "unstack and stack with python3 enabled"? | 03:20 |
| *** abaindur has quit IRC | 03:24 | |
| *** TxGirlGeek has quit IRC | 03:25 | |
| *** ociuhandu has joined #openstack-nova | 03:25 | |
| brinzhang_ | sean-k-mooney: I have encountered this problem several times, excute "python -m pip install --upgrade pip" and also raised the same issue. http://paste.openstack.org/show/786318/ | 03:27 |
| *** ociuhandu has quit IRC | 03:30 | |
| *** ociuhandu has joined #openstack-nova | 03:32 | |
| *** ociuhandu has quit IRC | 03:36 | |
| ianw | brinzhang_: you want to set USE_PYTHON3 in your devstack localrc | 03:44 |
| *** bhagyashris has joined #openstack-nova | 04:02 | |
| *** macz has joined #openstack-nova | 04:04 | |
| openstackgerrit | Dong Ma proposed openstack/nova master: ZVM: Implement update_provider_tree https://review.opendev.org/694897 | 04:05 |
| *** ociuhandu has joined #openstack-nova | 04:06 | |
| *** jbernard_ has quit IRC | 04:06 | |
| *** macz has quit IRC | 04:09 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** ociuhandu has quit IRC | 04:14 | |
| *** slaweq has quit IRC | 04:15 | |
| *** brinzhang has joined #openstack-nova | 04:27 | |
| *** brinzhang_ has quit IRC | 04:30 | |
| *** abaindur has joined #openstack-nova | 04:32 | |
| *** mkrai has joined #openstack-nova | 04:35 | |
| openstackgerrit | Merged openstack/nova stable/pike: Functional reproduce for bug 1852207 https://review.opendev.org/693817 | 04:41 |
| openstack | bug 1852207 in OpenStack Compute (nova) pike "reschedule ignores requested availability zone" [Medium,In progress] https://launchpad.net/bugs/1852207 - Assigned to Balazs Gibizer (balazs-gibizer) | 04:41 |
| *** brinzhang_ has joined #openstack-nova | 04:42 | |
| *** jmlowe has quit IRC | 04:42 | |
| *** brinzhang has quit IRC | 04:44 | |
| *** brinzhang has joined #openstack-nova | 04:46 | |
| *** brinzhang_ has quit IRC | 04:49 | |
| *** bhagyashris has quit IRC | 04:51 | |
| *** ratailor has joined #openstack-nova | 04:53 | |
| *** ociuhandu has joined #openstack-nova | 05:18 | |
| *** nanzha has quit IRC | 05:18 | |
| *** nanzha has joined #openstack-nova | 05:19 | |
| *** brinzhang_ has joined #openstack-nova | 05:20 | |
| *** abaindur has quit IRC | 05:22 | |
| *** ociuhandu has quit IRC | 05:22 | |
| *** abaindur has joined #openstack-nova | 05:23 | |
| *** brinzhang has quit IRC | 05:23 | |
| *** zhanglong has joined #openstack-nova | 05:24 | |
| *** elod is now known as elod_off | 05:28 | |
| *** ociuhandu has joined #openstack-nova | 05:30 | |
| *** brinzhang has joined #openstack-nova | 05:33 | |
| *** ociuhandu has quit IRC | 05:35 | |
| *** brinzhang_ has quit IRC | 05:36 | |
| brinzhang | ianw: thanks, I will try :) | 05:37 |
| *** bhagyashris has joined #openstack-nova | 05:38 | |
| *** links has joined #openstack-nova | 05:40 | |
| *** pcaruana has joined #openstack-nova | 05:43 | |
| *** lennyb has joined #openstack-nova | 05:54 | |
| *** Luzi has joined #openstack-nova | 06:00 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 06:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Refactor to extract Placement helper functions for functional tests. https://review.opendev.org/694906 | 06:05 |
| *** openstackstatus has joined #openstack-nova | 06:09 | |
| *** ChanServ sets mode: +v openstackstatus | 06:09 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** slaweq has quit IRC | 06:15 | |
| *** lpetrut has quit IRC | 06:25 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/694911 | 06:43 |
| *** abaindur has quit IRC | 06:44 | |
| *** abaindur has joined #openstack-nova | 06:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | 06:51 |
| *** pcaruana has quit IRC | 06:56 | |
| *** rcernin has quit IRC | 06:58 | |
| *** huaqiang has quit IRC | 07:00 | |
| *** dpawlik has joined #openstack-nova | 07:03 | |
| *** brinzhang_ has joined #openstack-nova | 07:03 | |
| *** nanzha has quit IRC | 07:04 | |
| *** brinzhang_ has quit IRC | 07:04 | |
| *** nanzha has joined #openstack-nova | 07:04 | |
| *** brinzhang_ has joined #openstack-nova | 07:04 | |
| *** brinzhang_ has quit IRC | 07:04 | |
| *** brinzhang has quit IRC | 07:05 | |
| *** udesale has joined #openstack-nova | 07:06 | |
| *** xek has quit IRC | 07:32 | |
| *** brinzhang has joined #openstack-nova | 07:41 | |
| *** dpawlik has quit IRC | 07:43 | |
| *** dpawlik has joined #openstack-nova | 07:44 | |
| *** ccamacho has joined #openstack-nova | 07:48 | |
| *** brinzhang_ has joined #openstack-nova | 07:49 | |
| *** brinzhang has quit IRC | 07:51 | |
| *** damien_r has joined #openstack-nova | 07:56 | |
| *** damien_r has quit IRC | 07:57 | |
| *** damien_r has joined #openstack-nova | 07:57 | |
| *** slaweq has joined #openstack-nova | 08:00 | |
| *** ivve has joined #openstack-nova | 08:17 | |
| *** tesseract has joined #openstack-nova | 08:18 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 08:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 08:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 08:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 08:23 |
| openstackgerrit | Merged openstack/nova stable/pike: doc: fix and clarify --block-device usage in user docs https://review.opendev.org/694450 | 08:35 |
| *** pcaruana has joined #openstack-nova | 08:36 | |
| *** abaindur has quit IRC | 08:38 | |
| bauzas | good morning Nova | 08:42 |
| *** luksky has joined #openstack-nova | 08:42 | |
| gibi | bauzas: good morning | 08:44 |
| *** ralonsoh has joined #openstack-nova | 08:50 | |
| brinzhang_ | Hi gibi, good morning | 08:51 |
| gibi | brinzhang_: o/ | 08:52 |
| brinzhang_ | gibi: Can you review the flavor explosion patach, and sean-k-mooney leave some comments, and we have the different opinion in the model design | 08:53 |
| gibi | brinzhang_: it is on my list to review | 08:53 |
| brinzhang_ | gibi: yeah, thanks. | 08:54 |
| *** priteau has joined #openstack-nova | 08:55 | |
| *** tkajinam has quit IRC | 08:56 | |
| bauzas | brinzhang_: can you ping me again the spec URL ? | 08:57 |
| bauzas | I'll start reviewing some changes today hopefully, I'm late with this :( | 08:57 |
| *** FlorianFa has joined #openstack-nova | 08:58 | |
| bauzas | gibi: about the placement audit command, it'd be awesome if you could test again with the latest revision | 08:59 |
| bauzas | https://review.opendev.org/#/c/670112/ | 08:59 |
| bauzas | I fixed both issues | 08:59 |
| gibi | bauzas: on my list too :) | 08:59 |
| bauzas | gibi: FWIW, I'm looking at how to fix the placementfixture issue | 08:59 |
| bauzas | gibi: <3 | 08:59 |
| *** martinkennelly has joined #openstack-nova | 08:59 | |
| brinzhang_ | bauzas: https://review.opendev.org/#/c/663563/ | 09:00 |
| *** ociuhandu has joined #openstack-nova | 09:00 | |
| bauzas | brinzhang_: thanks | 09:01 |
| *** brinzhang has joined #openstack-nova | 09:02 | |
| *** Luzi has quit IRC | 09:04 | |
| *** brinzhang_ has quit IRC | 09:05 | |
| *** rpittau|afk is now known as rpittau | 09:08 | |
| *** Luzi has joined #openstack-nova | 09:19 | |
| *** Luzi has quit IRC | 09:21 | |
| *** xek has joined #openstack-nova | 09:26 | |
| *** ratailor_ has joined #openstack-nova | 09:30 | |
| *** ratailor has quit IRC | 09:32 | |
| *** derekh has joined #openstack-nova | 09:38 | |
| *** martinkennelly has quit IRC | 09:42 | |
| *** ociuhandu has quit IRC | 09:43 | |
| *** zhanglong has quit IRC | 10:03 | |
| *** martinkennelly has joined #openstack-nova | 10:07 | |
| *** brinzhang_ has joined #openstack-nova | 10:29 | |
| *** brinzhang_ has quit IRC | 10:31 | |
| *** ociuhandu has joined #openstack-nova | 10:31 | |
| *** brinzhang_ has joined #openstack-nova | 10:32 | |
| *** brinzhang has quit IRC | 10:32 | |
| *** brinzhang has joined #openstack-nova | 10:33 | |
| *** tetsuro has quit IRC | 10:36 | |
| *** brinzhang_ has quit IRC | 10:37 | |
| *** tetsuro has joined #openstack-nova | 10:37 | |
| *** lpetrut has joined #openstack-nova | 10:40 | |
| *** dpawlik has quit IRC | 10:45 | |
| *** brinzhang_ has joined #openstack-nova | 10:51 | |
| *** mkrai has quit IRC | 10:52 | |
| *** mkrai_ has joined #openstack-nova | 10:52 | |
| *** brinzhang has quit IRC | 10:53 | |
| *** brinzhang has joined #openstack-nova | 10:54 | |
| * bauzas goes AWOL for gym | 10:55 | |
| *** mkrai_ has quit IRC | 10:56 | |
| *** mkrai__ has joined #openstack-nova | 10:56 | |
| *** brinzhang_ has quit IRC | 10:56 | |
| *** ratailor_ has quit IRC | 10:58 | |
| *** ratailor has joined #openstack-nova | 10:59 | |
| *** mkrai__ has quit IRC | 11:00 | |
| *** brinzhang_ has joined #openstack-nova | 11:07 | |
| *** brinzhang has quit IRC | 11:11 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently https://review.opendev.org/689180 | 11:16 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181 | 11:16 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182 | 11:16 |
| *** udesale has quit IRC | 11:17 | |
| *** dpawlik has joined #openstack-nova | 11:21 | |
| *** brinzhang has joined #openstack-nova | 11:21 | |
| gibi | sean-k-mooney, bauzas, brinzhang_, dansmith, efried_pto: I left comments in the flavor explosion spec https://review.opendev.org/#/c/663563/ . I tried to summarize Dan's and Eric's problems behind the -2s and my answers to those the problems. Let's see if this helps or not. | 11:22 |
| *** brinzhang has quit IRC | 11:22 | |
| *** brinzhang has joined #openstack-nova | 11:23 | |
| *** brinzhang_ has quit IRC | 11:24 | |
| *** dpawlik has quit IRC | 11:26 | |
| gibi | stable-cores: it seems that nova-live-migration job is sad on stable/pike I repeatedly get error like https://zuul.opendev.org/t/openstack/build/0a199eeccc334b98a2eaf67998eef8b5/log/job-output.txt#5821 | 11:27 |
| *** awalende has joined #openstack-nova | 11:28 | |
| * lyarwood clicks | 11:28 | |
| lyarwood | W: The repository 'http://mirror.dfw.rax.opendev.org/ubuntu-cloud-archive xenial-updates/ocata Release' is not signed. | 11:29 |
| lyarwood | eh, why are we using that on stable/pike? | 11:29 |
| *** dpawlik has joined #openstack-nova | 11:30 | |
| gibi | lyarwood: that is a good question | 11:30 |
| lyarwood | I forget where that's all defined tbh | 11:31 |
| gibi | it seems that job uses the legacy-ubuntu-xenial-2-node nodeset | 11:35 |
| gibi | that explains xenial-updates to me | 11:36 |
| gibi | https://github.com/openstack/nova/blob/9f2d653b4050dbff859c656144c1564ea7c6fa60/.zuul.yaml#L66 | 11:37 |
| gibi | https://github.com/openstack/nova/blob/9f2d653b4050dbff859c656144c1564ea7c6fa60/.zuul.yaml#L27 | 11:37 |
| *** tbachman has quit IRC | 11:38 | |
| *** dtantsur|afk is now known as dtantsur | 11:49 | |
| *** ociuhandu has quit IRC | 11:52 | |
| *** ociuhandu has joined #openstack-nova | 11:53 | |
| *** ociuhandu has quit IRC | 11:53 | |
| *** ociuhandu has joined #openstack-nova | 11:54 | |
| *** ociuhandu has quit IRC | 11:59 | |
| *** ratailor has quit IRC | 12:15 | |
| *** mgariepy has joined #openstack-nova | 12:17 | |
| *** dpawlik has quit IRC | 12:28 | |
| *** brinzhang_ has joined #openstack-nova | 12:31 | |
| *** dpawlik has joined #openstack-nova | 12:31 | |
| *** brinzhang_ has quit IRC | 12:32 | |
| *** brinzhang_ has joined #openstack-nova | 12:32 | |
| *** brinzhang_ has quit IRC | 12:33 | |
| *** brinzhang_ has joined #openstack-nova | 12:34 | |
| *** brinzhang has quit IRC | 12:34 | |
| *** brinzhang_ has quit IRC | 12:34 | |
| *** icey has quit IRC | 12:34 | |
| *** dave-mccowan has joined #openstack-nova | 12:34 | |
| *** ociuhandu has joined #openstack-nova | 12:36 | |
| *** udesale has joined #openstack-nova | 12:58 | |
| *** ociuhandu has quit IRC | 13:00 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063 | 13:00 |
| *** ociuhandu has joined #openstack-nova | 13:01 | |
| *** ociuhandu has quit IRC | 13:17 | |
| *** ociuhandu has joined #openstack-nova | 13:18 | |
| *** hamzy has quit IRC | 13:19 | |
| *** ociuhandu_ has joined #openstack-nova | 13:22 | |
| *** davee__ has joined #openstack-nova | 13:22 | |
| *** awalende has quit IRC | 13:26 | |
| *** ociuhandu has quit IRC | 13:26 | |
| *** tbachman has joined #openstack-nova | 13:27 | |
| *** efried_pto is now known as efried | 13:28 | |
| *** corvus has joined #openstack-nova | 13:31 | |
| lyarwood | mdbooth: https://review.opendev.org/#/c/693537/ - apologies, thought I had added you to this a while ago, would you mind taking a look later today? Not a complete fix but it should avoid issues in some situations. | 13:32 |
| *** liuyulong has joined #openstack-nova | 13:35 | |
| *** bhagyashris has quit IRC | 13:37 | |
| corvus | efried, stephenfin: can you take a look at https://review.opendev.org/694891 asap please? | 13:39 |
| efried | corvus: saw that go by. So you're saying "devstack isn't ready for you yet"? | 13:40 |
| corvus | efried: yeah. if someone downloads devstack and runs stack.sh, it'll break. | 13:41 |
| sean-k-mooney | there is a patch up to change the defualt value of devstack | 13:41 |
| *** eharney has quit IRC | 13:41 | |
| *** awalende has joined #openstack-nova | 13:41 | |
| sean-k-mooney | corvus: sure so why dont we just merge the other patch | 13:41 |
| corvus | sean-k-mooney: https://review.opendev.org/649097 has set it to WIP | 13:42 |
| sean-k-mooney | yes because it was depending on a change that has now merged | 13:42 |
| *** awalende has quit IRC | 13:42 | |
| *** awalende has joined #openstack-nova | 13:42 | |
| *** mriedem has joined #openstack-nova | 13:42 | |
| kashyap | Hey, folks. Now is the time to speak up, if you have comments on this: http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010907.html ("On next minimum libvirt / QEMU versions for "V" release") | 13:42 |
| stephenfin | corvus: Yeah, I was waiting on mriedem to appear and decide what to do | 13:43 |
| stephenfin | as the owner of https://review.opendev.org/#/c/649097/1 | 13:43 |
| stephenfin | mriedem: for context: <corvus> efried, stephenfin: can you take a look at https://review.opendev.org/694891 asap please? | 13:43 |
| corvus | ftr, you don't need to set wip to avoid something with a depends-on being merged. zuul does that for you. | 13:43 |
| sean-k-mooney | i know i think he might have been looking at the greneade failure too | 13:44 |
| mriedem | how are changes in the nova jobs breaking everything else that's using devstack? | 13:44 |
| sean-k-mooney | he set it to wip because he tought it might need to be rebased on https://review.opendev.org/#/c/688799/ | 13:44 |
| corvus | either way (whether we merge the revert or the default change), we should get USE_PYTHON3 out of the .zuul.yaml in nova -- that's the red flag here. basically, if something is required for devstack to work, it should be in the devstack repo instead of nova; we should only set individual job config tweaks in nova's config. | 13:45 |
| sean-k-mooney | mriedem: the chagne prevents nova being installed in python 2 | 13:45 |
| corvus | yeah, the change simultaneously stopped all py2 testing on nova, and broke installing nova on py2. | 13:45 |
| efried | corvus, stephenfin, sean-k-mooney: I +2ed; now just convince mriedem... | 13:45 |
| sean-k-mooney | corvus: USE_PYTHON3=true is not the problem | 13:46 |
| mriedem | these aren't the only jobs setting the USE_PYTHON3=True flag outside of devstack | 13:46 |
| mriedem | neutron has at least one as well | 13:46 |
| mriedem | sean-k-mooney: why can't it install on py2? because of dependencies that were removed? | 13:47 |
| sean-k-mooney | the reson other jobs broke is python-requires = >=3.6 | 13:47 |
| *** mdbooth has quit IRC | 13:47 | |
| sean-k-mooney | in setup.cfg | 13:47 |
| mriedem | i'd like to know if we (nova) can switch our jobs to use py3 meanwhile leaving in whatever is needed to install nova on py2 until other jobs move over | 13:47 |
| mriedem | so let's revert that | 13:47 |
| sean-k-mooney | if we just remove that it will allow nova to be installed on python 2 | 13:47 |
| efried | But doesn't "stop testing py2" leave us exposed there? | 13:47 |
| mriedem | with a big ass TODO about dropping that when devstack has USE_PYTHON3=True by default | 13:48 |
| * mriedem bites tongue | 13:48 | |
| mriedem | either we move, or we don't, i don't really care about dropping py2 support, but that's what the TC has been hammering on for yeras | 13:48 |
| mriedem | *years | 13:48 |
| mriedem | so then we do and things break, and omfg | 13:48 |
| slaweq | hi | 13:48 |
| sean-k-mooney | https://review.opendev.org/#/c/694891/1/setup.cfg@9 | 13:48 |
| mriedem | so let's just do the minimum possible to get things working which is revert the setup.cfg change yeah | 13:48 |
| mriedem | ? | 13:48 |
| sean-k-mooney | nova can move | 13:48 |
| slaweq | I just found out that patch https://review.opendev.org/#/c/687954/ which You are now talking about broke also neutron-grenade job | 13:49 |
| *** mdbooth has joined #openstack-nova | 13:49 | |
| sean-k-mooney | if we remove that 1 line other can install it on python2 | 13:49 |
| mriedem | slaweq: yeah we're just talking about what to revert | 13:49 |
| slaweq | this job is py2 job and is running in many projects | 13:49 |
| slaweq | mriedem: yes, I see. I just wanted to mention about this job which I just noticed that is broken | 13:50 |
| sean-k-mooney | so in anycase by december 12 all project are ment to chagne to python 3 and drop python 2 testing | 13:50 |
| sean-k-mooney | * all non lib projects | 13:51 |
| *** ociuhandu_ has quit IRC | 13:52 | |
| mriedem | i've left comments on the change, | 13:53 |
| *** ociuhandu has joined #openstack-nova | 13:53 | |
| mriedem | this is a clusterf*ck management-wise from my pov, | 13:53 |
| mriedem | so do whatever | 13:53 |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000 | 13:53 |
| mriedem | let the tc work on getting devstack to use py3 by default | 13:53 |
| corvus | mriedem: if nova runs all devstack jobs with USE_PYTHON3 set to true, then the same thing can happen again | 13:54 |
| *** tosky has joined #openstack-nova | 13:54 | |
| corvus | if you don't want to revert that whole change, can you at least keep one py2 job running as long as py2 is the devstack default? | 13:55 |
| mriedem | the same thing == not being able to install nova with py2, that's wrong, right? as long as we don't screw up setup.cfg, | 13:55 |
| mriedem | tempest tests could break if nova lands some code that doesn't work with py2, i get that | 13:56 |
| mriedem | but frankly i don't see that happening real soon, and if it does it can be fixed, | 13:56 |
| mriedem | and it's also motivation to get downstream projects to move to py3 as well | 13:56 |
| corvus | mriedem: right, i'm saying it's a testing hole. someone could introduce a change that doesn't work with py2. | 13:56 |
| mriedem | which is what i thought everyone wanted in ussuri as a major community goal | 13:56 |
| *** tkajinam has joined #openstack-nova | 13:56 | |
| *** tkajinam has quit IRC | 13:56 | |
| corvus | my only goal here is that "./stack.sh" always work for new users. | 13:56 |
| *** tkajinam has joined #openstack-nova | 13:57 | |
| mriedem | "always works" is pretty subjective | 13:57 |
| mriedem | bugs are bugs | 13:57 |
| mriedem | i agree that if nova doesn't install it's a problem | 13:58 |
| tosky | mriedem: please approve the revert - all the other projects are broken because nova does not start | 13:58 |
| mriedem | so revert the setup.cfg change | 13:58 |
| mriedem | some other core can approve if they care | 13:58 |
| mriedem | i'd like the community to shit or get off this py3 pot | 13:58 |
| corvus | mriedem: yeah, but there's no testing of nova in the default devstack configuration. | 13:58 |
| *** ociuhandu has quit IRC | 13:58 | |
| mriedem | christ we're talking about py3.8 gating in the tc threads these days already | 13:58 |
| mriedem | do whatever stephenfin and efried want | 13:59 |
| tosky | mriedem: I'm not sure why you are saying or implying that the community does not want to move - I think we want to move, just without blocking the work | 14:00 |
| mriedem | i've already said i'm good with fixing setup.cfg so nova can install again, | 14:02 |
| *** luksky has quit IRC | 14:02 | |
| *** ociuhandu has joined #openstack-nova | 14:02 | |
| mriedem | i don't think we should be gating on py2 though and if something slips through that's a py2 bug then we fix it | 14:02 |
| mriedem | otherwise just let the qa/tc/infra whoever team that cares about this manage it directly imo | 14:02 |
| mriedem | since the projects obviously can't orchestrate this themselves | 14:03 |
| tosky | fine, but then probably you also need to revert the requirment change | 14:03 |
| tosky | not just setup.cfg | 14:03 |
| mriedem | do whatever you guys want | 14:03 |
| stephenfin | So someone needs to go first, and I thought it could be us since we're a service, not a library, but obviously that isn't the case | 14:04 |
| stephenfin | What's the hold up with DevStack switching to Py3 first though? Can't we just merge that? | 14:04 |
| tosky | I don't know | 14:05 |
| mriedem | someone has to care | 14:05 |
| corvus | please have at least one test on nova that runs devstack in the default configuration. otherwise, there is a very high risk that changes will merge to nova which will break it. | 14:05 |
| stephenfin | okay, makes sense. So can I go switch DevStack to use Python 3 by default | 14:05 |
| corvus | stephenfin: https://review.opendev.org/649097 is relevant | 14:06 |
| sean-k-mooney | yes so it look lke we need to merge those 3 patches | 14:07 |
| efried | sean-k-mooney: sorry, what's the third? | 14:07 |
| efried | oh, the predecessor of --^ ? | 14:07 |
| corvus | mriedem: do you want to remove the wip setting on that change? | 14:07 |
| sean-k-mooney | https://review.opendev.org/#/c/688799/5 https://review.opendev.org/#/c/649097/10 and https://review.opendev.org/#/c/649278/5 | 14:07 |
| *** ociuhandu has quit IRC | 14:08 | |
| sean-k-mooney | mriedem's change should be the last of the 3 | 14:08 |
| sean-k-mooney | the other two can merge in any order i think | 14:08 |
| sean-k-mooney | https://review.opendev.org/#/c/688799/5 already has 1 +2 | 14:09 |
| stephenfin | sean-k-mooney: Now that CentOS 8 is out, why wouldn't you just use that? | 14:10 |
| stephenfin | IMO if we're switching to Python 3-only we should be testing on Python 3-supporting distros, namely CentOS 8 | 14:10 |
| tosky | stephenfin: we were discussing about CentOS 8/devstack support with frickler earlier today - it's not there yet | 14:10 |
| sean-k-mooney | you could but devstack may not work on it | 14:10 |
| sean-k-mooney | im pretty sure you will need eple or ius repos to make it work | 14:11 |
| stephenfin | tosky: can we disable CentOS-based jobs so? | 14:11 |
| tosky | stephenfin: there is a review for it | 14:11 |
| sean-k-mooney | stephenfin: we can run python 3 on centos 7 | 14:11 |
| sean-k-mooney | but we need pyton36 form eple or ius | 14:12 |
| tosky | stephenfin: https://review.opendev.org/#/c/694967/ | 14:12 |
| stephenfin | sean-k-mooney: we can, but we can also do it on CentOS 8. Both involve some work, and it seems obvious to me that the effort should spent on the latter option | 14:12 |
| kashyap | (On RPM-based distros, DevStack generally "works for me" on Fedora. Never tried on CentOS, though.) | 14:12 |
| mriedem | corvus: removing the WIP doesn't make it work, as you can see from the job results | 14:13 |
| sean-k-mooney | stephenfin: we can do both | 14:13 |
| kashyap | stephenfin: Just chiming in randomly, why can't one just stick to a Fedora-only job? (IIRC, there was one; need to check if it's still maintained, or is rotting) | 14:13 |
| mriedem | as sean pointed out there are a series of changes so someone has to align that stuff | 14:13 |
| mriedem | the one under my WIP has been sitting since april | 14:13 |
| mriedem | so clearly not a community priority | 14:13 |
| mriedem | kashyap: as far as i can recall the fedora jobs in openstack have been a garbage dump since forever | 14:14 |
| mriedem | i don't know of any projects in openstack that gate on fedora, maybe tripleo or some deployment projects | 14:14 |
| kashyap | mriedem: Right, need bodies. | 14:14 |
| stephenfin | kashyap: Fedora is too much of a moving target for CI, I'm afraid | 14:14 |
| tosky | mriedem: maybe devstack jobs - tripleo was able to have f28 jobs | 14:14 |
| sean-k-mooney | mriedem: well that because fedora and ci is basically an anti pattern. it chagne too much and keeps breaking | 14:14 |
| stephenfin | Ask sean-k-mooney - they know all about it | 14:14 |
| kashyap | The only one I know who worked on Fedora jobs was/is ianw | 14:14 |
| stephenfin | jinx :D | 14:14 |
| stephenfin | anyway, that's a different discussion | 14:15 |
| *** nweinber has joined #openstack-nova | 14:15 | |
| kashyap | Yeah, agreed on Fedora being a "moving target"; if CentOS-8 is more manageable, by all means. | 14:16 |
| kashyap | sean-k-mooney: "Anti-pattern" for a cloud software probably; libvirt and QEMU upstream test on Fedora jobs just fine. | 14:16 |
| sean-k-mooney | kashyap: i think the main issue with centos 8 will be a lack of packages | 14:16 |
| sean-k-mooney | kashyap: libvirt and qemu are too of the main issues | 14:16 |
| sean-k-mooney | we hit temproy brakages or chagnes in the output of things like qemu-img | 14:17 |
| kashyap | (Also, bear in mind -- most / all upstream kernel / Virt issues are fixed on Fedora first -- as most kernel / Virt upstream devs use it.) | 14:17 |
| sean-k-mooney | ya the kernel and gcc kept causing issues for compiling dpdk and ovs too | 14:18 |
| sean-k-mooney | anyway thats a different topic | 14:18 |
| stephenfin | corvus, tosky: Can we combine https://review.opendev.org/#/c/649097/ and https://review.opendev.org/#/c/694967/ and just merge that? | 14:18 |
| kashyap | Anyway, this is all largely about having enough warm bodies that are incentivized to care. | 14:18 |
| stephenfin | So switch DevStack to Python 3 and drop the CentOS 7 job, which will no longer work | 14:19 |
| mriedem | stephenfin: those non-ubuntu jobs aren't voting anyway so they don't matter | 14:19 |
| stephenfin | True | 14:19 |
| tosky | stephenfin: maybe, I don't know; I'd wait for gmann too, even though I have some objections to his comment in https://review.opendev.org/#/c/649097/ as I wrote there | 14:20 |
| mriedem | if a job isn't voting it's not enough of a priority for people to care about it | 14:20 |
| stephenfin | I don't want to inflict pain on people, but as mriedem notes someone needs to start driving this and if I'm doing that from nova's side, then a straight up revert is what I want | 14:20 |
| stephenfin | It sounds like we'd be kicking a can down the road. I'd rather help people pick up the pieces than do that | 14:20 |
| sean-k-mooney | mind if i just rebase the 3 devstack patch into the right order | 14:21 |
| stephenfin | sean-k-mooney: before you do, what are the three? | 14:21 |
| tosky | stephenfin: it's too big right now - if you don't want to fully revert https://review.opendev.org/#/c/694891/, are you going to accept at least a revert of setup.cfg (the condition) and *requirements.txt ? | 14:21 |
| * mriedem looks at the ironic, ceph and lvm jobs that we run on nova changes being non-voting for a long time | 14:21 | |
| sean-k-mooney | Handle uninstalled python3 -> Handle localrc early enough in stackrc -> Change USE_PYTHON3=True by default | 14:21 |
| sean-k-mooney | that fixes centos 7 then enable python 3 early then set it to the defaul | 14:22 |
| stephenfin | sean-k-mooney: again, I don't think we need "Handle uninstalled python3". Let's use CentOS 8 instead | 14:22 |
| sean-k-mooney | we can do both | 14:22 |
| stephenfin | we can, but it doesn't mean we should | 14:22 |
| stephenfin | tosky: We can, but that means we'll no longer test against Python 2.7 | 14:23 |
| sean-k-mooney | if we want to drop all centos testing until centos 7 works we could but why when its a trivial patch | 14:23 |
| stephenfin | so there's an implicit countdown before nova on py2.7 breaks anyway | 14:23 |
| tosky | stephenfin: no, not directly - but it is really likely that you are going to break py2 with a commit in the next 3 weeks? | 14:23 |
| stephenfin | no, it's not, in fairness | 14:24 |
| stephenfin | sean-k-mooney: for the reasons ianw has pointed out: no one has actually tested that it works | 14:24 |
| stephenfin | and it's not reflective of real-world use cases | 14:24 |
| stephenfin | better to disable the tests and focus on switching to centos8, imo | 14:25 |
| *** awalende has quit IRC | 14:25 | |
| sean-k-mooney | i used to used centos 7 with python 3 as my dev env untill like july | 14:25 |
| mriedem | as i've said earlier, i would put the bare minimum effort into making nova work with py27, i.e. let it install but after that all bets are off | 14:25 |
| mriedem | if it doesn't work with py27 it's a bug until we can really say we no longer care | 14:25 |
| *** awalende has joined #openstack-nova | 14:26 | |
| stephenfin | mriedem: I also like that approach | 14:26 |
| sean-k-mooney | ya same | 14:26 |
| sean-k-mooney | which means remove 1 line in setup.cfg | 14:26 |
| stephenfin | tosky: yeah, if you want to just revert the setup.cfg changes, I'll be happy with that | 14:26 |
| mriedem | stephenfin: and likely the requirements stuff | 14:26 |
| stephenfin | also that, yes | 14:26 |
| sean-k-mooney | the requirement chagne for contextlib2 is only half needed | 14:26 |
| mriedem | there should probably be a TODO in the setup.cfg line saying to remove python-requires once devstack uses py3 by default | 14:26 |
| sean-k-mooney | the way devstack works it will get installed by other projects but sure | 14:27 |
| stephenfin | and that, yup yup yup | 14:27 |
| mriedem | sean-k-mooney: but kolla! | 14:27 |
| mriedem | osa, etc | 14:27 |
| mriedem | anything running nova in a container or venv | 14:27 |
| tosky | stephenfin: but don't you think that also reverting requirements.txt is needed? There is at least one condition which affects py2, and that may break as well | 14:27 |
| mriedem | tosky: we just said yes | 14:27 |
| tosky | mriedem: sorry, missed in the stream | 14:27 |
| stephenfin | tosky: it is. I missed that. Fortunately mriedem caught it (y) | 14:27 |
| sean-k-mooney | kolla is python3 by default alredy but yes fair point | 14:28 |
| mriedem | stephenfin: technically tosky brought up the requirements thing first so credit goes to him for that | 14:30 |
| KeithMnemonic | lyarwood do you think you may have time to review this patch this week? https://review.opendev.org/683008 | 14:30 |
| efried | so is someone going to modify ianw's patch or propose a new one? Probably the latter is better. | 14:32 |
| sean-k-mooney | maybe we should send an update too the list too whith what our plan is | 14:33 |
| openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | 14:34 |
| tosky | let's see if it works ^^ | 14:34 |
| corvus | tosky: test results will not be helpful here -- there is no testing of py27 | 14:34 |
| tosky | corvus: one monent | 14:35 |
| sean-k-mooney | i dont think we should add the py 27 calssifier back | 14:35 |
| sean-k-mooney | but otherwise it looks fine | 14:35 |
| stephenfin | sean-k-mooney: just left a comment to that effect | 14:35 |
| sean-k-mooney | so did i :) | 14:36 |
| openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | 14:36 |
| tosky | I'm using this: https://review.opendev.org/694949 | 14:37 |
| tosky | to test it | 14:37 |
| stephenfin | tosky: one more comment, sorry /o\ (the Python 3 Only classifier still makes sense) | 14:37 |
| tosky | stephenfin: oh | 14:38 |
| stephenfin | it's just metadata so you can keep it | 14:38 |
| sean-k-mooney | as does the cpython on | 14:38 |
| stephenfin | yup | 14:38 |
| stephenfin | after that, I'm +2 pending https://review.opendev.org/694949 | 14:38 |
| openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | 14:38 |
| corvus | i'd really love for there to be a job which tests py2.7. can we not just add one until the default switches? | 14:40 |
| corvus | testing with depends-on changes seems error-prone | 14:41 |
| tosky | a non-voting one? A voting one? | 14:41 |
| tosky | I'd defer that to nova cores | 14:41 |
| sean-k-mooney | the whole point of the orginal change was nova wanted to drop all python 2 support and therefor the testing | 14:42 |
| sean-k-mooney | but yes we could | 14:42 |
| sean-k-mooney | gibi: im reviewing your comments on the composable flavors spec | 14:43 |
| sean-k-mooney | gibi: so far i more or less agree | 14:43 |
| stephenfin | if we were to add one, it'd have to be voting for it to be of any use but per above, I don't think we should add one | 14:43 |
| corvus | sean-k-mooney: right, i'm just suggesting that given the importance of devstack, that we should endeavor to keep it working | 14:43 |
| *** links has quit IRC | 14:44 | |
| dansmith | I'm coming into this late, but what is the controversy? | 14:44 |
| dansmith | whether or not we continue to work on py2 at all via a test? | 14:44 |
| stephenfin | dansmith: we've marked nova as python3 only, but devstack defaults to installing stuff in python2 mode | 14:44 |
| corvus | stephenfin: i'm really puzzled -- i don't understand why there is so little concern about whether devstack works | 14:44 |
| stephenfin | so anyone that doesn't override the defaults is broken | 14:44 |
| dansmith | so how is this even a question? | 14:44 |
| * dansmith is confused | 14:45 | |
| stephenfin | dansmith: It's not, we're reverting the part that broke everyone | 14:45 |
| dansmith | reverting what? the dropping of a py2 job? | 14:45 |
| corvus | but there are no current plans to have tests to ensure that it doesn't happen again (and even the revert is only tested indirectly with a depends-on patch) | 14:45 |
| stephenfin | dansmith: https://review.opendev.org/#/c/695007/ | 14:45 |
| dansmith | corvus: yeah, then you and I agree. | 14:46 |
| sean-k-mooney | dansmith: we had a require-pyton >= 3.6 line in setup config that prevented nova installing on less then our new supported version | 14:46 |
| dansmith | what's the argument for not having a py2 test until the devstack default switches? principle? | 14:46 |
| stephenfin | mostly, yeah | 14:47 |
| corvus | dansmith: https://review.opendev.org/694891 is the full revert which seems to be losing mindshare | 14:47 |
| dansmith | stephenfin: I'm not on board with that | 14:47 |
| sean-k-mooney | dansmith: that beeing testing py2 out of principal? | 14:47 |
| sean-k-mooney | or breaking the devstack default | 14:47 |
| sean-k-mooney | because im really hoping we change that today | 14:48 |
| dansmith | sean-k-mooney: I'm not on board with us not testing nova in the default devstack config, and not okay with *not* doing that because of the principle that py2 is (soon) out of support | 14:48 |
| dansmith | if we change the devstack default, then fine not testing py2 | 14:48 |
| dansmith | if we don't, then we *have* to, IMHO | 14:48 |
| sean-k-mooney | ok that is a clear statement | 14:49 |
| *** jaosorior has joined #openstack-nova | 14:49 | |
| *** bhagyashris has joined #openstack-nova | 14:49 | |
| *** ociuhandu has joined #openstack-nova | 14:49 | |
| dansmith | what is the blocker for the devstack py3 default? | 14:50 |
| sean-k-mooney | the devstack defautl in that case need to be change in the next 23 days or we cant drop py2 testing by m1 in nova per the tc plan | 14:50 |
| stephenfin | I figured someone needs to lead the way on this and it didn't seem anyone else was doing it. I also don't get why DevStack can't just change their default | 14:51 |
| dansmith | sean-k-mooney: I totes don't care about the tc's schedule as much as I care that devstack works out of the box | 14:51 |
| dansmith | (I don't care about the TC's schedule at all actually, but.. :P) | 14:51 |
| dansmith | I know mriedem was on top of the devstack py3 default, | 14:51 |
| dansmith | but he approved the switch prior to that being ready, which surprises me | 14:52 |
| mriedem | i didn't know that the nova change meant you couldn't install nova on py2 anymore | 14:53 |
| mriedem | i thought it was (a) what we tested against and (b) classifiers / support statement | 14:53 |
| dansmith | ack | 14:53 |
| gmann | mriedem: stephenfin dansmith tosky removing condition from setup.cfg should be ok as and add that once all projects moved to py3-only. | 14:54 |
| dansmith | mriedem: from the two patches and the votes, it looks like you want to re-allow install on py2, but not test it, yeah? problem is "it" is the "default devstack arrangement" right? | 14:54 |
| stephenfin | and I didn't know that this would break other people. I thought we were safe since we were consumers (a service), rather than the consumed (libs, clients). Didn't think of the DevStack implications | 14:54 |
| gmann | if nova is breaking on py2 by code then we do not need to fix and ask consumer to move to py3-only | 14:54 |
| dansmith | gmann: it's a matter of devstack working out of the box.. nothing to do with python versions, IMHO | 14:54 |
| mriedem | dansmith: correct | 14:55 |
| dansmith | if we're not testing devstack in remotely default form, that's a problem, IMHO | 14:55 |
| gmann | my argument for devstack move to py3 by default can migrate all py2 jobs to py3 which is planned before schedule, like library etc | 14:55 |
| mriedem | dansmith: i want more people to give a shit | 14:55 |
| mriedem | and pain is usually how that happens | 14:55 |
| stephenfin | ^ that, sadly | 14:55 |
| dansmith | mriedem: so you want it to break to prove a point? :) | 14:55 |
| mriedem | that's assuming we're going to land nova changes that break on py2 in the next what, 3-4 weeks? | 14:56 |
| efried | Does anybody object to | 14:56 |
| efried | - Re-enable py2 (revert setup.cfg and requirements changes) | 14:56 |
| efried | - Re-add one py2 job, which can be a pretty small/basic one afaiac | 14:56 |
| dansmith | I still haven't heard why devstack's default can't move yet | 14:56 |
| efried | ? | 14:56 |
| mriedem | i've asserted above that if we do, it's a bug and we just fix it | 14:56 |
| stephenfin | dansmith: see gmann's comment above | 14:56 |
| mriedem | but i don't think we have high risk of landing non-py2 code in the next 3-4 weeks | 14:56 |
| mriedem | i still use six everywhere | 14:56 |
| stephenfin | and on the review | 14:56 |
| efried | I agree with all of that, but "we probably won't break it" has never been a good reason not to test "it". | 14:56 |
| stephenfin | that is my preferred direction, by far | 14:57 |
| dansmith | yeah, probably won't break it doesn't work for me | 14:57 |
| stephenfin | (switching DevStack to Python 3) | 14:57 |
| gmann | i do not prefer nova or any project keep py2 job. but did not thought about min condition on setup.cfg | 14:57 |
| efried | are we objecting to re-adding a py2 job because we're worried about gate resources? | 14:57 |
| dansmith | that's like turning off gating for a bit because we'll be careful | 14:57 |
| efried | ^ this | 14:57 |
| dansmith | stephenfin: I still don't really understand.. gmann is saying we can't switch the default because a lot of jobs don't specify and would break on py3? | 14:57 |
| mriedem | efried: we don't gate on ceph or ironic and yet people care about those right? | 14:58 |
| sean-k-mooney | for what its worth that is why iw as suggesting fixing py3 on centos7 instad of disabling cento7 job untill cento 8 works | 14:58 |
| gmann | yeah but it is deadlock seems and need to tradeoff with either one | 14:58 |
| *** eharney has joined #openstack-nova | 14:58 | |
| stephenfin | dansmith: I think so, yeah | 14:58 |
| efried | mriedem: Agreed that we can't test everything in the world. But a minimal canary to make sure devstack doesn't just shit all over itself seems appropriate. | 14:58 |
| dansmith | well, the tradeoff, is, IMHO, what efried said, which is add back a single py2 devstack job | 14:58 |
| mriedem | and when can that be removed? | 14:59 |
| dansmith | mriedem: when the default switches | 14:59 |
| mriedem | when the tc fairy shows up in january to tell us we're ok? | 14:59 |
| efried | when devstack is py3 by default and we can do the minimum thing. | 14:59 |
| dansmith | mriedem: I don't care about the date, I care about the default | 14:59 |
| * dansmith prints a shirt | 14:59 | |
| stephenfin | Can we just make devstack py3 by default? | 14:59 |
| efried | ("the minimum thing" => restore the py3 minimum in setup.cfg) | 14:59 |
| stephenfin | We know there's going to be some degree of pain here. By reverting anything in nova, we're kicking the can down the road | 15:00 |
| efried | stephenfin: That's mriedem's patch, yes? I rechecked that a bit ago to see if it works yet. If so, maybe we can just pull the trigger. | 15:00 |
| mriedem | then just efried and dansmith should approve ianw's revert | 15:00 |
| gmann | default switch was planned for ~Jan | 15:00 |
| gmann | ok, let's move devstack to py3 and then if anyone need py2 testing (only lib and testing tools) can explicitly mention the py2 need | 15:00 |
| efried | though the predecessor also would need to go. | 15:00 |
| stephenfin | Switching to Python 3 by default is at least forward-looking pain | 15:00 |
| dansmith | gmann: right so if the default flip is coming, I don't see what the big deal is | 15:00 |
| gmann | except swift everyone has to switch to py3-only in ussuri | 15:00 |
| *** tkajinam has quit IRC | 15:00 | |
| mriedem | dansmith: that devstack patch of mine has been on top of another patch that has been around since april | 15:00 |
| stephenfin | then lets do that now | 15:00 |
| dansmith | stephenfin: I would agree except I don't know how many things will insta-fail on projects with few people working on them | 15:01 |
| gmann | i have patches upnfor all the projects (except clieent, testing tool and lib) so project can merge thsoe | 15:01 |
| dansmith | mriedem: I know | 15:01 |
| dansmith | mriedem: I'm not a py3 bigot, so I'm really in no rush :) | 15:01 |
| stephenfin | dansmith: those projects are going to insta-fail at some point though | 15:01 |
| dansmith | stephenfin: yep, so if the TC wants to schedule that, and it's in Jan, I would be fine waiting and moving then as long as it happens | 15:01 |
| dansmith | but, also fine now, I just don't want the disjoint default.. like I said, the date doesn't matter to me | 15:02 |
| gmann | dansmith: but it can be blocked other projects too and two times effort to get rid of py2. so i am ok to move devstack first | 15:02 |
| mriedem | dansmith: then just approve this https://review.opendev.org/#/c/694891/ | 15:03 |
| gmann | because if nova or any other project say min version is py3 then it is fair because reno said the same. | 15:03 |
| dansmith | mriedem: I'm trying to reach consensus like everyone else, not force-merge anything | 15:04 |
| dansmith | if gmann is going to flip the devstack default, then we don't need to do anything, AFAICT | 15:04 |
| stephenfin | yup | 15:05 |
| stephenfin | gmann: just so I'm 100% clear, what was the rationale for the proposed January switchover? | 15:05 |
| stephenfin | I missed whatever email discussed that so a link is fine :) | 15:05 |
| dansmith | January is when the actual upstream support stops, AFAIK | 15:05 |
| dansmith | so I imagine it's aligned there so that the TC's deadline has weight | 15:05 |
| gmann | stephenfin: to keep testing py2 on client lib and lib, testing tool which were planned to drop py2 in jan | 15:05 |
| gmann | plan is like, consumers drop py2 first which is openstack services and then lib or testing tool | 15:06 |
| sean-k-mooney | gmann: it was planned for m2 in febuary | 15:06 |
| stephenfin | We should probably switch over sooner than that then | 15:06 |
| sean-k-mooney | well by m2 | 15:06 |
| stephenfin | We need to keep clients and libraries on python 2 for longer to let the services switch everything over | 15:07 |
| dansmith | honestly, switching the default in devstack at m2 seems crazy late to me | 15:07 |
| dansmith | just for our cycle | 15:07 |
| stephenfin | so we should be switching devstack now to let the services fix whatever they need to fix | 15:07 |
| stephenfin | IMO, of course | 15:07 |
| dansmith | that makes more sense to me for sure | 15:07 |
| dansmith | break early | 15:07 |
| gmann | stephenfin: yeah and all services has to switch before m-2 | 15:07 |
| stephenfin | dansmith: we also have Xmas to worry about | 15:07 |
| gmann | +1. | 15:07 |
| dansmith | stephenfin: not nova's X-mas! :P | 15:08 |
| dansmith | but yeah I get that for sure | 15:08 |
| dansmith | so, just tobe clear, | 15:08 |
| dansmith | even if we push the devstack default, we need the partial revert so that py2-only projects can still install nova in their jobs | 15:08 |
| *** bhagyashris has quit IRC | 15:08 | |
| *** TxGirlGeek has joined #openstack-nova | 15:08 | |
| sean-k-mooney | dansmith: yes | 15:08 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add functional regression test for bug 1853009 https://review.opendev.org/695012 | 15:08 |
| openstack | bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [Undecided,In progress] https://launchpad.net/bugs/1853009 - Assigned to Mark Goddard (mgoddard) | 15:08 |
| dansmith | so we could push the default in devstack now, then revert our can-use-py2 part at m2 as the hard deadline yeah? | 15:08 |
| gmann | stephenfin: are you rebasing the mriedem patch and remove neutron-grenade job also in same patch to pass the gate | 15:09 |
| stephenfin | sean-k-mooney: why? | 15:09 |
| dansmith | stephenfin: so that trove (example) can still run py2 devstack jobs with nova | 15:09 |
| sean-k-mooney | why? so that if neutron need to keep a job on py2 for a day or two to fix it they can | 15:09 |
| dansmith | right | 15:09 |
| gmann | dansmith: they has to move as soon as any dependencies fail their gate | 15:10 |
| stephenfin | But unless they're setting USE_PYTHON3=False in jobs, they'll inherit the default (now python3), no? | 15:10 |
| dansmith | yeah | 15:10 |
| dansmith | that's my point, if nova can't run on py2 anymore (default or not) then they can't run jobs | 15:10 |
| slaweq | sean-k-mooney: what py2 job in neutron You are talking about? | 15:10 |
| dansmith | stephenfin: right, I'm sayingsome project that needs another month to be able to run devstack in default py3 | 15:11 |
| stephenfin | ohhhh | 15:11 |
| stephenfin | gotcha | 15:11 |
| dansmith | if we don't revert the minimum change, they physically can't install nova in unsupported py2 | 15:11 |
| sean-k-mooney | slaweq: none it was just an example of a big project with many jobs that often need nova in them | 15:11 |
| stephenfin | okay | 15:11 |
| *** dpawlik has quit IRC | 15:11 | |
| slaweq | sean-k-mooney: ahh, ok :) | 15:11 |
| gmann | for client lib which will happen later make sense to keep nova install-able on py2 , for service not | 15:11 |
| stephenfin | then I'm also onboard with that | 15:11 |
| dansmith | stephenfin: that all hinges on gmann being willing to pull the trigger | 15:12 |
| sean-k-mooney | by the way os-vif is currently broken as we have not swaped all the jobs to python 3 | 15:12 |
| stephenfin | so, revert the change to nova, merge the Python 3-ification patch to DevStack, wait a month and re-revert that change to nova | 15:12 |
| dansmith | stephenfin: just the half-revert | 15:12 |
| sean-k-mooney | we can trivially but we need to wait as a lib project | 15:12 |
| gmann | revert only setup.cfg and req right ? | 15:12 |
| gmann | yeah what dansmith mentioned | 15:12 |
| dansmith | stephenfin: revert the min, default devstack to py3, later un-revert the minimum | 15:13 |
| gmann | +1 | 15:13 |
| stephenfin | what about your concerns that we could accidentally break Python2 support in that time? | 15:13 |
| stephenfin | don't they still hold? | 15:13 |
| dansmith | stephenfin: those aren't my concerns | 15:13 |
| dansmith | stephenfin: my concerns are that we break the _default_ config in devstack | 15:13 |
| dansmith | if the default changes, I'm good | 15:13 |
| stephenfin | ah | 15:13 |
| * stephenfin is also good with this | 15:14 | |
| corvus | i agree with dansmith (that's my concern too). but it's unclear to me whether we can immediately change the default. is that something we can do today? | 15:14 |
| stephenfin | corvus, tosky: have you been following along or do you need a recap? | 15:14 |
| stephenfin | whoops | 15:14 |
| dansmith | sounds like gmann is willing | 15:14 |
| gmann | stephenfin: you are updating devstack patch? or should i do | 15:14 |
| gmann | gate will be fixed by nova revert | 15:15 |
| stephenfin | gmann: I can...if you tell me what needs to be done? | 15:15 |
| dansmith | corvus: we're going to do the half revert now as well, which I think will eliminate the actual devstack breakage immediately anyway | 15:15 |
| gmann | so default change happen today or tomorrow should be ok | 15:15 |
| sean-k-mooney | corvus: i think we can change the default today | 15:15 |
| tosky | stephenfin: a bit swamped with meetings, I think I may have got the gist of it though | 15:15 |
| gmann | stephenfin: sure, i will comment on patch | 15:15 |
| tosky | like: some reverting will land for now | 15:15 |
| corvus | there was a bunch of devstack centos7 stuff earlier that i didn't understand, but if people who do understand agree that's all doable, then cool. :) | 15:15 |
| tosky | and some other work is needed | 15:15 |
| sean-k-mooney | if it cause gate failure then project can set it back to false in each job that broke | 15:15 |
| tosky | which is a bit generic summary but I'm sure it fits :) | 15:16 |
| stephenfin | tosky: got it in one | 15:16 |
| dansmith | stephenfin: I can summarize on the half-revert patch and +2, you can come back and +W when you're done with the devstack thing okay? | 15:16 |
| stephenfin | ack | 15:16 |
| gmann | corvus: i pushed patch to add centos8 job so i think we can drop centos7 completely | 15:16 |
| sean-k-mooney | corvus: centos ships with python 3.4 so it need to have py 3.6 installed form eple or we need to swap master jobs to centos 8 | 15:17 |
| corvus | and centos8 is ready? | 15:17 |
| stephenfin | gmann shows up and fixes everything for us. This is excellent \o/ | 15:17 |
| tosky | gmann: see on #openstack-qa: some work is needed on centos 8, frickler was working on it | 15:17 |
| sean-k-mooney | we just need to fix any gaps in devstack on centos 8 | 15:17 |
| gmann | my bad and sorry for not considering the setup.cfg min py version things during composing the plan/goal | 15:17 |
| tosky | gmann: and the requirements too :) | 15:17 |
| gmann | yeah :( | 15:17 |
| stephenfin | gmann: Not your fault. I never thought about the DevStack default thing when putting that together | 15:18 |
| *** Sundar has joined #openstack-nova | 15:18 | |
| mriedem | stephenfin: your patch depended on the devstack default switch after i mentioned it, and then you dropped the depends-on | 15:18 |
| mriedem | likely because we could just set USE_PYTHON3=True in our jobs | 15:18 |
| stephenfin | yup, exactly because of that :( | 15:19 |
| stephenfin | I thought the depends on was an optimization to avoid us having to set that stuff manually | 15:19 |
| stephenfin | TIL | 15:19 |
| tosky | gmann: no problem, really; it happens, let's improve the process and continue | 15:19 |
| mriedem | slaweq: do you have a bug for this yet so i can track it in e-r | 15:20 |
| mriedem | ? | 15:20 |
| slaweq | mriedem: no, I didn't open any bug for this | 15:20 |
| *** markmcclain has quit IRC | 15:21 | |
| slaweq | I just checked here that You're already talking about it so I didn't report a bug | 15:21 |
| corvus | i think the thing to watch out for in future reviews is: when setting a devstack option, is it something that is intrinsic to the specific job (okay in nova) or is it something that is recommended/required for any devstack users (should be in devstack). if all the nova devstack jobs have an option, it's almost certainly the latter. | 15:21 |
| *** markmcclain has joined #openstack-nova | 15:23 | |
| stephenfin | makes sense | 15:23 |
| dansmith | stephenfin: https://review.opendev.org/#/c/695007/3 | 15:29 |
| dansmith | efried: mriedem ^ | 15:29 |
| stephenfin | dansmith: LGTM | 15:31 |
| efried | dansmith: so you've changed your mind on readding a minimal py2 job? | 15:32 |
| dansmith | efried: no, you must not have followed all of that, and.. did you read my wall of text? | 15:32 |
| efried | I did | 15:32 |
| dansmith | efried: all I care about is that we're testing the devstack default.. if the default is changing, I'm cool with sticking with py3 only and letting py2 issues creep in | 15:32 |
| sean-k-mooney | efried: im guessing your askign since this patch does not add the minimal job | 15:32 |
| dansmith | efried: if the default is not changing, I think we have to test and validate the default | 15:33 |
| efried | what sean-k-mooney said. since this patch doesn't depend on the "switch the default to py3" patch, and there's no telling how long it will be until that actually merges, we have The Hole. | 15:33 |
| dansmith | efried: gmann said they'd merge it today | 15:34 |
| mriedem | you have a gentlemans agreement for about the next 24 hours | 15:34 |
| mriedem | after that courtney love shows pu | 15:34 |
| efried | okaaay | 15:34 |
| mriedem | *up | 15:34 |
| dansmith | we could block on that, but we're blocking a bunch of other people | 15:34 |
| efried | yah, seems like it would have been easy to add one line to .zuul.yaml in that patch, but mebbe not. | 15:34 |
| dansmith | gmann: don't f*ck me over, okay? | 15:34 |
| efried | anyway, it's on the way | 15:34 |
| mriedem | for me it's not about ease | 15:34 |
| dansmith | efried: well, I'm fine with that if you want | 15:34 |
| sean-k-mooney | efried: nova-dsvm-multinode-base is still python 2 i think | 15:34 |
| mriedem | sean-k-mooney: that's not a ojb | 15:35 |
| mriedem | *job | 15:35 |
| mriedem | that's a base | 15:35 |
| sean-k-mooney | so nova-live-migration will by python 2 | 15:35 |
| mriedem | it's not | 15:35 |
| sean-k-mooney | ya i know | 15:35 |
| efried | nope | 15:35 |
| stephenfin | sean-k-mooney: it can't be. if it was, it wouldn't work for us :) | 15:35 |
| mriedem | hi https://review.opendev.org/#/c/694787/ | 15:35 |
| *** nweinber_ has joined #openstack-nova | 15:35 | |
| sean-k-mooney | im looking at https://github.com/openstack/nova/blob/master/.zuul.yaml and i dont see python 3 enabled | 15:36 |
| efried | because https://opendev.org/openstack/nova/src/branch/master/playbooks/legacy/nova-live-migration/run.yaml#L50 rite? | 15:36 |
| mriedem | it's in the legacy playbook | 15:36 |
| mriedem | yes that | 15:36 |
| *** bhagyashris has joined #openstack-nova | 15:36 | |
| mriedem | cue sean-k-mooney saying we should really move those jobs to zuulv3 | 15:36 |
| stephenfin | mriedem: on that, you need to keep the sphinx on py2 line in doc/requirements.txt | 15:36 |
| stephenfin | i tried removing it and got the same thing you're seeing | 15:36 |
| stephenfin | the tool is dumb | 15:36 |
| sean-k-mooney | ah ok | 15:37 |
| gmann | ? anything changed ? | 15:37 |
| dansmith | gmann: no, we're just taking bets on whether or not you're really going to merge the devstack change today | 15:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to Ie1a0cbd82a617dbcc15729647218ac3e9cd0e5a9 https://review.opendev.org/694787 | 15:37 |
| *** nweinber has quit IRC | 15:37 | |
| *** ivve has quit IRC | 15:37 | |
| dansmith | gmann: efried and I will have to meet on the playground after school if not, and he'll kick my ass | 15:38 |
| gmann | ok :) | 15:38 |
| *** mkrai has joined #openstack-nova | 15:38 | |
| *** damien_r has quit IRC | 15:41 | |
| openstackgerrit | Merged openstack/nova master: functional: Make '_wait_for_state_change' behave consistently https://review.opendev.org/689180 | 15:43 |
| gmann | mriedem: sean-k-mooney for legacy jobs i am explicitly setting py3 via d-g var for other projects. waiting to move them to zuulv3 +py3 might take time. | 15:47 |
| gmann | stephenfin: on requirement changes. I am removing the py2 only req also for other projects and if any project break anyone (which is rare case for all non-core/small projects) then we revert otherwise keep dropping those. | 15:49 |
| stephenfin | ack | 15:50 |
| mriedem | stephenfin: i'm going to drop the misleading comment on https://review.opendev.org/#/c/694789/2/playbooks/legacy/nova-grenade-multinode/run.yaml@35 | 15:50 |
| stephenfin | fine by me | 15:50 |
| *** pcaruana has quit IRC | 15:50 | |
| *** pcaruana has joined #openstack-nova | 15:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop neutron-grenade-multinode job https://review.opendev.org/694789 | 15:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop neutron-grenade-multinode job https://review.opendev.org/694789 | 15:52 |
| *** bhagyashris has quit IRC | 15:55 | |
| openstackgerrit | Pavel Gluschak (scsnow) proposed openstack/nova master: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/694756 | 16:00 |
| *** udesale has quit IRC | 16:00 | |
| *** awalende has quit IRC | 16:01 | |
| openstackgerrit | Archit Modi proposed openstack/nova stable/pike: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693236 | 16:02 |
| *** alex_xu has quit IRC | 16:03 | |
| openstackgerrit | Archit Modi proposed openstack/nova stable/pike: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693236 | 16:05 |
| *** gyee has joined #openstack-nova | 16:05 | |
| *** awalende has joined #openstack-nova | 16:08 | |
| *** mlavalle has joined #openstack-nova | 16:09 | |
| *** awalende has quit IRC | 16:12 | |
| *** awalende has joined #openstack-nova | 16:12 | |
| *** awalende has quit IRC | 16:13 | |
| *** awalende has joined #openstack-nova | 16:14 | |
| *** awalende has quit IRC | 16:14 | |
| artom | sean-k-mooney, FWIW, I'm not going to hassly you about the softer wording stuff in your NUMA rebuild patches. There's still enough stuff there to warrant a respin on both (albeit the top one is just typos) | 16:15 |
| artom | *hassle | 16:15 |
| *** mkrai has quit IRC | 16:15 | |
| *** ociuhandu has quit IRC | 16:17 | |
| *** nanzha has quit IRC | 16:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make '_IntegratedTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182 | 16:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Unify '_build_minimal_create_server_request' implementations https://review.opendev.org/695024 | 16:18 |
| *** awalende has joined #openstack-nova | 16:19 | |
| *** TxGirlGeek has quit IRC | 16:20 | |
| sean-k-mooney | artom: i am going ot resping them for the typos yes | 16:20 |
| artom | And the unit tests :) | 16:21 |
| artom | Mostly the unit tests | 16:21 |
| sean-k-mooney | i actully intionally did not add them but yes im going to add some for the neew fucntion | 16:24 |
| sean-k-mooney | mainly because functional tests and exsiting test provide equal or better coverage in general but as noted ill add the test for the function you highlighted | 16:25 |
| openstackgerrit | Thierry Carrez proposed openstack/nova master: Start README.rst with a better title https://review.opendev.org/695025 | 16:29 |
| mgoddard | mriedem: hi. The more I pick at this thing (rebalance) the more it comes apart :) | 16:32 |
| openstackgerrit | Merged openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | 16:32 |
| gmann | everyone, sent the ML for making devstack py3 default and other suggestion we agreed today- http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010938.html | 16:33 |
| mgoddard | mriedem: I have a few related but separable changes, and a functional tests. Does nova tend to prefer separate commits where possible, or shall I bung it all in one? | 16:33 |
| *** jmlowe has joined #openstack-nova | 16:33 | |
| mriedem | mgoddard: i can't speak for all of nova but i prefer separate commits if possible - easier to review, easier to revert if necessary | 16:34 |
| mgoddard | mriedem: sure. | 16:34 |
| mriedem | mgoddard: and i'm not surprised rebalance has issues since it's never had functional testing | 16:35 |
| kashyap | mgoddard: On separate commits, this is a good reminder: https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes | 16:35 |
| mriedem | the only way i found the race bug in the first place was digging into ironic multinode grenade logs looking for some other issue | 16:35 |
| kashyap | (Bearing in mind things like bisectability, etc) | 16:35 |
| mgoddard | mriedem: separate commits should be quite neat as each will fix a different part of the functional test | 16:35 |
| bauzas | gibi: mriedem: do you think it would be worth inspecting the args when calling PlacementFixture ? | 16:36 |
| bauzas | (related to the microversion/version issue) | 16:36 |
| mgoddard | thanks kashyap. I generally prefer them, although it's not universal | 16:37 |
| * kashyap nods | 16:37 | |
| *** abaindur has joined #openstack-nova | 16:39 | |
| efried | bauzas: can you point me to the change in question please? | 16:39 |
| efried | (It's somewhere on my list, been meaning to weigh in, but don't want to dig it up rn) | 16:39 |
| efried | if this is a functional test, the PlacementFixture should be doing the right thing with its kwargs. And there should usually not be a reason to (re-)mock a method on the fixture. | 16:40 |
| bauzas | efried: https://review.opendev.org/#/c/670112/8/nova/cmd/manage.py@2867 | 16:40 |
| bauzas | context is that I used a wrong argument : 'microversion' instead of 'version' | 16:41 |
| bauzas | so I could rather use utils.getargspec() | 16:41 |
| efried | I understand, gimme sec. | 16:41 |
| bauzas | I mean, in the PlacementFixture | 16:41 |
| bauzas | efried: ie. something around there https://github.com/openstack/nova/blob/master/nova/tests/functional/fixtures.py#L103 | 16:42 |
| efried | oh, crap, yeah, I remember trying to unwind this _fake_* gorp a while back and back-burnering it because it turned out to be hard. | 16:43 |
| *** TxGirlGeek has joined #openstack-nova | 16:44 | |
| efried | yeah, this is (still) awful to have in the way of the actual placement fixture | 16:44 |
| efried | it will mask all kinds of problems, like the one you're running into. | 16:44 |
| efried | egads, we should also be making self._client a sdk proxy now as well. | 16:45 |
| bauzas | you know what ? I'll provide a separate change | 16:46 |
| bauzas | efried: ^ | 16:46 |
| efried | not that it's hugely different | 16:46 |
| efried | bauzas: Totally agree a separate change is in order. | 16:46 |
| bauzas | k | 16:46 |
| efried | If you can't completely kill the _fake_* methods, they should at least be avoiding massaging the args as much as possible. | 16:47 |
| gmann | stephenfin: can you rebase this on top of slaweq patch to dropneutron-grenade from devstack (commented on review) - https://review.opendev.org/#/c/649097/10 | 16:47 |
| *** jaosorior has quit IRC | 16:48 | |
| stephenfin | ack | 16:48 |
| *** tesseract has quit IRC | 16:51 | |
| openstackgerrit | Merged openstack/nova stable/pike: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693236 | 16:51 |
| stephenfin | gmann: done | 16:52 |
| gmann | stephenfin: thanks, only thing we need to care is neutron-grenade job which will not work on devstack-py3-default. slaweq has patches up to migrate its usage to grenade-py3 but not all are merged. so i am making neutron-greande explicitly say py2 | 16:55 |
| stephenfin | gmann: Makes sense. Do we need https://review.opendev.org/#/c/649097/ to depend on that so? | 16:56 |
| gmann | stephenfin: yeah, i am pushing the neutron patch (neutron-grenade is in neutron repo) and ping you | 16:56 |
| gibi | bauzas: tested your placement audit patch. The basic functionality seems to work with even bandwidth involved. But I think --delete is broken somehow. (See my comment in the review) | 16:58 |
| bauzas | gibi: k, will look | 16:58 |
| bauzas | gibi: and thanks :) | 16:58 |
| gibi | np | 16:59 |
| * gibi ends the day | 16:59 | |
| bauzas | gibi: I can't see your comment on delete ? | 16:59 |
| bauzas | anyway, let's discuss this tomorrow | 16:59 |
| bauzas | thanks gibi a lot | 16:59 |
| bauzas | ah, nevermind | 17:00 |
| bauzas | Ctrl-R | 17:00 |
| *** jaosorior has joined #openstack-nova | 17:02 | |
| *** nweinber__ has joined #openstack-nova | 17:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907 | 17:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'console' RPC API https://review.opendev.org/687908 | 17:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909 | 17:04 |
| *** nweinber_ has quit IRC | 17:06 | |
| *** rpittau is now known as rpittau|afk | 17:06 | |
| *** awalende has quit IRC | 17:09 | |
| *** awalende has joined #openstack-nova | 17:17 | |
| *** dtantsur is now known as dtantsur|afk | 17:20 | |
| *** awalende has quit IRC | 17:20 | |
| *** awalende_ has joined #openstack-nova | 17:20 | |
| *** ivve has joined #openstack-nova | 17:21 | |
| *** ociuhandu has joined #openstack-nova | 17:22 | |
| *** ccamacho has quit IRC | 17:23 | |
| *** awalende_ has quit IRC | 17:24 | |
| *** ociuhandu has quit IRC | 17:27 | |
| *** Sundar has quit IRC | 17:29 | |
| *** munimeha1 has joined #openstack-nova | 17:50 | |
| *** igordc has joined #openstack-nova | 17:52 | |
| mriedem | dansmith: you want to move this bottom cross-cell patch along? https://review.opendev.org/#/c/642591/ - you should already be familiar with this one | 17:59 |
| *** derekh has quit IRC | 18:01 | |
| *** ociuhandu has joined #openstack-nova | 18:04 | |
| *** ricolin has quit IRC | 18:04 | |
| *** ociuhandu has quit IRC | 18:08 | |
| dansmith | mriedem: yeah, sorry I need to re-find my way on those | 18:10 |
| mriedem | bauzas: easy bug fix https://review.opendev.org/#/c/694756/ | 18:13 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri" https://review.opendev.org/695056 | 18:15 |
| *** ociuhandu has joined #openstack-nova | 18:17 | |
| *** ociuhandu has quit IRC | 18:21 | |
| *** dpawlik has joined #openstack-nova | 18:30 | |
| *** martinkennelly has quit IRC | 18:45 | |
| *** abaindur has quit IRC | 18:46 | |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825 | 18:58 |
| *** davee__ has quit IRC | 18:59 | |
| *** ralonsoh has quit IRC | 19:03 | |
| *** TxGirlGeek has quit IRC | 19:03 | |
| *** TxGirlGeek has joined #openstack-nova | 19:11 | |
| openstackgerrit | Merged openstack/nova master: FUP to Ie1a0cbd82a617dbcc15729647218ac3e9cd0e5a9 https://review.opendev.org/694787 | 19:19 |
| *** abaindur has joined #openstack-nova | 19:23 | |
| *** abaindur has quit IRC | 19:28 | |
| *** abaindur has joined #openstack-nova | 19:28 | |
| *** abaindur has quit IRC | 19:29 | |
| *** abaindur has joined #openstack-nova | 19:30 | |
| efried | mriedem: Do you remember seeing/fixing this recently? https://zuul.opendev.org/t/openstack/build/ac433b3305ba454f845990f98a3bf481/log/logs/grenade.sh.txt.gz#38749 | 19:32 |
| efried | I don't see it in e-r | 19:33 |
| *** ociuhandu has joined #openstack-nova | 19:37 | |
| *** dpawlik has quit IRC | 19:41 | |
| mriedem | efried: weren't you hitting something like that with trying to get osc to gate on py3? | 19:45 |
| efried | this is what I don't remember. | 19:46 |
| efried | fwiw this is trying to see whether barbican will gate on py3 | 19:46 |
| *** ociuhandu has quit IRC | 19:47 | |
| mriedem | so it's probably installing py27 on the old side and then trying to upgrade to py3 on the new side and packages are getting mixed up | 19:47 |
| mriedem | see https://review.opendev.org/#/c/694237/ | 19:48 |
| mriedem | and https://github.com/openstack/grenade/blob/master/playbooks/legacy/grenade-py3/run.yaml | 19:48 |
| *** dpawlik has joined #openstack-nova | 19:48 | |
| mriedem | do the same in https://github.com/openstack/barbican/blob/master/playbooks/legacy/grenade-devstack-barbican/run.yaml | 19:49 |
| mriedem | to make your barbican py3 dreams come true | 19:49 |
| efried | mriedem: "the same" meaning add | 19:51 |
| efried | export DEVSTACK_GATE_USE_PYTHON3=True | 19:51 |
| efried | ? | 19:51 |
| mriedem | yeah | 19:52 |
| efried | ack, trying, thanks. | 19:52 |
| *** artom has quit IRC | 19:53 | |
| *** artom has joined #openstack-nova | 19:55 | |
| *** gmann is now known as gmann_afk | 19:57 | |
| dansmith | let it be known gmann_afk is a gentleman and his word is his bond | 19:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow disabling cold migration to the same host https://review.opendev.org/676022 | 20:21 |
| *** dpawlik has quit IRC | 20:22 | |
| dustinc | dansmith: If you have a minute, would you mind taking a peek at this real quick and offering your opinion? https://review.opendev.org/#/c/693414/ | 20:26 |
| *** tosky has quit IRC | 20:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow disabling cold migration to the same host https://review.opendev.org/676022 | 20:28 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804 | 20:30 |
| efried | dansmith: Updated per your comments, but some of them left more questions than answers. I could use some help, please, when you get a chance. | 20:30 |
| efried | jroll: ^ might come down to "are we dead in the water if we simply can't support shelve-offload (and possibly others)?" | 20:31 |
| * efried feeds face | 20:31 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 20:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 20:31 |
| openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 20:31 |
| dansmith | dustinc: my opinion on what? whether it's fundamentally okay? | 20:34 |
| *** openstackgerrit has quit IRC | 20:35 | |
| dustinc | dansmith: Yes, efried suggested an alternative and I wanted help figuring out what makes more sense | 20:36 |
| *** ociuhandu has joined #openstack-nova | 20:38 | |
| efried | dansmith: Trying to address what happens when the same node appears more than once in provider configs. Due to e.g. ironic rebalance we can't just fail, because the "conflict" might not appear until we're already running. So we have to set some kind of precedence rules for ``$COMPUTE_NODE`` vs explicit uuid and name | 20:39 |
| dansmith | ohh, I clicked on the wrong link | 20:40 |
| efried | In practice, I think this could only possibly be an issue at runtime in an ironic deployment when a rebalance happens, I think. At which point a new node will "appear" and we have to decide whether it has a provider config. | 20:40 |
| dansmith | I have to run an errand, so I should probably not try to squeeze in a quick read of that before I go. | 20:40 |
| efried | If we commit to this only being an issue in that ^ scenario, then I *think* the fact that ironic node RP name == uuid (doesn't it?) would let us hardcode an unambiguous solution pretty easily. | 20:41 |
| efried | I need to food and then school run, will check back on this later. | 20:41 |
| dansmith | I would punt to mriedem on that as I think he has the most ironic RP stuff in his head | 20:41 |
| dansmith | but yeah, will leave this open for later | 20:42 |
| *** ociuhandu has quit IRC | 20:42 | |
| *** ociuhandu has joined #openstack-nova | 20:43 | |
| *** dpawlik has joined #openstack-nova | 20:45 | |
| *** openstackgerrit has joined #openstack-nova | 20:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/os-traits master: Add COMPUTE_SAME_HOST_COLD_MIGRATE trait https://review.opendev.org/666604 | 20:45 |
| openstackgerrit | Merged openstack/nova master: Fix driver tests on Windows https://review.opendev.org/518525 | 20:47 |
| *** eharney has quit IRC | 20:48 | |
| *** igordc has quit IRC | 20:50 | |
| mriedem | "ironic node RP name == uuid (doesn't it?)" yes | 20:50 |
| mriedem | ironic node RP name/uuid == compute node hypervisor_hostname and uuid == ironic node id | 20:51 |
| *** mgariepy has quit IRC | 20:53 | |
| *** dpawlik has quit IRC | 20:58 | |
| *** ociuhandu has quit IRC | 20:58 | |
| *** gmann_afk is now known as gmann | 21:03 | |
| *** igordc has joined #openstack-nova | 21:15 | |
| *** awalende has joined #openstack-nova | 21:15 | |
| *** dpawlik has joined #openstack-nova | 21:17 | |
| dansmith | efried: dustinc I don't understand.. you can just use ironic node uuid and be properly unique and specific no? | 21:18 |
| *** dpawlik has quit IRC | 21:23 | |
| dustinc | dansmith: well we need to make sure that whoever put it in the file did so correctly...the original spec required that if two different entries referenced the same provider, it would cause nova to fail to init, but since we realized that we cannot be sure if a specific uuid and $COMPUTE_NODE reference the same provider until _after_ init, we need to not fail so had to come up with another plan | 21:25 |
| *** ociuhandu has joined #openstack-nova | 21:29 | |
| *** awalende has quit IRC | 21:30 | |
| dansmith | dustinc: I think it's expected that "whoever put" anything in the file did so correctly | 21:32 |
| dansmith | IMHO, the solution is to use the ironic uuid there, regardless of which compute host gets that node in the rebalance, I think that's fine | 21:32 |
| *** awalende has joined #openstack-nova | 21:45 | |
| *** ociuhandu has quit IRC | 21:48 | |
| *** mriedem has quit IRC | 21:48 | |
| *** eharney has joined #openstack-nova | 21:48 | |
| *** lpetrut has quit IRC | 21:50 | |
| *** mriedem has joined #openstack-nova | 21:51 | |
| *** rcernin has joined #openstack-nova | 21:59 | |
| *** awalende has quit IRC | 22:01 | |
| *** rcernin has quit IRC | 22:01 | |
| *** rcernin has joined #openstack-nova | 22:01 | |
| *** rcernin has quit IRC | 22:01 | |
| *** rcernin has joined #openstack-nova | 22:02 | |
| *** nweinber__ has quit IRC | 22:05 | |
| dustinc | dansmith: Well the issue is that we need to decide what to do in the case the node is defined more than once in the configuration files. I proposed that we use the first entry that identifies the node and ignore the rest, but efried proposes that we use the $COMPUTE_NODE as a catch all and the specific uuid/name identification should take precedence if both exit (this makes sense the more I think about it) | 22:06 |
| dustinc | the remaining issue we _might_ run into is what happens if the node is identified by name and uuid? | 22:06 |
| efried | dustinc: let me go check whether the ironic node RP name and uuid are in fact the same in placement... | 22:13 |
| *** awalende has joined #openstack-nova | 22:14 | |
| *** priteau has quit IRC | 22:15 | |
| efried | dustinc: o look, a comment right at the top of ironic driver's update_provider_tree: | 22:15 |
| efried | # nodename is the ironic node's UUID. | 22:15 |
| efried | dansmith: lacking a better idea, do you think "create a glance image for the virtual device file" is an acceptable (if unlovely) path forward? | 22:16 |
| dustinc | ok so we can identify name/uuid identification conflicts before init with ironic...but what about nova? how can we be sure a name and uuid don't identify the same node? what should we do in the case that happens? | 22:17 |
| efried | dustinc: that we should be able to determine the *first* time the RT hits this code, i.e. on startup. | 22:17 |
| efried | for non-ironic, that is. Because we're looking at the compute node RP already. | 22:18 |
| *** awalende has quit IRC | 22:19 | |
| efried | To cover ironic, we just put an extra check that cfg1['name'] != cfg2['uuid'] for all (cfg1, cfg2). It's a tad specific, but it would be insanity for node[name] on one node to be the same as node[uuid] on another, so I don't feel awful about doing that. | 22:19 |
| *** awalende has joined #openstack-nova | 22:21 | |
| efried | btw, to anticipate (ironic) scaling issues, probably a good idea to index the configs by identifier. Which, since we're forbidding name/uuid conflicts, actually helps make ^ seem saner :P | 22:21 |
| efried | so, the load-up logic becomes simply: | 22:23 |
| efried | if identifier in cfgs: | 22:23 |
| efried | puke | 22:23 |
| efried | cfgs[identifier] = cfg | 22:23 |
| efried | And then when we're processing a node: | 22:23 |
| efried | if node.name in cfgs: | 22:23 |
| efried | cfg = cfgs[node.name] | 22:23 |
| efried | elif node.uuid in cfgs: | 22:23 |
| efried | cfg = cfgs[node.uuid] | 22:23 |
| efried | elif '$COMPUTE_NODE' in cfgs: | 22:23 |
| efried | cfg = cfgs['$COMPUTE_NODE'] | 22:23 |
| efried | else: | 22:24 |
| efried | or more terser: | 22:24 |
| efried | cfg = cfgs.get(node.uuid, cfgs.get(node.name, cfgs.get('$COMPUTE_NODE'))) | 22:24 |
| efried | if cfg: ... | 22:24 |
| *** awalende has quit IRC | 22:29 | |
| *** awalende has joined #openstack-nova | 22:29 | |
| *** pcaruana has quit IRC | 22:33 | |
| *** awalende has quit IRC | 22:35 | |
| *** slaweq has quit IRC | 22:39 | |
| *** ociuhandu has joined #openstack-nova | 22:41 | |
| efried | dansmith: procedurally, to get things moving, how would you feel about "resize/migration/shelve/others will be addressed in a subsequent spec"? | 22:44 |
| *** jaosorior has quit IRC | 22:45 | |
| *** ociuhandu has quit IRC | 22:46 | |
| *** slaweq has joined #openstack-nova | 22:48 | |
| *** munimeha1 has quit IRC | 22:49 | |
| *** jaosorior has joined #openstack-nova | 22:49 | |
| *** jaosorior has quit IRC | 22:52 | |
| *** slaweq has quit IRC | 22:53 | |
| *** slaweq has joined #openstack-nova | 23:03 | |
| *** ociuhandu has joined #openstack-nova | 23:07 | |
| *** tkajinam has joined #openstack-nova | 23:07 | |
| *** abaindur has quit IRC | 23:07 | |
| *** ociuhandu has quit IRC | 23:09 | |
| *** abaindur has joined #openstack-nova | 23:09 | |
| efried | mriedem: Is grenade *supposed* to use py2 on the "old" side? | 23:10 |
| *** ociuhandu has joined #openstack-nova | 23:11 | |
| *** ociuhandu has quit IRC | 23:16 | |
| *** slaweq has quit IRC | 23:16 | |
| melwitt | mriedem: new tempest test shenanigans you might have an opinion about https://review.opendev.org/693096 tl;dr is downstream we want to be able to test with the config_drive: True request param for POST /servers and one way to add it would result in dupe test coverage in the gate | 23:19 |
| *** priteau has joined #openstack-nova | 23:20 | |
| gmann | efried: for ussuri jobs no. py2->py3 does not work and required more fixes on pckg installation etc. it was decided to do py3->py3 in grenade ussuri jobs. | 23:22 |
| melwitt | gmann: hey, could you hit up the unified limits spec again? john updated to address your latest comments | 23:24 |
| *** tosky has joined #openstack-nova | 23:24 | |
| *** slaweq has joined #openstack-nova | 23:25 | |
| efried | gmann: Gotcha. How do I make the "old" side run py3 then? | 23:25 |
| gmann | melwitt: done. | 23:26 |
| melwitt | thanks gmann | 23:26 |
| *** tosky has quit IRC | 23:26 | |
| efried | gmann: note that https://review.opendev.org/#/c/695052/ still failed with the old side running py2, so | 23:26 |
| efried | export DEVSTACK_GATE_USE_PYTHON3=True | 23:26 |
| efried | apparently isn't correct/sufficient. | 23:26 |
| gmann | efried: is it, this should make use_python3=True on old node | 23:27 |
| gmann | i did in all other patches also - https://review.opendev.org/#/q/topic:drop-py27-support-devstack-default-py3+(status:open+OR+status:merged) | 23:27 |
| gmann | and grenade-py3 job is doing that only. | 23:27 |
| *** slaweq has quit IRC | 23:30 | |
| *** efried has quit IRC | 23:30 | |
| *** ociuhandu has joined #openstack-nova | 23:30 | |
| gmann | for example, watcher patch is working fine - https://review.opendev.org/#/c/695097/1 | 23:33 |
| *** abaindur has quit IRC | 23:34 | |
| gmann | from log it seems like DEVSTACK_GATE_USE_PYTHON3 is not set on d-g side | 23:36 |
| *** abaindur has joined #openstack-nova | 23:36 | |
| *** ociuhandu has quit IRC | 23:40 | |
| *** slaweq has joined #openstack-nova | 23:42 | |
| *** slaweq has quit IRC | 23:47 | |
| *** efried has joined #openstack-nova | 23:49 | |
| efried | gmann: sorry, I didn't mean to bail on you there, I was trying to get to zuul.o.o/jobs and it crashed my machine. This has been happening for a while, I should learn. | 23:50 |
| efried | Anyway, now I *do* need to bail. I'll try to catch up with you tomorrow about the grenade business. | 23:50 |
| gmann | efried: sure. | 23:51 |
| *** ivve has quit IRC | 23:54 | |
| *** Liang__ has quit IRC | 23:54 | |
| *** slaweq has joined #openstack-nova | 23:57 | |
| *** ociuhandu has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!