Friday, 2019-11-15

« Thursday, 2019-11-14 Index Saturday, 2019-11-16 »
*** macz has quit IRC00:02
*** dave-mccowan has quit IRC00:10
*** slaweq has joined #openstack-nova00:11
*** dave-mccowan has joined #openstack-nova00:15
*** slaweq has quit IRC00:16
*** KeithMnemonic has joined #openstack-nova00:16
*** KeithMnemonic has quit IRC00:17
*** KeithMnemonic has joined #openstack-nova00:17
*** KeithMnemonic has quit IRC00:23
*** igordc has quit IRC00:24
*** igordc has joined #openstack-nova00:25
*** slaweq has joined #openstack-nova00:28
*** igordc has quit IRC00:32
*** slaweq has quit IRC00:33
*** ccstone has quit IRC00:33
*** mlavalle has quit IRC00:40
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Expose instance action event details out of the API  https://review.opendev.org/69443000:43
*** mriedem has quit IRC00:45
*** slaweq has joined #openstack-nova00:50
*** TxGirlGeek has quit IRC00:52
*** slaweq has quit IRC00:55
*** nanzha has joined #openstack-nova00:59
*** ileixe has joined #openstack-nova01:00
*** dave-mccowan has quit IRC01:01
*** ociuhandu has joined #openstack-nova01:01
*** TxGirlGeek has joined #openstack-nova01:05
*** slaweq has joined #openstack-nova01:06
*** rpittau|afk has quit IRC01:11
*** mnasiadka has quit IRC01:11
*** rpittau|afk has joined #openstack-nova01:11
*** TxGirlGeek has quit IRC01:11
*** guilhermesp has quit IRC01:11
*** Li_Liu has quit IRC01:12
*** lamt has quit IRC01:12
*** TheJulia has quit IRC01:12
*** icey has quit IRC01:12
*** mnasiadka has joined #openstack-nova01:12
*** icey has joined #openstack-nova01:13
*** Li_Liu has joined #openstack-nova01:13
*** TheJulia has joined #openstack-nova01:13
*** guilhermesp has joined #openstack-nova01:13
*** jkulik has quit IRC01:14
*** slaweq has quit IRC01:15
*** jkulik has joined #openstack-nova01:17
*** artom has joined #openstack-nova01:17
*** slaweq has joined #openstack-nova01:18
*** Liang__ has joined #openstack-nova01:18
*** Liang__ has quit IRC01:20
*** ociuhandu has quit IRC01:23
*** slaweq has quit IRC01:23
*** zhanglong has quit IRC01:36
*** slaweq has joined #openstack-nova01:37
*** ociuhandu has joined #openstack-nova01:38
*** zhanglong has joined #openstack-nova01:38
*** ociuhandu has quit IRC01:42
*** slaweq has quit IRC01:45
*** slaweq has joined #openstack-nova01:52
*** slaweq has quit IRC01:56
*** ociuhandu has joined #openstack-nova02:02
*** openstackstatus has joined #openstack-nova02:03
*** ChanServ sets mode: +v openstackstatus02:03
*** ociuhandu has quit IRC02:06
*** ociuhandu has joined #openstack-nova02:07
*** prince_nana has joined #openstack-nova02:10
*** slaweq has joined #openstack-nova02:11
*** prince_nana has quit IRC02:11
*** ociuhandu has quit IRC02:12
*** chenhaw has joined #openstack-nova02:12
*** slaweq has quit IRC02:15
*** chenhaw has quit IRC02:17
openstackgerritMerged openstack/nova master: Move compute_node_to_inventory_dict to test-only code  https://review.opendev.org/69343802:20
openstackgerritMerged openstack/nova master: Remove get_minimum_version mocks from test_resource_tracker  https://review.opendev.org/69343902:20
openstackgerritMerged openstack/nova stable/queens: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69435702:20
*** ociuhandu has joined #openstack-nova02:26
*** jbernard has joined #openstack-nova02:31
*** ociuhandu has quit IRC02:36
*** jbernard has quit IRC02:50
*** jbernard_ has joined #openstack-nova02:50
*** jbernard_ has quit IRC02:51
*** igordc has joined #openstack-nova02:53
*** artom has quit IRC02:54
*** artom has joined #openstack-nova02:54
*** artom has quit IRC02:55
*** gyee has quit IRC02:55
*** zzzeek has quit IRC02:56
*** zzzeek has joined #openstack-nova02:57
*** zzzeek has quit IRC02:58
*** zzzeek has joined #openstack-nova02:59
openstackgerritMerged openstack/nova master: Stop using NoAuthMiddleware in tests  https://review.opendev.org/68741602:59
*** tbachman has quit IRC03:00
*** ociuhandu has joined #openstack-nova03:07
openstackgerritMerged openstack/nova master: Remove TODO from ComputeTaskManager._live_migrate  https://review.opendev.org/69369603:10
*** ociuhandu has quit IRC03:12
*** ociuhandu has joined #openstack-nova03:13
*** chenhaw has joined #openstack-nova03:14
*** francoisp has quit IRC03:19
*** abaindur has quit IRC03:22
*** zhubx has joined #openstack-nova03:35
*** ociuhandu has quit IRC03:36
*** jbernard has joined #openstack-nova03:36
*** boxiang has quit IRC03:39
*** bhagyashris has joined #openstack-nova03:42
*** JamesBenson has joined #openstack-nova03:52
*** chenhaw has quit IRC03:54
*** mkrai has joined #openstack-nova03:56
*** ociuhandu has joined #openstack-nova04:01
*** ociuhandu has quit IRC04:06
*** psachin has joined #openstack-nova04:16
openstackgerritArchit Modi proposed openstack/nova stable/pike: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69445004:31
*** ociuhandu has joined #openstack-nova04:40
*** ratailor has joined #openstack-nova04:42
*** ociuhandu has quit IRC04:45
*** ileixe has quit IRC04:46
*** JamesBenson has quit IRC04:58
*** ileixe has joined #openstack-nova04:58
*** ociuhandu has joined #openstack-nova05:00
*** ratailor has quit IRC05:04
*** ratailor has joined #openstack-nova05:04
*** ileixe has quit IRC05:19
*** udesale has joined #openstack-nova05:22
*** awalende has joined #openstack-nova05:28
*** ociuhandu has quit IRC05:28
*** links has joined #openstack-nova05:29
*** ociuhandu has joined #openstack-nova05:30
*** awalende has quit IRC05:33
*** ociuhandu has quit IRC05:36
openstackgerritBrin Zhang proposed openstack/nova-specs master: Add resources metadata of instance  https://review.opendev.org/66356305:41
*** zhanglong has quit IRC05:43
*** Luzi has joined #openstack-nova06:04
*** jbernard has quit IRC06:07
*** jbernard has joined #openstack-nova06:14
*** ociuhandu has joined #openstack-nova06:15
*** jbernard has quit IRC06:19
*** aloga_ has joined #openstack-nova06:32
*** jbernard has joined #openstack-nova06:32
*** gouthamr_ has joined #openstack-nova06:35
*** Jeffrey4l_ has joined #openstack-nova06:36
*** ociuhandu has quit IRC06:37
*** links has quit IRC06:37
*** rcernin has quit IRC06:37
*** trident has quit IRC06:37
*** huaqiang has quit IRC06:37
*** tetsuro has quit IRC06:37
*** yaawang has quit IRC06:39
*** jmlowe has quit IRC06:39
*** mgoddard has quit IRC06:39
*** johnthetubaguy has quit IRC06:39
*** hamzy has quit IRC06:39
*** mtreinish has quit IRC06:39
*** hoonetorg has quit IRC06:39
*** gouthamr has quit IRC06:39
*** antonym has quit IRC06:39
*** amorin has quit IRC06:39
*** brtknr has quit IRC06:39
*** aloga has quit IRC06:39
*** elod_off has quit IRC06:39
*** gryf has quit IRC06:39
*** yankcrime has quit IRC06:39
*** alex_xu has quit IRC06:39
*** Jeffrey4l has quit IRC06:39
*** evrardjp has quit IRC06:39
*** ryn_eq has quit IRC06:39
*** kashyap has quit IRC06:39
*** spotz has quit IRC06:39
*** ileixe has joined #openstack-nova06:39
*** openstackstatus has quit IRC06:40
*** kashyap has joined #openstack-nova06:42
*** spotz has joined #openstack-nova06:42
*** ileixe has quit IRC06:45
openstackgerritBrin Zhang proposed openstack/nova-specs master: Add resources metadata of instance  https://review.opendev.org/66356306:45
*** links has joined #openstack-nova06:48
*** rcernin has joined #openstack-nova06:48
*** trident has joined #openstack-nova06:48
*** huaqiang has joined #openstack-nova06:48
*** tetsuro has joined #openstack-nova06:48
*** yaawang has joined #openstack-nova06:48
*** jmlowe has joined #openstack-nova06:48
*** mgoddard has joined #openstack-nova06:48
*** hamzy has joined #openstack-nova06:48
*** mtreinish has joined #openstack-nova06:48
*** hoonetorg has joined #openstack-nova06:48
*** antonym has joined #openstack-nova06:48
*** amorin has joined #openstack-nova06:48
*** brtknr has joined #openstack-nova06:48
*** elod_off has joined #openstack-nova06:48
*** gryf has joined #openstack-nova06:48
*** alex_xu has joined #openstack-nova06:48
*** evrardjp has joined #openstack-nova06:48
*** ryn_eq has joined #openstack-nova06:48
*** nanzha has quit IRC06:52
*** dpawlik has joined #openstack-nova06:59
*** abaindur has joined #openstack-nova07:00
*** zhanglong has joined #openstack-nova07:00
*** nanzha has joined #openstack-nova07:02
*** dpawlik has quit IRC07:15
*** links has quit IRC07:15
*** rcernin has quit IRC07:15
*** trident has quit IRC07:15
*** huaqiang has quit IRC07:15
*** tetsuro has quit IRC07:15
*** yaawang has quit IRC07:15
*** jmlowe has quit IRC07:15
*** mgoddard has quit IRC07:15
*** hamzy has quit IRC07:15
*** mtreinish has quit IRC07:15
*** hoonetorg has quit IRC07:15
*** antonym has quit IRC07:15
*** amorin has quit IRC07:15
*** brtknr has quit IRC07:15
*** elod_off has quit IRC07:15
*** gryf has quit IRC07:15
*** alex_xu has quit IRC07:15
*** evrardjp has quit IRC07:15
*** ryn_eq has quit IRC07:15
*** links has joined #openstack-nova07:16
*** rcernin has joined #openstack-nova07:16
*** trident has joined #openstack-nova07:16
*** huaqiang has joined #openstack-nova07:16
*** tetsuro has joined #openstack-nova07:16
*** yaawang has joined #openstack-nova07:16
*** jmlowe has joined #openstack-nova07:16
*** mgoddard has joined #openstack-nova07:16
*** hamzy has joined #openstack-nova07:16
*** mtreinish has joined #openstack-nova07:16
*** hoonetorg has joined #openstack-nova07:16
*** antonym has joined #openstack-nova07:16
*** amorin has joined #openstack-nova07:16
*** brtknr has joined #openstack-nova07:16
*** elod_off has joined #openstack-nova07:16
*** gryf has joined #openstack-nova07:16
*** alex_xu has joined #openstack-nova07:16
*** evrardjp has joined #openstack-nova07:16
*** ryn_eq has joined #openstack-nova07:16
*** dpawlik has joined #openstack-nova07:17
openstackgerritShilpa Devharakar proposed openstack/nova master: Ignore root_gb if instance is booted from volume  https://review.opendev.org/61262607:18
openstackgerritShilpa Devharakar proposed openstack/nova master: Handle new is_volume_backend join column query  https://review.opendev.org/69446207:18
openstackgerritShilpa Devharakar proposed openstack/nova master: Instance object changes for the new 'is_volume_backed' expected_attr  https://review.opendev.org/69446307:18
*** chenhaw has joined #openstack-nova07:24
*** ociuhandu has joined #openstack-nova07:27
*** KeithMnemonic has joined #openstack-nova07:29
*** ociuhandu has quit IRC07:29
*** ociuhandu has joined #openstack-nova07:30
*** KeithMnemonic has quit IRC07:34
*** ociuhandu has quit IRC07:41
*** ociuhandu has joined #openstack-nova07:42
*** ociuhandu has quit IRC07:44
*** rcernin has quit IRC07:44
*** ociuhandu has joined #openstack-nova07:45
*** tbachman has joined #openstack-nova07:46
*** slaweq has joined #openstack-nova07:46
*** nanzha has quit IRC07:47
*** nanzha has joined #openstack-nova07:48
*** trident has quit IRC07:49
*** slaweq_ has joined #openstack-nova07:53
*** ociuhandu has quit IRC07:55
*** dpawlik has quit IRC07:56
*** slaweq has quit IRC07:56
*** rpittau|afk is now known as rpittau07:56
*** trident has joined #openstack-nova07:58
*** tkajinam has quit IRC08:00
*** sridharg has joined #openstack-nova08:01
*** ileixe has joined #openstack-nova08:02
*** ileixe has quit IRC08:02
*** bhagyashris has quit IRC08:02
*** slaweq_ is now known as slaweq08:03
*** tbachman has quit IRC08:03
*** dpawlik has joined #openstack-nova08:04
*** ileixe has joined #openstack-nova08:04
*** dpawlik has quit IRC08:08
bauzasgood morning Nova08:08
*** dpawlik has joined #openstack-nova08:10
*** tesseract has joined #openstack-nova08:15
*** bhagyashris has joined #openstack-nova08:17
*** damien_r has joined #openstack-nova08:17
*** gibi_off has quit IRC08:19
*** slaweq_ has joined #openstack-nova08:19
*** gibi has joined #openstack-nova08:19
*** slaweq has quit IRC08:19
*** awalende has joined #openstack-nova08:19
*** ralonsoh has joined #openstack-nova08:32
*** nanzha has quit IRC08:32
*** ociuhandu has joined #openstack-nova08:36
*** nanzha has joined #openstack-nova08:39
awalendeHello, I have trouble passing through an nvidia t4 card to my guests on Rocky. nova-compute log reports the final resource as: pci_stats=[PciDevicePool(count=1,numa_node=1,product_id='1eb8',tags={dev_type='type-PF'},vendor_id='10de')]08:39
awalendeHowever, when I set the alias as alias={"name":"T4","vendor_id":"10de","product_id":"1eb8"} on the controller and alias={"name":"T4","vendor_id":"10de", "product_id":"1eb8"} on compute node does not work08:40
awalendeAlso I wonder, why it is declared as a "PF". I clearly inserted an PCIe card08:41
stephenfinawalende: How have you configured the PCI whitelist in nova.conf?08:42
awalendepassthrough_whitelist={"vendor_id":"10de"}08:42
stephenfinawalende: So this is interesting. The Tesla T4 supports SR-IOV https://www.nvidia.com/content/dam/en-zz/Solutions/Data-Center/tesla-t4/t4-tensor-core-product-brief.pdf08:45
*** slaweq_ is now known as slaweq08:45
*** ivve has joined #openstack-nova08:46
stephenfinand because we're detecting that, we're flagging it as a PF https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6562-L656508:46
awalendeSo there is probably a difference passing them through as other regular gpus?08:46
awalendeCan we pass them even at all?08:47
stephenfinPossibly. I could be wrong, but I do recall that type-PF devices were disabled by default because you typically wouldn't want to use them when you talk about NICs08:47
stephenfinbut it can be enabled08:47
stephenfindo you want to pass through the PF or the VF?08:48
awalendethe whole hardware08:48
awalendeI guess probably the PF....so the usecase is, we want to pass the whole card to the guest. so that they have to install nvidia drivers by themselfs on the guest machine08:48
awalendelike we did with our older Tesla V100 cards08:49
stephenfinSeems like you could get better resource utilization if you passed through the VFs though (since apparently that would give you up to 16 devices)08:50
stephenfinThat doesn't matter for now though08:50
stephenfinIf you want to use type-PF devices, I _think_ you need to either (a) set the 'device_type' flag in the 'alias' config option or (b) make sure the VFs are not whitelisted08:51
awalendeye we already tried to set 'device_type' but it didn't make a difference :(08:51
stephenfinhave you tried (b)?08:52
stephenfinto do that, you'll need to also set the 'product_id' in the 'passthrough_whitelist'08:52
stephenfinto whatever the product_id of the PF is, assuming the PF and VF have different product_id's (they should)08:52
awalendemy colleague means he "maybe" tried it as well. We try it again and let you know08:52
stephenfinIf they don't, you're going to need to use the 'address' field, I'm afraid08:53
stephenfinokay, do please08:53
stephenfinsean-k-mooney might be able to help too but they're definitely fast asleep atm :)08:53
awalendeHow do you make sure that "VFs are not whitelisted"?08:54
bauzasthe T4 ?08:55
bauzasawalende: which grid driver are you using ?08:55
bauzasGRID8 ?08:55
awalendeno driver at all, we plugged the T4 into our hypervisor nodes and want to pass them through to guests08:55
stephenfinawalende: If SR-IOV is enabled on the device, you will have additional PCI devices appearing at e.g. 'lspci'08:56
*** jangutter has joined #openstack-nova08:56
awalendeone moment08:56
stephenfin'lspci | grep -i nvidia' should flag them, I'd imagine08:57
bauzasoh right, then that's normal08:57
bauzasNvidia plans to deliver virtual GPUs as VFs later08:57
bauzasI guess they already started to expose the GPU as a PF08:57
awalendestephenfin, it only shows me one card as af:00.0 3D controller: NVIDIA Corporation TU104GL [Tesla T4] (rev a1)08:57
stephenfinI'm not sure how you'd turn them on/off. Probably by echoing stuff to sysfs like you do for SR-IOV NICs, I guess08:57
bauzasbut I thought the Tesla models wouldn't get it08:57
bauzasjust the Volta ones08:57
bauzasI'm not a nVidia salesperson, (un?)fornutately :p08:58
stephenfinokay, it's probably disabled so08:58
*** nanzha has quit IRC08:58
bauzasawalende: just do something like 'lspci -vv | grep 10de08:59
stephenfinawalende: So there is definitely _something_ specific you need to do in order to use type-PF devices. I'm just trying to figure out what it is08:59
awalendebauzas, returns empty08:59
bauzasmmm08:59
stephenfinawalende: This is what I'm thinking of https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L289-L29709:00
bauzasawalende: are you OK with pasting your whole lspci output ?09:00
stephenfinso if I'm reading that correctly, you *must* set 'dev_type': 'type-PF' in the alias09:00
awalendewhich lspci command to you want pasted? 'lspci -vv'?09:01
bauzasI agree09:01
bauzasawalende: yes please09:01
bauzasstephenfin: looks like you need to expose your type-PF this way09:02
stephenfinwdym?09:02
bauzasbut I'm amazed that nvidia provides a PF and not a straight PCI ID09:02
bauzasstephenfin: you have to expose the PCI devices in nova.conf in order to allow Nova to use them, right?09:03
stephenfinyeah, awalende has done that mostly correctly I think09:03
awalendehttps://paste.ubuntu.com/p/xXkRfFMRYh/09:03
* bauzas clicks09:04
stephenfinthe '[pci] passthrough_whitelist' on the compute node is correct, but the '[pci] alias' on the controller and compute node doesn't appear to be (it needs 'dev_type')09:04
awalendestephenfin, we will try soon!09:04
awalendedoes dev_type needs to be specified on controller and compute?09:05
stephenfinsorry, 'device_type'09:05
stephenfinin the 'alias' option on both09:06
awalendeok, we'll try it09:06
stephenfin alias={"name":"T4","vendor_id":"10de","product_id":"1eb8","device_type":"type-PF"}09:06
stephenfinor something like that09:06
bauzasvery interesting lspci09:07
bauzashttps://paste.ubuntu.com/p/xXkRfFMRYh/ L324109:08
bauzasit shows a SR-IOV capability09:08
bauzasbut no VGA capability (!)09:08
bauzasthat's beyond my comfort zone09:08
stephenfinyeah, it's an accelerator, not a GPU09:09
bauzasmy bad then09:09
bauzasI'm not familiar with the product line09:09
bauzasso we're just talking of PCI passthrugh, not VGA passthru, my bad09:09
bauzasanyway, it doesn't expose a standard PCI address09:10
*** yan0s has joined #openstack-nova09:11
bauzasI just feel that stephenfin is absolutely right, nova punts the address because of the internal conditional he said09:12
*** dave-mccowan has joined #openstack-nova09:14
awalendesomeone rebooted the server =.= one more minute09:15
awalendeok, its spawning :D fingers crossed09:17
awalendeOk, the device shows up in the guest09:20
awalendehooray09:20
awalendeBut why do we explicitly have to specify device_type. In all of our other devices it wasn't really needed.....is it because pci is default?09:21
stephenfinawalende: https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L289-L29709:21
stephenfinIf you have a device that supports SR-IOV, the assumption we've made is that you'll generally want to use that capability because of the scalability it offers09:22
awalendeUhhh just a minor complaint....this isn't documented :D :D. But nice, the T4 is now there in the guest. Thanks all for helping us!09:23
stephenfinSo by default we don't allow you to use the parent/root/PF device because if you do, you won't be able to use the child/VF device(s)09:23
stephenfinAgreed. I'm working on a patch to do that now. I'll stick you on the review once it's up, if you like09:24
awalendesure thing :D09:24
*** nanzha has joined #openstack-nova09:24
*** gibi has quit IRC09:26
awalendeirc name is launchpad name09:27
huaqiangsean-k-mooney: about the per-vm-pci-NUMA-policy spec, I want to confirm that it defines a policy applied to all PCI devices for whole VM, right?09:33
*** ociuhandu has quit IRC09:35
*** huaqiang has quit IRC09:36
*** huaqiang has joined #openstack-nova09:36
*** psachin has quit IRC09:39
*** abaindur has quit IRC09:41
huaqiangsean-k-mooney: seems I have sent my questions we have drawn a conclusion agian by mistake, pls ignore it.09:43
*** xek__ has joined #openstack-nova09:54
*** bhagyashris has quit IRC09:55
*** yankcrime has joined #openstack-nova09:59
openstackgerritLee Yarwood proposed openstack/nova master: WIP block_device: Use original volume_type when creating volumes from snapshots  https://review.opendev.org/69449710:01
*** luksky has joined #openstack-nova10:07
*** udesale has quit IRC10:14
*** udesale has joined #openstack-nova10:15
*** bhagyashris has joined #openstack-nova10:16
openstackgerritLiang Fang proposed openstack/nova-specs master: Support volume local cache  https://review.opendev.org/68907010:21
*** gibi has joined #openstack-nova10:21
*** lpetrut has joined #openstack-nova10:26
*** zhanglong has quit IRC10:29
*** shilpasd has joined #openstack-nova10:30
*** ociuhandu has joined #openstack-nova10:31
*** slaweq has quit IRC10:34
*** chenhaw has quit IRC10:37
*** chenhaw has joined #openstack-nova10:37
*** ociuhandu has quit IRC10:37
*** elod_off is now known as elod10:38
*** ociuhandu has joined #openstack-nova10:38
*** chenhaw has quit IRC10:42
*** ociuhandu has quit IRC10:46
*** zhubx has quit IRC10:51
*** zhubx has joined #openstack-nova10:51
*** tesseract has quit IRC10:52
*** tesseract has joined #openstack-nova10:52
*** mkrai has quit IRC10:53
*** mkrai_ has joined #openstack-nova10:53
*** mkrai__ has joined #openstack-nova10:55
*** mkrai_ has quit IRC10:58
*** JamesBenson has joined #openstack-nova10:59
*** bhagyashris has quit IRC11:01
openstackgerritLee Yarwood proposed openstack/nova-specs master: Virtual instance rescue with stable disk devices  https://review.opendev.org/69384911:01
openstackgerritLee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue  https://review.opendev.org/69406311:01
*** mkrai__ has quit IRC11:02
*** JamesBenson has quit IRC11:03
*** ratailor has quit IRC11:06
*** ratailor has joined #openstack-nova11:06
*** bhagyashris has joined #openstack-nova11:18
*** jawad_axd has joined #openstack-nova11:32
*** rha has left #openstack-nova11:39
openstackgerritStephen Finucane proposed openstack/nova master: docs: Change order of PCI configuration steps  https://review.opendev.org/69452111:46
openstackgerritStephen Finucane proposed openstack/nova master: docs: Clarify configuration steps for PF devices  https://review.opendev.org/69452211:46
stephenfinawalende: ^11:46
stephenfinAlso sean-k-mooney, adrianc: ^11:46
stephenfinI'd like to backport that as far as we can go11:46
* stephenfin -> 🏋️11:46
*** dpawlik has quit IRC11:47
openstackgerritMerged openstack/nova master: Reset vm_state to original value if rebuild claim fails  https://review.opendev.org/69218511:48
openstackgerritStephen Finucane proposed openstack/nova master: docs: Clarify configuration steps for PF devices  https://review.opendev.org/69452211:48
*** dpawlik has joined #openstack-nova11:53
openstackgerritMerged openstack/nova master: FUP for Ib62ac0b692eb92a2ed364ec9f486ded05def39ad  https://review.opendev.org/69355611:53
*** slaweq has joined #openstack-nova11:55
*** ratailor has quit IRC12:00
*** artom has joined #openstack-nova12:01
*** gshippey has joined #openstack-nova12:02
sean-k-mooneystephenfin: im not sure if that is correct12:19
sean-k-mooneyif you dont set the device_type in the alias at all i think it will work with type-PF12:19
sean-k-mooneythe device_type is not required in the alias as far as i remember12:19
sean-k-mooneyif it is present it definetly needs to match12:19
sean-k-mooneyi need to test some sriov stuff later today so ill try this if i have time otherwise ill do it on monday12:20
shilpasdgibi: hi, can you please elaborate on point  'add compute nodes to the aggregates of shared RP aggregates' regarding Shared NFS, so that will think on designing the same12:21
sean-k-mooneythe product id will be differente for the PF vs VF so if you have the correct product id and no VF are allocated  i think it just works but again that is just going off memory i have not tried this in a year or two12:22
shilpasdgibi: at driver level, how ww will get aggragtes associated to shared RP and will map those to compute node? And if compute node already has aggregates (not the same as of shared RP) are we really bother of them?12:25
*** mmethot has quit IRC12:26
*** dpawlik has quit IRC12:28
*** artom has quit IRC12:28
*** mkrai has joined #openstack-nova12:29
*** ociuhandu has joined #openstack-nova12:32
*** dpawlik has joined #openstack-nova12:33
*** jangutter has quit IRC12:33
*** ociuhandu has quit IRC12:37
openstackgerritLee Yarwood proposed openstack/nova master: docs: Extract rescue from reboot  https://review.opendev.org/69452912:37
*** ociuhandu has joined #openstack-nova12:38
*** ociuhandu has quit IRC12:39
gibishilpasd: there are two types of aggregates: there are placement aggregates https://docs.openstack.org/api-ref/placement/#resource-provider-aggregates and there are nova host aggregates https://docs.openstack.org/api-ref/compute/#host-aggregates-os-aggregates12:39
*** ociuhandu has joined #openstack-nova12:39
gibithe disk sharing RP needs to be in the same placement aggregate as the compute RP it shares disk with12:39
gibiwe agreed that a new nova config option will tell the nova compute the uuid of the placement aggregate12:40
gibiin which the admin added the sharing disk RP12:40
openstackgerritLee Yarwood proposed openstack/nova master: docs: Extract rescue from reboot  https://review.opendev.org/69452912:40
gibiso when the compute start up it can change if its own RP (the compute PR) is already part of the placement aggregate configured in it's nova.conf12:41
gibiand if not then call PUT12:41
gibi/resource_providers/{uuid}/aggregatesPUT12:41
gibi/resource_providers/{uuid}/aggregates12:41
gibito put it's compute PR into the that aggregate12:42
gibishilpasd: an PR can be in any number or placement aggregates12:43
gibiso if the compute RP is already in other aggregates that does not really matter to us12:43
*** ociuhandu has quit IRC12:45
openstackgerritLee Yarwood proposed openstack/nova-specs master: Virtual instance rescue with stable disk devices  https://review.opendev.org/69384912:45
openstackgerritLee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue  https://review.opendev.org/69406312:45
shilpasdgibi: new nova config option which holds uuid of the placement aggregate or uuid of the shared RP?12:46
shilpasdand it will at compute level or libvirt level?12:47
gibishilpasd: uuid of the placement aggregate12:49
gibishilpasd: and I think the logic can be in the compute manager level12:49
*** ricolin has joined #openstack-nova12:50
gibishilpasd: have you seen this mailthread ? http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010624.html12:51
shilpasdgibi: no, will go through, thnaks for sharing12:52
gibishilpasd: I think that summarized most of what we talked above12:52
shilpasdgibi: yes, that's clear12:53
shilpasdgibi: thank you12:53
*** bhagyashris has quit IRC12:54
*** zhubx has quit IRC12:54
*** zhubx has joined #openstack-nova12:54
gibishilpasd: you're welcome12:54
openstackgerritMerged openstack/nova master: Add functional recreate test for bug 1852610  https://review.opendev.org/69435112:56
openstackbug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,In progress] https://launchpad.net/bugs/1852610 - Assigned to Matt Riedemann (mriedem)12:56
*** zhubx has quit IRC12:56
*** zhubx has joined #openstack-nova12:56
*** awalende has quit IRC12:59
*** awalende has joined #openstack-nova12:59
*** Luzi has quit IRC13:05
*** dpawlik has quit IRC13:06
*** awalende has quit IRC13:14
*** awalende has joined #openstack-nova13:14
*** awalende has quit IRC13:15
*** mmethot has joined #openstack-nova13:15
*** awalende has joined #openstack-nova13:15
*** ociuhandu has joined #openstack-nova13:16
*** Luzi has joined #openstack-nova13:20
*** jangutter has joined #openstack-nova13:20
*** mriedem has joined #openstack-nova13:23
*** dpawlik has joined #openstack-nova13:45
openstackgerritMatt Riedemann proposed openstack/nova master: Remove duplicate ServerMovingTests._resize_and_check_allocations  https://review.opendev.org/69453813:45
*** mkrai has quit IRC13:47
*** dlbewley has quit IRC13:49
*** sapd1_x has joined #openstack-nova13:55
*** mlavalle has joined #openstack-nova13:56
*** ociuhandu has quit IRC13:58
*** dpawlik has quit IRC14:03
*** dpawlik has joined #openstack-nova14:05
*** ociuhandu has joined #openstack-nova14:05
*** shilpasd has quit IRC14:06
*** nweinber has joined #openstack-nova14:15
*** Luzi has quit IRC14:16
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Add functional recreate test for bug 1852610  https://review.opendev.org/69454414:18
openstackbug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,In progress] https://launchpad.net/bugs/1852610 - Assigned to Matt Riedemann (mriedem)14:18
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Add functional recreate revert resize test for bug 1852610  https://review.opendev.org/69454514:18
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Block deleting compute services with in-progress migrations  https://review.opendev.org/69454614:18
*** tbachman has joined #openstack-nova14:19
*** artom has joined #openstack-nova14:20
*** tbachman_ has joined #openstack-nova14:21
artom"Before posting a comment to any patch, a third party testing system must contact the project they wish to test and get approval to post comments on their patches. This can be done by attending the project’s meeting."14:22
artomFrom https://docs.openstack.org/infra/system-config/third_party.html14:22
artomIs that an actual thing for Nova?14:22
*** tbachman has quit IRC14:23
*** tbachman_ is now known as tbachman14:23
dansmithit's for every project I think14:23
dansmithwe used to have problems with people setting up their own CI and it going haywire and spraying comments everywhere14:23
dansmith(in nova)14:23
artomdansmith, so context is http://post-office.corp.redhat.com/archives/rh-openstack-dev/2019-October/msg00060.html (sorry for the internal-only link)14:23
artomdansmith, and http://post-office.corp.redhat.com/archives/rh-openstack-dev/2019-October/msg00209.html that's sort of a summary of where we ended up after initial discussions14:25
dansmithyou could probably just say "I want to set up a CI system"14:26
artomI want to set up a CI system14:27
artom:D14:27
dansmithbut anyway, yes, there are hoops to jump through14:27
artomYeah14:28
artomInternally as well as here, *sigh*14:28
artomHopefully it'll be worth it14:28
artomI also noticed Mellanox has their own SRIOV CI14:28
artomBut... presumably that only tests their hardware14:28
artomAnd I have no idea what the status is14:28
artomadrianc, ^^ ?14:29
artomAnd the point of RHEx (Red Hat Exotic hardware CI) would be more than just SRIOV, SRIOV is just the initial MVP scope14:29
artomGPUs come to mind14:29
dansmithartom: are you looking for help setting it up? If so, I'm sure the infra people are who you want to talk to14:29
artomdansmith, yeah, that conversation is already happening - migi as well14:30
dansmithack14:30
mriedemi wish the dell emc people would have asked b/c their's comments and always fails14:30
bauzasgibi: I'm about to provide a new revision for the audit command, would it be possible for you to check it with the bandwidth-aware instances ?14:32
bauzas(at least once I'm done with reno)14:32
*** ociuhandu has quit IRC14:32
*** awalende has quit IRC14:33
*** awalende has joined #openstack-nova14:33
*** jawad_axd has quit IRC14:37
*** tbachman has quit IRC14:37
*** awalende_ has joined #openstack-nova14:37
*** awalende has quit IRC14:38
*** jawad_axd has joined #openstack-nova14:38
*** awalende_ has quit IRC14:39
*** jawad_ax_ has joined #openstack-nova14:40
gibibauzas: sure14:40
gibibauzas: If I time out on it today then I will do it next week14:41
bauzasgibi: thanks14:41
bauzashopefully, I'll push it in 20 mins14:41
*** KeithMnemonic has joined #openstack-nova14:41
*** luksky has quit IRC14:42
*** jawad_axd has quit IRC14:43
*** jawad_ax_ has quit IRC14:45
*** sridharg has quit IRC14:45
openstackgerritMerged openstack/nova master: Add functional recreate revert resize test for bug 1852610  https://review.opendev.org/69436414:47
openstackbug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,In progress] https://launchpad.net/bugs/1852610 - Assigned to Matt Riedemann (mriedem)14:47
*** usr2033 has quit IRC14:54
*** tbachman has joined #openstack-nova14:57
*** links has quit IRC14:59
*** jangutter has quit IRC15:00
openstackgerritSylvain Bauza proposed openstack/nova master: Add a placement audit command  https://review.opendev.org/67011215:03
*** eharney has joined #openstack-nova15:04
*** awalende has joined #openstack-nova15:05
*** awalende has quit IRC15:10
*** dpawlik has quit IRC15:10
*** sridharg has joined #openstack-nova15:10
gibieandersson: fyi, I reported a bug about the false error log from the compute you found https://bugs.launchpad.net/nova/+bug/185275915:12
openstackLaunchpad bug 1852759 in OpenStack Compute (nova) rocky "false error log at compute restart during error out stuck instances" [Low,Triaged] - Assigned to Balazs Gibizer (balazs-gibizer)15:12
*** jaosorior has joined #openstack-nova15:13
gibibauzas: building a devstack for your audit patch...15:14
*** ricolin has quit IRC15:18
*** ivve has quit IRC15:24
slaweqmriedem: hi15:29
slaweqmriedem: recently I noticed in neutron job error like https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_300/678438/22/check/neutron-tempest-dvr-ha-multinode-full/3008cc3/testr_results.html.gz15:29
slaweqand I see in nova logs (src host) error while connecting to libvirt on dst node: https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_300/678438/22/check/neutron-tempest-dvr-ha-multinode-full/3008cc3/compute2/logs/screen-n-cpu.txt.gz15:30
slaweqdo You know about such issue or maybe I should create new LP for this?15:30
*** JamesBenson has joined #openstack-nova15:32
artomslaweq, mriedem, doesn't look like a Nova bug: https://zuul.opendev.org/t/openstack/build/3008cc3eeaea44369a2fa3db3a29ae67/log/compute2/logs/screen-n-cpu.txt.gz#339215:32
*** SonPham has joined #openstack-nova15:32
artomJust unable to connect to the dest libvirt15:32
artomNot sure why tho15:32
mriedemyou mean this libvirt.libvirtError: unable to connect to server at 'ubuntu-bionic-rax-dfw-0012676801:49152': Connection refused15:33
slaweqartom: mriedem exactly15:33
mriedemusually need to look at the guest log15:33
mriedembut no this isn't a nova bug15:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests  https://review.opendev.org/68434515:33
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'os-security-group-default-rules' REST API  https://review.opendev.org/68680715:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unused '*_default_rules' security group DB APIs  https://review.opendev.org/68680815:33
openstackgerritStephen Finucane proposed openstack/nova master: Remove (most) '/os-networks' REST APIs  https://review.opendev.org/68680915:33
openstackgerritStephen Finucane proposed openstack/nova master: Remove '/os-tenant-networks' REST API  https://review.opendev.org/68681015:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'USE_NEUTRON' from functional tests  https://review.opendev.org/68681115:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota  https://review.opendev.org/68681215:33
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands  https://review.opendev.org/68681315:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs  https://review.opendev.org/68681415:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary  https://review.opendev.org/68681515:33
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary  https://review.opendev.org/68681615:33
openstackgerritStephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network  https://review.opendev.org/68681715:33
openstackgerritStephen Finucane proposed openstack/nova master: WIP  https://review.opendev.org/68681815:34
slaweqmriedem: artom ok, thx for looking into that15:34
slaweqI will than just leave it alone for now :)15:34
artomslaweq, uh, I think it's trying to live migrate to itself o_O15:35
artomhttps://zuul.opendev.org/t/openstack/build/3008cc3eeaea44369a2fa3db3a29ae67/log/zuul-info/host-info.compute2.yaml#40315:36
*** JamesBenson has quit IRC15:36
artomOh no, that's the controller15:36
mriedemubuntu-bionic-rax-dfw-0012676801 != ubuntu-bionic-rax-dfw-001267680415:36
artommriedem, yeah sorry, got confused15:36
artomBut anyways, something to look into - is the controller running the full nova-compute stack?15:37
*** ociuhandu has joined #openstack-nova15:37
mriedemyes, this is a 3 node job15:37
mriedemdvr-ha-multinode-full makes the lights dim when it runs15:37
artomIt dimmed my lights :(15:38
mriedemyou scamp15:38
*** JamesBenson has joined #openstack-nova15:38
*** JamesBenson has quit IRC15:38
*** JamesBenson has joined #openstack-nova15:39
*** KeithMnemonic1 has joined #openstack-nova15:41
mriedemcpu usage was pretty high on the controller when it failed15:41
mriedemload spiked up around then too15:42
*** ociuhandu has quit IRC15:42
openstackgerritMerged openstack/nova-specs master: Virtual instance rescue with stable disk devices  https://review.opendev.org/69384915:42
artomslaweq, there's your failure: https://zuul.opendev.org/t/openstack/build/3008cc3eeaea44369a2fa3db3a29ae67/log/controller/logs/libvirt/qemu/instance-00000011_log.txt.gz#415:42
artommriedem too if you care ^^15:43
mriedemartom: that's not a faliure15:43
mriedemthat shows up in like every guest log in thegate15:43
artomOh15:43
* artom gives up and goes back to his corner15:43
mriedeme.g. random guest https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_300/678438/22/check/neutron-tempest-dvr-ha-multinode-full/3008cc3/controller/logs/libvirt/qemu/instance-00000023_log.txt.gz15:43
mriedemmy guess is the failure is due to, like many gate failures these days, overloaded nodes crapping out15:44
mriedemthough the rax nodes usually aren't one of them15:44
openstackgerritBalazs Gibizer proposed openstack/nova stable/rocky: Fix false ERROR message at compute restart  https://review.opendev.org/69458115:46
gibieandersson: ^^15:50
*** ociuhandu has joined #openstack-nova15:55
openstackgerritMatt Riedemann proposed openstack/nova master: docs: Extract rescue from reboot  https://review.opendev.org/69452915:56
lyarwoodthanks for that mriedem16:00
openstackgerritMatt Riedemann proposed openstack/nova master: doc: mention that rescuing a volume-backed server is not supported  https://review.opendev.org/69458416:02
mriedemnp16:02
openstackgerritMatt Riedemann proposed openstack/nova master: doc: mention that rescuing a volume-backed server is not supported  https://review.opendev.org/69458416:03
*** nanzha has quit IRC16:04
*** SonPham has quit IRC16:04
*** mmethot has quit IRC16:04
gibibauzas: I hit a bug in https://review.opendev.org/#/c/670112/8/nova/cmd/manage.py@286716:07
mriedemgibi: you were +2 on this before it was rebased a bit in earlier changes https://review.opendev.org/#/c/642591/ - can you hit that again? dansmith - that's also the one where you suggested re-doing the logic so it should be simple and familiar16:08
bauzasgibi: graaah ok, thanks !16:08
gibimriedem: on it.16:08
bauzasgibi: just respinning, sec16:08
gibibauzas: sure, I will retry with the new ps16:09
mriedembauzas: why wouldn't your functional tests hit that?16:09
bauzasmriedem: the CI is still in the weeds16:09
bauzasno result yet16:09
bauzasand I was lazy16:09
mriedembauzas: i meant locally...16:09
mriedemyeah16:09
bauzasbut that's a good call, lemme check16:10
mriedemthis is why i said you don't really need unit testing on these types of commands, it should mostly, if not all, be functional test driven16:10
* gibi notes to run functional test on bauzas patches before pulling them into devstack16:10
bauzasthat's what happens when you do three things at same time...16:10
bauzasmeeting, patching, discussing16:10
bauzasgibi: I just run the functest now16:11
bauzashopefully it will get caught16:11
bauzasoh, and FWIW, I was rushing on updating a new revision, I haven't used yet the COMPUTE_NODE trait or did the split16:12
openstackgerritMerged openstack/nova stable/train: Use admin neutron client to query ports for binding  https://review.opendev.org/69401316:13
*** dlbewley has joined #openstack-nova16:13
bauzasmriedem: I'm not opposed to have most of the logic being checked by functional tests, I just added a few unit tests for sanity :)16:13
*** sridharg has quit IRC16:13
gibibauzas: nova.tests.functional.test_nova_manage.TestNovaManagePlacementAudit.test_audit_orphaned_allocations_from_deleted_compute_evacuate failed for me locally now but with a different error than what I saw in the devstack16:14
mriedemthat's a slippery slope and bad habit to get into with commands like this16:14
mriedemso just, don't do it16:14
gibibauzas:       File "nova/cmd/manage.py", line 2927, in audit16:14
gibi        ctxt, placement, output, provider, delete)16:14
gibi      File "nova/cmd/manage.py", line 2781, in _check_orphaned_allocations_for_provider16:14
gibi        inst_uuids, mig_uuids = result16:14
bauzasgibi: yeah, I just saw it16:14
gibi    TypeError: 'bool' object is not iterable16:14
bauzasI'm on it16:15
gibibauzas: cool16:15
gibimriedem: do you mean sanity is slippery slope with nova manage cli ? :)16:15
bauzasgibi: but for *some* reason, the functests should have caught the argument issue16:15
bauzas(for the microversion)16:16
bauzasI mean, the other issue is unrelateed16:16
bauzasor a side effect16:16
bauzasso, mriedem's point is legit16:16
bauzasI'm leaking coverage here16:16
mriedemgibi: heh, no, i just don't really trust unit tests in nova anymore for anything that involves more than one service or even more than a couple of methods interacting within the same service16:17
mriedemit's too easy to mock things that become false positives16:17
*** jawad_axd has joined #openstack-nova16:18
*** tbarron has quit IRC16:20
bauzasso the bug is fixed, but the argument issue isn't shown16:20
*** jawad_axd has quit IRC16:22
*** dpawlik has joined #openstack-nova16:24
gibimriedem: I share your view regarding the unit tests in nova16:26
bauzas2019-11-15 17:26:12,996 INFO [placement.requestlog] 127.0.0.1 "GET /placement/resource_providers" status: 200 len: 840 microversion: 1.016:27
bauzasmagnifico ^16:27
bauzasthe report client is blindly accepting the 'microversion' keyword16:27
bauzasbut just says "meh" to it16:27
bauzasgibi: mriedem: ^16:27
bauzasI don't see how to catch this unless to mock and assert the call16:28
bauzaswhich is nonsense16:28
gibibauzas: then something is wrong with the placement fixture we use in the functional test16:29
bauzasand, with using the 'version' keyword :16:29
bauzas    2019-11-15 17:29:16,087 INFO [placement.requestlog] 127.0.0.1 "GET /placement/resource_providers" status: 200 len: 1684 microversion: 1.1416:29
bauzaswe probably kwargs16:30
mriedemdef get(self, url, **kwargs): is your problem16:30
bauzasgibi: ^16:30
bauzasheh, this16:30
mriedemlike gibi said it's a bug in the fixture16:30
mriedemSchedulerReportClient.get won't let you pass microversion=16:30
mriedemdef get(self, url, version=None, global_request_id=None):16:30
gibithen it is a good time to fix the fixture16:30
gibi:)16:30
bauzasaaaaand I love to see a bug about some code with a few TODO(sbauza) around it...16:31
* bauzas hides16:31
openstackgerritStephen Finucane proposed openstack/nova master: functional: Change order of two classes  https://review.opendev.org/68917816:33
openstackgerritStephen Finucane proposed openstack/nova master: functional: Rework '_delete_server'  https://review.opendev.org/68917916:33
openstackgerritStephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently  https://review.opendev.org/68918016:33
openstackgerritStephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations  https://review.opendev.org/68918116:33
openstackgerritStephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin'  https://review.opendev.org/68918216:33
* stephenfin crosses fingers and hopes https://review.opendev.org/#/c/692374/ passes16:33
mriedemshould just remove those todos in the placement fixture about passing a token, that's never going to happen if it hasn't happened by now16:33
mriedemwe should like, put a 3 year timer on todos in the code16:33
mriedem"TODO(vishy): do this in grizzly"16:34
gibi:)16:34
openstackgerritSylvain Bauza proposed openstack/nova master: Add a placement audit command  https://review.opendev.org/67011216:36
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove 'adv-config', 'system-admin' subdocs  https://review.opendev.org/68440216:38
openstackgerritStephen Finucane proposed openstack/nova master: docs: Replacing underscores with dashes  https://review.opendev.org/68592916:38
openstackgerritStephen Finucane proposed openstack/nova master: docs: Strip '.rst' suffix  https://review.opendev.org/68726416:38
*** yan0s has quit IRC16:42
stephenfinmelwitt: If you have time before the end of the day, think you could hit this quotas doc patch? https://review.opendev.org/#/c/667165/16:42
stephenfinIt's been around for a few months. Would be nice to close it out16:42
*** macz has joined #openstack-nova16:42
KeithMnemonic1hello all any chance to get some more reviews and a possible WF+1 on this one ? https://review.opendev.org/#/c/683008/16:43
*** TxGirlGeek has joined #openstack-nova16:43
melwittstephenfin: that's a biggun. I'll try to get to it16:43
stephenfinmelwitt: Sure thing. tbh, I'd just forget whatever was there previously and read it like a new doc. If nothing stands out as totally wrong, it's gonna be better than what we have16:44
stephenfinIMO, obv16:44
sean-k-mooneyKeithMnemonic1: i think lyarwood should proably review that16:44
melwittstephenfin: ok, I'll approach it with that in mind16:45
stephenfinta16:47
* stephenfin -> 🏃16:48
stephenfinHave a good weekend, all o/16:48
melwitthappy weekend16:49
*** damien_r has quit IRC16:50
gibibauzas: another bug in https://review.opendev.org/#/c/670112/9/nova/cmd/manage.py@2695 this is also not caught by any functional test as that is green for me on PS916:51
*** rpittau is now known as rpittau|afk16:52
bauzasgibi: thanks16:52
*** bnemec is now known as beekneemech16:52
gibibauzas: don't be confused by the line numbers in my stack trace. I had to cherry-pick your patch top of the nova master in my devstack16:52
melwittgibi: I dunno if you saw this but I attempted to do a TODO you mentioned in the NeutronFixture for fun https://review.opendev.org/69345316:52
bauzasgibi: ack no worries16:52
gibimelwitt: yeah I think I saw it during the PTG but then I got distracted. Looking at it now. Thanks for picking that TODO up16:53
*** udesale has quit IRC16:53
melwittgibi: don't thank me yet haha, I hope I didn't misunderstand16:53
*** eharney has quit IRC16:55
*** luksky has joined #openstack-nova16:56
bauzasgibi: and I get why you catched the error and not my tests16:56
bauzasgibi: that's because when I use the cache, I forget to use the cell mapping16:56
*** sapd1_x has quit IRC16:57
bauzasso, unless you have more than one instance for the same compute, you don't have the problem16:57
bauzas(and I only verify one instance... :) )16:57
KeithMnemonic1thanks sean-k-mooney, lyarwood would you have time in the next few business days to look at it?16:59
KeithMnemonic1can someone please continue the reviews on mriedem patches for the "openstack list marker hang" https://review.opendev.org/#/c/690721/417:00
*** gyee has joined #openstack-nova17:01
sean-k-mooneyKeithMnemonic1: lyarwood for what its worth im +0.5 on it. i dont know htat part of the code well enought to tell if all of the change form queens make sense but the conflcits are called out in the commit and it looks more or less correct17:01
gibibauzas: I have one instance in shutoff state on the compute17:03
*** dpawlik has quit IRC17:03
bauzasno worries, I'm just fixing the bug17:03
gibibauzas: sure17:03
bauzasand thanks, I should actually test it17:04
bauzasit's 6.04pm tho, so I'll just fix the bug and add a TODO in the commit msg for saying I need to add a new func test for it :)17:04
bauzasie. two instances :-)17:04
bauzass/add/modify17:04
gibibauzas: yeah, I will time out soon as well17:05
bauzasactually, you know what ? I'm just gonna amend the test now17:05
bauzasand see whether it's seen17:05
*** tbarron has joined #openstack-nova17:06
*** lpetrut has quit IRC17:10
*** jaosorior has quit IRC17:11
openstackgerritMerged openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69323917:17
*** mriedem is now known as mriedem_afk17:19
*** dpawlik has joined #openstack-nova17:19
*** dpawlik has quit IRC17:25
openstackgerritSylvain Bauza proposed openstack/nova master: Add a placement audit command  https://review.opendev.org/67011217:26
gibimelwitt: two small cleanup suggestion in https://review.opendev.org/#/c/693453/3 then I'm +A17:30
melwittgibi: thanks, will update17:31
gibimelwitt: I thank you :)17:31
* gibi steps away from the keyboard17:33
*** dpawlik has joined #openstack-nova17:35
*** mmethot has joined #openstack-nova17:35
melwitt gibi: thank you for review :)17:35
*** jaosorior has joined #openstack-nova17:39
*** dpawlik has quit IRC17:39
openstackgerritArchit Modi proposed openstack/nova stable/pike: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69445017:42
*** TxGirlGeek has quit IRC17:59
*** TxGirlGeek has joined #openstack-nova17:59
*** TxGirlGeek has quit IRC18:01
*** TxGirlGe_ has joined #openstack-nova18:01
openstackgerritmelanie witt proposed openstack/nova master: Use wrapper class for NeutronFixture get_client  https://review.opendev.org/69345318:02
melwittgibi: updated ^18:04
openstackgerritDustin Cowles proposed openstack/nova-specs master: Update provider config spec for identification conflicts  https://review.opendev.org/69341418:18
eanderssongibi thanks a lot for fixing that bug18:18
*** tbachman has quit IRC18:18
eanderssonI completely forgot to open a bug for it.18:19
*** KeithMnemonic1 has quit IRC18:19
*** tbachman has joined #openstack-nova18:20
*** ralonsoh has quit IRC18:20
*** ivve has joined #openstack-nova18:21
*** jaosorior has quit IRC18:26
gibimelwitt: +2 thank you!18:26
gibieandersson: no worries18:26
*** eharney has joined #openstack-nova18:26
melwittthanks!18:26
*** jaosorior has joined #openstack-nova18:40
*** artom has quit IRC18:42
*** ociuhandu has quit IRC18:47
*** jaosorior has quit IRC18:50
*** jawad_axd has joined #openstack-nova18:55
*** pcaruana has quit IRC18:56
*** ociuhandu has joined #openstack-nova19:00
*** KeithMnemonic1 has joined #openstack-nova19:00
*** tesseract has quit IRC19:04
*** ociuhandu has quit IRC19:10
*** jmlowe has quit IRC19:12
*** trident has quit IRC19:20
openstackgerritMatt Riedemann proposed openstack/nova master: doc: mention that rescuing a volume-backed server is not supported  https://review.opendev.org/69458419:21
*** mriedem_afk is now known as mriedem19:23
*** trident has joined #openstack-nova19:29
*** jmlowe has joined #openstack-nova19:34
*** artom has joined #openstack-nova19:36
*** mriedem has quit IRC19:37
*** mriedem has joined #openstack-nova19:42
*** jawad_axd has quit IRC19:43
*** TxGirlGe_ has quit IRC19:53
*** JamesBen_ has joined #openstack-nova19:59
*** lennyb has quit IRC20:00
*** JamesBenson has quit IRC20:02
*** JamesBenson has joined #openstack-nova20:03
*** JamesBenson has quit IRC20:03
*** JamesBenson has joined #openstack-nova20:03
*** JamesBen_ has quit IRC20:03
efriedmelwitt: aren't you doing something with host status UNKNOWN? http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010887.html20:29
efriedah https://blueprints.launchpad.net/nova/+spec/policy-rule-for-host-status-unknown20:29
*** TxGirlGeek has joined #openstack-nova20:30
*** awalende has joined #openstack-nova20:34
*** awalende has quit IRC20:38
*** slaweq has quit IRC20:50
*** spatel has joined #openstack-nova20:55
*** nweinber has quit IRC20:56
*** spatel has quit IRC20:59
*** JamesBenson has quit IRC21:11
*** slaweq has joined #openstack-nova21:11
*** gshippey has quit IRC21:12
*** slaweq has quit IRC21:16
mriedems/doing/done/!21:27
* mriedem proxies the melwitt mic drop21:28
*** JamesBenson has joined #openstack-nova21:37
*** zhubx has quit IRC21:37
*** zhubx has joined #openstack-nova21:37
*** TxGirlGeek has quit IRC21:58
*** TxGirlGeek has joined #openstack-nova21:59
*** alex_xu has quit IRC22:01
efriedyeah, once I saw I had even approved it, it all came back to me.22:07
*** kaisers has joined #openstack-nova22:30
*** kaisers1 has quit IRC22:32
*** JamesBenson has quit IRC22:41
*** JamesBenson has joined #openstack-nova22:42
*** TxGirlGeek has quit IRC22:43
*** TxGirlGeek has joined #openstack-nova22:46
*** JamesBenson has quit IRC22:46
*** KeithMnemonic1 has quit IRC22:50
openstackgerritMerged openstack/nova master: Always trait the compute node RP with COMPUTE_NODE  https://review.opendev.org/68897923:01
openstackgerritMerged openstack/nova master: docs: Extract rescue from reboot  https://review.opendev.org/69452923:01
*** KeithMnemonic has quit IRC23:08
openstackgerritMerged openstack/nova master: Remove fixed sqlalchemy-migrate deprecation warning filters  https://review.opendev.org/69070423:11
*** slaweq has joined #openstack-nova23:11
efriedmriedem: quick ack on https://review.opendev.org/#/c/689823/ if you can please23:13
*** slaweq has quit IRC23:16
*** rcernin has joined #openstack-nova23:17
mriedemi thought you thought set commands should be a full overwrite?23:17
efriedmriedem: Didn't we agree earlier that adding --amend to a `set` would mean "add on"?23:22
efriedAnd there's no way to do partial removals with --amend, you have to implement an `unset`?23:22
efriedI don't love it, but it's simple(r than the alternatives)23:23
mriedemi left some comments23:24
mriedemwe have some docs to update23:24
*** mmethot has quit IRC23:26
efriedThanks mriedem. I actually tried `set` with no ``-trait`` before I posted my comments, it does indeed wipe out all the traits on the provider.23:40
efriedWith that, I'm out o/23:41
mriedem\o23:41
mriedemjust played the clean version of big poppa by notorious big to my kid and had to explain what "macking" means23:48
mriedemharder than you'd think23:48
openstackgerritMatt Riedemann proposed openstack/nova master: Add RevertResizeTask  https://review.opendev.org/63804623:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method  https://review.opendev.org/63804723:49
openstackgerritMatt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API  https://review.opendev.org/63804823:49
openstackgerritMatt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server  https://review.opendev.org/63826823:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test  https://review.opendev.org/65165023:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellWeigher  https://review.opendev.org/61435323:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration  https://review.opendev.org/66185923:49
openstackgerritMatt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event  https://review.opendev.org/65847823:49
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest  https://review.opendev.org/69199123:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.opendev.org/63826923:49
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job  https://review.opendev.org/65665623:50
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim  https://review.opendev.org/68883223:50
*** mriedem has quit IRC23:50
*** mdbooth has quit IRC23:53
*** mdbooth has joined #openstack-nova23:55
*** mmethot has joined #openstack-nova23:55
*** macz has quit IRC23:56
« Thursday, 2019-11-14 Index Saturday, 2019-11-16 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!