Tuesday, 2019-11-05

*** tbachman has joined #openstack-nova00:02
*** jawad_axd has joined #openstack-nova00:04
*** jawad_axd has quit IRC00:08
*** artom has joined #openstack-nova00:11
*** Liang__ has quit IRC00:12
*** ociuhandu has joined #openstack-nova00:12
*** rajinir has quit IRC00:19
*** ociuhandu has quit IRC00:21
*** ociuhandu has joined #openstack-nova00:22
*** rajinir has joined #openstack-nova00:24
*** ivve has quit IRC00:25
*** ociuhandu has quit IRC00:26
*** Liang__ has joined #openstack-nova00:33
*** Liang__ has quit IRC00:36
*** ociuhandu has joined #openstack-nova00:36
*** jawad_axd has joined #openstack-nova00:46
*** dave-mccowan has joined #openstack-nova00:47
*** gyee has quit IRC00:48
*** rajinir has quit IRC00:48
*** ociuhandu has quit IRC00:49
*** macz has quit IRC00:49
*** jawad_axd has quit IRC00:50
*** mriedem has joined #openstack-nova00:51
*** rajinir has joined #openstack-nova00:54
openstackgerritMerged openstack/nova stable/train: Nova compute: add in log exception to help debug failures  https://review.opendev.org/69266200:54
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Nova compute: add in log exception to help debug failures  https://review.opendev.org/69293600:56
*** TxGirlGeek has quit IRC01:00
*** jawad_axd has joined #openstack-nova01:07
*** jawad_axd has quit IRC01:11
*** bnemec has quit IRC01:12
gibi_ptgefried: thanks for pushing the evacute patches for qos. I think https://blueprints.launchpad.net/nova/+spec/support-move-ops-with-qos-ports-ussuri is incorrectly put into completed state. I still need to implement support for live migrate and unshelve with qos as the bp describes01:20
*** ociuhandu has joined #openstack-nova01:23
*** ociuhandu has quit IRC01:34
*** slaweq_ has joined #openstack-nova01:35
*** slaweq__ has joined #openstack-nova01:39
*** slaweq_ has quit IRC01:41
*** dave-mccowan has quit IRC01:43
*** adrianc_ has joined #openstack-nova01:45
*** jawad_axd has joined #openstack-nova01:48
*** rajinir has quit IRC01:48
*** tkajinam has joined #openstack-nova01:52
*** jawad_axd has quit IRC01:53
*** rajinir has joined #openstack-nova01:54
*** bnemec has joined #openstack-nova01:58
*** dave-mccowan has joined #openstack-nova02:00
mriedemgibi_ptg: fixed02:00
gibi_ptgmriedem: thanks02:02
*** dave-mccowan has quit IRC02:08
mriedemit's alive http://www.danplanet.com/blog/2019/11/04/start-and-monitor-image-pre-cache-operations-in-nova/02:15
*** adrianc_ has quit IRC02:16
*** adrianc_ has joined #openstack-nova02:16
gibi_ptgmriedem: I will mention it in the nova project update as something we already done from the Ussuri plans02:18
mriedemthe image cache thing? yeah good idea.02:19
gibi_ptgyepp02:19
gibi_ptgthe image download already come up in the war stories session yesterday02:19
*** slaweq__ has quit IRC02:23
*** ociuhandu has joined #openstack-nova02:28
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Create BDM in API during attach volume  https://review.opendev.org/69294002:29
*** ociuhandu has quit IRC02:36
*** bnemec has quit IRC02:37
*** Liang__ has joined #openstack-nova02:39
*** tkajinam has quit IRC02:40
*** slaweq has joined #openstack-nova02:45
*** adrianc_ has quit IRC02:46
*** adrianc_ has joined #openstack-nova02:46
*** mriedem has quit IRC02:47
*** rajinir has quit IRC02:48
*** jawad_axd has joined #openstack-nova02:50
*** bnemec has joined #openstack-nova02:52
*** ricolin has joined #openstack-nova02:53
*** adrianc__ has joined #openstack-nova02:53
*** rajinir has joined #openstack-nova02:53
*** adrianc_ has quit IRC02:54
*** adrianc_ has joined #openstack-nova02:54
*** jawad_axd has quit IRC02:55
*** yaawang_ has joined #openstack-nova02:55
*** Liang__ has quit IRC02:56
*** adrianc__ has quit IRC02:58
*** yaawang has quit IRC02:58
*** adrianc__ has joined #openstack-nova03:11
*** adrianc_ has quit IRC03:14
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add integration testing for heal_allocations  https://review.opendev.org/69292303:16
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add regression test for bug 1824435  https://review.opendev.org/69290603:16
openstackbug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt)03:16
openstackgerritmelanie witt proposed openstack/nova stable/stein: Remove redundant call to get/create default security group  https://review.opendev.org/69290703:16
*** adrianc__ has quit IRC03:16
*** adrianc__ has joined #openstack-nova03:32
*** ricolin has quit IRC03:35
*** psachin has joined #openstack-nova03:38
*** slaweq has quit IRC03:40
*** ricolin has joined #openstack-nova03:41
*** bnemec has quit IRC03:56
*** ricolin has quit IRC03:57
*** bnemec has joined #openstack-nova03:57
*** ricolin has joined #openstack-nova03:57
*** adrianc__ has quit IRC03:58
*** adrianc__ has joined #openstack-nova04:07
*** ricolin has quit IRC04:13
*** takashin has joined #openstack-nova04:23
*** yaawang_ has quit IRC04:23
*** adrianc__ has quit IRC04:25
*** yaawang_ has joined #openstack-nova04:26
*** bnemec has quit IRC04:26
*** adrianc__ has joined #openstack-nova04:29
*** adrianc__ has quit IRC04:30
*** bhagyashris has joined #openstack-nova04:36
*** larainema has joined #openstack-nova04:41
*** Liang__ has joined #openstack-nova05:02
*** Liang__ has quit IRC05:13
*** brault has quit IRC05:17
gibi_ptgnova project update went OK in Shanghai. We got questions about SRIOV live migration with bonded virtio interface for failover. adrianc wil; lead a discussion around it on the PTG05:20
*** ricolin has joined #openstack-nova05:23
*** ileixe has quit IRC05:24
*** slaweq has joined #openstack-nova05:24
*** slaweq_ has joined #openstack-nova05:28
*** ileixe has joined #openstack-nova05:28
*** slaweq has quit IRC05:29
*** ileixe has quit IRC05:33
*** ileixe has joined #openstack-nova05:33
*** pcaruana has joined #openstack-nova05:41
*** ileixe has quit IRC05:44
*** slaweq_ has quit IRC05:45
*** ileixe has joined #openstack-nova05:47
*** links has joined #openstack-nova05:47
*** rajinir has quit IRC05:48
*** rajinir has joined #openstack-nova05:49
*** ricolin has quit IRC05:50
*** bhagyashris has quit IRC06:08
*** yaawang_ has quit IRC06:22
*** yaawang_ has joined #openstack-nova06:23
*** ratailor has joined #openstack-nova06:24
*** bhagyashris has joined #openstack-nova06:56
*** Liang__ has joined #openstack-nova07:07
*** Liang__ has quit IRC07:14
*** Liang__ has joined #openstack-nova07:15
*** jawad_axd has joined #openstack-nova07:15
*** lpetrut has joined #openstack-nova07:16
*** slaweq_ has joined #openstack-nova07:16
*** lpetrut has quit IRC07:16
*** lpetrut has joined #openstack-nova07:17
*** ricolin has joined #openstack-nova07:17
*** slaweq__ has joined #openstack-nova07:20
*** slaweq_ has quit IRC07:22
*** dpawlik has joined #openstack-nova07:31
*** ircuser-1 has joined #openstack-nova07:34
*** ociuhandu has joined #openstack-nova07:37
*** ociuhandu has quit IRC07:37
*** ociuhandu has joined #openstack-nova07:38
*** luksky has joined #openstack-nova07:39
*** ociuhandu has quit IRC07:43
*** ricolin_ has joined #openstack-nova07:45
*** Liang__ has quit IRC07:46
*** ricolin has quit IRC07:47
*** bhagyashris has quit IRC07:55
*** ricolin_ has quit IRC08:04
*** Liang__ has joined #openstack-nova08:04
*** ricolin_ has joined #openstack-nova08:04
*** damien_r has joined #openstack-nova08:11
*** bhagyashris has joined #openstack-nova08:12
*** ociuhandu has joined #openstack-nova08:14
*** slaweq__ has quit IRC08:19
*** slaweq has joined #openstack-nova08:19
*** tesseract has joined #openstack-nova08:24
*** bnemec has joined #openstack-nova08:25
openstackgerritTushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP  https://review.opendev.org/65018808:26
*** takashin has left #openstack-nova08:30
*** ociuhandu has quit IRC08:30
*** ociuhandu has joined #openstack-nova08:31
*** ociuhandu has quit IRC08:33
*** ociuhandu has joined #openstack-nova08:34
*** Liang__ has quit IRC08:35
*** ociuhandu has quit IRC08:35
*** ociuhandu has joined #openstack-nova08:36
*** ricolin_ has quit IRC08:37
*** zbr|ooo is now known as zbr08:38
*** bhagyashris has quit IRC08:39
*** bhagyashris has joined #openstack-nova08:40
*** ociuhandu has quit IRC08:40
*** ociuhandu has joined #openstack-nova08:41
*** ociuhandu has quit IRC08:42
*** ociuhandu has joined #openstack-nova08:43
*** mkrai has joined #openstack-nova08:44
*** ociuhandu has quit IRC08:44
*** ociuhandu has joined #openstack-nova08:45
*** bnemec has quit IRC08:50
*** ociuhandu has quit IRC08:51
*** ociuhandu has joined #openstack-nova08:52
*** ralonsoh has joined #openstack-nova08:52
*** ociuhandu has quit IRC08:55
*** ociuhandu has joined #openstack-nova08:56
*** ociuhandu has quit IRC08:57
*** ociuhandu has joined #openstack-nova08:58
*** ociuhandu has quit IRC08:59
*** ociuhandu has joined #openstack-nova09:00
*** ociuhandu has quit IRC09:03
*** ociuhandu has joined #openstack-nova09:03
*** slaweq has quit IRC09:04
*** bhagyashris_ has joined #openstack-nova09:06
*** bhagyashris has quit IRC09:09
*** jistr is now known as jistr|mtgs09:10
*** mvkr has quit IRC09:17
*** bhagyashris_ has quit IRC09:18
*** bhagyashris has joined #openstack-nova09:18
*** bhagyashris_ has joined #openstack-nova09:18
*** ociuhandu has quit IRC09:23
*** ociuhandu has joined #openstack-nova09:23
*** arxcruz is now known as arxcruz|off09:24
*** ociuhandu has quit IRC09:25
*** ociuhandu has joined #openstack-nova09:25
*** ociuhandu has quit IRC09:27
*** ociuhandu has joined #openstack-nova09:27
*** ociuhandu has quit IRC09:29
*** ociuhandu has joined #openstack-nova09:30
*** ociuhandu has quit IRC09:31
*** ociuhandu has joined #openstack-nova09:32
*** ociuhandu has quit IRC09:39
*** ociuhandu has joined #openstack-nova09:40
*** ociuhandu has quit IRC09:41
*** ociuhandu has joined #openstack-nova09:42
*** bhagyashris__ has joined #openstack-nova09:43
*** derekh has joined #openstack-nova09:43
*** bhagyashris_ has quit IRC09:45
*** bhagyashris_ has joined #openstack-nova09:46
*** bhagyashris has quit IRC09:46
*** mkrai has quit IRC09:56
*** derekh has quit IRC10:01
*** derekh has joined #openstack-nova10:01
*** ygk_12345 has joined #openstack-nova10:10
*** ociuhandu has quit IRC10:23
*** bhagyashris__ has quit IRC10:23
*** bhagyashris_ has quit IRC10:23
*** ociuhandu has joined #openstack-nova10:23
*** ociuhandu has quit IRC10:25
*** ociuhandu has joined #openstack-nova10:26
*** dtantsur|afk is now known as dtantsur10:26
*** bhagyashris__ has joined #openstack-nova10:30
*** bhagyashris_ has joined #openstack-nova10:30
*** davee__ has quit IRC10:31
*** ygk_12345 has quit IRC10:32
*** davee__ has joined #openstack-nova10:32
*** davee__ has quit IRC10:33
*** davee__ has joined #openstack-nova10:34
*** davee__ has quit IRC10:35
*** ivve has joined #openstack-nova10:46
*** dpawlik has quit IRC10:48
*** mkrai has joined #openstack-nova10:53
*** ociuhandu has quit IRC10:57
*** ociuhandu has joined #openstack-nova10:57
*** ociuhandu has quit IRC10:59
*** ociuhandu has joined #openstack-nova11:00
openstackgerritAdit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found  https://review.opendev.org/67924711:06
*** dpawlik has joined #openstack-nova11:06
openstackgerritAdit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found  https://review.opendev.org/67924711:13
*** dpawlik has quit IRC11:14
*** dpawlik has joined #openstack-nova11:16
*** ociuhandu has quit IRC11:18
*** mkrai has quit IRC11:21
*** ratailor has quit IRC11:30
*** ociuhandu has joined #openstack-nova11:34
*** ociuhandu has quit IRC11:45
*** tbachman has quit IRC11:48
*** mvkr has joined #openstack-nova12:00
*** dviroel has joined #openstack-nova12:06
*** dpawlik has quit IRC12:10
*** luksky has quit IRC12:13
*** henriqueof has quit IRC12:16
*** bhagyashris__ has quit IRC12:28
*** bhagyashris_ has quit IRC12:28
*** ociuhandu has joined #openstack-nova12:30
*** larainema has quit IRC12:32
*** dpawlik has joined #openstack-nova12:44
*** ociuhandu has quit IRC12:50
openstackgerritya.wang proposed openstack/nova-specs master: Re-propose expose-auto-converge-post-copy spec for Ussuri  https://review.opendev.org/68719912:50
*** ociuhandu has joined #openstack-nova12:50
*** Garyx has quit IRC12:53
*** ociuhandu has quit IRC12:56
*** tbachman has joined #openstack-nova13:06
efriedgibi_ptg: thanks for the update, and thanks to y'all for covering the session.13:07
efriedand sorry about prematurely completing that bp, forgot about the lm bits.13:07
*** derekh has quit IRC13:09
*** jangutter has joined #openstack-nova13:10
*** ygk_12345 has joined #openstack-nova13:11
sean-k-mooneyis the PTG starting tonight13:14
*** jistr|mtgs is now known as jistr13:14
gibi_ptgsean-k-mooney: it starting wednesday morning shanghai time13:17
gibi_ptgefried: no problemo13:17
*** tbachman has quit IRC13:17
sean-k-mooneygibi_ptg: ya so thats 12-16 from now right is tuesday evenig/night for you now?13:18
*** tbachman has joined #openstack-nova13:18
sean-k-mooneyye are utc+8 right?13:19
gibi_ptg21:19 local time13:19
sean-k-mooneyya that is what i guessed cool13:19
*** Liang__ has joined #openstack-nova13:24
*** ociuhandu has joined #openstack-nova13:28
*** luksky has joined #openstack-nova13:37
*** ociuhandu has quit IRC13:37
openstackgerritMerged openstack/nova stable/stein: Nova compute: add in log exception to help debug failures  https://review.opendev.org/69293613:50
openstackgerritMerged openstack/nova stable/queens: cleanup evacuated instances not on hypervisor  https://review.opendev.org/68787313:50
openstackgerritMerged openstack/nova stable/queens: Add functional test for resize crash compute restart revert  https://review.opendev.org/68787413:50
openstackgerritMerged openstack/nova stable/queens: Prevent init_host test to interfere with other tests  https://review.opendev.org/68787613:50
openstackgerritMerged openstack/nova stable/queens: Functional reproduce for bug 1833581  https://review.opendev.org/68787713:50
openstackbug 1833581 in OpenStack Compute (nova) queens "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Elod Illes (elod-illes)13:50
openstackgerritMerged openstack/nova stable/queens: Error out interrupted builds  https://review.opendev.org/68787813:50
*** eharney has quit IRC13:53
*** macz has joined #openstack-nova13:55
*** mriedem has joined #openstack-nova13:58
*** amodi has quit IRC13:58
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Nova compute: add in log exception to help debug failures  https://review.opendev.org/69300914:06
*** mkrai has joined #openstack-nova14:07
*** xek has joined #openstack-nova14:11
*** mvkr has quit IRC14:19
*** yaawang_ has quit IRC14:19
*** yaawang has joined #openstack-nova14:20
*** lbragstad_ has joined #openstack-nova14:22
*** lbragstad has quit IRC14:23
mriedemdansmith: here is that follow up https://review.opendev.org/#/c/692856/ - the next one after it is really simple as well14:24
*** slaweq has joined #openstack-nova14:27
*** jaosorior has joined #openstack-nova14:29
*** slaweq_ has joined #openstack-nova14:32
*** slaweq has quit IRC14:32
*** mvkr has joined #openstack-nova14:32
*** jangutter has quit IRC14:33
*** ygk_12345 has left #openstack-nova14:36
*** xek has quit IRC14:40
*** amodi has joined #openstack-nova14:42
*** links has quit IRC14:48
*** eharney has joined #openstack-nova14:49
*** mvkr has quit IRC14:56
*** xek has joined #openstack-nova14:58
*** tbachman has quit IRC14:59
*** slaweq_ is now known as slaweq14:59
*** jawad_axd has quit IRC15:00
*** derekh has joined #openstack-nova15:02
*** ociuhandu has joined #openstack-nova15:03
*** jawad_axd has joined #openstack-nova15:04
*** dpawlik has quit IRC15:05
artommriedem, left a thought on https://review.opendev.org/#/c/594139/115:06
*** watersj has joined #openstack-nova15:07
*** ociuhandu has quit IRC15:07
watersjHow do I cancel a pre-migration task? It is stuck and will not complete15:07
watersj?15:07
*** slaweq has quit IRC15:08
*** jawad_axd has quit IRC15:09
mriedemwatersj: i think you're looking for https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-live-migration-abort15:09
*** mvkr has joined #openstack-nova15:09
*** slaweq__ has joined #openstack-nova15:11
*** jmlowe has quit IRC15:11
watersjmriedem, I get instance is in an invalid state 40915:12
*** jamesdenton has quit IRC15:13
*** jmlowe has joined #openstack-nova15:14
*** jamesdenton has joined #openstack-nova15:15
*** jawad_axd has joined #openstack-nova15:18
efriedmriedem: not sure if we do this for storyboard bugs, but https://review.opendev.org/69302815:18
mriedemwatersj: what is the migration status for that instance? you can use https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-server-migration-list15:19
mriedemefried: e-r doesn't support storyboard15:19
*** slaweq__ has quit IRC15:19
mriedemhttps://storyboard.openstack.org/#!/story/200474515:20
efriedoh. Oh well. The logstash query works. Is there a way to make it stick?15:20
dansmithmriedem: WAT :P15:20
mriedemefried: you could use https://bugs.launchpad.net/python-openstackclient/ ?15:20
mriedemoops15:20
efriedyeah15:20
mriedemefried: i meant https://bugs.launchpad.net/openstack-gate15:20
mriedemthat's the catch all15:20
efriedOkay.15:21
mriedemartom: i'm looking and responding, but it's...complicated15:21
artommriedem, I believe you :)15:22
*** macz has quit IRC15:23
*** macz has joined #openstack-nova15:23
efriedmriedem: done, thanks.15:24
*** macz has quit IRC15:25
mriedemartom: replied15:28
artommriedem, ack, lemme dig into that15:30
mriedemtl;dr the neutronv2/api code is a gd mess when it comes to migrations15:30
mriedemthere are like at least 6 methods involved in mucking with port bindings15:30
*** tbachman has joined #openstack-nova15:30
artommriedem, I guess it comes down to "are we backporting this?"15:37
artomIf not, we can invest in a more thorough refactor/rethink15:37
mriedemit probably depends on if sean-k-mooney can recreate the failure in a real env and confirm the bug and the fix15:38
mriedemon...rocky15:38
mriedemlike i said in the change over a year ago, "Waiting for Sean Mooney to test this out in his environment since he was  able to generate the issue and report the bug, so I want to know if  this fixes it. Also, I want Miguel to take a look at this given my  assumptions about how I thought neutron would handle the source host  binding when the dest binding is deleted."15:38
mriedemeven if we did backport, i could do either of my 1 or 2 options and make it backportable15:39
mriedemand add a wrapper/convenience method which doesn't get backported that calls both the activate and teardown methods under the covers15:40
*** ociuhandu has joined #openstack-nova15:40
sean-k-mooneyam what do i need to repoduce? reads back15:41
*** jaosorior has quit IRC15:41
mriedemhttps://review.opendev.org/#/c/594139/15:41
artomI kinda wonder what ovs-dpdk and/or hugepages have to do with it15:42
sean-k-mooneymriedem: that sounds like https://review.opendev.org/#/c/653506/15:42
artomSeems like we could repro it in func tests with an instance with some ports15:42
sean-k-mooneyalthough i need to reload the context for both back into my head15:43
mriedemartom: the neutron fixture would have to start tracking port bindings and do it correctly, which i'm not entirely confident in how that api works - which is why we have this bug in the first place15:43
mriedemi.e. deleting an inactive port binding does not automatically activate the other port binding15:44
mriedembut activating an inactive port binding automatically deactivates the previously active port binding15:44
artommriedem, ah, right15:44
mriedemfrom my commit message, "I had assumed neutron would automatically activate the old remaining port binding when the dest host port binding was deleted, like how neutron automatically deactivates the source host binding when the dest host binding is activated, but apparently that is not the case, so we have to do it ourselves on rollback."15:44
artommriedem, yep - as I said in my first comment, I can't speak to the raison d'etre of the patch15:45
artomJust the mechanics (assuming we need it in the first place)15:46
mriedemso i think tl;dr on live migration rollback since rocky we leave the source host port bindings inactive and you likely need to do something to resolve that, i'm not sure that the heal instance periodic fixes it15:46
sean-k-mooneyyep15:46
sean-k-mooneywell we have two patach to resovle to related edgecases already15:46
sean-k-mooneyartom: what bug are you looking at15:47
artomsean-k-mooney, https://bugs.launchpad.net/nova/+bug/178801415:47
openstackLaunchpad bug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] - Assigned to Matt Riedemann (mriedem)15:47
watersjmriedem, vm status is pre-migrating15:47
mriedemhttps://review.opendev.org/#/c/603844/ landed in stein but i'm not sure that heals the port binding on the source host either15:47
*** slaweq__ has joined #openstack-nova15:47
mriedemwatersj: i wanted to know the migration record status, not the server vm_state15:48
mriedemor maybe that's what you meant15:48
sean-k-mooneyso that is a duplicate of https://bugs.launchpad.net/nova/+bug/182288415:48
openstackLaunchpad bug 1822884 in OpenStack Compute (nova) "live migration fails due to port binding duplicate key entry in post_live_migrate" [Medium,In progress] - Assigned to sean mooney (sean-k-mooney)15:48
watersjmriedem, output from server-migration-list is empty15:48
*** ociuhandu has quit IRC15:48
mriedemi guess because the api doesn't consider pre-migrating as in-progress...i think i found that out recently15:49
artommriedem, wait, that rings a bell15:49
mriedemanyway, https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-live-migration-abort won't do anything for a pre-migrating migration, only running/queued/preparing15:49
mriedemartom: yeah i noticed it when reviewing your numa live migration series15:49
sean-k-mooneythere was a seperate issue with evacuate and pre-migrationg that artom might be thinking of15:50
artommriedem, oh right - https://review.opendev.org/#/c/684409/15:50
watersjthis is stein that I am running15:50
mriedembecause in the long ago live migration records didn't have pre-migrating since that was only done during the RT claim15:50
artomBut my patch only changes the non-API version of that query15:50
artomWhich is your comment on https://review.opendev.org/#/c/684409/1/nova/db/sqlalchemy/api.py@443115:51
mriedemright, so the api only shows in-progress live migrations when they have status "'queued', 'preparing', 'running'"15:52
mriedemwhich watersj just confirmed15:52
mriedemeven though arguably 'accepted' and 'pre-migrating' could be considered in-progress15:52
mriedemor as in-progress as queued15:52
*** slaweq__ has quit IRC15:52
mriedemwatersj: did you trace down where the migration request failed and got stuck?15:53
artommriedem, I think that has to do with when they get put in the queue15:53
artomIOW, you can't abort it if it's not in the queue yet15:53
mriedemwatersj: if the guest is still on the source host then nothing has really changed. you would likely have to manually change the migration record status to 'error' and reset the instance vm_state to 'active' and task_state to None15:53
*** lpetrut has quit IRC15:54
watersjno, looking at nova-compute logs did not give me much info. Currently vm is down and I trying to get it back on15:54
*** ociuhandu has joined #openstack-nova15:54
watersji did change its state ti error15:54
watersjand then active15:54
mriedemwatersj: ok, so you'll have to set the migration record status to 'error' and hard reboot the guest i think15:54
sean-k-mooneyartom: mriedem by the way i though when we got to post-copy stage we cant rollback anymore15:54
mriedemwatersj: the instances table record or the migrations table record?15:54
mriedemthose are different records15:54
*** TxGirlGeek has joined #openstack-nova15:55
watersj1sec15:55
artomsean-k-mooney, yeah, but... is that relevant here?15:56
watersji ran nova reset-state <name>15:56
artomAlso, which "here"? watersj's issue, or https://review.opendev.org/#/c/594139/1 ?15:56
watersji ran nova reset-state --active <name>15:56
mriedemwatersj: that just updates the server's vm/task states, it doesn't do anything with a stopped guest15:56
sean-k-mooneyartom: for mriedem commit "If we've reached the point of post-copy during live migration on the source host and activated the destination host port bindings, but then something fails and we have to rollback,"15:56
watersjthe guest is not running15:56
watersjthat is confirmed15:56
mriedemright, that's why i said you'll have to hard reboot it15:57
*** watersj has left #openstack-nova15:57
mriedemto get it back to active/running for real15:57
mriedembye!15:57
artomYou're welcome?15:57
artomsean-k-mooney, huh, good spot15:57
*** watersj has joined #openstack-nova15:57
artomOnce we're in post-copy, we can't rollback, as the VM is now running on the dest15:57
sean-k-mooneyyes15:57
artomhttps://wiki.qemu.org/Features/PostCopyLiveMigration#Summary15:57
sean-k-mooneyand libvirt cant rollback at that point15:58
artomAlthough I think that's just the commit message15:58
*** JamesBenson has joined #openstack-nova15:59
artomYour bug (https://bugs.launchpad.net/nova/+bug/1788014) doesn't mention post-copy15:59
openstackLaunchpad bug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] - Assigned to Matt Riedemann (mriedem)15:59
*** ociuhandu has quit IRC15:59
artomAnd the new code is being called from the existing _rollback_live_migration() method, so it's not like we're attempting to rollback a post-copy migration16:00
mriedemi likely mentioned post-copy in the commit message b/c the lifecycle handler callback thing will activate the dest host port binding if the migration switches to post-copy16:00
mriedemthis code https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L125216:00
watersjInstance not resizing, skipping migration, and looks to be staying there16:01
watersjfrom nova-compute logs16:01
mriedembut it doesn't have to be post-copy to switch bindings https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L120316:01
mriedemwatersj: yes, i realize b/c the resource tracker ignores live migrations in stein16:01
mriedemwatersj: like i said, you'll have to find and manually change the migrations table record to 'error' status and then hard reboot the server16:02
watersjah, k16:02
*** jawad_axd has quit IRC16:02
mriedemthe former takes it out of the RT loop which is why you're seeing "Instance not resizing, skipping migration" and the latter is to get the guest running agian16:02
mriedem*again16:02
watersjty, give it try16:02
mriedemsomething like this should find the migration:16:03
artommriedem, so EVENT_LIFECYCLE_POSTCOPY_STARTED and EVENT_LIFECYCLE_MIGRATION_COMPLETED mean the same thing in that context: the VM is now irreversibly running on the dest16:03
artommriedem, so it makes sense to update the port bindings at that point16:03
mriedemselect * from nova_cell1.migrations where instance_uuid=<server id> and deleted=0 and status='pre-migrating';16:03
sean-k-mooneyartom: not nessisarally16:03
sean-k-mooneyEVENT_LIFECYCLE_MIGRATION_COMPLETED i think can be sent for failure16:03
mriedemyup16:04
mriedemwhich is another patch of mine16:04
mriedemhttps://review.opendev.org/#/c/594527/16:04
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event  https://review.opendev.org/59452716:05
artomAha, TIL16:05
artom(Actually, I think I already checked this when faking it for my NUMA LM func tests, but forgot)16:05
artom(Which, btw, are waiting for review - but given the last thing was Stephen's -1 which I addressed, maybe wait for him to get pack from PTG)16:06
artomWe've long passed any sense of urgency, at this point16:06
sean-k-mooneyoh actully i think i know how to repoduce the failure by the way16:06
sean-k-mooneyi think i found this issue while trying to live migrate between kerenl ovs and ovs dpdk were the virtio feature flags change16:07
sean-k-mooneydue to setting the mtu in one and not in the other16:07
sean-k-mooneystrangely enough i set up a dpdk env to work on that and and another dpdk thing on friday16:08
*** tbachman has quit IRC16:09
sean-k-mooneyartom: this was part of the orginal error http://paste.openstack.org/show/728539/16:10
artomsean-k-mooney, ah, so you hit this because the source sent some XML the dest couldn't handle, and QEMU died16:11
sean-k-mooneyyep16:12
sean-k-mooneylibvirt was fine with it16:12
sean-k-mooneywell you can see the error16:12
artomRight, the XML itself was "fine"16:12
artomBut the generated qemu command line exploded it16:12
sean-k-mooneyya but not for the migration16:12
sean-k-mooneyqemu also acccpeted teh commandline16:13
sean-k-mooneyit was only an issue when the migration started16:13
mriedemso if https://review.opendev.org/#/c/594527/ fixes that to not activate the dest host port bindings, then we don't need to rollback and maybe i can just abandon https://review.opendev.org/59413916:13
sean-k-mooneyya maybe16:14
artomI wonder if we could reproduce that in the gate, with a DNM patch that borks the LM on purpose16:14
sean-k-mooneyi can try and recreate teh excat error i had and do some testing i guess16:14
*** jawad_axd has joined #openstack-nova16:14
sean-k-mooneyam i might be able to do that yes...16:14
sean-k-mooneyit woudl be quicker to do it locally first16:15
*** tbachman has joined #openstack-nova16:15
sean-k-mooneyi have to go fix my dpdk job16:15
*** links has joined #openstack-nova16:15
* artom is lazy, and likes having the gate do all the setup for him16:15
artom(Apologies to infra and the nodepool donors)16:15
sean-k-mooneyif i make it work again i could have 1 node be kernel ovs and the other dpdk and then replicte this with a simple live migrate test16:16
artomI'm assuming hacking Nova to just generate broken XML for the dest won't be enough?16:16
sean-k-mooneywell yes16:16
sean-k-mooneyto get teh conflcit one of the xmls shoudl have the mtu set and the udpated one not16:17
watersjmriedem,  just to verify update migrations set status = 'error' where id = 76;16:17
sean-k-mooneythat will change between the 32bit feature flags and teh 64bit feature flags and will cause the error16:17
watersjid 76 is record in question16:18
artomsean-k-mooney, so why not do that? DNM patch that adds a "break_xml()" to _update_xml() on the source16:18
artomRemove all the non-LM testing from Zuul16:18
artomAnd play around with that16:18
sean-k-mooneyartom: so your going to write that patch ya :)16:18
artomsean-k-mooney, I don't mind16:18
*** links has quit IRC16:19
*** jawad_axd has quit IRC16:19
mriedemwatersj: yeah16:19
sean-k-mooneywell it shoudl be pretty easy to do i guess. am i need to look at that downstream bug breifly but i can also maybe look at this with you after i figure out if we can backport that fix16:20
artomsean-k-mooney, there's a downstream bug for that?16:20
sean-k-mooneythat fix bing the binding_failded thing16:20
sean-k-mooneyno a different thing16:21
artomAh16:21
artomBecause one of the things we were discussing is are we backporting the fix16:21
artomWhich influences how invasive it can be16:21
mriedemartom: (10:13:25 AM) mriedem: so if https://review.opendev.org/#/c/594527/ fixes that to not activate the dest host port bindings, then we don't need to rollback and maybe i can just abandon https://review.opendev.org/59413916:21
sean-k-mooneymriedem: if i can recreate it ill apply that patch and see if it fixes it16:22
*** mkrai has quit IRC16:22
mriedemack16:22
artommriedem, ah, yeah, it we never update the port bindings for a failed LM, we don't need to roll them back16:22
artomSo, would there be value in a DNM to repro that in the gate?16:23
artom*DNM patch16:23
watersjI'm getting, There are allocations remaining against the source host that might need to be removed16:26
*** igordc has joined #openstack-nova16:27
*** igordc has quit IRC16:27
sean-k-mooneyartom: if you can repro it in the gate we can use that to test both of mriedem patches so yes i think there is still value16:27
sean-k-mooneyalthough long term a functional regression test would be optimal16:28
artomsean-k-mooney, mriedem was saying we need to fix the Neutron fixture for that16:28
sean-k-mooneyproably16:28
artomsean-k-mooney, so what was that thing about the MTU? Removing it should trigger thing? Seems weird16:28
sean-k-mooneyit does not really do the multiple port bindings workflow right16:29
sean-k-mooneyartom: ya remove it form the port forces libvirt to change form teh 64bit encodeing to the 32bit encoding16:29
sean-k-mooneywell adding it forces it16:29
*** damien_r has quit IRC16:30
sean-k-mooneyanyway the root of that secific libvirt/qemu issue is they ran out of feature bits and adding and removing hte mtu is one way to chagne it16:31
*** luksky has quit IRC16:31
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Create BDM in API during attach volume  https://review.opendev.org/69294016:31
openstackgerritMatt Riedemann proposed openstack/nova master: Provide a better error when _verify_response hits a TypeError  https://review.opendev.org/69304216:31
mriedemwatersj: ah yeah...so in placement the migration record (id=76) holds the allocations for the source host and the instance holds allocations for the dest host, and you need to move the instance allocations back to the source host and drop the allocations from the dest host, which doesn't sound fun right16:33
mriedemluckily i just wrote a guide on how to do this https://review.opendev.org/#/c/691427/16:33
watersjlol16:34
mriedemyou might want to just skip straight to the heal_allocations part16:34
mriedemi.e. delete the allocations for both the migration and instance consumer and then heal allocations for the instance16:34
mriedemhttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete16:34
mriedemyou'd pass the migration uuid and instance uuid to ^ to remove the allocations in placement16:35
*** jawad_axd has joined #openstack-nova16:35
mriedemthen run: nova-manage placemet heal_allocations16:35
mriedemhttps://docs.openstack.org/nova/stein/cli/nova-manage.html#placement16:35
mriedemif you want to target the specific instance, or do a dry-run heal_allocations, you'd need to setup a train nova instance in a vm/container/virtualenv https://docs.openstack.org/nova/train/cli/nova-manage.html#placement since --dry-run and --instance options aren't in stein16:36
watersjhave backup of volume16:37
watersjready really break it16:37
mriedemi don't know what that means16:37
mriedemoh you mean you do'nt need a dry run16:37
mriedemheal allocations just recreates the missing allocation records in placement for the instance using the flavor data associated with the instance16:37
watersjmean I ok to try without dryrun capabilities16:37
mriedemdoesn't touch the guest or anything like that16:37
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: break live migration to trigger bug 1788014  https://review.opendev.org/69304516:38
openstackbug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] https://launchpad.net/bugs/1788014 - Assigned to Matt Riedemann (mriedem)16:38
watersjk, ty for the help16:38
openstackgerritMerged openstack/nova stable/stein: Add integration testing for heal_allocations  https://review.opendev.org/69292316:39
*** jawad_axd has quit IRC16:39
*** ociuhandu has joined #openstack-nova16:46
*** mvkr has quit IRC16:48
*** tesseract has quit IRC16:50
*** ociuhandu has quit IRC16:50
mriedemdansmith: replied in https://review.opendev.org/#/c/635668/ - i'm not sure exactly what you're looking for so i gave some options16:57
mriedemif you want to see a paste of what i'm talking about i can do that quick16:57
*** luksky has joined #openstack-nova16:57
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: break live migration to trigger bug 1788014  https://review.opendev.org/69304516:59
openstackbug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] https://launchpad.net/bugs/1788014 - Assigned to Matt Riedemann (mriedem)16:59
dansmithmriedem: seems like you get it to me :)17:01
mriedemok17:02
mriedemupdating thusly17:02
*** psachin has quit IRC17:20
melwittwhoa, one of my things merged the first time17:23
* melwitt faints17:23
dansmithyou know17:26
dansmithit has been said that on several providers we're our own noisy neighbor17:26
dansmithif we see a massive drop in the IO-based failures this week,17:26
dansmiththat would probably just go to confirm that as a likely problem17:26
dansmithless volume for samples for sure, but..17:26
melwittyeah, I was wondering that too. summit/ptg and if suddenly less gate failures17:29
mriedemgate has been smooth has rich creamery butter this week17:30
mriedemhttps://www.youtube.com/watch?v=3ds0vWfoTwU17:32
*** gyee has joined #openstack-nova17:33
melwittlol17:33
mriedemi didn't actually think of the simpsons when i said that, but now i realize it's just baked into my brain from years of watching those recorded episodes on vhs as a kid17:35
mriedem"we didn't have streaming in my day..."17:35
melwittthat's impressive17:35
sean-k-mooneyeven with out streaming like friends the simsons is one of those shows that is on a loop on cable/satialite tv constantly17:36
mriedemwe didn't have cable until i was 1717:36
mriedemhence the vhs17:36
mriedemand then it was all WWE and Love Line years after my friends were sick of those shows17:37
sean-k-mooneysome what similar i was maybe 12/14 but that just becasue ireland and it not being a thing until the 90s17:37
* dansmith tweaks the topic for this channel17:37
dansmith"This channel is for Nova development and mriedem's childhood nostalgia"17:38
sean-k-mooneydansmith: and music references form the 80s17:38
dansmithsean-k-mooney: same category17:38
mriedemlet it be so17:39
sean-k-mooneywell now that im donw backporting a patch we backported 6 months ago i think im going to get food then do something useful...17:40
*** jamesdenton has quit IRC17:46
*** mvkr has joined #openstack-nova17:47
*** jamesdenton has joined #openstack-nova17:49
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add regression test for bug 1824435  https://review.opendev.org/69290617:50
openstackbug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt)17:50
openstackgerritmelanie witt proposed openstack/nova stable/stein: Remove redundant call to get/create default security group  https://review.opendev.org/69290717:50
*** jamesdenton has quit IRC17:59
*** derekh has quit IRC18:00
*** ociuhandu has joined #openstack-nova18:02
watersjis openstack resource provider a command available to stein? or am I supposed to replace "resource provider" with something else ?18:06
melwittwatersj: you need to install osc-placement in order to get the placement cli commands18:07
*** ociuhandu has quit IRC18:07
watersjmelwitt, ty18:10
openstackgerritMatt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask  https://review.opendev.org/63566818:17
openstackgerritMatt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler  https://review.opendev.org/66901218:17
openstackgerritMatt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize()  https://review.opendev.org/63568418:17
openstackgerritMatt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.opendev.org/63622418:17
openstackgerritMatt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize  https://review.opendev.org/63625318:17
openstackgerritMatt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor  https://review.opendev.org/64259118:17
openstackgerritMatt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing  https://review.opendev.org/64259218:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate  https://review.opendev.org/64345018:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing  https://review.opendev.org/64345118:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing  https://review.opendev.org/66901318:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method  https://review.opendev.org/63705818:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add ConfirmResizeTask  https://review.opendev.org/63707018:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method  https://review.opendev.org/63707518:17
openstackgerritMatt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API  https://review.opendev.org/63731618:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63763018:17
openstackgerritMatt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations  https://review.opendev.org/63945318:17
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method  https://review.opendev.org/63764718:17
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask  https://review.opendev.org/63804618:17
*** jamesdenton has joined #openstack-nova18:19
dansmithmriedem: I'm missing something18:25
dansmithokay I think I see, but I feel like now the flow is more confusing than it was before18:27
dansmithall the nested conditions make it hard for me to tell what states you can end up in after your fall out of all of it18:28
dansmithand having the two "restricting" cases is not helping18:28
dansmithI feel like that is a lot more complicated just because we're trying to log a message there about something that will happen later based on a flag we're not even concerned with18:29
dansmithmaybe it's more complicated because of the later change you commented about but... it's pretty confusing18:30
dansmith....which adds another level of nested conditional18:30
dansmithand more logs18:30
dansmithmaybe it's just me, and sorry if so, but I think that end state tripley-nested conditional thing is just a total nightmare18:31
openstackgerritArchit Modi proposed openstack/nova master: Fix block-device-mapping parameter naming  https://review.opendev.org/69306518:39
dansmithmriedem: totally untested, but I think this rearrangement of the final code works the same and is easier to follow? https://pastebin.com/Hq61MM2V18:40
*** CeeMac has quit IRC18:45
*** ralonsoh has quit IRC18:54
mriedemthat paste could work, it's fine with me. it's after the targeted host thing so https://review.opendev.org/#/c/635668/ would be different18:57
mriedemunless you're suggesting munging those changes together18:58
dansmithmriedem: no, I'm not suggesting muging, I just chose the final state to demonstrate what I think it needs to look like19:00
*** jaosorior has joined #openstack-nova19:03
mriedemi'm tinkering19:03
melwittmriedem: I added you to what's turning out to be a hairy review for a bfv docs fix https://review.opendev.org/69306519:04
melwittI think it probably just needs to be updated to use --boot-from-volume (new in 4.0.0 added by you) because it's a confusing mix of wrong osc commands and correct nova boot commands19:05
melwittbut you know best19:05
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334119:05
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602919:05
openstackgerritDustin Cowles proposed openstack/nova master: WIP: Provider Config File: Merge provider configs to provider tree  https://review.opendev.org/67652219:05
mriedemmelwitt: ok so this was likely a case of a doc being straight up changed from nova boot to just openstack server create with no thought to the implications of the actual option names or what was supported at the time19:06
mriedemfun19:06
melwittexactly19:06
mriedemmelwitt: left some thoughts on how to maybe break that down into more manageable chunks19:12
mriedemb/c i really hate fixing lots of random shit like this in the docs in the same patch19:12
mriedemeasy to get something wrong19:12
artomalias 'openstack server create' 'nova boot' amirite19:12
melwittcool thanks19:12
mriedemdansmith: ok so this would be pass 1 http://paste.openstack.org/show/785820/19:13
*** xek_ has joined #openstack-nova19:13
mriedemfor https://review.opendev.org/#/c/635668/19:13
*** ociuhandu has joined #openstack-nova19:14
*** xek has quit IRC19:14
mriedemwhich i'd build on with the targeted host stuff in https://review.opendev.org/#/c/642591/ later19:14
mriedemto be more like your final paste19:14
*** jaosorior has quit IRC19:15
melwittmriedem: so first step is just replace 'openstack server create' with 'nova boot' to make everything work correctly, backport that. then next step is just convert everything to osc commands properly. I don't think I understand the middle step you described19:18
melwittor rather I'm seeing 2 steps instead of 319:18
mriedemno there is still a nova boot example in there https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@22419:20
mriedemso i was saying:19:20
mriedem1. revert to using nova boot everywhere19:20
mriedemwhich is backportable19:20
*** ociuhandu has quit IRC19:21
dansmithmriedem: did I miss that requested_destination can be set and None?19:21
mriedem2. fix the non nova boot (so not https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@224) openstack server create usage19:21
mriedem3. replace the remaining nova boot example with openstack server create and mention --boot-from-volume since osc 4.0.019:21
mriedemdansmith: that was the existing logic and is what we do elsewhere for setting the cell when moving the server19:21
dansmithaight19:22
mriedemmelwitt: that's just how i'd tackle that to try and keep it small and sane for each thing getting fixed19:22
*** rouk has joined #openstack-nova19:22
mriedemrather than do it all in a single change stephen style :P and wait for 8 months for someone to review the doc fix19:22
melwittmriedem: yeah, sorry. I'm just thinking after we revert to nova boot everywhere, there won't be any non nova boot for step 219:23
mriedemdansmith: this is my end product http://paste.openstack.org/show/785821/19:23
mriedemno test changes19:23
mriedemmelwitt: oh yeah you're right19:23
dansmithmriedem: hundy times better, IMHO19:23
mriedemdansmith: ok pushing19:23
openstackgerritMatt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask  https://review.opendev.org/63566819:25
openstackgerritMatt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler  https://review.opendev.org/66901219:25
openstackgerritMatt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize()  https://review.opendev.org/63568419:25
openstackgerritMatt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.opendev.org/63622419:25
openstackgerritMatt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize  https://review.opendev.org/63625319:25
openstackgerritMatt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor  https://review.opendev.org/64259119:25
openstackgerritMatt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing  https://review.opendev.org/64259219:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate  https://review.opendev.org/64345019:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing  https://review.opendev.org/64345119:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing  https://review.opendev.org/66901319:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method  https://review.opendev.org/63705819:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add ConfirmResizeTask  https://review.opendev.org/63707019:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method  https://review.opendev.org/63707519:25
openstackgerritMatt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API  https://review.opendev.org/63731619:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63763019:25
openstackgerritMatt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations  https://review.opendev.org/63945319:25
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method  https://review.opendev.org/63764719:25
mriedemmelwitt: i guess the alternative is just (1) fix the existing busted osc usage in there, and (2) convert the remaining nova boot to osc and also mention --boot-from-volume19:25
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask  https://review.opendev.org/63804619:25
openstackgerritMatt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method  https://review.opendev.org/63804719:25
openstackgerritMatt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API  https://review.opendev.org/63804819:25
mriedemthe change right now just seems like it's trying to do too much and getting some of what it's trying to fix wrong - or incomplete19:25
melwittmriedem: yeah, I feel like reverting to nova boot and backport is the right first step19:26
mriedemthat works for me.19:26
melwittbecause actually making it correct for osc is not straightforward19:26
mriedembtw, i thought rhosp had it's own docs and didn't use upstream?19:26
melwittand would be better off as a separate change19:26
amodimriedem: melwitt sure, updting the patch to use nova boot19:27
amodiyes, we dont use upstream, except when we do :)19:28
mriedembtw, this was the breaking change in the manuals repo https://review.opendev.org/#/c/404623/19:28
*** dpawlik has joined #openstack-nova19:28
melwittyeah, that was part of the big sweep that did some find/replaces. other docs of ours became wrong in that sweep, can't remember which atm19:29
melwittoh, the quota stuf19:29
melwittstuff19:29
mriedemyup the quota one was annoying19:30
mriedemi left an updated comment on amodi's change hopefully clearing it up19:30
mriedemamodi: btw, you should create a doc bug for this since we'll backport the fix19:31
mriedemand now i'm off to vote on raising my taxes for schools because i love the children19:31
amodimriedem: ack, will do, and im just updating this doc19:32
amodior if u want me to update all the other ones in the referenced changed, lmk19:32
mriedemamodi: just that doc. i didn't look through https://review.opendev.org/#/c/404623/ to see if it broke other stuf19:33
mriedem*stuff19:33
melwittit broke the boot from ISO image too (still looking)19:33
amodihttps://review.opendev.org/#/c/404623/8/doc/user-guide/source/cli-nova-launch-instance-using-ISO-image.rst this has the --block-device used with osc command19:33
melwittthe other stuff is probably ok19:34
mriedemah yeah that is wrong, osc before 4.0 didn't have a way to boot with an image and create a blank volume19:34
mriedemyeah the rest looked ok19:34
amodicool, will update thanks!19:35
mriedemactually i'm not even sure latest osc allows creating a server and telling nova to create and attach a blank volume19:35
mriedemadd it to the gap pile!19:35
mriedemhttps://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc19:35
mriedemartom: you broke nothing https://review.opendev.org/#/c/693045/19:36
openstackgerritBoris Bobrov proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt  https://review.opendev.org/68482519:36
openstackgerritBoris Bobrov proposed openstack/nova master: Create a controller for qga when SEV is used  https://review.opendev.org/69307219:36
melwitthoo that is a lot of gaps19:37
mriedem(1) i thought you were artom (2) saying that is a lot of gas19:38
*** mriedem is now known as mriedem_afk19:38
melwittosc might cause gas19:40
artommriedem_afk, I know, I suck19:40
artomOr... blow? Which way is the gas supposed to go?19:40
dansmithsuck squeeze bang blow19:40
artomThat's the one19:41
artomApplies to ICEs and other things19:41
dansmithwhy do you think mriedem_afk is afk right now?19:41
dansmithHEY-O19:41
dansmithoh, voting, nevermind19:41
artomIn some ways it's the same thing19:42
dansmithheh19:42
artomI also like how he keeps -1'ing the _DNM_ change :)19:47
*** eharney has quit IRC19:52
*** watersj has quit IRC19:52
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: break live migration to trigger bug 1788014  https://review.opendev.org/69304519:58
openstackbug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] https://launchpad.net/bugs/1788014 - Assigned to Matt Riedemann (mriedem)19:58
sean-k-mooneyartom: its possibel the breakage has something to with vhost-user other then the mtu or libvirt could have fixed the issue and now always use the 64bit encoding instead20:07
artomsean-k-mooney, I added an extra debug log, we'll see20:09
artomIf the latter, we can try and find another way to trigger this20:09
sean-k-mooneyit been over a year since i actully hit that error and it was on cent7.5 so the libvirt we are using in the gate in the ubuntu vms is alot different20:09
*** amodi has quit IRC20:10
efriedsean-k-mooney: what do we do about tempest tests that need a certain minimum of e.g. libvirt or qemu?20:10
efriedDo all the CI nodes have the same (latest) version?20:11
efriedhm, I guess they probably do if they all use the same image...20:11
sean-k-mooneyit depends20:11
sean-k-mooneyin some cases we have feature flags in the tempest config20:11
sean-k-mooneybut in general tempest does not have test that care20:11
sean-k-mooneyin the nova code we have checks if feature need a newer version then our minium20:12
efriedI'm going to be getting into vTPM with encryption this cycle, which requires a very recent libvirt/qemu. I don't know yet whether I'll be adding CI for it, but was curious how that would happen if I did.20:12
efriedyeah, but that'll just cause the build to fail, right?20:12
*** dpawlik has quit IRC20:13
sean-k-mooneyam its a pain but we used to use fedora with the virt preview repo for that20:13
*** jawad_axd has joined #openstack-nova20:13
sean-k-mooneyif that is not an option we also have a devstack plugin you could use20:13
sean-k-mooneyit will compile libvirt and qemu from source20:13
efriedeek20:14
sean-k-mooneypersonally i found that beeter then random fedora virt preview package20:14
efriedI don't think I need *unreleased* versions. Just pretty recent ones.20:14
sean-k-mooneyefried: do you know what version you need20:14
efriedyeah, one sec...20:15
* artom goes for an early school run20:15
*** ociuhandu has joined #openstack-nova20:16
efriedsean-k-mooney: libvirt 5.6.0. qemu at least 1.11, but possibly higher, not sure.20:16
efriedsorry, 2.1120:16
sean-k-mooneyok fedroa 20 might have that 5.6 is pretty new i think20:16
sean-k-mooneyhttps://opendev.org/x/devstack-plugin-libvirt-qemu20:16
sean-k-mooneyi can try and build those with that too20:16
sean-k-mooneyi havent really been maintaining that20:17
sean-k-mooneybut its what we used to use at intel to test prerelease stuff20:17
*** mriedem_afk is now known as mriedem20:18
mriedemartom: -1ing your DNM changes is how i stay up on stackalytics20:18
*** ociuhandu has quit IRC20:21
mriedemthe bottom 2 trivial changes in the cross-cell resize series are begging for another core https://review.opendev.org/#/c/692856/20:21
mriedemthey are, not me20:22
sean-k-mooneyefried: ill test it but i think you just need to add http://paste.openstack.org/show/785823/ for the devstack plugin20:22
*** amodi has joined #openstack-nova20:23
openstackgerritArchit Modi proposed openstack/nova master: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69306520:26
*** zbr is now known as zbr|ooo20:29
efriedwhoah, I appear to have 4.0.0 on my bionic20:30
efriedis the apt package level the number I want to be looking at?20:30
sean-k-mooney4.0 of?20:30
sean-k-mooneylibvirt you check with libvirtd --version20:31
efriedyeah, 4.0.020:31
sean-k-mooneyya and ubuntu 18.04 has 2.11 libvirt20:31
sean-k-mooney*qemu20:32
sean-k-mooneyso the qemu in the gate should be fine20:32
efriedconfirmed 2.1120:32
efriedIs there a way *other* than building from source (which I have chronically shit luck with, no matter what I'm trying to build) to get a higher libvirt on my bionic?20:33
sean-k-mooneyi dont think there is a ppa but it migth be in the ubuntu cloud archive20:33
sean-k-mooneylet me check20:33
sean-k-mooneyya they have 5.420:34
sean-k-mooneyhttp://ubuntu-cloud.archive.canonical.com/ubuntu/pool/main/libv/libvirt/20:34
sean-k-mooneyyou need 5.6 however right20:35
efriedokay, so if I need 5.6.0 I need to build20:35
efriedyeah.20:35
efriedwah wah wahhhhh20:35
sean-k-mooneyeven the libvirt ppa is 5.4 https://launchpad.net/ubuntu/+source/libvirt20:36
sean-k-mooneyill let you know in a few minute i the plug still work.20:37
efriedsean-k-mooney: I gotta do this locally first anyway20:37
sean-k-mooneyi havenet used it in  like 2 years but i wrote the first version of it to solve this exact problem20:37
efriedunless you're saying I can use the plugin to do it locally.... which would make a certain amount of sense ;P20:38
sean-k-mooneyyes you can20:38
sean-k-mooneyits just a devstack plugin so you can run it locally by adding the 3 lines i sent you to your local.conf20:38
sean-k-mooneyit should intall all the deps to build it and checkout the version you set as part of stacking20:39
efriedoo20:40
efriedmriedem: done20:44
efriedsean-k-mooney: trying....20:46
mriedemefried: thanks20:47
sean-k-mooneyefried: libvirt just finsihed building for me20:47
efriedI couldn't just sit here listening to all the begging.20:47
sean-k-mooneyits working on qemu now20:47
efriedsean-k-mooney: cool, so given that I'm running 1/128th of the cores you are, mine will finish some time tomorrow?20:47
sean-k-mooneyits not that bad. im limited by disk io20:48
sean-k-mooneyit will add maybe 5-10 mins on the build at most and i setup the pluging to cache the build20:49
sean-k-mooneyit creates a BUILD_COMPLETE file in /opt/stack/libvirt and /opt/stack/qemu20:49
*** xek_ has quit IRC20:49
sean-k-mooneyso you dont need to do it again unless you want too20:49
sean-k-mooneyunstack does not delete that file but clean will20:50
*** xek has joined #openstack-nova20:50
efriednice20:50
efriedBy sheer luck, I totally asked the right person.20:50
efried...unless it doesn't work for me. In which case you're fired.20:51
sean-k-mooneyassuming it still works you can also give it a set of patchwork urls and to test with unmerged patche to both too20:51
efriedhum, I seem to still be running under py2, which probably isn't my best call.20:51
sean-k-mooneyit will proably be fine20:51
efriedDo I just fix that by setting USE_PYTHON3=true in my local.conf?20:51
sean-k-mooneyfor about another week or two20:52
sean-k-mooneyyes20:52
efriedwell, I don't really care except that I'm trying to be close to realistic here.20:52
sean-k-mooneyif your talking to a bank they will be running python 2 for the next decade20:52
sean-k-mooneysetting USE_PYTHON3=true wont remove the py2 stuff so its best to do that on a clean vm20:53
efriedwould you be disgusted if I told you I'm not running in a VM?20:53
rouks/python 2/COBOL or some variant of BASIC or java 1.0/g20:53
sean-k-mooneyefried: not really if you have a dev server20:54
efriedindeed rouk. FORTRAN etc. Course, they're probably not running OpenStack in those languages.20:54
sean-k-mooneyi would not run devstack on my laptop directly however20:54
efriedyeah, I've got some dev NUCs.20:54
efriedI think it's building libvirt...20:55
sean-k-mooneyjust finished qemu20:56
*** eharney has joined #openstack-nova20:57
sean-k-mooney... and it failed... sudo addgroup -f -r libvirt20:57
sean-k-mooneyOption f is ambiguous (firstuid, force-badname)20:57
sean-k-mooneyUnknown option: r20:57
sean-k-mooneywhy do pepole change things like addgroup20:57
*** xek has quit IRC20:59
sean-k-mooneyoh those are the optiongs for groupadd21:00
sean-k-mooneyefried: if you have a different terminal just run "sudo groupadd -f -r libvirt"21:01
sean-k-mooneyand it will continue instaed failing or you can leave it fail and run it after and then just stack and unstack21:02
efriedthanks sean-k-mooney. Why is it ambiguous in flight and not when I run it??21:04
sean-k-mooneyits trying to use addgroup not groupadd21:04
sean-k-mooneyhttps://opendev.org/x/devstack-plugin-libvirt-qemu/src/branch/master/devstack/libs/libvirt#L15721:05
sean-k-mooneyits a bug but  this has not been tested on 18.04 before21:05
sean-k-mooneyi last used it on 16.04 and centos721:05
openstackgerritArchit Modi proposed openstack/nova master: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69306521:06
efriedo21:06
sean-k-mooneyill fix it up after i test it a bit21:06
*** tbachman has quit IRC21:13
openstackgerritArchit Modi proposed openstack/nova master: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69306521:13
efriedsean-k-mooney: http://paste.openstack.org/raw/785825/ FYI21:15
sean-k-mooneydo you have /usr/bin/python21:18
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add regression test for bug 1824435  https://review.opendev.org/69290621:19
openstackbug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt)21:19
openstackgerritmelanie witt proposed openstack/nova stable/stein: Remove redundant call to get/create default security group  https://review.opendev.org/69290721:19
efriedsean-k-mooney: yes, it points to python2.721:19
sean-k-mooneythat shoudl be fine i have the same its form here https://opendev.org/x/devstack-plugin-libvirt-qemu/src/branch/master/devstack/libs/libvirt#L20921:20
sean-k-mooneyyou could proably comment that line out and install libvirt-python by hand21:22
sean-k-mooneythe plugin will be cloned locally to /opt/stack21:22
efriedsean-k-mooney: I tried, it fails the same way. I even tried installing a lower version.21:22
sean-k-mooneyso installing libvirt python just fails in general form pip21:23
efriedoh, hold on, it's failing a different way when I do it manually...21:24
efriedsean-k-mooney: http://paste.openstack.org/raw/785826/21:26
efriedsorry, the original thing happened when I tried it manually the first time21:28
efriedthen I unstacked21:28
efriedthen after the unstack it started to fail the second way. That's probably because unstack unset the path to libvirt.21:28
sean-k-mooneymaybe what to you get if you run this21:29
sean-k-mooneyubuntu@dev:/opt/repos/devstack$ pkg-config libvirt ; echo $?21:29
sean-k-mooney021:29
efried1 right now, lemme stack again and see...21:29
*** ociuhandu has joined #openstack-nova21:29
sean-k-mooneyhad you stacked on the system before21:30
sean-k-mooneyor was it clean21:30
sean-k-mooneyim currenly not using a clean vm21:30
efriedbefore before? yes21:30
sean-k-mooneyok same then21:30
efriedI unstacked, cleaned, upgraded all packages, rebooted, then started stacking with RECLONE and your plugin, other stuff unchanged.21:30
sean-k-mooneydo you have the libvirt.so?21:31
sean-k-mooneyubuntu@dev:/opt/repos/devstack$ ll /usr/lib/libvirt.so21:31
sean-k-mooneylrwxrwxrwx 1 root root 19 Nov  5 21:04 /usr/lib/libvirt.so -> libvirt.so.0.5008.0*21:31
openstackgerritmelanie witt proposed openstack/nova master: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69306521:32
sean-k-mooneythat shoudl have been install when the pluging did "sudo make install" in the /opt/stack/libvirt folder21:32
openstackgerritmelanie witt proposed openstack/nova master: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69306521:33
efriedI'll check when I get back to that point21:33
efriedI've got another NUC doing the same thing, but with USE_PYTHON3=yes21:33
efriedwe'll see if that hits the same problem.21:33
*** amodi has quit IRC21:34
*** ociuhandu has quit IRC21:39
*** tbachman has joined #openstack-nova21:40
*** amodi has joined #openstack-nova21:40
efriedhm, despite USE_PYTHON3=yes it still appears to be using py221:42
*** ociuhandu has joined #openstack-nova21:47
efriednevertheless the supposed-py3 one seems to have gotten past that point.21:49
sean-k-mooneyi guess that is a good thing21:49
sean-k-mooneyim expect apparmor to be unhappy by the way. im currently fixing that on my system21:51
*** takashin has joined #openstack-nova21:52
*** macz has joined #openstack-nova21:55
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602921:56
openstackgerritDustin Cowles proposed openstack/nova master: WIP: Provider Config File: Merge provider configs to provider tree  https://review.opendev.org/67652221:56
*** ociuhandu has quit IRC21:57
efriedsean-k-mooney: what's apparmor?21:57
efriedIs it related to this?21:57
efriedConnection to libvirt failed: authentication unavailable: no polkit agent available to authenticate action 'org.libvirt.unix.manage': libvirtError: authentication unavailable: no polkit agent available to authenticate action 'org.libvirt.unix.manage'21:57
sean-k-mooneyits the securaty context that ubuntu use instead of se linux21:57
sean-k-mooneysudo ln -s /etc/apparmor.d/usr.sbin.libvirtd /etc/apparmor.d/disable/usr.sbin.libvirtd21:58
sean-k-mooneywill diable the libvirt profie allowing soruce build to work21:58
sean-k-mooneybut you have to do a reboot for it to take effect21:58
sean-k-mooneyyou are ment to be able to just use aa-complain21:58
sean-k-mooneyto put it in warning/complain mode but it was not working for me21:58
efriedwould this be... not a problem if I compiled a different version of libvirt?21:59
sean-k-mooneyi need to write a readme for that plugin and doument this and fix the other issue21:59
sean-k-mooneyno i hit the same issue21:59
efriedoh, the readme isn't "Come find sean-k-mooney on IRC"?21:59
efriedwell, I didn't change 5.8 to 5.6 in my env21:59
sean-k-mooneywell it basicaly is right now21:59
efriedswhy I'm asking.21:59
efriedand if I reboot I have to restack, right?22:00
sean-k-mooneythere is another thing you coudl try first22:00
sean-k-mooneybut i did it the reboot way22:00
*** TxGirlGeek has quit IRC22:00
sean-k-mooneyyou can add security_driver="none"22:01
*** TxGirlGeek has joined #openstack-nova22:01
sean-k-mooneyto /etc/libvirt/qemu.conf and restart libvirt-bin22:01
sean-k-mooneybut if you rerun stack.sh it will overwrite it22:01
sean-k-mooneyill fix this up and automated in the plugin22:02
sean-k-mooneyits ment to do this for you22:02
sean-k-mooneybut as i said it has not been updated for ubuntu 18.0422:02
*** pcaruana has quit IRC22:03
efriedsean-k-mooney: and tbc, is this the same issue as22:04
efriedConnection to libvirt failed: authentication unavailable: no polkit agent available to authenticate action 'org.libvirt.unix.manage': libvirtError: authentication unavailable: no polkit agent available to authenticate action 'org.libvirt.unix.manage'22:04
efried?22:04
sean-k-mooneyyes22:04
efriedk22:04
sean-k-mooneypolkit is used to interact with selinux via dbus on fedora/centos/rhel22:05
sean-k-mooneyis apparently the libvirt default22:05
openstackgerritTakashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object  https://review.opendev.org/68304322:05
sean-k-mooneyim just not passing the correct flags when building it to have it auto install the apparmor files22:05
sean-k-mooneyi should prably just ask danpb how to do it correctly22:06
melwittmriedem: do you remember any func test change from the past made to avoid "{"forbidden": {"code": 403, "message": "Maximum number of ports exceeded"}}"22:11
mriedemare you backporting something to queens or newton or something and hitting that?22:11
melwittI'm backporting stuff and hitting this because I'm presumably missing some underlying func test improvement22:11
melwittyes22:11
melwittI thought if anyone might remember something related to that, it would be you22:12
*** jawad_axd has quit IRC22:12
mriedemnot specifically, but i'd look for port quota stuff on the NeutronFixture22:12
melwittthanks, any direction helps a lot :)22:12
mriedemhttps://review.opendev.org/#/q/I1dbccc2be6ba79bf267edac9208c80e187e6256a ?22:13
mriedemhttps://review.opendev.org/#/c/587412/4/nova/tests/fixtures.py@1347 is the thing i'd think you want22:13
melwittlooks promising22:14
*** ociuhandu has joined #openstack-nova22:18
*** ociuhandu has quit IRC22:23
*** tbachman has quit IRC22:24
sean-k-mooneyefried: ok i think i have fixed the issue locally ill work on a patch. but basically i need to tweak the /etc/libvirt/libvirtd.conf sligtly and nova will be happy22:25
*** ociuhandu has joined #openstack-nova22:25
sean-k-mooneyefried: http://paste.openstack.org/show/785827/22:25
openstackgerritMerged openstack/nova master: Follow up to I3e28c0163dc14dacf847c5a69730ba2e29650370  https://review.opendev.org/69285622:27
efriedsean-k-mooney: okay. I tried doing that conf change and now it's doing this22:27
efriedConnection to libvirt failed: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory: libvirtError: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory22:27
sean-k-mooneywhere is that error? nova? virsh?22:28
*** JamesBen_ has joined #openstack-nova22:28
efriednova compute startup (journalctl)22:28
sean-k-mooneyok what do you get if you do "sudo systemctl status libvirt-bin"22:29
*** rcernin has joined #openstack-nova22:29
*** ociuhandu has quit IRC22:30
openstackgerritMatt Riedemann proposed openstack/nova master: Improve metadata server performance with large security groups  https://review.opendev.org/65608422:30
mriedemthis is a simple performance improvement fix, been sitting a long time waiting for the originaly author to touch it up ^22:30
mriedemand when i went to do it, i realized there was a much simpler fix22:30
efriedd'oh, sorry, already started unstacking.22:31
*** JamesBenson has quit IRC22:31
sean-k-mooneyno worries22:31
efriedsean-k-mooney: I'm adding those extra libvirtd.conf lines (from within the plugin) and will restack.22:32
sean-k-mooneyby the way i have code in the pluging to fix the app armor stuff22:32
sean-k-mooneysudo apparmor_parser -R /etc/apparmor.d/usr.sbin.libvirtd || /bin/true22:32
sean-k-mooneyim guessing that is failing22:32
sean-k-mooneybecause i thinkg the package name chagned22:32
*** JamesBen_ has quit IRC22:32
sean-k-mooneyso im fining that too22:32
efriedare we not set -e here?22:33
efriedoh, || true would ignore :(22:33
sean-k-mooneyyes22:33
sean-k-mooneythe /bin/ture was to ignore it on subsequent runs but its really just a hack22:34
sean-k-mooneyinstall_build_deps for libvirt-bin used to pull in the apparmor utils but i apparently does not anymore so ill install them direcly22:35
sean-k-mooneyim guessing you dont have apparmor_parser right22:35
sean-k-mooneyi should not really depend on the transitive depencies like that22:36
*** ociuhandu has joined #openstack-nova22:36
efriedsean-k-mooney: I have an apparmor_parser in /sbin22:37
*** TxGirlGeek has quit IRC22:38
sean-k-mooneyhum ok it should have remvoed the proifle then but ill document the other way in anycase22:38
efriedthe file it's referring to doesn't exist fwiw22:39
melwittmriedem: you were right, that solved the 403. now it's on to 409 "Multiple possible networks found, use a Network ID to be more specific". I'm sifting through NeutronFixture changes22:41
*** TxGirlGeek has joined #openstack-nova22:41
efriedsean-k-mooney: with those extra lines, now stack fails when libvirt-bin won't start.22:41
sean-k-mooneyefried: there is still a profile in /etc/apparmor.d/libvirt/ in my case22:41
* melwitt pans for gold22:42
efriedthat line is skipping22:42
efried+/opt/stack/devstack-plugin-libvirt-qemu/devstack/libs/libvirt:install_libvirt_qemu_src:210  sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.libvirtd22:42
efriedFile /etc/apparmor.d/usr.sbin.libvirtd not found, skipping...22:42
*** ociuhandu has quit IRC22:43
efriedthe libvirt-bin service is failing thusly:22:43
efriedNov 05 16:40:14 nucle systemd[1]: libvirtd.service: Service hold-off time over, scheduling restart.22:43
efriedNov 05 16:40:14 nucle systemd[1]: libvirtd.service: Scheduled restart job, restart counter is at 5.22:43
efriedNov 05 16:40:14 nucle systemd[1]: Stopped Virtualization daemon.22:43
efriedNov 05 16:40:14 nucle systemd[1]: libvirtd.service: Start request repeated too quickly.22:43
efriedNov 05 16:40:14 nucle systemd[1]: libvirtd.service: Failed with result 'exit-code'.22:43
efriedNov 05 16:40:14 nucle systemd[1]: Failed to start Virtualization daemon.22:43
sean-k-mooneyya it has obviously moved22:43
efriedI see these22:43
efried/etc/apparmor.d/cache/usr.sbin.libvirtd22:43
efried/opt/stack/libvirt/src/security/apparmor/usr.sbin.libvirtd22:43
sean-k-mooneydo you have anything in the journal22:43
*** ociuhandu has joined #openstack-nova22:43
efriedAssuming I would find it with journalctl -u libvirt-bin, no22:44
sean-k-mooneyit would be libvirtd-bin22:44
sean-k-mooneybut i dont think that is where its logging22:44
efriedeither way22:44
efriedno22:44
sean-k-mooneyok give me a sec to push this up and test it22:45
efriedcrap, I f'ed up the libvirtd.conf hack, sec.22:45
melwittmriedem: ok, looks like I just needed more of that change and now things are working. gonna try backporting the whole thing22:47
mriedemmelwitt: which target branch? is this upstream?22:48
mriedembecause i don't think we want to backport that whole thing...22:49
*** ociuhandu has quit IRC22:49
melwittmriedem: this is downstream queens. really? ok22:50
mriedemwell, it's big22:50
mriedemnote you already have an abandoned backport of that upstream on stable/queens22:50
mriedemhttps://review.opendev.org/#/c/599764/22:50
melwittcause it looks like I need the bits removing the validate_networks stub, add the shared network stuff, and add stuff from this change too https://review.opendev.org/#/c/585385/15/nova/tests/fixtures.py22:51
melwittlol welp22:51
mriedemyou can't just do fake_network.set_stub_network_methods again?22:51
melwittmaybe I can. I have zero memory of doing that before22:51
melwittI'll try it22:51
melwittthat would be way easier22:52
sean-k-mooneyefried: im testing https://review.opendev.org/#/c/693094/1 now22:54
*** luksky has quit IRC22:54
sean-k-mooneyefried: assuming that correct the issue ill see about setting up a tempest gate jobs that uses it and then you can just reuse/extend it for your own stuff22:55
*** mriedem has quit IRC22:58
*** zbr|ooo has quit IRC23:00
*** yoctozepto has quit IRC23:04
*** yoctozepto has joined #openstack-nova23:04
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: doc: Fix supported version descriptions  https://review.opendev.org/69309723:05
*** tbachman has joined #openstack-nova23:23
sean-k-mooneyefried: looks like i should be adding "--with-apparmor_profiles" when compiling to have it install them correctly.23:25
sean-k-mooneyof cource the only mention of that flag in the libvirt repo is in the configure script ...23:26
sean-k-mooneysometimes i forget how "fun" C is23:27
*** ociuhandu has joined #openstack-nova23:29
efriedsean-k-mooney: how do I check my version of qemu?23:34
efriedn-cpu failed to start with23:35
efriedNova requires QEMU version 2.8.0 or greater.23:35
efriedbut the plugin should have set up 4.1.0, no?23:35
*** takashin has quit IRC23:35
sean-k-mooneycorrect23:35
sean-k-mooneyhttp://paste.openstack.org/show/785829/23:35
sean-k-mooneyi have 4.123:35
*** ociuhandu has quit IRC23:36
*** Liang__ has quit IRC23:38
openstackgerritmelanie witt proposed openstack/nova stable/stein: Add regression test for bug 1824435  https://review.opendev.org/69290623:39
openstackbug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt)23:39
openstackgerritmelanie witt proposed openstack/nova stable/stein: Remove redundant call to get/create default security group  https://review.opendev.org/69290723:39
sean-k-mooneyefried: ill try running this all again on a clean ububut cloud image in the morning and ill provide you with the local.conf and anychagnes that are needed on the system if any in an update to the readme.23:45
sean-k-mooneyone way or another its in my best interest to get this documented and updated in the repo because  i will need this again at somepoint in the futrue23:46
efriedsean-k-mooney: I gotta run and break some arms, but when I run the qemu commands I see 4.1, but obv nova thinks I've got something lesser23:53
efriedanyway, thanks for the help so far, I'll bug you again tomorrow.23:53
sean-k-mooneyno worries sorry it didnt "just work"23:54
efried:)23:55
*** bnemec has joined #openstack-nova23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!