Tuesday, 2019-10-29

« Monday, 2019-10-28 Index Wednesday, 2019-10-30 »
*** brinzhang_ has joined #openstack-nova00:06
*** brinzhang has quit IRC00:09
*** ivve has quit IRC00:10
*** zer0c00l has joined #openstack-nova00:34
*** aspiers has quit IRC00:35
*** xek has quit IRC00:37
*** ccamacho has quit IRC00:51
*** Liang__ has joined #openstack-nova00:57
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:volume:Disallow AIO=native when no 'O_DIRECT' is available  https://review.opendev.org/68277200:58
*** Liang__ is now known as LiangFang00:59
*** LiangFang has quit IRC01:01
*** Liang__ has joined #openstack-nova01:01
*** abaindur has quit IRC01:14
*** jawad_axd has joined #openstack-nova01:21
*** nanzha has joined #openstack-nova01:22
*** jawad_axd has quit IRC01:26
*** dpawlik has joined #openstack-nova01:40
*** igordc has quit IRC01:42
*** jawad_axd has joined #openstack-nova01:42
*** Xuchu has joined #openstack-nova01:44
*** dpawlik has quit IRC01:45
*** jawad_axd has quit IRC01:47
*** tbachman has joined #openstack-nova01:57
*** ileixe has quit IRC02:01
*** jawad_axd has joined #openstack-nova02:03
*** larainema has joined #openstack-nova02:04
*** ileixe has joined #openstack-nova02:05
*** jawad_axd has quit IRC02:07
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:volume:Disallow AIO=native when no 'O_DIRECT' is available  https://review.opendev.org/68277202:09
*** brinzhang has joined #openstack-nova02:21
*** brinzhang_ has quit IRC02:24
*** markvoelker has joined #openstack-nova02:36
*** markvoelker has quit IRC02:41
*** igordc has joined #openstack-nova02:45
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165102:45
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165102:49
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165102:50
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165102:51
*** mdbooth has quit IRC02:54
*** mdbooth has joined #openstack-nova02:56
*** brinzhang_ has joined #openstack-nova03:03
*** brinzhang has quit IRC03:07
*** ileixe has quit IRC03:11
*** ileixe has joined #openstack-nova03:15
*** artom has quit IRC03:16
*** brinzhang has joined #openstack-nova03:17
*** brinzhang_ has quit IRC03:21
*** tbachman has quit IRC03:31
*** tbachman has joined #openstack-nova03:31
*** Xuchu has quit IRC03:31
*** Xuchu has joined #openstack-nova03:32
*** Guest14611 has quit IRC03:50
*** benj has joined #openstack-nova03:51
*** benj is now known as Guest8534503:51
*** ricolin has joined #openstack-nova03:57
*** brinzhang_ has joined #openstack-nova04:17
*** brinzhang has quit IRC04:21
*** dave-mccowan has quit IRC04:22
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:volume:Disallow AIO=native when no 'O_DIRECT' is available  https://review.opendev.org/68277204:56
*** markvoelker has joined #openstack-nova04:58
*** markvoelker has quit IRC05:03
*** brinzhang has joined #openstack-nova05:18
*** brinzhang_ has quit IRC05:21
*** igordc has quit IRC05:31
*** dviroel has quit IRC05:37
*** igordc has joined #openstack-nova05:38
*** sridharg has joined #openstack-nova05:38
*** dpawlik has joined #openstack-nova05:42
*** brinzhang_ has joined #openstack-nova05:46
*** markvoelker has joined #openstack-nova05:46
*** dpawlik has quit IRC05:46
*** brinzhang has quit IRC05:49
*** markvoelker has quit IRC05:56
*** markvoelker has joined #openstack-nova05:56
*** brinzhang has joined #openstack-nova05:59
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165105:59
*** markvoelker has quit IRC06:00
*** brinzhang_ has quit IRC06:02
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165106:12
*** mkrai has joined #openstack-nova06:14
*** jawad_axd has joined #openstack-nova06:14
*** brinzhang has quit IRC06:17
*** brinzhang has joined #openstack-nova06:17
*** abaindur has joined #openstack-nova06:22
*** dpawlik has joined #openstack-nova06:30
brinzhangstephenfin: alex_xu: https://review.opendev.org/#/c/682772/ this patach find the root issue and update the changes, change the conf.driver_io in the libvirt driver, not change the conf.driver_io in any disk_driver in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L174-L20006:35
brinzhangstephenfin: alex_xu: do you have time to review this, and give any suggestion?06:36
*** Luzi has joined #openstack-nova06:38
*** luksky has joined #openstack-nova06:43
*** sapd1 has joined #openstack-nova06:45
*** brinzhang_ has joined #openstack-nova06:48
*** brinzhang_ has quit IRC06:49
*** sapd1 has quit IRC06:49
*** brinzhang_ has joined #openstack-nova06:49
*** tkajinam has quit IRC06:50
*** tkajinam has joined #openstack-nova06:51
*** brinzhang has quit IRC06:51
*** igordc has quit IRC06:52
openstackgerritDaniel Pawlik proposed openstack/nova stable/train: Added openssh-client into bindep  https://review.opendev.org/69180807:02
openstackgerritDaniel Pawlik proposed openstack/nova stable/stein: Added openssh-client into bindep  https://review.opendev.org/69180907:02
*** jawad_axd has quit IRC07:04
*** nanzha has quit IRC07:04
*** nanzha has joined #openstack-nova07:08
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165107:14
*** jawad_axd has joined #openstack-nova07:15
*** jawad_ax_ has joined #openstack-nova07:16
*** jawad_axd has quit IRC07:20
*** brinzhang has joined #openstack-nova07:27
*** rcernin has quit IRC07:28
*** brinzhang_ has quit IRC07:30
*** ccamacho has joined #openstack-nova07:33
*** pcaruana has joined #openstack-nova07:37
*** slaweq has joined #openstack-nova07:42
openstackgerritsunjiyun-inspur proposed openstack/nova master: On branch vm-query-notsameproject  https://review.opendev.org/69162907:49
*** tesseract has joined #openstack-nova07:49
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when no 'O_DIRECT' is available  https://review.opendev.org/68277207:51
*** tkajinam has quit IRC07:54
*** trident has quit IRC07:55
*** trident has joined #openstack-nova08:01
openstackgerritQiu Fossen proposed openstack/nova-specs master: support instance tag fuzzy query  https://review.opendev.org/69165108:03
*** damien_r has joined #openstack-nova08:03
*** maciejjozefczyk has joined #openstack-nova08:04
*** yaawang has quit IRC08:10
*** yaawang has joined #openstack-nova08:10
*** ivve has joined #openstack-nova08:13
*** brinzhang_ has joined #openstack-nova08:13
*** brinzhang has quit IRC08:17
*** brinzhang has joined #openstack-nova08:34
*** brinzhang_ has quit IRC08:37
*** ralonsoh has joined #openstack-nova08:44
*** priteau has joined #openstack-nova08:46
*** brinzhang_ has joined #openstack-nova08:49
*** brinzhang has quit IRC08:51
*** dtantsur|afk is now known as dtantsur08:55
*** Luzi has quit IRC09:07
*** rpittau|afk is now known as rpittau09:08
*** tkajinam has joined #openstack-nova09:15
*** tkajinam has quit IRC09:16
openstackgerritQiu Fossen proposed openstack/nova-specs master: Support fuzzy querying instance by tag  https://review.opendev.org/69165109:21
*** Luzi has joined #openstack-nova09:22
*** Liang__ has quit IRC09:23
*** Xuchu has quit IRC09:32
*** CeeMac has joined #openstack-nova09:37
*** ociuhandu has joined #openstack-nova09:47
*** ociuhandu has quit IRC09:50
*** brinzhang has joined #openstack-nova09:59
*** brinzhang_ has quit IRC10:02
*** pcaruana has quit IRC10:03
sean-k-mooneybrinzhang: i guess that is one way to adress it. the other way is to say that its invalid to set the cache mode to  'writeback', 'writethrough'or 'unsafe'10:03
sean-k-mooneye.g. use cache mode = node or direct_sysnc10:04
brinzhangsean-k-mooney: yeah, it's the one way to resolve this issue.10:07
*** lpetrut has joined #openstack-nova10:07
sean-k-mooneythis is also arguably a libvirt bug given we currently dont set teh driver io mode10:07
sean-k-mooneyim pretty sure i have hit that warning in the past and that is how i fixed it for the lvm driver10:08
sean-k-mooneybut using thread io is also accpetable10:08
sean-k-mooneythread io is a little more expensive in terms of qemu cpu overhead10:08
brinzhangI am not sure all of the volume driver can be set thread10:09
sean-k-mooneywell we dont want to default to threaded10:09
sean-k-mooneythat would be incorrect10:09
brinzhangBut if donot set driver_io to thread, the bug10:10
brinzhangthe bug is also exist, do you have another suggestion to fix it?10:10
sean-k-mooneyno what i mean is we dont want to defualt to therad in general outside of this edgecase10:10
brinzhangI know set thread more expensive10:10
sean-k-mooneyby the way i dont think10:11
sean-k-mooneyif (hasattr(conf, 'driver_io') and10:11
sean-k-mooney                conf.driver_io == "native" and conf.driver_cache in10:11
sean-k-mooney                ['writeback', 'writethrough', 'unsafe']):10:11
sean-k-mooneywill work10:11
sean-k-mooneydo you know where conf.driver_io == "native"   is set10:11
sean-k-mooneyoh its set in the volume plugins10:12
brinzhangit's in the volume driver, such as iscsi https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/iscsi.py#L5710:12
sean-k-mooneyyes im not sure its valid to override that10:13
sean-k-mooneythe code you added woudl basically change that to threaded on systems without direct io10:13
sean-k-mooneybrinzhang: ok i would want to see at least a release not to call out the behavior change10:14
brinzhangYeah, we test it in iscsi, change "native" to "thread" on my env, it's ok on the function,10:15
sean-k-mooneyand ideally i think we would also want a warning in init_host signally to the operator that we are falling back to threaded io10:15
sean-k-mooneybrinzhang: threaded i think will always be supported as it was teh legacy way fo doing io10:15
sean-k-mooneyso ya it should work with isci10:16
brinzhangsean-k-mooney: thanks reply my doubt10:16
sean-k-mooneybrinzhang: ill leave some comment on the review but i think i would be ok with this as the direction for the fix. it will enable most cases to just work and as long as we warn the opertaotr of the behavior change i think its ok10:17
brinzhangsean-k-mooney: yeah, thanks.10:18
*** priteau has quit IRC10:20
*** pcaruana has joined #openstack-nova10:24
*** artom has joined #openstack-nova10:36
*** tbachman has quit IRC10:40
openstackgerritMaciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled  https://review.opendev.org/47664211:27
openstackgerritsunjiyun-inspur proposed openstack/nova master: query diff user in same project  https://review.opendev.org/69184911:27
*** arxcruz is now known as arxcruz|lunch11:37
*** damien_r has quit IRC11:49
*** ociuhandu has joined #openstack-nova11:51
*** ociuhandu has quit IRC11:55
*** jaosorior has joined #openstack-nova11:56
*** markvoelker has joined #openstack-nova11:59
*** brinzhang_ has joined #openstack-nova12:02
*** mkrai has quit IRC12:03
*** markvoelker has quit IRC12:03
*** brinzhang has quit IRC12:05
*** markvoelker has joined #openstack-nova12:05
*** damien_r has joined #openstack-nova12:05
*** tbachman has joined #openstack-nova12:06
*** larainema has quit IRC12:22
*** belmoreira has joined #openstack-nova12:27
*** dpawlik has quit IRC12:27
*** jaosorior has quit IRC12:39
*** pcaruana has quit IRC12:45
*** jmlowe has quit IRC12:48
*** munimeha1 has quit IRC12:51
*** xek has joined #openstack-nova12:55
*** arxcruz|lunch is now known as arxcruz12:56
*** dklyle has quit IRC12:57
*** david-lyle has joined #openstack-nova12:57
*** pcaruana has joined #openstack-nova12:58
*** dpawlik has joined #openstack-nova13:04
*** dave-mccowan has joined #openstack-nova13:05
*** jmlowe has joined #openstack-nova13:10
*** liuyulong has joined #openstack-nova13:11
*** sridharg has quit IRC13:11
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available  https://review.opendev.org/68277213:11
*** francoisp has joined #openstack-nova13:22
openstackgerritArthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available  https://review.opendev.org/68277213:24
*** nweinber has joined #openstack-nova13:27
*** david-lyle is now known as dklyle13:28
*** mriedem has joined #openstack-nova13:29
*** jaosorior has joined #openstack-nova13:47
*** pcaruana has quit IRC13:52
*** pcaruana has joined #openstack-nova13:55
*** Luzi has quit IRC13:55
openstackgerritsean mooney proposed openstack/nova stable/stein: make config drives sticky bug 1835822  https://review.opendev.org/69186413:56
openstackbug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,Fix released] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney)13:56
*** jaosorior has quit IRC13:59
mriedemhuh, the changePassword server action api requires you specify adminPass but the value can be an empty string, in which case the server (nova-compute service) generates a password, but its not returned to the caller...14:02
mriedemthat's....helpful14:02
*** jaosorior has joined #openstack-nova14:03
*** brinzhang_ has quit IRC14:03
sean-k-mooneyvery much so i can see why some people migt find that irrating14:03
*** brinzhang_ has joined #openstack-nova14:04
sean-k-mooneyalso i abandond ^ since i notice the other config dirve backports were abandoned too14:04
efriedmriedem: to what extent is it allowable to run osc version $later against a cloud at version $earlier ?14:05
gansoHi folks. I am about to open a new nova bug that my customer is experiencing. They are running "openstack usage list --start 2019-08-01 --end 2019-08-31 --os-compute-api-version 2.40" and it stays in infinite loop. With --debug, I could see that the marker is never updated, therefore the server always sends the same page result over and over. The env is Queens, this was tested with OpenStack CLI 3.19 and 4.0. I decided to check here in case someone14:05
gansohas seen this problem before and it is an obvious one before I open the bug. Unfortunately I don't have access to the environment so it is hard for me to collect more data, and I couldn't reproduce in my lab. So, has anyone seen this weird behavior before?14:05
mriedemso i guess the question is, would we consider it a bug that you can generate and change the admin password on a guest without getting the value back?14:05
mriedembecause if that's a bug, we might not require a microversion to change it14:05
*** brinzhang_ has quit IRC14:05
*** dklyle has quit IRC14:05
mriedemefried: osc is meant to run against old server versions14:05
*** brinzhang_ has joined #openstack-nova14:06
mriedemdtroyer is pretty adament about backward compat with old clouds14:06
mriedemeven for like nova-network support14:06
efriedhow much older? The real question is: when can we drop nova-network support from osc?14:06
efriedd'oh14:06
mriedemwhy are you asking?14:06
mriedemwe dropped nova-network support from novaclient and dean had to fix that all up in osc to continue supporting nova-net14:06
efriedbecause osc generates option helps based on whether it detects the 'network' (neutron) service or not.14:07
sean-k-mooneycan you tell form the api that it is nova networks?14:07
efriedwhich is fine when you're running in a cloud14:07
efriedbut not so much when you're generating html docs to publish.14:07
*** brinzhang_ has quit IRC14:07
*** dklyle has joined #openstack-nova14:07
sean-k-mooneyefried: well the sphinx docs for osc should generate for all intree options right14:07
mriedemganso: never heard of it but i wouldn't be surprised with markers, though it would be good to know more details about the marker, e.g. if it's a deleted server14:08
sean-k-mooneyand then plugins have there own docs14:08
*** links has joined #openstack-nova14:08
sean-k-mooneyefried: do you wnat to skip the nova networks docs?14:08
mriedemefried: option help or entire commands?14:08
efriedboth neutron and nova-net options are in osc proper, non-plugin. Yes, I would love to be able to code that decision as: "If I'm not running in a cloud, assume I'm building docs, and since nova-network is dead, only generate the neutron options"14:09
efriedmriedem: uhm, not totally sure about that, would have to dig a bit more.14:09
mriedemi'd say either drop nova-network stuff from published docs or you'd have to mark anything as nova-net as nova-net specific i guess? which probably sucks.14:09
gansomriedem: hmm that is an interesting detail. So, the marker I have is exactly the last instance returned from the first request. In the dict returned by the API, the instance is marked as "active". The CLI then uses this instance's ID for the next request URL, but then the API just returns the same page, with the same instance as last one. And over and over.14:10
efriedright14:10
sean-k-mooneyefried: given the last time i deployed with nova net osc was not a thing i have never seen the nova net commands/opetions do you have an example14:11
gansomriedem: Even though the instance is marked as "active" in the returned API, it is possible that the instance has been deleted but was active in the queried period?14:11
efriedsean-k-mooney: I'm not sure whether the docs have any of those today. Which would make my job easier, as what I'm doing will just produce the equivalent. Let me go dig some...14:12
efriedsean-k-mooney: fyi https://review.opendev.org/#/c/691767/1/openstackclient/network/common.py@17414:12
*** dklyle has quit IRC14:12
mriedemganso: i would expect that if the instance is deleted then it's vm_state is not active14:13
*** eharney has quit IRC14:14
mriedemor you're really unlucky in hitting a tight race window14:14
mriedemi just asked about deleted markers because we've seen bugs with those so i wouldn't be surprised if that is the issue14:14
gansomriedem: hmm ok so the usage returns the current instance state. About races, the customer can consistently reproduce this, it happens every time14:15
mriedemdo you have this fix? https://review.opendev.org/#/c/632516/14:15
mriedemthat is in queens 17.0.1014:15
gansomriedem: yes. Customer is running 17.0.1114:16
sean-k-mooneyefried: for what its worth looking at https://docs.openstack.org/python-openstackclient/pike/cli/command-list.html and drilling down it port and network resouce i dont see nova network sepcific commands14:16
mriedemhttps://docs.openstack.org/python-openstackclient/pike/cli/command-objects/server.html#server-ssh is nova-net specific14:17
efriedsean-k-mooney: one example is https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/security-group.html#security-group-list14:17
efriedIn this case, the nova-network options (just --all-projects) are a subset of the neutron options (which is what the doc has)14:17
efriedAnd now I'm noticing that they're tagged.14:17
sean-k-mooneymriedem: you can use the ssh command with neutron14:17
sean-k-mooney mriedem i use it all the time when im too lazy to lookup the ip14:17
sean-k-mooneyefried why is that nova networks specific. it should list the neutorn security groups14:19
sean-k-mooneyand --all-project shoudl still work in that context if you are an admin14:19
efriedsean-k-mooney: I'm saying, this is an example where the same subcommand has "different" options for nova-net vs neutron.14:19
efriedexcept they overlap14:19
sean-k-mooneyah right14:19
efriedexcept the current doc says --all-projects is ignored14:20
sean-k-mooneyNetwork version 2 ignores this option and will always display information for all projects (admin only).14:20
efriedwhich doesn't gel with what the opt help says14:20
sean-k-mooneythat is the delta14:20
efriedoh, yes it does14:20
sean-k-mooneypeople might not click that "networkign v2" mean neutron v214:20
efriedyeah, no kidding14:20
efriedokay, so nova-net only supports --all-projects, and neutron supports all the others but ignores --all-projects. (But neutron still adds the opt so it won't blow up if you use it.)14:22
sean-k-mooneyefried: ya that seam to be the case14:23
efriedokay, so to make this work the way I want, to get actual parity, I would have to produce both helps, marked with their respective support statements :(14:25
dansmith...which is what we should do if we're responsible backwards-compatible software engineers amirite?14:25
efriedyes -- again assuming we still want an ussuri-level osc to support nova-net14:26
dansmithI think you mean s/ussuri-level//14:26
efriedpython-openstackclient is cycle-with-intermediary. Its deliverables are aligned with openstack releases. I'm making changes to osc that will release with ussuri. So I think I mean, if it's legal to deploy an ussuri-level osc in a cloud that still runs nova-net...14:28
*** Sundar has joined #openstack-nova14:28
dansmithwell, I think the point is.. it's a client and I think the goal for most is to have clients be backwards compatible with stable APIs14:29
efriedbut nova-net was only deprecated in newton. Which means there will be people who will run it until it don't run no mo. Which means stein. And surely you can run ussuri osc against a stein cloud.14:30
efriedSo I can assume removing nova-net support from osc is a ways off in the future, and I have to deal with it.14:30
sean-k-mooneyefried: dansmith as a compromise assuming moveing to the sdk in ocs contindues wehn the major version bump fo that happens we could drop nova-net support as part of that14:31
dansmithefried: fwiw just the other day I was talking to someone running a very large production mitaka cloud, working to deploy train for their next phase.. it would suck super bad to not have a client be able to talk to both of them14:31
efriedfor now I don't actually care "when" or even "if"; all I needed to know was "not now".14:31
*** Liang__ has joined #openstack-nova14:31
efrieddansmith: ack14:31
efriedbtw, for what I'm working on now, it's not a question of dropping actual support for nova-net. It's just a question of whether docs.o.o/osc/ussuri{and later}/ will contain the options for nova-net.14:33
efriedbut the answer is the same.14:33
dansmithwell, if it's in the client and not documented (even if not generated) that also kinda sucks, but less so, I'll agree14:34
*** dviroel has joined #openstack-nova14:34
efrieddansmith: the CLI helps only produce the content for one or the other, by detecting whether the 'network' (neutron) endpoint exists.14:35
dansmith...right14:35
efriedbut of course we're not in your cloud when we're generating docs14:36
dansmithsure14:36
efriedthanks for the talk, all. The path forward is clear, if messy.14:36
dansmithmriedem: are you looking for me to pass all the notification payload things in via init, or only the two things you noted in the review?14:40
openstackgerritMatt Riedemann proposed openstack/nova master: Remove dead set_admin_password code to generate password  https://review.opendev.org/69187314:44
*** mkrai_ has joined #openstack-nova14:45
mriedemdansmith: just the few things noted14:51
mriedemthe image lists are generated after the fact14:51
*** mlavalle has joined #openstack-nova14:51
dansmithmriedem: okay I'm not sure I see the distinction, but that's fine14:51
mriedemit was a nit, ignore if you want14:53
*** mkrai_ has quit IRC14:54
dansmithit's already done, I just wanted to know the convention for next time, but if it's just "feels right" then that's fine too14:54
*** slaweq has quit IRC14:54
*** slaweq has joined #openstack-nova14:56
*** Liang__ has quit IRC14:57
*** gyee has joined #openstack-nova14:57
*** mkrai has joined #openstack-nova14:57
*** eharney has joined #openstack-nova14:59
*** Liang__ has joined #openstack-nova14:59
*** xek_ has joined #openstack-nova15:00
*** ociuhandu has joined #openstack-nova15:00
*** dklyle has joined #openstack-nova15:01
*** links has quit IRC15:02
*** Sundar has quit IRC15:02
*** xek has quit IRC15:02
mriedemlike the spanx i'm wearing right now, it just feels right15:03
* dansmith nods15:04
openstackgerritMatt Riedemann proposed openstack/nova master: Remove dead set_admin_password code to generate password  https://review.opendev.org/69187315:04
openstackgerritMatt Riedemann proposed openstack/nova master: Fix changePassword adminPass="" broken schema validation  https://review.opendev.org/69188015:04
openstackgerritMatt Riedemann proposed openstack/nova master: Fix changePassword adminPass="" broken schema validation  https://review.opendev.org/69188015:06
*** ociuhandu has quit IRC15:07
mriedemoh god how many duplicates do we have of this bug https://bugs.launchpad.net/nova/+bug/185015315:09
openstackLaunchpad bug 1850153 in OpenStack Compute (nova) "nova resize operation doesn't support disk resize for emphemeral disk and swap disk" [Undecided,New]15:09
efriedmriedem: so passing in an empty password does *not* generate?15:09
mriedemefried: nope15:09
mriedemand you can't pass adminPass=None15:09
efriedpassing in null theoretically would have, but that gets kicked by schema... yeah.15:09
efriedadminPass="" will actually set the password to the empty string.15:10
sean-k-mooneyyep15:10
sean-k-mooneypeopel try to cheat schema validation on the neutron side setting ""15:10
mriedemwhich is probably a security vulnerability15:10
sean-k-mooneyto pass null and end up setting it to the litral empty sting15:10
mriedemas noted in the commit, the changePassword API originally did not allow ""15:11
mriedemit was regressed when jsonschema was applied15:11
*** mdbooth has quit IRC15:11
mriedemit wasn't caught because there was no test for empty string15:11
sean-k-mooneyi suppose it would not be that hard to validate the lenght of the sting15:11
*** ociuhandu has joined #openstack-nova15:12
*** mdbooth has joined #openstack-nova15:12
efriedisn't there something where setting empty password causes it to prompt you to set a real password the next time you log in?15:13
efriedmaybe I'm remembering some old shell hack from 20y ago.15:13
sean-k-mooneyya so we should proably update https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L364-L37115:14
mriedemsean-k-mooney: do you see the patch i proposed that just scrolled above?15:15
sean-k-mooneye.g. add 'minLenght':115:15
sean-k-mooneymriedem: nope15:15
efriedmriedem: sorry, where in https://review.opendev.org/#/c/35625/ is a nonempty password enforced?15:16
sean-k-mooneyi assume it does that or something similar15:16
sean-k-mooneyhttps://review.opendev.org/#/c/691880/15:16
mriedemefried: https://review.opendev.org/#/c/35625/10/nova/api/openstack/compute/plugins/v3/admin_password.py@6115:16
mriedemefried: oh well i guess that would be True15:16
mriedem"" is a basestring15:16
efriedmriedem: that enforces ... yeah15:16
efriedso empty string has always been allowed15:17
*** liuyulong has quit IRC15:17
openstackgerritDan Smith proposed openstack/nova master: Log some stats for image pre-cache  https://review.opendev.org/68817315:18
openstackgerritDan Smith proposed openstack/nova master: Add Aggregate image caching progress notifications  https://review.opendev.org/69139015:18
sean-k-mooneythe admin password requires the qemu guest agent to work too right.15:18
*** dpawlik has quit IRC15:18
sean-k-mooneye.g. by defualt it wont work unless you enable it and install it in your guest image at least for libvirt15:19
*** Liang__ has quit IRC15:19
efriedWhich is kinda okay imo, I'm not convinced it's always wrong to use "".15:19
mriedemlooks like that was originally this https://github.com/openstack/nova/blob/icehouse-eol/nova/api/openstack/compute/servers.py#L149015:19
dansmithgibi: mriedem: are either of you aware of any example notification-consuming code out there? thinking I might write up an example tool that caches images and watches for completion via notifications15:19
sean-k-mooneyefried: well at least on the linux side it can be locked down via ssh/pam setting in the guest15:19
mriedemand this is where the generate password stuff happened https://github.com/openstack/nova/blob/icehouse-eol/nova/api/openstack/compute/servers.py#L148415:20
gibidansmith: no I don't know about such tool15:20
*** ociuhandu has quit IRC15:20
mriedemso the regression was actually that you could specify adminPass=None and it would generate a password for you, which is probably how that got down into the compute manager code15:20
dansmithgibi: bummer, okay15:20
mriedemgibi: your versioned notifications talk had a project on github you wip'ed up for consuming notifications didn't you?15:21
mriedemin devstack15:21
gibimriedem: yeah that was an example tool15:21
gibimriedem: nothing production ready15:21
*** Sundar has joined #openstack-nova15:21
dansmithgibi: not looking for production, looking for example :)15:21
gibihttps://github.com/gibizer/nova-notification-demo15:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass RequestContext to oslo_policy  https://review.opendev.org/67403815:21
gibidansmith: sorry I skipped the 'example' word in your question15:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies  https://review.opendev.org/65769815:22
dansmithgibi: thanks, I'll see if I can steal enough out of that to get something working15:22
*** ociuhandu has joined #openstack-nova15:22
gibidansmith: I'm happy to help15:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies  https://review.opendev.org/66918115:23
*** jawad_ax_ has quit IRC15:24
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-services  https://review.opendev.org/64542715:24
*** jawad_axd has joined #openstack-nova15:25
*** ociuhandu has quit IRC15:26
*** jawad_axd has quit IRC15:29
*** xek__ has joined #openstack-nova15:41
mriedemis anyone against just putting something in the API reference about https://bugs.launchpad.net/nova/+bug/1558880 being a known limitation? there are at least 3 known duplicates of that bug now and i don't see it being fixed anytime soon.15:42
openstackLaunchpad bug 1558880 in OpenStack Compute (nova) "instance can not resize ephemeral from mitaka to stein and master" [Medium,Confirmed]15:42
*** xek_ has quit IRC15:43
*** mkrai has quit IRC15:45
*** slaweq has quit IRC15:49
*** slaweq has joined #openstack-nova15:54
gibimriedem: I agree to document it as a known limitation15:54
*** jmlowe has quit IRC15:55
*** mgariepy has quit IRC15:57
*** nanzha has quit IRC15:58
*** mgariepy has joined #openstack-nova15:59
*** nanzha has joined #openstack-nova15:59
*** igordc has joined #openstack-nova16:01
*** mkrai has joined #openstack-nova16:01
openstackgerritBalazs Gibizer proposed openstack/nova master: Use admin neutron client to gather port resource requests  https://review.opendev.org/69100516:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Use admin neutron client to see if instance has qos ports  https://review.opendev.org/69190016:04
efriedmriedem: This looks weird https://docs.openstack.org/api-ref/compute/?expanded=list-hypervisors-detail#list-hypervisors16:08
mriedemcaller, can you be more specific?16:08
efried'marker' is listed twice, once as integer, once as string. In the former it says it's available until 2.52 and also new in 2.5316:08
mriedemit's because marker and id changed from an int id to a uuid in 2.5316:09
mriedemfor multi-cell listing16:09
efriedoh, sorry, I misread 2.33 as 2.53.16:09
mriedemiow, the int id is not unique across cells16:09
efriedThis looks fine.16:09
* efried crawls back into hole.16:09
efriedmriedem: but while I have your attention... adding support for new qparams into SDK, who's responsible for that?16:10
efrieddo we have like a known "we have SDK support up to XXX microversion" somewhere?16:10
mriedemnope16:11
efriede.g. with_servers in that same API doesn't seem to exist in the SDK compute proxy's `hypervisors()` method.16:11
mriedemi did that for osc16:11
mriedemhttps://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc16:12
efriedack16:12
mriedemgetting anyone to care about that is also pretty non-starty16:12
efriedbut you're not surprised that `with_servers` isn't in the SDK yet?16:12
mriedemhell no16:12
efriedokay.16:12
mriedemas i've said before, the only thing that surprises me in openstack anymore is when things work16:12
*** ivve has quit IRC16:13
openstackgerritMatt Riedemann proposed openstack/nova master: Reset instance to current vm_state if rolling back in resize_instance  https://review.opendev.org/69190816:17
*** igordc has quit IRC16:18
openstackgerritBalazs Gibizer proposed openstack/nova master: Use admin neutron client to gather port resource requests  https://review.opendev.org/69100516:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Use admin neutron client to see if instance has qos ports  https://review.opendev.org/69190016:20
*** jaosorior has quit IRC16:24
*** nanzha has quit IRC16:31
*** Sundar has quit IRC16:35
*** xek__ has quit IRC16:36
*** tesseract has quit IRC16:38
*** damien_r has quit IRC16:43
*** lpetrut has quit IRC16:49
*** AJaeger has joined #openstack-nova16:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add known limitation about resize not resizing ephemeral disks  https://review.opendev.org/69191516:51
AJaegernova team, could I get a second +2 on https://review.opendev.org/#/c/689020/ to update the openSUSE Zuul job, please? Once that is in, I'll backport as well - these are needed to move forward on the infra side.16:52
AJaegerthanks, dansmith !16:56
dansmithAJaeger: np16:56
*** nanzha has joined #openstack-nova16:59
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: re-work resize action post-conditions  https://review.opendev.org/69191817:00
*** maciejjozefczyk has quit IRC17:04
*** nanzha has quit IRC17:05
*** tbachman has quit IRC17:14
*** igordc has joined #openstack-nova17:16
gmannjohnthetubaguy melwitt: replied on unified limit spec added comment of hangout call. this lgtm now. I think it is all you have captured in spec but it will be good if you can explain the plan per cycle (what we discussed in hangout, i wrote it in comment). also you need to change the cycle name in spec -https://review.opendev.org/#/c/602201/15/specs/ussuri/approved/unified-limits-nova.rst@52317:18
*** jmlowe has joined #openstack-nova17:19
*** ivve has joined #openstack-nova17:21
*** rpittau is now known as rpittau|afk17:25
*** jawad_axd has joined #openstack-nova17:26
*** gmann is now known as gmann_afk17:29
sean-k-mooneygmann: "- at some cycle in future - remove the APIs."17:30
sean-k-mooneygmann_afk: have we ever actully got around to removeing an api since we adopted micorverions17:31
sean-k-mooneye.g. you can always fall back to 2.0 and get them17:31
dansmithsean-k-mooney: we have removed the network stuff, AFAIK17:32
dansmithreturning 409 Gone for those17:32
sean-k-mooneythe nova net apis?17:32
sean-k-mooneyya i guess17:33
sean-k-mooneywe just usually keep them for quite a long time17:33
*** tbachman has joined #openstack-nova17:33
*** gmann_afk is now known as gmann17:35
gmannsean-k-mooney: removing API i mean 410 and keep the endpoints.17:36
gmannlike nova-net, cloudpipe, nova-cert APIs. but yes when it will happen do not know17:36
sean-k-mooneyi guess there have been a few17:37
sean-k-mooneyya that is what i assumed you ment17:37
gmanni clarified in comment.17:38
*** ociuhandu has joined #openstack-nova17:40
*** dtantsur is now known as dtantsur|afk17:41
*** ociuhandu has quit IRC17:45
*** mkrai has quit IRC17:57
mriedemdansmith: you're going to have to recheck your top notification patch on https://bugs.launchpad.net/nova/+bug/185051418:05
openstackLaunchpad bug 1850514 in OpenStack Compute (nova) "ReshapeForPCPUsTest.test_vcpu_to_pcpu_reshape intermittently fails with "Cannot 'migrate' instance while it is in vm_state building"" [Medium,Confirmed]18:05
dansmithyeah I know18:05
mriedemok, posting a fix for that bug18:11
mriedemit's using the _wait_for_state_change i hate18:11
mriedembut all of the libvirt functional tests use18:12
*** ociuhandu has joined #openstack-nova18:12
*** tbachman has quit IRC18:17
*** ociuhandu has quit IRC18:18
*** tbachman has joined #openstack-nova18:18
*** tbachman has quit IRC18:23
*** jaosorior has joined #openstack-nova18:24
*** jaosorior has quit IRC18:26
*** nweinber_ has joined #openstack-nova18:27
*** jmlowe has quit IRC18:28
*** nweinber has quit IRC18:29
*** tbachman has joined #openstack-nova18:30
openstackgerritMatt Riedemann proposed openstack/nova master: Fix race in test_vcpu_to_pcpu_reshape  https://review.opendev.org/69194118:33
mriedemdansmith: efried: ^ fixes that gate bug18:33
*** elod has quit IRC18:33
*** elod has joined #openstack-nova18:33
*** jmlowe has joined #openstack-nova18:33
*** abaindur has quit IRC18:36
*** nweinber__ has joined #openstack-nova18:45
*** nweinber_ has quit IRC18:47
dansmithmriedem: I haven't looked, but why does that fix it? because it might catch the ACTIVE before the transition or something?18:48
efrieddansmith: yes, that's how I understand it.18:51
efriedbecause it catches "not ACTIVE" immediately, rather.18:52
efriedmriedem: +218:52
dansmithyeah okay18:56
dansmithoh I should read the damn commit message :P18:57
mriedemalways start with the commit message...19:00
mriedemat least on my patches19:00
dansmithwell, I like to look at code first, but sometimes forget to go back19:00
dansmithmriedem: thanks for recheckin' mah thing19:01
mriedemhey, it's my pleasure19:01
mriedem;P19:01
*** spatel has joined #openstack-nova19:02
*** spatel has quit IRC19:02
*** tbachman has quit IRC19:02
mriedembrinzhang keeps pushing this spec since berlin and i just don't see the justification for it in case others want to pile on https://review.opendev.org/#/c/580336/19:05
mriedemit also requires changing what is now the swap volume only api19:05
mriedemwhich could get a bit weird19:05
*** Guest85345 is now known as benj_19:08
*** ralonsoh has quit IRC19:08
*** abaindur has joined #openstack-nova19:16
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1849409  https://review.opendev.org/69072019:25
openstackbug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)19:25
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix listing deleted servers with a marker  https://review.opendev.org/69072119:25
mriedemmelwitt: i worked around the rocky-only intermittent failure you noticed in ^19:27
*** eharney has quit IRC19:29
artommriedem, re: brinzhang's spec - isn't that heat's job?19:35
artom(Not updating volume attachments, deleting related things as a unit)19:38
artom(Which is what they want... right?)19:38
artomOh, just read your last comment19:39
dansmithartom: this is more about instances that were not created with the flag set the way they want it, right/19:39
artomI was thinking "make this volume go away when its instance does"19:40
dansmithright but you can already do that today19:40
dansmithif you get the flag set when you create the instance19:40
artomNot "oops, I messed up, please keep this volume when its instance goes away"19:40
dansmithif you don't, then you might want to change it later, which I thought is the point of this spec19:40
artomdansmith, right, they want to set it after19:40
artom... besides the wrong API stuff that mriedem raised, seems reasonable to me...19:42
*** panda|pto has quit IRC19:55
*** panda has joined #openstack-nova19:58
*** elod has quit IRC20:02
*** elod has joined #openstack-nova20:02
mriedemthe use case is you boot from volume with delete_on_termination=True, do some awesome stuff in the volume and then realize you don't want it deleted when you delete the server so you want to change delete_on_termination=False,20:08
mriedemwhich you can do since 2.79 with non-root volumes,20:08
mriedemand you can create a snapshot of the server which will create volume snapshots since forever20:09
mriedemso it seems like a waste of effort to bake that all into an API that is already solely just dealing with swap volume semantics20:09
*** AJaeger has left #openstack-nova20:10
mriedemobviously we *can* do this but i'm saying it doesn't seem justifiable that we *should* do it20:10
gmannefried: can you remove -2 on this, spec is merged and I am rebasing the series now - https://review.opendev.org/#/c/674038/20:11
mriedemanother spec that is a good example of things we can do but i'm not sure we should https://review.opendev.org/#/c/682302/20:12
mriedembut we kind of opened pandora's box when adding changePassword in the first place20:12
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles and mapping in policy base class  https://review.opendev.org/64545220:13
*** dpawlik has joined #openstack-nova20:14
mriedemheh http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010429.html20:15
openstackgerritGhanshyam Mann proposed openstack/nova master: Add policy deprecation fixture and Suppress warnings in tests  https://review.opendev.org/67667020:15
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies  https://review.opendev.org/64848020:15
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy  https://review.opendev.org/67668820:16
*** dpawlik has quit IRC20:19
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies  https://review.opendev.org/65769820:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in Admin Actions  https://review.opendev.org/65782320:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in Admin Action API policies  https://review.opendev.org/67668220:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Ensure we pass a target in admin actions  https://review.opendev.org/66309520:21
efriedgmann: done20:23
gmannjohnthetubaguy: melwitt ^^ rebased the policy patches. this and all its base patches are one set of os-services API policy change - https://review.opendev.org/#/c/676688/220:24
gmannefried: thanks20:24
*** CeeMac has quit IRC20:27
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies  https://review.opendev.org/65769820:27
*** eharney has joined #openstack-nova20:27
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in Admin Actions  https://review.opendev.org/65782320:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in Admin Action API policies  https://review.opendev.org/67668220:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Ensure we pass a target in admin actions  https://review.opendev.org/66309520:28
*** markvoelker has quit IRC20:35
*** markvoelker has joined #openstack-nova20:45
*** nweinber__ has quit IRC20:53
*** dtruong has quit IRC21:01
*** dtruong has joined #openstack-nova21:01
*** pcaruana has quit IRC21:15
openstackgerritsean mooney proposed openstack/nova master: Add transform_image_metadata request filter  https://review.opendev.org/66577521:21
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.opendev.org/63826921:40
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job  https://review.opendev.org/65665621:40
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim  https://review.opendev.org/68883221:40
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest  https://review.opendev.org/69199121:40
mriedemgibi: when you get a chance, can you come back on these cross-cell resize patches that you were +2 on before but have been rebased https://review.opendev.org/#/c/635668/ https://review.opendev.org/#/c/635684/21:42
*** elod has quit IRC21:45
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest  https://review.opendev.org/69199121:45
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.opendev.org/63826921:45
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job  https://review.opendev.org/65665621:45
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim  https://review.opendev.org/68883221:45
*** elod has joined #openstack-nova21:47
*** slaweq has quit IRC21:52
mriedemsmcginnis: btw, still waiting on https://review.opendev.org/#/c/687058/ for queens EM, it's been getting rechecked for a couple of weeks now - random unrelated failures and a long queue for nova to get ci run21:53
mriedemi think it if continues to fail into tomorrow i say we just cut it and let that not be part of the last release, it's a rando 3rd party volume driver fix that is low priority21:53
smcginnismriedem: Thanks, I had meant to check up on things today.21:54
*** elod has quit IRC21:54
smcginnisDang, (10 rechecks)21:54
*** elod has joined #openstack-nova21:56
mriedemdansmith: http://status.openstack.org/elastic-recheck/#1844929 continues to hurt the gate pretty badly - any ideas on ways that we could maybe punch/tickle the scheduler/cell db post-upgrade in grenade before running smoke tests to see if we can flush that out somehow?21:57
*** rcernin has joined #openstack-nova22:02
*** mriedem has quit IRC22:06
openstackgerritMerged openstack/nova master: Switch to opensuse-15 nodeset  https://review.opendev.org/68902022:06
*** gyee has quit IRC22:27
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Fix a bug in the sequence diagram.  https://review.opendev.org/69200122:39
*** slaweq has joined #openstack-nova22:50
*** gyee has joined #openstack-nova22:52
*** slaweq has quit IRC22:54
*** abaindur has quit IRC23:04
*** abaindur has joined #openstack-nova23:05
*** tkajinam has joined #openstack-nova23:08
*** ivve has quit IRC23:13
openstackgerritMerged openstack/nova stable/queens: Fixes multi-registry config in Quobyte driver  https://review.opendev.org/68705823:18
openstackgerritMerged openstack/nova master: Fix race in test_vcpu_to_pcpu_reshape  https://review.opendev.org/69194123:18
*** abaindur has quit IRC23:26
*** luksky has quit IRC23:26
*** abaindur has joined #openstack-nova23:27
*** abaindur has quit IRC23:33
*** mlavalle has quit IRC23:34
*** tbachman has joined #openstack-nova23:45
*** tkajinam has quit IRC23:48
*** brinzhang has joined #openstack-nova23:49
*** gyee has quit IRC23:54
« Monday, 2019-10-28 Index Wednesday, 2019-10-30 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!