Wednesday, 2019-10-23

« Tuesday, 2019-10-22 Index Thursday, 2019-10-24 »
*** rcernin has joined #openstack-nova00:05
*** gyee has quit IRC00:18
*** dviroel has quit IRC00:20
*** mdbooth has quit IRC00:38
openstackgerritmelanie witt proposed openstack/nova master: Fix policy doc for host_status and extended servers attribute  https://review.opendev.org/68983300:39
*** mdbooth has joined #openstack-nova00:40
*** hamzy__ has joined #openstack-nova00:51
*** hamzy_ has quit IRC00:53
*** mkrai has joined #openstack-nova00:59
*** Liang__ has joined #openstack-nova01:04
*** TxGirlGeek has joined #openstack-nova01:05
*** nanzha has joined #openstack-nova01:14
*** macz has joined #openstack-nova01:17
*** tetsuro has joined #openstack-nova01:20
*** mlavalle has quit IRC01:21
*** Liang__ has quit IRC01:40
*** ociuhandu has joined #openstack-nova02:06
*** ociuhandu has quit IRC02:12
KeithMnemonicmriedem here is the bug report https://bugs.launchpad.net/nova/+bug/184940902:27
openstackLaunchpad bug 1849409 in OpenStack Compute (nova) "openstack server list --deleted --limit -1 hangs" [Undecided,New]02:27
KeithMnemoniclet me know if you need anything changed/added to the bug report02:29
*** macz has quit IRC02:32
*** macz has joined #openstack-nova02:34
*** nanzha has quit IRC02:36
*** macz has quit IRC02:37
KeithMnemonicmriedem, i test that fix in one of my envs (pike) and it does resolve the issue02:37
*** nanzha has joined #openstack-nova02:38
KeithMnemonicmriedem how far can we backport it, rocky, queens but not pike?02:39
*** markvoelker has quit IRC02:45
*** spsurya has joined #openstack-nova02:52
openstackgerritmelanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN  https://review.opendev.org/67918102:57
*** ricolin has joined #openstack-nova03:16
*** gbarros has quit IRC03:24
*** mkrai has quit IRC03:59
*** mkrai_ has joined #openstack-nova03:59
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334104:09
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602904:09
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree  https://review.opendev.org/67652204:09
*** macz has joined #openstack-nova04:11
*** ileixe has quit IRC04:28
*** ileixe has joined #openstack-nova04:30
*** ociuhandu has joined #openstack-nova04:31
*** ociuhandu has quit IRC04:35
*** mkrai_ has quit IRC04:38
*** mkrai has joined #openstack-nova04:42
*** markvoelker has joined #openstack-nova04:46
*** markvoelker has quit IRC04:51
*** macz has quit IRC04:52
*** TxGirlGeek has quit IRC05:17
*** ociuhandu has joined #openstack-nova05:35
*** andyzon has joined #openstack-nova05:35
*** ociuhandu has quit IRC05:39
*** ralonsoh has joined #openstack-nova05:47
*** ccamacho has quit IRC05:58
*** igordc has joined #openstack-nova05:58
*** ileixe has quit IRC06:00
*** igordc has quit IRC06:03
*** dpawlik has joined #openstack-nova06:05
*** ratailor has joined #openstack-nova06:15
*** andyzon has quit IRC06:16
*** belmoreira has joined #openstack-nova06:28
*** rcernin has quit IRC06:37
*** andyzon has joined #openstack-nova06:43
*** markvoelker has joined #openstack-nova06:48
*** andyzon has quit IRC06:48
*** andyzon_ has joined #openstack-nova06:48
*** andyzon has joined #openstack-nova06:49
*** maciejjozefczyk has joined #openstack-nova06:52
*** markvoelker has quit IRC06:53
*** andyzon_ has quit IRC06:53
*** trident has quit IRC06:55
*** slaweq has joined #openstack-nova06:58
*** trident has joined #openstack-nova07:00
*** nanzha has quit IRC07:04
*** nanzha has joined #openstack-nova07:04
*** ttsiouts has joined #openstack-nova07:09
bauzasgood morning Nova07:18
*** damien_r has joined #openstack-nova07:19
openstackgerritDaniel Pawlik proposed openstack/nova master: Added openssh-client into bindep  https://review.opendev.org/69048207:21
*** ttsiouts has quit IRC07:25
*** ttsiouts has joined #openstack-nova07:26
*** ttsiouts has quit IRC07:30
*** damien_r has left #openstack-nova07:34
*** ivve has joined #openstack-nova07:39
*** nanzha has quit IRC07:41
*** ratailor_ has joined #openstack-nova07:44
*** brault has quit IRC07:44
*** ratailor has quit IRC07:46
*** nanzha has joined #openstack-nova07:48
*** ttsiouts has joined #openstack-nova07:53
*** jangutter has quit IRC07:54
*** belmoreira has quit IRC07:58
*** jangutter has joined #openstack-nova07:59
*** mgoddard has joined #openstack-nova08:05
*** rpittau|afk is now known as rpittau08:07
openstackgerritMerged openstack/nova master: Remove compute compat checks for aborting queued live migrations  https://review.opendev.org/68840908:08
openstackgerritMerged openstack/nova stable/stein: rt: soften warning case in _remove_deleted_instances_allocations  https://review.opendev.org/67951908:08
openstackgerritMerged openstack/nova master: Revert "vif: Resolve a TODO and update another"  https://review.opendev.org/67577608:08
*** tkajinam has quit IRC08:10
*** ccamacho has joined #openstack-nova08:13
openstackgerritMerged openstack/nova master: Revert "Log CellTimeout traceback in scatter_gather_cells"  https://review.opendev.org/69041708:27
*** dtantsur|afk is now known as dtantsur08:38
*** ttsiouts has quit IRC08:40
*** ttsiouts has joined #openstack-nova08:41
*** ttsiouts has quit IRC08:41
*** ttsiouts_ has joined #openstack-nova08:41
*** markvoelker has joined #openstack-nova08:49
*** ttsiouts_ has quit IRC08:52
*** ttsiouts has joined #openstack-nova08:53
*** markvoelker has quit IRC08:53
*** ttsiouts has quit IRC08:53
*** ttsiouts has joined #openstack-nova08:53
*** otsukahy has joined #openstack-nova08:55
*** otsukahy has quit IRC08:57
*** pcaruana has joined #openstack-nova09:02
*** otsukahy has joined #openstack-nova09:05
*** damien_r has joined #openstack-nova09:07
*** otsukahy has quit IRC09:16
*** maciejjozefczyk has quit IRC09:20
*** maciejjozefczyk has joined #openstack-nova09:20
*** nanzha has quit IRC09:21
*** nanzha has joined #openstack-nova09:21
*** rcernin has joined #openstack-nova09:23
*** derekh has joined #openstack-nova09:31
*** psachin has joined #openstack-nova09:46
*** psachin has quit IRC09:52
*** nanzha has quit IRC09:56
*** nanzha has joined #openstack-nova09:57
*** CeeMac has quit IRC09:58
*** jaosorior has joined #openstack-nova10:02
*** tssurya has joined #openstack-nova10:03
openstackgerritMerged openstack/nova stable/stein: Add functional test for resize crash compute restart revert  https://review.opendev.org/68753210:10
*** nanzha has quit IRC10:18
*** macz has joined #openstack-nova10:19
*** macz has quit IRC10:24
*** nanzha has joined #openstack-nova10:25
*** ttsiouts has quit IRC10:25
*** ttsiouts has joined #openstack-nova10:26
*** ttsiouts has quit IRC10:30
*** pcaruana has quit IRC10:41
*** tbachman has quit IRC10:50
openstackgerritMerged openstack/nova stable/stein: Prevent init_host test to interfere with other tests  https://review.opendev.org/68757910:50
*** yaawang_ has quit IRC10:51
*** yaawang_ has joined #openstack-nova10:52
*** belmoreira has joined #openstack-nova10:54
openstackgerritMerged openstack/nova stable/stein: Functional reproduce for bug 1833581  https://review.opendev.org/68753410:55
openstackbug 1833581 in OpenStack Compute (nova) stein "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)10:55
*** ttsiouts has joined #openstack-nova10:58
*** mkrai has quit IRC11:01
*** dtantsur is now known as dtantsur|brb11:01
*** ratailor_ has quit IRC11:12
*** macz has joined #openstack-nova11:23
*** macz has quit IRC11:27
*** dviroel has joined #openstack-nova11:47
*** yaawang_ has quit IRC11:58
*** ttsiouts has quit IRC12:01
*** ttsiouts has joined #openstack-nova12:02
*** otsukahy has joined #openstack-nova12:02
*** markvoelker has joined #openstack-nova12:05
*** ttsiouts has quit IRC12:06
*** dtantsur|brb is now known as dtantsur12:09
*** belmoreira has quit IRC12:09
*** tbachman has joined #openstack-nova12:10
*** tbachman has quit IRC12:17
*** tbachman has joined #openstack-nova12:18
*** nanzha has quit IRC12:25
*** nanzha has joined #openstack-nova12:27
*** hamzy_ has joined #openstack-nova12:30
*** hamzy__ has quit IRC12:33
*** hamzy has joined #openstack-nova12:35
*** hamzy_ has quit IRC12:37
*** ttsiouts has joined #openstack-nova12:45
*** takamatsu has joined #openstack-nova12:49
*** belmoreira has joined #openstack-nova12:51
openstackgerritMerged openstack/nova stable/stein: Error out interrupted builds  https://review.opendev.org/68753512:52
*** pcaruana has joined #openstack-nova12:53
*** mdbooth has quit IRC12:54
*** mdbooth has joined #openstack-nova12:56
*** dpawlik has quit IRC12:57
*** dave-mccowan has joined #openstack-nova12:57
*** nweinber_ has joined #openstack-nova12:57
openstackgerritMerged openstack/nova stable/stein: Fix exception translation when creating volume  https://review.opendev.org/68807313:01
openstackgerritMerged openstack/nova stable/train: Func: bug 1849165: mig race with _populate_assigned_resources  https://review.opendev.org/69009913:02
openstackbug 1849165 in OpenStack Compute (nova) train "_populate_assigned_resources raises "TypeError: argument of type 'NoneType' is not iterable" during active migration" [High,In progress] https://launchpad.net/bugs/1849165 - Assigned to Eric Fried (efried)13:02
*** nweinber__ has joined #openstack-nova13:02
openstackgerritMerged openstack/nova stable/train: Don't populate resources for not-yet-migrated inst  https://review.opendev.org/69010013:02
openstackgerritMerged openstack/nova stable/stein: Handle get_host_availability_zone error during reschedule  https://review.opendev.org/68626413:02
openstackgerritMerged openstack/nova stable/rocky: Fix unit of hw_rng:rate_period  https://review.opendev.org/68915413:02
openstackgerritMerged openstack/nova stable/rocky: Skip test_parallel_evacuate_with_server_group until fixed  https://review.opendev.org/68640213:02
*** hamzy has quit IRC13:03
*** nweinber_ has quit IRC13:05
*** yan0s has joined #openstack-nova13:07
*** dpawlik has joined #openstack-nova13:08
*** dave-mccowan has quit IRC13:17
*** rcernin has quit IRC13:24
*** belmoreira has quit IRC13:25
*** mriedem has joined #openstack-nova13:30
*** otsukahy has quit IRC13:32
*** eharney has quit IRC13:34
*** otsukahy has joined #openstack-nova13:39
KeithMnemonichi mriedem, short summary- bug logged, tested fix in my env and the hang does not occur. let me know if you need anything else13:43
*** otsukahy has quit IRC13:44
*** xek__ has joined #openstack-nova13:47
*** xek_ has joined #openstack-nova13:49
*** gbarros has joined #openstack-nova13:50
*** xek__ has quit IRC13:52
*** hamzy has joined #openstack-nova13:53
*** damien_r has left #openstack-nova13:53
mriedemyup i saw thanks, just trying to fix the other test that is failing, which means the fix won't be so clean13:56
KeithMnemonicthanks for the update, just ping me if you need anything else13:57
openstackgerritMerged openstack/nova stable/queens: Fix non-existent method of Mock  https://review.opendev.org/67684413:58
*** ivve has quit IRC14:05
*** andyzon has quit IRC14:10
*** belmoreira has joined #openstack-nova14:11
*** andyzon has joined #openstack-nova14:11
*** andyzon has quit IRC14:11
*** andyzon has joined #openstack-nova14:11
*** dpawlik has quit IRC14:11
*** otsukahy has joined #openstack-nova14:13
*** andyzon has quit IRC14:16
*** dave-mccowan has joined #openstack-nova14:16
*** otsukahy has quit IRC14:17
*** markvoelker has quit IRC14:20
*** priteau has joined #openstack-nova14:21
*** andyzon has joined #openstack-nova14:23
*** efried1 has joined #openstack-nova14:24
*** efried has quit IRC14:24
*** efried1 is now known as efried14:24
*** eharney has joined #openstack-nova14:27
*** markvoelker has joined #openstack-nova14:32
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional regression test for bug 1849409  https://review.opendev.org/69042814:33
openstackbug 1849409 in OpenStack Compute (nova) "openstack server list --deleted --limit -1 hangs" [High,Triaged] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)14:33
openstackgerritMatt Riedemann proposed openstack/nova master: Fix listing deleted servers with a marker  https://review.opendev.org/69042914:33
mriedemKeithMnemonic: ^14:33
mriedemmelwitt: dansmith: ^ we should get that back to queens before it goes to extended maintenance b/c it was a regression introduced in queens14:34
*** artom has quit IRC14:36
*** artom has joined #openstack-nova14:37
*** dave-mccowan has quit IRC14:37
*** artom has quit IRC14:37
*** amodi has quit IRC14:39
*** mkrai has joined #openstack-nova14:43
*** Garyx_ has quit IRC14:44
*** Garyx_ has joined #openstack-nova14:44
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: [stable-only] Disable cinder-backup service in nova-next job  https://review.opendev.org/69059314:47
*** slaweq has quit IRC14:47
sean-k-mooneymriedem: ill try and deploy the backport of that macvtap patch locally by the way and ill report back. the fact that we were seeing libvirt errors before the tempest jobs actully start makes me think that the melonox ci is haveing other issues.14:50
mriedemok that's what adrianc said about failures from that job on the change on master as well14:50
*** dklyle has quit IRC14:52
*** andyzon has quit IRC14:54
*** dklyle has joined #openstack-nova14:56
*** pcaruana has quit IRC14:57
adriancsean-k-mooney, mriedem, there are probably other issues, we have deployed internally and macvtap is working14:57
*** nanzha has quit IRC14:58
sean-k-mooneyadrianc: ya that what i was assuming too but id does not hurt to triple check these things14:58
adriancalso the issues observed are probably because the Baremetal server was not clean before running the CI job14:59
sean-k-mooneyi looked through the devstack logs and i could not see anything obviously out of the ordenary14:59
sean-k-mooneyya that is possibel i suspect that libvirt needed to be restarted15:00
dansmithmriedem: so we always return from getting BR, null the marker,15:00
*** nanzha has joined #openstack-nova15:00
dansmithmriedem: which means we keep getting the top N results from the instance list because we call without the marker yeah?15:00
melwittmriedem: ack15:00
mriedemdansmith: yeah15:01
mriedemand novaclient doesn't check to see that the marker it used in the last pass is the same as the marker it's going to use in the next pass15:01
mriedemso the cli just hangs15:01
dansmithhangs but is hammering the api15:02
mriedemyup15:02
dansmithmeh this doesn't seem worth fixing15:02
* mriedem abandons15:02
dansmithhah15:02
*** TxGirlGeek has joined #openstack-nova15:02
dansmithhow has this not been a thing before? like, doesn't this break almost everyone's pagination?15:02
mriedemi'm surprised it hasn't come up earlier, so idk,15:03
*** mlavalle has joined #openstack-nova15:03
mriedemit's a combination of using that --limit -1 semantic in the CLI and filtering on --deleted servers15:03
*** mkrai has quit IRC15:04
mriedemmaybe admins don't use --limit -1 often, idk15:04
dansmithoh right right, forgot about the deleted thing15:04
openstackgerritMatt Riedemann proposed openstack/nova master: doc: note the need to configure cinder auth in reclaim_instance_interval  https://review.opendev.org/69060215:06
*** ttsiouts has quit IRC15:09
*** ttsiouts has joined #openstack-nova15:09
*** tssurya has quit IRC15:10
*** ttsiouts has quit IRC15:14
*** maciejjozefczyk has quit IRC15:16
openstackgerritAdrian Chiris proposed openstack/nova stable/train: Revert "vif: Resolve a TODO and update another"  https://review.opendev.org/69012615:17
*** belmoreira has quit IRC15:24
*** mkrai has joined #openstack-nova15:25
mriedemgibi_off: looks like we need https://review.opendev.org/#/c/687550/ updated to keep that series moving,15:25
mriedemelod: ^ if gibi is out maybe you can do that?15:25
*** macz has joined #openstack-nova15:26
mriedemdoesn't have to be today since i know it's late in the day there, but would be good to wrap that up tomorrow15:26
*** gyee has joined #openstack-nova15:26
*** macz has quit IRC15:27
*** macz has joined #openstack-nova15:27
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Revert "vif: Resolve a TODO and update another"  https://review.opendev.org/69012615:28
mriedemneed another stable core on ^, that's a fix for a regression in train15:30
openstackgerritMerged openstack/python-novaclient master: Switch to Ussuri jobs  https://review.opendev.org/69001315:30
*** andyzon has joined #openstack-nova15:30
mriedemefried: you'll like this https://review.opendev.org/#/q/owner:kangyufei+status:open15:30
*** yan0s has quit IRC15:31
mriedemlyarwood: the stein version of this is merged now https://review.opendev.org/#/c/686292/15:34
lyarwoodmriedem: ack thanks,15:35
mriedemdansmith: mind hitting this in stable/rocky? https://review.opendev.org/#/c/686276/15:35
dansmithyar15:36
*** dtantsur is now known as dtantsur|afk15:48
*** igordc has joined #openstack-nova15:51
*** gbarros has quit IRC15:55
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: rt: only map compute node if we created it  https://review.opendev.org/67628515:57
*** ccamacho has quit IRC16:02
lyarwoodmriedem: https://review.opendev.org/#/q/topic:bug/1843639 - would you mind taking a swing at this if you have time this week btw? The functional test might be a little over the top for a chance like this but it felt like the best way of verifying this at the time.16:02
lyarwoodchange*16:02
*** macz has quit IRC16:04
mriedemi see that depends on https://review.opendev.org/#/c/686832/ which has had a -1 sitting for awhile16:05
mriedemis that going to be addressed?16:05
lyarwoodmriedem: I was going to talk to artom about that today once he's around16:06
lyarwoodmriedem: I'm happy to address it if he doesn't have time16:06
*** maciejjozefczyk has joined #openstack-nova16:09
*** andyzon has quit IRC16:10
mriedemlyarwood: ok i'll get out the red pen for your functional test16:11
*** mkrai has quit IRC16:12
lyarwoodthanks16:12
mriedemman there is a lot of mocking in this func test16:13
mriedemusually a red flag16:13
lyarwoodyeah given I'm trying to get to post_live_migration within the Libvirt driver itself I had to mock out the initial checks and migration itself16:16
mriedemi'm not sure the functional test is worth it honestly,16:17
mriedemespecially given the simple nature of the fix in the driver16:17
mriedemtrying to backport that functional test is also going to be a nightmare16:18
*** nanzha has quit IRC16:18
lyarwoodyeah true, I started writing this while triaging the original downstream bug as a way of proving an exception from post_live_migration would leave the instance in an ERROR state pointing at the wrong host16:18
mriedemwell, at least a bad dream16:18
mriedemthat's possible without using and mocking the shit out of the libvirt driver here,16:18
mriedemi.e. you could have a much much simpler functional test that just stubs the driver.post_live_migration method to raise some exception16:19
mriedembingo bango you cut out 80% of the gross of that test16:19
lyarwoodwell that's one mock gone16:20
efriedmriedem: somebody had to do it :P16:20
lyarwoodokay maybe two16:20
*** gbarros has joined #openstack-nova16:21
lyarwoodthat wouldn't even work anyway16:21
mriedemlyarwood: i left a comment16:21
lyarwoodthe pre migration checks are a PITA to workaround in a functional test sense16:21
mriedemwe have functional tests with the fake driver that all handle live migratoin16:21
mriedemthe only thing you have to do is stub out driver.post_live_migration to raise processutils.ProcessExecutionError16:22
mriedemso if you made this much simpler and more generic i'd say cool with the functional test - and it removes your dep on artom's change - otherwise i'd say drop it16:22
lyarwoodthat's only useful if I moved the fix up into the compute layer and out of the Libvirt driver16:22
mriedemtrue, in the libvirt driver fix you'd have to just remove the stub which would be dumb16:23
lyarwoodI don't mind going that way16:23
lyarwoodbut I was worried that other virt drivers might not want that behaviour tbh16:24
mriedemi'd just drop the functional test - you've at least proven the issue with it so we can be comfortable with the driver fix on top16:26
lyarwoodyup that's fine, thanks for the review!16:26
mriedemand now artom can go back to watching antiques roadshow16:27
*** andyzon has joined #openstack-nova16:28
*** andyzon has quit IRC16:32
*** markvoelker has quit IRC16:33
*** xek__ has joined #openstack-nova16:33
*** xek_ has quit IRC16:36
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration  https://review.opendev.org/68262216:39
melwittmriedem: I dunno if you saw, but I proposed a devstack change to fix the vnc + tls thing https://review.opendev.org/69046916:40
KeithMnemonicmriedem, would you expect --deleted --marker to work or is --marker only for active instances16:42
mriedemmelwitt: ooo cool16:43
mriedemKeithMnemonic: i would expect it to work16:43
mriedemKeithMnemonic: if you have 20 deleted instances and limit to 10 per page, then you'd get a marker16:43
*** markvoelker has joined #openstack-nova16:43
KeithMnemoniccan you look at this., this is with your latest patch http://paste.openstack.org/show/785528/16:44
KeithMnemoniceven with --limit -1 you get the same message16:46
mriedemhmm, we do look up deleted instances for markers so it's not that https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L228316:46
*** andyzon has joined #openstack-nova16:46
mriedemwhich cell is c244e139-98fe-44eb-a971-c067954da026 in ?16:46
mriedemcell1 or cell0?16:47
KeithMnemonicfor not deleted it works as expected. let me check one sec16:47
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-next multinode and drop tempest-slow-py3  https://review.opendev.org/68398816:49
*** igordc has quit IRC16:50
*** rpittau is now known as rpittau|afk16:50
KeithMnemoniccell1 it seems16:51
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-next multinode and drop tempest-slow-py3  https://review.opendev.org/68398816:52
mriedemhmm, i wonder if there is something going on with the multi-cell instance listing stuff that has some marker logic in it16:52
KeithMnemoniclet me try it with a market in cell016:53
KeithMnemonici have one instance there16:53
melwittmriedem: uh oh https://github.com/openstack/nova/blob/master/nova/compute/instance_list.py#L5916:53
melwittoh nevermind16:53
mriedemwas just looking at that code,16:53
mriedembut yeah a deleted instance will still have a mapping16:53
mriedemuntil archived16:53
melwittthere should still be an instance mapping? or no16:53
melwittyeah16:53
mriedemand https://github.com/openstack/nova/blob/master/nova/compute/instance_list.py#L6316:53
mriedemmatches the db api to read deleted markers16:53
melwittyeah hm16:54
*** andyzon has quit IRC16:54
KeithMnemonicnope same error with a deleted instance in cell0,16:54
mriedemok when i've had to debug these types of failures before i've needed to add a LOG.exception here in the API https://github.com/openstack/nova/blob/2718de6ed7c21f8ff8cf74164ae5054531fdbc30/nova/api/openstack/compute/servers.py#L331 to get a traceback16:56
KeithMnemonicbut just --deleted --limit -1 shows deleted from cell0 and cell1 so it is definitely something with the marker16:56
mriedemKeithMnemonic: is that something you can do and then recreate to get the trace?16:56
KeithMnemonicso this is interesting16:56
KeithMnemonic"https://192.168.23.35:8774/v2.1/428982d4248a419a933668b6a4dd14a0/servers?name=c244e139-98fe-44eb-a971-c067954da026" will this work without deleted being passed?16:57
melwittI'm wondering what this get_marker_by_values is16:57
mriedemKeithMnemonic: that's not a server name16:57
KeithMnemonicthat is what --debug shows16:57
mriedemi'd expect you to get no results in that case16:57
mriedemKeithMnemonic: hmm, ok so it's probably the cli trying to determine if the marker provided is a server name or id16:58
KeithMnemonici pass in --marker c244e139-98fe-44eb-a971-c067954da02616:58
KeithMnemonicno option to specify name vs ID16:58
mriedem  --marker <server>¶ The last server of the previous page. Display list of servers after marker. Display all servers if not specified. (name or ID)16:58
mriedemthat might be a red herring if osc is just trying to determine if you gave a name or id16:59
mriedemtry to recreate with the LOG.exception injection i mentioned above to see where the MarkerNotFound is coming from17:00
mriedemyou know, we might not even be getting to the api17:00
mriedem"No server with a name or ID of 'c244e139-98fe-44eb-a971-c067954da026' exists." sounds like an osc bug17:00
mriedemok i bet i know,17:01
mriedemthe osc code is trying to find the marker server by name or id,17:01
mriedembut failing to include the deleted=True filter,17:01
mriedemso the api says "nope a server that's not deleted does not exist for that"17:01
KeithMnemonicbut should it worked without specifying deleted in the api call?17:01
mriedemmeaning can you specify a marker that is a deleted server? yes17:02
mriedemit seems the bug is in osc though17:02
mriedemhttps://github.com/openstack/python-openstackclient/blob/4.0.0/openstackclient/compute/v2/server.py#L141517:03
melwittwait, how do we know it's not including the deleted=True filter? it should show that in the --debug right17:03
mriedemosc isn't looking for a deleted marker17:03
KeithMnemonicit is osc, you can not do a show on a deleted sever, you get the same curl and same error17:03
melwittI mean, when you pass --deleted doesn't it just send deleted=True regardless? or no17:03
mriedemhttps://192.168.23.35:8774/v2.1/428982d4248a419a933668b6a4dd14a0/servers?name=c244e139-98fe-44eb-a971-c067954da026 means osc is first looking to see if the marker server is given on the command line by name17:03
melwittoh17:03
mriedemit's not, it gets a 404 and then tries by id,17:03
mriedemwhich returns a 404 because the server is deleted and you're not including the ?deleted=true filter param17:04
KeithMnemoniccorrect17:04
KeithMnemonicbut osc is called with --deleted17:04
mriedemso it's a shell bug17:04
KeithMnemonicit is just not passed to the api call17:04
mriedemright, it's a bug17:04
KeithMnemonicok against osc17:04
mriedemyes17:04
KeithMnemonici can file another today. i will reference this discussion and some debug output.17:05
KeithMnemonicis that ok17:05
mriedemsure17:05
mriedemthat goes against osc in storyboard though17:05
mriedemwhere it will languish for 1000 years17:05
KeithMnemonicok let me test on something newer to see if it still exists is train for example17:06
mriedemthat code i linked above is train17:06
mriedemso it's there17:06
mriedemhttps://github.com/openstack/osc-lib/blob/1.14.1/osc_lib/utils/__init__.py#L16917:07
mriedemlooks like the fix is relatively simple:17:07
mriedemutils.find_resource(compute_client.servers, parsed_args.marker, deleted=parsed_args.deleted)17:08
*** otsukahy has joined #openstack-nova17:08
mriedemKeithMnemonic: feel free to have suse send me a check for the openstack support anytime :)17:10
KeithMnemonicyou know that is a sore point these days17:12
dansmithspeaking of that,17:13
dansmithdid aspiers ever show up and/or has anyone else been able to resolve the SEV issue we released with train?17:13
*** otsukahy has quit IRC17:13
KeithMnemonicAFAIK, aspiers is till with SUSE but not sure in what capacity17:13
KeithMnemonicmriedem since that fix is simple, can i take a stab at it?17:14
mriedemKeithMnemonic: go nuts17:14
KeithMnemonicok thanks17:14
dansmithsupposedly the SEV thing was resolvable by someone else, but has that happened?17:17
KeithMnemonicsomeone at SUSE? dansmith17:18
mriedemyou mean boris? https://review.opendev.org/#/c/684825/17:18
mriedemhe's also suse17:18
KeithMnemoniche is still on openstack as well17:18
* mriedem gets lunch17:21
*** otsukahy has joined #openstack-nova17:24
openstackgerritMerged openstack/nova master: Adds view builders for keypairs controller  https://review.opendev.org/34728917:29
*** artom has joined #openstack-nova17:29
*** otsukahy has quit IRC17:32
dansmithKeithMnemonic: no, I meant assuming nobody from SUSE is going to fix it, there was an assertion from the libvirty people that they could resolve it too, I just haven't heard that it happened17:34
dansmithefried: ?17:34
KeithMnemonicok17:35
*** jaosorior has quit IRC17:41
*** otsukahy has joined #openstack-nova17:48
*** otsukahy has quit IRC17:52
*** otsukahy has joined #openstack-nova17:53
*** ricolin has quit IRC17:55
*** otsukahy has quit IRC17:58
*** spsurya has quit IRC17:59
mriedemdansmith: so i'd be +2 on https://review.opendev.org/#/c/687348/ except,18:00
mriedemi think we should probably drop the dependency on the osc command for now because the horizon thing holding up novaclient 16.0.0 in upper-constraints is not going well18:01
mriedemcould use the nova cli in the docs for now and leave a todo in there to replace with osc later18:01
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334118:01
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602918:01
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree  https://review.opendev.org/67652218:01
dansmithmriedem: there's no real rush to merge that is there?18:02
mriedemthe docs?18:02
mriedemi'd like to merge it sooner than later so i don't lose the context on it18:02
mriedemespecially since we have a nova cli for the thing18:02
*** ricolin has joined #openstack-nova18:03
dansmithokay18:04
*** otsukahy has joined #openstack-nova18:08
*** ccamacho has joined #openstack-nova18:08
efrieddansmith: I talked to aspiers a couple weeks ago and he said he was going to try to fix the thing regardless of what SUSE does.18:10
efriedbut like as a swan song, not any kind of ongoing support.18:10
openstackgerritMatt Riedemann proposed openstack/nova master: Remove fixed sqlalchemy-migrate deprecation warning filters  https://review.opendev.org/69070418:11
mriedemthe song....remains the same?18:11
efriedbut it's also still not out of the question that amd will pony up (or partner with) someone to maintain moving forward.18:11
openstackgerritDan Smith proposed openstack/nova master: Add image precaching docs for aggregates  https://review.opendev.org/68734818:11
dansmithmriedem: ^18:11
mriedemyou forgot to remove the depends-on18:11
dansmithoops18:11
openstackgerritDan Smith proposed openstack/nova master: Add image precaching docs for aggregates  https://review.opendev.org/68734818:12
*** tbachman has quit IRC18:12
*** otsukahy has quit IRC18:13
mriedem+218:13
openstackgerritMatt Riedemann proposed openstack/nova master: Fix policy doc for host_status and extended servers attribute  https://review.opendev.org/68983318:18
*** tbachman has joined #openstack-nova18:21
*** igordc has joined #openstack-nova18:24
*** ricolin has quit IRC18:25
efriedmriedem, dansmith: do we backport docs?18:29
openstackgerritMerged openstack/nova stable/rocky: Noop CantStartEngineError in targets_cell if API DB not configured  https://review.opendev.org/68627618:29
dansmithprobably depends a lot on what it is18:29
openstackgerritMerged openstack/nova stable/rocky: Handle get_host_availability_zone error during reschedule  https://review.opendev.org/68629218:29
openstackgerritMerged openstack/nova stable/queens: Explain nested guest support  https://review.opendev.org/60979018:29
openstackgerritMerged openstack/nova master: Add functional regression test for bug 1849409  https://review.opendev.org/69042818:29
openstackbug 1849409 in OpenStack Compute (nova) "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)18:29
efriedLeading to...18:30
efriedshould we consider pushing the pre-precaching parts of what dansmith just wrote in an independent patch that can be backported, and then tacking the precaching bits on top in a separate master-only patch?18:30
*** otsukahy has joined #openstack-nova18:31
mriedemefried: we haven't ever had docs about the image cache so i don't think anyone is chomping at the bit to have those in stable18:32
*** igordc has quit IRC18:32
dansmithI guess I'm not opposed to that, but we have had image caching since forever, no docs since forever,18:32
mriedemwe finish each other's18:32
dansmithand the master docs (minus precaching) will be live in google and applicable18:32
dansmithso kinda meh18:32
dansmithmriedem: sentences!18:32
dansmithmriedem: <318:33
mriedemteehee!18:33
efriednot sure I agree with the philosophy of "nobody ever bitched about it so it must not be worth doing" but okay.18:33
mriedemwell, it's docs18:34
mriedemand this is already ready to go18:34
efriedis gerrit slow for anyone else rn?18:34
dansmithjust doesn't seem that important to have the docs back there.. people will google for this, and find this doc regardless18:34
dansmithit's not like stable gets burned to a cd and shipped to people18:35
* mriedem stops creating isos18:35
*** tbachman has quit IRC18:35
efriedokay. +W. I'm going to work up the patch to move those conf opts.18:35
efriedunless someone is already doing thot.18:36
efriedthat18:36
mriedemit's all yours18:36
mriedembut first, https://www.youtube.com/watch?v=az8ht2-U0Q018:36
dustincefried: gerrit page loads are fine for me right now18:37
efriedthanks. I'll bounce my router then.18:37
*** pcaruana has joined #openstack-nova18:38
efriedI don't get it mriedem. You're weird.18:38
dansmithefried: messing with conf options is a fool's errand, is his point18:39
dansmithefried: and stephenfin is the boogieman in this case18:40
dansmithmriedem: did I get that right?18:40
mriedemyou're both wrong18:41
mriedemi was just thinking of it18:41
dansmithdammit18:41
mriedemwatched that episode the other night with my daughter18:41
mriedemone of my favorites18:41
*** otsukahy has quit IRC18:42
*** TxGirlGeek has quit IRC18:44
*** pcaruana has quit IRC18:44
*** efried has quit IRC18:45
*** ralonsoh has quit IRC18:45
*** efried has joined #openstack-nova18:48
*** gbarros has quit IRC18:48
mriedemlyarwood: probably too late for you today but a couple of small things in your fix https://review.opendev.org/#/c/682622/18:49
*** maciejjozefczyk has quit IRC18:50
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Add functional regression test for bug 1849409  https://review.opendev.org/69071018:52
openstackbug 1849409 in OpenStack Compute (nova) "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)18:52
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Fix listing deleted servers with a marker  https://review.opendev.org/69071118:52
*** TxGirlGeek has joined #openstack-nova18:58
*** tbachman has joined #openstack-nova19:02
*** TxGirlGeek has quit IRC19:03
efrieddansmith, mriedem: ugh, what about [libvirt]remove_unused_resized_minimum_age_seconds? Should it be a) mentioned in the docs, b) moved to [image_cache]?19:03
dansmithis that imagecache related?19:04
* dansmith looks19:04
dansmithhmm, guess so19:04
dansmithhowever,19:04
dansmiththat looks to be libvirt-specific19:04
efriedright19:04
efried...now19:04
dansmithso I dunno that I'd put that in imagecache19:04
*** nweinber_ has joined #openstack-nova19:05
dansmithyou wouldn't move libvirt-only things out to DEFAULT just because someone else could implement them in the future, would you?19:05
efriedno. But it's definitely related to image cache; and it's weird that there's remove_unused_original_minimum_age_seconds in a *different* place (whether that's [DEFAULT] or [image_cache])19:06
efriedand19:06
efriedI wouldn't put up a patch to just do that move19:06
efriedbut since I'm moving the rest, this seems like the right thing to do in concert.19:06
*** nweinber__ has quit IRC19:07
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Add functional regression test for bug 1849409  https://review.opendev.org/69071519:07
openstackbug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)19:07
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Fix listing deleted servers with a marker  https://review.opendev.org/69071619:07
dansmithefried: but DEFAULT is related to everything, so the same argument for other things would seem to apply19:09
mriedemdansmith: he's moving the image cache stuff from [DEFAULT] to a new [image_cache] group19:09
mriedemto group those like options19:09
dansmithmriedem: the remove_unused is already in the libvirt group19:10
mriedemyeah i know, that's the only one (besides your new one)19:10
mriedemi don't have a strong opinion on moving this one to the new group19:10
efriedremove_unused_*original* is in [DEFAULT]; remove_unused_*resized* is in libvirt19:10
dansmithefried: that one is used by others19:11
mriedemoh i didn't realize there were two19:11
dansmiththe libvirt-only one should stay in the libvirt group until it's used elsewhere, IMHO19:11
efriedwhich like I said I wouldn't bother to "fix" if it was just that, but IMO makes sense to move, despite being currently libvirt-only, since we're making a special group for image_cache.19:11
mriedemfun that we don't even test remove_unused_resized_minimum_age_seconds19:11
mriedemsplit the baby in half19:16
*** slaweq_ has joined #openstack-nova19:18
mriedemdansmith: i've been thinking about taking a crack at that notification sample thing for your aggregate pre-cache stuff, do you mind if i do or are you already working on it?19:18
dansmithmriedem: I've been meaning to try to corner gibi, but I've been busy in the mornings.. however, I have *no* idea where to start, so please, by all means19:19
mriedemhe's all greased up by then, hard to atch19:19
mriedem*catch19:19
mriedemok i'll see if i can wip something up to start it19:19
*** abaindur has joined #openstack-nova19:21
*** eharney has quit IRC19:27
*** otsukahy has joined #openstack-nova19:27
*** slaweq_ is now known as slaweq19:28
*** tbachman has quit IRC19:28
mriedemmelwitt: fyi there is runway slot room for your host_status patch once that is ready for re-review https://etherpad.openstack.org/p/nova-runways-ussuri19:30
melwittmriedem: oh cool, thanks19:30
*** ociuhandu has joined #openstack-nova19:30
*** otsukahy has quit IRC19:32
mriedemsean-k-mooney: is https://review.opendev.org/#/q/topic:bp/image-metadata-prefiltering+status:open ready for runways?19:33
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1849409  https://review.opendev.org/69072019:34
openstackbug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)19:34
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix listing deleted servers with a marker  https://review.opendev.org/69072119:34
*** ociuhandu has quit IRC19:35
*** eharney has joined #openstack-nova19:40
*** priteau has quit IRC19:40
*** otsukahy has joined #openstack-nova19:42
*** gouthamr has quit IRC19:43
*** nweinber_ has quit IRC19:44
*** ociuhandu has joined #openstack-nova19:45
*** gouthamr has joined #openstack-nova19:46
openstackgerritEric Fried proposed openstack/nova master: Consolidate [image_cache] conf options  https://review.opendev.org/69072319:46
efriedmriedem, dansmith: ^19:46
efried(the baby is mine)19:46
*** otsukahy has quit IRC19:46
*** igordc has joined #openstack-nova19:47
*** artom has quit IRC19:48
*** ociuhandu has quit IRC19:50
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1849409  https://review.opendev.org/69072419:50
openstackbug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)19:50
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Fix listing deleted servers with a marker  https://review.opendev.org/69072519:50
*** gouthamr_ has joined #openstack-nova19:54
*** nweinber_ has joined #openstack-nova19:55
*** otsukahy has joined #openstack-nova19:55
openstackgerritElod Illes proposed openstack/nova stable/rocky: cleanup evacuated instances not on hypervisor  https://review.opendev.org/68755019:57
*** otsukahy has quit IRC20:00
elodmriedem: I've updated the commit message ^^^ (forgot to put me '_off', as today is national holiday here, but tomorrow gibi will be back)20:02
mriedemelod: i saw that, thanks20:02
*** otsukahy has joined #openstack-nova20:04
*** markvoelker has quit IRC20:07
*** otsukahy has quit IRC20:08
*** otsukahy has joined #openstack-nova20:09
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: cleanup evacuated instances not on hypervisor  https://review.opendev.org/68755020:10
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Add functional test for resize crash compute restart revert  https://review.opendev.org/68756320:10
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Prevent init_host test to interfere with other tests  https://review.opendev.org/68786220:10
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Functional reproduce for bug 1833581  https://review.opendev.org/68756420:11
openstackbug 1833581 in OpenStack Compute (nova) rocky "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)20:11
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Error out interrupted builds  https://review.opendev.org/68756520:11
openstackgerritEric Fried proposed openstack/nova master: Consolidate [image_cache] conf options  https://review.opendev.org/69072320:11
*** otsukahy has quit IRC20:13
efrieddansmith: support matrix, you want just one section for image caching (where maybe without precaching the support is "partial") or two?20:16
dansmithdoesn't matter to me20:16
mriedemi vote for one20:16
efriedack. dansmith, I haven't looked, which drivers does precaching work for today?20:17
dansmithlibvirt20:17
efriedight20:18
*** otsukahy has joined #openstack-nova20:20
KeithMnemonicmriedem , melwitt if you use the nova cli  --deleted --marker work as expected ;-)20:23
*** gouthamr has quit IRC20:23
mriedemnova cli A #120:24
efrieddo lxc and xen fall under the same libvirt umbrella?20:24
efriedI know they inherit some stuff...20:24
*** otsukahy has quit IRC20:24
mriedemfor image caching....don't know, but i'd think yes?20:25
mriedemat least for xen, not really sure about lxc and how it uses the image cache20:25
efriedlooks like xen explicitly says nay20:26
efriedbut there's not a separate driver for lxc afaics20:26
*** otsukahy has joined #openstack-nova20:27
efriedpowervm with the ssp driver does image caching, but it's not through the ImageCacheManager etc. And it wouldn't respond to any of the conf options. Not sure whether to say that has support or not...20:27
efriedoh, a driver note.20:28
mriedemKeithMnemonic: well, with nova list are you using --marker with a server name or id?20:28
mriedemb/c i wouldn't be surprised if nova list doesn't support specifying a server name for the marker like osc does20:28
mriedemefried: i assumed you mean libvirt+xen20:28
mriedemnot the xenserver driver20:29
efrieduhm20:29
mriedemthere are 2 xens20:29
efried...oh20:29
mriedemthe one we deprecated in train was xenserver20:29
mriedemlibvirt+xen is also a thing that citrix used to maintain and no longer does20:29
efriedo, I see now20:29
mriedemjust like libvirt+lxc, libvirt+uml, etc are things20:29
efriedbut like lxc, libvirt+xen would inherit whatever libvirt has.20:29
mriedemmaybe20:29
mriedemusually20:29
mriedemlxc is a weirdo though20:30
mriedemi'd probably mark libvirt+lxc as unknown20:30
*** nweinber_ has quit IRC20:31
*** otsukahy has quit IRC20:32
efriedand libvirt+xen too?20:32
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1849409  https://review.opendev.org/69073420:32
openstackbug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)20:32
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Fix listing deleted servers with a marker  https://review.opendev.org/69073520:32
KeithMnemonicmriedem an id, just like with osc which confirms it is just osc that is not doing the marker/deleted correctly20:37
efriedboo, support matrix doesn't sphinx20:41
*** otsukahy has joined #openstack-nova20:41
mriedemKeithMnemonic: my point is, if you did: nova list --deleted --marker <server name not id> i think it won't work20:43
mriedemnova cli isn't translating the marker from a name to an id, it just assumes id20:43
sean-k-mooneylibvirt+lxc will proably work for precaching but until we add support for resizing the filesystem to mage teh resized image the it will still be kind of borked.20:44
*** markvoelker has joined #openstack-nova20:44
sean-k-mooneynormally we just assume cloud-init or the use will grow the filecycle to file the root disk itself20:44
sean-k-mooneybut that does not work with lxc20:44
sean-k-mooneyor at least if it does i dont know how to do it20:45
KeithMnemonicright, i hear you20:46
*** xek__ has quit IRC20:48
*** xek__ has joined #openstack-nova20:48
*** otsukahy has quit IRC20:50
*** slaweq has quit IRC20:51
*** xek__ has quit IRC20:51
*** xek_ has joined #openstack-nova20:52
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Add functional regression test for bug 1849409  https://review.opendev.org/69074620:52
openstackbug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem)20:52
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Fix listing deleted servers with a marker  https://review.opendev.org/69074720:52
*** eharney has quit IRC20:54
openstackgerritMatt Riedemann proposed openstack/nova master: Require Migration object arg to migrate_instance_finish method  https://review.opendev.org/69010621:02
openstackgerritMatt Riedemann proposed openstack/nova master: Stop converting Migration objects to dicts for migrate_instance_start  https://review.opendev.org/69011521:02
openstackgerritMerged openstack/nova master: Add image precaching docs for aggregates  https://review.opendev.org/68734821:03
openstackgerritEric Fried proposed openstack/nova master: Add image caching to the support matrix  https://review.opendev.org/69074821:05
efriedmriedem, dansmith: ^21:05
melwittefried, mriedem: commented on https://review.opendev.org/683988 and while I was looking at the console proxy log I notice the token auth uuid is logged at INFO at different places :( one of which is coming from underlying websockify and not sure how to stop it21:15
*** henriqueof has quit IRC21:15
efrieda websockify bug I guess21:17
melwittit's not a bug, it's emitting it's 'path' but since noVNC upstream took out the cookie forwarding stuff and had us switch to using the path, the token auth is now in the path21:18
mriedemmelwitt: unrelated to this? https://review.opendev.org/#/c/220622/21:21
melwittmriedem: that fixes one of the two spots21:21
mriedemso are you talking about this? https://zuul.opendev.org/t/openstack/build/8b011c8d92134f27ab59a8d392267b2e/log/controller/logs/screen-n-novnc-cell1.txt.gz#3121:22
mriedemINFO nova.console.websocketproxy [-] 213.32.72.99 - - [23/Oct/2019 19:12:55] 213.32.72.99: Path: '?token=badacaffcc2-6d65-4bc4-a2f5-4081318d0433'21:22
melwittyes that's the other one21:22
melwittand that's logged from websockify underneath21:22
mriedemi feel like i remember something recently about a bug with logging and the websockify stuff but can't put my finger on it21:22
melwittorly? ok. it has always emitted the 'Path:' there but now the token auth is in the path21:23
mriedemwonder if there is a way to plumb a flag down to tell it not to log the path or mask certain keys21:24
mriedemit's not a cve since this is just in the logs21:25
melwittyeah, I have to go take a gander21:25
melwittand review the patch you linked. looks pretty simple21:25
mriedemand i have to go sit through maleficent 2, taking one for the team21:26
mriedemspeaking of bad stuff21:26
melwittlol21:26
*** mriedem is now known as mriedem_afk21:26
* melwitt piles more stuff onto the todo list21:27
*** ccamacho has quit IRC21:32
efrieddansmith: what's your stance on testing requirements for the cyborg interaction? tempest > functional > unit, to the point where if there's tempest we can live without functional?21:34
*** Sundar has joined #openstack-nova21:37
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334122:03
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602922:03
openstackgerritDustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree  https://review.opendev.org/67652222:03
*** mlavalle has quit IRC22:19
*** markvoelker has quit IRC22:22
*** rcernin has joined #openstack-nova22:33
*** tbachman has joined #openstack-nova22:46
*** tkajinam has joined #openstack-nova23:02
*** abaindur has quit IRC23:03
*** abaindur has joined #openstack-nova23:04
*** igordc has quit IRC23:23
*** Sundar has quit IRC23:29
*** artom has joined #openstack-nova23:41
openstackgerritmelanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN  https://review.opendev.org/67918123:58
« Tuesday, 2019-10-22 Index Thursday, 2019-10-24 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!