| *** jawad_axd has quit IRC | 00:01 | |
| *** bbowen has quit IRC | 00:29 | |
| *** tbachman has joined #openstack-nova | 00:46 | |
| *** jawad_axd has joined #openstack-nova | 00:59 | |
| *** jawad_axd has quit IRC | 01:04 | |
| *** tbachman has quit IRC | 01:17 | |
| *** jawad_axd has joined #openstack-nova | 01:20 | |
| *** yaawang has quit IRC | 01:24 | |
| *** jawad_axd has quit IRC | 01:24 | |
| *** gbarros has quit IRC | 01:25 | |
| *** yaawang has joined #openstack-nova | 01:25 | |
| *** markvoelker has joined #openstack-nova | 01:32 | |
| *** brinzhang has joined #openstack-nova | 01:32 | |
| *** jawad_axd has joined #openstack-nova | 01:41 | |
| *** markvoelker has quit IRC | 01:42 | |
| *** markvoelker has joined #openstack-nova | 01:43 | |
| *** ircuser-1 has quit IRC | 01:43 | |
| *** jawad_axd has quit IRC | 01:45 | |
| *** markvoelker has quit IRC | 01:47 | |
| *** brinzhang_ has joined #openstack-nova | 02:00 | |
| *** gbarros has joined #openstack-nova | 02:02 | |
| *** brinzhang has quit IRC | 02:03 | |
| *** SonPham has joined #openstack-nova | 02:09 | |
| *** BjoernT has joined #openstack-nova | 02:11 | |
| SonPham | Hi. i wrote some script on horizon to show instance info. But dev environment is devstack. | 02:11 |
|---|---|---|
| SonPham | i want to write code on nova | 02:12 |
| SonPham | have any docs about nova api? | 02:12 |
| *** brinzhang has joined #openstack-nova | 02:19 | |
| *** brinzhang_ has quit IRC | 02:23 | |
| *** yaawang has quit IRC | 02:24 | |
| *** yaawang has joined #openstack-nova | 02:27 | |
| SonPham | Hi. i wrote some script on horizon to show instance info. But dev environment is devstack. | 02:28 |
| *** brinzhang_ has joined #openstack-nova | 02:40 | |
| *** jawad_axd has joined #openstack-nova | 02:43 | |
| *** brinzhang has quit IRC | 02:44 | |
| *** jawad_axd has quit IRC | 02:48 | |
| mordred | SonPham: https://docs.openstack.org/api-ref/compute/ | 02:56 |
| *** gbarros has quit IRC | 02:58 | |
| *** jawad_axd has joined #openstack-nova | 03:04 | |
| *** jawad_axd has quit IRC | 03:08 | |
| *** gbarros has joined #openstack-nova | 03:26 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** brinzhang_ has quit IRC | 03:37 | |
| *** brinzhang_ has joined #openstack-nova | 03:37 | |
| *** gbarros has quit IRC | 03:39 | |
| *** gbarros has joined #openstack-nova | 03:42 | |
| *** brinzhang has joined #openstack-nova | 03:44 | |
| *** mkrai has joined #openstack-nova | 03:45 | |
| *** SonPham has quit IRC | 03:45 | |
| *** brinzhang_ has quit IRC | 03:47 | |
| *** gbarros has quit IRC | 03:47 | |
| *** gbarros has joined #openstack-nova | 04:01 | |
| *** gbarros has quit IRC | 04:05 | |
| *** udesale has joined #openstack-nova | 04:07 | |
| *** brinzhang_ has joined #openstack-nova | 04:07 | |
| *** brinzhang has quit IRC | 04:10 | |
| *** ricolin has joined #openstack-nova | 04:12 | |
| *** gbarros has joined #openstack-nova | 04:14 | |
| *** ricolin_ has joined #openstack-nova | 04:15 | |
| *** dave-mccowan has quit IRC | 04:18 | |
| *** ricolin has quit IRC | 04:19 | |
| *** BjoernT has quit IRC | 04:24 | |
| *** brinzhang has joined #openstack-nova | 04:28 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add regression test for bug 1824435 https://review.opendev.org/688205 | 04:29 |
| openstack | bug 1824435 in OpenStack Compute (nova) "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt) | 04:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use a separate transaction to read default security group https://review.opendev.org/688206 | 04:29 |
| *** brinzhang_ has quit IRC | 04:31 | |
| *** lpetrut has joined #openstack-nova | 04:42 | |
| *** yaawang has quit IRC | 04:52 | |
| *** lpetrut has quit IRC | 04:52 | |
| *** yaawang has joined #openstack-nova | 04:52 | |
| *** brinzhang_ has joined #openstack-nova | 05:44 | |
| *** brinzhang has quit IRC | 05:47 | |
| *** larainema has joined #openstack-nova | 05:51 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add regression test for bug 1824435 https://review.opendev.org/688205 | 06:05 |
| openstack | bug 1824435 in OpenStack Compute (nova) "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt) | 06:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use a separate transaction to read default security group https://review.opendev.org/688206 | 06:05 |
| *** ccamacho has joined #openstack-nova | 06:10 | |
| *** jawad_axd has joined #openstack-nova | 06:13 | |
| *** dpawlik has joined #openstack-nova | 06:23 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 06:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 06:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 06:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 06:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 06:23 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: [WIP] add cyborg tempest job https://review.opendev.org/670999 | 06:23 |
| *** pcaruana has joined #openstack-nova | 06:43 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:46 | |
| *** slaweq has joined #openstack-nova | 07:04 | |
| *** tesseract has joined #openstack-nova | 07:04 | |
| *** rcernin has quit IRC | 07:11 | |
| *** damien_r has joined #openstack-nova | 07:13 | |
| *** rpittau|afk is now known as rpittau | 07:40 | |
| *** jangutter has joined #openstack-nova | 07:42 | |
| *** markvoelker has joined #openstack-nova | 07:45 | |
| *** ivve has joined #openstack-nova | 07:46 | |
| *** markvoelker has quit IRC | 07:51 | |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** brinzhang has joined #openstack-nova | 07:57 | |
| gibi | good morning nova | 07:58 |
| *** awalende has joined #openstack-nova | 08:00 | |
| *** brinzhang_ has quit IRC | 08:00 | |
| bauzas | gibi: good morning :) | 08:02 |
| gibi | :) | 08:02 |
| *** dpawlik has quit IRC | 08:03 | |
| *** brinzhang_ has joined #openstack-nova | 08:05 | |
| *** brinzhang has quit IRC | 08:08 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912 | 08:11 |
| openstackgerrit | Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765 | 08:11 |
| *** lpetrut has joined #openstack-nova | 08:13 | |
| *** brinzhang has joined #openstack-nova | 08:24 | |
| *** brinzhang_ has quit IRC | 08:27 | |
| *** CeeMac has joined #openstack-nova | 08:33 | |
| *** dtantsur|afk is now known as dtantsur | 08:34 | |
| *** dpawlik has joined #openstack-nova | 08:38 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** gbarros has quit IRC | 08:38 | |
| stephenfin | bauzas: Gooood morning. I have a another real easy patch for you here, if you want a stats boost for the morning https://review.opendev.org/#/c/677969/ | 08:39 |
| bauzas | stephenfin: heh, I took my vitamins this morning but sure | 08:39 |
| * bauzas refrains the idea to comment on "we don't distrubute eggs" about explaining how collective farms work | 08:41 | |
| *** ricolin_ is now known as ricolin | 08:41 | |
| *** brinzhang_ has joined #openstack-nova | 08:41 | |
| *** dpawlik has quit IRC | 08:43 | |
| *** brinzhang has quit IRC | 08:44 | |
| *** xek_ has joined #openstack-nova | 08:47 | |
| *** brinzhang has joined #openstack-nova | 08:57 | |
| *** brinzhang_ has quit IRC | 09:00 | |
| *** dpawlik has joined #openstack-nova | 09:13 | |
| *** dpawlik has quit IRC | 09:18 | |
| *** trident has quit IRC | 09:23 | |
| *** trident has joined #openstack-nova | 09:28 | |
| *** dpawlik has joined #openstack-nova | 09:30 | |
| *** brtknr_ has quit IRC | 09:31 | |
| *** brtknr has joined #openstack-nova | 09:32 | |
| *** ricolin has quit IRC | 09:41 | |
| *** brinzhang_ has joined #openstack-nova | 09:51 | |
| *** tbachman has joined #openstack-nova | 09:52 | |
| *** ociuhandu has joined #openstack-nova | 09:53 | |
| *** brinzhang has quit IRC | 09:54 | |
| *** tbachman has quit IRC | 10:13 | |
| *** cdent has joined #openstack-nova | 10:24 | |
| *** ociuhandu has quit IRC | 10:24 | |
| *** SonPham has joined #openstack-nova | 10:24 | |
| SonPham | hi | 10:24 |
| SonPham | how this code work? | 10:24 |
| SonPham | def reboot_instance(self, ctxt, instance, block_device_info, | 10:24 |
| SonPham | block_device_info=block_device_info, | 10:24 |
| *** SonPham has quit IRC | 10:25 | |
| *** mdbooth has quit IRC | 10:26 | |
| *** SonPham has joined #openstack-nova | 10:26 | |
| *** mdbooth has joined #openstack-nova | 10:28 | |
| SonPham | hi . i just traced nova-compute code | 10:28 |
| SonPham | from nova-compute (api.py) call to rpcapi.py | 10:29 |
| SonPham | but i can;t trace how it call to manager.py | 10:29 |
| *** ociuhandu has joined #openstack-nova | 10:29 | |
| gibi | SonPham: ComputeManager.reboot_instance() is called via RPC from ComputeAPI.reboot_instance() | 10:32 |
| SonPham | gibi can i add more RPCapi? | 10:33 |
| SonPham | i'm finding docs about this | 10:33 |
| gibi | SonPham: there is some documentation here https://docs.openstack.org/nova/latest/reference/rpc.html | 10:34 |
| jkulik | Hi, what's the expected outcome if I create a server with imageRef and a boot-from-volume block_device_mapping_v2 entry in the same request? I know some code checks for instance.image_ref for bfv. But it looks like in this case image_ref is still set even though the bfv disk is kept. | 10:34 |
| gibi | SonPham: but this is even better from dansmith http://www.danplanet.com/blog/2015/10/05/upgrades-in-nova-rpc-apis/ | 10:35 |
| kashyap | gibi: I wouldn't normally randomly spam, but mind taking this no-risk (can explain) backport for Queens? -- https://review.opendev.org/#/c/668111/ | 10:36 |
| gibi | kashyap: I can read it but note that I don't have +2 on stable branches | 10:37 |
| kashyap | gibi: It already has +2, FWIW. I'd have asked Eric, as he ACKed the change before, but he's on PTO | 10:37 |
| kashyap | Aargh. Who is awak that can ACK it now? | 10:37 |
| kashyap | s/awak/awake/ | 10:37 |
| gibi | kashyap: https://review.opendev.org/#/admin/groups/540,members maybe bauzas can help | 10:39 |
| * kashyap clicks | 10:39 | |
| kashyap | Thank you, yeah | 10:40 |
| kashyap | bauzas: Mind having a look? It is largely a procedural ACK. It was discussed here a week or so ago to be safe: https://review.opendev.org/#/c/668111/ | 10:40 |
| *** maciejjozefczyk has quit IRC | 10:40 | |
| *** maciejjozefczyk has joined #openstack-nova | 10:41 | |
| SonPham | i have push a nova-specs rts file and tag nova core-reviewer but no want review it. what must i do | 10:46 |
| gibi | SonPham: be patient :) | 10:48 |
| SonPham | my boss not patient with me ;( | 10:51 |
| *** elod has quit IRC | 10:51 | |
| *** elod has joined #openstack-nova | 10:52 | |
| openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | 10:52 |
| *** ociuhandu has quit IRC | 10:53 | |
| *** mkrai_ has joined #openstack-nova | 10:55 | |
| gibi | SonPham: then you have to explain to your boss how the openstack upstream community works. | 10:55 |
| SonPham | (y) nice. good ideal | 10:56 |
| gibi | SonPham: you got questions from Eric in your spec https://review.opendev.org/#/c/686948/ | 10:57 |
| gibi | SonPham: so the next step would be to answer them | 10:58 |
| *** mkrai has quit IRC | 10:58 | |
| *** mkrai__ has joined #openstack-nova | 10:58 | |
| *** brinzhang has joined #openstack-nova | 10:59 | |
| SonPham | gibi yep . i uploaded new patch set | 11:00 |
| *** mkrai_ has quit IRC | 11:00 | |
| gibi | SonPham: cool Eric (efried) is on PTO (vacation) when he returns I suggest that you ping him telling him that you answered his questions in the spec reviw | 11:01 |
| gibi | review | 11:01 |
| *** brinzhang_ has quit IRC | 11:03 | |
| SonPham | gibi how to ping him? | 11:04 |
| *** mkrai__ has quit IRC | 11:04 | |
| cdent | blargh: launchpad is timing out on write for me | 11:04 |
| gibi | SonPham: his nick is efried (now efried_pto as he is on vacation) if you mention his nick his IRC client will notify him | 11:05 |
| openstackgerrit | Merged openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969 | 11:11 |
| *** udesale has quit IRC | 11:13 | |
| SonPham | gibi what is his nick's name in IRC chat? | 11:15 |
| gibi | SonPham: 'efried_pto' now, 'efried' when he is not on vacation | 11:15 |
| *** brinzhang has quit IRC | 11:15 | |
| *** brinzhang has joined #openstack-nova | 11:16 | |
| SonPham | ok thanks | 11:16 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | 11:25 |
| *** ociuhandu has joined #openstack-nova | 11:28 | |
| *** SonPham has quit IRC | 11:31 | |
| *** pcaruana has quit IRC | 11:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | 11:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | 11:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | 11:35 |
| sean-k-mooney | stephenfin: i think your topic is incorrect on https://review.opendev.org/#/c/687954/5 | 11:37 |
| stephenfin | Yes. Yes it is :D | 11:38 |
| stephenfin | fixed | 11:38 |
| sean-k-mooney | you need to fix the follow up patch too | 11:38 |
| *** elod has quit IRC | 11:38 | |
| sean-k-mooney | but cool | 11:38 |
| *** dave-mccowan has joined #openstack-nova | 11:39 | |
| *** elod has joined #openstack-nova | 11:39 | |
| bauzas | kashyap: /me clicks on the stable change | 11:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | 11:41 |
| bauzas | hah, queens backport | 11:41 |
| *** pcaruana has joined #openstack-nova | 11:41 | |
| bauzas | kashyap: FWIW, the queens branch will become on Extended Maintenance in around 3 weeks :) | 11:44 |
| bauzas | https://releases.openstack.org/ | 11:44 |
| bauzas | Queens Maintained 2018-02-28 Extended Maintenance estimated 2019-10-25 | 11:44 |
| openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:volume:Disallow AIO=native when no 'O_DIRECT' is available https://review.opendev.org/682772 | 11:47 |
| *** tbachman has joined #openstack-nova | 11:54 | |
| kashyap | bauzas: Yeah, I'm aware of that. And thank you! :-) | 11:55 |
| *** brinzhang_ has joined #openstack-nova | 12:01 | |
| *** brinzhang has quit IRC | 12:04 | |
| *** FlorianFa has joined #openstack-nova | 12:05 | |
| *** jroll has quit IRC | 12:14 | |
| *** jroll has joined #openstack-nova | 12:15 | |
| *** brinzhang has joined #openstack-nova | 12:20 | |
| *** brinzhang_ has quit IRC | 12:24 | |
| *** cdent has left #openstack-nova | 12:39 | |
| *** larainema has quit IRC | 12:44 | |
| *** bbowen has joined #openstack-nova | 12:48 | |
| alex_xu | stephenfin: gibi efried_pto, just try to kick off the work https://etherpad.openstack.org/p/nova-train-release-project-update | 12:49 |
| gibi | alex_xu: good initiative! I will check the etherpad out | 12:50 |
| alex_xu | gibi: thanks | 12:50 |
| *** ociuhandu has quit IRC | 12:53 | |
| *** ttsiouts has joined #openstack-nova | 12:55 | |
| *** Guest31368 has joined #openstack-nova | 12:58 | |
| *** Guest31368 is now known as redrobot_ | 13:00 | |
| *** redrobot_ is now known as redrobot | 13:01 | |
| *** liuyulong has joined #openstack-nova | 13:04 | |
| *** Guest69423 has quit IRC | 13:06 | |
| *** eharney has joined #openstack-nova | 13:10 | |
| *** CeeMac has quit IRC | 13:12 | |
| *** mriedem has joined #openstack-nova | 13:14 | |
| *** openstackstatus has quit IRC | 13:15 | |
| *** liuyulong has quit IRC | 13:16 | |
| *** slaweq_ has joined #openstack-nova | 13:20 | |
| *** slaweq has quit IRC | 13:23 | |
| *** nweinber has joined #openstack-nova | 13:24 | |
| *** BjoernT has joined #openstack-nova | 13:26 | |
| *** ociuhandu has joined #openstack-nova | 13:27 | |
| *** liuyulong has joined #openstack-nova | 13:28 | |
| *** tbachman has quit IRC | 13:30 | |
| *** bnemec has joined #openstack-nova | 13:31 | |
| *** ociuhandu has quit IRC | 13:32 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Updated Nova-Cyborg interaction spec. https://review.opendev.org/684151 | 13:32 |
| *** jawad_axd has quit IRC | 13:34 | |
| *** slaweq_ is now known as slaweq | 13:35 | |
| *** awalende has quit IRC | 13:36 | |
| *** awalende has joined #openstack-nova | 13:37 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | 13:38 |
| *** awalende has quit IRC | 13:41 | |
| *** lbragstad_ is now known as lbragstad | 13:44 | |
| *** brinzhang_ has joined #openstack-nova | 13:47 | |
| *** BjoernT_ has joined #openstack-nova | 13:47 | |
| *** BjoernT has quit IRC | 13:49 | |
| *** brinzhang has quit IRC | 13:50 | |
| *** gbarros has joined #openstack-nova | 13:57 | |
| *** brinzhang has joined #openstack-nova | 14:00 | |
| *** brinzhang has quit IRC | 14:01 | |
| *** brinzhang has joined #openstack-nova | 14:02 | |
| *** brinzhang_ has quit IRC | 14:03 | |
| *** beekneemech has joined #openstack-nova | 14:06 | |
| *** bnemec has quit IRC | 14:06 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/668111 | 14:06 |
| *** munimeha1 has joined #openstack-nova | 14:06 | |
| *** dpawlik has quit IRC | 14:07 | |
| dansmith | mriedem: https://review.opendev.org/#/c/633293 needs a rebase and compute rpc bump because of me... sorry :( | 14:09 |
| mriedem | just replied on that one and noticed | 14:09 |
| mriedem | don't worry, not my first rodeo chasing compute rpc version bumps on that series | 14:10 |
| mriedem | you also have to rebase your api change and address some stuff in it :) | 14:10 |
| mriedem | i misunderstood your question about the long rpc call | 14:11 |
| mriedem | thought you were asking why it was a call and not a cast | 14:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove compute compat checks for aborting queued live migrations https://review.opendev.org/688409 | 14:12 |
| dansmith | mriedem: no, I was asking why a long call and not a regular call | 14:12 |
| mriedem | yeah i realized | 14:13 |
| *** ricolin has joined #openstack-nova | 14:13 | |
| mriedem | i don't have a good answer except it's what i did in all the new compute methods in this series | 14:13 |
| dansmith | heh okay, like I said, I'm not sure there's a reason *not* to do it really, other than just signaling that some of them are expected to run *really* long | 14:13 |
| dansmith | well, and I guess there's a teensy bit of messaging overhead | 14:14 |
| bauzas | mriedem: just saw this morning that Queens will be on Extended Maintenance in 3 weeks, so maybe we should look at https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens ? | 14:14 |
| dansmith | mriedem: I guess I thought the point of the schema was so we didn't have to test for things that the schema would reject for us | 14:15 |
| dansmith | well, one of the points of the schema | 14:15 |
| mriedem | we still have to test that we defined the schema correctly | 14:15 |
| dansmith | isn't that like kinda like silly tests that are actually only testing that mock is working? | 14:15 |
| dansmith | okay | 14:15 |
| mriedem | and i'd say to prevent regressions in later microversions on the same api | 14:16 |
| dansmith | okay, that's fine it just seems inconsistent with what we do elsewhere, like we don't check that when you define an object field as int that a string will blow it up :) | 14:16 |
| mriedem | i've seen and i'm pretty used invalid schema before adding tests to validate it so it's a more complicated thing than type checking | 14:17 |
| mriedem | *pretty sure | 14:17 |
| dansmith | ah dammit, I really wanted 2.80 | 14:18 |
| dansmith | also, I haven't had to write one of these in a long time, but it really sucks to have to do so much work if you miss your microversion | 14:18 |
| mriedem | bauzas: join the party i guess, it's usually a party of 1 | 14:18 |
| dansmith | I wish we could do something better there | 14:19 |
| mriedem | i don't thinking the microversion stuff can be reasonably automated | 14:20 |
| mriedem | *think | 14:20 |
| mriedem | coffee hasn't kicked into my brain yet | 14:20 |
| *** priteau has joined #openstack-nova | 14:20 | |
| dansmith | well, it would take some changes in our workflow I think | 14:20 |
| dansmith | I know it's not trivial | 14:20 |
| *** efried_pto is now known as efried | 14:29 | |
| efried | o/ nova | 14:29 |
| efried | alex_xu, stephenfin, gibi: I copied the Denver proj update to a new google slide thingy. PM me whatever email address you have a google account for and I'll add you to editors. | 14:30 |
| dansmith | gmann: can you help me decipher mriedem's request here? or point me at what something new looks like that I can copy? https://review.opendev.org/#/c/687140/5/nova/tests/unit/test_policy.py@312 | 14:35 |
| *** tbachman has joined #openstack-nova | 14:37 | |
| gmann | dansmith: yeah, we can use the new naming standard for new policy. EX -https://github.com/openstack/nova/blob/master/nova/policies/server_topology.py#L19 | 14:39 |
| dansmith | gmann: oh meaning just s/os-// ? | 14:39 |
| *** dklyle has quit IRC | 14:40 | |
| mriedem | decipher :/ | 14:40 |
| mriedem | i said "compute:aggregates:images" or "compute:aggregates:images:cache" | 14:40 |
| *** dtantsur is now known as dtantsur|brb | 14:40 | |
| dansmith | okay, I dunno what I was thinking last week, but reading it this morning he *did* tell me what to type | 14:40 |
| *** dklyle has joined #openstack-nova | 14:40 | |
| gmann | "compute:aggregates:images:cache" seems perfect | 14:40 |
| dansmith | mriedem: yeah I dunno, sorry I read that a couple times last week and it seemed like you were waffling on what you thought it should be and my eyes glazed over | 14:41 |
| mriedem | i was only waffling on making it specific to the cache action for future actions like purge | 14:41 |
| dansmith | I probably didn't see that the os- was removed, so it looked like what I had and I assumed I was missing something bigger | 14:42 |
| bauzas | mriedem: sure, will do | 14:42 |
| frickler | mriedem: did you see the thing I noticed last week? I'm assuming you might like that one, too ;) https://bugs.launchpad.net/tempest/+bug/1847759 | 14:42 |
| openstack | Launchpad bug 1847759 in tempest "reboot_server_hard can trigger corrupted file system" [Undecided,New] | 14:42 |
| dansmith | having one operation in aggregates be different from the rest seems unhelpful to admins, but I'm more than happy to just do whatever as I don't know anything about this stuff | 14:42 |
| mriedem | dansmith: i believe gmann has an approved blueprint to re-write all of those policy rules so it's just less work when he does | 14:43 |
| dansmith | ack | 14:43 |
| mriedem | frickler: i didn't | 14:43 |
| gmann | naming change for existing policy we dropped from policy improvement spec but for new one we can follow the new naming standard | 14:44 |
| gmann | at least not part of scope+new read-only defaults spec | 14:44 |
| mriedem | frickler: i've definitely seen this in the gate jobs that have ssh failures "cp: write error: No space left on device" | 14:45 |
| mriedem | frickler: http://status.openstack.org/elastic-recheck/#1808010 | 14:45 |
| *** ociuhandu has joined #openstack-nova | 14:47 | |
| frickler | mriedem: yes, the "no space left" is pretty generic, though, this one seems directly tied to hard reboots and the resulting corruption causing kernel panics | 14:47 |
| gmann | but yes, i wanted to change all old name but that is something needs to be discussed if worth to do or not from operator perspective. this will be separate spec | 14:47 |
| mriedem | dansmith: so we haven't done this for train yet - https://review.opendev.org/#/c/642599/ - does that need to be in train? | 14:48 |
| mriedem | or is ok for just ussuri? | 14:48 |
| mriedem | *is it | 14:48 |
| frickler | mriedem: so I'd say it is not a duplicate, but a specific subset of it, tied to a single test scenario | 14:49 |
| mriedem | gmann: renaming all of the old policy rules seems like a ton of churn for not much gain | 14:49 |
| mriedem | frickler: ack | 14:49 |
| dansmith | mriedem: it'd be nice for it to be in train eventually in case anyone sets their train level to train in an attempt to bump to current | 14:50 |
| *** brault has quit IRC | 14:50 | |
| dansmith | mriedem: really they should unpin or use auto, but you can imagine setting train to train meaning current making sense to people | 14:50 |
| mriedem | https://wiki.openstack.org/wiki/Nova/ReleaseChecklist says "Ideally add the RPC version alias just before opening the next release" | 14:50 |
| mriedem | i noticed that the rocky one was added in stein https://review.opendev.org/#/c/589972/ | 14:50 |
| dansmith | mriedem: right, that wiki link means like "in rc2 when we know we're not going to be adding anything else to the rpc api" | 14:51 |
| gmann | mriedem: true. initially i added name change as part of other policy changes but then we dropped that as it was changing every policies. i agree that doing it separately is not so much gain. | 14:51 |
| dansmith | mriedem: I think after auto came on the scene we got a little lax about that | 14:51 |
| dansmith | mriedem: and certainly people using a numbered version that has nothing to do with "train", that word means not very much to them | 14:52 |
| openstackgerrit | Nicolas Belouin proposed openstack/nova master: Add support for Xen PVH VM Mode in libvirt driver https://review.opendev.org/687827 | 14:52 |
| *** liuyulong has quit IRC | 14:54 | |
| mriedem | ok i'd push the patch but i'm rebasing this cross-cell series which will take awhile, | 14:54 |
| mriedem | if someone else wants to push it i'd +2 | 14:54 |
| dansmith | ack I can do it | 14:56 |
| dansmith | waiting for that conductor patch to land before rebasing mine | 14:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Update compute rpc version alias for train https://review.opendev.org/688418 | 14:58 |
| dansmith | eff, conductor patch failed, might as well rebase now I guess | 14:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor rebuild_instance https://review.opendev.org/688419 | 15:00 |
| dansmith | hmm, I don't see that 2.80 patch in the queue | 15:00 |
| *** beekneemech is now known as bnemec | 15:01 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | 15:01 |
| mriedem | it's #3 in the gate but the #1 spot just failed | 15:02 |
| mriedem | which was yours | 15:02 |
| efried | alex_xu, stephenfin, gibi: I updated the slides to have no Denver info in them (I think) and filled out a few easy ones including the microversion table. | 15:02 |
| stephenfin | mriedem: It's low priority (because 3rd party CI, at a minimum), but I'm going to need your help on the remove python2 patch at some point. I haven't a clue how to tell the two remaining legacy jobs to use python3 | 15:04 |
| *** TxGirlGeek has joined #openstack-nova | 15:04 | |
| *** tbachman has quit IRC | 15:04 | |
| mriedem | devstack jobs? | 15:04 |
| mriedem | https://review.opendev.org/#/c/649097/ | 15:05 |
| mriedem | depends-on that? | 15:05 |
| *** maciejjozefczyk has quit IRC | 15:05 | |
| *** ivve has quit IRC | 15:05 | |
| mriedem | i'll be annoyed if we drop py2 and have to define USE_PYTHON3=True everywhere | 15:05 |
| efried | mriedem: I haven't been following https://blueprints.launchpad.net/nova/+spec/add-user-id-field-to-the-migrations-table -- see patches +A this morning, is that the last of it? Can we mark complete (when merged)? | 15:09 |
| gmann | stephenfin: mriedem or you can use d-g var for legacy if not writing directly on localrc - DEVSTACK_GATE_USE_PYTHON3. But moving the devstack default to py3 and keep py2 setting in devstack on demand if anyone needed is something we should do first. I will review mriedem patch (not sure it does the same). | 15:11 |
| *** udesale has joined #openstack-nova | 15:12 | |
| dansmith | mriedem: yeah it wasn't showing up on dash for me at the time, but is now.. hadn't run anything so must've just been queued or something | 15:14 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 15:14 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 15:14 |
| dansmith | mriedem: conductor patch was just rebased to kick it out of the gate right away and get in line behind the 2.80 one ^ | 15:15 |
| mriedem | efried: no, there is still a novaclient change | 15:15 |
| gmann | stephenfin: mriedem FYI. fully dropping py2 from devstack or other common tooling/lib/oslo etc will be the last once all projects drop py2. We discussed the plan in TC for that and i will send the same on ML also, further and final plan/discussion will be on 24th TC office hour. | 15:15 |
| efried | mriedem: ack thx | 15:15 |
| mriedem | gmann: can't change the default on DEVSTACK_GATE_USE_PYTHON3 in d-g since it's branchless, unless we add branch logic in d-g for that like we did for using neutron by default back in i think newton or ocata | 15:16 |
| mriedem | this https://github.com/openstack/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L199 | 15:16 |
| *** ttx has quit IRC | 15:18 | |
| gmann | mriedem: yeah, legacy jobs and d-g need branch handling. | 15:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | 15:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents https://review.opendev.org/688425 | 15:18 |
| mriedem | one question is going to be grenade, since if grenade train side starts with py2 and upgrades to ussuri and starts using py3 packages, but https://review.opendev.org/#/c/649097/ should have hit that | 15:19 |
| dansmith | mriedem: is that what we'll do? or just go py3-py3 on both sides? | 15:19 |
| dansmith | I feel like staying on py3 on both sides is more in line with what we've done before with ubuntu upgrades, but not very realistic of couse | 15:19 |
| mriedem | since https://review.opendev.org/#/c/649097/ isn't doing anything else i expect grenade starts with py2 and the new side is py3 | 15:20 |
| mriedem | yeah it's definitely not realisitc, | 15:20 |
| mriedem | *realistic | 15:20 |
| mriedem | we - or someone that cares enough, like a distro - should make sure that people can upgrade from py2 in train to py3 in ussuri | 15:20 |
| mriedem | this came up a long time ago of course when the tc was talking about py2 deprecation and the only thing i remember really coming up was maybe some oslo libraries, like messaging, maybe having some compat issues | 15:21 |
| dansmith | mriedem: why is that patch causing a switch? | 15:21 |
| gmann | that should be tested as past of py2.7 jobs + py3 testing on train | 15:21 |
| mriedem | dansmith: because the old side of grenade in that run would run with py2 by default - since it's running from stable/n-1 | 15:21 |
| dansmith | mriedem: oh you mean the grenade testing of that patch in isolation, not once that patch is merged? | 15:21 |
| gmann | mean both version testing make sure train code can run on both py version so does upgrade is no issue | 15:21 |
| mriedem | dansmith: both | 15:22 |
| mriedem | gmann: not really | 15:22 |
| mriedem | say you have multi-node grenade where one compute is left at n-1 (train), | 15:22 |
| gmann | mriedem: but we will keep only grenade-py3 in ussuri which will be py3->py3 | 15:22 |
| mriedem | i would expect that job to start with py2, upgrade controller services and one compute to py3 ussuri and leave the n-1 compute at py2 | 15:23 |
| mriedem | and everything, like rpc, should continue to work | 15:23 |
| dansmith | mriedem: oh, devstack has branched, d-g does not I see, yeah | 15:23 |
| mriedem | yup | 15:23 |
| mriedem | gmann: if we don't have something like what i described above with multinode grenade we're not really testing upgrades from py2 to py3 | 15:23 |
| mriedem | e.g. what happens if a py3 conductor sends serialized json rpc to a py2 compute? | 15:24 |
| gmann | how that will be different than testing compute node for both version in separate jobs | 15:24 |
| gmann | ohk | 15:24 |
| dansmith | mriedem: one *could* argue that we don't care to test that sort of thing | 15:25 |
| mriedem | sure | 15:25 |
| mriedem | this isn't going to be my fight in ussuri | 15:25 |
| dansmith | mriedem: as you say, leave it to thedistros, but not specifically test or care about a platform change related problem | 15:25 |
| mriedem | if it blows up i'll laugh | 15:25 |
| gmann | this came up in denver PTG (previous one) also | 15:25 |
| mriedem | gmann: lots of things come up | 15:26 |
| mriedem | idk if anyone (the tc?) documented test plans for this | 15:26 |
| mriedem | or statements about testing this kind of upgrade | 15:26 |
| *** xek_ has quit IRC | 15:26 | |
| mriedem | if there was previous agreement from the tc and/or qa or whatever that we as a community don't care about testing that scenario, then fine | 15:26 |
| gmann | http://lists.openstack.org/pipermail/openstack-dev/2018-September/134592.html | 15:27 |
| mriedem | yeah that's the thread i was thinking about when i said this came up earlier | 15:27 |
| *** ttx has joined #openstack-nova | 15:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | 15:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | 15:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents https://review.opendev.org/688425 | 15:30 |
| gmann | mriedem: i think there was agreement 'community don't care ' but documented anywhere | 15:30 |
| mriedem | that's what doug seems to be saying http://lists.openstack.org/pipermail/openstack-dev/2018-September/134655.html | 15:31 |
| mriedem | so *shrug* | 15:31 |
| gmann | * not documented anywhere | 15:31 |
| *** elod has quit IRC | 15:31 | |
| gmann | I think we can add that in TC doc/resolution. i will add that part as part of 24th TC office hour discussion | 15:33 |
| *** awalende has joined #openstack-nova | 15:37 | |
| *** elod has joined #openstack-nova | 15:42 | |
| *** damien_r has quit IRC | 15:42 | |
| *** awalende has quit IRC | 15:42 | |
| *** ttsiouts has quit IRC | 15:46 | |
| *** ttsiouts has joined #openstack-nova | 15:46 | |
| *** ccamacho has quit IRC | 15:47 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: single pass instance info fetch in host manager https://review.opendev.org/623558 | 15:48 |
| *** ttsiouts has quit IRC | 15:51 | |
| melwitt | mriedem: I thought you might be interested in this, I wrote a regression test for the "run online_data_migrations twice fails" in the post test hook and a different fix on top https://review.opendev.org/688205 | 15:58 |
| mriedem | that would get around the mysql in functional test thing yeah | 15:58 |
| mriedem | get your power back? | 15:59 |
| melwitt | yeah, restored friday evening | 16:03 |
| *** tbachman has joined #openstack-nova | 16:03 | |
| *** openstackstatus has joined #openstack-nova | 16:03 | |
| *** ChanServ sets mode: +v openstackstatus | 16:03 | |
| melwitt | nice to have internet again | 16:03 |
| mriedem | heh, i bet | 16:03 |
| melwitt | and yeah, I couldn't find another way to exercise the bug and explained briefly why in the commit message. lmk if you think the explanation could use more info, or if there are alternatives that I missed | 16:06 |
| *** mlavalle has joined #openstack-nova | 16:06 | |
| *** rpittau is now known as rpittau|afk | 16:06 | |
| *** ociuhandu_ has joined #openstack-nova | 16:07 | |
| openstackgerrit | Merged openstack/nova master: Avoid using image with kernel in BDM large request func test https://review.opendev.org/688132 | 16:07 |
| *** dtantsur|brb is now known as dtantsur | 16:08 | |
| efried | stephenfin: Does https://review.opendev.org/#/c/688249/ look right to you? | 16:08 |
| stephenfin | sure does | 16:10 |
| *** ociuhandu has quit IRC | 16:10 | |
| efried | stephenfin: cool, I've got a few similar ones... | 16:11 |
| efried | thanks | 16:11 |
| melwitt | zzzeek: I would appreciate your review on this fix I proposed related to the questions I asked you on friday https://review.opendev.org/688206 | 16:13 |
| zzzeek | melwitt: yah, saw the link, will look now | 16:13 |
| melwitt | (and thanks again for helping me out with that) | 16:13 |
| *** mkrai_ has joined #openstack-nova | 16:13 | |
| *** ociuhandu_ has quit IRC | 16:14 | |
| efried | https://review.opendev.org/#/c/688250/ https://review.opendev.org/#/c/688235/ https://review.opendev.org/#/c/688087/ if you care stephenfin | 16:15 |
| *** cdent has joined #openstack-nova | 16:15 | |
| *** mkrai_ has quit IRC | 16:15 | |
| cdent | mriedem: my to do list has just reminded me to prompt folk about https://review.opendev.org/#/c/623558/ which is jay's patch to improve instance info fetch in the host manager. A while back I added some unit tests and did the tweaks that eric requested | 16:17 |
| openstackgerrit | Merged openstack/os-resource-classes master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/688249 | 16:18 |
| *** igordc has joined #openstack-nova | 16:21 | |
| *** dave-mccowan has quit IRC | 16:23 | |
| zzzeek | melwitt: before I look silly on the review because I'm missing something, do i read correctly that security_group_ensure_default is called twice inside of instance_create() ? | 16:24 |
| melwitt | zzzeek: that is correct. the first time, it intends to create it if it doesn't exist, the second time, it's really only doing it to read it back (was my conclusion) | 16:25 |
| zzzeek | melwitt: what condition would casue the return value to have changed in the intervening 15 or so lines of code? | 16:25 |
| melwitt | are you thinking another way would be to just use the returned object from the first time, later on? | 16:25 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Feature Liaison' spec process https://review.opendev.org/685857 | 16:25 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add spec for vm scoped sriov numa affinity https://review.opendev.org/683174 | 16:25 |
| efried | bauzas: ^ | 16:26 |
| zzzeek | melwitt: beacsue i dont know the concepts being worked with here, from what im seeing i dont immediately see why a. the top call should use the context, not independent transaction and b. what's wrong with default_gruop assigned at the top there | 16:26 |
| *** mkrai_ has joined #openstack-nova | 16:26 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | 16:26 |
| zzzeek | melwitt: then there's this _Get_Sec_group_models closure, which appears to be called only once, three lines later, no recursion, no passing it onwards, so why is it like that | 16:27 |
| gmann | melwitt: ^^^ re-proposed policy spec for ussuri | 16:27 |
| mriedem | cdent: without digging into the code change yet, i dropped a few comments in the commit message | 16:27 |
| mriedem | soft -1, i know it's an adopted patch | 16:27 |
| *** mkrai_ has quit IRC | 16:27 | |
| zzzeek | melwitt: it makes it look like this used to be very different and was refactored, but not all the way | 16:27 |
| cdent | mriedem: thanks | 16:27 |
| zzzeek | melwitt: if you agree thatim reading it right i can post my comments to this effect and folks can discuss | 16:27 |
| *** eharney has quit IRC | 16:28 | |
| melwitt | zzzeek: indeed, I could only assume similar because I'm not _that_ familiar with the method and definitely not familiar with the history. I'm not quite parsing your question a) though, why the top call should not use a separate transcation? did you mean why does it? | 16:28 |
| mriedem | note that we don't even need that call if using neutron https://review.opendev.org/#/c/653065/ | 16:29 |
| melwitt | zzzeek: and I agree that it looks partially refactored | 16:29 |
| zzzeek | melwitt: yes, got my negatives reversed. | 16:29 |
| zzzeek | melwitt: yes why use a separte trans there | 16:29 |
| zzzeek | melwitt: when the separate trans is used, that means that you either want the thing you're doing to modify the DB even if your method fails, or you want the thing you're doing to modify the DB while your mehtod is still running (like logging a slow operation), or, otehrwise you're trying to read some state that occurs within the middle of your ongoing, slow transaction | 16:30 |
| zzzeek | melwitt: this instance_create doesn't look like a slow function and it looks like the originator of the transaction that it commits. but i dont know | 16:31 |
| *** brault has joined #openstack-nova | 16:31 | |
| melwitt | zzzeek: ok, yeah, I went through thinking about it and I think what that comment is saying is that if we don't fork out a separate transaction, two racing server creates would try to insert the default group (the first time) and then one will succeed and the second would fail the COMMIT and then raise a DBError and fail the second server create [to the user]. using a separate transaction avoids that. now, I think an alternative way to | 16:31 |
| melwitt | have handled that would have been to try-except the DBError and call instance_create again in that case, but that's not what was done | 16:31 |
| zzzeek | melwitt: only if this function is overall slow-ish is there a race created that wouldn't also exist in the security_group_ensure_default() call itself | 16:32 |
| melwitt | *fail the COMMIT because of the unique constraint on project_id | 16:33 |
| zzzeek | like, those can race anyway right? | 16:33 |
| zzzeek | oh it has the retry on it | 16:33 |
| zzzeek | I see so its independent so that it can run and do a retry | 16:33 |
| zzzeek | OK but...it returns the value at least, so, you can use it at the top? the return value that is, and not call it a second time | 16:34 |
| *** udesale has quit IRC | 16:34 | |
| *** BjoernT_ is now known as BjoernT | 16:34 | |
| melwitt | yeah... thinking... on the surface I don't see why we couldn't. I was trying to think if there would be any implications for racing requests to instance_create, but there shouldn't be right.. | 16:36 |
| zzzeek | melwitt: I did a blame. this code is oldish | 16:37 |
| zzzeek | Pavel Kholkin in 2015 seems to be most of what I'm asking about, is that person still around | 16:37 |
| zzzeek | e.g. i can put up my qeustions and bring them onto a review if they still work for openstack | 16:38 |
| melwitt | mriedem: yeah, I remember that patch. I'm not opposed to working around it but I landed on this because I was genuinely puzzled about how dupe groups were being created when the logic is clearly "get or create". once I found the root cause of how two identical groups were being created, I went ahead and proposed a way to address that directly | 16:38 |
| zzzeek | haha "work for openstack" | 16:38 |
| zzzeek | melwitt: is a "security group" kind of an infrequently created concept and the race here is the kind of thing that happens only during some kind of installation? a "Security group" sounds like the kind of thing an administrator creates just once | 16:39 |
| melwitt | zzzeek: yeah, the code is old and as mriedem mentioned, it doesn't come into play (default group not ever used) if running with neutron, and neutron is the only networking we support as of... a few releases ago. this code is dealing with legacy nova-network security group record | 16:40 |
| melwitt | and I don't think Pavel Kholkin is still around working on openstack | 16:40 |
| zzzeek | melwitt: OK ill comment to these effects | 16:41 |
| *** xek_ has joined #openstack-nova | 16:42 | |
| *** xek_ has quit IRC | 16:42 | |
| melwitt | zzzeek: yeah, this code only creates a group once per project and the only time it becomes a problem is when it's done with an anonymous RequestContext which has project_id=NULL, which is happening because nova-manage is inserting a "dummy" instance record to support a marker/paging (don't ask, haha) and the unique constraint on project_id won't "work" for NULL values | 16:42 |
| *** xek has joined #openstack-nova | 16:44 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop using NoAuthMiddleware in tests https://review.opendev.org/687416 | 16:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | 16:45 |
| openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | 16:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 16:45 |
| efried | mriedem: ^ | 16:45 |
| *** mkrai_ has joined #openstack-nova | 16:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 16:48 |
| *** xek has quit IRC | 16:49 | |
| *** mkrai_ has quit IRC | 16:49 | |
| *** brinzhang has quit IRC | 16:50 | |
| *** brinzhang has joined #openstack-nova | 16:50 | |
| *** cdent has quit IRC | 16:51 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Feature Liaison' spec process https://review.opendev.org/685857 | 16:52 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add spec for vm scoped sriov numa affinity https://review.opendev.org/683174 | 16:52 |
| efried | bauzas, gmann: Had to respin to fix the title on gibi's s/Core/Feature/ Liaison section ^ | 16:52 |
| efried | (gibi thanks for adding that section preemptively :) | 16:53 |
| gmann | efried: +1 | 16:55 |
| efried | thanks gmann | 16:55 |
| *** derekh has quit IRC | 17:00 | |
| *** brinzhang_ has joined #openstack-nova | 17:00 | |
| *** munimeha1 has quit IRC | 17:02 | |
| *** brinzhang has quit IRC | 17:04 | |
| *** brinzhang has joined #openstack-nova | 17:05 | |
| *** brinzhang_ has quit IRC | 17:07 | |
| *** priteau has quit IRC | 17:11 | |
| *** BjoernT has quit IRC | 17:20 | |
| *** gmann is now known as gmann_afk | 17:25 | |
| *** tesseract has quit IRC | 17:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | 17:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | 17:26 |
| *** lpetrut has quit IRC | 17:28 | |
| *** ircuser-1 has joined #openstack-nova | 17:29 | |
| *** SonPham has joined #openstack-nova | 17:32 | |
| *** ricolin has quit IRC | 17:33 | |
| *** dtantsur is now known as dtantsur|afk | 17:36 | |
| *** maciejjozefczyk has joined #openstack-nova | 17:40 | |
| *** maciejjozefczyk has quit IRC | 17:49 | |
| openstackgerrit | Son Pham proposed openstack/nova-specs master: [WIP]Add blueprint snapshot-vms-with-state of-processes https://review.opendev.org/688522 | 17:51 |
| *** ivve has joined #openstack-nova | 17:53 | |
| openstackgerrit | Son Pham proposed openstack/nova-specs master: [WIP]Add blueprint snapshot-vms-with-state-of-processes https://review.opendev.org/686948 | 18:00 |
| *** brinzhang_ has joined #openstack-nova | 18:00 | |
| mriedem | bauzas: here are a set of queens changes that are good to go: https://review.opendev.org/#/c/676285/ https://review.opendev.org/#/c/675355/ https://review.opendev.org/#/c/682722/ https://review.opendev.org/680873 https://review.opendev.org/#/c/676500/ | 18:01 |
| *** brinzhang has quit IRC | 18:04 | |
| *** psachin has quit IRC | 18:05 | |
| *** SonPham has quit IRC | 18:10 | |
| dansmith | mriedem: I guess you didn't squash that fixup patch into your second patch when you rebased just now eh/ | 18:11 |
| *** gbarros has quit IRC | 18:11 | |
| *** gbarros has joined #openstack-nova | 18:12 | |
| dansmith | doesn't look like anything is running yet, so you could do that without losing much still I think | 18:12 |
| *** ralonsoh has quit IRC | 18:12 | |
| mriedem | https://review.opendev.org/#/c/678951/ you mean? | 18:12 |
| mriedem | at some point the thing it was FUP'ing ( https://review.opendev.org/#/c/627890/ ) had +2s on it a couple of times so i figured it was easier to not squash for those +2s to come back as a diff check | 18:13 |
| mriedem | i can if you want, i'm sure at this point a diff isn't trivial for gibi or stephenfin anymore anyway | 18:14 |
| dansmith | mriedem: yeah, but rebased on master now so there's a ton of churn in the patches from there now | 18:14 |
| dansmith | yeah | 18:14 |
| mriedem | none of this code is impacted much from master... | 18:14 |
| mriedem | well, this conductor task code | 18:14 |
| dansmith | I think it makes sense to just do it now | 18:14 |
| dansmith | oh, fair I guess. I just eye-diffed the bottom one and there was a lot of churn, but true about this one | 18:15 |
| mriedem | https://review.opendev.org/#/c/627890/53..59 it's not really trivial anyway | 18:15 |
| dansmith | anyway, whatever, the reason for doing it was a +2 on there in August, so seems safe to squash now but whatever | 18:15 |
| mriedem | yeah i will | 18:15 |
| mriedem | i'll take most any excuse to take a break from reviewing these queens backports... | 18:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.opendev.org/637070 | 18:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075 | 18:22 |
| dansmith | mriedem: so that filter patch that added 2.80, | 18:33 |
| dansmith | can I rebased that on master real quick since it needs a recheck anyway? | 18:33 |
| dansmith | otherwise I can't run tests easily because it doesn't have the rpc changes | 18:33 |
| dansmith | (which are in master already) | 18:33 |
| dansmith | rebasing it will only take ten minutes away from its queue time and it's behind your massive set anyway | 18:34 |
| mriedem | sure | 18:34 |
| mriedem | i'll re-approve | 18:34 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 18:35 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 18:35 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 18:35 |
| dansmith | done | 18:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix legacy issues in filter migrations by user_id/project_id https://review.opendev.org/682198 | 18:49 |
| *** factor has quit IRC | 18:50 | |
| *** gbarros has quit IRC | 18:53 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 18:54 |
| *** brinzhang has joined #openstack-nova | 19:00 | |
| *** brinzhang_ has quit IRC | 19:03 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove redundant call to get/create default security group https://review.opendev.org/688206 | 19:07 |
| *** bnemec has quit IRC | 19:22 | |
| *** Jeffrey4l has quit IRC | 19:23 | |
| *** brault has quit IRC | 19:24 | |
| *** Jeffrey4l has joined #openstack-nova | 19:24 | |
| dansmith | mriedem: question for you here: https://review.opendev.org/#/c/627890/60/nova/conductor/tasks/cross_cell_migrate.py@495 | 19:35 |
| dansmith | I didn't -1 in case you had a good reason or excuse, but figured it was worth pointing out if you hadn't thought about it | 19:36 |
| *** gbarros has joined #openstack-nova | 19:39 | |
| *** awalende has joined #openstack-nova | 19:42 | |
| *** awalende has quit IRC | 19:42 | |
| *** awalende has joined #openstack-nova | 19:42 | |
| *** gbarros has quit IRC | 19:42 | |
| *** awalende has quit IRC | 19:43 | |
| *** awalende has joined #openstack-nova | 19:43 | |
| mriedem | replied | 19:49 |
| mriedem | i've got some negative tests for things failing higher in the stack but not the scenario you're asking about | 19:49 |
| mriedem | it wouldn't be hard to add though | 19:49 |
| sean-k-mooney | mriedem: while that would be good i think its also i higher bar of testing then we have of similarly hairy failure modes. | 19:53 |
| sean-k-mooney | i have wondered in the past if we should have a delete --force and change delete to raise a error with --force when the vm is in task state that are potentially hard to clean up | 19:54 |
| sean-k-mooney | the issue with that is force deleteion is somehting i proably woudl want only my admin to do sicne they are the ones that woudl have to clean it up but as a use if i dont want a thing any more i should be able to say that | 19:55 |
| sean-k-mooney | espcially since im being billed for it in most cases | 19:55 |
| *** bnemec has joined #openstack-nova | 19:56 | |
| *** dpawlik has joined #openstack-nova | 19:56 | |
| sean-k-mooney | which reminds me we shoud get around to merging this so we dont leak vifs when we delete the vm while its spwaning https://review.opendev.org/#/c/663382/ | 20:00 |
| *** nweinber has quit IRC | 20:01 | |
| *** gmann_afk is now known as gmann | 20:01 | |
| *** gbarros has joined #openstack-nova | 20:05 | |
| sean-k-mooney | dansmith: melwitt could one of ye review ^ efried since you looked at that ages ago if you get a chance that would be cool too | 20:06 |
| efried | sean-k-mooney: are you +1 at this point? | 20:07 |
| sean-k-mooney | im rereviewing it now to determind what matt changed | 20:08 |
| sean-k-mooney | but it think it ws just the unit tests | 20:08 |
| mriedem | trying to catch up, was on a call | 20:08 |
| sean-k-mooney | but it was rebased so doing eye ball diff manually | 20:08 |
| mriedem | so (1) sean-k-mooney you're saying fault injection testing per dansmith's request is a higher bar of testing than we usually have, right? if so i agree but i also agree we should do that kind of testing while it's fresh in our minds so i don't have a problem adding it | 20:09 |
| mriedem | and (2) https://review.opendev.org/#/c/663382/ the last time i looked at that there were questions about how you can even get into that situation - did anyone (stephen?) sort that out? | 20:10 |
| sean-k-mooney | mriedem: yes im not saying we should not do it just we normally have not been that proactive | 20:10 |
| sean-k-mooney | i just notice that mdbooth updated it and so maybe that is a ping to early | 20:11 |
| dansmith | mriedem: sorry didn't see you replied.. fault injection would be a tempest-level test, I'm more looking for a test where you make the save() delete the instance and then fail like save would have to make sure you call all the cleanups you expect | 20:11 |
| mriedem | dansmith: maybe fault injection is a bad word but that's essentially what i proposed in my reply, stub resize_claim on the dest to (through the api) delete the instance from the source, which will trigger a failure in conductor and rollback the instance from the target cell db and the test would assert the various cleanups | 20:12 |
| sean-k-mooney | mriedem: it looks like nothing substantive has change so i need to parse all the comments again to confim if there was still any outstanding questions | 20:12 |
| dansmith | mriedem: ack | 20:12 |
| mriedem | sean-k-mooney: the reply from stephen is the last time i looked at it https://review.opendev.org/#/c/663382/4/nova/compute/manager.py@2506 | 20:14 |
| mriedem | "open to ideas here" | 20:14 |
| mriedem | if there is a way to recreate that issue, then i'd say write a functional test to recreate it and then lay the fix on top to show it's fixed | 20:14 |
| mriedem | which goes back to our historically bad level of testing which is why we have requests for fault injection and more complicated test scenarios in my cross-cell resize series above | 20:15 |
| mriedem | *bad level of testing for non-happy path scenarios | 20:15 |
| *** slaweq_ has joined #openstack-nova | 20:15 | |
| sean-k-mooney | mriedem: right | 20:15 |
| sean-k-mooney | which is exeactly why this bug laid dorment for so long | 20:16 |
| sean-k-mooney | i know how the issue happend in the customer env | 20:16 |
| sean-k-mooney | it would be hard to recreate but maybe not imposible | 20:16 |
| sean-k-mooney | ill try an think about how to recreate in a functionla test although mdbooth might also be looking into that | 20:18 |
| *** slaweq has quit IRC | 20:18 | |
| *** slaweq__ has joined #openstack-nova | 20:19 | |
| mriedem | note that it's not against the rules to have a functional test to recreate a bug which stubs something to inject the failure mode, | 20:20 |
| mriedem | we do that and still do it with functional tests to make sure the api / service / db interaction is what we'd expect | 20:20 |
| sean-k-mooney | ya i was wondign if i could use a spy or mock to inject the fault at the correct time | 20:21 |
| mriedem | e.g. the test would do something like start creating an instance, stub something to then call the api to delete the instance, and then go back to spawning which would fail and make sure we deallocaten networks properly | 20:21 |
| *** slaweq_ has quit IRC | 20:21 | |
| *** BjoernT has joined #openstack-nova | 20:24 | |
| *** pcaruana has quit IRC | 20:26 | |
| mriedem | sean-k-mooney: i left a comment to that effect on the review | 20:27 |
| *** benj has joined #openstack-nova | 20:28 | |
| *** benj is now known as Guest39910 | 20:28 | |
| sean-k-mooney | cool | 20:28 |
| mriedem | dansmith: so on https://review.opendev.org/#/c/627890/60/nova/conductor/tasks/cross_cell_migrate.py@495 - the functional tests start later in the series and in at least one or two cases gibi has asked a "what happens if x fails" question like you are here and i've added a test later in the series before he proceeds, | 20:29 |
| mriedem | are you ok with that here as well? | 20:29 |
| *** dpawlik has quit IRC | 20:31 | |
| *** BjoernT_ has joined #openstack-nova | 20:32 | |
| *** BjoernT has quit IRC | 20:32 | |
| dansmith | mriedem: with adding it later you mean? | 20:33 |
| mriedem | dansmith: no i mean i'd add it to the series and you'd hold off on +2ing that change until it's up and shows things are cool | 20:36 |
| dansmith | that's what I mean | 20:36 |
| dansmith | sure | 20:36 |
| mriedem | alright | 20:36 |
| mriedem | that'll be my tomrrow | 20:36 |
| mriedem | *tomorrow | 20:36 |
| * sean-k-mooney realises i forgot to press y when creating the github links to the site where the race happens and now they are all pointing at different code :( | 20:41 | |
| *** dpawlik has joined #openstack-nova | 20:42 | |
| sean-k-mooney | i think its https://github.com/openstack/nova/blob/stable/queens/nova/compute/manager.py#L2164-L2167 | 20:44 |
| sean-k-mooney | if we get the delete after we call _update_instance_after_spawn but before we call instance.save(expected_task_state=task_states.SPAWNING) | 20:46 |
| sean-k-mooney | we will raise the unexpected task state error. | 20:46 |
| *** dpawlik has quit IRC | 20:46 | |
| sean-k-mooney | i could simulated tat by mocking _update_instance_after_spawn to raise it but it would be a bit of a hack | 20:46 |
| sean-k-mooney | or maybe better | 20:47 |
| sean-k-mooney | have _update_instance_after_spawn inject the delete | 20:47 |
| sean-k-mooney | effefctly the race only happen in the interaval betwen reciving the libvirt event to notify that the spawn has completed and updating the db with that state | 20:49 |
| *** slaweq has joined #openstack-nova | 20:50 | |
| *** slaweq__ has quit IRC | 20:51 | |
| openstackgerrit | Merged openstack/nova master: Deprecate [api]auth_strategy and noauth2 https://review.opendev.org/687373 | 20:56 |
| openstackgerrit | Merged openstack/nova master: Leave brackets on Ceph IP addresses for libguestfs https://review.opendev.org/649405 | 20:56 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix wrong assertions in unit tests https://review.opendev.org/677390 | 20:57 |
| *** rcernin has joined #openstack-nova | 20:57 | |
| *** brinzhang_ has joined #openstack-nova | 21:00 | |
| *** brinzhang has quit IRC | 21:04 | |
| sean-k-mooney | no that is not the point were it happens... we handel the exception in that case. | 21:05 |
| sean-k-mooney | actully no it is the right spot we reraise teh expection to do the cleanup else where and that is where we dont catch it | 21:08 |
| mriedem | so uh | 21:26 |
| mriedem | let's just have a functional test that recreates the bug how about | 21:26 |
| mriedem | since this spaghetti code is hard to reason about otherwise (as you've just demonstrated) | 21:26 |
| sean-k-mooney | yes | 21:28 |
| sean-k-mooney | i commented on the bug how to do it i think | 21:28 |
| sean-k-mooney | mriedem: mdbooth siad he was going to add a funcitonl test to one of stephen pathces this morining | 21:28 |
| sean-k-mooney | if it was not this one ill look into adding it later in the week | 21:29 |
| *** awalende has quit IRC | 21:30 | |
| *** awalende_ has joined #openstack-nova | 21:30 | |
| *** awalende_ has quit IRC | 21:35 | |
| *** awalende has joined #openstack-nova | 21:36 | |
| *** awalende has quit IRC | 21:40 | |
| *** brault has joined #openstack-nova | 21:46 | |
| *** brinzhang has joined #openstack-nova | 21:48 | |
| *** brinzhang_ has quit IRC | 21:52 | |
| *** jistr has quit IRC | 21:52 | |
| *** vesper11- has joined #openstack-nova | 21:53 | |
| *** vesper11 has quit IRC | 21:53 | |
| *** bnemec has quit IRC | 21:55 | |
| *** rcernin has quit IRC | 21:59 | |
| *** jistr has joined #openstack-nova | 22:01 | |
| *** jistr has quit IRC | 22:02 | |
| *** jistr has joined #openstack-nova | 22:03 | |
| *** trident has quit IRC | 22:04 | |
| *** trident has joined #openstack-nova | 22:07 | |
| *** slaweq has quit IRC | 22:14 | |
| *** mlavalle has quit IRC | 22:16 | |
| *** TxGirlGeek has quit IRC | 22:31 | |
| *** TxGirlGeek has joined #openstack-nova | 22:33 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | 22:48 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 22:48 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522 | 22:49 |
| *** ivve has quit IRC | 22:49 | |
| *** slaweq has joined #openstack-nova | 22:52 | |
| *** slaweq has quit IRC | 22:56 | |
| *** rcernin has joined #openstack-nova | 23:07 | |
| *** artom has joined #openstack-nova | 23:11 | |
| *** tkajinam has joined #openstack-nova | 23:17 | |
| *** tkajinam_ has joined #openstack-nova | 23:17 | |
| *** tkajinam has quit IRC | 23:21 | |
| *** TxGirlGeek has quit IRC | 23:33 | |
| *** brault has quit IRC | 23:36 | |
| *** brault has joined #openstack-nova | 23:38 | |
| openstackgerrit | Merged openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 23:40 |
| *** mriedem has quit IRC | 23:48 | |
| openstackgerrit | sean mooney proposed openstack/nova master: block rebuild when numa toplogy changed https://review.opendev.org/687957 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!