| *** brinzhang has joined #openstack-nova | 00:04 | |
| *** sapd1_x has joined #openstack-nova | 00:07 | |
| *** brinzhang_ has quit IRC | 00:07 | |
| *** gyee has quit IRC | 00:08 | |
| *** igordc has quit IRC | 00:15 | |
| *** tetsuro has joined #openstack-nova | 00:18 | |
| *** tetsuro has quit IRC | 00:20 | |
| *** hongbin has joined #openstack-nova | 00:30 | |
| *** brinzhang_ has joined #openstack-nova | 00:31 | |
| *** brinzhang has quit IRC | 00:34 | |
| *** gbarros has quit IRC | 00:45 | |
| *** hongbin has quit IRC | 00:50 | |
| *** ricolin has joined #openstack-nova | 00:59 | |
| *** brinzhang has joined #openstack-nova | 01:03 | |
| *** brinzhang has quit IRC | 01:05 | |
| *** brinzhang has joined #openstack-nova | 01:05 | |
| *** brinzhang has joined #openstack-nova | 01:06 | |
| *** brinzhang_ has quit IRC | 01:06 | |
| *** brinzhang_ has joined #openstack-nova | 01:23 | |
| *** brinzhang has quit IRC | 01:27 | |
| *** ricolin has quit IRC | 01:34 | |
| *** ricolin has joined #openstack-nova | 01:35 | |
| *** markvoelker has quit IRC | 01:35 | |
| openstackgerrit | Jing Zhang proposed openstack/nova master: Force small pages accounting for CPU pinned VMs so that memory can be reserved on NUMA 0 for host processes. https://review.opendev.org/686079 | 01:36 |
|---|---|---|
| *** spsurya has joined #openstack-nova | 01:47 | |
| *** irclogbot_2 has quit IRC | 02:09 | |
| *** irclogbot_0 has joined #openstack-nova | 02:12 | |
| *** SonPham has joined #openstack-nova | 02:17 | |
| *** SonPham has quit IRC | 02:18 | |
| *** sapd1_x has quit IRC | 02:19 | |
| *** SonPham has joined #openstack-nova | 02:20 | |
| *** SonPham has joined #openstack-nova | 02:23 | |
| SonPham | Hi, I want to commit my little project | 02:24 |
| SonPham | It is a small module to snapshot VM and keep running process | 02:24 |
| SonPham | what workflow i need to do? | 02:25 |
| *** alex_xu has joined #openstack-nova | 02:28 | |
| *** tetsuro has joined #openstack-nova | 02:31 | |
| *** tetsuro has quit IRC | 02:33 | |
| *** brinzhang has joined #openstack-nova | 02:44 | |
| *** brinzhang_ has quit IRC | 02:47 | |
| *** markvoelker has joined #openstack-nova | 03:10 | |
| *** BjoernT has quit IRC | 03:16 | |
| *** Jeffrey4l has quit IRC | 03:38 | |
| *** Jeffrey4l has joined #openstack-nova | 03:40 | |
| *** brinzhang_ has joined #openstack-nova | 03:46 | |
| *** brinzhang has quit IRC | 03:50 | |
| *** sapd1_x has joined #openstack-nova | 04:20 | |
| *** henriqueof has quit IRC | 04:33 | |
| *** henriqueof1 has joined #openstack-nova | 04:33 | |
| *** mmethot_ has joined #openstack-nova | 04:36 | |
| *** jangutter_ has joined #openstack-nova | 04:36 | |
| *** ricolin_ has joined #openstack-nova | 04:36 | |
| *** takashin has joined #openstack-nova | 04:37 | |
| *** kaisers has quit IRC | 04:37 | |
| *** cgoncalves has quit IRC | 04:37 | |
| *** kaisers has joined #openstack-nova | 04:38 | |
| *** jangutter has quit IRC | 04:38 | |
| *** bbobrov has quit IRC | 04:38 | |
| *** bbobrov has joined #openstack-nova | 04:40 | |
| *** ricolin has quit IRC | 04:40 | |
| *** sean-k-mooney has quit IRC | 04:40 | |
| *** mmethot has quit IRC | 04:40 | |
| *** eandersson has quit IRC | 04:40 | |
| SonPham | Hi, I want to commit my little project | 04:40 |
| *** dasp has quit IRC | 04:40 | |
| *** sean-k-mooney has joined #openstack-nova | 04:40 | |
| *** jamesdenton has quit IRC | 04:41 | |
| *** jamesdenton has joined #openstack-nova | 04:44 | |
| *** cgoncalves has joined #openstack-nova | 04:46 | |
| *** pcaruana has joined #openstack-nova | 04:52 | |
| *** Luzi has joined #openstack-nova | 05:21 | |
| *** sapd1_x has quit IRC | 05:34 | |
| *** dpawlik has joined #openstack-nova | 05:36 | |
| *** icarusfactor has joined #openstack-nova | 05:39 | |
| *** factor has quit IRC | 05:39 | |
| *** mkrai has joined #openstack-nova | 05:57 | |
| *** rcernin_ has joined #openstack-nova | 05:59 | |
| *** rcernin has quit IRC | 06:01 | |
| *** dpawlik has quit IRC | 06:06 | |
| *** ileixe_ has joined #openstack-nova | 06:11 | |
| *** dpawlik has joined #openstack-nova | 06:11 | |
| *** ileixe_ is now known as ileixe | 06:12 | |
| *** avolkov has joined #openstack-nova | 06:29 | |
| *** brinzhang_ has quit IRC | 06:32 | |
| *** brinzhang_ has joined #openstack-nova | 06:32 | |
| *** luksky has joined #openstack-nova | 06:35 | |
| *** ttsiouts has joined #openstack-nova | 06:39 | |
| *** dasp has joined #openstack-nova | 06:40 | |
| *** icarusfactor has quit IRC | 06:41 | |
| *** rcernin_ has quit IRC | 06:45 | |
| *** rcernin has joined #openstack-nova | 06:45 | |
| gibi | sean-k-mooney: neutron creates child RPs under the compute RP and reports bandwidth inventory on the child RPs only. Also the resource allocation is done by nova as part of the instance (and migration) allocation. So the zun and the neturon case is pretty different | 06:47 |
| SonPham | Hi, I want to commit my little project | 06:48 |
| *** xek has joined #openstack-nova | 06:55 | |
| *** tesseract has joined #openstack-nova | 06:57 | |
| *** mkrai has quit IRC | 06:57 | |
| *** damien_r has joined #openstack-nova | 07:02 | |
| gibi | SonPham: hi! most of the core developers are active after 12:00 UTC. The contribution process is documented here https://docs.openstack.org/nova/latest/contributor/index.html | 07:02 |
| *** brinzhang has joined #openstack-nova | 07:03 | |
| *** jaosorior has joined #openstack-nova | 07:03 | |
| *** rcernin has quit IRC | 07:04 | |
| *** brinzhang_ has quit IRC | 07:05 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:06 | |
| gibi | SonPham: regarding your feature. How does it different from the existing snapshot feature of OpenStack? | 07:09 |
| *** slaweq has joined #openstack-nova | 07:10 | |
| SonPham | gibi i'm using libvirt for snapshot | 07:10 |
| SonPham | it can keep running process | 07:11 |
| SonPham | but volume image type must be change from RAW to QCOW2 | 07:11 |
| *** awalende has joined #openstack-nova | 07:13 | |
| gibi | SonPham: I think nova can also do live snapshot | 07:15 |
| gibi | SonPham: the relevant codepath starts around here https://github.com/openstack/nova/blob/bf37bec80baa527ac013dfaa7480ef2761ed2cb9/nova/virt/libvirt/driver.py#L2267 | 07:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/685534 | 07:19 |
| *** ttsiouts has quit IRC | 07:26 | |
| *** ttsiouts has joined #openstack-nova | 07:26 | |
| SonPham | gibi i think openstakc snapshot is an image of disk. not keep process | 07:30 |
| *** ttsiouts has quit IRC | 07:31 | |
| gibi | SonPham: yes, it creates a copy of the disk while the libvirt domain is still running | 07:31 |
| gibi | SonPham: you what I mean is that the existing snapshot code does not require to shutdown the domain | 07:33 |
| gibi | s/you// | 07:33 |
| gibi | SonPham: do you mean that in your case the snapshot itself stores the running state of the whole domain? | 07:34 |
| SonPham | gibi my project create snapshot when domain running. but when you revert snapshot. all of process still keep lock like you snapshot | 07:35 |
| SonPham | gibi yep . stores the running state of the whole domain | 07:37 |
| gibi | SonPham: I see | 07:37 |
| gibi | SonPham: I suggest to try to propose a feature specification | 07:37 |
| gibi | SonPham: the nova spec repo is here https://opendev.org/openstack/nova-specs | 07:37 |
| *** ralonsoh has joined #openstack-nova | 07:38 | |
| *** slaweq has quit IRC | 07:38 | |
| gibi | SonPham: you basically need to fill the spec template https://opendev.org/openstack/nova-specs/src/branch/master/specs/ussuri-template.rst | 07:38 |
| gibi | SonPham: and open a blueprint pointing to the spec https://blueprints.launchpad.net/nova | 07:39 |
| *** tetsuro has joined #openstack-nova | 07:41 | |
| *** tetsuro has quit IRC | 07:46 | |
| *** ivve has joined #openstack-nova | 07:56 | |
| *** ttsiouts has joined #openstack-nova | 07:56 | |
| *** slaweq has joined #openstack-nova | 07:57 | |
| *** rpittau|afk is now known as rpittau | 07:57 | |
| *** takashin has left #openstack-nova | 08:00 | |
| brinzhang | gibi: I saw the code as you, and there is an configuration https://docs.openstack.org/nova/stein/configuration/config.html#workarounds.disable_libvirt_livesnapshot | 08:03 |
| *** tkajinam has quit IRC | 08:04 | |
| brinzhang | gibi: it seems that there is not has the API provide for user to do the live-snapshot,I think it's not support good enough(https://docs.openstack.org/nova/stein/configuration/config.html#workarounds.disable_libvirt_livesnapshot) | 08:05 |
| brinzhang | gibi: I didn't go deep into the logic of this piece :P | 08:06 |
| *** mkrai has joined #openstack-nova | 08:07 | |
| *** markvoelker has quit IRC | 08:09 | |
| *** ttsiouts has quit IRC | 08:12 | |
| *** ttsiouts has joined #openstack-nova | 08:12 | |
| *** brinzhang_ has joined #openstack-nova | 08:16 | |
| *** brinzhang_ has joined #openstack-nova | 08:17 | |
| *** ttsiouts has quit IRC | 08:17 | |
| *** brinzhang_ has quit IRC | 08:17 | |
| *** brinzhang_ has joined #openstack-nova | 08:17 | |
| *** ttsiouts has joined #openstack-nova | 08:18 | |
| *** brinzhang_ has quit IRC | 08:18 | |
| *** tssurya_ has joined #openstack-nova | 08:19 | |
| *** brinzhang has quit IRC | 08:20 | |
| *** ileixe has quit IRC | 08:24 | |
| *** lpetrut has joined #openstack-nova | 08:30 | |
| *** dpawlik has quit IRC | 08:31 | |
| *** ociuhandu has joined #openstack-nova | 08:32 | |
| *** ociuhandu has quit IRC | 08:32 | |
| *** ociuhandu has joined #openstack-nova | 08:33 | |
| *** ociuhandu has quit IRC | 08:34 | |
| *** ociuhandu has joined #openstack-nova | 08:35 | |
| *** jaosorior has quit IRC | 08:37 | |
| *** jawad_axd has joined #openstack-nova | 08:38 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** ricolin_ is now known as ricolin | 08:41 | |
| *** ileixe has joined #openstack-nova | 08:46 | |
| *** panda has quit IRC | 08:48 | |
| *** dpawlik has joined #openstack-nova | 08:49 | |
| *** panda has joined #openstack-nova | 08:49 | |
| *** tetsuro has joined #openstack-nova | 09:03 | |
| *** tetsuro has quit IRC | 09:08 | |
| *** mkrai_ has joined #openstack-nova | 09:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not print default dicts during heal_allocations https://review.opendev.org/686001 | 09:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879 | 09:18 |
| gibi | stephenfin: fixed your comments in ^^ | 09:18 |
| *** tssurya_ is now known as tssurya | 09:19 | |
| gibi | stephenfin: unfortunately we dont have jq in the environment | 09:20 |
| *** ab-a has quit IRC | 09:30 | |
| *** ab-a has joined #openstack-nova | 09:31 | |
| *** tetsuro has joined #openstack-nova | 09:39 | |
| *** tetsuro has quit IRC | 09:45 | |
| *** kaisers has quit IRC | 09:52 | |
| *** jaosorior has joined #openstack-nova | 09:52 | |
| *** kaisers has joined #openstack-nova | 09:53 | |
| *** ociuhandu has quit IRC | 10:02 | |
| *** ociuhandu has joined #openstack-nova | 10:03 | |
| *** sapd1_x has joined #openstack-nova | 10:05 | |
| *** ociuhandu has quit IRC | 10:08 | |
| *** markvoelker has joined #openstack-nova | 10:10 | |
| *** tetsuro has joined #openstack-nova | 10:13 | |
| *** sapd1_x has quit IRC | 10:14 | |
| *** markvoelker has quit IRC | 10:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949 | 10:17 |
| *** tetsuro has quit IRC | 10:18 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950 | 10:18 |
| *** mkrai_ has quit IRC | 10:20 | |
| *** mkrai has quit IRC | 10:20 | |
| *** rcernin has joined #openstack-nova | 10:24 | |
| *** ttsiouts has quit IRC | 10:32 | |
| *** ivve has quit IRC | 10:32 | |
| *** ttsiouts has joined #openstack-nova | 10:33 | |
| *** ttsiouts has quit IRC | 10:37 | |
| *** slaweq has quit IRC | 10:38 | |
| *** zbr|ruck is now known as zbr|lunch | 10:39 | |
| *** slaweq has joined #openstack-nova | 10:42 | |
| *** tetsuro has joined #openstack-nova | 10:48 | |
| *** SonPham has quit IRC | 10:49 | |
| *** slaweq has quit IRC | 10:51 | |
| *** tetsuro has quit IRC | 10:53 | |
| *** SonPham has joined #openstack-nova | 10:57 | |
| *** slaweq has joined #openstack-nova | 10:57 | |
| *** ociuhandu has joined #openstack-nova | 10:58 | |
| *** jaosorior has quit IRC | 11:02 | |
| *** dpawlik has quit IRC | 11:03 | |
| *** sapd1_x has joined #openstack-nova | 11:03 | |
| *** openstackstatus has quit IRC | 11:09 | |
| *** rnoriega- has quit IRC | 11:09 | |
| *** rchurch has quit IRC | 11:10 | |
| *** rchurch has joined #openstack-nova | 11:13 | |
| *** rnoriega_ has joined #openstack-nova | 11:13 | |
| *** ttsiouts has joined #openstack-nova | 11:14 | |
| *** dpawlik has joined #openstack-nova | 11:14 | |
| *** SonPham has quit IRC | 11:15 | |
| *** jaosorior has joined #openstack-nova | 11:28 | |
| *** rpittau is now known as rpittau|afk | 11:38 | |
| *** sapd1_x has quit IRC | 11:44 | |
| *** artom has joined #openstack-nova | 11:47 | |
| *** ivve has joined #openstack-nova | 11:56 | |
| *** gbarros has joined #openstack-nova | 12:16 | |
| *** derekh has quit IRC | 12:27 | |
| *** gbarros has quit IRC | 12:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326 | 12:38 |
| *** nweinber has joined #openstack-nova | 12:47 | |
| *** tbachman has quit IRC | 12:49 | |
| *** derekh has joined #openstack-nova | 12:59 | |
| *** gbarros has joined #openstack-nova | 13:00 | |
| *** ociuhandu has quit IRC | 13:06 | |
| *** ociuhandu has joined #openstack-nova | 13:07 | |
| *** mriedem has joined #openstack-nova | 13:08 | |
| *** jaosorior has quit IRC | 13:08 | |
| *** ociuhandu has quit IRC | 13:11 | |
| *** ivve has quit IRC | 13:12 | |
| *** luksky has quit IRC | 13:14 | |
| *** dpawlik has quit IRC | 13:20 | |
| *** jawad_axd has quit IRC | 13:27 | |
| *** jawad_axd has joined #openstack-nova | 13:28 | |
| *** jawad_ax_ has joined #openstack-nova | 13:30 | |
| *** ociuhandu has joined #openstack-nova | 13:31 | |
| *** jawad_axd has quit IRC | 13:33 | |
| *** jawad_ax_ has quit IRC | 13:34 | |
| *** Luzi has quit IRC | 13:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Improve spy CM's data passing https://review.opendev.org/686167 | 13:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: lxc: make use of filter python3 compatible https://review.opendev.org/676500 | 13:41 |
| *** luksky has joined #openstack-nova | 13:42 | |
| *** tbachman has joined #openstack-nova | 13:45 | |
| *** zbr|lunch is now known as zbr|ruck | 13:48 | |
| efried | gibi: I'm having way too much fun with spy | 13:49 |
| *** henriqueof1 has quit IRC | 13:51 | |
| *** zul has joined #openstack-nova | 13:51 | |
| *** mkrai_ has joined #openstack-nova | 13:52 | |
| *** mkrai has joined #openstack-nova | 13:53 | |
| *** markvoelker has joined #openstack-nova | 13:53 | |
| *** jaosorior has joined #openstack-nova | 13:54 | |
| gibi | efried: I know.I feel the same thing :) | 13:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Improve spy CM's data passing https://review.opendev.org/686167 | 13:55 |
| gibi | efried: I try to answered your concerns about accessing _spy in the body of _spy() | 13:56 |
| dansmith | efried: gibi: maybe I'm missing something, but why isn't this as easy as: https://pastebin.com/b0g9ZFHS ? | 13:56 |
| dansmith | that mock-wraps the original thing with just one line but leaves you to examine the regular mock attributes | 13:56 |
| mriedem | gibi: replied in https://review.opendev.org/#/c/686047/ | 13:56 |
| efried | dansmith: it allows you to examine the args, but it never runs the original foo() | 13:57 |
| gibi | dansmith: is some tests we need to run the original function | 13:57 |
| dansmith | efried: yes it does | 13:57 |
| dansmith | efried: run it | 13:57 |
| efried | oic | 13:57 |
| mriedem | note that mock.patch(wraps=...) does that as well | 13:57 |
| dansmith | gibi: that runs the original | 13:57 |
| dansmith | ah, didn't know about wraps | 13:58 |
| *** markvoelker has quit IRC | 13:58 | |
| gibi | dansmith: let me try that with a bound method | 13:58 |
| mriedem | wraps is kind of weird to use | 13:58 |
| mriedem | not documented very well | 13:58 |
| efried | What spy does is allow you to keep track of things per invocation of the wrapped method, which wraps= doesn't | 13:58 |
| *** awalende has quit IRC | 13:59 | |
| efried | also selectively change the behavior | 13:59 |
| efried | like "run normally the first time, raise the second time" | 13:59 |
| dansmith | I don't see how it's different from side_effect | 13:59 |
| gibi | dansmith: side_effect is not good for calling the original if the original is a bound method http://paste.openstack.org/show/780754/ | 14:04 |
| dansmith | gibi: that's because you're mocking the class not the object | 14:05 |
| dansmith | I think you're just using your spy in a different order | 14:05 |
| dansmith | if you mock.patch.object(a) I think you'll be fine | 14:05 |
| gibi | dansmith: but in the functional test when we mock we tend not to have easy access to the instantiated objects just the classes | 14:06 |
| dansmith | in that one scenario you mean, but not necessarily as a general rule | 14:06 |
| *** panda has quit IRC | 14:06 | |
| dansmith | efried's use of spy in the patch above that does not seem to be very clean to me, especially for a supposed functional test | 14:07 |
| gibi | dansmith: my goal is to want to get rid of (or contain) the scope magic and the original function handling in cases like https://github.com/openstack/nova/blob/bf37bec80baa527ac013dfaa7480ef2761ed2cb9/nova/tests/functional/regressions/test_bug_1843090.py#L100 | 14:07 |
| dansmith | but anyway, not saying it's not useful, it just seems like in a lot of cases, you could get away with base mock stuff instead of having to learn a new convention | 14:07 |
| efried | oh, yeah, in the vast majority of cases | 14:08 |
| *** panda has joined #openstack-nova | 14:08 | |
| gibi | spy is not a replacement for mock. There are cases where I think mock is hard to use to achive the same thing | 14:08 |
| gibi | like the funct test I linket above | 14:08 |
| dansmith | gibi: understand. using side_effect to provide a sequence of run,fail is more conventional than what either the old or new code in that patch is doing | 14:08 |
| dansmith | assuming you can hook at the right spot to mock the object itself | 14:09 |
| efried | dansmith: I don't think you can use side_effect to run,fail | 14:09 |
| dansmith | efried: of course you can | 14:09 |
| dansmith | efried: provide it a list and it will iterate on each call | 14:09 |
| efried | because when you pass an iterable to side_effect, it's return values, not callables. | 14:09 |
| dansmith | nope | 14:10 |
| dansmith | return_value behaves like that, side_effect does not | 14:10 |
| *** mriedem has quit IRC | 14:10 | |
| efried | side_effect=one_thing calls one_thing | 14:10 |
| efried | side_effect=[one, two] *returns* one followed by two | 14:10 |
| gibi | dansmith: btw, mocking f through the instance doesn't work either http://paste.openstack.org/show/780755/ | 14:10 |
| *** mriedem has joined #openstack-nova | 14:10 | |
| dansmith | efried: "If side_effect is an iterable then each call to the mock will return the next value from the iterable." | 14:10 |
| efried | ^ | 14:11 |
| *** mkrai has quit IRC | 14:11 | |
| *** mkrai_ has quit IRC | 14:11 | |
| dansmith | efried: https://pastebin.com/bLpt6Skz | 14:11 |
| dansmith | gibi: it's all about calling convention, it's tricky and magical, but you're not doing anything different other than the ordering | 14:12 |
| efried | dansmith: yup, that didn't print "Foo ran 1" | 14:12 |
| efried | try to get it to do that the first time, and raise the second | 14:13 |
| gibi | dansmith: tell me how can I call the original with side_effect if the original is a bound method because I failed to find a way | 14:13 |
| efried | gibi: you can't | 14:13 |
| dansmith | efried: it printed 1, my local env has a different foo | 14:13 |
| dansmith | efried: wait, what are you arguing? that it didn't run foo? I didn't ask it to | 14:14 |
| efried | I know. And you can't. | 14:14 |
| efried | that's what spy helps with | 14:14 |
| gibi | exaclty what efried is asking is what I'm after. having the original function is called while spying on the call | 14:14 |
| dansmith | ah, I see what you mean.. a lambda in the list will solve that | 14:15 |
| gibi | dansmith: no, the lambda would be returned, not called | 14:15 |
| efried | ^ | 14:15 |
| dansmith | gibi: having the original called is what side_effect=callable will do, but the list, fine fine, I see | 14:15 |
| gibi | dansmith: but I cannot do that^^ if the original is a bound method as mock does not pass proper arglist to the callable | 14:16 |
| dansmith | you guys seem to be describing a world where spy will make it easier to not write terrible tests like what efried is adding (and what he replaced), yet he's using spy to (if called once, then explode) | 14:16 |
| efried | what did I write? | 14:16 |
| dansmith | efried: this: https://review.opendev.org/#/c/685950/3/nova/tests/functional/regressions/test_bug_1843090.py | 14:17 |
| *** mkrai has joined #openstack-nova | 14:17 | |
| *** mkrai_ has joined #openstack-nova | 14:17 | |
| efried | gibi gets credit for those | 14:17 |
| * gibi takes credit for the original of that | 14:17 | |
| efried | I think | 14:17 |
| dansmith | oh sorry, I thought you were commenting on your own | 14:17 |
| dansmith | I should have provided a url instead of a name :) | 14:18 |
| gibi | dansmith: I want to make the test in test_bug_1843090.py better with spy. If there is other way to make it better then I'm open to suggestion | 14:18 |
| *** jaosorior has quit IRC | 14:18 | |
| dansmith | gibi: okay, but you're not in that change, right? you're still counting calls and failing once it's been called | 14:19 |
| dansmith | and doing gross stuff like mangling the original object to tell if you've been called twice | 14:19 |
| dansmith | so where is your call,fail bit you said was easy with spy? | 14:19 |
| gibi | dansmith: we need the logic like first call fails to trigger a re-schedule but the second succeds so that the re-schedule succeeds. | 14:20 |
| artom | Actually yeah | 14:20 |
| dansmith | fine, where is your fail,call ? :) | 14:20 |
| gibi | dansmith: is there a nicer way to code that? | 14:20 |
| artom | What we're doing in https://review.opendev.org/#/c/685950/3/nova/tests/functional/regressions/test_bug_1843090.py is exactly what we said we shouldn't do in https://review.opendev.org/#/c/685950/2/nova/tests/functional/compute/test_live_migration.py@23 | 14:20 |
| dansmith | gibi: well, for one thing you should keep track of your mock calls outside of the runtime objects you're handling | 14:21 |
| efried | dansmith: Checking the actual mock's call_count is hard because you have to define the method before you create the mock before you define the method, but you have to reference the mock from within the method. | 14:21 |
| dansmith | gibi: point being I'm not sure what spy is making nicer about that test because it seems like the same ickiness, but with a different calling convention | 14:21 |
| gibi | dansmith: it hides the scope magic efried is just described | 14:22 |
| gibi | dansmith: it automates the call to the original function | 14:22 |
| dansmith | efried: everywhere else we keep a list above the scope and chuck things into there inside the handler | 14:22 |
| dansmith | gibi: so it saves the one line of saving a reference to the original method? | 14:22 |
| gibi | dansmith: and it hides the outer scope list | 14:22 |
| dansmith | but replaces it with the terrible hack of modifying the runtime objects instead of keeping that fully within the test! | 14:23 |
| efried | and when there are multiple calls to the same method nested inside whatever's happening inside the context manager, it gives you a way to introspect them individually | 14:23 |
| gibi | dansmith: and it remembers that we have to use new= instead of side_effect if the mocked function is bound method | 14:23 |
| efried | with mock.patch: | 14:23 |
| efried | do_thing() | 14:23 |
| efried | do_thing calls foo() N times with different args or whatever | 14:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017 | 14:23 |
| openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 14:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 14:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during build reschedule https://review.opendev.org/686047 | 14:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during migrate reschedule https://review.opendev.org/686050 | 14:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update cells v2 up-call caveats doc https://review.opendev.org/686053 | 14:23 |
| efried | dansmith: I also suggested a way we don't have to do the | 14:24 |
| efried | spy.claim_calls_on_node = getattr(spy, 'claim_calls_on_node', []) | 14:24 |
| efried | thing, which puts creation of the tracker container back in the hands of the caller. | 14:24 |
| efried | same #LOC, just a little more scrutable | 14:25 |
| dansmith | efried: yes, initializing that "context" elsewhere would be a lot better | 14:25 |
| dansmith | anyway, it seems to do a lot for you and gibi, that's all that matters. it's something else I have to learn to comprehend the test, but... | 14:25 |
| efried | gibi: I can work that ^ up if you like, at least for demonstration purposes. | 14:26 |
| efried | maybe it'll read more intuitively to dansmith | 14:26 |
| *** BjoernT has joined #openstack-nova | 14:26 | |
| *** markvoelker has joined #openstack-nova | 14:26 | |
| dansmith | no, not more intuitively, it'll just make the handler less gross | 14:26 |
| *** openstackstatus has joined #openstack-nova | 14:28 | |
| *** ChanServ sets mode: +v openstackstatus | 14:28 | |
| mriedem | i found out yesterday that we patch mock.patch globally using something in oslotest for fixing the autospec'ing stuff - what claudiub worked on a long time ago. i saw those changes merge but didn't realize we were patching the mock library. | 14:28 |
| mriedem | i would not be surprised when we go to a new version and that blows up in our faces | 14:28 |
| openstackgerrit | Merged openstack/nova stable/train: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686066 | 14:29 |
| *** awalende has joined #openstack-nova | 14:30 | |
| *** rcernin has quit IRC | 14:30 | |
| gibi | efried, dansmith: fine. I'm out of steam. I think I get that we cannot remove the full uglyness of these tests. I think we can move and contain some the uglyness. But I also get that it makes the test less explicit. so meh | 14:31 |
| dansmith | gibi: I appreciate your efforts to improve :) | 14:32 |
| mriedem | gibi: if it makes you feel better, i was able to use mock.patch context manager in that migrate reschedule functional test :) | 14:32 |
| gibi | mriedem: I haven't tried mock.patch(wraps=) recently. so it might work | 14:32 |
| mriedem | using wraps= is awkward in my experience | 14:32 |
| mriedem | side_effect is more straightforward, but maybe that's just b/c i have more experience with it | 14:33 |
| gibi | mriedem: and patching the mock library feels baaaad | 14:33 |
| mriedem | we'll find out about ^ but this is what we call https://github.com/openstack/oslotest/blob/master/oslotest/mock_fixture.py#L187 | 14:33 |
| gibi | dansmith: I guess I will go and fined another tech debt and work on that a bit :) | 14:34 |
| *** awalende has quit IRC | 14:34 | |
| gibi | s/fined/find/ | 14:34 |
| gibi | mriedem: that patching might even be relevant to my problem with side_effect and bound methods as it touches 'self' | 14:36 |
| mriedem | too much touching of self can lead to problems | 14:36 |
| mriedem | i've heard | 14:36 |
| mriedem | ... | 14:36 |
| gibi | ... | 14:36 |
| dansmith | mriedem: comment here: https://review.opendev.org/#/c/686017/3 | 14:38 |
| *** kaisers has quit IRC | 14:39 | |
| mriedem | i can probably keep a handle to the mock and assert it's called, but if you remove the mock the test fails so i'm not sure it's worthwhile | 14:39 |
| mriedem | actually as written i should confirm that statement, | 14:41 |
| mriedem | because it probably fails anyway since the stub always raises right not, not just on the first host | 14:41 |
| mriedem | *now | 14:41 |
| mriedem | dansmith: replied inline with options | 14:42 |
| dansmith | mriedem: that's why I'm asking.. just seems like since we can't see the actual failure in the fault, we should make sure it's hitting what we think it is | 14:42 |
| dansmith | mriedem: I'd rather the explicit assertCalled personally, but it was just a suggestion anyway | 14:44 |
| *** mkrai_ has quit IRC | 14:47 | |
| *** mkrai has quit IRC | 14:47 | |
| *** mkrai__ has joined #openstack-nova | 14:47 | |
| *** luksky has quit IRC | 14:48 | |
| mriedem | ok i can tinker with it, gonna be a bit since i'm in a meeting in 10 minutes | 14:50 |
| *** mkrai__ has quit IRC | 14:51 | |
| *** mlavalle has joined #openstack-nova | 14:52 | |
| dansmith | ack, I dropped a few other comments on that series, | 14:52 |
| dansmith | but overall..thanks for closing that loop.. it always seemed like a big deal so I never wanted to even start, but you made it look easy | 14:52 |
| *** henriqueof has joined #openstack-nova | 14:55 | |
| * mriedem blushes | 14:57 | |
| mnaser | sean-k-mooney: cpu/libvirt-y related question, is it possible that not all flags are passed down to the vm even with host-passthrough ? | 14:59 |
| *** JamesBenson has joined #openstack-nova | 14:59 | |
| *** jangutter_ has quit IRC | 15:00 | |
| sean-k-mooney | i belive that yes there are 1 or 2 instruction that are not passsed but in general no | 15:00 |
| mnaser | ok i have way more than 1 or 2 that arent passed through in this case.. | 15:01 |
| sean-k-mooney | the ones that are not passed releated to things like system management mode/model specic registers | 15:02 |
| sean-k-mooney | mnaser: which ones? | 15:02 |
| mnaser | https://www.irccloud.com/pastebin/MAa6LBVo/ | 15:03 |
| mnaser | sean-k-mooney: ^ | 15:03 |
| mnaser | wait sorry, thats what is exposed | 15:04 |
| mnaser | what _doesnt_ get exposed is | 15:04 |
| sean-k-mooney | they are the one not passed through? | 15:04 |
| sean-k-mooney | ok that makes more sense | 15:04 |
| mnaser | https://www.irccloud.com/pastebin/6qVAPHMx/ | 15:04 |
| mnaser | those ^ | 15:04 |
| sean-k-mooney | i was like how is it working at all with out a floating point unit | 15:04 |
| mnaser | loll | 15:04 |
| sean-k-mooney | i need to jump on an internal call for an hour mind if we come back to this after | 15:05 |
| sean-k-mooney | but first glance several of them are not verutaliable or are cpu bug flags | 15:06 |
| mnaser | yeah it looked like a lot of "management" things | 15:06 |
| mnaser | like seeing stuff like hw_pstate | 15:06 |
| sean-k-mooney | ya the svm ones are amd nested virt flags which need to be enabled in the kvm module sperately | 15:07 |
| sean-k-mooney | ht is hyper treading and is only expose dif you configre the guest to have 2 thrads | 15:08 |
| sean-k-mooney | e.g. hw:cpu_threads=2 | 15:08 |
| sean-k-mooney | "cat" "cdp" and "rdt" freatures cant be viertualsed | 15:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refine comments about move_allocations https://review.opendev.org/686182 | 15:09 |
| mnaser | okay so it looks like things are okay | 15:09 |
| sean-k-mooney | yep | 15:09 |
| sean-k-mooney | ill look at the list again later but first glance i dont see anygin alarming | 15:10 |
| kashyap | mnaser: Ideally all flags from host will be passed-through as-is | 15:10 |
| kashyap | (I haven't read the whole scrollback, though) | 15:10 |
| mnaser | kashyap: that was my theory but i figured there might some blacklist of "things i will not pass because a vm shouldnt have them" | 15:11 |
| mnaser | https://www.irccloud.com/pastebin/6qVAPHMx/ | 15:11 |
| mnaser | ^ the list that didnt show up | 15:11 |
| kashyap | mnaser: What's the host processor? | 15:13 |
| mnaser | kashyap: AMD EPYC 7402 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937 | 15:14 |
| kashyap | mnaser: Maybe silly question, did you cold-reboot the guest? | 15:16 |
| kashyap | (A bit slow, as on a meeting) | 15:16 |
| kashyap | s/on/I'm on/ | 15:16 |
| mnaser | kashyap: yeah, and the 'proof' of that is the model name in the VM went from "AMD EPYC Processor (with IBPB)" to "AMD EPYC 7402 24-Core Processor" | 15:17 |
| *** macz has joined #openstack-nova | 15:17 | |
| kashyap | mnaser: Aside: your guest doesn't have 'virt-ssbd', 'amd-ssbd', -- that means your microcode/QEMU/libvirt versions are older. | 15:21 |
| mnaser | kashyap: this is latest rdo so qemu 2.12.0, libvirt 4.5.0 | 15:22 |
| mnaser | for microcodes, amd stuff is all new to me :) | 15:22 |
| *** macz has quit IRC | 15:22 | |
| kashyap | (Nod.) There's a QEMU web page that tells you what features you need based on your CPU | 15:24 |
| mnaser | yeah, well, i'll see and dig into it | 15:24 |
| *** markvoelker has quit IRC | 15:25 | |
| kashyap | mnaser: Isn't that brand new CPU? | 15:25 |
| mnaser | yes, like released on the 7th of august :p | 15:26 |
| mnaser | so part of me is also wondering "oh i wonder if we have something odd here" | 15:26 |
| kashyap | [https://github.com/qemu/qemu/blob/master/docs/qemu-cpu-models.texi] Sorry for the 'texi' file | 15:26 |
| kashyap | mnaser: Yeah, darn, was checking on WikiChip | 15:26 |
| kashyap | mnaser: Okay, then here are the reasons why your guest don't see those features (also confirmed w/ a libvirt dev): | 15:26 |
| mnaser | they're pretty badass :) | 15:26 |
| kashyap | The reasons you don't see some host CPU features in your guest _despite_ 'host-passthrough': | 15:27 |
| kashyap | (1) The said CPU flag must be supported by QEMU/KVM and must be "virtualizable" | 15:27 |
| kashyap | (2) Some CPU flags (rather, features) are not exposed by default because, they're not migratable. | 15:28 |
| kashyap | ... the said features from (2) must be explicitly turned on _even with_ 'host-passthrough'. | 15:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/686184 | 15:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/686185 | 15:29 |
| kashyap | mnaser: Hope the above makes sense. | 15:29 |
| efried | gibi, dansmith: There's my crack at it --^ (done in a separate series) | 15:29 |
| gibi | efried: ack | 15:30 |
| efried | I have another idea that, if it works, will be an uglier helper but more intuitive calling syntax. | 15:30 |
| * efried tries... | 15:30 | |
| *** gbarros has quit IRC | 15:30 | |
| *** gyee has joined #openstack-nova | 15:30 | |
| sean-k-mooney | lyarwood: could you take a look at this reno backport https://review.opendev.org/#/c/662095/ for the rabbitmq eventlet behavior | 15:36 |
| *** gbarros has joined #openstack-nova | 15:36 | |
| sean-k-mooney | oh its not a backprot but ya we proably want to land that before the next stable/stein release whenever that is | 15:37 |
| * lyarwood walks away from RHBZ and takes a look | 15:39 | |
| *** ttsiouts has quit IRC | 15:39 | |
| * sean-k-mooney walking away for RHBZ is often the right choice in my experince :) | 15:39 | |
| *** ttsiouts has joined #openstack-nova | 15:40 | |
| lyarwood | sean-k-mooney: LGTM, I missed that Mel had updated this recently thanks. | 15:42 |
| sean-k-mooney | so did i i thought i had actully merged a week or two ago but went looking for it after our downstream call | 15:42 |
| *** ttsiouts has quit IRC | 15:44 | |
| *** JamesBenson has quit IRC | 15:48 | |
| *** mdbooth has quit IRC | 15:50 | |
| mnaser | kashyap: oh i see -- i will read around a bit more | 15:50 |
| kashyap | mnaser: We (I?) should document this somewhere. As many people will come to wonder. | 15:51 |
| mnaser | kashyap: yeah, i'm still wondering if this is a "im running really new hardware" issue or "its normal and i dont get it hat well" heh | 15:51 |
| *** mdbooth has joined #openstack-nova | 15:51 | |
| kashyap | (Maybe I'll send a patch to the upstream libvirt docs itself; and then to Nova.) | 15:52 |
| *** lpetrut has quit IRC | 15:52 | |
| kashyap | mnaser: This is a new hardware with some CPU features that are not yet supported by KVM/QEMU. | 15:53 |
| mnaser | kashyap: i really wanted to run el8 but rdo and friends are not there yet unfortunately | 15:53 |
| *** BjoernT has quit IRC | 15:53 | |
| kashyap | mnaser: What's the issue? Stein not yet tested on CentOS8? | 15:54 |
| mnaser | kashyap: yeah there's no openstack packages for el8 afaik | 15:54 |
| mnaser | there's f28 but not el8 | 15:54 |
| kashyap | mnaser: Yeah, I think the issue was CentOS-8 was released like last week. (I _guess_ it was delayed partly due to the "CentOS Stream", the parallel distro, announcement) | 15:55 |
| mnaser | yes, i think that's the theory that i heard too :) | 15:55 |
| kashyap | mnaser: Also, from my chat w/ Alan Pevec (from RDO) the other day, EL-8 packages are in the works. | 15:56 |
| *** damien_r has quit IRC | 15:56 | |
| kashyap | (But "in the works" is boring to hear, I know.) | 15:56 |
| *** BjoernT has joined #openstack-nova | 15:56 | |
| *** ociuhandu has quit IRC | 15:58 | |
| *** ociuhandu has joined #openstack-nova | 15:59 | |
| *** ociuhandu has quit IRC | 16:03 | |
| openstackgerrit | Merged openstack/nova master: Do not print default dicts during heal_allocations https://review.opendev.org/686001 | 16:04 |
| stephenfin | lyarwood: Care to look at https://review.opendev.org/#/c/685980/ so I can proceed with the other backports? https://review.opendev.org/#/c/685980/ | 16:05 |
| lyarwood | stephenfin: sure looking | 16:09 |
| *** pcaruana has quit IRC | 16:10 | |
| *** pcaruana has joined #openstack-nova | 16:11 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686063 | 16:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Another swing at `spy` https://review.opendev.org/686207 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/686208 | 16:21 |
| efried | gibi, dansmith: I think I have something that will make the caller happy. I have to run for a bit, so I haven't done up the actual tests yet, but... ^ | 16:21 |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686067 | 16:24 |
| mriedem | i'd like to get a stable/stein release out soon but i'd like it to have https://review.opendev.org/#/c/686063/ in it as well since it's a regression, but i'm not sure how that works in relation to train, i.e. can we release that in stein once it's in train rc2? i think that's probably fine | 16:26 |
| mriedem | we fix stuff in master all the time, backport it and release in stable before it's released in master i guess | 16:27 |
| *** tesseract has quit IRC | 16:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove a whole load of unused images https://review.opendev.org/686211 | 16:29 |
| *** jawad_axd has joined #openstack-nova | 16:30 | |
| melwitt | mriedem: did you mean can we release it in stein before we release train rc2? | 16:32 |
| lyarwood | I'm okay with doing that given train hasn't GA'd yet | 16:33 |
| *** jawad_axd has quit IRC | 16:35 | |
| mriedem | melwitt: yes, we obviously released the regression on stable before train | 16:36 |
| mriedem | so i think it's ok | 16:36 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove a whole load of unused images, most remainder https://review.opendev.org/686211 | 16:36 |
| mriedem | i think i'm just overthinking the train stuff | 16:37 |
| gibi | efried: ack, looks promising | 16:37 |
| melwitt | ok | 16:37 |
| *** derekh has quit IRC | 16:43 | |
| *** jawad_axd has joined #openstack-nova | 16:44 | |
| *** ociuhandu has joined #openstack-nova | 16:48 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add AggregateMultiTenancyIsolation filter tests https://review.opendev.org/464002 | 16:51 |
| *** ociuhandu has quit IRC | 16:52 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Update the file for IPv4-only or IPv6-only network https://review.opendev.org/465891 | 16:54 |
| *** tssurya has quit IRC | 16:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add warning message for cache_utils connection failure https://review.opendev.org/509060 | 17:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add warning message for cache_utils connection failure https://review.opendev.org/509060 | 17:02 |
| stephenfin | efried: This looks related to what we were talking about yesterday https://review.opendev.org/#/c/518119/ | 17:03 |
| stephenfin | Or not. I just see references to the same thing | 17:03 |
| stephenfin | I'm looking through super old bugs | 17:03 |
| stephenfin | *patches | 17:03 |
| mriedem | stephenfin: i think we already have a test for this now https://review.opendev.org/#/c/464002/ | 17:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't create instance_extra entry for deleted instance https://review.opendev.org/412771 | 17:06 |
| stephenfin | mriedem: Good spot. I guess I can rebase/rework that | 17:09 |
| stephenfin | Tomorrow though | 17:09 |
| mriedem | well, if it's duplicate we don't need it | 17:10 |
| * stephenfin -> 🏃 | 17:10 | |
| stephenfin | Not sure if there's stuff missing or not | 17:10 |
| stephenfin | I need to diff | 17:10 |
| *** jawad_axd has quit IRC | 17:10 | |
| stephenfin | or maybe what we have is good enough. Eh | 17:10 |
| mriedem | up to you, o/ | 17:11 |
| *** factor has joined #openstack-nova | 17:14 | |
| *** maciejjozefczyk has quit IRC | 17:22 | |
| *** BjoernT has quit IRC | 17:22 | |
| openstackgerrit | Merged openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980 | 17:23 |
| *** TxGirlGeek has joined #openstack-nova | 17:36 | |
| *** luksky has joined #openstack-nova | 17:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017 | 17:44 |
| openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 17:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 17:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during build reschedule https://review.opendev.org/686047 | 17:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during migrate reschedule https://review.opendev.org/686050 | 17:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update cells v2 up-call caveats doc https://review.opendev.org/686053 | 17:44 |
| mriedem | gibi: i had to remove the mock.patch context manager usage in the migrate functional test in that series ^ because it wasn't working properly | 17:44 |
| *** pcaruana has quit IRC | 17:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Handle get_host_availability_zone error during reschedule https://review.opendev.org/686226 | 17:48 |
| *** jmlowe has quit IRC | 17:50 | |
| openstackgerrit | Merged openstack/nova master: Handle get_host_availability_zone error during reschedule https://review.opendev.org/685997 | 17:54 |
| openstackgerrit | Merged openstack/nova stable/stein: Add reno about nova-api eventlet monkey-patching and rabbitmq https://review.opendev.org/662095 | 17:54 |
| *** awalende has joined #openstack-nova | 17:57 | |
| *** eandersson has joined #openstack-nova | 18:00 | |
| *** awalende has quit IRC | 18:02 | |
| *** igordc has joined #openstack-nova | 18:03 | |
| *** jmlowe has joined #openstack-nova | 18:10 | |
| openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add image-precache-support spec https://review.opendev.org/686232 | 18:12 |
| *** tbachman has quit IRC | 18:13 | |
| openstackgerrit | Merged openstack/nova master: Fix incorrect usages of fake moref in VMware tests https://review.opendev.org/685020 | 18:17 |
| *** TxGirlGeek has quit IRC | 18:29 | |
| *** jmlowe has quit IRC | 18:33 | |
| *** jdillaman has quit IRC | 18:35 | |
| openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add image-precache-support spec https://review.opendev.org/686232 | 18:40 |
| *** TxGirlGeek has joined #openstack-nova | 18:44 | |
| *** BjoernT has joined #openstack-nova | 18:44 | |
| *** BjoernT has quit IRC | 18:49 | |
| *** BjoernT has joined #openstack-nova | 18:52 | |
| melwitt | mriedem or efried: do you know if this is a known gate bug? 409 from placement "consumer generation conflict - expected null but got 1" https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dc8/684118/1/check/nova-multi-cell/dc8f056/testr_results.html.gz | 18:52 |
| *** TxGirlGeek has quit IRC | 18:53 | |
| *** tbachman has joined #openstack-nova | 18:54 | |
| mriedem | dagnabbit dansmith i was nearly done with PS1 on your spec | 18:54 |
| dansmith | mriedem: sorry, it was just a couple formatting things | 18:55 |
| mriedem | ok comments inline on PS1 | 18:56 |
| dansmith | thanks | 18:56 |
| mriedem | artom asked some of the same | 18:56 |
| *** TxGirlGeek has joined #openstack-nova | 18:57 | |
| mriedem | melwitt: i want to say not necessarily known, but i know i've fixed a race like that in scheduling before | 18:58 |
| *** tbachman has quit IRC | 18:59 | |
| *** dave-mccowan has joined #openstack-nova | 18:59 | |
| melwitt | ack. this one is new to me | 18:59 |
| dansmith | ....artom reviewed something of mine? | 19:00 |
| mriedem | melwitt: this is the gate issue that's like that which i fixed before https://review.opendev.org/#/c/623596/ | 19:00 |
| artom | dansmith, payback time | 19:00 |
| mriedem | i thought artom reserved his reviews specifically just for -1ing my stuff | 19:00 |
| melwitt | mriedem: thanks | 19:00 |
| *** tbachman has joined #openstack-nova | 19:03 | |
| *** bbowen_ has quit IRC | 19:05 | |
| *** spsurya has quit IRC | 19:09 | |
| mriedem | melwitt: given the name of the test, test_delete_server_while_in_building_state, i'm not surprised that there might be a race somehow | 19:09 |
| dansmith | artom: mriedem thanks for all that, and in record turnaround time :D | 19:10 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22consumer%20generation%20conflict%20-%20expected%20null%20but%20got%201%5C%22&from=7d | 19:10 |
| mriedem | neither change that hit it look related to causing the issue though | 19:11 |
| mriedem | Oct 01 22:17:03.897751 ubuntu-bionic-rax-iad-0012085716 devstack@n-api.service[17786]: INFO nova.api.openstack.wsgi [None req-c9e65a63-ea1f-4144-aace-c148ba386c8e tempest-DeleteServersTestJSON-641512281 tempest-DeleteServersTestJSON-641512281] HTTP exception thrown: Failed to delete allocations for consumer e7339a26-880b-4c27-972c-265d66eb5d82. Error: {"errors": [{"status": 409, "title": "Conflict", "detail": "There was a con | 19:12 |
| mriedem | t when trying to complete your request.\n\n consumer generation conflict - expected null but got 1 ", "code": "placement.concurrent_update", "request_id": "req-374479cc-0a6d-47b2-afbd-17c6e2f5413d"}]} | 19:12 |
| mriedem | so in this case the server probably got through scheduling and allocated resources on a provider after the delete request started but before we tried to delete the allocations | 19:13 |
| mriedem | in the local delete path in the api since the server doesn't have a host set yet | 19:13 |
| mriedem | melwitt: might as well report a bug for tracking | 19:13 |
| mriedem | melwitt: looks like this changed in stein to return the 409 https://review.opendev.org/#/c/591597/ | 19:17 |
| *** tbachman has quit IRC | 19:17 | |
| mriedem | before that we'd log but not fail the delete request | 19:17 |
| *** tbachman has joined #openstack-nova | 19:18 | |
| mriedem | when i wrote this in rocky anyway https://review.opendev.org/#/q/If507e23f0b7e5fa417041c3870d77786498f741d | 19:18 |
| mriedem | if delete_allocation_for_instance were smarter and returned a generation conflict exception, the api code could retry the call | 19:20 |
| mriedem | we could look for this in the error from placement: "code": "placement.concurrent_update" | 19:21 |
| mriedem | we do that elsewhere to detect races | 19:21 |
| mriedem | see SchedulerReportClient.claim_resources | 19:21 |
| *** ccamacho has joined #openstack-nova | 19:24 | |
| openstackgerrit | Merged openstack/nova master: conf: Remove deprecated 'project_id_regex' opt https://review.opendev.org/501057 | 19:26 |
| openstackgerrit | Merged openstack/nova master: Replace 'fake' with a real project ID https://review.opendev.org/685645 | 19:26 |
| *** ccamacho has quit IRC | 19:28 | |
| openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add image-precache-support spec https://review.opendev.org/686232 | 19:31 |
| efried | melwitt: did you get your answer on that 409? | 19:32 |
| efried | stephenfin: yes, you're right, that appears to be hitting some of the same stuff I was looking at, will dig, thanks for the pointer. | 19:33 |
| *** bbowen has joined #openstack-nova | 19:33 | |
| *** BjoernT has quit IRC | 19:37 | |
| *** jmlowe has joined #openstack-nova | 19:40 | |
| mriedem | efried: i think so - see above | 19:42 |
| mriedem | efried: just need a bug and a retry decorator on delete_allocations_for_instances i think | 19:42 |
| openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add image-precache-support spec https://review.opendev.org/686232 | 19:43 |
| efried | mriedem: Yeah, that sounds familiar, I want to say I had that somewhere on my to-do list ages ago but haven't gotten back to it. | 19:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Handle get_host_availability_zone error during reschedule https://review.opendev.org/686264 | 19:44 |
| *** BjoernT has joined #openstack-nova | 19:47 | |
| melwitt | mriedem: ok, I'll file a bug. thanks | 19:51 |
| mriedem | dansmith: i'm not sure that "sufficiently-endowed" should ever be in a spec | 19:55 |
| dansmith | mriedem: not with you around, that's for sure | 19:55 |
| mriedem | :P | 19:55 |
| artom | dansmith, "sufficiently-endowed", seriously? | 19:55 |
| artom | mriedem, dammit | 19:55 |
| mriedem | now don't go removing it yet, i'm commenting | 19:55 |
| dansmith | you two being the only two reviewers, I had to bait you good | 19:56 |
| artom | Careful how you spell bait | 19:56 |
| *** dpawlik has joined #openstack-nova | 19:56 | |
| * dansmith shakes his head | 19:57 | |
| dansmith | you guys are too easy | 19:57 |
| artom | It's more fun that way. | 19:57 |
| dansmith | endowed with permission is a totally legit phrasing | 19:58 |
| sean-k-mooney | dansmith: you have a lot of references in that spec. i added it to my list of things to revew | 19:59 |
| dansmith | sean-k-mooney: I listed a bunch of them so that reviewers would be afraid to not approve it | 19:59 |
| sean-k-mooney | it looks relitivly short for a spec but im to tired to review stuff a tthe momemnt so ill go through it tomorrow. | 20:00 |
| sean-k-mooney | hehe i see you are going for the over load them with example of why this is need so you cant question it approch | 20:00 |
| sean-k-mooney | it fairly effective | 20:01 |
| *** dpawlik has quit IRC | 20:01 | |
| artom | dansmith, I don't suppose setting up glance -> computes multicast is part of your MVP spec ;) | 20:02 |
| artom | But it'd be a way to get both the ease of fire-and-forget RPC cast while not killing the glance server | 20:03 |
| artom | Not that it's, you know, realistic in any way | 20:03 |
| dansmith | artom: the right solution, IMHO, is bittorrent | 20:03 |
| dansmith | which was proposed and implemented in RAX at one point | 20:03 |
| dansmith | basically, glance becomes a torrent seeder and only has to dish out the image once | 20:04 |
| artom | I genuinely thought you were kidding at first | 20:04 |
| dansmith | or however many workers you have, that's how many seeds you have | 20:04 |
| artom | But yeah, that's actually smart | 20:04 |
| dansmith | imagine how good that would be for an edge site where you have four computes.. right now they all pull the image over the WAN... but that makes no sense, they should share once one of them has it | 20:04 |
| dansmith | right | 20:04 |
| *** dave-mccowan has quit IRC | 20:04 | |
| dansmith | and if one got it yesterday and still has it, the peer compute can pull it from it instead of over the way | 20:05 |
| dansmith | *wan | 20:05 |
| dansmith | also imagine how in the future iteration where we need to report which computes have that image cached, if we could just ask the torrent magnet which computes are now seeds... :D | 20:06 |
| artom | *stunned Pikachu face* | 20:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Restore console proxy deployment info to cells v2 layout doc https://review.opendev.org/686271 | 20:08 |
| sean-k-mooney | we talkabout using bittorrent like 2 years ago | 20:08 |
| dansmith | we talked about it in 2012 | 20:08 |
| melwitt | efried, mriedem: added ^ to https://etherpad.openstack.org/p/nova-train-release-todo as a possible thing for RC2 | 20:08 |
| dansmith | but probably two years ago as well | 20:08 |
| sean-k-mooney | was it that long | 20:08 |
| * sean-k-mooney feels old | 20:09 | |
| sean-k-mooney | anyway im glad its now a thing | 20:09 |
| sean-k-mooney | because ya for edge it toptally makes sense | 20:09 |
| *** dave-mccowan has joined #openstack-nova | 20:10 | |
| sean-k-mooney | its resilent, spreads the load across multiple peers and works over low bandwitd links | 20:10 |
| dansmith | I'm not really proposing that in the short term, but it's always been something I wanted us to do | 20:10 |
| sean-k-mooney | well part of why i like it is its also not us e.g. openstack comping up with our own solution for a proablem that has and existing soltion already | 20:11 |
| dansmith | yup | 20:11 |
| mriedem | more comments | 20:14 |
| artom | dansmith, brainstorming here - but does oslo.concurrency give us a distributed semaphore? | 20:14 |
| *** remi_ness has joined #openstack-nova | 20:14 | |
| dansmith | artom: not without some external service | 20:15 |
| artom | I'm thinking - cast to the computes, but have the grab the semaphore when downloading | 20:15 |
| bnemec | Sounds like a use case for tooz. | 20:15 |
| mriedem | i was just going to make an etcd joke | 20:15 |
| bnemec | oslo.concurrency only works within a single machine. | 20:16 |
| artom | That way the concurrency becomes configurable (just set the semaphore's... err, cardinality?) and you don't ddos the glance server | 20:16 |
| dansmith | artom: yeah, it's just not really necessary when we can threadpool it from the conductor | 20:16 |
| artom | dansmith, for an RPC call though, right? | 20:16 |
| dansmith | artom: yup | 20:17 |
| artom | Yeah, I may be overthinking this | 20:17 |
| mriedem | melwitt: ack i'm cool with that, docs only and regression in train | 20:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Noop CantStartEngineError in targets_cell if API DB not configured https://review.opendev.org/686276 | 20:20 |
| *** markvoelker has joined #openstack-nova | 20:21 | |
| *** tbachman has quit IRC | 20:23 | |
| openstackgerrit | Merged openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | 20:26 |
| dansmith | mriedem: yawna read my response to the parallelism thing and if you're cool with it I can squash those todos in my next rev: https://review.opendev.org/#/c/686232/4/specs/ussuri/approved/image-precache-support.rst@123 | 20:26 |
| melwitt | mriedem: coolio | 20:26 |
| *** munimeha1 has joined #openstack-nova | 20:27 | |
| mriedem | dansmith: replied | 20:28 |
| dansmith | mriedem: thanks | 20:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Restore console proxy deployment info to cells v2 layout doc https://review.opendev.org/686271 | 20:30 |
| *** gbarros has quit IRC | 20:32 | |
| openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add image-precache-support spec https://review.opendev.org/686232 | 20:35 |
| *** nweinber has quit IRC | 20:36 | |
| *** tbachman has joined #openstack-nova | 20:36 | |
| efried | melwitt, mriedem: +2, good catch | 20:36 |
| efried | aspiers: how's that SEV fixup looking? Would be nice to produce RC2 tomorrow (and not need RC3). Your fix is the last one I know of that's not well on the way to merging. | 20:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Handle get_host_availability_zone error during reschedule https://review.opendev.org/686292 | 20:42 |
| mriedem | efried: deadline for RCs is oct 10 right? | 20:44 |
| efried | yes | 20:44 |
| mriedem | i mean, we want time for rc3 for sev issue #12 but sure | 20:44 |
| efried | smy point | 20:44 |
| efried | Oh, I misread, you're actually picking on SEV. I don't think we've had especially more issues for SEV than for other blueprints. Have there been more than one for any? | 20:45 |
| efried | Seems like one for SEV, one for VPMEM, one for console tokens, one (?) for cpu-resources... | 20:46 |
| efried | which is fine, exactly the reason FF happens before the release. | 20:46 |
| sean-k-mooney | efried: i dont think we had any for cpu-resouce but we had/have one for numa migration | 20:51 |
| sean-k-mooney | artom: has your fix for the RT cacheing issue landed? | 20:51 |
| mriedem | yes | 20:51 |
| *** tbachman has quit IRC | 20:52 | |
| sean-k-mooney | ok cool | 20:52 |
| mriedem | console proxy was a docs thing | 20:52 |
| mriedem | my point is sev landed late with a ton of churn over 2 releases (speaking as an outside observer to that series), so i wouldn't be surprised if there aren't more hairy issues | 20:52 |
| mriedem | seems like every issue in that series is very hard to resolve | 20:52 |
| mriedem | i also won't be surprised when there are issues with PCPU - we haven't seen issues because we're not using it anywhere yet | 20:53 |
| mriedem | but in 18 months...watch out! | 20:53 |
| sean-k-mooney | well there kind of is one but it was an issue we defeind as out of scope | 20:54 |
| sean-k-mooney | it related to https://review.opendev.org/#/c/686079/ | 20:54 |
| *** remi_ness has quit IRC | 20:54 | |
| sean-k-mooney | you can only have flaoting instnace and pinned instance on the same host and not have mempage issue if you enable the numa aware memory tracking using hw:mem_page_size=<any valid value> | 20:55 |
| sean-k-mooney | but we know it would not address that | 20:56 |
| *** dpawlik has joined #openstack-nova | 20:56 | |
| efried | mriedem: the console token thing we just merged? That wasn't a docs issue. | 20:58 |
| efried | it may not have been related to an actual blueprint either though, not sure. | 20:59 |
| sean-k-mooney | the console issue was passing the path argument in case it was not required right? | 21:00 |
| dansmith | I think he means the cells console proxy doc thing | 21:00 |
| efried | no | 21:00 |
| efried | https://review.opendev.org/#/c/686066/ Reduce scope of 'path' query parameter to noVNC consoles | 21:00 |
| dansmith | this: https://review.opendev.org/#/c/686271/ | 21:00 |
| efried | no | 21:01 |
| efried | -----^ | 21:01 |
| dansmith | efried: I mean he==mriedem, not you | 21:01 |
| efried | right | 21:01 |
| efried | and confirmed it wasn't a blueprint, it was a bug | 21:01 |
| efried | anywho | 21:01 |
| sean-k-mooney | im going to call it a night o/ | 21:02 |
| *** TxGirlGeek has quit IRC | 21:02 | |
| mriedem | efried: oh i wasn't thinking of the serial console thing | 21:05 |
| mriedem | efried: it was a bug fix for a novnc 1.1.0 regression or something but dug a bit too deep | 21:06 |
| *** lpetrut has joined #openstack-nova | 21:06 | |
| efried | y | 21:06 |
| mriedem | and actually wouldn't have been caught had it not been backported and released on stable | 21:06 |
| mriedem | speaking of, dansmith can you get https://review.opendev.org/#/c/686063/ on stein so we can do a stein release tomorrow? | 21:07 |
| mriedem | i think that's the last thing i was waiting on | 21:07 |
| *** maciejjozefczyk has joined #openstack-nova | 21:07 | |
| dansmith | okay | 21:07 |
| *** dpawlik has quit IRC | 21:07 | |
| *** xek has quit IRC | 21:08 | |
| *** markvoelker has quit IRC | 21:11 | |
| *** maciejjozefczyk has quit IRC | 21:12 | |
| *** markvoelker has joined #openstack-nova | 21:12 | |
| *** lpetrut has quit IRC | 21:15 | |
| *** factor has quit IRC | 21:17 | |
| *** dpawlik has joined #openstack-nova | 21:19 | |
| *** dpawlik has quit IRC | 21:24 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 21:25 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Modify nova routing table to process null requests https://review.opendev.org/518119 | 21:27 |
| *** BjoernT has quit IRC | 21:30 | |
| *** JamesBenson has joined #openstack-nova | 21:31 | |
| *** JamesBenson has quit IRC | 21:32 | |
| *** JamesBenson has joined #openstack-nova | 21:32 | |
| *** BjoernT has joined #openstack-nova | 21:35 | |
| *** JamesBenson has quit IRC | 21:37 | |
| *** markvoelker has quit IRC | 21:41 | |
| *** markvoelker has joined #openstack-nova | 21:41 | |
| *** tbachman has joined #openstack-nova | 21:45 | |
| *** markvoelker has quit IRC | 21:45 | |
| *** markvoelker has joined #openstack-nova | 21:45 | |
| ozzzo | Is there an "openstack" command corresponding to every "nova" and "nova-manage" command? | 21:46 |
| ozzzo | For example, can I do "nova-manage service-disable <HV UUID>" via openstack? | 21:47 |
| ozzzo | or "nova service-list" ? | 21:48 |
| ozzzo | The obvious thing to try would be "openstack service list" but that does something different | 21:49 |
| *** BjoernT has quit IRC | 21:50 | |
| *** takashin has joined #openstack-nova | 21:51 | |
| *** BjoernT has joined #openstack-nova | 21:54 | |
| mriedem | yes, | 21:56 |
| mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html#compute-service-set | 21:56 |
| mriedem | nova-manage and nova/openstack CLIs are not the same | 21:56 |
| mriedem | the former doesn't use apis, but hits the db directly when the api isn't available, and doesn't require a token, the latter requires a token and uses the api | 21:57 |
| mriedem | you're also looking for this https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html#compute-service-list | 21:57 |
| ozzzo | very nice, thank you! | 21:58 |
| *** TxGirlGeek has joined #openstack-nova | 22:01 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix unit of hw_rng:rate_period https://review.opendev.org/683051 | 22:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | 22:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Move Destination object tests to their own test class https://review.opendev.org/683017 | 22:02 |
| *** TxGirlGeek has quit IRC | 22:12 | |
| *** markvoelker has quit IRC | 22:17 | |
| *** mlavalle has quit IRC | 22:18 | |
| ozzzo | Is there an "openstack" command for "nova-manage cell_v2 discover-hosts" ? | 22:18 |
| mriedem | no | 22:19 |
| mriedem | there is a config option to enable it in a periodic task if you don't want to hit the command line | 22:20 |
| ozzzo | ok ty | 22:20 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#scheduler.discover_hosts_in_cells_interval | 22:20 |
| *** TxGirlGeek has joined #openstack-nova | 22:23 | |
| *** BjoernT has quit IRC | 22:24 | |
| melwitt | mriedem: at first glance I wondered if this is related to the recent eventlet tpool proxy change, but it's reported against ocata https://bugs.launchpad.net/nova/+bug/1845759 | 22:27 |
| openstack | Launchpad bug 1845759 in OpenStack Compute (nova) "Openstack nova-compute service gives cant start new thread with oslo messaging" [Undecided,New] | 22:27 |
| mriedem | i saw it in triage but didn't have thoughts on it | 22:28 |
| melwitt | me neither. I've never seen anything like it before | 22:29 |
| *** mriedem has quit IRC | 22:31 | |
| ozzzo | I was thinking that "openstack compute service delete" would behave similar to "openstack resource provider delete" but the service did not come back when I typed "nova-manage cell_v2 discover_hosts" | 22:33 |
| ozzzo | how can I re-create the hypervisor service that I deleted? | 22:34 |
| *** slaweq has quit IRC | 22:35 | |
| artom | sean-k-mooney, https://review.opendev.org/#/c/685387/? Yeah | 22:38 |
| melwitt | ozzzo: I think just create it again https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/service.html#service-create the service command is different than the resource provider command, the resource provider command modifies only the placement service database and the service command modifies both the nova service database and the placement service database (by way of the placement API) | 22:39 |
| ozzzo | ok I'll try that, ty! | 22:44 |
| melwitt | 'openstack compute service delete' will delete the records of the service in the nova database and then it will do an equivalent REST API call as 'openstack resource provider delete' to the placement service | 22:45 |
| *** rcernin has joined #openstack-nova | 22:48 | |
| ozzzo | that didn't seem to work; I typed "openstack service create --name us01odc-dev1-hv001 --enable nova-compute" but I still only have 2 hypervisor services under "openstack compute service list" | 22:50 |
| ozzzo | It looks like I created a new service called us01odc-dev1-hv001 under "openstack service list" | 22:51 |
| ozzzo | it looks like "service" and "compute service" are 2 different things | 22:51 |
| melwitt | yeah... I'm looking at the doc and the <type> looks like it should be one of compute, identity, volume but I'm not 100% sure | 22:52 |
| ozzzo | on the "compute service" man page I only see delete, list and set, there is no create | 22:52 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/686207 | 22:54 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/686208 | 22:54 |
| efried | gibi, dansmith: There ^ | 22:54 |
| *** tkajinam has joined #openstack-nova | 22:54 | |
| efried | (recommend looking at the test deltas first) | 22:55 |
| ozzzo | I stop/started nova-compute on the hypervisor; that appears to have re-created the service | 22:56 |
| ozzzo | thanks for your advice melwitt! | 22:56 |
| ozzzo | I'm trying to figure out how to remove, repair and re-add broken hypervisors | 22:57 |
| melwitt | ozzzo: oh, yeah ok, all you have to do it start the service, I guess that makes sense -_- heh. I guess just delete that extra service from earlier so it won't confuse you later | 22:57 |
| melwitt | whatever that was, the one that didn't help | 22:57 |
| ozzzo | righton | 22:58 |
| ozzzo | I guess service means 2 things in OS; there's a "nova" service that has multiple service providers, managed by "openstack service" but there's also a "nova-compute" service that runs on each of those service providers, managed by "openstack compute service" | 22:59 |
| melwitt | yeah, it looks like the unified client (openstackclient) lumps all the services together for the 'service list' but when you do a 'service create' you have to specify the <type> which is either 'compute' (nova), 'identity' (keystone), 'volume' (cinder) etc and they are compartmentalized like that | 23:02 |
| melwitt | and the <type> lets the client know which REST API to call | 23:04 |
| ozzzo | ok, I'm starting to get it | 23:04 |
| melwitt | but it sounds like there's no validation on the <type> so it allows anything and tries to do a lookup in the service catalog and doesn't raise an error? that seems odd | 23:05 |
| melwitt | I'm just speculating, I'd have to look in the code to know for sure | 23:05 |
| openstackgerrit | Merged openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/685534 | 23:09 |
| openstackgerrit | Merged openstack/nova master: Restore console proxy deployment info to cells v2 layout doc https://review.opendev.org/686271 | 23:09 |
| *** JamesBenson has joined #openstack-nova | 23:20 | |
| *** luksky has quit IRC | 23:22 | |
| *** JamesBenson has quit IRC | 23:24 | |
| *** TxGirlGeek has quit IRC | 23:35 | |
| *** panda is now known as panda|off | 23:39 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/686208 | 23:40 |
| *** gbarros has joined #openstack-nova | 23:41 | |
| *** gbarros has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!