| *** victor286 has joined #openstack-nova | 00:31 | |
| *** ricolin has joined #openstack-nova | 00:32 | |
| *** victor287 has joined #openstack-nova | 00:33 | |
| *** victor286 has quit IRC | 00:33 | |
| *** victor287 has quit IRC | 00:33 | |
| *** victor286 has joined #openstack-nova | 00:33 | |
| *** victor287 has joined #openstack-nova | 00:37 | |
| *** victor286 has quit IRC | 00:40 | |
| *** victor287 is now known as victor286 | 00:40 | |
| *** Liang__ has joined #openstack-nova | 01:08 | |
| *** Liang__ is now known as LiangFang | 01:17 | |
| *** brinzhang has quit IRC | 01:29 | |
| *** brinzhang has joined #openstack-nova | 01:29 | |
| *** victor287 has joined #openstack-nova | 01:35 | |
| *** brinzhang_ has joined #openstack-nova | 01:38 | |
| *** victor286 has quit IRC | 01:39 | |
| *** victor287 is now known as victor286 | 01:39 | |
| *** brinzhang has quit IRC | 01:41 | |
| *** BjoernT has joined #openstack-nova | 01:50 | |
| *** BjoernT has quit IRC | 01:59 | |
| *** BjoernT has joined #openstack-nova | 02:05 | |
| *** tkajinam_ has joined #openstack-nova | 02:06 | |
| *** BjoernT has quit IRC | 02:08 | |
| *** tkajinam has quit IRC | 02:09 | |
| *** brinzhang has joined #openstack-nova | 02:10 | |
| *** brinzhang_ has quit IRC | 02:14 | |
| *** brinzhang_ has joined #openstack-nova | 02:17 | |
| *** brinzhang has quit IRC | 02:20 | |
| *** gbarros has joined #openstack-nova | 02:21 | |
| *** victor287 has joined #openstack-nova | 02:27 | |
| *** victor286 has quit IRC | 02:29 | |
| *** victor287 is now known as victor286 | 02:29 | |
| *** brinzhang has joined #openstack-nova | 02:43 | |
| *** gbarros has quit IRC | 02:43 | |
| *** brinzhang_ has quit IRC | 02:46 | |
| *** markvoelker has joined #openstack-nova | 02:46 | |
| *** davee_ has joined #openstack-nova | 03:03 | |
| *** davee__ has quit IRC | 03:04 | |
| *** brinzhang_ has joined #openstack-nova | 03:13 | |
| openstackgerrit | Rui Zang proposed openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593 | 03:16 |
|---|---|---|
| *** brinzhang has quit IRC | 03:17 | |
| *** BjoernT has joined #openstack-nova | 03:19 | |
| *** brinzhang has joined #openstack-nova | 03:20 | |
| *** BjoernT_ has joined #openstack-nova | 03:23 | |
| *** brinzhang_ has quit IRC | 03:23 | |
| *** BjoernT has quit IRC | 03:24 | |
| *** mkrai has joined #openstack-nova | 03:41 | |
| *** psachin has joined #openstack-nova | 03:55 | |
| *** udesale has joined #openstack-nova | 04:04 | |
| *** toabctl has joined #openstack-nova | 04:07 | |
| *** brinzhang_ has joined #openstack-nova | 04:12 | |
| *** brinzhang has quit IRC | 04:15 | |
| *** BjoernT_ has quit IRC | 04:18 | |
| *** BjoernT has joined #openstack-nova | 04:21 | |
| *** ociuhandu has joined #openstack-nova | 04:30 | |
| *** ociuhandu has quit IRC | 04:35 | |
| *** brinzhang has joined #openstack-nova | 04:57 | |
| *** Luzi has joined #openstack-nova | 05:01 | |
| *** brinzhang_ has quit IRC | 05:01 | |
| *** ircuser-1 has joined #openstack-nova | 05:01 | |
| *** brinzhang_ has joined #openstack-nova | 05:02 | |
| *** markvoelker has quit IRC | 05:02 | |
| *** jaosorior has joined #openstack-nova | 05:03 | |
| *** brinzhang has quit IRC | 05:03 | |
| *** BjoernT has quit IRC | 05:08 | |
| *** BjoernT has joined #openstack-nova | 05:11 | |
| *** BjoernT has quit IRC | 05:23 | |
| *** brinzhang has joined #openstack-nova | 05:23 | |
| *** pcaruana has joined #openstack-nova | 05:24 | |
| *** ratailor has joined #openstack-nova | 05:25 | |
| *** brinzhang_ has quit IRC | 05:27 | |
| *** dpawlik has joined #openstack-nova | 05:28 | |
| *** pcaruana has quit IRC | 05:30 | |
| *** janki has joined #openstack-nova | 05:35 | |
| *** brinzhang_ has joined #openstack-nova | 05:38 | |
| *** brinzhang has quit IRC | 05:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace 'fake' with a real project ID https://review.opendev.org/685645 | 05:43 |
| *** markvoelker has joined #openstack-nova | 05:58 | |
| openstackgerrit | Rui Zang proposed openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593 | 05:58 |
| *** dpawlik has quit IRC | 06:01 | |
| *** markvoelker has quit IRC | 06:02 | |
| *** slaweq has joined #openstack-nova | 06:23 | |
| *** dpawlik has joined #openstack-nova | 06:29 | |
| *** avolkov has joined #openstack-nova | 06:37 | |
| *** luksky has joined #openstack-nova | 06:38 | |
| *** pcaruana has joined #openstack-nova | 06:41 | |
| *** damien_r has joined #openstack-nova | 06:56 | |
| *** damien_r has quit IRC | 06:56 | |
| *** damien_r has joined #openstack-nova | 06:57 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:12 | |
| *** rcernin has quit IRC | 07:14 | |
| *** tesseract has joined #openstack-nova | 07:17 | |
| *** jchhatbar has joined #openstack-nova | 07:23 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM libvirt: extract _start_heterogeneous_computes https://review.opendev.org/682620 | 07:23 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621 | 07:23 |
| openstack | bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood) | 07:23 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622 | 07:23 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove stale BDMs on reserve_block_device_name failure https://review.opendev.org/682594 | 07:25 |
| *** arxcruz|zzz is now known as arxcruz|ruck | 07:25 | |
| *** janki has quit IRC | 07:25 | |
| openstackgerrit | wangfaxin proposed openstack/nova master: fixd notes: neuton is replaced with neutron in line 756. https://review.opendev.org/685509 | 07:29 |
| *** tesseract has quit IRC | 07:43 | |
| *** tesseract has joined #openstack-nova | 07:43 | |
| *** LiangFang has quit IRC | 07:43 | |
| *** dpawlik has quit IRC | 07:45 | |
| *** rpittau|afk is now known as rpittau | 07:52 | |
| *** markvoelker has joined #openstack-nova | 08:00 | |
| *** ralonsoh has joined #openstack-nova | 08:00 | |
| *** tkajinam_ has quit IRC | 08:00 | |
| *** ttsiouts has joined #openstack-nova | 08:02 | |
| *** dpawlik has joined #openstack-nova | 08:04 | |
| *** markvoelker has quit IRC | 08:04 | |
| *** takashin has left #openstack-nova | 08:05 | |
| *** ttsiouts has quit IRC | 08:16 | |
| *** ttsiouts has joined #openstack-nova | 08:20 | |
| *** xek has joined #openstack-nova | 08:23 | |
| *** dtantsur|afk is now known as dtantsur | 08:24 | |
| *** ttsiouts has quit IRC | 08:31 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** dpawlik has quit IRC | 08:39 | |
| *** cdent has joined #openstack-nova | 08:56 | |
| *** cdent has left #openstack-nova | 08:57 | |
| *** tssurya has joined #openstack-nova | 08:57 | |
| *** dpawlik has joined #openstack-nova | 08:59 | |
| openstackgerrit | Seyeong Kim proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info https://review.opendev.org/579004 | 09:00 |
| *** dpawlik has quit IRC | 09:04 | |
| *** ttsiouts has joined #openstack-nova | 09:08 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Fix invalid link index https://review.opendev.org/685664 | 09:12 |
| *** dpawlik has joined #openstack-nova | 09:13 | |
| *** ricolin has quit IRC | 09:13 | |
| *** jangutter has joined #openstack-nova | 09:13 | |
| *** smcginnis has quit IRC | 09:14 | |
| bauzas | gibi: <3 you | 09:15 |
| bauzas | gibi: found a shit number of helpers | 09:15 |
| bauzas | in the integrated helpers for my functional tests | 09:15 |
| bauzas | will make them easier to read | 09:15 |
| gibi | bauzas: I'm glad that those can help you | 09:15 |
| *** ttsiouts has quit IRC | 09:17 | |
| bauzas | gibi: the only issue is that I discovered those helpers after some time | 09:20 |
| * bauzas needs more to look at the existing modules | 09:20 | |
| gibi | yeah it is hard how to make such (and other) helper codes discoverable | 09:21 |
| bauzas | unless by reviewing others's patches :) | 09:21 |
| gibi | but nobody can review every incoming patch in nova to know what happens | 09:22 |
| *** zbr is now known as zbr|ruck | 09:24 | |
| bauzas | ...also if they have a lot of other things to do internally :) | 09:27 |
| aspiers | Is it just me or is https://docs.openstack.org/glance/latest/admin/useful-image-properties.html wrong regarding the default of hw_scsi_model being virtio-blk? | 09:29 |
| *** dpawlik has quit IRC | 09:29 | |
| aspiers | AFAICS, if hw_scsi_model is not specified, there will be no SCSI controller | 09:31 |
| aspiers | but also, "virtio-blk" is not a valid value in nova.objects.fields.SCSIModel | 09:32 |
| *** sapd1_x has joined #openstack-nova | 09:33 | |
| aspiers | and in fact that doc is missing all the other valid values | 09:36 |
| *** dpawlik has joined #openstack-nova | 09:48 | |
| *** ociuhandu has joined #openstack-nova | 09:52 | |
| *** ttsiouts has joined #openstack-nova | 09:55 | |
| *** mkrai has quit IRC | 09:57 | |
| *** victor286 has quit IRC | 10:11 | |
| aspiers | ah, I think I figured it out | 10:16 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use the `preferred` memory allocation mode for NUMA https://review.opendev.org/684375 | 10:16 |
| aspiers | the default when hw_scsi_model is not specified is no SCSI controller, and something like <target dev='vda' bus='virtio'/> | 10:16 |
| aspiers | which is colloquially referred to as virtio-blk, but it's just 'virtio' in the code | 10:17 |
| *** sean-k-mooney has quit IRC | 10:18 | |
| *** sean-k-mooney has joined #openstack-nova | 10:22 | |
| sean-k-mooney | aspiers: yes the defualt for libvirt/kvm is virtio or virtio-blk or virtio block | 10:23 |
| *** mkrai has joined #openstack-nova | 10:23 | |
| aspiers | sean-k-mooney: thanks for confirmation. just submitted https://review.opendev.org/#/c/685674/ | 10:23 |
| sean-k-mooney | if you want to use virto-scsi you need to set the disk bus to scsi and then set the scsi model to virtio-scsi | 10:24 |
| sean-k-mooney | the default storage contole depend on the hypervisor and virt type | 10:25 |
| sean-k-mooney | it wont alwyas be virtio if you dont set hw_disk_bus | 10:25 |
| *** avolkov has quit IRC | 10:27 | |
| sean-k-mooney | aspiers: this is the funciton in the libvirt driver that chooes the defult disk bus https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L221-L296 | 10:28 |
| sean-k-mooney | i should also point out that there is this horrible code that tries to incorrectly determin the optimal default disk and cd buss form the image os | 10:31 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L114-L147 | 10:31 |
| sean-k-mooney | but its actully broken by desgin in that it expect the OS version to be concatonated into the os_distro field instead of actully reading the os_version field so it does not actully work correctly | 10:33 |
| openstackgerrit | Dongcan Ye proposed openstack/nova master: libvirt: Check the guest support UEFI https://review.opendev.org/685678 | 10:39 |
| *** ociuhandu has quit IRC | 10:40 | |
| *** ociuhandu has joined #openstack-nova | 10:53 | |
| *** ricolin has joined #openstack-nova | 10:54 | |
| *** ttsiouts has quit IRC | 10:56 | |
| *** jchhatbar has quit IRC | 11:00 | |
| *** henriqueof has joined #openstack-nova | 11:01 | |
| *** markvoelker has joined #openstack-nova | 11:01 | |
| *** markvoelker has quit IRC | 11:06 | |
| *** udesale has quit IRC | 11:13 | |
| *** luksky has quit IRC | 11:14 | |
| *** rcernin has joined #openstack-nova | 11:28 | |
| sean-k-mooney | lyarwood: care to hit some easy sable patches in os-vif | 11:32 |
| sean-k-mooney | https://review.opendev.org/#/c/683489/ https://review.opendev.org/#/c/683488/ | 11:33 |
| sean-k-mooney | well not backports release stuff. just the git review and constraits file updates for train | 11:33 |
| *** ociuhandu has quit IRC | 11:35 | |
| *** ociuhandu has joined #openstack-nova | 11:36 | |
| *** mkrai has quit IRC | 11:38 | |
| *** xek has quit IRC | 11:39 | |
| *** xek_ has joined #openstack-nova | 11:39 | |
| *** mkrai has joined #openstack-nova | 11:45 | |
| lyarwood | sean-k-mooney: ack looking | 11:48 |
| *** awalende has joined #openstack-nova | 11:50 | |
| lyarwood | sean-k-mooney: done | 11:52 |
| *** ttsiouts has joined #openstack-nova | 11:52 | |
| *** ttsiouts has quit IRC | 12:06 | |
| *** ttsiouts has joined #openstack-nova | 12:06 | |
| *** Kevin_Zheng has quit IRC | 12:10 | |
| *** luksky has joined #openstack-nova | 12:13 | |
| openstackgerrit | Seyeong Kim proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info https://review.opendev.org/579004 | 12:15 |
| *** rcernin has quit IRC | 12:50 | |
| *** sapd1_x has quit IRC | 12:58 | |
| *** dtantsur is now known as dtantsur|afk | 12:58 | |
| *** gbarros has joined #openstack-nova | 12:59 | |
| *** nweinber_ has joined #openstack-nova | 12:59 | |
| *** dklyle has quit IRC | 13:00 | |
| *** markvoelker has joined #openstack-nova | 13:02 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 13:03 | |
| openstackgerrit | Merged openstack/os-vif master: Update the constraints url https://review.opendev.org/683873 | 13:04 |
| *** maciejjozefczyk has quit IRC | 13:05 | |
| *** ttsiouts has quit IRC | 13:06 | |
| *** markvoelker has quit IRC | 13:06 | |
| *** ratailor has quit IRC | 13:10 | |
| openstackgerrit | Merged openstack/os-vif master: Update master for stable/train https://review.opendev.org/683490 | 13:12 |
| *** mkrai has quit IRC | 13:12 | |
| *** BjoernT has joined #openstack-nova | 13:14 | |
| *** dave-mccowan has joined #openstack-nova | 13:17 | |
| *** ttsiouts has joined #openstack-nova | 13:20 | |
| *** mriedem has joined #openstack-nova | 13:25 | |
| bauzas | mriedem: morningh | 13:27 |
| bauzas | mriedem: reviewing a shit number of times https://review.opendev.org/#/c/678100/ | 13:27 |
| bauzas | IIUC, we leak the source allocation by https://review.opendev.org/#/c/678100/1/nova/tests/functional/wsgi/test_services.py | 13:29 |
| *** BjoernT has quit IRC | 13:33 | |
| *** maciejjozefczyk_ has quit IRC | 13:35 | |
| openstackgerrit | Merged openstack/os-vif stable/train: Update .gitreview for stable/train https://review.opendev.org/683488 | 13:35 |
| *** maciejjozefczyk has joined #openstack-nova | 13:35 | |
| *** dpawlik has quit IRC | 13:36 | |
| *** Luzi has quit IRC | 13:37 | |
| *** BjoernT_ has joined #openstack-nova | 13:43 | |
| mriedem | bauzas: i'm not following the question | 13:43 |
| bauzas | sorry then | 13:43 |
| *** dklyle has joined #openstack-nova | 13:43 | |
| mriedem | for evacuate we leak the source allocation when deleting the source compute service | 13:44 |
| mriedem | b/c we fail to delete the resource provider b/c it has allocatoins against it from the evacuate | 13:44 |
| bauzas | trying to exactly understand how to get an orphan allocation when resizeing | 13:44 |
| bauzas | as I want to write some functest | 13:44 |
| mriedem | for resize, you'd migrate the server so it gets to VERIFY_RESIZE, then delete the source compute service | 13:44 |
| bauzas | for the moment, I did : create the instance, resize, delete the service | 13:44 |
| mriedem | yes | 13:44 |
| mriedem | the source resource provider will have allocations held by the migration record | 13:44 |
| bauzas | but when confirming the resize, I get an exception | 13:45 |
| *** awalende has quit IRC | 13:45 | |
| mriedem | that's separate from the leaked allocation issue | 13:45 |
| *** awalende has joined #openstack-nova | 13:45 | |
| bauzas | hum, so, once I delete the service, I'll just delete the instance? | 13:46 |
| mriedem | for one thing, if you restart the source compute service it will create a new compute node with a new uuid and a new resource provider, so the migration record won't be able to find allocations on that one | 13:46 |
| mriedem | i guess i'd have to know what the error is when you go to confirm the resize | 13:46 |
| bauzas | secf | 13:46 |
| bauzas | mriedem: http://paste.openstack.org/show/780354/ | 13:47 |
| *** dklyle has quit IRC | 13:48 | |
| bauzas | when confirming the resize, I get an exception saying that it doesn't get the source compute UUID | 13:48 |
| *** david-lyle has joined #openstack-nova | 13:48 | |
| *** munimeha1 has joined #openstack-nova | 13:49 | |
| mriedem | does the test stop/start a new compute service after deleting the original source compute service? | 13:49 |
| mriedem | starting a new compute service is going to create a new compute node record | 13:49 |
| mriedem | if you didn't fully stop the service it's going to have residual cached information in the ResourceTracker.compute_nodes dict | 13:49 |
| *** awalende has quit IRC | 13:50 | |
| mriedem | which is likely a bug in your test, though someone could totally forget to stop the compute service before deleting it, we have warnings in the API about that | 13:50 |
| openstackgerrit | Merged openstack/os-vif stable/train: Update TOX/UPPER_CONSTRAINTS_FILE for stable/train https://review.opendev.org/683489 | 13:51 |
| bauzas | mriedem: okay, I can restart the service before confirming, then | 13:51 |
| bauzas | thanks | 13:51 |
| mriedem | well, to do things the proper way, you should be stopping the source compute service, then deleting it, and then starting a new one | 13:52 |
| mriedem | https://docs.openstack.org/api-ref/compute/?expanded=delete-compute-service-detail#delete-compute-service | 13:52 |
| *** gbarros has quit IRC | 13:53 | |
| mriedem | so what is happening i think is that because you're confirming with a stale ResourceTracker.compute_nodes entry, it's trying to update a record that was deleted when you deleted the compute service | 13:53 |
| mriedem | w/o stopping it | 13:53 |
| *** jangutter has quit IRC | 13:53 | |
| *** jamesdenton has quit IRC | 13:54 | |
| mriedem | one could argue that drop_move_claim should handle that since we don't prevent you from deleting the compute service in the api w/o stopping it first | 13:54 |
| mriedem | but it's a different bug | 13:54 |
| bauzas | okay, I'll quickly write it | 13:55 |
| *** gbarros has joined #openstack-nova | 13:56 | |
| mriedem | b/c of this https://opendev.org/openstack/nova/src/branch/master/nova/compute/resource_tracker.py#L714 is why we don't create a new compute node record when you start the service after deleting it | 13:56 |
| mriedem | and we're using the old now-deleted version | 13:56 |
| mriedem | https://review.opendev.org/#/c/684849/ is a similar issue | 13:57 |
| mriedem | i've found a few problems in the RT code lately b/c of that caching | 13:57 |
| *** TxGirlGeek has joined #openstack-nova | 13:57 | |
| mriedem | https://review.opendev.org/#/q/I9fa1d509a3de405d6246fb8670612c65c10cc93b | 13:57 |
| *** ociuhandu has quit IRC | 13:58 | |
| mriedem | feel free to hit the queens backport for ^ before you get a bz downstream for it anyway | 13:58 |
| *** redrobot has joined #openstack-nova | 13:59 | |
| mriedem | need another stable core to approve this backport for train rc2 https://review.opendev.org/#/c/685387/ | 14:02 |
| bauzas | mriedem: can do | 14:02 |
| *** TxGirlGeek has quit IRC | 14:05 | |
| *** jamesdenton has joined #openstack-nova | 14:06 | |
| mriedem | bauzas: btw i might have misled you with a comment on your placement audit patch about recreating an evacuate scenario with leaked allocations, if i said there is a migration-based allocatoin on the source provider during evacuate, that was wrong | 14:06 |
| mriedem | we only do migration-based allocation swap-a-roo for cold and live migrate | 14:07 |
| mriedem | *and resize | 14:07 |
| bauzas | mriedem: hmmm | 14:07 |
| mriedem | there is an allocation on the source provider, it's just not held by a migration record, it's held by the instance consumer | 14:07 |
| *** jangutter has joined #openstack-nova | 14:08 | |
| bauzas | mriedem: that's what I found | 14:08 |
| bauzas | mriedem: I already have a test for evacuate which works | 14:08 |
| *** smcginni1 has joined #openstack-nova | 14:08 | |
| bauzas | mriedem: https://review.opendev.org/#/c/670112/5/nova/tests/functional/test_nova_manage.py@1470 (but I need to rewrite this test to use the existing helpers thanks to gibi :) ) | 14:08 |
| *** adriant has quit IRC | 14:09 | |
| *** smcginni1 is now known as smcginnis_ | 14:11 | |
| *** pcaruana has quit IRC | 14:18 | |
| *** ttsiouts has quit IRC | 14:20 | |
| *** ttsiouts has joined #openstack-nova | 14:20 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ociuhandu has joined #openstack-nova | 14:33 | |
| *** BjoernT_ is now known as BjoernT | 14:40 | |
| *** smcginnis_ is now known as smcginnis | 14:46 | |
| *** slaweq has quit IRC | 14:48 | |
| *** slaweq has joined #openstack-nova | 14:50 | |
| *** TxGirlGeek has joined #openstack-nova | 14:54 | |
| *** awalende has joined #openstack-nova | 14:56 | |
| *** maciejjozefczyk has quit IRC | 14:57 | |
| *** awalende has quit IRC | 15:01 | |
| *** markvoelker has joined #openstack-nova | 15:02 | |
| *** mlavalle has joined #openstack-nova | 15:04 | |
| *** nweinber_ has quit IRC | 15:04 | |
| *** nweinber has joined #openstack-nova | 15:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in '_IntegratedTestBase' subclasses https://review.opendev.org/684326 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in 'ApiSampleTestBase' subclasses https://review.opendev.org/684328 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in 'ServersSampleBase' subclasses https://review.opendev.org/684330 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_networks_associate' functional tests https://review.opendev.org/684338 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 15:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 15:14 |
| *** Jeffrey4l has quit IRC | 15:19 | |
| *** Jeffrey4l has joined #openstack-nova | 15:20 | |
| *** mkrai has joined #openstack-nova | 15:24 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825 | 15:25 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825 | 15:25 |
| *** luksky has quit IRC | 15:26 | |
| openstackgerrit | Merged openstack/nova stable/train: Stop filtering out 'accepted' for in-progress migrations https://review.opendev.org/685387 | 15:29 |
| *** gyee has joined #openstack-nova | 15:30 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593 | 15:34 |
| *** jdillaman has joined #openstack-nova | 15:35 | |
| dansmith | efried: looks like that should be an rc2 thing eh? | 15:36 |
| *** jmlowe has quit IRC | 15:38 | |
| *** damien_r has quit IRC | 15:39 | |
| dansmith | really, the guest config module should handle that | 15:39 |
| efried | dansmith: Could make an argument for RC2, yeah. | 15:41 |
| efried | since basically py3 is busted otherwise. | 15:42 |
| dansmith | it's a regression and a broken feature we added in train, so it seems clear to me | 15:42 |
| efried | dansmith: Since Alex was +2 and I just changed the test, would you feel good about fast approving it? | 15:42 |
| efried | "the guest config module should handle" like by knowing which fields are supposed to be int and casting them before stringifying them? | 15:43 |
| dansmith | I'm pulling it down to mess with it | 15:43 |
| dansmith | efried: uhyeah.. right now it would stringify an object in that field if you gave it to it | 15:43 |
| dansmith | which is dumb | 15:43 |
| dansmith | obviously not for this fix though | 15:44 |
| efried | yeah, seems like probably that would be a pervasive problem throughout | 15:44 |
| efried | though I haven't looked | 15:44 |
| dansmith | it is, from a quick look | 15:44 |
| efried | It took me a hot minute to figure out why we weren't getting by on the fact that the ovo fields are IntegerField() | 15:45 |
| efried | but it's because we're doing the conversion after that | 15:45 |
| efried | s/conversion/division/ | 15:45 |
| dansmith | yeah, this is way after any object stuff | 15:45 |
| *** pcaruana has joined #openstack-nova | 15:46 | |
| *** rpittau is now known as rpittau|afk | 15:48 | |
| *** tssurya has quit IRC | 15:49 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/train: make virtual pmem feature compatible with python3 https://review.opendev.org/685742 | 15:50 |
| *** tesseract has quit IRC | 15:55 | |
| dansmith | I guess if we | 15:58 |
| dansmith | are going to merge things based purely on manual testing by the submitter, we should ask for them to do it in py2 and py3 | 15:58 |
| dansmith | (or not do that thing) | 15:58 |
| *** xek_ is now known as xek | 15:59 | |
| efried | Well, it wasn't manual, it was 3pCI, but I never thought to check that it was running py3. | 16:00 |
| efried | Are we planning to continue supporting py2 in ussuri? | 16:00 |
| efried | the argument could be made that testing (3pCI et al) should *only* be py3 | 16:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_networks_associate' functional tests https://review.opendev.org/684338 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 16:03 |
| bauzas | mriedem: you know what ? can't confirm a resize after stopping/deleting/restarting the original compute | 16:03 |
| mriedem | that's not surprising | 16:04 |
| bauzas | mriedem: after this, I'm stopping to do this, I'll just mock out the allocation delete | 16:04 |
| bauzas | so it'll just leave the orphaned migration allocation | 16:04 |
| mriedem | bauzas: i'm assuming the failure is the same as before? or something new because on restart of the source compute service, we've created a new compute node record with a new uuid and a new resource provider and we can't cleanup the migration-based allocations b/c we're looking for the wrong provider? | 16:05 |
| bauzas | mriedem: a different exception | 16:05 |
| *** itlinux has joined #openstack-nova | 16:06 | |
| bauzas | mriedem: a conflict because we want to recreate a new RP with the same name | 16:06 |
| mriedem | do you have a paste? | 16:06 |
| bauzas | sure, sec | 16:06 |
| mriedem | nvm that's a known bug | 16:06 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1817833 | 16:07 |
| openstack | Launchpad bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 16:07 |
| mriedem | called out in https://review.opendev.org/#/c/678100/ | 16:07 |
| *** maciejjozefczyk has joined #openstack-nova | 16:07 | |
| bauzas | mriedem: http://paste.openstack.org/show/780370/ | 16:08 |
| bauzas | mriedem: anyway, like I said, I'll just mock out the allocation delete | 16:08 |
| bauzas | so once we fix the bug, we won't need to modify the functional test | 16:08 |
| bauzas | (or I'll just recreate the migration allocation) | 16:08 |
| bauzas | in order to make sure the nova-manage audit command sees it and then deletes it if asked | 16:09 |
| mriedem | i'd make sure to have a note explaining it's due to bug 1817833 | 16:10 |
| openstack | bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem) | 16:10 |
| mriedem | if you're mocking things out in a functional test | 16:10 |
| bauzas | mriedem: I'll write something and rushing to upload it, so you can provide comments | 16:11 |
| mriedem | you're assuming i'm going to review that today... | 16:12 |
| mriedem | but sure :) | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 16:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 16:12 |
| *** ociuhandu has quit IRC | 16:13 | |
| bauzas | mriedem: nah, it's 6:13pm, my wife is looking at me angrily | 16:13 |
| bauzas | mriedem: so I'll do this tomorrow morning | 16:13 |
| mriedem | i understand | 16:13 |
| bauzas | well, my wife understands more my upstream work than other folks :) | 16:14 |
| *** Sundar has joined #openstack-nova | 16:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 16:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Migrate old style volume attachments on nova-compute startup https://review.opendev.org/549130 | 16:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract some helper functions from DriverVolumeBlockDevice https://review.opendev.org/685752 | 16:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 16:24 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 16:24 |
| openstackgerrit | Merged openstack/nova-specs master: Fix invalid link index https://review.opendev.org/685664 | 16:26 |
| *** yaawang has quit IRC | 16:28 | |
| *** yaawang has joined #openstack-nova | 16:30 | |
| *** cgoncalves has quit IRC | 16:42 | |
| *** cgoncalves has joined #openstack-nova | 16:42 | |
| *** mkrai has quit IRC | 16:43 | |
| *** cgoncalves has quit IRC | 16:43 | |
| *** cgoncalves has joined #openstack-nova | 16:45 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825 | 16:45 |
| *** jaosorior has quit IRC | 16:46 | |
| openstackgerrit | Adam Spiers proposed openstack/nova stable/train: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/685756 | 16:47 |
| *** zbr|ruck is now known as zbr | 16:52 | |
| *** gbarros has quit IRC | 16:53 | |
| *** gbarros has joined #openstack-nova | 16:55 | |
| *** slaweq has quit IRC | 16:59 | |
| *** cgoncalves has quit IRC | 16:59 | |
| *** gbarros has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:00 | |
| *** cgoncalves has joined #openstack-nova | 17:00 | |
| *** cfriesen has joined #openstack-nova | 17:01 | |
| *** slaweq has joined #openstack-nova | 17:01 | |
| *** gbarros has joined #openstack-nova | 17:03 | |
| *** jmlowe has joined #openstack-nova | 17:03 | |
| efried | aspiers: RC2? ^ | 17:05 |
| efried | not clear from the bug report what actually breaks | 17:06 |
| *** igordc has joined #openstack-nova | 17:08 | |
| *** owalsh has quit IRC | 17:09 | |
| *** owalsh has joined #openstack-nova | 17:10 | |
| sean-k-mooney | efried: im guessing it breaks sev guest when you set the disk bus to scsi and select virt-scsi as the model | 17:11 |
| *** gbarros has quit IRC | 17:13 | |
| efried | sean-k-mooney: is that something that happens frequently? | 17:14 |
| sean-k-mooney | yes | 17:14 |
| *** gbarros has joined #openstack-nova | 17:14 | |
| efried | and by "breaks" -- the guest won't boot? or won't be SEV'd? or...? | 17:14 |
| sean-k-mooney | hw_disk_mode=scsi and hw_scsi_model=virtio-scsi is the recommend mode for ceph | 17:14 |
| sean-k-mooney | im not sure what aspiers is chaning is enabling the iommu integration so i would guest it unencyrped but i dont think tha tis allowd for sev guest so it might just not boot | 17:15 |
| aspiers | efried: I think it probably causes a kernel panic | 17:17 |
| sean-k-mooney | in the guest right | 17:17 |
| aspiers | from the spec: "The iommu attribute is on for all virtio devices. Despite the name, this does not require the guest or host to have an IOMMU device, but merely enables the virtio flag which indicates that virtualized DMA should be used. This ties into the SEV code to handle memory encryption/decryption, and prevents IO buffers being shared between host and guest." | 17:17 |
| *** markvoelker has quit IRC | 17:17 | |
| aspiers | I've definitely seen kernel panics from incorrectly configured guests, I can't remember if I explicitly tested virtio-scsi without iommu | 17:17 |
| aspiers | but it's required for sure | 17:17 |
| efried | k, would be good to understand all of that to know whether this should be considered critical for RC2. It sounds like it probably is. <== dansmith mriedem | 17:17 |
| sean-k-mooney | well you have to opt into enabling the scsi disk bus | 17:18 |
| efried | aspiers: imo [unencrypted when encrypted was expected] would be worse than [kernel panic] (assuming the latter is only affecting the guest, not the whole host) | 17:18 |
| *** BjoernT has quit IRC | 17:18 | |
| sean-k-mooney | since that is not the default | 17:18 |
| aspiers | sean-k-mooney: not if config drives or cdroms are used | 17:18 |
| sean-k-mooney | but it would be very common to do so if you are using ceph | 17:18 |
| efried | but either way it's a bug in a new feature and therefore RC potential IIUC | 17:19 |
| sean-k-mooney | aspiers: config drive should now defualt to sata | 17:19 |
| aspiers | efried: [unencrypted when encrypted was expected] will not happen | 17:19 |
| sean-k-mooney | and it used to default to ide | 17:19 |
| efried | well that's good anyway :) | 17:19 |
| *** ociuhandu has joined #openstack-nova | 17:19 | |
| aspiers | efried: the <launchSecurity> element will be there regardless of any iommu stuff | 17:19 |
| *** markvoelker has joined #openstack-nova | 17:20 | |
| dansmith | efried: in a sec | 17:22 |
| dansmith | mriedem: do you know if another db_sync --all-cells patch was floated somewhere? The one I was thinking of never merged and was abandoned silently in july | 17:23 |
| dansmith | mriedem: https://review.opendev.org/#/c/519275/ | 17:23 |
| dansmith | not sure why, but that probably took it off anyone's radar | 17:23 |
| dansmith | or hmm, maybe we made it hit all cells by default... gosh, all this fell out of my head | 17:24 |
| dansmith | ah, no --local-cell is just skipping cell0, so it still doesn't fan like I thought | 17:25 |
| *** maciejjozefczyk has quit IRC | 17:26 | |
| *** ociuhandu has quit IRC | 17:27 | |
| dansmith | efried: probably depends on what the fix looks like and what impacts it might have, and what the impact of not having it is (like you say expecting safe, but not safe) | 17:29 |
| sean-k-mooney | thats the main part of the fix https://review.opendev.org/#/c/684825/4/nova/virt/libvirt/designer.py | 17:30 |
| *** maciejjozefczyk has joined #openstack-nova | 17:32 | |
| sean-k-mooney | aspiers: by the way the only think that stikes me about the fix is that we are testing with a fake xml we cannot generate | 17:33 |
| mriedem | dansmith: i don't remember another, though i thought i had reported a bug at some point about making db sync support all cells but i might just be thinking of the archive command | 17:33 |
| sean-k-mooney | e.g. its not posibel to have two scsi contolers with a different model based on how nova generates the xml | 17:34 |
| dansmith | mriedem: yeah, so code in tree does not fan out (except to cell0) and that other patch got abandoned in July for some reason | 17:34 |
| sean-k-mooney | that said it is vaild in libvirt to do that | 17:34 |
| mriedem | i also remember bringing it up at some summit, i.e. should the nova-manage commands hit all cells? and it was a low priority response - that might have been sydney... | 17:34 |
| mriedem | dansmith: my guess is they abandoned it b/c it sat since july with no replies | 17:34 |
| dansmith | could be | 17:34 |
| mriedem | lincanwei is still around though, he's the watcher ptl | 17:34 |
| dansmith | oh, nm, this was abandoned in Jan, last patch was in july 2018, I see | 17:39 |
| dansmith | hmm, I thought there was a more recent attempt at this t hen | 17:39 |
| mriedem | i see a duplicate of the archive all-cells patch | 17:40 |
| mriedem | https://review.opendev.org/#/c/599050/ ? | 17:40 |
| mriedem | oh no that's different | 17:41 |
| dansmith | no | 17:41 |
| dansmith | yeah | 17:41 |
| dansmith | anyway, not a big deal | 17:41 |
| gmann | mriedem: dansmith : seems like sec groups are added for down cell response for detail GET API case only (it is not included in Show API case) | 17:41 |
| mriedem | dansmith: heh https://review.opendev.org/#/c/420973/ | 17:42 |
| mriedem | it was me! | 17:42 |
| gmann | and that is because sec grps are added explicitly for detail case- https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L410 | 17:42 |
| dansmith | mriedem: that's not the one I was thinking of, but..funny | 17:42 |
| gmann | is it missed in 2.69 microversion ? | 17:42 |
| *** gbarros has quit IRC | 17:43 | |
| gmann | with nova-net it was not added as there were no sec grp in DB nut with stephenfin patch to run sample tests with neutron fail - https://review.opendev.org/#/c/684335/5/doc/api_samples/servers/v2.69/servers-details-resp.json@12 | 17:44 |
| mriedem | it was probably an oversight | 17:45 |
| mriedem | i'm also not sure how much we need to care if the cell that the instance is in is down | 17:45 |
| gmann | and same for host_status ? | 17:45 |
| mriedem | if the cell that the instance is in is down, the host_status likely doesn't matter | 17:46 |
| mriedem | you can't do anything with that instance | 17:46 |
| mriedem | except maybe delete it | 17:46 |
| *** awalende has joined #openstack-nova | 17:46 | |
| mriedem | the whole point with 2.69 is return a minimal set of stuff based on what's in the API DB for the instance | 17:47 |
| mriedem | not to return everything we possibly can | 17:47 |
| mriedem | e.g. we could also proxy to cinder to get attached volume info but we're not going to do that (like the neutron api proxy call to get security groups) | 17:47 |
| mriedem | gmann: for host_status this method won't work really https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/compute/api.py#L4881 | 17:48 |
| gmann | yeah, it would not hurt to return. only difference will be GET and GET details response. Not sure is it worth to fix though. | 17:48 |
| mriedem | instance.host wouldn't be set so at best we'd be returning NONE which is potentially not accurate - UNKNOWN would be more appropriate | 17:49 |
| mriedem | if you're using 2.69+ and getting a repsonse from a down cell, there are already going to be a lot of differences | 17:49 |
| mriedem | for which you need to account client-side | 17:49 |
| mriedem | https://docs.openstack.org/api-guide/compute/down_cells.html gives the details on the fields that are returned | 17:50 |
| *** gbarros has joined #openstack-nova | 17:50 | |
| *** imacdonn has joined #openstack-nova | 17:50 | |
| *** awalende has quit IRC | 17:50 | |
| sean-k-mooney | aspiers: commented on https://review.opendev.org/#/c/684825/4 over all this address the reported bug but it misses another edgecase where qemu virtio channeles are not handeled | 17:52 |
| gmann | i see. then let's include in sample files as it is returned. | 17:53 |
| mriedem | gmann: sorry, what is returned? | 17:54 |
| mriedem | host_status nor security_groups are returned for GET /servers/{server_id} when the cell is down | 17:55 |
| mriedem | show and detail are different in the down cell case b/c in the detail case we won't even get to https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L146 because we will have already filtered out the instances from the down cells | 17:55 |
| gmann | mriedem: yeah but 'security_groups' are returned in GET /servers/details case | 17:55 |
| mriedem | not if the instance is in a down cell | 17:56 |
| gmann | mriedem: due to this - https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L410 | 17:56 |
| *** psachin has quit IRC | 17:56 | |
| mriedem | gmann: you will not get there with an instance from a down cell | 17:56 |
| mriedem | the multi-cell instance lister code will filter out those results | 17:56 |
| gmann | because for detail case it is added after show method return | 17:56 |
| mriedem | ... | 17:57 |
| mriedem | again, | 17:57 |
| mriedem | GET /servers/detail will filter out instances from down cells | 17:57 |
| mriedem | so we will not get to https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L410 for instances from down cells | 17:57 |
| mriedem | so i don't see the problem | 17:57 |
| mriedem | oh i think i see | 17:58 |
| mriedem | https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L396 | 17:58 |
| mriedem | self._list_view(self.show | 17:58 |
| mriedem | but still, | 17:58 |
| mriedem | instances from a down cell won't get that far | 17:58 |
| mriedem | gmann: are you just basing this on code inspection? | 17:58 |
| gmann | mriedem: this is from tests which I am not sure does actual down cell handling - https://review.opendev.org/#/c/684335/5/doc/api_samples/servers/v2.69/servers-details-resp.json | 17:59 |
| *** itlinux has quit IRC | 17:59 | |
| gmann | so instance from down-cell will be there in GET detail case or not | 17:59 |
| mriedem | will not | 18:00 |
| *** gbarros has quit IRC | 18:00 | |
| gmann | *so not sure if instance | 18:00 |
| gmann | ok | 18:00 |
| mriedem | compute API get_all will filter those out | 18:00 |
| *** jmlowe has quit IRC | 18:00 | |
| mriedem | you would need to follow this thread https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/compute/api.py#L2760 | 18:00 |
| *** gbarros has joined #openstack-nova | 18:02 | |
| gmann | but cell-down-support will be true for > 2.69 - https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/servers.py#L329 | 18:02 |
| gmann | then it will include the instances form down cell also | 18:03 |
| mriedem | no | 18:03 |
| mriedem | that's not what that means | 18:03 |
| mriedem | you need to look at the InstanceLister code | 18:03 |
| aspiers | sean-k-mooney: I've replied and emailed the SEV gurus to ask them | 18:03 |
| *** gbarros has quit IRC | 18:03 | |
| aspiers | sean-k-mooney: I would prefer to deal with that in a follow-up though | 18:03 |
| aspiers | especially considering we don't actually know for sure yet it's an issue | 18:04 |
| sean-k-mooney | yep we could | 18:04 |
| sean-k-mooney | the code as written should be correct and adress the current bug | 18:04 |
| mriedem | gmann: in here https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/compute/multi_cell_list.py#L414 | 18:05 |
| sean-k-mooney | but i think we should file a bug for the qemu-channel too | 18:05 |
| sean-k-mooney | aspiers: if ye file a bug for it im +1 i just dont want to loose track of it | 18:05 |
| sean-k-mooney | aspiers: we can always close it as invalid if its not required | 18:05 |
| *** gbarros has joined #openstack-nova | 18:06 | |
| sean-k-mooney | aspiers: did ye try to boot a vm with a spice console and sev? | 18:06 |
| aspiers | sean-k-mooney: I'll wait until the gurus respond, they're normally very fast and that can potentially save me the effort of filing | 18:06 |
| aspiers | sean-k-mooney: yes I booted with spice fine | 18:06 |
| aspiers | or at least I'm pretty sure | 18:06 |
| aspiers | I tried a lot of different combos, can't remember all the details | 18:06 |
| aspiers | definitely saw one minor virtio device without iommu | 18:07 |
| aspiers | and it didn't crash | 18:07 |
| aspiers | in fact I think I checked about that with our guru and he said don't worry about it... think it was mouse or USB input of some kind | 18:07 |
| aspiers | heading off now o/ | 18:09 |
| sean-k-mooney | aspiers: its used for spices usb fowradign support that allows usb devices to be hotpluged at runtime | 18:09 |
| sean-k-mooney | without requireing libvirt to modify the xml | 18:09 |
| sean-k-mooney | i belive it also allows spcie to do remote hotpug | 18:09 |
| sean-k-mooney | e.g. a local usb to a remove vm like RDP does with drives and printers | 18:10 |
| gmann | mriedem: thanks. that param in multi cell control only exception or skip to prepare the minimum response in APi view. | 18:15 |
| gmann | we need to mock the same in sample tests also. | 18:18 |
| *** gmann is now known as gmann_afk | 18:19 | |
| mriedem | gmann_afk: ok. there are samples for 2.69 which use a down cell fixture so maybe something is just missing from that, idk. | 18:21 |
| *** ricolin has quit IRC | 18:27 | |
| *** elod has quit IRC | 18:28 | |
| *** jmlowe has joined #openstack-nova | 18:41 | |
| *** ociuhandu has joined #openstack-nova | 18:45 | |
| *** Sundar has quit IRC | 18:53 | |
| *** maciejjozefczyk has quit IRC | 18:54 | |
| *** elod has joined #openstack-nova | 18:55 | |
| *** BjoernT has joined #openstack-nova | 18:56 | |
| mriedem | dansmith: maybe we should finally fix this :) https://bugs.launchpad.net/nova/+bug/1781286 | 18:56 |
| openstack | Launchpad bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,Triaged] | 18:56 |
| mriedem | i think it's just a matter of shoving the AZ into the Selection object that we pass around in conductor | 18:57 |
| mriedem | tricky thing is functional testing since we don't have a great way to poison conductor on a reschedule to not hit the API DB | 18:58 |
| dansmith | ack | 18:58 |
| dansmith | mriedem: in your reply you said cern is running without a superconductor.. you just mean their cell conductors have api creds right? | 18:59 |
| mriedem | yeah | 18:59 |
| mriedem | but, | 18:59 |
| mriedem | i don't think they make a distinction between a top and cell level conductor | 18:59 |
| dansmith | because unless I'm missing something, you can't not have superconductors, as you need something listening on the conductor topic that isn't going to be confused for cell traffic | 18:59 |
| dansmith | I guess you could have your apis set to penalize one cell's conductors to do the super work, if that made sense in your topology (i.e. one big cell and a bunch of smaller ones or something) | 19:00 |
| mriedem | hmm, i just assumed they were doing whatever devstack does for singleconductor | 19:00 |
| mriedem | which still has cell0 and cell1 | 19:00 |
| mriedem | right, that's what i'm assuming cern does | 19:00 |
| dansmith | well, if you do, then cell1 ends up doing all the work for cell2 for example | 19:00 |
| mriedem | or just a handful of big conductor | 19:00 |
| mriedem | we could ask them but no one in channel | 19:00 |
| *** jmlowe has quit IRC | 19:00 | |
| dansmith | for a deployment tool, they'd have to have some way of letting you pick which cell should be burdened with the extra work | 19:01 |
| dansmith | which seems less than ideal to me | 19:01 |
| mriedem | as for the console proxy auth stuff, | 19:03 |
| mriedem | https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/convert-consoles-to-objects.html | 19:03 |
| mriedem | "instead we will resolve the cell database issue by running console proxies per cell instead of global to a deployment, such that the cell database is local to the console proxy" | 19:03 |
| mriedem | i couldn't find that in our docs | 19:03 |
| mriedem | which seems...bad | 19:03 |
| mriedem | like it should be in https://docs.openstack.org/nova/latest/user/cellsv2-layout.html | 19:03 |
| mriedem | melwitt: ^? | 19:03 |
| mriedem | did the console proxy per cell thing get into the docs? | 19:03 |
| dansmith | yeah, I couldn't either, which is why I punted to her | 19:04 |
| *** ociuhandu has quit IRC | 19:04 | |
| mriedem | nothing here either https://docs.openstack.org/nova/latest/admin/remote-console-access.html | 19:04 |
| mriedem | mgoddard: when you say kolla-ansible is adding support for cells v2, you mean multiple cells specifically right? because cells v2 (cell0, cell1, mappings, etc) has been required since ocata | 19:11 |
| dansmith | mriedem: I think he said specifically adding a cell to an existing deployment | 19:12 |
| mriedem | ah yeah at the end, "I'm trying to design it such that it's possible to deploy a new cell in an existing environment" | 19:13 |
| dansmith | aye | 19:13 |
| mriedem | here is a docs bug for the console proxy per cell thing anyway https://bugs.launchpad.net/nova/+bug/1846045 | 19:18 |
| openstack | Launchpad bug 1846045 in OpenStack Compute (nova) "Docs don't mention running console proxies per cell" [Undecided,New] | 19:18 |
| *** jmlowe has joined #openstack-nova | 19:20 | |
| *** ccamacho has joined #openstack-nova | 19:22 | |
| *** luksky has joined #openstack-nova | 19:23 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 19:38 |
| *** nweinber has quit IRC | 20:01 | |
| *** markvoelker has quit IRC | 20:04 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Alt: Extract some helper functions from DriverVolumeBlockDevice https://review.opendev.org/685782 | 20:14 |
| *** markguz_ has joined #openstack-nova | 20:40 | |
| *** ralonsoh has quit IRC | 20:49 | |
| *** ociuhandu has joined #openstack-nova | 20:49 | |
| *** pcaruana has quit IRC | 20:50 | |
| *** markvoelker has joined #openstack-nova | 20:52 | |
| *** irclogbot_3 has quit IRC | 20:55 | |
| *** irclogbot_0 has joined #openstack-nova | 20:56 | |
| *** ccamacho has quit IRC | 20:57 | |
| *** irclogbot_0 has quit IRC | 21:01 | |
| *** irclogbot_1 has joined #openstack-nova | 21:02 | |
| openstackgerrit | Merged openstack/nova master: make virtual pmem feature compatible with python3 https://review.opendev.org/685593 | 21:03 |
| efried | dansmith: ^ | 21:04 |
| *** irclogbot_1 has quit IRC | 21:07 | |
| *** irclogbot_3 has joined #openstack-nova | 21:08 | |
| *** ociuhandu has quit IRC | 21:12 | |
| *** irclogbot_3 has quit IRC | 21:13 | |
| *** irclogbot_3 has joined #openstack-nova | 21:14 | |
| *** xek has quit IRC | 21:17 | |
| *** markguz_ has quit IRC | 21:18 | |
| *** irclogbot_3 has quit IRC | 21:19 | |
| *** gbarros has quit IRC | 21:19 | |
| *** irclogbot_0 has joined #openstack-nova | 21:20 | |
| *** irclogbot_0 has quit IRC | 21:25 | |
| *** irclogbot_3 has joined #openstack-nova | 21:26 | |
| *** irclogbot_3 has quit IRC | 21:33 | |
| *** BjoernT has quit IRC | 21:34 | |
| *** irclogbot_0 has joined #openstack-nova | 21:36 | |
| *** markguz_ has joined #openstack-nova | 21:39 | |
| markguz_ | Hi, Anyone know of way to group pci passthrough cards together based on a label or tagging? | 21:39 |
| markguz_ | for example. I have a compute node with 4 Identical Fiber Channel cards. 2 are connected to SAN 1 and 2 are connected to SAN 2. | 21:40 |
| markguz_ | i wanted to be able to group the cards based on what they were connected to, but so far I have not found a way of doing that | 21:40 |
| markguz_ | am i out of luck? | 21:40 |
| *** irclogbot_0 has quit IRC | 21:41 | |
| *** irclogbot_0 has joined #openstack-nova | 21:42 | |
| *** TxGirlGeek has quit IRC | 21:43 | |
| *** TxGirlGeek has joined #openstack-nova | 21:46 | |
| *** irclogbot_0 has quit IRC | 21:47 | |
| *** irclogbot_2 has joined #openstack-nova | 21:48 | |
| efried | markguz_: I defer to sean-k-mooney for all things pci alias, but yeah, I don't think you can e.g. have each of two aliases grouping together the cards on the same SAN. | 21:52 |
| *** irclogbot_2 has quit IRC | 21:53 | |
| *** irclogbot_1 has joined #openstack-nova | 21:54 | |
| markguz_ | efried: Yeah I thought maybe I could make an alias for a pci slot, but alias doesn't support it | 21:55 |
| efried | nope, only whitelist has wildcarding I think | 21:55 |
| efried | once we have placement tracking of devices, your SAN is a trait... | 21:56 |
| markguz_ | efried: and I suppose there's anyway to reference the whitelist directly in a flavor? | 21:56 |
| efried | no, the alias is the level of abstraction available to flavors. | 21:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add Selection.availability_zone field https://review.opendev.org/685807 | 21:59 |
| *** irclogbot_1 has quit IRC | 21:59 | |
| markguz_ | efried: bummer. thanks though. | 21:59 |
| *** irclogbot_0 has joined #openstack-nova | 22:00 | |
| *** irclogbot_0 has quit IRC | 22:05 | |
| *** dave-mccowan has quit IRC | 22:05 | |
| *** irclogbot_0 has joined #openstack-nova | 22:06 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 22:06 |
| *** luksky has quit IRC | 22:13 | |
| *** adriant has joined #openstack-nova | 22:14 | |
| *** slaweq has quit IRC | 22:14 | |
| *** irclogbot_0 has quit IRC | 22:15 | |
| *** irclogbot_2 has joined #openstack-nova | 22:16 | |
| *** gbarros has joined #openstack-nova | 22:22 | |
| *** rcernin has joined #openstack-nova | 22:24 | |
| *** mlavalle has quit IRC | 22:25 | |
| *** munimeha1 has quit IRC | 22:28 | |
| *** TxGirlGeek has quit IRC | 22:31 | |
| efried | mriedem: we used to have something in nova-specs that enforced conformance to the template, no?? | 22:39 |
| efried | ah, it's hidden in pep8 | 22:41 |
| *** TxGirlGeek has joined #openstack-nova | 22:42 | |
| *** mriedem has quit IRC | 22:44 | |
| *** gbarros has quit IRC | 22:45 | |
| *** mriedem has joined #openstack-nova | 22:45 | |
| *** TxGirlGeek has quit IRC | 22:55 | |
| *** markguz_ has quit IRC | 22:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' section to spec template https://review.opendev.org/685857 | 22:59 |
| *** gbarros has joined #openstack-nova | 22:59 | |
| *** tkajinam has joined #openstack-nova | 23:02 | |
| *** mriedem has quit IRC | 23:08 | |
| *** sapd1_x has joined #openstack-nova | 23:12 | |
| *** sapd1_x has quit IRC | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!