Tuesday, 2019-09-17

« Monday, 2019-09-16 Index Wednesday, 2019-09-18 »
*** markvoelker has quit IRC00:02
*** gbarros has quit IRC00:03
*** gyee has quit IRC00:14
alex_xuefried: updated https://review.opendev.org/68250900:16
zzzeeklogan-: not something ive seen before, https://dba.stackexchange.com/a/19139/81161 seems to have the best info00:17
zzzeekmax_packet_size00:17
openstackgerritBrin Zhang proposed openstack/nova-specs master: Track user_id/project_id for migrations  https://review.opendev.org/68251100:19
openstackgerritBrin Zhang proposed openstack/nova-specs master: Track user_id/project_id for migrations  https://review.opendev.org/68251100:20
openstackgerritBrin Zhang proposed openstack/nova-specs master: Track user_id/project_id for migrations  https://review.opendev.org/68251100:38
openstackgerritBrin Zhang proposed openstack/nova master: Add the maximum train flag in api version history  https://review.opendev.org/68251300:45
*** masayukig has joined #openstack-nova00:47
*** JamesBenson has joined #openstack-nova00:53
*** JamesBenson has quit IRC00:55
*** TxGirlGeek has quit IRC00:57
*** hongbin has joined #openstack-nova01:03
*** igordc has quit IRC01:08
*** BjoernT has joined #openstack-nova01:24
*** macz has quit IRC01:36
openstackgerritMerged openstack/nova master: Follow up for the bandwidth series  https://review.opendev.org/68238901:41
openstackgerritMerged openstack/nova master: Remove redundancies from AggregateRequestFiltersTest.setUp  https://review.opendev.org/68247501:41
openstackgerritMerged openstack/nova master: doc: mark the max microversion for train  https://review.opendev.org/68198201:42
openstackgerrithutianhao27 proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage"  https://review.opendev.org/68252301:56
*** markvoelker has joined #openstack-nova02:03
*** markvoelker has quit IRC02:08
*** mmethot_ has quit IRC02:11
*** mmethot_ has joined #openstack-nova02:12
*** gbarros has joined #openstack-nova02:19
*** tbachman has quit IRC02:43
openstackgerritya.wang proposed openstack/nova master: Fix typo of cpu model when check CPU compatibility  https://review.opendev.org/68226702:44
*** rajinir has quit IRC02:50
*** rajinir has joined #openstack-nova02:56
*** gbarros has quit IRC02:58
*** dave-mccowan has quit IRC03:00
*** BjoernT has quit IRC03:06
*** tbachman has joined #openstack-nova03:08
*** tbachman_ has joined #openstack-nova03:10
*** tbachman has quit IRC03:12
*** tbachman_ is now known as tbachman03:12
*** mkrai has joined #openstack-nova03:15
*** rajinir has quit IRC03:18
*** psachin has joined #openstack-nova03:22
*** ricolin has joined #openstack-nova03:22
*** rajinir has joined #openstack-nova03:24
*** mkrai has quit IRC03:26
*** hongbin has quit IRC04:01
*** ash2307 has left #openstack-nova04:05
*** hongbin has joined #openstack-nova04:08
*** tbachman has quit IRC04:09
*** hongbin has quit IRC04:10
*** etp has joined #openstack-nova04:19
*** macz has joined #openstack-nova04:28
*** ratailor has joined #openstack-nova04:29
*** ociuhandu has joined #openstack-nova04:31
*** macz has quit IRC04:33
*** ociuhandu has quit IRC04:35
*** Tianhao_Hu has joined #openstack-nova04:55
*** Tianhao_Hu has left #openstack-nova04:55
*** udesale has joined #openstack-nova05:01
*** mkrai has joined #openstack-nova05:14
*** pcaruana has joined #openstack-nova05:16
*** Luzi has joined #openstack-nova05:16
openstackgerritMerged openstack/nova master: Centralize volume create code during boot from volume  https://review.opendev.org/68237805:16
*** mkrai has quit IRC05:26
*** pcaruana has quit IRC05:29
*** boxiang has joined #openstack-nova05:47
*** zhubx has quit IRC05:47
*** adriant has quit IRC05:54
*** spsurya has joined #openstack-nova05:55
*** larainema has joined #openstack-nova06:09
*** sapd1_x has joined #openstack-nova06:19
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously  https://review.opendev.org/65196906:20
*** mjozefcz has joined #openstack-nova06:21
*** slaweq has joined #openstack-nova06:26
*** eandersson has quit IRC06:28
*** eandersson has joined #openstack-nova06:38
*** markvoelker has joined #openstack-nova06:47
*** markvoelker has quit IRC06:52
*** artom has quit IRC06:56
*** xek has joined #openstack-nova06:57
*** efried has quit IRC07:00
*** efried has joined #openstack-nova07:01
*** artom has joined #openstack-nova07:03
*** xek has quit IRC07:08
bauzasgood morning Nova07:14
gibigood morning bauzas07:18
*** ivve has joined #openstack-nova07:21
*** ratailor has quit IRC07:21
*** ratailor has joined #openstack-nova07:22
*** trident has quit IRC07:22
*** jangutter has joined #openstack-nova07:28
*** rpittau|afk is now known as rpittau07:28
*** brinzhang_ has joined #openstack-nova07:29
*** ttsiouts has joined #openstack-nova07:29
*** trident has joined #openstack-nova07:31
*** brinzhang has quit IRC07:32
*** ralonsoh has joined #openstack-nova07:33
*** brinzhang_ has quit IRC07:33
*** yingjun has joined #openstack-nova07:35
*** cervigni has quit IRC07:36
*** trident has quit IRC07:36
*** ttsiouts has quit IRC07:42
*** ttsiouts has joined #openstack-nova07:43
bauzasgibi: any change you wanna stuff me in ?07:43
*** slaweq has quit IRC07:43
*** priteau has joined #openstack-nova07:43
*** damien_r has quit IRC07:44
*** damien_r has joined #openstack-nova07:45
*** trident has joined #openstack-nova07:46
*** ttsiouts has quit IRC07:47
*** rcernin has quit IRC07:47
*** brinzhang has joined #openstack-nova07:49
*** slaweq has joined #openstack-nova07:52
gibibauzas: nothing open at the moment I'm working on to fix mriedem's comments in the bug fix https://review.opendev.org/#/c/666857/07:59
bauzasack, saw iy07:59
bauzasit*07:59
gibibauzas: I will ping you if that rework is ready08:00
bauzas++08:01
gibibauzas: do you have something I need to look at?08:01
bauzasgibi: not atm, still fixing some tests for the placement audit08:02
*** tkajinam has quit IRC08:03
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891208:06
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776508:06
*** lpetrut has joined #openstack-nova08:07
*** lpetrut has quit IRC08:08
*** ttsiouts has joined #openstack-nova08:12
*** igordc has joined #openstack-nova08:20
openstackgerritBalazs Gibizer proposed openstack/nova master: Error out interrupted builds  https://review.opendev.org/66685708:23
*** igordc has quit IRC08:28
*** derekh has joined #openstack-nova08:33
*** lpetrut has joined #openstack-nova08:39
*** lpetrut has quit IRC08:40
*** luksky has joined #openstack-nova08:44
*** lpetrut has joined #openstack-nova08:47
*** slaweq has quit IRC08:52
*** sapd1_x has quit IRC08:53
*** aloga has joined #openstack-nova08:59
*** slaweq has joined #openstack-nova09:10
*** pcaruana has joined #openstack-nova09:19
*** ratailor has quit IRC09:23
*** ratailor has joined #openstack-nova09:24
*** yingjun has quit IRC09:34
*** boxiang has quit IRC09:39
*** boxiang has joined #openstack-nova09:40
openstackgerritLee Yarwood proposed openstack/nova master: compute: Remove stale BDMs on reserve_block_device_name failure  https://review.opendev.org/68259409:41
*** bbowen_ has joined #openstack-nova09:51
*** bbowen has quit IRC09:53
*** tetsuro has joined #openstack-nova09:57
*** ttsiouts has quit IRC10:03
*** bhagyashris has joined #openstack-nova10:03
*** ttsiouts has joined #openstack-nova10:04
*** ociuhandu has joined #openstack-nova10:05
*** pcaruana has quit IRC10:07
*** dtantsur|afk is now known as dtantsur10:07
*** ttsiouts has quit IRC10:08
*** bhagyashris has quit IRC10:12
*** Luzi has quit IRC10:13
*** tetsuro has quit IRC10:20
*** tetsuro has joined #openstack-nova10:22
*** ratailor has quit IRC10:25
*** sapd1_x has joined #openstack-nova10:25
*** ratailor has joined #openstack-nova10:26
*** damien_r has quit IRC10:27
*** tetsuro has quit IRC10:27
*** Luzi has joined #openstack-nova10:29
*** luksky has quit IRC10:29
*** udesale has quit IRC10:34
*** udesale has joined #openstack-nova10:34
*** tetsuro has joined #openstack-nova10:38
*** tetsuro has quit IRC10:38
*** larainema has quit IRC10:54
*** pcaruana has joined #openstack-nova10:55
*** zhubx has joined #openstack-nova10:58
*** boxiang has quit IRC11:00
*** ttsiouts has joined #openstack-nova11:01
*** luksky has joined #openstack-nova11:05
*** rouk has quit IRC11:14
*** boxiang has joined #openstack-nova11:15
*** sapd1_x has quit IRC11:15
openstackgerritLee Yarwood proposed openstack/nova master: DNM libvirt: extract _start_heterogeneous_computes  https://review.opendev.org/68262011:15
openstackgerritLee Yarwood proposed openstack/nova master: Add regression test for bug #1843639  https://review.opendev.org/68262111:15
openstackbug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,Confirmed] https://launchpad.net/bugs/184363911:15
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration  https://review.opendev.org/68262211:15
*** zhubx has quit IRC11:18
*** ratailor has quit IRC11:27
*** ratailor has joined #openstack-nova11:27
*** brault has joined #openstack-nova11:31
*** damien_r has joined #openstack-nova11:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Error out interrupted builds  https://review.opendev.org/66685711:35
*** brault has quit IRC11:36
*** panda is now known as panda|ruck11:41
*** mkrai has joined #openstack-nova11:52
*** takamatsu has joined #openstack-nova11:53
*** mkrai has quit IRC11:53
*** mkrai_ has joined #openstack-nova11:53
*** mkrai_ has quit IRC11:56
*** mkrai has joined #openstack-nova11:56
openstackgerritIvaylo Mitev proposed openstack/nova master: VMware VMDK detach: get adapter type from instance VM  https://review.opendev.org/65373811:57
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities  https://review.opendev.org/67379011:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Add methods to detect firmware auto-selection and SB  https://review.opendev.org/68262711:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Methods to handle request for Secure Boot & non-Q35 machine types  https://review.opendev.org/68262811:58
gibimriedem, bauzas: comments fixed i  https://review.opendev.org/#/c/66685712:01
*** etp has quit IRC12:04
stephenfinefried: Are we ever going to be able to merge a patch again? :D12:05
*** jangutter_ has joined #openstack-nova12:05
*** jangutter has quit IRC12:08
* kashyap gingerly notes ... we (I) haven't done the recurring, per-cycle work of "new libvirt/QEMU version bump (with a heads-up to operators)" dance this time :-(12:09
kashyap(And remove needless compat code; we should have much less of it, though, as we've already cleaned up a good chunk of it a few months.)12:10
*** jangutter_ has quit IRC12:11
*** markvoelker has joined #openstack-nova12:11
*** shilpasd has joined #openstack-nova12:13
efriedstephenfin: appears this time it was mirror problems. But yeah, the gods really seem to hate that top pmem patch.12:17
efriedstephenfin: though mriedem and I fixed a regression from the forbidden aggs series which was causing a bunch of our failures.12:17
stephenfino rly? link?12:18
efriednow if we could just kill the innodb bug12:18
efriedstephenfin: https://review.opendev.org/#/c/682475/12:18
efriedalso a couple WIPs to poison multiple sched services from starting.12:18
sean-k-mooneykashyap: didnt we already bump to a minium of 3.0 earlier in the cycle12:19
efriedhttps://review.opendev.org/#/c/682485/ and https://review.opendev.org/#/c/682486/12:19
kashyapsean-k-mooney: We picked for Train, but we didn't pick anything for U release and gave a heads-up to the operators.12:20
stephenfinkashyap: It's not too late to do that though, right?12:20
stephenfingiven that Train hasn't gone out12:20
kashyapsean-k-mooney: No, not late :-)  I just wanted to write it out loud, so I feel compelled to do it :D12:21
kashyapI mean, stephenfin ^12:21
sean-k-mooneykashyap: we dont need to actully pick before we do the relaease. we can do it in early U12:22
kashyapstephenfin: sean-k-mooney: Right.  But the thing is - we didn't bump the version we said we will bump for Train12:23
kashyapWe gave heads-up to bump Train to these:12:24
kashyap+NEXT_MIN_LIBVIRT_VERSION = (4, 0, 0)12:24
kashyap+NEXT_MIN_QEMU_VERSION = (2, 11, 0)12:24
kashyap... in Sep 2018 (commit: 489b5f762e2c828354362667cd647086dc4eed60)12:24
stephenfinkashyap: Sounds like something you might want to bring up at the team meeting12:25
kashyapstephenfin: Think we're too late to do _that_, I suppose -- as people don't like the bump at the end of the release12:25
kashyapstephenfin: Yeah, I take full accountability of not doing it in time earlier in the release :-(  Just dropped through the cracks12:25
*** dave-mccowan has joined #openstack-nova12:25
shilpasdEric: mriedem: thanks for setUp cleanup https://review.opendev.org/#/c/682475/12:26
kashyapstephenfin: Ah, the meeting is today12:26
sean-k-mooneykashyap: i pesonally dont like that how we do the bumps in general.12:26
kashyapstephenfin: My guess: Matt(R) will (correctly) dislike it...12:26
*** pcaruana has quit IRC12:27
sean-k-mooneybut as i said we can bump early in U12:27
kashyapsean-k-mooney: Like how we announce up ahead what we'll bump in the next release, and actually bump in the said release?12:27
kashyapAny alternatives welcome :-)12:27
kashyapsean-k-mooney: Yes, early U is fine.  We've done such a thing before12:27
efriedshilpasd: yw, that would have been a tough one to spot12:27
*** openstackstatus has quit IRC12:28
*** openstack has joined #openstack-nova12:30
*** ChanServ sets mode: +o openstack12:30
*** macz has joined #openstack-nova12:31
sean-k-mooneyanyway there have been several realses in the past were we did not bump12:32
kashyapsean-k-mooney: While I have you here, can I borrow you brain for a bit more on an unrelated thing...12:32
sean-k-mooneyin fact i woudl say it more common not too looking at the table12:32
kashyapsean-k-mooney: Yep, indeed...12:33
sean-k-mooneysure12:33
*** jmlowe has joined #openstack-nova12:33
kashyapsean-k-mooney: It's the Secure Boot-related scaffolding code - I have some sketch here (and the next patch): https://review.opendev.org/68262712:33
kashyap(No tests yet, mind you)12:34
kashyapsean-k-mooney: Just want a different pair of eyes; as I'm feeling weary12:34
kashyapsean-k-mooney: The design refresher for detecting firmware auto-selection and SB-enabled OVMF is in the above commit message12:35
sean-k-mooneyno test oh easy -1 the :)12:35
kashyapsean-k-mooney: Might want to read it, when you have a block of time12:35
kashyap:D12:35
kashyapsean-k-mooney: It's Workflow -1 already12:35
*** macz has quit IRC12:36
kashyapActually, I used that commit message as "documentation" (as some of that should - I will - be added in documentation)12:36
sean-k-mooneyso  we need to eventually talk about the inter for use get_domain_caps12:36
sean-k-mooney domain_caps = self.get_domain_capabilities()12:36
sean-k-mooney        for arch in domain_caps:12:36
sean-k-mooney            for machine_type in domain_caps[arch]:12:37
sean-k-mooneyi have see that way to much12:37
kashyapsean-k-mooney: Also, see the "Firmware auto-detection in action" part in the message12:37
kashyapHmm12:37
sean-k-mooneyevery use of it i has see so far does the nested looping12:37
kashyapI might get actually get rid of one level of it at least12:37
sean-k-mooneyand i mentioned to aspires that i want too change the to take parmaters for arch and machine type optionally12:38
kashyapsean-k-mooney: Yeah, that's something I want consider12:38
kashyapI already began by taking 'arch' as the param12:38
sean-k-mooneyyes so i want to change how the fuction works12:39
sean-k-mooneyif you pass nothinbg it will work as it currently does12:39
sean-k-mooneyif you pass parmater it woul check if it in the cache and if not call libivrt with those paramater set and look it up12:39
sean-k-mooneythen cache it12:39
*** nweinber has joined #openstack-nova12:39
sean-k-mooneythe current way we use it does not actully work in all cases12:40
*** bhagyashris has joined #openstack-nova12:41
sean-k-mooneykashyap: by the way im not sure the fireware changes per machinetype12:41
kashyapYeah, I was considering the caching approach; will keep fiddling12:41
kashyapsean-k-mooney: Sorry, what do you mean?12:41
sean-k-mooneywell at least on x86 you use the same uefi firmware image for both pc and q3512:42
kashyapsean-k-mooney: You mean the firmware values returned ("uefi" / "bios") won't change per machine type?12:42
sean-k-mooneyyes12:42
sean-k-mooneythey might12:42
sean-k-mooneybut then dont on x86 anyway as far as i know12:43
kashyapFor UEFI boot, q35 is mandatory; see the next patch, please, where we handle it12:43
sean-k-mooneyno its not12:43
sean-k-mooneyat least libvirt does not require that12:43
*** ratailor has joined #openstack-nova12:43
kashyapHmm, /me tries :-)12:44
*** damien_r has quit IRC12:45
*** damien_r has joined #openstack-nova12:45
kashyapModifying existing SB-enabled VMs to 'pc' is not a good idea; as the entire PCIe topo needs to change, etc.  Will test on a diff. box later today12:50
sean-k-mooneysecure boot wont work for pc12:51
sean-k-mooneybut uefi should12:51
sean-k-mooneyimy trying it locally too12:51
sean-k-mooneybut im pretty sure i have done this in the past12:51
kashyapRight, please try it.  (Yeah, that's for sure: SB won't of course work for 'pc')12:51
kashyapBut I'm also 99.9999981% sure, UEFI with OVMF won't work with 'pc'12:51
sean-k-mooneyit boots with a black scree and 100% cpu usage so it does not look like its that happy12:53
sean-k-mooneythat said i am pretty sure i did use uefi with pc machine type in the past12:53
kashyapYep.  OVMF is 'q35' only12:53
sean-k-mooneymaybe it was a different firmware image12:54
kashyapI bet euros-to-croissants12:54
kashyapsean-k-mooney: Thanks for the eyes so far.12:56
*** pcaruana has joined #openstack-nova12:59
*** shilpasd has left #openstack-nova12:59
*** shilpasd has joined #openstack-nova12:59
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.opendev.org/68263713:01
*** HagunKim has quit IRC13:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next  https://review.opendev.org/66987913:05
*** mriedem has joined #openstack-nova13:05
*** ratailor has quit IRC13:08
*** mdbooth has joined #openstack-nova13:11
*** mkrai has quit IRC13:15
*** mkrai has joined #openstack-nova13:17
gibimriedem: fixed your nits in ^^13:17
gibimriedem: and also in https://review.opendev.org/#/c/66685713:18
gibiahh you already hit the heal port patch, thanks for that13:18
*** damien_r has quit IRC13:19
openstackgerritMatt Riedemann proposed openstack/nova master: Only allow one scheduler service in tests  https://review.opendev.org/68248613:20
*** gbarros has joined #openstack-nova13:21
mriedemoh no a full rebase on 66685713:21
mriedemmeans i can't diff to PS713:21
mriedemwhy gibi why13:21
gibimriedem: there is a separate ps for the rebase but yeah I screewed up the order of those actions :/13:22
gibisorry13:22
gibiI should have pushed the fix then the rebase13:22
*** belmoreira has joined #openstack-nova13:23
bauzasI leave it here on purpose :) https://sbauza.wordpress.com/2014/11/14/how-to-compare-2-patchsets-in-gerrit/13:23
bauzas(pretty old but still accurate :) )13:24
sean-k-mooney bauzas gitreview -m does not always work13:24
*** eharney has joined #openstack-nova13:24
sean-k-mooneyyou need to do a 4 way diff13:25
sean-k-mooneywhich i think is what you came up with later13:25
bauzassean-k-mooney: this post was made in 201413:25
bauzas(and then I stopped writing stupid things)13:26
sean-k-mooneyvimdiff <(git diff ${MY_PS1_BRANCH}^ ${MY_PS1_BRANCH}) <(git diff ${MY_PS2_BRANCH}^ ${MY_PS2_BRANCH})13:27
sean-k-mooneyis bassicaly a 4 way diff13:27
sean-k-mooneyso that will do what you want and eliminate rebase changes13:27
*** gbarros has quit IRC13:27
*** pcaruana has quit IRC13:28
sean-k-mooneyi kind of want to add that to git review at some point13:29
sean-k-mooneythat said i more want it to be in gerrit which is thould be if/when we upgrade the openstack gerrirt to the polomer ui13:30
bauzassean-k-mooney: yeah, true and false, it's a diff of diffs13:30
sean-k-mooneyyes13:31
bauzasI just use vimdiff because the UI makes the diff most easier to read and catch the differences13:31
sean-k-mooneyi dont use vimdiff but i like meld13:31
bauzasbut you could technically stick with diff (with -y, side-to-side) and just grep a few things13:31
stephenfinsean-k-mooney: They won't accept it13:31
sean-k-mooneyi rarely use it but when i do it works well13:32
stephenfinThey being infra13:32
sean-k-mooneystephenfin: why not13:32
stephenfinSomething about git-review being a dead simple tool that shouldn't grow any additional functionality13:32
stephenfinwhich I kind of get13:32
bauzasmeld works too, I mean litterally any decent editor that supports merge diffs13:32
sean-k-mooneyit already has -m13:32
stephenfinit probably shouldn't have that13:32
bauzas-m has a very different behaviour13:32
sean-k-mooneyif you dont do the rebase in -m its the same13:33
bauzasthe 'if' makes the difference13:33
sean-k-mooneyas you said -m rebase both to master to elimitate the need to diff diffs13:33
sean-k-mooneybut both are trying to do the same thing13:33
sean-k-mooneyelimiate chagne that are not part of your actual patch13:34
bauzascorrect but then you have to handle merge conflicts if they occur13:34
bauzasthat's unnecessary work on my opinion13:34
sean-k-mooneyyes whcih is why i dont like how -m works13:34
sean-k-mooneyyep13:34
bauzasanyway13:35
bauzasjust saying13:35
bauzasthis is a problem I've seen from 6 years ago, I bet someone would have come up with some stuff in git review if infra was happy with13:36
mriedemgibi: ok comments in https://review.opendev.org/#/c/666857/13:36
gibimriedem: looking13:36
stephenfinsean-k-mooney: does glance have documentation for flavor extra specs?13:37
bauzassnap, mriedem beated me13:37
mriedemstephenfin: flavors != glance13:37
mriedemyou mean image properties?13:37
mriedemhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html13:37
sean-k-mooneystephenfin: it has metadefs for them13:37
stephenfinmriedem: Nope, flavor extra specs. I know it's not their domain but sean-k-mooney had mentioned some about flavor definitions in glance before13:38
mriedemit has metadefs for image properties13:38
sean-k-mooneyand it has the image properties that mriedem linked13:38
mriedemnot flavor extra specs13:38
*** macz has joined #openstack-nova13:38
*** Luzi has quit IRC13:38
sean-k-mooneyyes they do13:38
sean-k-mooneythe metadefs cover flavors image and host agrrates metatdata13:38
sean-k-mooneyhttps://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt.json#L9-L1413:39
sean-k-mooneyits where all the documenation in glance and heat comes form for those values13:39
sean-k-mooney*horizon and heat13:40
mriedemhuh13:40
mriedemi found https://github.com/openstack/glance/blob/master/etc/metadefs/compute-trust.json which we removed that filter from nova years ago...so it's good to know the information about this stuff is in glance and is stale13:40
sean-k-mooneyhorizon and heat both autogenerat  there ui from the glance metadef api13:41
sean-k-mooneyyes i have been slowly trying to update it every now and then13:41
sean-k-mooneyi would like to bring it fully up to date envtually13:41
stephenfinIMO those definitions should live in nova and be thrown across the wall on a regular cadence to glance13:41
* stephenfin is reproposing the extra spec validation RFE13:42
sean-k-mooneythey should live in a seperate project that is not part of either13:42
sean-k-mooneybut use by all services13:42
stephenfinor we could just expose it via an API that glance could consume?13:42
sean-k-mooneyglance currentlly is our metadata defintion store/repositroy13:42
sean-k-mooneyglance already exposes this via an api13:43
*** psachin has quit IRC13:43
sean-k-mooneythat others consume13:43
*** macz has quit IRC13:43
sean-k-mooneywe coudl move to all service exposing the same api13:43
openstackgerritEric Fried proposed openstack/nova master: DNM: Try to repro bug 1823251 with mysql logs  https://review.opendev.org/67805113:43
openstackbug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/182325113:43
sean-k-mooneye.g. have a /metadefs on each service but really this shoudl be its own serivice or stay in glance13:43
sean-k-mooneyhaveing all serivice provide an identical api would only really work if we had a lib with the api defintion and each service just kept the data in the repo13:45
stephenfinidk, clearly having our definitions live in another service is an issue13:48
sean-k-mooneywell we define image properties that belong to glance in our ovos13:48
stephenfinand I'm not sure using an external library is an option since that means only official extra specs can be used13:48
sean-k-mooneyif you take that route we shoudl not be doing that either13:48
sean-k-mooneystephenfin: no it doesnt13:49
sean-k-mooneythe metadefs can be exetended by operators or distors13:49
sean-k-mooneyyou simply add entires to the files13:49
sean-k-mooneyor new files13:49
stephenfinactually, we already figured this out13:50
sean-k-mooneyso we can take the same data driven approch or we can define a custom_ prefix or seveler other thigns13:50
stephenfinstevedore13:50
sean-k-mooneyin the spec we figured out how to use stevedore13:50
sean-k-mooneyya13:50
*** BjoernT has joined #openstack-nova13:50
stephenfinyeah, glance can just hook into that like we do13:51
stephenfineasy as13:51
sean-k-mooneynot really13:51
sean-k-mooneythis is an api that has existed for 6+ years13:51
sean-k-mooneyand other pojects depend on it13:51
stephenfinthey can keep the API13:52
sean-k-mooneyyes but unless we can expose our flavor form it13:52
sean-k-mooney*flavor extra specs via the new mechanisum at the metadefs endpoin im not sure going our own way is good13:53
stephenfinIt should be easy do13:53
sean-k-mooneystevador only works if everythign is installed in teh same place13:53
sean-k-mooneyin contienr it wont work13:53
stephenfinIf they can pull our definitions in, they just need to transform them so they match whatever we had before13:54
stephenfinthen we provide a tool to dump in their JSON metadef style13:54
stephenfinand push a patch to Glance13:54
sean-k-mooneyya bout you would have have to install nova in the glance contienr13:54
sean-k-mooneythats not good13:54
stephenfinbetter than what we have at the momenty13:55
sean-k-mooneyhavign a nova tool to generate teh metadefs and copy it could work13:55
stephenfinoh, I thought you meant the tool13:55
sean-k-mooneyno i ment stevadore13:55
*** xek has joined #openstack-nova13:56
sean-k-mooneystevador was a suggestion for other project to add validtors13:56
sean-k-mooneyto nova13:56
stephenfinYup, gotcha. My bad13:56
sean-k-mooneynot to share data to other projects13:56
mriedembelmoreira: this might have an impact to compute start times when using the ironic driver https://review.opendev.org/#/c/666857/13:56
mriedembelmoreira: so if you have suggestions about what definitely not to do there it would be appreciated13:56
sean-k-mooneyit wouldnt be nova-mange but a nova-metadefs tool or something could be used to do an export i guess13:56
mriedembelmoreira: specifically https://review.opendev.org/#/c/666857/9/nova/compute/manager.py@132913:57
*** pcaruana has joined #openstack-nova13:59
belmoreiramriedem thanks for ping me14:01
openstackgerritEric Fried proposed openstack/nova master: Only allow one scheduler service in tests  https://review.opendev.org/68248614:02
*** munimeha1 has joined #openstack-nova14:04
openstackgerritStephen Finucane proposed openstack/nova-specs master: Re-propose the flavor extra spec validation spec  https://review.opendev.org/68265514:04
efriedmriedem: Re test_walk_versions, when I tried turning those debug conf switches on I wound up with enough data to blow up subunit. So I reinstrumented the logging fixture to write to a file in /var/log/mysql (to save me having to capture yet another directory). In local experimentation, that's about 35MB...14:07
*** mdbooth has quit IRC14:07
efried(that's with the sqlite impl tho)14:08
*** mdbooth has joined #openstack-nova14:09
efriedI also knocked the timeout factor back down to 1 to improve chances of hitting the bug... although I'm not actually convinced that's going to make the difference.14:09
*** JamesBenson has joined #openstack-nova14:09
*** larainema has joined #openstack-nova14:09
*** rpittau is now known as rpittau|afk14:10
bhagyashrismriedem: Hi,14:12
openstackgerritBalazs Gibizer proposed openstack/nova master: Error out interrupted builds  https://review.opendev.org/66685714:17
gibibauzas, mriedem: ^^14:17
bauzasgibi: I need to go to the school to get my children but I'll look at ^ after14:18
gibibauzas: thanks14:18
sean-k-mooneystephenfin: i have a scoping question for you and i guess to nova in general. should the scope of os-vif be expaned to include the neutron related pices of nova/networks/*14:20
stephenfingive me an example14:20
sean-k-mooneywell im wondering if we shoudl move https://github.com/openstack/nova/tree/master/nova/network/neutronv214:21
sean-k-mooneyos-vif is often incorrectly refered to as the nova neutron interface lib14:21
sean-k-mooneyimplying its used to handel the comunicaiton between nova and neutron14:22
sean-k-mooneybut its actully not14:22
sean-k-mooneyi was wondering if we finally remove nova-networks shoudl we move the neutron interaction code to os-vif14:22
stephenfinhmm, not a bad idea14:22
sean-k-mooneygive the nova core team are os-vif cores it would not realy change that aspect14:23
sean-k-mooneybut it would make os-vif more like os-bricks14:23
stephenfinI'd probably need to see some patches before I can make any verdict though, tbh14:23
stephenfinand get nova-network removed, heh14:23
openstackgerritEric Fried proposed openstack/nova master: DNM: Get rid of 'Aborted connection' mysql errors  https://review.opendev.org/68266114:23
sean-k-mooneyya its just something i was thinking about over the weekend14:23
efriedzzzeek: ----^14:23
*** mlavalle has joined #openstack-nova14:24
efriedand mriedem14:24
sean-k-mooneystephenfin: we still tecnically support drivers in nova for the networking laywer14:24
sean-k-mooneystephenfin: so i was thinking of porting using that14:24
*** lbragstad_ has joined #openstack-nova14:26
*** lbragstad has quit IRC14:28
mriedemlyarwood: melwitt: just fyi i'm planning on doing stable branch reviews throughout this week to prepare for some releases next thursday (next week) to coincide with RC1 on master14:29
*** mkrai has quit IRC14:29
bhagyashrisefried, mriedem: Hi I would like you insight on https://review.opendev.org/#/c/612626/ . Address all the review commets.14:35
bhagyashriss/you/your14:36
*** gbarros has joined #openstack-nova14:42
*** BjoernT has quit IRC14:42
*** TxGirlGeek has joined #openstack-nova14:44
*** FlorianFa has quit IRC14:44
*** TxGirlGeek has quit IRC14:44
*** TxGirlGeek has joined #openstack-nova14:45
*** BjoernT has joined #openstack-nova14:45
efriedbhagyashris: I can take a look, but this isn't my area of expertise.14:47
efriedbhagyashris: I also suspect a db change is going to be too high-risk for us to land in Train at this point.14:48
*** dtantsur is now known as dtantsur|afk14:52
*** mkrai has joined #openstack-nova14:53
*** ttsiouts has quit IRC14:55
*** pcaruana has quit IRC14:55
*** ttsiouts has joined #openstack-nova14:55
*** TxGirlGeek has quit IRC14:59
*** ttsiouts has quit IRC14:59
sean-k-mooneymriedem: by the way when i was working on https://review.opendev.org/#/c/682515/ i notice the sqlalchemy-migrate does not use upper constratins and test fail if i add it15:00
sean-k-mooneyi need to look at why those py27 test failed too i only ran the sqlite test locally so i guess i missed somthing15:01
sean-k-mooneybut shoudl sqlalchemy use upper-constraints or is it intentionally not?15:01
*** mkrai has quit IRC15:01
*** mkrai_ has joined #openstack-nova15:01
*** ttsiouts has joined #openstack-nova15:03
sean-k-mooney*sqlalchemy-migrate15:06
* bauzas runs errand now15:07
*** udesale has quit IRC15:08
*** luksky has quit IRC15:11
*** lpetrut has quit IRC15:12
*** sapd1 has quit IRC15:14
*** sapd1 has joined #openstack-nova15:15
*** gbarros has quit IRC15:21
*** lbragstad_ is now known as lbragstad15:23
*** ivve has quit IRC15:27
*** boxiang has quit IRC15:27
*** boxiang has joined #openstack-nova15:28
melwittmriedem: ack15:31
*** gyee has joined #openstack-nova15:32
*** CeeMac has joined #openstack-nova15:35
*** tbachman has joined #openstack-nova15:37
shilpasdefried: on behalf of bhagyashris, it will be great help if we target this in Train15:54
efriedmriedem: Is it feasible to merge db changes at this stage? https://review.opendev.org/#/c/612626/15:55
*** jmlowe has quit IRC15:55
sean-k-mooneyefried: technically before rc1 its doable15:56
sean-k-mooneyjust clicking the link15:56
sean-k-mooneybut what db changes are needed15:56
*** ttsiouts has quit IRC15:57
sean-k-mooneyshilpasd: usein "is" for boolean comparison is deprecated by the way15:57
sean-k-mooneyso we shoudl not do  "if instance.is_volume_backed is False:"15:57
*** ttsiouts has joined #openstack-nova15:58
efriedI guess it doesn't have db changes15:58
sean-k-mooneythis is technically an api change however right15:58
sean-k-mooneyso it would have a micro version bump?15:58
sean-k-mooneywe would be changng the semantics of the api15:59
efriedyeah, I guess that's technically true.16:00
*** mdbooth has quit IRC16:01
mriedemthat's not an api change really16:01
mriedemit's saying, don't count disk usage for servers tha tare volume-backed16:01
shilpasdsean-k-mooney: thanks for points, request you to add same on patch, so that will be addressed and tracked16:01
mriedemefried: i would not rush that into train16:01
sean-k-mooneymriedem: yes16:01
mriedemi would also split it into at least 2 patches, one that introduces the db api changes for the is_volume_backed stuff so that can be reviewed and tested separately16:01
sean-k-mooneyand before it did so is that not an api change because the value now has a different meaning16:02
mriedembecause it involves sqla magic16:02
mriedemand therefore will need scrutiny16:02
efriedbhagyashris, shilpasd: ^16:02
*** ttsiouts has quit IRC16:02
shilpasdmriedem: efried: understood16:02
mriedemsean-k-mooney: consider that in rocky (i think it was) we fixed scheduling and the resource tracker to not request disk for volume-backed servers,16:02
sean-k-mooneypeople keep telling me there is a reason we allow bfv instance to have a root_gb!=016:03
mriedemwhich would indirectly cause the os-hypervisors API to no longer report disk usage for those volume-backed servers,16:03
mriedemso yes it changes the api behavior, but it's fixing latent busted behavior16:03
sean-k-mooneysure16:03
sean-k-mooneybut im wonder ing why we allow bfv guests to have a root_gb set to non 0  in general16:03
mriedemwe don't by default policy anymore16:04
sean-k-mooneywe dont allow non bfv flavor with root_gb=016:04
mriedemsee os_compute_api:servers:create:zero_disk_flavor16:04
sean-k-mooneyi think that is only in the ohter direction16:04
mriedemhttps://docs.openstack.org/nova/latest/configuration/policy.html16:04
* sean-k-mooney clicks16:04
*** mkrai_ has quit IRC16:04
mriedemand sqla-migrate doesn't use upper-constraints because...it's never needed to16:05
sean-k-mooneyya that is not what im asking16:05
mriedemit hardly changes, is released like once per year16:05
sean-k-mooneymriedem: ok16:05
sean-k-mooneyill remove the todo16:05
sean-k-mooneythe one i was adding16:05
mriedemsean-k-mooney: also https://review.opendev.org/#/c/669738/16:06
sean-k-mooneyso that policy flag prevent instace with root disk = 0 if they are not bfv16:06
openstackgerritBalazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host  https://review.opendev.org/68268016:06
mriedemcorrect16:06
shilpasdmriedem: what is  sqla-migrate?16:06
sean-k-mooneybut we dont have a simplar policy for the oppisite16:06
mriedemsqlalchemy-migrate16:07
sean-k-mooneye.g. prevent bfv instance using a flavor with root_gb!=016:07
shilpasdohh, tnx, got it16:07
sean-k-mooneythat is the policy i think we should consider adding16:07
mriedemso you want to force all deployers to duplicate all of their flavors?16:07
sean-k-mooneythe main objection i have heard to that is requireing two sets of flavor. 1 for bfv and 1 for non bfv16:08
mriedemi would not do that without some additional feature to make bfv simpler with volume-defined flavors or something16:08
mriedemhttps://review.opendev.org/#/c/511965/16:08
mriedemlet's just do that in V16:09
mriedemV for Volumessssss16:09
* mriedem goes to lunch16:09
sean-k-mooneywell it woudl be a policy flag taht coudl default to false so not force them but im not sure how common it is to mix bfv and non bfv on the same host16:09
*** mriedem is now known as mriedem_afk16:09
sean-k-mooneyi got the impression people tend to segration the bfv hosts form the rest but i could be wrong16:09
shilpasdmriedem: sean-k-mooney: it will be great help, if you add review comments on patch so that can be addressed appropriately https://review.opendev.org/#/c/612626/16:11
sean-k-mooneymriedem_afk: oh thanks for reviewig the config drive stuff ill fix that up16:12
openstackgerritMerged openstack/nova master: Remove SchedulerReportClient from AggregateRequestFiltersTest  https://review.opendev.org/68248016:14
openstackgerritMerged openstack/nova stable/stein: Remove descriptions of nonexistent hacking rules  https://review.opendev.org/67969516:14
*** mdbooth has joined #openstack-nova16:17
sean-k-mooneyefried: stephenfin do either of ye have the rc bug etherpad link16:21
efriedhttps://etherpad.openstack.org/p/nova-train-release-todo ?16:21
sean-k-mooneyyes that one16:21
sean-k-mooneyefried: https://review.opendev.org/#/c/669738/4 would be a regression in train if we dont land it in the rc16:21
efriedsean-k-mooney: ack16:22
efriedmake sure mriedem_afk is aware16:23
sean-k-mooneyefried: he is16:23
sean-k-mooneyim going to address his review feedback now16:23
sean-k-mooneywe "fixed" https://bugs.launchpad.net/nova/+bug/182749216:23
openstackLaunchpad bug 1827492 in OpenStack Compute (nova) stein "vms failed to hard reboot and became error after set force_config_drive in compute nodes" [Low,In progress] - Assigned to Lee Yarwood (lyarwood)16:23
sean-k-mooneyand intoduced https://bugs.launchpad.net/nova/+bug/183582216:23
openstackLaunchpad bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] - Assigned to sean mooney (sean-k-mooney)16:23
*** derekh has quit IRC16:41
zzzeekefried: how does that huge amount of change in the .zuul.yaml file relate to the extra config variable being set ?16:43
efriedzzzeek: It just restricts the run to only do unit tests, and gather logs from the mysql dir16:44
efriedzzzeek: if we end up doing this irl we'll revert that bit and just keep the test setup bit.16:44
zzzeekefried: oh ok16:45
zzzeekefried: well great, see if it fixes those errors16:45
efriedThe extra zuul job (*collect) is to actually grab the logs so we can make sure this works. The removals is just so we don't waste the gate resources on the other test jobs.16:45
efriedzzzeek: thanks for the pointer!16:45
*** luksky has joined #openstack-nova16:50
sean-k-mooneyefried: i just commented on the mail but could the mysql issues be related too the the rabbit mq issue we have in the api16:51
sean-k-mooneye.g. could it be cause by eventlet and running multiple thread in the wsgi server16:52
sean-k-mooneyim not sure if this is happeng in the gate or not16:52
sean-k-mooneyif its in the gate then no16:52
efriedsean-k-mooney: I have no. freaking. clue. If you can solve this one, I will buy you cookies forever.16:52
*** brault has joined #openstack-nova16:52
efriedit's happening in the gate, yeah.16:52
sean-k-mooneyok in the gate we hard code one thread i think16:52
sean-k-mooneybut ill check16:52
efriedwait16:52
efriedwe're talking about different issues, sorry.16:53
efrieddisregard cookie promise16:53
sean-k-mooneyis was talking about  RE: [oslo][nova] Nova causes MySQL timeouts16:53
efriedcookie promise applies to http://bugs.launchpad.net/bugs/182325116:53
openstackLaunchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed]16:53
sean-k-mooneywhich i assme is what you and zzzeek were talking about?16:53
efriedno, zzzeek and I were talking about ----^16:53
sean-k-mooneyah ok16:53
*** pcaruana has joined #openstack-nova16:55
*** zhubx has joined #openstack-nova16:57
*** nweinber has quit IRC16:58
*** nweinber has joined #openstack-nova16:59
*** boxiang has quit IRC17:00
*** nweinber has quit IRC17:02
*** nweinber has joined #openstack-nova17:03
*** brault has quit IRC17:10
*** bhagyashris has quit IRC17:13
efriedsean-k-mooney: oh, it looks like it may actually be the same thing zzzeek and I were talking about.17:16
*** ralonsoh has quit IRC17:16
efriedwhich kind of forked off of the test_walk_versions thing.17:16
sean-k-mooneythe mysql timeouts17:17
sean-k-mooneyso i was wondering if it could be related to eventlet in genreal17:17
sean-k-mooneyconnection pooling might not play nicely with evnetly monkey patching when don in a wsgi envionment17:18
sean-k-mooneyor rather a mod_wsgi or uwsgi env17:18
sean-k-mooneythat said if it was an eventlet issue i dont think it would affect the test_walk_versions stuff17:19
efriedsean-k-mooney: it may be entirely unrelated to the gate timeout in those tests. But I'm seeing it in the mysqld logs for those tests (whether they pass or fail). So, can't hurt to get rid of them, nah?17:21
sean-k-mooneywell i thik fixing mysql issue in general is a good thing17:23
sean-k-mooneyjust not sure as you said fi they are releated or not17:24
openstackgerritFrançois Palin proposed openstack/nova master: Add retry when attachment_delete or terminate_connection fails  https://review.opendev.org/66967417:25
*** jmlowe has joined #openstack-nova17:25
*** ociuhandu has quit IRC17:25
*** priteau has quit IRC17:32
*** shilpasd has quit IRC17:43
*** ociuhandu has joined #openstack-nova17:44
*** ociuhandu has quit IRC17:48
openstackgerritsean mooney proposed openstack/nova master: make config drives sticky bug 1835822  https://review.opendev.org/66973817:51
openstackbug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney)17:51
mriedem_afksean-k-mooney: i tagged the bug so we won't forget about it https://bugs.launchpad.net/nova/+bugs?field.tag=train-rc-potential17:52
donnydI fixed my mysql issues by removing the ulimits in systemd for the service17:52
sean-k-mooneymriedem_afk: i added it to the etherpad17:52
*** mmethot_ has quit IRC17:53
donnydprobably a better answer out there... but i haven't ran into it again17:53
sean-k-mooneymriedem_afk: i think i have done the things you asked for17:53
*** mmethot_ has joined #openstack-nova17:53
*** mriedem_afk is now known as mriedem17:53
sean-k-mooneyah i see you are using launchpad to track the rc potentail bugs ya that is better17:54
sean-k-mooneyim going to grab food but ill asress your comments in the devname patch when i get back17:55
*** tbachman has quit IRC18:01
*** tbachman has joined #openstack-nova18:01
*** nweinber has quit IRC18:01
*** jmlowe has quit IRC18:02
mriedemsean-k-mooney: https://review.opendev.org/#/c/669738/518:05
*** igordc has joined #openstack-nova18:16
*** tbachman has quit IRC18:26
*** ricolin has quit IRC18:28
*** jmlowe has joined #openstack-nova18:32
efrieddonnyd: Were they the same mysql issues we've been discussing?18:37
*** henriqueof has joined #openstack-nova18:38
efriedI sort of doubt it would be a problem to remove ulimits on CI nodes?18:38
*** brault has joined #openstack-nova18:42
*** hemna_ is now known as hemna_afk18:43
donnydyea it was pretty close to the same issue18:47
donnydmy load is different... but I just didn't want to hear any guff from mariadb18:47
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: lxc: make use of filter python3 compatible  https://review.opendev.org/67649818:48
donnydwoot woot LXC18:48
*** tbachman has joined #openstack-nova18:49
*** ociuhandu has joined #openstack-nova18:52
*** xek_ has joined #openstack-nova18:54
sean-k-mooneydonnyd: you will like this then https://review.opendev.org/#/c/667976/18:56
donnydYESSSS sean-k-mooney18:56
*** ociuhandu has quit IRC18:56
sean-k-mooneyi think i said this becore but we need to fix the console and resizeing of the root file system bit it more or less works18:57
donnydI am unreasonably pumped for LXC support... I think it works great and can't wait18:57
*** xek has quit IRC18:57
sean-k-mooneywell we supported  lxc years ago18:57
sean-k-mooneyits just has not been maintianed18:57
sean-k-mooneybut i would like to see it working again18:57
sean-k-mooney*fully working again18:58
donnydI know... and it worked great... LXC can support a large number of workloads and its heavily underused by those who just don't know... I use it every day18:58
* donnyd stands up to clap for the LXC's18:59
sean-k-mooneymy main issue with lxc was the lack of a good way to build images for it18:59
donnydi think distrobuilder is growing18:59
sean-k-mooneyi first start to use docker when it use the lxc backend18:59
donnydthere a quite a few image types available in there now18:59
sean-k-mooneyand that was perfoect form me18:59
*** Sundar has joined #openstack-nova19:01
*** mjozefcz has quit IRC19:05
*** jmlowe has quit IRC19:08
*** brault has quit IRC19:16
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Drop source node allocations if finish_resize fails  https://review.opendev.org/68272219:19
donnydI see nothing wrong with  LXC19:23
donnydand additionally there are solid examples of people using it for prod workloads...It also makes me happy to see some work going into lxc to make it work again... Many thanks19:25
*** brault has joined #openstack-nova19:26
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Add functional recreate test for regression bug 1825537  https://review.opendev.org/68272519:31
openstackbug 1825537 in OpenStack Compute (nova) queens "finish_resize failures incorrectly revert allocations" [Medium,In progress] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem)19:31
*** brault has quit IRC19:32
*** mmethot_ has quit IRC19:37
*** mmethot_ has joined #openstack-nova19:37
*** dtruong has quit IRC19:40
*** dtruong has joined #openstack-nova19:40
*** mmethot_ has quit IRC19:40
*** mmethot_ has joined #openstack-nova19:41
*** priteau has joined #openstack-nova19:46
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Changing scheduler sync event from INFO to DEBUG  https://review.opendev.org/66912719:46
*** spsurya has quit IRC19:48
*** jmlowe has joined #openstack-nova19:48
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor pre-live-migration work out of _do_live_migration  https://review.opendev.org/64145319:49
*** larainema has quit IRC19:59
*** sean-k-mooney has quit IRC20:17
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor volume connection cleanup out of _post_live_migration  https://review.opendev.org/68274120:20
*** Sundar has quit IRC20:20
*** sean-k-mooney has joined #openstack-nova20:25
*** priteau has quit IRC20:28
*** panda|ruck is now known as panda|ruck|off20:29
*** mriedem has quit IRC20:32
*** mriedem has joined #openstack-nova20:32
gyeeif the given vm is using pci passthrough, is resizing to the same host allowed or disallowed?20:36
*** BjoernT_ has joined #openstack-nova20:37
*** BjoernT has quit IRC20:38
*** zhubx has quit IRC20:41
*** BjoernT_ is now known as bjoernT20:41
*** bjoernT is now known as BjoernT20:41
*** boxiang has joined #openstack-nova20:41
*** mjozefcz has joined #openstack-nova20:43
*** trident has quit IRC20:48
*** brault has joined #openstack-nova20:48
*** mmethot_ has quit IRC20:48
*** mmethot has joined #openstack-nova20:49
*** brault has quit IRC20:52
artommriedem, left a question in https://review.opendev.org/#/c/682741/120:52
artomFigured it's more polite to ask on IRC than -1 the thing (even if that's what I initially did)20:53
*** ociuhandu has joined #openstack-nova20:53
*** mmethot has quit IRC20:53
*** mmethot has joined #openstack-nova20:54
*** mjozefcz has quit IRC20:55
*** mmethot has quit IRC20:55
*** luksky has quit IRC20:55
*** eharney has quit IRC20:55
*** mmethot has joined #openstack-nova20:55
*** brault has joined #openstack-nova20:57
*** pcaruana has quit IRC20:58
*** gbarros has joined #openstack-nova20:59
*** trident has joined #openstack-nova21:00
*** brault has quit IRC21:01
openstackgerritAkihiro Motoki proposed openstack/nova master: doc: Improve PDF document structure  https://review.opendev.org/68274621:02
mriedemreplied21:06
artomCheers21:07
*** slaweq has quit IRC21:10
*** slaweq has joined #openstack-nova21:11
*** gbarros has quit IRC21:12
mriedemgyee: resize on the same host with pci passthrough should work but there is no integration testing for it, if there are limitations sean-k-mooney might be aware of them21:13
*** mmethot has quit IRC21:13
*** mmethot has joined #openstack-nova21:14
mriedemi could see the code not being so smart and realizing that if pci devices in the flavor have not changed and we're resizing on the same host that we don't need to re-claim them21:14
gyeemriedem, if the host has one PCI card, I am guessing we can't resize and it has already claimed21:15
gyeebut I am not too sure, have had time to dive into the code yet, was hoping for a quick yes or no answer :-)21:15
mriedemi don't have that code memorized so i can't say off the top of my head21:16
*** slaweq has quit IRC21:16
mordredmriedem: I'm very disappointed that you don't have it memorized21:17
mriedemi'm not21:17
gyeeI see this in the logs "nova-scheduler.log:2019-09-17 19:41:34.269 31312 DEBUG nova.scheduler.filters.pci_passthrough_filter [req-9165ec70-88b2-4ce1-804b-ee28d7c1992c c6d51320a59041588a26477c64ec0973 d35583e194d845b79aaa2a6de2bef94b - default default] (d14-58-d0-52-4c-28, d14-58-d0-52-4c-28.i1.cloud.suse.de) ram: 114519MB disk: 1468416MB io_ops: 0 instances: 2 doesn't have the required PCI devices (InstancePCIRequests(i21:17
gyeenstance_uuid=<?>,requests=[InstancePCIRequest])) host_passes /usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:54"21:17
mriedemgyee: the claims code in the resource tracker would be here for resize https://github.com/openstack/nova/blob/0984ebb9f1c3cc3c8ff352dd2a615a58da79833c/nova/compute/resource_tracker.py#L28021:17
gyeeso I am guessing the device has already be claimed and therefore we can't share the same device, even on resizing21:17
mriedemgyee: the PciPassthroughFilter might not be smart enough for resize to the same host yeah21:19
mriedemin general the scheduler and its filters don't know about move operations21:19
mriedemmordred: also, what a weird time for you to show up and heckle me :)21:19
mriedemgyee: i wouldn't be surprised if you look at the starlingx nova repo that they have something for pci passthrough same host resize21:21
mriedemcfriesen: ^21:22
mordredmriedem: it's 11:22pm where I am right now - that seems like perfect heckling time21:23
gyeemriedem, thanks for the info. Time to read code I guess. :-)21:23
*** gbarros has joined #openstack-nova21:23
mriedemmordred: so you're bored and lonely eh21:24
mordredmriedem: well, there's no aurora borealis tonight21:24
cfriesenmriedem: gyee: I think we're now aligned with upstream nova now, and that doesn't ring any bells for me.  Checking with someone.21:26
*** JamesBenson has quit IRC21:28
mriedemi would think being able to resize a pci passthrough instance on a single node edge site would be important for starlingx21:28
gyeecfriesen, thanks. Our instance is running stable/rocky right now, if that makes any difference.21:28
*** slaweq has joined #openstack-nova21:32
*** ociuhandu has quit IRC21:33
*** markvoelker has quit IRC21:35
*** slaweq has quit IRC21:36
cfriesengyee: mriedem: just checked and can't find anything like that.  Since Stein at least Starlingx has been aligned with upstream nova.  Sounds like a useful change though.21:41
gyeecfriesen, thanks for the info! Yeah, I agree, resizing to the same host is a useful feature21:45
*** munimeha1 has quit IRC21:48
*** gbarros has quit IRC21:51
*** TxGirlGeek has joined #openstack-nova21:51
*** BjoernT has quit IRC21:52
*** hemna has joined #openstack-nova22:09
*** xek_ has quit IRC22:15
cfriesengyee: I did some more digging, turns out that we did do some special-casing for sriov and resize/cold migration for Pike, because cold migration with PCI passthrough was broken.  For Stein, I think the only customization is numa-aware live migration.22:27
*** TxGirlGeek has quit IRC22:34
*** macz has joined #openstack-nova22:40
openstackgerritMerged openstack/nova stable/stein: Fix 'has_calls' method calls in unit tests  https://review.opendev.org/67732922:45
*** macz has quit IRC22:47
*** mriedem has quit IRC22:52
*** hemna has quit IRC22:57
*** tkajinam has joined #openstack-nova23:04
*** zhubx has joined #openstack-nova23:09
*** boxiang has quit IRC23:10
*** slaweq has joined #openstack-nova23:11
*** slaweq has quit IRC23:15
stephenfinalex_xu: This failing PMEM patch is killing me. If I rebase the PCPU series and push it up, can you fast re-approve them. I see only one merge conflict with master23:22
alex_xustephenfin: yes, I can23:22
*** markvoelker has joined #openstack-nova23:22
stephenfinThanks. Incoming23:22
alex_xu\o/23:23
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement  https://review.opendev.org/67179323:23
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available'  https://review.opendev.org/67269323:23
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMATopology.cpu_pinning' property  https://review.opendev.org/68010623:23
openstackgerritStephen Finucane proposed openstack/nova master: Validate CPU config options against running instances  https://review.opendev.org/68010723:23
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field  https://review.opendev.org/68010823:23
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180023:23
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait  https://review.opendev.org/67557123:23
openstackgerritStephen Finucane proposed openstack/nova master: tests: Additional functional tests for pinned instances  https://review.opendev.org/68175023:23
openstackgerritStephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count  https://review.opendev.org/68137423:23
openstackgerritStephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta  https://review.opendev.org/67180123:23
openstackgerritStephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique  https://review.opendev.org/68106023:23
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly  https://review.opendev.org/68106123:23
openstackgerritStephen Finucane proposed openstack/nova master: Add reshaper for PCPU  https://review.opendev.org/67489523:23
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Use sane indent  https://review.opendev.org/68022923:23
stephenfinalex_xu: FYI the merge conflict was on 'libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait' and due to commit 36ee9c1913a23:23
alex_xustephenfin: ok, thanks23:23
*** mlavalle has quit IRC23:27
*** adriant has joined #openstack-nova23:35
*** igordc has quit IRC23:39
*** rcernin has joined #openstack-nova23:44
*** JamesBenson has joined #openstack-nova23:47
*** JamesBenson has quit IRC23:52
openstackgerritBrin Zhang proposed openstack/nova-specs master: Track user_id/project_id for migrations  https://review.opendev.org/68251123:56
« Monday, 2019-09-16 Index Wednesday, 2019-09-18 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!