| openstackgerrit | Merged openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | 00:02 |
|---|---|---|
| *** kaliya has joined #openstack-nova | 00:03 | |
| *** kaliya has quit IRC | 00:08 | |
| donnyd | sean-k-mooney: is FN giving you any issues? | 00:09 |
| donnyd | looks like you have some jobs running | 00:09 |
| *** gbarros has quit IRC | 00:28 | |
| *** henriqueof1 has joined #openstack-nova | 00:45 | |
| *** henriqueof has quit IRC | 00:45 | |
| *** gbarros has joined #openstack-nova | 00:49 | |
| *** Garyx_ has quit IRC | 00:49 | |
| *** gyee has quit IRC | 00:53 | |
| *** gbarros has quit IRC | 00:59 | |
| *** markvoelker has joined #openstack-nova | 01:01 | |
| *** Garyx has joined #openstack-nova | 01:03 | |
| *** markvoelker has quit IRC | 01:05 | |
| brinzhang | melwitt: mriedem: Thanks | 01:10 |
| *** mlavalle has quit IRC | 01:10 | |
| *** mriedem_afk has quit IRC | 01:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove an unused file and a related description https://review.opendev.org/681955 | 01:41 |
| *** mkrai has joined #openstack-nova | 01:42 | |
| *** tbachman has joined #openstack-nova | 01:48 | |
| *** dolpher has quit IRC | 01:49 | |
| *** tkajinam has quit IRC | 01:54 | |
| *** brinzhang_ has joined #openstack-nova | 01:59 | |
| *** brinzhang_ has quit IRC | 02:01 | |
| *** brinzhang_ has joined #openstack-nova | 02:01 | |
| *** brinzhang has quit IRC | 02:02 | |
| *** kaliya has joined #openstack-nova | 02:05 | |
| *** kaliya has quit IRC | 02:09 | |
| *** tkajinam has joined #openstack-nova | 02:11 | |
| *** markvoelker has joined #openstack-nova | 02:26 | |
| *** gaoyan has joined #openstack-nova | 02:27 | |
| *** hongbin has joined #openstack-nova | 02:32 | |
| *** tkajinam has quit IRC | 02:36 | |
| *** markvoelker has quit IRC | 02:36 | |
| *** markvoelker has joined #openstack-nova | 02:38 | |
| *** markvoelker has quit IRC | 02:43 | |
| *** tkajinam has joined #openstack-nova | 02:56 | |
| *** dklyle has quit IRC | 02:57 | |
| *** sapd1 has joined #openstack-nova | 03:00 | |
| *** dklyle has joined #openstack-nova | 03:00 | |
| openstackgerrit | Merged openstack/nova master: Add nova-status to man-pages list https://review.opendev.org/681733 | 03:15 |
| *** tbachman has quit IRC | 03:29 | |
| openstackgerrit | Merged openstack/nova master: trivial: Remove single-use classmethod https://review.opendev.org/681751 | 03:31 |
| *** tbachman has joined #openstack-nova | 03:32 | |
| *** hongbin has quit IRC | 03:34 | |
| *** factor has quit IRC | 03:35 | |
| *** shilpasd has joined #openstack-nova | 03:56 | |
| *** shilpasd has quit IRC | 03:57 | |
| *** eharney has joined #openstack-nova | 04:11 | |
| *** markvoelker has joined #openstack-nova | 04:16 | |
| *** markvoelker has quit IRC | 04:21 | |
| *** eharney has quit IRC | 04:27 | |
| *** zhubx has quit IRC | 05:00 | |
| *** zhubx has joined #openstack-nova | 05:01 | |
| *** pcaruana has joined #openstack-nova | 05:02 | |
| *** sapd1_x has joined #openstack-nova | 05:05 | |
| *** udesale has joined #openstack-nova | 05:08 | |
| *** ratailor has joined #openstack-nova | 05:08 | |
| *** Luzi has joined #openstack-nova | 05:23 | |
| *** mkrai has quit IRC | 05:23 | |
| *** mkrai has joined #openstack-nova | 05:25 | |
| *** damien_r has joined #openstack-nova | 05:31 | |
| *** damien_r has quit IRC | 05:36 | |
| *** gaoyan has quit IRC | 05:50 | |
| *** tkajinam has quit IRC | 05:54 | |
| gibi | happy rechecking morning nova | 06:02 |
| *** tkajinam has joined #openstack-nova | 06:03 | |
| *** xek has joined #openstack-nova | 06:03 | |
| *** rpittau|afk is now known as rpittau | 06:08 | |
| *** xek has quit IRC | 06:12 | |
| *** xek has joined #openstack-nova | 06:13 | |
| *** ralonsoh has joined #openstack-nova | 06:14 | |
| *** tkajinam_ has joined #openstack-nova | 06:19 | |
| *** sapd1_x has quit IRC | 06:20 | |
| *** tkajinam has quit IRC | 06:22 | |
| gibi | ok I think I rechecked every approved but failed nova patch | 06:24 |
| *** mkrai has quit IRC | 06:25 | |
| *** mkrai_ has joined #openstack-nova | 06:25 | |
| gibi | 32 approved nova patches in the check queue 3 in the gate queue | 06:26 |
| *** henriqueof has joined #openstack-nova | 06:27 | |
| *** henriqueof1 has quit IRC | 06:28 | |
| *** avolkov has joined #openstack-nova | 06:29 | |
| *** sapd1_x has joined #openstack-nova | 06:46 | |
| *** slaweq has joined #openstack-nova | 06:50 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:52 | |
| *** lpetrut has joined #openstack-nova | 06:54 | |
| *** trident has quit IRC | 06:55 | |
| *** xek has quit IRC | 06:56 | |
| *** sapd1_x has quit IRC | 06:59 | |
| gibi | The todays killer bug is: bug 1813147 - p35 jobs are failing with subunit.parser ... FAILED | 06:59 |
| openstack | bug 1813147 in OpenStack Compute (nova) "p35 jobs are failing with subunit.parser ... FAILED" [High,In progress] https://launchpad.net/bugs/1813147 - Assigned to Balazs Gibizer (balazs-gibizer) | 06:59 |
| *** jkulik has joined #openstack-nova | 07:02 | |
| *** udesale has quit IRC | 07:04 | |
| *** trident has joined #openstack-nova | 07:07 | |
| *** mkrai_ has quit IRC | 07:10 | |
| *** Florian has joined #openstack-nova | 07:10 | |
| *** damien_r has joined #openstack-nova | 07:12 | |
| *** henriqueof has quit IRC | 07:12 | |
| *** henriqueof has joined #openstack-nova | 07:12 | |
| *** tesseract has joined #openstack-nova | 07:15 | |
| openstackgerrit | Merged openstack/nova master: Add user_id and project_id column to Migration https://review.opendev.org/673990 | 07:15 |
| openstackgerrit | Merged openstack/nova master: Cleanup reno live-migration-with-PCI-device https://review.opendev.org/681942 | 07:15 |
| *** gaoyan has joined #openstack-nova | 07:18 | |
| *** ralonsoh has quit IRC | 07:19 | |
| brinzhang_ | good morning gibi | 07:19 |
| gibi | brinzhang_: good morning | 07:20 |
| *** tssurya has joined #openstack-nova | 07:20 | |
| *** ralonsoh has joined #openstack-nova | 07:21 | |
| *** ttsiouts has joined #openstack-nova | 07:26 | |
| *** jaosorior has joined #openstack-nova | 07:35 | |
| *** ttsiouts has quit IRC | 07:36 | |
| *** ttsiouts has joined #openstack-nova | 07:37 | |
| *** ttsiouts has quit IRC | 07:41 | |
| bauzas | good morning folks | 07:45 |
| gibi | good morning bauzas | 07:47 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: mark the max microversion for train https://review.opendev.org/681982 | 07:49 |
| *** priteau has joined #openstack-nova | 07:57 | |
| kashyap | efried: aspiers: I was ill yesterday (and partly today). Reading the relevant bits. | 07:59 |
| *** ttsiouts has joined #openstack-nova | 07:59 | |
| *** ivve has joined #openstack-nova | 08:00 | |
| kashyap | aspiers: No, that reference to 'vexpress-a15' is _not_ correct: it should be 'virt' for ARMv7 or AArch64. | 08:00 |
| kashyap | aspiers: See the releasenotes/notes/Use-virt-as-machine-type-for-ARMv7-cd2c252336057ec8.yaml | 08:01 |
| *** tkajinam_ has quit IRC | 08:01 | |
| kashyap | aspiers: That Glance doc should be updated | 08:02 |
| bauzas | gibi: I eventually went unable to join yesterday evening | 08:02 |
| bauzas | gibi: any idea on where we are ? | 08:02 |
| bauzas | did we cut the cord ? | 08:02 |
| *** mkrai_ has joined #openstack-nova | 08:02 | |
| bauzas | I see a lot of merge conflicts as expected | 08:02 |
| kashyap | aspiers: For reference, see this: https://opendev.org/openstack/nova/commit/e155baefb0 | 08:03 |
| gibi | bauzas: the bw series is approved. I see vpmem in also approved | 08:03 |
| bauzas | gibi: actually, nevermind, I'll read the nova meeting logs | 08:03 |
| bauzas | gibi: the cpu-resources too, but it got conflicts | 08:03 |
| gibi | bauzas: yepp | 08:04 |
| *** awalende has joined #openstack-nova | 08:04 | |
| *** takashin has left #openstack-nova | 08:05 | |
| bauzas | okay, so tl;dr: let's continue trying to merge stuff that was previously approved | 08:07 |
| * bauzas now looks at the gate | 08:07 | |
| bauzas | gibi: how is your series ? still in the weeds ? | 08:07 |
| gibi | bauzas: one patch merged during the night, rest is in check queue after recheck | 08:09 |
| bauzas | ack | 08:11 |
| kashyap | aspiers: Sent the doc fix to Glance: https://review.opendev.org/681990 useful-image-properties: Update note on machine types | 08:13 |
| *** ccamacho has joined #openstack-nova | 08:14 | |
| *** ccamacho has quit IRC | 08:14 | |
| *** ccamacho has joined #openstack-nova | 08:18 | |
| *** BlackDex has left #openstack-nova | 08:31 | |
| openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Update flavor-related metadata on resize https://review.opendev.org/681004 | 08:33 |
| *** mkrai_ has quit IRC | 08:38 | |
| *** mkrai__ has joined #openstack-nova | 08:38 | |
| luyao | stephenfin: are you around, I see you string the vpmems and cpu resources, they merge conflict now | 08:38 |
| luyao | stephenfin: I'll rebase to master branch | 08:39 |
| *** mkrai__ has quit IRC | 08:39 | |
| *** mkrai__ has joined #openstack-nova | 08:40 | |
| luyao | stephenfin: this is the last patch , right ? https://review.opendev.org/#/c/674895/41 | 08:41 |
| *** raghavendrat has joined #openstack-nova | 08:42 | |
| *** markvoelker has joined #openstack-nova | 08:44 | |
| *** derekh has joined #openstack-nova | 08:45 | |
| *** mkrai__ has quit IRC | 08:45 | |
| *** markvoelker has quit IRC | 08:49 | |
| *** ralonsoh has quit IRC | 08:51 | |
| *** IvensZambrano has joined #openstack-nova | 08:54 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResourceList objs https://review.opendev.org/678448 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces https://review.opendev.org/678453 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: objects: Add 'InstanceNUMATopology.cpu_pinning' property https://review.opendev.org/680106 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 08:55 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 08:55 |
| *** ralonsoh has joined #openstack-nova | 08:55 | |
| bauzas | luyao: AFAICS, looks like stephenfin rebased his series on top of yours to prevent more merge conflicts | 08:59 |
| bauzas | stephenfin: correct ? | 08:59 |
| *** jaosorior has quit IRC | 09:00 | |
| luyao | bauzas: I think so, I handled the merge conflict due to my first two patches | 09:01 |
| *** ttsiouts has quit IRC | 09:02 | |
| *** ttsiouts has joined #openstack-nova | 09:03 | |
| *** kaliya has joined #openstack-nova | 09:03 | |
| bauzas | cool | 09:05 |
| *** ttsiouts has quit IRC | 09:07 | |
| *** kaliya has quit IRC | 09:08 | |
| *** ttsiouts has joined #openstack-nova | 09:14 | |
| *** udesale has joined #openstack-nova | 09:15 | |
| *** Florian has quit IRC | 09:19 | |
| *** FlorianFa has joined #openstack-nova | 09:19 | |
| *** jawad_axd has joined #openstack-nova | 09:19 | |
| aspiers | kashyap: thanks, please see also https://review.opendev.org/#/c/681866/ | 09:24 |
| *** boxiang has joined #openstack-nova | 09:24 | |
| kashyap | aspiers: Ah, it's the other thing you mentioned; metadata props. Nice | 09:25 |
| *** zhubx has quit IRC | 09:27 | |
| kashyap | aspiers: +1, FWIW. Wauw, given the number of values/props, could spot no typos :D | 09:30 |
| *** ivve has quit IRC | 09:32 | |
| * bauzas disappears | 09:40 | |
| *** mkrai has joined #openstack-nova | 09:41 | |
| aspiers | kashyap: why is ARM singled out in these docs when we have other defaults for other archs? | 09:41 |
| kashyap | aspiers: I don't know who wrote it originally. But I agree, we should be complete and specify the defaults for other arches, too? | 09:43 |
| aspiers | That was my thought | 09:43 |
| stephenfin | luyao: Correct. Looks like you have it handled. Thanks :) | 09:43 |
| kashyap | Mention it in the review, please. | 09:43 |
| aspiers | kashyap: We probably also need comments in the nova code "# if you change this, don't forget to change useful-image-properties.rst in glance" | 09:43 |
| kashyap | aspiers: Yes, good reminder, to keep things in sync | 09:44 |
| *** mdbooth has quit IRC | 09:44 | |
| aspiers | kashyap: I'll do that now | 09:44 |
| *** mdbooth has joined #openstack-nova | 09:46 | |
| aspiers | kashyap: hw_machine_type is not the only thing needing a reminder, what else? | 09:47 |
| *** ralonsoh has quit IRC | 09:48 | |
| *** ralonsoh has joined #openstack-nova | 09:48 | |
| aspiers | hw_*_bus is one | 09:49 |
| *** gaoyan has quit IRC | 09:50 | |
| *** ralonsoh has quit IRC | 09:50 | |
| *** ralonsoh has joined #openstack-nova | 09:53 | |
| kashyap | aspiers: Yeah, hw_*_bus and machine type are the only things that come to mind | 09:55 |
| *** udesale has quit IRC | 09:56 | |
| *** udesale has joined #openstack-nova | 09:57 | |
| *** ttsiouts has quit IRC | 09:57 | |
| *** ttsiouts has joined #openstack-nova | 09:57 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add reminder to update corresponding glance docs https://review.opendev.org/682012 | 10:01 |
| aspiers | kashyap: ^^^ | 10:01 |
| *** cdent has joined #openstack-nova | 10:01 | |
| *** ttsiouts has quit IRC | 10:02 | |
| kashyap | aspiers: Already has it open | 10:04 |
| *** tkajinam has joined #openstack-nova | 10:05 | |
| *** ivve has joined #openstack-nova | 10:05 | |
| *** ociuhandu has joined #openstack-nova | 10:06 | |
| *** ociuhandu has quit IRC | 10:07 | |
| kashyap | aspiers: Reviewed; only thing is - do you want to spell out the name of the document? | 10:10 |
| aspiers | kashyap: I removed that from the first version, because it could change, and anyway there are multiple files | 10:10 |
| aspiers | there's the metadefs JSON too | 10:10 |
| kashyap | aspiers: Okay, thought so. | 10:10 |
| * cdent waves | 10:11 | |
| * kashyap waves back | 10:11 | |
| kashyap | aspiers: And on casing, is my guess correct? | 10:11 |
| *** pcaruana has quit IRC | 10:11 | |
| aspiers | kashyap: replied | 10:22 |
| *** ociuhandu has joined #openstack-nova | 10:23 | |
| *** mkrai has quit IRC | 10:24 | |
| *** ociuhandu has quit IRC | 10:28 | |
| kashyap | aspiers: So I have to "unlearn" the capitalization everywhere except at the start of sentence. | 10:31 |
| aspiers | kashyap: IIUC | 10:31 |
| kashyap | Okido; regardless, the change is ready for merge :-) | 10:32 |
| * kashyap --> bbiab | 10:32 | |
| *** luksky has joined #openstack-nova | 10:36 | |
| *** ociuhandu has joined #openstack-nova | 10:38 | |
| openstackgerrit | Takashi Kajinami proposed openstack/nova master: Add an option to pass extra parameters for libvirt migration uri https://review.opendev.org/682019 | 10:40 |
| stephenfin | gibi: I'd say hold on rechecking the mox patches | 10:40 |
| stephenfin | We discussed it in the meeting last night and decided to wait until U to merge those now since the gate is busted | 10:41 |
| openstackgerrit | Takashi Kajinami proposed openstack/nova master: Add an option to pass extra parameters for libvirt migration uri https://review.opendev.org/682019 | 10:43 |
| *** ociuhandu has quit IRC | 10:44 | |
| *** tbachman has quit IRC | 10:45 | |
| openstackgerrit | Takashi Kajinami proposed openstack/nova master: Add an option to pass extra parameters for libvirt migration uri https://review.opendev.org/682019 | 10:49 |
| *** awalende has quit IRC | 10:52 | |
| *** awalende has joined #openstack-nova | 10:53 | |
| *** elod has quit IRC | 10:54 | |
| *** awalende has quit IRC | 10:54 | |
| *** awalende has joined #openstack-nova | 10:54 | |
| openstackgerrit | Merged openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | 10:55 |
| *** jawad_axd has quit IRC | 10:55 | |
| *** elod has joined #openstack-nova | 10:55 | |
| *** jawad_axd has joined #openstack-nova | 10:55 | |
| tkajinam | ping stephenfin | 10:58 |
| *** luksky has quit IRC | 11:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix a misuse of assertGreaterEqual https://review.opendev.org/682025 | 11:11 |
| *** takashin has joined #openstack-nova | 11:13 | |
| takashin | Hi, core reviewers. Would you review this patch https://review.opendev.org/#/c/682025/ related to a gate failure? | 11:14 |
| cdent | good find takashin | 11:17 |
| *** lpetrut has quit IRC | 11:20 | |
| *** sapd1_x has joined #openstack-nova | 11:22 | |
| *** pcaruana has joined #openstack-nova | 11:24 | |
| *** luksky has joined #openstack-nova | 11:26 | |
| *** luksky11 has joined #openstack-nova | 11:28 | |
| *** takashin has left #openstack-nova | 11:29 | |
| *** luksky has quit IRC | 11:31 | |
| *** jawad_axd has quit IRC | 11:37 | |
| *** jawad_axd has joined #openstack-nova | 11:37 | |
| *** udesale has quit IRC | 11:40 | |
| *** luksky11 has quit IRC | 11:40 | |
| *** udesale has joined #openstack-nova | 11:41 | |
| *** ociuhandu has joined #openstack-nova | 11:41 | |
| *** lpetrut has joined #openstack-nova | 11:42 | |
| *** ociuhandu has quit IRC | 11:42 | |
| *** luksky11 has joined #openstack-nova | 11:56 | |
| *** raghavendrat has quit IRC | 11:57 | |
| *** lpetrut has quit IRC | 11:59 | |
| *** lpetrut has joined #openstack-nova | 11:59 | |
| *** awalende has quit IRC | 12:01 | |
| *** awalende has joined #openstack-nova | 12:02 | |
| *** tbachman has joined #openstack-nova | 12:04 | |
| *** markvoelker has joined #openstack-nova | 12:04 | |
| sean-k-mooney | donnyd: i have had no issue with any of the FN jobs that have been run in the last 24 hours. they all completed fine. the reson we are rechcking them is to pick up different versions fo the code. i am using a feature of how zuul works to mean i dont need to keep rebasing the zuul job to test diffent parts of the code via an in repo depends on | 12:06 |
| *** awalende has quit IRC | 12:06 | |
| *** awalende has joined #openstack-nova | 12:09 | |
| donnyd | sean-k-mooney: that is great news | 12:14 |
| donnyd | Let me know if there is anything else I can do | 12:14 |
| sean-k-mooney | donnyd: at this point we are just waiting on zuul. also my brain is mostly fried after the last few days so im not going to be doing much more until next week | 12:16 |
| gibi | stephenfin: ack | 12:17 |
| sean-k-mooney | donnyd: my next ci task is to create the nodepool lable for nested-virt-bionic and update my ovs-dpdk job https://review.opendev.org/#/c/656580/ then work with limestone and/or vexxhost to expand the multi-numa lable to them and try and enable the whitebox tempest pluging in the nfv job we have been Running against FN | 12:19 |
| *** ttsiouts has joined #openstack-nova | 12:19 | |
| *** ratailor has quit IRC | 12:20 | |
| sean-k-mooney | donnyd: the white box tempest pluging, combined with writing some new standard test will allow me to compress the many fo the temport jobs down into 1 job | 12:21 |
| sean-k-mooney | donnyd: which im hoping to run as a perodic job intially and eventuly move to check after its stableised. | 12:21 |
| sean-k-mooney | donnyd: so for now relax, you have done more then enough to help with this effort | 12:22 |
| *** luksky11 has quit IRC | 12:22 | |
| *** ociuhandu has joined #openstack-nova | 12:22 | |
| donnyd | I'm very glad I could be helpful. | 12:23 |
| *** luksky11 has joined #openstack-nova | 12:23 | |
| *** tkajinam has quit IRC | 12:25 | |
| sean-k-mooney | donnyd: for what its worth this is the set of ci topic we talked about last PTG https://etherpad.openstack.org/p/nova-ptg-train-ci | 12:26 |
| *** jaosorior has joined #openstack-nova | 12:27 | |
| sean-k-mooney | donnyd: line 36 multi numa guests and basically everytin form line 31 to 45 is what you have allowed us to start testing | 12:28 |
| donnyd | Well if fn can do anything else, never be afraid to ask | 12:30 |
| *** sapd1_x has quit IRC | 12:31 | |
| sean-k-mooney | efried: speaking of that etherpad line 29 https://etherpad.openstack.org/p/nova-ptg-train-ci can i anounce/propose the deprectation fo libvirt with virt-type uml | 12:32 |
| *** ociuhandu has quit IRC | 12:32 | |
| sean-k-mooney | efried: there are other virt types that also shoudl be marked experimenal or deprecated but too slince they have no testing. lxc is almost workign again but there are defiently gaps | 12:33 |
| sean-k-mooney | so i kind of want to hold off on that until Ussuri | 12:34 |
| *** boxiang has quit IRC | 12:35 | |
| sean-k-mooney | efried: mriedem has an experimal lxc job and we have patches to fixed some of the short comings with cloud init https://review.opendev.org/#/c/667976/ | 12:35 |
| *** boxiang has joined #openstack-nova | 12:35 | |
| *** jawad_ax_ has joined #openstack-nova | 12:38 | |
| *** ociuhandu has joined #openstack-nova | 12:39 | |
| *** jawad_axd has quit IRC | 12:41 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for I220fa02ee916728e241503084b14984bab4b0c3b https://review.opendev.org/680810 | 12:42 |
| *** dave-mccowan has joined #openstack-nova | 12:44 | |
| *** lpetrut has quit IRC | 12:48 | |
| *** henriqueof1 has joined #openstack-nova | 12:49 | |
| *** belmoreira has quit IRC | 12:49 | |
| *** henriqueof has quit IRC | 12:50 | |
| *** lpetrut has joined #openstack-nova | 12:53 | |
| *** ociuhandu has quit IRC | 12:58 | |
| *** dave-mccowan has quit IRC | 12:58 | |
| donnyd | sean-k-mooney: I'm pretty interested in lxc functionality due to my resources not being as much as some others out there | 12:59 |
| sean-k-mooney | ya it would be nice to get it working fully again | 13:00 |
| sean-k-mooney | i was able to boot a contianer and inject keys with that cloud init patch | 13:00 |
| donnyd | And knocking down targets from the ptg is a good thing too | 13:01 |
| sean-k-mooney | the next gap for lxc that i hit while testing it is we are not correctly resizing the filesystme in the image to match the route disk on the flaovr | 13:02 |
| sean-k-mooney | and you cant do it inside the contianer | 13:02 |
| sean-k-mooney | so we would have to fix that before i would be comfortable useing it in production | 13:02 |
| *** Luzi has quit IRC | 13:06 | |
| *** luksky11 has quit IRC | 13:06 | |
| *** ociuhandu has joined #openstack-nova | 13:07 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | 13:09 |
| lyarwood | ^ any cores around, is it too late in the cycle to land bugfixes that bump requirements.txt? | 13:10 |
| lyarwood | or is that not even a thing until rc? | 13:10 |
| *** ociuhandu has quit IRC | 13:12 | |
| *** ociuhandu has joined #openstack-nova | 13:16 | |
| stephenfin | gibi: You should probably hit https://review.opendev.org/#/c/682025/ | 13:17 |
| stephenfin | lyarwood: I've no idea. Might be a good thing to ask on #openstack-requirements ? | 13:18 |
| stephenfin | or wait for mriedem, I guess | 13:18 |
| *** mriedem has joined #openstack-nova | 13:18 | |
| *** jawad_ax_ has quit IRC | 13:18 | |
| *** jawad_axd has joined #openstack-nova | 13:19 | |
| stephenfin | speak of the devil | 13:20 |
| mriedem | muwahahahaha? | 13:21 |
| * tbachman wonders how mriedem knew he was the devil | 13:22 | |
| stephenfin | <openstackgerrit> Lee Yarwood proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | 13:22 |
| stephenfin | <lyarwood> ^ any cores around, is it too late in the cycle to land bugfixes that bump requirements.txt? | 13:22 |
| stephenfin | mriedem: ^ | 13:22 |
| *** jawad_ax_ has joined #openstack-nova | 13:22 | |
| mriedem | seems a bit risky to land that right now, | 13:23 |
| mriedem | that's something i'd rather land early in U and let it bake | 13:23 |
| mriedem | b/c fallout from that would probably be weird and hard to determine | 13:23 |
| *** jawad_axd has quit IRC | 13:24 | |
| lyarwood | yup that's fair and on me for not pushing this earlier in the cycle | 13:25 |
| mriedem | i think it's also a low severity issue, | 13:26 |
| mriedem | i left some comments in the patch | 13:26 |
| lyarwood | ack thanks | 13:26 |
| *** jaosorior has quit IRC | 13:26 | |
| *** jawad_ax_ has quit IRC | 13:28 | |
| *** jawad_axd has joined #openstack-nova | 13:29 | |
| efried | sean-k-mooney: "deprectation fo libvirt with virt-type uml" I don't know what that means. | 13:31 |
| *** ttsiouts has quit IRC | 13:31 | |
| efried | So, sure, you can propose it, but someone who knows more than me might reject your proposal :) | 13:31 |
| *** ttsiouts has joined #openstack-nova | 13:32 | |
| sean-k-mooney | the libvirt virt dirver support multiple virt-types that match to different dirver in libvirt | 13:32 |
| sean-k-mooney | UML is user mode linux | 13:32 |
| sean-k-mooney | i dont think we have ever had ci for that and dont know of anyone that support it in a product | 13:33 |
| *** eharney has joined #openstack-nova | 13:33 | |
| *** jawad_axd has quit IRC | 13:33 | |
| sean-k-mooney | we talked about deprecating libvirt virt types that do not have ci at the ptg in the test/ci session | 13:34 |
| *** ttsiouts_ has joined #openstack-nova | 13:34 | |
| sean-k-mooney | since we are going to do that for xenserver i was wondering if we should do it for uml | 13:34 |
| *** ttsiouts has quit IRC | 13:35 | |
| sean-k-mooney | again its more of a shot across the bow. | 13:35 |
| dansmith | sean-k-mooney: I'd be fine with deprecation or straight removal, but I'm not sure it's worth it | 13:35 |
| dansmith | the xen deprecation brings benefit, I'm not sure deprecating or removing uml is anything other than more work | 13:36 |
| sean-k-mooney | we have a few conditional in the libvirt dirver to handel it | 13:36 |
| dansmith | I know | 13:36 |
| sean-k-mooney | so we could remove those | 13:36 |
| sean-k-mooney | but it not a huge benifit | 13:36 |
| dansmith | which is work for minimal benefit :) | 13:36 |
| sean-k-mooney | ya | 13:37 |
| dansmith | but if you want to do it I don't think there's any reason to keep it | 13:37 |
| sean-k-mooney | well its not like anyone has filed a bug for it in years | 13:37 |
| sean-k-mooney | whicih is proably the primary inicator no one is useing it | 13:38 |
| sean-k-mooney | well there is one https://bugs.launchpad.net/nova/+bug/1597754 | 13:38 |
| openstack | Launchpad bug 1597754 in OpenStack Compute (nova) "Unable to boot instance using UML" [Low,Triaged] | 13:38 |
| sean-k-mooney | that seams like an imporant action for a virt type to support :) | 13:39 |
| efried | Hell, even powervm could do THAT. | 13:41 |
| sean-k-mooney | :) | 13:41 |
| dansmith | I'd guess that was someone bored on a thursday evening, just trying to see if it still works | 13:42 |
| dansmith | I'd bet it's less flexible than ironic even, probably fails the support matrix test | 13:42 |
| sean-k-mooney | it was reported by mdbooth so i suspect it was filed when he was working on https://review.opendev.org/#/q/status:abandoned+topic:libvirt-imagebackend | 13:43 |
| dansmith | heh | 13:43 |
| * dansmith didn't even clic | 13:43 | |
| sean-k-mooney | he fixed it in his image backend erfactor which we never merged. | 13:44 |
| efried | So I'm having kind of a hard time believing that nova's gate throughput is on par with everyone else's, even in absolute numbers. Are small projects literally getting like two results every three hours? | 13:45 |
| efried | i.e. the algorithm is broken | 13:46 |
| sean-k-mooney | efried: we are effectivly down 2 ci providres at the momemnt i think | 13:46 |
| efried | oh? | 13:46 |
| sean-k-mooney | i think FN is still scaled down and we are having issue with vexxhost and boot form volume | 13:47 |
| sean-k-mooney | and by we i mean infra | 13:47 |
| sean-k-mooney | so maybe | 13:47 |
| mriedem | today is then a docs and education friday! | 13:49 |
| efried | Okay, well, I'm going to more or less take the day off, just watch and recheck. | 13:49 |
| efried | I think mriedem has me on some messaging app or other if I'm needed. | 13:50 |
| mriedem | how about commenting on the highlights patch which is due today https://review.opendev.org/#/c/681943/ | 13:51 |
| efried | have I not done that? | 13:51 |
| mriedem | dansmith: ^ words on the live migration + numa + cpu pinning + huge pages thing? | 13:51 |
| mriedem | efried: oh i guess you did | 13:52 |
| mriedem | or artom i guess ^ | 13:52 |
| efried | I'm basically +1 on whatever you wind up with. alex_xu or luyao could add some words about vpmem, but I'm not sure if that's supposed to be a tech preview or a trumpet-from-rooftops, or whatever | 13:52 |
| efried | also, I think "first draft" was due today, so we're done :P | 13:53 |
| artom | mriedem, I'm happy with it, left a note | 13:54 |
| *** cdent has quit IRC | 13:57 | |
| *** ratailor has joined #openstack-nova | 14:00 | |
| stephenfin | dansmith/mriedem/efried: This is going to cause gate issues and should be merged, right? https://review.opendev.org/682025 | 14:07 |
| *** gbarros has joined #openstack-nova | 14:07 | |
| * stephenfin thinks the original patch was to fix gate issues | 14:07 | |
| mriedem | sob | 14:11 |
| mriedem | no wonder this didn't go down :/ http://status.openstack.org/elastic-recheck/#1843615 | 14:12 |
| * mriedem gets out the harakiri sword | 14:12 | |
| *** JamesBenson has joined #openstack-nova | 14:15 | |
| sean-k-mooney | mriedem: i did get a passing test run with numa+pcpus+vpmem last night by the way | 14:21 |
| mriedem | how are you testing vpmem in the gate? | 14:22 |
| sean-k-mooney | https://review.opendev.org/#/c/681771/ https://zuul.opendev.org/t/openstack/build/6a67b28d6e9e4b739e7575df7943a69d | 14:22 |
| mriedem | doesn't that require special hardware? | 14:22 |
| sean-k-mooney | it just had the code merged | 14:22 |
| sean-k-mooney | didnt test the feature | 14:22 |
| mriedem | stephenfin: thanks for calling that out - infra just pushed it to the gate | 14:22 |
| stephenfin | np | 14:23 |
| sean-k-mooney | but we did test with pinning+hugepage+multi numa https://review.opendev.org/#/c/681771/2/playbooks/nfv/nfv.yaml | 14:23 |
| *** ratailor has quit IRC | 14:24 | |
| mriedem | sean-k-mooney: iow, vpmem didn't obviously regress any RT stuff with numa+pcpu in the same run | 14:24 |
| sean-k-mooney | mriedem: right | 14:25 |
| sean-k-mooney | no idea if it works | 14:25 |
| sean-k-mooney | but when its not used it does not seam to break anything | 14:25 |
| sean-k-mooney | unfortuetly it looks like the intel pmem ci did not run on that | 14:26 |
| mriedem | idk if it's the new version of firefox i'm on, but i can't copy text from gerrit comments anymore, which is super annoying | 14:27 |
| dansmith | from non-editing ones, I have the same issue in chrome | 14:27 |
| dansmith | not always consistent, but sometimes.. it's weird | 14:28 |
| sean-k-mooney | i have been having issue with that too but i can sometimes get ti to work | 14:28 |
| *** panda|ruck has quit IRC | 14:28 | |
| *** panda has joined #openstack-nova | 14:29 | |
| *** xek has joined #openstack-nova | 14:32 | |
| *** xek_ has joined #openstack-nova | 14:35 | |
| *** mlavalle has joined #openstack-nova | 14:35 | |
| melwitt | yeah, same. I couldn't remember if copying from comments in gerrit was ever possible (I guess it was) | 14:36 |
| *** xek has quit IRC | 14:37 | |
| sean-k-mooney | i can get ctrl+insert to wrok and ctrl+c to work in some cases but its really inconsitent | 14:40 |
| *** rcernin has quit IRC | 14:42 | |
| *** jangutter has quit IRC | 14:42 | |
| *** lpetrut has quit IRC | 14:43 | |
| mriedem | do we have a patch up to mark train in the rest api history doc? | 14:45 |
| *** ociuhandu has quit IRC | 14:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Denote max version for Train in REST API history doc https://review.opendev.org/682069 | 14:47 |
| *** tbachman has quit IRC | 14:48 | |
| dansmith | mriedem: do you want to throw an rpc alias in there? | 14:50 |
| mriedem | separate patch? | 14:51 |
| dansmith | both are aliases right? | 14:51 |
| mriedem | sean-k-mooney: adrianc: shouldn't the note here https://docs.openstack.org/nova/latest/admin/pci-passthrough.html be updated to mention sriov live migratoin support in train? | 14:51 |
| mriedem | dansmith: feel free to throw something up, i'm trying to wrap up these cycle highlights | 14:51 |
| dansmith | just seemed like appropriate for the same patch but okay | 14:51 |
| sean-k-mooney | not really | 14:52 |
| sean-k-mooney | that is flavor based pci passthouhg | 14:52 |
| *** gbarros has quit IRC | 14:53 | |
| sean-k-mooney | we could not that if you dont use this you can doe neutron based sriov and live migate | 14:53 |
| sean-k-mooney | if that is what you ment | 14:53 |
| sean-k-mooney | but i prefer to keep the flavor based apparoch which uses an alias seperate form the neutron port approch which does not | 14:53 |
| sean-k-mooney | the sriov live migration only work for neutron ports | 14:54 |
| mriedem | oh right yeah, | 14:54 |
| mriedem | guess i wouldn't have thought about that except for the conditionals in the RT claims code | 14:54 |
| sean-k-mooney | ya the proabme with generic pci devices is that even if the supprot sriov and you passthogh the PF | 14:58 |
| sean-k-mooney | *VF | 14:58 |
| sean-k-mooney | guest kerenls generall dont expect gpus or fpga to go away and we dont have an indireciton mecanisum like macvtap | 14:58 |
| sean-k-mooney | so its not realy safe to detatch them wtihout impacting the guest | 14:58 |
| *** ociuhandu has joined #openstack-nova | 14:59 | |
| sean-k-mooney | vfio-mediated device or mdev | 14:59 |
| sean-k-mooney | give you that indrection but few thing support that yet | 14:59 |
| sean-k-mooney | which is why we declare all of the flavor based stuff out of scope and just did the simpelest thing which is nics | 14:59 |
| sean-k-mooney | that is also what most people wanted | 15:00 |
| mriedem | hmm, i wonder if i should clarify that in the highlights, | 15:02 |
| mriedem | because it just says "live migration support for sriov ports when using the libvirt driver" | 15:02 |
| mriedem | i guess "ports" is good enough? | 15:02 |
| sean-k-mooney | am maybe but i would leave that up to more docs focused people | 15:03 |
| sean-k-mooney | ports is enough for me | 15:03 |
| *** ociuhandu has quit IRC | 15:03 | |
| sean-k-mooney | we coudl say neutron ports | 15:03 |
| mriedem | as opposed to, | 15:04 |
| mriedem | what was that neutron replacement from cisco? | 15:04 |
| sean-k-mooney | as aopposed to just sriov port say sriov neutron ports | 15:04 |
| sean-k-mooney | vpp | 15:04 |
| mriedem | it had another name | 15:04 |
| sean-k-mooney | ? | 15:04 |
| sean-k-mooney | oh yes am | 15:04 |
| mriedem | that yaml based port definition thing that was a drop in for neutron | 15:04 |
| mriedem | quark? | 15:04 |
| sean-k-mooney | no but it was like that | 15:05 |
| sean-k-mooney | prothon or some partical thing | 15:05 |
| mriedem | porthole | 15:05 |
| mriedem | anyway, saying "neutron ports" in openstack is redundant | 15:05 |
| sean-k-mooney | ya as i said it looks fine to me | 15:06 |
| sean-k-mooney | stephenfin: any opipion ^ | 15:06 |
| stephenfin | nope :) | 15:06 |
| *** tbachman has joined #openstack-nova | 15:09 | |
| *** awalende has quit IRC | 15:13 | |
| *** ociuhandu has joined #openstack-nova | 15:13 | |
| *** awalende has joined #openstack-nova | 15:13 | |
| mriedem | stephenfin: wasn't this supposed to fail https://review.opendev.org/#/c/681938/ ? | 15:15 |
| stephenfin | Yes. Yes it was. | 15:15 |
| stephenfin | So my diagnosis is wrong | 15:16 |
| stephenfin | That code is definitely wrong, on account of it leaving Nones in there, but what did I do to trigger it... | 15:16 |
| * stephenfin investigates. | 15:16 | |
| mriedem | unless my patch is wrong | 15:16 |
| stephenfin | it looks okay | 15:16 |
| *** ociuhandu has quit IRC | 15:18 | |
| mriedem | i see that the flavor is configured properly from the n-cpu logs | 15:18 |
| mriedem | https://zuul.opendev.org/t/openstack/build/a7ae03ac0af24dc6b474a54de9d5cf86/log/controller/logs/screen-n-cpu.txt.gz#1924 | 15:18 |
| mriedem | Sep 13 04:50:30.647385 ubuntu-bionic-rax-ord-0011241791 nova-compute[18284]: DEBUG nova.virt.hardware [None req-f2beffe4-882b-4f73-ab07-ba3c859361ab tempest-AggregatesAdminTestJSON-598247452 tempest-AggregatesAdminTestJSON-598247452] Getting desirable topologies for flavor Flavor(created_at=2019-09-13T04:48:13Z,deleted=False,deleted_at=None,description=None,disabled=False,ephemeral_gb=0,extra_specs={trait:COMPUTE_NET_ATTACH_I | 15:18 |
| mriedem | FACE='required'},flavorid='42',id=11,is_public=True,memory_mb=64,name='m1.nano',projects=<?>,root_gb=1,rxtx_factor=1.0,swap=0,updated_at=None,vcpu_weight=0,vcpus=1) and image_meta ImageMeta(checksum='443b7623e27ecf03dc9e01ee93f67afe',container_format='bare',created_at=2019-09-13T04:45:17Z,direct_url=<?>,disk_format='qcow2',id=e085b93e-a43c-42f1-9496-2b46f103dd3d,min_disk=0,min_ram=0,name='cirros-0.4.0-x86_64-disk',owner='4323 | 15:18 |
| mriedem | f86c41da98dc6230d777d7c4',properties=ImageMetaProps,protected=<?>,size=12716032,status='active',tags=<?>,updated_at=2019-09-13T04:45:17Z,virtual_size=<?>,visibility=<?>), allow threads: True {{(pid=18284) _get_desirable_cpu_topologies /opt/stack/nova/nova/virt/hardware.py:572}} | 15:18 |
| *** awalende_ has joined #openstack-nova | 15:18 | |
| *** awalende has quit IRC | 15:18 | |
| stephenfin | mriedem: I know - you don't have cpu_model set on the host | 15:19 |
| stephenfin | or cpu_flags | 15:19 |
| stephenfin | both in the 'libvirt' group | 15:19 |
| mriedem | and the scheduling request in placement | 15:19 |
| mriedem | https://zuul.opendev.org/t/openstack/build/a7ae03ac0af24dc6b474a54de9d5cf86/log/controller/logs/screen-placement-api.txt.gz#337 | 15:19 |
| stephenfin | I missed that /o\ | 15:19 |
| mriedem | oh | 15:20 |
| mriedem | so this is only if you use the cpu flag traits stuff | 15:20 |
| stephenfin | Not quite | 15:20 |
| openstackgerrit | Merged openstack/nova master: Find instance in another cell during floating IP re-association https://review.opendev.org/656594 | 15:20 |
| stephenfin | It's only if you have '[libvirt] cpu_model' and '[libvirt] cpu_flags' (or maybe just the first - I'll check) set on the host | 15:21 |
| stephenfin | which I _think_ most people will have because (a) live migration and (b) spectre/meltdown | 15:21 |
| mriedem | you mean cpu_models and cpu_model_extra_flags yeah? | 15:21 |
| stephenfin | that's the one | 15:22 |
| mriedem | and yeah those are both [] in this run | 15:22 |
| stephenfin | Because we're not actually using the libvirt driver in the functional tests, it should be possible set both of those in a functional tests | 15:23 |
| *** awalende_ has quit IRC | 15:23 | |
| stephenfin | I'll check | 15:23 |
| *** maciejjozefczyk is now known as mjozefcz|away | 15:23 | |
| mriedem | so cpu_model was renamed to cpu_models in train, right? | 15:23 |
| stephenfin | it was. It's now a list | 15:24 |
| mriedem | because i see https://docs.openstack.org/nova/stein/configuration/config.html#libvirt.cpu_model in stein but not in train and https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.cpu_models in train but not stein | 15:24 |
| mriedem | so, | 15:24 |
| *** TxGirlGeek has joined #openstack-nova | 15:24 | |
| mriedem | if cpu_model isn't deprecated with a rename how is the upgrade handled? just checking for cpu_models first and if not found use cpu_model and log a warning to use the new option? | 15:24 |
| stephenfin | deprecated_name | 15:25 |
| mriedem | bnemec: is there any kind of flag in oslo.config that says "kill the service on startup if using config options that aren't actually defined"? | 15:25 |
| stephenfin | ListOpt works just like StrOpt if you only list one item | 15:25 |
| mriedem | oh there it is | 15:25 |
| mriedem | bnemec: ignore | 15:25 |
| *** tesseract has quit IRC | 15:25 | |
| *** igordc has joined #openstack-nova | 15:25 | |
| *** ociuhandu has joined #openstack-nova | 15:26 | |
| *** igordc has quit IRC | 15:27 | |
| *** igordc has joined #openstack-nova | 15:27 | |
| *** tbachman has quit IRC | 15:28 | |
| *** ivve has quit IRC | 15:29 | |
| mriedem | so is there a model i could use in this devstack job that we could expect to be in a gate run, like IvyBridge? and i could probably just set cpu_model_extra_flags to pcid? | 15:29 |
| mriedem | or vmx or something? | 15:30 |
| *** udesale has quit IRC | 15:30 | |
| *** udesale has joined #openstack-nova | 15:31 | |
| *** weshay|ruck has quit IRC | 15:31 | |
| sean-k-mooney | vmx would need nested virt but ya pcid would proably work | 15:31 |
| stephenfin | I'm using this https://gist.github.com/stephenfin/31a44d9cc40d9ce7abffadb5a6830cb1#file-local-conf-master-L25-L28 | 15:31 |
| *** gbarros has joined #openstack-nova | 15:31 | |
| stephenfin | and that's on 6+ year old hardware so it should do the trick | 15:31 |
| mriedem | ok i'll update my devstack patch | 15:31 |
| *** igordc has quit IRC | 15:32 | |
| *** tbachman has joined #openstack-nova | 15:33 | |
| sean-k-mooney | pcid was added in the first gen xeon i think back like 11 years ago | 15:33 |
| *** ociuhandu has quit IRC | 15:33 | |
| sean-k-mooney | so ya that is safe | 15:33 |
| sean-k-mooney | well | 15:33 |
| sean-k-mooney | as long as the geate is useing it | 15:33 |
| *** macz has joined #openstack-nova | 15:33 | |
| sean-k-mooney | it will proably work however | 15:34 |
| mriedem | we'll see https://review.opendev.org/#/c/681938/ | 15:34 |
| *** dklyle has quit IRC | 15:35 | |
| mriedem | updated release cycle highlights https://review.opendev.org/681943 | 15:36 |
| *** dklyle has joined #openstack-nova | 15:36 | |
| *** ttsiouts_ has quit IRC | 15:37 | |
| *** ttsiouts has joined #openstack-nova | 15:38 | |
| *** damien_r has quit IRC | 15:40 | |
| *** ociuhandu has joined #openstack-nova | 15:42 | |
| *** ttsiouts has quit IRC | 15:42 | |
| *** artom has quit IRC | 15:43 | |
| *** mjozefcz|away has quit IRC | 15:43 | |
| aspiers | I've just drafted a blog post on SEV. Feedback welcome: https://blog.adamspiers.org/?p=1871&preview=1&_ppp=1bfc4e4f7e | 15:45 |
| *** ociuhandu has quit IRC | 15:46 | |
| *** IvensZambrano has quit IRC | 16:06 | |
| *** owalsh has quit IRC | 16:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: remove mention about os-migrations no longer being extended https://review.opendev.org/682102 | 16:18 |
| *** mriedem is now known as mriedem_afk | 16:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: remove mention about os-migrations no longer being extended https://review.opendev.org/682102 | 16:19 |
| *** rpittau is now known as rpittau|afk | 16:22 | |
| stephenfin | aspiers: Can you check something for me? | 16:24 |
| * stephenfin gets links | 16:24 | |
| *** eharney has quit IRC | 16:25 | |
| *** owalsh has joined #openstack-nova | 16:29 | |
| aspiers | stephenfin: I'll try | 16:30 |
| stephenfin | sorry, got distracted | 16:31 |
| stephenfin | aspiers: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L697 | 16:31 |
| stephenfin | Isn't that line wrong? Should it read: | 16:31 |
| stephenfin | self._host.get_capabilities().host.cpu.model (not .arch) ? | 16:31 |
| stephenfin | *shouldn't it | 16:31 |
| stephenfin | (Actually, "shouldn't it" is colloquial. Oops :)) | 16:32 |
| *** owalsh has quit IRC | 16:34 | |
| sean-k-mooney | https://review.opendev.org/#/c/634827/ failed withthe 6 not greathan 7 notificaiton thing again | 16:39 |
| *** derekh has quit IRC | 16:40 | |
| stephenfin | sean-k-mooney: https://review.opendev.org/682025 | 16:40 |
| sean-k-mooney | so the numa serise will block until https://review.opendev.org/#/c/682025/ is mergd | 16:40 |
| sean-k-mooney | ya | 16:40 |
| sean-k-mooney | just pointing out there is no point recheck untill that has merged | 16:40 |
| sean-k-mooney | wow that was the fix... | 16:41 |
| stephenfin | yup | 16:44 |
| stephenfin | tbf, I've made that same mistake myself many times | 16:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: DNM: Reproducer for bug #1843836 https://review.opendev.org/682111 | 16:44 |
| openstack | bug 1843836 in OpenStack Compute (nova) "Failure to schedule if flavor contains non-CPU flag traits" [Undecided,In progress] https://launchpad.net/bugs/1843836 - Assigned to Stephen Finucane (stephenfinucane) | 16:44 |
| stephenfin | mriedem_afk: ^ | 16:44 |
| *** gyee has joined #openstack-nova | 16:44 | |
| sean-k-mooney | i think it was enqued directly to gate so it should merge soon i hope | 16:44 |
| *** markvoelker has quit IRC | 16:45 | |
| stephenfin | mriedem_afk: there's a WIP functional reproducer for the bug. I'll clean it up Monday once I'm done investigating the other issue that reproducer highlighted | 16:45 |
| stephenfin | *potential issue | 16:45 |
| stephenfin | sean-k-mooney: It sure was, yup | 16:45 |
| aspiers | stephenfin: that github link is basically a DoS attack on my browser X-D | 16:47 |
| stephenfin | aspiers: Hahahaha | 16:48 |
| stephenfin | yeah...don't try to load it on a phone | 16:48 |
| *** bnemec is now known as beekneemech | 16:48 | |
| aspiers | no that was on my laptop | 16:48 |
| *** markvoelker has joined #openstack-nova | 16:49 | |
| stephenfin | if there was ever a sign that a file had grown too large... | 16:49 |
| aspiers | right? | 16:49 |
| stephenfin | funnily enough, libvirt source files tend to be huuuuge as well | 16:49 |
| sean-k-mooney | thats not uncommon in c | 16:49 |
| *** tssurya has quit IRC | 16:50 | |
| *** markvoelker has quit IRC | 16:53 | |
| *** gbarros has quit IRC | 16:53 | |
| *** owalsh has joined #openstack-nova | 16:54 | |
| aspiers | stephenfin: anyway yes it looks wrong to me | 17:00 |
| stephenfin | \o/ | 17:01 |
| *** gbarros has joined #openstack-nova | 17:01 | |
| stephenfin | Another one to fix on Monday | 17:01 |
| stephenfin | Thanks for taking a look, aspiers | 17:01 |
| *** artom has joined #openstack-nova | 17:03 | |
| *** cfriesen has quit IRC | 17:08 | |
| *** xek_ has quit IRC | 17:08 | |
| *** ralonsoh has quit IRC | 17:11 | |
| aspiers | BTW I'm off next week | 17:17 |
| aspiers | stephenfin: In case you missed it, I've just drafted a blog post on SEV. Feedback welcome: https://blog.adamspiers.org/?p=1871&preview=1&_ppp=1bfc4e4f7e | 17:18 |
| stephenfin | aspiers: Won't get to it today but I'll try early next week. Enjoy your time off! | 17:23 |
| *** luksky11 has joined #openstack-nova | 17:25 | |
| aspiers | cheers :) | 17:25 |
| *** priteau has quit IRC | 17:28 | |
| artom | Where's the part you call us all poopyheads for not reviewing your code enough? | 17:28 |
| *** udesale has quit IRC | 17:36 | |
| sean-k-mooney | damit... mriedem_afk https://review.opendev.org/#/c/682025/ is going to fail | 17:49 |
| sean-k-mooney | subunit parser is exploding | 17:50 |
| *** markvoelker has joined #openstack-nova | 17:51 | |
| *** mriedem_afk is now known as mriedem | 17:51 | |
| mriedem | drats | 17:51 |
| *** eharney has joined #openstack-nova | 17:51 | |
| sean-k-mooney | https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_897/682025/1/gate/openstack-tox-py37/89752ac/testr_results.html.gz | 17:51 |
| artom | What even causes those? | 17:53 |
| sean-k-mooney | large amount of output to standard out or error | 17:53 |
| sean-k-mooney | like all the logging of the host capablities | 17:53 |
| mriedem | those seem to have spiked against recently so something must have merged that is causing us to tip over | 17:54 |
| mriedem | http://status.openstack.org/elastic-recheck/#1813147 | 17:54 |
| mriedem | #2 top most fail in the check queue right now | 17:55 |
| sean-k-mooney | its happening in other jobs too not just py35 but ya | 17:55 |
| sean-k-mooney | before it was due to a bunch of deprecation warnings | 17:56 |
| mriedem | the name of the bug is old | 17:57 |
| sean-k-mooney | can we force submit that change? im running the unit test locally to see if it explodes but i dont expect it to | 17:58 |
| mriedem | as in get it re-queued? | 17:58 |
| mriedem | i think you'd have to rebase | 17:58 |
| mriedem | which will put it back through check | 17:58 |
| sean-k-mooney | as in ask infra to override zuul | 17:58 |
| mriedem | i asked for it to be promoted to gate earlier in infra | 17:59 |
| sean-k-mooney | but we could requeu it too | 17:59 |
| mriedem | jesus look at this https://4c970d31e6335324d673-0d0b23b7f62d479822a1b52b605369e3.ssl.cf1.rackcdn.com/682025/1/gate/nova-tox-functional-py36/5f76307/job-output.txt | 17:59 |
| mriedem | search for inprogress | 17:59 |
| mriedem | see the wall of 00s | 17:59 |
| artom | Those subunit things appear to start on september... 4th? | 18:00 |
| mriedem | wtf is that | 18:00 |
| artom | Picking up on the 5th and 6th | 18:00 |
| mriedem | artom: we only have 10 days of logs | 18:00 |
| artom | I thought it was 30? | 18:00 |
| mriedem | 10 days of indexed logs in ES | 18:00 |
| artom | Aha | 18:00 |
| mriedem | and we need to filter out glance, | 18:01 |
| mriedem | but yeah i can check that in logstash | 18:01 |
| sean-k-mooney | i think htat is the empty buffer that subunit was trying to use or somthing like that | 18:01 |
| sean-k-mooney | ValueError: Not a text type application/octet-stream | 18:01 |
| sean-k-mooney | was that a local issue or was that just one of the things we saw when subunit blows up | 18:02 |
| *** panda has quit IRC | 18:02 | |
| mriedem | you get the valuerror when subunit blows up | 18:02 |
| mriedem | i have'nt seen that wall of 00s before though, | 18:03 |
| mriedem | and in the unit test fail https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_897/682025/1/gate/openstack-tox-py37/89752ac/job-output.txt | 18:03 |
| mriedem | dumping the libvirt host capabilities seems to be new | 18:03 |
| mriedem | which i wouldn't be surprised if something from the sev series added that | 18:03 |
| mriedem | INFO [nova.virt.libvirt.host] kernel doesn't support AMD SEV" | 18:03 |
| *** panda has joined #openstack-nova | 18:03 | |
| sean-k-mooney | ya i saw that | 18:03 |
| sean-k-mooney | that might be related although i did not see that in the other failed run | 18:04 |
| sean-k-mooney | https://4c970d31e6335324d673-0d0b23b7f62d479822a1b52b605369e3.ssl.cf1.rackcdn.com/682025/1/gate/nova-tox-functional-py36/5f76307/testr_results.html.gz | 18:04 |
| mriedem | the other failed run is a functional job | 18:04 |
| mriedem | looks like nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_xml_and_uri ? | 18:05 |
| sean-k-mooney | same wall of 00s | 18:05 |
| sean-k-mooney | oh damb i got the same issue locally | 18:06 |
| sean-k-mooney | with master | 18:06 |
| mriedem | if you look at a functional-py36 run that didn't fail, you'll still see lots of stuff dumped to output on passing tests https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_529/656594/7/gate/nova-tox-functional-py36/529d847/job-output.txt | 18:08 |
| mriedem | test_create_server_with_network_create_port_has_resource_request | 18:08 |
| sean-k-mooney | like this http://paste.openstack.org/show/775781/ | 18:08 |
| mriedem | test_boot_reschedule_fill_provider_mapping_raises | 18:08 |
| artom | Dumb solution, but move that capabilities logging to debug? | 18:09 |
| sean-k-mooney | its proably the 6 INFO [nova.virt.libvirt.host] Libvirt host capabilities <capabilities>' call | 18:09 |
| mriedem | artom: i have a better solution | 18:09 |
| mriedem | please hold | 18:09 |
| * artom trembles | 18:09 | |
| mriedem | with anticipation? | 18:10 |
| artom | Partially. | 18:10 |
| sean-k-mooney | so we remove https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L660 yes | 18:12 |
| sean-k-mooney | you mock it in the tests | 18:12 |
| mriedem | i'm going to move it into a separate method and stub it out in the libvirt fixture | 18:12 |
| sean-k-mooney | mriedem: ya that is a good way to handel that | 18:13 |
| artom | What about tests that don't use the fixture? All the fakelibvirt'y tests | 18:13 |
| sean-k-mooney | normally this would only print once as we cache the result | 18:13 |
| artom | Or just move it to init_host | 18:14 |
| artom | And not on every damn get_capabilities call | 18:15 |
| sean-k-mooney | it does not log on every call | 18:15 |
| sean-k-mooney | it logs once but we keep recreating the driver in the tests | 18:15 |
| artom | Ah, right, only if self._caps isn't set | 18:15 |
| sean-k-mooney | yes | 18:15 |
| mriedem | LibvirtConnTestCase is the bad one and that uses the fixture so i think we'll be ok | 18:15 |
| *** mjozefcz|away has joined #openstack-nova | 18:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: stub logging of host capabilities https://review.opendev.org/682133 | 18:21 |
| mriedem | tremble before this ^ | 18:21 |
| *** TxGirlGeek has quit IRC | 18:22 | |
| sean-k-mooney | isnt it awsome how it conflits with everything | 18:22 |
| mriedem | ha | 18:23 |
| sean-k-mooney | im running the tests localy | 18:23 |
| artom | Don't we have a thing about not changing code to work around CI? | 18:23 |
| sean-k-mooney | this is not a ci bug | 18:23 |
| sean-k-mooney | its a subunit parser bug | 18:23 |
| artom | Tru | 18:23 |
| artom | e | 18:23 |
| sean-k-mooney | so the alteritive is disbable test. which is worse or 1 day after FF replace our test framework with somethin that does not use stestr | 18:24 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22subunit.parser%5C%22%20AND%20message%3A%5C%22FAILED%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20project%3A%5C%22openstack%2Fnova%5C%22&from=7d | 18:24 |
| mriedem | for the recent nova hits on that bug | 18:24 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22subunit.parser%5C%22%20AND%20message%3A%5C%22FAILED%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20project%3A%5C%22openstack%2Fnova%5C%22&from=10d i guess is better | 18:24 |
| sean-k-mooney | so far it seams to be working locallly. do you want to rebases https://review.opendev.org/#/c/682025/ on top of combine them? | 18:27 |
| mriedem | i do'nt want to combine them | 18:27 |
| mriedem | and i don't know if we have cores around to approve the libvirt one | 18:28 |
| mriedem | looking at the other tracebacks in a passing functional test job, i see a lot of _allocate_network_async which makes me think (and i think these are negative scenario tests) that we're triggering a failure to satisfy the test, | 18:28 |
| mriedem | but then dropping something in the code, | 18:28 |
| mriedem | which gets logged and i'm thinking we might want to have a fixture that makes _allocate_network_async serial | 18:29 |
| mriedem | like the fixtures we have for spawn_n | 18:29 |
| mriedem | i mean we're hitting NetworkInfoAsyncWrapper which calls utils.spawn(_allocate_network_async) | 18:29 |
| sean-k-mooney | we use a fixture like that for the cells scater gather code too right | 18:29 |
| mriedem | so we might just not be using the spawn fixture in several places | 18:30 |
| sean-k-mooney | there are quite a few SADeprecationWarning too | 18:33 |
| sean-k-mooney | The Engine.contextual_connect() method is deprecated. | 18:33 |
| mriedem | and lots of "Detected removed column" | 18:34 |
| mriedem | we should probably squash alembic logging in tests | 18:34 |
| sean-k-mooney | well im not sure we would notice it was deprected if we did but maybe | 18:35 |
| mriedem | i'm talking about a different issue | 18:35 |
| mriedem | these | 18:35 |
| mriedem | 2019-09-13 17:33:40.316170 | ubuntu-bionic | 2019-09-13 17:33:40.248 4439 INFO alembic.autogenerate.compare [req-d6f4db5b-4ad9-4096-9832-08d8692555d7 fake fake - - -] Detected removed column 'build_requests.vm_state'[00m | 18:35 |
| sean-k-mooney | oh ok | 18:36 |
| mriedem | there are columns from the build_requests table that were removed from the model but not the schema | 18:36 |
| sean-k-mooney | like the vpmem coloum in the instance_extra table | 18:37 |
| sean-k-mooney | dont we normally whitelist to be ingored. i would have expected that to not be logged | 18:38 |
| sean-k-mooney | but i guess not | 18:38 |
| mriedem | idk | 18:38 |
| mriedem | idk where the message is coming from | 18:38 |
| mriedem | probably the walk migrations stuff | 18:38 |
| mriedem | yeah there is a whitelist in filter_metadata_diff | 18:39 |
| sean-k-mooney | the deprecation warnings at lesast are not coming form nova they are form sqlaclamate migrate | 18:39 |
| sean-k-mooney | eventrulally we will need to move off that | 18:40 |
| mriedem | yeah that's an old one | 18:40 |
| mriedem | i disagree | 18:40 |
| mriedem | just fix this https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1814288 | 18:40 |
| openstack | Launchpad bug 1814288 in sqlalchemy-migrate "DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead" [Medium,Confirmed] | 18:40 |
| mriedem | sqlalchemy.migrate is opened by openstack, i'm a core, it's in maintenance mode, and changing nova to go from migrate to alembic is not worth the trouble | 18:41 |
| sean-k-mooney | mriedem: didnt the maintainer say the did not want to maintain sqlalcamey migrate anymore | 18:41 |
| mriedem | at least not while i'm around | 18:41 |
| sean-k-mooney | oh ok | 18:41 |
| mriedem | openstack has maintained it for like 5 years now | 18:41 |
| mriedem | so patches welcome to fix https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1814288 | 18:42 |
| openstack | Launchpad bug 1814288 in sqlalchemy-migrate "DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead" [Medium,Confirmed] | 18:42 |
| mriedem | migrate is probably due for a release in ussuri | 18:42 |
| sean-k-mooney | well if i can squash some of those message simple then sure | 18:42 |
| sean-k-mooney | thats the allcoate error right http://paste.openstack.org/show/775783/ | 18:43 |
| sean-k-mooney | also http://paste.openstack.org/show/775785/ | 18:44 |
| sean-k-mooney | the functional test seamed to pass but i know that the subunit thing is somewhat non determinisitc | 18:45 |
| sean-k-mooney | huh when i open it in pycharm it sticts through getaragspec and tell you how to fix it | 18:51 |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Amend "Configure max number of volumes to attach" spec https://review.opendev.org/682136 | 18:51 |
| mriedem | i'm working on http://paste.openstack.org/show/775783/ | 18:51 |
| sean-k-mooney | ok i was going to fix the migrate issue since it seam simpler | 18:52 |
| mriedem | i can't quite figure out what's wrong with test_boot_reschedule_fill_provider_mapping_raises | 18:52 |
| sean-k-mooney | also you sounded like you had an idea how to fix it | 18:52 |
| mriedem | probably need gibi | 18:52 |
| mriedem | using the SpawnIsSynchronous fixture in test_boot_reschedule_fill_provider_mapping_raises definitely makes it fail on that IndexError | 18:52 |
| mriedem | i'm just not sure why yet | 18:53 |
| mriedem | but i think it's because it's stubbing out fill_provider_mapping | 18:53 |
| sean-k-mooney | ill open it and take a look but i dont know if ill be able to help i gues i can run it in a debugger and step in | 18:53 |
| *** xek_ has joined #openstack-nova | 18:54 | |
| sean-k-mooney | or not... its one of those test where the debuger does not work | 18:56 |
| artom | pysnoop | 18:57 |
| sean-k-mooney | its the placmenet fixture | 18:57 |
| sean-k-mooney | but i could use that i dont think it will help however | 18:57 |
| mriedem | got it | 18:57 |
| *** mjozefcz|away has quit IRC | 19:01 | |
| *** markvoelker has quit IRC | 19:04 | |
| *** markvoelker has joined #openstack-nova | 19:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use SpawnIsSynchronousFixture in reschedule functional tests https://review.opendev.org/682140 | 19:08 |
| mriedem | sean-k-mooney: ^ | 19:08 |
| sean-k-mooney | it seams to get rid fo the error | 19:10 |
| sean-k-mooney | how is mock_fill in scope? | 19:12 |
| sean-k-mooney | it refers to the mock you are creating in the with statemnet but you are using it in the stub fill provider mapping funciton | 19:13 |
| mriedem | python magic | 19:14 |
| mriedem | it's used in the function which isn't used until after the mock is setup | 19:14 |
| mriedem | anyway, as for https://review.opendev.org/#/c/682133/ i'm going to do a full py26,func-py36,pep8 locally and if that's good clark is going to promote to the gate | 19:14 |
| sean-k-mooney | right so its parsing the function signiture but not the body untill its used | 19:14 |
| *** lpetrut has joined #openstack-nova | 19:14 | |
| mriedem | yar | 19:14 |
| mriedem | that's something that always trips me up with python | 19:14 |
| sean-k-mooney | and by the time its use its inscope | 19:14 |
| sean-k-mooney | that is slightly terrifying but ok | 19:15 |
| artom | Wait, what? | 19:15 |
| *** lpetrut has quit IRC | 19:15 | |
| artom | The function can refer to its own mock? | 19:16 |
| *** lpetrut has joined #openstack-nova | 19:16 | |
| sean-k-mooney | dont look too closely https://review.opendev.org/#/c/682140/1/nova/tests/functional/test_servers.py@6808 | 19:16 |
| sean-k-mooney | you might go insane | 19:16 |
| artom | Too late, I clicked | 19:16 |
| *** markvoelker has quit IRC | 19:16 | |
| sean-k-mooney | but ya i get how it could work | 19:16 |
| artom | There's gotta be a less funky clever way of doing that | 19:16 |
| sean-k-mooney | i think there is a mock.wraps that does something similar | 19:17 |
| artom | Yeah | 19:17 |
| artom | Or even with side_effect | 19:17 |
| *** markvoelker has joined #openstack-nova | 19:17 | |
| artom | Something like side_effect=[original_fill] + itertools.repeat(raise) | 19:17 |
| sean-k-mooney | it is a side effect | 19:17 |
| sean-k-mooney | that is how the fuction is used | 19:18 |
| sean-k-mooney | *stub_fuction | 19:18 |
| artom | Right, I meant... we don't need the weirdly scoped function introspecting itself thing | 19:18 |
| sean-k-mooney | with all that said what mriedem worte appeares to work | 19:18 |
| artom | Not that it's not clever | 19:18 |
| artom | It'll just cause headaches to whoever has to work with it next | 19:18 |
| * artom starts the afternoon kids/home logistics | 19:26 | |
| artom | o/ see ya Monday | 19:26 |
| *** artom has quit IRC | 19:26 | |
| sean-k-mooney | oh i see what its doing its filling the provider mapping if tis not filled | 19:27 |
| sean-k-mooney | and raise an exception if called again | 19:28 |
| *** slaweq has quit IRC | 19:52 | |
| *** lpetrut has quit IRC | 19:58 | |
| *** panda has quit IRC | 20:05 | |
| *** panda has joined #openstack-nova | 20:08 | |
| *** igordc has joined #openstack-nova | 20:10 | |
| *** tbachman has quit IRC | 20:31 | |
| *** dannins has quit IRC | 20:44 | |
| mriedem | sean-k-mooney: heh, of course now the libvirt logging patch failed in the gate b/c of the functional notifications patch | 20:51 |
| *** openstackgerrit has quit IRC | 20:51 | |
| sean-k-mooney | nothing else would do sure :) i has to keep up the tradtion of the rest | 20:54 |
| *** henriqueof1 has quit IRC | 20:54 | |
| mriedem | corvus is going to promote both | 20:56 |
| *** markvoelker has quit IRC | 20:57 | |
| sean-k-mooney | if they fail again we might need to squash them. the failures are not determisitic so we should be able to merge them on there own but we might not want to retry them that much | 20:59 |
| *** pcaruana has quit IRC | 21:03 | |
| efried | o/ | 21:09 |
| efried | checking in | 21:09 |
| efried | I assume we're holding rechecks until we can merge some of those gate fixes mriedem? | 21:09 |
| efried | I've got eight or so lined up. | 21:10 |
| efried | rechecks, not fixes | 21:10 |
| *** slaweq has joined #openstack-nova | 21:11 | |
| mriedem | efried: yeah | 21:11 |
| mriedem | corvus just promoted to top of gate | 21:11 |
| efried | nice of him | 21:12 |
| mriedem | i think i just bring out the best in people | 21:12 |
| mriedem | you know? | 21:12 |
| efried | threats of violence will do that | 21:12 |
| mriedem | ha | 21:12 |
| efried | do you want me to merge https://review.opendev.org/#/c/682140/ ? | 21:13 |
| efried | despite artom hatin on it | 21:13 |
| *** luksky11 has quit IRC | 21:14 | |
| efried | even though you spelled stacktrace wrong | 21:14 |
| *** slaweq has quit IRC | 21:16 | |
| sean-k-mooney | he did. unsurpisingly i did not notice | 21:17 |
| mriedem | i got it correct in one spot | 21:18 |
| mriedem | i was rushing | 21:18 |
| mriedem | it's up to me if you want to approve it or let it sit, it's not the big blow up like the libvirt host capabilities one | 21:18 |
| *** KeithMnemonic has quit IRC | 21:19 | |
| mriedem | i think both your alternative and artom's are equally gross | 21:20 |
| sean-k-mooney | ya that one does not actully casuse the test to fail and the log mesage is like 20 lines vs 100s | 21:20 |
| efried | how many times do we actually need to raise? | 21:20 |
| sean-k-mooney | well once really. the stub raises if its called more then once | 21:21 |
| sean-k-mooney | i doubt we will call it again if we raise | 21:21 |
| *** zhubx has joined #openstack-nova | 21:22 | |
| sean-k-mooney | i +1'd it because a.) it works and b.) while it was surpising at first glance i understand how it works after looking at it for 30 seconds | 21:22 |
| mriedem | you can't use wraps because we need to side effect the error in the 2nd call, | 21:22 |
| sean-k-mooney | ya you cant | 21:23 |
| sean-k-mooney | i tried | 21:23 |
| mriedem | and we can't just mock it because the test fails if you don't actually call the original method on the first pass | 21:23 |
| sean-k-mooney | yep | 21:23 |
| mriedem | and that was the bug i uncovered | 21:23 |
| sean-k-mooney | out of interest why do you dislike moveing the stub function inside the mock context manager | 21:24 |
| *** boxiang has quit IRC | 21:24 | |
| sean-k-mooney | functionally its identiacla to what you wrote but im just wondering out of interest | 21:25 |
| efried | I approved it. | 21:28 |
| mriedem | sean-k-mooney: but it's late on a friday and i don't feel like updating the patch :) | 21:29 |
| mriedem | and i'm trying to do some education stuff | 21:29 |
| mriedem | *b/c | 21:29 |
| sean-k-mooney | that totally fair | 21:30 |
| sean-k-mooney | i was just wondering if you had a technical reason i missed | 21:30 |
| sean-k-mooney | as i said i +1 because i was ok with what you wrote and didnt think it was really worth a respin | 21:31 |
| efried | okay, unless there's something else I can do here, I'm going to bugger back off and just monitor the gate | 21:32 |
| efried | looks like we're back up to a 12h delay \o/ | 21:32 |
| *** efried is now known as efried_afk | 21:35 | |
| *** tbachman has joined #openstack-nova | 21:36 | |
| *** xek_ has quit IRC | 21:46 | |
| *** JamesBenson has quit IRC | 21:46 | |
| *** xek has joined #openstack-nova | 21:47 | |
| *** openstackgerrit has joined #openstack-nova | 21:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix a misuse of assertGreaterEqual https://review.opendev.org/682168 | 21:48 |
| *** tbachman has quit IRC | 21:48 | |
| *** xek has quit IRC | 21:49 | |
| *** xek has joined #openstack-nova | 21:49 | |
| *** mriedem has left #openstack-nova | 21:49 | |
| *** xek_ has joined #openstack-nova | 21:52 | |
| *** xek has quit IRC | 21:55 | |
| *** mriedem has joined #openstack-nova | 22:04 | |
| *** markvoelker has joined #openstack-nova | 22:09 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** markvoelker has quit IRC | 22:14 | |
| *** slaweq has quit IRC | 22:16 | |
| *** hemna has joined #openstack-nova | 22:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: neutron: refactor nw info cache refresh out of associate_floating_ip https://review.opendev.org/682181 | 22:24 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Trap and log errors from _update_inst_info_cache_for_disassociated_fip https://review.opendev.org/682182 | 22:24 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Find instance in another cell during floating IP re-association https://review.opendev.org/682183 | 22:24 |
| mriedem | gibi: just so you're aware we're trying to get https://review.opendev.org/#/c/682133/ and https://review.opendev.org/#/c/682025/ through the gate since things keep failing on those bugs | 22:28 |
| *** mriedem is now known as mriedem_afk | 22:30 | |
| *** macz has quit IRC | 22:58 | |
| *** xek_ has quit IRC | 22:59 | |
| *** hemna has quit IRC | 23:03 | |
| *** tbachman has joined #openstack-nova | 23:08 | |
| *** JamesBenson has joined #openstack-nova | 23:23 | |
| *** JamesBenson has quit IRC | 23:27 | |
| *** gyee has quit IRC | 23:32 | |
| *** gyee has joined #openstack-nova | 23:35 | |
| *** gyee has quit IRC | 23:51 | |
| *** ozzzo has quit IRC | 23:51 | |
| *** rcernin has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!