| *** avolkov has quit IRC | 00:01 | |
| *** threestrands has quit IRC | 00:03 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** markvoelker has joined #openstack-nova | 00:15 | |
| *** markvoelker has quit IRC | 00:20 | |
| *** dpawlik has joined #openstack-nova | 00:20 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 00:24 |
|---|---|---|
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 00:24 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 00:24 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 00:24 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 00:24 |
| *** dpawlik has quit IRC | 00:24 | |
| dustinc | 🤞 | 00:24 |
| dustinc | "all tests pass on my machine" | 00:25 |
| *** tbachman has quit IRC | 00:33 | |
| *** gbarros has quit IRC | 00:34 | |
| *** tbachman has joined #openstack-nova | 00:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Ussuri https://review.opendev.org/679364 | 00:35 |
| artom | mriedem, ack - thanks for spending time on this | 00:35 |
| *** mlavalle has quit IRC | 00:44 | |
| *** hongbin has quit IRC | 00:44 | |
| *** tbachman_ has joined #openstack-nova | 00:45 | |
| *** mriedem has quit IRC | 00:45 | |
| *** tbachman has quit IRC | 00:45 | |
| *** tbachman_ is now known as tbachman | 00:45 | |
| *** brinzhang_ has joined #openstack-nova | 01:01 | |
| *** bhagyashris has joined #openstack-nova | 01:03 | |
| *** brinzhang has quit IRC | 01:04 | |
| *** licanwei has quit IRC | 01:12 | |
| *** itlinux-away is now known as itlinux | 01:39 | |
| *** itlinux is now known as itlinux-away | 01:56 | |
| *** markvoelker has joined #openstack-nova | 02:05 | |
| *** markvoelker has quit IRC | 02:10 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| openstackgerrit | Fan Zhang proposed openstack/nova master: Clear RequestSpec requested_destination and ignore_hosts in confirm/revert resize. https://review.opendev.org/679212 | 02:14 |
| *** ricolin has joined #openstack-nova | 02:16 | |
| *** slaweq has quit IRC | 02:16 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 02:17 |
| *** tetsuro has joined #openstack-nova | 02:20 | |
| *** dpawlik has joined #openstack-nova | 02:21 | |
| *** brinzhang has joined #openstack-nova | 02:22 | |
| *** dpawlik has quit IRC | 02:25 | |
| *** brinzhang_ has quit IRC | 02:26 | |
| *** nicolasbock has quit IRC | 02:52 | |
| *** hongbin has joined #openstack-nova | 03:02 | |
| *** psachin has joined #openstack-nova | 03:17 | |
| *** itlinux-away is now known as itlinux | 03:31 | |
| openstackgerrit | Merged openstack/nova master: Add FUP unit test for port heal allocations https://review.opendev.org/672142 | 03:50 |
| *** mkrai has joined #openstack-nova | 03:52 | |
| *** udesale has joined #openstack-nova | 03:52 | |
| *** mkrai has quit IRC | 03:55 | |
| *** mkrai has joined #openstack-nova | 03:58 | |
| *** dklyle has quit IRC | 04:00 | |
| *** david-lyle has joined #openstack-nova | 04:00 | |
| *** slaweq has joined #openstack-nova | 04:03 | |
| *** slaweq has quit IRC | 04:08 | |
| *** mkrai has quit IRC | 04:09 | |
| *** mkrai has joined #openstack-nova | 04:11 | |
| *** dave-mccowan has quit IRC | 04:14 | |
| *** hongbin has quit IRC | 04:19 | |
| *** jhesketh has quit IRC | 04:20 | |
| *** dpawlik has joined #openstack-nova | 04:22 | |
| *** mkrai has quit IRC | 04:22 | |
| *** mkrai has joined #openstack-nova | 04:23 | |
| *** dpawlik has quit IRC | 04:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Ussuri https://review.opendev.org/679364 | 04:43 |
| *** ratailor has joined #openstack-nova | 04:48 | |
| *** ratailor has quit IRC | 04:50 | |
| *** ratailor has joined #openstack-nova | 04:50 | |
| *** larainema has joined #openstack-nova | 04:54 | |
| *** ccamacho has joined #openstack-nova | 05:00 | |
| *** markvoelker has joined #openstack-nova | 05:00 | |
| *** bhagyashris has quit IRC | 05:00 | |
| *** tkajinam has quit IRC | 05:05 | |
| *** markvoelker has quit IRC | 05:06 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** tetsuro has quit IRC | 05:12 | |
| *** slaweq has quit IRC | 05:15 | |
| *** hamzy has quit IRC | 05:16 | |
| *** tetsuro has joined #openstack-nova | 05:18 | |
| *** stakeda has quit IRC | 05:20 | |
| *** jaosorior has joined #openstack-nova | 05:27 | |
| *** dpawlik has joined #openstack-nova | 05:30 | |
| openstackgerrit | Merged openstack/nova master: Move live_migration test hooks under gate/ https://review.opendev.org/679251 | 05:37 |
| *** tkajinam has joined #openstack-nova | 05:41 | |
| *** igordc has quit IRC | 05:46 | |
| *** slaweq has joined #openstack-nova | 06:08 | |
| *** sapd1 has joined #openstack-nova | 06:08 | |
| *** slaweq has quit IRC | 06:13 | |
| *** xek has joined #openstack-nova | 06:18 | |
| *** luksky has joined #openstack-nova | 06:28 | |
| *** brault has joined #openstack-nova | 06:30 | |
| *** brault has quit IRC | 06:35 | |
| *** avolkov has joined #openstack-nova | 06:35 | |
| *** rcernin has quit IRC | 06:48 | |
| *** aojea has joined #openstack-nova | 06:49 | |
| *** sapd1 has quit IRC | 06:49 | |
| *** slaweq has joined #openstack-nova | 06:49 | |
| *** slaweq has quit IRC | 06:54 | |
| openstackgerrit | ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298 | 06:59 |
| openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | 06:59 |
| openstackgerrit | ya.wang proposed openstack/nova master: Support reporting multi CPU model traits https://review.opendev.org/670300 | 06:59 |
| openstackgerrit | LEIJIE SHA proposed openstack/os-vif master: Fix code bug in document https://review.opendev.org/679382 | 07:04 |
| *** slaweq has joined #openstack-nova | 07:05 | |
| *** trident has quit IRC | 07:10 | |
| *** itlinux is now known as itlinux-away | 07:11 | |
| *** trident has joined #openstack-nova | 07:18 | |
| *** trident has quit IRC | 07:22 | |
| *** trident has joined #openstack-nova | 07:30 | |
| *** lpetrut has joined #openstack-nova | 07:30 | |
| *** jhesketh has joined #openstack-nova | 07:38 | |
| *** cdent has joined #openstack-nova | 07:39 | |
| *** tetsuro has quit IRC | 07:46 | |
| *** dtantsur|afk is now known as dtantsur | 07:46 | |
| *** ivve has joined #openstack-nova | 07:50 | |
| *** shilpasd has joined #openstack-nova | 08:01 | |
| *** cdent has quit IRC | 08:06 | |
| *** dougsz has joined #openstack-nova | 08:07 | |
| *** jaosorior has quit IRC | 08:07 | |
| *** brault has joined #openstack-nova | 08:12 | |
| *** mdbooth has joined #openstack-nova | 08:12 | |
| *** dpawlik has quit IRC | 08:12 | |
| *** markvoelker has joined #openstack-nova | 08:21 | |
| *** ralonsoh has joined #openstack-nova | 08:26 | |
| *** markvoelker has quit IRC | 08:27 | |
| *** tkajinam has quit IRC | 08:27 | |
| *** derekh has joined #openstack-nova | 08:35 | |
| *** dpawlik has joined #openstack-nova | 08:39 | |
| *** cdent has joined #openstack-nova | 08:41 | |
| *** dpawlik has quit IRC | 08:43 | |
| stephenfin | bauzas, sean-k-mooney, alex_xu: You'll probably be interested in Bhagyashri's comments here https://review.opendev.org/#/c/674895/ | 08:50 |
| * bauzas clicks | 08:50 | |
| stephenfin | tl;dr: It works as expected but we do need to tweak that config option as noted | 08:50 |
| sean-k-mooney | e.g. default it to true | 08:51 |
| bauzas | yup, makes sense | 08:51 |
| bauzas | what ? I'm not always saying terrible ideas ? | 08:52 |
| bauzas | so sad | 08:52 |
| bauzas | :p | 08:52 |
| *** dpawlik has joined #openstack-nova | 08:52 | |
| bauzas | stephenfin: FWIW, I'll start looking over the rest of the series later in the afternoon | 08:54 |
| sean-k-mooney | by the way thanks to donnyd we now have a multi numa lable in the gate with nested vert adn teh ablity to use hugepages,dpdk,and pinning testing in the gate... os i have a ci job to go right | 08:55 |
| sean-k-mooney | *write | 08:55 |
| bauzas | cool | 08:56 |
| sean-k-mooney | oh by the way i mentioned this to artom alreay but i also figured out how to do nested pci passthough over the weekend | 08:57 |
| sean-k-mooney | e.g. pci passthough from a host all the way to an l2 guest | 08:57 |
| sean-k-mooney | and i might be able to use virtual device in the l1 guest as pci deivce to the l2 guest also. | 08:58 |
| sean-k-mooney | nova cant do it yet due to how we currently generate teh xml but i might be able to use that to test sriov or pci passthough at some point. | 08:59 |
| kashyap | sean-k-mooney: On nested PCI passthrough, have you seen this past blog from DanPB: https://www.berrange.com/posts/2017/02/16/setting-up-a-nested-kvm-guest-for-developing-testing-pci-device-assignment-with-numa/ | 08:59 |
| stephenfin | bauzas: Not always terrible. Just mostly terrible ;) | 09:00 |
| bauzas | like proposing to ski over a weekend ? | 09:00 |
| *** dougsz has quit IRC | 09:00 | |
| bauzas | I can assume that | 09:00 |
| stephenfin | that was one of the non-terrible ones | 09:01 |
| sean-k-mooney | kashyap i think a few years ago | 09:01 |
| sean-k-mooney | kashyap: once we got a virtula iommu and q35 we could technically do it | 09:01 |
| sean-k-mooney | but the issue is getin ghte right pci tree such that the passthough devices are in there own iommu group | 09:02 |
| sean-k-mooney | and ya i have been advocating creating a pci root per numa node for years at this point | 09:03 |
| kashyap | sean-k-mooney: On virtual IOMMU, there was a talk on its implementation earlier this year at FOSDEM: | 09:03 |
| kashyap | https://archive.fosdem.org/2019/schedule/event/vai_iommu_implementation_using_hw_nested_paging/ | 09:03 |
| kashyap | (It's a different approach to existing impl.) | 09:03 |
| sean-k-mooney | ok | 09:04 |
| sean-k-mooney | at this point if qemu supported a virtual device that had sriov support we would have everything we need to be able to test sriov in the gate | 09:08 |
| sean-k-mooney | well assuming we lanned all the reuqired changes in openstack and a cloud provier or two ran that version and hadn the correct flavors | 09:08 |
| kashyap | sean-k-mooney: QEMU supporting an emulated SRIOV device is the key bit -- needs someone familiar with a card to implement it. | 09:10 |
| kashyap | I won't count on it, though | 09:10 |
| *** jaosorior has joined #openstack-nova | 09:10 | |
| sean-k-mooney | there were patches for it before | 09:10 |
| sean-k-mooney | they just never landed | 09:10 |
| *** hamzy has joined #openstack-nova | 09:10 | |
| sean-k-mooney | kashyap: https://github.com/knuto/qemu | 09:11 |
| kashyap | sean-k-mooney: Yes, I know the author. He works for Oracle | 09:11 |
| kashyap | Last I checked he had a student working on it...but the student left | 09:12 |
| kashyap | Knut ('knuto') introduced the supporting infrastructure for adding an emulated SRIOV card | 09:12 |
| *** xek has quit IRC | 09:20 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 09:22 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 09:26 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 09:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | 09:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 09:37 |
| *** mkrai has quit IRC | 09:39 | |
| *** mkrai has joined #openstack-nova | 09:39 | |
| sean-k-mooney | just tested the v22 iteration of artoms patches and its still working correctly | 09:39 |
| *** dpawlik has quit IRC | 09:46 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add operator user_id/project_id to the migrations https://review.opendev.org/679413 | 09:49 |
| *** mkrai has quit IRC | 09:49 | |
| *** luksky has quit IRC | 09:52 | |
| sean-k-mooney | for those not on the neutron channel i just confrimed that cold migration and live migration with vnic_type=direct-physical is broken | 10:08 |
| sean-k-mooney | there are at least two related issues, 1 we do not update the mac on migration and second we do not correctly find the device to detach it on live migration | 10:09 |
| sean-k-mooney | live migration also like has the first issue but its failing before it gets that far | 10:09 |
| *** icarusfactor has quit IRC | 10:11 | |
| *** icarusfactor has joined #openstack-nova | 10:11 | |
| *** dpawlik has joined #openstack-nova | 10:12 | |
| *** icarusfactor has quit IRC | 10:12 | |
| sean-k-mooney | it looks like detach works correctly for suspend and the live migration code should be useing the same fucntion i think but maybe its not | 10:12 |
| *** icarusfactor has joined #openstack-nova | 10:13 | |
| sean-k-mooney | im going to try and fix this next week and ill file the upstream bug shortly. i think the cold migration behavior is broken all the way back to queens. the live migration behavior is obviouly new since we added that this cycle | 10:14 |
| *** factor__ has joined #openstack-nova | 10:17 | |
| *** icarusfactor has quit IRC | 10:20 | |
| *** brault has quit IRC | 10:23 | |
| *** trident has quit IRC | 10:23 | |
| *** aojea has quit IRC | 10:23 | |
| *** udesale has quit IRC | 10:23 | |
| *** brinzhang has quit IRC | 10:23 | |
| *** tbachman has quit IRC | 10:23 | |
| *** cgoncalves has quit IRC | 10:23 | |
| *** francoisp has quit IRC | 10:23 | |
| *** bnemec has quit IRC | 10:23 | |
| *** owalsh|away has quit IRC | 10:23 | |
| *** frickler has quit IRC | 10:23 | |
| *** NostawRm has quit IRC | 10:23 | |
| *** tobias-urdin has quit IRC | 10:23 | |
| *** mloza has quit IRC | 10:24 | |
| *** lyarwood has quit IRC | 10:24 | |
| *** efried has quit IRC | 10:24 | |
| *** kevinbenton has quit IRC | 10:24 | |
| *** dtruong has quit IRC | 10:24 | |
| *** jbernard has quit IRC | 10:24 | |
| *** edleafe has quit IRC | 10:24 | |
| *** mandre has quit IRC | 10:24 | |
| *** ebbex has quit IRC | 10:24 | |
| *** eandersson has quit IRC | 10:24 | |
| *** evrardjp has quit IRC | 10:24 | |
| *** amorin has quit IRC | 10:24 | |
| *** lifeless has quit IRC | 10:24 | |
| *** weshay_pto has quit IRC | 10:24 | |
| *** ociuhandu has joined #openstack-nova | 10:24 | |
| *** NostawRm has joined #openstack-nova | 10:24 | |
| *** trident has joined #openstack-nova | 10:24 | |
| *** frickler has joined #openstack-nova | 10:24 | |
| stephenfin | aspiers: Hit that whole SEV series. Couple of comments left, but ping me when you've tackled them and I'll re-review | 10:25 |
| *** irclogbot_3 has quit IRC | 10:25 | |
| *** lbragstad has quit IRC | 10:25 | |
| *** brinzhang has joined #openstack-nova | 10:26 | |
| *** jbernard has joined #openstack-nova | 10:26 | |
| *** cgoncalves has joined #openstack-nova | 10:26 | |
| *** brinzhang has quit IRC | 10:26 | |
| *** aojea has joined #openstack-nova | 10:26 | |
| *** efried has joined #openstack-nova | 10:27 | |
| *** kevinbenton has joined #openstack-nova | 10:27 | |
| *** evrardjp has joined #openstack-nova | 10:27 | |
| *** lbragstad has joined #openstack-nova | 10:27 | |
| *** brinzhang has joined #openstack-nova | 10:27 | |
| *** tbachman has joined #openstack-nova | 10:27 | |
| *** dtruong has joined #openstack-nova | 10:27 | |
| *** owalsh has joined #openstack-nova | 10:27 | |
| *** irclogbot_3 has joined #openstack-nova | 10:28 | |
| *** bnemec has joined #openstack-nova | 10:28 | |
| *** lifeless has joined #openstack-nova | 10:29 | |
| *** ebbex has joined #openstack-nova | 10:29 | |
| *** amorin has joined #openstack-nova | 10:33 | |
| *** mandre has joined #openstack-nova | 10:33 | |
| artom | sean-k-mooney, hey, so how feasible would be to hack together a tempest job that runs https://review.rdoproject.org/r/#/c/18832/ on that new FN flavor? | 10:36 |
| artom | ('morning!) | 10:36 |
| sean-k-mooney | artom: well my nfv test job did actully work a few months ago so i could make it work on FN pretty quick | 10:37 |
| sean-k-mooney | as in today | 10:37 |
| sean-k-mooney | but im currently reworking functional test | 10:37 |
| sean-k-mooney | want me to give it ago when im done | 10:38 |
| *** mkrai has joined #openstack-nova | 10:38 | |
| artom | sean-k-mooney, that'd be awesome :) whitebox needs a bunch of configs to be set, I can help with those | 10:38 |
| artom | https://review.opendev.org/#/c/678887/ failed with KVM errors, so I'm trying think of other possibilities | 10:39 |
| sean-k-mooney | ya well first thing would be to just get it stacking multinode with a few smoketests. then we can add the plugin | 10:39 |
| artom | Right, baby steps :) | 10:40 |
| sean-k-mooney | artom: i dont see errors in the n-cpu log | 10:40 |
| sean-k-mooney | oh multinode | 10:41 |
| sean-k-mooney | still no erros on the other node | 10:41 |
| artom | sean-k-mooney, no, they're in the qemu logs | 10:42 |
| artom | ex: https://zuul.opendev.org/t/openstack/build/905b52e0b1e84532944f0606b5455381/log/logs/subnode-2/libvirt/qemu/instance-00000005.txt.gz | 10:42 |
| *** ociuhandu has quit IRC | 10:42 | |
| sean-k-mooney | oh thats the kernel bug i mentioned to donnyd | 10:42 |
| sean-k-mooney | actully may be not | 10:42 |
| sean-k-mooney | it could be but that looks like an issue with the cpu model | 10:43 |
| donnyd | i am using host-passthrough on nova | 10:43 |
| *** jaosorior has quit IRC | 10:43 | |
| sean-k-mooney | its checking for svm with is amds version of vt-x | 10:43 |
| sean-k-mooney | donnyd: ya this is on vexhost | 10:43 |
| sean-k-mooney | but i think this is a different issue | 10:44 |
| donnyd | oh | 10:44 |
| sean-k-mooney | ya so | 10:44 |
| sean-k-mooney | [libvirt] | 10:44 |
| sean-k-mooney | live_migration_uri = qemu+ssh://stack@%s/system | 10:44 |
| sean-k-mooney | cpu_mode = none | 10:44 |
| sean-k-mooney | virt_type = kvm | 10:44 |
| sean-k-mooney | we should be setting cpu_mode=custom and cpu_model=kvm64 in devstack | 10:45 |
| sean-k-mooney | with cpu_mode=none we default to host-model | 10:45 |
| sean-k-mooney | but host-model does not always detect the capablity proably espcailly with nested virt | 10:45 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 10:45 |
| artom | sean-k-mooney, I'll just add that to Matt's devstack nuke | 10:46 |
| sean-k-mooney | so this host whihc is likel intel x86 was detected as support svm which from the kvm error it is not | 10:46 |
| sean-k-mooney | cool | 10:46 |
| artom | But coffee first | 10:46 |
| sean-k-mooney | kvm64 is the most portable cpu model that work with kvm | 10:46 |
| * artom is running on sleep fumes this week. | 10:46 | |
| artom | Daughter started school. I'm guess I'm just excited/stressed for her. | 10:47 |
| sean-k-mooney | first time | 10:47 |
| artom | Gym attendance took a hit as well | 10:47 |
| artom | Yeah | 10:47 |
| kashyap | sean-k-mooney: IIRC, there was a reason we went with existing CPU model 'qemu64' | 10:47 |
| kashyap | In DevStack | 10:48 |
| sean-k-mooney | that can be stressful for both her and you. im sure it will be fine | 10:48 |
| kashyap | Because not all Gate hosts support KVM | 10:48 |
| sean-k-mooney | kashyap: yes but we are specific testing someing with nested vert | 10:48 |
| sean-k-mooney | e.g we are hardcodeing stuff and targeting 1 cloud that does | 10:48 |
| sean-k-mooney | so we are trying to undo all the other suff that hard codes it to qemu | 10:48 |
| *** tbachman has quit IRC | 10:49 | |
| kashyap | sean-k-mooney: Ah, for that context, sure | 10:49 |
| alex_xu | stephenfin: emm...all are expected, since he still using vcpu_pin_set, that means no PCPU | 10:49 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 10:50 |
| sean-k-mooney | kashyap: ill be writing a sperate permenet job later but this is a quick hack just to do some non me testing of artoms code | 10:50 |
| kashyap | sean-k-mooney: Sure. I didn't realize the full context. | 10:50 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 10:50 |
| sean-k-mooney | kashyap: its kind of a libvirt/qemu bug. | 10:51 |
| sean-k-mooney | with host model it should not be trying to use svm for the l2 guest on a l1 guest that does not have it | 10:52 |
| sean-k-mooney | but if we use kvm64 it wont do that so its all good | 10:52 |
| sean-k-mooney | i would not run real workload with kvm64 but its perfect for testing | 10:52 |
| *** luksky has joined #openstack-nova | 10:53 | |
| kashyap | sean-k-mooney: What precisely is a libvirt/QEMU bug? /me reads on | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 10:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 10:53 |
| sean-k-mooney | kashyap: we are default to host-model because cpu_mode is none | 10:54 |
| sean-k-mooney | but https://zuul.opendev.org/t/openstack/build/905b52e0b1e84532944f0606b5455381/log/logs/subnode-2/libvirt/qemu/instance-00000005.txt.gz | 10:54 |
| kashyap | sean-k-mooney: Right | 10:54 |
| sean-k-mooney | but qemu expose an cpu flag to the l2 guest that the l1 guest does not suport | 10:55 |
| kashyap | sean-k-mooney: Hmm. (Also, yes, agreed - on kvm64 for testing-only) | 10:56 |
| sean-k-mooney | its deffintly a qemu bug since we are not passing the -cpu flag at all in this case | 10:56 |
| sean-k-mooney | so its up to qemu to figure out what cpu model to use and it selected an invalid one for the host | 10:56 |
| kashyap | sean-k-mooney: File a bug, please, if you're confident. I'm struggling to multi-task | 10:57 |
| kashyap | I'll be interested to see a simple reproducer. | 10:57 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add operator user_id/project_id to the migrations https://review.opendev.org/679413 | 10:57 |
| sean-k-mooney | i have hit this many many times | 10:57 |
| sean-k-mooney | its been a thing in qemu for quite a while | 10:58 |
| sean-k-mooney | but yes i should file a bug | 10:58 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | 10:58 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | 10:58 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | 10:58 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | 10:58 |
| *** artom has quit IRC | 10:58 | |
| *** artom has joined #openstack-nova | 10:59 | |
| sean-k-mooney | the reproduce is basicaly boot a qemu l2 gues with kvm enabled in a l1 guest where the host is intel x86 | 10:59 |
| sean-k-mooney | it picks up support for vmx in the l1 guest but enable svm in the l2 guest | 10:59 |
| donnyd | sean-k-mooney: is the numa thing working | 10:59 |
| sean-k-mooney | i have seen other similar case for other instruction too | 10:59 |
| *** jaosorior has joined #openstack-nova | 10:59 | |
| sean-k-mooney | donnyd: havent tried it yet | 11:00 |
| donnyd | oh ok | 11:00 |
| sean-k-mooney | but im 99% sure it will | 11:00 |
| sean-k-mooney | you have configured the flavor more or less how i do for dev | 11:00 |
| *** artom has quit IRC | 11:00 | |
| *** artom has joined #openstack-nova | 11:01 | |
| *** artom has joined #openstack-nova | 11:01 | |
| *** ociuhandu has joined #openstack-nova | 11:02 | |
| stephenfin | kashyap: Is the secure boot spec punted til U? | 11:02 |
| stephenfin | *to | 11:02 |
| stephenfin | (i.e. https://review.opendev.org/#/c/506720/) | 11:02 |
| kashyap | stephenfin: No, it's not. It's the CPU APIs spec that's punted to U | 11:03 |
| kashyap | SB spec aiming for Train, still. I'm optimistic like that | 11:03 |
| *** nicolasbock has joined #openstack-nova | 11:05 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 11:05 |
| * aspiers is back | 11:10 | |
| *** brinzhang has quit IRC | 11:13 | |
| *** ociuhandu has quit IRC | 11:14 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 11:21 |
| *** artom has joined #openstack-nova | 11:22 | |
| *** slaweq has quit IRC | 11:26 | |
| openstackgerrit | Merged openstack/nova master: Add functional test for AggregateMultiTenancyIsolation + migrate https://review.opendev.org/571265 | 11:27 |
| *** cdent has quit IRC | 11:30 | |
| *** ricolin has quit IRC | 11:35 | |
| *** dpawlik has quit IRC | 11:39 | |
| *** tesseract has joined #openstack-nova | 11:42 | |
| *** aojea has quit IRC | 11:46 | |
| *** ratailor has quit IRC | 11:48 | |
| *** jawad_axd has joined #openstack-nova | 11:48 | |
| *** ociuhandu has joined #openstack-nova | 11:50 | |
| *** markvoelker has joined #openstack-nova | 11:51 | |
| *** cdent has joined #openstack-nova | 11:52 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340 | 11:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340 | 11:57 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339 | 11:57 |
| *** ociuhandu has quit IRC | 11:57 | |
| *** lee1 has joined #openstack-nova | 11:59 | |
| *** lee1 is now known as lyarwood | 11:59 | |
| *** dave-mccowan has joined #openstack-nova | 12:02 | |
| *** tbachman has joined #openstack-nova | 12:06 | |
| *** dpawlik has joined #openstack-nova | 12:12 | |
| openstackgerrit | sean mooney proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | 12:15 |
| openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney) | 12:15 |
| openstackgerrit | sean mooney proposed openstack/nova master: Whether to use config drive depends on instance.configdrive https://review.opendev.org/485930 | 12:15 |
| sean-k-mooney | ... i forgot to update the commit message | 12:16 |
| sean-k-mooney | actully no never mind i di | 12:16 |
| sean-k-mooney | didnt need too | 12:16 |
| *** dpawlik has quit IRC | 12:16 | |
| lyarwood | urgh, stupid question time. I'm using functional.libvirt.base.ServersTestBase and mocking calls to nova.virt.libvirt.host.Host.get_connection but my functional test is still barfing http://paste.openstack.org/show/767633/ | 12:19 |
| sean-k-mooney | yep | 12:19 |
| sean-k-mooney | so that does not work proably | 12:19 |
| sean-k-mooney | you have to use _host i think | 12:19 |
| sean-k-mooney | its sometimes works proably and sometiems does not dependin on your other mocking | 12:20 |
| lyarwood | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1595962.py - yeah I'm basically following the approach taken in here | 12:21 |
| lyarwood | but using https://github.com/openstack/nova/blob/744615559eb575bb0cf0a5ddc91acf255ebc3825/nova/tests/functional/libvirt/base.py#L30-L93 as the base class | 12:22 |
| lyarwood | aaaaaaah that's already mocking it in setup | 12:22 |
| lyarwood | my bad | 12:22 |
| sean-k-mooney | this | 12:23 |
| sean-k-mooney | self.useFixture(fixtures.MonkeyPatch( | 12:23 |
| sean-k-mooney | 'nova.virt.libvirt.host.libvirt', | 12:23 |
| sean-k-mooney | fakelibvirt)) | 12:23 |
| sean-k-mooney | when you do | 12:24 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1595962.py#L41 | 12:24 |
| lyarwood | No, lower | 12:24 |
| lyarwood | # Mock the 'get_connection' function, as we're going to need to provide | 12:24 |
| lyarwood | # custom capabilities for each test | 12:24 |
| lyarwood | _p = mock.patch('nova.virt.libvirt.host.Host.get_connection') | 12:24 |
| lyarwood | self.mock_conn = _p.start() | 12:24 |
| lyarwood | self.addCleanup(_p.stop) | 12:24 |
| *** dpawlik has joined #openstack-nova | 12:25 | |
| sean-k-mooney | i dont see that in the file you linked but sounds like you have figured it out | 12:25 |
| lyarwood | sean-k-mooney: sorry that's in the base class I'm using in the second link | 12:27 |
| lyarwood | sean-k-mooney: and yeah it's working now | 12:27 |
| *** ociuhandu has joined #openstack-nova | 12:27 | |
| *** derekh has quit IRC | 12:27 | |
| *** francoisp has joined #openstack-nova | 12:28 | |
| *** xek has joined #openstack-nova | 12:31 | |
| *** brault has joined #openstack-nova | 12:33 | |
| *** ociuhandu has quit IRC | 12:33 | |
| openstackgerrit | François Palin proposed openstack/nova master: Add retry when attachment_delete or terminate_connection fails https://review.opendev.org/669674 | 12:41 |
| *** larainema has quit IRC | 12:43 | |
| openstackgerrit | sean mooney proposed openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964 | 12:45 |
| sean-k-mooney | prometheanfire: efried ^ now using self.assertXmlEqual | 12:45 |
| aspiers | sean-k-mooney: \o/ | 12:46 |
| aspiers | glad I invested some time into that function | 12:46 |
| sean-k-mooney | i was doing it the old way | 12:46 |
| sean-k-mooney | then erric remided me it existited | 12:46 |
| sean-k-mooney | i dont know why testtoold decied that matches shoudl return nothing for sucess | 12:47 |
| sean-k-mooney | but i hate that api so im glad we have a wrapper | 12:47 |
| sean-k-mooney | prometheanfire: actully we need to invert the depends on relationship | 12:48 |
| sean-k-mooney | your upperconstaits bump needs to depend on the nova change | 12:48 |
| openstackgerrit | sean mooney proposed openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964 | 12:49 |
| efried | sean-k-mooney: +2, thank you | 12:49 |
| efried | race condition | 12:49 |
| sean-k-mooney | efried: hehe care to +2 again | 12:49 |
| efried | done | 12:49 |
| sean-k-mooney | thanks | 12:49 |
| sean-k-mooney | prometheanfire: do you mind if i update your patch to depend on mine | 12:50 |
| efried | since you were updating the commit message, you could have s/XMLMatcher/assertXmlEqaual/ | 12:50 |
| efried | but technically still true, so meh | 12:50 |
| sean-k-mooney | oh i can if you want | 12:50 |
| efried | nah | 12:50 |
| sean-k-mooney | ok | 12:50 |
| *** mriedem has joined #openstack-nova | 12:51 | |
| luyao | dansmith: Are you around? | 12:51 |
| *** xek has quit IRC | 12:52 | |
| mriedem | luyao: he's out today | 12:56 |
| luyao | mriedem: okey, thanks for telling me this | 12:58 |
| sean-k-mooney | mriedem: i finally got around to updating https://review.opendev.org/#/c/669738/. the functional tests are now in there own module as you asked. sorry for the delay. | 12:58 |
| gibi | mriedem: hi! thanks for the reviews on the nova-grenade-multinode patches. It seems that GRENADE_PHASE var is not defined even in a grenade job. but GRENADE_NEW_BRANCH is, so I'm pushing a new patch set soon | 12:59 |
| *** derekh has joined #openstack-nova | 12:59 | |
| sean-k-mooney | oh i added a shelve/unshelve test too | 12:59 |
| mriedem | gibi: hmm, when i looked at the job results yesterday i thought i looked for that, but can't remember the details now | 12:59 |
| gibi | mriedem: here is a run with env dumped https://b8c08d7c14d41636ca2c-db936121e3703832159c63a0fb95ab4b.ssl.cf5.rackcdn.com/679210/5/check/nova-grenade-multinode/2489dbd/job-output.txt | 13:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | 13:00 |
| mriedem | gibi: GRENADE_(NEW|OLD)_BRANCH should work yeah, we've used that before https://github.com/openstack/nova/blob/stable/pike/nova/tests/live_migration/hooks/run_tests.sh#L52 | 13:00 |
| luyao | mriedem: Welcome to review this patch series if you would like, I'll appreciate that. Current design is NOT virt driver specific. https://review.opendev.org/#/q/topic:bp/virtual-persistent-memory+(status:open) | 13:00 |
| mriedem | gibi: ok you're going to drop that env dump yeah? | 13:02 |
| mriedem | that's just WIP? | 13:02 |
| gibi | mriedem: yes, I just noticed it | 13:02 |
| gibi | mriedem: new PS is coming | 13:02 |
| *** jawad_axd has quit IRC | 13:02 | |
| mriedem | luyao: i'll be honest with you, that series is likely not something i'm going to be focusing on in the next 2 weeks to feature freeze, i'm already committed to reviewing some other series that have been around longer | 13:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | 13:03 |
| mriedem | sean-k-mooney: btw, totally unrelated, i realize our docs for AggregateInstanceExtraSpecsFilter kind of suck https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html?highlight=aggregate_instance_extra_specs#aggregateinstanceextraspecsfilter | 13:03 |
| mriedem | meaning, what the hell is aggregate_instance_extra_specs supposed to mean to a user trying to configure flavors or aggregates for that filter? | 13:04 |
| mriedem | looking at the code it doesn't even really make sense to me | 13:04 |
| sean-k-mooney | i know i hate that filter and tried to replaces it | 13:04 |
| mriedem | should at least have an example of how to use it | 13:04 |
| sean-k-mooney | yes | 13:05 |
| mriedem | it came up while triaging this bug https://bugs.launchpad.net/nova/+bug/1841932 | 13:05 |
| openstack | Launchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,Incomplete] | 13:05 |
| sean-k-mooney | i can proably add one if you want | 13:05 |
| luyao | mriedem: Yes, I fully understand you, but any comments are welcome, even small and short. :) | 13:05 |
| sean-k-mooney | mriedem: it bassicaly asserts that that every extraspec that is in the fiter (optionally that starts with aggregate_instance_extra_specs:) is set in at least 1 aggreate the current host is a member of | 13:07 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 13:07 |
| aspiers | alex_xu, stephenfin: Your feedback addressed ^^^ | 13:08 |
| sean-k-mooney | mriedem: looking at the bug report its working as intended | 13:09 |
| sean-k-mooney | well actuly | 13:10 |
| *** edleafe has joined #openstack-nova | 13:10 | |
| sean-k-mooney | it might not handel un namepaced extra specs properly ill check | 13:11 |
| *** nweinber has joined #openstack-nova | 13:11 | |
| *** cdent has quit IRC | 13:11 | |
| sean-k-mooney | mriedem: no its working as indended | 13:12 |
| sean-k-mooney | its not working as they want in https://bugs.launchpad.net/nova/+bug/1841932 | 13:12 |
| openstack | Launchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,Incomplete] | 13:12 |
| sean-k-mooney | but that is worrking the way that filter has always worked | 13:12 |
| mriedem | sean-k-mooney: i've reported a docs bug if you you're keen https://bugs.launchpad.net/nova/+bug/1842061 | 13:12 |
| openstack | Launchpad bug 1842061 in OpenStack Compute (nova) "Compute schedulers in nova - AggregateInstanceExtraSpecsFilter docs are not clear" [Undecided,New] | 13:12 |
| sean-k-mooney | ill see if i can add it to my list. but we create https://github.com/openstack/nfv-filters/blob/master/nfv_filters/nova/scheduler/filters/aggregate_instance_type_filter.py to replace it for several reason. also with docs https://github.com/openstack/nfv-filters/blob/master/doc/source/scheduler_filters/aggregate-instance-type-filter.rst | 13:15 |
| aspiers | stephenfin: I also split off those fixups | 13:15 |
| *** KeithMnemonic has joined #openstack-nova | 13:21 | |
| *** mkrai has quit IRC | 13:22 | |
| efried | aspiers: why is textwrap.dedent necessary https://review.opendev.org/#/c/679339/3/nova/tests/unit/virt/libvirt/fake_libvirt_data.py ? | 13:29 |
| openstackgerrit | Merged openstack/nova-specs master: Create specs directory for Ussuri https://review.opendev.org/679364 | 13:29 |
| sean-k-mooney | efried: its not | 13:29 |
| efried | This is xml, not python - it doesn't care about whitespace internally, does it? | 13:29 |
| sean-k-mooney | actully it does | 13:29 |
| aspiers | efried: it's necessary to keep stephenfin happy, and I kinda like it too | 13:29 |
| sean-k-mooney | but we are using xml parsing libs and we dont care | 13:29 |
| aspiers | I could live without, but he suggested it and I like keeping things as readable as possible | 13:30 |
| aspiers | sean-k-mooney: it's about readability not parsing | 13:30 |
| efried | I'm not asking why you're indenting the lines with the xml on them. Visually prettier. I'm asking why textwrap.dedent is necessary. | 13:30 |
| stephenfin | hmm, yeah, we could forget about the textwrap piece, actually. It was the indentation of the XML itself that I cared about | 13:30 |
| aspiers | Oh right | 13:30 |
| sean-k-mooney | aspiers: yes but we dont read the xml we read the code | 13:30 |
| stephenfin | efried: I suggested that out of habit | 13:30 |
| aspiers | sean-k-mooney: strongly disagree | 13:30 |
| stephenfin | You're right, it's not needed in this case | 13:30 |
| sean-k-mooney | and that makes the code mroe readable | 13:30 |
| aspiers | I can drop dedent if that's the consensus | 13:30 |
| sean-k-mooney | e.g. leaving it out | 13:30 |
| stephenfin | I'm happy with it. I'm happy without it. Just so long as I get my block indentation :) | 13:31 |
| *** eharney has joined #openstack-nova | 13:31 | |
| sean-k-mooney | aspiers: i read the xml all the time just not that xml its alway after its been parsed or pretty printed | 13:31 |
| *** edmondsw_ has joined #openstack-nova | 13:31 | |
| aspiers | sean-k-mooney: OK you meant "we don't read the XML as it is at *run-time*, we read it in the source"? I would mostly agree with that | 13:32 |
| efried | aspiers: it's just entirely unnecessary. And in fact if you folded the result into the surrounding xml doc, it would look weird, because it's completely left-justifying | 13:32 |
| sean-k-mooney | aspiers: yes | 13:32 |
| aspiers | efried: what's entirely unnecessary, the dedent or the whole fixup? | 13:33 |
| sean-k-mooney | aspiers: if im reading it at runtime its in a debugger or a traceback | 13:33 |
| aspiers | another classic bikeshed topic :) | 13:33 |
| sean-k-mooney | obviously | 13:33 |
| aspiers | Is there a mandatory minimum of one per day? ;-p | 13:33 |
| *** xek has joined #openstack-nova | 13:33 | |
| efried | well, both aspiers, and if it weren't for the fact that all these lines already belong to two very recent commits, I would -1 it for the sake of git history. I'm tempted to do that anyway. | 13:34 |
| efried | but I have an actual problem with the dedent. | 13:34 |
| aspiers | efried: I only submitted this because stephenfin asked for it - please negotiate with him not me :) | 13:34 |
| efried | it's unnecessary processing (test only, but still) and the result is actually technically too dedented. | 13:34 |
| aspiers | I really don't mind what you guys agree on | 13:34 |
| efried | I hear ya. | 13:34 |
| aspiers | thanks :) | 13:35 |
| stephenfin | efried: straight up indentation fixes aren't an issue, tbh - git blame -w | 13:36 |
| * efried negotiates on the patch | 13:36 | |
| sean-k-mooney | mriedem: i may have ranted a bit but hopefully that helps. https://bugs.launchpad.net/nova/+bug/1842061 | 13:37 |
| openstack | Launchpad bug 1842061 in OpenStack Compute (nova) "Compute schedulers in nova - AggregateInstanceExtraSpecsFilter docs are not clear" [Undecided,New] | 13:37 |
| efried | stephenfin: where's the -w option in pycharm? | 13:37 |
| sean-k-mooney | ill try and come up with a doc friendly way to say that | 13:37 |
| stephenfin | efried: Google tells me it's on by default? https://stackoverflow.com/questions/37868225/ignore-whitespace-identation-in-annotate-mode-with-intelliji-and-git | 13:37 |
| sean-k-mooney | efried: you can get the history of the lines you have slected and go back though each commit | 13:38 |
| stephenfin | Also, am I the only sucker still working in Vim? | 13:38 |
| sean-k-mooney | yes | 13:38 |
| efried | sean-k-mooney: Yes, of course I can, but is that extra work worth it? IMO it is not. | 13:38 |
| efried | especially for this | 13:38 |
| efried | stephenfin: I believe cdent is with you. | 13:39 |
| sean-k-mooney | efried: sooy i was not following the converstion | 13:39 |
| sean-k-mooney | can you do git blame -w with pycharm | 13:39 |
| sean-k-mooney | and yes if you want too | 13:39 |
| efried | well, that's interesting, stephenfin you're right about -w being on by default. That takes some of the sting out. | 13:40 |
| sean-k-mooney | how did i miss a full sentence... | 13:40 |
| efried | I'll just abstain. | 13:40 |
| stephenfin | \o/ | 13:40 |
| stephenfin | that's a sane default | 13:41 |
| *** edmondsw_ has quit IRC | 13:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/679449 | 13:41 |
| * stephenfin wonders why git doesn't allow this mode to be configured | 13:41 | |
| sean-k-mooney | litally ment to type "all i saw was" before "can you do..." | 13:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/679449 | 13:41 |
| sean-k-mooney | stephenfin: proably because white space in lanagues like python matters | 13:41 |
| sean-k-mooney | so changing indention could change behavior | 13:42 |
| sean-k-mooney | or no one added it | 13:42 |
| stephenfin | sean-k-mooney: Right, but make it toggleable | 13:42 |
| stephenfin | Maybe 'git blame -W' to override whatever and re-enable it | 13:42 |
| stephenfin | Hmm, that would be a decent patch | 13:42 |
| stephenfin | Possible weekend project there | 13:42 |
| sean-k-mooney | stephenfin: as long as you dont change the default behavior | 13:42 |
| * efried moves on to more important reviews | 13:43 | |
| stephenfin | oh yeah, of cours | 13:43 |
| stephenfin | *course | 13:43 |
| sean-k-mooney | efried: speaking of which | 13:43 |
| sean-k-mooney | efried: care to take a look at |https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/image-metadata-prefiltering | 13:43 |
| sean-k-mooney | there are more more important reviews but im hoping those merge soon | 13:44 |
| efried | sean-k-mooney: been on the list, but got some stuff in front of it. | 13:44 |
| sean-k-mooney | cool | 13:44 |
| sean-k-mooney | stephenfin: by they way i tested and fixed https://review.opendev.org/#/c/675776/ | 13:45 |
| stephenfin | the revert? | 13:45 |
| sean-k-mooney | stephenfin: we do need that fix to avoid out issue with libvirt | 13:45 |
| sean-k-mooney | yes | 13:45 |
| stephenfin | yeah | 13:45 |
| sean-k-mooney | i guess we are still waiting for the melonox ci to run on it too | 13:47 |
| mdbooth | mriedem dansmith: I don't think I'm going to get better confirmation of the fix in https://review.opendev.org/#/c/677736/ . It *has* run on a real system, though, and didn't break it. | 13:49 |
| sean-k-mooney | artom: https://review.opendev.org/#/c/678887/ failed because its using qemu again | 13:49 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py https://review.opendev.org/636318 | 13:50 |
| aspiers | alex_xu, stephenfin, efried: need your take on this debate https://review.opendev.org/#/c/636318/49/nova/virt/libvirt/config.py@2701 | 13:51 |
| mriedem | mdbooth: dan is out today, | 13:52 |
| mriedem | but are you going to address https://review.opendev.org/#/c/677736/3/nova/virt/libvirt/host.py@a236 ? | 13:52 |
| mriedem | otherwise i'll +2 it | 13:52 |
| aspiers | stephenfin, efried: if the question isn't easy to parse from those comments, I can help explain here | 13:53 |
| efried | aspiers: Give me 10 mins | 13:53 |
| aspiers | efried: np | 13:53 |
| sean-k-mooney | mdbooth: you know the py37 hang i was seeing before when we tryied to boot vms could also be fixed by https://review.opendev.org/#/c/677736/3 | 13:53 |
| sean-k-mooney | i had assumed when i saw it it was due to eventlest and python37 not playing nicely but that looks like it is more likely the actual cause | 13:54 |
| * aspiers goes for late lunch | 13:55 | |
| *** cdent has joined #openstack-nova | 13:55 | |
| *** JamesBenson has joined #openstack-nova | 13:57 | |
| mdbooth | sean-k-mooney: Why would the behaviour be different on py37, though? | 13:57 |
| mdbooth | Bug call time | 13:58 |
| *** ociuhandu has joined #openstack-nova | 14:01 | |
| sean-k-mooney | well i was febuary, eventlet did not offically test/support py37 and we have see issue with it on python3 in the pasted that looked like it | 14:02 |
| sean-k-mooney | but honestly it was just a guess and it happend on python 3 but python 2.7 | 14:02 |
| *** ociuhandu has quit IRC | 14:02 | |
| *** ratailor has joined #openstack-nova | 14:05 | |
| *** mloza has joined #openstack-nova | 14:07 | |
| efried | aspiers: I don't have the bandwidth to dig into this all the way right now, so the following is a bit from the hip: | 14:09 |
| efried | If it's possible for Thing A (via extra spec, image meta, config, etc) to ask for a switch to be flipped on, and Thing B (likewise) for it to be off, that's a conflict, and should be an error. | 14:09 |
| efried | We have a place where we validate flavor+image compatibility for things like this: nova.compute.api.API._validate_flavor_image | 14:09 |
| efried | As of yet, I think all of these ^ checks are just checking whether Thing A is on in flavor and off in image meta, kind of thing. | 14:09 |
| efried | So this might be the first time we are cross-checking Thing A and Thing B for compatibility. | 14:09 |
| efried | But that's fine - I believe that was one of the long-term goals of that infrastructure. stephenfin might be able to say more there. | 14:09 |
| efried | Now, that's at the API layer. Once you get down to the compute, you can start vetting against things like config or whatever. Hopefully any conflicts there would have already been filtered out based on placement; but if not, late fail the spawn. | 14:09 |
| efried | So if all of that were in place, having a single function that checks sev *and anything else relevant* and either sets iommu on or raises an exception: sounds like the right plan. | 14:09 |
| *** gbarros has joined #openstack-nova | 14:10 | |
| *** dpawlik has quit IRC | 14:11 | |
| mriedem | artom: so https://review.opendev.org/#/c/678887/18 we're just waiting for another run after your rebase right? | 14:13 |
| *** dougsz has joined #openstack-nova | 14:15 | |
| * mriedem dials into bluejeans | 14:16 | |
| *** dougsz has quit IRC | 14:17 | |
| aspiers | efried: thanks, I think that's enough justification for me to start switching the driver iommu flags so they all get enabled from a single place | 14:21 |
| aspiers | efried: right now the conflict is only a theoretical possibility | 14:22 |
| *** luksky has quit IRC | 14:22 | |
| aspiers | efried: so we may never need to worry about it, but yeah it makes sense what you say about there being enough places for us to proactively catch and handle any such conflicts if they did arise in future | 14:22 |
| *** itlinux-away is now known as itlinux | 14:24 | |
| aspiers | efried: the only risk I can't see us easily avoiding is someone adding code which explicitly disables iommu but forgets to prevent the SEV code from overriding that. Moving the SEV iommu code away from each individual chunk responsible for building driver configuration means that it's "hidden" out of sight from that code, and therefore easily missed | 14:25 |
| aspiers | efried: but that seems like a small risk, and in return we probably get much cleaner code enabling iommu for SEV | 14:25 |
| aspiers | alex_xu: ^^^ | 14:25 |
| *** shilpasd has left #openstack-nova | 14:27 | |
| *** shilpasd has joined #openstack-nova | 14:29 | |
| mriedem | efried: dustinc: couple of questions in the ironic get_node sdk change https://review.opendev.org/#/c/642899/44/nova/virt/ironic/driver.py | 14:29 |
| dansmith | artom: I think the version checking in here is wrong and that you'll fail spectacularly if you have an rpc version pin and have to roll back a migration: https://review.opendev.org/#/c/634606 | 14:33 |
| *** ratailor has quit IRC | 14:34 | |
| *** ociuhandu has joined #openstack-nova | 14:34 | |
| efried | mriedem: responded | 14:37 |
| *** mkrai has joined #openstack-nova | 14:39 | |
| *** ociuhandu has quit IRC | 14:39 | |
| mriedem | sean-k-mooney: this is all host agnostic right? https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L212-L228 | 14:44 |
| mriedem | sean-k-mooney: meaning, if an instance has non-sriov pci requests, we're going to hit that same code for each alternate host during live migration and just fail on all of them since that validation doesn't involve the host | 14:44 |
| mriedem | seems that should be pulled up higher in the conductor task before we even ask the scheduler for dest hosts | 14:44 |
| mriedem | like https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L85 | 14:44 |
| sean-k-mooney | we check for non neutron pci device requets in the conductor already | 14:45 |
| *** Sundar has joined #openstack-nova | 14:45 | |
| sean-k-mooney | mriedem: here https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L216-L221 | 14:46 |
| sean-k-mooney | mriedem: dan wanted us to check again in the compute node to be extra safe | 14:46 |
| sean-k-mooney | mriedem: so if you have pci deivce requested by the flavor alias we never get to artoms code | 14:47 |
| mriedem | sean-k-mooney: i think you're missing my point | 14:48 |
| mriedem | let's say i have conductor configured to retry up to 100 hosts for live mgiration and the scheduler gives me back 100 possible dests, | 14:49 |
| mriedem | if the instance has flavor-defined pci requests, i'm going to hit that same block of validation code 100 times | 14:49 |
| mriedem | with the exact same results | 14:49 |
| mriedem | also, did we check with any of the non-libvirt driver maintainers that flavor-defined pci requests aren't supported in their driver for live migration? | 14:50 |
| mriedem | i'm assuming they don't, hyper-v would be the only one remotely close probably, but wondering if anyone asked or just assumed libvirt is the only driver in nova | 14:50 |
| stephenfin | mriedem: No, we don't | 14:51 |
| stephenfin | We assume libvirt is the only driver for a lot of these things | 14:51 |
| *** ivve has quit IRC | 14:51 | |
| stephenfin | We've also done a bad job of documenting the features and config options that are libvirt only, fwiw | 14:52 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1842087 | 14:53 |
| openstack | Launchpad bug 1842087 in OpenStack Compute (nova) "_check_can_migrate_pci in the LiveMigrationTask has host agnostic validation that is redundant/expensive" [Low,Triaged] | 14:53 |
| stephenfin | mriedem: fwiw, I've suggested aspiers adds similar checks for the SEV feature (based on his docs, you can't live migrate those instances) | 14:54 |
| mriedem | efried: ok so https://review.opendev.org/#/c/642899/44 - looks like quite a few unrelated things in there, but i'm just grumbling i think b/c it seems to be that kind of morning | 14:57 |
| mriedem | efried: can you sniff my latest comments and if i'm not crazy then i'll +W | 14:57 |
| shilpasd | mriedem: Hi, i am in the process of understanding fixture client created at novaclient https://opendev.org/openstack/python-novaclient/src/branch/master/novaclient/tests/unit/fixture_data/client.py#L21 | 14:58 |
| shilpasd | can you help me how this COMPUTE_URL is derived (endpoint >> http://<host_ip>/compute/v2.1) | 14:59 |
| mriedem | shilpasd: i'm not sure what you're asking, but i guess i'd follow this code: https://opendev.org/openstack/python-novaclient/src/branch/master/novaclient/tests/unit/fixture_data/client.py#L39-L40 | 15:02 |
| artom | sean-k-mooney, wat. OK, I removed some ansible lines because the devstack patch was doing it, looks like I'll have to re-add them | 15:03 |
| artom | mriedem, what I said to sean-k-mooney ^^ | 15:03 |
| sean-k-mooney | mriedem: i did think we check but i cant recal specificlly | 15:03 |
| efried | mriedem: Yeah, it's not terribly surprising that | 15:04 |
| shilpasd | mriedem:COMPUTE_URL is used for creating endpoint in fixture, and if you check endpoint for compute is 'http://<host_ip>/compute/v2.1' | 15:04 |
| sean-k-mooney | e.g. with other dirvers | 15:04 |
| efried | mriedem: ...that a six-part series with two authors and four dozen patch sets got a bit of intra-series bleed :( | 15:04 |
| efried | mriedem: If you want we can get dustinc to ack those comments. | 15:04 |
| shilpasd | mriedem: so my question, how what's the relation COMPUTE_URL as endpoint here in Fixture | 15:06 |
| artom | dansmith, ah, I think I see what you mean. I do a 'if src_supports_numa_live_migration' check here: https://review.opendev.org/#/c/634606/62/nova/compute/manager.py@6511 | 15:07 |
| *** ociuhandu has joined #openstack-nova | 15:07 | |
| dansmith | artom: ...but... | 15:08 |
| artom | dansmith, so I should move that if into post_claim_migrate_data, right? | 15:09 |
| artom | To make sure the new field got through RPC version pinning to the dest | 15:09 |
| dansmith | the field will make it through regardless of the rpc pin | 15:09 |
| dansmith | they're unrelated | 15:09 |
| dansmith | entirely | 15:09 |
| dansmith | that's my point | 15:09 |
| artom | Oh. | 15:10 |
| dansmith | you can't use the presence of a field in an object to know what the version pin is | 15:10 |
| artom | Wait, so how does the conductor know when to backlevel an object? | 15:10 |
| dansmith | artom: conductor backlevels an object when asked. when an object arrives at a compute node and that compute node sees it's too new, and asks conductor to backlevel it to a specific version (i.e. its latest for that object) | 15:11 |
| artom | dansmith, aha, so I had it completely wrong. OK, need to rethink and update then. | 15:12 |
| dansmith | but compute->compute there is no conductor involvement for the actual rpc call, and the version pin is not related to object versions | 15:12 |
| dansmith | artom: yep | 15:12 |
| *** shilpasd has quit IRC | 15:15 | |
| mriedem | artom: left my comments in the claims patch as well https://review.opendev.org/#/c/635669/47 | 15:16 |
| *** mlavalle has joined #openstack-nova | 15:16 | |
| artom | mriedem, ack, much thanks. | 15:16 |
| * artom wishes he had more sleep under his belt to think clearer. | 15:16 | |
| artom | And we want to see https://review.opendev.org/#/c/678887/ passing before we start the +W Train (zing!) going, right? | 15:17 |
| mriedem | speaking of that, | 15:18 |
| artom | (OK, train may have been optimistic - snail?) | 15:18 |
| mriedem | why did you pull it away from the nova series? | 15:18 |
| mriedem | it's a nova change that depends on a devstack change that depends on a nova change...but why? | 15:18 |
| artom | It became a PITA to work on both at the same time in the same stack? | 15:18 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 15:18 |
| artom | Specifically, it needed a rebase, but no the stack below it | 15:18 |
| artom | *not | 15:19 |
| mriedem | oh yeah ok | 15:19 |
| dansmith | artom: I would really like to see that working, unless there's some fundamental reason it can't | 15:19 |
| dansmith | artom: it looks like it's still not even able to start an instance though right? | 15:19 |
| mriedem | as for the +W train yeah ^ what dan said | 15:19 |
| artom | sean-k-mooney would know more about the fundamental reasons, so if thinks it can work, let's keep trying. | 15:19 |
| artom | I removed some lines I thought were no longer needed (beause of the devstack nuke) when I rebased, looks like I'll have to put them back int | 15:20 |
| artom | And put it on top again, why not, I'm respinning the series anyways | 15:20 |
| mriedem | you don't have to put it back on top, | 15:21 |
| mriedem | but can if you want | 15:22 |
| sean-k-mooney | artom: the temp job? we jsut don have the right setting in the config. | 15:22 |
| sean-k-mooney | dansmith: mriedem do ye just want to see a gate job using numa migrtaion | 15:23 |
| sean-k-mooney | or does it have to be that gate job | 15:23 |
| artom | *snerk* let's try and hack something in grenade! | 15:23 |
| dansmith | well, especially given the upgrade issues, it'd also be nice to run the grenade LM job against this, even though it probably wouldn't have covered the situation I found earlier | 15:24 |
| sean-k-mooney | because at this point if adding the options artom remvoed does not work it would be simpler form me to just make my nfv job work | 15:24 |
| dansmith | sean-k-mooney: if it runs some LMs then that's better than noting | 15:24 |
| dansmith | I'm also going to be tempted to hack the job to pin the rpc version at 5.1 to check his work | 15:24 |
| sean-k-mooney | dansmith: well i have my https://review.opendev.org/#/c/652197/ nfv job | 15:24 |
| dansmith | because breaking LM across versions is icky | 15:24 |
| sean-k-mooney | that i was going to rework | 15:24 |
| sean-k-mooney | so i was going to stop using fedora and jsut use ubunut with nested vert | 15:25 |
| sean-k-mooney | the multinode version runs live migratio tests | 15:25 |
| dansmith | the closer it is to a standard job, the easier it will be to verify, but anything is better than nothing | 15:26 |
| sean-k-mooney | sure | 15:26 |
| sean-k-mooney | whcih is why im swapping ot ubuntu | 15:26 |
| sean-k-mooney | but we also need to move the nova-migration job to non legacy at some point | 15:26 |
| sean-k-mooney | anyway i was planning to finish up early today given how late i have been working lately | 15:27 |
| dansmith | understandable, and holiday weekend here for lots of people | 15:28 |
| *** luksky has joined #openstack-nova | 15:28 | |
| sean-k-mooney | dansmith: donnyd provide a mulit numa flavor we can use on FN and we can also use vexhost. so ill create a job on monday | 15:28 |
| sean-k-mooney | assuming ye dont get the other one working | 15:29 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 15:29 |
| *** eandersson has joined #openstack-nova | 15:30 | |
| *** jaosorior has quit IRC | 15:31 | |
| *** gyee has joined #openstack-nova | 15:33 | |
| *** macz has joined #openstack-nova | 15:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Rename Claims resources to compute_node https://review.opendev.org/679470 | 15:34 |
| mriedem | artom: i thought this was funny https://review.opendev.org/#/c/635669/47/nova/compute/resource_tracker.py@399 | 15:37 |
| mriedem | "because the fake objects in the tests aren't correct, we can't do anything about the actual code looking weird" | 15:37 |
| *** jaosorior has joined #openstack-nova | 15:37 | |
| artom | mriedem, heh - so, either we create a migration for the test that already has the accepted status set, which is close to real like but then... | 15:38 |
| artom | Well | 15:38 |
| artom | No, it'd work | 15:38 |
| artom | Assert it's still accepted | 15:38 |
| artom | Thanks! | 15:38 |
| artom | *real life | 15:38 |
| mriedem | yeah.... | 15:38 |
| mriedem | i think you're overthinking all of this :) | 15:38 |
| artom | Like a lot of things in life :( | 15:39 |
| *** jaosorior has quit IRC | 15:42 | |
| *** rmk has joined #openstack-nova | 15:50 | |
| *** brault has quit IRC | 15:51 | |
| *** tesseract has quit IRC | 15:52 | |
| mriedem | efried: as for the ironic + sdk series, i'll wait for your ack on https://review.opendev.org/#/c/656027/ since you brought up CERN performance anxiety | 15:59 |
| *** ivve has joined #openstack-nova | 16:03 | |
| *** brault has joined #openstack-nova | 16:03 | |
| *** jangutter has quit IRC | 16:04 | |
| *** nweinber has quit IRC | 16:04 | |
| *** nweinber has joined #openstack-nova | 16:04 | |
| *** ccamacho has quit IRC | 16:05 | |
| *** brault has quit IRC | 16:07 | |
| openstackgerrit | Merged openstack/nova master: Follow up for specifying az to unshelve https://review.opendev.org/679164 | 16:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle VirtDriverNotReady in _cleanup_running_deleted_instances https://review.opendev.org/679473 | 16:13 |
| *** eharney has quit IRC | 16:13 | |
| artom | dansmith, sanity check with you before I go off haxing - if in https://review.opendev.org/#/c/634606/62/nova/compute/manager.py@6481 I check for the presense of the migration kwarg, which is new in RPC 5.2 and is not None from the conductor, is that a good way to make sure we're not pinned to < 5.2? | 16:14 |
| dustinc | mriedem, efried: thanks for help and reviews, checking out comments now | 16:14 |
| dustinc | (on ironic sdk series) | 16:14 |
| mriedem | artom: wouldn't https://review.opendev.org/#/c/634606/62/nova/compute/manager.py@6511 already be False in that case? | 16:15 |
| dansmith | artom: isn't that the destination not the source? | 16:16 |
| * mriedem goes to lunch | 16:16 | |
| *** mriedem is now known as mriedem_afk | 16:16 | |
| artom | Doh, right | 16:16 |
| dansmith | artom: I quickly looked to see if you had an easy indication on the source like that and didn't see one | 16:16 |
| dansmith | but yeah, that's a little obscure, but as long as it's commented you should be able to use something like that | 16:17 |
| dansmith | but, not sure there is one for the source :/ | 16:17 |
| artom | Right, it's set by the libvirt driver during the source check: https://review.opendev.org/#/c/634606/62/nova/virt/libvirt/driver.py | 16:18 |
| artom | That's the bit that has to be conditional on RPC 5.2 | 16:18 |
| artom | dansmith, feels ugly, but add a new sentinel param to check_can_live_migrate_source when it's called from check_can_live_migrate_destination? | 16:19 |
| artom | Or just have check_can_live_migrate_source manually check the RPC version | 16:19 |
| dansmith | it's always called from there no? | 16:20 |
| artom | You mean _source from _destination? Yeah, I was saying it from context | 16:21 |
| artom | *for | 16:21 |
| *** xek has quit IRC | 16:21 | |
| dansmith | it's always called there, so you mean when it's called from a new-enough node to pass that flag, yeah? | 16:22 |
| *** markvoelker has quit IRC | 16:22 | |
| artom | dansmith, yeah. If the node has the new code, it'll set the sentinel, and if the RPC is new enough, it'll actually reach the source | 16:22 |
| dansmith | yeah, I don | 16:23 |
| dansmith | I don't love it, but... | 16:23 |
| *** itlinux is now known as itlinux-away | 16:24 | |
| artom | Or. | 16:25 |
| artom | When the destination gets the migrate_data back from the source, pop the src_supports_numa_live_migration sentinel if the destination did not receive a migration from the conductor | 16:26 |
| dansmith | the migration from conductor doesn't tell the whole story, so I don't think it's legit to use that as your sentinel | 16:28 |
| *** markvoelker has joined #openstack-nova | 16:28 | |
| dansmith | conductor's rpc version may be pinned differently | 16:28 |
| artom | Differently.... from the computes? | 16:29 |
| artom | I thought it was a deployment-wide thing | 16:29 |
| dansmith | differently from anything, sure | 16:29 |
| dansmith | config is per-node | 16:30 |
| *** mrjk has quit IRC | 16:30 | |
| dansmith | in general you'd kinda assume they're the same, but especially when doing the slide-puzzle migration approch, | 16:30 |
| dansmith | you might need to pin some computes differently to be able to communicate while things are old | 16:30 |
| artom | Hrmm, so in addition to this whole thing, I need to check that the migration from the conductor is not None | 16:31 |
| dansmith | regardless of the pinning of the computes you mean? | 16:31 |
| artom | Yeah | 16:31 |
| dansmith | if there's something you're doing that assumes conductor passed an argument from compute 5.2, then for sure, | 16:31 |
| dansmith | because if it's pinned at 5.1 or "auto" and there are older computes present, then..yeah | 16:32 |
| dansmith | also, | 16:32 |
| dansmith | if everyone is set to "auto", then the version they think is legit right now depends on when they started, or were restarted during the upgrade | 16:32 |
| dansmith | like, as soon as the last compute restarts, its auto pin is set to current, but everyone else hasn't gotten their service restart kick yet, etc | 16:32 |
| dansmith | so assuming they're all atomically set identically is not legit, IMHO | 16:33 |
| artom | So I think migration=None ends up creating a migration object in _move_claim, which is not what we want | 16:33 |
| artom | OK, I think I got a better handle on this, thanks! | 16:34 |
| dansmith | ack, maybe comment that on the patch in the proper place for tracking | 16:34 |
| *** dtantsur is now known as dtantsur|afk | 16:36 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 16:36 |
| aspiers | efried: need your input on this (sorry) https://review.opendev.org/#/c/666616/38/nova/conf/libvirt.py@845 | 16:38 |
| efried | aspiers: more than earlier? | 16:38 |
| *** igordc has joined #openstack-nova | 16:39 | |
| aspiers | efried: uhh, different topic I think | 16:39 |
| efried | okay, hit me | 16:39 |
| aspiers | URL above ^^^ | 16:39 |
| efried | oh, sorry, stand by | 16:39 |
| aspiers | alex_xu and stephenfin want the default for num_memory_encrypted_guests changed from None to 0 | 16:40 |
| aspiers | I'm not convinced it's the best idea, but I guess I'd be OK with it. However I wouldn't be OK with ditching None altogether. | 16:40 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339 | 16:43 |
| sean-k-mooney | aspiers: you could replace non with -1 to signify unlimited | 16:43 |
| aspiers | sean-k-mooney: that's already mentioned in my comment | 16:43 |
| sean-k-mooney | i didnt click | 16:44 |
| aspiers | efried, stephenfin: dedent removed ^^^ | 16:44 |
| sean-k-mooney | i just assumed that that would be reason for not using none | 16:44 |
| aspiers | No, None currently means "try to auto-detect, but if you can't, unlimited" | 16:44 |
| sean-k-mooney | ah right yes | 16:44 |
| aspiers | Another reasonable default would be "try to auto-detect, but if you can't, 0" | 16:45 |
| aspiers | So that operators have to explicitly request unlimited | 16:45 |
| sean-k-mooney | ya | 16:45 |
| *** Sundar has left #openstack-nova | 16:45 | |
| aspiers | I'd be OK with that too, although it's getting a bit complicated | 16:45 |
| sean-k-mooney | well that would be cloaset to that you want | 16:46 |
| aspiers | Not necessarily | 16:46 |
| aspiers | Read the comment ;-) | 16:46 |
| *** itlinux-away is now known as itlinux | 16:46 | |
| sean-k-mooney | im more or less done for the day. just waiting for food to be delivers so im trying to avoid starting any more reviews or work. | 16:47 |
| sean-k-mooney | anyway i was fine with what you had orginally proposed | 16:47 |
| aspiers | thanks | 16:47 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339 | 16:48 |
| aspiers | Don't you just love it when the final tempest-slow-py3 in the gate fails with some unrelated issue and means you have to re-run your whole damn CI twice | 16:49 |
| aspiers | *sigh* | 16:49 |
| sean-k-mooney | twice your lucky its not more :) | 16:49 |
| aspiers | haha maybe it will be | 16:49 |
| aspiers | tempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.222 via SSH timed out. | 16:49 |
| aspiers | Ah that good old favourite | 16:50 |
| aspiers | stephenfin: you still around? | 16:51 |
| aspiers | If I address two nits in https://review.opendev.org/#/c/638680/ I guess I lose the +2 W+1, right? | 16:52 |
| sean-k-mooney | you will and i think he is gong for the weekend | 16:52 |
| sean-k-mooney | add a followup patch | 16:52 |
| efried | aspiers: responded | 16:52 |
| *** bnemec is now known as beekneemech | 16:53 | |
| *** eharney has joined #openstack-nova | 16:58 | |
| *** derekh has quit IRC | 17:00 | |
| *** mkrai has quit IRC | 17:08 | |
| *** cdent has quit IRC | 17:15 | |
| *** ralonsoh has quit IRC | 17:19 | |
| *** ricolin has joined #openstack-nova | 17:28 | |
| aspiers | efried: thanks | 17:38 |
| aspiers | sean-k-mooney: ok | 17:38 |
| *** cfriesen has joined #openstack-nova | 17:42 | |
| *** ociuhandu has quit IRC | 17:51 | |
| *** ociuhandu has joined #openstack-nova | 17:57 | |
| *** ricolin has quit IRC | 18:00 | |
| *** ociuhandu has quit IRC | 18:02 | |
| *** itlinux is now known as itlinux-away | 18:10 | |
| *** psachin has quit IRC | 18:12 | |
| artom | dansmith, so actually, I could at least test pinning to 5.1 in the func tests | 18:14 |
| artom | Just self.flags(compute='5.1', group='upgrade_levels') | 18:14 |
| dansmith | artom: yeah, you should be able to test old conductor (call), new compute(s), mixed computes, etc I think | 18:16 |
| artom | Not sure about mixed because CONF is global | 18:16 |
| dansmith | in unit tests for sure, | 18:17 |
| dansmith | but the compute manager should grab its rpcapi object on start, IIRC, which means you can set it, start one, set it again, start another, etc | 18:17 |
| dansmith | I think it doesn't work for auto, but for manual pins I think you can | 18:17 |
| *** adriant has quit IRC | 18:17 | |
| *** adriant has joined #openstack-nova | 18:18 | |
| artom | Oh, fun. | 18:19 |
| artom | After lunch though, I put it off long enough | 18:19 |
| artom | I'll push what I have I guess | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229 | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | 18:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 18:20 |
| *** gbarros has quit IRC | 18:26 | |
| *** itlinux-away is now known as itlinux | 18:35 | |
| *** bbowen has quit IRC | 18:36 | |
| mriedem_afk | sean-k-mooney: you have a pep8 failure here https://review.opendev.org/#/c/669738/ | 18:38 |
| *** bbowen has joined #openstack-nova | 18:39 | |
| *** mrjk has joined #openstack-nova | 18:47 | |
| *** bbowen has quit IRC | 18:51 | |
| *** bbowen has joined #openstack-nova | 18:52 | |
| *** tbachman has quit IRC | 18:57 | |
| *** dave-mccowan has quit IRC | 19:02 | |
| *** itlinux has quit IRC | 19:04 | |
| *** xek has joined #openstack-nova | 19:11 | |
| *** KeithMnemonic has quit IRC | 19:22 | |
| *** mriedem_afk is now known as mriedem | 19:24 | |
| mriedem | efried: i think these are ready for gibi's series https://review.opendev.org/#/q/topic:nova-grenade-multinode+(status:open+OR+status:merged) | 19:24 |
| *** slaweq has joined #openstack-nova | 19:32 | |
| openstackgerrit | Nathan Kinder proposed openstack/nova master: Allow TLS ciphers to be configurable for console proxies https://review.opendev.org/679502 | 19:33 |
| openstackgerrit | Merged openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 19:42 |
| openstackgerrit | Merged openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340 | 19:42 |
| openstackgerrit | Merged openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964 | 19:42 |
| mriedem | need someone to backport https://review.opendev.org/#/c/678964/ to stein. | 19:44 |
| *** bbowen has quit IRC | 19:45 | |
| *** nweinber has quit IRC | 19:48 | |
| *** bbowen has joined #openstack-nova | 19:53 | |
| *** xek has quit IRC | 19:57 | |
| *** nweinber has joined #openstack-nova | 20:12 | |
| *** adriant has quit IRC | 20:17 | |
| *** nweinber has quit IRC | 20:17 | |
| *** adriant has joined #openstack-nova | 20:18 | |
| *** tbachman has joined #openstack-nova | 20:22 | |
| *** ociuhandu has joined #openstack-nova | 20:25 | |
| *** ociuhandu has quit IRC | 20:30 | |
| *** bbowen has quit IRC | 20:32 | |
| *** bbowen has joined #openstack-nova | 20:34 | |
| *** markvoelker has quit IRC | 20:51 | |
| *** bbowen has quit IRC | 20:56 | |
| *** eharney has quit IRC | 21:18 | |
| *** JamesBenson has quit IRC | 21:19 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 21:19 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py https://review.opendev.org/636318 | 21:21 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | 21:26 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 21:30 |
| *** markvoelker has joined #openstack-nova | 21:30 | |
| *** xek has joined #openstack-nova | 21:34 | |
| *** markvoelker has quit IRC | 21:35 | |
| *** xek has quit IRC | 21:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode https://review.opendev.org/678841 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | 21:49 |
| mriedem | gibi: i'm out monday but rebased the series and addressed my small test comments on the bottom few changes so I'll +2 those ^ | 21:49 |
| *** slaweq has quit IRC | 21:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | 22:09 |
| openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney) | 22:09 |
| *** mriedem has quit IRC | 22:09 | |
| *** luksky has quit IRC | 22:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: rt: soften warning case in _remove_deleted_instances_allocations https://review.opendev.org/679519 | 22:14 |
| *** avolkov has quit IRC | 22:24 | |
| donnyd | mriedem remembers FN likes work to do, so he rebases fridays:) | 22:29 |
| *** macz has quit IRC | 22:33 | |
| *** vesper has quit IRC | 22:46 | |
| *** vesper11 has joined #openstack-nova | 22:47 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 22:52 |
| artom | ^^ found a bug :D | 22:53 |
| artom | which I'll fix Monday | 22:53 |
| artom | o/ | 22:53 |
| *** artom has quit IRC | 22:53 | |
| *** JamesBenson has joined #openstack-nova | 22:56 | |
| *** JamesBenson has quit IRC | 23:00 | |
| *** yaawang has quit IRC | 23:00 | |
| *** yaawang has joined #openstack-nova | 23:01 | |
| *** ivve has quit IRC | 23:10 | |
| *** jhesketh has quit IRC | 23:18 | |
| *** xek has joined #openstack-nova | 23:19 | |
| *** xek has quit IRC | 23:34 | |
| *** gyee has quit IRC | 23:37 | |
| *** N3l1x has quit IRC | 23:44 | |
| openstackgerrit | Nathan Kinder proposed openstack/nova master: WIP - Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502 | 23:52 |
| *** jamiec has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!