| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 00:00 |
|---|---|---|
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029 | 00:00 |
| *** macz has quit IRC | 00:00 | |
| *** macz has joined #openstack-nova | 00:01 | |
| *** tbachman has quit IRC | 00:01 | |
| *** macz has quit IRC | 00:04 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 00:10 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029 | 00:10 |
| *** macz has joined #openstack-nova | 00:15 | |
| *** macz has quit IRC | 00:18 | |
| *** spatel has joined #openstack-nova | 00:27 | |
| *** brinzhang has joined #openstack-nova | 00:32 | |
| *** brinzhang_ has quit IRC | 00:35 | |
| *** markvoelker has quit IRC | 00:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676030 | 00:40 |
| *** gyee has quit IRC | 00:40 | |
| *** markvoelker has joined #openstack-nova | 00:44 | |
| openstackgerrit | Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908 | 00:45 |
| openstackgerrit | Merged openstack/nova stable/ocata: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674906 | 00:52 |
| *** abaindur has quit IRC | 00:57 | |
| *** dave-mccowan has quit IRC | 00:58 | |
| *** yedongcan has joined #openstack-nova | 01:07 | |
| *** bhagyashris has joined #openstack-nova | 01:13 | |
| openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused helper _get_instances_by_filters https://review.opendev.org/676036 | 01:30 |
| *** factor has joined #openstack-nova | 01:39 | |
| *** yedongcan has quit IRC | 01:48 | |
| openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused helper filter_and_format_resource_metadata https://review.opendev.org/676038 | 01:49 |
| *** yedongcan has joined #openstack-nova | 01:51 | |
| *** bbowen has quit IRC | 01:51 | |
| *** spsurya has joined #openstack-nova | 02:11 | |
| *** igordc has quit IRC | 02:17 | |
| *** igordc has joined #openstack-nova | 02:39 | |
| openstackgerrit | Merged openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889 | 02:51 |
| openstackgerrit | Merged openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281 | 02:51 |
| openstackgerrit | Merged openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 02:51 |
| openstackgerrit | Merged openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 02:52 |
| *** igordc has quit IRC | 02:55 | |
| *** hongbin has joined #openstack-nova | 03:00 | |
| *** spatel has quit IRC | 03:02 | |
| openstackgerrit | Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908 | 03:25 |
| *** takashin has left #openstack-nova | 03:30 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 03:31 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133 | 03:43 |
| *** macz has joined #openstack-nova | 03:51 | |
| *** macz has quit IRC | 03:55 | |
| *** macz has joined #openstack-nova | 03:56 | |
| *** macz has quit IRC | 03:57 | |
| *** macz has joined #openstack-nova | 03:57 | |
| *** ash2307 has joined #openstack-nova | 03:58 | |
| *** macz has quit IRC | 04:01 | |
| *** macz has joined #openstack-nova | 04:02 | |
| *** macz has quit IRC | 04:06 | |
| *** ash2307 has left #openstack-nova | 04:09 | |
| *** shilpasd has joined #openstack-nova | 04:13 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 04:14 |
| *** hongbin has quit IRC | 04:17 | |
| *** whoami-rajat has joined #openstack-nova | 04:18 | |
| *** abaindur has joined #openstack-nova | 04:25 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 04:28 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 04:28 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 04:28 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 04:28 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 04:28 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 04:28 |
| *** ociuhandu has joined #openstack-nova | 04:31 | |
| *** sapd1_x has joined #openstack-nova | 04:34 | |
| *** ociuhandu has quit IRC | 04:35 | |
| *** sapd1_x has quit IRC | 04:46 | |
| *** mkrai has joined #openstack-nova | 04:49 | |
| *** dave-mccowan has joined #openstack-nova | 04:56 | |
| *** dave-mccowan has quit IRC | 05:01 | |
| *** gryf has joined #openstack-nova | 05:05 | |
| *** dpawlik has joined #openstack-nova | 05:20 | |
| *** jaosorior has quit IRC | 05:24 | |
| *** igordc has joined #openstack-nova | 05:28 | |
| *** udesale has joined #openstack-nova | 05:33 | |
| *** ratailor has joined #openstack-nova | 05:36 | |
| *** pcaruana has joined #openstack-nova | 05:40 | |
| *** pcaruana has quit IRC | 05:49 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990 | 05:54 |
| *** shilpasd has quit IRC | 06:00 | |
| *** igordc has quit IRC | 06:02 | |
| openstackgerrit | Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776 | 06:09 |
| *** ksdean has quit IRC | 06:10 | |
| openstackgerrit | Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776 | 06:11 |
| *** epoojad1 has joined #openstack-nova | 06:12 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 06:16 |
| *** ivve has joined #openstack-nova | 06:43 | |
| *** mjozefcz has joined #openstack-nova | 06:48 | |
| *** dpawlik has quit IRC | 06:52 | |
| *** damien_r has joined #openstack-nova | 07:00 | |
| *** luksky has joined #openstack-nova | 07:01 | |
| *** abaindur has quit IRC | 07:01 | |
| *** slaweq has joined #openstack-nova | 07:05 | |
| *** psachin has joined #openstack-nova | 07:16 | |
| *** tssurya has joined #openstack-nova | 07:16 | |
| *** tesseract has joined #openstack-nova | 07:17 | |
| *** rcernin has quit IRC | 07:21 | |
| gibi | efried: I felt the same about importing the real fixtures in https://review.opendev.org/#/c/675935 ;) | 07:28 |
| *** rpittau|afk is now known as rpittau | 07:34 | |
| *** jangutter has joined #openstack-nova | 07:34 | |
| *** mjozefcz has quit IRC | 07:36 | |
| *** mjozefcz has joined #openstack-nova | 07:37 | |
| *** pcaruana has joined #openstack-nova | 07:45 | |
| *** macz has joined #openstack-nova | 07:46 | |
| *** helenafm has joined #openstack-nova | 07:46 | |
| *** macz has quit IRC | 07:50 | |
| *** xek has joined #openstack-nova | 07:53 | |
| *** macz has joined #openstack-nova | 07:57 | |
| *** macz has quit IRC | 07:59 | |
| *** dpawlik has joined #openstack-nova | 08:00 | |
| *** ccamacho has joined #openstack-nova | 08:03 | |
| *** ccamacho has quit IRC | 08:03 | |
| *** ccamacho has joined #openstack-nova | 08:03 | |
| *** priteau has joined #openstack-nova | 08:04 | |
| tssurya | good morning gmann, did you already propose a client side change for microversion 2.75 ? just asking so that I can rebase on client side change on that | 08:14 |
| *** derekh has joined #openstack-nova | 08:24 | |
| *** cdent has joined #openstack-nova | 08:26 | |
| *** jaosorior has joined #openstack-nova | 08:26 | |
| *** ociuhandu has joined #openstack-nova | 08:30 | |
| *** ociuhandu has quit IRC | 08:35 | |
| *** dpawlik has quit IRC | 08:37 | |
| *** zhouyao has joined #openstack-nova | 08:42 | |
| zhouyao | bauzas Can you tell me if nvram file can be stored in shared storage? | 08:46 |
| gmann | tssurya: not yet, I am planning for today or tomorrow. | 08:46 |
| gmann | i will ping the link. | 08:46 |
| tssurya | gmann: thanks ! :) | 08:46 |
| *** ociuhandu has joined #openstack-nova | 08:47 | |
| *** ociuhandu has quit IRC | 08:53 | |
| *** trident has quit IRC | 08:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | 09:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | 09:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | 09:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | 09:07 |
| *** trident has joined #openstack-nova | 09:08 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | 09:09 |
| *** rpittau is now known as rpittau|bbl | 09:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | 09:11 |
| *** ccamacho has quit IRC | 09:11 | |
| *** dpawlik has joined #openstack-nova | 09:11 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 09:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113 | 09:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | 09:17 |
| *** psachin has quit IRC | 09:18 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for revert migration with bandwidth https://review.opendev.org/676140 | 09:19 |
| *** priteau has quit IRC | 09:20 | |
| *** takamatsu has joined #openstack-nova | 09:23 | |
| *** trident has quit IRC | 09:25 | |
| *** ksdean has joined #openstack-nova | 09:26 | |
| *** ociuhandu has joined #openstack-nova | 09:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | 09:29 |
| *** ociuhandu has quit IRC | 09:32 | |
| *** trident has joined #openstack-nova | 09:32 | |
| *** mkrai has quit IRC | 09:34 | |
| *** xek has quit IRC | 09:41 | |
| *** xek has joined #openstack-nova | 09:42 | |
| *** zhouyao has quit IRC | 09:49 | |
| *** shilpasd has joined #openstack-nova | 09:50 | |
| *** sapd1_x has joined #openstack-nova | 09:56 | |
| lyarwood | redkrieg: Apologies for missing your ping yesterday re stable device rescue, it's dropped down to the the bottom of the pile for me recently. | 09:56 |
| lyarwood | redkrieg: there appears to be growing interest again so I might kick it back to life for the U cycle but I can't really guarantee anything at this point. | 09:57 |
| slaweq | efried: hi | 09:57 |
| slaweq | efried: I just opened bug https://bugs.launchpad.net/nova/+bug/1839961 as I see that this test if failing quite often | 09:58 |
| openstack | Launchpad bug 1839961 in OpenStack Compute (nova) "Test tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc failing often" [Undecided,New] | 09:58 |
| slaweq | efried: please take a look at it if You will have few minutes, I opened it for nova but maybe it's e.g. tempest issue - I'm not 100% sure | 09:58 |
| *** rcernin has joined #openstack-nova | 10:08 | |
| *** ksdean has quit IRC | 10:13 | |
| *** elod is now known as elod_off | 10:17 | |
| shilpasd | stephenfin: thanks for review 'isolate_aggregate' pre-request filter patches | 10:30 |
| shilpasd | stephenfin: just small query on https://review.opendev.org/#/c/671075/6/nova/scheduler/request_filter.py@68 and @72 | 10:30 |
| shilpasd | if we have only one ResourceRequest, then we can omit union, right? | 10:30 |
| stephenfin | shilpasd: Yeah, I think so. That's what we do in nova/scheduler/utils.py https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L461-L483 | 10:31 |
| *** bhagyashris has quit IRC | 10:31 | |
| stephenfin | Ignore the numbered_groups_from_flavor piece and I think you have exactly what you want | 10:32 |
| stephenfin | Also, there's a check there to see if 'Flavor.extra_specs' exists. However, I assumed it always would so I don't know why that's there. Maybe just tests? | 10:33 |
| *** ociuhandu has joined #openstack-nova | 10:35 | |
| shilpasd | thanks for reference, will address accordingly, and in my changes will check do we need this check 'if 'Flavor.extra_specs' exists', then only add | 10:35 |
| shilpasd | stephenfin: and for https://review.opendev.org/#/c/671074/5/nova/objects/aggregate.py@541 | 10:36 |
| stephenfin | Makes sense. To say everything is passing so far, I imagine you don't, but it would be no harm to trace the paths to see if the field is ever _not_ set | 10:36 |
| shilpasd | will edit doc message | 10:36 |
| shilpasd | sure, will check if field is ever _not_ set, is any causing issue | 10:37 |
| *** ociuhandu has quit IRC | 10:45 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 11:01 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 11:03 |
| *** udesale has quit IRC | 11:03 | |
| *** jaosorior has quit IRC | 11:04 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969 | 11:08 |
| *** ociuhandu has joined #openstack-nova | 11:12 | |
| *** yedongcan has left #openstack-nova | 11:29 | |
| *** sapd1_x has quit IRC | 11:29 | |
| *** slaweq_ has joined #openstack-nova | 11:30 | |
| *** rcernin has quit IRC | 11:31 | |
| *** epoojad1 has quit IRC | 11:31 | |
| *** slaweq has quit IRC | 11:33 | |
| *** trident has quit IRC | 11:34 | |
| *** trident has joined #openstack-nova | 11:40 | |
| openstackgerrit | ya.wang proposed openstack/nova master: Support report driver migrate feature https://review.opendev.org/674522 | 11:44 |
| openstackgerrit | ya.wang proposed openstack/nova master: Add property check when create/rebuild/resize. https://review.opendev.org/674523 | 11:44 |
| openstackgerrit | ya.wang proposed openstack/nova master: Scheduler translate properties to traits https://review.opendev.org/674524 | 11:44 |
| openstackgerrit | ya.wang proposed openstack/nova master: Change method: _live_migration_flags https://review.opendev.org/674525 | 11:44 |
| openstackgerrit | ya.wang proposed openstack/nova master: Add releasenote and update docs. https://review.opendev.org/674526 | 11:44 |
| *** yaawang has quit IRC | 11:47 | |
| *** yaawang has joined #openstack-nova | 11:48 | |
| *** mriedem has joined #openstack-nova | 11:52 | |
| *** yaawang has quit IRC | 11:53 | |
| *** Alon_KS has joined #openstack-nova | 11:54 | |
| *** yaawang has joined #openstack-nova | 11:55 | |
| *** beagles is now known as beagles_pto | 11:57 | |
| mriedem | stephenfin: replied in https://review.opendev.org/#/c/627892/ | 11:59 |
| *** ricolin has quit IRC | 12:01 | |
| openstackgerrit | Peter Penchev proposed openstack/nova master: libvirt: use native AIO mode for StorPool Cinder volumes. https://review.opendev.org/676172 | 12:02 |
| *** artom has joined #openstack-nova | 12:04 | |
| *** bbowen has joined #openstack-nova | 12:08 | |
| *** ivve has quit IRC | 12:09 | |
| *** ociuhandu has quit IRC | 12:09 | |
| *** rpittau|bbl is now known as rpittau | 12:11 | |
| *** ociuhandu has joined #openstack-nova | 12:19 | |
| *** ociuhandu has quit IRC | 12:24 | |
| mriedem | tssurya: i've informally reserved 2.76 for you | 12:26 |
| tssurya | mriedem: just saw the ML, thanks a lot Matt! :) | 12:37 |
| *** eharney has quit IRC | 12:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Prevent init_host test to interfere with other tests https://review.opendev.org/675553 | 12:40 |
| *** priteau has joined #openstack-nova | 12:41 | |
| *** slaweq_ has quit IRC | 12:45 | |
| *** slaweq__ has joined #openstack-nova | 12:45 | |
| *** nweinber_ has joined #openstack-nova | 12:45 | |
| *** jaosorior has joined #openstack-nova | 12:47 | |
| *** jangutter_ has joined #openstack-nova | 12:49 | |
| *** ratailor has quit IRC | 12:51 | |
| *** factor has quit IRC | 12:51 | |
| *** factor has joined #openstack-nova | 12:52 | |
| *** jangutter has quit IRC | 12:52 | |
| *** yonglihe has joined #openstack-nova | 12:52 | |
| yonglihe | melwitt: I came up with some comment to the code you concerned, hope it address your problem. glad to have you take a | 12:56 |
| yonglihe | look: https://review.opendev.org/#/c/627765/36/nova/compute/manager.py | 12:56 |
| yonglihe | sean-k-mooney: I bet you will be here again -:) , so could you please take another round of review for https://review.opendev.org/#/c/627765. | 12:58 |
| sean-k-mooney | hehe i am, ill try an take a look again later today | 12:59 |
| yonglihe | Thanks | 13:01 |
| yonglihe | Have a good review day, Sean, -:) . | 13:02 |
| *** watersj has joined #openstack-nova | 13:12 | |
| *** watersj has left #openstack-nova | 13:15 | |
| *** priteau has quit IRC | 13:20 | |
| *** eharney has joined #openstack-nova | 13:21 | |
| *** artom has quit IRC | 13:21 | |
| *** pcaruana has quit IRC | 13:23 | |
| *** tinwood has quit IRC | 13:30 | |
| *** udesale has joined #openstack-nova | 13:30 | |
| *** tinwood has joined #openstack-nova | 13:31 | |
| *** lbragstad has joined #openstack-nova | 13:31 | |
| *** slaweq__ is now known as slaweq | 13:33 | |
| *** brinzhang has quit IRC | 13:35 | |
| *** brinzhang has joined #openstack-nova | 13:36 | |
| tssurya | dansmith, mriedem: I opened this bug a few days ago : https://bugs.launchpad.net/nova/+bug/1839009 , would be could if someone could confirm it since I am not exactly sure if its a bug or if its intended to be that way. | 13:36 |
| openstack | Launchpad bug 1839009 in OpenStack Compute (nova) "os-server-external-events does not behave correctly for failed single events" [Undecided,New] | 13:36 |
| *** BjoernT has joined #openstack-nova | 13:36 | |
| *** ociuhandu has joined #openstack-nova | 13:37 | |
| dansmith | tssurya: yeah, looks like maybe the assumption around "if accepted events" meaning "no instances" is too naive | 13:39 |
| *** BjoernT_ has joined #openstack-nova | 13:39 | |
| tssurya | dansmith: yea | 13:39 |
| *** BjoernT has quit IRC | 13:39 | |
| *** ociuhandu has quit IRC | 13:41 | |
| dansmith | I dunno what the api recommendation is here, | 13:42 |
| dansmith | but I would think that just removing the else: raise bit there would be fine, | 13:42 |
| dansmith | since we calculate the overall and per-event result regardless | 13:43 |
| dansmith | I think that else is left from my original code that didn't try to do per-event status | 13:43 |
| *** BjoernT has joined #openstack-nova | 13:44 | |
| tssurya | dansmith: yea we could, but wouldn't it change the existing api behaviour? | 13:45 |
| *** BjoernT_ has quit IRC | 13:46 | |
| dansmith | well, obviously it would, but I think it falls under the "people don't write clients to depend on obviously broken behavior" | 13:47 |
| dansmith | we could specifically check for "they provided a legit single-event but the instance just wasn't found, so do this special 404" I guess | 13:47 |
| *** brinzhang has quit IRC | 13:49 | |
| tssurya | dansmith: hmm yea I didn't do anything to the bug since I wasn't sure what was the right way out | 13:49 |
| tssurya | but like you said as least for ironic the client assumes everything is done correctly on server side | 13:49 |
| *** brinzhang has joined #openstack-nova | 13:49 | |
| *** mlavalle has joined #openstack-nova | 13:52 | |
| *** eharney has quit IRC | 13:57 | |
| *** whoami-rajat has quit IRC | 13:59 | |
| *** eharney has joined #openstack-nova | 13:59 | |
| *** pcaruana has joined #openstack-nova | 14:00 | |
| *** lbragstad has quit IRC | 14:02 | |
| redkrieg | lyarwood: thanks for getting back to me. if there's anything I can do to help with stable device rescue, please let me know. it would solve some big pain points for me and my clients. | 14:03 |
| *** dpawlik has quit IRC | 14:06 | |
| efried | slaweq: I've seen https://bugs.launchpad.net/nova/+bug/1839961 quite a bit as well. mriedem is our resident bugmeister, though, perhaps he has insight. | 14:07 |
| openstack | Launchpad bug 1669468 in devstack "duplicate for #1839961 tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Fix released] - Assigned to melanie witt (melwitt) | 14:07 |
| slaweq | efried: thx, yes, mriedem already marked it as duplicate of other bug | 14:08 |
| slaweq | sorry for noise than :) | 14:08 |
| mriedem | the devstack patch was merged yesterday | 14:08 |
| slaweq | and thx for fix | 14:08 |
| mriedem | http://status.openstack.org/elastic-recheck/#1669468 | 14:08 |
| mriedem | if it's still hitting we might have other problems | 14:08 |
| mriedem | https://review.opendev.org/#/c/675721/ | 14:08 |
| * efried crosses off another one | 14:09 | |
| *** Tianhao_Hu has joined #openstack-nova | 14:09 | |
| efried | now the list is down to 167 | 14:09 |
| *** mjozefcz has quit IRC | 14:14 | |
| *** tbachman has joined #openstack-nova | 14:15 | |
| *** jaosorior has quit IRC | 14:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | 14:16 |
| *** nweinber__ has joined #openstack-nova | 14:16 | |
| mriedem | tssurya: when are you on vacation? | 14:17 |
| *** ociuhandu has joined #openstack-nova | 14:17 | |
| *** nweinber_ has quit IRC | 14:19 | |
| *** ociuhandu has quit IRC | 14:22 | |
| *** whoami-rajat has joined #openstack-nova | 14:25 | |
| *** ociuhandu has joined #openstack-nova | 14:25 | |
| Tianhao_Hu | About this issue, there are files left after cold migration every time. But the directory left is empty and has no effect on cold migration. I'm wondering that if we can think this is not a bug? Can anyone give me some help on this? | 14:26 |
| Tianhao_Hu | https://bugs.launchpad.net/starlingx/+bug/1824858 | 14:26 |
| openstack | Launchpad bug 1824858 in StarlingX "nova instance remnant left behind after cold migration completes" [Low,Confirmed] - Assigned to hutianhao27 (hutianhao) | 14:26 |
| *** ricolin has joined #openstack-nova | 14:28 | |
| mriedem | tssurya: dansmith: efried: https://review.opendev.org/#/c/645611/ | 14:30 |
| mriedem | i didn't compare to my last set of comments (PS7) because the diff is too large | 14:32 |
| mriedem | tssurya: if you're going to be on vacation soon, like leaving today/tomorrow, then i can take this over | 14:32 |
| mriedem | i think my main concern is whether or not operators can disable ironic sending the event until nova is completely upgraded | 14:33 |
| efried | They can, there's a conf option on the ironic side. | 14:33 |
| efried | https://review.opendev.org/#/c/664842/19/ironic/conf/nova.py | 14:33 |
| mriedem | efried: you mean just to disalbe nova? | 14:33 |
| dansmith | and unless ironic really cares, it shouldn't be an issue | 14:33 |
| mriedem | ah send_power_notifications | 14:34 |
| mriedem | yeah we should mentio nthat in the nova release note | 14:34 |
| dansmith | I expect ironic is sending these to be informative, but not depending on the result | 14:34 |
| mriedem | dansmith: that's not the issue, | 14:34 |
| mriedem | the issue is if you're doing rolling upgrades of your computes, you've upgraded ironic before nova, then nova control plane, and you can be getting the events, the api sets the task_state on the instance and casts to an old compute that doesn't know how to handle this event and then your instance is stuck with a task_state that won't go back to None w/o admin intervention | 14:34 |
| dansmith | okay yeah, good point | 14:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! tox: Add mypy target https://review.opendev.org/676208 | 14:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | 14:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.opendev.org/676210 | 14:35 |
| dansmith | even if we can disable the ironic side, the nova side needs to not do that | 14:35 |
| *** tbachman has quit IRC | 14:36 | |
| dansmith | tbh, the api setting the task state has kinda rubbed me the wrong way the whole time anyway, | 14:36 |
| dansmith | as it seems like we should just forward this down to the compute and let it do its thing if needed | 14:36 |
| mriedem | i mentioned in ealier review that the API could check the compute service version, but because volume-extended was merged w/o doing that and has the same issue, it was going to slide here as well | 14:36 |
| dansmith | setting task state is to help with races to take action on events, and if we can't do the power state short-circuit because something else has started, it's fine to fail/log late | 14:37 |
| stephenfin | mriedem: Question on https://review.opendev.org/#/c/631581/44/nova/conductor/tasks/cross_cell_migrate.py | 14:37 |
| mriedem | dansmith: that was another thing i pointed out, the API code isn't handling UnexpectedTaskStateError if we lose a race so the API would 500 and fail for all events | 14:37 |
| mriedem | *all events in that request | 14:38 |
| dansmith | mriedem: yeah, so I think I'd use this as an argument to not make this something more complex on the api side | 14:39 |
| mriedem | stephenfin: replied | 14:41 |
| mriedem | stephenfin: i realized late that the cinder 3.44 check in there can be removed now https://review.opendev.org/#/c/649759/ | 14:45 |
| mriedem | i wrote the cross-cell patch before we bumped the min required cinder, | 14:45 |
| mriedem | so i'll remove that in a follow up | 14:45 |
| stephenfin | I also missed that. Yeah, follow-up would be good (y) | 14:45 |
| *** Tianhao_Hu has quit IRC | 14:52 | |
| *** dave-mccowan has joined #openstack-nova | 14:58 | |
| *** tbachman has joined #openstack-nova | 15:03 | |
| *** Tianhao_Hu has joined #openstack-nova | 15:04 | |
| *** dave-mccowan has quit IRC | 15:04 | |
| *** Tianhao_Hu has quit IRC | 15:07 | |
| dansmith | mriedem: I commented on tssurya's patch about the api task_state involvement, and also thought of another problem with that | 15:09 |
| *** liuyulong has joined #openstack-nova | 15:17 | |
| *** mjozefcz has joined #openstack-nova | 15:20 | |
| *** tssurya has quit IRC | 15:22 | |
| *** artom has joined #openstack-nova | 15:23 | |
| mriedem | dansmith: i don't think the libvirt thing is an issue if you're compute is train+ | 15:26 |
| dansmith | no? | 15:26 |
| mriedem | b/c the driver will raise NotImplementedError and @reverts_task_state will set the task_state to None | 15:26 |
| dansmith | is that a call? | 15:26 |
| mriedem | i commented on that in one of the unit tests - as in that scenario is not asserted | 15:26 |
| mriedem | @reverts_task_state is a decorator on the compute managermethod | 15:27 |
| dansmith | ah | 15:27 |
| mriedem | so i think we're covered there, it's just not tested :( | 15:28 |
| dansmith | okay I see, she's got it on the helper method | 15:28 |
| dansmith | I was pretty sure it was not on the event handler function itself | 15:28 |
| mriedem | dansmith: efried: fyi i'll be out on friday, going camping up north in the bOuNdArY wAtErS; if i'm not back next monday it's either because a bear ate me or i illegally emigrated to canada | 15:32 |
| efried | ack | 15:33 |
| efried | you're going with someone you can outrun, right? | 15:33 |
| mriedem | until then i'll be planning on how to live w/o running water and on hot dogs for 6 straight meals | 15:33 |
| mriedem | oh of course | 15:33 |
| *** helenafm has quit IRC | 15:36 | |
| *** yonglihe has quit IRC | 15:42 | |
| *** gyee has joined #openstack-nova | 15:44 | |
| openstackgerrit | Merged openstack/nova stable/ocata: fix unshelve notification test instability https://review.opendev.org/674907 | 15:51 |
| *** mjozefcz has quit IRC | 15:52 | |
| *** macz has joined #openstack-nova | 15:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I30916d8d10d70ce25523fa4961007cedbdfe8ad7 https://review.opendev.org/676228 | 15:52 |
| *** KeithMnemonic has quit IRC | 15:52 | |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | 15:55 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | 15:55 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | 15:57 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | 15:58 |
| *** vesper11 has quit IRC | 15:58 | |
| *** ociuhandu has quit IRC | 15:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676230 | 15:59 |
| *** vesper11 has joined #openstack-nova | 16:00 | |
| *** markvoelker has quit IRC | 16:02 | |
| *** spsurya has quit IRC | 16:04 | |
| *** Alon_KS has left #openstack-nova | 16:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 16:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I4d181b44494f3b0b04537d5798537831c8fdf400 https://review.opendev.org/676231 | 16:08 |
| mriedem | wtf | 16:09 |
| mriedem | oh sob | 16:09 |
| efried | is mriedem wishing he had rebase=false in his .gitconfig? | 16:10 |
| *** Alon_KS has joined #openstack-nova | 16:10 | |
| mriedem | no, i did git review -R, that's not the problem | 16:10 |
| mriedem | the problem is i rebased HEAD~41, FUP to 41, git rebase --continue, FUP to 40, but that was not part of my main series so now it's diverged | 16:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 16:11 |
| sean-k-mooney | efried: im not sure how people end up with git reveiw rebasing there patches without them asking. i dont have rebase=false in my .gitconfig but i dont think i have ever had that proablem and dont then to use -R | 16:12 |
| *** markvoelker has joined #openstack-nova | 16:12 | |
| sean-k-mooney | at least in my normal workflow of "git review -d <gerrit number>; edit, git commit --amend, git review" that has never been a issue i have had | 16:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I4d181b44494f3b0b04537d5798537831c8fdf400 https://review.opendev.org/676231 | 16:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 16:13 |
| mriedem | i'll just wait for the bottom things to merge and then do a proper rebase | 16:15 |
| efried | mriedem: I don't think I understand the rolling upgrade with the ironic event thing. | 16:16 |
| efried | If ironic sends the event to a nova that can't understand it, it'll just bounce, and the behavior will be as if we didn't have the feature, and the nova periodic will force the instance state like it does today -- right?? | 16:16 |
| mriedem | no | 16:16 |
| mriedem | traditional upgrade sequence for nova and ironic is ironic first because the driver didn't do version discovery, | 16:17 |
| *** BjoernT has quit IRC | 16:17 | |
| mriedem | i think that's changed in recent releases but not sure how robust it is, | 16:17 |
| mriedem | so you upgrade ironic, then the nova control plane, and you can have Stein computes for rolling upgrades, right? | 16:17 |
| mriedem | so your nova api is train exposing 2.76 | 16:17 |
| dansmith | yup | 16:18 |
| efried | ah, so this is really a coordination problem where we need to tolerate n-api > n-cpu | 16:18 |
| mriedem | ironic default to send the events and if ironic is configured for talking to nova, | 16:18 |
| mriedem | it will send the events | 16:18 |
| mriedem | yes | 16:18 |
| efried | it really has little to do with the ironic side sending events or not. | 16:18 |
| mriedem | this is why the api does min compute service version checking in places | 16:18 |
| mriedem | correct | 16:18 |
| dansmith | correct, which is why I said the ironic tunable is not a solution | 16:18 |
| mriedem | if the nova api was smarter ironic wouldn't care | 16:18 |
| efried | okay, I'm up to speed, thanks. | 16:18 |
| dansmith | even if the power state sync will fix it (not sure it will), ironic will lock up the instance for some period of time until it unlocks, which is not okay | 16:19 |
| mriedem | the power state sync task will ignore the instance if the task_state is not None | 16:19 |
| mriedem | so if the api gets an event, sets the task_state, then casts off to stein compute that ignores it, the sync task won't fix it | 16:19 |
| dansmith | yeah, I thought it wouldn't fix it up, but I can never remember the million or so conditionals int here | 16:19 |
| dansmith | no response from tssurya right? | 16:19 |
| mriedem | if it's thursday and you're using vcenter you get a free vm | 16:20 |
| mriedem | correct | 16:20 |
| *** macz has quit IRC | 16:26 | |
| cdent | mriedem: nothing ever comes for free from vcenter | 16:31 |
| *** rpittau is now known as rpittau|afk | 16:32 | |
| mriedem | heh | 16:33 |
| *** ociuhandu has joined #openstack-nova | 16:38 | |
| *** jangutter_ has quit IRC | 16:39 | |
| *** macz has joined #openstack-nova | 16:43 | |
| *** udesale has quit IRC | 16:43 | |
| *** tesseract has quit IRC | 16:43 | |
| *** ociuhandu has quit IRC | 16:43 | |
| *** ricolin_ has joined #openstack-nova | 16:48 | |
| *** ricolin has quit IRC | 16:52 | |
| *** slaweq has quit IRC | 16:52 | |
| *** cdent has quit IRC | 16:53 | |
| *** mgariepy has quit IRC | 16:58 | |
| *** jangutter has joined #openstack-nova | 16:59 | |
| *** derekh has quit IRC | 17:00 | |
| *** ricolin_ is now known as ricolin | 17:04 | |
| *** jangutter has quit IRC | 17:10 | |
| *** mgariepy has joined #openstack-nova | 17:20 | |
| *** ociuhandu has joined #openstack-nova | 17:20 | |
| *** ociuhandu_ has joined #openstack-nova | 17:34 | |
| *** ociuhandu has quit IRC | 17:36 | |
| *** ociuhandu_ has quit IRC | 17:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Delete unused get_all_host_states method https://review.opendev.org/676255 | 17:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Convert HostMapping.cells to a dict https://review.opendev.org/676256 | 17:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Cache host to cell mapping in HostManager https://review.opendev.org/676257 | 17:40 |
| *** mvkr has quit IRC | 17:45 | |
| mriedem | the nova-lxc job finds it's first bug https://bugs.launchpad.net/nova/+bug/1840068 | 17:48 |
| openstack | Launchpad bug 1840068 in OpenStack Compute (nova) "(lxc) Instance failed to spawn: TypeError: object of type 'filter' has no len()" [High,Confirmed] | 17:48 |
| *** ociuhandu has joined #openstack-nova | 17:48 | |
| sean-k-mooney | oh you/someone got an lxc job running? cool | 17:50 |
| sean-k-mooney | looks like its more or less in teh same nbd mount region of the code that the other issue was in | 17:51 |
| mriedem | this is a py3 specific failure | 17:51 |
| *** ociuhandu has quit IRC | 17:52 | |
| sean-k-mooney | oh that is becasue filter is nolonger a keyword | 17:53 |
| sean-k-mooney | and not you have to import it form itertools | 17:53 |
| sean-k-mooney | so we need to use six | 17:53 |
| sean-k-mooney | s/keywork/built in fucntion/ | 17:53 |
| *** hamzy has quit IRC | 17:54 | |
| *** shilpasd has quit IRC | 17:59 | |
| mriedem | that implies the problem would actually be in py27 rather than 3 | 18:01 |
| mriedem | https://github.com/openstack/nova/blob/e3a55493ba0cb405f14b9090282d93eb230c5715/nova/virt/disk/mount/nbd.py#L44 | 18:01 |
| mriedem | since it's using filter() | 18:01 |
| mriedem | i think the problem is passing an iterable from filter() to random.shuffle | 18:01 |
| sean-k-mooney | well filter is a builtin in python 2 | 18:02 |
| sean-k-mooney | in python 3 its not and you have to import it | 18:02 |
| sean-k-mooney | so i was about to push what i think is a fix | 18:02 |
| mriedem | ok i'm not sure what was used then, because we | 18:02 |
| mriedem | TypeError: object of type 'filter' has no len() | 18:02 |
| sean-k-mooney | it might be something else | 18:02 |
| sean-k-mooney | does this show up in unit tests | 18:03 |
| mriedem | nope, b/c there is no test coverage | 18:03 |
| mriedem | the method is mocked out | 18:03 |
| mriedem | lots of this old virt/disk/mount code isn't tested very deep | 18:03 |
| sean-k-mooney | ok i guess i should add a test. i was hoping ot just quickly fix this and move on | 18:03 |
| mriedem | it uses a stub, | 18:04 |
| mriedem | _fake_detect_nbd_devices_none | 18:04 |
| mriedem | which returns a [] rather than the results of a filter | 18:04 |
| *** bbowen_ has joined #openstack-nova | 18:04 | |
| *** spatel has joined #openstack-nova | 18:04 | |
| sean-k-mooney | right it shoudl be mocking the os.listdir call really | 18:04 |
| sean-k-mooney | well the stub is fine for oter tests | 18:05 |
| *** bbowen has quit IRC | 18:05 | |
| sean-k-mooney | but we should have a test for that _detect_nbd_devices function directly. | 18:05 |
| *** mjozefcz has joined #openstack-nova | 18:08 | |
| mriedem | yeah i see there is a _fake_listdir_nbd_devices stub but it's not used by anything, i.e. removing that doesn't make tests fail | 18:09 |
| *** markvoelker has quit IRC | 18:12 | |
| *** markvoelker has joined #openstack-nova | 18:15 | |
| *** BjoernT has joined #openstack-nova | 18:15 | |
| *** mjozefcz has quit IRC | 18:16 | |
| mriedem | yeah so filter() in py27 returns a list, or some kind of iterable, and in py3 it's a built-in function | 18:21 |
| mriedem | which is why random.shuffle doesn't handle it | 18:21 |
| *** bbowen__ has joined #openstack-nova | 18:24 | |
| *** abaindur has joined #openstack-nova | 18:25 | |
| *** bbowen_ has quit IRC | 18:27 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 18:27 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 18:27 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 18:27 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 18:27 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 18:27 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 18:27 |
| *** hamzy has joined #openstack-nova | 18:30 | |
| *** eharney has quit IRC | 18:33 | |
| openstackgerrit | sean mooney proposed openstack/nova master: lxc: make use of filter python3 compatiable https://review.opendev.org/676263 | 18:40 |
| sean-k-mooney | mriedem: i think that should fix it ^ | 18:43 |
| mriedem | yup just commented | 18:43 |
| mriedem | i was working on the same thing | 18:43 |
| sean-k-mooney | :) i can make the chagne you suggest but if you have tehm locally i can also abandon min | 18:45 |
| sean-k-mooney | it will only take 30 secons either way | 18:45 |
| mriedem | i dropped mine | 18:45 |
| sean-k-mooney | ok ill make it a static method so it does not need to be an instance method at all | 18:45 |
| sean-k-mooney | we dont traselate logs anymore right | 18:46 |
| sean-k-mooney | you know what ill jsut fix this and i wont rewrite teh fule file | 18:47 |
| sean-k-mooney | its tempting but i have no idea why we save sutff to self.error in the oter functions and i dont want to break that | 18:48 |
| openstackgerrit | Merged openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 18:48 |
| openstackgerrit | Merged openstack/nova master: Prevent init_host test to interfere with other tests https://review.opendev.org/675553 | 18:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Get ironicclient retry conf from ksa https://review.opendev.org/676264 | 18:49 |
| *** mrhillsman has joined #openstack-nova | 18:51 | |
| *** hamzy has quit IRC | 18:51 | |
| *** hamzy has joined #openstack-nova | 18:51 | |
| efried | dustinc: Having done all that work... now I'm not sure it's the right thing at all. | 18:52 |
| efried | dansmith: Why are those other methods remotable? | 18:52 |
| dansmith | efried: there are some legacy cases where aggregate methods got called from the compute, like when the xen driver was doing some sync | 18:53 |
| dansmith | and potentially also just people adding them because they see the decorator elsewhere and don't understand | 18:53 |
| efried | yes, that's certainly what I would have done | 18:53 |
| openstackgerrit | sean mooney proposed openstack/nova master: lxc: make use of filter python3 compatiable https://review.opendev.org/676263 | 18:58 |
| sean-k-mooney | mriedem: done im going to grab something to eat so ill be afk for a while | 18:59 |
| *** cfriesen has joined #openstack-nova | 19:03 | |
| efried | o/ cfriesen! how are things? | 19:06 |
| cfriesen | efried: just got back from long road trip with family. now recovering from my vacation | 19:06 |
| cfriesen | :) | 19:06 |
| efried | ah yes, I know the feeling | 19:07 |
| *** mgariepy has quit IRC | 19:08 | |
| *** mriedem has quit IRC | 19:08 | |
| *** mriedem has joined #openstack-nova | 19:12 | |
| *** ivve has joined #openstack-nova | 19:14 | |
| mriedem | easy fix https://review.opendev.org/#/c/676263/ | 19:18 |
| dansmith | mriedem: sean-k-mooney won't list() fix it without the six thing? | 19:21 |
| mnaser | mriedem: about https://review.opendev.org/#/c/675496/ would it make sense to make a patch updating the index? | 19:23 |
| mnaser | (in master, so that one alone is backportable) | 19:23 |
| *** mvkr has joined #openstack-nova | 19:24 | |
| mriedem | dansmith: yeah i think so | 19:24 |
| dansmith | mriedem: so am I missing why we don't just do that? I mean, this works too but I don't think it's what we've done elsewhere | 19:25 |
| mriedem | that's what i was doing in my local patch, but sean-k-mooney beat me to it and used six here so... | 19:25 |
| mriedem | i'm fine with removing the six.moves | 19:25 |
| mriedem | mnaser: you mean change the unique index from just uuid to uuid + deleted? | 19:26 |
| mnaser | yeah | 19:26 |
| dansmith | I know he'll be back.. should we wait to see if he had some reason or just go ahead and fix it? | 19:26 |
| dansmith | not sure if it's a rush | 19:26 |
| mriedem | mnaser: the schema change is a bit wonkier b/c the unique index is defined on the uuid column rather than an actual index | 19:26 |
| mriedem | it's not a rush, can wait for sean | 19:26 |
| mnaser | mriedem: i guess the only issue with that is if you put your entire fleet into maintenance mode and then bring it back | 19:27 |
| mnaser | you just doubled your db | 19:27 |
| mriedem | mnaser: nvm, i guess it's not defined on the column https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L115 | 19:27 |
| mnaser | so i think i rather not end up with that type of thing | 19:27 |
| mriedem | it's just a unique index | 19:27 |
| mnaser | my suggestion was to drop the update-deleted workaround | 19:28 |
| mnaser | and make it so that it creates a new entry anyways | 19:28 |
| mnaser | actually i havent had enough coffee | 19:28 |
| mnaser | ignore me :) | 19:29 |
| *** mvkr has quit IRC | 19:30 | |
| * mriedem looks at clock | 19:31 | |
| mriedem | what tz are you in? | 19:31 |
| dansmith | he's a millenial | 19:32 |
| mriedem | the order of the columns in the index also matters and i'm not sure what order we'd use for that unique index | 19:32 |
| dansmith | so, start work at 11am, lunch at 12, etc | 19:32 |
| *** eharney has joined #openstack-nova | 19:32 | |
| *** whoami-rajat has quit IRC | 19:33 | |
| efried | dustinc: You handy? | 19:33 |
| *** slaweq has joined #openstack-nova | 19:34 | |
| *** mgariepy has joined #openstack-nova | 19:34 | |
| efried | dustinc: I just put up https://review.opendev.org/676268 which, until it's merged, you should Depends-On from https://review.opendev.org/#/c/642899/ which should also bump the ksa minimum to 3.16.0. | 19:35 |
| efried | mriedem: Is devstack automatically a required-projects? | 19:35 |
| efried | i.e. can I Depends-On a devstack patch from nova without twaddling .zuul.yaml? | 19:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024 | 19:37 |
| mriedem | you said twaddle | 19:38 |
| mriedem | eventually the job inherits from devstack-base which requires devstack | 19:38 |
| *** bbowen__ has quit IRC | 19:39 | |
| efried | okay, cool | 19:40 |
| *** markvoelker has quit IRC | 20:10 | |
| *** dpawlik has joined #openstack-nova | 20:19 | |
| *** markvoelker has joined #openstack-nova | 20:28 | |
| mriedem | efried: i volunteer alex_xu and gibi for the project update in shanghai | 20:31 |
| efried | ++ | 20:31 |
| efried | dual language | 20:31 |
| *** spatel has quit IRC | 20:32 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275 | 20:35 |
| *** bbowen__ has joined #openstack-nova | 20:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient master: API microversion 2.76: Add 'power-update' external event https://review.opendev.org/666792 | 20:39 |
| *** abaindur has quit IRC | 20:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: rt: only map compute node if we created it https://review.opendev.org/676278 | 20:49 |
| *** dpawlik has quit IRC | 21:02 | |
| *** xek has quit IRC | 21:04 | |
| *** markvoelker has quit IRC | 21:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: rt: only map compute node if we created it https://review.opendev.org/676280 | 21:09 |
| *** dpawlik has joined #openstack-nova | 21:11 | |
| sean-k-mooney | dansmith: technically yes just list would be fine. but on python 2.7 you would be constucting the list twice, six.move.filter is itertools.iflter on py27 and just the filter builtin on py3 so six.moves.fiter alway return an interator which we colapse into a list | 21:17 |
| sean-k-mooney | we proably dont care too much for that specifc case | 21:18 |
| sean-k-mooney | efried: mriedem dansmith want me to drop the use of six? or just fix typos/nits or leave it as is | 21:24 |
| openstackgerrit | Merged openstack/nova stable/ocata: Replace non-nova server fault message https://review.opendev.org/674908 | 21:26 |
| mriedem | sean-k-mooney: you're listifying twice on py27 anyway yeah? | 21:26 |
| mriedem | so dropping six is fine | 21:26 |
| sean-k-mooney | with six.moves.filter no | 21:26 |
| sean-k-mooney | by that i mean it will only build the list once with six.move.filter regardless of the version of python | 21:28 |
| sean-k-mooney | but i also dont partaclly care too much for this so ill do whatever ye prefer | 21:28 |
| melwitt | can anyone link me a shortcut to where the "strict host isolation" work is going on at this point? is it called "dedicated CPUs" now? | 21:31 |
| efried | This is up to dansmith and his passive-aggressive no-vote | 21:31 |
| sean-k-mooney | strict host isolation? | 21:32 |
| efried | melwitt: are you talking about forbidden aggregates? | 21:32 |
| efried | melwitt: https://review.opendev.org/#/q/topic:bp/placement-req-filter-forbidden-aggregates+(status:open+OR+status:merged) | 21:32 |
| melwitt | it's the thing where if you have windows licenses or something, you only want certain tenants landing on those and other tenants not allowed to land on them | 21:32 |
| *** artom has quit IRC | 21:32 | |
| efried | Yeah, that ^ | 21:33 |
| sean-k-mooney | ya that the forbidden aggretates thing | 21:33 |
| efried | not at all related to "dedicated CPUs" https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cpu-resources | 21:33 |
| melwitt | ok, thanks. I lost track of what it was called today | 21:33 |
| melwitt | haha, well, glad I asked | 21:33 |
| efried | heh, yeah, now we're calling it "isolated aggregates" | 21:33 |
| efried | yes, yes you are | 21:33 |
| melwitt | customers asking about it | 21:33 |
| sean-k-mooney | efried: well to melwitt defence until this relase you have to isolate dedicated cpu into there own host aggreate | 21:33 |
| sean-k-mooney | so i get why she might link those | 21:34 |
| efried | you wouldn't have wanted to get entrenched in that series only to realize it wasn't the one you cared about :P | 21:34 |
| melwitt | because today they have to label all aggregates with something in order to have guests not land on certain aggregates and it's a pain | 21:34 |
| efried | melwitt: you still kinda have to do that. | 21:34 |
| efried | oh, you mean you even have to label the ones you're *not* isolating? | 21:34 |
| melwitt | yes | 21:35 |
| sean-k-mooney | unless you use my/rdolfos out of tree filter... | 21:35 |
| efried | mm | 21:35 |
| sean-k-mooney | well actuly that still neede you to put stuff in aggrate metaddata | 21:35 |
| melwitt | because if something lacks a label, a guest can still land there. if I'm thinking about this right | 21:35 |
| melwitt | lacks a key, I mean | 21:35 |
| melwitt | and what they want is, guests can only land on this host if flavor key=value matches aggregate key=value and aggregates that do not have that key will not match | 21:36 |
| sean-k-mooney | if you want to requrie traits to be request to land on a host. you need either https://github.com/openstack/nfv-filters/blob/master/nfv_filters/nova/scheduler/filters/aggregate_instance_type_filter.py or my reverse required tratis featrue i wand in plamcneet | 21:37 |
| mriedem | melwitt: yes you are correct | 21:37 |
| melwitt | yesss I was right once | 21:37 |
| mriedem | with current in-tree filters you can restrict things to host aggregates but not exclude other unrestricted things from landing on those same hosts | 21:37 |
| mriedem | which is why you have to create aggregates for everything to strictly isolate everything | 21:38 |
| mriedem | which is the mgmt pain in the ass | 21:38 |
| melwitt | yeah exactly | 21:38 |
| melwitt | they've labeled everything like, windows=YES and windows=NO, for example, to get the strict isolation | 21:38 |
| mriedem | https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregatemultitenancyisolation has an example as well about the exclusion problem | 21:39 |
| sean-k-mooney | yes but we fixed that and the sylvain fast revreted it | 21:39 |
| efried | melwitt: the series is pretty close to landing, just a couple of little tweaks requested by dansmith, so if you want in, now's the time. | 21:39 |
| melwitt | thanks for the pointers. I'll read through that so I can let them know where upstream is at with the feature | 21:39 |
| melwitt | they asked for the feature but I know it's been in the works for a long time and wasn't sure what it was being called now :) thanks all | 21:40 |
| *** igordc has joined #openstack-nova | 21:52 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 21:57 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029 | 21:57 |
| *** hamzy has quit IRC | 21:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Hook resource_tracker to remove stale node information https://review.opendev.org/676282 | 21:59 |
| melwitt | oh, the ability to add a suffix to filter_tenant_id is only when filtering with placement | 22:03 |
| openstackgerrit | Merged openstack/nova master: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676030 | 22:08 |
| *** dpawlik has quit IRC | 22:10 | |
| *** slaweq has quit IRC | 22:10 | |
| *** markvoelker has joined #openstack-nova | 22:10 | |
| *** markvoelker has quit IRC | 22:14 | |
| mriedem | yup | 22:16 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1802111 | 22:17 |
| openstack | Launchpad bug 1802111 in OpenStack Compute (nova) rocky "Unable to assign more than 7 tenants to a filter_tenant_id string" [Low,Fix committed] - Assigned to Matt Riedemann (mriedem) | 22:17 |
| *** nweinber__ has quit IRC | 22:21 | |
| openstackgerrit | Merged openstack/nova master: rt: only map compute node if we created it https://review.opendev.org/675704 | 22:23 |
| openstackgerrit | Merged openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 22:23 |
| openstackgerrit | sean mooney proposed openstack/nova master: lxc: make use of filter python3 compatible https://review.opendev.org/676263 | 22:27 |
| *** igordc has quit IRC | 22:28 | |
| *** igordc has joined #openstack-nova | 22:28 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: lxc: make use of filter python3 compatible https://review.opendev.org/676263 | 22:30 |
| *** igordc has quit IRC | 22:33 | |
| sean-k-mooney | mriedem: i dont know why i even try somtimes. i actully spell checked that in grammerly then copied it and decied to tweak it slightly | 22:33 |
| sean-k-mooney | i should never tweak a commit message out of a tool that fixes spelling because i obviously just cant | 22:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024 | 22:34 |
| sean-k-mooney | thanks for fixing it directly :) | 22:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024 | 22:36 |
| *** ivve has quit IRC | 22:36 | |
| mriedem | you must have run it through the olde englishifier to change behavior to behaviour | 22:37 |
| *** luksky has quit IRC | 22:37 | |
| sean-k-mooney | actully i proably dont have it set to us english | 22:38 |
| mriedem | oooo | 22:38 |
| mriedem | don't tell trump that | 22:39 |
| sean-k-mooney | sorry i belive its called american my bad :P | 22:39 |
| mriedem | 'merican | 22:39 |
| mriedem | please | 22:39 |
| mriedem | pew pew yee hawww | 22:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: rt: only map compute node if we created it https://review.opendev.org/676285 | 22:41 |
| melwitt | argh, I'm too dumb to understand placement_aggregate_required_for_tenants after reading the help | 22:50 |
| sean-k-mooney | what is the help text? | 22:51 |
| melwitt | ok, the reno helps | 22:51 |
| sean-k-mooney | that praobly means we need better help test in the config option | 22:51 |
| melwitt | "This setting, when limit_tenants_to_placement_aggregate=True, will control whether or not a tenant with no aggregate affinity will be allowed to schedule to any available node. If aggregates are used to limit some tenants but not all, then this should be False. If all tenants should be confined via aggregate, then this should be True to prevent them from receiving unrestricted scheduling to any available node." | 22:51 |
| mriedem | there is a doc on it | 22:52 |
| melwitt | I'm looking at it now | 22:52 |
| melwitt | the conf option help was like.... not understandable by me | 22:53 |
| sean-k-mooney | it could be worded clearer but tl;dr is if you want to require all tenants be mapped to placmenet aggrates then set it to true | 22:53 |
| sean-k-mooney | otherwise set it to false | 22:53 |
| mriedem | "Multiple tenants may be added to a single aggregate by appending a serial number to the key, such as filter_tenant_id:123." is lacking a big | 22:54 |
| mriedem | *bit | 22:54 |
| sean-k-mooney | melwitt: i would have to read that twice or tree times to parse it if had not seen it before | 22:55 |
| sean-k-mooney | serial number is kind of cryptic | 22:55 |
| mriedem | the doc is more clear IMO, | 22:56 |
| mriedem | "Note that the filter_tenant_id metadata key can be optionally suffixed with any string for multiple tenants, such as filter_tenant_id3=$tenantid." | 22:56 |
| melwitt | yeah, that makes sense to me. placement_aggregate_required_for_tenants is actually not mentioned in the doc though | 22:56 |
| sean-k-mooney | oh that what they ment i though serial number was referint to the 123 e.g. a different name for the teanant id | 22:57 |
| melwitt | heh | 22:57 |
| mriedem | melwitt: yeah i noticed that too | 22:57 |
| melwitt | I think the reason this isn't clear to me is because I know that strict isolation isn't possible, yet "placement_aggregate_required_for_tenants" makes it sound like it is | 22:58 |
| *** tkajinam has joined #openstack-nova | 22:59 | |
| melwitt | ok, looking at the code, I see that placement_aggregate_required_for_tenants means that it will warn and fail if no aggregate has a match for filter_tenant_id | 23:00 |
| melwitt | does that mean strict tenant isolation *is* possible already? sounds like it | 23:01 |
| sean-k-mooney | melwitt: i think you can build stict isolation with that if you manually map each tenant to a different aggretate | 23:01 |
| melwitt | yeah... because if you turn this on, it will not let you land on filter_tenant_id-less hosts | 23:02 |
| sean-k-mooney | then you can set the correct conf options to for the scheduler/plamcent to reject request that are not mapped to an aggregate | 23:02 |
| sean-k-mooney | yep | 23:02 |
| sean-k-mooney | but its just as much a pain in the ass as doing it with host aggrates and the old tenabt isolation filter | 23:03 |
| melwitt | yeah, true | 23:03 |
| sean-k-mooney | i proably performs better | 23:03 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029 | 23:03 |
| melwitt | yeah ok, this isn't actually different, just the mechanism is different (better) and then you can get it to warn you if you didn't set the tenant keys on all your aggregates | 23:04 |
| sean-k-mooney | yeah so its the waring/force fail behavior is slightly better but not a lot | 23:05 |
| mriedem | the tenant to aggregate stuff was for cern i think, to model tenant-to-cell with azs / aggregates for a cell | 23:06 |
| mriedem | since cern maps tenants to specific cells | 23:06 |
| mriedem | and with that i'm out | 23:08 |
| *** mriedem has quit IRC | 23:08 | |
| melwitt | yeah, I was thinking this was for CERN. the customer case I'm writing this up for is also dividing up the cluster per tenant | 23:08 |
| sean-k-mooney | cern used to use the tenat isoaltion filter to do that tenat to cell mapping with cells v1 when they had two levels of scheduler | 23:11 |
| sean-k-mooney | so ya this was a partity thing for them to be able to move to cells v2 | 23:11 |
| melwitt | ah, thanks | 23:15 |
| melwitt | I knew the basics of that but a lot of these scheduler things confuse me, so here I am :P | 23:16 |
| sean-k-mooney | ya cern is an edge case as they have so many host they needed to use the limit parmater on the placmenet api and and if they did that without the aggrate feature placmenet could return only host that did not map to the correct cell | 23:20 |
| sean-k-mooney | and when it hit the tenat isolation filter it would eliminate all hosts | 23:20 |
| melwitt | ah right | 23:20 |
| sean-k-mooney | so now they use this pluse a limit of like 15 host or something similarly tiny | 23:21 |
| sean-k-mooney | the default limit being 1000 | 23:21 |
| *** markvoelker has joined #openstack-nova | 23:25 | |
| *** macz has quit IRC | 23:32 | |
| *** mlavalle has quit IRC | 23:33 | |
| *** markvoelker has quit IRC | 23:36 | |
| *** takashin has joined #openstack-nova | 23:37 | |
| melwitt | sean-k-mooney: with forbidden aggregates, do you know off the top of your head what happens with aggregate-less hosts? will they still come back as eligible to be scheduled upon or no? | 23:47 |
| sean-k-mooney | i belive the intent is the prefilter will append a forbidine aggreate requrest based on info in the the request spec to the placment query | 23:48 |
| sean-k-mooney | so i guess they would be allowed | 23:48 |
| sean-k-mooney | but no i dont know off the top of my head what the actul behavior is for certin | 23:49 |
| melwitt | yeah, ok. that's what I was thinking | 23:49 |
| sean-k-mooney | the spec is a little light on details | 23:51 |
| sean-k-mooney | oh i see we went with sotring the tratit requriemetn in the hostaggreate metadata | 23:52 |
| sean-k-mooney | * nova host agggreate metadata | 23:52 |
| melwitt | ok, so yeah need everything to be in an aggregate in order for it to be excluded. I think. | 23:53 |
| sean-k-mooney | yep exactlyu like my old filter worked... | 23:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676289 | 23:54 |
| sean-k-mooney | except that predated placmenet and match on flavor extra_specs | 23:54 |
| sean-k-mooney | actully this is a little less flexiable but its close | 23:55 |
| melwitt | RIP old filter | 23:55 |
| sean-k-mooney | melwitt: how would you feel about adding cpu pinning or hugepage traits? | 23:56 |
| melwitt | I don't know :( I know very little about those | 23:56 |
| sean-k-mooney | they dont exisats. yet... actully i have a better way to do what i want to do if i have thos | 23:57 |
| sean-k-mooney | *those | 23:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676290 | 23:57 |
| sean-k-mooney | dpdk requried you to have hugepages to work with openstack | 23:58 |
| sean-k-mooney | if we have a hugepage traits we could make it so your dpdk host would not allow vms without hugepages to be scheuled | 23:58 |
| sean-k-mooney | for pinning we already have the dedicated cpus spec | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!