*** xek__ has joined #openstack-nova | 00:00 | |
gmann | melwitt: but can we query on placement for nova owned limits usage (server groups, injected_files etc) ? also not about showing the limit from keystone so we need to keep the GET /os-quota-sets for those limits al least. | 00:01 |
---|---|---|
melwitt | gmann: I'm not sure I understand the second question about the existing GET quotas API for limits. we have to keep that as long as old quotas are the default, I think | 00:01 |
melwitt | gmann: we cannot, no. so that's another thing | 00:02 |
*** xek_ has quit IRC | 00:02 | |
gmann | yeah. | 00:03 |
melwitt | gmann: it's a little unclear because there's overlap with /limits and GET /os-quota-sets. I'm not sure we need the latter if we have the former (once unified limits is default down the road) | 00:04 |
melwitt | the (server groups, injected_files etc) limits are shown from /limits and will only be modifiable via the config files. no more API access for those | 00:05 |
*** TxGirlGeek has quit IRC | 00:05 | |
melwitt | *no more API access to update those | 00:05 |
gmann | yeah, if we keep /limits then it is enough. But we need one API to show those limits and usage. | 00:06 |
melwitt | yeah, agreed | 00:06 |
*** slaweq has joined #openstack-nova | 00:11 | |
openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 00:12 |
*** slaweq has quit IRC | 00:15 | |
*** gyee has quit IRC | 00:19 | |
openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 00:20 |
openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 00:22 |
*** brinzhang_ has quit IRC | 00:38 | |
*** brinzhang_ has joined #openstack-nova | 00:39 | |
*** igordc has quit IRC | 00:45 | |
*** BjoernT has joined #openstack-nova | 00:45 | |
*** brinzhang has quit IRC | 00:47 | |
*** brinzhang has joined #openstack-nova | 00:47 | |
*** BjoernT has quit IRC | 00:47 | |
*** BjoernT has joined #openstack-nova | 00:48 | |
*** BjoernT has quit IRC | 00:48 | |
*** BjoernT has joined #openstack-nova | 00:49 | |
*** BjoernT has quit IRC | 00:49 | |
*** BjoernT has joined #openstack-nova | 00:49 | |
*** BjoernT has quit IRC | 00:50 | |
*** BjoernT has joined #openstack-nova | 00:50 | |
*** BjoernT has quit IRC | 00:50 | |
*** BjoernT has joined #openstack-nova | 00:51 | |
*** brinzhang has quit IRC | 00:51 | |
*** BjoernT has quit IRC | 00:51 | |
*** betherly has joined #openstack-nova | 00:51 | |
*** brinzhang_ has quit IRC | 00:52 | |
*** BjoernT has joined #openstack-nova | 00:54 | |
*** BjoernT has quit IRC | 00:54 | |
*** ricolin has joined #openstack-nova | 00:56 | |
*** betherly has quit IRC | 00:56 | |
*** mlavalle has quit IRC | 00:56 | |
*** avolkov has quit IRC | 01:04 | |
*** betherly has joined #openstack-nova | 01:13 | |
*** betherly has quit IRC | 01:17 | |
*** betherly has joined #openstack-nova | 01:33 | |
*** betherly has quit IRC | 01:38 | |
*** boxiang_ has quit IRC | 01:40 | |
*** yaawang has quit IRC | 01:44 | |
*** yaawang has joined #openstack-nova | 01:44 | |
*** brinzhang_ has joined #openstack-nova | 01:48 | |
*** brinzhang has joined #openstack-nova | 01:48 | |
*** betherly has joined #openstack-nova | 01:54 | |
*** betherly has quit IRC | 01:59 | |
*** sapd1_x has joined #openstack-nova | 02:06 | |
*** tinwood has quit IRC | 02:10 | |
*** slaweq has joined #openstack-nova | 02:11 | |
*** tinwood has joined #openstack-nova | 02:12 | |
*** brinzhang_ has quit IRC | 02:14 | |
*** brinzhang has quit IRC | 02:14 | |
*** brinzhang has joined #openstack-nova | 02:14 | |
*** brinzhang_ has joined #openstack-nova | 02:14 | |
*** betherly has joined #openstack-nova | 02:15 | |
*** slaweq has quit IRC | 02:16 | |
*** betherly has quit IRC | 02:20 | |
*** whoami-rajat has joined #openstack-nova | 02:26 | |
*** bhagyashris has joined #openstack-nova | 02:33 | |
*** factor has joined #openstack-nova | 02:38 | |
*** betherly has joined #openstack-nova | 02:57 | |
*** JamesBenson has joined #openstack-nova | 02:59 | |
*** JamesBenson has quit IRC | 02:59 | |
openstackgerrit | karim proposed openstack/nova-specs master: Support VM memory encryption using Intel's MKTME https://review.opendev.org/666769 | 03:00 |
*** betherly has quit IRC | 03:01 | |
*** _hemna has joined #openstack-nova | 03:02 | |
*** slaweq has joined #openstack-nova | 03:11 | |
*** JamesBenson has joined #openstack-nova | 03:14 | |
*** slaweq has quit IRC | 03:15 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Always cleanup when hitting MaxRetriesExceeded https://review.opendev.org/672855 | 03:22 |
*** psachin has joined #openstack-nova | 03:22 | |
*** psachin has quit IRC | 03:23 | |
openstackgerrit | pengyuesheng proposed openstack/os-vif master: Blacklist sphinx 2.1.0 (autodoc bug) https://review.opendev.org/672856 | 03:23 |
*** _hemna has quit IRC | 03:25 | |
eandersson | sean-k-mooney, no clue if that is the fix, but looks reasonable to me ^ | 03:25 |
openstackgerrit | pengyuesheng proposed openstack/os-vif master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/672857 | 03:26 |
*** artom has quit IRC | 03:27 | |
*** psachin has joined #openstack-nova | 03:27 | |
openstackgerrit | pengyuesheng proposed openstack/os-vif master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/672857 | 03:27 |
*** betherly has joined #openstack-nova | 03:28 | |
*** betherly has quit IRC | 03:33 | |
*** sapd1_x has quit IRC | 03:39 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Always cleanup when hitting MaxRetriesExceeded https://review.opendev.org/672855 | 03:46 |
*** Luzi has joined #openstack-nova | 03:48 | |
*** betherly has joined #openstack-nova | 03:48 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Always cleanup when hitting MaxRetriesExceeded https://review.opendev.org/672855 | 03:49 |
*** JamesBenson has quit IRC | 03:52 | |
*** betherly has quit IRC | 03:53 | |
*** udesale has joined #openstack-nova | 03:57 | |
*** betherly has joined #openstack-nova | 04:09 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** betherly has quit IRC | 04:14 | |
*** slaweq has quit IRC | 04:15 | |
*** yaawang has quit IRC | 04:24 | |
*** yaawang has joined #openstack-nova | 04:24 | |
openstackgerrit | Merged openstack/nova-specs master: Add user_id to the migrations https://review.opendev.org/667894 | 04:25 |
*** betherly has joined #openstack-nova | 04:30 | |
alex_xu | sean-k-mooney: stephenfin the real_time_mask indeed neeed the '^', you can check my reply https://review.opendev.org/#/c/668656/4/specs/train/approved/use-pcpu-vcpu-in-one-instance.rst@84 | 04:31 |
*** mkrai has joined #openstack-nova | 04:34 | |
*** betherly has quit IRC | 04:35 | |
*** ChipOManiac has joined #openstack-nova | 04:38 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration https://review.opendev.org/672595 | 04:49 |
*** BjoernT has joined #openstack-nova | 04:58 | |
*** betherly has joined #openstack-nova | 05:01 | |
*** BjoernT has quit IRC | 05:01 | |
*** BjoernT has joined #openstack-nova | 05:02 | |
*** BjoernT has quit IRC | 05:02 | |
*** betherly has quit IRC | 05:06 | |
*** jaosorior has joined #openstack-nova | 05:21 | |
*** etp has joined #openstack-nova | 05:27 | |
*** ratailor has joined #openstack-nova | 05:40 | |
*** ratailor has quit IRC | 05:41 | |
*** rtjure has joined #openstack-nova | 05:42 | |
*** ratailor has joined #openstack-nova | 05:43 | |
*** zbr has joined #openstack-nova | 05:44 | |
*** JamesBenson has joined #openstack-nova | 05:53 | |
*** JamesBenson has quit IRC | 05:57 | |
*** rcernin has quit IRC | 06:08 | |
*** slaweq has joined #openstack-nova | 06:11 | |
*** slaweq has quit IRC | 06:16 | |
*** dpawlik has joined #openstack-nova | 06:25 | |
*** etp has quit IRC | 07:02 | |
openstackgerrit | Huachang Wang proposed openstack/os-traits master: CPU: add a trait for AVX512-VNNI support https://review.opendev.org/672888 | 07:02 |
*** tesseract has joined #openstack-nova | 07:03 | |
*** brinzhang_ has quit IRC | 07:03 | |
*** brinzhang has quit IRC | 07:03 | |
*** brinzhang has joined #openstack-nova | 07:04 | |
*** maciejjozefczyk has joined #openstack-nova | 07:04 | |
*** brinzhang has quit IRC | 07:04 | |
*** brinzhang has joined #openstack-nova | 07:06 | |
*** slaweq has joined #openstack-nova | 07:07 | |
*** awalende has joined #openstack-nova | 07:19 | |
*** brault has joined #openstack-nova | 07:35 | |
*** rpittau|afk is now known as rpittau | 07:44 | |
*** pcaruana has joined #openstack-nova | 07:44 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 07:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 07:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 07:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py https://review.opendev.org/636318 | 07:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | 07:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 07:48 |
openstackgerrit | Alex Xu proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices https://review.opendev.org/670782 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Moves the allocation retrieving early https://review.opendev.org/670783 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker https://review.opendev.org/670784 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 07:51 |
openstackgerrit | Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 07:51 |
*** brinzhang_ has joined #openstack-nova | 07:55 | |
*** ralonsoh has joined #openstack-nova | 07:56 | |
*** brinzhang has quit IRC | 07:58 | |
*** ttsiouts has joined #openstack-nova | 08:03 | |
*** brinzhang_ has quit IRC | 08:04 | |
*** brinzhang has joined #openstack-nova | 08:06 | |
*** tssurya has joined #openstack-nova | 08:08 | |
*** ricolin has quit IRC | 08:19 | |
*** tssurya has quit IRC | 08:23 | |
*** ivve has joined #openstack-nova | 08:37 | |
*** mdbooth has joined #openstack-nova | 08:48 | |
*** shilpasd has joined #openstack-nova | 08:59 | |
*** cdent has joined #openstack-nova | 09:06 | |
*** yaawang has quit IRC | 09:08 | |
*** yaawang has joined #openstack-nova | 09:10 | |
*** ratailor has quit IRC | 09:16 | |
*** ratailor has joined #openstack-nova | 09:18 | |
*** derekh has joined #openstack-nova | 09:23 | |
*** arxcruz is now known as arxcruz|off | 09:32 | |
*** ttsiouts has quit IRC | 09:46 | |
*** ttsiouts has joined #openstack-nova | 09:47 | |
*** ttsiouts has quit IRC | 09:51 | |
*** priteau has joined #openstack-nova | 09:53 | |
*** bhagyashris has quit IRC | 09:54 | |
*** brinzhang_ has joined #openstack-nova | 09:54 | |
*** brinzhang has quit IRC | 09:58 | |
*** ttsiouts has joined #openstack-nova | 10:01 | |
*** dpawlik has quit IRC | 10:08 | |
*** brinzhang has joined #openstack-nova | 10:08 | |
aspiers | sean-k-mooney, efried, bbobrov: exciting progress! http://paste.openstack.org/show/754889/ | 10:11 |
*** brinzhang_ has quit IRC | 10:12 | |
aspiers | cdent: inventory stuff seems to be working nicely :) ^^^ | 10:13 |
cdent | excellent, glad to hear it | 10:14 |
*** ttsiouts has quit IRC | 10:25 | |
*** ttsiouts has joined #openstack-nova | 10:25 | |
*** dpawlik has joined #openstack-nova | 10:26 | |
*** ttsiouts has quit IRC | 10:30 | |
*** brinzhang has quit IRC | 10:32 | |
*** brtknr has quit IRC | 10:36 | |
*** brtknr has joined #openstack-nova | 10:37 | |
*** psachin has quit IRC | 10:38 | |
*** ChipOManiac has quit IRC | 10:39 | |
sean-k-mooney | aspiers: yep that does look like its working well | 10:42 |
sean-k-mooney | aspiers: you said you finally booted an sev instance with openstack yesterday right or is that the goal for today | 10:42 |
sean-k-mooney | aspiers: cdent actully should th max unit on that inventory not be 1 | 10:43 |
sean-k-mooney | you can only have one mem_encryption_context per vm right | 10:44 |
*** Luzi has quit IRC | 10:44 | |
*** udesale has quit IRC | 10:44 | |
*** udesale has joined #openstack-nova | 10:45 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: only disable mac ageing for ovs hybrid plug https://review.opendev.org/672834 | 10:45 |
sean-k-mooney | this a relitivly minor nit | 10:45 |
*** mdbooth has quit IRC | 10:52 | |
*** mdbooth has joined #openstack-nova | 10:52 | |
*** sapd1_x has joined #openstack-nova | 10:54 | |
aspiers | sean-k-mooney: booting is the goal for today | 10:55 |
*** mkrai has quit IRC | 10:55 | |
aspiers | sean-k-mooney: I don't get why you think max_unit should be 1? there are 16 slots configured on that machine | 10:56 |
sean-k-mooney | yes but max_unit is the maxium amount you can request in a singe request | 10:56 |
aspiers | ohhh, are you saying max_unit represents the maximum per VM, not the maximum per host? | 10:56 |
sean-k-mooney | yes | 10:57 |
aspiers | ok I didn't know that | 10:57 |
aspiers | in that case yeah it should be 1 | 10:57 |
aspiers | good catch | 10:57 |
sean-k-mooney | total is the total capasity | 10:57 |
aspiers | right that never quite made sense before | 10:57 |
aspiers | easy to fix | 10:57 |
sean-k-mooney | ya as i said minor nit | 10:57 |
aspiers | minor but v important! | 10:57 |
sean-k-mooney | we will only ever ask for 1 anyway | 10:57 |
aspiers | true | 10:57 |
aspiers | well | 10:57 |
aspiers | yeah | 10:58 |
aspiers | unless some operator requested the resource directly via the flavor | 10:58 |
sean-k-mooney | still it does not hurt to be defensive | 10:58 |
sean-k-mooney | ya | 10:58 |
*** ksdean has quit IRC | 10:59 | |
aspiers | sean-k-mooney: is min_unit=1 correct though? | 10:59 |
sean-k-mooney | can you ask for less then 1 allocation of something if you want a resouce | 11:00 |
sean-k-mooney | yes it is | 11:00 |
*** dpawlik has quit IRC | 11:00 | |
sean-k-mooney | the min unit only applie if you ask for a resouce of that type | 11:00 |
sean-k-mooney | and since we dont want people saying resouce:MEM_ENCRYPTION_CONTEXT=0 it is correct | 11:01 |
aspiers | got it | 11:01 |
aspiers | thanks | 11:01 |
*** brtknr has quit IRC | 11:02 | |
sean-k-mooney | resouce:MEM_ENCRYPTION_CONTEXT=0 would actully for the vm to land on a host that supported sev but not consume sev resouces so it could be used incorrectly by opertors to stave those nodes or ram cpus and disk | 11:02 |
*** psachin has joined #openstack-nova | 11:02 | |
*** brtknr has joined #openstack-nova | 11:02 | |
*** brtknr has quit IRC | 11:02 | |
*** brtknr has joined #openstack-nova | 11:03 | |
sean-k-mooney | /for/force | 11:03 |
aspiers | good point | 11:03 |
*** brtknr has quit IRC | 11:06 | |
*** dpawlik has joined #openstack-nova | 11:06 | |
*** ttsiouts has joined #openstack-nova | 11:06 | |
*** tssurya has joined #openstack-nova | 11:08 | |
*** brtknr has joined #openstack-nova | 11:10 | |
*** jaosorior has quit IRC | 11:15 | |
*** mvkr has joined #openstack-nova | 11:16 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549 | 11:28 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 11:28 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956 | 11:28 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957 | 11:28 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958 | 11:28 |
*** sapd1_x has quit IRC | 11:30 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.75: Add 'power-update' external event https://review.opendev.org/645611 | 11:31 |
*** tbachman has quit IRC | 11:32 | |
efried | mnaser: re openstacksdk: | 11:39 |
efried | spec: http://specs.openstack.org/openstack/nova-specs/specs/train/approved/openstacksdk-in-nova.html | 11:39 |
efried | code: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/openstacksdk-in-nova | 11:39 |
efried | mnaser: note that we're not using clouds.yaml. We're using newly introduced functionality to consume ksa.loading oslo.config opts to build the Connection obj. | 11:40 |
efried | aspiers, sean-k-mooney: You can't ask placement for an allocation of 0. | 11:42 |
sean-k-mooney | efried: because we explcitly check or because we set min_unit to 1 | 11:43 |
efried | If you want to land on a SEV host but not consume SEV resources (why??) you would have to require the SEV trait. Which of course wouldn't be generic for SEV/MKTME like the rc is. | 11:43 |
sean-k-mooney | efried: we dont | 11:43 |
efried | sean-k-mooney: I'm actually not sure. Because I'm pretty sure you can't set min_unit to 0 either. | 11:43 |
sean-k-mooney | efried: aspiers was just asking if min_unit=1 was correct | 11:43 |
sean-k-mooney | and i was saying yes it is | 11:44 |
efried | yeah, it certainly is. | 11:44 |
efried | and per the design, max_unit=1 is also correct. | 11:44 |
efried | as you said | 11:44 |
efried | alex_xu: yt? | 11:48 |
efried | sean-k-mooney, aspiers: Who among cores do y'all think would be appropriate reviewers for https://review.opendev.org/670189 (harden get_domain_capabilities)? | 11:50 |
sean-k-mooney | good question. am most of the redhat folk are familar with libvirt, matt knows all but is also always over subsribed, maybe alex_xu on the intel side | 11:52 |
sean-k-mooney | to be honest we added a tone of comments so most core should be able to review at this point | 11:53 |
*** irclogbot_0 has quit IRC | 11:53 | |
sean-k-mooney | short list would proably be dansmith bauzas alex_xu or mriedem | 11:54 |
*** irclogbot_2 has joined #openstack-nova | 11:55 | |
sean-k-mooney | stephenfin is on pto today and maybe monday hence why he is not on the list | 12:00 |
*** artom has joined #openstack-nova | 12:04 | |
sean-k-mooney | johnthetubaguy: by the way regarding https://review.opendev.org/#/c/669190/ | 12:04 |
sean-k-mooney | one i assume you still want to merge ^ but second i assume you are not against either reverting the feature entrily or making it work properly | 12:05 |
*** ksdean has joined #openstack-nova | 12:12 | |
*** derekh has quit IRC | 12:24 | |
openstackgerrit | Merged openstack/os-vif master: Blacklist sphinx 2.1.0 (autodoc bug) https://review.opendev.org/672856 | 12:24 |
*** mrch_ has quit IRC | 12:30 | |
*** awalende has quit IRC | 12:31 | |
*** waverider has joined #openstack-nova | 12:34 | |
*** derekh has joined #openstack-nova | 12:36 | |
*** dpawlik has quit IRC | 12:37 | |
*** ratailor has quit IRC | 12:41 | |
*** ratailor has joined #openstack-nova | 12:41 | |
*** dpawlik has joined #openstack-nova | 12:43 | |
*** Luzi has joined #openstack-nova | 12:47 | |
*** mriedem has joined #openstack-nova | 12:53 | |
*** ttsiouts has quit IRC | 12:56 | |
aspiers | efried: re. core reviewers, I can't add anything to sean-k-mooney's answer | 12:57 |
aspiers | I just found an issue with some of the SEV tests | 12:57 |
aspiers | turns out you can't use decorators on classes after all :-( or at least in some circumstances. digging more now | 12:58 |
*** xek__ has quit IRC | 13:01 | |
*** brtknr has quit IRC | 13:01 | |
*** xek__ has joined #openstack-nova | 13:02 | |
*** brtknr has joined #openstack-nova | 13:03 | |
*** brtknr has quit IRC | 13:05 | |
*** brtknr has joined #openstack-nova | 13:05 | |
*** brtknr has quit IRC | 13:05 | |
*** ratailor has quit IRC | 13:06 | |
*** brtknr has joined #openstack-nova | 13:06 | |
mriedem | if anyone has a stein env handy could you see if you can recreate this? https://bugs.launchpad.net/nova/+bug/1837995 | 13:06 |
openstack | Launchpad bug 1837995 in OpenStack Compute (nova) ""Unexpected API Error" when use "openstack usage show" command" [Undecided,New] | 13:06 |
*** brtknr has quit IRC | 13:06 | |
mriedem | i don't see why it would happen but if it is it should be fairly obvious | 13:06 |
*** brtknr has joined #openstack-nova | 13:06 | |
*** artom has quit IRC | 13:09 | |
*** artom has joined #openstack-nova | 13:09 | |
*** yaawang has quit IRC | 13:11 | |
*** yaawang has joined #openstack-nova | 13:12 | |
*** ttsiouts has joined #openstack-nova | 13:14 | |
*** b3nt_pin is now known as beagles | 13:15 | |
*** jawad_axd has joined #openstack-nova | 13:24 | |
*** mchlumsky has joined #openstack-nova | 13:26 | |
*** artom has quit IRC | 13:26 | |
*** smcginnis has joined #openstack-nova | 13:29 | |
*** brinzhang has joined #openstack-nova | 13:36 | |
*** jawad_axd has quit IRC | 13:37 | |
*** waverider has quit IRC | 13:39 | |
*** huaqiang has joined #openstack-nova | 13:39 | |
*** xek__ has quit IRC | 13:46 | |
*** xek__ has joined #openstack-nova | 13:47 | |
sean-k-mooney | mriedem: i can unstack and restack an env but i dont have one to hand | 13:53 |
*** liuyulong has joined #openstack-nova | 13:55 | |
*** shilpasd has quit IRC | 13:56 | |
*** FlorianFa has quit IRC | 13:58 | |
*** mlavalle has joined #openstack-nova | 13:58 | |
*** mrjk__ has joined #openstack-nova | 13:59 | |
*** mrjk_ has quit IRC | 13:59 | |
*** mchlumsky_ has joined #openstack-nova | 13:59 | |
*** mchlumsky has quit IRC | 14:00 | |
*** eharney has joined #openstack-nova | 14:02 | |
aspiers | stupid question #734: what's a "remote security group" as returned by "openstack security group rule list" ? | 14:09 |
openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Where have all the global_request_id gone? https://review.opendev.org/672986 | 14:10 |
aspiers | and what's the effect of rules where the IP protocol / range are both None? | 14:10 |
aspiers | I would assume it just allows everything, but I'm not seeing that behaviour | 14:11 |
efried | aspiers: This sounds like a question for #openstack-keystone | 14:13 |
aspiers | oh really? I thought secgroups were part of nova | 14:13 |
aspiers | I guess my knowledge in this area is 5 years out of date or something | 14:13 |
mriedem | you're both wrong | 14:15 |
mriedem | neutron | 14:15 |
aspiers | haha | 14:15 |
aspiers | that would have been my second guess | 14:15 |
aspiers | actually I don't know why it wasn't my first | 14:16 |
aspiers | since I know full well that neutron manages the network namespaces and the rules within them | 14:16 |
* aspiers tries to engage brain more | 14:16 | |
*** dpawlik has quit IRC | 14:16 | |
*** jmlowe has quit IRC | 14:17 | |
slaweq | aspiers: if both IP protocol and range are None than it's not inserted into iptables rule to match, so all will be matched | 14:18 |
aspiers | slaweq: isn't the default is to reject? | 14:18 |
aspiers | if there's no corresponding iptables rule, I don't see what could match | 14:19 |
slaweq | aspiers: with rules You are defining what should be accepted | 14:19 |
aspiers | exactly that's what I mean | 14:19 |
slaweq | everything else, what will not match rules will be rejected | 14:19 |
aspiers | right but before you said "all will be matched" | 14:19 |
slaweq | so e.g. if You have rule with only "--direction ingress" than everything with ingress direction will be accepted | 14:19 |
slaweq | as such rule will be inserted into iptables (or openflow rules, depends on fw driver) | 14:20 |
aspiers | are you still talking about when you have a rule with proto/range None? | 14:20 |
slaweq | if You will do e.g. rule "--direction ingress --protocol tcp" than such rule will be in iptables and will be accepted | 14:20 |
aspiers | yes I know that, but I'm asking about proto/range None | 14:20 |
aspiers | because above you said if it's proto/range None then it's not inserted into iptables, in which case I don't see how any iptables rule can match | 14:21 |
aspiers | therefore it should use the default which is REJECT | 14:21 |
aspiers | (or maybe DROP I dunno) | 14:21 |
*** JamesBenson has joined #openstack-nova | 14:21 | |
slaweq | aspiers: yes, if You not specify protocol, it's None | 14:21 |
aspiers | I don't even know why devstack created rules with proto/range None | 14:21 |
*** cdent has quit IRC | 14:21 | |
aspiers | that makes no sense to me | 14:21 |
aspiers | unless None means "match ANY proto/range" | 14:21 |
aspiers | but that doesn't align with what you said above | 14:22 |
aspiers | because it can't match if there is no iptables rule for it | 14:22 |
*** mkrai has joined #openstack-nova | 14:22 | |
*** psachin has quit IRC | 14:22 | |
slaweq | technically it's not None but null :) | 14:22 |
openstackgerrit | Merged openstack/os-traits master: CPU: add a trait for AVX512-VNNI support https://review.opendev.org/672888 | 14:22 |
aspiers | openstack CLI says "None" | 14:22 |
aspiers | but I guess you mean null in the db | 14:23 |
aspiers | None in Python | 14:23 |
aspiers | maybe a SQLAlchemy translation? | 14:23 |
slaweq | aspiers: ok, so lets say I'm creating rule like http://paste.openstack.org/show/754898/ | 14:23 |
slaweq | this will be visible in iptables like: | 14:24 |
aspiers | ohhhh I see the confusion now | 14:24 |
aspiers | <slaweq> aspiers: if both IP protocol and range are None than it's not inserted into iptables rule to match, so all will be matched | 14:24 |
aspiers | I thought you were saying that _no_rule_ would be inserted into iptables | 14:25 |
aspiers | but you meant just the protocol/range elements of the rule | 14:25 |
aspiers | so there will be a rule, but it won't care what protocol/range, so it will match anything | 14:25 |
*** JamesBenson has quit IRC | 14:25 | |
slaweq | this will be visible in iptables like: -A neutron-openvswi-i425cf5a4-1 -j RETURN | 14:26 |
*** bnemec is now known as beekneemech | 14:26 | |
*** artom has joined #openstack-nova | 14:26 | |
*** mkrai has quit IRC | 14:27 | |
aspiers | right | 14:27 |
aspiers | so it will accept | 14:27 |
slaweq | aspiers: but if You will e.g. specify "--protocol tcp" in this rule in neutron, rule in iptables will be like: | 14:27 |
slaweq | -A neutron-openvswi-i425cf5a4-1 -p tcp -j RETURN | 14:27 |
slaweq | so it will accept "only" tcp traffic | 14:28 |
*** JamesBenson has joined #openstack-nova | 14:28 | |
slaweq | if You will add some port or port range in neutron, it will be added to match conditions in iptables | 14:28 |
slaweq | is it more clear now? | 14:28 |
aspiers | yeah I get what you were saying now. that all makes sense in theory, but it doesn't match the behaviour I'm seeing | 14:28 |
*** xek__ has quit IRC | 14:28 | |
*** JamesBenson has quit IRC | 14:29 | |
*** xek__ has joined #openstack-nova | 14:29 | |
*** JamesBenson has joined #openstack-nova | 14:29 | |
*** jmlowe has joined #openstack-nova | 14:29 | |
aspiers | slaweq: look at this sec group: http://paste.openstack.org/show/754899/ | 14:29 |
aspiers | I can't ping my cirros VM in that group until I add another rule for icmp | 14:30 |
*** cdent has joined #openstack-nova | 14:30 | |
slaweq | from "outside"? | 14:30 |
slaweq | it's normal | 14:30 |
aspiers | from the qrouter netns | 14:30 |
aspiers | the private address | 14:30 |
slaweq | You have only rules to allow all egress traffic from instance | 14:30 |
aspiers | huh? | 14:31 |
aspiers | there are two ingress rules | 14:31 |
slaweq | and 2 rules which accepts traffic from other instances which are using same security group | 14:31 |
*** smrcascao has joined #openstack-nova | 14:31 | |
slaweq | router port is not using same SG so from router it will not be allowed | 14:31 |
aspiers | ohhhh OK | 14:31 |
slaweq | if You will have second vm which will use same SG than it will work for You | 14:31 |
aspiers | so effectively you are explaining what "remote security group" means? | 14:32 |
sean-k-mooney | aspiers: i generally have better look in the dhcp namespaces | 14:32 |
slaweq | yes :) | 14:32 |
aspiers | slaweq: is that documented anywhere? | 14:32 |
sean-k-mooney | aspiers: why would the router ever be in the the same securtiy group | 14:32 |
sean-k-mooney | the security group is typically on the port | 14:32 |
sean-k-mooney | not the network unlike qos | 14:33 |
slaweq | aspiers: tbh I'm not sure, let me look | 14:33 |
aspiers | also interesting to note that security groups are documented in nova not neutron https://docs.openstack.org/nova/latest/admin/security-groups.html | 14:34 |
aspiers | well, in both | 14:34 |
sean-k-mooney | aspiers: thats because fo nova networks | 14:34 |
sean-k-mooney | which we have now deleted? | 14:34 |
aspiers | sean-k-mooney: yeah I remember the history from 2012 :) | 14:34 |
sean-k-mooney | aspiers: well stpehn is activly deleteing the remainder of the code this cycle | 14:35 |
aspiers | finally \o/ | 14:35 |
sean-k-mooney | i think he has done cellsv1 | 14:35 |
sean-k-mooney | and some of the xen only console stuff | 14:36 |
sean-k-mooney | nova networks is next on his list | 14:36 |
*** ricolin has joined #openstack-nova | 14:36 | |
sean-k-mooney | after he finishes the cpu pinning via placement stuff | 14:36 |
slaweq | aspiers: from what I'm now looking into Neutron documentation, I think this remote_group_id isn't really explained there | 14:39 |
slaweq | :( | 14:39 |
aspiers | slaweq: thanks for checking! | 14:39 |
aspiers | that sounds like a doc bug | 14:40 |
slaweq | aspiers: yes, indeed | 14:40 |
slaweq | aspiers: but I hope it's clear for You now :) | 14:40 |
aspiers | I think so | 14:40 |
aspiers | is it also possible to have an egress rule with remote secgroup set? | 14:40 |
aspiers | so that the rule only matches outgoing traffic to another (or maybe the same) secgroup? | 14:41 |
slaweq | aspiers: yes | 14:41 |
aspiers | cool | 14:41 |
slaweq | technically it creates ipset with IP addresses which belongs to other ports with same SG | 14:41 |
slaweq | and use this ipset in match conditions for rule | 14:41 |
aspiers | makes sense | 14:42 |
slaweq | but if You want to do so, please remember to remove default rule which allows all egress traffic | 14:42 |
slaweq | otherwise it will match first and still all will work fine | 14:42 |
slaweq | s/work fine/be allowed | 14:42 |
slaweq | :) | 14:42 |
aspiers | got it | 14:42 |
aspiers | OK think I understand much better now, thanks a lot! | 14:43 |
slaweq | aspiers: yw :) | 14:48 |
*** openstackgerrit has quit IRC | 14:51 | |
sean-k-mooney | aspiers: you can use cidr notation with egreess rules | 14:56 |
sean-k-mooney | you do not need to use remote sec groups at all | 14:56 |
*** jmlowe has quit IRC | 15:07 | |
*** huaqiang has quit IRC | 15:08 | |
melwitt | dansmith: hey, appreciate the review on the last context manager patch. I'm investigating into the our test setup code to be able to reply about some things. thanks again for looking | 15:09 |
dansmith | melwitt: okay, you haven't rebased the archive patch yet right? | 15:10 |
melwitt | dansmith: not yet no, wanted to get a run with the post test hook change before shuffling things around | 15:10 |
melwitt | which I got last evening, just need to rebase from the last context manager patch now | 15:11 |
melwitt | *away from | 15:11 |
melwitt | should do that right now actually, I got distracted | 15:12 |
*** openstackgerrit has joined #openstack-nova | 15:13 | |
openstackgerrit | melanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.opendev.org/507486 | 15:13 |
openstackgerrit | melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 15:13 |
melwitt | still have mriedem's +2 on the top patch, yusss | 15:14 |
sean-k-mooney | mriedem: could you take a second look at https://review.opendev.org/#/c/669738/2 i added the functional tests and its pretttry trivial otherwise so it would be nice to land that | 15:14 |
*** ttsiouts has quit IRC | 15:27 | |
efried | mriedem: Got $NOVA_CPU_CONF working | 15:27 |
efried | https://review.opendev.org/#/c/672805/ | 15:27 |
efried | https://review.opendev.org/#/c/672800/ | 15:27 |
*** ttsiouts has joined #openstack-nova | 15:28 | |
*** jmlowe has joined #openstack-nova | 15:29 | |
sean-k-mooney | efried: are you finally fixing the fact that we override the /etc/nova/nova-cpu.conf | 15:30 |
efried | yes, see above. | 15:30 |
sean-k-mooney | cool i have been setting things for both nova.conf and nova-cpu.conf in my local.conf for years at this point to work around it | 15:31 |
*** ttsiouts has quit IRC | 15:32 | |
*** ttsiouts has joined #openstack-nova | 15:33 | |
*** Luzi has quit IRC | 15:42 | |
*** xek__ has quit IRC | 15:51 | |
*** xek__ has joined #openstack-nova | 15:51 | |
*** brinzhang has quit IRC | 15:55 | |
*** eharney has quit IRC | 15:57 | |
*** rpittau is now known as rpittau|afk | 15:57 | |
*** gyee has joined #openstack-nova | 15:59 | |
*** cdent has quit IRC | 16:01 | |
*** cdent has joined #openstack-nova | 16:06 | |
*** icarusfactor has joined #openstack-nova | 16:06 | |
*** factor has quit IRC | 16:08 | |
*** cdent has quit IRC | 16:12 | |
*** ksdean has quit IRC | 16:14 | |
*** ttsiouts has quit IRC | 16:17 | |
*** ttsiouts has joined #openstack-nova | 16:17 | |
*** ttsiouts has quit IRC | 16:22 | |
*** tssurya has quit IRC | 16:23 | |
*** ricolin has quit IRC | 16:23 | |
*** vishwanathj has joined #openstack-nova | 16:24 | |
mriedem | sean-k-mooney: i've been busy with some stuff most of the morning and i'm going to lunch soon but i have that in a tab for later | 16:32 |
mriedem | efried: same for you | 16:33 |
*** icarusfactor has quit IRC | 16:33 | |
*** icarusfactor has joined #openstack-nova | 16:33 | |
mriedem | melwitt: i would have expected https://review.opendev.org/#/c/507486/65 to be smaller after you rebased it away from https://review.opendev.org/#/c/672604/1 ? | 16:34 |
*** mriedem is now known as mriedem_lunch | 16:35 | |
melwitt | mriedem: oh, so I wasn't sure whether I should toss out the func test or if it still has any value | 16:35 |
mriedem_lunch | well, i thought the func test didn't work w/o the other change so that's why i was confused | 16:36 |
*** icarusfactor has quit IRC | 16:36 | |
melwitt | it does a false positive for _archive_rows_for_table (whatever it's named) is not targeted. but it might have other value so I wasn't sure whether to kill it | 16:36 |
melwitt | mriedem_lunch: it works, it just returned a false positive when there was a bug in targeting for one of the archive db api methods | 16:37 |
dansmith | a proper test should have multiple cell dbs, | 16:38 |
dansmith | and archive things out of all of them, right? | 16:38 |
melwitt | if you think it's not useful given the nova-next testing, I'm fine with throwing it away. just wasn't sure what you'd want | 16:38 |
dansmith | so I would expect if it's pedantic enough it would catch the non-targeting behavior | 16:38 |
melwitt | dansmith: right, that's what the func test does | 16:39 |
melwitt | archives things out of cell0, cell1, and cell2 | 16:39 |
melwitt | but since the fixture auto-targets the last targeted context, it gives a false positive when one of the db api archive methods was *not* properly targeting | 16:39 |
dansmith | yeah that's what I don't get | 16:40 |
melwitt | so I went in and removed what I thought was just cruft from the fixture to make it able to catch that, not realizing that would be problematic in any way | 16:40 |
dansmith | won't this catch if we fail to target? https://review.opendev.org/#/c/507486/65/nova/tests/functional/test_nova_manage.py@1541 | 16:43 |
dansmith | because we wouldn't have archived in each cell? | 16:43 |
melwitt | well, last context manager is extremely confusing so I don't fully understand it either. but I tested it and sure enough, removing it makes the test properly fail when the bug is in the patchset | 16:44 |
*** vishwanathj has quit IRC | 16:44 | |
melwitt | dansmith: it will. and it passes with last context manager + buggy patchset and fails without last context manager + buggy patchset | 16:45 |
melwitt | I have to dig in more to figure out how/when last context manager manages to target each of cell0, cell1, and cell2 databases in a way that makes it archive properly when it shouldn't | 16:45 |
melwitt | when the bug is present | 16:46 |
dansmith | hmm, sounds fishy to me.. would definitely like to fully understand it either way, because I'd worry that means there's maybe still some behavior we don't expect | 16:46 |
dansmith | er, understand | 16:46 |
*** vishwanathj has joined #openstack-nova | 16:46 | |
melwitt | ok. I shall try to figure out exactly what happens re: last context manager. my brain might not be good enough though | 16:47 |
*** KeithMnemonic has joined #openstack-nova | 16:50 | |
melwitt | dansmith: I'm in luck, looks like it's a simple reason. the nova-manage command itself targets each cell as it archives and the bug in a previous patchset was that a helper method in db api was not properly targeting any database via a RequestContext https://review.opendev.org/#/c/507486/65/nova/cmd/manage.py@573 | 16:57 |
melwitt | so each target_cell in manage.py will save last context manager, and then the db api method that is buggily untargeted will pick up that last context manager | 16:58 |
*** derekh has quit IRC | 16:58 | |
melwitt | and then archive the records properly in func test land when it does not archive records properly in real life | 16:59 |
dansmith | nothing in db_api should be doing targeting | 17:00 |
*** vishwanathj has quit IRC | 17:00 | |
dansmith | so I'm not sure I understand | 17:00 |
dansmith | manage iterates the cells, targets, and calls db_api.archiveblah() right? | 17:00 |
melwitt | right, lemme show you the bug | 17:00 |
melwitt | that will make it make sense | 17:01 |
*** eharney has joined #openstack-nova | 17:01 | |
*** jangutter has quit IRC | 17:02 | |
melwitt | dansmith: here, the bug was that this get_engine() call was not being passed context=context in an earlier patchset https://review.opendev.org/#/c/507486/65/nova/db/sqlalchemy/api.py@5442 | 17:02 |
melwitt | so it had no access to any db connection info that came from cell targeting | 17:03 |
dansmith | is this because this method isn't using the context manager like the rest of them? | 17:03 |
dansmith | i.e. @pick_context_manager and friends | 17:04 |
melwitt | looking, refreshing my memory | 17:05 |
dansmith | like i'm guessing maybe this method is super old and just didn't get context managerified or something | 17:06 |
dansmith | because it's only part of manage and not runtime code | 17:06 |
dansmith | which is a problem anyway | 17:06 |
dansmith | so if the assertion is that we couldn't catch this with the fixture because the underlying db code was totally not adhering to our db api conventions, then that makes sense | 17:06 |
dansmith | but it's not a super strong argument to me.. valid for sure, just not big concern I think | 17:07 |
*** vishwanathj has joined #openstack-nova | 17:07 | |
melwitt | yeah, I'm not sure. the pick_context_manager looks to just pick up the db_connection attr from the RequestContext and does ctxt_mgr.reader.using() whatever that does. it's not directly calling get_engine() | 17:08 |
dansmith | but those are the places that honor the targeting in the context, | 17:08 |
dansmith | which is what this helper is missing, and why this helper needed special plumbing into the engine to keep it targeted | 17:08 |
melwitt | I assume maybe the archive stuff needs to go more manual because it's moving things to shadow tables. but I don't really know, I'm not that familiar with it | 17:08 |
dansmith | it just needs a pointer to the engine is all | 17:09 |
dansmith | anyway, I get it.. still meh, but I understand | 17:11 |
melwitt | you are right that this is a pretty special case | 17:11 |
melwitt | (special to have a bug like that) | 17:11 |
dansmith | I need to go through the other uses of get_engine in more detail and figure out if we maybe need some other trap to make sure that we don't get an engine with no context, even in other situations where cell targeting isn't a thing | 17:12 |
dansmith | but I don't have time for that today | 17:12 |
melwitt | ok. it caused me a lot of confusion and time spent so I thought there might be value in removing the last context manager weirdness, but if you think it's better to have than not, I can accept that | 17:12 |
aspiers | efried: found some more issues with SEV series, please bear with me. /cc bbobrov | 17:26 |
efried | ack | 17:26 |
*** vishwanathj has quit IRC | 17:28 | |
*** udesale has quit IRC | 17:31 | |
*** igordc has joined #openstack-nova | 17:34 | |
*** igordc has quit IRC | 17:36 | |
*** igordc has joined #openstack-nova | 17:36 | |
*** brault has quit IRC | 17:46 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 17:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 17:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 17:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py https://review.opendev.org/636318 | 17:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | 17:48 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 17:48 |
*** rtjure has quit IRC | 17:50 | |
*** mriedem_lunch is now known as mriedem | 17:50 | |
*** mdbooth_ has joined #openstack-nova | 17:52 | |
*** tesseract has quit IRC | 17:54 | |
*** mdbooth has quit IRC | 17:55 | |
*** rtjure has joined #openstack-nova | 17:56 | |
*** chason has quit IRC | 17:56 | |
openstackgerrit | Merged openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196 | 18:02 |
*** oomichi_ has joined #openstack-nova | 18:13 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 18:16 |
artom | This NUMA LM func test is actually some of the most fun code I've written in a while | 18:22 |
artom | ... not sure that's a good thing :P | 18:22 |
mriedem | efried: should https://review.opendev.org/#/c/631242/ be rebased on your SDK series now? | 18:25 |
mriedem | ...or is that a bad idea b/c cyborg isn't in the sdk yet? | 18:25 |
efried | mriedem: I would like it if cyborg used sdk, but the cyborg blueprint shouldn't have to be dependent on the sdk one. | 18:26 |
efried | mriedem: If we could merge https://review.opendev.org/#/c/643664/ then yeah, I would say we should do that. | 18:26 |
efried | any cores around? dansmith? | 18:26 |
mriedem | he's out, or on the way | 18:27 |
efried | melwitt? | 18:27 |
mriedem | efried: in general I'm just wondering about what looks like stalled progress on https://review.opendev.org/#/q/topic:bp/nova-cyborg-interaction+(status:open+OR+status:merged) | 18:27 |
mriedem | we're <2 months from FF | 18:28 |
efried | mriedem: I think the progress is on the cyborg side for the mo https://review.opendev.org/#/c/659233/ | 18:28 |
mriedem | oh ok | 18:28 |
efried | mriedem: recall at ptg demo time, they were working against a PoC feature branch off of cyborg, not code merged (or even proposed) in master. So they're catching up on that now. | 18:29 |
efried | though I'll admit progress could be faster. | 18:29 |
mriedem | yar | 18:30 |
mriedem | now that we're past spec freeze for train, i'm sure you don't feel like it, but what are your thoughts on a state-of-the-state email about the status of our cycle themes? https://specs.openstack.org/openstack/nova-specs/priorities/train-priorities.html | 18:30 |
mriedem | i'm writing my monthly report which is why i'm in reporting mode :) | 18:31 |
efried | mriedem: that sounds like a friggin hoot | 18:31 |
efried | I should delegate that | 18:32 |
efried | to someone in reporting mode | 18:32 |
mriedem | man it looks like https://review.opendev.org/#/c/659233/8 should be split up | 18:32 |
efried | I agree, but it's such a garbled mess right now it would be tough to tell how. | 18:32 |
mriedem | right again | 18:34 |
dansmith | doesn't it have a recipe in the commit message? | 18:35 |
dansmith | I mean "dos2unix of a file" does not belong in a patch with anything else | 18:35 |
dansmith | I mean good lord | 18:35 |
mriedem | yeah i saw that too | 18:36 |
efried | I don't know what kind of recipes you use, that have two 4s. | 18:36 |
dansmith | file renames should be their own deal | 18:36 |
efried | must be why you're so skinny. | 18:37 |
dansmith | heh | 18:37 |
efried | Y'all should feel free to add your -1 for those reasons as well. I've done enough ranting on that patch for one day. | 18:38 |
mriedem | i just did | 18:38 |
dansmith | can I just -1 with "smh" ? | 18:38 |
mriedem | given i had to google that, i'm guessing someone from china won't get it either :) | 18:39 |
dansmith | heh, I feel like I'm 20 years older than my self, but you're like.. eighty | 18:39 |
efried | I'd rather keep the comments on the constructive side, even if brutal. | 18:39 |
efried | not much they can do with "smh" | 18:39 |
dansmith | efried: I wasn't serious of course | 18:39 |
efried | yeah | 18:39 |
efried | of course | 18:39 |
dansmith | but I did see you were like "woah, nuke this whole sumbitch" | 18:39 |
efried | well, the *probably* can't justify holding a copy of provider_tree, but they *definitely* can't justify holding a copy of os-resource-classes | 18:40 |
efried | that's just... no. | 18:40 |
dansmith | heh | 18:41 |
*** oomichi_ has quit IRC | 18:41 | |
dansmith | yeah, that's like... well, ... smh | 18:41 |
efried | but also, yeah, get rid of 90% of the ReportClient | 18:41 |
mriedem | dansmith: i'd like you to get off my lawn | 18:41 |
* mriedem shakes fist | 18:41 | |
dansmith | mriedem: you first | 18:41 |
mriedem | hip is broken, can't | 18:41 |
* efried calls Springer | 18:41 | |
dansmith | I don't have an all-terrain cane so I'm kinda stuck | 18:41 |
efried | Oh, is *that* what "ATC" stands for on the summit badge? | 18:42 |
dansmith | heh | 18:42 |
*** jmlowe has quit IRC | 18:43 | |
efried | btw, zun copied in the *whole* SchedulerReportClient. | 18:43 |
efried | Chris and I both had a leetle to say about that https://review.opendev.org/#/c/586960/ | 18:44 |
mriedem | this is the point where i joke about how everyone shits on nova but then copies a bunch of the code out of nova | 18:44 |
efried | and then it doesn't work for them, so they shit on nova | 18:44 |
mriedem | i'd pay to see someone copy something wholesale that is about cells | 18:44 |
mriedem | that'd be great | 18:44 |
mriedem | i left a comment on the zun patch, pointing to watcher's start https://review.opendev.org/#/c/661245/ | 18:47 |
mriedem | which is pretty simple | 18:47 |
mriedem | they clearly copied some stuff from SchedulerReportClient but not much | 18:47 |
mriedem | efried: where do you want blueprints that aren't going to be in train moved to, as in series goal? https://blueprints.launchpad.net/nova/train | 18:48 |
mriedem | like the rmd ones? | 18:48 |
mriedem | just...undefined? | 18:48 |
efried | that's our only option, nah? | 18:48 |
efried | or do we have the power to create a new one, like 'backlog'? | 18:48 |
mriedem | yeah, unless you create a u release, but we don't know the name of that yet | 18:48 |
mriedem | there is a trunk series but we don't really use it | 18:48 |
efried | maybe we should | 18:49 |
mriedem | you could create a backlog series.... | 18:49 |
mriedem | but the 300 or so nova blueprints are already in the backlog | 18:49 |
mriedem | er, make that | 18:49 |
mriedem | 1 → 75 of 1128 results | 18:49 |
efried | it would be nicer to start a backlog afresh | 18:49 |
mriedem | shrug | 18:49 |
efried | and for a diligent PTL to refresh it every cycle, moving dead stuff to undefined | 18:49 |
mriedem | is rmd in the backlog? | 18:49 |
efried | let me go look at it | 18:50 |
efried | it's probably just dead, obsolete, but let me look real quick | 18:50 |
efried | mriedem: if we mark Definition as Obsolete, they drop off this report? | 18:51 |
mriedem | i think obsolete is as close as we get to dead yeah | 18:52 |
efried | superseded | 18:52 |
efried | let me play | 18:52 |
mriedem | superseded is like duping a bug | 18:52 |
mriedem | not the same thing as obsolete | 18:52 |
mriedem | for example, at one point we had at least 5 or 6 blueprints for adding volume type to the server create bdm interface, | 18:52 |
mriedem | eventually i picked one and just marked all the rest as superseded by that one | 18:52 |
efried | meh, it shows up on the report either way. Superseded seems appropriate to me. | 18:53 |
efried | mdbooth_, mriedem: Local disk serial numbers appears to have a bunch of merged code but also a bunch of abandoned code. What should we do with that? | 18:57 |
efried | https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers | 18:57 |
mriedem | when you supersede a blueprint don't you have to mark it superseded by something else? | 18:57 |
mriedem | otherwise it's not really superseded | 18:57 |
efried | apparently not :) | 18:57 |
efried | I just commented in the whiteboard | 18:57 |
mriedem | :/ | 18:57 |
mriedem | https://blueprints.launchpad.net/nova/+spec/rmd-base-enablement is still marked for the train series goal | 18:58 |
mriedem | i'm not really the person to ask about local disk serial numberes | 18:59 |
mriedem | *numbers | 18:59 |
efried | yes, all three are | 18:59 |
mriedem | it's been deferred a couple of times | 18:59 |
efried | It's not wrong imo to keep it under train since that's where it was proposed and superseded. | 18:59 |
mriedem | efried: so you're going to leave the rmd ones as marked for train? i guess what i'm looking for is eventually https://blueprints.launchpad.net/nova/train will just show approved blueprint | 18:59 |
efried | what would be neat is if there was some way to search for release *plus* status | 19:00 |
efried | so we wouldn't have to misuse fields like that. | 19:00 |
efried | never been a fan of launchpad | 19:00 |
efried | or really any project management software | 19:00 |
efried | or project management | 19:00 |
efried | or project managers | 19:00 |
efried | why am I PTL again? | 19:00 |
mriedem | the perks | 19:00 |
mriedem | kickbacks | 19:00 |
mriedem | fame | 19:00 |
mriedem | nickels | 19:01 |
efried | I see. So clearly I just have to wait for those to kick in. | 19:01 |
* fungi kicks a crusty nickel at efried | 19:03 | |
efried | thanks fungi. Now I have enough to make a phone call in 1985. | 19:03 |
fungi | if only you could find a phone booth | 19:04 |
*** maciejjozefczyk has quit IRC | 19:08 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: DNM: Interactive Train Themes Midcycle Status https://review.opendev.org/673095 | 19:13 |
*** jmlowe has joined #openstack-nova | 19:19 | |
*** igordc has quit IRC | 19:37 | |
*** brtknr has quit IRC | 19:40 | |
*** brtknr has joined #openstack-nova | 19:40 | |
*** slaweq has quit IRC | 19:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: fix links for server actions in api guide https://review.opendev.org/673101 | 19:48 |
*** BjoernT has joined #openstack-nova | 19:51 | |
*** BjoernT has quit IRC | 19:55 | |
*** ralonsoh has quit IRC | 19:55 | |
*** jmlowe has quit IRC | 19:57 | |
*** jmlowe has joined #openstack-nova | 19:59 | |
efried | mriedem: http://lists.openstack.org/pipermail/openstack-discuss/2019-July/008064.html | 20:06 |
*** igordc has joined #openstack-nova | 20:10 | |
*** slaweq has joined #openstack-nova | 20:11 | |
*** slaweq has quit IRC | 20:16 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use a less chipper title for release notes https://review.opendev.org/671752 | 20:19 |
*** brtknr_ has joined #openstack-nova | 20:20 | |
*** brtknr has quit IRC | 20:22 | |
*** mchlumsky_ has quit IRC | 20:35 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration https://review.opendev.org/672595 | 20:42 |
*** priteau has quit IRC | 20:53 | |
*** hemna has quit IRC | 20:57 | |
*** artom has quit IRC | 21:06 | |
*** KeithMnemonic has quit IRC | 21:18 | |
*** beekneemech is now known as bnemec-pto | 21:22 | |
*** eharney has quit IRC | 21:23 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Inline trace_request_filter https://review.opendev.org/666663 | 21:24 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Always cleanup when hitting MaxRetriesExceeded https://review.opendev.org/672855 | 21:43 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Always cleanup when hitting MaxRetriesExceeded https://review.opendev.org/672855 | 21:44 |
*** jaypipes has quit IRC | 21:44 | |
openstackgerrit | Merged openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282 | 21:50 |
openstackgerrit | Merged openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431 | 21:50 |
*** brtknr_ has quit IRC | 22:01 | |
*** JamesBenson has quit IRC | 22:03 | |
*** whoami-rajat has quit IRC | 22:06 | |
*** slaweq has joined #openstack-nova | 22:11 | |
*** xek__ has quit IRC | 22:12 | |
*** slaweq has quit IRC | 22:16 | |
*** gyee has quit IRC | 22:39 | |
*** gyee has joined #openstack-nova | 22:55 | |
*** mriedem has quit IRC | 23:08 | |
*** slaweq has joined #openstack-nova | 23:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 23:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 23:12 |
*** huaqiang has joined #openstack-nova | 23:15 | |
*** slaweq has quit IRC | 23:15 | |
*** huaqiang has left #openstack-nova | 23:18 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 23:41 |
*** huaqiang has joined #openstack-nova | 23:45 | |
*** huaqiang has quit IRC | 23:46 | |
*** huaqiang has joined #openstack-nova | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!