| *** ociuhandu has joined #openstack-nova | 00:03 | |
| *** Bidwe_jay has quit IRC | 00:03 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** IvensZambrano has quit IRC | 00:13 | |
| *** brinzhang has joined #openstack-nova | 00:14 | |
| *** slaweq has quit IRC | 00:16 | |
| *** ociuhandu has quit IRC | 00:17 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669 | 00:26 |
|---|---|---|
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 00:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | 00:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | 00:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | 00:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 00:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | 00:27 |
| *** gyee has quit IRC | 00:46 | |
| *** betherly has joined #openstack-nova | 00:55 | |
| *** betherly has quit IRC | 01:00 | |
| *** ociuhandu has joined #openstack-nova | 01:15 | |
| *** betherly has joined #openstack-nova | 01:15 | |
| *** imacdonn has quit IRC | 01:16 | |
| *** imacdonn has joined #openstack-nova | 01:17 | |
| *** betherly has quit IRC | 01:20 | |
| *** mlavalle has quit IRC | 01:24 | |
| *** tbachman has quit IRC | 01:27 | |
| *** ociuhandu has quit IRC | 01:28 | |
| *** _hemna has quit IRC | 01:30 | |
| *** whoami-rajat has joined #openstack-nova | 01:31 | |
| *** ileixe has quit IRC | 01:37 | |
| *** _hemna has joined #openstack-nova | 01:49 | |
| *** brinzhang55 has joined #openstack-nova | 01:53 | |
| *** _hemna has quit IRC | 01:54 | |
| *** betherly has joined #openstack-nova | 01:57 | |
| *** tetsuro has joined #openstack-nova | 01:57 | |
| *** betherly has quit IRC | 02:02 | |
| *** spatel has joined #openstack-nova | 02:09 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** spatel has quit IRC | 02:14 | |
| *** slaweq has quit IRC | 02:15 | |
| *** ociuhandu has joined #openstack-nova | 02:26 | |
| *** _hemna has joined #openstack-nova | 02:26 | |
| *** ociuhandu has quit IRC | 02:38 | |
| *** threestrands has joined #openstack-nova | 02:43 | |
| *** _hemna has quit IRC | 02:46 | |
| *** brinzhang55 has quit IRC | 02:50 | |
| *** hongda has joined #openstack-nova | 02:50 | |
| *** tetsuro has quit IRC | 03:00 | |
| *** JamesBenson has joined #openstack-nova | 03:02 | |
| *** betherly has joined #openstack-nova | 03:09 | |
| *** betherly has quit IRC | 03:14 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: [WIP] Populate the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 03:23 |
| openstackgerrit | Alex Xu proposed openstack/nova master: [WIP] Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 03:23 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 03:23 |
| *** redrobot has quit IRC | 03:32 | |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** ociuhandu has joined #openstack-nova | 03:36 | |
| *** Guest99405 has joined #openstack-nova | 03:39 | |
| *** JamesBenson has quit IRC | 03:40 | |
| *** betherly has joined #openstack-nova | 03:40 | |
| *** betherly has quit IRC | 03:45 | |
| *** ociuhandu has quit IRC | 03:50 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** brinzhang has quit IRC | 04:30 | |
| *** brinzhang has joined #openstack-nova | 04:30 | |
| *** tetsuro has joined #openstack-nova | 04:37 | |
| *** udesale has joined #openstack-nova | 04:39 | |
| *** tetsuro has quit IRC | 04:42 | |
| *** ociuhandu has joined #openstack-nova | 04:48 | |
| *** tetsuro has joined #openstack-nova | 04:55 | |
| *** Bidwe_jay has joined #openstack-nova | 04:56 | |
| *** ociuhandu has quit IRC | 05:00 | |
| *** ganso has quit IRC | 05:05 | |
| *** Luzi has joined #openstack-nova | 05:09 | |
| *** Bidwe_jay has quit IRC | 05:10 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** tetsuro has quit IRC | 05:12 | |
| *** ratailor has joined #openstack-nova | 05:13 | |
| *** slaweq has quit IRC | 05:15 | |
| *** gokhani has quit IRC | 05:18 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 05:20 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 05:20 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 05:20 |
| alex_xu | bauzas: ^ need your review on those patches, I move the mdev into the new claim_for_instance interface | 05:22 |
| *** gokhani has joined #openstack-nova | 05:22 | |
| *** maciejjozefczyk has joined #openstack-nova | 05:24 | |
| *** ccamacho has quit IRC | 05:33 | |
| *** pcaruana has joined #openstack-nova | 05:44 | |
| *** ociuhandu has joined #openstack-nova | 05:57 | |
| *** damien_r has joined #openstack-nova | 05:57 | |
| *** logan- has quit IRC | 06:00 | |
| *** logan_ has joined #openstack-nova | 06:01 | |
| *** logan_ is now known as logan- | 06:01 | |
| *** ociuhandu has quit IRC | 06:02 | |
| *** dpawlik has joined #openstack-nova | 06:04 | |
| *** igordc has quit IRC | 06:14 | |
| *** slaweq has joined #openstack-nova | 06:28 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 06:30 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 06:30 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 06:30 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 06:30 |
| *** gokhani has quit IRC | 06:31 | |
| *** tetsuro has joined #openstack-nova | 06:32 | |
| *** tetsuro has quit IRC | 06:36 | |
| *** sapd1 has quit IRC | 06:37 | |
| *** rcernin has quit IRC | 06:44 | |
| openstackgerrit | Yongli He proposed openstack/python-novaclient master: Microversion 2.75 - show server topology https://review.opendev.org/670790 | 06:46 |
| *** damien_r has quit IRC | 06:47 | |
| *** tbachman has joined #openstack-nova | 06:54 | |
| *** tbachman has quit IRC | 06:58 | |
| *** ociuhandu has joined #openstack-nova | 07:00 | |
| *** xek has joined #openstack-nova | 07:06 | |
| *** belmoreira has joined #openstack-nova | 07:07 | |
| *** ociuhandu has quit IRC | 07:08 | |
| *** rpittau|afk is now known as rpittau | 07:11 | |
| *** damien_r has joined #openstack-nova | 07:11 | |
| *** ttsiouts has joined #openstack-nova | 07:13 | |
| *** maciejjozefczyk has quit IRC | 07:17 | |
| *** tetsuro has joined #openstack-nova | 07:22 | |
| *** helenafm has joined #openstack-nova | 07:23 | |
| *** threestrands has quit IRC | 07:24 | |
| *** belmoreira has quit IRC | 07:31 | |
| *** ccamacho has joined #openstack-nova | 07:36 | |
| *** ttsiouts has quit IRC | 07:39 | |
| *** belmoreira has joined #openstack-nova | 07:39 | |
| *** ttsiouts has joined #openstack-nova | 07:39 | |
| *** tetsuro has quit IRC | 07:41 | |
| openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 07:43 |
| *** ttsiouts has quit IRC | 07:44 | |
| *** ttsiouts has joined #openstack-nova | 07:46 | |
| *** ralonsoh has joined #openstack-nova | 07:56 | |
| *** ttsiouts has quit IRC | 08:00 | |
| *** ttsiouts has joined #openstack-nova | 08:01 | |
| *** ttsiouts has quit IRC | 08:06 | |
| *** ociuhandu has joined #openstack-nova | 08:07 | |
| *** ttsiouts has joined #openstack-nova | 08:09 | |
| *** ociuhandu has quit IRC | 08:11 | |
| *** cdent has joined #openstack-nova | 08:20 | |
| *** derekh has joined #openstack-nova | 08:20 | |
| stephenfin | efried: Correct. We're doing that already and we've decided it's not an issue since operators should already have separate hosts for pinned and non-pinned instances | 08:22 |
| stephenfin | efried: and if they don't, they get pretty much what they had before, even if placement inventory will be kind of a lie | 08:23 |
| cdent | lying is bad, mmmkay? | 08:27 |
| *** belmoreira has quit IRC | 08:33 | |
| *** tetsuro has joined #openstack-nova | 08:34 | |
| *** belmoreira has joined #openstack-nova | 08:35 | |
| *** tetsuro has quit IRC | 08:39 | |
| *** tkajinam has quit IRC | 08:40 | |
| *** xek has quit IRC | 08:42 | |
| *** xek has joined #openstack-nova | 08:43 | |
| openstackgerrit | QingFeng Hao proposed openstack/nova master: Add get_host_memory_stats in zvm driver https://review.opendev.org/671430 | 08:44 |
| *** tetsuro has joined #openstack-nova | 08:46 | |
| *** xek has quit IRC | 08:47 | |
| gibi | sean-k-mooney: left comments in https://review.opendev.org/#/c/671338 overall direction looks good to me | 08:48 |
| *** tetsuro has quit IRC | 08:50 | |
| *** xek has joined #openstack-nova | 08:51 | |
| *** tetsuro has joined #openstack-nova | 08:51 | |
| *** xek has quit IRC | 08:52 | |
| sean-k-mooney | gibi: thanks, ya the unit test failures are valid i ran them locally with a regex of things i tought might break but i obviously missed some | 08:53 |
| *** tetsuro has quit IRC | 08:53 | |
| *** tetsuro has joined #openstack-nova | 08:54 | |
| *** Bidwe_jay has joined #openstack-nova | 08:56 | |
| *** tssurya has joined #openstack-nova | 09:00 | |
| *** arxcruz|ruck is now known as arxcruz | 09:01 | |
| *** asmita_s has joined #openstack-nova | 09:08 | |
| *** asmita_s has quit IRC | 09:08 | |
| *** davidsha has joined #openstack-nova | 09:15 | |
| *** Bidwe_jay has quit IRC | 09:16 | |
| *** tssurya has quit IRC | 09:17 | |
| *** tetsuro has quit IRC | 09:20 | |
| *** xek has joined #openstack-nova | 09:26 | |
| *** belmoreira has quit IRC | 09:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Keeping going with docs https://review.opendev.org/670332 | 09:26 |
| kashyap | Heya, a random question: what else tooling do people use besides `git-review` to make life pleasant with Gerrit? | 09:26 |
| kashyap | (I'm asking because, I'm providing a data point for those who are mailing lists, and are considering web-based workflows, GitLab/GitHub; not Gerrit at this point) | 09:27 |
| kashyap | I think `gertty` would be another for those who like the offline caching and terminal-based reviews | 09:27 |
| *** ttsiouts has quit IRC | 09:27 | |
| *** ttsiouts has joined #openstack-nova | 09:28 | |
| *** belmoreira has joined #openstack-nova | 09:29 | |
| sean-k-mooney | its mainly git review for me. with web for review. i strongly dislike mailing list based workflows to the point that unless that project also has patchwork i almost entirly avoid them | 09:29 |
| sean-k-mooney | at least when it comes to code reviews | 09:29 |
| sean-k-mooney | gertty if fine for reviewing | 09:30 |
| sean-k-mooney | but its offline asspect comes at the cost that it needs to build up an sql database of the open changes | 09:30 |
| sean-k-mooney | that can be slow with large repos like nova | 09:30 |
| gibi | efried: I added comments to https://review.opendev.org/#/c/612497 | 09:31 |
| kashyap | I maintain Gertty in Fedora, FWIW, because I enjoy the offline ability. And the DB build-up is a negligible cost | 09:31 |
| kashyap | sean-k-mooney: It's not SQL; but Berkely | 09:31 |
| sean-k-mooney | kashyap: no is sqlight3 | 09:32 |
| kashyap | Ah, right | 09:32 |
| kashyap | Sorry | 09:32 |
| *** ttsiouts has quit IRC | 09:33 | |
| * kashyap also appreciates the strenghts of mailing lists. Nothing beats their blazing fastness, if you are using proper tools (`mutt` or equivalent, plus OfflineIMAP, indexing like `notmuch`, etc). | 09:33 | |
| sean-k-mooney | there are allo tools like https://github.com/openstack-infra/git-restack or https://github.com/dhellmann/git-nit | 09:33 |
| kashyap | sean-k-mooney: Thanks; /me checks | 09:34 |
| sean-k-mooney | kashyap: personally i find mailing list much slower and harder to follow since you have to constuct all that tooling yourself | 09:34 |
| kashyap | Ah, didn't know of them | 09:34 |
| sean-k-mooney | git restack is old and not really uses much i think | 09:35 |
| sean-k-mooney | personally i found doing a interactive rebase manullay to the same base commit was just as quick | 09:36 |
| kashyap | sean-k-mooney: Nod. (But the kernel and other systems folks still maintain mailing lists are the "best way" to manage large projects as kernel: https://lwn.net/Articles/702177/) | 09:36 |
| kashyap | sean-k-mooney: Okay, thanks for the opinion and notes :-) | 09:37 |
| *** ttsiouts has joined #openstack-nova | 09:38 | |
| bauzas | alex_xu: ack, will look | 09:39 |
| alex_xu | bauzas: thanks | 09:40 |
| *** tssurya has joined #openstack-nova | 09:40 | |
| bauzas | alex_xu: wow, that's a massive refactoring, I'll do this this afternoon | 09:42 |
| bauzas | thanks for it | 09:42 |
| bauzas | alex_xu: FWIW, I'm also working on https://review.opendev.org/#/c/589085/ | 09:43 |
| alex_xu | bauzas: I guess it should works with your patch also, and you get the vgpu claim for dst host | 09:43 |
| bauzas | alex_xu: that's why I need to look at your series to exactly understand how it works | 09:44 |
| *** tetsuro has joined #openstack-nova | 09:44 | |
| bauzas | alex_xu: also, a nit, I wonder if we should have a specless bp for this | 09:46 |
| *** tetsuro has quit IRC | 09:46 | |
| alex_xu | bauzas: yea, probably we can ask efried about that | 09:46 |
| *** belmoreira has quit IRC | 09:51 | |
| *** ttsiouts has quit IRC | 10:15 | |
| *** tetsuro has joined #openstack-nova | 10:15 | |
| *** ttsiouts has joined #openstack-nova | 10:15 | |
| *** helenafm has quit IRC | 10:16 | |
| *** belmoreira has joined #openstack-nova | 10:19 | |
| *** ttsiouts has quit IRC | 10:20 | |
| *** bbowen has quit IRC | 10:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: bindep: Remove dead markers https://review.opendev.org/671452 | 10:28 |
| *** helenafm has joined #openstack-nova | 10:29 | |
| stephenfin | bauzas, alex_xu: Easiest +2 you'll ever have right here https://review.opendev.org/671452 | 10:30 |
| *** whoami-rajat has quit IRC | 10:30 | |
| bauzas | stephenfin: hands on deck | 10:30 |
| *** takamatsu has joined #openstack-nova | 10:37 | |
| *** tetsuro has quit IRC | 10:49 | |
| *** tetsuro has joined #openstack-nova | 10:50 | |
| *** tetsuro has quit IRC | 10:52 | |
| kashyap | bauzas: Isn't it simple enough to just go ahead and +W it? | 11:06 |
| kashyap | (It being the 'bindep' one) | 11:06 |
| bauzas | no | 11:06 |
| bauzas | fast-approval seems right, but honestly people could have concerns | 11:07 |
| *** maciejjozefczyk has joined #openstack-nova | 11:07 | |
| *** belmoreira has quit IRC | 11:07 | |
| kashyap | If there _can_ be concerns, okay, fair enough. | 11:08 |
| sean-k-mooney | kashyap: even if it was stephenfin wrote it so we shoul dnot have a redhat core +2+w without someone else looking at it | 11:08 |
| kashyap | Well, not that asinine reason again. There are sensible exceptions | 11:08 |
| sean-k-mooney | kashyap: yep this is not one of them | 11:09 |
| kashyap | On that point, see my extended point here: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006080.html | 11:09 |
| kashyap | sean-k-mooney: Okay. | 11:09 |
| *** ttsiouts has joined #openstack-nova | 11:09 | |
| kashyap | I don't care about this change particularly, BTW. Just the simplicity of it is what prompted me to say it. | 11:09 |
| cdent | kashyap++ and *hugs* | 11:18 |
| kashyap | :-) | 11:18 |
| kashyap | sean-k-mooney: For argument's sake, why is this not one of them? Precise is even EOL | 11:22 |
| kashyap | This is definitely one of those dead-simple changes that doesn't require an completely unhinged process to interfere | 11:22 |
| kashyap | Anyway, not my circus, not my clowns. | 11:22 |
| kashyap | s/"an completely"/"a completely"/ | 11:23 |
| sean-k-mooney | ignoring the same company aspect. one out of curtusy to other disto maintainer we shoudl not fast merge thing related to our competitor distro without any external reveiew, second we only use singel +2 in very limited cases like when you would have been the second +2 but you fix a minor nit in someone esle pathc or rebased a patch that went int merge confcit and you are proxing a previous +2 from a | 11:27 |
| sean-k-mooney | core, third its not urgent, i.e. there is no bug associated wthi this stepen jsut noticed it and its not blocking the gate. put that to gether with the same company core thing and even though its trivial and it looks correct i dont think this has a stong case for bypassing our standard policy | 11:27 |
| *** belmoreira has joined #openstack-nova | 11:28 | |
| * gibi resolved the controversy by +Aing the patch | 11:29 | |
| kashyap | Sure, it is not about "urgency", but needless, grinding processes coming in the way. Also on courtesy, who says it is being incourteous? Assume good intent. | 11:29 |
| *** bbowen has joined #openstack-nova | 11:29 | |
| kashyap | gibi: :-) I was just "thinking (or arguing) out loud". | 11:30 |
| sean-k-mooney | i am assuming good intent but i would assume you would like to see change to fedora requirement before they merged if i was droping support for a fedora version | 11:31 |
| kashyap | For an EOL release? I don't give a damn | 11:31 |
| sean-k-mooney | anyway thanks gibi :) | 11:31 |
| gibi | we an always revert such patches :) | 11:32 |
| gibi | we can | 11:32 |
| kashyap | Yes, exactly. | 11:32 |
| kashyap | The "revert" hammer is always near by :D | 11:32 |
| sean-k-mooney | keep it away from artom for a while | 11:32 |
| kashyap | Haha | 11:32 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.75: Add 'power-update' external event https://review.opendev.org/645611 | 11:38 |
| *** tesseract has joined #openstack-nova | 11:38 | |
| *** ganso has joined #openstack-nova | 11:39 | |
| * artom pops up like a meerkat | 11:39 | |
| artom | What am I reverting? | 11:39 |
| sean-k-mooney | hehe nothing i was just saying lets not hit you with the revert hammer for a while. | 11:40 |
| sean-k-mooney | i think you have had enough heartache form it in the last week or two | 11:40 |
| *** ratailor has quit IRC | 11:40 | |
| artom | Ugh | 11:40 |
| *** eharney has quit IRC | 11:40 | |
| kashyap | He was teasing you :D | 11:41 |
| sean-k-mooney | more his bad luck | 11:41 |
| artom | I know, the "ugh" was about the reverts, not the tease | 11:41 |
| kashyap | Nod, figured as much. | 11:48 |
| *** Bidwe_jay has joined #openstack-nova | 11:50 | |
| *** dpawlik has quit IRC | 12:16 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: migrations: libvirt: remove get_machine_ips() https://review.opendev.org/671471 | 12:26 |
| artom | sean-k-mooney, ^^ | 12:26 |
| *** eharney has joined #openstack-nova | 12:26 | |
| artom | stephenfin, ^^ you might like the code removal aspect too :) | 12:26 |
| *** udesale has quit IRC | 12:26 | |
| artom | Not sure if I need a bug for that... | 12:26 |
| *** udesale has joined #openstack-nova | 12:27 | |
| sean-k-mooney | ya we proably should have a bug and mention the downstream one | 12:27 |
| sean-k-mooney | :) +0,-55 | 12:27 |
| sean-k-mooney | artom: actully we want to backport it so it need a bug | 12:31 |
| stephenfin | artom: Makes sense. Do you want to backport it? | 12:34 |
| sean-k-mooney | stephenfin: we need this on newton downstream | 12:34 |
| sean-k-mooney | so yes | 12:34 |
| stephenfin | I assume so, given your comment in the bug. If so, what sean-k-mooney said | 12:34 |
| stephenfin | ack | 12:34 |
| artom | stephenfin, it's for an internal escalation, so yeah | 12:34 |
| artom | Busy with household'y stuff, will file bug | 12:35 |
| artom | In a few | 12:35 |
| stephenfin | That's going to be an ugly backport. You've been warned | 12:35 |
| artom | I... I can't tell if you're being serious | 12:35 |
| stephenfin | (look at the "Conflicts With" for an idea of the amount of _unmerged_ patches this touches) | 12:35 |
| stephenfin | Oh, I'm always very serious | 12:35 |
| sean-k-mooney | really? why | 12:35 |
| stephenfin | Serious Steve, I've been called | 12:35 |
| sean-k-mooney | i think that is likely jsut change to the module import in most cases | 12:36 |
| artom | I would think most of those are just whitespace-type things | 12:36 |
| artom | Ie, the excision itself is clean, but git is having trouble because what's around it changed | 12:36 |
| stephenfin | Quite possibly. I didn't check. It doesn't matter much either. If it's got to be done, it's got to be done. | 12:36 |
| sean-k-mooney | stephenfin: also if artom going to be the one doing it ... :) | 12:36 |
| artom | Sheesh guys, team spirit and all that | 12:37 |
| sean-k-mooney | we will review it for you down stream too :P | 12:37 |
| stephenfin | Go team? | 12:38 |
| artom | And I'm sure it'll be done most professionally | 12:38 |
| stephenfin | And that's all the team spirit I have for one day. | 12:38 |
| sean-k-mooney | stephenfin: maybe an infution of teen sprit will help https://www.youtube.com/watch?v=hTWKbfoikeg | 12:40 |
| artom | sean-k-mooney, *fist bump* | 12:45 |
| artom | Noice. | 12:45 |
| *** mvkr_ has quit IRC | 12:56 | |
| kashyap | alex_xu: When you're awake: Mind giving an opinion on the Intel CMT thing? -- https://review.opendev.org/#/c/669129/ | 12:58 |
| *** damien_r has quit IRC | 13:03 | |
| *** Guest99405 is now known as redrobot | 13:13 | |
| *** dpawlik has joined #openstack-nova | 13:15 | |
| *** ag-47 has joined #openstack-nova | 13:17 | |
| *** boxiang has joined #openstack-nova | 13:18 | |
| alex_xu | kashyap: thanks, I will check that | 13:19 |
| kashyap | Thanks! | 13:23 |
| *** hoonetorg has quit IRC | 13:28 | |
| *** damien_r has joined #openstack-nova | 13:30 | |
| *** damien_r has quit IRC | 13:30 | |
| *** damien_r has joined #openstack-nova | 13:30 | |
| *** ag-47 has quit IRC | 13:32 | |
| *** jovial[m] has joined #openstack-nova | 13:33 | |
| *** tbachman has joined #openstack-nova | 13:34 | |
| alex_xu | kashyap: I will send an email double check with team, the last time(after the dublin ptg) I check with team, it said ok to remove it. so just wait few more sec, I will get that back to you. | 13:35 |
| kashyap | alex_xu: Sure, no rush. By "remove it", are you suggesting to remove entire support for it, yeah? | 13:36 |
| alex_xu | kashyap: the entire perf feature, right? I didn't heard any requirement from intel for it now. | 13:36 |
| kashyap | Right, indeed | 13:36 |
| *** beekneemech has joined #openstack-nova | 13:36 | |
| kashyap | As we know, the kernel itself has completely nuked it | 13:37 |
| *** bnemec has quit IRC | 13:37 | |
| *** tbachman has quit IRC | 13:39 | |
| *** tbachman has joined #openstack-nova | 13:40 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-next: Deploy noVNC from source https://review.opendev.org/671490 | 13:42 |
| lyarwood | melwitt: ^ as discussed, hopefully that's enough to make this work. | 13:42 |
| *** Luzi has quit IRC | 13:52 | |
| *** TxGirlGeek has joined #openstack-nova | 13:52 | |
| *** whoami-rajat has joined #openstack-nova | 13:55 | |
| *** artom has quit IRC | 13:56 | |
| *** boxiang has quit IRC | 13:56 | |
| *** ttsiouts has quit IRC | 14:01 | |
| *** tbachman has quit IRC | 14:01 | |
| *** ttsiouts has joined #openstack-nova | 14:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 14:04 |
| *** ttsiouts has quit IRC | 14:05 | |
| *** ttsiouts has joined #openstack-nova | 14:06 | |
| *** JamesBenson has joined #openstack-nova | 14:06 | |
| *** JamesBenson has quit IRC | 14:10 | |
| *** JamesBenson has joined #openstack-nova | 14:13 | |
| stephenfin | dansmith: Off the top of your head, any idea what would cause this? http://paste.openstack.org/show/754546/ | 14:13 |
| dansmith | yes? | 14:14 |
| dansmith | you named the things different in the model and the migration | 14:14 |
| dansmith | pcpus vs pcpus_used apparently | 14:14 |
| efried | kashyap: I use git-restack regularly to manage series | 14:14 |
| dansmith | stephenfin: ^ | 14:14 |
| *** JamesBenson has quit IRC | 14:15 | |
| stephenfin | dansmith: I don't see how though http://paste.openstack.org/show/754547/ | 14:15 |
| *** JamesBenson has joined #openstack-nova | 14:15 | |
| *** ccamacho has quit IRC | 14:15 | |
| dansmith | hmm, so it must be claiming that both of those are missing from one or the other | 14:16 |
| dansmith | oh | 14:17 |
| dansmith | stephenfin: aren't you creat5ing them as nullable=True, | 14:17 |
| dansmith | but they're =false in the model | 14:17 |
| stephenfin | god damn it, yup | 14:17 |
| dansmith | that output from the test looks different than I remember for some reason, but .. yeah | 14:18 |
| stephenfin | Thanks. I've been looking at that for at least 30 minutes 😅 | 14:18 |
| dansmith | np, blinders.. it's a thing | 14:18 |
| *** tbachman has joined #openstack-nova | 14:19 | |
| *** ccamacho has joined #openstack-nova | 14:20 | |
| kashyap | efried: Good to know. Thanks for the view | 14:21 |
| *** mlavalle has joined #openstack-nova | 14:22 | |
| efried | kashyap: in fact, if you're trying to convince people that gerrit is awesomer than other things, how do other things manage series? Cause gerrit does it awesomely. | 14:22 |
| * kashyap on a call; back in a min | 14:24 | |
| efried | kashyap: I wrote a tutorial, which might be handy: https://docs.openstack.org/contributors/de/code-and-documentation/patch-series-tutorial.html | 14:24 |
| efried | https://docs.openstack.org/contributors/code-and-documentation/patch-series-tutorial.html | 14:25 |
| * kashyap is back here. | 14:29 | |
| kashyap | Excellent; I saw that before! | 14:30 |
| kashyap | efried: I don't think this group might consider Gerrit. I wanted to present where Gerrit shines | 14:30 |
| kashyap | s/!// | 14:30 |
| efried | cool | 14:31 |
| *** TxGirlGeek has quit IRC | 14:33 | |
| kashyap | efried: So 'git-restack' is not exactly "abandonware" is it? | 14:33 |
| efried | what does that mean? | 14:33 |
| kashyap | Sorry, meanining, nobody has time to tend to it | 14:34 |
| *** ricolin_ is now known as ricolin | 14:34 | |
| kashyap | [Last commit was from 4 years ago.] | 14:34 |
| efried | oh, it's maintained, insofar as that's necessary. I think someone like fungi or dhellmann owns it. | 14:34 |
| kashyap | It might well be that the project is "done", though. Which is perfectly acceptable | 14:34 |
| kashyap | Right, noted. | 14:34 |
| efried | yeah, it doesn't need much. It's just a thin wrapper around `git rebase -i commit-before-wherever-my-current-series-meets-up-with-master` | 14:34 |
| efried | just saves you figuring out that last piece. | 14:35 |
| fungi | efried: it's a side-project of corvus | 14:36 |
| fungi | (like gertty) | 14:36 |
| efried | ah, k | 14:36 |
| *** lbragstad has joined #openstack-nova | 14:36 | |
| sean-k-mooney | efried: i think its a little smarter tehn that and looks for the parent commit where my current series meets up with its parent branch. but i might be mistaken | 14:36 |
| fungi | ahh, nope, it's official opendev. i forgot | 14:36 |
| fungi | he just initially developed it | 14:36 |
| sean-k-mooney | e.g. i think if you were on stable/stien origically it look for where your feature branch meets stable/stine instead of master | 14:37 |
| *** belmoreira has quit IRC | 14:37 | |
| efried | kashyap: If you wanted to break that 4-year streak, we did recently discuss adding a feature where you could say `git restack --continue` and it determines whether you need a `commit --amend` or just a `rebase --continue`, which is one place I've gotten bitten in the restack workflow from time to time. | 14:37 |
| fungi | https://review.opendev.org/#/admin/groups/git-restack-core | 14:37 |
| fungi | infra-core approves changes for it | 14:37 |
| kashyap | efried: Hehe, noted. | 14:37 |
| efried | sean-k-mooney: yes, "meets up with its parent branch" is more correct. My hyphenated thingy wasn't long enough already. | 14:38 |
| sean-k-mooney | :) | 14:38 |
| fungi | no pending changes for review on opendev/git-restack that i can see | 14:38 |
| fungi | was someone having problems using it? | 14:38 |
| sean-k-mooney | the tool extention i personly want to write at some point is "git review --quad-diff <gerrit id>" or "git-review -Q" if that is free | 14:39 |
| sean-k-mooney | it would print the diff of the current reve to its base difed againt the previs revies to that revions base | 14:40 |
| fungi | sean-k-mooney: maybe better to just make a separate git subcommand for whatever that does? (doesn't sound like it's related to fetching and pushing changes for review) | 14:40 |
| sean-k-mooney | so if you have don rebase it would remove them and show you only what changed | 14:40 |
| fungi | oh, i see, you want to compare against content on gerrit... hmmm | 14:40 |
| sean-k-mooney | fungi: ya i actully want it in gerrit itself but i dont want to write java or javscript | 14:41 |
| *** mlavalle has quit IRC | 14:41 | |
| sean-k-mooney | so ill settle for a little tool or an extention to git review. | 14:41 |
| *** belmoreira has joined #openstack-nova | 14:41 | |
| sean-k-mooney | its on my todo list for the next weekend i feel like hacking on something | 14:42 |
| fungi | gertty has a couple of diff options already, maybe a third would fit in nicely? | 14:42 |
| sean-k-mooney | ya maybe | 14:42 |
| sean-k-mooney | i have been meaning to look at the db opertion in gerrty to see if i can speed up the intial data base builing | 14:43 |
| sean-k-mooney | but the diff feature would be simpler to start with | 14:43 |
| *** goldenfri has quit IRC | 14:45 | |
| efried | fungi: "no pending changes" "having problems" -- no, I was just mentioning its existence to kashyap, and he asked if it was abandoned because it hasn't seen a commit in 4y, and I said nay because it doesn't need any because it's so simple, but we talked recently about a feature that could be added to it. | 14:45 |
| efried | and now you're up to date | 14:45 |
| sean-k-mooney | fungi: efried does it work on python3? | 14:45 |
| kashyap | Yeah, that's completely fair. I shouldn't confuse "activity" with "improvements". | 14:45 |
| sean-k-mooney | if its been 4 years... | 14:45 |
| kashyap | sean-k-mooney: So? Maybe it does one thing and does it well? :-) | 14:46 |
| efried | sean-k-mooney: um, it's possible it's sh, not python, though I haven't looked. | 14:46 |
| efried | because technically all it would need to do is invoke a few git commands | 14:46 |
| *** mlavalle has joined #openstack-nova | 14:46 | |
| sean-k-mooney | its got some python 3 checking code https://github.com/openstack-infra/git-restack/blob/master/git_restack/cmd.py#L30-L46 | 14:47 |
| sean-k-mooney | so ill assume its fine | 14:47 |
| *** priteau has joined #openstack-nova | 14:48 | |
| fungi | efried: kashyap: thanks! and yeah, happy to discuss features that might be in-scope, but also as you say it's a great example of a very simple git subcommand, and it's easy to add more subcommands to git... the opendev/git-restack is nearly all boilerplate | 14:50 |
| fungi | er, the opendev/git-restack repo is i mean | 14:50 |
| kashyap | Noted :-) | 14:51 |
| fungi | and yeah, it's python-based, and yeah i run it installed into a python3 (.8 beta) venv | 14:51 |
| sean-k-mooney | gibi: do you mind if i reverse the direction fo the depend on for the vpmu patch. e.g. make the glance change to the metadef depend on the nova one. | 14:54 |
| *** belmoreira has quit IRC | 14:54 | |
| sean-k-mooney | the glance change is not really needed for it to work its just documentation which ill write but i dont know how long that will take to merge | 14:54 |
| *** ratailor has joined #openstack-nova | 14:58 | |
| *** TxGirlGeek has joined #openstack-nova | 15:00 | |
| gibi | sean-k-mooney: ohh, so the new glance image property doesn't need any code on glance side? | 15:01 |
| sean-k-mooney | correct | 15:02 |
| sean-k-mooney | we just need to extend the nova image meta object | 15:02 |
| sean-k-mooney | glance does no validation | 15:02 |
| sean-k-mooney | what the metadefs are fro aare auto generating client e.g. the horizon dashboard for setting image metadata | 15:03 |
| gibi | sean-k-mooney: thanks, then I'm OK to have the dependency in the other way | 15:04 |
| sean-k-mooney | im currently fixing the other issue but i should get a new version up today. | 15:05 |
| sean-k-mooney | ill start on the glance patch once that is done | 15:05 |
| *** belmoreira has joined #openstack-nova | 15:08 | |
| *** nicholas has joined #openstack-nova | 15:08 | |
| *** artom has joined #openstack-nova | 15:08 | |
| efried | gibi: responded in https://review.opendev.org/#/c/612497/ -- please let's resolve the discussion about $COMPUTE_HOST if you're still around. | 15:08 |
| cdent | heh: "this is obviously by design" | 15:12 |
| *** eharney_ has joined #openstack-nova | 15:12 | |
| dansmith | efried: your comment about $COMPUTE_HOST for ironic makes this basically unusable by any real ironic deployment, AFAICT | 15:14 |
| *** eharney has quit IRC | 15:15 | |
| efried | dansmith: on the contrary, $COMPUTE_HOST is really a convenience to un-awkward the chicken/egg of having to bring up the compute so it creates the provider so you can glean its UUID and create your file and restart compute. | 15:15 |
| efried | for ironic, don't you already know the UUIDs of the nodes before you bring up the compute service? | 15:15 |
| dansmith | efried: except that ironic computes rebalance their nodes in ways you don | 15:15 |
| dansmith | don't control | 15:15 |
| efried | meaning putting them under different computes? | 15:16 |
| dansmith | the ownership of nodes by comptues I mean | 15:16 |
| efried | got it | 15:16 |
| efried | well | 15:16 |
| dansmith | point being, | 15:16 |
| dansmith | the node is the thing with the inventory, be it the one single node for a libvirt system, | 15:16 |
| dansmith | or the ironic nodes managed by a compute *service* | 15:16 |
| efried | If we want to add a "template multiple providers" feature in the future, that's certainly a possibility. | 15:17 |
| dansmith | further, | 15:17 |
| *** eharney_ is now known as eharney | 15:17 | |
| dansmith | on something like xen or vmware where the compute *service* may be running on a different host than the actual thing providing the resource, | 15:17 |
| dansmith | it's the node that has the inventory and they don't even share a name | 15:17 |
| efried | Okay, so you're suggesting a) $COMPUTE_NODE is the more proper term regardless; and b) we should apply whatever changes to all "nodes", which is only >1 for ironic | 15:18 |
| dansmith | if you make it $COMPUTE_NODE, then I think it would be natural to apply the contents below that to any compute node the compute service manages, | 15:18 |
| dansmith | which is basically the templating thing done | 15:18 |
| dansmith | yes | 15:18 |
| efried | okay, I can buy that. | 15:18 |
| dansmith | every time I look at this spec it has been rev'd or rebased, which makes back-and-forth discussion on individual points kinda hard, | 15:19 |
| dansmith | so I'm going to reply to your reply to my comments on three patch revisions ago to capture this | 15:19 |
| efried | dansmith: thanks. | 15:19 |
| *** hoonetorg has joined #openstack-nova | 15:26 | |
| stephenfin | dansmith: Turns out adding a new column to an existing table with 'nullable=False, default=0' doesn't do what you'd think it does. We need 'server_default="0"' instead, for some reason | 15:28 |
| stephenfin | The more you know | 15:28 |
| stephenfin | Django's ORM _does_ work as expected | 15:28 |
| efried | I remember something about this from a couple years ago | 15:28 |
| dansmith | stephenfin: yep, knew that | 15:28 |
| dansmith | stephenfin: however, you don't need a default either | 15:29 |
| dansmith | stephenfin: your object should handle all of that | 15:29 |
| stephenfin | Figured you might, but I mentioned it cos that also took me some time to handle that | 15:29 |
| stephenfin | Hmm, without that SQLite complained about adding a non-nullable field without a default value | 15:29 |
| dansmith | stephenfin: you can't make it non-nullable | 15:29 |
| stephenfin | Right, that's what I ended up doing instead | 15:30 |
| dansmith | it needs to be nullable in the model and the schema, but the object can/should be non-nullable and just handle the translation across the upgrade boundary | 15:30 |
| stephenfin | Oh, I assumed the DB model had to match the object | 15:31 |
| stephenfin | I'll tweak that, in that case | 15:31 |
| dansmith | no, | 15:32 |
| dansmith | that's kind of the point of the object is to hide the differences in the model and the upgrade minutia from the above layers | 15:32 |
| dansmith | efried: I just realized I somehow didn't commit a comment on the spec from yesterday, relating to the version thing | 15:33 |
| dansmith | efried: what I was going to say is that I think that the file should be forwards and backwards compatible within a minor version, | 15:33 |
| dansmith | er, within a major | 15:33 |
| dansmith | such that 1.0 should be parseable by a 1.9-knowing bit of code | 15:33 |
| dansmith | and similarly, 1.9 file should work for a 1.0-knowing old piece of code | 15:34 |
| dansmith | the reason the minor is there is just as an early key for newer code to know if it should even look for new things, not to know if it should use the stricter or looser schecma | 15:34 |
| dansmith | and that the schema(s) should have additionalProperties:true in them | 15:34 |
| dansmith | such that we're always purely additive within a major, and the new stuff is ignore-able by old things | 15:35 |
| dansmith | i.e. less pedantic than our external API | 15:35 |
| dansmith | I say this because in reality people will be rolling multiple versions of compute code with a single version of a deployment tool, and having to know the precise minor expected by a particular RPM revision on a single node is going to be super annoying | 15:36 |
| dansmith | config files are supposed to be uuber stable and our handling of them across versions super gracious | 15:37 |
| *** ttsiouts has quit IRC | 15:44 | |
| *** ttsiouts has joined #openstack-nova | 15:45 | |
| *** tssurya has quit IRC | 15:47 | |
| *** ag-47 has joined #openstack-nova | 15:48 | |
| *** ttsiouts has quit IRC | 15:49 | |
| gibi | efried: I replyied to the $COMPUTE_HOST part of the spec and removed my -1. Besides this COMPUTE_HOSt identification thing I'm OK with the spec | 15:50 |
| gibi | efried: and I have to leave now (was no a meeting since you pinged) | 15:50 |
| *** helenafm has quit IRC | 15:53 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'devname' field of '[pci] passthrough_whitelist' https://review.opendev.org/670585 | 15:55 |
| *** davidsha has quit IRC | 15:56 | |
| *** beekneemech has quit IRC | 15:57 | |
| *** belmoreira has quit IRC | 15:58 | |
| *** bnemec has joined #openstack-nova | 15:58 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: migrations: libvirt: remove get_machine_ips() https://review.opendev.org/671471 | 15:59 |
| artom | sean-k-mooney, stephenfin ^^ | 16:00 |
| openstackgerrit | Merged openstack/nova master: bindep: Remove dead markers https://review.opendev.org/671452 | 16:00 |
| *** eharney has quit IRC | 16:02 | |
| * stephenfin clicks | 16:02 | |
| *** rpittau is now known as rpittau|afk | 16:05 | |
| *** ratailor has quit IRC | 16:05 | |
| artom | stephenfin, cheers! | 16:06 |
| * artom wonders if another core could be recruited. gibi, efried? | 16:07 | |
| efried | dansmith: I don't see how you could expect 1.4-level code to be able to handle 1.5-level config | 16:08 |
| efried | artom: we talking about remove get_machine_ips? | 16:10 |
| artom | efried, we are | 16:10 |
| efried | looking. | 16:10 |
| artom | Thank you, appreciated :) | 16:10 |
| dansmith | efried: because the rule would be additive only | 16:11 |
| dansmith | efried: it works today with our nova.conf, we just have no version so we don't know anything about it | 16:11 |
| efried | dansmith: wait, you mean 1.4 code would be able to load up 1.5 conf, but it would ignore any 1.5-isms? | 16:12 |
| efried | So schema-wise, the only difference is additionalProperties:true everywhere. But usage-wise, the deployer has to make sure their compute version is at 1.5 to use 1.5-isms -- which they had to do anyway, except now they have to do it explicitly instead of the code enforcing it. | 16:14 |
| efried | s/explicitly/preemptively? or something/ | 16:15 |
| dansmith | I'm not sure what you mean about the explicit operator tasks | 16:16 |
| sean-k-mooney | efried: in v1 of this are we going to allow the provider yaml to modify any RP create by the virt dirver. i read the last version fo the spec as no. we would only beable to add new rps as childern of the copute node | 16:16 |
| efried | I get the parallel with nova.conf, where you can put in all the [foo]bar=baz you want and it'll get ignored by the code. But that's an artifact of oslo.config - we couldn't do anything about that if we tried. | 16:16 |
| dansmith | you mean because you made them put the minor in there? | 16:16 |
| sean-k-mooney | efried: well we could | 16:16 |
| sean-k-mooney | we know all the valid filed we coudl check for any that are not registered | 16:16 |
| sean-k-mooney | and raise an error | 16:17 |
| sean-k-mooney | we just dont | 16:17 |
| efried | dansmith: In both cases I'm assuming a file with schema_version:1.5 and some 1.5-specific values therein. | 16:17 |
| dansmith | sean-k-mooney: we're talking about the opposite thing, and he's right we can't check for that | 16:17 |
| sean-k-mooney | we cant check for fileds and section in the config we dont have a config option registered for? | 16:18 |
| sean-k-mooney | that seams like ti would be pretty trivail to do | 16:18 |
| efried | dansmith: in the stricter impl (as proposed), if compute is at 1.4, it will fail. | 16:18 |
| efried | in the looser impl (what you're suggesting), if compute is at 1.4, it will successfully load up the config, but only process the >=1.4-isms, ignoring the 1.5-isms. | 16:18 |
| dansmith | sean-k-mooney: can you hold on a sec, we're not even talking about the actual config file | 16:18 |
| sean-k-mooney | sure sorry to interupt | 16:18 |
| dansmith | efried: the operator should declare which "version of the docs" they're reading when they write the file, nova should not freak out about things it doesn't know about and not expect things to be present if the operator has clearly indicated they wrote the config file four versions ago | 16:19 |
| dansmith | efried: the alternative is just to look at what is present in the file and not worry about the minor, and only use the major to control large changes, which I think we've already discussed | 16:19 |
| sean-k-mooney | like the version in heat templates? | 16:19 |
| dansmith | efried: but yes, all I'm saying is add additionalProperties:true, and just require the 1.5isms to not break the 1.4isms, and also not have compute fail if it expects 1.5 and only 1.4 is provided (which would break our upgrade promise, which has been in place since forever) | 16:20 |
| dansmith | sean-k-mooney: is the heat template version a format version? I thought that was a self-assigned revision so heat can tell when you've modified it | 16:20 |
| sean-k-mooney | yes | 16:20 |
| sean-k-mooney | its the schema version | 16:20 |
| dansmith | okay, then yes probably similar but I dunno what their semantics are | 16:21 |
| sean-k-mooney | https://docs.openstack.org/heat/latest/template_guide/hot_spec.html | 16:21 |
| sean-k-mooney | heat_template_version | 16:22 |
| sean-k-mooney | This key with value 2013-05-23 (or a later date) indicates that the YAML document is a HOT template of the specified version. | 16:22 |
| efried | dansmith: "1.5 schema and compute always accepts 1.4 config" -- absolutely | 16:22 |
| efried | still don't agree with the other direction. | 16:22 |
| dansmith | that 1.4 should be able to read a 1.5 file? | 16:22 |
| efried | right. If I lay down a 1.5 file, I expect the 1.5-isms to be observed, not ignored. | 16:23 |
| dansmith | so, here's how an upgrade has to go then: | 16:23 |
| efried | noting that the file declares itself as 1.5 | 16:23 |
| dansmith | 1. Start with 1.4 code and config everywhere | 16:23 |
| dansmith | 2. Upgrade to 1.5 code over time | 16:23 |
| dansmith | 3. Once all the 1.5 is deployed, then deploy 1.5 config everywhere, revisiting all nodes and restarting them again | 16:23 |
| *** sapd1_x has joined #openstack-nova | 16:24 | |
| sean-k-mooney | Ignoring FFU is that not what we are ment to do in general | 16:24 |
| efried | I see your point, you save the last restart if you do the loose way | 16:24 |
| sean-k-mooney | e.g. upgade code then modify config after | 16:24 |
| dansmith | or else you have to have two versions of all your ansible modules, or they have to embed the version awareness into the ansible modules | 16:24 |
| dansmith | so you're generating the right version for the *Exact* code version you're deploying | 16:24 |
| efried | I'm trying to convince myself that the extra restart is worse than my new fields being ignored, and I don't know why until I go figure out the version diff between the code and the config and which fields were added in that span. | 16:27 |
| *** gyee has joined #openstack-nova | 16:27 | |
| dansmith | it's not just the extra restart, | 16:27 |
| dansmith | it's also the embedding of this knowledge into the ansible/puppet/whatever | 16:27 |
| sean-k-mooney | we also might need to do reshapes right? | 16:27 |
| *** brinzhang has quit IRC | 16:28 | |
| dansmith | well, I guess I'd hope we don't, which is another reason for my other comment, | 16:28 |
| dansmith | which is not allowing operators to randomly change/subtract inventory from what the virt driver is providing | 16:28 |
| *** brinzhang has joined #openstack-nova | 16:28 | |
| sean-k-mooney | im just thinking about FFU whould you have to start the compute agent for each version | 16:28 |
| sean-k-mooney | or just do one config update at the end | 16:29 |
| efried | we've removed all possibilities of reshape and affecting existing inventories from this version of the spec | 16:29 |
| *** brinzhang has quit IRC | 16:29 | |
| sean-k-mooney | e.g keep 1.2 all the way up to 1.5 cond and then update to 1.5 template or do you have to go lockstepp | 16:29 |
| sean-k-mooney | efried: are you still allowing effect exiting RP | 16:29 |
| efried | yes, but not existing *inventory* | 16:29 |
| sean-k-mooney | by modifying tratis or adding new inventories | 16:30 |
| efried | you can't muck with VCPU | 16:30 |
| efried | and by "existing" I mean "inventories the virt driver deals with explicitly". | 16:30 |
| sean-k-mooney | im not conviced we shoudl allow creating inventories or modifying tratis on the RPs created by the virt driver | 16:30 |
| sean-k-mooney | at least in v1 | 16:30 |
| efried | wait, what?? | 16:30 |
| efried | That's the entire point | 16:30 |
| sean-k-mooney | i was suggesting only allow creating child RP of the compute node | 16:31 |
| efried | No | 16:31 |
| sean-k-mooney | and giving you full contol of the RP | 16:31 |
| efried | no child RPs | 16:31 |
| efried | that is way more complex | 16:31 |
| efried | and will be harder to "fix" in the future. | 16:31 |
| sean-k-mooney | how have we solved the multi writer issue for the traits | 16:32 |
| sean-k-mooney | e.g. traits taht are set to be ensured in the provider yaml vs auto discovered | 16:32 |
| dansmith | sean-k-mooney: I mostly agree, but I understand why adding (and sometimes removing) traits will be necessary | 16:32 |
| efried | As currently suggested, auto traits would still take precedence. Let me get you the spot where I explained that... | 16:32 |
| dansmith | but totes agree on inventory | 16:32 |
| efried | https://review.opendev.org/#/c/612497/12/specs/train/approved/provider-config-file.rst@159 | 16:33 |
| dansmith | it's a slippery slope, | 16:33 |
| dansmith | because you want them to be able to add/remove processor flag traits, | 16:33 |
| dansmith | but if you let them remove things like the disabled trait, or something critical to the rest of nova, then they've broken the internals and don't know why | 16:33 |
| dansmith | which is why I commented as such on the spec | 16:33 |
| cdent | trait mgt is the part that has me most concerned/confused | 16:34 |
| sean-k-mooney | right i was suggesting a seperate rp to avoid any possible conflcit with the virt driver | 16:34 |
| efried | but this is why we've taken all that stuff out | 16:34 |
| * cdent nods | 16:34 | |
| efried | the only thing that remains is the levels of hierarchy that would allow us to consider adding it back in the future without a major schema bump (or ugliness in the schema to work around that) | 16:35 |
| efried | which (I think - I'm still trying to grok) is even more important if we want to ensure forward-compat of minor versions. | 16:35 |
| efried | but | 16:36 |
| efried | if it's going to be the difference between getting this moving and having it stuck | 16:36 |
| efried | we can pare the schema down to only what's needed in v1.0 -- YAGNI+KISS | 16:36 |
| dansmith | sean-k-mooney: so, I'm really glad to hear you object to the random editing of the inventory by this file, which energizes me to take a more rigid stand on that point | 16:37 |
| efried | dansmith: we've already declared that you're not allowed to edit inventory of resources that the virt driver knows about. | 16:37 |
| *** ccamacho has quit IRC | 16:37 | |
| efried | (while noting that at some point in the future we want this file to be able to do just that for things like allocation ratios and reserved values) | 16:38 |
| dansmith | efried: so then you can remove the "ensure" hierarchy level | 16:38 |
| dansmith | I totally do not think this is the place to be controlling allocation ratios, and if it's in this file, it shouldn't be in the place where you expose other non-virt inventory | 16:39 |
| dansmith | or change "ensure" to "add" or "additional" to make it clear that it's appending stuff | 16:39 |
| dansmith | because I don't know how you're going to explain or communicate to people that try to override inventory in that section otherwise | 16:40 |
| efried | we had "add" originally. | 16:40 |
| dansmith | they're going to be like "dammit, I want to ENSURE that the VCPU inventory is 3" | 16:40 |
| sean-k-mooney | right i was about to ask what does https://review.opendev.org/#/c/612497/12/specs/train/approved/provider-config-file.rst@197 actully do | 16:40 |
| efried | gibi objected to that as being a verb and not idempotent | 16:40 |
| dansmith | I think I did too, so... additional | 16:40 |
| sean-k-mooney | i read that as only that trait will be reported | 16:40 |
| sean-k-mooney | not ensure that trait is appended to the virt dirver set | 16:41 |
| dansmith | yeah | 16:41 |
| efried | okay, so: | 16:42 |
| efried | - s/ensure/additional/g | 16:42 |
| efried | - forward compat for $minor version (additionalProperties:true) | 16:42 |
| efried | - $COMPUTE_NODE with explanation that includes "all ironic nodes" | 16:42 |
| efried | what else? | 16:42 |
| dansmith | not all ironic nodes, but all nodes | 16:42 |
| dansmith | or "all nodes managed by this compute" or something like that | 16:42 |
| sean-k-mooney | maybe call it $compute_service | 16:42 |
| dansmith | GOD | 16:43 |
| dansmith | no | 16:43 |
| *** sapd1_x has quit IRC | 16:43 | |
| dansmith | have you read the comments from the last 24 hours? | 16:43 |
| dansmith | it's *not* the service, it's the node that provides inventory | 16:43 |
| sean-k-mooney | ok | 16:43 |
| dansmith | that's the point :) | 16:43 |
| * dansmith puts down his nerf gun | 16:43 | |
| sean-k-mooney | oh right | 16:43 |
| sean-k-mooney | yes i was trying to say that i map node to a singel RP for a since server in my head. and that each ironci compute sevicce manage mulitpl phyical server each of which is a seper compute node but i think we mean the same thing and im jsut saying it badly | 16:44 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-next: Deploy noVNC from source https://review.opendev.org/671490 | 16:45 |
| *** gibi has quit IRC | 16:45 | |
| dansmith | sean-k-mooney: right, it's the terminology that is important I think, but obviously we're on the same page for mechanics | 16:45 |
| dansmith | it would be wrong to apply something that is declared to be "for the compute service" to the "compute nodes" | 16:45 |
| sean-k-mooney | yes | 16:46 |
| dansmith | but making the terminology match makes it clear that it's for the node, 1, 2, or 20 of them as managed by this service | 16:46 |
| efried | except we're conflating that a bit with things like the DISABLED trait... | 16:46 |
| efried | perhaps that's not the best example, but we've got traits on the RP that are really capabilities of the compute service... | 16:46 |
| dansmith | we're headed in the right direction with that though | 16:47 |
| dansmith | disabled predates nodes as a concept | 16:47 |
| dansmith | this moves it closer to the right thing, which is move it to the schedulable entity | 16:47 |
| sean-k-mooney | well if a compute service was disabled. all the compute nodes it managed would be unavailable until ironci moved them to be managed by another compute service | 16:48 |
| dansmith | that's my point | 16:48 |
| dansmith | it used to be right, now it's wrong, disabled traits on compute nodes is making it right-er | 16:48 |
| efried | also, do you feel as though the virt driver should or should *not* be involved in the processing here? | 16:49 |
| efried | cdent: this plays into whether auto traits can be added or not | 16:49 |
| efried | If we cut the virt driver out entirely, we can do the providers.yaml processing after update_provider_tree+update_traits without reorganizing the rt flow. | 16:50 |
| sean-k-mooney | efried: we breifly discussed if the generic code should live in teh Resouce tracker or in the driver base class | 16:50 |
| efried | Yeah, I'm less concerned about which module the generic code lives in and more about where it's invoked from in the flow. | 16:50 |
| sean-k-mooney | right i have a prefence but im wondering what dansmith thinks | 16:51 |
| *** panda is now known as panda|off | 16:51 | |
| efried | I've been proposing (https://review.opendev.org/#/c/612497/10/specs/train/approved/provider-config-file.rst@205) that it be invoked from within update_provider_tree itself, giving the driver a certain amount of control | 16:52 |
| sean-k-mooney | also my perference change depening on what we allow in the current version and in the future | 16:52 |
| dansmith | efried: remember, I was mostly concerned about the optics of how it's viewed from reading the spec, | 16:52 |
| dansmith | but I do think that making it as absolutely uniform as possible is important, | 16:52 |
| dansmith | and having it fully within the RT so that the RT refuses to update/replace anything the virt driver has done across the board would be the most consistent I think | 16:53 |
| *** damien_r has quit IRC | 16:53 | |
| efried | including automatic traits? | 16:53 |
| dansmith | well, I really think allowing them to remove traits by this mechanism is dangerous, as I said | 16:53 |
| sean-k-mooney | efried: my perfernce would be that the behavior would be the same regardless of the virt driver if at all possible | 16:53 |
| dansmith | yes ^ | 16:54 |
| *** igordc has joined #openstack-nova | 16:54 | |
| cdent | is there any mechanism to remove traits? | 16:54 |
| efried | In this iteration only adding traits is allowed, so the difference is whether, when I try to add a trait that's otherwise dealt with by the compute manager, it sticks or not. | 16:54 |
| efried | cdent: not yet, but we've been trying to leave it open for that possibility (in some form) in the future. | 16:54 |
| dansmith | definitely should not | 16:54 |
| efried | okay. | 16:54 |
| efried | so | 16:54 |
| sean-k-mooney | if we allw modifcation of inventores/traits creted by the virt driver i also conceed we might want to delgate processign to the virt driver at that point | 16:54 |
| dansmith | efried: don't we have a declaration of which traits are owned by the compute and virt, so that we can wholly box off those anyway? | 16:55 |
| efried | today: update_provider_tree => update_auto_traits | 16:55 |
| efried | tomorrow: update_provider_tree => process_providers_yaml => update_auto_traits | 16:55 |
| efried | dansmith: no, unfortunately not | 16:55 |
| efried | and in fact, the above mixes poorly | 16:55 |
| sean-k-mooney | dansmith: not really. unless we say provdier.yaml can only use CUSTOM_ | 16:55 |
| dansmith | efried: well, maybe we should do that as part of this.. I know we discussed it before | 16:55 |
| sean-k-mooney | which i think is too restrictive | 16:55 |
| dansmith | sean-k-mooney: well, that would probably not be too bad, IMHO | 16:55 |
| efried | because update_provider_tree may have some traits it enforces | 16:55 |
| dansmith | it would clearly draw a box around the things you're doing as being purely localized customization and not mucking with internal features | 16:56 |
| efried | but then update_auto_traits (which is not under control of the virt driver -- except as declared by the compute capabilities dict) has others | 16:56 |
| sean-k-mooney | it would be nice to be able to use a standard hyper treading treat or secure boot trait | 16:56 |
| sean-k-mooney | and use the file to add them if its supported | 16:56 |
| efried | dansmith: unfortunately it's not easy to do. See venn diagram here https://docs.openstack.org/nova/latest/reference/update-provider-tree.html#taxonomy-of-traits-and-capabilities | 16:56 |
| dansmith | sean-k-mooney: but why would that not be exposed by the driver if it's available and enabled? making operators track that is dumb | 16:56 |
| sean-k-mooney | im not sure if those are actully good examples | 16:57 |
| efried | that is, we've identified the problem before, but punted on trying to solve it because it's too hard. | 16:57 |
| dansmith | efried: CUSTOM_ would make it pretty easy | 16:57 |
| sean-k-mooney | dansmith: well the hypertreading tread is explcitly not owned by the virt driver | 16:57 |
| efried | hum | 16:57 |
| dansmith | sean-k-mooney: why? | 16:57 |
| sean-k-mooney | its stated that way to allow the cpu tread polices to work | 16:57 |
| dansmith | sean-k-mooney: give me a reason that makes sense, not one that is tied to how things work today :) | 16:58 |
| sean-k-mooney | this is why i said that might not be a good example but its in che CPU standaisation in placement spec | 16:58 |
| dansmith | ack | 16:59 |
| sean-k-mooney | last paragrh in https://github.com/openstack/nova-specs/blob/master/specs/train/approved/cpu-resources.rst#add-hw_cpu_hyperthreading-trait | 16:59 |
| sean-k-mooney | well that section in general. | 16:59 |
| sean-k-mooney | im not sure if there are standard traits you would want to manage this way | 16:59 |
| sean-k-mooney | i just didnt want to assuem there wasnt | 17:00 |
| *** derekh has quit IRC | 17:00 | |
| dansmith | I think saying that these things are all restricted to the CUSTOM_ realm is a good line, IMHO | 17:00 |
| efried | I think I can buy CUSTOM_ only. | 17:00 |
| sean-k-mooney | again for v1 we could say just CUSTOM_ untill we have a usecase that requires standard traits | 17:00 |
| *** udesale has quit IRC | 17:00 | |
| dansmith | efried: you willing to say that for traits and inventory or just the former? | 17:01 |
| sean-k-mooney | e.g. you can only have CUSTOM_ resouce classes too? | 17:01 |
| dansmith | I'm less sure about it for inventory, but it does eliminate a lot of my concern over overriding virt inventory | 17:01 |
| efried | well, in both cases it would be nice to be able to propose standard so that, if/when those features become native, you don't have to reshape. | 17:01 |
| sean-k-mooney | i think invntories are less of an issue | 17:01 |
| efried | but | 17:01 |
| efried | I can see where it simplifies things to say CUSTOM_ only for now. | 17:02 |
| dansmith | efried: seems like a clearer line though | 17:02 |
| efried | yes | 17:02 |
| dansmith | efried: do you actually expect people to define their own non-custom classes in placement? if they do they run up against id conflict right? | 17:02 |
| sean-k-mooney | we have previosly agreed that that virt divers should not use CUSTOM_ stuff in general right | 17:02 |
| efried | dansmith: no, they would have to propose them in the actual repos | 17:02 |
| dansmith | sean-k-mooney: except for ironic which *relies* on it | 17:03 |
| dansmith | efried: right, so then they have to reshape anyway | 17:03 |
| sean-k-mooney | and i gues the vPMEM stuff | 17:03 |
| sean-k-mooney | ok ignore the virt driver wont use it thing | 17:03 |
| efried | I'm saying if they propose the standard ones before they start customizing, they don't need to reshape. | 17:03 |
| dansmith | efried: that's a big if, but okay :) | 17:03 |
| efried | anyway, I think trying to anticipate how reshapes play in here is a fool's errand | 17:03 |
| cdent | It's an important question though | 17:04 |
| dansmith | I'm massively happier about all this if it's restricted to CUSTOM_ | 17:04 |
| efried | so yeah, CUSTOM only for both traits and resource classes is okay for this rev | 17:04 |
| cdent | if the point of the yaml file is to allow people to experiment on thing that they then expect to some day become "normal" | 17:04 |
| efried | cdent: yeah, that's where I was leaning | 17:04 |
| dansmith | cdent: that may be one use of it, but not the primary use I expect | 17:04 |
| cdent | I was going on what the spec says, because I _still_ have trouble comprehending who the user is here | 17:05 |
| *** ag-47 has quit IRC | 17:05 | |
| sean-k-mooney | there may be some things we never want nova to own on the comptue node like the cyborg aclleartos so something may move out of the provdier.yaml to other service or jsut stay there | 17:05 |
| dansmith | cdent: the user is intel :/ | 17:05 |
| cdent | it reads as "some hardware vendors want to get some stuff in faster than nova can do it,but still want nova to do it" | 17:05 |
| dansmith | cdent: pretty much :) | 17:06 |
| cdent | hawt | 17:06 |
| *** xek has quit IRC | 17:06 | |
| sean-k-mooney | well RMD is one usecase | 17:06 |
| sean-k-mooney | there are others | 17:06 |
| sean-k-mooney | probably | 17:06 |
| cdent | whereas when it was coming in from the jay angle, I understood more as "sometimes we want to shape the hardware that is present to make it look different from what it says" | 17:07 |
| dansmith | I don't think that's jay's angle but I could be wrong | 17:07 |
| sean-k-mooney | well jay would like to abstract where it makes sense too | 17:07 |
| sean-k-mooney | to not expose every faset of the hardware topology | 17:07 |
| dansmith | and in his absence, I would claim that his angle is my angle, which is that this is for custom stuff, like accounting for fan capacity in aisles, etc | 17:07 |
| sean-k-mooney | just the bits that we need | 17:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/rocky: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/671303 | 17:08 |
| sean-k-mooney | dansmith: ya one of the usecase i was thinking of was power and termal cpasity | 17:08 |
| cdent | fans in aisles are so cool | 17:08 |
| dansmith | sean-k-mooney: yeah | 17:08 |
| efried | So then this suggests a flow like: | 17:08 |
| efried | 0) parse and schema-validate the file. (This happens just once, on startup, and fails the compute service if something is wrong) | 17:08 |
| efried | Then in the RT _update flow: | 17:08 |
| efried | 1) update_provider_tree (as today). (If we ever decide we want to give the driver direct pre/post processing control over the providers.yaml content, we could pass the json blob as a kwarg here. But not now.) | 17:08 |
| efried | 2) automatic traits (as today) | 17:08 |
| efried | 3) merge in providers.yaml stuff. (I think a second level of validation happens here, and fails the compute service if something is wrong -- that should only be possible the first time through, so we're not worried about the service dying after having been running for a while) | 17:08 |
| efried | 4) update_from_provider_tree (flush to placement) (as today) | 17:08 |
| * cdent thinks it probably time to say goodnight | 17:08 | |
| efried | I'm not sure how to detect a conflict between a custom RC from upt and one from providers.yaml. | 17:10 |
| sean-k-mooney | the validation of 3 might be as simple as make sure the intersection between the inventoires form each part of the merger is 0 | 17:11 |
| efried | yeah, that's what I'm noodling | 17:11 |
| sean-k-mooney | e.g. an invenotry is not defiend both the provider and virt driver trees | 17:11 |
| efried | that puts a bit of extra onus on upt to make sure it doesn't "ignore resource classes it doesn't know about" | 17:11 |
| efried | cause today we're careful to tell upt it must "ignore child providers it doesn't know about" | 17:12 |
| sean-k-mooney | ya that is related to the general problem of shareign RP between service. | 17:12 |
| efried | but I think that doesn't conflict. | 17:12 |
| sean-k-mooney | which for now we have punted | 17:12 |
| efried | yes | 17:12 |
| cdent | we keep having discussions about things knowing about things, and that makes me anxious. how does anything know? | 17:12 |
| efried | it's the virt driver's job to know about the hardware resources it has the ability to assign to VMs. | 17:13 |
| sean-k-mooney | right ad the provider.yamls would know about resoce that are not assinged to the vm but are indrecly consumed by it | 17:13 |
| sean-k-mooney | e.g power | 17:13 |
| *** eharney has joined #openstack-nova | 17:13 | |
| sean-k-mooney | or cache if the cache is affiend outside the virt dirver | 17:14 |
| dansmith | efried: the validation becomes "is CUSTOM_ and not already in the stuff I got from the virt driver" right? | 17:14 |
| sean-k-mooney | which you can do with rmd or sysfs and a crons script | 17:14 |
| sean-k-mooney | dansmith: i would hope so. or at least not signifcatly more complex | 17:14 |
| sean-k-mooney | the majority fo the validate would be done when parsing the file | 17:15 |
| dansmith | yeah | 17:15 |
| dansmith | yeah | 17:15 |
| efried | dansmith: yes, the concern I had was with idempotency. The second time through, the provider_tree we hand to upt will already contain the CUSTOM_ RCs from the last iteration when we processed providers.yaml. So upt has to *remove* those, or we'll blow up when we process the providers.yaml blob the second time. | 17:15 |
| *** igordc has quit IRC | 17:15 | |
| dansmith | ah I see | 17:16 |
| efried | if we think of upt's responsibility as simply "completely overwite the inventories for the providers I own" then it works. | 17:16 |
| dansmith | maybe just not fail if they're identical? | 17:16 |
| *** igordc has joined #openstack-nova | 17:16 | |
| efried | yeah, or that, that could work. | 17:16 |
| efried | um | 17:16 |
| dansmith | just "isn't already defined or is exactly the same" | 17:16 |
| efried | except "identical" needs to be forgiving of defaults | 17:16 |
| efried | because my providers.yaml is allowed to give only "total" and let the other fields default. | 17:16 |
| * cdent smhs | 17:17 | |
| dansmith | it's already limited to CUSTOM_ so there wouldn't be any of those right? | 17:17 |
| sean-k-mooney | is identical would require the virt driver to have the infor from the yaml to compare agaisnt | 17:17 |
| efried | default inventory values, like min_unit etc. | 17:17 |
| cdent | good luck, gotta make dinner | 17:17 |
| dansmith | efried: oh I see, | 17:17 |
| efried | o/ cdent | 17:17 |
| * cdent goodnights | 17:17 | |
| sean-k-mooney | unless the virt driver kept a list of the invetores it managed and only looked at those | 17:17 |
| dansmith | well, I'm sure you can work that out | 17:17 |
| sean-k-mooney | cdent: o/ | 17:17 |
| efried | sean-k-mooney: the virt driver does that | 17:17 |
| dansmith | sean-k-mooney: I think what you mean is just mark in the provider tree where each thing came from | 17:17 |
| sean-k-mooney | right so if it igores inventories not in that list | 17:17 |
| dansmith | so we can check the origin | 17:17 |
| *** cdent has quit IRC | 17:18 | |
| efried | except "only looked at those" is what I'm saying *doesn't* work. | 17:18 |
| sean-k-mooney | ya but we dont have an owner on the inventory to do that currently | 17:18 |
| sean-k-mooney | or ever | 17:18 |
| efried | because we're enforcing that providers.yaml is not allowed to muck with resources upt controls. | 17:18 |
| sean-k-mooney | so we would have to determin that in the RT | 17:18 |
| efried | yes | 17:18 |
| sean-k-mooney | whci we could do if we updated form teh provder.yaml first | 17:18 |
| sean-k-mooney | then called the virt dirver | 17:19 |
| efried | not the second time around. | 17:19 |
| sean-k-mooney | then added the auto tratis | 17:19 |
| *** panda|off has quit IRC | 17:19 | |
| sean-k-mooney | we should be able to mark them second time around | 17:19 |
| efried | "mark" how? | 17:19 |
| efried | You're talking about adding a metadata field to the ProviderTree object or something? | 17:19 |
| dansmith | efried: that's what I meant, but I'll leave it to you about what approach is best for that conflict resolution | 17:20 |
| sean-k-mooney | we woudl still get the set form teh file and then the tree we pass into upt we embed a flag in each inventory | 17:20 |
| efried | ugh, that seems overly complicated to me. | 17:20 |
| sean-k-mooney | efried: yes but not one that need to ever leave nova | 17:20 |
| efried | yeah, I get that | 17:20 |
| efried | I would just hate to explode the compute service because of a cache bug. | 17:20 |
| efried | maybe we take advantage of the init kwarg | 17:21 |
| efried | and only do that check the first time through. | 17:21 |
| efried | because that's the only time we're worried about it anyway. | 17:21 |
| dansmith | as long as we don't re-load the yaml, that would be reasonable It hink | 17:21 |
| sean-k-mooney | well the work flwo would be. get prov_tree from placement. generate tree from file. merge them and mark any that are common as from the file then pass it to the driver upt meethod | 17:21 |
| *** panda has joined #openstack-nova | 17:21 | |
| efried | yeah, we're definitely only loading the yaml once. | 17:21 |
| efried | otherwise the admin can blow up the compute service with a typo. | 17:22 |
| sean-k-mooney | we would have to load it one each agent start | 17:22 |
| efried | yes | 17:22 |
| sean-k-mooney | we can keep the file in memroy bettwen update_resouce calls in the RT | 17:23 |
| efried | yes | 17:23 |
| efried | as an attr on the rt | 17:23 |
| sean-k-mooney | sure | 17:23 |
| dansmith | efried: yep | 17:23 |
| sean-k-mooney | so on the second iterate we just mark anny inventory we get from placement that is in that cached tree as form_file | 17:23 |
| sean-k-mooney | or whatever | 17:23 |
| sean-k-mooney | if we did not want to blow up the virt drivers | 17:24 |
| sean-k-mooney | we could actully remove thos nodes tepmproally before we pass the tree to the driver | 17:25 |
| sean-k-mooney | and add them back after | 17:25 |
| sean-k-mooney | that a liitle more complext then i would like but you would hate my other idea more | 17:26 |
| efried | anyway, we're in implementation weeds here. Do y'all want to see this flow explicitly described in the spec or can we leave it vague-ish and sort it out in code? | 17:26 |
| dansmith | I think some of it in the spec would be good so we don't re-have this convo | 17:26 |
| sean-k-mooney | it would be nice to see it in the spec but ill leave that up to dan. | 17:26 |
| efried | ack | 17:27 |
| sean-k-mooney | efried: you could also summerise it to the mailing list? and then put the high level flow in the spec | 17:27 |
| sean-k-mooney | dansmith: efried on a different topic are ye ok with backport this to stien. the low constratit for sqlalchemy on stable/stine is above teh version wehre that was depercated | 17:42 |
| sean-k-mooney | https://review.opendev.org/#/c/664193/2 | 17:42 |
| efried | sean-k-mooney: I'm not stable fwiw | 17:42 |
| sean-k-mooney | its not? | 17:43 |
| efried | I'm saying, I can't +2 a backport | 17:43 |
| sean-k-mooney | oh | 17:43 |
| efried | What would the motivation be for backporting that? | 17:43 |
| sean-k-mooney | no i just wanted to know if ye are ok with me proposing ths | 17:43 |
| efried | just to reduce log noise? | 17:44 |
| sean-k-mooney | well we backported it down stream becasue rhel8 uses a version of sqlacamy that is new the the upper constatine on stable/stine | 17:44 |
| sean-k-mooney | so it was causing helping to cause the subunit parser explotion | 17:44 |
| sean-k-mooney | in our downstream functional job | 17:45 |
| *** hogepodge has quit IRC | 17:45 | |
| sean-k-mooney | that was not enought to fix the job donwstream but was one of the noiser things | 17:45 |
| efried | I confirm that sqla l-c in stein is above 0.8.0, so procedurally there's no reason not to do it. | 17:45 |
| efried | https://opendev.org/openstack/nova/src/branch/stable/stein/lower-constraints.txt#L150 | 17:45 |
| *** seyeongkim has quit IRC | 17:45 | |
| efried | so sure, if it helps ya, I don't object. | 17:45 |
| efried | But again, I can't +2 it. | 17:45 |
| *** guilhermesp has quit IRC | 17:46 | |
| sean-k-mooney | sure but you are ptl so its still good to check with you. | 17:46 |
| efried | :) thank you | 17:46 |
| openstackgerrit | sean mooney proposed openstack/nova stable/stein: Replace joinedload_all with joinedload https://review.opendev.org/671532 | 17:47 |
| sean-k-mooney | ill leave it up to the stable cores to weight in ^ | 17:47 |
| *** hogepodge has joined #openstack-nova | 17:47 | |
| sean-k-mooney | i can always abandon it | 17:47 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: take over instances from down compute services https://review.opendev.org/671534 | 17:48 |
| *** seyeongkim has joined #openstack-nova | 17:48 | |
| *** guilhermesp has joined #openstack-nova | 17:48 | |
| sean-k-mooney | currently im hoping adding --suppress-attachments to our downstream tox job will fix the sub unit issue at least for now | 17:48 |
| sean-k-mooney | that will skip the stdout and stderror for succesfful tests which grealy reduces the test output | 17:49 |
| sean-k-mooney | but still give you all the output if a test fails | 17:49 |
| sean-k-mooney | btu we dont know if that will be enough so suppressing deprecation warnings also helps | 17:49 |
| *** ralonsoh has quit IRC | 17:51 | |
| *** mgariepy has quit IRC | 17:53 | |
| *** gibi has joined #openstack-nova | 17:53 | |
| *** mgariepy has joined #openstack-nova | 17:57 | |
| *** psachin has quit IRC | 18:04 | |
| *** irclogbot_1 has quit IRC | 18:07 | |
| *** altlogbot_1 has quit IRC | 18:07 | |
| *** irclogbot_3 has joined #openstack-nova | 18:08 | |
| *** altlogbot_3 has joined #openstack-nova | 18:09 | |
| efried | dansmith: does ironic hash ring reshuffle require compute restart? | 18:45 |
| dansmith | efried: no | 18:45 |
| efried | I guess that still works, though, since you've already parsed the file. | 18:45 |
| efried | thx | 18:45 |
| dansmith | yeah | 18:45 |
| efried | but means we can't rely on the 'startup' arg | 18:46 |
| *** Bidwe_jay has quit IRC | 18:46 | |
| efried | except | 19:00 |
| efried | if one of the new ironic nodes has inventory in a RC we've been happily adding on at the behest of the providers.yaml | 19:00 |
| efried | then we'll blow up the compute service. | 19:00 |
| *** luksky11 has joined #openstack-nova | 19:00 | |
| dansmith | meaning if someone provides CUSTOM_IRONIC_GOLD in providers.yaml? | 19:01 |
| efried | yeah | 19:01 |
| efried | well, isn't that a trait? Not worried about traits | 19:01 |
| efried | RC is what we blow up on | 19:01 |
| dansmith | yeah, that's going to be a hard case to reason about I guess, because ironic is re-using customs | 19:01 |
| dansmith | no, it's an RC | 19:02 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Replace "integrated-gate-py3" template with new "integrated-gate-storage" https://review.opendev.org/671551 | 19:02 |
| efried | okay | 19:02 |
| dansmith | that's the whole point | 19:02 |
| dansmith | so what about this: | 19:02 |
| dansmith | if we're on init=true, we set any providers inventory that isn't already in the tree, and explode otherwise | 19:02 |
| efried | I think I can swing the "don't error if identical" thing, it's just going to be a bit tricky because I have to ignore fields (like min_unit) that weren't in the config. | 19:02 |
| dansmith | if we're init=false, we set any inventory that isn't already in the tree, but ignore/warn otherwise | 19:02 |
| *** lbragstad has quit IRC | 19:02 | |
| efried | that seems safer, anyway. | 19:03 |
| efried | could do that regardless | 19:03 |
| *** ricolin_ has joined #openstack-nova | 19:03 | |
| *** ricolin has quit IRC | 19:05 | |
| *** gibi has quit IRC | 19:15 | |
| *** _erlon_ has joined #openstack-nova | 19:23 | |
| *** gibi has joined #openstack-nova | 19:28 | |
| *** maciejjozefczyk has quit IRC | 19:31 | |
| *** whoami-rajat has quit IRC | 19:44 | |
| *** bbowen has quit IRC | 19:51 | |
| *** pcaruana has quit IRC | 20:01 | |
| *** tesseract has quit IRC | 20:05 | |
| *** mvkr_ has joined #openstack-nova | 20:05 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 20:13 |
| efried | dansmith, sean-k-mooney: ^ | 20:13 |
| *** dakshina-ilangov has joined #openstack-nova | 20:15 | |
| efried | artom: that took me a while, but reviewed (CONF.my_ip warning) | 20:27 |
| artom | efried, aha, thanks! | 20:28 |
| artom | I did feel a bit weird about taking out a warning, I mean, it was added for a reason, right? | 20:30 |
| efried | artom: I linked the reason | 20:31 |
| efried | which looks like it was a legit reason... when it was an exception. | 20:31 |
| artom | Exactly | 20:32 |
| efried | But as a warning, not sure if it's really worthwhile or not. | 20:32 |
| artom | When it turned into a warning, is it really useful? | 20:32 |
| efried | I'm not sure | 20:32 |
| efried | it depends how the cold migration failure manifests | 20:32 |
| *** eharney has quit IRC | 20:32 | |
| efried | if it's one of those things where it's really hard to figure out why it happened, unless you have this warning, then we might want to keep it around. | 20:32 |
| efried | then again, are you really going to notice this warning waaay back in the logs while you're investigating your cold mig failure. | 20:33 |
| * artom tries to see where get_host_ip_addr is used | 20:36 | |
| artom | To set migration.dest_host | 20:36 |
| artom | (Which AFAICT isn't actually used for anything) | 20:36 |
| artom | Ah, no, it's passed to migrate_disk_and_power_off | 20:36 |
| artom | And then is used in the actual cleanup catch-all Exception handler | 20:38 |
| artom | So yeah, problems | 20:38 |
| *** takashin has joined #openstack-nova | 20:49 | |
| *** dpawlik has quit IRC | 20:53 | |
| efried | nova meeting in 4 minutes in #openstack-meeting | 20:56 |
| *** priteau has quit IRC | 21:05 | |
| *** eharney has joined #openstack-nova | 21:08 | |
| *** belmoreira has joined #openstack-nova | 21:20 | |
| *** bbowen has joined #openstack-nova | 21:26 | |
| *** igordc has quit IRC | 21:27 | |
| *** igordc has joined #openstack-nova | 21:28 | |
| *** beekneemech has joined #openstack-nova | 21:38 | |
| *** beekneemech has quit IRC | 21:38 | |
| *** belmoreira has quit IRC | 21:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 21:49 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 21:49 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 21:50 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 21:50 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 21:50 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 21:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 21:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 21:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 21:52 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 21:52 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 21:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 21:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716 | 21:54 |
| *** JamesBenson has quit IRC | 22:00 | |
| *** bnemec has quit IRC | 22:03 | |
| *** alex_xu has quit IRC | 22:05 | |
| *** alex_xu has joined #openstack-nova | 22:09 | |
| *** slaweq has quit IRC | 22:09 | |
| *** bnemec has joined #openstack-nova | 22:13 | |
| *** eharney has quit IRC | 22:16 | |
| *** artom has quit IRC | 22:23 | |
| dustinc_OSCON | Anyone use any tools for reviewing local diffs before pushing other than ‘git diff’? | 22:36 |
| *** bnemec has quit IRC | 22:42 | |
| *** bnemec has joined #openstack-nova | 22:43 | |
| *** bbowen has quit IRC | 22:45 | |
| *** ivve has quit IRC | 22:54 | |
| *** luksky11 has quit IRC | 22:58 | |
| *** tkajinam has joined #openstack-nova | 22:58 | |
| *** TxGirlGeek has quit IRC | 23:01 | |
| *** TxGirlGeek has joined #openstack-nova | 23:03 | |
| *** rcernin has joined #openstack-nova | 23:15 | |
| *** artom has joined #openstack-nova | 23:16 | |
| efried | dustinc_OSCON: I have in the past, don't really anymore. Long ago I used one called beyond compare. But I don't remember whether it worked with diffs (à la git) or with two actual copies of the file, probably the latter. | 23:17 |
| efried | If I'm really having trouble seeing what I want to see via git diff, I'll actually just push the change to gerrit and review it there. | 23:18 |
| *** JamesBenson has joined #openstack-nova | 23:33 | |
| *** JamesBenson has quit IRC | 23:37 | |
| *** yaawang has quit IRC | 23:53 | |
| *** tbachman has quit IRC | 23:53 | |
| *** yaawang has joined #openstack-nova | 23:53 | |
| *** TxGirlGeek has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!