Wednesday, 2019-07-10

openstackgerritTakashi NATSUME proposed openstack/nova master: Add a live migration regression test  https://review.opendev.org/64120000:04
*** slaweq has joined #openstack-nova00:08
*** slaweq has quit IRC00:13
*** altlogbot_3 has joined #openstack-nova00:29
*** zbr has quit IRC00:34
*** altlogbot_3 has quit IRC00:37
*** zbr has joined #openstack-nova00:44
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66995800:59
*** mriedem has quit IRC00:59
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66995801:01
*** altlogbot_1 has joined #openstack-nova01:07
*** tbachman has joined #openstack-nova01:08
*** imacdonn has quit IRC01:13
*** imacdonn has joined #openstack-nova01:14
*** altlogbot_1 has quit IRC01:15
openstackgerritMerged openstack/python-novaclient master: Add irrelevant files in dsvm job again  https://review.opendev.org/66829301:20
*** gyee has quit IRC01:22
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.opendev.org/61403601:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.opendev.org/63112301:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.opendev.org/62789201:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.opendev.org/63158101:27
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.opendev.org/63385301:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63329301:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789001:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483201:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.opendev.org/63760501:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789101:27
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection  https://review.opendev.org/64218301:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method  https://review.opendev.org/64259001:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63508001:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask  https://review.opendev.org/63564601:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field  https://review.opendev.org/61403501:27
openstackgerritMatt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask  https://review.opendev.org/63566801:27
openstackgerritMatt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize()  https://review.opendev.org/63568401:27
openstackgerritMatt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.opendev.org/63622401:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration  https://review.opendev.org/66185901:27
openstackgerritMatt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event  https://review.opendev.org/65847801:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.opendev.org/63826901:27
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job  https://review.opendev.org/65665601:27
*** tetsuro has joined #openstack-nova01:47
*** lbragstad has quit IRC01:57
*** Kevin_Zheng has joined #openstack-nova02:08
*** altlogbot_0 has joined #openstack-nova02:19
*** irclogbot_3 has joined #openstack-nova02:19
openstackgerritLuyao Zhong proposed openstack/nova-specs master: update spec: virtual persistent memory  https://review.opendev.org/66997002:23
*** altlogbot_0 has quit IRC02:25
*** irclogbot_3 has quit IRC02:26
*** tkajinam has quit IRC02:29
*** tkajinam has joined #openstack-nova02:29
*** factor has quit IRC02:34
*** factor has joined #openstack-nova02:35
*** awalende has joined #openstack-nova02:36
openstackgerritBoxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule  https://review.opendev.org/64996302:38
*** awalende has quit IRC02:41
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously  https://review.opendev.org/65196902:42
*** psachin has joined #openstack-nova03:03
*** dklyle has quit IRC03:19
*** tetsuro has quit IRC03:29
openstackgerritLi Liu proposed openstack/nova master: Added Cyborg accelerator external events to Nova  https://review.opendev.org/66997503:36
*** Li_Liu has joined #openstack-nova03:41
*** tetsuro has joined #openstack-nova03:57
*** irclogbot_3 has joined #openstack-nova04:07
*** bhagyashris has joined #openstack-nova04:09
*** irclogbot_3 has quit IRC04:12
*** altlogbot_1 has joined #openstack-nova04:13
*** altlogbot_1 has quit IRC04:17
*** spatel has joined #openstack-nova04:22
*** _alastor1 has quit IRC04:25
*** udesale has joined #openstack-nova04:27
*** spatel has quit IRC04:30
*** factor has quit IRC04:36
*** whoami-rajat has joined #openstack-nova04:52
openstackgerritLuyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs  https://review.opendev.org/63454805:00
*** dannins has quit IRC05:03
*** altlogbot_2 has joined #openstack-nova05:03
*** irclogbot_2 has joined #openstack-nova05:07
*** ratailor has joined #openstack-nova05:11
*** altlogbot_2 has quit IRC05:21
*** irclogbot_2 has quit IRC05:22
*** ratailor has quit IRC05:30
*** ratailor has joined #openstack-nova05:32
*** janki has joined #openstack-nova05:33
*** pcaruana has joined #openstack-nova05:37
*** Luzi has joined #openstack-nova05:43
*** belmoreira has joined #openstack-nova05:52
*** lei-zh has joined #openstack-nova05:56
*** lei-zh has quit IRC05:58
*** lei-zh has joined #openstack-nova05:59
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously  https://review.opendev.org/65196906:05
*** rcernin has quit IRC06:10
*** rcernin has joined #openstack-nova06:11
*** pcaruana has quit IRC06:20
openstackgerritSundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs.  https://review.opendev.org/63124406:27
openstackgerritSundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML.  https://review.opendev.org/63124506:27
*** lei-zh1 has joined #openstack-nova06:29
*** lei-zh has quit IRC06:31
*** luksky11 has joined #openstack-nova06:37
*** janki has quit IRC06:40
*** dpawlik has joined #openstack-nova06:44
*** xek has joined #openstack-nova06:48
*** Dinesh_Bhor has quit IRC06:50
*** slaweq has joined #openstack-nova06:54
*** janki has joined #openstack-nova06:57
*** gokhani has joined #openstack-nova07:00
*** ivve has joined #openstack-nova07:02
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385107:03
*** altlogbot_2 has joined #openstack-nova07:03
*** rpittau|afk is now known as rpittau07:04
*** maciejjozefczyk has joined #openstack-nova07:04
openstackgerritShilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates  https://review.opendev.org/66795207:05
*** lei-zh1 has quit IRC07:05
*** lei-zh1 has joined #openstack-nova07:06
*** altlogbot_2 has quit IRC07:08
*** lei-zh has joined #openstack-nova07:08
*** awalende has joined #openstack-nova07:10
*** lei-zh1 has quit IRC07:10
*** tssurya has joined #openstack-nova07:13
openstackgerritTakashi NATSUME proposed openstack/nova master: doc: Fix a parameter of NotificationPublisher  https://review.opendev.org/66999307:18
*** kaisers has quit IRC07:24
*** ttsiouts has joined #openstack-nova07:26
*** belmoreira has quit IRC07:27
*** helenafm has joined #openstack-nova07:27
*** tetsuro has quit IRC07:30
*** ratailor has quit IRC07:36
*** kaisers has joined #openstack-nova07:36
*** ratailor has joined #openstack-nova07:37
*** ttsiouts has quit IRC07:37
*** ttsiouts has joined #openstack-nova07:38
*** brinzhang_ has joined #openstack-nova07:38
openstackgerritAlexandre arents proposed openstack/nova master: Do not update root_device_name during guest config  https://review.opendev.org/67000007:38
*** ratailor_ has joined #openstack-nova07:39
*** irclogbot_3 has joined #openstack-nova07:39
*** brinzhang has quit IRC07:41
*** ratailor has quit IRC07:41
*** ttsiouts has quit IRC07:43
*** kaisers has quit IRC07:43
*** irclogbot_3 has quit IRC07:44
*** cdent has joined #openstack-nova07:45
*** kaisers has joined #openstack-nova07:48
*** traskat has joined #openstack-nova07:52
*** ttsiouts has joined #openstack-nova07:54
*** pcaruana has joined #openstack-nova07:54
*** mkrai_ has joined #openstack-nova07:58
*** belmoreira has joined #openstack-nova07:58
*** takashin has left #openstack-nova08:00
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891208:09
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776508:09
*** umbSublime has quit IRC08:13
*** ralonsoh has joined #openstack-nova08:13
*** tkajinam has quit IRC08:14
*** umbSublime has joined #openstack-nova08:16
*** priteau has joined #openstack-nova08:18
alex_xubauzas: do we have a short race window between allocate the gpu mdev and create the domain in the libvirt https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 ?08:19
alex_xubauzas: I'm reviewing the vpmem patches, and thinking of where we should allocate the actual device08:19
*** dtantsur|afk is now known as dtantsur08:19
*** derekh has joined #openstack-nova08:20
bauzasalex_xu: AFAIK nope, because we already synchronize https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L186508:21
bauzasit calls https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1873 which eventually calls spawn() https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L225108:22
alex_xubauzas: that is for avoid mulitple action for a singple instance, but if there are multiple instances are creating at same time08:22
bauzasmmmm you're right08:24
alex_xubauzas: it is only protected by https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L641508:24
bauzasyup indeed08:24
alex_xubauzas: but there still have a small window between https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L324108:25
bauzasalex_xu: sure but we only assigned the mdev in the synchronized method08:26
bauzasthen we only define the XML08:26
bauzasso two instances would have different mdevs08:26
bauzastwo concurrent*08:26
*** mdbooth has joined #openstack-nova08:27
alex_xubauzas: but the available device is calculated by all - free, the assigned device is get by list all the libvirt domain08:28
alex_xuso both two instances get the available devices by listing existed domain in the libvirt, and may get the same dev08:28
alex_xubauzas: here is the code for populate the mdev devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L630608:29
alex_xus/all - free/all - assigned/08:29
bauzasalex_xu: oh shit you're right08:29
bauzasgiven we're defining the XML out of that semaphore, the assigned mdev couldn't be seen concurrently08:30
bauzasexcellent point08:30
bauzasalex_xu: worth shouting a patch ? or want me to do so ?08:30
alex_xubauzas: you can fix that if you want, actually I'm looking for a solution for pmem08:30
alex_xubauzas: also do we support resize for the instance with vgpu?08:31
bauzasalex_xu: I'm working on it08:32
bauzasalex_xu: I have a patch up08:32
bauzasbut I need to work on revert_resize too08:32
alex_xubauzas: where are you claim the mdev?08:32
bauzasalex_xu: first, something is missing https://review.opendev.org/#/c/589085/08:33
alex_xubauzas: that doesn't include the mdev claim08:34
alex_xuso I'm thinking whether we should manage those device in the resource tracker instead of virt driver08:34
alex_xus/manage those device/tracking those resource/08:34
bauzassorry in meeting08:36
alex_xubauzas: no worries, catch up you later08:37
*** janki has quit IRC08:43
*** janki has joined #openstack-nova08:51
*** helenafm has quit IRC08:53
*** irclogbot_3 has joined #openstack-nova08:57
*** helenafm has joined #openstack-nova08:58
*** irclogbot_3 has quit IRC09:02
*** ccamacho has joined #openstack-nova09:03
*** janki has quit IRC09:07
bauzasalex_xu: I'm back09:07
bauzasalex_xu: so, we don't technically claim mdevs09:08
bauzasalex_xu: as we do with PCI devices09:08
openstackgerrithuanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration  https://review.opendev.org/67001609:08
*** ociuhandu has joined #openstack-nova09:09
*** janki has joined #openstack-nova09:09
*** belmoreira has quit IRC09:12
*** altlogbot_0 has joined #openstack-nova09:12
*** altlogbot_0 has quit IRC09:14
*** rcernin has quit IRC09:17
openstackgerrithuanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration  https://review.opendev.org/67001609:18
*** lei-zh has quit IRC09:25
*** altlogbot_0 has joined #openstack-nova09:26
*** altlogbot_0 has quit IRC09:28
*** belmoreira has joined #openstack-nova09:28
*** altlogbot_1 has joined #openstack-nova09:29
*** belmoreira has quit IRC09:29
*** priteau has quit IRC09:30
*** belmoreira has joined #openstack-nova09:30
*** lei-zh has joined #openstack-nova09:31
*** altlogbot_1 has quit IRC09:34
openstackgerritMerged openstack/nova master: doc: Fix a parameter of NotificationPublisher  https://review.opendev.org/66999309:35
*** irclogbot_1 has joined #openstack-nova09:38
*** mdbooth has quit IRC09:39
*** mdbooth has joined #openstack-nova09:40
*** irclogbot_1 has quit IRC09:40
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace  https://review.opendev.org/63454909:44
*** altlogbot_3 has joined #openstack-nova09:45
*** altlogbot_3 has quit IRC09:50
alex_xubauzas: yes, mdevs needn't claim, you can free to choice any one of free mdevs09:58
alex_xubauzas: vpmem needs the claim, since we need to copy the vpmem data to the destination vpmem09:59
openstackgerritQiu Fossen proposed openstack/nova master: Correct  project/user id descriptions with nova-server-actions  https://review.opendev.org/67002710:08
*** mkrai_ has quit IRC10:17
*** belmoreira has quit IRC10:20
*** IvensZambrano has joined #openstack-nova10:20
*** irclogbot_1 has joined #openstack-nova10:23
*** irclogbot_1 has quit IRC10:26
*** artom has quit IRC10:27
*** lei-zh has quit IRC10:30
*** lei-zh has joined #openstack-nova10:30
*** ttsiouts has quit IRC10:33
*** ttsiouts has joined #openstack-nova10:34
*** mdbooth has quit IRC10:35
*** mdbooth has joined #openstack-nova10:35
*** lei-zh has quit IRC10:35
*** ttsiouts has quit IRC10:38
*** shilpasd has quit IRC10:38
*** helenafm has quit IRC10:40
*** helenafm has joined #openstack-nova10:43
*** helenafm has quit IRC10:53
*** helenafm has joined #openstack-nova10:55
*** janki has quit IRC10:55
*** bhagyashris has quit IRC10:55
*** belmoreira has joined #openstack-nova10:56
*** mdbooth has quit IRC11:06
*** ttsiouts has joined #openstack-nova11:07
*** tesseract has joined #openstack-nova11:08
*** mdbooth has joined #openstack-nova11:13
*** mkrai_ has joined #openstack-nova11:15
*** francoisp has quit IRC11:25
*** francoisp has joined #openstack-nova11:27
openstackgerritChris Dent proposed openstack/nova master: WIP: Add conf to not update to placement during instance_claim  https://review.opendev.org/67004111:36
*** mdbooth_ has joined #openstack-nova11:45
*** mdbooth has quit IRC11:49
*** mdbooth_ has quit IRC11:51
*** udesale has quit IRC11:51
*** udesale has joined #openstack-nova11:52
*** mdbooth has joined #openstack-nova11:59
openstackgerrithuanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration  https://review.opendev.org/67001611:59
*** tbachman has quit IRC12:01
*** mdbooth_ has joined #openstack-nova12:01
*** mdbooth has quit IRC12:04
*** mdbooth_ has quit IRC12:06
*** ratailor_ has quit IRC12:07
*** belmoreira has quit IRC12:17
*** belmoreira has joined #openstack-nova12:21
*** spatel has joined #openstack-nova12:23
*** spatel has quit IRC12:23
*** mchlumsky has joined #openstack-nova12:33
*** artom has joined #openstack-nova12:34
*** eharney has joined #openstack-nova12:37
*** mchlumsky has quit IRC12:47
*** priteau has joined #openstack-nova12:47
*** mdbooth has joined #openstack-nova12:48
openstackgerritBalazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none'  https://review.opendev.org/65779612:48
*** mchlumsky has joined #openstack-nova12:49
*** belmoreira has quit IRC12:54
*** mdbooth_ has joined #openstack-nova12:56
*** mdbooth_ has quit IRC12:56
*** irclogbot_1 has joined #openstack-nova13:07
*** irclogbot_1 has quit IRC13:08
*** altlogbot_1 has joined #openstack-nova13:11
*** spatel has joined #openstack-nova13:14
*** lbragstad has joined #openstack-nova13:16
*** altlogbot_1 has quit IRC13:16
*** irclogbot_3 has joined #openstack-nova13:17
*** belmoreira has joined #openstack-nova13:18
*** tbachman has joined #openstack-nova13:18
*** irclogbot_3 has quit IRC13:22
*** _alastor1 has joined #openstack-nova13:22
openstackgerritEric Fried proposed openstack/nova master: Make sure update resource usage when revert_resize  https://review.opendev.org/66513813:26
*** mkrai_ has quit IRC13:28
*** mriedem has joined #openstack-nova13:31
*** belmoreira has quit IRC13:32
*** belmoreira has joined #openstack-nova13:33
*** belmoreira has quit IRC13:41
*** belmoreira has joined #openstack-nova13:45
sean-k-mooneymriedem: mind if i push a slightly modified version of your coverage patch13:49
sean-k-mooneyi have a version that mostly works13:49
openstackgerritTakashi NATSUME proposed openstack/nova stable/stein: doc: Fix a parameter of NotificationPublisher  https://review.opendev.org/67006413:50
sean-k-mooneywe only get an extra 2% form the functional test by the way13:50
sean-k-mooneyTOTAL                                                                                                   82128   5924  24452   2240    91%13:50
yonglihesean-k-mooney, thanks for the review.  For a instance is deleted, checking the states is not reliable at least for test case it's not correct.  The instance.Destroy action call DB delete, which then make the instance.id attr gone. Instance.id not exist means the instance is  'deleted'.13:51
sean-k-mooneyyonglihe: your current code can delete active instnces13:51
yonglihethat what i'm talking about.13:52
yonglihehttps://www.irccloud.com/pastebin/BSYfEoER/13:52
yonglihe "not instance.obj_attr_is_set('id')" means instance is deleted.13:52
mriedemsean-k-mooney: sure13:53
sean-k-mooneyyonglihe: im not sure that is correct13:53
mriedemsean-k-mooney: btw i meant to split that out to do some of the cleanup stuff separately and only try to merge the functional tests in at the end13:53
mriedemsean-k-mooney: i can do that split after you update it13:53
mriedemi basically wanted to fire and forget yesterday13:53
*** whoami-rajat has quit IRC13:54
sean-k-mooneywell this is actully the diff i was going to push http://paste.openstack.org/show/754262/13:54
*** _alastor1 has quit IRC13:54
*** whoami-rajat has joined #openstack-nova13:54
sean-k-mooneywe cant remove the python hack entirely as running stestr on its own does not record any coverage info13:55
sean-k-mooneythe -p groups parrallel test by class13:55
sean-k-mooneythis gets rid of almost all the mocking issues13:55
sean-k-mooneyi have only 4 failing tests with that13:56
mriedemgo ahead and push it13:56
*** BjoernT has joined #openstack-nova13:56
cdentshouldn't we not mask the mocking problems, and fix them instead?13:56
sean-k-mooneysure will do13:56
*** shilpasd has joined #openstack-nova13:56
mriedemi'm doing stable release reviews while tony is on vacation....13:56
mriedemso i'm going to be stuck for awhile13:56
yonglihesean-k-mooney, check this line: https://github.com/openstack/nova/blob/de31466fdb09dd367b23660f71b4ca06f83271a2/nova/objects/instance.py#L61113:56
sean-k-mooneycdent: we should but it proably better to do that after getting the test running13:56
yongliheI'm not sure either.13:56
yongliheseems correct.13:56
cdentsean-k-mooney: i was assuming that the test failing was the only way of identifying the failures. tdd and all that13:57
*** mdbooth has quit IRC13:57
*** mkrai_ has joined #openstack-nova13:57
sean-k-mooney cdent we can remove the -p to get them to fail again in the patch that fixes them13:57
cdentor we will just ignore it for a few more years :)13:58
sean-k-mooneywell if its not broke...13:58
*** mdbooth has joined #openstack-nova13:58
cdentwould love to continue talking about this, but unfortunately must head ot appt13:58
aarentsHi there, it will be great if someone can have a look to this reproducible bug and related fix: https://review.opendev.org/#/c/67000013:59
yonglihefake-db does had this behavior for deleted instance, and i also saw while deleted, we save instance.id to instance.delete filed.13:59
sean-k-mooneythere is a test isolation analasys flag in stestr to figure out what test cause issues13:59
sean-k-mooneyso im hoping i can just let that run and get a list of the broken tests13:59
*** cdent has quit IRC14:00
yonglihesean-k-mooney: I did not got time to test that on machine. I gonna do smoke test tomorrow to make sure it won't delete active instance.  Other comments seems reasonable and good, thanks.14:01
sean-k-mooneyok i didnt run it locally to test. but that was the main reason for the -114:03
yongliheand here is another wired thing i running into. for the unit test14:03
yonglihehttps://www.irccloud.com/pastebin/Fep61BPV/14:03
yonglihethe assert_calls say  'Calls not found.'14:04
*** dklyle has joined #openstack-nova14:04
sean-k-mooneyby the way an instance not having id set does not mean its deleted it means it has not be created in the db14:04
yonglihebut the instance in expect and actual actually just same (but might had wrong order).14:05
sean-k-mooneyor nolonger exists in the db14:05
yonglihesean-k-mooney:  Is it possible only database know what is deleted? and we can not get that information from the instance ?14:06
sean-k-mooneyanyway that sinip is a little hard to read but you can proably do an order independ check if that is not important14:06
yonglihesean-k-mooney : i don't find one to ignore the order.14:07
sean-k-mooneyyou would have to write it. just asser the call object is in the mock.calls array14:07
sean-k-mooneybut you would have to construct a mock call object to do that14:08
yonglihereplace wiht  assert_called_with also does not work,  assert_called_with still checking the order, that's so wired for me.14:08
sean-k-mooneynormally we want the order to be checked14:08
sean-k-mooneywe have some examples of doing order independ dict comparisons i think14:09
yongliheseems i had to assert the call is in that array.14:09
sean-k-mooneyhttps://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls14:10
yongliheI would like  to find the example, that's should work.  but checking if instance is deleted seems hard? any other condition i can check?14:10
sean-k-mooneyyou can do mock.assert_has_calls(calls, any_order=True)14:11
yonglihesean-k-mooney: thanks, got it.14:11
*** ttsiouts has quit IRC14:11
*** ttsiouts has joined #openstack-nova14:12
sean-k-mooneyif you use assert_has_calls you have to create teh mock calls manually like this https://github.com/openstack/nova/blob/de31466fdb09dd367b23660f71b4ca06f83271a2/nova/tests/unit/utils.py#L323-L33614:12
sean-k-mooneyhere are some example you can follow https://github.com/openstack/nova/search?q=assert_has_calls+any_order%3DTrue&unscoped_q=assert_has_calls+any_order%3DTrue14:14
*** ttsiouts has quit IRC14:16
yonglihethanks. for the 'delete' states, i think the 'deleted_at' filed been set seems could filter out the instance is creating at that moment.14:17
*** jdillaman has joined #openstack-nova14:18
yonglihe'no id attr' and  'deleted_at' is set before now.14:18
sean-k-mooneyperhap but again i would use the instance status personally unless you have an example where that does not work14:18
*** awalende has quit IRC14:19
yonglihenot work in the unite test, that's why i checking other stuff. but the unit test just call the destroy, not set the states right.14:19
*** awalende has joined #openstack-nova14:20
sean-k-mooneyyonglihe: then why not fix the unit tests14:20
sean-k-mooneyanyway ill leave it up to you14:20
yongliheSure.  do we need checking other stuff if we depend on he vm_state filed?14:21
sean-k-mooneyleave a comment in the next version based on your testing14:21
yongliheSure.14:21
sean-k-mooneye.g. why you are doing whatever test you come up with14:21
*** ttsiouts has joined #openstack-nova14:22
sean-k-mooneyim not sure but i need to go work on somehting before a meeting soon14:23
yongliheI gonna to verify if that code working on real stack. thanks. I got to run also.14:23
sean-k-mooneyi think the task state + checking for soft delete would be enough14:23
yongliheOk , i gonna checking  that,14:23
yongliheHave a good day.14:24
*** awalende has quit IRC14:24
*** dklyle has quit IRC14:30
sean-k-mooneyjohnthetubaguy: by the way i -1 the unifed limits spec but if just declare the discoverablity as out of scope to be resolved in a futrue version of the sdk or in a follow up spec then im fine to swap to +1 on that spec14:32
sean-k-mooneyonce the nits inline are adressed that is14:32
*** mkrai_ has quit IRC14:32
johnthetubaguysean-k-mooney: cool, I will respin14:33
*** mkrai_ has joined #openstack-nova14:33
sean-k-mooneyis it safe to assume that the keysone limits api wont have limits for compute resouces if we have not enabled it for nova14:34
sean-k-mooneyif so the sdk could check that once an cache it or something like that to determin if it should use keystone limits or nova14:35
sean-k-mooneyso the actully check would be. 1.) is keystone version new enough to support limtis 2.) are instance limits reported in keysonte limits api,  if yes to both use keystone if the either are false use nova14:36
*** dpawlik has quit IRC14:37
sean-k-mooneyjohnthetubaguy: would somthing like ^ work14:37
*** Luzi has quit IRC14:38
*** belmoreira has quit IRC14:38
*** dklyle has joined #openstack-nova14:38
johnthetubaguysean-k-mooney: Its not a smooth transition that way... nova might still be ignoring keystone, but it might be good enough (assuming default keystone policy means you can list the limits of your project)14:40
*** altlogbot_0 has joined #openstack-nova14:40
johnthetubaguyit gets worse with hierarchy mind, as everything seems to14:40
sean-k-mooneywell we dont need to encode that in the spec i was just wondering if there was a huristic the sdk could resonably use14:41
*** altlogbot_0 has quit IRC14:42
sean-k-mooneyit could be as simple as stick it in a config option for now14:42
*** belmoreira has joined #openstack-nova14:43
sean-k-mooneythe clouds.yaml has profiles for clouds that encode there knonw behavior for non discoverable things14:43
sean-k-mooneyso that is always an option for limits14:43
sean-k-mooneyat least i think nodepool gets that stuff from clouds.yaml for the sdk14:44
*** awalende has joined #openstack-nova14:48
*** altlogbot_2 has joined #openstack-nova14:52
openstackgerritDakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file  https://review.opendev.org/61249714:52
*** awalende has quit IRC14:53
*** altlogbot_2 has quit IRC14:56
spatelsean-k-mooney: did you ever see this error http://paste.openstack.org/show/754267/14:59
*** Roamer` has joined #openstack-nova15:00
*** _alastor1 has joined #openstack-nova15:02
*** mdbooth has quit IRC15:05
*** mdbooth has joined #openstack-nova15:05
stephenfinjohnthetubaguy: Seeing as you've been reviewing docs, could you have a look at https://review.opendev.org/#/c/667164/ ?15:07
johnthetubaguystephenfin: sure15:07
*** _alastor1 has quit IRC15:07
*** altlogbot_3 has joined #openstack-nova15:08
*** dklyle has quit IRC15:09
*** altlogbot_3 has quit IRC15:12
openstackgerritJohn Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec  https://review.opendev.org/60220115:15
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils'  https://review.opendev.org/66250115:15
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects  https://review.opendev.org/66250215:15
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController  https://review.opendev.org/66250315:15
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils  https://review.opendev.org/66250415:15
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers  https://review.opendev.org/66250515:15
openstackgerritStephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware  https://review.opendev.org/66250615:15
*** mkrai_ has quit IRC15:17
*** mkrai_ has joined #openstack-nova15:18
openstackgerritStephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups  https://review.opendev.org/66663015:19
openstackgerritStephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another  https://review.opendev.org/66663115:19
openstackgerritStephen Finucane proposed openstack/nova master: vif: Remove dead minimum libvirt checks  https://review.opendev.org/66681415:19
*** maciejjozefczyk has quit IRC15:19
*** irclogbot_0 has joined #openstack-nova15:20
Nick_AWe are trying to offload the _base nova image cache using cephfs. our idea was to do a read-only mirror of glance's image pool and mount that to _base on compute. Would nova have problems with that setup?15:20
*** tbachman has quit IRC15:20
openstackgerritMerged openstack/nova master: Perf: Use dicts for ProviderTree roots  https://review.opendev.org/63722515:21
openstackgerritStephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities  https://review.opendev.org/63103815:21
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Split '_get_host_numa_topology' function  https://review.opendev.org/63123715:21
openstackgerritStephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware  https://review.opendev.org/63105315:21
openstackgerritShilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates  https://review.opendev.org/66795215:22
*** irclogbot_0 has quit IRC15:22
*** boxiang has joined #openstack-nova15:24
*** boxiang has quit IRC15:25
openstackgerritStephen Finucane proposed openstack/nova stable/stein: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67009615:25
openstackgerritStephen Finucane proposed openstack/nova stable/rocky: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67009715:26
*** boxiang has joined #openstack-nova15:26
openstackgerritStephen Finucane proposed openstack/nova stable/stein: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67009615:28
openstackgerritStephen Finucane proposed openstack/nova stable/rocky: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67009715:28
openstackgerritStephen Finucane proposed openstack/nova stable/queens: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/67010015:29
*** mkrai_ has quit IRC15:30
*** mkrai__ has joined #openstack-nova15:30
*** altlogbot_1 has joined #openstack-nova15:32
*** BjoernT_ has joined #openstack-nova15:33
*** altlogbot_1 has quit IRC15:34
*** ivve has quit IRC15:34
mriedemstephenfin: i see https://review.opendev.org/#/c/667164/2 is already approved and you've started backports, but some issues inline15:35
stephenfinlooking15:35
*** BjoernT has quit IRC15:36
openstackgerritsean mooney proposed openstack/nova master: WIP: coverage job changes  https://review.opendev.org/66991215:36
*** BjoernT has joined #openstack-nova15:36
stephenfinmriedem: Those all look fair. Want me to pull it out of the gate and address those?15:36
mriedemthat would be nice yes15:37
artomThere's a thing to re-run just the tests that failed in the last run... right?15:37
mriedemartom: not in the gate15:37
mriedemlocally,15:37
artommriedem, locally15:37
mriedemtox -e <whatever> -- --failing15:37
artommriedem++15:37
*** BjoernT_ has quit IRC15:38
openstackgerritStephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716415:38
stephenfinmriedem: 'openstack quota list --compute' won't show the _default_ quotas though, will it?15:40
stephenfin(RE: https://review.opendev.org/#/c/667164/2/doc/source/admin/quotas.rst@68)15:40
mriedemstephenfin: honestly i don't know how that command works under the covers,15:41
mriedem"default" doesn't really mean anything for the compute API if you're not looking at the default class15:41
mriedemneutron has an api to see 'defaults'15:41
mriedembut i don't think cinder does and nova doesn't besides the class15:41
*** mkrai__ has quit IRC15:42
stephenfinlooks like 'quota list' is no good to us15:43
stephenfin"List quotas for all projects with non-default quota values or list detailed15:43
stephenfinquota informations for requested project"15:43
stephenfinI'll add a note that there are non-compute quotas mixed in there15:44
*** _alastor1 has joined #openstack-nova15:46
mriedemyeah this feels like a wild goose chase15:48
mriedemsorting out the clis and docs is a mess15:48
openstackgerritsean mooney proposed openstack/nova master: WIP: coverage job changes  https://review.opendev.org/66991215:50
*** _alastor1 has quit IRC15:51
*** mlavalle has joined #openstack-nova15:55
*** altlogbot_0 has joined #openstack-nova15:56
*** tbachman has joined #openstack-nova15:58
*** altlogbot_0 has quit IRC15:58
*** mdbooth has quit IRC15:58
openstackgerritStephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716415:59
stephenfinmriedem: ^ addressed what I could of them15:59
mriedemack16:00
spatelsean-k-mooney: nevermind after reload rabbitmq cluster it fixed issue.16:00
*** _erlon_ has joined #openstack-nova16:00
*** helenafm has quit IRC16:01
*** udesale has quit IRC16:01
sean-k-mooneyspatel: sorry i was on a call earlier but yes we have seen that before16:02
sean-k-mooneyrestarting rabbit or the compute agged typicaly fixes it16:03
spatelsame here16:03
sean-k-mooneyits related to how oslo.messaging handels retrasmits and connection issue but i think they are trying to fix it16:04
sean-k-mooneyits not really a nova issue as we dont actuly handel creating the queue/exchanges16:04
sean-k-mooneythat is all done use by oslo.messaging16:05
*** ttsiouts has quit IRC16:05
*** mkrai__ has joined #openstack-nova16:05
*** thgcorrea_ has joined #openstack-nova16:06
*** ttsiouts has joined #openstack-nova16:06
*** tssurya has quit IRC16:09
*** ttsiouts has quit IRC16:10
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Add a placement audit command  https://review.opendev.org/67011216:14
*** gyee has joined #openstack-nova16:16
*** mkrai__ has quit IRC16:23
*** belmoreira has quit IRC16:26
*** psachin has quit IRC16:26
sean-k-mooneyalex_xu: efried thanks for your input on https://review.opendev.org/#/c/662264/. I have abandoned it for train so we can focus on similar uses of placements new feature in train and come back to cache in U16:31
sean-k-mooneyif im working on that again in U ill propose a placmeent native version that may pull some of the provider yaml stuff it that makes progress16:32
openstackgerritStephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716416:40
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation  https://review.opendev.org/66716516:40
openstackgerritStephen Finucane proposed openstack/nova master: docs: Scrub available quotas  https://review.opendev.org/67012516:40
*** factor has joined #openstack-nova16:41
openstackgerritStephen Finucane proposed openstack/nova master: docs: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716416:42
openstackgerritStephen Finucane proposed openstack/nova master: docs: Scrub available quotas  https://review.opendev.org/67012516:42
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation  https://review.opendev.org/66716516:42
*** Sundar has joined #openstack-nova16:46
openstackgerritMerged openstack/nova master: db: Add vpmems to instance_extra  https://review.opendev.org/66269716:48
*** altlogbot_1 has joined #openstack-nova16:49
*** ricolin has quit IRC16:52
*** _alastor1 has joined #openstack-nova16:54
*** altlogbot_1 has quit IRC16:54
*** dtantsur is now known as dtantsur|afk16:57
*** IvensZambrano has quit IRC16:57
SundarHello gibi, Could you look at https://review.opendev.org/657464 ? I understand it merited a -1 earlier, but I think we have resolved the naming issues in the Cyborg-Nova spec. Thanks.16:59
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717716:59
openstackgerritArtom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration()  https://review.opendev.org/66863116:59
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events  https://review.opendev.org/66444216:59
*** derekh has quit IRC17:01
stephenfinmriedem, melwitt: If we removed the injected_files, injected_file_content_bytes and injected_file_path_bytes quotas in API v2.57, does that mean the conf options in '[quotas]' should have a note saying the quotas aren't used anymore or something?17:06
openstackgerritMerged openstack/nova master: Remove 'nova.virt.libvirt.compat'  https://review.opendev.org/66912017:06
stephenfinI'm not grasping whether those quotas actually do anything any more and, if so, what's enforcing it17:07
sean-k-mooneystephenfin: i think we still need them since we still support it for older microversions17:16
sean-k-mooneyfile injection itself is deprecated but you can still use it if you drop back too older microverions17:17
*** rpittau is now known as rpittau|afk17:23
*** rouk has joined #openstack-nova17:24
openstackgerritMerged openstack/nova master: libvirt: Remove unreachable native QEMU iSCSI initiator config code  https://review.opendev.org/66875017:32
*** BjoernT has quit IRC17:41
*** dpawlik has joined #openstack-nova17:47
*** shilpasd has quit IRC17:49
openstackgerritDakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file  https://review.opendev.org/61249717:50
*** ociuhandu has quit IRC17:53
openstackgerritDakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file  https://review.opendev.org/61249718:00
*** irclogbot_1 has joined #openstack-nova18:06
*** belmoreira has joined #openstack-nova18:07
*** irclogbot_1 has quit IRC18:08
*** tbachman has quit IRC18:09
mriedemstephenfin: what sean-k-mooney said18:11
*** hemna has quit IRC18:11
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim()  https://review.opendev.org/63566918:12
openstackgerritArtom Lifshitz proposed openstack/nova master: New objects for NUMA live migration  https://review.opendev.org/63482718:12
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source  https://review.opendev.org/63482818:12
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source  https://review.opendev.org/63522918:12
openstackgerritArtom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration  https://review.opendev.org/63460518:12
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA live migration support  https://review.opendev.org/63460618:13
openstackgerritArtom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration  https://review.opendev.org/64002118:13
*** Sundar has quit IRC18:14
*** hongbin has joined #openstack-nova18:18
*** tbachman has joined #openstack-nova18:23
sean-k-mooneysomeday we will have v4 api after the go rewite and then we can drop 2.1 api support18:26
*** xek has quit IRC18:35
*** xek has joined #openstack-nova18:36
*** hemna has joined #openstack-nova18:44
mriedemefried: i'm guessing you want to backport this right? https://review.opendev.org/#/c/637225/18:46
mriedemto at least rocky18:46
*** belmoreira has quit IRC18:48
mriedemlyarwood: fyi in case you never saw this https://bugs.launchpad.net/devstack-plugin-ceph/+bug/183562718:48
openstackLaunchpad bug 1835627 in devstack-plugin-ceph "test_shelve_unshelve_server failing on stable/pike (and probably ocata)" [Undecided,Confirmed]18:48
*** boxiang has quit IRC18:57
*** boxiang has joined #openstack-nova18:57
*** belmoreira has joined #openstack-nova18:58
*** zhubx has joined #openstack-nova18:59
*** priteau has quit IRC18:59
*** boxiang has quit IRC19:01
*** altlogbot_2 has joined #openstack-nova19:02
*** ralonsoh has quit IRC19:03
*** altlogbot_2 has quit IRC19:04
*** thgcorrea_ has quit IRC19:04
*** BjoernT has joined #openstack-nova19:11
*** tesseract has quit IRC19:16
*** elod has quit IRC19:16
*** elod has joined #openstack-nova19:18
*** ivve has joined #openstack-nova19:18
*** belmoreira has quit IRC19:19
*** irclogbot_3 has joined #openstack-nova19:20
*** eharney has quit IRC19:21
*** irclogbot_3 has quit IRC19:22
*** whoami-rajat has quit IRC19:24
dansmithefried: normally I'd like to see the top of a series be nearly ready to go before we merge a db migration for it: https://review.opendev.org/#/c/662697/19:26
dansmithI know you didn't +W, but, just my opinion19:26
efrieddansmith: I saw that go by and thought of you.19:29
efriedI considered -2ing for that reason, but then... didn't.19:29
efriedmriedem: yes, I would like to backport https://review.opendev.org/#/c/637225/19:30
dansmithI would have liked a different column name at least, but alas I missed my slot19:30
efriedsean-k-mooney: ack. What would be super awesome is if those efforts were sunk into getting us closer to NUMA modeling in placement. The nested magic stuff has merged.19:30
efrieddansmith: is it too late to correct it? We don't actually need to support mid-stream commit levels, do we?19:31
dansmithuh, we do, and it's too late really19:31
dansmithwe could migrate the migration, but it's not worth it for that19:32
dansmithbut yes, we've always supported deploying any commit.. the sins that come from dropping that expectation are really bad19:32
efriedokay19:32
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66995819:42
*** belmoreira has joined #openstack-nova19:43
efrieddansmith: I appreciate you looking at that vpmem series though. I look at the object stuff and all I can do is compare it to existing things - I don't really understand it.19:43
efriedbtw, the conf thing isn't there because I asked them to put that last, as it's the "master switch" that makes the admin think something should work. Probably some additional refactoring would be appropriate so we're not referencing the conf option before we introduce it.19:44
mriedemis that the thing that starts exposing the inventory?19:44
*** belmoreira has quit IRC19:45
mriedemhopefully they have pretty robust functional testing before that - which you should be able to do with stubs or something w/o the config option19:45
dansmithefried: putting the config option after code that uses it is backwards19:45
mriedemwe've done something like that before to keep a series moving before exposing it in the api,19:46
dansmithbut not actually referencing a non-existent config option19:46
mriedemgibi's bw stuff in stein did something like that19:46
mriedemyeah19:46
mriedemmy cross-cell resize stuff does something like that with the new policy rule - stubs a compute api method way earlier in the series to make functional testing possible before the api actually supports cross-cell resize19:47
dansmithwrap the check in a is_thing_enabled() method and patch that in your tests or something19:47
mriedemyup that's what both gibi and i did19:47
dansmithyeah19:47
dansmithi this case,19:48
dansmithhowever,19:48
mriedemhttps://review.opendev.org/#/c/636253/36/nova/tests/functional/test_cross_cell_migrate.py@6519:48
dansmiththe config thing is a complex encoded structure in a string list,19:48
dansmithwhich doesn't lend itself to that pattern quite as well19:48
mriedemmmm delicious pci whitelist offspring19:49
dansmithmaybe have the helper return the contents, and then later have it get the value from config and parse it or something19:49
mriedemthat would lend itself to easier functional testing as well - just stub the helper to return whatever config you are testing19:49
dansmithbut putting the parsing in a part of the code that complains about the format not being adhered to, well in advance of the patch that introduces the config option and doc is kinda silly19:49
dansmithright19:49
*** openstackgerrit has quit IRC19:49
efriedyup, agreed19:50
dansmithto be clear, that thing should not just return the string(s), but do the god-awful parsing of the : and | tokens and return a structure19:50
*** openstackgerrit has joined #openstack-nova19:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.opendev.org/61403619:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.opendev.org/63112319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.opendev.org/62789219:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.opendev.org/63158119:51
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.opendev.org/63385319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63329319:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789019:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483219:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.opendev.org/63760519:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789119:51
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection  https://review.opendev.org/64218319:51
dansmithand I'd like to see that whole stack ready to go at merge time,19:51
dansmithnot merging dead code in the driver well in advance of the later patch19:51
mriedemdansmith: i lost your +2 on https://review.opendev.org/#/c/631123/because of the db migration19:52
dansmithI didn't walk up the set any further because it has a bunch of merged or abandoned patches in the middle19:52
dansmithso probably needs a good restacking19:52
dansmithmriedem: maybe you'll be more careful with this one19:53
mriedem?19:53
dansmithyou lost the last one I gave you19:53
mriedemi'm pretty sure this is the last time i have to rebase this series19:54
*** factor has quit IRC19:55
efriedDo we cover revert_resize in any of our CI jobs?19:56
mriedemyes19:57
mriedemdefinitely single node, the trickier is multi-node coverage19:57
efriedI'm looking at https://review.opendev.org/#/c/665138/ and not finding out a way to tell whether it's doing... anything at all.19:58
mriedemhttp://logs.openstack.org/39/669539/1/check/tempest-full-py3/1555a09/job-output.txt.gz#_2019-07-05_22_24_52_92686919:58
artomefried, you stay away from that stuff. Run, I tell you. RUN!19:58
artomefried, you could try using https://review.opendev.org/#/c/664442/ somehow19:59
sean-k-mooneyefried: for what its worth i have poposed that we dont backfil the libvirt pos feature and instead use any bandwith it frees up to work on things like numa in placment or novas use of placement in general19:59
efriedsean-k-mooney: proposed internally at RH you mean?19:59
sean-k-mooneyya19:59
efriedthat's wonderful.20:00
efriedI would really like to see us focus on moving forward that way rather than adding to the burden of stuff that helps us stay where we are.20:00
sean-k-mooneywe will see if that helps or not but my intent at least is to finish off the work i have started and then see what time is left in the cycle20:00
mriedemefried: the tempest-slow job has a cold migration test that is doing revert resize but it's skipped http://logs.openstack.org/39/669539/1/check/tempest-slow-py3/cd3cb0e/job-output.txt.gz#_2019-07-05_22_44_58_146668 until sean-k-mooney/artom's fix lands...20:00
mriedemso a catch-2220:00
mriedemhttps://review.opendev.org/#/c/663405/20:01
sean-k-mooneymriedem: dansmith merged your change to add teh iptables job to the experimenatl pipline right so that can be used for testing revert for now20:02
mriedembut yeah https://review.opendev.org/#/c/664442/ is the canary20:02
mriedemsean-k-mooney: oh yeah that's right20:02
artomsean-k-mooney, I thought that was single node?20:02
mriedemsee? there are only like 5 need-to-know manual on-demand things20:02
artom(That being the reason it failed - we didn't test same host revert with OVS hybrid plug)20:03
mriedemartom: it is20:03
mriedemso neutron-tempest-iptables_hybrid tests ovs hybrid plug same-host resize,20:03
mriedemtempest-slow (will eventually) test multi-node revert20:03
mriedembut not ovs hybrid plug20:03
artomWe have same-host resize in tempest-full-py3 too, no?20:04
mriedemand tempest-full tests non-hybrid plug same host resize revert20:04
efriedSo I could update https://review.opendev.org/#/c/665138/ to depend-on https://review.opendev.org/#/c/664442/ and that would tell me... what?20:04
artomjynx20:04
mriedemyes, but not ovs hybrid plug20:04
mriedemand single node20:04
sean-k-mooneyartom: the iptables one is singel node yes20:04
artomMy brain is leaking20:04
efriedI'm probably too dense today to understand it anyway; maybe I'll just push it to the back of the queue again until I'm feeling sharp.20:04
mriedemand the dnm patch at the top of the series for multi-node ovs hybrid plug=true20:04
sean-k-mooneyso same host resize revert can be tested which is basically cold migrate20:04
mriedemefried: you're likely best leaving it to me and dansmith at this point20:04
efriedokay20:05
dansmithsave. yourself.20:05
mriedemsean-k-mooney: .... we don't test same-host cold migration in the gate20:05
sean-k-mooneytechnically we might allow same host "migrate" too but never bothered to try that20:05
artomdansmith, that's what I said!20:05
mriedemb/c the libvirt driver doesn't support that20:05
mriedemsean-k-mooney: only the vcenter driver allows that20:05
artomBut noooo, we need "quality" and for things to "work"20:05
sean-k-mooneymriedem: well same host cold migrate isnt really useful20:05
sean-k-mooneywait they allow it because its a clustered hypervior20:05
mriedemyes20:05
sean-k-mooneyso im guessing its not really the same host right20:05
sean-k-mooneyat least internally20:06
mriedemdifferent esxi host20:06
sean-k-mooneyright of course it is20:06
mriedemsame nova-compute service host20:06
mriedemwonder if i could get some questions onto the openstack COA exam20:06
*** factor has joined #openstack-nova20:06
*** zhubx has quit IRC20:07
mriedem"what is a compute node?" BZZZT!20:07
*** zhubx has joined #openstack-nova20:07
sean-k-mooneywhen is disk_available_least bigger then free_gb20:08
efrieda) the same as a compute host20:08
efriedb) the physical system on which the nova-compute service runs20:08
efriedc) an ironic instance20:08
efriedd) all of the above20:08
dansmithplease, you guys are depressing me20:09
efried(btw, I would totally fail that question)20:09
efriedmriedem: backporting...20:11
openstackgerritEric Fried proposed openstack/nova stable/stein: Perf: Use dicts for ProviderTree roots  https://review.opendev.org/67017920:11
efriedI think the rocky backport is going to be dirty, because the mdev stuff I "fixed" wasn't there yet.20:12
efriedyup20:12
efriedoh, worse than that20:14
*** ivve has quit IRC20:14
mriedemunrelated, but while looking at ironic n-cpu job logs for that change on master, i see we hit a provider inventory conflict and we must refresh and re-push and it works20:15
mriedemhttp://logs.openstack.org/25/637225/2/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/fee37e3/controller/logs/screen-n-cpu.txt.gz#_Jul_10_00_32_51_41364020:15
mriedemb/c the reserved value changed on the node20:15
mriedemonly question is, does that 409 need to be an error if we're going to refresh associations and try again?20:15
mriedemlike, "ERROR! .... oh nvm i've got this."20:16
efriedit's the kind of thing where we would sure want the last one (when we give up retrying) to be an error.20:17
efriedbut yeah, that one could certainly be warning or even info20:17
*** zhubx has quit IRC20:18
*** zhubx has joined #openstack-nova20:19
openstackgerritEric Fried proposed openstack/nova stable/rocky: Perf: Use dicts for ProviderTree roots  https://review.opendev.org/67018220:22
efriedmriedem: ^20:23
efriedconflicts pare it down to just one file.20:23
efriedShould we go to queens?20:24
mriedembelmiro's bug was against rocky b/c that's what cern was using at the time,20:25
mriedemi'd say maybe wait for someone to ask for it in queens20:25
efriedight20:26
*** boxiang has joined #openstack-nova20:27
*** dpawlik has quit IRC20:27
*** altlogbot_1 has joined #openstack-nova20:28
*** zhubx has quit IRC20:28
*** zhubx has joined #openstack-nova20:30
*** altlogbot_1 has quit IRC20:32
*** boxiang has quit IRC20:33
*** eharney has joined #openstack-nova20:42
*** dpawlik has joined #openstack-nova20:44
*** pcaruana has quit IRC20:48
*** dpawlik has quit IRC20:48
*** xek_ has joined #openstack-nova20:51
*** xek has quit IRC20:52
*** dklyle has joined #openstack-nova20:55
*** ociuhandu has joined #openstack-nova20:59
openstackgerritsean mooney proposed openstack/nova master: DNM demonstrate that get_domain_capabilities is broken.  https://review.opendev.org/67018921:01
sean-k-mooneyefried: aspiers ^ im going rework get_domain_capabilities function so that it does not explode at runtime21:02
*** altlogbot_3 has joined #openstack-nova21:04
*** ociuhandu has quit IRC21:08
*** altlogbot_3 has quit IRC21:08
*** xek_ has quit IRC21:11
efriedneat21:15
*** altlogbot_1 has joined #openstack-nova21:18
*** altlogbot_1 has quit IRC21:22
*** boxiang has joined #openstack-nova21:23
sean-k-mooneythe test case is a bit contrived as  i would otherwise be assert that if i trow an excpetion that it thing explode21:23
sean-k-mooneybut hopefully its clear that there reason it was passing wa we were hardcoding stuff21:23
sean-k-mooneyand we  dont call it21:24
*** zhubx has quit IRC21:25
openstackgerritMerged openstack/nova master: docs: Correct issues with 'openstack quota set' commands  https://review.opendev.org/66716421:26
*** admin0 has quit IRC21:27
*** spatel has quit IRC21:27
sean-k-mooneyim going to change the api of _get_domain_capabilities to match libvirt which allows all args to be set to none so we dont need to invent a default if we dont have one and can just use libvirts instead21:28
*** dklyle has quit IRC21:29
openstackgerritMatt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job  https://review.opendev.org/67019621:36
*** zhubx has joined #openstack-nova21:36
*** zhubx has quit IRC21:39
*** zhubx has joined #openstack-nova21:39
*** boxiang has quit IRC21:40
*** boxiang has joined #openstack-nova21:44
openstackgerritMatt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job  https://review.opendev.org/67019621:44
*** zhubx has quit IRC21:45
*** factor has quit IRC21:45
*** factor has joined #openstack-nova21:46
*** takashin has joined #openstack-nova21:46
*** irclogbot_3 has joined #openstack-nova21:48
*** artom has quit IRC21:50
*** irclogbot_3 has quit IRC21:52
*** tbachman_ has joined #openstack-nova21:59
*** tbachman has quit IRC22:00
*** tbachman_ is now known as tbachman22:00
*** mchlumsky has quit IRC22:10
*** mlavalle has quit IRC22:18
*** slaweq has quit IRC22:20
*** _erlon_ has quit IRC22:30
*** zhubx has joined #openstack-nova22:38
*** boxiang has quit IRC22:42
*** luksky11 has quit IRC22:43
*** rcernin has joined #openstack-nova22:48
openstackgerritEric Fried proposed openstack/nova master: Introduces the openstacksdk to nova  https://review.opendev.org/64366422:48
openstackgerritEric Fried proposed openstack/nova master: Use OpenStack SDK for placement  https://review.opendev.org/65602322:48
openstackgerritMerged openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf  https://review.opendev.org/66217622:58
*** hongbin has quit IRC23:02
*** altlogbot_3 has joined #openstack-nova23:04
*** tkajinam has joined #openstack-nova23:06
*** altlogbot_3 has quit IRC23:08
*** altlogbot_0 has joined #openstack-nova23:14
openstackgerritsean mooney proposed openstack/nova master: libvirt: harden get_domain_capabilities  https://review.opendev.org/67018923:17
*** altlogbot_0 has quit IRC23:18
*** altlogbot_1 has joined #openstack-nova23:20
*** altlogbot_1 has quit IRC23:24
*** altlogbot_0 has joined #openstack-nova23:26
*** altlogbot_0 has quit IRC23:30
*** hoonetorg has quit IRC23:38
*** hoonetorg has joined #openstack-nova23:40
openstackgerritDustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get  https://review.opendev.org/64289923:43
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list  https://review.opendev.org/65602723:43
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node  https://review.opendev.org/65602823:43
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id  https://review.opendev.org/65969023:43
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for add/remove instance info from node  https://review.opendev.org/65969123:43
openstackgerritDustin Cowles proposed openstack/nova master:     Use SDK instead of ironicclient for getting network metadata from node  https://review.opendev.org/67021323:43
*** artom has joined #openstack-nova23:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!