| *** tbachman has quit IRC | 00:02 | |
| *** brinzhang has joined #openstack-nova | 00:14 | |
| openstackgerrit | Merged openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939 | 00:16 |
|---|---|---|
| *** igordc has quit IRC | 00:49 | |
| brinzhang | Hi all, who is familiar with the schema, please help review this schema check, thanks | 00:49 |
| brinzhang | https://review.opendev.org/#/c/663851/13/nova/api/openstack/compute/schemas/servers.py | 00:49 |
| *** frankwang has joined #openstack-nova | 01:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | 01:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | 01:06 |
| *** imacdonn has quit IRC | 01:11 | |
| *** imacdonn has joined #openstack-nova | 01:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042 | 01:22 |
| *** mriedem has quit IRC | 01:26 | |
| *** redkrieg has quit IRC | 01:28 | |
| *** redkrieg has joined #openstack-nova | 01:30 | |
| *** bhagyashris_ has joined #openstack-nova | 01:32 | |
| *** frank_wang has joined #openstack-nova | 01:46 | |
| *** tbachman has joined #openstack-nova | 01:47 | |
| *** gyee has quit IRC | 01:49 | |
| *** ricolin has joined #openstack-nova | 01:53 | |
| *** frankwang has quit IRC | 01:54 | |
| *** lei-zh has joined #openstack-nova | 01:54 | |
| openstackgerrit | Merged openstack/nova master: Require at least cryptography>=2.7 https://review.opendev.org/667765 | 01:55 |
| *** BjoernT_ has joined #openstack-nova | 01:59 | |
| alex_xu | efried_pto: bauzas I only question is about why we just use existed json-schema we have. if it is already agreement by a lot of people, it is ok for moving forward | 02:00 |
| *** BjoernT has quit IRC | 02:02 | |
| *** lei-zh has quit IRC | 02:05 | |
| *** lei-zh has joined #openstack-nova | 02:06 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: Replace a wiki link with API ref guide link https://review.opendev.org/669027 | 02:49 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 02:51 |
| *** ricolin_ has joined #openstack-nova | 02:59 | |
| *** stakeda has joined #openstack-nova | 03:00 | |
| *** ricolin has quit IRC | 03:01 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: Add links to novaclient contributor guide https://review.opendev.org/669028 | 03:02 |
| *** BjoernT_ has quit IRC | 03:04 | |
| *** ricolin_ is now known as ricolin | 03:06 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate vpmems request to placement request group https://review.opendev.org/634553 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: compute: allocate pmem namespaces to instance https://review.opendev.org/662702 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.opendev.org/634555 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.opendev.org/634552 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update migrations_context to support migration with vpmems https://review.opendev.org/662709 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.opendev.org/634556 | 03:15 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate vpmems request to placement request group https://review.opendev.org/634553 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: compute: allocate pmem namespaces to instance https://review.opendev.org/662702 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.opendev.org/634555 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.opendev.org/634552 | 03:48 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update migrations_context to support migration with vpmems https://review.opendev.org/662709 | 03:49 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.opendev.org/634556 | 03:49 |
| *** lei-zh1 has joined #openstack-nova | 03:58 | |
| *** lei-zh has quit IRC | 04:01 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Remove deprecated methods and properties https://review.opendev.org/667762 | 04:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 04:07 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 04:07 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715 | 04:07 |
| *** spatel has joined #openstack-nova | 04:18 | |
| *** artom has joined #openstack-nova | 04:18 | |
| *** artom is now known as artom|gmtplus3 | 04:18 | |
| *** _alastor_ has quit IRC | 04:24 | |
| *** tkajinam has quit IRC | 04:30 | |
| *** shilpasd has joined #openstack-nova | 04:42 | |
| *** yikun has quit IRC | 04:47 | |
| *** ricolin_ has joined #openstack-nova | 04:48 | |
| *** bnemec has quit IRC | 04:50 | |
| *** ricolin has quit IRC | 04:51 | |
| *** bnemec has joined #openstack-nova | 04:53 | |
| *** whoami-rajat has joined #openstack-nova | 04:55 | |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** altlogbot_0 has quit IRC | 04:57 | |
| *** altlogbot_0 has joined #openstack-nova | 04:58 | |
| *** tkajinam has joined #openstack-nova | 05:06 | |
| *** spatel has quit IRC | 05:12 | |
| *** Luzi has joined #openstack-nova | 05:29 | |
| *** lei-zh1 has quit IRC | 05:32 | |
| *** ccamacho has quit IRC | 05:32 | |
| *** ricolin__ has joined #openstack-nova | 05:34 | |
| *** shilpasd has quit IRC | 05:35 | |
| *** ricolin_ has quit IRC | 05:37 | |
| *** shilpasd has joined #openstack-nova | 05:41 | |
| *** luksky11 has joined #openstack-nova | 05:50 | |
| *** lpetrut has joined #openstack-nova | 06:09 | |
| *** factor has joined #openstack-nova | 06:16 | |
| *** slaweq has joined #openstack-nova | 06:21 | |
| *** ccamacho has joined #openstack-nova | 06:34 | |
| *** frank_wang has quit IRC | 06:39 | |
| *** frank_wang has joined #openstack-nova | 06:39 | |
| *** ricolin__ is now known as ricolin | 06:42 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:47 | |
| *** rcernin has quit IRC | 06:54 | |
| *** Luzi has quit IRC | 06:55 | |
| *** ivve has joined #openstack-nova | 06:57 | |
| *** Luzi has joined #openstack-nova | 06:57 | |
| *** udesale has joined #openstack-nova | 06:58 | |
| *** luksky11 has quit IRC | 07:02 | |
| *** maciejjozefczyk has quit IRC | 07:02 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:04 | |
| *** tesseract has joined #openstack-nova | 07:05 | |
| *** psachin has joined #openstack-nova | 07:13 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: bdm: store empty object as connection_info by default https://review.opendev.org/669072 | 07:17 |
| *** sridharg has joined #openstack-nova | 07:17 | |
| *** ociuhandu has joined #openstack-nova | 07:22 | |
| *** psachin has quit IRC | 07:23 | |
| *** rpittau|afk is now known as rpittau | 07:23 | |
| *** tssurya has joined #openstack-nova | 07:25 | |
| *** pcaruana has joined #openstack-nova | 07:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: bdm: store empty object as connection_info by default https://review.opendev.org/669078 | 07:30 |
| *** yikun has joined #openstack-nova | 07:31 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Give volume DriverBlockDevice classes a common prefix https://review.opendev.org/669081 | 07:33 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: bdm: store empty object as connection_info by default https://review.opendev.org/669082 | 07:33 |
| *** ttsiouts has joined #openstack-nova | 07:34 | |
| *** ttsiouts has quit IRC | 07:45 | |
| *** ttsiouts has joined #openstack-nova | 07:46 | |
| *** ttsiouts has quit IRC | 07:50 | |
| *** ociuhandu has quit IRC | 07:51 | |
| *** luksky11 has joined #openstack-nova | 07:54 | |
| *** avolkov has joined #openstack-nova | 07:55 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info https://review.opendev.org/579004 | 07:55 |
| *** xek has joined #openstack-nova | 07:59 | |
| *** damien_r has joined #openstack-nova | 07:59 | |
| *** ttsiouts has joined #openstack-nova | 08:00 | |
| *** ralonsoh has joined #openstack-nova | 08:03 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | 08:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | 08:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 08:08 |
| *** jangutter has joined #openstack-nova | 08:13 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{QEMU,LIBVIRT}_LUKS_VERSION https://review.opendev.org/668924 | 08:16 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626 | 08:17 |
| lyarwood | kashyap: ^ re your change, I think we can drop all of the allow native LUKS compat code now, would you mind if I respun your change with some additional removals? | 08:26 |
| lyarwood | kashyap: happy to create a follow up if you just want to remove the VERSION constants | 08:27 |
| kashyap | lyarwood: Yeah, a follow-up built on this would be cleaner, IMHO. | 08:27 |
| lyarwood | kashyap: kk | 08:27 |
| *** pcaruana has quit IRC | 08:28 | |
| kashyap | lyarwood: If it's not too much can drop it in this change already? | 08:28 |
| kashyap | Just that I have another change built on top of it, trying to reduce rebase churn... | 08:28 |
| lyarwood | kashyap: I'll post it and we can go from there | 08:30 |
| lyarwood | kashyap: it might be larger than your current PS tbh | 08:30 |
| kashyap | Okido, I'll keep an eye. | 08:31 |
| lyarwood | oh and FWIW my change shouldn't impact your series | 08:37 |
| lyarwood | I'll just need to rebase it when you rebase yours etc | 08:37 |
| lyarwood | but it shouldn't cause any conflicts in yours | 08:37 |
| kashyap | Yep, noted | 08:38 |
| *** cdent has joined #openstack-nova | 08:45 | |
| *** pcaruana has joined #openstack-nova | 09:04 | |
| *** tkajinam has quit IRC | 09:08 | |
| *** ociuhandu has joined #openstack-nova | 09:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Stabilize unshelve notification sample tests https://review.opendev.org/669118 | 09:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.virt.libvirt.compat' https://review.opendev.org/669120 | 09:20 |
| *** ricolin has quit IRC | 09:22 | |
| *** bhagyashris_ has quit IRC | 09:25 | |
| *** owalsh_ is now known as owalsh | 09:34 | |
| *** ttsiouts has quit IRC | 09:35 | |
| *** ttsiouts has joined #openstack-nova | 09:36 | |
| *** ttsiouts has quit IRC | 09:40 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | 09:40 |
| lyarwood | kashyap / stephenfin ; ^ follow up to the MIN LUKS_VERSION removal change | 09:40 |
| *** ttsiouts has joined #openstack-nova | 09:41 | |
| kashyap | Will look; thanks! | 09:43 |
| kashyap | s/!// | 09:43 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 09:44 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 09:45 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | 09:48 |
| *** brinzhang has quit IRC | 09:48 | |
| *** brinzhang has joined #openstack-nova | 09:48 | |
| kashyap | lyarwood: I think you've addressed the things you pointed out in my review in your follow-up, yeah? | 09:49 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 09:53 |
| johnthetubaguy | kashyap: will take a look at your spec now ish, been away in bristol for two days | 09:55 |
| kashyap | johnthetubaguy: Ah, I _think_ you alluded to it. Thanks a ton. | 09:56 |
| kashyap | (Sorry for pestering.) | 09:56 |
| johnthetubaguy | pestering is good, helps me remember | 09:56 |
| lyarwood | kashyap: yes | 09:57 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate vpmems request to placement request group https://review.opendev.org/634553 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: compute: allocate pmem namespaces to instance https://review.opendev.org/662702 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.opendev.org/634555 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.opendev.org/634552 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update migrations_context to support migration with vpmems https://review.opendev.org/662709 | 10:00 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.opendev.org/634556 | 10:00 |
| kashyap | johnthetubaguy: To help your memory, there's a list of things addressed (based on your feedforward) as note in PS-12 | 10:00 |
| johnthetubaguy | kashyap: I meant to ask you about os-info, when using cento7 as os_distro, I seem to get unsupported device errors from libvirt when trying to boot, is that a known thing? | 10:01 |
| kashyap | [It starts with: "Overall, turned the spec a bit "upside down" to reorganize some content:"] | 10:01 |
| kashyap | johnthetubaguy: Hmm, didn't hear that before -- got a full error somewhere? | 10:01 |
| johnthetubaguy | kashyap: not handily, I will let you know and get that into a bug report | 10:02 |
| kashyap | johnthetubaguy: By 'os-info', you mean `osinfo-query`? | 10:02 |
| johnthetubaguy | yeah | 10:02 |
| *** rcernin has joined #openstack-nova | 10:03 | |
| johnthetubaguy | mostly os-distro flags just have a warning message with no match found... historially bad at setting them correctly, but everything blew up when I tried to "fix" that | 10:03 |
| johnthetubaguy | its an unknown virtio device type I think, but I will get you the details | 10:03 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove unreachable native QEMU iSCSI initiator config code https://review.opendev.org/668750 | 10:03 |
| lyarwood | stephenfin: ^ thanks for the review, I've removed disconnect_volume and addressed the nits in the commit | 10:04 |
| kashyap | johnthetubaguy: Sure, happy to look and check w/ the virtio folks if I don't know | 10:04 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 10:05 |
| openstackgerrit | Dirk Mueller proposed openstack/nova stable/queens: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669126 | 10:05 |
| openstackgerrit | Dirk Mueller proposed openstack/nova stable/pike: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669127 | 10:05 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{QEMU,LIBVIRT}_LUKS_VERSION https://review.opendev.org/668924 | 10:06 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_PERF_VERSION https://review.opendev.org/669128 | 10:06 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove support for Intel CMT `perf` events https://review.opendev.org/669129 | 10:06 |
| *** pcaruana has quit IRC | 10:12 | |
| openstackgerrit | Merged openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.opendev.org/506720 | 10:14 |
| kashyap | johnthetubaguy: Thanks! | 10:15 |
| *** rcernin has quit IRC | 10:17 | |
| *** lpetrut has quit IRC | 10:22 | |
| *** ttsiouts has quit IRC | 10:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | 10:27 |
| *** ttsiouts has joined #openstack-nova | 10:28 | |
| *** ttsiouts has quit IRC | 10:32 | |
| *** rcernin has joined #openstack-nova | 10:33 | |
| johnthetubaguy | kashyap: "Instance failed to spawn: UnsupportedHardware: Requested hardware 'virtio1.0-net' is not supported by the 'kvm' virt driver" | 10:36 |
| johnthetubaguy | its with os_distro="centos7.0" | 10:36 |
| *** lpetrut has joined #openstack-nova | 10:37 | |
| kashyap | johnthetubaguy: And only with CentOS 7? | 10:38 |
| johnthetubaguy | haven't tried many of the others right now | 10:39 |
| *** brault has quit IRC | 10:39 | |
| johnthetubaguy | kashyap: I have written it up here for now: https://bugs.launchpad.net/nova/+bug/1835400 | 10:41 |
| openstack | Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Undecided,New] | 10:41 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336 | 10:41 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949 | 10:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Get rid of args to RBDDriver.__init__() https://review.opendev.org/668564 | 10:42 |
| kashyap | johnthetubaguy: I don't see what you mean by "isn't known by 'os-info'". Do you mean this: | 10:42 |
| kashyap | Whe nyou run `osinfo-query os | grep -i centos`, you don't see CentOS listed there at all? | 10:42 |
| johnthetubaguy | correct, only centos7.0 | 10:42 |
| kashyap | Ah, it's the exact string match | 10:43 |
| johnthetubaguy | yeah, although we get the "correct" match in the end, thats OK | 10:43 |
| johnthetubaguy | just when it matches it all seems to fail | 10:44 |
| kashyap | Right | 10:44 |
| kashyap | johnthetubaguy: I'll check and report back on the bug | 10:44 |
| *** brinzhang has quit IRC | 10:45 | |
| johnthetubaguy | kashyap: thanks, I suspect we are meant to just put "virtio" in there? I am not sure though | 10:46 |
| kashyap | johnthetubaguy: So ... was talking to DanPB on #virt, he does indeed say it's a Nova bug: | 10:47 |
| johnthetubaguy | kashyap: I saw this patch: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d | 10:47 |
| johnthetubaguy | I guess we could do the same | 10:47 |
| kashyap | 12:45 < danpb1> kashyap: nova is checking is_vif_model_valid_for_virt() | 10:48 |
| kashyap | 12:45 < danpb1> kashyap: and that method has an incomplete list of hardware models | 10:48 |
| johnthetubaguy | I don't mind patching that, if I know what we should do :) | 10:48 |
| kashyap | ^ See above | 10:48 |
| johnthetubaguy | ah... | 10:48 |
| johnthetubaguy | kashyap: do you know where the full list lives? unsure if libvirt does this check | 10:49 |
| kashyap | johnthetubaguy: /me is unsure, too; will check post lunch and get back | 10:51 |
| johnthetubaguy | kashyap: sweet, thank you | 10:52 |
| *** takashin has left #openstack-nova | 11:01 | |
| *** ttsiouts has joined #openstack-nova | 11:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Stabilize unshelve notification sample tests https://review.opendev.org/669118 | 11:04 |
| *** lpetrut has quit IRC | 11:04 | |
| *** lpetrut has joined #openstack-nova | 11:07 | |
| kashyap | johnthetubaguy: Still here? | 11:14 |
| johnthetubaguy | yeah | 11:14 |
| kashyap | johnthetubaguy: So Dan tells me there are two issues here. | 11:15 |
| kashyap | 1. Nova's validation of n/w models is incomplete | 11:16 |
| kashyap | 2. The "model names returned by libosinfo are *NOT* required to be valid libvirt network model names". | 11:16 |
| kashyap | On point 2, there is no such "virtio-1.0-net" model name in libvirt, if we see here: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/conf/domain_conf.c#l515 | 11:17 |
| johnthetubaguy | yeah, it was (2) I was suspecting, given this: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d | 11:17 |
| kashyap | Apparently libosinfo is just telling us that the guest supports 'virio-1.0-net' | 11:17 |
| kashyap | And there are two ways to provide that: https://libvirt.org/formatdomain.html#elementsVirtioTransitional | 11:18 |
| kashyap | The "virtio-transitional" vs. "virtio-non-transitional" devices. | 11:18 |
| kashyap | Where "virtio-transitional" provides a device that will auto-negotiate virtio 1.0 support; while "virtio-non-transitional" provoides a device that is fixed to always use virtio 1.0 support. | 11:19 |
| johnthetubaguy | and "virtio" what does that do? | 11:19 |
| johnthetubaguy | thinking ln520 in libvirt... I am wondering what we should do here | 11:20 |
| johnthetubaguy | seems like (1) doesn't matter, the issue is our os-info logic seems totally bogus | 11:20 |
| kashyap | johnthetubaguy: On 'virtio': | 11:21 |
| kashyap | virtio | 11:21 |
| kashyap | This device will work like a virtio-non-transitional device when plugged into a PCI Express slot, and like a virtio-transitional device otherwise; libvirt will pick one or the other based on the machine type. This is the best choice when compatibility with libvirt versions older than 5.2.0 is necessary, but it's otherwise not recommended to use it. | 11:21 |
| kashyap | --- | 11:21 |
| johnthetubaguy | ah, that's libvirt docs somewhere? | 11:21 |
| *** bbowen has joined #openstack-nova | 11:21 | |
| kashyap | Yeah, I'm quoting from here: https://libvirt.org/formatdomain.html#elementsVirtioTransitional | 11:22 |
| kashyap | (The link I posted earlier) | 11:22 |
| * kashyap goes to update the bug with a comment | 11:22 | |
| johnthetubaguy | ah, cool, I only got this far: https://libvirt.org/formatdomain.html#elementsNICSModel | 11:22 |
| johnthetubaguy | ah... so this text makes sense now | 11:22 |
| *** ricolin has joined #openstack-nova | 11:25 | |
| johnthetubaguy | kashyap: maybe a better question... what is the optimum settings for all Cento7.0 devices, and how does os-info help me do the right thing | 11:25 |
| kashyap | I think the optimium should be 'virtio', isn't it? | 11:25 |
| kashyap | Given that it behaves correctly with versions older than 5.2.0? | 11:25 |
| * kashyap double-checks with DanPB on #virt, OFTC | 11:26 | |
| johnthetubaguy | just wondering if we set the machine type "correctly" | 11:27 |
| kashyap | johnthetubaguy: Nova doesn't pick a machine type automatically for x86 (but it does for AArch64 and s390x) | 11:27 |
| kashyap | johnthetubaguy: https://bugs.launchpad.net/nova/+bug/1780138 | 11:28 |
| openstack | Launchpad bug 1780138 in OpenStack Compute (nova) "Don't assume the guest machine type to be of 'pc'" [Medium,Confirmed] - Assigned to Kashyap Chamarthy (kashyapc) | 11:28 |
| *** bbowen has quit IRC | 11:30 | |
| johnthetubaguy | just seems like we need to ignore libosinfo for now, and just default everything to virtio | 11:31 |
| kashyap | Right | 11:31 |
| johnthetubaguy | hmm, OK | 11:32 |
| kashyap | johnthetubaguy: Added a comment here based on the chat here: https://bugs.launchpad.net/nova/+bug/1835400 | 11:34 |
| openstack | Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Undecided,New] | 11:34 |
| *** lpetrut has quit IRC | 11:40 | |
| *** rcernin has quit IRC | 11:42 | |
| *** ratailor has quit IRC | 11:44 | |
| *** psachin has joined #openstack-nova | 12:02 | |
| *** lpetrut has joined #openstack-nova | 12:04 | |
| *** tetsuro has joined #openstack-nova | 12:28 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/667421 | 12:32 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: CONF.workarounds.enable_numa_live_migration is not needed >= Train https://review.opendev.org/640021 | 12:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669167 | 12:41 |
| openstackgerrit | Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.opendev.org/608696 | 12:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669168 | 12:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669169 | 12:42 |
| *** tetsuro has quit IRC | 12:44 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_{LIBVIRT,QEMU}_RX_QUEUE_SIZE https://review.opendev.org/669171 | 12:59 |
| *** ttsiouts has quit IRC | 13:01 | |
| *** ttsiouts has joined #openstack-nova | 13:01 | |
| *** Luzi has quit IRC | 13:01 | |
| *** ttsiouts has quit IRC | 13:03 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | 13:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | 13:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 13:04 |
| *** ttsiouts has joined #openstack-nova | 13:04 | |
| *** lpetrut has quit IRC | 13:11 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_{LIBVIRT,QEMU}_RX_QUEUE_SIZE https://review.opendev.org/669171 | 13:11 |
| *** lpetrut has joined #openstack-nova | 13:11 | |
| *** ricolin_ has joined #openstack-nova | 13:15 | |
| *** ricolin has quit IRC | 13:18 | |
| *** whoami-rajat has quit IRC | 13:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955 | 13:23 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.opendev.org/641670 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation https://review.opendev.org/668925 | 13:26 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN https://review.opendev.org/669176 | 13:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Mova consts from neutronv2/api to constants module https://review.opendev.org/668945 | 13:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module https://review.opendev.org/668945 | 13:29 |
| *** ricolin_ is now known as ricolin | 13:41 | |
| kashyap | What is the 'U' release namE? | 13:45 |
| sean-k-mooney | we have not choosen one yet | 13:45 |
| * kashyap only saw the "Call for help" | 13:45 | |
| sean-k-mooney | ya i have not seen much since then. we should call it unicorn | 13:46 |
| gibi | I currently use Unicorn as a workname | 13:46 |
| gibi | jinx | 13:46 |
| sean-k-mooney | haha ya me too | 13:46 |
| sean-k-mooney | it will totally have all my special feature i have wanted for years in it | 13:46 |
| kashyap | Yes, "nova, make me a sandwich" | 13:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py https://review.opendev.org/668946 | 13:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants https://review.opendev.org/668947 | 13:47 |
| kashyap | https://xkcd.com/149/ | 13:47 |
| sean-k-mooney | that would have been the S release | 13:47 |
| *** liuyulong has joined #openstack-nova | 13:49 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | 13:51 |
| *** belmoreira has quit IRC | 13:56 | |
| *** belmoreira has joined #openstack-nova | 13:58 | |
| stephenfin | It so peaceful here without all those pesky Americans cluttering the place up | 13:58 |
| * stephenfin wonders what he should merge while mriedem isn't looking | 13:59 | |
| sean-k-mooney | all of his cross cell migration code of couse so he wonders where the 20 patch series went :) | 14:00 |
| sean-k-mooney | and by 20 i appernetly ment 43 | 14:01 |
| cdent | stephenfin: merge all the things. also thanks for abandoning that health check thing | 14:01 |
| cdent | gibi, sean-k-mooney : unfinished | 14:01 |
| gibi | cdent: not a bad idea :) | 14:04 |
| jangutter | I thought the "U" release would be "Unnamed". | 14:05 |
| gibi | sean-k-mooney, stephenfin: if you want to surprise mriedem then this could be easy too https://review.opendev.org/#/q/topic:bp/pre-filter-disabled-computes+(status:open+OR+status:merged) | 14:05 |
| *** xek has quit IRC | 14:05 | |
| stephenfin | oh, I can probably do that today | 14:06 |
| * stephenfin goes to look at spec again | 14:06 | |
| *** lpetrut has quit IRC | 14:10 | |
| *** tesseract has quit IRC | 14:15 | |
| *** tesseract has joined #openstack-nova | 14:16 | |
| *** luksky11 has quit IRC | 14:17 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove assumption of http error if consumer not exists https://review.opendev.org/669188 | 14:21 |
| *** BjoernT has joined #openstack-nova | 14:23 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Stop using virtio1.0-block and virtio1.0-net https://review.opendev.org/669190 | 14:25 |
| *** BjoernT_ has joined #openstack-nova | 14:27 | |
| *** BjoernT has quit IRC | 14:27 | |
| sean-k-mooney | johnthetubaguy: regarding ^ | 14:30 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Stop using virtio1.0-block and virtio1.0-net https://review.opendev.org/669190 | 14:30 |
| sean-k-mooney | we will still be ablt ot use virtio 1.0 device if qemu supports it right | 14:30 |
| sean-k-mooney | we just wont be forcing them | 14:30 |
| johnthetubaguy | I should probably change the short description | 14:30 |
| sean-k-mooney | well im reading https://libvirt.org/formatdomain.html#elementsVirtioTransitional now and then going back to read your patch | 14:31 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Stop sending bad values from libosinfo to libvirt https://review.opendev.org/669190 | 14:32 |
| johnthetubaguy | that is a better tag line | 14:32 |
| sean-k-mooney | yep | 14:32 |
| sean-k-mooney | and the patch makes sense too | 14:32 |
| johnthetubaguy | even better :) | 14:32 |
| sean-k-mooney | our min version is not 5.2 so we shoudl definetly be normalising | 14:33 |
| johnthetubaguy | yeah, I mean either way, we can't sent virtio1.0-net its just not a thing libvirt accepts | 14:33 |
| sean-k-mooney | it will be a while but we should add a todo to remove whne we have the required min version | 14:33 |
| sean-k-mooney | for the driver typ correct | 14:34 |
| sean-k-mooney | well the model | 14:34 |
| sean-k-mooney | actully we ming not need teh todo in that case | 14:35 |
| *** lpetrut has joined #openstack-nova | 14:36 | |
| johnthetubaguy | we could do something more fancy, when we have new libvirt, I guess, but this seems more... backportable | 14:36 |
| sean-k-mooney | ya | 14:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Fix followup comments of policy-defaults-refresh spec https://review.opendev.org/669196 | 14:37 |
| sean-k-mooney | that module in general feels weird. | 14:39 |
| *** mrch_ has quit IRC | 14:39 | |
| sean-k-mooney | i was not expecting it to be doing things based on image metadata | 14:39 |
| sean-k-mooney | it feel like the HardwareProperties class shoulnd not be there | 14:40 |
| sean-k-mooney | really those properties shoudl jsut be on the image metadata object | 14:41 |
| sean-k-mooney | thats unrealed to your cahnge but just an observation. | 14:41 |
| johnthetubaguy | agreed... its odd | 14:43 |
| sean-k-mooney | is this file used by anything other then the libvirt driver | 14:44 |
| johnthetubaguy | not that I can see | 14:46 |
| johnthetubaguy | I suspect it was placed aspirationally | 14:47 |
| sean-k-mooney | im wondering if we should do this in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py instead | 14:47 |
| *** belmoreira has quit IRC | 14:48 | |
| johnthetubaguy | I think there are more issues than that, looking at this more closely | 14:49 |
| johnthetubaguy | right now we fail to boot instances with the "correct" os_distro, that is probably the main bit | 14:49 |
| johnthetubaguy | looking at a follow up patch... this isn't right | 14:50 |
| sean-k-mooney | i think this is only ever used here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L237 | 14:50 |
| sean-k-mooney | outside of test that is | 14:50 |
| kashyap | johnthetubaguy: Nice, the "Stop sending bad values"... | 14:51 |
| *** ivve has quit IRC | 14:51 | |
| *** belmoreira has joined #openstack-nova | 14:52 | |
| sean-k-mooney | kashyap: this actully look like a libosinfo bug to me | 14:52 |
| kashyap | sean-k-mooney: This morning we analyzed, there is definitely a Nova bug here. | 14:52 |
| kashyap | (If there's a libosinfo bug, that could be extra) | 14:52 |
| sean-k-mooney | there proably is too but i am not sure that libosinfo should also be retruning virtion1.0-net | 14:53 |
| kashyap | See my comment in the bug: https://bugs.launchpad.net/nova/+bug/1835400 | 14:53 |
| openstack | Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Medium,In progress] - Assigned to John Garbutt (johngarbutt) | 14:53 |
| kashyap | Not probably, we pretty sure know there is a Nova bug. Nova's validation is incomplete. And the is_vif_model_valid_for_virt() does not have the full list of hardware models | 14:53 |
| sean-k-mooney | im not sure it should be encoding the virtio version in the model name | 14:53 |
| kashyap | We're sure; I checked with the libosinfo + libvirt upstream this morning | 14:54 |
| kashyap | johnthetubaguy: and I had an hour-long chat here (might want to read the scroll, if you could stomach reading it). | 14:54 |
| johnthetubaguy | this is another data point: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d | 14:54 |
| kashyap | sean-k-mooney: 'virtio' is the _right_ choice. Beacuse see the documentation johnthetubaguy linked to in the commit message. | 14:55 |
| sean-k-mooney | what im saying is i consider it an api breaking in libsoinfo | 14:55 |
| kashyap | What precisely is an API breakage? | 14:55 |
| kashyap | The 'virtio1.0-net' not being availablE? | 14:55 |
| sean-k-mooney | addtion of new values to the enum in a way that is backward incompatible. | 14:55 |
| kashyap | Quoting my second point from the bug: | 14:56 |
| kashyap | "(2) The "model names returned by libosinfo are *NOT* required to be valid libvirt network model names". I.e. there is no such "virtio-1.0-net" model name in libvirt, if we see here: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/conf/domain_conf.c#l515" | 14:56 |
| sean-k-mooney | im not saying that we should not normalise them but i am qustioning the value of using libosinfo at all if they are not required to be valid | 14:57 |
| johnthetubaguy | so they had virtio-block before and now also have virtio1.0-block for the new non-legacy device | 14:57 |
| *** udesale has quit IRC | 14:58 | |
| johnthetubaguy | all the other users whitelist and go digging for the info they want, it seems | 14:58 |
| *** sridharg has quit IRC | 14:58 | |
| johnthetubaguy | we just blindly trusted and thing that was never planned to be correct | 14:58 |
| *** lpetrut has quit IRC | 14:58 | |
| sean-k-mooney | ya | 14:58 |
| *** udesale has joined #openstack-nova | 14:59 | |
| *** luksky11 has joined #openstack-nova | 14:59 | |
| sean-k-mooney | if it was a python lib i would say we should be capping it in upper constratits | 14:59 |
| johnthetubaguy | we are using the interface wrong here, I dislike libosinfo's interface (but honestly, this is minor in my general dislike of the interface)... but we don't have anything better, we did try feedback this dislike when we first added support. | 14:59 |
| sean-k-mooney | but anyway i guess we need to normalise it but im not sure what value this code adds | 14:59 |
| johnthetubaguy | I think this was probably broken when we added it, just clearly no one seems to use it | 15:00 |
| johnthetubaguy | appart from me, when I tried to squash a bunch of warning logs in production... | 15:00 |
| johnthetubaguy | (facepalm) | 15:00 |
| johnthetubaguy | magnum actually requires an osdistro value that isn't supported by libosinfo... but that is just as well else the instance wouldn't boot | 15:01 |
| johnthetubaguy | (they want fedora atomic only, for their fedora atomic driver) | 15:02 |
| sean-k-mooney | so i think this is fundementally broken as it also ignores what disk buses are supporte by the hypervior | 15:02 |
| sean-k-mooney | i am adding some related logic for one of my spec | 15:04 |
| sean-k-mooney | https://review.opendev.org/#/c/666915/2/nova/virt/libvirt/driver.py@9659 | 15:04 |
| sean-k-mooney | there i am using the new domain capablities api to get the disk models supoted by the hypervior | 15:04 |
| sean-k-mooney | your current patch just checks there in the supported list but does not take account of the vrit type | 15:05 |
| sean-k-mooney | so if the virt type was lxc you could end up retruning virtio which is wrong | 15:05 |
| sean-k-mooney | osinfo also should not take preference overe hw_disk_bus | 15:06 |
| sean-k-mooney | if the user specfically set it we shoudl use that | 15:06 |
| sean-k-mooney | so there are several bugs with this | 15:06 |
| sean-k-mooney | actully never mind that last point | 15:07 |
| sean-k-mooney | it handel that internaly | 15:07 |
| sean-k-mooney | that is is why we need to pass the image metadata | 15:07 |
| sean-k-mooney | to the hardware properties class but we dont pass the virt type | 15:08 |
| sean-k-mooney | i dont know maybe im wrong but it feels odd teh way its currently layed out | 15:10 |
| sean-k-mooney | i have not gone back and read the commit that added it maybe it explained why the current form is used | 15:10 |
| sean-k-mooney | * order | 15:10 |
| *** belmoreira has quit IRC | 15:17 | |
| johnthetubaguy | sean-k-mooney: its feels stupid the way it currently is, particular in reference to this logic: https://github.com/openstack/nova/blob/61558f274842b149044a14bbe7537b9f278035fd/nova/virt/libvirt/blockinfo.py#L219 and https://github.com/openstack/nova/blob/ff0f33cf7e44c5d01f3fb999295eff4508c24a14/nova/virt/libvirt/vif.py#L137 | 15:20 |
| johnthetubaguy | I know stephenfin just did a bunch of improvements in there, but yeah, its a bit stupid in its current form | 15:20 |
| stephenfin | Yeah, it's on my list. tbh, 'get_base_config' just needs to disappear | 15:24 |
| stephenfin | It doesn't really provide a consistent base for anything at this point | 15:24 |
| johnthetubaguy | so I liked the libosinfo plan, specify os_distro and you get a best default for your chosen hypervisor... but yeah, it doesn't do that today. | 15:26 |
| *** priteau has joined #openstack-nova | 15:30 | |
| kashyap | johnthetubaguy or anyone: If you want a change of scenery, some easy patches with "negative code": https://review.opendev.org/#/q/topic:Bump_min_libvirt_and_QEMU_for_Stein+(status:open) | 15:31 |
| johnthetubaguy | yeah, I keep meaning to look, but I have to fix some customer stuff at the moment | 15:31 |
| kashyap | johnthetubaguy: Sure, this can wait | 15:33 |
| kashyap | Go for the other one; more important :-) | 15:33 |
| *** frank_wang has quit IRC | 15:39 | |
| *** frank_wang has joined #openstack-nova | 15:39 | |
| stephenfin | kashyap: Looks like we've got some duplication between that series above and my one ending here https://review.opendev.org/#/c/666814/ | 15:41 |
| kashyap | stephenfin: Whoops | 15:42 |
| * kashyap clicks | 15:42 | |
| stephenfin | kashyap: Specifically on this one https://review.opendev.org/#/c/669171/ Think you could do some rebasing one way or the other (or just drop that patch) | 15:42 |
| stephenfin | Also, have questions on the cmt patch. Rest is +" | 15:43 |
| stephenfin | *+2 | 15:43 |
| kashyap | stephenfin: Darn the 'vif' thing is indeed a duplicate. Sorry; I'll abandon that | 15:43 |
| kashyap | Abandoned; will check the question on the CMT one. | 15:45 |
| kashyap | Thanks for review. | 15:45 |
| kashyap | s/for/"for the"/ | 15:45 |
| *** ttsiouts has quit IRC | 15:47 | |
| *** whoami-rajat has joined #openstack-nova | 15:47 | |
| *** ttsiouts has joined #openstack-nova | 15:48 | |
| *** BjoernT_ has quit IRC | 15:51 | |
| *** tssurya has quit IRC | 15:52 | |
| *** cdent has quit IRC | 15:52 | |
| *** ttsiouts has quit IRC | 15:52 | |
| *** wwriverrat has joined #openstack-nova | 16:04 | |
| *** ccamacho has quit IRC | 16:06 | |
| *** artom|gmtplus3 has quit IRC | 16:10 | |
| *** maciejjozefczyk has quit IRC | 16:13 | |
| *** rpittau is now known as rpittau|afk | 16:14 | |
| sean-k-mooney | johnthetubaguy: regarding the osinfo issue we coudl merge you small fix as a stepping stone but i think we should file a seperate bug to adress the larger issue later | 16:30 |
| sean-k-mooney | e.g. we should unbreak your customers and then figure out where to go from there. | 16:31 |
| johnthetubaguy | sean-k-mooney: cool, that aligns with my thinking | 16:31 |
| *** udesale has quit IRC | 16:31 | |
| johnthetubaguy | certainly, a heap of issues in there... its tempting to just drop the libosinfo stuff honestly, I am not sure its helping us any more, if we always send "virtio" expect for very old distros | 16:32 |
| sean-k-mooney | ya i considerd that too but was not sure why it was originally added e.g. what would we be regressing if we did | 16:33 |
| sean-k-mooney | by the way os_distro=centos7.0 is not correct it should be os_distro=centos and os_version=7 | 16:38 |
| sean-k-mooney | see https://github.com/openstack/glance/blob/master/etc/metadefs/operating-system.json | 16:38 |
| *** damien_r has quit IRC | 16:38 | |
| sean-k-mooney | which i now realise that module does not handel correctly either | 16:39 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L123-L124 should be checking both values and technically we should be rejecting centos7.0 as an invalde disto name | 16:43 |
| sean-k-mooney | but we treat it as a sting filed here https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L456 since we dont know the full set of os we could be running | 16:44 |
| openstackgerrit | Merged openstack/nova master: vif: Skip most of 'get_base_config' if not using virtio https://review.opendev.org/666629 | 16:53 |
| openstackgerrit | Merged openstack/nova stable/queens: Init HostState.failed_builds https://review.opendev.org/668911 | 17:10 |
| *** icarusfactor has joined #openstack-nova | 17:16 | |
| *** eharney has quit IRC | 17:17 | |
| *** factor has quit IRC | 17:19 | |
| *** psachin has quit IRC | 17:20 | |
| *** icarusfactor has quit IRC | 17:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP:Introduce scope_types in os-services https://review.opendev.org/645427 | 17:24 |
| *** ralonsoh has quit IRC | 17:24 | |
| *** spatel has joined #openstack-nova | 17:30 | |
| *** luksky11 has quit IRC | 17:33 | |
| *** spatel has quit IRC | 17:35 | |
| *** ivve has joined #openstack-nova | 17:36 | |
| *** ricolin has quit IRC | 17:37 | |
| *** priteau has quit IRC | 17:59 | |
| johnthetubaguy | sean-k-mooney: right, it only seems to work with centos7.0 right now, else it gets rejected, go figure | 18:00 |
| sean-k-mooney | right but the os_disto is ment to be the os name without the version | 18:00 |
| sean-k-mooney | so it was broken from the start | 18:00 |
| johnthetubaguy | maybe, it spits out a warning unless you smoosh them together | 18:01 |
| sean-k-mooney | libosinfo? | 18:02 |
| sean-k-mooney | looking at the spec the spec was using it wrongly form the start https://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/libvirt-hardware-policy-from-libosinfo.html | 18:02 |
| johnthetubaguy | no, Nova | 18:02 |
| sean-k-mooney | nova should not spit out an error | 18:02 |
| johnthetubaguy | the spec wasn't updated vs the implementation | 18:02 |
| sean-k-mooney | os_distro=centos is the correct form | 18:03 |
| johnthetubaguy | it always, had, well only in the operators logs as a warning | 18:03 |
| johnthetubaguy | saying osdistro not found | 18:03 |
| openstackgerrit | Merged openstack/nova stable/stein: Add functional recreate test for regression bug 1825537 https://review.opendev.org/666959 | 18:03 |
| openstack | bug 1825537 in OpenStack Compute (nova) stein "finish_resize failures incorrectly revert allocations" [Medium,In progress] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem) | 18:03 |
| openstackgerrit | Merged openstack/nova stable/stein: Drop source node allocations if finish_resize fails https://review.opendev.org/667155 | 18:03 |
| openstackgerrit | Merged openstack/nova stable/rocky: Delete resource providers for all nodes when deleting compute service https://review.opendev.org/666854 | 18:03 |
| johnthetubaguy | sorry, I need ot run | 18:03 |
| sean-k-mooney | yes but os_distro was not added for libosinfo | 18:03 |
| openstackgerrit | Merged openstack/nova stable/rocky: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659246 | 18:03 |
| sean-k-mooney | johnthetubaguy: sure o/ | 18:03 |
| johnthetubaguy | I thought it existed before | 18:03 |
| sean-k-mooney | it did | 18:04 |
| sean-k-mooney | for other drivers for other things that expect jsut the os name | 18:04 |
| sean-k-mooney | not the os name + version | 18:04 |
| openstackgerrit | Merged openstack/nova master: Refactor bandwidth related functional tests https://review.opendev.org/641679 | 18:07 |
| *** ociuhandu has quit IRC | 18:16 | |
| *** tesseract has quit IRC | 18:35 | |
| *** whoami-rajat has quit IRC | 18:47 | |
| *** markvoelker has quit IRC | 18:55 | |
| *** whoami-rajat has joined #openstack-nova | 19:07 | |
| *** markvoelker has joined #openstack-nova | 19:39 | |
| *** spatel has joined #openstack-nova | 19:40 | |
| *** spatel has quit IRC | 19:40 | |
| *** markvoelker has quit IRC | 19:44 | |
| *** luksky11 has joined #openstack-nova | 19:55 | |
| *** ociuhandu has joined #openstack-nova | 20:14 | |
| *** damien_r has joined #openstack-nova | 20:25 | |
| *** ociuhandu has quit IRC | 20:26 | |
| *** markvoelker has joined #openstack-nova | 20:32 | |
| *** ivve has quit IRC | 20:47 | |
| *** _alastor_ has joined #openstack-nova | 21:02 | |
| *** _alastor_ has quit IRC | 21:06 | |
| *** whoami-rajat has quit IRC | 21:27 | |
| *** slaweq has quit IRC | 22:09 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** adriant has quit IRC | 22:23 | |
| *** slaweq has quit IRC | 22:24 | |
| *** damien_r has quit IRC | 22:28 | |
| *** slaweq has joined #openstack-nova | 22:37 | |
| *** luksky11 has quit IRC | 22:43 | |
| *** slaweq has quit IRC | 22:50 | |
| *** tkajinam has joined #openstack-nova | 23:02 | |
| *** slaweq has joined #openstack-nova | 23:12 | |
| *** slaweq has quit IRC | 23:24 | |
| *** rcernin has joined #openstack-nova | 23:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!