| *** jenglisch has quit IRC | 00:00 | |
| *** brinzhang has joined #openstack-nova | 00:02 | |
| *** takashin has joined #openstack-nova | 00:10 | |
| *** gyee has quit IRC | 00:15 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 00:21 |
|---|---|---|
| openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 00:24 |
| *** rcernin has quit IRC | 00:25 | |
| *** rcernin has joined #openstack-nova | 00:27 | |
| *** liuyulong has joined #openstack-nova | 00:28 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 00:38 |
| sean-k-mooney | not with spell checking ^ :) | 00:39 |
| sean-k-mooney | or rather grammerly checking | 00:40 |
| *** BjoernT has joined #openstack-nova | 00:44 | |
| *** BjoernT has quit IRC | 00:45 | |
| *** BjoernT has joined #openstack-nova | 00:45 | |
| *** BjoernT has quit IRC | 00:46 | |
| *** BjoernT has joined #openstack-nova | 00:46 | |
| *** BjoernT has quit IRC | 00:46 | |
| *** BjoernT has joined #openstack-nova | 00:47 | |
| *** BjoernT has quit IRC | 00:47 | |
| *** BjoernT has joined #openstack-nova | 00:48 | |
| *** BjoernT has quit IRC | 00:48 | |
| *** BjoernT has joined #openstack-nova | 00:48 | |
| *** ricolin has joined #openstack-nova | 00:48 | |
| *** lbragstad has quit IRC | 00:49 | |
| *** BjoernT has quit IRC | 00:49 | |
| *** BjoernT has joined #openstack-nova | 00:49 | |
| *** BjoernT has joined #openstack-nova | 00:50 | |
| *** BjoernT has quit IRC | 00:50 | |
| *** BjoernT has joined #openstack-nova | 00:51 | |
| *** BjoernT has quit IRC | 00:51 | |
| *** BjoernT has joined #openstack-nova | 00:52 | |
| *** BjoernT has quit IRC | 00:52 | |
| *** BjoernT has joined #openstack-nova | 00:53 | |
| *** BjoernT has quit IRC | 00:53 | |
| *** BjoernT has joined #openstack-nova | 00:54 | |
| *** BjoernT has quit IRC | 00:54 | |
| *** BjoernT has joined #openstack-nova | 00:55 | |
| *** BjoernT has quit IRC | 00:55 | |
| *** BjoernT has joined #openstack-nova | 00:56 | |
| *** BjoernT has quit IRC | 00:56 | |
| *** BjoernT has joined #openstack-nova | 00:57 | |
| *** BjoernT has quit IRC | 00:57 | |
| *** BjoernT has joined #openstack-nova | 00:58 | |
| *** BjoernT has joined #openstack-nova | 00:59 | |
| *** BjoernT has quit IRC | 00:59 | |
| *** BjoernT has joined #openstack-nova | 01:00 | |
| *** BjoernT has joined #openstack-nova | 01:01 | |
| *** BjoernT has quit IRC | 01:01 | |
| *** BjoernT has joined #openstack-nova | 01:02 | |
| *** markvoelker has joined #openstack-nova | 01:02 | |
| *** BjoernT has joined #openstack-nova | 01:02 | |
| *** BjoernT has quit IRC | 01:02 | |
| *** BjoernT has joined #openstack-nova | 01:03 | |
| *** BjoernT has quit IRC | 01:03 | |
| *** rcernin_ has joined #openstack-nova | 01:05 | |
| *** rcernin has quit IRC | 01:06 | |
| openstackgerrit | sean mooney proposed openstack/os-traits master: add libvirt image metadata traits https://review.opendev.org/652996 | 01:07 |
| *** lbragstad has joined #openstack-nova | 01:07 | |
| openstackgerrit | sean mooney proposed openstack/os-traits master: add GOP, NONE and VIRTIO grapics models https://review.opendev.org/665830 | 01:11 |
| *** rajinir has quit IRC | 01:16 | |
| *** lbragstad has quit IRC | 01:20 | |
| *** markvoelker has quit IRC | 01:22 | |
| *** _erlon_ has joined #openstack-nova | 01:32 | |
| *** Sundar has joined #openstack-nova | 01:36 | |
| *** spsurya has joined #openstack-nova | 01:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated arguments in db sync command https://review.opendev.org/666470 | 02:02 |
| *** bbowen has quit IRC | 02:04 | |
| *** tetsuro has joined #openstack-nova | 02:40 | |
| *** JamesBenson has joined #openstack-nova | 02:51 | |
| *** tetsuro has quit IRC | 03:11 | |
| *** cfriesen has quit IRC | 03:19 | |
| *** psachin has joined #openstack-nova | 03:22 | |
| *** whoami-rajat has joined #openstack-nova | 03:47 | |
| *** tetsuro has joined #openstack-nova | 03:51 | |
| *** udesale has joined #openstack-nova | 03:56 | |
| *** _erlon_ has quit IRC | 03:56 | |
| *** tetsuro has quit IRC | 03:57 | |
| *** tetsuro has joined #openstack-nova | 04:03 | |
| *** brinzhang0 has joined #openstack-nova | 04:07 | |
| *** brinzhang has quit IRC | 04:10 | |
| *** JamesBenson has quit IRC | 04:14 | |
| *** dave-mccowan has quit IRC | 04:25 | |
| *** janki has joined #openstack-nova | 04:26 | |
| *** JamesBenson has joined #openstack-nova | 04:42 | |
| *** JamesBenson has quit IRC | 04:46 | |
| *** tetsuro has quit IRC | 05:10 | |
| *** bhagyashris has joined #openstack-nova | 05:12 | |
| *** ratailor has joined #openstack-nova | 05:22 | |
| *** ratailor_ has joined #openstack-nova | 05:24 | |
| *** ratailor has quit IRC | 05:27 | |
| *** Luzi has joined #openstack-nova | 05:40 | |
| *** tetsuro has joined #openstack-nova | 05:46 | |
| *** liuyulong has quit IRC | 05:47 | |
| *** Sundar has quit IRC | 05:47 | |
| *** ccamacho has quit IRC | 05:48 | |
| *** tetsuro has quit IRC | 05:50 | |
| *** lpetrut has joined #openstack-nova | 06:06 | |
| *** udesale has quit IRC | 06:07 | |
| *** udesale has joined #openstack-nova | 06:08 | |
| *** belmoreira has joined #openstack-nova | 06:09 | |
| *** belmoreira has quit IRC | 06:09 | |
| openstackgerrit | mashuting proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/521690 | 06:11 |
| *** pcaruana has joined #openstack-nova | 06:15 | |
| *** hamdyk has joined #openstack-nova | 06:30 | |
| *** lxkong has quit IRC | 06:41 | |
| *** ccamacho has joined #openstack-nova | 06:42 | |
| *** udesale has quit IRC | 06:45 | |
| *** udesale has joined #openstack-nova | 06:46 | |
| *** ivve has joined #openstack-nova | 07:04 | |
| *** rcernin_ has quit IRC | 07:06 | |
| *** tesseract has joined #openstack-nova | 07:07 | |
| *** trident has quit IRC | 07:08 | |
| *** ccamacho has quit IRC | 07:09 | |
| *** trident has joined #openstack-nova | 07:10 | |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** slaweq has quit IRC | 07:15 | |
| *** rpittau|afk is now known as rpittau | 07:20 | |
| *** tssurya has joined #openstack-nova | 07:20 | |
| *** yaawang has quit IRC | 07:22 | |
| *** markvoelker has joined #openstack-nova | 07:22 | |
| *** yaawang has joined #openstack-nova | 07:22 | |
| *** udesale has quit IRC | 07:27 | |
| *** udesale has joined #openstack-nova | 07:28 | |
| *** helenafm has joined #openstack-nova | 07:31 | |
| *** ttsiouts has joined #openstack-nova | 07:31 | |
| *** udesale has quit IRC | 07:33 | |
| *** udesale has joined #openstack-nova | 07:33 | |
| *** udesale has quit IRC | 07:33 | |
| *** udesale has joined #openstack-nova | 07:34 | |
| *** awalende has joined #openstack-nova | 07:37 | |
| *** ralonsoh has joined #openstack-nova | 07:39 | |
| *** awalende has quit IRC | 07:41 | |
| *** slaweq has joined #openstack-nova | 07:42 | |
| *** damien_r has joined #openstack-nova | 07:44 | |
| *** damien_r has quit IRC | 07:45 | |
| *** slaweq has quit IRC | 07:47 | |
| *** hamzy has quit IRC | 07:50 | |
| *** markvoelker has quit IRC | 07:50 | |
| *** hamzy has joined #openstack-nova | 07:51 | |
| *** dklyle has quit IRC | 07:52 | |
| *** yaawang has quit IRC | 07:52 | |
| *** damien_r has joined #openstack-nova | 07:55 | |
| *** awalende has joined #openstack-nova | 07:59 | |
| *** awalende has quit IRC | 07:59 | |
| *** takashin has left #openstack-nova | 08:00 | |
| *** awalende has joined #openstack-nova | 08:00 | |
| *** awalende has quit IRC | 08:04 | |
| *** yaawang has joined #openstack-nova | 08:10 | |
| *** slaweq has joined #openstack-nova | 08:11 | |
| *** tkajinam has quit IRC | 08:16 | |
| *** slaweq has quit IRC | 08:16 | |
| *** zbr has joined #openstack-nova | 08:17 | |
| *** igordc has quit IRC | 08:20 | |
| *** tetsuro has joined #openstack-nova | 08:20 | |
| *** ociuhandu has joined #openstack-nova | 08:22 | |
| *** udesale has quit IRC | 08:23 | |
| *** slaweq has joined #openstack-nova | 08:23 | |
| *** udesale has joined #openstack-nova | 08:23 | |
| *** slaweq has quit IRC | 08:28 | |
| *** belmoreira has joined #openstack-nova | 08:30 | |
| *** tetsuro has quit IRC | 08:31 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Grab fresh power state info from the driver https://review.opendev.org/665975 | 08:31 |
| *** ociuhandu has quit IRC | 08:34 | |
| *** belmoreira has quit IRC | 08:37 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Grab fresh power state info from the driver https://review.opendev.org/665975 | 08:40 |
| *** imacdonn has quit IRC | 08:41 | |
| stephenfin | efried: When do you _sleep_? | 08:41 |
| *** imacdonn has joined #openstack-nova | 08:41 | |
| stephenfin | :) | 08:41 |
| *** lxkong has joined #openstack-nova | 08:45 | |
| *** ccamacho has joined #openstack-nova | 08:45 | |
| *** davidsha has joined #openstack-nova | 08:46 | |
| *** tetsuro has joined #openstack-nova | 08:47 | |
| *** tetsuro has quit IRC | 08:47 | |
| *** markvoelker has joined #openstack-nova | 08:47 | |
| *** tetsuro has joined #openstack-nova | 08:49 | |
| *** markvoelker has quit IRC | 08:52 | |
| *** ociuhandu has joined #openstack-nova | 08:54 | |
| *** moshele has joined #openstack-nova | 08:59 | |
| *** tetsuro has quit IRC | 08:59 | |
| moshele | sean-k-mooney | 08:59 |
| moshele | sean-k-mooney: hi | 09:00 |
| *** slaweq has joined #openstack-nova | 09:00 | |
| *** ociuhandu has quit IRC | 09:02 | |
| ohwhyosa | Morning guys and gals! | 09:02 |
| *** brinzhang0 has quit IRC | 09:11 | |
| *** derekh has joined #openstack-nova | 09:12 | |
| *** psachin has quit IRC | 09:14 | |
| kashyap | jroll: Just saw the ping in scrollback; I don't know the answer to where the keys are stored. I'll inquire and let you know. | 09:15 |
| *** damien_r has quit IRC | 09:19 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709 | 09:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552 | 09:23 |
| *** belmoreira has joined #openstack-nova | 09:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553 | 09:23 |
| openstack | bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172 | 09:23 |
| *** belmoreira has quit IRC | 09:31 | |
| *** slaweq has quit IRC | 09:34 | |
| *** damien_r has joined #openstack-nova | 09:37 | |
| openstackgerrit | guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096 | 09:38 |
| *** belmoreira has joined #openstack-nova | 09:42 | |
| *** martinkennelly has joined #openstack-nova | 09:43 | |
| *** psachin has joined #openstack-nova | 09:47 | |
| *** markvoelker has joined #openstack-nova | 09:48 | |
| *** belmoreira has quit IRC | 09:53 | |
| *** markvoelker has quit IRC | 09:53 | |
| *** janki has quit IRC | 09:55 | |
| *** belmoreira has joined #openstack-nova | 10:01 | |
| *** bhagyashris has quit IRC | 10:02 | |
| *** cdent has joined #openstack-nova | 10:16 | |
| mgoddard | Hello novatons, I have a question about upgrades using [upgrade_levels]compute=auto. Is there a programatic way to know when all computes are running the new RPC version, so that I can restart services to remove the version cap? | 10:16 |
| mgoddard | johnthetubaguy: ^ | 10:16 |
| mgoddard | I'm looking for something like 'nova-manage wait for computes [--all-cells]' | 10:17 |
| johnthetubaguy | there is the services API, does that not return you the version? | 10:17 |
| mgoddard | nope | 10:17 |
| mgoddard | the only potentially useful thing there is updated_at, but that's a bit kludgey | 10:17 |
| johnthetubaguy | checking if its in a new microversion | 10:17 |
| mgoddard | ah | 10:17 |
| mgoddard | I'd quite like to not need to care what the latest version is | 10:18 |
| johnthetubaguy | so if you do controllers upgrade, then wait for them all to be the same | 10:19 |
| johnthetubaguy | its quite close | 10:19 |
| johnthetubaguy | but I get your point | 10:19 |
| mgoddard | service_version = service_obj.get_minimum_version_all_cells( | 10:19 |
| mgoddard | context.get_admin_context(), ['nova-compute']) | 10:19 |
| mgoddard | I'd quite like a command that does that, compares with the latest version and says yes/no | 10:19 |
| johnthetubaguy | yeah, that would be a good nova-manage cmd | 10:20 |
| mgoddard | or even waits with a timeout | 10:20 |
| mgoddard | I'm leaning towards short sleep + nova RFE at this point :) | 10:20 |
| *** slaweq has joined #openstack-nova | 10:20 | |
| johnthetubaguy | RFE? what is that | 10:21 |
| * johnthetubaguy is slightly kidding | 10:21 | |
| mgoddard | blueprint | 10:22 |
| mgoddard | :p | 10:22 |
| johnthetubaguy | yeah, I am wondering about nova status as a place for this kind of thing | 10:22 |
| johnthetubaguy | "is every upgraded" check, makes sense | 10:22 |
| mgoddard | yeah | 10:23 |
| *** bbowen has joined #openstack-nova | 10:23 | |
| johnthetubaguy | i am not seeing anything useful just yet | 10:24 |
| johnthetubaguy | I am sure we used to have a nova-manage cmd for this, I guess we killed it | 10:27 |
| mgoddard | that's a shame | 10:27 |
| johnthetubaguy | https://github.com/openstack/nova/blob/fc8cd8f3b346c8f53e2dfc8e3de9fdcaedb0d35d/nova/cmd/manage.py#L613 | 10:30 |
| johnthetubaguy | although doesn't seem like that had the version either | 10:30 |
| *** bbowen has quit IRC | 10:31 | |
| mgoddard | that was just pushed into the API wasn't it? | 10:32 |
| mgoddard | if the version was available in the service API that would be fine, but ideally I'd want a way to discover what the version should be | 10:34 |
| mgoddard | Looks like it takes 10+ seconds to update the service version in an AIO setup | 10:34 |
| *** ociuhandu has joined #openstack-nova | 10:35 | |
| johnthetubaguy | there is a reporting delay config | 10:36 |
| johnthetubaguy | yeah, so I can't find anything useful in the API or nova-manage, need to add a new thing | 10:36 |
| johnthetubaguy | I mean SIGHUP should be enough, but not sure how we do that via docker? | 10:36 |
| mgoddard | no SIGHUP, it's busted. Need to restart | 10:37 |
| mgoddard | we do that already in kolla, the problem is we're not waiting long enough to actually uncap | 10:37 |
| johnthetubaguy | ah, right | 10:38 |
| johnthetubaguy | https://github.com/openstack/nova/blob/74aebe0d4e5a978a40011e890aee9e70e98246c4/nova/servicegroup/api.py#L35 | 10:39 |
| mgoddard | so I think my band aid is 'sleep ${nova_compute_startup_delay:-30}' | 10:39 |
| johnthetubaguy | so we do wait 5 seconds before reporting | 10:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/609460 | 10:39 |
| johnthetubaguy | that is once its called, and in a timer that might trigger at somepoint after that | 10:39 |
| mgoddard | although I think the thing I'm waiting for happens here: https://github.com/openstack/nova/blob/74aebe0d4e5a978a40011e890aee9e70e98246c4/nova/service.py#L77 | 10:40 |
| johnthetubaguy | init_host is quite expensive | 10:41 |
| johnthetubaguy | it might be just the cost of waiting for that to finish | 10:41 |
| johnthetubaguy | but yeah, its not affected by what I was pointing at | 10:41 |
| mgoddard | would you call this a bug or blueprint? | 10:43 |
| johnthetubaguy | its either really, the release notes are independent these days, so it matters little | 10:44 |
| johnthetubaguy | (to me) | 10:44 |
| johnthetubaguy | the API change would be a spec, but that is a separate issue, a quick fix to nova-manage to list all the services not currently at the latest version would be a simple enough patch | 10:45 |
| johnthetubaguy | you have to target a cell with hosts in it, so maybe its a cell command? | 10:46 |
| johnthetubaguy | get_non_upgrade_cell_computes() or ideally some less rubbish name | 10:46 |
| *** trident has quit IRC | 10:47 | |
| mgoddard | so there are two cases. API, scheduler & super conductor need to wait for all computes. Cell conductor & computes need to wait just for the cell | 10:48 |
| *** trident has joined #openstack-nova | 10:48 | |
| mgoddard | similar logic to https://github.com/openstack/nova/blob/74aebe0d4e5a978a40011e890aee9e70e98246c4/nova/compute/rpcapi.py#L412 | 10:48 |
| *** markvoelker has joined #openstack-nova | 10:49 | |
| johnthetubaguy | hmm... eek | 10:49 |
| mgoddard | which does mean that we shouldn't restart the API etc until all cells have been upgraded | 10:49 |
| mgoddard | quite the ballet we have going on here | 10:50 |
| johnthetubaguy | yeah, I think that is correct... | 10:51 |
| *** belmoreira has quit IRC | 10:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix test_flavors to run with correct microversion https://review.opendev.org/666536 | 10:51 |
| johnthetubaguy | I think its that --cascade argument, one just checks the local cell, the other checks all cells | 10:51 |
| johnthetubaguy | it is correct though, no compute <-> compute communication between cells | 10:52 |
| johnthetubaguy | and after the pin is lifted, compute still accepts older version of requests coming from the API | 10:52 |
| johnthetubaguy | till everyone is done... then boom off we go | 10:52 |
| johnthetubaguy | does kolla give the child cells a connection to the API database? | 10:53 |
| johnthetubaguy | that is going to breaking this logic, interestingly | 10:53 |
| mgoddard | it did until recently | 10:53 |
| mgoddard | actually that was something different | 10:54 |
| *** markvoelker has quit IRC | 10:54 | |
| johnthetubaguy | yeah, there is a strong assumption about that now | 10:54 |
| mgoddard | we don't have a conductor/superconductor split currently | 10:54 |
| mgoddard | not even sure how that distinction is made TBH, is it just the presence of an API DB connection? | 10:55 |
| johnthetubaguy | yeah | 10:55 |
| johnthetubaguy | in the nova.conf | 10:55 |
| johnthetubaguy | if not empty, check all cells is what it does there | 10:56 |
| johnthetubaguy | I mean nova-compute shouldn't have any database strings, I think, so this is about the conductor really | 10:56 |
| mgoddard | right | 10:57 |
| johnthetubaguy | hmm, is that a recent change in kolla-ansible, removing the db conf from nova-compute? | 10:58 |
| *** belmoreira has joined #openstack-nova | 10:59 | |
| mgoddard | johnthetubaguy: yeah, but backported | 11:03 |
| *** davidsha has quit IRC | 11:05 | |
| johnthetubaguy | mgoddard: ah, cool, I guess I might see that fix soon | 11:08 |
| jroll | kashyap: thanks! | 11:12 |
| *** janki has joined #openstack-nova | 11:18 | |
| kashyap | jroll: So, from discussion in #qemu (OFTC network): | 11:23 |
| kashyap | jroll: It _is_ on disk (as you guessed): libvirt stores the state under: /var/lib/libvirt/swtpm/. It is *not* encrypted yet; however, libvirt is *capable* of it | 11:24 |
| kashyap | jroll: And the relevant libvirt/QEMU devs seem to discuss the design of it, as we speak | 11:25 |
| kashyap | jroll: LOL, and the QEMU dev asks me to file a libvirt RFE. Now I need to read up the relevant context to file a meaningful bug | 11:26 |
| jroll | kashyap: oof, sorry I got you roped into that :/ | 11:29 |
| *** shilpasd has quit IRC | 11:30 | |
| kashyap | jroll: Apparently _another_ RFE is also required, for "swtpm" -- to let us pass keys without them being on disk. | 11:33 |
| kashyap | jroll: Regardless, your question was interesting, and I learned something new. I'll let you know once the RFE bugs are filed (see how carefully I dodge the question of _who_ might file them :D) | 11:34 |
| *** lpetrut has quit IRC | 11:35 | |
| *** belmoreira has quit IRC | 11:35 | |
| *** brault has quit IRC | 11:35 | |
| jroll | kashyap: thanks for your help with it, I do appreciate it :) | 11:35 |
| jroll | now the question is, do we implement tpm passthrough in nova for the time being? or do I carry that patch downstream? :/ | 11:36 |
| * jroll will write an email today | 11:36 | |
| *** udesale has quit IRC | 11:36 | |
| kashyap | jroll: Might want to also ask on the upstream list -- some operators might chime in | 11:36 |
| *** udesale has joined #openstack-nova | 11:37 | |
| jroll | kashyap: sorry, yes, I meant I'll email the upstream list today :) | 11:37 |
| *** bbowen has joined #openstack-nova | 11:37 | |
| kashyap | Ah, okay :-) | 11:38 |
| efried | stephenfin: I sleep. I'm actually (usually) very careful about getting enough sleep, as I find it makes all other things better. | 11:39 |
| *** markvoelker has joined #openstack-nova | 11:50 | |
| kashyap | Yes! | 11:51 |
| aspiers | stephenfin: you need to try stestr run -n path.to.module.Class.test, it really does work ... | 11:51 |
| kashyap | efried: In your copious free time, I vehemently suggest to read this (by a real sleep scientist, engagingly written): https://www.penguin.co.uk/books/295/295665/why-we-sleep/9780141983769.html | 11:52 |
| aspiers | /dev/cft: device full | 11:52 |
| kashyap | [Don't let "impressions" from the title come in your way. He writes, and speaks very engagingly and is _full_ of "signal".] | 11:52 |
| efried | kashyap: oo | 11:53 |
| *** markvoelker has quit IRC | 11:54 | |
| mgoddard | that is an excellent book | 11:56 |
| *** janki has quit IRC | 11:57 | |
| *** udesale has quit IRC | 11:58 | |
| *** udesale has joined #openstack-nova | 11:59 | |
| kashyap | Yeah, as the author, Matt Walker, dedicated 20 years (and still on going) studying sleep. | 11:59 |
| stephenfin | aspiers: o rly? | 12:01 |
| * stephenfin tests | 12:01 | |
| efried | aspiers, stephenfin: Are we highlighting -n (don't do discovery) here? | 12:03 |
| stephenfin | Yuuup | 12:03 |
| stephenfin | I knew it worked for files | 12:03 |
| efried | ++ | 12:03 |
| aspiers | see also https://github.com/mtreinish/stestr/issues/219 | 12:03 |
| stephenfin | but not for Python module paths | 12:03 |
| efried | Yeah, I usually can't be bothered to type the thing out, so I run it once with a substring and no -n, and then copy the test name from that output for subsequent runs with -n | 12:04 |
| aspiers | yeah I do that sometimes too | 12:04 |
| stephenfin | For some reason, I expected the project-team-guide to be a docs team deliverable | 12:04 |
| stephenfin | I'm kind of glad it's not, since we're trying to offload what we can, but still - I want my +2 rights, dammit | 12:05 |
| *** jistr is now known as jistr|lunch | 12:08 | |
| cdent | stephenfin: i'm certain someone will be very happy to give them to you | 12:12 |
| *** sridharg has joined #openstack-nova | 12:15 | |
| *** sridharg has quit IRC | 12:16 | |
| aspiers | efried: question about implementation of https://review.opendev.org/#/c/664420/11/nova/virt/hardware.py@2144 ... | 12:16 |
| *** psachin has quit IRC | 12:16 | |
| efried | was just responding to that | 12:17 |
| aspiers | efried: requiring each caller to implement the any() logic feels wrong | 12:17 |
| efried | don't do anything drastic | 12:17 |
| efried | cause I had a better idea in my sleep last night. | 12:17 |
| aspiers | ah? | 12:17 |
| efried | will comment, stand by. | 12:17 |
| aspiers | OK! | 12:17 |
| *** psachin has joined #openstack-nova | 12:20 | |
| efried | aspiers: responded. | 12:22 |
| aspiers | ack | 12:22 |
| *** rdopiera has joined #openstack-nova | 12:28 | |
| efried | aspiers: sane? | 12:28 |
| aspiers | efried: so ditch the need to log the exact reason *why* mem encryption has been requested? | 12:29 |
| rdopiera | bauzas: so about https://review.opendev.org/#/c/666394/ | 12:29 |
| aspiers | I thought that was kind of useful | 12:29 |
| efried | aspiers: no, I'm saying log that in the helper | 12:29 |
| efried | not in the filter | 12:29 |
| aspiers | oh, gotcha | 12:30 |
| efried | phrased in helper-speak, not in filter-speak - see other comment | 12:30 |
| aspiers | sure | 12:30 |
| aspiers | so then it gets logged in the API calls too | 12:30 |
| efried | yes! | 12:30 |
| bauzas | rdopiera: yup, so long story there | 12:30 |
| aspiers | even though that's only done for validation | 12:30 |
| efried | dandy | 12:30 |
| aspiers | OK | 12:30 |
| efried | we're at debug, yah? | 12:30 |
| aspiers | I guess so | 12:30 |
| efried | If that really bothers you, add a do_log=False kwarg | 12:31 |
| bauzas | rdopiera: basically, old microversions (<2.29) were forcing the destination when you were providing a target | 12:31 |
| efried | but it doesn't bother me at all. | 12:31 |
| aspiers | efried: nice idea, but yeah I guess it's fine anyway | 12:31 |
| bauzas | rdopiera: (for live-migration and for evacuate) | 12:31 |
| bauzas | rdopiera: that's why by default it's False in Nova | 12:32 |
| bauzas | oops, s/False/True | 12:32 |
| openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 12:32 |
| bauzas | rdopiera: but with 2.30 microversion, we pass a 'False' value unless you have the --force option | 12:33 |
| rdopiera | bauzas: what about >2.67? | 12:34 |
| bauzas | rdopiera: by 2.67, we removed the --force flag | 12:37 |
| bauzas | rdopiera: https://github.com/openstack/nova/commit/7aa2285e724345717a3f333adc13660d7b97dfcd | 12:38 |
| bauzas | in particular https://github.com/openstack/nova/commit/7aa2285e724345717a3f333adc13660d7b97dfcd#diff-6c3b14d3964eb808ade9d3e7c5d4676d | 12:38 |
| bauzas | if api_version_request.is_supported(req, min_version='2.30'): force = body["os-migrateLive"].get("force", False) force = strutils.bool_from_string(force, strict=True) | 12:39 |
| bauzas | rdopiera: so Nova API defaults the force argument to False after 2.30 | 12:39 |
| rdopiera | bauzas: so for >2.67 force=False always? | 12:40 |
| bauzas | rdopiera: it changed a bit but https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/migrate_server.py#L104-L105 | 12:41 |
| bauzas | rdopiera: which does the same indeed https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/migrate_server.py#L168-L174 | 12:42 |
| bauzas | rdopiera: it's just the JSON schema which changed | 12:42 |
| bauzas | after 2.67, it's no longer possible to pass a force field to the API | 12:43 |
| rdopiera | so in plain words, what is your recommendation for handling that in Horizon? | 12:43 |
| bauzas | so it always defaults to False | 12:43 |
| rdopiera | right, so we only need a special case for 2.29? | 12:43 |
| bauzas | rdopiera: well, looking at https://review.opendev.org/#/c/666394/2/openstack_dashboard/api/nova.py | 12:43 |
| bauzas | rdopiera: with 2.30 and later, you don't need to pass a force flag | 12:44 |
| rdopiera | so something like | 12:45 |
| rdopiera | if client.api_version == api_versions.APIVersion('2.29'): | 12:45 |
| rdopiera | os should we just make sure to request a microversion older than 2.29 instead? | 12:46 |
| bauzas | well, you would then change the UX right? | 12:46 |
| rdopiera | I think that was the idea behind the reported issue in the first place | 12:47 |
| bauzas | remember, before 2.30, it wasn't possible to not force a destination | 12:47 |
| bauzas | it was either possible to either pass a destination and then force to it without checking the scheduler *or* not pass a destination and then the scheduler would be giving you some target | 12:48 |
| bauzas | rdopiera: ^ | 12:48 |
| rdopiera | and after 2.67 it's impossible to force it | 12:48 |
| bauzas | correct | 12:48 |
| rdopiera | so there is going to be a change at some point either way | 12:48 |
| bauzas | so, I'd recommend you to not ask for a target with 2.29 and older | 12:48 |
| bauzas | and for 2.30, accept a target by defaulting to not force to it | 12:49 |
| bauzas | that actually depends on what kind of user experience you'd like to provide | 12:49 |
| bauzas | the force flag was just a way to keep the same behaviour for some time | 12:50 |
| *** markvoelker has joined #openstack-nova | 12:50 | |
| rdopiera | personally I don't feel like I have enough knowledge about Nova to decide on user experience, I would rather ask for recommendation from people who designed it | 12:51 |
| rdopiera | you know what, how about I just abandon that patch and close the bug with "current version" explaining that later versions of the api behave as expected? | 12:52 |
| *** jistr|lunch is now known as jistr | 12:55 | |
| *** udesale has quit IRC | 12:58 | |
| *** pcaruana has quit IRC | 13:00 | |
| *** pcaruana has joined #openstack-nova | 13:00 | |
| *** kaisers has quit IRC | 13:02 | |
| *** kaisers has joined #openstack-nova | 13:03 | |
| *** davidsha has joined #openstack-nova | 13:12 | |
| *** lbragstad has joined #openstack-nova | 13:16 | |
| *** Bidwe_jay_ has joined #openstack-nova | 13:20 | |
| *** markvoelker has quit IRC | 13:20 | |
| *** Bidwe_jay_ has quit IRC | 13:20 | |
| *** mriedem has joined #openstack-nova | 13:23 | |
| mriedem | o/ | 13:23 |
| sean-k-mooney | o/ | 13:23 |
| *** moshele has quit IRC | 13:23 | |
| *** ratailor_ has quit IRC | 13:27 | |
| *** spsurya has quit IRC | 13:29 | |
| *** BjoernT has joined #openstack-nova | 13:30 | |
| *** jistr is now known as jistr|call | 13:31 | |
| bauzas | rdopiera: whoops, missed your question | 13:33 |
| *** BjoernT_ has joined #openstack-nova | 13:33 | |
| efried | kashyap: "Book will arrive tomorrow" --Renae (aka wife aka personal shopper) | 13:33 |
| bauzas | rdopiera: I think yeah it's a reasonable approach, as I wouldn't recommend to change an expected behaviour | 13:33 |
| kashyap | efried: Ow, you trusted me. Thank you :-) | 13:34 |
| bauzas | rdopiera: but this is kind of a tribal knowledge, so again it really depends on what the horizon community would like to see | 13:34 |
| bauzas | and when I see community, I obviously mean devs *and* ops | 13:34 |
| bauzas | (or rather users) | 13:34 |
| *** BjoernT has quit IRC | 13:35 | |
| mriedem | alex_xu: i replied to you here https://review.opendev.org/#/c/610727/ - i'm not sure if i misunderstood your comment | 13:45 |
| mriedem | sean-k-mooney: is https://review.opendev.org/#/c/644881/ ready for re-review? i saw you went from PS33 to PS37 :) | 13:49 |
| *** jistr|call is now known as jistr | 13:50 | |
| sean-k-mooney | it should be. i had to fix the unit tests and then i had to put it to grammerly to fix my spelling in the commit message | 13:51 |
| sean-k-mooney | the changes are not really that big but i think i have adressed everything. ill respin if there are anything else you would like changed. | 13:52 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 13:53 |
| aspiers | efried: ^^^ should address all your feedback | 13:53 |
| efried | ack | 13:53 |
| aspiers | rebasing ... | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV https://review.opendev.org/636318 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' /> https://review.opendev.org/644564 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required https://review.opendev.org/662557 | 13:56 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 13:56 |
| *** whoami-rajat has quit IRC | 13:56 | |
| aspiers | efried: the way bbobrov added the code to ensure virtio devices have IOMMU enabled when SEV is requested, it was inserted within each chunk of device config creation. I'm wondering if it might be better to have a single method which is called after all device config is created if SEV is required, and iterates over each device, enabling IOMMU where required? | 14:01 |
| aspiers | efried: similar to how the tests do it: https://review.opendev.org/#/c/644565/9/nova/tests/unit/virt/libvirt/test_driver.py@2609 | 14:02 |
| *** Luzi has quit IRC | 14:02 | |
| efried | aspiers: I don't really understand how libvirt works. Kind of relying on folks like kashyap to validate those top patches. | 14:02 |
| aspiers | maybe not, since other code might want to insist on (say) disabling IOMMU for a specific type of device | 14:03 |
| * aspiers looks at kashyap | 14:03 | |
| efried | aspiers: IMO if the flavor/image requested encryption and some other piece of code thinks that shouldn't happen, that should be an error. | 14:03 |
| kashyap | On a long call; back in a few, folks | 14:03 |
| aspiers | maybe better to keep each device's IOMMU decision local to the code which creates its config | 14:03 |
| efried | We should never turn off requested encryption based on something discovered internally "later on". | 14:04 |
| aspiers | efried: sure, that's not quite the scenario I mean though | 14:04 |
| efried | okay | 14:04 |
| aspiers | let's say some other extra spec requires a particular storage device to be virtio but have IOMMU disabled | 14:04 |
| aspiers | and there's also an extra spec or image property requiring memory encryption | 14:04 |
| aspiers | these are mutually incompatible since SEV requires IOMMU on all virtio devices | 14:05 |
| aspiers | now ideally, this would be caught earlier on than at instance creation time | 14:05 |
| aspiers | but as a last resort, the chunk of code building the XML for that device should spot the conflict | 14:05 |
| aspiers | whereas if I followed my previous suggestion of moving the "turn IOMMU on for all virtio devices" code to a separate SEV method, it couldn't | 14:06 |
| aspiers | so in summary, maybe the general approach in places like https://review.opendev.org/#/c/644565/9/nova/virt/libvirt/driver.py@1626 is fine | 14:07 |
| aspiers | well | 14:07 |
| aspiers | fine, except for your valid point about explicit turn-off | 14:07 |
| aspiers | which I am still replying to | 14:07 |
| *** dave-mccowan has joined #openstack-nova | 14:10 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 14:18 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required https://review.opendev.org/662557 | 14:18 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 14:18 |
| *** ttsiouts has quit IRC | 14:20 | |
| *** JamesBenson has joined #openstack-nova | 14:20 | |
| *** ttsiouts has joined #openstack-nova | 14:21 | |
| *** mlavalle has joined #openstack-nova | 14:22 | |
| *** mlavalle has quit IRC | 14:22 | |
| aspiers | efried: regarding the need for some kind of master switch: I don't think I can float the MEM_ENCRYPTION_CONTEXT patch to the top - at very least, that's the one which bumps os-resource-classes to 0.4.0 to provide the new class | 14:22 |
| aspiers | efried: if I combined the top three patches, that would be the master switch really, since none of the others change the way guests are created | 14:23 |
| *** mlavalle has joined #openstack-nova | 14:25 | |
| *** ttsiouts has quit IRC | 14:25 | |
| openstackgerrit | Merged openstack/nova master: Log disk transfer stats in live migration monitor. https://review.opendev.org/619395 | 14:27 |
| *** priteau has joined #openstack-nova | 14:28 | |
| *** JamesBenson has quit IRC | 14:29 | |
| mriedem | melwitt: replied inline on https://review.opendev.org/#/c/633227/ | 14:33 |
| mriedem | thanks for thinking through that | 14:33 |
| *** hamdyk has quit IRC | 14:34 | |
| *** ttsiouts has joined #openstack-nova | 14:34 | |
| *** ccstone has quit IRC | 14:38 | |
| kashyap | aspiers: Back here for 15 min. So on the approach to enable IOMMU for virtio devices 'if-SEV-is-requested': I need a fresher mind than the pear-shaped one I have now, afraid. Not to mention a chunky block of time. Let's work it out tomm? | 14:39 |
| aspiers | kashyap: sure but it's simpler than you think | 14:40 |
| aspiers | e.g. https://review.opendev.org/#/c/644565/11/nova/virt/libvirt/driver.py@1626 | 14:40 |
| aspiers | the only question I'm asking is whether this is the right place to do it | 14:40 |
| kashyap | aspiers: The "single method" thing does make sense to me | 14:40 |
| * kashyap clicks | 14:41 | |
| aspiers | except the single method approach has the issue described above | 14:41 |
| aspiers | (35 mins ago) | 14:41 |
| kashyap | Hm, "maybe not, since other code might want to insist on (say) disabling IOMMU for a specific type of device" | 14:41 |
| kashyap | aspiers: Did you audit what other code will insist disabling IOMMU? Let me quickly check with the RHT virt folks | 14:42 |
| aspiers | kashyap: no, that was a potentially hypothetical future scenario | 14:43 |
| kashyap | As in, for potential gotchas here | 14:43 |
| kashyap | aspiers: So SEV requires IOMMU unconditionally on _all_ virtio devices? | 14:44 |
| *** zbr is now known as zbr|ruck | 14:44 | |
| *** rajinir has joined #openstack-nova | 14:45 | |
| aspiers | kashyap: yes, http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html#proposed-change | 14:46 |
| kashyap | aspiers: So, I looked at the "enable IOMMU at the time of each device configuration" code -- where the check is: *if* bus is 'virtio', then enable IOMMU... | 14:46 |
| *** JamesBenson has joined #openstack-nova | 14:47 | |
| * kashyap clicks | 14:48 | |
| efried | aspiers: My problem with "none of the others change the way guests are created" is that as of patch #3: the inventory is being exposed, the flavor/image syntax is being accepted, and the allocation is being created. The only thing that's *not* happening is... the actual feature. That's bad. | 14:53 |
| *** Sundar has joined #openstack-nova | 14:53 | |
| aspiers | efried: OK. Totally open to suggestions for how to fix that | 14:53 |
| efried | aspiers: You can put the os-traits bump in whatever patch first needs it. That's fine. | 14:53 |
| *** JamesBenson has quit IRC | 14:53 | |
| stephenfin | jangutter, sean-k-mooney, ralonsoh: I've royally confused myself again (every damn time) - either of you care to remind me of the difference between VIF_TYPE_foo and VNIC_TYPE_foo? | 14:53 |
| efried | aspiers: I'm saying that exposing the inventory is a nice master switch, because without it, there's zero expectation of anything else working. | 14:54 |
| aspiers | efried: o-r-c not o-t, but yeah sure, I can split the o-r-c patch in two | 14:54 |
| stephenfin | I think one refers to the backend that handles the VIF, while the other determines how it's actually attached to the instance. Right? | 14:54 |
| aspiers | efried: wfm | 14:54 |
| jangutter | stephenfin: VNIC_TYPE can in theory be set by the user, where VIF type is behind the scenes. | 14:55 |
| efried | aspiers: As far as I'm concerned, we can *always* bump ot and orc to latest. (In other projects we've implemented canary tests that will fail as soon as a new release comes through upper-constraints.) | 14:55 |
| aspiers | efried: yup, makes sense | 14:55 |
| efried | aspiers: So for my money, you could do that in its own patch on the bottom, and not even have to tag it against this blueprint. | 14:55 |
| jangutter | stephenfin: VNIC is an _attribute_ of the VIF. | 14:55 |
| Sundar | sean-k-mooney, mriedem, gibi, johnthetubaguy: There has been further discussion on Line 276 of https://review.opendev.org/#/c/603955/14. That seems to be the sole point to address before this spec is merged. Please take a look. Thanks. | 14:56 |
| stephenfin | jangutter: So in theory any VIF type could use one of the...six VNIC types we provide? | 14:57 |
| jangutter | stephenfin: there are two checks I think. Neutron has to allow it, and Nova has to translate it right from Neutron. | 14:57 |
| stephenfin | Yeah, in theory but not in practice | 14:58 |
| jangutter | stephenfin: there's no easy way to answer the question: "does this cloud support this VNIC type" without trying to spawn an instance. | 14:58 |
| openstackgerrit | Matt Riedemann proposed openstack/os-traits master: Add COMPUTE_SAME_HOST_COLD_MIGRATE trait https://review.opendev.org/666604 | 14:58 |
| jangutter | stephenfin: your first NACK might be neutron saying "this combination of driver + vnic type is not valid". But it could go right up to Nova failing to find a free PCI device conforming to the NUMA topology. | 14:59 |
| stephenfin | How did I ever get dragged into this stuff? :D | 15:00 |
| kashyap | aspiers: I need to get back to this, afraid. Saddled with another meeting | 15:00 |
| aspiers | kashyap: np | 15:00 |
| stephenfin | jangutter: That does clarify some things | 15:00 |
| stephenfin | ...though | 15:00 |
| jangutter | stephenfin: in them olden days, I think there was a field that you could set that could select e1000 or realtek or something. | 15:00 |
| jangutter | stephenfin: confusingly that was called vif type. | 15:01 |
| kashyap | aspiers: But I _did_ ask the question to libvirt folks if there's any other way than injecting the "IOMMU on" at device config time | 15:01 |
| kashyap | [If the device is 'virtio'] | 15:01 |
| aspiers | kashyap: thanks for that | 15:01 |
| gibi | Sundar: do you mean L376 ? | 15:01 |
| kashyap | I'll keep you posted | 15:01 |
| aspiers | kashyap: I don't expect there to be. I was more wondering whether it should be done device by device, or near the end of instance config time, after all devices have already been constructed | 15:02 |
| Sundar | gibi: Yes, sorry for the typo | 15:02 |
| aspiers | kashyap: but this is just a matter of how to construct the guest XML | 15:02 |
| gibi | Sundar: OK, reading the discussion | 15:02 |
| Sundar | Thanks | 15:02 |
| kashyap | aspiers: While I'm zoned out on the call, a quick questioN: | 15:02 |
| kashyap | ... | 15:02 |
| kashyap | if ('virtio' in info['bus'] and | 15:02 |
| kashyap | self._sev_required(...): | 15:02 |
| kashyap | cfg.driver_iommu = True | 15:02 |
| kashyap | ... | 15:02 |
| *** JamesBenson has joined #openstack-nova | 15:03 | |
| kashyap | aspiers: Shouldnt that be "or", instead of "and"? | 15:03 |
| aspiers | no | 15:03 |
| aspiers | from the spec: "The iommu attribute is on for all virtio devices. Despite the name, this does not require the guest or host to have an IOMMU device, but merely enables the virtio flag which indicates that virtualized DMA should be used. This ties into the SEV code to handle memory encryption/decryption, and prevents IO buffers being shared between host and guest." | 15:04 |
| *** factor has joined #openstack-nova | 15:04 | |
| jangutter | stephenfin: Neutron's checks can look like this: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L80 | 15:04 |
| *** factor__ has quit IRC | 15:05 | |
| kashyap | aspiers: I see, thanks for the context. | 15:06 |
| *** ivve has quit IRC | 15:07 | |
| mriedem | Sundar: replied | 15:07 |
| *** factor has quit IRC | 15:08 | |
| *** factor has joined #openstack-nova | 15:08 | |
| Sundar | mriedem: Thanks. "If we agree to add a "fail on binding timeout" option" --> IUC, you are not saying that the option must be added. Only that, if we were to add it, it should be named a certain way, right? | 15:10 |
| *** pcaruana has quit IRC | 15:14 | |
| *** cfriesen has joined #openstack-nova | 15:14 | |
| melwitt | mriedem: thanks, replied and +W on the bottom change | 15:15 |
| *** dklyle has joined #openstack-nova | 15:16 | |
| *** davidsha has quit IRC | 15:16 | |
| *** priteau has quit IRC | 15:16 | |
| mriedem | Sundar: correct, though i tend to think we should add that option | 15:17 |
| mriedem | melwitt: thanks | 15:17 |
| *** priteau has joined #openstack-nova | 15:18 | |
| aspiers | efried: what else needs to go in https://review.opendev.org/#/c/664397/ ? | 15:19 |
| efried | aspiers: Nothing currently known. Could approve it now, or could wait until we're pretty sure the series is a go. | 15:20 |
| aspiers | efried: let's get it in now - I can easily submit follow-ups if needed | 15:20 |
| efried | okay, +2 (someone else still needs to push it) | 15:21 |
| aspiers | thanks | 15:21 |
| aspiers | stephenfin maybe? | 15:21 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 15:22 |
| aspiers | efried: ^^^ s/ers/ed/ | 15:23 |
| efried | +2 | 15:23 |
| stephenfin | aspiers: Sure, but not for another hour at least | 15:24 |
| aspiers | stephenfin: np | 15:24 |
| gibi | Sundar: replied too | 15:25 |
| *** ttsiouts has quit IRC | 15:29 | |
| *** ttsiouts has joined #openstack-nova | 15:30 | |
| *** ttsiouts has quit IRC | 15:30 | |
| *** ttsiouts has joined #openstack-nova | 15:30 | |
| Sundar | gibi: Thanks. I responded back. Please take a look. Happy to answer any questions you may have. | 15:31 |
| *** helenafm has quit IRC | 15:31 | |
| *** hongbin has joined #openstack-nova | 15:32 | |
| gibi | Sundar: replied. If the VM cannot use the accelerator when it is finally bound then I dont see why we let the VM boot up | 15:33 |
| *** ttsiouts has quit IRC | 15:35 | |
| mriedem | Sundar: gibi: replied as well | 15:36 |
| mriedem | i didn't realize that we have to wait for the bind event to then get config information to put into the domain xml for the guest, | 15:36 |
| mriedem | that is a difference from how the port binding event loop works with nova - with ports we have the config to build the domain xml before the plugged event happens | 15:36 |
| mriedem | we're just waiting for neutron to tell us that we're ok to proceed | 15:36 |
| gibi | mriedem, Sundar: yeah that seems like a big difference to em | 15:37 |
| gibi | me | 15:37 |
| mriedem | in that case i agree if we have to wait to get the necessary information to build the domain xml, and if we timeout and don't have that information, then we need to fail | 15:37 |
| Sundar | gibi, mriedem: Agreed. The analogy with Neutron does not hold here (as in many other cases). So, we all agree to leave out the arq_bind_timeout_is_fatal option, right? | 15:38 |
| gibi | I agree to leave that config out | 15:38 |
| sean-k-mooney | well it kind of does but in a diffeernt way | 15:39 |
| sean-k-mooney | we dont know how to generate teh xml until after we bind the port | 15:39 |
| sean-k-mooney | the delta is that binding is asyconus for cyborge | 15:39 |
| sean-k-mooney | for neutron we get the vif_type back synconouly when we call the bind api | 15:40 |
| sean-k-mooney | so we dont need to wait for it to be plugged | 15:40 |
| mriedem | yeah we're confusing bind and plug here | 15:40 |
| sean-k-mooney | but ya if we timeout i think we need to fail | 15:40 |
| sean-k-mooney | because we cant generate the xml without the info form cyborg | 15:41 |
| Sundar | sean-k-mooney, mriedem, gibi: Thanks, and agreed. So, once I fix the formatting issues that mriedem mentioned, we are ready to merge this one, right? | 15:42 |
| sean-k-mooney | i dont have any outstanding issue with the current version | 15:42 |
| sean-k-mooney | ignoring formating | 15:42 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add a new CONF.libvirt.num_memory_encrypted_guests option https://review.opendev.org/662105 | 15:42 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 15:42 |
| mriedem | Sundar: the formatting can be a follow up, i'll +2 | 15:43 |
| gibi | Sundar: I will +2 it after the config is dropped | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV https://review.opendev.org/636318 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' /> https://review.opendev.org/644564 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required https://review.opendev.org/662557 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/666616 | 15:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Document AMD SEV support for encrypted VMs in libvirt https://review.opendev.org/666617 | 15:43 |
| sean-k-mooney | gibi: it was droped in the latest version i think | 15:43 |
| gibi | sean-k-mooney: ahh, there is a newer ps, ... | 15:43 |
| sean-k-mooney | uless there has been another version since i last looked | 15:43 |
| aspiers | efried: ^^^ master switch floated to top, just under a new WIP docs patch (which could be squashed into the switch later) | 15:44 |
| melwitt | gibi: I dunno if you saw my ping from yesterday, your review would be appreciated on this involved func test https://review.opendev.org/631294 where I have wondered if there are any simplifications you could spot because it's quite large and complicated IMHO | 15:44 |
| Sundar | PS15 is the latest, and it drops the config under discussion | 15:44 |
| mriedem | gibi: sean-k-mooney: yeah he dropped it in PS15, we're just discussing in PS14 | 15:44 |
| gibi | melwitt: I missed your ping. Put put that patch in my queue | 15:44 |
| mriedem | Sundar: +Workflowed, congratulations, you can open some champagne now. | 15:45 |
| mriedem | edleafe might still have some in the trunk of his car | 15:45 |
| *** gyee has joined #openstack-nova | 15:45 | |
| melwitt | gibi: thanks much | 15:46 |
| gibi | mriedem: nothing is better during the summer than a glass of warm champagne :) | 15:46 |
| Sundar | mriedem: I drank all the champagne after the PTG :P | 15:47 |
| * Sundar heads to edleafe's car | 15:47 | |
| Sundar | mriedem, gibi, sean-k-mooney, efried, all: Thanks very much for your discussion and feedback. Learnt a lot (including patience ;) ) | 15:49 |
| gibi | Sundar: thank you for your perseverance! | 15:50 |
| *** NobodyCam_ has joined #openstack-nova | 15:55 | |
| *** ohwhyosa- has joined #openstack-nova | 15:55 | |
| *** masayukig_ has joined #openstack-nova | 15:55 | |
| *** dasp_ has joined #openstack-nova | 15:57 | |
| *** gfhellma has joined #openstack-nova | 15:57 | |
| *** rpittau is now known as rpittau|afk | 15:58 | |
| *** sean-k-mooney1 has joined #openstack-nova | 15:58 | |
| edleafe | mriedem: that was cdent with the bubbly. And it was prosecco, I believe | 16:02 |
| * mriedem googles prosecco | 16:02 | |
| *** pcaruana has joined #openstack-nova | 16:02 | |
| mriedem | edleafe: i just like the idea of you driving around texas with a crate of champagne in the trunk of your car | 16:03 |
| openstackgerrit | Merged openstack/nova-specs master: Nova Cyborg interaction specification. https://review.opendev.org/603955 | 16:03 |
| *** masayukig has quit IRC | 16:03 | |
| *** NobodyCam has quit IRC | 16:03 | |
| *** ohwhyosa has quit IRC | 16:03 | |
| *** dasp has quit IRC | 16:03 | |
| *** szaher has quit IRC | 16:03 | |
| *** med_ has quit IRC | 16:03 | |
| *** mvkr has quit IRC | 16:03 | |
| *** sean-k-mooney has quit IRC | 16:03 | |
| *** NobodyCam_ is now known as NobodyCam | 16:03 | |
| *** masayukig_ is now known as masayukig | 16:03 | |
| *** damien_r has quit IRC | 16:03 | |
| *** jangutter has quit IRC | 16:03 | |
| edleafe | mriedem: Sheesh, with temperatures these days over 100F, it would be exploding in my trunk | 16:08 |
| cdent | Big Ed's Champagne and Nosh. We deliver. | 16:09 |
| *** szaher has joined #openstack-nova | 16:09 | |
| *** mvkr has joined #openstack-nova | 16:10 | |
| aspiers | Exception occurred: | 16:10 |
| aspiers | File "<frozen importlib._bootstrap_external>", line 455, in _validate_bytecode_header | 16:10 |
| aspiers | ImportError: bad magic number in 'nova.conf.cells': b'\x03\xf3\r\n' | 16:10 |
| aspiers | #wtf | 16:10 |
| aspiers | this is from tox -e docs | 16:10 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.74: Add 'power-update' external event https://review.opendev.org/645611 | 16:11 |
| aspiers | stephenfin: this look familiar to you? https://gist.github.com/aspiers/63ed063899729c46d6fef7f751b92fee | 16:11 |
| stephenfin | aspiers: You've got leftover pyc files and/or __pycache__ directories | 16:12 |
| aspiers | ah ok thanks | 16:12 |
| mriedem | aspiers: kill pyc | 16:14 |
| mriedem | d'oh | 16:14 |
| mriedem | stephenfin: remember when i said something about still having a tox.ini line to delete pycs when building docs? | 16:14 |
| aspiers | yup there was a pyc somewhere | 16:15 |
| stephenfin | I'm not sure why the docs target isn't respecting the PYTHONDONTWRITEBYTECODE option | 16:15 |
| stephenfin | aspiers: Have you recently jumped back through stable branches? | 16:15 |
| aspiers | don't think so | 16:16 |
| sean-k-mooney1 | PYTHONDONTWRITEBYTECODE has issue if you cahnge branches | 16:16 |
| aspiers | it's possible | 16:16 |
| sean-k-mooney1 | unless we backport it to all brances | 16:16 |
| stephenfin | Yeah, that's why I was asking | 16:16 |
| aspiers | I haven't built the docs for a while | 16:16 |
| stephenfin | I had backports proposed somewhere | 16:16 |
| sean-k-mooney1 | that is why i prefered the find command | 16:16 |
| aspiers | but I used --recreate and that didn't help, I had to remove .pyc from nova/ | 16:16 |
| stephenfin | Yeah, all the backports are there | 16:16 |
| stephenfin | and Google doesn't help | 16:17 |
| sean-k-mooney1 | the backport will only help if you have a clean repo | 16:17 |
| sean-k-mooney1 | and you dont use the repor for devstack | 16:17 |
| sean-k-mooney1 | but ya | 16:17 |
| *** lyarwood has quit IRC | 16:18 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/609460 | 16:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Skip most of 'get_base_config' if not using virtio https://review.opendev.org/666629 | 16:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630 | 16:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631 | 16:18 |
| stephenfin | dansmith: I think that's closer to what you were looking for ^ | 16:19 |
| dansmith | stephenfin: ack, lemme pull that down and poke at that other test | 16:20 |
| dansmith | but probably | 16:20 |
| sean-k-mooney1 | stephenfin: ya https://review.opendev.org/#/c/609460/4/nova/virt/libvirt/vif.py look logically correct | 16:21 |
| dansmith | stephenfin: okay, so on the test... | 16:24 |
| dansmith | er, wait, lemme try something | 16:24 |
| *** ccamacho has quit IRC | 16:25 | |
| *** factor has quit IRC | 16:26 | |
| stephenfin | sean-k-mooney1: You should take a look at https://review.opendev.org/#/c/666630/ at some point too, if possible. I've been wanting to do that for as long as I've known it | 16:30 |
| dansmith | stephenfin: okay, yeah, nevermind | 16:30 |
| stephenfin | dansmith: On the same note, you'll probably like https://review.opendev.org/#/c/666629/ too (it's the same principle) | 16:34 |
| dansmith | hrm, parallels uses virtio? | 16:37 |
| dansmith | that seems, weird to me. | 16:37 |
| sean-k-mooney1 | paralles have two backens | 16:38 |
| sean-k-mooney1 | one based on openvz container and a vm based one | 16:39 |
| sean-k-mooney1 | they use virtio if you are using the vm based one | 16:39 |
| dansmith | ah | 16:44 |
| dansmith | I only know of the container part I guess | 16:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.opendev.org/666638 | 16:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.opendev.org/666639 | 16:44 |
| *** damien_r has joined #openstack-nova | 16:47 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630 | 16:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631 | 16:48 |
| *** panda has quit IRC | 16:50 | |
| gibi | What will happen in review https://review.opendev.org/#/c/666666 ? We are pretty close to that number | 16:50 |
| *** panda has joined #openstack-nova | 16:52 | |
| sean-k-mooney1 | efried: i responed to your comments on the storageTransfrom as to why i intentionally did it this way. https://review.opendev.org/#/c/665844/1/nova/scheduler/request_filter.py@169 let me know if that is resonable | 16:53 |
| efried | sean-k-mooney1: will look | 16:54 |
| *** gfhellma_ has joined #openstack-nova | 16:56 | |
| sean-k-mooney1 | i do admit the code is somewhat clever which is not always a smart thing to do but i can achive the same intent with multple moduels too | 16:56 |
| *** derekh has quit IRC | 16:58 | |
| *** gfhellma has quit IRC | 17:00 | |
| openstackgerrit | Merged openstack/nova-specs master: Change new image property to hw_mem_encryption https://review.opendev.org/664397 | 17:01 |
| stephenfin | sean-k-mooney1: Want to hit https://review.opendev.org/#/c/666387/1 ? | 17:02 |
| *** factor has joined #openstack-nova | 17:02 | |
| sean-k-mooney1 | ill take a look now | 17:03 |
| sean-k-mooney1 | we dont actully support python 3.4 sp that proably shoudl be 3.5 https://review.opendev.org/#/c/666387/1/doc/requirements.txt | 17:04 |
| sean-k-mooney1 | that said its fine | 17:04 |
| sean-k-mooney1 | let me check upper constratints | 17:04 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Document AMD SEV support for encrypted VMs in libvirt https://review.opendev.org/666617 | 17:05 |
| sean-k-mooney1 | stephenfin: how did the too long titles in teh rst not casue an error? | 17:05 |
| sean-k-mooney1 | do we not have a check for that | 17:05 |
| stephenfin | no idea | 17:05 |
| stephenfin | we don't use doc8, which could catch these | 17:05 |
| stephenfin | though I though Sphinx usually complained about them | 17:06 |
| sean-k-mooney1 | but we do you warn as error for sphinx build | 17:06 |
| sean-k-mooney1 | which i would have assumed would complain | 17:06 |
| sean-k-mooney1 | stephenfin: so this is wrong | 17:07 |
| *** tssurya has quit IRC | 17:07 | |
| sean-k-mooney1 | we should not be setting an upper limit in our requirements file | 17:08 |
| stephenfin | we have to for sphinx on Python 2 | 17:08 |
| sean-k-mooney1 | sphinx is already caped for py2.7 in upperconstraitns to https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L459 | 17:08 |
| stephenfin | It is, but it complains if we don't sync them | 17:08 |
| sean-k-mooney1 | no we cap to 1.8.5 for py27 | 17:08 |
| sean-k-mooney1 | in upper constatints | 17:08 |
| stephenfin | Yup | 17:08 |
| sean-k-mooney1 | we might not be using it in the docs target | 17:09 |
| sean-k-mooney1 | no we should be | 17:09 |
| stephenfin | Propose a patch that touches requirements.txt without modifying the sphinx stuff and see what happens | 17:09 |
| *** whoami-rajat has joined #openstack-nova | 17:09 | |
| stephenfin | the requirements gate job will fail it | 17:09 |
| stephenfin | infra might know why but I just know if we do this, it fixes things | 17:09 |
| sean-k-mooney1 | we should not have teh <2.0.0 however | 17:10 |
| sean-k-mooney1 | we are not ment to cap in repo | 17:10 |
| mriedem | gibi: the end times is what | 17:12 |
| *** tesseract has quit IRC | 17:14 | |
| stephenfin | sean-k-mooney1: I'd suggest proposing a WIP patch without that cap and seeing what happens. There have been a lot of these patches going in across oslo projects lately | 17:14 |
| *** tesseract has joined #openstack-nova | 17:15 | |
| sean-k-mooney1 | stephenfin: well we also use python3 for building docs not python 2 | 17:16 |
| sean-k-mooney1 | so i also dont see why we would need the python 2 version | 17:16 |
| stephenfin | We do if you build docs using tox | 17:16 |
| sean-k-mooney1 | yes which is the only thing we suport | 17:16 |
| *** martinkennelly has quit IRC | 17:16 | |
| sean-k-mooney1 | that is what the pti also requires | 17:16 |
| stephenfin | Right, but other projects use sphinx for things other than building docs | 17:16 |
| stephenfin | for example, oslo_config.sphinxext | 17:17 |
| sean-k-mooney1 | theat project supprot building docs via tox | 17:17 |
| stephenfin | For those projects, we still need to support Python2 | 17:17 |
| sean-k-mooney1 | why | 17:17 |
| sean-k-mooney1 | they can move to running that under python3 | 17:17 |
| sean-k-mooney1 | they need to do that this cycle anyway | 17:18 |
| stephenfin | They can't drop py27 tests | 17:18 |
| stephenfin | and if the project specifies sphinx as a requirement (vs. a test-requirement), it's going to pull in sphinx | 17:19 |
| sean-k-mooney1 | well i guess not until U | 17:19 |
| bnemec | It's kind of irrelevant. The requirements job isn't smart enough to differentiate, so you need the cap whether you support python 2 or not. | 17:19 |
| sean-k-mooney1 | stephenfin: sure | 17:19 |
| sean-k-mooney1 | but upper contratits caps it | 17:19 |
| stephenfin | so attempting to install something like oslo.config on Python 2.7 would no longer be possible | 17:19 |
| sean-k-mooney1 | so it should not be an issue | 17:20 |
| sean-k-mooney1 | it is if you use upper-constratints | 17:20 |
| sean-k-mooney1 | it cap sphix at 1.8.5 | 17:20 |
| stephenfin | I don't know the specifics, but it's not as simple as that unfortunately | 17:20 |
| stephenfin | See what bnemec said | 17:20 |
| stephenfin | The requirements gate job will fail until we fix this | 17:20 |
| sean-k-mooney1 | then we should wait to fix the gate | 17:21 |
| *** luksky has joined #openstack-nova | 17:21 | |
| stephenfin | Perhaps. I never looked into it, tbh | 17:21 |
| stephenfin | Merging these patches seemed easier, particularly given we can drop them again in < 4 (3?) months | 17:21 |
| sean-k-mooney1 | locally master works and im about to push a test patch to verify the gate | 17:21 |
| bnemec | That's a discussion for the requirements team. | 17:21 |
| bnemec | I know they're aware that this is bad, but I don't think they have a solution yet. | 17:22 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: testing docs job https://review.opendev.org/666651 | 17:22 |
| sean-k-mooney1 | bnemec: well if i build with tox on master or with ^ its works | 17:22 |
| bnemec | That won't demonstrate the problem. Make a change to a requirements file. | 17:23 |
| bnemec | Without Stephen's patch it will fail the requirements job. | 17:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.opendev.org/640730 | 17:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.opendev.org/641723 | 17:23 |
| sean-k-mooney1 | then the requirement job is broken | 17:23 |
| sean-k-mooney1 | not the repo | 17:23 |
| stephenfin | sean-k-mooney1: That's kind of what we're saying | 17:23 |
| stephenfin | but | 17:23 |
| bnemec | Again, that's an argument to have with the requirements team. :-) | 17:23 |
| stephenfin | <bnemec> I know they're aware that this is bad, but I don't think they have a solution yet. | 17:23 |
| sean-k-mooney1 | i have noticed and reported that the job does not handel the python version stuff properly | 17:24 |
| sean-k-mooney1 | we spoke about this at the ptg when we wer fixing lower constraits | 17:25 |
| stephenfin | sean-k-mooney1: If you fancy looking into this, by all means. However, if you want to save yourself a few hours of mostly thankless work, this patch and others like it are a good band-aid for this cycle :) | 17:25 |
| stephenfin | and then, come next cycle | 17:25 |
| stephenfin | Boom. Bye bye Python 2.7 | 17:26 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: testing docs job https://review.opendev.org/666651 | 17:26 |
| aspiers | ffs devstack why do you hate me so? | 17:26 |
| * stephenfin drools at the thought of getting to use all the Python 3.5+ goodies | 17:26 | |
| aspiers | good riddance to 2.7 | 17:26 |
| stephenfin | aspiers: Don't worry, it hates everyone | 17:26 |
| aspiers | it hates me more | 17:26 |
| aspiers | it's even refusing to download stuff from files.pythonhosted.org! | 17:27 |
| stephenfin | Good riddance to all manner of encoding issues | 17:27 |
| aspiers | some SSL Certificate verification failure bullshit | 17:27 |
| aspiers | SSLError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/09/f1/93603a26daf7a993a0acbbcfd32afce8b2fdf30a765d5651571ab635969b/etcd3-0.10.0.tar.gz (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:661)'),)) | 17:27 |
| aspiers | no matter that it used to work fine | 17:27 |
| aspiers | pip install of anything fails | 17:28 |
| stephenfin | I've seen that before but only against internal stuff | 17:29 |
| sean-k-mooney1 | stephenfin: its a quick fix but its also againt the sprit of https://github.com/openstack/governance/blob/master/reference/pti/python.rst#constraints we opt in to the requiremetn team managing the upper-constiraits i dont like circumventing that | 17:29 |
| *** penick has quit IRC | 17:30 | |
| sean-k-mooney1 | lets see if the bug is repoduced in the gate first | 17:30 |
| stephenfin | aspiers: The solution internally is setting 'export REQUESTS_CA_BUNDLE=<path to some certs>' but I doubt that's applicable to you | 17:30 |
| sean-k-mooney1 | if so then ill file a bug and we can merge it | 17:30 |
| stephenfin | sean-k-mooney1: Fair. To be clear I think this will happen any time a package we use drops Python 2 support | 17:31 |
| stephenfin | Again, until U | 17:31 |
| sean-k-mooney1 | if that is the cases i really dont want to have to manage this in every repo and we should fix the requiremetns job | 17:32 |
| aspiers | stephenfin: openssl s_client -connect files.pythonhosted.org:443 -prexit | 17:32 |
| aspiers | gives this: | 17:32 |
| aspiers | Verify return code: 9 (certificate is not yet valid) | 17:32 |
| *** ricolin has quit IRC | 17:32 | |
| * aspiers tries a shotgun system upgrade | 17:33 | |
| * aspiers gives up for the day | 17:33 | |
| aspiers | cya tomorrow o/ | 17:33 |
| efried | jroll: see latest response before you start hacking at the bp template | 17:33 |
| efried | s/bp/spec/ | 17:33 |
| *** ociuhandu has quit IRC | 17:34 | |
| *** ralonsoh has quit IRC | 17:41 | |
| *** gfhellma_ has quit IRC | 17:41 | |
| *** priteau has quit IRC | 17:46 | |
| *** cdent has quit IRC | 17:46 | |
| *** tobias-urdin has joined #openstack-nova | 17:47 | |
| jroll | efried: you severely underestimate my work queue if you think I start on anything within the hour :P | 17:47 |
| jroll | oh, that's good news, thanks | 17:48 |
| efried | yahyoubetcha | 17:48 |
| efried | jroll: justification for no spec: no API change, no upgrade impact, no RPC/OVO changes, no new config, etc | 17:49 |
| *** Sundar has quit IRC | 17:49 | |
| efried | mriedem may feel differently | 17:49 |
| jroll | efried: yeah that's fair. I don't mind small specs anyway, so I'm open to either direction | 17:49 |
| efried | heh, except nova-specs will bust you if you don't do the template just right. | 17:50 |
| efried | but sure. | 17:50 |
| sean-k-mooney1 | stephenfin: so http://logs.openstack.org/51/666651/2/check/requirements-check/c8c82c5/job-output.txt.gz#_2019-06-20_17_39_08_900979 is the same issue i spoke to the requirements folks about comming up to RC2 back like 3 months ago | 17:50 |
| *** gfhellma has joined #openstack-nova | 17:50 | |
| jroll | efried: I'm used to nit-picky CI :P | 17:51 |
| sean-k-mooney1 | i hit it when trying to fix nova lower contratits job and found i could not actully use phytion version markers unless they matched upper constritns exactly | 17:51 |
| sean-k-mooney1 | im pretty sure the problem is this | 17:53 |
| sean-k-mooney1 | https://github.com/openstack/requirements/blob/master/global-requirements.txt#L459-L460 | 17:53 |
| sean-k-mooney1 | we should not be listing the max versions there | 17:53 |
| sean-k-mooney1 | that is what is causeign the conflict | 17:54 |
| sean-k-mooney1 | so https://github.com/openstack/requirements/commit/00b2bcf7d664b1526b4eefe157c33113206d6251 is likely the reason all the other porject are broken | 17:55 |
| sean-k-mooney1 | we should have caped just in upper constraitns not in global requiremetns | 17:55 |
| mriedem | sean-k-mooney1: dansmith: it is done https://review.opendev.org/#/c/644881/37 | 17:56 |
| mriedem | efried: jroll: passthrough tpm seems small spec worthy to me, but i can also pass the buck to dansmith | 17:57 |
| sean-k-mooney1 | mriedem: thanks and thanks for rechecking too | 17:58 |
| * jroll really doesn't care | 17:58 | |
| mriedem | we've had specs for less complicated things i'm sure | 17:58 |
| dansmith | yeah | 17:58 |
| *** tesseract has quit IRC | 17:59 | |
| *** tesseract has joined #openstack-nova | 18:01 | |
| *** gfhellma has quit IRC | 18:06 | |
| *** cburgess has joined #openstack-nova | 18:07 | |
| *** cburgess has quit IRC | 18:07 | |
| mriedem | there, i have provided at least a few things that would likely need to be mulled over in a spec | 18:09 |
| mriedem | creating a server with a thing and deleting it is easy, moving the damn thing and what happens when the compute is down and we need to cleanup later is the pain in the ass | 18:09 |
| mriedem | stephenfin: remind me why you think it's better to list every option in the group here https://review.opendev.org/#/c/640730/8/doc/source/admin/vendordata.rst@134 rather than just the group itself and let the operator read through the config option docs? | 18:14 |
| *** spotz has quit IRC | 18:14 | |
| mriedem | previously you said, "While this service happens to have most things nicely grouped, that's not always the case. I realize duplication isn't nice but there's value in having everything grouped in one place. I'd like to keep this, if that's okay" but what is that value? and does it outweigh the duplication? | 18:15 |
| mriedem | sean-k-mooney1: john is totally cool with https://review.opendev.org/#/c/647733/ | 18:21 |
| mriedem | the +1 bot must not have -W filtering | 18:21 |
| sean-k-mooney1 | haha ya... | 18:22 |
| sean-k-mooney1 | i will get to adding the missing test before i sign off today | 18:22 |
| *** igordc has joined #openstack-nova | 18:27 | |
| efried | jroll: oh well, I tried | 18:29 |
| *** igordc has quit IRC | 18:36 | |
| *** spotz has joined #openstack-nova | 18:37 | |
| *** tesseract has quit IRC | 18:37 | |
| *** tesseract has joined #openstack-nova | 18:38 | |
| openstackgerrit | Merged openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.opendev.org/633212 | 18:48 |
| jroll | mriedem: <3 | 18:48 |
| mriedem | jroll: that's not an ironic (as in hipster, not the openstack project) heart is it? is it...true love? | 18:50 |
| jroll | somewhere in the middle, like, I love you in this moment but it is not promised forever :P | 18:50 |
| mriedem | now i'm thinking about david coverdale, great | 18:50 |
| jroll | lol | 18:51 |
| openstackgerrit | Merged openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.opendev.org/633227 | 18:51 |
| Nick_A | what are some potential reasons why metadata would have keys but not password (either in openstack/latest/password or openstack/latest/meta_data.json) when both are used to create the instance? | 19:01 |
| efried | dansmith: Since request_filter.py is fresh in your head, how would you feel about moving the logic in the @trace decorator just into the main loop? | 19:05 |
| efried | so we don't have to remember to decorate every method | 19:06 |
| dansmith | efried: meh, seems like not much to remember and obvious if you're copying, but if you think it's important then okay | 19:06 |
| efried | dansmith: When I was looking at sean-k-mooney1's patch and considering how best it could be done more simply, the fact that the trace was a decorator was slightly in the way of one of the better ways of organizing. Otherwise as you say not a big deal. | 19:07 |
| dansmith | efried: I'm likely biased, but I totes don't see that much organization is needed at this point and prefer to wait for more things to be added so that clear patterns develop | 19:09 |
| sean-k-mooney1 | efried: im not sure if dansmith has seen my patch yet | 19:09 |
| efried | sean-k-mooney1: He did, swhat prompted me to bug him about it :) | 19:10 |
| sean-k-mooney1 | ah i was doing bug assignment | 19:10 |
| sean-k-mooney1 | let me check the patch | 19:10 |
| dansmith | prepare to be overwhelmed with reading material | 19:11 |
| *** psachin has quit IRC | 19:11 | |
| sean-k-mooney1 | haha ok so you agree with erric :) | 19:11 |
| sean-k-mooney1 | am are ye ok with me resturcting the code so ist more like the normal filter-schduler filers instead? | 19:13 |
| dansmith | not really, no | 19:13 |
| sean-k-mooney1 | ok... i can just revert to functions | 19:13 |
| sean-k-mooney1 | and keep it all in one file but i think that is going to get annoying in the medium to long term | 19:14 |
| dansmith | when it gets annoying we can split it up | 19:14 |
| sean-k-mooney1 | well it was already annying me a littel :) but not enought to fight this battel to much | 19:15 |
| sean-k-mooney1 | efried: im going to finish writing the 3 transform (as function not fucntors) and then ill start working on the dirver chagnes to report the tratis and move the filters to the end of the patch series | 19:16 |
| sean-k-mooney1 | i might do the extraction fo the common helper code as a singel patch too and then build on that | 19:18 |
| sean-k-mooney1 | that sound ok with people? | 19:18 |
| dansmith | sean-k-mooney1: the three transforms need only be a single function..hopefully that's what you're planning right? | 19:19 |
| sean-k-mooney1 | i was going to have one function for each to make the testing simplere but i can compess them | 19:19 |
| dansmith | that is way (way) overkill, IMHO and just serves to get us to "annoying" sooner for no benefit :) | 19:20 |
| sean-k-mooney1 | i would prefer to just add another fucntion to the dict everytime we add a new image metadata trait we support | 19:20 |
| dansmith | but they're identical in behavior right? | 19:20 |
| *** markvoelker has joined #openstack-nova | 19:20 | |
| sean-k-mooney1 | i think i can generalise it actully | 19:21 |
| sean-k-mooney1 | the main different is the field they match on and the prefix for the trait | 19:21 |
| dansmith | I don't understand how it's not already generalized, but.. okay | 19:21 |
| sean-k-mooney1 | that was on my todo list for the next versions anyway | 19:21 |
| sean-k-mooney1 | which fucntio were you refering to by the way i plan to have only one filter fucntion transform_image_metadata but ideally i would also have one transfrom function that is paramaterised on teh traits prefix to use and the image metadata value to check | 19:23 |
| dansmith | all you need is one function that inside it has a list of the properties to traitify | 19:24 |
| sean-k-mooney1 | my StorageTrasform object is currently only parmaterised on the key to check but i wanted to refactor to also thake the prefix | 19:24 |
| sean-k-mooney1 | ya ill make it simpelr in the next version | 19:25 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Inline trace_request_filter https://review.opendev.org/666663 | 19:33 |
| efried | dansmith, sean-k-mooney1: ^ | 19:33 |
| dansmith | damn, three away from double devil | 19:33 |
| efried | I should go claim those next few numbers... | 19:33 |
| sean-k-mooney1 | efried: i like that we will actully be using the return value for something outside of the tests | 19:35 |
| efried | sean-k-mooney1: I didn't change anything from what was there before... | 19:35 |
| sean-k-mooney1 | well i guess it was used in teh decorator before | 19:35 |
| efried | yeah | 19:35 |
| sean-k-mooney1 | im updating the docs string in my patch with the input paramaters so ill add a return parmaater to call that out too | 19:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Claim https://review.opendev.org/666666 | 19:36 |
| efried | booya | 19:36 |
| efried | now I just need to find a use for it | 19:36 |
| sean-k-mooney1 | efried: with great power comes epic trolling :P | 19:37 |
| efried | I can't wait | 19:37 |
| mriedem | ooo | 19:37 |
| mriedem | i can almost smell the goats blood | 19:38 |
| efried | I'll be taking offers. Bitcoin and souls only. | 19:38 |
| *** whoami-rajat has quit IRC | 19:39 | |
| *** gfhellma has joined #openstack-nova | 19:39 | |
| mriedem | i'd offer up taylor swift's soul so i don't have to hear that me-e-e-e-e song anymore | 19:39 |
| *** markvoelker has quit IRC | 19:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Claim https://review.opendev.org/666666 | 19:40 |
| efried | kashyap: tbc, the spec in jroll's thread is for a *physical* tpm passthrough, so he doesn't have to wait for the "not-on-disk" feature of *virtual* tpm to become available. | 19:43 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671 | 19:46 |
| * lbragstad shakes fist at efried | 19:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671 | 19:53 |
| *** ivve has joined #openstack-nova | 19:57 | |
| lbragstad | could add some black sabbath links to your docs | 19:57 |
| Nick_A | why would admin password be stored in config drive meta_data.json but not shown in either meta_data.json or password when curling metadata from the guest? | 20:04 |
| *** bbowen has quit IRC | 20:11 | |
| *** gfhellma_ has joined #openstack-nova | 20:17 | |
| *** gfhellma has quit IRC | 20:21 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to AMD SEV guest configs https://review.opendev.org/636318 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | 20:39 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | 20:39 |
| *** damien_r has quit IRC | 20:42 | |
| *** pcaruana has quit IRC | 20:45 | |
| *** eharney has quit IRC | 20:45 | |
| *** markmcclain has quit IRC | 20:50 | |
| *** ivve has quit IRC | 20:51 | |
| aspiers | efried: first pass at series restructuring done | 20:51 |
| *** takashin has joined #openstack-nova | 20:51 | |
| aspiers | I'm sure you'll find things you still don't like :) | 20:51 |
| efried | aspiers: cool. Sorry to be a PITA about this | 20:51 |
| aspiers | np | 20:51 |
| efried | it's the 'master switch' that's the most important thing. | 20:52 |
| aspiers | I may not entirely disagree with your commit boundary preferences, but I agree 100% with the master switch thing, and 1000% with a pedantic approach which achieves high quality results ;-) | 20:52 |
| aspiers | s/disagree/agree/ | 20:52 |
| aspiers | OK, that's enough (actually too much) work for today | 20:53 |
| *** gfhellma_ has quit IRC | 20:53 | |
| aspiers | 10pm and still haven't eaten | 20:53 |
| efried | there must be a magic triangle of pedantry/quality/productivity | 20:53 |
| aspiers | haha | 20:53 |
| aspiers | screw productivity, it's all about pedantry/quality ;-) | 20:53 |
| aspiers | BTW tomorrow may be my last day working on SEV for ~3 weeks since next week is SUSE hackweek, and then I'm off to the USA for 2 weeks holiday | 20:54 |
| efried | ight. | 20:54 |
| aspiers | I think Boris is back around now, so *maybe* he can help progress things while I'm gone | 20:54 |
| efried | aspiers: In your absence, if small things come up, permission to address them without you? | 20:54 |
| aspiers | sure! | 20:54 |
| efried | so like you might (*might*) come back to find this merged | 20:54 |
| aspiers | haha | 20:55 |
| *** markmcclain has joined #openstack-nova | 20:55 | |
| aspiers | well that would be a lovely welcome back, but I'm not expecting it | 20:55 |
| efried | yes, laughter appropriate | 20:55 |
| aspiers | BTW it's looking like I'm being more officially allocated to upstream work from now on | 20:55 |
| aspiers | so this is very good news (for me at least, maybe not for you) | 20:55 |
| efried | nice | 20:56 |
| efried | it is good news for me | 20:56 |
| aspiers | :) | 20:56 |
| efried | been getting kinda breezy around here | 20:56 |
| aspiers | more excuses to be a pedant ;-p | 20:57 |
| *** gfhellma_ has joined #openstack-nova | 20:57 | |
| aspiers | would be great if I got time to hack on that requested_resources stuff, for example | 20:58 |
| aspiers | at the moment I'm slightly feeling the heat on the SEV stuff, as we have some internal deadlines | 20:58 |
| aspiers | not for forcing stuff down upstream's throat, but for reaching something that is functionally near complete downstream | 20:58 |
| aspiers | OK, dinner time. Hopefully zuul CI won't shit all over my latest patchsets :) | 21:00 |
| aspiers | Cya tomorrow o/ | 21:00 |
| *** owalsh has quit IRC | 21:00 | |
| mriedem | having a meeting today? | 21:00 |
| efried | oh, crap, I am completely unprepared. | 21:01 |
| *** lbragstad has quit IRC | 21:27 | |
| efried | hmph, probably no meeting next week due to idempotence day | 21:32 |
| efried | week after next, rather | 21:34 |
| *** gyee has quit IRC | 21:34 | |
| mriedem | i read that as impotence | 21:35 |
| mriedem | which is not something i celebrate in my house | 21:35 |
| mriedem | and on that note, i'm out of here, o/ | 21:36 |
| *** mriedem is now known as mriedem_awau | 21:36 | |
| *** mriedem_awau is now known as mriedem_away | 21:36 | |
| *** markvoelker has joined #openstack-nova | 21:37 | |
| *** markvoelker has quit IRC | 21:42 | |
| *** BjoernT_ is now known as BjoernT | 21:47 | |
| *** bbowen has joined #openstack-nova | 21:49 | |
| *** JamesBenson has quit IRC | 21:52 | |
| *** cdent has joined #openstack-nova | 21:56 | |
| *** slaweq has quit IRC | 21:57 | |
| *** david-lyle has joined #openstack-nova | 22:01 | |
| *** dklyle has quit IRC | 22:01 | |
| *** david-lyle is now known as dklyle | 22:01 | |
| *** owalsh has joined #openstack-nova | 22:05 | |
| *** BjoernT has quit IRC | 22:12 | |
| *** slaweq has joined #openstack-nova | 22:14 | |
| *** slaweq has quit IRC | 22:18 | |
| *** mriedem_away has quit IRC | 22:19 | |
| *** hoonetorg has quit IRC | 22:23 | |
| *** j99 has quit IRC | 22:27 | |
| *** tesseract has quit IRC | 22:35 | |
| *** alex_xu has quit IRC | 22:35 | |
| *** hoonetorg has joined #openstack-nova | 22:37 | |
| *** markvoelker has joined #openstack-nova | 22:38 | |
| *** owalsh has quit IRC | 22:39 | |
| *** owalsh has joined #openstack-nova | 22:39 | |
| *** markvoelker has quit IRC | 22:43 | |
| *** gfhellma__ has joined #openstack-nova | 22:45 | |
| *** mlavalle has quit IRC | 22:45 | |
| *** sean-k-mooney1 has quit IRC | 22:49 | |
| *** gfhellma_ has quit IRC | 22:49 | |
| *** gfhellma_ has joined #openstack-nova | 22:52 | |
| *** sean-k-mooney has joined #openstack-nova | 22:55 | |
| *** gfhellma__ has quit IRC | 22:56 | |
| *** dklyle has quit IRC | 23:02 | |
| *** cdent has quit IRC | 23:03 | |
| *** rajinir has quit IRC | 23:09 | |
| *** rcernin has joined #openstack-nova | 23:11 | |
| *** hongbin has quit IRC | 23:15 | |
| *** tkajinam has joined #openstack-nova | 23:21 | |
| aspiers | efried: you can abandon https://review.opendev.org/#/c/662557/13 too | 23:30 |
| *** owalsh has quit IRC | 23:32 | |
| *** luksky has quit IRC | 23:34 | |
| *** markvoelker has joined #openstack-nova | 23:39 | |
| *** markvoelker has quit IRC | 23:43 | |
| *** owalsh has joined #openstack-nova | 23:49 | |
| *** gfhellma_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!