| *** awalende has joined #openstack-nova | 00:13 | |
| *** awalende has quit IRC | 00:18 | |
| *** alex_xu has joined #openstack-nova | 00:23 | |
| *** brinzhang has joined #openstack-nova | 00:34 | |
| *** markvoelker has joined #openstack-nova | 00:45 | |
| *** markvoelker has quit IRC | 00:50 | |
| *** sapd1_x has quit IRC | 00:55 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 01:03 |
|---|---|---|
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV https://review.opendev.org/636318 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' /> https://review.opendev.org/644564 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required https://review.opendev.org/662557 | 01:03 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 01:03 |
| *** ricolin has joined #openstack-nova | 01:05 | |
| *** Sundar has quit IRC | 01:12 | |
| *** takashin has joined #openstack-nova | 01:19 | |
| *** lbragstad has quit IRC | 01:22 | |
| *** lbragstad has joined #openstack-nova | 01:22 | |
| *** hongbin has joined #openstack-nova | 01:32 | |
| *** _hemna has joined #openstack-nova | 01:35 | |
| *** markvoelker has joined #openstack-nova | 01:46 | |
| *** markvoelker has quit IRC | 01:50 | |
| openstackgerrit | Merged openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | 01:52 |
| *** rajinir has quit IRC | 01:52 | |
| *** _hemna has quit IRC | 02:07 | |
| openstackgerrit | sean mooney proposed openstack/nova master: add StorageTransform class to prefilter https://review.opendev.org/665844 | 02:12 |
| *** _hemna has joined #openstack-nova | 02:42 | |
| *** markvoelker has joined #openstack-nova | 02:46 | |
| *** mgoddard has quit IRC | 02:48 | |
| *** markvoelker has quit IRC | 02:51 | |
| *** kevinluuuuu has joined #openstack-nova | 02:56 | |
| *** mgoddard has joined #openstack-nova | 03:01 | |
| *** tristanC has quit IRC | 03:01 | |
| *** whoami-rajat has joined #openstack-nova | 03:01 | |
| *** tristanC has joined #openstack-nova | 03:04 | |
| *** cfriesen has quit IRC | 03:13 | |
| *** _hemna has quit IRC | 03:16 | |
| *** lbragstad has quit IRC | 03:26 | |
| *** markvoelker has joined #openstack-nova | 03:47 | |
| *** hongbin has quit IRC | 03:47 | |
| *** psachin has joined #openstack-nova | 03:50 | |
| *** markvoelker has quit IRC | 03:52 | |
| *** awalende has joined #openstack-nova | 03:56 | |
| *** udesale has joined #openstack-nova | 04:00 | |
| *** threestrands has joined #openstack-nova | 04:05 | |
| *** brinzh has joined #openstack-nova | 04:13 | |
| *** bhagyashris__ has joined #openstack-nova | 04:14 | |
| *** brinzhang has quit IRC | 04:17 | |
| *** awalende has quit IRC | 04:29 | |
| *** _hemna has joined #openstack-nova | 04:32 | |
| *** janki has joined #openstack-nova | 04:35 | |
| *** markvoelker has joined #openstack-nova | 04:48 | |
| *** markvoelker has quit IRC | 04:52 | |
| *** pcaruana has joined #openstack-nova | 04:56 | |
| *** awalende has joined #openstack-nova | 05:03 | |
| *** _hemna has quit IRC | 05:05 | |
| *** zzzeek has quit IRC | 05:07 | |
| *** awalende has quit IRC | 05:08 | |
| *** zzzeek has joined #openstack-nova | 05:08 | |
| *** rtjure has joined #openstack-nova | 05:24 | |
| *** ivve has quit IRC | 05:29 | |
| *** _hemna has joined #openstack-nova | 05:35 | |
| *** NobodyCam has quit IRC | 05:35 | |
| *** masayukig has quit IRC | 05:36 | |
| *** johnsom has quit IRC | 05:36 | |
| *** csatari has quit IRC | 05:36 | |
| *** NobodyCam has joined #openstack-nova | 05:36 | |
| *** rpittau|afk has quit IRC | 05:36 | |
| *** hogepodge has quit IRC | 05:36 | |
| *** rpittau|afk has joined #openstack-nova | 05:37 | |
| *** csatari has joined #openstack-nova | 05:37 | |
| *** masayukig has joined #openstack-nova | 05:37 | |
| *** hogepodge has joined #openstack-nova | 05:38 | |
| *** johnsom has joined #openstack-nova | 05:38 | |
| *** ratailor has joined #openstack-nova | 05:40 | |
| *** dtantsur|afk is now known as dtantsur | 05:42 | |
| *** Luzi has joined #openstack-nova | 05:44 | |
| *** brinzh has quit IRC | 05:47 | |
| *** brinzhang has joined #openstack-nova | 05:47 | |
| *** markvoelker has joined #openstack-nova | 05:49 | |
| *** udesale has quit IRC | 05:51 | |
| *** udesale has joined #openstack-nova | 05:52 | |
| *** markvoelker has quit IRC | 05:54 | |
| *** _hemna has quit IRC | 06:10 | |
| *** slaweq has joined #openstack-nova | 06:10 | |
| *** brault has joined #openstack-nova | 06:15 | |
| *** janki has quit IRC | 06:15 | |
| *** ratailor has quit IRC | 06:17 | |
| *** ratailor has joined #openstack-nova | 06:19 | |
| *** brinzhang has quit IRC | 06:22 | |
| *** brinzhang has joined #openstack-nova | 06:23 | |
| *** rpittau|afk is now known as rpittau | 06:28 | |
| *** igordc has quit IRC | 06:32 | |
| gibi | sean-k-mooney: regarding os-vif and osprofiler. The idea come up in neutron to profile the timing of vif plug. To be able to do that we need to make sure the osprofiler info is transferred to neutron during the vif plug. So far the patch is a PoC which is missing the neutron part. In the long run we might want to have support for osprofiling vif plug in some way | 06:39 |
| *** ivve has joined #openstack-nova | 06:40 | |
| gibi | sean-k-mooney: it was also discussed yesterday on the neutron performance meeting http://eavesdrop.openstack.org/meetings/neutron_performance/2019/neutron_performance.2019-06-17-16.00.log.html#l-20 | 06:45 |
| *** maciejjozefczyk has joined #openstack-nova | 06:49 | |
| *** markvoelker has joined #openstack-nova | 06:50 | |
| *** hamdyk has joined #openstack-nova | 06:51 | |
| *** dpawlik has joined #openstack-nova | 06:51 | |
| *** markvoelker has quit IRC | 06:54 | |
| *** trident has quit IRC | 06:57 | |
| *** trident has joined #openstack-nova | 06:59 | |
| *** kevinluuuuu has quit IRC | 07:06 | |
| *** luksky has joined #openstack-nova | 07:08 | |
| *** udesale has quit IRC | 07:11 | |
| *** udesale has joined #openstack-nova | 07:11 | |
| *** _hemna has joined #openstack-nova | 07:11 | |
| *** _hemna has quit IRC | 07:16 | |
| *** tesseract has joined #openstack-nova | 07:24 | |
| *** helenafm has joined #openstack-nova | 07:26 | |
| *** jcosmao has quit IRC | 07:33 | |
| *** owalsh has quit IRC | 07:35 | |
| *** owalsh has joined #openstack-nova | 07:35 | |
| *** threestrands has quit IRC | 07:36 | |
| *** jangutter has joined #openstack-nova | 07:38 | |
| *** xek has joined #openstack-nova | 07:41 | |
| openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716 | 07:45 |
| *** _hemna has joined #openstack-nova | 07:48 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix wrong assert methods https://review.opendev.org/665897 | 07:49 |
| *** ralonsoh has joined #openstack-nova | 07:50 | |
| *** markvoelker has joined #openstack-nova | 07:50 | |
| *** tssurya has joined #openstack-nova | 07:55 | |
| *** markvoelker has quit IRC | 07:55 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 07:58 |
| *** takashin has left #openstack-nova | 08:00 | |
| *** spsurya has joined #openstack-nova | 08:01 | |
| *** yan0s has joined #openstack-nova | 08:05 | |
| *** tetsuro has joined #openstack-nova | 08:14 | |
| *** ttsiouts has joined #openstack-nova | 08:16 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785 | 08:21 |
| *** _hemna has quit IRC | 08:22 | |
| *** keerthigd has joined #openstack-nova | 08:24 | |
| *** psachin has quit IRC | 08:24 | |
| *** ociuhandu has quit IRC | 08:25 | |
| *** ttsiouts has quit IRC | 08:29 | |
| *** keerthigd has quit IRC | 08:29 | |
| *** ttsiouts has joined #openstack-nova | 08:29 | |
| *** ttsiouts_ has joined #openstack-nova | 08:30 | |
| *** ttsiouts has quit IRC | 08:30 | |
| *** dklyle has quit IRC | 08:35 | |
| *** david-lyle has joined #openstack-nova | 08:35 | |
| *** priteau has joined #openstack-nova | 08:39 | |
| *** imacdonn has quit IRC | 08:40 | |
| *** imacdonn has joined #openstack-nova | 08:40 | |
| *** ociuhandu has joined #openstack-nova | 08:41 | |
| *** ociuhandu has quit IRC | 08:46 | |
| *** derekh has joined #openstack-nova | 08:47 | |
| *** tkajinam has quit IRC | 08:50 | |
| *** markvoelker has joined #openstack-nova | 08:51 | |
| *** kevinluuuuu has joined #openstack-nova | 08:55 | |
| *** markvoelker has quit IRC | 08:56 | |
| *** helenafm has quit IRC | 08:57 | |
| *** mdbooth has joined #openstack-nova | 09:03 | |
| *** ratailor has quit IRC | 09:14 | |
| *** damien_r has joined #openstack-nova | 09:14 | |
| *** damien_r has quit IRC | 09:15 | |
| *** ociuhandu has joined #openstack-nova | 09:20 | |
| *** martinkennelly has joined #openstack-nova | 09:20 | |
| bhagyashris__ | stephenfin, sean-k-mooney, alex_xu: Hi, I have checked the replies on mailing list and encounter in issue so replied to mailing thread http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007190.html I would like to hear your opinion. | 09:21 |
| *** cdent has joined #openstack-nova | 09:23 | |
| *** damien_r has joined #openstack-nova | 09:25 | |
| *** damien_r has quit IRC | 09:25 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237 | 09:26 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 09:26 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.74: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 09:30 |
| *** panda|off is now known as panda | 09:30 | |
| *** davidsha has joined #openstack-nova | 09:33 | |
| stephenfin | bhagyashris__: Cool, I'll reply now. What email client are you using, btw? It's not quoting replies properly, whatever it is /o\ | 09:33 |
| *** awalende has joined #openstack-nova | 09:34 | |
| *** damien_r has joined #openstack-nova | 09:35 | |
| *** damien_r has quit IRC | 09:35 | |
| bhagyashris__ | stephenfin: actaully I am using outlook in browser so it's not quoting properly, sorry for inconvenience :( | 09:35 |
| stephenfin | bhagyashris__: All good. I was going to point this out (hard learned lesson from my Intel days) but it only applies to the desktop version https://that.guru/blog/sane-outlook/ | 09:36 |
| bhagyashris__ | stephenfin: ohh ok. Thank you ! | 09:42 |
| *** damien_r has joined #openstack-nova | 09:55 | |
| *** damien_r has quit IRC | 09:55 | |
| *** rcernin has quit IRC | 09:57 | |
| bhagyashris__ | stephenfin: Got your reply thank you! Just one question if operator set only ``cpu_shared_set`` then in that case what should happen? Will it be reported as VCPU inventory or it should raise error? | 09:57 |
| stephenfin | It should be ignored for VCPU calculation and a warning raised | 09:58 |
| bhagyashris__ | On Train | 09:58 |
| stephenfin | If cpu_dedicated_set is not defined, then cpu_shared_set should only be used for emulator threads | 09:58 |
| stephenfin | However, I think I addressed this in a previous email by saying it was extremely unlikely that cpu_shared_set would be defined without vcpu_pin_set, since it wouldn't offer any advantage (the emulator thread host cores would overlap with the pinned CPU host cores) | 09:59 |
| bhagyashris__ | stephenfin: no I am talking about if operator sets only ``cpu_shared_set`` in Train on fresh compute node then it should report the VCPU inventory as per the specs | 10:01 |
| *** awalende has quit IRC | 10:01 | |
| bhagyashris__ | Right? | 10:01 |
| stephenfin | Then the spec needs a modification. They also need to set cpu_dedicated_set, even if it's to an empty string | 10:01 |
| *** awalende has joined #openstack-nova | 10:01 | |
| stephenfin | Because otherwise we can't tell the difference between a freshly deployed node and an upgraded node | 10:02 |
| *** damien_r has joined #openstack-nova | 10:02 | |
| bhagyashris__ | stephenfin: ok means on train operator can not set the ``cpu_shared_set`` alone . If it's sets then raised the error that ``cpu_dsedoicated_set`` should be set | 10:03 |
| stephenfin | Not an error, a warning | 10:03 |
| bhagyashris__ | Ok ok | 10:03 |
| stephenfin | Stating that we are ignoring that value and are instead relying on 'vcpu_pin_set', if configured, or reporting all host cores if not | 10:04 |
| stephenfin | From the spec | 10:04 |
| stephenfin | "If the [compute] cpu_dedicated_set config option is not set, a warning will be logged stating that reserved_host_cpus is deprecated and that the operator should set both [compute] cpu_shared_set and [compute] cpu_dedicated_set." | 10:04 |
| bhagyashris__ | Then in that case the inventory reported at placement side will be PCPU=0 and VCPU=0 | 10:04 |
| *** awalende has quit IRC | 10:05 | |
| stephenfin | No, it'll be PCPU = (len(vcpu_pin_set) | len($total_host_cores)) | 10:05 |
| stephenfin | and VCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio | 10:05 |
| stephenfin | i.e. the exact same behavior if cpu_shared_set wasn't defined | 10:05 |
| stephenfin | and cpu_dedicated_set wasn't defined | 10:06 |
| openstackgerrit | zhaixiaojun proposed openstack/python-novaclient master: Modify the url of upper_constraints_file https://review.opendev.org/665934 | 10:06 |
| bhagyashris__ | means if only the ``cpu_shared_set`` is define then in that case inventory should be reported as PCPU = (len(vcpu_pin_set) | len($total_host_cores)) and VCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio | 10:08 |
| bhagyashris__ | ? | 10:09 |
| stephenfin | What's the question? | 10:10 |
| bhagyashris__ | stephenfin: ^ | 10:10 |
| stephenfin | You seem to just be saying exactly what I just said :) | 10:10 |
| bhagyashris__ | stephenfin: my question is if the operator set only ``cpu_shared_set`` in Train on fresh compute node then we will raise the Warning but what inventory will reported at placement side? | 10:11 |
| stephenfin | What I just said | 10:12 |
| stephenfin | PCPU = (len(vcpu_pin_set) | len($total_host_cores)) | 10:12 |
| stephenfin | VCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio | 10:12 |
| bhagyashris__ | Ok got it | 10:12 |
| sean-k-mooney | actully that is not correct | 10:12 |
| bhagyashris__ | But if operator want to use that not as shared then in that case reporting both PCPU and VCPU the inventory is wrong IMO | 10:13 |
| sean-k-mooney | if vcpu_pin_set is not defiend and cpu_dedicated_set is not defiend but cpu_shared_set is then we should only report a singel inventory of VCPU=len(cpu_share_set) | 10:13 |
| stephenfin | Ohhh, you're right | 10:14 |
| sean-k-mooney | and set the inventory allcoation raito as neeeded | 10:14 |
| stephenfin | Sorry bhagyashris__ | 10:14 |
| bhagyashris__ | stephenfin, sean-k-mooney : yeah thats whats my understanding from the spec | 10:14 |
| stephenfin | Yeah, I guess we'd written off the combination of cpu_shared_set being defined and vcpu_pin_set being undefined as "not gonna happen" | 10:15 |
| sean-k-mooney | yes so we dont actly multiple the capasity by the allocation raition since the inventory has an allcoation ration filed seperatly as well | 10:15 |
| sean-k-mooney | stephenfin: cpu_share_set and vcpu_pin_set makes sense when doign cpu pinning | 10:16 |
| sean-k-mooney | as the cpu_shared_set is used for emulator trheads as you know but in that case we report vcpu and pcu based on vcpu_pin_set | 10:17 |
| stephenfin | Agreed. I'm saying cpu_shared_set *without* vcpu_pin_set *doesn't* makes sense when doing CPU pinning | 10:17 |
| sean-k-mooney | well i guess it could | 10:17 |
| sean-k-mooney | no it doesnt | 10:17 |
| sean-k-mooney | you never want teh emulator thread to overlap with the cpu that you can pin too | 10:18 |
| sean-k-mooney | so it only makes sense if you have use vcpu_pin_set to restic what cpus you can pin too | 10:18 |
| stephenfin | Correct | 10:18 |
| *** _hemna has joined #openstack-nova | 10:18 | |
| stephenfin | It's just annoying that we don't have a check to validate that at the moment | 10:18 |
| stephenfin | I wonder if we should add one and backport it? | 10:19 |
| stephenfin | i.e. WARNING: You've set cpu_shared_set without vcpu_pin_set. This is dumb. Stop it. | 10:19 |
| sean-k-mooney | so if cpu_shared_set was defined on its own then it would only make sense in train to model a host that resultss floating vms being confined to a subset of hosts | 10:19 |
| sean-k-mooney | :) | 10:20 |
| sean-k-mooney | i like how bitchy the warning is :) | 10:20 |
| sean-k-mooney | +1 | 10:20 |
| sean-k-mooney | stephenfin: maybe it makes sense to write up a bunch of different configuration in an eterpad with the config args and the expect placmenet inventories which we can use as a set of functional test to implement | 10:22 |
| *** ttsiouts_ has quit IRC | 10:23 | |
| *** ttsiouts has joined #openstack-nova | 10:24 | |
| bhagyashris__ | stephenfin, sean-k-mooney : thank you for you opinion ! I will try to push the patches ASAP. And incase any of any doubts I will ping. | 10:28 |
| *** ttsiouts has quit IRC | 10:28 | |
| *** bhagyashris__ has quit IRC | 10:31 | |
| *** helenafm has joined #openstack-nova | 10:32 | |
| *** brinzhang has quit IRC | 10:32 | |
| *** derekh has quit IRC | 10:42 | |
| *** derekh has joined #openstack-nova | 10:42 | |
| *** bbowen has quit IRC | 10:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104 | 10:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Use consistent URL regex substitution https://review.opendev.org/665949 | 10:47 |
| *** psachin has joined #openstack-nova | 10:48 | |
| *** awalende has joined #openstack-nova | 10:50 | |
| *** awalende has quit IRC | 10:51 | |
| *** _hemna has quit IRC | 10:52 | |
| *** awalende has joined #openstack-nova | 10:52 | |
| *** tetsuro has quit IRC | 10:56 | |
| *** awalende has quit IRC | 10:56 | |
| *** udesale has quit IRC | 10:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518 | 11:04 |
| *** _hemna has joined #openstack-nova | 11:20 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove redundant group host setup https://review.opendev.org/665954 | 11:22 |
| *** ratailor has joined #openstack-nova | 11:28 | |
| *** luksky has quit IRC | 11:30 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512 | 11:33 |
| *** dave-mccowan has joined #openstack-nova | 11:36 | |
| *** awalende has joined #openstack-nova | 11:49 | |
| *** awalende has quit IRC | 11:51 | |
| *** awalende has joined #openstack-nova | 11:52 | |
| *** _hemna has quit IRC | 11:54 | |
| *** awalende has quit IRC | 11:55 | |
| *** luksky has joined #openstack-nova | 12:02 | |
| *** damien_r has quit IRC | 12:03 | |
| *** lpetrut has joined #openstack-nova | 12:05 | |
| *** bbowen has joined #openstack-nova | 12:05 | |
| *** mgariepy has joined #openstack-nova | 12:14 | |
| *** _erlon_ has joined #openstack-nova | 12:17 | |
| *** artom has quit IRC | 12:22 | |
| *** artom has joined #openstack-nova | 12:23 | |
| *** awalende has joined #openstack-nova | 12:23 | |
| *** awalende has quit IRC | 12:27 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | 12:29 |
| *** damien_r has joined #openstack-nova | 12:31 | |
| *** decrypt has joined #openstack-nova | 12:31 | |
| *** udesale has joined #openstack-nova | 12:32 | |
| *** artom has quit IRC | 12:33 | |
| *** artom has joined #openstack-nova | 12:33 | |
| *** damien_r has quit IRC | 12:38 | |
| *** lpetrut has quit IRC | 12:39 | |
| *** mgariepy has quit IRC | 12:39 | |
| *** francoisp has joined #openstack-nova | 12:40 | |
| *** priteau has quit IRC | 12:49 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Grab fresh info from the driver during nova start/stop actions https://review.opendev.org/665975 | 12:49 |
| *** awalende has joined #openstack-nova | 12:53 | |
| *** markvoelker has joined #openstack-nova | 12:55 | |
| *** mgariepy has joined #openstack-nova | 12:55 | |
| *** awalende has quit IRC | 12:56 | |
| *** awalende has joined #openstack-nova | 12:58 | |
| *** markvoelker has quit IRC | 13:00 | |
| *** ratailor has quit IRC | 13:00 | |
| *** awalende has quit IRC | 13:02 | |
| *** awalende_ has joined #openstack-nova | 13:02 | |
| yonglihe | sean-k-mooney: clean up orphan instances, Checking instance nova metadata added: https://review.opendev.org/#/c/627765/ | 13:03 |
| yonglihe | sean-k-mooney: You might want to take a look | 13:03 |
| sean-k-mooney | cool jsut responding to a review but ill look at it next | 13:03 |
| yonglihe | Thanks. | 13:04 |
| *** mriedem has joined #openstack-nova | 13:06 | |
| *** ttsiouts has joined #openstack-nova | 13:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 13:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | 13:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | 13:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function https://review.opendev.org/665976 | 13:07 |
| jangutter | hamdyk: I don't understand https://review.opendev.org/#/c/665965 - I don't see how it's required. | 13:10 |
| yonglihe | add spec "show-server-numa-topology", Got Alex's +2. Hope I can got another +2, thanks guys. https://review.opendev.org/#/c/658716/ | 13:10 |
| *** lbragstad has joined #openstack-nova | 13:11 | |
| hamdyk | jangutter: when we use hostdev (unmanaged device by libvirt), MAC will need to be set outside of Nova | 13:13 |
| jangutter | hamdyk: yes, which is why it's not used? | 13:13 |
| jangutter | hamdyk: for kernel TC offloads, <interface type='hostdev'> is used. | 13:14 |
| hamdyk | we updated the Nova patch | 13:14 |
| sean-k-mooney | right but if you want to delegate the mac managment to os-vif it has to work form multiple vendors and cant depend on the presence of a biforcated driver | 13:15 |
| hamdyk | jangutter: take a look: https://review.opendev.org/#/c/658785/ | 13:15 |
| hamdyk | sean-k-mooney: correct, so now we are setting the MAC for bifurcated drivers | 13:15 |
| sean-k-mooney | do you have a follow up patch that set it for non biforcated driver like i40e | 13:16 |
| hamdyk | sean-k-mooney: and maybe later for non-bifurcated | 13:16 |
| jangutter | hamdyk: you realise that introduces a race condition, right? | 13:17 |
| sean-k-mooney | jangutter: it actully should not. | 13:17 |
| sean-k-mooney | jangutter: we wait for os-vif to plug the vfs before we start teh vm | 13:17 |
| hamdyk | actually we are looking into this (setting MAC for non-biforcated driver) any insights would be great | 13:17 |
| jangutter | sean-k-mooney: ah, so libvirt always pauses? | 13:18 |
| sean-k-mooney | no we call os-vif.plug before we defien the domain in libvirt | 13:18 |
| hamdyk | yes, libvirt waits for event that plugging was successful | 13:18 |
| sean-k-mooney | so we fully complete plug before we ever define the domain in libvirt | 13:18 |
| yonglihe | mriedem: You have all context about this, It may easier for you than other cores. Hope you could have a time slot. Thanks, https://review.opendev.org/#/c/658716/ | 13:18 |
| jangutter | sean-k-mooney: but on reboot? The domain is already defined? | 13:19 |
| sean-k-mooney | oh hard reboot we destroy and redefine the domain | 13:19 |
| *** priteau has joined #openstack-nova | 13:19 | |
| sean-k-mooney | on soft reboot we do not unplug the vf for qemu or ovs | 13:19 |
| hamdyk | so we are good with the patch? | 13:20 |
| sean-k-mooney | not really | 13:20 |
| sean-k-mooney | i would like to check with the ovs folks first | 13:21 |
| sean-k-mooney | unless we can do it in a vendor neutral way i would prefer to do it in libvirt but im open to being conviced | 13:21 |
| jangutter | sean-k-mooney, hamdyk: what happens on upgrade? This would cause an interface type=hostdev to morph to unmanaged PCI passthrough. | 13:22 |
| sean-k-mooney | if the ovs or dpdk folks are open to adding a way to set the mac via ovs in the future the im oke with the patch | 13:22 |
| sean-k-mooney | jangutter: only for this once case correct | 13:22 |
| sean-k-mooney | this code path will not be taken by standard sriov | 13:23 |
| sean-k-mooney | i have not read the nova patch yet | 13:23 |
| sean-k-mooney | but while i want to add a generic sriov driver in os-vif i have not sat down an written it yet | 13:23 |
| jangutter | sean-k-mooney, hamdyk: there's another key point here, OpenStack is not the only user of this type of plugging, it makes sense to put the common code in libvirt. | 13:23 |
| jangutter | sean-k-mooney, hamdyk: If it's in Nova/os-vif, I'd really like to see documentation, (it's just me), so that the reference design prevents other people from making 100 other ways of doing the same. | 13:24 |
| sean-k-mooney | i can live with it being in os-vif infact it solves some race condition that libvirt creates | 13:25 |
| sean-k-mooney | jangutter: we shoudl avoid libvirt ever plugging vif if we can | 13:25 |
| sean-k-mooney | it creates a race between neutron and qemu that cannot be fixed in libvirt by design | 13:25 |
| jangutter | sean-k-mooney: I agree. However, this smells more like a "port-on-the-VM" option than a "port-on-the-Switch". | 13:26 |
| *** damien_r has joined #openstack-nova | 13:26 | |
| sean-k-mooney | the mac address | 13:26 |
| *** _hemna has joined #openstack-nova | 13:27 | |
| sean-k-mooney | yes perhaps but in that case we would be looking at a qemu change right to set the mac | 13:27 |
| jangutter | sean-k-mooney: yep. The confusion comes in that a "let's configure the switch" thing is conflated with "let's configure the virtual thing connected to the switch". | 13:27 |
| hamdyk | so, if OVS/DPDK guys are planning to set the VF MAC in the near future that would be great | 13:27 |
| sean-k-mooney | libvirt is not going to embed a dpdk driver and i dont really want libvirt talking to ovs | 13:27 |
| jangutter | sean-k-mooney: agree 100% | 13:28 |
| sean-k-mooney | hamdyk: im going to ask them on #openvswitch but could you send an email to the openvswich mailing list and ask? im not currently subsribed to it | 13:29 |
| hamdyk | so we need to take care of the edge cases (upgrade, soft reboot if it is a problem) | 13:29 |
| jangutter | sean-k-mooney: I'm definitely not opposed to this with -2, (and I'm definitely not the official gatekeeper for this decision either). | 13:29 |
| sean-k-mooney | hamdyk: soft reboot is fine. | 13:30 |
| sean-k-mooney | hamdyk: upgrades will not modify the xml until the guest reboots | 13:30 |
| hamdyk | sean-k-mooney: will do send the email | 13:30 |
| sean-k-mooney | if they come back and say yes we can add that feature then im ok with proceeding with your patch as a workaound in the short term if we also add a todo to consume the ovs/dpdk feature when available | 13:31 |
| hamdyk | sean-k-mooney: so after the guest reboots, os-vif will do the plugging again then setting the MAC, correct ? | 13:32 |
| sean-k-mooney | hamdyk: i need to revew the nova patch too however | 13:32 |
| *** ttsiouts has quit IRC | 13:32 | |
| sean-k-mooney | hamdyk: on soft reboot no but it does not need too on hard reboot yes | 13:32 |
| hamdyk | I see | 13:32 |
| *** ttsiouts has joined #openstack-nova | 13:33 | |
| sean-k-mooney | soft reboot we just send a achi command to the guest os and dont teardown the vm | 13:35 |
| *** ttsiouts_ has joined #openstack-nova | 13:36 | |
| sean-k-mooney | hard reboot we kill teh runnign vm. unplug all the ports and disk redeine the vm and plug all the port/disk/devices again from scratch as if it was a first boot | 13:36 |
| jangutter | hamdyk: You could split out the _set_config_VIFHostDevice section from https://review.opendev.org/#/c/658785 | 13:37 |
| *** ttsiouts has quit IRC | 13:37 | |
| *** pcaruana has quit IRC | 13:37 | |
| jangutter | hamdyk: That should be pretty non-controversial. | 13:38 |
| *** damien_r has quit IRC | 13:41 | |
| *** psachin has quit IRC | 13:46 | |
| *** udesale has quit IRC | 13:48 | |
| *** udesale has joined #openstack-nova | 13:49 | |
| *** mlavalle has joined #openstack-nova | 13:53 | |
| *** liuyulong has joined #openstack-nova | 13:53 | |
| *** pcaruana has joined #openstack-nova | 13:54 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 13:55 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 13:55 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 13:55 |
| openstackgerrit | Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.opendev.org/608696 | 13:55 |
| *** markvoelker has joined #openstack-nova | 13:56 | |
| *** med_ has joined #openstack-nova | 13:59 | |
| *** _hemna has quit IRC | 14:00 | |
| *** mchlumsky has joined #openstack-nova | 14:00 | |
| hamdyk | jangutter: will do | 14:07 |
| *** liuyulong has quit IRC | 14:07 | |
| *** Luzi has quit IRC | 14:12 | |
| *** markvoelker has quit IRC | 14:15 | |
| *** _hemna has joined #openstack-nova | 14:15 | |
| *** liuyulong has joined #openstack-nova | 14:16 | |
| *** rajinir has joined #openstack-nova | 14:17 | |
| *** bbowen_ has joined #openstack-nova | 14:21 | |
| *** icarusfactor has joined #openstack-nova | 14:23 | |
| *** bbowen has quit IRC | 14:24 | |
| *** bbowen_ is now known as bbowen | 14:24 | |
| *** icarusfactor has quit IRC | 14:25 | |
| *** factor has quit IRC | 14:25 | |
| *** icarusfactor has joined #openstack-nova | 14:25 | |
| *** awalende_ has quit IRC | 14:27 | |
| *** dpawlik has quit IRC | 14:27 | |
| *** awalende has joined #openstack-nova | 14:27 | |
| *** priteau has quit IRC | 14:29 | |
| *** awalende has quit IRC | 14:31 | |
| *** hamdyk has quit IRC | 14:33 | |
| mdbooth | lyarwood: LGTM, but missing unit test I think. | 14:35 |
| *** ttsiouts_ has quit IRC | 14:36 | |
| *** ttsiouts has joined #openstack-nova | 14:37 | |
| *** ohwhyosa has joined #openstack-nova | 14:38 | |
| ohwhyosa | Hello peoples! | 14:38 |
| ohwhyosa | What is the best way to change the keymap in spice / novnc per instance? | 14:38 |
| ohwhyosa | I saw the keymap param in nova.conf and I saw also that it's deprecated | 14:38 |
| ohwhyosa | But that is more global | 14:39 |
| ohwhyosa | Say I have a french person, a german person and an american person accesing their instances, surely they can change the keympa? | 14:39 |
| sean-k-mooney | ohwhyosa: the best way is for them to do it in the os when they log in | 14:40 |
| lyarwood | mdbooth: ack thanks | 14:40 |
| lyarwood | is gerrit dying for anyone else? | 14:40 |
| sean-k-mooney | ohwhyosa: that or they can try and set it in there spice client | 14:40 |
| *** JamesBenson has joined #openstack-nova | 14:40 | |
| ohwhyosa | sean-k-mooney, But then, for example, the cirros pass with a :) at the end becomes complicated, and if the only way they had of accessing the machine was via console they'd be screweeeed | 14:40 |
| ohwhyosa | sean-k-mooney, Thanks anyway! | 14:41 |
| ohwhyosa | Hmmm sean-k-mooney the spice client, the web one? | 14:41 |
| *** ttsiouts has quit IRC | 14:41 | |
| sean-k-mooney | ohwhyosa: no a desktop one | 14:41 |
| sean-k-mooney | you can install a spice client locally and use that to conect to the vm directly | 14:42 |
| sean-k-mooney | that client should be able to set the keymap i think | 14:42 |
| ohwhyosa | sean-k-mooney, great! thanks! | 14:42 |
| *** priteau has joined #openstack-nova | 14:45 | |
| sean-k-mooney | stephenfin: you worked on ^ a bit do we have any documenation that could help | 14:46 |
| *** ttsiouts has joined #openstack-nova | 14:48 | |
| artom | sean-k-mooney, errr, don't think support anything besides the webclient for SPICE | 14:48 |
| artom | Because of the websocket proxy thing | 14:49 |
| artom | The native client would need to understand websockets | 14:49 |
| *** tssurya has quit IRC | 14:49 | |
| sean-k-mooney | im not sure about that i think you can get the direct socket url via the api | 14:50 |
| artom | IIRC you get the websocket HTTP URL | 14:50 |
| sean-k-mooney | but i think you do need to configure you hosts to support it | 14:50 |
| stephenfin | sean-k-mooney: afaik it should be configurable via the VNC/Spice client, if said client supports such a thing | 14:51 |
| sean-k-mooney | maybe im not sure i have used it with novnc in the past | 14:51 |
| stephenfin | noVNC does since version 1.0, I think | 14:51 |
| sean-k-mooney | artom: i would not be surprised if there are spice clients tha tsupprot websocket streams too by they way | 14:52 |
| artom | sean-k-mooney, maybe, but back when I tried https://review.opendev.org/#/c/442040/ there weren't | 14:53 |
| sean-k-mooney | oh ok. is that just a limitation for spice? im pretty sure i have used remote viewer and other clinets to connect to no vnc in the past | 14:54 |
| artom | All consoles, I think | 14:55 |
| artom | Because you can't get to the compute host directly, you need to go through a proxy on the publicly accessible controller | 14:55 |
| *** cfriesen has joined #openstack-nova | 14:55 | |
| artom | And all of our proxies use websockets | 14:55 |
| sean-k-mooney | i could have been using virt-manager to connect via the host... | 14:55 |
| artom | To be able to authenticate the connection first | 14:56 |
| sean-k-mooney | well that the thing i thought we supported directly connecting to the host without the proxy and that was required for non web clients | 14:56 |
| sean-k-mooney | anyway got to grab coffee before a meeting | 14:56 |
| *** bbowen_ has joined #openstack-nova | 14:57 | |
| *** priteau has quit IRC | 14:58 | |
| *** bbowen has quit IRC | 14:59 | |
| *** spsurya has quit IRC | 15:01 | |
| ohwhyosa | thanks sean-k-mooney artom stephenfin !! | 15:03 |
| *** eharney has quit IRC | 15:06 | |
| *** damien_r has joined #openstack-nova | 15:07 | |
| *** gyee has joined #openstack-nova | 15:07 | |
| Nick_A | We are trying to inject passwords and keys with libguestfs-tools. keys work fine but not passwords. tried with config drive on and off. any ideas? | 15:12 |
| *** markvoelker has joined #openstack-nova | 15:12 | |
| *** awalende has joined #openstack-nova | 15:15 | |
| *** _hemna has quit IRC | 15:19 | |
| *** whoami-rajat has quit IRC | 15:21 | |
| *** mrch_ has quit IRC | 15:22 | |
| *** damien_r has quit IRC | 15:26 | |
| *** markvoelker has quit IRC | 15:31 | |
| *** ivve has quit IRC | 15:33 | |
| *** ttsiouts has quit IRC | 15:33 | |
| *** ttsiouts has joined #openstack-nova | 15:34 | |
| *** zbr|ruck is now known as zbr|brb | 15:34 | |
| *** hamzy_ has joined #openstack-nova | 15:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 15:38 |
| *** ttsiouts has quit IRC | 15:38 | |
| *** mgagne has quit IRC | 15:39 | |
| *** d34dh0r53 has quit IRC | 15:39 | |
| *** luksky has quit IRC | 15:39 | |
| *** davidsha has quit IRC | 15:39 | |
| *** NobodyCam has quit IRC | 15:39 | |
| *** rajinir has quit IRC | 15:40 | |
| *** masayukig has quit IRC | 15:40 | |
| *** hamzy has quit IRC | 15:40 | |
| *** d34dh0r53 has joined #openstack-nova | 15:40 | |
| *** dave-mccowan has quit IRC | 15:40 | |
| *** rajinir has joined #openstack-nova | 15:40 | |
| *** masayukig has joined #openstack-nova | 15:40 | |
| *** NobodyCam has joined #openstack-nova | 15:40 | |
| *** awalende has quit IRC | 15:41 | |
| *** awalende has joined #openstack-nova | 15:42 | |
| *** mgagne has joined #openstack-nova | 15:42 | |
| *** efried has quit IRC | 15:44 | |
| *** awalende has quit IRC | 15:46 | |
| Nick_A | virt-customize works, so it seems libguestfs isn't the issue | 15:46 |
| *** hamzy_ is now known as hamzy | 15:48 | |
| *** efried has joined #openstack-nova | 15:49 | |
| *** awalende has joined #openstack-nova | 15:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Additional upgrade clarifications for cpu-resources https://review.opendev.org/666032 | 15:52 |
| *** mdbooth_ has joined #openstack-nova | 15:55 | |
| *** gfhellma has joined #openstack-nova | 15:56 | |
| *** helenafm has quit IRC | 15:56 | |
| *** _erlon_ has quit IRC | 15:57 | |
| *** mdbooth has quit IRC | 15:58 | |
| *** mdbooth_ has quit IRC | 16:00 | |
| *** pcaruana has quit IRC | 16:01 | |
| *** igordc has joined #openstack-nova | 16:03 | |
| *** liuyulong has quit IRC | 16:04 | |
| dansmith | mriedem: can you circle back to this soonishly? https://review.opendev.org/#/c/644881/ | 16:06 |
| mriedem | https://www.youtube.com/watch?v=yKNQzFxV-qg | 16:08 |
| mriedem | mm | 16:09 |
| mriedem | buh | 16:09 |
| mriedem | snuf | 16:09 |
| dansmith | https://www.youtube.com/watch?v=9MOAhnQbC6s | 16:09 |
| mriedem | NSFW | 16:10 |
| *** rpittau is now known as rpittau|afk | 16:14 | |
| *** martinkennelly has quit IRC | 16:17 | |
| *** awalende has quit IRC | 16:19 | |
| *** awalende has joined #openstack-nova | 16:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042 | 16:21 |
| *** vishwanathj has joined #openstack-nova | 16:22 | |
| *** awalende has quit IRC | 16:23 | |
| Nick_A | Is this the place to ask about nova-lxd? | 16:24 |
| dansmith | no. | 16:24 |
| *** gfhellma_ has joined #openstack-nova | 16:27 | |
| sean-k-mooney | Nick_A: nova-lxd is an out of tree dirver that is effectivly only supported by cannonical | 16:27 |
| *** markvoelker has joined #openstack-nova | 16:28 | |
| Nick_A | gotcha | 16:28 |
| sean-k-mooney | Nick_A: https://github.com/openstack/nova-lxd#support-and-discussions looks like they use #lxcontainers | 16:29 |
| Nick_A | having trouble getting initial root passwords injected with it for lxc and with libguestfs for kvm | 16:29 |
| *** gfhellma has quit IRC | 16:30 | |
| sean-k-mooney | Nick_A: its not listed here but it does not work for libvirt lxc https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_set_admin_password | 16:30 |
| sean-k-mooney | Nick_A: so i would not be surprised if it was not supported for lxd also | 16:30 |
| *** yan0s has quit IRC | 16:31 | |
| sean-k-mooney | Nick_A: https://github.com/openstack/nova-lxd/blob/bbdd85d5ce70e9b959c6b70a8ebc704ae41a1a79/doc/source/support_matrix/support-matrix.ini#L245-L260 its marked as unknon in there own documuentation so i dont think its suppored | 16:31 |
| sean-k-mooney | Nick_A: if you are using config drive it might work https://github.com/openstack/nova-lxd/blob/d0faf787d92e20a55faf35ea6d95dd4d7ae7e598/nova/virt/lxd/driver.py#L584-L590 | 16:32 |
| Nick_A | we've been trying with and without config drive | 16:33 |
| Nick_A | reviewing your links thank you | 16:33 |
| sean-k-mooney | ya i would suggest using user-data and cloud init instead | 16:33 |
| sean-k-mooney | file injection is deprecated for some time now | 16:34 |
| *** zbr|brb is now known as zbr|ruck | 16:38 | |
| *** pcaruana has joined #openstack-nova | 16:45 | |
| *** ricolin has quit IRC | 16:46 | |
| *** markvoelker has quit IRC | 16:46 | |
| *** cdent has quit IRC | 16:47 | |
| *** igordc has quit IRC | 16:49 | |
| *** gfhellma_ has quit IRC | 16:52 | |
| *** mgariepy has quit IRC | 16:54 | |
| *** mgariepy has joined #openstack-nova | 16:55 | |
| *** yikun has quit IRC | 16:56 | |
| *** panda has quit IRC | 16:56 | |
| *** altlogbot_0 has quit IRC | 17:00 | |
| *** gfhellma has joined #openstack-nova | 17:01 | |
| *** panda has joined #openstack-nova | 17:01 | |
| *** irclogbot_3 has quit IRC | 17:01 | |
| *** altlogbot_2 has joined #openstack-nova | 17:02 | |
| *** irclogbot_0 has joined #openstack-nova | 17:03 | |
| *** udesale has quit IRC | 17:11 | |
| *** _hemna has joined #openstack-nova | 17:15 | |
| *** gfhellma has quit IRC | 17:18 | |
| *** gfhellma has joined #openstack-nova | 17:18 | |
| *** mrch_ has joined #openstack-nova | 17:19 | |
| *** ociuhandu_ has joined #openstack-nova | 17:24 | |
| *** awalende has joined #openstack-nova | 17:24 | |
| *** dtantsur is now known as dtantsur|afk | 17:25 | |
| *** ociuhandu has quit IRC | 17:26 | |
| *** ociuhandu_ has quit IRC | 17:28 | |
| *** gfhellma has quit IRC | 17:32 | |
| *** slaweq has quit IRC | 17:34 | |
| artom | dansmith, any chance I could get you to revisit https://review.opendev.org/#/c/644881/ hopefully one last time? I've added logging, and commented pointing out where they're happening in gate jobs. Should show that the patch works as intended and alleviate your reluctance to merge something you can't test | 17:35 |
| *** igordc has joined #openstack-nova | 17:35 | |
| dansmith | artom: I poked mriedem above to look at it | 17:35 |
| dansmith | artom: I will after he does | 17:35 |
| artom | dansmith, ack, appreciated | 17:35 |
| *** mdbooth has joined #openstack-nova | 17:36 | |
| artom | Am I the pony in this situation? | 17:36 |
| artom | I've been worse | 17:36 |
| *** whoami-rajat has joined #openstack-nova | 17:37 | |
| dansmith | honestly, I have no idea | 17:41 |
| *** eharney has joined #openstack-nova | 17:44 | |
| *** _hemna has quit IRC | 17:49 | |
| *** awalende has quit IRC | 17:55 | |
| *** awalende has joined #openstack-nova | 17:56 | |
| *** ralonsoh has quit IRC | 17:56 | |
| *** mdbooth has quit IRC | 17:56 | |
| *** awalende_ has joined #openstack-nova | 17:58 | |
| *** awalende has quit IRC | 17:58 | |
| *** markmcclain has quit IRC | 18:00 | |
| *** awalende_ has quit IRC | 18:02 | |
| *** markmcclain has joined #openstack-nova | 18:02 | |
| *** BjoernT has joined #openstack-nova | 18:04 | |
| *** awalende has joined #openstack-nova | 18:05 | |
| *** mdbooth has joined #openstack-nova | 18:05 | |
| *** dpawlik has joined #openstack-nova | 18:06 | |
| *** gfhellma has joined #openstack-nova | 18:09 | |
| mriedem | i'm trying to get some timings on this host_status perf regression before i kill this devstack env and then i'll get on that resize revert change | 18:20 |
| *** vishwanathj has quit IRC | 18:22 | |
| *** _hemna has joined #openstack-nova | 18:25 | |
| *** ociuhandu has joined #openstack-nova | 18:30 | |
| *** slaweq has joined #openstack-nova | 18:31 | |
| *** mdbooth has quit IRC | 18:33 | |
| *** vishwanathj has joined #openstack-nova | 18:35 | |
| *** awalende has quit IRC | 18:35 | |
| *** awalende has joined #openstack-nova | 18:36 | |
| *** ociuhandu has quit IRC | 18:39 | |
| *** awalende has quit IRC | 18:39 | |
| *** derekh has quit IRC | 18:40 | |
| *** awalende has joined #openstack-nova | 18:40 | |
| *** awalende has quit IRC | 18:43 | |
| *** pcaruana has quit IRC | 18:45 | |
| *** slaweq has quit IRC | 18:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042 | 18:56 |
| *** _hemna has quit IRC | 18:59 | |
| *** eharney has quit IRC | 19:01 | |
| *** pcaruana has joined #openstack-nova | 19:05 | |
| *** luksky has joined #openstack-nova | 19:05 | |
| *** vishwanathj has quit IRC | 19:06 | |
| *** decrypt has quit IRC | 19:07 | |
| *** damien_r has joined #openstack-nova | 19:16 | |
| *** bbowen_ has quit IRC | 19:16 | |
| *** damien_r has quit IRC | 19:16 | |
| *** damien_r has joined #openstack-nova | 19:17 | |
| *** efried has quit IRC | 19:21 | |
| openstackgerrit | Merged openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | 19:24 |
| openstackgerrit | Merged openstack/nova master: Fix enabled_filters default value in admin config docs https://review.opendev.org/665751 | 19:24 |
| *** JamesBenson has quit IRC | 19:26 | |
| *** _hemna has joined #openstack-nova | 19:27 | |
| *** JamesBenson has joined #openstack-nova | 19:27 | |
| *** awalende has joined #openstack-nova | 19:29 | |
| *** awalende has quit IRC | 19:32 | |
| *** panda has quit IRC | 19:33 | |
| *** JamesBenson has quit IRC | 19:34 | |
| *** efried has joined #openstack-nova | 19:35 | |
| *** JamesBenson has joined #openstack-nova | 19:36 | |
| openstackgerrit | François Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics https://review.opendev.org/666152 | 19:36 |
| *** _erlon_ has joined #openstack-nova | 19:38 | |
| mriedem | man https://review.opendev.org/#/c/644881/ is still queued after nearly 6 hours | 19:38 |
| openstackgerrit | François Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics https://review.opendev.org/666152 | 19:38 |
| *** awalende has joined #openstack-nova | 19:42 | |
| *** panda has joined #openstack-nova | 19:43 | |
| *** damien_r has quit IRC | 19:45 | |
| *** slaweq has joined #openstack-nova | 19:45 | |
| *** vishwanathj has joined #openstack-nova | 19:54 | |
| *** ivve has joined #openstack-nova | 19:55 | |
| *** gfhellma_ has joined #openstack-nova | 19:58 | |
| *** vishwanathj has quit IRC | 19:59 | |
| *** _hemna has quit IRC | 20:00 | |
| *** gfhellma has quit IRC | 20:02 | |
| *** bbowen_ has joined #openstack-nova | 20:13 | |
| openstackgerrit | Merged openstack/nova master: Deprecate RetryFilter https://review.opendev.org/663953 | 20:19 |
| *** gfhellma has joined #openstack-nova | 20:20 | |
| *** BjoernT has quit IRC | 20:23 | |
| *** gfhellma_ has quit IRC | 20:23 | |
| mriedem | artom: dansmith: well the last time i commented was PS23 and now it's at PS32 so pretty hard to do a diff (unless I eyeball the patch sets in separate tabs), but i think i've found enough to -1 for now anyway | 20:24 |
| artom | mriedem, cheers :) | 20:25 |
| artom | (Whoever implements "diff of diffs" for Gerrit will have songs written about them) | 20:25 |
| mriedem | mostly easy stuff | 20:26 |
| mriedem | but you've missed some of the 35 conditionals from the existing libvirt driver _create_domain_and_network logic to determine if we should wait for events | 20:27 |
| artom | Oh only 35? | 20:28 |
| *** _hemna has joined #openstack-nova | 20:28 | |
| *** eharney has joined #openstack-nova | 20:35 | |
| *** mgariepy has quit IRC | 20:36 | |
| * artom won't have time to finish this now, need to think about dinner and daycare taxi | 20:40 | |
| *** dpawlik has quit IRC | 20:52 | |
| *** whoami-rajat has quit IRC | 20:56 | |
| *** _hemna has quit IRC | 21:02 | |
| *** xek has quit IRC | 21:15 | |
| sean-k-mooney | dansmith: im pretty sure i know the answer to this but the order in which https://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L157-L161 is defined is not ment to change the behavior of the prefilters right? | 21:17 |
| sean-k-mooney | because if i reorder that alphabetically then it breaks unit test by changing behvior | 21:18 |
| sean-k-mooney | ALL_REQUEST_FILTERS = [ | 21:19 |
| sean-k-mooney | require_tenant_aggregate, | 21:19 |
| sean-k-mooney | map_az_to_placement_aggregate, | 21:19 |
| sean-k-mooney | require_image_type_support, | 21:19 |
| sean-k-mooney | ] | 21:19 |
| sean-k-mooney | works but | 21:20 |
| sean-k-mooney | LL_REQUEST_FILTERS = [ | 21:20 |
| sean-k-mooney | map_az_to_placement_aggregate, | 21:20 |
| sean-k-mooney | require_image_type_support, | 21:20 |
| sean-k-mooney | require_tenant_aggregate, | 21:20 |
| sean-k-mooney | ] | 21:20 |
| sean-k-mooney | breaks | 21:20 |
| aspiers | ooh, interesting | 21:20 |
| sean-k-mooney | yes .... that is totally the word i would use | 21:21 |
| aspiers | :) | 21:21 |
| sean-k-mooney | :0 | 21:21 |
| sean-k-mooney | i was trying to figure out how i broke the teant az fileter with https://review.opendev.org/#/c/665775/1/nova/scheduler/request_filter.py@195 | 21:22 |
| sean-k-mooney | but then i just reorderd them on master and it also broke | 21:22 |
| aspiers | sean-k-mooney: would you be able to advise me on an OVO problem? | 21:27 |
| sean-k-mooney | aspiers: dansmith in case ye are wondering this aggragte https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L163-L165 gets returned here https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L177 and it should not | 21:27 |
| sean-k-mooney | aspiers: i can try | 21:28 |
| aspiers | sean-k-mooney: so neither of these approaches work https://review.opendev.org/#/c/664420/8..9/nova/virt/hardware.py | 21:29 |
| aspiers | sean-k-mooney: and when I changed to hasattr I got a NotImplemented error from the ovo base class because image_meta.py doesn't implement obj_load_attr() | 21:29 |
| aspiers | I tried copying an implementation from one of the other object classes which just does setattr(self, attrname, None), but that errors because None is not a valid value for image properties | 21:30 |
| aspiers | I think the problem is maybe that while outside test environments, ImageMeta objects always have the "properties" property defined, inside test environments they don't | 21:31 |
| sean-k-mooney | i just did "if key in request_spec.image.properties:" | 21:31 |
| sean-k-mooney | but i could be safe and use .get() | 21:32 |
| aspiers | no, I need to test "if properties in image" | 21:32 |
| aspiers | not for some image property | 21:32 |
| aspiers | see https://review.opendev.org/#/c/664420/9/nova/tests/unit/virt/test_hardware.py@3650 where ImageMeta is constructed without properties | 21:32 |
| aspiers | this seems common in unit tests | 21:32 |
| aspiers | they don't bother to populate all the fields | 21:32 |
| sean-k-mooney | e.g. request_spec.get("image",{}).get("properties",{}).get(key) | 21:32 |
| aspiers | I already tried that, it didn't work | 21:33 |
| aspiers | well, I think it might have worked when starting with a request_spec | 21:33 |
| sean-k-mooney | request_spec.get("image",{}).get("properties") will return none if its not set | 21:33 |
| aspiers | but not when starting with objects.ImageMeta() | 21:33 |
| sean-k-mooney | yes it will | 21:34 |
| aspiers | in test_hardware.py there are no request_specs | 21:34 |
| sean-k-mooney | the base ovo implmentes get for all fileds | 21:34 |
| mriedem | wrong | 21:34 |
| mriedem | only if using the DictCompatMixin | 21:34 |
| aspiers | I will try .get() again but I'm pretty sure I tried that already | 21:35 |
| mriedem | *nova/tests/unit/compute/test_compute_api.py | 21:35 |
| mriedem | oops | 21:35 |
| mriedem | NovaObjectDictCompat | 21:35 |
| mriedem | not everything uses that | 21:35 |
| mriedem | and we actually want to ween things off relying on it | 21:35 |
| aspiers | Ahh interesting | 21:35 |
| aspiers | Yeah, the "object or dict" paradigm kinda seemed weird to me | 21:36 |
| mriedem | ImageMetaProps.get is it's own special thing | 21:36 |
| sean-k-mooney | mriedem: ah your right its in VersionedObjectDictCompat https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L773 | 21:36 |
| mriedem | and ImageMeta doesn't use the dict compat mixin | 21:36 |
| mriedem | and RequestSpec.image is an ImageMeta object | 21:37 |
| mriedem | so you can't do request_spec.get('image', {}).get('properties', {}) | 21:37 |
| sean-k-mooney | ya i was actully just assuming it would always be set when we got to the request filetrs | 21:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 21:38 |
| mriedem | RequestSpec.image should be set when we get to the request filters yes | 21:38 |
| sean-k-mooney | so i personally was planning on jsut doing "if key in request_spec.image.properties:" | 21:38 |
| aspiers | The problem I'm having is with the properties getter not being there at all, not with testing for the existence of an individual property | 21:40 |
| sean-k-mooney | aspiers: in what code | 21:40 |
| aspiers | the first link I pasted above | 21:40 |
| dansmith | sean-k-mooney: I'm really not sure what you're asking, but I can see the ordering of those needing to be specific | 21:40 |
| aspiers | <aspiers> sean-k-mooney: so neither of these approaches work https://review.opendev.org/#/c/664420/8..9/nova/virt/hardware.py | 21:40 |
| mriedem | aspiers: lots of tests don't use full objects b/c they can be a pain in the ass to construct if you don't need a full object for what you're testing, | 21:41 |
| mriedem | as you add code that relies on more things being set in the object, you have to adjust the tests as necessary | 21:41 |
| aspiers | mriedem: yes exactly, I was trying to avoid needing full objects which is why I'm running into this problem | 21:41 |
| mriedem | sure, so you need something like image=objects.ImageMeta(properties=objects.ImageMetaProps())) | 21:41 |
| aspiers | if I use "image_meta.get('properties')" as the test, I get AttributeError: 'ImageMeta' object has no attribute 'get'" | 21:42 |
| mriedem | your code could be defensive and do "if 'properties' in image" but that's not really realistic | 21:42 |
| aspiers | Ah, so I always have to construct an ImageMetaProps inside? | 21:42 |
| aspiers | I thought I saw existing test code which got away without doing that | 21:42 |
| aspiers | but maybe it wasn't doing property lookups like my new code does | 21:42 |
| mriedem | if the code didn't care about accessing properties in the ImageMeta object then it didn't need to | 21:42 |
| sean-k-mooney | dansmith: i guess i can add a comment | 21:42 |
| aspiers | mriedem: OK thanks, I'll try that approach | 21:43 |
| sean-k-mooney | dansmith: basically i was hoping we had not wrote the filter to requrie to be run in a specifc order without documenting it | 21:43 |
| sean-k-mooney | dansmith: espcially when the beahvior changes | 21:43 |
| sean-k-mooney | dansmith: my real question is should i try to make it order independent | 21:44 |
| sean-k-mooney | or should i comment that the order matters and just append my filter to the end | 21:44 |
| dansmith | sean-k-mooney: okay I'm not sure there are any such inter-dependencies at the moment, but I can very much imagine that there could be. it's an internal list, not a configured sequence or anything... | 21:44 |
| mriedem | since those request filters can be disabled i'm not sure why order should matter - i assumed that order wouldn't matter | 21:44 |
| sean-k-mooney | dansmith: ther is a depenc currently | 21:44 |
| dansmith | mriedem: some of them cascade a bit, like the tenant aggregate one | 21:45 |
| mriedem | but is that a side effect of how the tests are written | 21:45 |
| sean-k-mooney | mriedem: no | 21:45 |
| dansmith | I don't understand what the big deal is, I don't think there's any promise that they are or aren't dependent, | 21:45 |
| sean-k-mooney | its actully broken if reorderd | 21:45 |
| dansmith | so unless it breaks if you enable one and not the other and it's not documented, then I don't see the problem | 21:45 |
| *** JamesBenson has quit IRC | 21:46 | |
| dansmith | sean-k-mooney: isn't that like saying you expect you can reorder any code or method calls in other places and be surprised that it breaks? | 21:46 |
| dansmith | no promises means no promises | 21:46 |
| dansmith | if we want to have such promises, then we should document, but if not, why are you surprised? | 21:46 |
| sean-k-mooney | im surprised because i understood that the filter were additive | 21:47 |
| dansmith | s/understood/assumed/ ? | 21:47 |
| * mriedem has to leave | 21:47 | |
| *** mriedem is now known as mriedem_away | 21:47 | |
| *** tesseract has quit IRC | 21:47 | |
| sean-k-mooney | quickly read the code and that what it appeared to be reorded and the unit test broke | 21:47 |
| dansmith | the sequence isn't mutable in a config file, so I don't see why we would make that code more complicated to handle the potential reordering of them, when it's in code | 21:48 |
| sean-k-mooney | the reason we would is so that its easy to extend | 21:48 |
| *** markvoelker has joined #openstack-nova | 21:48 | |
| dansmith | sean-k-mooney: right, but if I quickly read some code and decide I should be able to reorder the code in the live migration routine, it's highly likely that tests will break right? | 21:48 |
| *** ivve has quit IRC | 21:48 | |
| sean-k-mooney | its not the same thing | 21:49 |
| dansmith | why not? | 21:49 |
| dansmith | seems like exactly the same thing to me, except that you made some assumption that it shouldn't be :) | 21:49 |
| sean-k-mooney | mecasue these are filters that extend the request spec | 21:49 |
| dansmith | no, | 21:49 |
| sean-k-mooney | with addtion constratits | 21:49 |
| dansmith | they *mutate* the request spec | 21:49 |
| sean-k-mooney | yes | 21:49 |
| sean-k-mooney | additivly | 21:49 |
| dansmith | so it's entirely expected, IMHO, that changing the order of a set of mutations might end up in a different result | 21:50 |
| dansmith | not additively, that's your implicit assumption :) | 21:50 |
| sean-k-mooney | is it expected that one that adds a constratin on an az an annothe r on a tenatn would allow an aggate that has neither the tenatn or the az set to work | 21:50 |
| sean-k-mooney | that https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L154 is the test that fails | 21:51 |
| sean-k-mooney | aggreate 3 | 21:51 |
| sean-k-mooney | objects.Aggregate( | 21:51 |
| sean-k-mooney | uuid=uuids.agg3, | 21:51 |
| sean-k-mooney | metadata={'other_key': 'owner'})], | 21:51 |
| sean-k-mooney | get retruned in reqspec.requested_destination.aggregates[0] | 21:52 |
| dansmith | this is precisely my point | 21:52 |
| *** awalende has quit IRC | 21:52 | |
| sean-k-mooney | when the order chages but we are requireing the project id and teh ax in the request spec | 21:52 |
| dansmith | pretty much all our unit tests assume that the code runs in a specific ordering | 21:52 |
| dansmith | you think you should be able to reorder those method calls and have the tests not notice, but I have no idea why | 21:52 |
| dansmith | I refer back to my previous example about any random other sequence of code | 21:53 |
| *** awalende has joined #openstack-nova | 21:53 | |
| sean-k-mooney | what i think is broke is i think its not correctly comparing project_id='owner' to filter_tenat_id | 21:53 |
| sean-k-mooney | but maybe im not understanding how that works | 21:53 |
| sean-k-mooney | anyway if this is the expected behavior ill revert the ordering change and add a comment to document that the ordering is important | 21:55 |
| sean-k-mooney | i have not actully read throuhg how those filters actully work line by line | 21:55 |
| sean-k-mooney | so i was just comparing what i changed to determin what could have broken it and then noticed i changed the ordering and asked if it was imporant | 21:56 |
| *** awalende has quit IRC | 21:57 | |
| *** markvoelker has quit IRC | 22:00 | |
| *** gfhellma_ has joined #openstack-nova | 22:00 | |
| *** gfhellma has quit IRC | 22:04 | |
| sean-k-mooney | anyway ill see if i can repoduce the same issue without reordering the filters as a sperate test. | 22:05 |
| sean-k-mooney | the test code and filters seam to be working slightly differently then i thought from first reading | 22:06 |
| *** slaweq has quit IRC | 22:08 | |
| *** mchlumsky has quit IRC | 22:09 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** rajinir has quit IRC | 22:15 | |
| *** slaweq has quit IRC | 22:16 | |
| *** rajinir has joined #openstack-nova | 22:19 | |
| *** _hemna has joined #openstack-nova | 22:21 | |
| *** awalende has joined #openstack-nova | 22:24 | |
| *** gfhellma_ has quit IRC | 22:25 | |
| *** gfhellma_ has joined #openstack-nova | 22:28 | |
| *** awalende has quit IRC | 22:29 | |
| *** icarusfactor has quit IRC | 22:34 | |
| *** icarusfactor has joined #openstack-nova | 22:34 | |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Propose showing server status UNKNOWN when host status UNKNOWN https://review.opendev.org/666181 | 22:36 |
| *** luksky has quit IRC | 22:47 | |
| *** _hemna has quit IRC | 22:48 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification. https://review.opendev.org/603955 | 22:58 |
| *** JamesBenson has joined #openstack-nova | 22:59 | |
| *** tkajinam has joined #openstack-nova | 23:01 | |
| *** awalende has joined #openstack-nova | 23:03 | |
| *** JamesBenson has quit IRC | 23:04 | |
| sean-k-mooney | dansmith: on i figured out what was confusing me | 23:06 |
| sean-k-mooney | the fitler will work in any order | 23:06 |
| *** rtjure has quit IRC | 23:07 | |
| sean-k-mooney | the mock data we are generating in the unit test is not order indepent | 23:07 |
| sean-k-mooney | i missed the fact that if you set the side_effect to an iterable then each time the mocked fucntion is called it will return the next item form that iterable so the results i was seing make sense again. | 23:09 |
| dansmith | this is why I said I'm not aware of any dependencies currently, and that the test expecting that the code runs in a specific order is, you know, pretty common and not a problem to me | 23:10 |
| dansmith | anyway, I gotta run | 23:10 |
| *** rcernin has joined #openstack-nova | 23:16 | |
| *** rcernin has quit IRC | 23:17 | |
| *** _erlon_ has quit IRC | 23:17 | |
| *** rcernin has joined #openstack-nova | 23:18 | |
| openstackgerrit | Merged openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237 | 23:21 |
| openstackgerrit | Merged openstack/nova master: docs: Remove references to nova-consoleauth https://review.opendev.org/652965 | 23:21 |
| openstackgerrit | Merged openstack/nova master: tests: Stop starting consoleauth in functional tests https://review.opendev.org/652966 | 23:21 |
| *** gfhellma_ has quit IRC | 23:31 | |
| *** mlavalle has quit IRC | 23:33 | |
| *** awalende has quit IRC | 23:36 | |
| *** gfhellma_ has joined #openstack-nova | 23:42 | |
| *** gfhellma_ has quit IRC | 23:49 | |
| *** gfhellma_ has joined #openstack-nova | 23:50 | |
| *** gfhellma_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!