| zzzeek | mriedem_away: yep still seems like DROP is slow for millions of rows | 00:25 |
|---|---|---|
| openstackgerrit | Merged openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.opendev.org/574413 | 00:56 |
| *** mriedem_away has quit IRC | 00:57 | |
| *** lbragstad has quit IRC | 01:16 | |
| openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716 | 01:19 |
| *** guozijn has joined #openstack-nova | 01:27 | |
| *** gyee has quit IRC | 01:42 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 01:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 01:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 01:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 01:55 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 01:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 01:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 01:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 01:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 01:57 |
| *** whoami-rajat has joined #openstack-nova | 01:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 01:58 |
| *** igordc has quit IRC | 01:58 | |
| *** markvoelker has joined #openstack-nova | 02:10 | |
| *** markvoelker has quit IRC | 02:14 | |
| *** bnemec has quit IRC | 02:18 | |
| *** bnemec has joined #openstack-nova | 02:29 | |
| *** guozijn has quit IRC | 02:52 | |
| *** ricolin has joined #openstack-nova | 02:54 | |
| *** nicolasbock has quit IRC | 02:59 | |
| *** dave-mccowan has quit IRC | 03:08 | |
| *** bnemec has quit IRC | 03:11 | |
| *** bnemec has joined #openstack-nova | 03:29 | |
| *** guozijn has joined #openstack-nova | 03:29 | |
| *** boxiang has joined #openstack-nova | 03:41 | |
| *** ysandeep has joined #openstack-nova | 03:47 | |
| *** sapd1_x has joined #openstack-nova | 03:59 | |
| *** sapd1_x has quit IRC | 04:07 | |
| *** guozijn has quit IRC | 04:22 | |
| *** toabctl has joined #openstack-nova | 04:41 | |
| *** tkajinam has quit IRC | 05:03 | |
| *** pcaruana has joined #openstack-nova | 05:03 | |
| *** tkajinam has joined #openstack-nova | 05:03 | |
| *** tkajinam has quit IRC | 05:04 | |
| *** ricolin has quit IRC | 05:05 | |
| *** igordc has joined #openstack-nova | 05:06 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | 05:06 |
| *** tkajinam has joined #openstack-nova | 05:07 | |
| *** rcernin has quit IRC | 05:07 | |
| *** amodi has quit IRC | 05:08 | |
| *** _alastor_ has joined #openstack-nova | 05:20 | |
| *** dpawlik has joined #openstack-nova | 05:25 | |
| *** takashin has quit IRC | 05:29 | |
| *** tkajinam_ has joined #openstack-nova | 05:33 | |
| *** tkajinam has quit IRC | 05:36 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure https://review.opendev.org/661466 | 05:48 |
| *** burt has quit IRC | 05:48 | |
| *** dtantsur|afk is now known as dtantsur | 05:52 | |
| *** igordc has quit IRC | 05:52 | |
| *** lpetrut has joined #openstack-nova | 06:03 | |
| *** _alastor_ has quit IRC | 06:03 | |
| *** dpawlik has quit IRC | 06:08 | |
| *** dpawlik has joined #openstack-nova | 06:08 | |
| *** rcernin has joined #openstack-nova | 06:10 | |
| *** sapd1_x has joined #openstack-nova | 06:11 | |
| *** luksky has joined #openstack-nova | 06:30 | |
| *** xek_ has joined #openstack-nova | 06:34 | |
| *** _alastor_ has joined #openstack-nova | 06:37 | |
| *** dpawlik has quit IRC | 06:43 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:44 | |
| *** itlinux has quit IRC | 06:53 | |
| *** ivve has quit IRC | 07:01 | |
| *** itlinux has joined #openstack-nova | 07:08 | |
| *** awalende has joined #openstack-nova | 07:09 | |
| *** tesseract has joined #openstack-nova | 07:12 | |
| *** hemna has quit IRC | 07:14 | |
| *** hemna has joined #openstack-nova | 07:16 | |
| *** ccamacho has quit IRC | 07:24 | |
| *** ccamacho has joined #openstack-nova | 07:24 | |
| *** itlinux has quit IRC | 07:30 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 07:42 |
| *** tkajinam_ has quit IRC | 07:42 | |
| *** luksky has quit IRC | 07:45 | |
| *** dpawlik has joined #openstack-nova | 07:46 | |
| *** rcernin has quit IRC | 07:52 | |
| *** sapd1_x has quit IRC | 07:58 | |
| *** takashin has joined #openstack-nova | 08:05 | |
| kashyap | efried: Yeah, saw it; responded. Will address. (And yes, that "soft -1" is totally justified. :-)) | 08:16 |
| *** luksky has joined #openstack-nova | 08:29 | |
| *** derekh has joined #openstack-nova | 08:40 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Exclude broken ironicclient versions 2.7.1 https://review.opendev.org/662404 | 08:40 |
| *** janki has joined #openstack-nova | 08:42 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add valid compute nodes with host and/or node in api layer https://review.opendev.org/661237 | 08:43 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 08:43 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add compute_nodes_uuid field to Destination object https://review.opendev.org/661188 | 08:43 |
| openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 08:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 09:00 |
| *** sapd1_x has joined #openstack-nova | 09:19 | |
| openstackgerrit | Balazs Gibizer proposed openstack/os-traits master: Add COMPUTE_NET_VF_PARENT_NAME_REPORTING trait https://review.opendev.org/658852 | 09:21 |
| *** tstrul has joined #openstack-nova | 09:21 | |
| *** panda is now known as panda|ruck | 09:24 | |
| *** takashin has left #openstack-nova | 09:31 | |
| *** cdent has joined #openstack-nova | 09:33 | |
| *** ociuhandu has joined #openstack-nova | 09:33 | |
| *** stakeda has quit IRC | 09:37 | |
| *** boxiang has quit IRC | 09:41 | |
| *** janki has quit IRC | 09:46 | |
| *** janki has joined #openstack-nova | 09:48 | |
| *** janki has quit IRC | 09:49 | |
| *** janki has joined #openstack-nova | 09:50 | |
| *** janki has quit IRC | 09:52 | |
| *** janki has joined #openstack-nova | 09:53 | |
| *** ysandeep has quit IRC | 10:01 | |
| *** janki has quit IRC | 10:02 | |
| *** janki has joined #openstack-nova | 10:03 | |
| *** janki has quit IRC | 10:04 | |
| *** cdent has quit IRC | 10:05 | |
| *** guozijn has joined #openstack-nova | 10:25 | |
| *** guozijn has quit IRC | 10:34 | |
| *** cdent has joined #openstack-nova | 10:39 | |
| *** pmannidi has quit IRC | 10:41 | |
| *** tstrul has quit IRC | 10:48 | |
| *** tbachman has quit IRC | 10:49 | |
| *** sridharg has joined #openstack-nova | 11:00 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201 | 11:02 |
| *** sapd1_x has quit IRC | 11:18 | |
| *** dave-mccowan has joined #openstack-nova | 11:25 | |
| openstackgerrit | Merged openstack/nova-specs master: Cap sphinx for py2 to match global requirements https://review.opendev.org/659205 | 11:26 |
| openstackgerrit | Merged openstack/nova-specs master: Bump openstackdocstheme to 1.30.0 https://review.opendev.org/662354 | 11:26 |
| *** tjgresha has quit IRC | 11:30 | |
| *** tjgresha has joined #openstack-nova | 11:33 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Simplfy test setup for TestNovaMigrations* tests https://review.opendev.org/662434 | 11:44 |
| *** nicolasbock has joined #openstack-nova | 11:48 | |
| *** eharney has quit IRC | 11:50 | |
| *** lifeless has quit IRC | 11:51 | |
| *** lifeless has joined #openstack-nova | 11:52 | |
| *** kaiokmo has joined #openstack-nova | 11:56 | |
| *** tbachman has joined #openstack-nova | 12:04 | |
| openstackgerrit | Merged openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.opendev.org/642558 | 12:05 |
| *** logan- has quit IRC | 12:07 | |
| *** logan- has joined #openstack-nova | 12:07 | |
| *** cdent has quit IRC | 12:13 | |
| *** openstack has joined #openstack-nova | 12:28 | |
| *** ChanServ sets mode: +o openstack | 12:28 | |
| *** yankcrime has joined #openstack-nova | 12:28 | |
| kashyap | stephenfin: or anyone: Can you put this through its misery? Already has +2 from Eric: https://review.opendev.org/#/c/639091/ | 12:29 |
| kashyap | ("libvirt: Rework 'EBUSY' (SIGKILL) error handling code path") | 12:29 |
| *** yaawang has quit IRC | 12:30 | |
| *** yaawang has joined #openstack-nova | 12:32 | |
| kashyap | mdbooth: When you can, can I have your your +1 back, too? | 12:33 |
| mdbooth | kashyap: Well I'm not sure I trust you. I need to check you haven't tried to slip anything by me. | 12:34 |
| aspiers | ditto for https://review.opendev.org/#/c/661782/ :) | 12:34 |
| * mdbooth checks diligently | 12:34 | |
| aspiers | haha | 12:34 |
| kashyap | mdbooth: Haha, sure. Distrust away | 12:34 |
| aspiers | mdbooth: He's a slippery one, that kashyap ;-) | 12:34 |
| mdbooth | aspiers: I know! | 12:34 |
| mdbooth | kashyap: You've rephrased your comment! | 12:34 |
| mdbooth | -1 | 12:34 |
| kashyap | mdbooth: Hehe, that was after an elaborate discussion with aspiers | 12:34 |
| aspiers | I mean, he once tried to slip some Perl 4 into nova | 12:35 |
| kashyap | For better clarity :-) | 12:35 |
| * kashyap will remain in undisturbed serenity #stoicism | 12:35 | |
| mdbooth | kashyap: Yeah, that reads a bit better. | 12:35 |
| kashyap | mdbooth: Thanks. *Clear* phrasing is bloody hard work, it never ceases to amaze me. | 12:35 |
| kashyap | aspiers: Hah, now, tell the truth | 12:36 |
| aspiers | OK OK, it's was COBOL | 12:36 |
| aspiers | it, even | 12:36 |
| kashyap | aspiers: "It's COBOL all the way down"! | 12:37 |
| aspiers | :) | 12:37 |
| aspiers | the parent company I just left (Micro Focus) actually is *the* COBOL company these days | 12:37 |
| kashyap | aspiers: https://increment.com/programming-languages/cobol-all-the-way-down/ | 12:37 |
| kashyap | aspiers: I see, didn't know. | 12:38 |
| aspiers | oh yeah, MF mentioned in that article | 12:38 |
| kashyap | aspiers: I'll address Eric's nits (which you agreed with) in a couple of hours. Finishing up something else that is racing against time. | 12:38 |
| aspiers | sure | 12:39 |
| kashyap | aspiers: Unrelated: What terminal font do you use? I'm really enjoying "Liberation Mono Regular" | 12:40 |
| aspiers | http://www.csis.ul.ie/cobol/exercises/Exm-BestSellersRpt/BestSellers.cbl | 12:40 |
| aspiers | OK, now I need to wash my eyes out | 12:40 |
| kashyap | Hehe | 12:41 |
| aspiers | kashyap: https://github.com/aspiers/desktop-config/blob/master/.Xresources.d/terms.rdb#L237 | 12:41 |
| kashyap | So whatever is the default | 12:42 |
| *** BlackDex has quit IRC | 12:46 | |
| stephenfin | kashyap: Done | 12:54 |
| kashyap | stephenfin: Vielen Dank | 12:55 |
| *** BlackDex has joined #openstack-nova | 12:56 | |
| *** mriedem has joined #openstack-nova | 13:05 | |
| mriedem | stephenfin: can you confirm on the todo here to drop the cell_name column https://review.opendev.org/#/c/651309/9/nova/db/sqlalchemy/models.py@343 that you're just talking about from the model and not an actual alter table drop column schema change? | 13:06 |
| *** eharney has joined #openstack-nova | 13:09 | |
| *** BlackDex has quit IRC | 13:10 | |
| *** d34dh0r53 has quit IRC | 13:11 | |
| *** d34dh0r53 has joined #openstack-nova | 13:13 | |
| *** awalende has quit IRC | 13:13 | |
| *** d34dh0r53 has quit IRC | 13:15 | |
| *** d34dh0r53 has joined #openstack-nova | 13:18 | |
| *** BjoernT has joined #openstack-nova | 13:19 | |
| *** igordc has joined #openstack-nova | 13:19 | |
| openstackgerrit | Merged openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.opendev.org/651307 | 13:31 |
| mriedem | sean-k-mooney: you might want to check my comments in here https://review.opendev.org/#/c/661237/3 | 13:31 |
| *** lbragstad has joined #openstack-nova | 13:32 | |
| *** mlavalle has joined #openstack-nova | 13:34 | |
| mriedem | i thought we agreed in the ML to validate the requested node using placement rather than iterating the cells, but maybe that wasn't clear | 13:34 |
| stephenfin | mriedem: I just wanted to indicate that the column was unused and _something_ should be done about it. If that's just a case of removing the model and keeping the actual column, I'm a-ok with it | 13:40 |
| stephenfin | Heck, the thing could stay there forever for all I care. It's just cleanup :) | 13:40 |
| stephenfin | mriedem: Do you want a follow-up to clarify the comment? If so, what would you propose it says? | 13:41 |
| mriedem | per those 2 other changes i linked for internal_id and scheduled_at, it looks like a follow up could just be to comment on the column with a comment saying it's still in the db schema but not used in code so it's removed from the model | 13:43 |
| mriedem | it looks like we actually did a drop column on scheduled_at but never did for internal_id | 13:44 |
| openstackgerrit | Merged openstack/nova master: Remove unnecessary wrapper https://review.opendev.org/651308 | 13:44 |
| mriedem | stephenfin: +W | 13:46 |
| stephenfin | ta | 13:46 |
| mriedem | someone want to get in this very old test patch for dan? https://review.opendev.org/#/c/452006/ | 13:47 |
| openstackgerrit | Merged openstack/nova stable/stein: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/662331 | 13:48 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: DRY up test_rollback_live_migration_set_migration_status https://review.opendev.org/662470 | 13:55 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Restore connection_info after live migration rollback https://review.opendev.org/662471 | 13:55 |
| stephenfin | gibi: Replied to https://review.opendev.org/#/c/660774/3 | 13:56 |
| mriedem | lyarwood: i kicked out the stein release https://review.opendev.org/#/c/656304/ from the gate so we can get https://review.opendev.org/#/c/656304/ into it | 13:59 |
| lyarwood | mriedem: ack thanks | 14:02 |
| *** itlinux has joined #openstack-nova | 14:16 | |
| *** igordc has quit IRC | 14:18 | |
| *** luksky has quit IRC | 14:24 | |
| openstackgerrit | Julia Kreger proposed openstack/nova stable/stein: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662479 | 14:26 |
| *** dpawlik has quit IRC | 14:27 | |
| *** openstackstatus has joined #openstack-nova | 14:34 | |
| *** ChanServ sets mode: +v openstackstatus | 14:34 | |
| mriedem | gibi: thanks for wading into the cross-cell resize series | 14:35 |
| *** JamesBenson has joined #openstack-nova | 14:35 | |
| mriedem | you're brave | 14:35 |
| mriedem | i shall call you beowulf | 14:35 |
| *** igordc has joined #openstack-nova | 14:36 | |
| *** shilpasd has quit IRC | 14:38 | |
| *** jangutter has quit IRC | 14:41 | |
| *** BlackDex has joined #openstack-nova | 14:47 | |
| *** tbachman has quit IRC | 14:48 | |
| kashyap | aspiers: Hey, FWIW, Erik Skultety from libvirt upstream was just inquiring about SEV work. I pointed to the in-progress patch series, and what's remaining. And says: "hopefully I'll find some time to go through the patches thoroughly" | 14:52 |
| aspiers | kashyap: thanks, the more reviews the better! | 14:53 |
| aspiers | kashyap: is he on IRC? | 14:53 |
| *** eharney has quit IRC | 14:53 | |
| kashyap | aspiers: On OFTC (#virt): eskultet | 14:53 |
| efried | aspiers, kashyap: I'm off doing something else but it occurs to me my time right now would be well spent reviewing the os-traits and SEV stuff while y'all are around. | 14:54 |
| efried | is there an update since yesterday? | 14:54 |
| efried | esp on the os-traits side? | 14:54 |
| efried | cause the can't-build-shit thing is getting annoying. | 14:54 |
| kashyap | efried: Hiya, _just_ about to push one | 14:55 |
| efried | ack, please ping when done, thx | 14:55 |
| kashyap | efried: I'm done addressing your remarks. Feel free to nit-pick away | 14:55 |
| efried | feel like we were on the downward slope | 14:55 |
| kashyap | Heh, no. I appreciate the "soft -1" | 14:56 |
| *** lpetrut has quit IRC | 14:56 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193 | 14:58 |
| kashyap | efried: aspiers --^ Did I get it right? | 14:58 |
| kashyap | [I'm here for an hour more, then I need to bike to get some groceries] | 14:59 |
| *** BlackDex has quit IRC | 15:00 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324 | 15:01 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845 | 15:01 |
| openstackgerrit | melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056 | 15:01 |
| *** boxiang has joined #openstack-nova | 15:01 | |
| *** BlackDex has joined #openstack-nova | 15:05 | |
| -openstackstatus- NOTICE: Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running. | 15:08 | |
| *** ChanServ changes topic to "Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running." | 15:08 | |
| *** _alastor_ has quit IRC | 15:09 | |
| *** mlavalle has quit IRC | 15:13 | |
| *** eharney has joined #openstack-nova | 15:14 | |
| *** luksky has joined #openstack-nova | 15:18 | |
| *** maciejjozefczyk has quit IRC | 15:19 | |
| *** boxiang has quit IRC | 15:21 | |
| *** jaosorior has quit IRC | 15:22 | |
| *** macza has joined #openstack-nova | 15:28 | |
| mriedem | gibi: i suspect this bug https://bugs.launchpad.net/nova/+bug/1829479 is a duplicate of the orphaned allocations from wiped evacuated node you worked on, but i'm having a hard time parsing it from the reporter | 15:31 |
| openstack | Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,New] | 15:31 |
| *** tbachman has joined #openstack-nova | 15:33 | |
| *** mdbooth has quit IRC | 15:38 | |
| *** _alastor_ has joined #openstack-nova | 15:40 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/639091 | 15:41 |
| *** mdbooth has joined #openstack-nova | 15:44 | |
| *** cdent has quit IRC | 15:46 | |
| *** bnemec is now known as beekneemech | 15:49 | |
| *** gyee has joined #openstack-nova | 15:50 | |
| *** cdent has joined #openstack-nova | 15:51 | |
| *** sridharg has quit IRC | 15:54 | |
| mriedem | oof the ironic hashring stuff in nova is not documented at all | 15:54 |
| mriedem | re https://bugs.launchpad.net/nova/+bug/1831195 | 15:56 |
| openstack | Launchpad bug 1831195 in OpenStack Compute (nova) "disable one compute service will prevent scheduler to choose the hypervisor the compute service manange" [Undecided,Invalid] | 15:56 |
| mriedem | "i've disabled my nova-compute service managing ironic nodes but still want to schedule stuff there, what gives?!" | 15:57 |
| * cdent blinks | 15:57 | |
| mriedem | i'm assuming they just aren't aware of the hashring | 15:58 |
| *** ChanServ changes topic to "Current runways: https://etherpad.openstack.org/p/nova-runways-train -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 16:00 | |
| aspiers | kashyap: think you missed the s/e\.g\./i.e./ | 16:00 |
| kashyap | aspiers: ****; let me do it. I _knew_ I'd miss something | 16:00 |
| *** eharney has quit IRC | 16:01 | |
| aspiers | :) | 16:01 |
| kashyap | It's not even a nit-pick, it's a logical mistake, so I _want_ to correct it :-) | 16:01 |
| kashyap | Anything else? | 16:01 |
| aspiers | nope | 16:01 |
| aspiers | Not that I can see | 16:01 |
| * aspiers hovers his finger over 'R' | 16:02 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Rework the directory layout; add missing traits https://review.opendev.org/655193 | 16:02 |
| kashyap | aspiers: Hehe, done. | 16:02 |
| * aspiers presses | 16:02 | |
| aspiers | Hrm | 16:03 |
| aspiers | not sure I see a difference | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils' https://review.opendev.org/662501 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects https://review.opendev.org/662502 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController https://review.opendev.org/662503 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils https://review.opendev.org/662504 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505 | 16:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506 | 16:03 |
| * stephenfin needs to stop looking in the dusty corners of nova | 16:03 | |
| aspiers | kashyap: "Uploaded patch set 8: Commit message was updated." | 16:03 |
| aspiers | stephenfin: No technical debt to see here, move along now! | 16:04 |
| kashyap | aspiers: That's it, no? | 16:04 |
| aspiers | Doh | 16:04 |
| aspiers | Yes it is | 16:04 |
| aspiers | +1 | 16:04 |
| aspiers | Hopefully efried likes too | 16:05 |
| mriedem | stephenfin: i really wish you'd ask about that kind of stuff before spending time on doing it | 16:05 |
| stephenfin | Why? | 16:05 |
| mriedem | because that ec2 stuff is used by the out of tree ec2 api stuff | 16:06 |
| mriedem | which as far as i know we haven't agreed, as a team, to deliberatly break | 16:06 |
| *** _alastor_ has quit IRC | 16:06 | |
| stephenfin | I need to double check some of them but codesearch wasn't bringing up hits for a lot of them, and for the others it was bringing up dupes from the ec2 stuff | 16:07 |
| mriedem | ec2api out of tree code won't show hits for things that are internal to nova but necessary for that api to work | 16:07 |
| mriedem | i also noticed https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:hacking-update this morning and it'd be nice, as a courtesy to the core team and others working on nova, to at least raise some of this stuff up in the ML or meeting *before* starting work on it | 16:09 |
| mriedem | i'm not saying i'm against those hacking changes fwiw, just saying they are big changes that once merged will impact everyone so a heads up would be nice | 16:09 |
| mriedem | while i'm ranting, can i get some eyes on https://review.opendev.org/#/q/topic:bug/1830747+(status:open+OR+status:merged) since bauzas is on EU PTO infinitum so i can start backports since that's going to hammer anyone with rescheduled cold migrations / resizes before stein, which is pretty gd nasty | 16:11 |
| mriedem | dansmith: ^ you'd probably be best besides bauzas | 16:11 |
| mriedem | if you're around | 16:11 |
| dansmith | ack | 16:12 |
| mriedem | danke | 16:12 |
| mriedem | and welcome back to the fun house | 16:12 |
| dansmith | heh thanks | 16:13 |
| *** mriedem is now known as mriedem_hangry | 16:14 | |
| stephenfin | mriedem: I get where you're coming from but I really don't agree. If I'm happy to burn an hour on tech debt reduction, my patches are reviewable, and I keep them rebased as conflicts pop up, why not? EAFP and all that | 16:16 |
| stephenfin | hacking being a fair exception since that touches a _lot_ of stuff, sadly | 16:16 |
| stephenfin | I left the comments on https://review.opendev.org/#/c/662501/1/nova/api/ec2/ec2utils.py anyway. That -2 can probably be removed unless I've missed something obvious | 16:17 |
| * stephenfin goes back to wrangling with NUMATopologyFilter | 16:18 | |
| *** eharney has joined #openstack-nova | 16:21 | |
| *** tstrul has joined #openstack-nova | 16:21 | |
| *** dtantsur is now known as dtantsur|afk | 16:22 | |
| *** cdent has quit IRC | 16:25 | |
| dansmith | mriedem_hangry: question I'll probably regret asking in that set | 16:27 |
| *** itlinux has quit IRC | 16:32 | |
| *** mgoddard has quit IRC | 16:35 | |
| sean-k-mooney | stephenfin: are you looking at the resize issue | 16:36 |
| stephenfin | sean-k-mooney: I am | 16:36 |
| stephenfin | sean-k-mooney: Are you? | 16:36 |
| sean-k-mooney | no i know why it happens | 16:36 |
| stephenfin | shoot | 16:36 |
| sean-k-mooney | i looked at the code a few days ago | 16:37 |
| sean-k-mooney | and asked them to file a bz which you triaged but i have filed an upstream bug | 16:37 |
| stephenfin | Got a link? | 16:37 |
| sean-k-mooney | if you want to fix it feel free | 16:37 |
| sean-k-mooney | *have not | 16:37 |
| *** ociuhandu_ has joined #openstack-nova | 16:38 | |
| *** mgoddard has joined #openstack-nova | 16:38 | |
| stephenfin | sean-k-mooney: Want to give the tl;dr? | 16:38 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1038 | 16:39 |
| sean-k-mooney | we use the pagesize form the embeded instance numa toplogy object | 16:39 |
| sean-k-mooney | so in a resize when we do https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L98 | 16:40 |
| stephenfin | sean-k-mooney: Right, which we have one of already https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L74 | 16:40 |
| stephenfin | yeah | 16:40 |
| stephenfin | Why doesn't this hit rebuild though? | 16:40 |
| *** ociuhandu has quit IRC | 16:41 | |
| sean-k-mooney | because its a resize | 16:41 |
| stephenfin | Oh, because the size hasn't changed | 16:41 |
| stephenfin | Yah | 16:41 |
| stephenfin | *yeah | 16:41 |
| stephenfin | *mempage size | 16:41 |
| sean-k-mooney | anyway for a resize we need to update the instance toplogy object with the mem_page_size form the new flavor | 16:42 |
| *** ociuhandu_ has quit IRC | 16:42 | |
| sean-k-mooney | so we can either make a copy of the toplogy and pass that in our maybe use the tempory_mutation decorator | 16:42 |
| stephenfin | I'm trying to figure out what sets it for the requested_topology the first day (i.e. on a server create) | 16:42 |
| sean-k-mooney | i belive we generate it form the flavor but dont fill in all the fields | 16:43 |
| sean-k-mooney | but i didnt look | 16:43 |
| sean-k-mooney | its foming from the sepc_object whic is the request_spec | 16:44 |
| *** tstrul has quit IRC | 16:44 | |
| stephenfin | Must be https://github.com/openstack/nova/blob/master/nova/compute/api.py#L978 | 16:44 |
| stephenfin | which is set by https://github.com/openstack/nova/blob/master/nova/compute/api.py#L876-L877 | 16:45 |
| -openstackstatus- NOTICE: Gerrit is back up and running again. Thank you for your patience and sorry for the delay in this notification (we thought the statusbot was still busy updating channel topics). | 16:47 | |
| stephenfin | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1831269 | 16:50 |
| openstack | Launchpad bug 1831269 in OpenStack Compute (nova) "Resize ignores mem_page_size in new flavor" [Undecided,New] | 16:50 |
| sean-k-mooney | we should proably be updating the request spec here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3558-L3560 | 16:50 |
| sean-k-mooney | which is just before we call resize instnace | 16:51 |
| sean-k-mooney | that or self.compute_task_api.resize_instance should do it | 16:52 |
| *** _alastor_ has joined #openstack-nova | 16:55 | |
| *** derekh has quit IRC | 17:00 | |
| sean-k-mooney | stephenfin: i have triage it upstream and commented on the issue https://bugs.launchpad.net/nova/+bug/1831269 | 17:01 |
| openstack | Launchpad bug 1831269 in OpenStack Compute (nova) "Resize ignores mem_page_size in new flavor" [Medium,Confirmed] | 17:01 |
| sean-k-mooney | stephenfin: it should in theory be a fairly simple fix | 17:02 |
| stephenfin | Yup, it should | 17:02 |
| sean-k-mooney | i think it should be backportable too | 17:03 |
| sean-k-mooney | rebuild is harder to fix | 17:03 |
| stephenfin | I'm not sure why this is passing though https://review.rdoproject.org/r/#/c/11297/11/whitebox_tempest_plugin/api/compute/test_cpu_pinning.py@108 | 17:03 |
| sean-k-mooney | or rather inplace rebuild without the double allocations | 17:03 |
| sean-k-mooney | the downstream bug only happens because the destination host did not have any 2mb hugepages only 1G | 17:04 |
| stephenfin | Actually, maybe it is. But we have a host that actually has enough free CPUs | 17:04 |
| kashyap | efried: aspiers: Thanks for the reviews. | 17:04 |
| *** JamesBenson has quit IRC | 17:04 | |
| *** itlinux has joined #openstack-nova | 17:04 | |
| stephenfin | So we'd start seeing this more when cpu-resources is done, because we might only have limited PCPU inventory | 17:04 |
| aspiers | kashyap: we still need one more +2 | 17:04 |
| aspiers | I guess we should wait for cdent | 17:05 |
| kashyap | aspiers: Right, not sure who can give it. Chris Dent? | 17:05 |
| kashyap | Bingo | 17:05 |
| *** _alastor_ has quit IRC | 17:05 | |
| *** JamesBenson has joined #openstack-nova | 17:05 | |
| stephenfin | oooh, review.rdoproject.org supports polygerrit now | 17:05 |
| sean-k-mooney | stephenfin we likely are looking up the cpu policy differently | 17:05 |
| stephenfin | pretty | 17:05 |
| aspiers | stephenfin: still waiting for OpenStack Gerrit upgrade | 17:05 |
| *** maciejjozefczyk has joined #openstack-nova | 17:05 | |
| stephenfin | yup, but I'm assured they're on it. Looking forward to a few of those features | 17:06 |
| sean-k-mooney | nope https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1100 | 17:06 |
| aspiers | stephenfin: but even that upgrade is fairly old: 2.14.7, and 3.0 is now out | 17:06 |
| aspiers | there are lots of really nice improvements since 2.14 | 17:06 |
| stephenfin | Yeah, I think we discussed before and the strategy was to go to 2.16, which deprecates a load of things but would provide time to prepare for 3.0 | 17:07 |
| aspiers | stephenfin: skip upgrades are not supported anyway | 17:07 |
| aspiers | you have to go to 2.16 to migrate to notedb before moving to 3.0 | 17:07 |
| stephenfin | yup | 17:07 |
| efried | stephenfin: Not sure how much mikal is monitoring his reviews these days; if I do those two fixups (remove redundant lines) would you fast approve? | 17:08 |
| sean-k-mooney | stephenfin: so ya https://review.rdoproject.org/r/#/c/11297/11/whitebox_tempest_plugin/api/compute/test_cpu_pinning.py@108 should fail | 17:08 |
| stephenfin | efried: I would | 17:08 |
| stephenfin | sean-k-mooney: I'm thinking it would fail if the other had no free cores | 17:09 |
| stephenfin | *other host | 17:09 |
| sean-k-mooney | stephenfin: the self.get_server_cpu_pinning call should be checking the xml | 17:09 |
| stephenfin | but because it does, the NUMATopologyFilter is passing and then things get recalculated properly when it starts building the instance on the host | 17:09 |
| sean-k-mooney | unless we actully update the request spec later | 17:09 |
| sean-k-mooney | e.g. on the compute node | 17:10 |
| sean-k-mooney | right | 17:10 |
| sean-k-mooney | ok so ya that is passing because there is enough free cpus | 17:10 |
| *** JamesBenson has quit IRC | 17:10 | |
| sean-k-mooney | ok so resize with numa is not totally broken | 17:11 |
| sean-k-mooney | just the sechduler bit | 17:11 |
| sean-k-mooney | the compute node will still validate it with the new flavor when it trys to build the instance xml | 17:11 |
| sean-k-mooney | or just before it when it generates the new numa toplogy | 17:12 |
| *** maciejjozefczyk has quit IRC | 17:12 | |
| *** xek_ has quit IRC | 17:12 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 17:14 |
| stephenfin | sean-k-mooney: ^ untested (completely) but something like that should do the trick, I imagine? | 17:14 |
| sean-k-mooney | yes that is exactly what i was thinking too | 17:15 |
| stephenfin | Nice | 17:15 |
| sean-k-mooney | the one thing im not sure about however is should we but using the tempory mutation thing | 17:15 |
| stephenfin | I'll try whip up a functional test for the on Monday^H^H^H Tuesday and see if I can reproduce it there | 17:16 |
| stephenfin | Possibly | 17:16 |
| sean-k-mooney | e.g. if we revert we need to make sure we go back to the old numa toplogy | 17:16 |
| stephenfin | The fact that we're overwriting some RequestSpec fields already leads me to think we might be rolling back somewhere, but I haven't investigated | 17:16 |
| sean-k-mooney | i think we nolonger persist the ignore_hosts field to the db | 17:17 |
| sean-k-mooney | anyway that is at least a step in the right direction | 17:17 |
| *** amodi has joined #openstack-nova | 17:18 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.opendev.org/643894 | 17:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.opendev.org/643895 | 17:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.opendev.org/643896 | 17:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793 | 17:23 |
| efried | stephenfin: done | 17:23 |
| *** JamesBenson has joined #openstack-nova | 17:27 | |
| *** JamesBenson has quit IRC | 17:34 | |
| *** sapd1_x has joined #openstack-nova | 17:46 | |
| *** JamesBenson has joined #openstack-nova | 17:50 | |
| *** mlavalle has joined #openstack-nova | 17:51 | |
| *** sapd1_x has quit IRC | 17:51 | |
| *** JamesBenson has quit IRC | 17:55 | |
| *** panda|ruck has quit IRC | 17:59 | |
| *** panda has joined #openstack-nova | 18:01 | |
| *** sridharg has joined #openstack-nova | 18:03 | |
| *** tesseract has quit IRC | 18:04 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324 | 18:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845 | 18:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056 | 18:08 |
| *** dave-mccowan has quit IRC | 18:09 | |
| *** JamesBenson has joined #openstack-nova | 18:11 | |
| *** JamesBenson has quit IRC | 18:17 | |
| *** sridharg has quit IRC | 18:27 | |
| *** minmin has quit IRC | 18:28 | |
| *** minmin has joined #openstack-nova | 18:29 | |
| *** whoami-rajat has quit IRC | 18:37 | |
| *** JamesBenson has joined #openstack-nova | 18:42 | |
| *** mriedem_hangry is now known as mriedem | 18:44 | |
| openstackgerrit | Merged openstack/nova stable/stein: Fix live-migration when glance image deleted https://review.opendev.org/662152 | 18:52 |
| mriedem | dansmith: thanks, replied | 18:53 |
| mriedem | dansmith: sounds like you're prefer me to go back to PS3 for the backports and leave the group_uuid stuff separately on master - if so, that's fine and i can do that | 18:53 |
| mriedem | *you'd | 18:53 |
| *** eharney has quit IRC | 18:54 | |
| dansmith | mriedem: ah I didn't see that it was that way in a previous set.. I'm not super opposed, but just feels like the right thing to do | 18:59 |
| mriedem | ok i'll split that one apart and make the func test change to pop request_spec from kwargs | 19:00 |
| *** BjoernT has quit IRC | 19:00 | |
| *** cmart has joined #openstack-nova | 19:00 | |
| *** openstackgerrit has quit IRC | 19:01 | |
| artom | dansmith, welcome back from PTO. I left you a steaming homecoming present: https://review.opendev.org/#/c/653498/ | 19:01 |
| artom | (It's the revert resize thing we had a hangouts about) | 19:02 |
| mriedem | ....except much different | 19:03 |
| dansmith | um, great? | 19:03 |
| mriedem | something something very specific vif type / profile thing right? | 19:04 |
| mriedem | b/c i have not tried to grok any of it | 19:04 |
| artom | Well, the problem turned out to be specific | 19:04 |
| artom | Hence the proposed solution is as well | 19:04 |
| mriedem | and the generic solution we talked about on the hangout wouldn't have fixed it? | 19:04 |
| artom | But yeah, it only happens (in this specific case) when Neutron uses OVS hybrid plug | 19:04 |
| mnaser | two annoying Friday questions: why is the UEFI path hard-coded and why does it have no functional tests (lack of UEFI image?) | 19:05 |
| mriedem | i.e. register the callback in compute manager before updating the port binding and calling the virt driver method | 19:05 |
| artom | mriedem, no, because Neutron sends the event at different times depending on its internals | 19:05 |
| mriedem | mnaser: it was bolted it years ago... | 19:05 |
| mriedem | *in | 19:05 |
| artom | mriedem, wait, say that again? Callback for what? | 19:06 |
| mriedem | artom: the event | 19:06 |
| mriedem | mnaser: https://bugs.launchpad.net/nova/+bug/1825386 is the first issue right? | 19:07 |
| openstack | Launchpad bug 1825386 in OpenStack Compute (nova) "nova is looking for OVMF file no longer provided by CentOS 7.6" [Undecided,New] | 19:07 |
| mnaser | because the fact centos and ubuntu both host it in different places is pretty gross right now | 19:07 |
| mnaser | bahaha | 19:07 |
| mnaser | yes | 19:07 |
| artom | mriedem, you mean wrapping the call to update the port binding with wait_for_event? | 19:07 |
| mnaser | okay, well I guess it's being addressed then | 19:07 |
| mriedem | mnaser: so the workaround from kashyap in there is to create a link | 19:07 |
| mnaser | fair nuff | 19:08 |
| mriedem | mnaser: just b/c there is a bug doesn't mean it's being addressed :) you should know that | 19:08 |
| mriedem | artom: yeah | 19:08 |
| mnaser | well I think kashyap is doing this work | 19:08 |
| mnaser | oh its not even approved yet | 19:08 |
| mriedem | functional testing would catch that anyway | 19:08 |
| mriedem | *wouldn't | 19:09 |
| artom | mriedem, that only works if Neutron sends the event in response to the port binding update | 19:09 |
| mnaser | it's probably trivial to make a config option I guess | 19:09 |
| artom | Which it only does when OVS hybrid plug is in use | 19:09 |
| mriedem | mnaser: or create a link in osa | 19:09 |
| mnaser | but having a config option with two defaults (i.e. aarch64 vs x86)... EH. | 19:09 |
| mnaser | yeah I think that seems like the likely path | 19:09 |
| mriedem | but then all deployment tools have to do that | 19:09 |
| artom | mriedem, the rest of the time, it's business as usual with waiting as we currently do in the virt driver | 19:09 |
| mnaser | yeah it seems like having a config option is the right thing™ | 19:09 |
| mriedem | mnaser: every deployment tool will still have to make a change | 19:10 |
| mriedem | either way | 19:10 |
| mriedem | unless/until nova can auto-detect it | 19:10 |
| mriedem | artom: ok it sounds like a similar issue with hard reboot depending on the type of vif (odl ovs doesn't send the event unless you change the port binding) | 19:10 |
| *** cmart has quit IRC | 19:11 | |
| artom | mriedem, not quite type of vif, but yeah. The real root cause here is Neutron not being consistent in when it sends the events | 19:11 |
| mriedem | mnaser: regarding testing :) https://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/boot-from-uefi.html#testing | 19:12 |
| mriedem | damn those neutrinios | 19:12 |
| artom | Since I'm not sure how realistic is to expect Neutron to change in the near future, the next best alternative is a hopefully-not-too-ugly Nova hack :/ | 19:13 |
| mriedem | i was joking, i like the neutrinos | 19:16 |
| artom | Don't worry, I didn't rat you out | 19:17 |
| *** imacdonn has quit IRC | 19:17 | |
| *** imacdonn has joined #openstack-nova | 19:18 | |
| *** openstackgerrit has joined #openstack-nova | 19:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression recreate test for bug 1830747 https://review.opendev.org/661822 | 19:19 |
| openstack | bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | 19:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786 | 19:19 |
| openstackgerrit | Merged openstack/nova stable/stein: cleanup evacuated instances not on hypervisor https://review.opendev.org/662189 | 19:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set/get group uuid when transforming RequestSpec to/from filter_properties https://review.opendev.org/662550 | 19:28 |
| mriedem | dansmith: there you go, all 3 ^ | 19:28 |
| mriedem | assuming you can fast approve the func test one | 19:28 |
| dansmith | right on | 19:31 |
| mnaser | mriedem: fwiw -- https://review.opendev.org/662552 | 19:33 |
| mriedem | delicious ansible | 19:34 |
| mriedem | mnaser: question in there | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Add configs for AMD SEV https://review.opendev.org/636318 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Add iommu driver to devices https://review.opendev.org/644564 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Use launchSecurity element when SEV was required https://review.opendev.org/662557 | 19:37 |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 19:37 |
| mnaser | mriedem: good call, done | 19:39 |
| mriedem | melwitt: thing in https://review.opendev.org/#/c/638324/ which you can tack into your FUP change | 19:42 |
| *** amodi has quit IRC | 19:47 | |
| *** slaweq has quit IRC | 19:48 | |
| *** slaweq has joined #openstack-nova | 19:54 | |
| *** eharney has joined #openstack-nova | 19:57 | |
| *** slaweq has quit IRC | 19:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897 | 20:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897 | 20:01 |
| efried | mriedem, melwitt: ^ | 20:03 |
| efried | sounded like they weren't super interested in continuing to follow that patch given the controversy, I went ahead and fixed my nits. | 20:03 |
| efried | The changes are small and test-only, but a fair number of lines, so I'd prefer not to +2 it myself at this point. | 20:04 |
| *** tbachman has quit IRC | 20:06 | |
| mriedem | i think they just didn't care b/c they've already been running with it in prod for a year or more | 20:07 |
| mriedem | but yeah thanks for updating it | 20:09 |
| *** itlinux has quit IRC | 20:11 | |
| *** xek_ has joined #openstack-nova | 20:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update quota known issues docs https://review.opendev.org/662570 | 20:13 |
| efried | mriedem: I'm updating the nested magic 1 spec, what do you want that footnote to look like? | 20:18 |
| mriedem | just a footnote? | 20:19 |
| mriedem | not a huge deal to me, that won't make me +2 the spec or anything | 20:19 |
| mriedem | as i said, i feel unqualified to approve that spec | 20:20 |
| efried | I don't know what you mean by "just a footnote" | 20:20 |
| efried | you mean plain non-RST'd non-linked text? | 20:21 |
| mnaser | I can't quite grasp if https://github.com/openstack/nova/blob/5868303f2c33021310eb4fade97828ef1757dc6b/nova/network/linux_net.py is nova-network or nova's networking code. | 20:22 |
| mnaser | (I'm cleaning up OSA's long list of old dependencies, and we install bridge-utils which provides brctl, and im just wondering if its necessary) | 20:22 |
| efried | mnaser: Pretty sure it's nova networking, but I could be wrong. | 20:22 |
| efried | by which I mean: pretty sure it's still needed | 20:22 |
| mnaser | I mean I dont think nova should be creating or deleting any bridges? | 20:22 |
| mnaser | right, the neutron role should install bridge-utils, not nova in this case | 20:23 |
| *** dpawlik has joined #openstack-nova | 20:23 | |
| mnaser | (it'll end up there, but just want to make sure its the right thing that puts it there) | 20:23 |
| melwitt | mriedem: k thanks | 20:30 |
| *** maciejjozefczyk has joined #openstack-nova | 20:31 | |
| *** dpawlik has quit IRC | 20:31 | |
| *** itlinux has joined #openstack-nova | 20:32 | |
| mriedem | mnaser: os-vif likely handles the low-level bridge stuff now | 20:34 |
| mriedem | sean-k-mooney would be the person to ask such questions | 20:34 |
| mriedem | efried: i guess using a footnote http://docutils.sourceforge.net/docs/user/rst/quickref.html#footnotes | 20:35 |
| mriedem | i guess what was in the spec was a citation? | 20:35 |
| efried | mriedem: Yes, I'm using that third form. | 20:35 |
| mriedem | ok just tell me to stfu on the spec then | 20:37 |
| efried | mriedem, I live to make you happy. It's easy to change to something you consider prettier. Just tell me what that is and I'll do it. | 20:37 |
| efried | note that the theme is going to mung the appearance - that's what's giving you the magical backreference link instead of the bold full-sized text on the footnote itself | 20:38 |
| efried | so if I changed to [1] it's still going to be "ugly". | 20:38 |
| *** tbachman has joined #openstack-nova | 20:38 | |
| mnaser | mriedem: ah good call, fyi -- https://github.com/openstack/os-vif/commit/1f6fed6a69e9fd386e421f3cacae97c11cdd7c75#diff-17b53d4f2c04032fb60eec093a443af0 | 20:40 |
| mnaser | so .. no longer needed now | 20:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup quota user docs https://review.opendev.org/662573 | 20:41 |
| *** tbachman has quit IRC | 20:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add regression recreate test for bug 1830747 https://review.opendev.org/662574 | 20:48 |
| openstack | bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | 20:49 |
| openstackgerrit | Merged openstack/nova master: extract baselineCPU API call from _get_cpu_traits() https://review.opendev.org/661782 | 20:50 |
| openstackgerrit | Merged openstack/nova master: xenapi: log quality warning in init_host https://review.opendev.org/662295 | 20:50 |
| *** dklyle has quit IRC | 20:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.opendev.org/643896 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793 | 21:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add regression recreate test for bug 1830747 https://review.opendev.org/662578 | 21:02 |
| openstack | bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | 21:02 |
| *** cmart has joined #openstack-nova | 21:29 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056 | 21:29 |
| melwitt | mriedem: lmk if that code comment makes sense now ^ | 21:29 |
| *** cmart has quit IRC | 21:39 | |
| *** xek_ has quit IRC | 21:48 | |
| *** pcaruana has quit IRC | 21:54 | |
| *** maciejjozefczyk has quit IRC | 21:59 | |
| *** JamesBenson has quit IRC | 22:00 | |
| openstackgerrit | Julia Kreger proposed openstack/nova stable/rocky: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662584 | 22:05 |
| *** spatel has joined #openstack-nova | 22:17 | |
| *** _erlon_ has quit IRC | 22:19 | |
| *** spatel has quit IRC | 22:21 | |
| mnaser | efried: I realize this is probably not much of your thing but I noticed some commits to openstack-ansible with the PowerVM driver around 1.5 years ago by IBM-ers .. is there someone I can talk to about the usage of it (if any left..?) | 22:23 |
| efried | mnaser: Who were the IBMers? | 22:23 |
| efried | mnaser: The PowerVM driver is still changing hands. Evidence is that the new maintainers are still... very new and ramping up. But they are ramping up. | 22:24 |
| efried | If you're asking about the actual PowerVM driver, I can probably help you. (I know nothing about ansible, though) | 22:24 |
| mnaser | efried: I see https://review.opendev.org/#/c/518980/ and https://review.opendev.org/#/c/455350/ and https://review.opendev.org/#/c/450298/ as small things here and there | 22:25 |
| mnaser | well, OSA apparently supports deploying it.. but it has absolutely zero testing, so I'm a bit curious if we're just maintaining something that no one is using or if there's usage behind it | 22:25 |
| mnaser | and 'maintain' is a strong word because more like have no idea if any of it works :) | 22:25 |
| efried | interesting question. | 22:26 |
| efried | So yeah, Adam and Eric are long gone at this point. | 22:26 |
| efried | And as of today, I know for sure the OOT driver is broken, because of this patch to fix it: https://review.opendev.org/#/c/662393/ | 22:27 |
| efried | does osa "support" the in-tree or out-of-tree driver? | 22:27 |
| mnaser | efried: looking at the code, we install nova-powervm and set the compute driver to 'powervm.driver.PowerVMDriver' | 22:28 |
| efried | wow | 22:28 |
| efried | mnaser: at what openstack version? | 22:29 |
| mnaser | efried: nova-powervm is installed without constraints so I guess it'll always pull in latest | 22:30 |
| mnaser | and this code has been around for a while, still in master | 22:30 |
| efried | cause I'm pretty sure you can't use the oot driver at that path | 22:30 |
| mnaser | yeah, googling around apparently it should be powervm_ext | 22:30 |
| efried | To use oot, you would have to say powervm_ext.driver.PowerVMDriver; and to use | 22:30 |
| efried | yes | 22:30 |
| efried | so here's my best guess | 22:30 |
| mnaser | so it is functionally broken since $release_that_added_ext | 22:31 |
| efried | yeah, that was like 2015 or 16 | 22:31 |
| efried | I'm guessing we put this stuff together to force some distro (like RHEL) to include nova-powervm in packaging, knowing it would never work as is | 22:31 |
| efried | so that we could install PowerVC (management GUI) into that distro | 22:32 |
| efried | PowerVC would fix up all the stuff | 22:32 |
| efried | anyway, if you wanted to rip all that stuff out, I think you would be justified in proposing that patch, but it would be nice to poke the ML first. | 22:33 |
| mnaser | I think ill push a patch and poke the ML because if no one proposes fixing it then it sitting around doesn't help | 22:33 |
| efried | agreed | 22:41 |
| mnaser | efried: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006797.html fyi :) | 22:46 |
| efried | ack | 22:47 |
| *** macza has quit IRC | 23:06 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 23:23 |
| *** _alastor_ has joined #openstack-nova | 23:27 | |
| *** _alastor_ has quit IRC | 23:32 | |
| *** panda has quit IRC | 23:37 | |
| *** gyee has quit IRC | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!