Tuesday, 2019-05-21

*** panda|rover has quit IRC00:10
*** panda has joined #openstack-nova00:11
*** tbachman has joined #openstack-nova00:40
*** markvoelker has joined #openstack-nova00:41
*** markvoelker has quit IRC00:45
*** ttsiouts has quit IRC01:00
*** brinzhang has joined #openstack-nova01:02
*** ttsiouts has joined #openstack-nova01:15
tonybI have a couple of ironic nodes in my OpenStack, how can I see which traits they provide ... and if they don't provide useful ones add them?01:19
*** ttsiouts has quit IRC01:20
*** frankwang has joined #openstack-nova01:21
*** frankwang has quit IRC01:42
*** ttsiouts has joined #openstack-nova01:49
*** frankwang has joined #openstack-nova01:53
*** ttsiouts has quit IRC01:54
*** lei-zh has joined #openstack-nova02:00
*** whoami-rajat has joined #openstack-nova02:00
*** nicolasbock has quit IRC02:16
*** ttsiouts has joined #openstack-nova02:27
*** ykarel|away has joined #openstack-nova02:29
*** lei-zh has quit IRC02:32
*** lei-zh has joined #openstack-nova02:33
*** _alastor_ has joined #openstack-nova02:36
*** ricolin has joined #openstack-nova02:44
*** ykarel|away is now known as ykarel02:44
*** tbachman has quit IRC02:45
*** tbachman has joined #openstack-nova02:46
*** _alastor_ has quit IRC02:50
*** tbachman has quit IRC02:51
*** wwriverrat has quit IRC02:51
*** dave-mccowan has quit IRC02:55
*** frankwang has quit IRC02:56
*** tbachman has joined #openstack-nova02:57
*** tbachman has quit IRC02:58
*** hemna has joined #openstack-nova02:59
*** hongbin has joined #openstack-nova03:00
*** ttsiouts has quit IRC03:01
*** hemna has quit IRC03:03
*** tkajinam has quit IRC03:03
*** tkajinam has joined #openstack-nova03:04
*** wwriverrat has joined #openstack-nova03:04
*** frankwang has joined #openstack-nova03:06
*** hemna has joined #openstack-nova03:07
*** kaisers has quit IRC03:17
*** tkajinam has quit IRC03:20
*** hemna has quit IRC03:26
*** tkajinam has joined #openstack-nova03:28
*** psachin has joined #openstack-nova03:29
*** udesale has joined #openstack-nova03:47
*** tbachman has joined #openstack-nova03:50
*** ttsiouts has joined #openstack-nova04:03
*** lei-zh has quit IRC04:06
*** hongbin has quit IRC04:21
*** markvoelker has joined #openstack-nova04:35
*** ttsiouts has quit IRC04:36
*** janki has joined #openstack-nova04:37
*** markvoelker has quit IRC04:39
*** tbachman has quit IRC04:44
*** ratailor has joined #openstack-nova04:46
*** itlinux has quit IRC04:46
*** tbachman has joined #openstack-nova04:49
*** slaweq has joined #openstack-nova04:49
*** slaweq has quit IRC04:59
*** pcaruana has joined #openstack-nova05:02
*** ykarel is now known as ykarel|away05:03
*** ykarel|away has quit IRC05:08
*** pcaruana has quit IRC05:11
*** slaweq has joined #openstack-nova05:16
*** slaweq has quit IRC05:20
*** ykarel|away has joined #openstack-nova05:20
*** lei-zh has joined #openstack-nova05:27
*** ykarel|away is now known as ykarel05:28
*** ivve has quit IRC05:34
*** ttsiouts has joined #openstack-nova05:39
*** imacdonn has quit IRC05:40
*** imacdonn has joined #openstack-nova05:41
*** ykarel_ has joined #openstack-nova05:42
*** Luzi has joined #openstack-nova05:43
*** udesale has quit IRC05:44
*** ykarel has quit IRC05:44
*** udesale has joined #openstack-nova05:44
*** ykarel__ has joined #openstack-nova06:01
*** ykarel_ has quit IRC06:03
*** ykarel__ is now known as ykarel06:04
*** zbr_ has quit IRC06:05
*** slaweq has joined #openstack-nova06:12
*** ttsiouts has quit IRC06:12
*** lpetrut has joined #openstack-nova06:15
*** tbachman has quit IRC06:15
*** jistr is now known as jistr|mtg06:20
openstackgerritWangliangyu proposed openstack/nova master: Replace colon with comma in route comment  https://review.opendev.org/66025606:32
*** kaisers has joined #openstack-nova06:34
*** markvoelker has joined #openstack-nova06:36
*** maciejjozefczyk has joined #openstack-nova06:42
*** ivve has joined #openstack-nova06:43
*** ccamacho has joined #openstack-nova06:56
*** luksky has joined #openstack-nova07:00
*** dpawlik has joined #openstack-nova07:03
*** trident has quit IRC07:03
*** trident has joined #openstack-nova07:05
*** tesseract has joined #openstack-nova07:06
*** markvoelker has quit IRC07:09
*** rcernin has quit IRC07:19
*** ralonsoh has joined #openstack-nova07:19
*** tssurya has joined #openstack-nova07:20
*** pcaruana has joined #openstack-nova07:21
*** helenafm has joined #openstack-nova07:24
*** ttsiouts has joined #openstack-nova07:27
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552007:30
*** ykarel is now known as ykarel|lunch07:35
*** udesale has quit IRC07:35
*** udesale has joined #openstack-nova07:36
*** pcaruana has quit IRC07:39
*** yikun_ has joined #openstack-nova07:40
*** rpittau|afk is now known as rpittau07:41
*** jangutter has joined #openstack-nova07:44
kashyapefried: Will look.  Actually, Ya Wang did ping me on a few things in that PostCopy / Auto-Converge spec07:47
kashyapyaawang: Hi, what do you mean "applicatoins sensitive to performance reduced"?07:50
openstackgerritya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.opendev.org/66027107:53
yaawangkashyap: Hi, for example: some scientific computing applications may be more sensitive to memory access latency.08:05
*** markvoelker has joined #openstack-nova08:06
*** luksky has quit IRC08:11
*** tkajinam has quit IRC08:12
*** dtantsur|afk is now known as dtantsur08:20
*** priteau has joined #openstack-nova08:20
kashyapyaawang: Ah, noted.08:23
kashyapefried: yaawang: I just reviewed it.  The idea itself is sound.  I had some small comments on phrasing -- they can be addressed as a follow-on, or in this if there's a strong need to respin.08:23
*** guozijn has joined #openstack-nova08:24
openstackgerritya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.opendev.org/66027108:24
*** priteau has quit IRC08:24
*** betherly has joined #openstack-nova08:25
openstackgerritAlexandre arents proposed openstack/nova master: Fix live-migration when glance image deleted  https://review.opendev.org/65905408:25
openstackgerritMerged openstack/nova master: Fix failure to boot instances with qcow2 format images  https://review.opendev.org/64027108:28
openstackgerritMerged openstack/nova stable/ocata: Do not dump all instances in the scheduler  https://review.opendev.org/65983308:28
*** priteau has joined #openstack-nova08:29
*** ykarel|lunch is now known as ykarel08:30
*** xek has joined #openstack-nova08:36
*** xek has quit IRC08:38
*** markvoelker has quit IRC08:39
*** derekh has joined #openstack-nova08:43
*** luksky has joined #openstack-nova08:46
*** jistr|mtg is now known as jistr08:46
*** ttsiouts has quit IRC08:48
*** xek has joined #openstack-nova08:48
*** davidsha has joined #openstack-nova08:48
openstackgerritHamdy Khader proposed openstack/nova master: OVS DPDK port representors support  https://review.opendev.org/65878508:53
*** tetsuro has joined #openstack-nova09:01
*** awalende has joined #openstack-nova09:05
*** dtantsur is now known as dtantsur|brb09:06
*** phasespace has joined #openstack-nova09:12
*** openstackstatus has quit IRC09:13
*** openstackstatus has joined #openstack-nova09:15
*** ChanServ sets mode: +v openstackstatus09:15
*** yan0s has joined #openstack-nova09:15
*** bhagyashris has joined #openstack-nova09:16
*** ttsiouts has joined #openstack-nova09:18
mdboothjohnthetubaguy: If you're around, any chance you might prod this over the line? https://review.opendev.org/#/c/659317/09:19
openstackgerritLee Yarwood proposed openstack/nova master: fixtures: Return a mocked class instead of method within fake_imagebackend  https://review.opendev.org/61980409:24
lyarwoodstephenfin: https://review.opendev.org/#/c/551349/ - would you mind taking a look at this if you have time today09:25
lyarwoodmdbooth: ^ there's additional stuff on top of that I could use your take on btw - https://review.opendev.org/#/q/topic:live-migration-volume-bdm-rollback-rework+(status:open+OR+status:merged)09:26
stephenfinlyarwood: Sure. Fixing some issues with pbr/taskflow at the moment but it's next in the queue after that09:26
lyarwoodthanks09:26
*** guozijn_ has joined #openstack-nova09:27
lyarwoodstephenfin / mdbooth ; https://review.opendev.org/#/c/572790/ - could also use reviews if you have time.09:28
*** cdent has joined #openstack-nova09:29
*** guozijn has quit IRC09:31
*** guozijn_ is now known as guozijn09:31
*** bhagyashris has quit IRC09:33
mdboothlyarwood: Ack09:34
*** lei-zh has quit IRC09:35
*** markvoelker has joined #openstack-nova09:35
*** guozijn has quit IRC09:46
*** ttsiouts has quit IRC09:50
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Stop logging traceback when skipping quiesce  https://review.opendev.org/66032509:53
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Stop logging traceback when skipping quiesce  https://review.opendev.org/66032709:54
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Stop logging traceback when skipping quiesce  https://review.opendev.org/66032809:54
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Fix target used in nova.policy.check_is_admin  https://review.opendev.org/66033009:55
stephenfinlyarwood: Can I get a reno for https://review.opendev.org/#/c/572790/ please?10:06
stephenfinActually, that's mriedem's. nvm. He'll see it soon enough10:06
*** aarents has quit IRC10:07
*** dpawlik has quit IRC10:09
*** markvoelker has quit IRC10:09
*** dpawlik has joined #openstack-nova10:09
*** mmethot has quit IRC10:11
lyarwoodstephenfin: I will if he can't10:19
*** boxiang has joined #openstack-nova10:20
*** boxiang has quit IRC10:21
*** boxiang has joined #openstack-nova10:22
*** boxiang has quit IRC10:24
*** boxiang has joined #openstack-nova10:25
*** dtantsur|brb is now known as dtantsur10:30
*** boxiang has quit IRC10:30
cdentbauzas: Have you got a new version of  https://review.opendev.org/#/c/552924/ coming?10:33
openstackgerritLee Yarwood proposed openstack/nova master: compute: refactor volume bdm rollback error handling  https://review.opendev.org/65650010:45
*** ileixe has quit IRC10:46
*** udesale has quit IRC10:46
*** bbowen has quit IRC10:51
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296910:55
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297010:55
openstackgerritMerged openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.opendev.org/57141010:56
*** awalende has quit IRC10:58
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297010:58
*** awalende has joined #openstack-nova10:59
*** mmethot has joined #openstack-nova11:01
*** ttsiouts has joined #openstack-nova11:02
openstackgerritHamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support  https://review.opendev.org/65878611:05
*** markvoelker has joined #openstack-nova11:06
*** panda is now known as panda|rover|eat11:13
*** nicolasbock has joined #openstack-nova11:15
*** ccstone has quit IRC11:22
openstackgerritHamdy Khader proposed openstack/nova master: OVS DPDK port representors support  https://review.opendev.org/65878511:24
openstackgerritMerged openstack/nova master: Fix guestfs.set_backend_settings call  https://review.opendev.org/52474811:26
*** dave-mccowan has joined #openstack-nova11:27
*** ttsiouts has quit IRC11:36
*** markvoelker has quit IRC11:39
openstackgerritHamdy Khader proposed openstack/nova master: OVS DPDK port representors support  https://review.opendev.org/65878511:42
openstackgerritMerged openstack/nova master: Replace colon with comma in route comment  https://review.opendev.org/66025611:44
*** awalende has quit IRC11:44
*** awalende has joined #openstack-nova11:45
openstackgerritHamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support  https://review.opendev.org/65878611:46
*** aarents has joined #openstack-nova11:52
*** awalende has quit IRC11:52
*** awalende has joined #openstack-nova11:54
*** brinzh has joined #openstack-nova11:54
*** janki has quit IRC11:54
*** brinzhang has quit IRC11:56
*** bbowen has joined #openstack-nova11:57
*** ttsiouts has joined #openstack-nova12:06
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.opendev.org/66036112:07
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.opendev.org/66036212:07
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.opendev.org/66036312:08
*** ratailor has quit IRC12:09
*** ttsiouts has quit IRC12:10
*** ttsiouts has joined #openstack-nova12:12
*** udesale has joined #openstack-nova12:16
*** tetsuro has quit IRC12:26
openstackgerritMerged openstack/nova master: Restore connection_info after live migration rollback  https://review.opendev.org/55134912:27
*** panda|rover|eat is now known as panda|rover12:27
*** francoisp has joined #openstack-nova12:31
*** ttsiouts has quit IRC12:32
*** psachin has quit IRC12:34
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Restore connection_info after live migration rollback  https://review.opendev.org/66037012:36
*** priteau has quit IRC12:36
*** priteau has joined #openstack-nova12:41
*** boxiang_ has joined #openstack-nova12:42
*** asettle has joined #openstack-nova12:43
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Restore connection_info after live migration rollback  https://review.opendev.org/66037512:44
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add uuid filter to nova list  https://review.opendev.org/66037612:46
*** brinzh has quit IRC12:48
*** priteau has quit IRC12:51
*** tobias-urdin has quit IRC13:03
*** tbachman has joined #openstack-nova13:04
alex_xusean-k-mooney: good morning, do you want to have look at this https://review.opendev.org/#/c/658716/1/specs/train/approved/show-server-numa-topology.rst@110 ?13:05
alex_xui guess core and threads should be removed also.13:05
efriedthanks for that, kashyap13:06
alex_xusince numa_cell.cpu_topology only valid for dedicated cpu policy, and I guess cores and threads is empty all the time13:06
sean-k-mooney alex_xu im just waiting for someome form the gas company to call but i can take a look in an hour or so13:07
*** mriedem has joined #openstack-nova13:07
alex_xusean-k-mooney: thanks, not hurry13:07
*** cgoncalves has quit IRC13:08
*** eharney has quit IRC13:11
sean-k-mooneyalex_xu: im ok with the api reporting the number of sockets, cores per socket and threads per core.13:11
*** janki has joined #openstack-nova13:11
sean-k-mooneyim not sure it shoudl be reported at the numa node level however13:11
sean-k-mooneygiven that its vm wide13:11
alex_xusean-k-mooney: yea, at least not in the numa cell13:11
sean-k-mooneyi would add cpu_topology:{sockets:1,cores:10, threads:2} as a sibling but not childe of nodes13:12
alex_xuwhether we have separated file for sockets, cores and threads, that should be a question for yonglihe and chris13:13
sean-k-mooneythat said i have not really given that much tought13:13
*** READ10 has joined #openstack-nova13:13
alex_xusean-k-mooney: I will tell yonglihe, let him check with starlingx whether need sockets, cores and threads13:14
openstackgerritMerged openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API  https://review.opendev.org/65526813:15
*** zhongjun2_ has quit IRC13:15
alex_xusean-k-mooney: actually, we won't have different hugepage size for cells13:16
alex_xui'm not sure this one also13:17
sean-k-mooneycorrect we wont13:18
sean-k-mooneywe store the info in the db percell13:18
alex_xuyes13:18
sean-k-mooneybut that is just so we did not have to pass it in as a peramater when calulating the assignment13:19
sean-k-mooneybut as you said the pagesize will be the same for all cells in the instance13:19
sean-k-mooneylibvirt can technically support different page sizes per cell and even multipl page sizes in the same numa cell but we have no plans to ever support that in nova so we dont really need to worry about it13:21
alex_xuyea, can't see a usecase for that13:21
alex_xuif they need that, then put it out of cell also, sounds correct choice13:22
sean-k-mooneyyes i think so to.13:22
*** cgoncalves has joined #openstack-nova13:23
sean-k-mooneyi would prefer to have the vm wide things at the top level and the cell specific things at the node level. whcih i think is your preference too.13:23
alex_xuyes. our db structure is really confuse me in the beginning13:24
alex_xusean-k-mooney: thanks, I think yonglihe can move forward now13:25
*** ttsiouts has joined #openstack-nova13:34
*** tbachman_ has joined #openstack-nova13:35
*** tbachman has quit IRC13:35
*** tbachman_ is now known as tbachman13:35
*** tbachman_ has joined #openstack-nova13:39
*** tbachman has quit IRC13:40
*** tbachman_ is now known as tbachman13:40
*** itlinux has joined #openstack-nova13:43
*** bbobrov has quit IRC13:47
efriedkashyap: If you'll ack https://review.opendev.org/#/c/633855/ I'll approve it.13:52
* kashyap clicks13:52
efriedtia13:53
boxiang_alex_xu: hi alex, is it necessary for me to add the approved blueprint to runways again? https://review.opendev.org/#/c/645520/13:53
mriedemboxiang_: yes13:53
mriedemjust queue it back up13:53
alex_xuyea13:53
boxiang_ok, thanks :)13:54
*** mlavalle has joined #openstack-nova13:54
alex_xuboxiang_: another patch I have is want to remove something https://review.opendev.org/659243, if that makes sense, probably can save some of your code13:54
alex_xubut still waiting for review13:54
*** jchhatbar has joined #openstack-nova13:57
*** ttsiouts has quit IRC13:57
*** jangutter_ has joined #openstack-nova13:57
*** mrjk_ has joined #openstack-nova13:57
*** mmethot_ has joined #openstack-nova13:57
*** cdent_ has joined #openstack-nova13:57
*** NewBruce3 has joined #openstack-nova13:58
boxiang_alex_xu: got it. I will read it later.13:59
*** mriedem1 has joined #openstack-nova13:59
mriedem1alex_xu: that removal change of yours would make this not work i think https://review.opendev.org/#/c/650376/13:59
*** adrianc_ has joined #openstack-nova13:59
alex_xumriedem1: emm...let me check that patch14:00
*** gary_perkins_ has joined #openstack-nova14:00
mriedem1i'm trying to use requested_destination in the rebuild + new image scenario, rather than force_hosts/force_nodes14:00
mriedem1which requires a hack in the host manager code14:00
*** lifeless_ has joined #openstack-nova14:01
mriedem1i haven't gone over https://review.opendev.org/#/c/645520/ but i would expect it to use requested_destination as well14:01
*** Anticime1 has joined #openstack-nova14:01
efriedmriedem1 fwiw I've been having similar concerns, which is why I have been procrastinating on that patch.14:01
*** cmart has joined #openstack-nova14:02
alex_xumriedem1: ok, i can have look at it tomorrow, it sounds a complex thing I don't want to go through before sleep14:02
*** tbachman_ has joined #openstack-nova14:02
mriedem1yup understood, i'd comment on the review but14:02
alex_xuefried: nice instinct~14:03
boxiang_one question.if my patch is something different from the approved spec. Can I update the spec again?14:04
mriedem1efried: the sriov bp in the top runway slot is expired by a few days https://etherpad.openstack.org/p/nova-runways-train14:04
mriedem1boxiang_: you can amend the spec yes14:04
*** phasespace has quit IRC14:05
mriedem1sean-k-mooney: adrianc: was a patch ever pushed to update these docs for sriov live migration? https://docs.openstack.org/neutron/latest/admin/config-sriov.html#known-limitations14:05
sean-k-mooneymriedem1: no but its on my todolist for today. im currently updating the osc evacuate command patch14:06
*** janki has quit IRC14:06
*** mriedem has quit IRC14:06
*** derekh has quit IRC14:06
*** jangutter has quit IRC14:06
*** jamesdenton has quit IRC14:06
*** zer0c00l has quit IRC14:06
*** adrianc has quit IRC14:06
*** markmcclain has quit IRC14:06
*** lifeless has quit IRC14:06
*** kashyap has quit IRC14:06
*** dosaboy has quit IRC14:06
*** NewBruce has quit IRC14:06
*** tbachman has quit IRC14:06
*** udesale has quit IRC14:06
*** mmethot has quit IRC14:06
*** cdent has quit IRC14:06
*** ralonsoh has quit IRC14:06
*** toabctl has quit IRC14:06
*** mrjk has quit IRC14:06
*** aspiers has quit IRC14:06
*** johnthetubaguy has quit IRC14:06
*** smcginnis has quit IRC14:06
*** gary_perkins has quit IRC14:06
*** Anticimex has quit IRC14:06
*** edmondsw_ has quit IRC14:06
*** redkrieg has quit IRC14:06
*** cdent_ is now known as cdent14:06
*** tbachman_ is now known as tbachman14:06
sean-k-mooneymriedem1: you can kick the sriov bp out of the runway and replace it with something else14:06
*** rpittau is now known as rpittau|afk14:06
*** udesale has joined #openstack-nova14:07
mriedem1sean-k-mooney: note that https://review.opendev.org/#/c/647733/ is next in the queue but is in merge conflict14:07
*** yankcrime has quit IRC14:07
*** awalende has quit IRC14:07
*** mriedem1 is now known as mriedem14:07
sean-k-mooneyoh i guess i need to rebase that too14:07
mriedembrb14:07
boxiang_mriedem1: ok. i see14:07
*** mriedem has quit IRC14:07
sean-k-mooneyok ill do that then the docs patch14:07
*** mriedem has joined #openstack-nova14:08
efriedsean-k-mooney: I'll put it in the slot.14:08
*** Luzi has quit IRC14:09
*** awalende has joined #openstack-nova14:11
*** aspiers has joined #openstack-nova14:11
sean-k-mooneylooks like teh confligt was just in the nova object version file so i should have a rebased version up shortly14:11
*** eharney has joined #openstack-nova14:12
*** ralonsoh has joined #openstack-nova14:12
efriedaspiers: bottom SEV patches are merging, if you want to get those other rebases working.14:12
*** itlinux has quit IRC14:13
dansmithefried: are you holding off on the ironic power state one for ironic side review or something? AFAICT, of the nova people who have looked at it, all are either +vote or out at the moment14:14
efrieddansmith: Yes, giving SMEs and people with prior reviews a chance to re-ack.14:15
efriedIs there some hurry to merge the spec?14:15
*** awalende has quit IRC14:15
efrieddansmith: whoops, I actually asked jroll and melwitt to re-look, but I did it in the -placement channel by accident.14:15
dansmithefried: we've been kinda dragging our feet with it and tssurya has been her usual overly polite self.. we discussed in a couple small groups at ptg about it so I just don't want her to continue to have to wait14:16
dansmithefried: okay14:16
jrollI'm +1 on it14:16
efrieddansmith: afaict the code patch isn't being held up by the bp approval https://review.opendev.org/#/c/645611/14:16
sean-k-mooneyi have to admit i kind of like running the nova unit tests on my desktop/server14:16
*** boxiang_ has quit IRC14:17
dansmithefried: ...14:17
openstackgerritsean mooney proposed openstack/nova master: extend libvirt video model support  https://review.opendev.org/64773314:17
*** tbachman has quit IRC14:22
sean-k-mooneyi will redeploy with ^ later today but the unit and functional test pass locally14:23
sean-k-mooneyhas anyone used rtox https://pypi.org/project/rtox/ by the way14:23
*** lpetrut has quit IRC14:27
*** _erlon_ has joined #openstack-nova14:27
*** ykarel is now known as ykarel|afk14:27
mriedemlow-hanging-fruit bug if someone wants it https://bugs.launchpad.net/nova/+bug/182987714:31
openstackLaunchpad bug 1829877 in OpenStack Compute (nova) "avoid lazy-lodaing instance.flavor during cold migration" [Low,Confirmed]14:31
mriedemooo typo14:31
dansmithefried: tomorrow, the top patch set will have been up for 14 days.. presumably that's plenty of time time for anyone to have voiced their opinion, right?14:33
efrieddansmith: "top patch set" of what?14:34
dansmithefried: the latest revision of the ironic power state change. Just trying to figure out what "a few days" means in terms of when we should set reminders to make sure that it gets merged and doesn't get ignored again14:34
efrieddansmith: Give it a couple hours for melwitt to come on the scene and pick up the IRC nag I left for her. I expect we can merge it by lunchtime.14:35
dansmithalright14:36
efriedtssurya: Meanwhile, you should feel pretty confident this is going to go substantially as it stands, if you have the time and desire to crank on the code some :)14:38
*** liuyulong has joined #openstack-nova14:39
*** luksky has quit IRC14:49
*** tbachman has joined #openstack-nova14:55
*** yankcrime has joined #openstack-nova14:56
mriedemhmm, scatter_gather_all_cells seems to make us lose the request_id on the context we're using14:57
*** bbowen_ has joined #openstack-nova14:58
mriedemwhich makes debugging not so nice14:59
*** bbowen has quit IRC15:01
*** jchhatbar is now known as janki15:02
mriedemthe RequestContext.from_dict(context.to_dict()) stuff must overwrite the thread local context15:04
*** cfriesen has joined #openstack-nova15:05
mriedemwhich messes up the logging, even though those copies should be using the same request id15:05
dansmithmriedem: is it just that the threads we spawn to do the scatter don't get the thread-local set to their new context?15:06
*** hamzy has quit IRC15:07
mriedemRequestContext __init__ defaults overwrite=True so i'd think each one is updated15:10
mriedemi'm tracing a cold migration in these logs http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/controller/logs/screen-n-super-cond.txt.gz#_May_16_19_46_23_815726 with req-bde576dc-5de2-4113-982d-025c65b97e8d which is the request starting in the API15:10
mriedembut after that we hit the scatter/gather and lose the request id15:11
mriedemafter that it's using req-66d8138a-530a-4dec-b1cd-9c22e4402dd115:11
*** yan0s has quit IRC15:13
*** awalende has joined #openstack-nova15:15
*** kashyap` has joined #openstack-nova15:17
*** awalende has quit IRC15:19
aspiersefried: yup thanks15:19
*** priteau has joined #openstack-nova15:24
kashyap`efried: This was re-proposed (despite me abandoning it): https://review.opendev.org/#/c/660271/ ("Re-propose the spec to allow specifying a list of CPU models")15:31
efriedI noticed that15:31
efriedhaven't looked yet15:31
kashyap`efried: Don't.  After technical discussions w/ the libvirt / QEMU CPU modelling maintainers, we've concluded it's not a good idea15:32
kashyap`At least not in its present form.15:32
efriedkashyap`: lmk if you want me to -2 bomb the sucker.15:32
kashyap`efried: Hehe, please do.15:32
mriedemcfriesen: ^15:32
efriedkashyap`: save me finding the one you originally abandoned, got it at your fingertips?15:33
mriedemunrelated, it seems odd that we'd fail to stop a libvirt cirros guest after a minute http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/compute1/logs/screen-n-cpu.txt.gz#_May_16_19_47_26_01750915:33
kashyap`(It was approved previously during Stein-time; but I didn't pay sufficient attention to it.)15:33
efriednm, see the link in the comment.15:33
kashyap`mriedem: Noticed it only today?15:33
mriedemnoticed yes, but http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Instance%20failed%20to%20shutdown%20in%2060%20seconds.%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d15:34
efriedkashyap`: I did one better, I abandoned it.15:34
mriedemif we're burning up to a minute waiting to gracefully kill cirros guests in the gate that could explain in part why some jobs/tests are really slow15:35
kashyap`efried: Thanks!15:35
*** hamzy has joined #openstack-nova15:35
kashyap`mriedem: "Needs more investigation."  (I'm on mobile data in the library; will check tomm early.)15:38
mdboothefried: https://review.opendev.org/#/admin/groups/540,members Everybody on that list works for RH except Claudiu, John, and Matt. I don't know Claudiu, and I understand mriedem has some administrative difficulties right now :/15:40
mdboothefried: So the project is entirely dependent on johnthetubaguy to land stable patches.15:41
mriedemno it's not15:41
mriedemhttps://review.opendev.org/#/admin/groups/530,members15:41
mriedemthere is an #openstack-stable channel15:41
mriedemand people like mtreinish15:41
mriedemi'd also say smcginnis but he's in the same boat as me15:42
kashyap`mriedem: Aren't you referring to release managers group?15:42
mdboothOk. John and Matt Treinish15:42
kashyap`I think mdbooth is referring to "stable-core"15:42
mriedemnova-stable-maint's parent group is stable-maint-core 15:42
mdboothkashyap`: Yeah, mriedem was referring to stable-maint-core, who I understand can ack everything15:42
mriedemAlan Pevecalan.pevec@redhat.comChuck Shortchucks@redhat.comFlavio Percocofpercoco@redhat.com so much for that15:43
mdboothmriedem: Yeah, it's a bit RH loaded :/15:43
mriedemat some point can RH just extend me a job offer and i can switch sides here and start approving all RH stuff?15:43
mdboothmriedem: You won't be allowed under trifecta rules ;)15:43
cfriesenkashyap: what was the objection by the libvirt/qemu folks?  As you recall, the weakness in the current model is that you can only specify a model on the node, and it affects all guests on that node.15:44
aspiersmriedem: not if another Linux distro nabs you first ;-)15:44
mriedemso pressure the foundation to figure out wtf is going on with huawei developers to be able to work on open source15:44
kashyap`cfriesen: I don't know if that's a "weakness" per-se.  But the objection was the we'd need more data; and it is finicky, error-prone.15:45
kashyap`cfriesen: They also asked: Do you have data on why _not_ use the default 'host-model' -- that has the important double-advantage in that, it auto-adds the relevant flags15:45
*** helenafm has quit IRC15:45
*** ykarel|afk is now known as ykarel|away15:45
cfriesenkashyap`: host-model can be an issue if you happen to land on a brand new compute node that has more advanced hardware than most of the other nodes15:46
cfriesenkashyap`: makes it hard to live migrate15:46
kashyap`cfriesen: Not quite -- 'host-model' explicitly makes sure that you _can_ live-migrate across disparate hosts.  That's one of the reasons why Nova defaults to it15:47
sean-k-mooneycfriesen: yes that is true but its kind of a know issue15:47
cfriesensean-k-mooney: yeah, but the whole point of the CPU model feature was to fix that known issue. :)15:47
*** kashyap` is now known as kashyap15:47
sean-k-mooneykashyap`: what he is raising is if you have 10 skylake servers and 90 ivybridge servers then if you land on the skylake ones you will only be able to migrate to the skylake ones15:48
cfriesenas it stands, I think you'd need to set up host aggregates for the different hardware generations, or something like that.15:48
mriedemfwiw i've had a non-RH core nom in mind for stable15:48
sean-k-mooneyso you would set cpu_mode=custom cpu_mode=ivybridge to mitigate against that15:48
* kashyap needs to be AFK; will read scroll once back15:48
mdboothmriedem: Do say!15:48
mriedemill never tell!15:48
mriedemi can start that conversation again with the nova stable maint team15:49
*** ivve has quit IRC15:49
*** ykarel|away has quit IRC15:51
*** janki has quit IRC15:55
*** macza has joined #openstack-nova15:55
*** macza has quit IRC15:56
*** macza has joined #openstack-nova15:56
*** ccamacho has quit IRC15:57
*** smcginnis has joined #openstack-nova15:58
sean-k-mooneycfriesen: that is one apprch yes all though if i ever get arround to it i really want to play with the idea of a boaring host weigher that use traits as a proxy for how intersting a host is and selects the one with the least traits16:01
sean-k-mooneye.g. the most boaring hosts16:01
cfriesenboaring?  like wild pigs? :)16:01
sean-k-mooneywhich woudl mean if you did not ask for a trait specificaly the weigher would prefer selecting the oldest host16:01
cfriesensean-k-mooney: yeah, that's not a bad idea16:01
* mdbooth assumed boring16:02
cfriesenme too16:02
sean-k-mooneyyes its a weigher that digs holes :)16:02
*** wwriverrat has quit IRC16:02
cfriesensean-k-mooney: you'd still have the problem though that if you happened to land on a "newer" node due to resource pressure you'd be stuck on that hardware for live migration16:03
sean-k-mooneyya that is true but i acutlly want it for other reasons like avoiding my host that have gpus when you did not ask for them that sort of thing16:04
cfriesenit just seems unnecessarily restrictive to say that all guests on a node must have the same virtual CPU16:04
sean-k-mooneywell that is what nova has always done to this point but ya im aware of the new spec too16:04
sean-k-mooneypersonally i just use host-passthough and say screw it ill use host aggrates to seperate things if i need too16:05
sean-k-mooneyactully i used ot use AZs at intel for that and ould have one AZ per generation but that was just so i could select the generation simplely when lanuching a vm16:06
mtreinishmriedem: do I need to review something?16:06
mdboothmtreinish: https://review.opendev.org/#/c/659317/ please?16:06
*** luksky has joined #openstack-nova16:06
*** panda|rover has quit IRC16:09
*** panda has joined #openstack-nova16:10
sean-k-mooneyefried: thanks for reviewing the video models stuff ill adress your commets after dinner16:15
*** gyee has joined #openstack-nova16:15
*** igordc has joined #openstack-nova16:20
mriedemkashyap: https://bugs.launchpad.net/nova/+bug/1829896 for that guest not stopping thing, i checked the libvirtd logs and the power off requests all return with 016:20
openstackLaunchpad bug 1829896 in OpenStack Compute (nova) "libvirt: "Instance failed to shutdown in 60 seconds." in the gate" [Undecided,New]16:20
mriedemnot urgent but is concerning16:20
sean-k-mooneyi wonder if the qemu monitor process had hung?16:22
sean-k-mooneyi would expect a non 0 return in that case but i dont know if that is the case16:22
*** mgoddard has quit IRC16:25
*** ricolin has quit IRC16:27
*** mgoddard has joined #openstack-nova16:28
*** davidsha has quit IRC16:37
gansomriedem: hi Matt! Just a heads up in case you haven't seen it and have some free time to look at: https://review.opendev.org/#/c/659338 Thanks in advance! =)16:41
kashyapsean-k-mooney: Yeah, I'd expect this to return non-zero here, in of a hung QEMU mithe case of hung QEMU: 2019-05-16 19:47:19.996+0000: 10502: debug : virThreadJobClear:121 : Thread 10502 (virNetServerHandleJob) finished job remoteDispatchDomainShutdown with ret=016:41
*** mgoddard has quit IRC16:42
*** mgoddard has joined #openstack-nova16:43
kashyapmriedem: It seems to fail with the "MigrationsAdmin" test (but your bug descriptino says: 'snapshot'), whose purpose is "Add os-migration tests for Nova v2 API" (added in 2014).16:46
*** tssurya has quit IRC16:47
mriedemkashyap: if you look at the logstash results it's on pretty much everything16:48
*** dtantsur is now known as dtantsur|afk16:48
mriedemmigrate_disk_and_power_off in a cold migration / resize will also power off the guest16:48
mriedemwhich is where i noticed it while debugging a cold migration test today16:49
*** whoami-rajat has quit IRC16:49
kashyapHmm.  So it is the actual guest16:52
kashyapDamned if I could put a finger on why.  Let me ask the libvirt folks, if they can think of anything16:53
*** udesale has quit IRC16:53
kashyapWish I could reproduce the issue.  Damn sure it won't if I try locally16:53
kashyapOne dev asks:16:54
kashyap< aw> kashyap: is it the VM or the guest OS?  I've had fedora fail to shutdown in a timely way for all sorts of reasons, some that I still haven't figured out16:54
mriedemdon't know, but these test vms in the gate runs are just cirros images16:55
kashyap(I've told it's CirrOS; and it's the VM, aka. QEMU process)16:55
*** itlinux has joined #openstack-nova16:58
*** ivve has joined #openstack-nova16:59
openstackgerritElod Illes proposed openstack/nova stable/ocata: Fix incompatible version handling in BuildRequest  https://review.opendev.org/66045617:01
kashyapCan anyone please remind, where is the guest boot log from the serial console here: http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/compute1/logs/17:02
* kashyap --> make some dinner; be back later17:02
*** dpawlik has quit IRC17:08
sean-k-mooneyi think i just spent an hour debuging a unit test failure because teh unit tests in osc are wrong an i coppied them to create my own...17:09
*** tbachman has quit IRC17:10
*** tbachman has joined #openstack-nova17:11
*** igordc has quit IRC17:12
*** igordc has joined #openstack-nova17:13
*** jangutter_ has quit IRC17:14
sean-k-mooneynope i am wrong it was 2 hours but now they pass17:15
*** whoami-rajat has joined #openstack-nova17:15
*** dpawlik has joined #openstack-nova17:20
*** itlinux has quit IRC17:22
*** dpawlik has quit IRC17:24
*** eharney has quit IRC17:27
sean-k-mooneyaspiers: mriedem i just updated https://review.opendev.org/#/c/643578/ if there are any other changes you would like let me know with a comment :)17:30
aspierssean-k-mooney: ok will take a look thanks!17:30
*** ralonsoh has quit IRC17:37
*** ykarel|away has joined #openstack-nova17:37
*** priteau has quit IRC17:42
*** cdent has quit IRC17:43
*** itlinux has joined #openstack-nova17:44
*** igordc has quit IRC17:46
aspiersefried / anyone got any thoughts on whether it still makes sense to use nova.virt.libvirt.utils.file_open for mocking file opens?17:53
openstackgerritMerged openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts  https://review.opendev.org/63385517:53
openstackgerritMerged openstack/nova master: Extract provider tree functional tests into new file.  https://review.opendev.org/66015717:53
aspiers\o/ first real SEV patch lands in nova!17:54
aspiersfile_open() was added in 2011 by Soren with the original framework for testing the libvirt driver17:55
aspiershttps://opendev.org/openstack/nova/commit/bb622e6d7c921894fd0e7697a0003630989d4f3517:55
aspiershe wrote "I hope eventually to make it similar to fakelibvirt in style (e.g. keep track of files created and deleted and attempts to open a file that it doesn't know about, you'll get proper exceptions with proper errnos set and whatnot)."17:56
aspiersmeanwhile, a ton of other tests just use mock.mock_open()17:57
aspierssean-k-mooney: any thoughts?17:57
efriedaspiers: The reason it exists is so that fake_libvirt_utils can mock it18:00
efriedand fake_libvirt_utils is dying in a fire.18:00
efriedhttps://review.opendev.org/#/c/642558/818:00
efriedIMO there's no reason for it to exist; we should just use mock_open18:00
aspiersefried: my point was that a whole bunch of stuff needs to (and does) mock open, not just that18:00
aspiersand it seems we have two different ways of doing it right now18:00
efriedyup18:01
efriedIf you want to do the cleanup to kill file_open, I would support that.18:01
efriedmeanwhile, definitely don't do anything that relies of fake_libvirt_utils.file_open18:01
aspiersfile_open seems much less popular right now than mock_open18:01
efriedand save yourself having more cleanup by avoiding mocking file_open - just mock open.18:01
efriedyeah.18:02
efriedNice intention, but clearly nobody in the last eight years has cared enough to make it go.18:02
aspiershaving said that, Soren's original intention does make sense ... right18:02
efriedJust be wary of side effects. I had a situation recently where mocking open at the test method level was too broad and effed up, like, a dynamic import or something.18:02
aspiersbut file_open is actually also defined in nova/virt/libvirt/utils.py18:03
efriedso I had to do the18:03
efriedorig_open = builtins.open18:03
efrieddef fake_open(f, ...):18:03
efried    if f == 'thing_i_care_about':18:03
efried        do_the_mock_thing18:03
efried    else:18:03
efried        return orig_open(f, ...)18:03
efriedthing.18:03
aspiersisn't that what mock_open is supposed to help avoid?18:04
efriedyes, it's defined in fake_libvirt_utils because it was defined in libvirt.utils and apparently whoever set that up didn't know how to mock (or maybe mock wasn't properly powerful back then, dunno).18:04
efriedaforementioned series is getting rid of fake_libvirt_utils and just mocking the utils directly.18:05
aspiersah18:05
aspiersmakes sense, since a bunch of stuff is doing @mock.patch('nova.virt.libvirt.utils.file_open', ...18:05
aspiersI'll stare at that review until I understand it18:05
efriedaspiers: re "isn't that what mock_open is supposed to help avoid?" -- not that I know of. Is there a way to make the mock automatically trigger conditionally based on the inputs?18:06
aspiersI *think* there is, IIRC18:07
aspiersI may have even done it recently, but would have to check18:07
efriedI thought mock_open was just good for abstracting the context manager awkwardness and providing an easy way to specify "output".18:07
efriedI don't see any conditionally-use-the-real-open mentioned in https://docs.python.org/3.3/library/unittest.mock.html#mock-open18:08
aspiersYeah I'm probably thinking of something else18:10
aspiersmock is very powerful, but I find the API pretty damn confusing18:11
aspiersI don't think it's the best designed API in the world18:11
aspiersrspec is quite a bit easier to use18:11
*** READ10 has quit IRC18:12
aspiersefried: maybe I was just thinking of side_effect, which would presumably at least avoid the need for orig_open18:13
efriedaspiers: We should totally use mox18:13
efriedI don't see how side_effect would avoid needing orig_open18:14
aspiersAh, yeah maybe not18:14
*** panda has quit IRC18:14
efriedside_effect lets you replace the generic no-op method with a method of your own design.18:15
* aspiers crawls back in a corner and puts a dunce hat on18:15
efriedthat method would still have to have a condition to orig_open if that was a thing you needed.18:15
*** panda has joined #openstack-nova18:15
efriedno need for that, this is good discussion.18:15
aspiers;)18:15
efriedhelps clarify it in my mind if nothing else18:15
aspiersI was thinking that inside the side_effect context, the built-in open would still be available18:15
efriedah. Yeah, no.18:16
aspiersbut maybe it's not18:16
efriedyou would recurse into your mock.18:16
aspiersRight18:16
efriedand then other kinds of curse18:16
aspiersThat's necessary to support re-entrancy cases, I guess18:16
efriedalso because it was the simplest to implement :)18:16
aspiersI guess you were already well aware of https://governance.openstack.org/tc/goals/rocky/mox_removal.html18:18
*** jmlowe has quit IRC18:18
*** igordc has joined #openstack-nova18:18
aspiersI never tried mox, so it's a shame if that's nicer to work with, but I guess consistency trumps niceness18:18
efriedaspiers: I was totally kidding. We've been working on removing mox for years now.18:20
efriedI find it very difficult to understand, but that's probably mostly because I'm not used to it.18:20
*** eharney has joined #openstack-nova18:21
efriedweird method-chain-y way of setting things up18:21
efriedmethod chaining and pep8 don't mix very well18:21
*** xek_ has joined #openstack-nova18:21
aspiersOh right :)18:22
*** xek has quit IRC18:24
*** cfriesen has quit IRC18:28
*** cfriesen has joined #openstack-nova18:28
*** xek__ has joined #openstack-nova18:30
mriedemsean-k-mooney: i've noticed that the ksa only client stuff we're doing with port bindings in the nova/network/neutronv2/api.py stuff is not propagating the request id into the neutron requests which makes correlating the nova and neutron logs tricky18:31
*** xek_ has quit IRC18:33
mriedemhttps://bugs.launchpad.net/nova/+bug/182991418:36
openstackLaunchpad bug 1829914 in OpenStack Compute (nova) "nova context request_id is not propagated for port binding operations in neutron" [Medium,Triaged]18:36
aspiersefried: since you mentioned the idea of partial patching with pass-through to the original function in the cases which don't match specific parameters, what's the rationale for doing that?18:36
aspiersefried: for example I see it here: https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/virt/libvirt/test_driver.py#L1819918:36
aspiersbut if a test ends up hitting code which tests for file existence on the test system, shouldn't the test bomb out rather than accidentally succeed just because the original function luckily returns the right thing to make the test pass?18:37
aspiersAFAICS that would apply for both os.path.exists and file.open18:38
aspierse.g. I want to mock the result of os.path.exists('/sys/module/kvm_amd/parameters/sev'), but if the code happens to also run os.path.exists('something/else') then that should be mocked too18:39
*** itlinux has quit IRC18:40
aspiersI suppose assert_called_once_with() will take care of that18:44
aspiersohhhh, it needs to be able to find stuff like placement-policy.yaml18:48
*** xek has joined #openstack-nova18:49
*** xek__ has quit IRC18:50
aspiersOK, so I need to reuse patch_exists() which is currently in TestGuestConfigSysinfoSerialOS18:52
aspiersmaybe I can move it to nova.test.TestCase18:53
mriedemsean-k-mooney: it looks like the cross-cell resize revert cold migration flow is failing because when reverting on the dest host, we first delete the active dest host port binding and then on the source host, we update the port's binding:host_id to point at the source host, but that fails in neutron with a not found error i think because it's complaining that the dest host port binding is already gone18:55
mriedemwhich seems weird, i'm not sure why it would care18:55
mriedembut we might have the same issue for live migration rollbacks which we don't test in the gate18:55
mriedemi.e. i think we might need https://review.opendev.org/#/c/594139/18:57
openstackgerritDustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node  https://review.opendev.org/65969119:01
*** gyee has quit IRC19:07
efriedaspiers: Looks like you figured it out, but yeah, sometimes the code you're calling goes off and does things outside of the purview of the thing you're testing, and sometimes those things hit the thing you're mocking, if you're mocking something low-level like open or file existence, so you only want to use your mock in the code paths that you care about, and otherwise leave them unaffected.19:08
openstackgerritHamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support  https://review.opendev.org/65878619:08
aspiersefried: yeah, it hadn't occurred to me that os.path.exists() might be called on files which are actually inside the virtualenv, like placement-policy.yaml19:15
aspiersefried: but when I blanket-mocked it, placement blew up in my face :)19:16
aspiersefried: so I'm moving patch_exists() to nova.test.TestCase for reuse19:16
efriedight19:19
*** gyee has joined #openstack-nova19:19
sean-k-mooneymriedem: ill take a look. once we have activated the dest binding it should have atomicly delete teh source binding so that makes sense19:21
*** maciejjozefczyk has quit IRC19:26
mriedemi thought activating the dest binding just makes the source binding automatically inactive, but not deleted19:26
*** Sundar has joined #openstack-nova19:26
openstackgerritAdam Spiers proposed openstack/nova master: Move patch_exists() to nova.test.TestCase for reuse  https://review.opendev.org/66050019:26
aspiersefried: ^^^^19:26
*** whoami-rajat has quit IRC19:29
sean-k-mooneymriedem: actully looking at the spec https://specs.openstack.org/openstack/neutron-specs/specs/ocata/portbinding_information_for_nova.html#usage-by-nova you are correct but i had a feeling it was different for some reason19:30
mriedemlooking at the ml2 plugin code that also looks correct,19:30
mriedemoriginally i had also assumed the deleting the active binding would automatically re-activate the inactive binding, but that's not the case19:30
mriedemit just deletes the active port binding resource and i think that eventually makes the vif_type=unbound19:31
mriedemwhich is why i have https://review.opendev.org/#/c/594139/19:31
openstackgerritMerged openstack/nova stable/stein: Fix retry of instance_update_and_get_original  https://review.opendev.org/65931719:32
sean-k-mooneyyes if there is no active port binding having it revert to vif_type=unbound make sense19:32
mriedemmy guess is there might be a bug in neutron when (1) delete the active binding and then (2) change the port's binding:host_id to a new host (for the inactive binding), it must try to do some cleanup of the old binding and fails b/c it doesn't exist anymore19:32
sean-k-mooneywell thats the think i dont think its valide to just update teh inactive binding19:32
sean-k-mooneythat part of why the other live migration issue was happening19:33
sean-k-mooneythe neutron port bidning api seems to only work if you interact with it exactly as they expect with no auto recovery if we delete or update things19:34
sean-k-mooneythe spec didnt say we were allowed to interact with it in thos other ways so its fair but likely it could be made more robust19:34
mriedemyeah maybe, i'd accept that if i opened a neutron bug and that was the response19:34
mriedemor if mlavalle said that was the case19:35
*** ykarel|away has quit IRC19:36
sean-k-mooneyi also would not expect much push back if we specified the set of addtion behavior we intuitivly expect to work and proposed them as an extention19:36
mriedemi don't really care about making those edge cases work,19:36
mriedemi'd just like clarity on the api, since it's not documented in the api-ref19:36
mriedemso maybe that's the neutron bug is just lack of docs19:37
sean-k-mooneyright i more or less keep going back to the spec to determin what the expected behavior is19:37
sean-k-mooneymy guess is what happening is becasue of https://specs.openstack.org/openstack/neutron-specs/specs/ocata/portbinding_information_for_nova.html#effects-on-existing-apis19:37
sean-k-mooneyUpdate Port with host_id will still re-trigger port binding for a host. The difference will be update_port() will only action on the active binding.19:38
mriedem"The difference will be update_port() will only action on the active binding."19:38
mriedemyeah19:38
mriedemand if the active binding doesn't exist....19:38
mlavallemriedem: has the src inactive binding benn deleted when you try to go back?19:38
mriedemmlavalle: no19:38
mriedemwell, not as far as i know anyway19:38
mriedemnova isn't explicitly deleting the inactive source host binding19:39
sean-k-mooneythe correfct thing to do based on the spec would be to reactivate the souce binding19:39
mlavallein that case, I think that whn going back, activate tje source binding19:39
sean-k-mooneyrather then update it19:39
sean-k-mooneywhich is what mriedem is doing in https://review.opendev.org/#/c/594139/ correct19:39
sean-k-mooneyya in setup_networks_on_host19:40
mriedemok yeah that's what i'll try (when i can push up the change)19:41
sean-k-mooneymriedem: that is what you are already doing in https://review.opendev.org/#/c/594139/1/nova/network/neutronv2/api.py@42319:42
sean-k-mooneyinstance.host should be the souce host19:42
mriedemsean-k-mooney: that's not a patch in my cross-cell series though19:42
mriedemit's just a related thing19:42
sean-k-mooneyoh ok19:42
mriedemand ^ isn't merged anyway19:43
sean-k-mooneyi wonder if we call _update_port_binding_for_instance in teh revert flow19:44
sean-k-mooneythat might be why https://review.opendev.org/#/c/653506/ was fixign your cross cell issue19:45
mriedemi'm not using https://review.opendev.org/#/c/653506/ in the cross-cell series19:45
mriedemwhat fixed the cross-cell issue was i needed to activate the dest host bindings before calling migrate_instance_finish https://review.opendev.org/#/c/634832/29/nova/compute/manager.py@462519:45
mriedemsame as live migration in _post_live_migration19:46
sean-k-mooneyactully i missed something the cross cell migration/resize is a cold migration. you  choose to use the the multiple port binding flow for cross cell migrations?19:47
mriedemyes19:48
sean-k-mooneyah ok19:48
mriedembecause we want to validate early that we can create the port binding on the dest host in the target cell19:48
sean-k-mooneythen yes that makes sense that you would have to also add that19:48
sean-k-mooneyyep cross cell is proably even more imporant then live migration in that its likely more expensive to try again19:49
*** logan- has quit IRC19:55
sean-k-mooneyi think the answer is no but does the super conductor ever call the cell conductor or does it always interact directly with a compute node. that a general cellsv2 question not related to your patches19:55
sean-k-mooneyi just realised i dont think i have ever seen code in the conductor call another conductor but i have nerver actully looked either19:56
mriedemit calls the compute20:00
sean-k-mooneyand the compute talks to its local cell conductor as needed20:00
mriedemyes20:13
*** bbowen_ has quit IRC20:18
sean-k-mooneymriedem: thanks for the correction/comments on https://review.opendev.org/#/c/643578 ill fix that up tomorrow20:32
sean-k-mooneymriedem: are you ok with the verb 'resurrect' by the way20:33
mriedemfrom the forum session etherpad there is a note that mordred wants to talk about naming20:34
mriedemhttps://etherpad.openstack.org/p/DEN-osc-compute-api-gaps20:34
openstackgerritEric Fried proposed openstack/nova master: Support old & new versions of svm and avx traits  https://review.opendev.org/66051520:35
sean-k-mooneyill ping him and dean to review once i fix up the last few bits20:35
mriedemdansmith may or may not have strong feelings about how evacuate gets named in osc20:36
sean-k-mooneyill also proably submit a patch to try and swap over the nova live migration job to uses it but im not 100% certin a depens-on will work. i could add it to the requred project which should work but no sure we want to do that in general20:37
mriedemyou could test it with a dnm/wip patch until it's released in osc20:37
sean-k-mooneyya i can try that20:38
sean-k-mooneyits more i dont think we want to use osc in the gate form mater in general20:38
sean-k-mooneyso i can juse a dnm patch that does for testing20:38
sean-k-mooneythen drop the source install bit after its released20:38
sean-k-mooneyi just dont want to adde the python-openstackclient as a required project in the final version of the gate job patch but as you siad tis fine for a dnm or wip patch20:39
mriedemwe already use osc in the gate20:40
mriedemfor devstack and grenade20:40
mriedemusing the things we want users to use in our testing is a good thing20:40
dansmithmriedem: I dunno.. I definitely want a different name for it, but don't think we should change the API.. having it be named something different in osc seems confusing, especially since it will be a new operation that isn't one of the other three evacuates we have20:43
mriedemnew operation?20:44
mriedemit would just be the osc version of https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-evacuate20:44
*** hamzy has quit IRC20:45
sean-k-mooneymriedem: oh im not saying we shoulding use osc in the gate i was saying we proably want to stick to released versions in the gate rather then adding to reqiured porjects which get translated in to LIBS_FORM_GIT which will install it form master20:46
mriedemsean-k-mooney: yes agree20:46
sean-k-mooneydansmith: my current patch just delegated internall to the nova evacuate command so its the same one that we know and hate20:47
sean-k-mooneydansmith: origially i was calling the osc version "openstack server recreate" but aspiers asked me to change it to "openstack server resurrect"20:48
sean-k-mooneywhich is what the current patch uses20:48
dansmithsean-k-mooney: right and I'm saying having the command name be something new may not help with the confusion20:49
sean-k-mooneydansmith: that is vaild20:49
dansmithbecause now it will be "resurrect in osc, which is evacuate in novaclient, which is not host-evacuate or host-evacuate-live"20:49
*** xek has quit IRC20:49
sean-k-mooneyat least for osc we currently dont have the host versions20:49
*** dave-mccowan has quit IRC20:50
sean-k-mooneywe did talk about that in the fourm session however but bauzas is not a fan of adding them to osc and well i dont care one way or another20:50
mriedemand then i had to yell at both of you, it was great fun20:50
sean-k-mooney:)20:51
sean-k-mooneyanyway ill add the docs and a release not and fix all the spelling mistakes tomorrow then let the patch sit for a few days for peopel to think about20:52
*** dave-mccowan has joined #openstack-nova20:57
mriedemfwiw in osc the sub-command is scoped to the source which might avoid some confusion20:57
mriedemi.e. nova evacuate vs openstack server evacuate20:57
mriedemso that should lessen confusion over what evacuate means per resource20:57
mriedemif we did a whole host evacuate in osc, it would likely be "openstack compute service evacuate"20:58
mriedemsince there is a 'compute service' resource20:58
sean-k-mooneyis ironic the only case where there is not a 1:1 correspondece between compute services and hypervisors20:59
mriedemyes20:59
sean-k-mooneyin the ironic case you would jsut use teh server version20:59
sean-k-mooneyok i was wondering if vmware worked similarly21:00
mriedemit used to back before i think kilo or liberty21:00
mriedem1 nova-compute service host could manage M vcenters21:00
mriedemmuch hilarity ensued21:01
sean-k-mooneyim sure cdent has fond memories21:01
mriedemthis was pre-cdent in nova or vmware21:01
mriedembut coincidentally had dire consequences for evacuate21:01
mriedemi.e. nova deleting all vms in your vcenter21:02
mriedemoops!21:02
sean-k-mooneyi can imagine21:02
dansmithmriedem: you mean the scoping actually makes "evacuate" less bad right?21:04
sean-k-mooneythe only thing that is unintutive about evacuate (ignoring the host versions) is the fact for ephmereal root volumes you loose the data21:06
sean-k-mooneyif evacuated only worked for instacnes with shared storage it actully would be a good name for what it does21:07
sean-k-mooneywe brefliy discussed the idea of one command that always preservs your data and a second that always recreates the vm with the same image and flavor but again that might be more confusing21:08
sean-k-mooneyanway night all o/21:09
dansmiththat is not the only thing21:09
dansmithbut we've been over it a hundred times21:10
mriedemdansmith: yes21:10
dansmithI think keeping evacuate and relying on the scoping to disambiguate is the best plan at the moment21:10
*** logan- has joined #openstack-nova21:16
* aspiers agrees it is not the only thing unintuitive about it21:16
sean-k-mooneyill rephase while i wait for mincraft to load. the only thing where i have gone that must be a bug is the differecne between what we do for instance on shared storage vs non shared storage21:18
*** bbowen_ has joined #openstack-nova21:27
*** slaweq has quit IRC21:27
*** maciejjozefczyk has joined #openstack-nova21:38
*** _alastor_ has joined #openstack-nova21:39
*** dave-mccowan has quit IRC21:40
openstackgerritEric Fried proposed openstack/nova master: Remove nova.compute.*API() shims  https://review.opendev.org/66052721:42
*** maciejjozefczyk has quit IRC21:44
*** _alastor_ has quit IRC21:46
*** itlinux has joined #openstack-nova21:49
*** mriedem has quit IRC21:51
*** itlinux has quit IRC21:54
*** bbobrov has joined #openstack-nova21:56
*** cmart has quit IRC21:58
openstackgerritEric Fried proposed openstack/nova master: Remove nova.compute.*API() shims  https://review.opendev.org/66052722:01
dansmithefried: any luck raising melwitt for that ironic power state spec?22:01
efriednope22:03
dansmithaight, I'm about to end my day, so I'll leave it up on my screen to check in the morning22:03
efriedcool beans22:03
efrieddansmith: FYI I'm +2 all the way on cellsv1 removal, in case you want to hit those...22:04
efried...for some loose definition of "want",22:04
dansmithefried: probably should wait a few weeks until all the inactive former cellsv1 people have had a chance to look22:04
*** rcernin has joined #openstack-nova22:05
*** _alastor_ has joined #openstack-nova22:05
efriedVek: ^22:06
*** tesseract has quit IRC22:07
*** _alastor_ has quit IRC22:10
efriedbauzas: Would you please ack https://review.opendev.org/#/c/651681/ (since you had an earlier -1 on it)?22:11
*** ttsiouts has joined #openstack-nova22:15
*** itlinux has joined #openstack-nova22:26
*** _alastor_ has joined #openstack-nova22:39
*** rcernin has quit IRC22:40
*** ttsiouts has quit IRC22:40
*** rcernin has joined #openstack-nova22:41
*** itlinux has quit IRC22:43
*** tjgresha has joined #openstack-nova22:51
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Integrating with unified limits  https://review.opendev.org/61518022:53
efriedo/22:53
*** prometheanfire has joined #openstack-nova22:53
prometheanfirehttp://logs.openstack.org/54/660254/2/check/cross-nova-functional/a0617a9/testr_results.html.gz22:53
prometheanfirefailures for the new fasteners fasteners===0.1522:54
*** ttsiouts has joined #openstack-nova22:56
*** tkajinam has joined #openstack-nova22:59
*** ttsiouts has quit IRC23:01
*** Sundar has quit IRC23:02
*** ttsiouts has joined #openstack-nova23:05
*** rchurch_ has quit IRC23:11
*** _erlon_ has quit IRC23:17
*** luksky has quit IRC23:26
*** mlavalle has quit IRC23:36
*** macza has quit IRC23:39
*** macza has joined #openstack-nova23:40
*** itlinux has joined #openstack-nova23:45
*** itlinux_ has joined #openstack-nova23:47
*** macza has quit IRC23:47
*** itlinux has quit IRC23:49
*** tbachman has quit IRC23:57
*** itlinux_ has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!