| *** boxiang has quit IRC | 00:48 | |
| *** altlogbot_1 has quit IRC | 00:50 | |
| openstackgerrit | zhufl proposed openstack/nova master: Change some URLs to point to better targets https://review.opendev.org/658312 | 00:52 |
|---|---|---|
| *** altlogbot_3 has joined #openstack-nova | 00:55 | |
| *** ileixe has quit IRC | 01:03 | |
| *** bbowen has quit IRC | 01:06 | |
| *** bbowen has joined #openstack-nova | 01:08 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** slaweq has quit IRC | 01:15 | |
| *** awalende has joined #openstack-nova | 01:23 | |
| *** awalende has quit IRC | 01:28 | |
| *** ircuser-1 has quit IRC | 01:32 | |
| *** bbowen has quit IRC | 01:38 | |
| *** bbowen has joined #openstack-nova | 01:38 | |
| *** brinzhang has joined #openstack-nova | 01:49 | |
| *** ricolin has joined #openstack-nova | 02:22 | |
| *** ricolin_ has joined #openstack-nova | 02:31 | |
| openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716 | 02:31 |
| *** ricolin has quit IRC | 02:33 | |
| *** BjoernT has joined #openstack-nova | 02:49 | |
| *** BjoernT has quit IRC | 02:53 | |
| *** BjoernT has joined #openstack-nova | 02:54 | |
| *** whoami-rajat has joined #openstack-nova | 03:05 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** slaweq has quit IRC | 03:16 | |
| *** psachin has joined #openstack-nova | 03:19 | |
| *** ricolin_ has quit IRC | 03:44 | |
| *** udesale has joined #openstack-nova | 03:56 | |
| *** david-lyle is now known as dklyle | 03:58 | |
| *** ricolin_ has joined #openstack-nova | 04:03 | |
| *** dklyle has quit IRC | 04:03 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.opendev.org/575311 | 04:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.opendev.org/575581 | 04:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.opendev.org/576017 | 04:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.opendev.org/576018 | 04:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.opendev.org/576019 | 04:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 04:06 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 04:07 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 04:07 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 04:08 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 04:08 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 04:08 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 04:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 04:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 04:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 04:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153 | 04:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.opendev.org/637716 | 04:10 |
| *** itlinux has joined #openstack-nova | 04:10 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 04:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix a description for config_drive parameter https://review.opendev.org/653683 | 04:11 |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** BjoernT has quit IRC | 04:25 | |
| *** Luzi has joined #openstack-nova | 04:42 | |
| *** jaosorior has joined #openstack-nova | 04:43 | |
| *** dpawlik has joined #openstack-nova | 04:44 | |
| *** jaosorior has quit IRC | 04:52 | |
| *** tjgresha has quit IRC | 04:57 | |
| *** tjgresha has joined #openstack-nova | 04:57 | |
| *** jaosorior has joined #openstack-nova | 05:00 | |
| *** hongbin has quit IRC | 05:02 | |
| *** ratailor has joined #openstack-nova | 05:03 | |
| *** ivve has quit IRC | 05:07 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** boxiang has joined #openstack-nova | 05:18 | |
| *** ricolin_ has quit IRC | 05:31 | |
| *** ricolin has joined #openstack-nova | 05:36 | |
| *** guozijn has joined #openstack-nova | 05:38 | |
| *** lpetrut has joined #openstack-nova | 05:39 | |
| *** guozijn has left #openstack-nova | 05:40 | |
| *** guozijn has joined #openstack-nova | 05:41 | |
| *** udesale has quit IRC | 05:45 | |
| *** udesale has joined #openstack-nova | 05:45 | |
| *** udesale has quit IRC | 05:49 | |
| *** udesale has joined #openstack-nova | 05:49 | |
| *** guozijn_ has joined #openstack-nova | 05:55 | |
| *** lpetrut has quit IRC | 05:55 | |
| *** guozijn has quit IRC | 05:56 | |
| *** guozijn_ is now known as guozijn | 05:56 | |
| *** alex_xu has joined #openstack-nova | 05:59 | |
| *** lpetrut has joined #openstack-nova | 06:06 | |
| *** sapd1_x has joined #openstack-nova | 06:11 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** slaweq has quit IRC | 06:16 | |
| *** pcaruana has joined #openstack-nova | 06:16 | |
| *** boxiang has quit IRC | 06:17 | |
| *** ivve has joined #openstack-nova | 06:17 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 06:17 |
| *** boxiang has joined #openstack-nova | 06:17 | |
| *** lpetrut has quit IRC | 06:22 | |
| openstackgerrit | Merged openstack/nova master: Change some URLs to point to better targets https://review.opendev.org/658312 | 06:38 |
| *** udesale has quit IRC | 06:47 | |
| *** udesale has joined #openstack-nova | 06:47 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:56 | |
| *** awalende has joined #openstack-nova | 06:58 | |
| *** awalende has quit IRC | 07:01 | |
| *** rcernin has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-nova | 07:12 | |
| *** tesseract has joined #openstack-nova | 07:17 | |
| *** rpittau|afk is now known as rpittau | 07:18 | |
| *** ccamacho has joined #openstack-nova | 07:20 | |
| *** yan0s has joined #openstack-nova | 07:21 | |
| *** slaweq has quit IRC | 07:28 | |
| *** igordc has quit IRC | 07:29 | |
| *** tssurya has joined #openstack-nova | 07:31 | |
| *** itlinux has quit IRC | 07:35 | |
| *** helenafm has joined #openstack-nova | 07:39 | |
| *** awalende has joined #openstack-nova | 07:40 | |
| *** igordc has joined #openstack-nova | 07:44 | |
| *** janki has joined #openstack-nova | 07:46 | |
| *** ralonsoh has joined #openstack-nova | 07:53 | |
| *** igordc has quit IRC | 07:55 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | 08:05 |
| *** jangutter has joined #openstack-nova | 08:05 | |
| *** ricolin has quit IRC | 08:15 | |
| *** ricolin has joined #openstack-nova | 08:15 | |
| *** ricolin has quit IRC | 08:19 | |
| *** ricolin has joined #openstack-nova | 08:20 | |
| *** ricolin has quit IRC | 08:21 | |
| *** tkajinam has quit IRC | 08:31 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 08:38 |
| *** derekh has joined #openstack-nova | 08:48 | |
| *** sapd1_x has quit IRC | 08:57 | |
| *** takashin has left #openstack-nova | 09:00 | |
| *** xek has joined #openstack-nova | 09:18 | |
| ralonsoh | stephenfin, hi. I'm having problems with https://review.opendev.org/#/c/655694/ (Queens) because of sphinx | 09:24 |
| *** sapd1_x has joined #openstack-nova | 09:24 | |
| ralonsoh | stephenfin, is ok if I cherry-pick https://review.opendev.org/#/c/479862/ to Queens? | 09:24 |
| *** mgoddard has joined #openstack-nova | 09:25 | |
| *** wxy-xiyuan has joined #openstack-nova | 09:39 | |
| *** dpawlik has quit IRC | 09:41 | |
| *** dpawlik has joined #openstack-nova | 09:41 | |
| jangutter | ralonsoh: hmmm, the other option is to pin sphinx to an older version for the queens release. | 09:57 |
| ralonsoh | I'll take a look at sphinx versions to know which one supports both, 2 and 3 | 09:57 |
| *** janki has quit IRC | 09:58 | |
| ralonsoh | jangutter, probably <2.0 | 09:58 |
| *** janki has joined #openstack-nova | 09:58 | |
| jangutter | ralonsoh: yep, out of interest, what does Nova do for queens? | 09:58 |
| ralonsoh | jangutter, I'll review this now | 09:58 |
| stephenfin | ralonsoh: Sphinx isn't the problem. We need this 96b5a11d | 10:02 |
| stephenfin | Sorry, https://opendev.org/openstack/os-vif/commit/96b5a11d | 10:03 |
| ralonsoh | stephenfin, yes, I saw this. os-vif was not using upper-constraints | 10:03 |
| stephenfin | yup | 10:04 |
| stephenfin | bad os-vif | 10:04 |
| stephenfin | bad | 10:04 |
| ralonsoh | hehehe | 10:04 |
| ralonsoh | should I cherry-pick this patch to previous versions? Queens? | 10:04 |
| stephenfin | Yeah, but change the URL to https://releases.openstack.org/constraints/upper/queens | 10:05 |
| ralonsoh | stephenfin, perfect. Thanks!! | 10:05 |
| stephenfin | (And include a 'NOTE(ralonsoh):' in the commit message saying that, so people know wtf happened in the future :D) | 10:05 |
| ralonsoh | stephenfin, perfect | 10:06 |
| *** lpetrut has joined #openstack-nova | 10:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796 | 10:19 |
| *** guozijn has quit IRC | 10:23 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780 | 10:24 |
| ralonsoh | stephenfin, please feel free to modify the commit message to add a good NOTE https://review.opendev.org/#/c/658780/ | 10:24 |
| ralonsoh | stephenfin, yours will be better than mine | 10:24 |
| *** slaweq has joined #openstack-nova | 10:25 | |
| stephenfin | ralonsoh: done | 10:29 |
| ralonsoh | stephenfin, thanks! | 10:29 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780 | 10:33 |
| openstackgerrit | Merged openstack/python-novaclient master: Tiny fix of documentation https://review.opendev.org/657522 | 10:35 |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Process VIF type ovs-dpdk for dpdk representor ports https://review.opendev.org/658785 | 10:44 |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Plug ovs-dpdk vif port type for dpdk representor integration https://review.opendev.org/658786 | 10:47 |
| *** tbachman has quit IRC | 10:48 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694 | 10:54 |
| *** nicolasbock has joined #openstack-nova | 11:04 | |
| *** slaweq has quit IRC | 11:09 | |
| *** udesale has quit IRC | 11:17 | |
| *** baderbuddy has joined #openstack-nova | 11:20 | |
| *** nicolasbock has quit IRC | 11:20 | |
| *** nicolasbock has joined #openstack-nova | 11:20 | |
| *** baderbuddy has quit IRC | 11:26 | |
| *** janki has quit IRC | 11:29 | |
| *** jchhatbar has joined #openstack-nova | 11:29 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780 | 11:41 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/queens: [DEBUG] Add functional confirm_migration_error test https://review.opendev.org/658136 | 11:44 |
| *** boxiang has quit IRC | 11:51 | |
| *** boxiang has joined #openstack-nova | 11:51 | |
| *** boxiang has quit IRC | 11:54 | |
| *** boxiang has joined #openstack-nova | 11:57 | |
| *** tbachman has joined #openstack-nova | 12:11 | |
| *** slaweq has joined #openstack-nova | 12:26 | |
| *** mgariepy has quit IRC | 12:27 | |
| *** mgariepy has joined #openstack-nova | 12:31 | |
| *** ratailor has quit IRC | 12:34 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648659 | 12:38 |
| *** psachin has quit IRC | 12:46 | |
| openstackgerrit | Merged openstack/nova master: api-ref: fix mention of all_tenants filter for non-admins https://review.opendev.org/657620 | 12:47 |
| *** slaweq has quit IRC | 12:52 | |
| *** pcaruana|afk| has joined #openstack-nova | 12:55 | |
| *** pcaruana has quit IRC | 12:57 | |
| *** rchurch has joined #openstack-nova | 12:58 | |
| openstackgerrit | Merged openstack/nova master: Update Python 3 test runtimes for Train https://review.opendev.org/657941 | 12:58 |
| *** wxy-xiyuan has quit IRC | 12:59 | |
| *** jbernard_ has joined #openstack-nova | 12:59 | |
| *** rpittau has quit IRC | 12:59 | |
| *** rchurch_ has quit IRC | 12:59 | |
| *** psyton has quit IRC | 12:59 | |
| *** vdrok has quit IRC | 12:59 | |
| *** jdillaman has joined #openstack-nova | 13:00 | |
| *** jbernard has quit IRC | 13:00 | |
| *** vdrok has joined #openstack-nova | 13:00 | |
| *** rpittau has joined #openstack-nova | 13:02 | |
| *** BjoernT has joined #openstack-nova | 13:03 | |
| *** brinzhang has quit IRC | 13:09 | |
| *** slaweq has joined #openstack-nova | 13:09 | |
| *** Luzi has quit IRC | 13:10 | |
| *** udesale has joined #openstack-nova | 13:10 | |
| *** wxy-xiyuan has joined #openstack-nova | 13:14 | |
| *** udesale has quit IRC | 13:18 | |
| *** udesale has joined #openstack-nova | 13:18 | |
| *** efried has quit IRC | 13:19 | |
| *** efried has joined #openstack-nova | 13:20 | |
| *** mchlumsky has joined #openstack-nova | 13:23 | |
| *** slaweq has quit IRC | 13:26 | |
| *** dpawlik has quit IRC | 13:35 | |
| kashyap | efried: When you're about, thanks for the feedback on the 'traits' thingie. While I don't want to belabor this, please see the "Another Idea" section here: https://review.opendev.org/#/c/655193/4 | 13:39 |
| *** awalende has quit IRC | 13:40 | |
| kashyap | efried: If you (and any others) think that's sensible (I think it is, FWIW), I'll go and file a bug to track it. | 13:40 |
| kashyap | (And of course, then fix it :D) | 13:40 |
| efried | kashyap: ack, looking. | 13:40 |
| *** awalende has joined #openstack-nova | 13:41 | |
| kashyap | (Sorry for the broken formatting; I wrote it locally in plain text and posted it there. As typing in the tiny window of Grrrrit was infuriating.) | 13:41 |
| *** awalende has quit IRC | 13:42 | |
| efried | kashyap: You know you can resize the tiny window, right? | 13:43 |
| efried | handle on the bottom right | 13:43 |
| kashyap | efried: No, I didn't realize that | 13:43 |
| efried | re intel vs amd, it sounds like you're agreeing with me? or not? | 13:43 |
| *** awalende has joined #openstack-nova | 13:43 | |
| kashyap | Ha! | 13:43 |
| *** awalende has quit IRC | 13:43 | |
| kashyap | (Just saw that) | 13:43 |
| *** awalende has joined #openstack-nova | 13:44 | |
| efried | brb, gotta med a cat | 13:44 |
| kashyap | efried: You mean, on having the generic *_CURE traits? | 13:44 |
| kashyap | Sure | 13:44 |
| kashyap | (I need to go into a 20-min meeting in 16 min, then be here for 30 min, then head out to catch a train back home) | 13:45 |
| openstackgerrit | chenker proposed openstack/python-novaclient master: Optimize limit option docs string description for novaclient https://review.opendev.org/643035 | 13:45 |
| dtantsur | hi folks! how crazy would it be to backport https://review.opendev.org/#/c/563722/ ? it's a bug fix, but it adds new driver calls.. | 13:45 |
| *** janki has joined #openstack-nova | 13:47 | |
| *** janki has quit IRC | 13:47 | |
| kashyap | efried: When you're back: on picking Intel/AMD-specific traits, I think we should try not to "abstract" them out, and have separate traits per vendor, for clarity. (Open to change my mind if I missed to consider something more important.) | 13:48 |
| *** jchhatbar has quit IRC | 13:48 | |
| *** awalende has quit IRC | 13:48 | |
| kashyap | dtantsur: Looks fairly invasive to me. Depends on how far you want to backport | 13:49 |
| kashyap | dtantsur: Also, how 'important' it is - as in, if the bug is severe, then probably you might get away with it | 13:49 |
| dtantsur | I'm mostly interested in queens | 13:49 |
| efried | kashyap: Intel/AMD I'm just talking about making the namespaces more distinctive. | 13:49 |
| efried | kashyap: tbc, I agree that we should keep the granular traits. | 13:49 |
| efried | And making rollup traits, if we do it at all, could still be done later. | 13:50 |
| kashyap | Ah, okay. efried -- Sorry, more distinctive, how? | 13:50 |
| kashyap | efried: Yeah, good point (that the door is open for roll-up for future). | 13:50 |
| efried | like hw/cpu/x86/intel and hw/cpu/x86/amd | 13:50 |
| *** amodi has joined #openstack-nova | 13:51 | |
| efried | kashyap: but my point about the granular traits with no rollups is that they don't help operators unless they're okay predetermining whether they want amd or intel. | 13:51 |
| efried | because we don't have required=in: yet | 13:51 |
| dtantsur | people suspect it may be the cause or one of the causes of https://bugzilla.redhat.com/show_bug.cgi?id=1560690#c60 | 13:52 |
| openstack | bugzilla.redhat.com bug 1560690 in openstack-heat "Re-deployment of overcloud fails with: ResourceInError: resources.OpenShiftWorker: Went to status ERROR due to "Message: Build of instance c7c5191b-59ed-44a0-8b2a-0f68e48e9a52 aborted: Failure prepping block device., Code: 500"" [High,Assigned] - Assigned to jkreger | 13:53 |
| * dtantsur hopes the link is public | 13:53 | |
| kashyap | efried: Yeah, okay, I agree with the making more distinctive part. | 13:53 |
| dansmith | dtantsur: doesn't seem too crazy | 13:53 |
| kashyap | efried: Right - I see that point. Hmm, damn "real world" | 13:53 |
| dansmith | IMHO | 13:53 |
| *** priteau has joined #openstack-nova | 13:53 | |
| kashyap | efried: What do you think about the 'sysfs' thingie? | 13:53 |
| *** BjoernT has quit IRC | 13:53 | |
| kashyap | efried: I.e. Nova traversing /sys/devices/system/cpu/vulnerabilities/meltdown (and /sys/devices/system/cpu/vulnerabilities/spectre_*) -- if either of them report vulnerable, then warn that future Nova will refuse to launch VMs on that host | 13:53 |
| kashyap | (And next release, make it good on the warning promise. | 13:54 |
| kashyap | ) | 13:54 |
| * kashyap bbiab | 13:54 | |
| efried | kashyap: Reporting generically "vulnerable" as opposed to "mitigation" - sure, that's fine by me, whatever the implementation winds up being. | 13:54 |
| *** takashin has joined #openstack-nova | 13:54 | |
| kashyap | efried: Right. I was just noting the notion of what the 'sysfs' reports. If you're _secure_, it is represented as: (You have) "Mitigation": $MITIGATION | 13:55 |
| efried | kashyap: I don't think we should enforce "you can't land on a vulnerable host" across the board. There are surely some environments where they don't care (if all vms in the az are trusted, or whatever) | 13:55 |
| kashyap | efried: Yeah, I hear ya. | 13:55 |
| efried | kashyap: being able to expose that as a trait, where it's not intel/amd specific, is the part I care about. | 13:55 |
| efried | whether it's positive or negative, or how it's determined, I trust you :) | 13:56 |
| efried | so | 13:56 |
| efried | for this patch | 13:56 |
| efried | fix the typo | 13:56 |
| efried | make intel and amd namespaces and move the granular traits appropriately | 13:56 |
| efried | done | 13:57 |
| efried | yah? | 13:57 |
| kashyap | efried: Yeah, makes sense. | 13:57 |
| efried | and then make a new patch with the 'vulnerable' thing in the generic x86 namespace in whatever form you decide will work. | 13:57 |
| kashyap | Nod | 13:58 |
| kashyap | efried: Thanks for your time and discussion! | 13:58 |
| *** BjoernT has joined #openstack-nova | 13:59 | |
| efried | thanks for your patience | 13:59 |
| *** BjoernT has quit IRC | 14:02 | |
| *** BjoernT has joined #openstack-nova | 14:03 | |
| *** slaweq has joined #openstack-nova | 14:05 | |
| *** gmann has joined #openstack-nova | 14:07 | |
| *** gmann is now known as gmann_pto | 14:07 | |
| *** ratailor has joined #openstack-nova | 14:10 | |
| *** jbernard_ is now known as jbernard | 14:13 | |
| *** artom has joined #openstack-nova | 14:24 | |
| *** ratailor has quit IRC | 14:24 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796 | 14:25 |
| *** mriedem has joined #openstack-nova | 14:25 | |
| *** slaweq has quit IRC | 14:34 | |
| *** takashin has quit IRC | 14:35 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/rocky: [DEBUG] Add functional confirm_migration_error test https://review.opendev.org/658834 | 14:35 |
| *** sean-k-mooney has joined #openstack-nova | 14:39 | |
| *** sean-k-mooney has left #openstack-nova | 14:39 | |
| *** sean-k-mooney has quit IRC | 14:39 | |
| *** sean-k-mooney has joined #openstack-nova | 14:40 | |
| *** hongbin has joined #openstack-nova | 14:53 | |
| johnthetubaguy | stephenfin: added a -2 as this looks like an API change that breaks our microversion contract, would be great if you can double check my reasoning on there: https://review.opendev.org/#/c/350299 | 14:54 |
| *** pcaruana|afk| has quit IRC | 14:55 | |
| stephenfin | johnthetubaguy: Ack. I'll take a look | 14:56 |
| johnthetubaguy | thanks | 14:57 |
| *** macza has joined #openstack-nova | 14:57 | |
| *** __hemna has quit IRC | 14:57 | |
| *** belmoreira has joined #openstack-nova | 14:58 | |
| *** beekneemech is now known as bnemec | 15:00 | |
| *** tbachman has quit IRC | 15:01 | |
| sean-k-mooney | johnthetubaguy: ya i think that proably should have a micro version bump if we make that change | 15:02 |
| johnthetubaguy | its a deprecated API now, so I think we just block it? seems harsh though | 15:03 |
| johnthetubaguy | one alternative is to error with conflict when ports that have a floating ip are changed via that API, as we know something odd happens | 15:04 |
| sean-k-mooney | johnthetubaguy: i was thinking something similar | 15:04 |
| sean-k-mooney | but i was not sure we were allowed to | 15:05 |
| sean-k-mooney | personally i would prefer that you were requried to disassociate the fip first | 15:05 |
| johnthetubaguy | its borderline... | 15:06 |
| sean-k-mooney | but again that would need a micro version too right | 15:06 |
| sean-k-mooney | what we could do is just remove the fixed ip but not the port id from the floating ip | 15:07 |
| johnthetubaguy | hmm, I though that is what happened today? | 15:08 |
| johnthetubaguy | oh wait, I see what you mean now | 15:08 |
| johnthetubaguy | hmm, that is probably more surprising at this point | 15:08 |
| sean-k-mooney | if the port has multiple fixed ips and you dont specify one when setting the fip assocation it just uses the first | 15:09 |
| johnthetubaguy | hmm, re-reading | 15:09 |
| sean-k-mooney | so if the port has multiple fixed ips i dont know if you would expect it to be retarged to one of the others or not | 15:09 |
| artom | efried, https://review.opendev.org/#/c/603955/12/specs/train/approved/nova-cyborg-interaction.rst@249 | 15:12 |
| artom | See PS11, L250 | 15:12 |
| efried | thanks artom | 15:13 |
| sean-k-mooney | anyway i can see the logic of removing the fip association and also of not. since we dont know what we should do i feel raising an error is best but honestly i would be fine with doing nothing and not merging the patch also. | 15:14 |
| dansmith | sean-k-mooney: johnthetubaguy that was last touched by the owner in 2017 right? | 15:14 |
| dansmith | I think we can probably just ignore it | 15:14 |
| *** wwriverrat has joined #openstack-nova | 15:14 | |
| *** ircuser-1 has joined #openstack-nova | 15:15 | |
| johnthetubaguy | dansmith: oops, I see even the +2 was from 2017 now... | 15:16 |
| dansmith | johnthetubaguy: yeah :) | 15:16 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845 | 15:17 |
| sean-k-mooney | dansmith: mriedem rebased it in april i wonder if he had a customer ask about it | 15:17 |
| mriedem | nope | 15:17 |
| *** yan0s has quit IRC | 15:17 | |
| sean-k-mooney | in that case ya we canb proably just abandon it | 15:18 |
| johnthetubaguy | I was trying to find some low hanging +Ws (facepalm) | 15:18 |
| mriedem | i likely saw it at the top of http://status.openstack.org/reviews/#nova during the forum and just rebased it to see if it still worked | 15:18 |
| dansmith | johnthetubaguy: a noble goal :) | 15:18 |
| johnthetubaguy | ah, similar, found it in the review dashboard | 15:18 |
| johnthetubaguy | abandoned it, its a distraction for sure | 15:19 |
| openstackgerrit | Merged openstack/nova master: Trivial: Adds comments and tests for scheduler https://review.opendev.org/658516 | 15:19 |
| mriedem | as noted in the review, the remove_fixed_ip_from_instance (and add counterpart) were added to mirror nova-net functionality and i think i pointed out (now years ago) that it was more or less super janky | 15:20 |
| ganso | mriedem: Hi Matt, I fixed the functional test and ran it against queens and rocky (https://review.opendev.org/#/c/658136 and https://review.opendev.org/#/c/658834) and unfortunately it seems the fix that merged in rocky does not solve the issue | 15:20 |
| mriedem | ok | 15:24 |
| mriedem | johnthetubaguy: super old bug for the same api https://bugs.launchpad.net/nova/+bug/1533260 | 15:28 |
| openstack | Launchpad bug 1533260 in OpenStack Compute (nova) "Unexpected API Error is returned, when trying to add fixed IP to an instance in ERROR state" [Medium,Confirmed] | 15:28 |
| mriedem | well, same set of apis | 15:28 |
| mriedem | https://review.opendev.org/#/c/163864/ was the super old re-write of the apis | 15:29 |
| mriedem | abandoned in 2016 with "does anyone use this? don't think so" | 15:30 |
| johnthetubaguy | yeah, although that fix looks fine, but meh. | 15:31 |
| mriedem | "The more I think about, maybe the existing behaviour is correct. I need to catch up with mriedem about this." | 15:32 |
| mriedem | july 4 2016 | 15:32 |
| mriedem | i was knee deep in grilled meats and explosives | 15:33 |
| mriedem | ganso: i'll pull your rocky test down and play with it to see if i can figure out what's going on | 15:35 |
| ganso | mriedem: thanks Matt! =) | 15:36 |
| mriedem | sean-k-mooney: in case you didn't notice, i got a recreate on https://review.opendev.org/#/c/653506/ stacked above it and cleaned it up, should be good to go now | 15:36 |
| mriedem | also figured out what i was doing wrong in the cross-cell resize series that was hitting that, so once i got that fixed i got a clean run in the multi cell job for cross-cell cold migration | 15:36 |
| *** itlinux has joined #openstack-nova | 15:37 | |
| *** igordc has joined #openstack-nova | 15:37 | |
| *** hongbin has quit IRC | 15:39 | |
| *** igordc has quit IRC | 15:40 | |
| *** pcaruana|afk| has joined #openstack-nova | 15:44 | |
| *** mvkr has joined #openstack-nova | 15:46 | |
| *** igordc has joined #openstack-nova | 15:47 | |
| openstackgerrit | Balazs Gibizer proposed openstack/os-traits master: Add REPORT_PARENT_INTERFACE_NAME_FOR_SRIOV_NIC trait https://review.opendev.org/658852 | 15:51 |
| *** jangutter has quit IRC | 15:52 | |
| *** __hemna has joined #openstack-nova | 15:57 | |
| *** __hemna has quit IRC | 15:58 | |
| *** tbachman has joined #openstack-nova | 15:58 | |
| *** hemna has joined #openstack-nova | 15:59 | |
| *** mlavalle has joined #openstack-nova | 16:03 | |
| *** helenafm has quit IRC | 16:03 | |
| *** BjoernT has quit IRC | 16:04 | |
| *** canori01 has joined #openstack-nova | 16:06 | |
| canori01 | hello, I am running nova 18.0.2 and setting disk-cachemodes to writeback | 16:07 |
| canori01 | However, the instance xml says none. Is this intended behavior? | 16:08 |
| sean-k-mooney | mriedem: hi sorry was in a meeting | 16:09 |
| sean-k-mooney | mriedem: im just grabing lunch but ill read through comment you left thanks for looking at this in depth | 16:09 |
| *** awalende has joined #openstack-nova | 16:14 | |
| *** awalende has quit IRC | 16:19 | |
| *** belmoreira has quit IRC | 16:19 | |
| *** tesseract has quit IRC | 16:20 | |
| gibi | efried: I'm going to be away til Wednesday next week so I'm wondering if I should pul the heal port allocation from the runway slot | 16:20 |
| *** dtantsur is now known as dtantsur|afk | 16:23 | |
| *** rpittau is now known as rpittau|afk | 16:25 | |
| *** roukoswarf is now known as rouk | 16:30 | |
| *** whoami-rajat has quit IRC | 16:31 | |
| *** rouk is now known as roukoswarf | 16:32 | |
| *** whoami-rajat has joined #openstack-nova | 16:36 | |
| *** priteau has quit IRC | 16:38 | |
| *** roukoswarf is now known as rouk | 16:40 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845 | 16:45 |
| openstackgerrit | Merged openstack/os-vif master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655068 | 16:48 |
| *** ivve has quit IRC | 16:48 | |
| *** mgoddard has quit IRC | 16:50 | |
| *** nicolasbock has quit IRC | 16:50 | |
| *** nicolasbock has joined #openstack-nova | 16:50 | |
| *** mgoddard has joined #openstack-nova | 16:52 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780 | 16:53 |
| *** mgoddard has quit IRC | 16:57 | |
| *** imacdonn has joined #openstack-nova | 16:57 | |
| *** mgoddard has joined #openstack-nova | 16:58 | |
| *** udesale has quit IRC | 16:59 | |
| *** slaweq has joined #openstack-nova | 17:04 | |
| *** rouk has quit IRC | 17:07 | |
| *** mgoddard has quit IRC | 17:16 | |
| *** med_ has joined #openstack-nova | 17:17 | |
| *** mgoddard has joined #openstack-nova | 17:21 | |
| *** mchlumsky has quit IRC | 17:23 | |
| openstackgerrit | Merged openstack/nova master: Cleanup update_instance cell mapping handling https://review.opendev.org/467380 | 17:23 |
| *** lpetrut has quit IRC | 17:27 | |
| *** mchlumsky has joined #openstack-nova | 17:29 | |
| *** ralonsoh has quit IRC | 17:32 | |
| *** jroll has quit IRC | 17:34 | |
| *** jroll has joined #openstack-nova | 17:35 | |
| openstackgerrit | Merged openstack/nova master: Remove cells v2 transition code from update_instance https://review.opendev.org/467382 | 17:35 |
| openstackgerrit | Merged openstack/nova master: api-ref: 'os-hypervisors' doesn't reflect overcommit ratio https://review.opendev.org/611604 | 17:35 |
| *** derekh has quit IRC | 17:37 | |
| *** slaweq has quit IRC | 17:43 | |
| efried | gibi: Probably a good idea. | 17:44 |
| *** itlinux has quit IRC | 17:50 | |
| *** BjoernT has joined #openstack-nova | 17:50 | |
| *** itlinux has joined #openstack-nova | 17:53 | |
| *** sapd1_x has quit IRC | 17:56 | |
| *** dklyle has joined #openstack-nova | 17:59 | |
| *** slaweq has joined #openstack-nova | 18:01 | |
| *** igordc has quit IRC | 18:04 | |
| *** dklyle has quit IRC | 18:08 | |
| *** slaweq has quit IRC | 18:12 | |
| *** ivve has joined #openstack-nova | 18:19 | |
| *** dklyle has joined #openstack-nova | 18:23 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] Testing links to inline comments, ignore https://review.opendev.org/658887 | 18:30 |
| artom | Crap, that was supposed to go to downstream gerrit :( | 18:30 |
| sean-k-mooney | am it did | 18:32 |
| sean-k-mooney | oh you posted it upstream then downstream | 18:32 |
| *** dklyle has quit IRC | 18:34 | |
| artom | I learn from my mistakes :D | 18:36 |
| artom | For posterioriy, @a<line number> links to the "before"/left pane. | 18:37 |
| *** igordc has joined #openstack-nova | 18:37 | |
| *** dpawlik has joined #openstack-nova | 19:03 | |
| *** slaweq has joined #openstack-nova | 19:17 | |
| *** JamesBenson has joined #openstack-nova | 19:27 | |
| *** alex_xu has quit IRC | 19:32 | |
| *** gmann_pto has quit IRC | 19:33 | |
| openstackgerrit | Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903 | 19:37 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Add 'power-update' external event to listen to ironic https://review.opendev.org/645611 | 19:37 |
| *** JamesBenson has quit IRC | 19:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.opendev.org/621313 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353 | 19:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478 | 19:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 19:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 19:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904 | 19:40 |
| mriedem | dansmith: i've hit a not-so-fun snag in pre-validating the target host wrt attached volumes in the cross-cell resize stuff and i'd like to brain dump | 19:41 |
| dansmith | okay | 19:41 |
| mriedem | so we want to try and connect the volume on the dest host to see if it will work before starting the whole process, | 19:42 |
| mriedem | to do that, i need to update the volume attachment with the dest host connector to get the connection_info dict that the virt driver uses, | 19:42 |
| mriedem | the problem is, at the point i'm doing that, the source host volume attachment still exists and cinder pukes saying you essentially can't have more than one connected attachment for the same volume at the same time | 19:42 |
| mriedem | which makes sense i guess, and is not something we hit in a normal move because we delete the source host attachment before finishing on the dest | 19:43 |
| mriedem | granted normal resize could fail the same thing today - if you can't connect the volume on the dest after we've transferred the disks and stuff | 19:44 |
| dansmith | cross-cell is actually easier in this case because you have two separate instances and attachments on the nova side | 19:44 |
| dansmith | normal resize would need to stash that in case it needs to revert right? or maybe just ask cinder again.. tbh, I dunno how that attachment stuff works really :) | 19:44 |
| mriedem | attachments in cinder are essentially ephemeral, we can create and delete them as needed, or that's the idea anyway | 19:45 |
| mriedem | so if i want to make this work, | 19:45 |
| *** macza has quit IRC | 19:45 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648659 | 19:46 |
| mriedem | i'd need to do something like delete the source host attachment, update the attachment with the dest host connector so we can test the connection on the dest host, | 19:46 |
| *** macza has joined #openstack-nova | 19:46 | |
| mriedem | and then if something fails and we're rolling back, i'd have to create a new attachment and complete it for the source host (using the source host connector, which we don't stash away) | 19:46 |
| dansmith | which entity is going to give you the go/no-go on the new attachment? cinder? brick? libvirt? | 19:46 |
| mriedem | so not impossible, but kinda gross | 19:46 |
| mriedem | updating the attachment with the host connector is what creates the exports in the storage backend | 19:47 |
| mriedem | and gives us back the connection_info dict | 19:47 |
| dansmith | okay, so, cinder yeah? | 19:48 |
| *** BjoernT has quit IRC | 19:48 | |
| mriedem | i'm honestly not sure if that's enough or not, i.e. if you still need the low-level connection on the host for libvirt/brick | 19:48 |
| mriedem | we maybe don't need that - we don't try to plug vifs on the dest host during pre-validation | 19:48 |
| dansmith | cinder might tell you no, or it might not know and say "sure" but then the actual attach fails I guess | 19:48 |
| mriedem | yeah i'm not sure, that's why i was trying to do it all | 19:49 |
| mriedem | either way i'm not disconnecting the guest / volume from the source host until we've pre-validated the dest | 19:49 |
| mriedem | and start doing the power off / snapshot stuff | 19:50 |
| dansmith | hmm | 19:50 |
| dansmith | in what case is cinder going to tell you no to the attempted attachment change? | 19:50 |
| dansmith | I mean... why do you think you need to do this special for cross-cell? | 19:51 |
| mriedem | i was thinking in case we hit a scenario where the target cell is using a different storage backend from the source cell | 19:51 |
| mriedem | not sure how realistic that is though | 19:52 |
| dansmith | but I mean, | 19:52 |
| dansmith | how is that different from single-cell resize? | 19:52 |
| sean-k-mooney | mriedem: in an edge deployment its likely not that uncommon that they would have different backends | 19:52 |
| mriedem | it's not really, like i said before we could hit this same thing during normal resize and we really don't try to pre-validate that (in prep_resize) or rollback from that kind of failure | 19:52 |
| dansmith | yeah, I'm not sure what the backend difference is that you're talking about | 19:53 |
| dansmith | in this case, the volume is in cinder, on a backend, but migrating won't change what *cinder* backend it's on, regardless of where you move it | 19:53 |
| sean-k-mooney | dansmith: that is ture but that may mean the backen is not reachale from the new host. although if we are using sharing resouce providres to model this in placement it shoudl be reachable | 19:54 |
| sean-k-mooney | assuming you have set up the aggreate correctly | 19:55 |
| mriedem | we are not using sharing providers for any of this, or anything | 19:55 |
| dansmith | sean-k-mooney: right, but that's what I'm saying has nothing to do with cross-cell migration | 19:55 |
| sean-k-mooney | dansmith: sure | 19:55 |
| sean-k-mooney | its not a special case that only comes up with cross cell | 19:56 |
| mriedem | so if this is really not any different from normal resize then i'm probably bending over backwards for no good reason | 19:57 |
| mriedem | but yeah i was thinking kind of like what sean said, the target host can't connect to the storage for the volume | 19:57 |
| dansmith | mriedem: yep, but that's just a thing that can happen any time, | 19:58 |
| dansmith | so if we're going to do something different, implement this test for regular and cross-cell, and assume they're the same until then, IMHO | 19:58 |
| tssurya | efried: heh was just about to reply to that thread :) | 19:58 |
| mriedem | tssurya: since you're around, does cern use the same cinder for all of its cells? or most anyway? | 19:59 |
| efried | please do tssurya. I'm sure you can provide better insight. | 19:59 |
| mriedem | s/cinder/volume backend/ | 19:59 |
| dansmith | mriedem: do you mean the same cinder, or the same backend? | 19:59 |
| sean-k-mooney | dansmith: mriedem for normal resize do we pass a member of parmater to ensure we select a host that is attache to the same sharign resouce provider | 19:59 |
| dansmith | yeah :) | 19:59 |
| dansmith | the latter, I'm sure not, but that's what cross-az-attach is for | 19:59 |
| tssurya | mriedem: cinder for specific cells as far as I know | 19:59 |
| tssurya | but yes same cinder | 19:59 |
| mriedem | i only know of 2 users of cross_az_attach=False (NeCTAR and Target) | 20:00 |
| tssurya | efried: yea what they are saying is true though, just making resource_provider_association_refresh to large value doesn't still solve it for ironic | 20:00 |
| tssurya | we have been having the same problem and mostly might end up adding more computes | 20:01 |
| tssurya | the periodic task locks really long enough (sometimes ~20mins) and doesn't allow boot request to walk past it and we get stuff stuck in scheduling | 20:01 |
| dansmith | mriedem: you mean only two that speak up often or what? we definitely have users of it and are prescribing it for all edge deploys with cinder of course | 20:02 |
| tssurya | so its interesting to see if for them setting update_resources_interval stays fine or not (in terms of things going out of sync) | 20:02 |
| mriedem | right, i only saw target people mention it in a talk once | 20:03 |
| *** BjoernT has joined #openstack-nova | 20:03 | |
| mriedem | well i've commented out the trouble code for now and will have a gate run with a volume-backed cross-cell resize so i'll see if i run into any other bumps along the way; if the only issues with volume-backed cross-cell resize is this pre-validation thing, i'll probably just drop it. | 20:05 |
| *** mlavalle has quit IRC | 20:07 | |
| efried | tssurya: oh, okay, I thought I might be on the wrong track with refresh interval | 20:09 |
| efried | please do correct me on the thred. | 20:09 |
| efried | thread | 20:09 |
| tssurya | yep no problem | 20:10 |
| *** maciejjozefczyk has quit IRC | 20:14 | |
| *** panda has quit IRC | 20:19 | |
| *** mlavalle has joined #openstack-nova | 20:19 | |
| *** slaweq has quit IRC | 20:19 | |
| *** panda has joined #openstack-nova | 20:21 | |
| *** partlycloudy has quit IRC | 20:27 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.opendev.org/642557 | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.opendev.org/642558 | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.opendev.org/643894 | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.opendev.org/643895 | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.opendev.org/643896 | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793 | 20:27 |
| *** itlinux has quit IRC | 20:32 | |
| *** dpawlik has quit IRC | 20:35 | |
| *** tssurya has quit IRC | 20:38 | |
| *** pcaruana|afk| has quit IRC | 20:46 | |
| *** xek has quit IRC | 20:47 | |
| *** ttsiouts has joined #openstack-nova | 20:56 | |
| *** derekh has joined #openstack-nova | 20:59 | |
| *** artom has quit IRC | 21:07 | |
| sean-k-mooney | mriedem: so regarding https://review.opendev.org/#/c/653506/ https://review.opendev.org/#/c/653506/4/nova/network/neutronv2/api.py@3358 is really the only part i would proably change but i think the updated code is more or less correct. | 21:08 |
| *** BjoernT_ has joined #openstack-nova | 21:09 | |
| sean-k-mooney | the pci requst update code for the non migration flow i belive is correct i just got confused by the comment | 21:09 |
| *** openstackgerrit has quit IRC | 21:09 | |
| *** BjoernT has quit IRC | 21:10 | |
| *** slaweq has joined #openstack-nova | 21:11 | |
| mriedem | ganso: figured it out | 21:13 |
| *** dklyle has joined #openstack-nova | 21:13 | |
| ganso | yay \o/ mriedem: what was the problem? | 21:13 |
| mriedem | tight coupling in _delete_allocation_after_move which was dropped in stein, | 21:14 |
| mriedem | details are in https://review.opendev.org/#/c/658834/1/nova/tests/functional/test_servers.py | 21:14 |
| mriedem | i think i've got a fix | 21:15 |
| *** slaweq has quit IRC | 21:15 | |
| mriedem | your persistence has paid off | 21:15 |
| mriedem | ganso: so if you want, i can cleanup your rocky-only test with the proper context and such in the commit message, make the test assert the bug, and then stack the fix on top | 21:16 |
| mriedem | and also explain why it's not a problem in stein | 21:17 |
| *** ttsiouts has quit IRC | 21:18 | |
| ganso | mriedem: hmmm would the fix be a) or b) ? I am not sure I understand which case (a) does not cover | 21:18 |
| ganso | mriedem: as far as I understand, we would always have a migration-based allocation if confirm_migration ever fails | 21:20 |
| mriedem | the fix i'm going with is (b) | 21:22 |
| mriedem | which is safe for rocky and queens | 21:22 |
| mriedem | migration-based allocation during resize means that conductor moves the source node allocations to the migration record, which was new in queens and only happens iff the computes in the migration are new enough to handle that logic | 21:22 |
| mriedem | which might not be the case if you're doing a rolling upgrade in queens | 21:22 |
| mriedem | so (b) is safer i guess for backports | 21:23 |
| mriedem | it's also how that code is meant to work assuming you hit _delete_allocation_after_move without driver.confirm_migration failing | 21:23 |
| *** dklyle has quit IRC | 21:24 | |
| mriedem | so i guess we just need to figure out what to do about your recreate test | 21:25 |
| ganso | mriedem: hmm I understand now | 21:26 |
| mriedem | i think we could land your test in master, backport to stein, and backport to rocky but in rocky we lay the rocky-only fix on it (and then backport that to queens as well), or we change the test patch in rocky to assert it fails until we have a rocky-only fix on top | 21:27 |
| ganso | mriedem: so, about the test in master, I am not sure it is 100% the same. If it is the same, we would need to make a lot of changes to backport it to rocky | 21:27 |
| mriedem | you already made those changes right? and it's not the same as the point i pointed out | 21:28 |
| mriedem | it's close, but in the existing test in master the PUT /allocations call to placement is stubbed to fail with a 409 | 21:28 |
| mriedem | so not really what we'd want for asserting this fix in rocky/queens | 21:28 |
| mriedem | *not the same as the test i pointed out | 21:28 |
| ganso | mriedem: oh sorry, just saw your response! great we can merge it then =D | 21:28 |
| mriedem | yeah given https://review.opendev.org/#/c/652153/ hasn't merged in queens, we can hold that up until your recreate test is ready in queens | 21:30 |
| ganso | yes | 21:30 |
| ganso | mriedem: ok sounds like a good plan, I can improve the rocky patch once the stein backport lands, so it makes sense | 21:31 |
| mriedem | ack ok | 21:31 |
| mriedem | dansmith: can you hit this easy test-only patch? https://review.opendev.org/#/c/657870/ | 21:31 |
| mriedem | actually hold up | 21:32 |
| * dansmith holds | 21:32 | |
| mriedem | ganso: one thing in https://review.opendev.org/#/c/657870/ - you can remove that self.failed_host thing right? | 21:33 |
| mriedem | it's not used | 21:33 |
| mriedem | must have been copy/paste | 21:33 |
| ganso | mriedem: yea was copy paste | 21:33 |
| mriedem | ok remove that and i'm +2 | 21:33 |
| ganso | mriedem: will remove and push an update | 21:33 |
| ganso | mriedem: great =D | 21:33 |
| ganso | mriedem: doing that now | 21:33 |
| mriedem | sean-k-mooney: so on https://review.opendev.org/#/c/653506/4/nova/network/neutronv2/api.py@3358 - what do you want to do instead? just remove the try/except and let the PortBindingActivationFailed raise up? if so i'm cool with that. | 21:34 |
| sean-k-mooney | mriedem: i was just responding. either that or as i previous said in stead of just doing the update delete the inactive port bidning then leave it fall back to updating the souce binding | 21:35 |
| *** openstackgerrit has joined #openstack-nova | 21:36 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Add functional confirm_migration_error test https://review.opendev.org/657870 | 21:36 |
| *** bbowen has quit IRC | 21:36 | |
| mriedem | sean-k-mooney: just letting that raise up is easier | 21:36 |
| mriedem | this is all workaround for weird edge casing anyway | 21:36 |
| sean-k-mooney | ya that is ture. | 21:36 |
| mriedem | true even | 21:37 |
| sean-k-mooney | :) | 21:37 |
| mriedem | i'll just do that then | 21:37 |
| mriedem | dansmith: ok i'm +2 on https://review.opendev.org/#/c/657870/ | 21:37 |
| sean-k-mooney | cool in which case the last test can just be an assertRaises | 21:38 |
| mriedem | dansmith: tl;dr i had fixed an allocation leak in master and stein but ganso found it it didn't really fix the bug before stein b/c of some code refactor stuff that was missed in the backport | 21:38 |
| *** mchlumsky has quit IRC | 21:38 | |
| dansmith | okay | 21:38 |
| mriedem | the test is used to recreate the bug in rocky and queens https://review.opendev.org/#/q/I9d6478f492351b58aa87b8f56e907ee633d6d1c6 | 21:38 |
| *** ttsiouts has joined #openstack-nova | 21:38 | |
| *** whoami-rajat has quit IRC | 21:41 | |
| *** ttsiouts has quit IRC | 21:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle inactive port binding in _update_port_binding_for_instance https://review.opendev.org/653506 | 21:45 |
| *** zhongjun2_ has quit IRC | 21:45 | |
| *** slaweq has joined #openstack-nova | 21:46 | |
| *** slaweq has quit IRC | 21:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional confirm_migration_error test https://review.opendev.org/658929 | 21:52 |
| mriedem | ganso: there is the stein backport ^ | 21:53 |
| *** mriedem is now known as mriedem_afk | 21:53 | |
| ganso | mriedem_afk: cool, ok! I will improve the text message of the other ones | 21:54 |
| aspiers | is it just me or is https://etherpad.openstack.org/p/nova-ptg-train borked? is that why there was a https://etherpad.openstack.org/p/nova-ptg-train-2 ? but that seems borked too | 22:00 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/rocky: Add functional confirm_migration_error test https://review.opendev.org/658834 | 22:03 |
| *** bbowen has joined #openstack-nova | 22:03 | |
| sean-k-mooney | aspiers: -4 was working last week | 22:07 |
| sean-k-mooney | looks like that is broken too. efried has an offline copy. i have one on my personal laptop too | 22:09 |
| aspiers | sean-k-mooney: yikes, etherpad zombies everywhere | 22:09 |
| sean-k-mooney | we proably should jsut email it to the mailing list | 22:09 |
| aspiers | did it just get too big for etherpad to handle? | 22:09 |
| efried | I made -5 last week | 22:09 |
| aspiers | does the infra team know about this? | 22:09 |
| sean-k-mooney | efried: -5 is not loading either | 22:10 |
| efried | aspiers: I've seen way bigger etherpads that have survived, so I doubt it's the size. | 22:10 |
| aspiers | yeah, -5 not loading for me either | 22:10 |
| sean-k-mooney | there is proably some content in it that it does not like | 22:10 |
| efried | urm, looks like I might have killed my open window to -5 | 22:11 |
| aspiers | I've just notified infra | 22:11 |
| efried | was there anything in particular you needed from there? | 22:11 |
| sean-k-mooney | i have a copy i saved offline | 22:11 |
| sean-k-mooney | i can email it to the list | 22:11 |
| sean-k-mooney | if i was to guess at anything i woudl guess it was the non ascii chater that was added to the start of the etherpad | 22:12 |
| *** partlycloudy has joined #openstack-nova | 22:13 | |
| *** yonglihe has quit IRC | 22:14 | |
| *** BjoernT_ has quit IRC | 22:17 | |
| sean-k-mooney | aspiers: i sent a mail to the list with subject " [nova][ptg] main etherpad backup" | 22:23 |
| sean-k-mooney | which is apparently held for moderator apporval becasue apprently its over 40KB... | 22:24 |
| sean-k-mooney | this is 2019 right | 22:25 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: TC Vision Reflection https://review.opendev.org/658932 | 22:25 |
| sean-k-mooney | efried: am i missing somthing or is the reflect missing form ^ | 22:30 |
| efried | sean-k-mooney: You mean did I forget to git-add | 22:30 |
| efried | yes | 22:30 |
| efried | yes I did. | 22:30 |
| efried | thanks | 22:30 |
| sean-k-mooney | ah ok :) | 22:30 |
| efried | doesn't do me much good to "back up my work" and "save my place" if I don't upload the freakin document. | 22:30 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: TC Vision Reflection https://review.opendev.org/658932 | 22:31 |
| efried | sean-k-mooney: ^ | 22:31 |
| sean-k-mooney | did this come up in the ptg by the way. i was in the fourm session but i never got around to bringin this up in the ptg | 22:31 |
| efried | no, it's just something that's been on my to-do list for months and months | 22:31 |
| efried | okay, since March | 22:32 |
| sean-k-mooney | ah ok, we discussed this a bit in the fourm session but since bauzas and i were the only novaish people in the room we did not really have a reason other then no one has done it yet for why nova had not done one when asked | 22:33 |
| efried | yeah, I figured it was my responsibility, just hadn't gotten to it yet | 22:33 |
| efried | (dreading, dreading) | 22:33 |
| sean-k-mooney | out of interest is it still technically possible to deploy nova without keystone. | 22:36 |
| sean-k-mooney | i think our configs imply you coudl deploy the api with no auth but im pretty sure it totally would bork things if you tried | 22:37 |
| efried | no idea. I expect I will commit a number of inaccuracies in my writeup due to my relatively brief history on the project. I expect it to be vetted thoroughly by Nova veterans such as yourself before it is considered mergeable. | 22:37 |
| efried | gtg | 22:38 |
| sean-k-mooney | well you can still fall back to noauth2 but i dont know how functional the deployment would be https://github.com/openstack/nova/blob/master/nova/conf/api.py#L24-L36 | 22:38 |
| sean-k-mooney | o/ | 22:38 |
| *** tkajinam has joined #openstack-nova | 22:56 | |
| *** rcernin has joined #openstack-nova | 23:04 | |
| *** rcernin has quit IRC | 23:07 | |
| *** rcernin has joined #openstack-nova | 23:07 | |
| *** macza has quit IRC | 23:10 | |
| *** macza has joined #openstack-nova | 23:11 | |
| *** macza has quit IRC | 23:16 | |
| *** dklyle has joined #openstack-nova | 23:18 | |
| *** alex_xu has joined #openstack-nova | 23:20 | |
| *** artom has joined #openstack-nova | 23:22 | |
| mriedem_afk | dansmith: well with commenting out that volume attachment stuff i did get a clean run on a volume-backed cross-cell resize confirm tempest test http://logs.openstack.org/56/656656/10/check/nova-multi-cell/f1def72/testr_results.html.gz so i guess i'll just nix that code from the series | 23:30 |
| dansmith | sweet | 23:30 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180 | 23:30 |
| *** derekh has quit IRC | 23:30 | |
| *** mriedem_afk has quit IRC | 23:31 | |
| *** mlavalle has quit IRC | 23:57 | |
| *** hemna has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!