| *** dosaboy has quit IRC | 00:08 | |
| *** ganso has quit IRC | 00:08 | |
| *** ganso has joined #openstack-nova | 00:08 | |
| *** dosaboy has joined #openstack-nova | 00:09 | |
| *** mdbooth_ has joined #openstack-nova | 00:10 | |
| *** mdbooth has quit IRC | 00:13 | |
| *** jangutter has quit IRC | 00:22 | |
| *** nicolasbock has quit IRC | 00:27 | |
| *** jangutter has joined #openstack-nova | 00:30 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock spec https://review.opendev.org/650171 | 00:34 |
|---|---|---|
| openstackgerrit | melanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells" https://review.opendev.org/653894 | 00:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use futurist.GreenThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172 | 00:34 |
| *** jangutter has quit IRC | 00:40 | |
| *** jangutter has joined #openstack-nova | 00:46 | |
| *** slaweq has quit IRC | 00:58 | |
| *** takashin has joined #openstack-nova | 01:00 | |
| *** hoonetorg has quit IRC | 01:01 | |
| *** mriedem has quit IRC | 01:03 | |
| *** yedongcan has joined #openstack-nova | 01:11 | |
| *** markvoelker has joined #openstack-nova | 01:13 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278 | 01:14 |
| *** hoonetorg has joined #openstack-nova | 01:15 | |
| *** whoami-rajat has joined #openstack-nova | 01:16 | |
| *** mvkr has quit IRC | 01:32 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.utils. https://review.opendev.org/655281 | 01:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282 | 01:45 |
| *** gerrykopec has quit IRC | 01:49 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 02:01 |
| *** ricolin has joined #openstack-nova | 02:06 | |
| openstackgerrit | Merged openstack/nova master: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/654457 | 02:08 |
| *** gmann_afk is now known as gmann | 02:16 | |
| *** mvkr has joined #openstack-nova | 02:21 | |
| *** igordc has joined #openstack-nova | 02:43 | |
| *** ileixe has quit IRC | 02:50 | |
| *** dikonoor has joined #openstack-nova | 02:51 | |
| *** ileixe has joined #openstack-nova | 02:53 | |
| *** ileixe has quit IRC | 02:53 | |
| *** jdillaman has quit IRC | 02:54 | |
| *** psachin has joined #openstack-nova | 03:02 | |
| *** lbragstad has quit IRC | 03:08 | |
| *** ileixe has joined #openstack-nova | 03:22 | |
| *** whoami-rajat has quit IRC | 03:35 | |
| *** udesale has joined #openstack-nova | 03:58 | |
| openstackgerrit | Boxiang Zhu proposed openstack/python-novaclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/647671 | 04:02 |
| *** whoami-rajat has joined #openstack-nova | 04:06 | |
| *** arshad777 has quit IRC | 04:19 | |
| *** ivve has quit IRC | 04:25 | |
| *** ileixe has quit IRC | 04:28 | |
| *** ileixe has joined #openstack-nova | 04:31 | |
| openstackgerrit | Merged openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.opendev.org/641179 | 04:54 |
| openstackgerrit | Merged openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.opendev.org/639382 | 04:54 |
| *** ivve has joined #openstack-nova | 05:02 | |
| *** ileixe has quit IRC | 05:06 | |
| *** ileixe has joined #openstack-nova | 05:09 | |
| *** markvoelker has quit IRC | 05:10 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** yedongcan has quit IRC | 05:39 | |
| *** mvkr has quit IRC | 05:40 | |
| *** igordc has quit IRC | 05:49 | |
| *** Luzi has joined #openstack-nova | 05:50 | |
| *** yedongcan has joined #openstack-nova | 05:52 | |
| *** mvkr has joined #openstack-nova | 05:53 | |
| openstackgerrit | zhongshengping proposed openstack/nova master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/654398 | 06:00 |
| *** ileixe has quit IRC | 06:01 | |
| *** dakshina-ilangov has joined #openstack-nova | 06:10 | |
| *** ileixe has joined #openstack-nova | 06:12 | |
| *** sridharg has joined #openstack-nova | 06:12 | |
| *** boxiang has quit IRC | 06:21 | |
| *** boxiang has joined #openstack-nova | 06:21 | |
| *** d34dh0r53 has quit IRC | 06:22 | |
| *** pcaruana has joined #openstack-nova | 06:24 | |
| *** arshad777 has joined #openstack-nova | 06:44 | |
| arshad777 | Hi everyone, I am trying to create an instance on the controller node on a multinode setup but getting no valid host found in nova log. Please refer nova log http://paste.openstack.org/show/749631/ for more detail. Please let me know if some thing is wrong on my setup | 06:46 |
| *** yonglihe has joined #openstack-nova | 06:47 | |
| *** Luzi has quit IRC | 06:50 | |
| *** ralonsoh has joined #openstack-nova | 06:52 | |
| *** liuyulong_ has joined #openstack-nova | 06:55 | |
| *** rpittau|afk is now known as rpittau | 06:56 | |
| *** slaweq has joined #openstack-nova | 06:57 | |
| *** Luzi has joined #openstack-nova | 06:57 | |
| *** ileixe has quit IRC | 06:58 | |
| *** ileixe has joined #openstack-nova | 07:00 | |
| *** egonzalez has quit IRC | 07:03 | |
| *** egonzalez has joined #openstack-nova | 07:04 | |
| *** rcernin has quit IRC | 07:05 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: set device address tag only if setting disk unit https://review.opendev.org/653512 | 07:05 |
| *** markvoelker has joined #openstack-nova | 07:12 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332 | 07:19 |
| *** luksky has joined #openstack-nova | 07:26 | |
| *** tosky has joined #openstack-nova | 07:26 | |
| *** phasespace has joined #openstack-nova | 07:28 | |
| kashyap | aspiers: Thank you :-) Noticed it from an e-mail alert on the blueprint. /me opens the change | 07:30 |
| *** dtantsur|afk is now known as dtantsur | 07:40 | |
| *** luksky has quit IRC | 07:42 | |
| *** helenafm has joined #openstack-nova | 07:51 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database https://review.opendev.org/655278 | 07:56 |
| *** yan0s has joined #openstack-nova | 07:59 | |
| *** takashin has left #openstack-nova | 08:00 | |
| *** dikonoor has quit IRC | 08:01 | |
| kashyap | aspiers: When you're awake, something unrelated: any reason why you added 'SEV' trait to a separate file, os_traits/hw/cpu/amd.py, instead of appending it to existing os_traits/hw/cpu/x86.py? | 08:03 |
| aspiers | kashyap: based on feedback in the review | 08:03 |
| aspiers | I originally proposed the latter | 08:04 |
| kashyap | I see | 08:05 |
| kashyap | aspiers: So, I'm wondering if I should add the AMD CPU feature traits I added: https://review.opendev.org/#/c/655193/1/os_traits/hw/cpu/x86.py | 08:06 |
| kashyap | ... to also amd.py | 08:06 |
| aspiers | definitely | 08:06 |
| aspiers | I would have thought, anyway | 08:06 |
| kashyap | Then, I also have to do a "clean up" of moving the existing "SVM" from x86.py to amd.py, too. Will do that in a separate change. | 08:07 |
| *** tssurya has joined #openstack-nova | 08:12 | |
| *** ttsiouts has joined #openstack-nova | 08:12 | |
| *** derekh has joined #openstack-nova | 08:13 | |
| aspiers | kashyap: https://review.opendev.org/#/c/609779/12/specs/stein/approved/amd-sev-libvirt-support.rst@95 | 08:14 |
| *** luksky has joined #openstack-nova | 08:16 | |
| * kashyap clicks | 08:17 | |
| gibi | efried: I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with? | 08:18 |
| kashyap | aspiers: Hmm, one of the points was about whether it is an instruction set extension or not | 08:18 |
| aspiers | kashyap: yup | 08:18 |
| aspiers | s/definitely/I have no clue what I'm talking about/ | 08:18 |
| aspiers | but I can point to people who do ;-) | 08:18 |
| kashyap | :D | 08:18 |
| kashyap | I find that too granular. We should stick to one clear approach: if they're AMD-specific, then use amd.py (regardless of whether it an "instruction set extension' or whatever it is) | 08:19 |
| kashyap | Anyway, not too important. | 08:19 |
| aspiers | yeah, needs to be clearly documented, e.g. in the README | 08:19 |
| kashyap | Also, "x86" can mean both Intel and AMD. (Although, the original term derived from Intel's 8086.) | 08:21 |
| aspiers | right | 08:21 |
| kashyap | aspiers: So, 'sev' shows up under /proc/cpuinfo on an AMD box yeah? | 08:22 |
| aspiers | think so but checking | 08:22 |
| aspiers | yes | 08:22 |
| aspiers | in the flags | 08:23 |
| aspiers | as does svm | 08:23 |
| kashyap | Thanks | 08:24 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | 08:52 |
| aspiers | kashyap: ^^^ PEP8 TODO issue should be fixed | 08:52 |
| *** mgoddard has joined #openstack-nova | 08:53 | |
| kashyap | Ack. | 08:55 |
| aspiers | kashyap: any thoughts on whether the tests are sufficient as is? | 08:56 |
| aspiers | kashyap: they're a bit lame but https://review.opendev.org/#/c/633855/ is the immediate follow-up which makes them sensible again | 08:57 |
| kashyap | aspiers: Yeah, that is fine and more than acceptable. | 08:57 |
| aspiers | specifically testing that a feature can get added to the .features list | 08:57 |
| kashyap | The infra patch is ... just that ... the infra :-) | 08:57 |
| aspiers | right | 08:57 |
| kashyap | Any sensible reviewer would (and should) understand that. | 08:58 |
| aspiers | and it does have tests anyway, which do test some aspects of it, just not the <features> bit | 08:58 |
| aspiers | well even that gets basic testing I guess | 08:58 |
| kashyap | Right, it's perfectly fine. | 09:00 |
| *** tetsuro has joined #openstack-nova | 09:06 | |
| *** dtantsur is now known as dtantsur|brb | 09:19 | |
| *** tetsuro has quit IRC | 09:24 | |
| *** tetsuro has joined #openstack-nova | 09:31 | |
| *** tetsuro has quit IRC | 09:34 | |
| *** tetsuro has joined #openstack-nova | 09:41 | |
| *** d34dh0r53 has joined #openstack-nova | 09:45 | |
| *** tkajinam has quit IRC | 09:52 | |
| *** seyeongkim has quit IRC | 09:53 | |
| *** awestin1 has quit IRC | 09:54 | |
| *** awestin1_ has joined #openstack-nova | 09:54 | |
| *** pas-ha has quit IRC | 09:54 | |
| *** gmann has quit IRC | 09:54 | |
| *** pas-ha has joined #openstack-nova | 09:54 | |
| *** rpittau has quit IRC | 09:55 | |
| *** vdrok has quit IRC | 09:55 | |
| *** mrhillsman has quit IRC | 09:55 | |
| *** rm_work has quit IRC | 09:55 | |
| *** seyeongkim has joined #openstack-nova | 09:55 | |
| *** gmann has joined #openstack-nova | 09:56 | |
| *** tetsuro has quit IRC | 09:56 | |
| *** vdrok has joined #openstack-nova | 09:57 | |
| *** rpittau has joined #openstack-nova | 09:57 | |
| *** mrhillsman has joined #openstack-nova | 09:58 | |
| *** rm_work has joined #openstack-nova | 10:06 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 10:07 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.opendev.org/639396 | 10:07 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.opendev.org/644881 | 10:07 |
| *** liuyulong_ has quit IRC | 10:08 | |
| kashyap | jaypipes: When you're about -- hope that answers your question: https://review.opendev.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@19 | 10:12 |
| *** dakshina-ilangov has quit IRC | 10:12 | |
| *** shilpasd has quit IRC | 10:12 | |
| kashyap | artom: When you get time, can you confirm if I answered your questions on PS-11: https://review.opendev.org/#/c/506720/11/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst | 10:13 |
| kashyap | (On the review is fine.) | 10:13 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 10:18 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.opendev.org/639396 | 10:18 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.opendev.org/644881 | 10:18 |
| *** rtjure has joined #openstack-nova | 10:18 | |
| artom | kashyap, ya | 10:20 |
| artom | kashyap, yep, your answers make sense | 10:23 |
| artom | I'll leave it to your judgment on whether you want to include any of them in the spec proper :) | 10:23 |
| *** yedongcan has left #openstack-nova | 10:30 | |
| *** dtantsur|brb is now known as dtantsur | 10:35 | |
| *** nicolasbock has joined #openstack-nova | 10:36 | |
| *** gmann has quit IRC | 10:44 | |
| *** tbachman has quit IRC | 10:50 | |
| kashyap | artom: Some of them I will. Next iteration coming soon to a Firefox tab near you :D | 10:52 |
| * kashyap --> makes food | 10:52 | |
| *** wwriverrat has quit IRC | 10:52 | |
| *** belmoreira has joined #openstack-nova | 11:06 | |
| jaypipes | kashyap: hmm, didn't I +2 that yesterday? did you push new revs? | 11:09 |
| jaypipes | or am I confusing with the AMD SEV one... | 11:09 |
| *** belmoreira has quit IRC | 11:09 | |
| sean-k-mooney | jaypipes: you did | 11:09 |
| *** belmoreira has joined #openstack-nova | 11:09 | |
| sean-k-mooney | there was a few tiny nits that were fixed | 11:09 |
| NewBruce | sean-k-mooney that workaround patch is holding up splendidly; but man is the live migration process dicey - any failure can really leave you messed up at times…. | 11:10 |
| sean-k-mooney | oh sorry no i confused myself | 11:10 |
| sean-k-mooney | jaypipes: you +2'd the sev one not the secure boot one | 11:11 |
| NewBruce | but the workaround +1 so thanks for that | 11:11 |
| sean-k-mooney | jaypipes: ignore me | 11:11 |
| sean-k-mooney | NewBruce: way we know we can harden that code more, especially in the failure case | 11:12 |
| sean-k-mooney | NewBruce: ill try and make the code a bit more presentable (pass tests) after the ptg | 11:12 |
| NewBruce | aye, admittedly the cleanup is a complex beast and really depends on where the failure happens; but if the second ports are set up, you can be in for a bad time in some cases | 11:12 |
| NewBruce | sean-k-mooney no worries mate; if i get some more time, ill try and dig into that flow a bit more | 11:13 |
| *** udesale has quit IRC | 11:16 | |
| sean-k-mooney | jaypipes: fyi if you have time to look at the latest revision of the sev spec https://review.opendev.org/#/c/641994/12 we shoudl be able to remove it form the PTG agenda assumeing your good with it still. | 11:19 |
| jaypipes | sean-k-mooney: k, will try this afternoon. | 11:20 |
| jaypipes | (need to get car repair done now) | 11:20 |
| sean-k-mooney | car trouble is the worst, best of luck, hopfully its minor | 11:21 |
| *** rtjure has quit IRC | 11:28 | |
| jaypipes | efried, aspiers: AMD SEV re-proposal +W'd | 11:29 |
| jaypipes | sean-k-mooney: ^ | 11:29 |
| sean-k-mooney | :) | 11:29 |
| jaypipes | sean-k-mooney: and yeah, it's just a servicing. nothing major (I hope!) | 11:30 |
| *** ttsiouts has quit IRC | 11:31 | |
| *** ttsiouts has joined #openstack-nova | 11:32 | |
| *** ttsiouts has quit IRC | 11:34 | |
| *** ttsiouts has joined #openstack-nova | 11:34 | |
| jaypipes | efried: what are the numbers that start off each bullet point/topic in the nova ptg train etherpad? for example: | 11:36 |
| jaypipes | " 66 :30 Disabled compute service request filter (mriedem)" | 11:36 |
| jaypipes | what does '66' mean there? | 11:37 |
| sean-k-mooney | i had the same question | 11:37 |
| sean-k-mooney | but didnt ask | 11:37 |
| sean-k-mooney | how many bottels of beer we need? | 11:37 |
| jaypipes | heh | 11:39 |
| kashyap | jaypipes: Yeah, you're mixing up two different specs :-) | 11:40 |
| kashyap | jaypipes: Mine is the Secure Boot spec (https://review.opendev.org/#/c/506720/) | 11:40 |
| jaypipes | kashyap: ETOOMANYSPECS ;) | 11:40 |
| kashyap | :-) Understandable. | 11:41 |
| *** ccamacho has joined #openstack-nova | 11:44 | |
| openstackgerrit | Merged openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.opendev.org/641994 | 11:44 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/os-traits master: Add CPU traits for Meltdown/Spectre mitigation https://review.opendev.org/655193 | 11:44 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add HW_CPU_X86_* traits for Meltdown/Spectre mitigation https://review.opendev.org/655191 | 11:45 |
| *** helenafm has quit IRC | 11:45 | |
| *** belmoreira has quit IRC | 11:53 | |
| kashyap | mdbooth_: When you're get a minute, a blast from the past: wanted to triple-check if I need to raise at all in the 'else' condition: https://review.opendev.org/#/c/639091/4/nova/virt/libvirt/driver.py | 11:56 |
| kashyap | mdbooth_: (You have context for it; it is the "Make EBUSY handling suck less" thing) | 11:57 |
| *** belmoreira has joined #openstack-nova | 11:57 | |
| kashyap | s/you're get/you get/ | 11:57 |
| kashyap | (I think I should 'raise' _something_ there.../me refreshes context) | 11:59 |
| *** markvoelker has quit IRC | 12:08 | |
| *** tbachman has joined #openstack-nova | 12:19 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332 | 12:20 |
| *** udesale has joined #openstack-nova | 12:29 | |
| *** dikonoor has joined #openstack-nova | 12:37 | |
| *** lbragstad has joined #openstack-nova | 12:44 | |
| *** eharney has quit IRC | 12:50 | |
| *** jdillaman has joined #openstack-nova | 12:53 | |
| *** irclogbot_3 has quit IRC | 12:55 | |
| *** jistr is now known as jistr|afk | 12:56 | |
| *** irclogbot_3 has joined #openstack-nova | 12:56 | |
| hemna | hey guys, I have libvirt section in nova.conf setup to use rbd as the libvirt_images_type, to use ceph for all image storage, and yet the placement API says I don't have a provider with enough space to create an 80G vm (flavor m1.large) | 12:56 |
| *** francoisp has quit IRC | 12:56 | |
| *** altlogbot_1 has quit IRC | 12:57 | |
| *** altlogbot_0 has joined #openstack-nova | 12:58 | |
| *** helenafm has joined #openstack-nova | 13:02 | |
| * alex_xu hates google chrome+gerrit | 13:03 | |
| stephenfin | alex_xu: Firefox is really quite nice nowadays :) | 13:04 |
| stephenfin | I'd argue better than Chrome in many cases (certainly resource utilization) | 13:04 |
| lyarwood | hemna: https://review.opendev.org/#/c/650188/ is aiming to model that in Placement, I assume you don't have 80G of local disks? | 13:05 |
| hemna | yah I don't have 80G in local disk | 13:05 |
| hemna | hence the usage of ceph | 13:05 |
| alex_xu | ok, I can a try, I'm enough with the screen always scrolling automatically... | 13:05 |
| lyarwood | hemna: right, I was just trying to confirm that DISK_GB wouldn't be >= 80GB for the compute node | 13:07 |
| hemna | http://paste.openstack.org/show/749699/ | 13:07 |
| lyarwood | hemna: I guess that's a valid bug, you could use volumes to workaround it. | 13:08 |
| hemna | I have a single compute node (devstack) | 13:09 |
| lyarwood | so the pool doesn't even have 80GB in it? | 13:10 |
| *** ratailor has quit IRC | 13:10 | |
| hemna | 6.5Tib available | 13:12 |
| hemna | lyarwood: http://paste.openstack.org/show/749700/ | 13:15 |
| hemna | walt-cloud-vms is my pool for nova | 13:16 |
| hemna | nothing in it so far | 13:16 |
| efried | jaypipes, sean-k-mooney: Those are my personal scratch notes for priority (lower==earlier) and estimated time needed. | 13:18 |
| efried | alex_xu, stephenfin: What issues are you seeing with chrome+gerrit? I've been using that combo for years without heartache, but maybe I'm missing out on something amazing on Firefox | 13:18 |
| *** belmoreira has quit IRC | 13:19 | |
| hemna | hrmm | 13:19 |
| stephenfin | efried: Oh, no issues on that particular use case for me: I use Firefox for other reasons (it performs better, supports pretty much everything Chrome doesn't, and is worth supporting to avoid a browser monoculture) | 13:20 |
| alex_xu | efried: the screan always auto scrolling, and jump to another random place... | 13:20 |
| efried | alex_xu: Oh, screen flickers up and down when reviewing big files/deltas? You can fix that by toggling the gerrit option: <your name> => Settings => Diff Options => Render => Slow | 13:21 |
| alex_xu | s/screan/screen | 13:21 |
| alex_xu | yes | 13:21 |
| alex_xu | let me try | 13:21 |
| lyarwood | hemna: sorry on a call, reading over the update_provider_tree code for the libvirt driver this should actually be set to the overall rbd pool size | 13:22 |
| stephenfin | but the only time I've seen an autoscrolling issue in Gerrit is when I'm creating/editing a comment and I try to scroll down. It jumps me back up | 13:22 |
| efried | It still jumps a little for me, but only occasionally, and it never does the thrashing thing it used to do. | 13:22 |
| hemna | it's ok. I'm looking further | 13:22 |
| lyarwood | hemna: can you confirm what placement actually has as DISK_GB for the compute node | 13:22 |
| *** belmoreira has joined #openstack-nova | 13:22 | |
| hemna | I just bounced n-cpu and none of the settings in the [libvirt] section of nova.conf are being used. | 13:22 |
| alex_xu | efried: oh yeah, looks better, thanks | 13:22 |
| efried | cool | 13:23 |
| hemna | lyarwood: http://paste.openstack.org/show/749701/ | 13:23 |
| alex_xu | yea, i saw a little jump, but far better than previous | 13:23 |
| lyarwood | hemna: ah, so the images_type isn't rbd for some reason | 13:24 |
| hemna | yah, it's all the defaults | 13:24 |
| hemna | instead of what I have in nova.conf [libvirt] | 13:24 |
| lyarwood | hemna: it's images_type | 13:24 |
| lyarwood | hemna: not libvirt_images_type | 13:24 |
| lyarwood | hemna: you've prefixed everything with libvirt_* in there it seems | 13:24 |
| hemna | guess it was renamed ? | 13:24 |
| hemna | bah ok | 13:25 |
| hemna | I'll update that and retry | 13:25 |
| hemna | not sure how/why I did that | 13:25 |
| lyarwood | hemna: it has always been images_type, libvirt is just the config section. | 13:25 |
| hemna | must have been a copy/paste from somewhere | 13:26 |
| *** francoisp has joined #openstack-nova | 13:28 | |
| efried | alex_xu: Would you be willing to be the first contact liaison for your time zone, per http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005555.html ? | 13:28 |
| hemna | hrmm that didn't do it | 13:29 |
| hemna | looks like the conf is read from nova-cpu.conf not nova.conf ? | 13:29 |
| lyarwood | yeah with devstack it is | 13:29 |
| hemna | yup that's what it was | 13:31 |
| hemna | phew | 13:31 |
| hemna | lets see if I can create a vm now. thanks for the help | 13:31 |
| openstackgerrit | Eric Fried proposed openstack/nova stable/stein: Fix {min|max}_version in ironic Adapter setup https://review.opendev.org/655429 | 13:31 |
| lyarwood | hemna: np, sorry for the earlier confusion :) | 13:31 |
| hemna | local_gb is now 6705 | 13:32 |
| hemna | a bit better | 13:32 |
| lyarwood | slightly | 13:32 |
| *** sapd1_x has joined #openstack-nova | 13:34 | |
| *** seba has joined #openstack-nova | 13:38 | |
| alex_xu | efried: I can be that, at least i'm the only nova core in my time zone | 13:40 |
| efried | alex_xu: Thanks :) | 13:41 |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Do not perform port update in case of baremetal instance. https://review.opendev.org/649345 | 13:41 |
| efried | alex_xu: What is your time zone? UTC+8? | 13:41 |
| alex_xu | efried: np | 13:41 |
| alex_xu | yes | 13:41 |
| *** helenafm has quit IRC | 13:46 | |
| *** eharney has joined #openstack-nova | 13:48 | |
| kashyap | efried: alex_xu: Heya, does this look any beter: https://review.opendev.org/641994 https://review.opendev.org/655191 | 13:49 |
| efried | kashyap: Being merged, that first one looks great! | 13:49 |
| kashyap | efried: Hehe, one more thing: because we're consolidating all the AMD stuff in amd.py, I am going to move 'SVM' trit from x86.py to amd.py (in a separate change). | 13:50 |
| kashyap | (Didn't wanted to sneak it in part of this.) | 13:50 |
| *** gmann has joined #openstack-nova | 13:51 | |
| kashyap | alex_xu: efried: Also, a trait-per-CPU-feature is _correct_, isn't it? | 13:52 |
| *** mriedem has joined #openstack-nova | 13:53 | |
| efried | kashyap: Yes, one trait per feature is correct. | 13:53 |
| efried | Re: moving traits... I'm not sure what harm that could do, if any. You may need to provide a shim. edleafe jaypipes? | 13:53 |
| efried | kashyap: tbc, you're not changing what the string would end up being; just the module path we take to get there, right? | 13:54 |
| kashyap | efried: Yes, exactly. Just moving the 'SVM' as-is from one file to another | 13:54 |
| kashyap | Not modifying the string itself | 13:54 |
| efried | kashyap: I mean the string as it comes out the other end. Like if it's currently HW_CPU_FOO_SVM and you made it HW_CPU_FOO_AMD_SVM, that's bad. | 13:55 |
| efried | i.e. that's a *new* trait (and you can't remove the old one, and it's now confusing which one consumers should use) | 13:55 |
| kashyap | efried: Ah-ha...Hmm. | 13:55 |
| efried | But if it's currently in hw/cpu/foo.py and called AMD_SVM, so it actually winds up being HW_CPU_FOO_AMD_SVM, and you move it to hw/cpu/foo/amd.py and name it SVM, the string itself wouldn't change. And that's the thing that *might* be okay. | 13:56 |
| kashyap | I'll post the quick change, and would prefer to be educated there | 13:56 |
| kashyap | efried: Ah-ha, I think you're right there | 13:57 |
| kashyap | So, I see it being os_traits.HW_CPU_X86_SVM | 13:57 |
| efried | kashyap: Sounds like you ought to propose it in its own patch :) | 13:57 |
| kashyap | If I move SVM to amd.py, it can end up being: HW_CPU_AMD_SVM | 13:57 |
| efried | kashyap: Okay, so by project charter, we can't make os_traits.HW_CPU_X86_SVM go away, ever. | 13:57 |
| efried | HW_CPU_AMD_SVM will be a new trait. | 13:58 |
| efried | If there's no such thing as SVM on X86, that's just too bad. | 13:58 |
| efried | you can leave a comment on it that it's bogus | 13:58 |
| efried | but you can't remove it. | 13:58 |
| kashyap | efried: Yeah, indeed. SVM is AMD's equivalent of Intel's VMX (Virtual Machine Extensions) | 13:59 |
| efried | Okay. So if you're just adding AMD_SVM, you can do it as part of your change if that's appropriate. Is it? Sounds like it might be unrelated. | 13:59 |
| kashyap | efried: Okay, that makes sense -- add a comment that it's bogus; and add a new trait for SVM in amd.py | 13:59 |
| efried | ++ | 14:00 |
| kashyap | efried: It's slightly unrelated: but frankly, all these traits_ you are using hardware-based virt (Intel VMX; or AMD SVM) | 14:00 |
| kashyap | Separate change coming soon | 14:00 |
| efried | If your patch is called "add CPU traits related to spectre/meltdown" and it's not, then separate | 14:01 |
| efried | If your patch is called "add a bunch of CPU traits that are missing" you'll have to justify why we need each one anyway. If it's a bunch of different reasons, all in one patch could be fine. But if it's 1) spectre/meltdown and 2) this other random thing that I saw while I was here -- separate patches :) | 14:02 |
| kashyap | Yeah, noted. :-) | 14:02 |
| *** helenafm has joined #openstack-nova | 14:04 | |
| edleafe | efried: (reading back) It's the full name of the trait that can't change. How it is constructed in the file structure of os-traits is irrelevant | 14:06 |
| efried | edleafe: cool, gtk | 14:06 |
| *** udesale has quit IRC | 14:06 | |
| *** udesale has joined #openstack-nova | 14:07 | |
| *** udesale has quit IRC | 14:08 | |
| *** udesale has joined #openstack-nova | 14:08 | |
| mriedem | efried: want to hit the easy gerrit cherry pick button to put this in stable/stein? https://review.opendev.org/#/c/654457/ | 14:13 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332 | 14:13 |
| efried | mriedem: I'm 42 minutes ahead of you. | 14:13 |
| mriedem | ah didn't notice b/c the tb changed | 14:13 |
| efried | tb? | 14:13 |
| mriedem | topic branch | 14:14 |
| mriedem | the gerrit ui appends an annoying branch specifier in the backports | 14:14 |
| efried | oh. That's weird | 14:14 |
| efried | I'll pay attention to that from now on and fix it. | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.opendev.org/650370 | 14:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix mock specs set to strings https://review.opendev.org/655455 | 14:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954 | 14:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955 | 14:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: pull out functions from _heal_allocations_for_instance https://review.opendev.org/655457 | 14:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: reorder conditions in _heal_allocations_for_instance https://review.opendev.org/655458 | 14:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: pull out put_allocation call from _heal_* https://review.opendev.org/655459 | 14:24 |
| efried | melwitt: FYI since we talked about this a couple weeks ago: I fixed the Mock(spec='string') things ---^ and put the patch for the hacking rule on top of it | 14:24 |
| *** phasespace has quit IRC | 14:26 | |
| efried | kashyap: You have a lot of support for https://review.opendev.org/#/c/645814/ -- if you add some words about when/how you're going to use the information (which I still don't know from outside conversations - fail spawn? fail to start n-cpu?) I'll fast approve if that's okay with sean-k-mooney | 14:30 |
| efried | aspiers: I'm removing SEV from the PTG agenda, since it's approved \o/ | 14:31 |
| sean-k-mooney | ya im fine with that. | 14:31 |
| efried | thx | 14:31 |
| kashyap | efried: Yeah, it's the top-2 item on my TODO, will add it by tomm, that okay? | 14:31 |
| kashyap | If not for this traits yak, I would have done it today | 14:31 |
| efried | kashyap: wfm | 14:31 |
| efried | kashyap: IMO more important than traits yak | 14:32 |
| efried | but of course I would say that because it eases my PTG schedule pain :P | 14:32 |
| sean-k-mooney | ideally it would be nice to log the cpu basleing that was calulated + the flags form the cpu model and config and indicate what flag was incompatable. then kill the agent but we can discus that in the implementation | 14:32 |
| kashyap | efried: Yesterday, I was about to add a quick note that: "Ack, will address this once I finish addressing the Secure Boot comments" | 14:32 |
| kashyap | (The SB spec took a lot more time, too) | 14:32 |
| sean-k-mooney | effectivly if nova can detect via libvirt that its incomatible we shoudl also tell the operator why so that they dont need to figure it out themselves | 14:33 |
| kashyap | sean-k-mooney: Yeah. Let's hash it out when I actually get to implement it | 14:33 |
| jaypipes | efried: ack, got it. thx! | 14:33 |
| efried | jaypipes: Since parlayed into a draft agenda, see ML. | 14:33 |
| efried | (which may be where you were coming from in the first place) | 14:34 |
| *** KH-Jared has joined #openstack-nova | 14:34 | |
| *** itlinux has quit IRC | 14:35 | |
| kashyap | efried: On your question on that spec about 'where to fail' -- I'm thinking currently 'spawn'. Will add words to the spec | 14:37 |
| efried | kashyap: Perfect, thanks. | 14:37 |
| efried | I don't actually have a stake in what the answer is - I just want to see one :) | 14:37 |
| efried | So it be like, "Before this wonderful feature, the instance might fail to come alive, but nova wouldn't know anything was wrong. Now we can fail the spawn operation, putting the instance in ERROR state, with a helpful log message indicating which bits are a problem." | 14:39 |
| *** igordc has joined #openstack-nova | 14:42 | |
| *** amodi has joined #openstack-nova | 14:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.opendev.org/555081 | 14:44 |
| *** mlavalle has joined #openstack-nova | 14:45 | |
| kashyap | efried: Hehe, noted | 14:46 |
| *** yan0s has quit IRC | 14:46 | |
| * kashyap is a bit unwell today; so a tad slow with things. Just one more meeting to go, which is the final straw to exhaust all the neurons for the day :D | 14:47 | |
| *** luksky has quit IRC | 14:49 | |
| *** Luzi has quit IRC | 14:50 | |
| *** ratailor has joined #openstack-nova | 14:57 | |
| *** tbachman has quit IRC | 14:59 | |
| *** tbachman has joined #openstack-nova | 14:59 | |
| *** dave-mccowan has joined #openstack-nova | 15:01 | |
| melwitt | efried: ack | 15:04 |
| *** pcaruana has quit IRC | 15:06 | |
| *** dave-mccowan has quit IRC | 15:07 | |
| *** amotoki_ is now known as amotoki | 15:08 | |
| *** ccamacho has quit IRC | 15:15 | |
| *** ricolin has quit IRC | 15:17 | |
| *** tbachman has quit IRC | 15:19 | |
| mriedem | lyarwood: re getting the ceph job voting, we might consider disabling the ssh validation (which is on by default in tempest) to avoid spurious failures http://logs.openstack.org/06/641806/12/check/devstack-plugin-ceph-tempest/7fc39ec/testr_results.html.gz - ssh failing is something with networking breaking down, not really anything that should be a result of a ceph backend for storage | 15:24 |
| mriedem | it'd also make the job fast | 15:24 |
| mriedem | *faster | 15:24 |
| mriedem | lyarwood: i also posted https://review.opendev.org/#/c/655452/ earlier today | 15:25 |
| *** ricolin has joined #openstack-nova | 15:28 | |
| *** itlinux has joined #openstack-nova | 15:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.opendev.org/555081 | 15:30 |
| lyarwood | mriedem: ack sounds and looks good, where's the best place to track devstack-plugin-ceph-tempest result trends btw? | 15:31 |
| mriedem | here is a patch to disable the ssh validation https://review.opendev.org/655472 | 15:31 |
| mriedem | there is a graph that is out of date, sec | 15:32 |
| mriedem | http://grafana.openstack.org/d/-iKINcImz/ceph-failure-rate?orgId=1 | 15:32 |
| mriedem | https://opendev.org/openstack/project-config/src/branch/master/grafana/ceph.yaml needs fixing to fix that graph | 15:32 |
| mriedem | otherwise i think melwitt might be tracking ceph job failure rates somewhere | 15:32 |
| lyarwood | kk, I can take a look at fixing the graph if there's not another way | 15:33 |
| melwitt | I've been tracking via eyeball because I keep forgetting how to get the graph that shows the comparison with the tempest-full job | 15:34 |
| mriedem | that's what that graph above is for, but it's broken | 15:34 |
| * lyarwood opens the file and immediately regrets offering to help | 15:34 | |
| melwitt | haha. I can also try to fix it | 15:35 |
| mriedem | first it was broken by the ceph job renames, but now i think it's broken b/c of some zuulv3 thing, i had talked with corvus about it before but don't remember what needs fixing now | 15:35 |
| *** ivve has quit IRC | 15:35 | |
| mriedem | looking for one more core for this functional recreate test patch https://review.opendev.org/#/c/641521/ | 15:36 |
| mriedem | then i can claim victory on merging 4/47 patches of my cross-cell series while it was in runways for 2 weeks | 15:37 |
| *** itlinux has quit IRC | 15:41 | |
| stephenfin | mriedem: I thought my cells-v1 series was big... I won't get to it tonight but I can look at that tomorrow morning | 15:42 |
| stephenfin | (assuming no one gets to it before me) | 15:43 |
| mriedem | thanks | 15:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.opendev.org/640207 | 15:44 |
| efried | kashyap: I just did a thorough look at https://review.opendev.org/#/c/655193/ | 15:44 |
| efried | I would like to get some os-traits-y people (edleafe jaypipes) to scrutinize, esp. to make a ruling on whether/how we should do the split I suggested. | 15:44 |
| edleafe | efried: buried in meetings etc until the afternoon | 15:44 |
| kashyap | efried: /me looks; (while adding words to the other spec, so as to reduce your PTG scheduling workload :-)) | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.opendev.org/640207 | 15:45 |
| kashyap | efried: Eagle eyes there! On "stibp" | 15:45 |
| efried | kashyap: No hurry on my end | 15:46 |
| kashyap | I missed to add it, due to all these subtle acronyms | 15:46 |
| *** pcaruana has joined #openstack-nova | 15:46 | |
| efried | kashyap: If it helps, I distilled that web page | 15:47 |
| efried | 136 @node important_cpu_features_intel_x86 | 15:47 |
| efried | 148 @item @code{pcid} | 15:47 |
| efried | 159 @item @code{spec-ctrl} | 15:47 |
| efried | 171 @item @code{stibp} | 15:47 |
| efried | 182 @item @code{ssbd} | 15:47 |
| efried | 194 @item @code{pdpe1gb} | 15:47 |
| efried | 248 @node important_cpu_features_amd_x86 | 15:47 |
| efried | 260 @item @code{ibpb} | 15:47 |
| efried | 272 @item @code{stibp} | 15:47 |
| efried | 283 @item @code{virt-ssbd} | 15:47 |
| efried | 299 @item @code{amd-ssbd} | 15:47 |
| efried | 313 @item @code{amd-no-ssb} | 15:47 |
| efried | 325 @item @code{pdpe1gb} | 15:47 |
| kashyap | efried: You actually read the source I lnked. It makes me happy that someone actually read it :D | 15:47 |
| kashyap | Thanks for the handy posting here. | 15:48 |
| mgoddard | mriedem: did you see my response re placement? | 15:49 |
| kashyap | efried: Ah-ha, I missed 'stibp' because it was very recently added (21 March), and it isn't present in the HTML rendering | 15:50 |
| efried | oh, interesting | 15:50 |
| kashyap | [https://qemu.weilnetz.de/doc/qemu-doc.html#important_005fcpu_005ffeatures_005famd_005fx86] | 15:50 |
| jaypipes | efried: what does "AMD x86 hosts" mean w.r.t. Spectre/Meltdown? I thought it was an Intel-only architectural problem that was being exploited? | 15:50 |
| mriedem | mgoddard: i did now, thanks | 15:50 |
| efried | jaypipes: I haven't a clue. kashyap --^ | 15:50 |
| mgoddard | mriedem: np | 15:50 |
| kashyap | jaypipes: Not really; you fell for AMD's marketing :D | 15:50 |
| kashyap | jaypipes: Meltdown is an Intel-only thing | 15:51 |
| kashyap | jaypipes: Spectre affects both AMD _and_ Intel. | 15:51 |
| *** belmoreira has quit IRC | 15:52 | |
| jaypipes | kashyap: I didn't fall for anything... I was just asking a question :) | 15:52 |
| kashyap | jaypipes: Yeah, sorry for the flippant answer. Hope I answered. But look at the qemu.weilnetz.de link I posted. | 15:53 |
| kashyap | It shows all the CVEs that affect AMD hosts, too | 15:53 |
| jaypipes | kashyap: so AMD's CPUs use the same speculative execution "algorithms"? | 15:53 |
| jaypipes | ack, I'll read the paper. | 15:53 |
| jaypipes | if I can get through it :) | 15:53 |
| kashyap | jaypipes: Some yes, some not: https://www.amd.com/en/corporate/security-updates | 15:54 |
| melwitt | jaypipes: sorry to interrupt... mnaser and I have a change to create request spec, build request, and instance mapping in a single database transaction https://review.opendev.org/586742 and could use your review eyeballs | 15:54 |
| jaypipes | melwitt: pas de probleme. have a meeting for next 30 mins, will review after that | 15:56 |
| *** itlinux has joined #openstack-nova | 15:56 | |
| jaypipes | melwitt: and no need to apologize! :) | 15:56 |
| melwitt | merci beaucoup :) | 15:57 |
| jaypipes | de rien | 15:58 |
| *** tosky has quit IRC | 16:00 | |
| *** helenafm has quit IRC | 16:00 | |
| *** ratailor has quit IRC | 16:02 | |
| *** rpittau is now known as rpittau|afk | 16:03 | |
| *** _erlon_ has joined #openstack-nova | 16:03 | |
| *** efried is now known as efried_rollin | 16:04 | |
| *** wwriverrat has joined #openstack-nova | 16:06 | |
| *** tbachman has joined #openstack-nova | 16:07 | |
| *** altlogbot_0 has quit IRC | 16:09 | |
| mnaser | look at all this french | 16:09 |
| mnaser | D: | 16:09 |
| mnaser | (the nice type of French :p) | 16:10 |
| sean-k-mooney | stephenfin: ill try to review the latest versoin of the cpu spec again | 16:11 |
| sean-k-mooney | do you have any pending changes or is it fine teo start on v26 | 16:11 |
| *** altlogbot_2 has joined #openstack-nova | 16:12 | |
| gibi | efried: This morning I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with? | 16:15 |
| *** ivve has joined #openstack-nova | 16:16 | |
| *** ricolin has quit IRC | 16:20 | |
| *** ttsiouts has quit IRC | 16:21 | |
| *** ttsiouts has joined #openstack-nova | 16:21 | |
| *** ccamacho has joined #openstack-nova | 16:25 | |
| *** ttsiouts has quit IRC | 16:26 | |
| *** dtantsur is now known as dtantsur|afk | 16:29 | |
| *** itlinux has quit IRC | 16:33 | |
| *** derekh has quit IRC | 16:35 | |
| *** itlinux has joined #openstack-nova | 16:37 | |
| *** ccamacho has quit IRC | 16:38 | |
| *** altlogbot_2 has quit IRC | 16:43 | |
| *** manjeets_ is now known as manjeets | 16:43 | |
| *** sapd1_x has quit IRC | 16:43 | |
| *** mdbooth_ has quit IRC | 16:44 | |
| *** gyee has joined #openstack-nova | 16:44 | |
| *** itlinux has quit IRC | 16:44 | |
| *** altlogbot_0 has joined #openstack-nova | 16:44 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: set device address tag only if setting disk unit https://review.opendev.org/653514 | 16:45 |
| *** igordc has quit IRC | 16:45 | |
| *** itlinux has joined #openstack-nova | 16:50 | |
| mnaser | reading scroll back, while it's nice to figure out those flags, I've noticed that different distros will tack in their own cpu flags. | 16:52 |
| mnaser | which absolutely drives me f'n insane because it breaks live migration across qemus/operating systems. | 16:53 |
| *** altlogbot_0 has quit IRC | 16:53 | |
| *** psachin has quit IRC | 16:53 | |
| *** dikonoor has quit IRC | 16:54 | |
| *** altlogbot_1 has joined #openstack-nova | 16:54 | |
| *** itlinux has quit IRC | 16:56 | |
| *** luksky has joined #openstack-nova | 16:59 | |
| aspiers | efried_rollin: can your procedural -2 be removed from https://review.opendev.org/#/c/633855/ now that the spec is approved? | 16:59 |
| artom | Who's good with Zuul? sean-k-mooney? | 17:07 |
| *** KH-Jared has quit IRC | 17:07 | |
| artom | I'm trying to figure out why my "new" job (actually just nova-live-migration renamed) has apparently not run at all: https://review.opendev.org/#/c/653498/ | 17:08 |
| artom | There aren't even logs that I can look at :( | 17:08 |
| sean-k-mooney | ill take a look | 17:10 |
| *** itlinux has joined #openstack-nova | 17:10 | |
| artom | Appreciated :) | 17:10 |
| sean-k-mooney | ah because you renamed it but did not add it to the check/gate queue | 17:10 |
| artom | *facepalm* | 17:11 |
| artom | Thank you! | 17:11 |
| sean-k-mooney | comments in https://review.opendev.org/#/c/653498/4/.zuul.yaml | 17:11 |
| artom | Yep, found those with a grep nova-live-migration :P | 17:12 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 17:13 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.opendev.org/639396 | 17:13 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.opendev.org/644881 | 17:13 |
| artom | And now to pick up car from garage (and maybe lunch) | 17:13 |
| *** KH-Jared has joined #openstack-nova | 17:13 | |
| *** igordc has joined #openstack-nova | 17:16 | |
| sean-k-mooney | efried_rollin: regarding https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models it was marked as accpeted for train in last weeks meeting but the definiotn was not set to approved | 17:21 |
| sean-k-mooney | efried_rollin: should it be updated or left at new? i was going to att the patch to the runway list so just checking before i do | 17:22 |
| *** markvoelker has joined #openstack-nova | 17:22 | |
| *** markvoelker has quit IRC | 17:26 | |
| *** phasespace has joined #openstack-nova | 17:31 | |
| *** hongbin has joined #openstack-nova | 17:31 | |
| *** markvoelker has joined #openstack-nova | 17:37 | |
| *** eharney_ has joined #openstack-nova | 17:42 | |
| *** eharney has quit IRC | 17:44 | |
| *** eharney_ is now known as eharney | 17:45 | |
| mriedem | https://review.opendev.org/#/c/649345/ should be good to go and fixes a stein regression | 17:49 |
| *** udesale has quit IRC | 17:49 | |
| mriedem | sean-k-mooney: done | 17:50 |
| sean-k-mooney | thanks :) | 17:50 |
| mriedem | oh http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-04-18-14.00.log.html#l-197 | 17:50 |
| mriedem | 14:41:14 <efried> If nobody has objections, I'll catch up with kashyap later and approve the bp if he's on board, cool? | 17:51 |
| mriedem | i don't know if that happened | 17:51 |
| sean-k-mooney | ah he had not syncted with kashap maybe | 17:51 |
| sean-k-mooney | well there is no rush really | 17:51 |
| sean-k-mooney | by the way for https://review.opendev.org/#/c/649345/ | 17:52 |
| sean-k-mooney | i was going to point out that manages_network_binding_host_id might be a littel confuing in some cases | 17:53 |
| sean-k-mooney | altully maybe not i was in the middel of finding out where we do the prot binding on swan for the livrt dirver | 17:54 |
| sean-k-mooney | if we do it from the compute manager then thats all good | 17:55 |
| *** ralonsoh has quit IRC | 18:00 | |
| *** sridharg has quit IRC | 18:09 | |
| jaypipes | melwitt, mnaser: still looking into that WSREP not prepared node thing... | 18:11 |
| sean-k-mooney | WSREP is a galera thing right | 18:18 |
| jaypipes | sean-k-mooney: yeah. though the actual error in this case is a red herring. any old internal error from any old RDBMS could cause this issue. | 18:24 |
| *** tbachman has quit IRC | 18:24 | |
| melwitt | np :) | 18:25 |
| sean-k-mooney | the only time i had had to deal with WSREP errors was when i ran out of diskspeack on one of my contolers | 18:25 |
| sean-k-mooney | that was... fun to fix | 18:25 |
| jaypipes | melwitt, mnaser: "The api_context_manager.writer decorators are not nestable." <-- I am almost positive that statement is incorrect. AFAIK, any methods that are decorated by transaction context manager will *enlist* the decorated function's DB calls into an existing transaction (and if there is no existing transaction, one will automatically be created the first time a SQL statement is called (via ORM or core expression API in sqlalchemy) | 18:26 |
| * jaypipes goes to find the code that show the above... | 18:26 | |
| melwitt | jaypipes: I thought the same thing so I tried that approach first, and in my func test I found that if the 2nd create() failed, the 1st create() remained in the sqlite database anyway | 18:27 |
| jaypipes | melwitt: are they using the same RequestContext? | 18:28 |
| melwitt | so I changed to the approach that's currently in the patch now | 18:28 |
| melwitt | yes | 18:28 |
| jaypipes | hmmm. | 18:28 |
| jaypipes | melwitt: and both in the same thread of execution, yeah? | 18:29 |
| jaypipes | melwitt: both create() calls, that is... | 18:29 |
| melwitt | it's possible I did something wrong but I'm not sure how. I had originally decorated a function in compute/api with a writer decorator and just put all 3 create() calls in it | 18:29 |
| melwitt | yeah | 18:29 |
| jaypipes | melwitt: interesting. | 18:30 |
| melwitt | the create() methods themselves are not decorated but they call decorated methods inside them. I dunno if that might be why | 18:30 |
| jaypipes | melwitt: ftr, engineface's transaction context manager *should* only enlist into a single transaction (here is the relevant code, FWIW: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L1050-L1052) | 18:30 |
| jaypipes | melwitt: ok, lemme look further into this and see what might be causing this issue. | 18:30 |
| jaypipes | melwitt: just wanted to make sure that all the calls were actually expected to be in the same RequestContext | 18:31 |
| jaypipes | s/to be in the/using the/ | 18:31 |
| melwitt | jaypipes: ok, thanks. I don't want to take up too much of your time on this | 18:32 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662 | 18:32 |
| jaypipes | melwitt: not a worry, Melanie :) | 18:32 |
| melwitt | jaypipes: it's a little complex in that the create() methods will use the object's internal self._context but all the objects self._context are set to the same RequestContext | 18:33 |
| melwitt | but maybe that aspect can cause a break in the decorator nesting-ness? I'm not sure | 18:33 |
| jaypipes | yeah, not entirely sure either :) will dig further. | 18:34 |
| *** mdbooth has joined #openstack-nova | 18:41 | |
| *** itlinux has quit IRC | 18:50 | |
| *** itlinux has joined #openstack-nova | 18:52 | |
| *** itlinux has quit IRC | 18:54 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/648662 | 18:56 |
| *** openstackgerrit has quit IRC | 18:57 | |
| *** itlinux has joined #openstack-nova | 18:58 | |
| melwitt | jaypipes: based on the code you linked, it really should work to nest it so I went back and tried it all again and it looks like it does indeed work properly. I must have messed something up last time, sorry for that :( being able to nest makes the code 1000x better so thank you for pointing it out. I'm going to respin | 19:07 |
| *** itlinux has quit IRC | 19:11 | |
| melwitt | jaypipes++ | 19:12 |
| tssurya | mriedem: following up on our discussion yesterday regarding filters/sorting I have a doubt here: https://review.opendev.org/#/c/648662/6/nova/api/openstack/compute/schemas/servers.py@544 could you leave a comment when you get time ? | 19:12 |
| dansmith | tssurya: see if I answered your question | 19:21 |
| melwitt | turns out what I did wrong was not pass the RequestContext to the decorated outer method. it needs to be passed in for the decorator to start the transaction and then that will get used by the subsequent create() methods | 19:21 |
| tssurya | dansmith: thanks looking | 19:22 |
| tssurya | dansmith: ah you mean do something like 'sort_key': multi_params(VALID_SORT_KEYS_V273) ?, | 19:23 |
| dansmith | tssurya: yeah | 19:23 |
| tssurya | got it, I'll try to update that patch :) thanks! | 19:23 |
| *** _erlon_ has quit IRC | 19:23 | |
| *** eharney has quit IRC | 19:23 | |
| *** openstackgerrit has joined #openstack-nova | 19:25 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Create request spec, build request and mappings in one transaction https://review.opendev.org/586742 | 19:25 |
| *** itlinux has joined #openstack-nova | 19:34 | |
| jaypipes | melwitt: no worries, Melanie! :) | 19:36 |
| *** tssurya has quit IRC | 19:38 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image type capability flags and trait conversions https://review.opendev.org/652710 | 19:40 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Expose Hyper-V supported image types https://review.opendev.org/655137 | 19:40 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make libvirt expose supported image types https://review.opendev.org/653454 | 19:40 |
| *** JamesBenson has joined #openstack-nova | 19:41 | |
| JamesBenson | hey all | 19:42 |
| JamesBenson | I'm getting a nova_compute issue with this error: https://paste.fedoraproject.org/paste/EZYsQ8eDlp9gDjA8BB1YiA/ | 19:42 |
| JamesBenson | This is with a xen hypervisor | 19:42 |
| *** openstackgerrit has quit IRC | 19:42 | |
| JamesBenson | I'm installed os_xenapi with pip | 19:42 |
| dansmith | oh so you're the one! | 19:46 |
| *** gerrykopec has joined #openstack-nova | 19:48 | |
| JamesBenson | dansmith??? | 19:51 |
| dansmith | JamesBenson: ...guy still using xen :) | 19:52 |
| JamesBenson | dansmith, trust me, this is the first time and only because we are getting software that is based off of the xen hypervisor. | 19:52 |
| JamesBenson | needless to say, I'm finding bugs. | 19:52 |
| dansmith | I'm assuming this is the nova-compute log, but it looks really strange. definitely seems like you're failing to import os_xenapi for some reason that I can't help you with | 19:53 |
| JamesBenson | yes, nova-compute log | 19:53 |
| dansmith | the db accesses are super strange, but I'd resolve the import issue first in case that is kicking it into some weird state where it's trying to survey the db when it shouldn't | 19:53 |
| JamesBenson | it's coming from kolla-ansible | 19:53 |
| JamesBenson | So in the docker container, I can open python console and import sucessfully | 19:53 |
| JamesBenson | I did have to tar the dir in site-packages, cp it over and expand... but console did work. | 19:54 |
| dansmith | it's hard to tell from the traces, but I guess it's possible that os_xenapi is trying to access the db on init and that is preventing it from being imported, but that has been disallowed for many years | 19:55 |
| dansmith | so I wouldn't know what to say | 19:55 |
| *** dave-mccowan has joined #openstack-nova | 19:56 | |
| JamesBenson | dansmith, are you familiar with kolla? | 20:01 |
| dansmith | nope | 20:02 |
| JamesBenson | Is it possible to check that nova is using openstack's os-xenapi instead of python-os-xenapi? | 20:09 |
| JamesBenson | I've never played with nova code explicitly. | 20:09 |
| *** efried_rollin is now known as efried | 20:14 | |
| efried | JamesBenson: The nova requirements.txt file lists: | 20:15 |
| efried | requirements.txt:os-xenapi>=0.3.3 # Apache-2.0 | 20:15 |
| efried | which means whatever happens when you say pip install 'os-xenapi>=0.3.3' | 20:16 |
| efried | aspiers: done, thanks for the reminder. | 20:16 |
| efried | sean-k-mooney: re libvirt-video-device-models, the action from last week was for kashyap to have a look at it and I would approve it if he was on board. | 20:18 |
| efried | I know kashyap has been one-armed-wallpaperer busy for the past few days... | 20:19 |
| *** igordc has quit IRC | 20:22 | |
| *** igordc has joined #openstack-nova | 20:23 | |
| *** igordc has quit IRC | 20:23 | |
| sean-k-mooney | efried: ya that fine | 20:36 |
| sean-k-mooney | it cna wait until after the ptg | 20:36 |
| sean-k-mooney | i was going to add it to the runway list but noticed it wasnt approved so held off | 20:36 |
| sean-k-mooney | i have set a workflow -1 on the nova patch in the inerim | 20:36 |
| *** pcaruana has quit IRC | 20:39 | |
| JamesBenson | efried, so I wonder why it wasn't installed by default | 20:40 |
| efried | sorry, I wasn't following the conversation, let me read scrollback... | 20:41 |
| gmann | efried: regarding PT schedule, can we move 'API inconsistency cleanup' L276 on Thursday or friday ? I would not be available on Saturday due to my flight | 20:41 |
| gmann | PTG | 20:41 |
| efried | gmann: Roger that, will shuffle, thanks for the heads up. | 20:42 |
| gmann | efried: thanks . | 20:42 |
| JamesBenson | efried, sean-k-mooney could you provide insight too, I've seen you in kolla :-) | 20:42 |
| efried | you haven't seen *me* in kolla :P | 20:42 |
| JamesBenson | sorry to pick on you explicitly, oh man, sorry efried! | 20:42 |
| sean-k-mooney | JamesBenson: context? | 20:43 |
| efried | (I have nothing against kolla, just completely ignorant/inexperienced there) | 20:43 |
| sean-k-mooney | reading back | 20:43 |
| JamesBenson | sean-k-mooney: I'm doing kolla with xen, the nova_compute container is having issues with os_xenapi and six, I had to manually install them, but still vomits on itself. | 20:43 |
| JamesBenson | sean-k-mooney, check out the paste for the error log... | 20:44 |
| sean-k-mooney | JamesBenson: i honestly did not know kolla-ansible supproted xen i always used it with kvm | 20:45 |
| JamesBenson | likewise, until we got software that needs a xenblanket... | 20:45 |
| sean-k-mooney | i would gues in addtion to installing xen you might need to run some db migrations | 20:46 |
| sean-k-mooney | oh xen server is supported now https://github.com/openstack/kolla-ansible/blob/23415bf8bb8179a966d1c10bd46e6cb9045f2b5d/doc/source/reference/compute/xenserver-guide.rst | 20:47 |
| JamesBenson | doing this little experiment, I'm finding bugs in several different openstack processes... :-( | 20:47 |
| JamesBenson | yeah | 20:47 |
| sean-k-mooney | what version of python are you using | 20:47 |
| sean-k-mooney | i assume python 2 | 20:48 |
| JamesBenson | this is version 2 still | 20:48 |
| sean-k-mooney | ya it 2.7 from the logs cool | 20:48 |
| sean-k-mooney | so this is in the cells scater gather code | 20:49 |
| sean-k-mooney | we indocuded explcitly use fo eventlets there | 20:49 |
| JamesBenson | ? | 20:49 |
| sean-k-mooney | in stien we intoduced a parallel cell list feature | 20:50 |
| JamesBenson | yes, I think it was failing at the cells spot in ansible | 20:50 |
| JamesBenson | I'm deploying using 7.0.1 | 20:50 |
| sean-k-mooney | it was implemented using eventlets expclitly but that means in stien you need to monkey patch the nova api now | 20:50 |
| sean-k-mooney | but some people have been having issue with monkey patched nova api under uwsigi also | 20:51 |
| sean-k-mooney | do you know how this is run in in kolla | 20:51 |
| JamesBenson | honestly, starting to get to the limits of my knowledge here now. | 20:52 |
| *** eharney has joined #openstack-nova | 20:52 | |
| sean-k-mooney | im checking the kolla repos to see | 20:52 |
| JamesBenson | I do know this needs to get fixed in kolla-ansible: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/tasks/bootstrap_xenapi.yml#L3 and L4, | 20:54 |
| efried | mriedem: pike-em good to go at this point? | 20:54 |
| sean-k-mooney | JamesBenson: the command is nova-api so i think it running under pythons built in web server with haproxy in front | 20:55 |
| sean-k-mooney | at least based on https://github.com/openstack/kolla-ansible/blob/7.0.1/ansible/roles/nova/templates/nova-api.json.j2#L2 | 20:56 |
| sean-k-mooney | JamesBenson: what people were seeing was under uwsgi instead of mod_wsig the nova-api was not sending/reciving heartbeats to rabbitmq and teh connect to amqp was dropping | 20:58 |
| sean-k-mooney | although im not sure that is related to your issue | 20:58 |
| sean-k-mooney | JamesBenson: how did you install os_xenapi | 21:00 |
| sean-k-mooney | did you rebuild the images using the template overide file | 21:00 |
| JamesBenson | it was a multistep process.... but tar'ed the package locally from python2.7/site-packages, docker cp, untar... I issued the commands using docker exec -u 0 | 21:01 |
| sean-k-mooney | oh there is a standard way to extend kolla images | 21:02 |
| JamesBenson | I verified inside the container by logging into it, running python, and importing the packages without issue | 21:02 |
| JamesBenson | yeah, I didn't want to rebuild the images as I was sure there would be more issues. | 21:02 |
| sean-k-mooney | https://github.com/openstack/kolla/blob/master/doc/source/admin/image-building.rst#generic-customisation | 21:02 |
| sean-k-mooney | did you pull the image form the docker hub | 21:03 |
| JamesBenson | yes | 21:03 |
| sean-k-mooney | ok | 21:03 |
| sean-k-mooney | let me check something | 21:03 |
| JamesBenson | so I'm good at debugging but don't do some processes often enough to remember how to do it, like submitted a bug, but now submitting the bug fix :-/. lol, downfall of academia and not industry, it's not a tool we use all too often. | 21:04 |
| JamesBenson | I know :how: to fix it, just submitting it... | 21:04 |
| sean-k-mooney | well i was going to check if they had a configuration option in the kolla build config to enable building with xen then compare that to the build setting used in the gate to publish the image | 21:05 |
| sean-k-mooney | but no no buil option that i can see in the config | 21:06 |
| sean-k-mooney | and just checking you rna the xen_bootsrap command | 21:07 |
| JamesBenson | yes had issues, but seemed to build the facts.json: https://da.gd/E0FIl | 21:08 |
| JamesBenson | and I can literally submit about 3 patches to fix the issues I had with xen, if I can bug you about the process privately. | 21:09 |
| *** ttsiouts has joined #openstack-nova | 21:09 | |
| *** arshad777 has quit IRC | 21:10 | |
| sean-k-mooney | well i havent working on kolla in about 18 months but if i can help sure | 21:10 |
| sean-k-mooney | wel proably should also bring this to the openstack-kolla channel | 21:10 |
| JamesBenson | because there are bugs in kolla-ansible, openstack os-xenapi, and what ever the issue is here or kolla with not installing the packages correctly in the docker container. | 21:11 |
| sean-k-mooney | im just loggin off for the night but feel free to ping me tommorow | 21:11 |
| sean-k-mooney | or ping me while im away and ill respond tomorow | 21:12 |
| JamesBenson | Lets talk tomorrow, I'm logging off soon too | 21:12 |
| sean-k-mooney | cool my irc client is connected to #openstack-kolla also so feel free to ping me there so we dont distub the nova folks for the packaging side | 21:13 |
| sean-k-mooney | the nova issue we can prably debug more here | 21:13 |
| sean-k-mooney | is it repoducable? | 21:13 |
| JamesBenson | most likely. | 21:13 |
| sean-k-mooney | only with xen or do you think i would hit it with libvir kvm too | 21:14 |
| sean-k-mooney | this does not look realted to xen to be honest | 21:14 |
| sean-k-mooney | well the db issues dont | 21:14 |
| sean-k-mooney | there are some other issue with the xenapi too at the end | 21:15 |
| mriedem | efried: yeah i've had the patch up since earlier today | 21:15 |
| JamesBenson | I'm not sure where it exactly crosses over, but I know definitely those two packages have issues, kolla-ansible and os-xenapi. Nova will need to dig deeper into to see where it breaks. | 21:16 |
| JamesBenson | But I've never dug into nova this deep. | 21:16 |
| *** itlinux has quit IRC | 21:16 | |
| sean-k-mooney | well there seams to be 2 basic erros in the nova log | 21:18 |
| sean-k-mooney | DBNotAllowed: nova-compute | 21:18 |
| sean-k-mooney | and then the xen api one | 21:18 |
| JamesBenson | agreed | 21:18 |
| JamesBenson | Is it possible that kolla mucked up the install of that package? | 21:19 |
| *** ttsiouts has quit IRC | 21:19 | |
| JamesBenson | But I thought that was pulled from the nova repo. | 21:19 |
| JamesBenson | ? | 21:19 |
| sean-k-mooney | well its posibel that the xen dirver need other config option to be set that kolla is nto setting in the nova.conf | 21:20 |
| sean-k-mooney | the default for the databse are set here https://github.com/openstack/kolla-ansible/blob/2dd69e9140b1ce1bd248c5c09217fb3a6502a9fc/ansible/roles/nova/defaults/main.yml#L161-L167 and used to generate teh config nova.conf here https://github.com/openstack/kolla-ansible/blob/2dd69e9140b1ce1bd248c5c09217fb3a6502a9fc/ansible/roles/nova/templates/nova.conf.j2#L156-L164 | 21:22 |
| sean-k-mooney | that code should be virt dirver independent | 21:23 |
| *** itlinux has joined #openstack-nova | 21:23 | |
| mriedem | melwitt: heh yeah that PS4 on the transactional create patch is about a billion times cleaner | 21:23 |
| *** itlinux has quit IRC | 21:24 | |
| *** whoami-rajat has quit IRC | 21:25 | |
| mriedem | efried: https://review.opendev.org/#/c/652868/ | 21:25 |
| *** itlinux has joined #openstack-nova | 21:28 | |
| *** openstackgerrit has joined #openstack-nova | 21:30 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.opendev.org/642899 | 21:30 |
| efried | mriedem: Right, just wanted to make sure that was the final | 21:32 |
| efried | mriedem: and presumably the one on top fails tests until the bottom one merges and the tag is created. | 21:32 |
| jaypipes | dansmith, mriedem: is it possible to update metadata on a server that failed to boot properly? (i.e. the instance went to cell0) | 21:36 |
| dansmith | jaypipes: metadata? like user metadata? | 21:36 |
| mriedem | efried: i'm trying to figure out why the one on top is failing | 21:37 |
| jaypipes | dansmith: no, sorry, metadata was a bad term. any attribute of the instance... say, it's name. | 21:37 |
| efried | mriedem: It's because the tags aren't created yet | 21:37 |
| efried | mriedem: I guess the job isn't smart enough to infer them from the releases in the predecessor patch. | 21:37 |
| dansmith | jaypipes: shouldn't really be anything cell0 specific I don't think.. if you can do it in error, then you can do it | 21:37 |
| dansmith | jaypipes: anything that requires talking to the host the instance is on won't work, of course | 21:38 |
| mriedem | jaypipes: like dansmith says it depends on the API and what it restricts, | 21:39 |
| mriedem | but i don't see any vm_state restrictions on the server update API | 21:39 |
| dansmith | and what I meant was, there could be vm_state restrictions, but none that are specific to cell0 that I know of, | 21:39 |
| dansmith | except something that ends up with an rpc call | 21:39 |
| jaypipes | dansmith, mriedem: this is some custom Yahoo! API plugin ... it grabs the Instance object, updates some custom attribute on it and then calls instance.save(). Unfortunately, that isn't working in a cellsv2 environment... | 21:39 |
| mriedem | interestingly there are restrictions on updating things like metadata and tags | 21:39 |
| mriedem | jaypipes: likely b/c it's not targeted to the cell0 db | 21:40 |
| dansmith | jaypipes: should be fine, just .. yeah, make sure it's targeted, | 21:40 |
| mriedem | it's not cells-aware | 21:40 |
| jaypipes | yeahg | 21:40 |
| jaypipes | juno code. | 21:40 |
| jaypipes | being converted to ocata. ugh. | 21:40 |
| dansmith | juno we don't give a shit, right? | 21:40 |
| mriedem | if it were smart and used the common.get_instance method, the Instance._context would already be targeted | 21:40 |
| jaypipes | ocata. | 21:41 |
| jaypipes | none of this is "smart" :) | 21:41 |
| dansmith | JU .. NO | 21:41 |
| *** itlinux has quit IRC | 21:41 | |
| mriedem | can i count verizon media group as a fallback employer to fix these old forks in case i get canned? | 21:41 |
| dansmith | can anyone count on verizon media group as an employer? | 21:41 |
| dansmith | bah dum dum | 21:41 |
| *** tbachman has joined #openstack-nova | 21:45 | |
| *** slaweq has quit IRC | 21:47 | |
| mriedem | ugh https://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/availability_zones.py#L125 | 21:47 |
| mriedem | https://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/compute/api.py#L4972 | 21:48 |
| mriedem | badum https://review.opendev.org/#/c/649197/ | 21:48 |
| *** slaweq has joined #openstack-nova | 21:48 | |
| *** itlinux has joined #openstack-nova | 21:49 | |
| *** igordc has joined #openstack-nova | 21:53 | |
| *** nicolasbock has quit IRC | 21:55 | |
| *** JamesBenson has quit IRC | 21:59 | |
| *** imacdonn has quit IRC | 22:01 | |
| *** imacdonn has joined #openstack-nova | 22:02 | |
| efried | gmann: Thursday 1200-1230 okay for API inconsistency cleanup? | 22:03 |
| *** itlinux has quit IRC | 22:03 | |
| gmann | efried: yeah, prefect. | 22:03 |
| efried | gmann: d'oh, I meant Friday 1200-1230 | 22:04 |
| gmann | efried: ok, friday also fine at 12. | 22:05 |
| efried | gmann: thanks | 22:05 |
| *** s1061123 has quit IRC | 22:05 | |
| *** s1061123 has joined #openstack-nova | 22:05 | |
| efried | dustinc: I've got the sdk topic scheduled for Thursday 1415-1430. mordred plans to be there for it too. | 22:09 |
| *** itlinux has joined #openstack-nova | 22:09 | |
| jaypipes | dansmith, mriedem: cells(v2) is a requirement in ocata, no? meaning, there's no "turning off" or not using cellsv2, yeah? | 22:09 |
| jaypipes | dansmith, mriedem: that's what the nova-manage map_instances call enables I thought? | 22:11 |
| mriedem | cells v2 is required since ocata yeah | 22:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: AZ list performance optimization: avoid double service list DB fetch https://review.opendev.org/636947 | 22:12 |
| mriedem | efried: i think i got the test leak plugged ^ and actually found another slight perf improvement in the process | 22:13 |
| efried | nice | 22:13 |
| mriedem | turns out globally mocking the DB API is not a great idea! | 22:13 |
| *** mlavalle has quit IRC | 22:13 | |
| efried | who woulda thunk | 22:13 |
| melwitt | mriedem: yeah, jaypipes saved the day :D | 22:14 |
| *** itlinux has quit IRC | 22:15 | |
| mriedem | so the spandex and cape aren't unusual | 22:15 |
| *** gibi has quit IRC | 22:15 | |
| jaypipes | nobody needs to see me in spandex. eww. | 22:15 |
| melwitt | not even the pugs | 22:15 |
| jaypipes | well, sure, Winnie in a cape would be cool. | 22:17 |
| melwitt | pugs in spandex, smooth out the rolls | 22:17 |
| jaypipes | she's already got the Rosie the Pugeter iron-on decal on her Brownies jersey. | 22:18 |
| melwitt | hells yeah | 22:18 |
| melwitt | hm, somehow the unit tests get caught up in the database poison fixture when I back out the change | 22:21 |
| jaypipes | that girl is poison. | 22:21 |
| melwitt | that's a blast from the past | 22:22 |
| jaypipes | that's right... whipped out some Bell Biv there. | 22:22 |
| jaypipes | jeebus I'm old. | 22:22 |
| * jaypipes goes back to applying arthritis medicine | 22:22 | |
| *** gibi has joined #openstack-nova | 22:23 | |
| melwitt | oh, it's just because of the database context manager decorator on the helper method, that triggers the POISON | 22:23 |
| melwitt | arthritis-- | 22:23 |
| *** slaweq has quit IRC | 22:24 | |
| *** itlinux has joined #openstack-nova | 22:25 | |
| efried | aspiers: are you around through Saturday at the PTG? | 22:29 |
| aspiers | yup | 22:29 |
| *** luksky has quit IRC | 22:31 | |
| efried | aspiers: Friday 1615-beer good for you? | 22:32 |
| aspiers | $day $time beer is good for me | 22:33 |
| aspiers | that particular tuple is no exception :) | 22:33 |
| efried | sorry, what I mean is, Friday 1615 until it's time to go get beer. | 22:33 |
| efried | I'm not saying you get beer at 1615 | 22:34 |
| aspiers | awww | 22:34 |
| efried | you can bring your own, I won't stop you. | 22:34 |
| aspiers | raise up my hopes then cruelly dash them, why don't you | 22:34 |
| aspiers | but sure :) | 22:34 |
| efried | I'm cruelly dashing that way | 22:34 |
| aspiers | I guess 1615 is kinda early to start ;-) | 22:34 |
| efried | it'll be 2315 in your time zone | 22:34 |
| aspiers | true | 22:35 |
| efried | pubs already closed | 22:35 |
| efried | (do they still close at 11? It was so when I was growing up) | 22:35 |
| aspiers | It varies | 22:35 |
| aspiers | You used to live here? | 22:35 |
| aspiers | or just remember the tourist pub run | 22:35 |
| efried | I used to live in Buckinghamshire | 22:36 |
| aspiers | no way | 22:36 |
| aspiers | for how long? | 22:36 |
| efried | 1984-7 and 89-94 | 22:36 |
| aspiers | that's a decent length of time | 22:37 |
| efried | Most of my formative years, I would say. | 22:37 |
| aspiers | whereabouts? | 22:37 |
| efried | Gerrard's Cross and Beaconsfield, respectively. | 22:37 |
| aspiers | funny old world | 22:37 |
| aspiers | where are you now? | 22:37 |
| efried | you know Bucks? | 22:37 |
| efried | Central Texas, Austin area | 22:37 |
| aspiers | not really, but I know of both those places | 22:38 |
| aspiers | most notably, Dominic Grieve represents the latter in Parliament IIRC | 22:38 |
| aspiers | that's quite a change | 22:38 |
| efried | heh, never paid any attention to the politics. Still don't. | 22:38 |
| aspiers | I like Austin, don't know the surrounding area | 22:38 |
| efried | I used to like Austin | 22:38 |
| aspiers | haha | 22:39 |
| efried | Now it's overrun with hipster douchebags | 22:39 |
| efried | and getting too snobby for its britches | 22:39 |
| aspiers | :) | 22:39 |
| aspiers | happens to all the best places | 22:39 |
| *** slaweq has joined #openstack-nova | 22:40 | |
| efried | if you like it they will come | 22:41 |
| efried | case in point, the Trocadero | 22:41 |
| efried | Carnaby Street | 22:41 |
| efried | Camden Town | 22:42 |
| aspiers | :) | 22:42 |
| aspiers | it's a bit like the Ballmer Peak | 22:43 |
| aspiers | places are shit for ages, then suddenly get cool, then everyone realises and floods the trendy cool place and ruins it again | 22:44 |
| efried | aspiers, mriedem, gibi: I swapped both the traits filter topics with the bandwidth continuation. So now we have | 22:45 |
| efried | Thursday 1330-1415: Let's plan the next steps of the bandwidth support feature (gibi) | 22:45 |
| efried | Friday | 22:45 |
| efried | 1615-1630: Compute capabilities traits placement request filter (mriedem) | 22:45 |
| efried | 1630-beer: Disabled compute service request filter (mriedem) | 22:45 |
| efried | um, jaypipes, did you want to be around for the latter? | 22:45 |
| aspiers | awesome thanks | 22:45 |
| mriedem | efried: ok, although i didn't think the bw spec was that controversial | 22:49 |
| mriedem | just needs to be updated | 22:49 |
| efried | mriedem: Sorry, lack of context, I just realized that aspiers responded to me and not the list - he wanted to be around for the traits filter topics (which also increases our chances of convincing him to own them :) but is unavailable Thursday. | 22:50 |
| efried | mriedem, gibi: And definitely if we don't need as much (or any) time to talk about the bandwidth stuff, let me know so I can shuffle some more stuff in. | 22:51 |
| efried | mriedem: I got the impression that gibi wanted to have a kind of live design session for some of the issues. | 22:52 |
| mriedem | i'll let gibi answer that, i think the biggest hangups in the bw migration spec was (1) do we use a microversion (sounds like yeah probably) and (2) upgrade issues which i think he understands now | 22:52 |
| *** slaweq has quit IRC | 22:53 | |
| *** tkajinam has joined #openstack-nova | 22:53 | |
| *** rcernin has joined #openstack-nova | 22:54 | |
| efried | neat, I'll fup with gibi | 22:55 |
| mriedem | dansmith: re https://review.opendev.org/#/c/649197/2/nova/compute/rpcapi.py@381 i think that's as easy as just resetting the compute.rpcapi._ROUTER global on ComputeManager.reset() or am i missing some nasty detail? | 22:56 |
| dansmith | mriedem: nope, I think that'll do it | 22:57 |
| mriedem | what do you think about just throwing reset_globals() from https://review.opendev.org/#/c/649197/2/nova/tests/unit/compute/test_rpcapi.py@37 into the rpcapi module itself? then i can hit it from multiple locations | 22:57 |
| dansmith | sec, phone | 23:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Always pass HostAPI to get_availability_zones https://review.opendev.org/655583 | 23:03 |
| mriedem | heh "Problme: Even though splited, still long and boring. Need fully review." | 23:04 |
| mriedem | L224 in the ptg etherpad | 23:04 |
| mriedem | efried: L223 is likely not something we really need for the ptg https://etherpad.openstack.org/p/nova-ptg-train it's just a request for review | 23:06 |
| mriedem | which i've done once before, just - it's a lot of code and i forgot about it | 23:06 |
| eandersson | What is this fun error | 23:07 |
| eandersson | > ValueError: unmatched '{' in format | 23:07 |
| eandersson | When running cell mapping | 23:07 |
| efried | mriedem: ack | 23:07 |
| mriedem | are you using templates for the transport_url or db connection? | 23:07 |
| eandersson | no template | 23:07 |
| eandersson | my best guess is a special char in the password is causing some fun bug | 23:08 |
| mriedem | do you have a stacktrace you can paste? | 23:08 |
| efried | mriedem: a little background, I've scheduled that there because of the stx association, and dtroyer will still be in the room. If we don't need to discuss it, we can take a coffee break at that time :) | 23:08 |
| mriedem | maybe | 23:08 |
| mriedem | i suppose you don't want to paste the trace b/c of said password... | 23:08 |
| mriedem | efried: ok, whatever, i think it's just a request for review | 23:09 |
| efried | ack | 23:09 |
| mriedem | melwitt and i have both reviewed it before | 23:09 |
| efried | well cool, if y'all merge it before the PTG I'll definitely strike it :) | 23:10 |
| mriedem | it's like 800 LOC though | 23:10 |
| mriedem | heh | 23:10 |
| efried | and in merge conflict | 23:10 |
| mriedem | if it were a blueprint (which it arguably could be) then it could sit in a runway | 23:10 |
| mriedem | the bottom patch isn't | 23:10 |
| ccstone | (I'm also working with eandersson) He already gave away the special character which is { :) | 23:10 |
| mriedem | then the reviews would floweth like fine wine | 23:10 |
| efried | sure they would | 23:11 |
| *** slaweq has joined #openstack-nova | 23:11 | |
| efried | lemme see what a rebase would look like. | 23:11 |
| mriedem | ccstone: which release of rocky? | 23:12 |
| mriedem | latest patch? | 23:12 |
| mriedem | 18.2.0? | 23:12 |
| *** mvkr has quit IRC | 23:12 | |
| mriedem | i was thinking maybe https://review.opendev.org/#/c/633086/ but that might not hit you if you're not using templated urls | 23:12 |
| mriedem | ccstone: can you provide a bug or trace without the password in it? i don't know which command is being referenced | 23:14 |
| ccstone | Yeah, we're on 18.2.0, looks like we do have that patch. | 23:14 |
| *** cooper6581 has joined #openstack-nova | 23:15 | |
| eandersson | http://paste.openstack.org/show/749729/ | 23:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912 | 23:16 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Clean up orphan instances https://review.opendev.org/627765 | 23:16 |
| efried | mriedem, melwitt: fyi, rebase was easy ^ | 23:16 |
| *** gibi has quit IRC | 23:18 | |
| mriedem | eandersson: ccstone: please report a bug, i want to say we talked about special characters in passwords when adding that code and there were some assertions made, but i can't remember now, would definitely want dansmith to look | 23:18 |
| mriedem | but he's busy | 23:18 |
| dansmith | mriedem: sure, that seems okay I think (re reset_globals) | 23:20 |
| mriedem | eandersson: ccstone: looks like we'll catch and trace that ValueError but things don't fail right? we return the URL as-is | 23:21 |
| dansmith | mriedem: eandersson ccstone: passwords should be url-encoded | 23:21 |
| ccstone | mriedem: Will do, thanks! Our immediate fix was to change the rabbit password, but we're still getting the error, I assume because something has already put the transport_url in the database. Is there a nova-manage command to update that? | 23:21 |
| mriedem | ccstone: nova-manage cell_v2 update_cell https://docs.openstack.org/nova/rocky/cli/nova-manage.html#nova-cells-v2 | 23:22 |
| dansmith | I do remember something about one place where we couldn't urlencode it ourselves for you but I forget why | 23:22 |
| dansmith | but it was non-trivial silliness | 23:22 |
| eandersson | Yea - we didn't realize that it wasn't reading it from the config. | 23:22 |
| eandersson | (anymore at least) | 23:22 |
| ccstone | I think the issue was that it wasn't URL encoded when we ran simple_cell_setup (also we did that step on Newton code) | 23:22 |
| ccstone | Or part of that issue at least | 23:22 |
| mriedem | fwiw i remember f'ing around with this several times https://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/cmd/manage.py#L1006 | 23:23 |
| mriedem | for formatting the db url | 23:23 |
| mriedem | using sqlalchemy utilities | 23:23 |
| *** mchlumsky has quit IRC | 23:23 | |
| *** slaweq has quit IRC | 23:25 | |
| *** JamesBenson has joined #openstack-nova | 23:27 | |
| *** gibi has joined #openstack-nova | 23:31 | |
| *** cooper6581 has quit IRC | 23:31 | |
| *** JamesBenson has quit IRC | 23:31 | |
| *** itlinux has quit IRC | 23:33 | |
| *** itlinux has joined #openstack-nova | 23:37 | |
| *** hongbin has quit IRC | 23:48 | |
| *** itlinux has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!