| openstackgerrit | Merged openstack/nova stable/rocky: Override the 'get' method in DriverBlockDevice class https://review.openstack.org/647651 | 00:01 |
|---|---|---|
| *** tetsuro has joined #openstack-nova | 00:02 | |
| alex_xu | francoisp_: already add it my review list, will try to reach it | 00:06 |
| *** gyee has quit IRC | 00:08 | |
| *** sapd1_x has joined #openstack-nova | 00:11 | |
| mriedem | cfriesen: jackding: wee stein regression https://bugs.launchpad.net/nova/+bug/1825020 | 00:25 |
| openstack | Launchpad bug 1825020 in OpenStack Compute (nova) "resize of instance, that was booted from volume, trigger image size check then fails resize" [Undecided,New] | 00:26 |
| *** jding1_ has joined #openstack-nova | 00:29 | |
| *** sapd1_x has quit IRC | 00:30 | |
| *** jackding has quit IRC | 00:32 | |
| *** mriedem has quit IRC | 00:38 | |
| *** nicolasbock has quit IRC | 00:39 | |
| *** jding1__ has joined #openstack-nova | 00:45 | |
| *** jding1_ has quit IRC | 00:47 | |
| *** bryan_stephenson has quit IRC | 00:54 | |
| *** ricolin has joined #openstack-nova | 00:56 | |
| *** hamzy has joined #openstack-nova | 01:22 | |
| *** threestrands has joined #openstack-nova | 01:24 | |
| *** yedongcan has joined #openstack-nova | 01:24 | |
| melwitt | aspiers: something odd for your morrow http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-04-17.log.html#t2019-04-17T00:13:06 | 01:24 |
| melwitt | tl;dr placement rejecting a PUT of the COMPUTE_NET_ATTACH_INTERFACE trait from nova compute. I don't understand how that could be happening | 01:26 |
| *** tetsuro has quit IRC | 01:27 | |
| *** whoami-rajat has joined #openstack-nova | 01:31 | |
| *** hongbin has joined #openstack-nova | 01:37 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix functional tests for USE_NEUTRON https://review.openstack.org/649385 | 01:54 |
| openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1669054 https://review.openstack.org/649386 | 01:54 |
| openstack | bug 1669054 in OpenStack Compute (nova) pike "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | 01:54 |
| *** ileixe has quit IRC | 01:55 | |
| *** ileixe has joined #openstack-nova | 01:58 | |
| *** Sundar has quit IRC | 01:58 | |
| openstackgerrit | Merged openstack/nova stable/pike: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649387 | 02:06 |
| *** itlinux has joined #openstack-nova | 02:09 | |
| *** mriedem has joined #openstack-nova | 02:11 | |
| *** lbragstad has quit IRC | 02:30 | |
| *** cfriesen has quit IRC | 02:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude fake marker instance when listing servers https://review.openstack.org/653158 | 02:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test wrinkle to list deleted servers before archive https://review.openstack.org/653131 | 02:32 |
| *** itlinux has quit IRC | 02:52 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | 02:54 |
| *** itlinux has joined #openstack-nova | 02:54 | |
| mriedem | melwitt: regarding the change in behavior for quota usage calculations pre and post pike with counting, you might want to report a bug just to capture the change in behavior just so we can at least document it if we want outside of mailing list threads and code review comments | 02:57 |
| mriedem | i was thinking something like if we fleshed out the quota docs reference page we could / should the big shift in design with counting in pike but could also list that as a known issue | 02:57 |
| mriedem | https://docs.openstack.org/nova/latest/user/quotas.html | 02:58 |
| mriedem | there was also https://bugs.launchpad.net/nova/+bug/1716706 | 02:59 |
| openstack | Launchpad bug 1716706 in OpenStack Compute (nova) "Should count instances in build requests when check quotas" [Medium,Triaged] | 02:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1825020 https://review.openstack.org/653268 | 03:03 |
| openstack | bug 1825020 in OpenStack Compute (nova) stein "resize of instance, that was booted from volume, trigger image size check then fails resize" [High,Triaged] https://launchpad.net/bugs/1825020 | 03:03 |
| *** psachin has joined #openstack-nova | 03:12 | |
| *** ileixe has quit IRC | 03:25 | |
| melwitt | mriedem: ack | 03:28 |
| eandersson | mriedem, nvm wasn't a nova bug | 03:29 |
| eandersson | https://review.openstack.org/#/c/653271/ | 03:29 |
| eandersson | * https://review.openstack.org/#/c/653233/ | 03:29 |
| *** ileixe has joined #openstack-nova | 03:31 | |
| mriedem | eandersson: ack - you should report a bug for the latter | 03:33 |
| mriedem | or story or whatever | 03:33 |
| eandersson | Yep | 03:33 |
| eandersson | I'll deal with that tomorrow | 03:33 |
| *** hongbin has quit IRC | 03:38 | |
| *** itlinux has quit IRC | 03:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass root bdm to _validate_flavor_image_nostatus during resize https://review.openstack.org/653273 | 04:02 |
| *** imacdonn has quit IRC | 04:07 | |
| *** imacdonn has joined #openstack-nova | 04:07 | |
| *** mriedem has quit IRC | 04:08 | |
| *** david-lyle has joined #openstack-nova | 04:13 | |
| *** manjeets_ has joined #openstack-nova | 04:14 | |
| *** dklyle has quit IRC | 04:16 | |
| *** manjeets has quit IRC | 04:16 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_usages_counts_for_quota to SchedulerReportClient https://review.openstack.org/653145 | 04:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 04:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Set [quota]count_usage_from_placement = True in nova-next https://review.openstack.org/653146 | 04:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 04:27 |
| *** mdbooth has joined #openstack-nova | 04:30 | |
| *** ileixe has quit IRC | 04:31 | |
| *** mdbooth has quit IRC | 04:34 | |
| *** udesale has joined #openstack-nova | 04:37 | |
| *** ratailor has joined #openstack-nova | 04:51 | |
| *** ratailor has quit IRC | 04:51 | |
| *** ratailor has joined #openstack-nova | 04:53 | |
| *** ileixe has joined #openstack-nova | 05:02 | |
| *** vishakha has joined #openstack-nova | 05:09 | |
| *** ivve has joined #openstack-nova | 05:13 | |
| *** sridharg has joined #openstack-nova | 05:23 | |
| *** janki has joined #openstack-nova | 05:49 | |
| *** ileixe has quit IRC | 05:55 | |
| *** ileixe has joined #openstack-nova | 05:58 | |
| *** pcaruana has joined #openstack-nova | 06:11 | |
| *** belmoreira has joined #openstack-nova | 06:17 | |
| *** ralonsoh has joined #openstack-nova | 06:21 | |
| *** dpawlik has joined #openstack-nova | 06:31 | |
| *** udesale has quit IRC | 06:37 | |
| *** udesale has joined #openstack-nova | 06:38 | |
| *** udesale has quit IRC | 06:39 | |
| *** udesale has joined #openstack-nova | 06:44 | |
| *** udesale has quit IRC | 06:46 | |
| *** bhagyashris has joined #openstack-nova | 06:49 | |
| *** udesale has joined #openstack-nova | 06:56 | |
| *** ileixe has quit IRC | 06:57 | |
| *** ileixe has joined #openstack-nova | 07:02 | |
| *** tesseract has joined #openstack-nova | 07:03 | |
| *** belmoreira has quit IRC | 07:09 | |
| *** belmoreira has joined #openstack-nova | 07:10 | |
| *** rpittau|afk is now known as rpittau | 07:19 | |
| kashyap | aspiers: Morning, just took a quick look. I see the topic is: machine types as 'traits'. Will respond today once I finish something | 07:22 |
| *** tesseract has quit IRC | 07:29 | |
| *** tosky has joined #openstack-nova | 07:29 | |
| *** tesseract has joined #openstack-nova | 07:29 | |
| *** dtantsur|afk is now known as dtantsur | 07:33 | |
| *** tesseract has quit IRC | 07:33 | |
| *** tesseract has joined #openstack-nova | 07:34 | |
| *** tssurya has joined #openstack-nova | 07:43 | |
| *** awalende has joined #openstack-nova | 07:52 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Do not perform port update in case of baremetal instance. https://review.openstack.org/649345 | 08:00 |
| *** ttsiouts has joined #openstack-nova | 08:06 | |
| *** klindgren has quit IRC | 08:10 | |
| *** klindgren has joined #openstack-nova | 08:10 | |
| *** rcernin has quit IRC | 08:13 | |
| *** ttsiouts has quit IRC | 08:17 | |
| *** ttsiouts has joined #openstack-nova | 08:17 | |
| *** tkajinam has quit IRC | 08:17 | |
| *** ttsiouts has quit IRC | 08:22 | |
| *** rcernin has joined #openstack-nova | 08:27 | |
| *** ttsiouts has joined #openstack-nova | 08:28 | |
| *** vishakha has quit IRC | 08:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Re-propose stable device rescue for Train https://review.openstack.org/651151 | 08:33 |
| *** luksky has joined #openstack-nova | 08:43 | |
| *** udesale has quit IRC | 08:51 | |
| *** ccamacho has joined #openstack-nova | 08:53 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534 | 09:09 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | 09:09 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | 09:09 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | 09:09 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: FUP on use-placement-in-tree series https://review.openstack.org/653362 | 09:09 |
| *** ttsiouts has quit IRC | 09:17 | |
| *** ttsiouts has joined #openstack-nova | 09:18 | |
| *** ttsiouts_ has joined #openstack-nova | 09:19 | |
| *** ttsiouts has quit IRC | 09:19 | |
| *** udesale has joined #openstack-nova | 09:20 | |
| *** mdbooth has joined #openstack-nova | 09:21 | |
| *** threestrands has quit IRC | 09:36 | |
| *** lpetrut has joined #openstack-nova | 09:40 | |
| *** mdbooth_ has joined #openstack-nova | 09:43 | |
| *** mdbooth_ has quit IRC | 09:46 | |
| *** mdbooth has quit IRC | 09:46 | |
| *** mdbooth has joined #openstack-nova | 09:49 | |
| *** bhagyashris has quit IRC | 09:49 | |
| stephenfin | rechecking all the things | 09:49 |
| *** luksky has quit IRC | 10:08 | |
| *** jchhatbar has joined #openstack-nova | 10:14 | |
| *** janki has quit IRC | 10:16 | |
| *** janki has joined #openstack-nova | 10:23 | |
| *** jchhatbar has quit IRC | 10:25 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.openstack.org/506720 | 10:26 |
| kashyap | sean-k-mooney: Hi, when you get a minute ^ I've wrote a summary response. And addressed a few things. | 10:27 |
| kashyap | I spent a lot of time writing the summary response, please read it in full before responding. | 10:28 |
| *** awalende has quit IRC | 10:32 | |
| *** awalende has joined #openstack-nova | 10:32 | |
| *** awalende has quit IRC | 10:36 | |
| *** ttsiouts_ has quit IRC | 10:37 | |
| *** ttsiouts has joined #openstack-nova | 10:38 | |
| *** nicolasbock has joined #openstack-nova | 10:38 | |
| *** yedongcan has left #openstack-nova | 10:39 | |
| *** luksky has joined #openstack-nova | 10:39 | |
| *** awalende has joined #openstack-nova | 10:42 | |
| *** ttsiouts has quit IRC | 10:42 | |
| *** tbachman has quit IRC | 10:45 | |
| kashyap | lyarwood: gibi: If you have 15 more minutes today, appreciate another look at this: https://review.openstack.org/506720 | 10:45 |
| *** awalende has quit IRC | 10:56 | |
| *** awalende has joined #openstack-nova | 10:57 | |
| aspiers | kashyap: cool thanks | 11:01 |
| kashyap | aspiers: About to hit 'submit' with my comment | 11:02 |
| aspiers | awesome | 11:02 |
| kashyap | aspiers: Also if you have spare neurons, here's the UEFI SB spec: https://review.openstack.org/#/c/506720/ | 11:02 |
| kashyap | I addressed as much as I can. And my eyes are weary from reading my own text. (Despite extensive editing) | 11:02 |
| aspiers | if anything I have a neuron deficit, but that's my problem ;-) | 11:02 |
| aspiers | Haha I know that feeling | 11:02 |
| kashyap | aspiers: No problem at all. Then just say "no". :-) | 11:04 |
| aspiers | I hate asking people for help and not offering some in return though :-/ | 11:06 |
| *** ttsiouts has joined #openstack-nova | 11:08 | |
| sean-k-mooney | kashyap: ya most of your responce makes sense. ill re review with itopen in a secon tab | 11:12 |
| kashyap | Nod. I would like to avoid "scope creep". "Takcle few things, and takle them well" | 11:13 |
| sean-k-mooney | well i dont think you can tackel it well without the trait for secure boot support and if we add one then we have to add it for all hyperviors that support it or require operator to manully add it to the flavor instead of making it automatic | 11:16 |
| sean-k-mooney | so the way to avoid scope creap is to documnet the reqrirement to add it to the flavor. | 11:16 |
| kashyap | Let's talk systematically on the change. I need to go be AFK for lunch | 11:16 |
| sean-k-mooney | sure :) | 11:16 |
| *** panda is now known as panda|lunch | 11:18 | |
| NewBruce | sean-k-mooney: (mnaser) - have restared nova-conductor, issue still persists; cold migration RDO - OSA works fine, and OSA - OSA is ok | 11:19 |
| NewBruce | - have updated the launchpad | 11:19 |
| *** jchhatbar has joined #openstack-nova | 11:20 | |
| *** ttsiouts has quit IRC | 11:20 | |
| *** ttsiouts has joined #openstack-nova | 11:21 | |
| sean-k-mooney | NewBruce: you are sure your python interperter was not built on friday the 13th and shipt on april 1st with some magical gremlens thrown in for good mesure | 11:21 |
| NewBruce | he he he, seems that way, huh? | 11:21 |
| NewBruce | ive got on my to try 1) disable binding-extended (if possible) 2) upgrade_levels = queens 3) priest + full a moon | 11:22 |
| *** janki has quit IRC | 11:22 | |
| sean-k-mooney | im wondering if we litrally need to do a singel node osa deployment + add a singel node rdo compute to actlly be able to reporduce this | 11:22 |
| NewBruce | yeah, im thinking what we can do to reproduce | 11:23 |
| sean-k-mooney | NewBruce: is you rdo deployment made with triplo or packstack? | 11:24 |
| NewBruce | Not that im aware of, it pre-dates my time here - but i think it was pretty ad-hoc | 11:24 |
| *** ttsiouts has quit IRC | 11:25 | |
| sean-k-mooney | so its a manual install of RDO without a tool? | 11:25 |
| NewBruce | but going back to basics and what we know; we can localise it to post_migrate and an attempt to update the port profiles, which it shouldnt be doing. right? | 11:25 |
| sean-k-mooney | im wondering if we can use a gate job to repoduce | 11:25 |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: WIP: Initial prototype for simple RPC health checks https://review.openstack.org/653406 | 11:26 |
| sean-k-mooney | mnaser: it should be fairly simple to create an all in one OSA right, im wondering how hard it would be to also add a singel node rdo computej too maybe via packstack to repoducs NewBruce's issue | 11:27 |
| NewBruce | so, peppering the api.py with enough debug statements we’ve been able to localise where thats done - and we should be able to walk backwards right? | 11:27 |
| *** ttsiouts has joined #openstack-nova | 11:27 | |
| NewBruce | sean-k-mooney: did you see the full log traces i sent? | 11:28 |
| sean-k-mooney | yes it is ending in post migrate so we should be able to walk backward. | 11:28 |
| NewBruce | grabbed your email from you launchpad page - will drop you a mail shortly | 11:29 |
| sean-k-mooney | NewBruce: no not yet. bit of a late start today so still catching up on things | 11:29 |
| NewBruce | quick question to the assembled masses - does anyone know if Enable cold migration with target host - Queen (https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/cold-migration-with-target-queens.html was ever implemented? ive not had any luck getting it to work | 11:33 |
| sean-k-mooney | well its in the implemented section so it should have been yes | 11:34 |
| sean-k-mooney | you cant do it via osc | 11:35 |
| NewBruce | only apl? | 11:35 |
| sean-k-mooney | nova migrate [--host <host>] [--poll] <server> | 11:36 |
| NewBruce | Aha - gotcha; cheers | 11:36 |
| *** cdent has joined #openstack-nova | 11:36 | |
| sean-k-mooney | you have to add --host and the order is cahnged | 11:36 |
| sean-k-mooney | we should proablly add that to osc too | 11:36 |
| *** _erlon_ has joined #openstack-nova | 11:42 | |
| *** mdbooth_ has joined #openstack-nova | 11:42 | |
| *** ttsiouts has quit IRC | 11:43 | |
| *** ttsiouts has joined #openstack-nova | 11:44 | |
| *** boxiang has quit IRC | 11:44 | |
| *** boxiang has joined #openstack-nova | 11:45 | |
| *** mdbooth has quit IRC | 11:45 | |
| *** ttsiouts_ has joined #openstack-nova | 11:46 | |
| *** ttsiouts has quit IRC | 11:47 | |
| *** mdbooth_ has quit IRC | 11:47 | |
| *** ratailor has quit IRC | 11:48 | |
| *** ttsiouts_ has quit IRC | 11:51 | |
| *** awalende has quit IRC | 11:52 | |
| *** awalende has joined #openstack-nova | 11:53 | |
| *** awalende has quit IRC | 11:53 | |
| *** awalende has joined #openstack-nova | 11:54 | |
| *** awalende has quit IRC | 11:54 | |
| *** awalende has joined #openstack-nova | 11:54 | |
| *** awalende has quit IRC | 11:55 | |
| *** awalende has joined #openstack-nova | 11:56 | |
| *** awalende has joined #openstack-nova | 11:57 | |
| *** awalende has quit IRC | 11:58 | |
| *** cdent has quit IRC | 11:59 | |
| *** cdent has joined #openstack-nova | 12:04 | |
| *** dtantsur is now known as dtantsur|brb | 12:07 | |
| *** awalende has joined #openstack-nova | 12:08 | |
| *** pcaruana has quit IRC | 12:30 | |
| *** panda|lunch is now known as panda | 12:32 | |
| *** mdbooth has joined #openstack-nova | 12:41 | |
| *** artom has quit IRC | 12:42 | |
| *** pcaruana has joined #openstack-nova | 12:53 | |
| *** lbragstad has joined #openstack-nova | 12:56 | |
| *** vishakha has joined #openstack-nova | 12:57 | |
| *** mriedem has joined #openstack-nova | 12:57 | |
| *** mdbooth has quit IRC | 13:00 | |
| *** dtantsur|brb is now known as dtantsur | 13:07 | |
| *** mdbooth has joined #openstack-nova | 13:13 | |
| *** jding1__ has quit IRC | 13:16 | |
| mriedem | thoughts on a potentially less invasive fix (see inline comments) on this stein regression https://review.openstack.org/#/c/653273/ are appreciated | 13:24 |
| mriedem | i wrote the fix late last night but aren't super happy with how grossly tightly coupled all of that code is | 13:25 |
| *** mchlumsky has joined #openstack-nova | 13:26 | |
| *** awaugama has joined #openstack-nova | 13:27 | |
| sean-k-mooney | mriedem: i was talking to NewBruce about the bug they are hitting and i tink i might know how to fix it but still not clear on why its happening. im starting on a patch now. should i add you to review list when i submit | 13:32 |
| *** cdent has quit IRC | 13:36 | |
| *** cdent has joined #openstack-nova | 13:36 | |
| *** cdent has quit IRC | 13:40 | |
| sean-k-mooney | lyarwood: mriedem when ye have time can one of ye +2 +W this https://review.openstack.org/#/c/644035/ so that we use the correct upper_constratins | 13:42 |
| mriedem | sean-k-mooney: done and yes | 13:49 |
| sean-k-mooney | thanks and cool will do | 13:51 |
| *** artom has joined #openstack-nova | 13:53 | |
| mriedem | bauzas: want to hit this backport https://review.openstack.org/#/c/647911/ ? | 13:54 |
| bauzas | sure | 13:54 |
| mriedem | all of them actually since it's a gate race issue https://review.openstack.org/#/q/If966eb1161c842ff49aa530e4482dbca87b61a3e+status:open | 13:54 |
| bauzas | looking | 13:54 |
| mriedem | http://status.openstack.org/elastic-recheck/index.html#1820337 | 13:54 |
| *** mlavalle has joined #openstack-nova | 14:02 | |
| *** awalende has quit IRC | 14:06 | |
| *** awalende has joined #openstack-nova | 14:06 | |
| *** cfriesen has joined #openstack-nova | 14:08 | |
| kashyap | aspiers: Hiya...seems like I need the getDomainCapabilities() API call for Secure Boot | 14:08 |
| kashyap | aspiers: Wondering if you're planning to split it out: https://review.openstack.org/#/c/633855/11/nova/virt/libvirt/host.py@680 | 14:08 |
| aspiers | I wasn't, as per previous conversation | 14:09 |
| aspiers | but maybe that can be revisited | 14:09 |
| kashyap | aspiers: Yeah, let's revisit that conversation, plese | 14:09 |
| aspiers | Can you do me a favour and find the link to it? ;-) | 14:10 |
| kashyap | aspiers: Because, IMHO, it is not needed to tie that to SEV at all | 14:10 |
| aspiers | Maybe in that review | 14:10 |
| aspiers | I remember explicitly explaining the dependency somewhere | 14:10 |
| aspiers | Oh, that *is* the link | 14:11 |
| kashyap | Yeah :-) | 14:11 |
| aspiers | Yeah, my comment on March 19th | 14:11 |
| *** awalende_ has joined #openstack-nova | 14:11 | |
| kashyap | aspiers: Oh, I'm blind. Will read it | 14:11 |
| aspiers | :) | 14:11 |
| *** awalende has quit IRC | 14:11 | |
| kashyap | aspiers: The reason I ask is ... just now a libvirt dev was suggesting: | 14:11 |
| kashyap | "I suggest Nova queries domcapabilities first, to see if 'efi' with Secure Boot is available" | 14:12 |
| kashyap | (When implementing SB support, i.e.) | 14:12 |
| * kashyap bbiab | 14:12 | |
| *** awalende_ has quit IRC | 14:16 | |
| *** dansmith changes topic to "Current runways: https://etherpad.openstack.org/p/nova-runways-train -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 14:16 | |
| *** ChanServ sets mode: -o dansmith | 14:16 | |
| *** itlinux has joined #openstack-nova | 14:19 | |
| *** dpawlik has quit IRC | 14:19 | |
| mriedem | so we have a RESIZE_CONFIRMING task_state enum but never use it while confirming a resize https://github.com/openstack/nova/blob/e25d59078e61fe9f925dbef53dfe88e575d34dab/nova/compute/api.py#L3535 | 14:21 |
| mriedem | that seems...not good? | 14:21 |
| mriedem | unlike when reverting a resize we set the task_state in the API before casting to compute https://github.com/openstack/nova/blob/e25d59078e61fe9f925dbef53dfe88e575d34dab/nova/compute/api.py#L3515 | 14:22 |
| *** itlinux has quit IRC | 14:22 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | 14:26 |
| *** liuyulong has quit IRC | 14:27 | |
| mriedem | vdrok: mdbooth: lyarwood: more comments in https://review.openstack.org/#/c/571410/9 | 14:28 |
| *** liuyulong has joined #openstack-nova | 14:28 | |
| *** lpetrut has quit IRC | 14:28 | |
| *** cdent has joined #openstack-nova | 14:28 | |
| mriedem | i'm inclined to take a more conservative incremental approach to fixing the VERIFY_RESIZE steady state issue | 14:29 |
| mriedem | which we could also backport more safely i think | 14:29 |
| vdrok | meaning somewhat like it was done in ps7 https://review.openstack.org/#/c/571410/7/nova/virt/libvirt/driver.py | 14:31 |
| mriedem | exactly | 14:31 |
| mriedem | i'm not entirely sold on the completely ignore case like in bug 1824974 where the disk on the host is garbage and we just put our heads in the sand | 14:33 |
| openstack | bug 1824974 in OpenStack Compute (nova) "Nova Compute Manager (Resource update) fails if a disk is missing" [Low,In progress] https://launchpad.net/bugs/1824974 - Assigned to Vladyslav Drok (vdrok) | 14:33 |
| *** markvoelker has joined #openstack-nova | 14:35 | |
| *** david-lyle is now known as dklyle | 14:35 | |
| mnaser | as far as I know RDO ships upstream code | 14:39 |
| mnaser | NewBruce: I wonder if it would be a good exercise to change one of the compute nodes to log it's current highest negotiated rpc version | 14:40 |
| mnaser | and then see if for some reason it's negotiating a bad number | 14:40 |
| artom | mnaser, I believe you're right, RDO is straight up upstream | 14:41 |
| artom | Any backports we do is OSP, not RSO | 14:41 |
| artom | *RDO | 14:41 |
| *** tbachman has joined #openstack-nova | 14:42 | |
| mnaser | yeah, so RDO is upstream, OSA is upstream | 14:45 |
| *** luksky has quit IRC | 14:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make libvirt expose supported image types https://review.openstack.org/653454 | 14:47 |
| sean-k-mooney | mnaser: im currently updating unit test but i think http://paste.openstack.org/show/749431/ will fix NewBruce issue | 14:48 |
| efried | mriedem: There's no blueprint or anything for sdk-in-nova yet because up to this point we've been experimenting to see how it would work and what we can get done. I do have it on the ptg etherpads in some form. But will also try to file a bp soon. | 14:51 |
| sean-k-mooney | efried: well you can file a blueprint just as a tracker right | 14:51 |
| efried | yeah, could do. | 14:51 |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | 14:51 |
| mnaser | sean-k-mooney: that's fair, I do feel like that might be a bit of a workaround I guess :-p | 14:52 |
| efried | dustinc: How do you feel about leading that? | 14:52 |
| sean-k-mooney | efried: it does not need to have a solution atached just "sdk is a thing we should use it" | 14:52 |
| mriedem | "x exists we should use it" isn't sufficient justification imo | 14:52 |
| sean-k-mooney | mnaser: well i have not found the root casue so yes but i think we likely should make this chagne on master and backport and then see if we can create a reporducer | 14:52 |
| efried | sean-k-mooney: Part of what we've been working on is the scope too. "Plumb SDK" is one aspect; "stop using python-${service}client" is another. | 14:53 |
| sean-k-mooney | mriedem: maybe not to approve the blueprint but it enough to file it | 14:53 |
| *** jchhatbar has quit IRC | 14:53 | |
| sean-k-mooney | efried: ah ok | 14:53 |
| mriedem | sure, blueprints are free | 14:53 |
| *** jchhatbar has joined #openstack-nova | 14:54 | |
| mriedem | fixing the bugs they introduce is not | 14:54 |
| sean-k-mooney | was "stop using python-*-client" in services approved as a comunity goal by the way | 14:54 |
| mriedem | https://governance.openstack.org/tc/goals/ | 14:55 |
| efried | sean-k-mooney, mriedem: The reasoning would go something like: "We want to stop using python-${service}client => We could use ksa adapter stuff, which we've already set up, but then we would have to write do-a-thing wrappers around get/put/etc primitives => so let's use the sdk, which already has those wrappers" | 14:55 |
| sean-k-mooney | actully i guess that is a dumb question that will be decided at the fourm/ptg in 2 weeks | 14:55 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add ids to sections of flavors guide to allow deep-linking https://review.openstack.org/653458 | 14:55 |
| *** dustinc has quit IRC | 14:56 | |
| *** dustinc has joined #openstack-nova | 14:56 | |
| *** dustinc is now known as dustinc_away | 14:56 | |
| mriedem | sean-k-mooney: is that even a proposed goal for train or are you just making it up? | 14:56 |
| sean-k-mooney | efried: part of the scoping would be ensuring the sdk has the actual wrapper we need | 14:56 |
| efried | mriedem: there was a proposed goal to stop using python-${service}client for CLIs. | 14:57 |
| *** weshay is now known as weshay|rover | 14:57 | |
| mriedem | yeah, that's quite a bit different | 14:57 |
| efried | which is distantly related to this, but not really overlapping. | 14:57 |
| efried | yeah. | 14:57 |
| *** udesale has quit IRC | 14:57 | |
| sean-k-mooney | ah that is proably what im mixing it up with | 14:57 |
| sean-k-mooney | it was one of the tread i lost track of on the mailing list | 14:58 |
| efried | mriedem: anyway, the ironic team (as an example) is strongly behind the idea of ripping ironicclient out of nova | 14:58 |
| efried | so I poked at a couple of ways of doing that | 14:58 |
| *** udesale has joined #openstack-nova | 14:59 | |
| *** udesale has quit IRC | 14:59 | |
| efried | and it's about time we did *something* to break our pattern of "set up a whole KSA adapter just to grab the endpoint out of it and send that into *client which uses it to create a whole nother Adapter to do its work" | 14:59 |
| efried | which we do (in different ways!) for glance, ironic, neutron... | 14:59 |
| *** udesale has joined #openstack-nova | 14:59 | |
| mriedem | the ksa stuff in nova still feels new to me, but i'm slow and old | 15:00 |
| mriedem | and was a big improvement over the per-service config and all that | 15:00 |
| mriedem | cinder excluded since we haven't fixed that one yet | 15:01 |
| *** lpetrut has joined #openstack-nova | 15:01 | |
| gmann | mriedem: updated this with review comments. - https://review.openstack.org/#/c/603969/ | 15:01 |
| efried | mriedem: It was an improvement in the sense that operators can now use same-looking conf values for talking to the services. But internally we didn't improve much: we're still doing the dance I mentioned above --^ | 15:04 |
| efried | And, wasn't the ksa cutover in Queens? That's a pretty long time ago. Maybe just seems that way for me as it's pretty much when I first got involved in nova proper. | 15:05 |
| *** udesale has quit IRC | 15:06 | |
| mriedem | queens is still very new to me | 15:07 |
| mriedem | hell pike is as well | 15:08 |
| mriedem | if i'm still fixing bugs in ocata/pike etc it's new to me | 15:08 |
| *** dakshina-ilangov has joined #openstack-nova | 15:10 | |
| *** cdent has quit IRC | 15:11 | |
| mriedem | vdrok: just some small updates to https://review.openstack.org/#/c/571410/ | 15:16 |
| mriedem | dansmith: can you hit this backport to keep things moving https://review.openstack.org/#/c/651639/2 | 15:24 |
| mriedem | and https://review.openstack.org/#/q/If966eb1161c842ff49aa530e4482dbca87b61a3e+status:open since that's a gate issue hitting stable backports | 15:24 |
| mriedem | melwitt: can you hit these backports? https://review.openstack.org/#/q/topic:bug/1819963+(status:open+OR+status:merged)+branch:stable/rocky | 15:25 |
| cfriesen | mriedem: thanks for triaging that resize regression issue and writing the regression test. looks like Jack and I dropped the ball there. | 15:25 |
| mriedem | cfriesen: i approved the change | 15:25 |
| mriedem | i probably approved all of these busted changes | 15:25 |
| mriedem | cfriesen: please see my comment-to-self on the fix and drop your opinion on decoupling the grossitude | 15:25 |
| dansmith | mriedem: ack | 15:25 |
| cfriesen | mriedem: for sure | 15:26 |
| mriedem | cfriesen: i'll also say that as much as i don't like these regressions, i'm happy there are people in your org somewhere doing real testing | 15:26 |
| mriedem | lyarwood: can you hit this backport? https://review.openstack.org/#/c/647623/ | 15:27 |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | 15:27 |
| mriedem | gmann: ack | 15:27 |
| mriedem | vdrok: +2 thanks | 15:28 |
| mriedem | would be good to get another core on ^ since that's been around a long time | 15:28 |
| mriedem | and is very latent | 15:28 |
| mriedem | efried: ^ | 15:28 |
| lyarwood | mriedem: ack, I'll also try to get around to that bugfix again later, slightly busy downstream today. | 15:31 |
| mriedem | lyarwood: which bug fix? | 15:31 |
| *** belmoreira has quit IRC | 15:32 | |
| lyarwood | mriedem: vdrok's above | 15:32 |
| mriedem | oh ok | 15:32 |
| *** jchhatbar has quit IRC | 15:33 | |
| *** jchhatbar has joined #openstack-nova | 15:33 | |
| *** itlinux has joined #openstack-nova | 15:35 | |
| *** jchhatbar has quit IRC | 15:36 | |
| *** jchhatbar has joined #openstack-nova | 15:36 | |
| *** jchhatbar has quit IRC | 15:40 | |
| *** lpetrut has quit IRC | 15:42 | |
| *** cdent has joined #openstack-nova | 15:54 | |
| mriedem | cfriesen: i'm going with that alternative - have it locally and it's a much simpler diff | 15:57 |
| *** gyee has joined #openstack-nova | 15:58 | |
| openstackgerrit | Merged openstack/os-vif stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644035 | 16:03 |
| cfriesen | mriedem: so you're moving the last ~10 lines of _validate_flavor_image_nostatus() into another function? | 16:05 |
| mriedem | yup | 16:05 |
| aspiers | efried: run out of time for today, but I've almost finished updating the spec to talk about the new resource class rather than the existing HW_CPU_AMD_SEV trait. I'll submit another patchset tomorrow | 16:07 |
| efried | aspiers: I'm not quite caught up, did you get other cores to ack that shift in direction? | 16:07 |
| *** dims has quit IRC | 16:07 | |
| efried | mriedem: what am I looking at? https://review.openstack.org/#/c/571410/ ? | 16:07 |
| *** lpetrut has joined #openstack-nova | 16:09 | |
| cfriesen | mriedem: seems like it could work | 16:09 |
| mriedem | efried: hold on that one | 16:11 |
| efried | ack | 16:11 |
| *** ccamacho has quit IRC | 16:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix volume-backed resize with a smaller disk flavor https://review.openstack.org/653273 | 16:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update volume-backed comment in _validate_flavor_image_nostatus https://review.openstack.org/653483 | 16:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove FlavorNotFound dead code condition in API.resize https://review.openstack.org/653484 | 16:18 |
| mriedem | cfriesen: https://review.openstack.org/#/c/653273/ | 16:18 |
| *** rpittau is now known as rpittau|afk | 16:20 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add ids to sections of flavors guide to allow deep-linking https://review.openstack.org/653458 | 16:23 |
| *** dtantsur is now known as dtantsur|afk | 16:24 | |
| *** david-lyle has joined #openstack-nova | 16:24 | |
| *** igordc has joined #openstack-nova | 16:25 | |
| *** ileixe has quit IRC | 16:25 | |
| *** manjeets__ has joined #openstack-nova | 16:26 | |
| *** dklyle has quit IRC | 16:27 | |
| *** manjeets_ has quit IRC | 16:27 | |
| cfriesen | mriedem: couple comments in the review | 16:30 |
| mriedem | i'll fix those image status docstrings even though i blame you :) | 16:33 |
| cfriesen | my bad entirely. :) | 16:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix volume-backed resize with a smaller disk flavor https://review.openstack.org/653273 | 16:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update volume-backed comment in _validate_flavor_image_nostatus https://review.openstack.org/653483 | 16:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove FlavorNotFound dead code condition in API.resize https://review.openstack.org/653484 | 16:34 |
| cfriesen | mriedem: it's still a bit grody, but the underlying special-casing is complicated so I don't see a nice way to make it cleaner | 16:35 |
| *** tesseract has quit IRC | 16:40 | |
| *** idlemind has joined #openstack-nova | 16:51 | |
| *** dims has joined #openstack-nova | 16:54 | |
| *** dims has quit IRC | 16:59 | |
| *** dims has joined #openstack-nova | 17:01 | |
| *** ricolin has quit IRC | 17:04 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make libvirt expose supported image types https://review.openstack.org/653454 | 17:08 |
| *** luksky has joined #openstack-nova | 17:09 | |
| *** dakshina-ilangov has quit IRC | 17:26 | |
| *** igordc has quit IRC | 17:26 | |
| *** markvoelker has quit IRC | 17:31 | |
| *** markvoelker has joined #openstack-nova | 17:31 | |
| artom | Would there be a point in adding multinode resize tests somewhere? | 17:32 |
| artom | AFAICT currently we're only testing in in the allinone tempest-full job | 17:32 |
| artom | Which isn't super realistic... | 17:32 |
| artom | I want to try it regardless, but how I do it will depend. Either as a throwaway DNM hack, or I'll put in some minimal amount of effort | 17:33 |
| *** markvoelker has quit IRC | 17:35 | |
| *** ralonsoh has quit IRC | 17:36 | |
| *** awaugama has quit IRC | 17:39 | |
| *** awaugama has joined #openstack-nova | 17:39 | |
| *** jangutter has quit IRC | 17:39 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.openstack.org/639396 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run test_resize_server_revert in the live migration job https://review.openstack.org/653498 | 17:40 |
| artom | h4x | 17:40 |
| *** igordc has joined #openstack-nova | 17:44 | |
| *** bryan_stephenson has joined #openstack-nova | 17:52 | |
| *** ivve has quit IRC | 17:52 | |
| *** manjeets__ is now known as manjeets | 17:53 | |
| *** david-lyle is now known as dklyle | 17:55 | |
| *** tssurya has quit IRC | 17:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: DEMO: Reinstate bug 1819963 https://review.openstack.org/653503 | 18:01 |
| openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | 18:01 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Functional recreate test for bug 1819963 https://review.openstack.org/653504 | 18:01 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Update instance.availability_zone on revertResize https://review.openstack.org/653505 | 18:01 |
| efried | dammit, spelling those tags wrong didn't prevent them from posting to lp | 18:03 |
| efried | oh well, guess I might as well spell them correctly then. | 18:03 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Functional recreate test for bug 1819963 https://review.openstack.org/653504 | 18:04 |
| openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | 18:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Update instance.availability_zone on revertResize https://review.openstack.org/653505 | 18:04 |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] only update port binding if there is not an inactive binding https://review.openstack.org/653506 | 18:06 |
| sean-k-mooney | mriedem: i spent the last hour or more fighting with some of the unit test so im takeing a break form it but ^ i think will fix NewBruce issue | 18:12 |
| NewBruce | will test it out shortly | 18:12 |
| NewBruce | Thanks sean-k-mooney | 18:12 |
| sean-k-mooney | ok im going to go have dinner. ill check back later to see what the gate thinks. | 18:13 |
| *** psachin has quit IRC | 18:13 | |
| *** boxiang has quit IRC | 18:20 | |
| *** zhubx has joined #openstack-nova | 18:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: set device address tag only if setting disk unit https://review.openstack.org/611974 | 18:21 |
| *** cfriesen has quit IRC | 18:21 | |
| mriedem | melwitt: begin backport procedures | 18:21 |
| efried | mriedem: I'm setting up a demo for the summit onboarding session. I want to show adding a regression test for a bug and then fixing the bug. I want to use https://bugs.launchpad.net/nova/+bug/1819963 | 18:34 |
| openstack | Launchpad bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 18:34 |
| efried | I've got most of the setup done at this point, just have a question about the bug itself: Given that the API was masking that the instance AZ in the db doesn't match where the instance actually is, for whom is it actually a problem, and why? | 18:34 |
| mriedem | the most obvious one is filtering instances by az | 18:38 |
| mriedem | GET /servers?availability_zone=foo | 18:38 |
| mriedem | when it's really in bar | 18:38 |
| *** tbachman has quit IRC | 18:39 | |
| *** lpetrut has quit IRC | 18:41 | |
| *** lpetrut has joined #openstack-nova | 18:42 | |
| *** cfriesen has joined #openstack-nova | 18:43 | |
| *** sridharg has quit IRC | 18:48 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: libvirt: set device address tag only if setting disk unit https://review.openstack.org/653510 | 18:52 |
| *** tbachman has joined #openstack-nova | 18:55 | |
| *** vishakha has quit IRC | 18:56 | |
| mriedem | gmann: done https://review.openstack.org/#/c/603969/ | 18:56 |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: libvirt: set device address tag only if setting disk unit https://review.openstack.org/653510 | 18:57 |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: libvirt: set device address tag only if setting disk unit https://review.openstack.org/653511 | 18:59 |
| openstackgerrit | melanie witt proposed openstack/nova stable/queens: libvirt: set device address tag only if setting disk unit https://review.openstack.org/653512 | 19:00 |
| *** cdent has quit IRC | 19:04 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/pike: libvirt: set device address tag only if setting disk unit https://review.openstack.org/653514 | 19:05 |
| *** tbachman has quit IRC | 19:06 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Functional recreate test for bug 1819963 https://review.openstack.org/653504 | 19:08 |
| openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | 19:08 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DEMO: Update instance.availability_zone on revertResize https://review.openstack.org/653505 | 19:08 |
| *** keekz is now known as nicholas | 19:08 | |
| efried | mriedem: Thanks. I've done a couple of things to improve that test case ^ - lmk if you think it's worth pulling those out into a real patch. | 19:08 |
| efried | actually, the first thing - checking the db explicitly - would have only applied to the interim recreate patch. So it's just the part where we do that GET /servers?availability_zone=* query that would be added now. | 19:09 |
| *** tbachman has joined #openstack-nova | 19:12 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | 19:20 |
| gmann | mriedem: thanks. ^^ updated. | 19:21 |
| *** artom has quit IRC | 19:22 | |
| *** tbachman has quit IRC | 19:26 | |
| *** tjgresha has quit IRC | 19:33 | |
| *** tjgresha_nope has joined #openstack-nova | 19:33 | |
| *** tjgresha_nope has quit IRC | 19:40 | |
| *** lpetrut has quit IRC | 19:40 | |
| *** tjgresha has joined #openstack-nova | 19:44 | |
| *** tjgresha has quit IRC | 19:51 | |
| openstackgerrit | Merged openstack/nova master: Remove '/os-cells' REST APIs https://review.openstack.org/651291 | 20:16 |
| openstackgerrit | Merged openstack/nova master: Stop handling cells v1 in '/os-hypervisors' API https://review.openstack.org/651292 | 20:16 |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix incomplete instance data returned after build failure https://review.openstack.org/647911 | 20:29 |
| openstackgerrit | Merged openstack/nova stable/queens: Update instance.availability_zone during live migration https://review.openstack.org/647623 | 20:29 |
| *** francoisp_ has quit IRC | 20:31 | |
| *** tjgresha has joined #openstack-nova | 20:34 | |
| *** tjgresha has quit IRC | 20:39 | |
| *** francoisp has joined #openstack-nova | 20:42 | |
| *** pcaruana has quit IRC | 20:43 | |
| *** tjgresha has joined #openstack-nova | 20:54 | |
| efried | mriedem: Prior to "handle down cells", would the APIs just return failures? | 20:55 |
| *** tjgresha has quit IRC | 20:56 | |
| mriedem | efried: by default no, but it's configurable | 20:57 |
| mriedem | https://docs.openstack.org/nova/latest/admin/cells.html#handling-cell-failures | 20:57 |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] only update port binding if there is not an inactive binding https://review.openstack.org/653506 | 20:57 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#api.list_records_by_skipping_down_cells | 20:57 |
| efried | okay, so previously we would either (a) show information only for up cells, completely skipping down cells as if they weren't there; or (b) error the API call | 20:59 |
| efried | and now we (c) show partial information from the down cells | 20:59 |
| mriedem | (c) if you're using microversion >= 2.69 | 21:00 |
| *** whoami-rajat has quit IRC | 21:01 | |
| efried | ack, thx | 21:02 |
| *** awaugama has quit IRC | 21:03 | |
| *** slaweq has quit IRC | 21:17 | |
| *** slaweq has joined #openstack-nova | 21:20 | |
| openstackgerrit | sean mooney proposed openstack/nova stable/rocky: [WIP] only update port binding if there is not an inactive binding https://review.openstack.org/653609 | 21:21 |
| *** bryan_stephenson has quit IRC | 21:22 | |
| sean-k-mooney | ^ is for testing | 21:24 |
| *** slaweq has quit IRC | 21:24 | |
| *** rchurch has joined #openstack-nova | 21:24 | |
| *** mchlumsky has quit IRC | 21:29 | |
| *** logan- has quit IRC | 21:34 | |
| *** logan- has joined #openstack-nova | 21:37 | |
| *** slaweq has joined #openstack-nova | 21:41 | |
| *** slaweq has quit IRC | 21:45 | |
| *** luksky has quit IRC | 21:48 | |
| *** takashin has joined #openstack-nova | 21:50 | |
| *** slaweq has joined #openstack-nova | 21:51 | |
| *** hongbin has joined #openstack-nova | 21:52 | |
| *** slaweq has quit IRC | 21:55 | |
| mriedem | here it comes | 22:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521 | 22:02 |
| openstack | bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem) | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Add instance hard delete https://review.openstack.org/650984 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.openstack.org/638046 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.openstack.org/651650 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269 | 22:02 |
| mriedem | time to scram http://grafana.openstack.org/d/T6vSHcSik/zuul-status?orgId=1&fullscreen&panelId=3 | 22:03 |
| mriedem | btw, ^ is in a runway slot and the bottom 3 changes have a +2 on them, should be relatively easy if another core can help out | 22:04 |
| *** mriedem has quit IRC | 22:10 | |
| *** zhubx has quit IRC | 22:18 | |
| *** mlavalle has quit IRC | 22:18 | |
| *** boxiang has joined #openstack-nova | 22:19 | |
| mnaser | hmm | 22:29 |
| mnaser | is there a possible race condition around cell discover hosts? | 22:29 |
| mnaser | this is really weird | 22:29 |
| mnaser | http://logs.openstack.org/32/653532/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a2f00da/logs/ara-report/result/2a432934-7b70-491a-9571-a40e85cd15c6/ | 22:29 |
| mnaser | "Checking host mapping for compute host" repeated twice, but with the same uuid? | 22:30 |
| mnaser | the heck | 22:31 |
| mnaser | http://logs.openstack.org/32/653532/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a2f00da/logs/host/nova/nova-compute.log.txt.gz#_2019-04-17_21_52_21_727 | 22:31 |
| mnaser | http://logs.openstack.org/32/653532/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a2f00da/logs/host/nova/nova-compute.log.txt.gz#_2019-04-17_21_52_21_819 | 22:31 |
| mnaser | in the same pid.. | 22:32 |
| melwitt | are you running discover_hosts in parallel during a deployment? | 22:33 |
| *** lbragstad has quit IRC | 22:33 | |
| melwitt | https://bugs.launchpad.net/nova/+bug/1824445 | 22:34 |
| openstack | Launchpad bug 1824445 in OpenStack Compute (nova) "nova-manage cellv2 discover_hosts traces when run in parallel" [Low,In progress] - Assigned to melanie witt (melwitt) | 22:35 |
| *** lbragstad has joined #openstack-nova | 22:35 | |
| mnaser | melwitt: nope, should be once only | 22:36 |
| mnaser | but also is it normal that there is two log lines that say compute node created | 22:36 |
| mnaser | melwitt: we also delegate_to the nova-conductor host so we run it once | 22:37 |
| melwitt | I've only seen this before when the command is run in parallel presumably on different hosts | 22:39 |
| melwitt | that's not normal, it shouldn't be trying to create the host mapping for the same host twice | 22:39 |
| melwitt | I don't even get how that could happen non-parallel | 22:39 |
| mnaser | yeah.. | 22:39 |
| mnaser | and the pid is the same too | 22:40 |
| melwitt | I dunno, seems like dark magic | 22:41 |
| melwitt | hm, ok the last log is ringing a bell | 22:42 |
| melwitt | did you delete a service via the API and then not restart the nova-compute that goes with it? | 22:42 |
| melwitt | because nova-compute will only create a compute node record when it starts up, it will not recover if the compute node record gets deleted out from under it while it's running | 22:43 |
| mnaser | we don't delete anything afaik :\ | 22:46 |
| mnaser | during the CI run at least | 22:46 |
| melwitt | ok. I don't see how that would be related to the discover_hosts thing anyway if it were happening | 22:46 |
| mnaser | https://github.com/openstack/openstack-ansible-os_nova/blob/d1aa5839b482c7412404ebb7bf050ee806fbf281/tasks/main.yml#L233-L243 | 22:48 |
| melwitt | mnaser: oh, sorry, I see now it's saying Checking first and then Creating, so that's probably normal | 22:48 |
| mnaser | oh oops | 22:48 |
| melwitt | I thought it was the same message twice but it's not | 22:48 |
| mnaser | you're right yes | 22:49 |
| mnaser | "Compute node record created" is just once | 22:49 |
| melwitt | but the duplicate, I've only seen that when one nova-manage is racing against another. do you have the discover_hosts scheduler periodic enabled? | 22:49 |
| *** tbachman has joined #openstack-nova | 22:49 | |
| mnaser | I think we enable that based on something | 22:49 |
| mnaser | one sec | 22:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.openstack.org/643664 | 22:49 |
| melwitt | that's another possibility, if you were unlucky enough to have that fire at the same time as another scheduler, or if you were to run 'nova-manage cellv2 discover_hosts' at the same time a scheduler periodic discover_hosts fires | 22:50 |
| mnaser | scheduler.discover_hosts_in_cells_interval = 60 | 22:50 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899 | 22:50 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899 | 22:51 |
| mnaser | does discover_hosts run in the conductor I assume? | 22:51 |
| melwitt | ok, and is that set on all schedulers or just one? (recommendation is to enable it on only one) see https://review.openstack.org/651947 | 22:51 |
| melwitt | scheduler | 22:51 |
| mnaser | http://logs.openstack.org/32/653532/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a2f00da/logs/host/nova/nova-scheduler.log.txt.gz#_2019-04-17_21_52_03_776 | 22:52 |
| mnaser | yeah its around the same time | 22:52 |
| mnaser | we have it enabled on all hosts :X | 22:52 |
| melwitt | ok. yeah, I don't think we knew this was going to be a potential problem, or at least I didn't know | 22:53 |
| mnaser | I mean its the first time I see this | 22:53 |
| mnaser | but at least we kno wwhy | 22:53 |
| melwitt | the trace isn't harmful, it just means discover_hosts collided with another one | 22:53 |
| melwitt | so the patch I linked earlier aims to warn and give guidance instead of tracing | 22:53 |
| mnaser | yeah that would be good because the ansible obviously fails when it sees that | 22:54 |
| mnaser | so that would be good to know | 22:54 |
| melwitt | commit message explains why to do that too vs ignore DBDuplicateEntry | 22:54 |
| mnaser | neat | 22:54 |
| melwitt | oh it does? how do yall do discover_hosts? keep running until you receive status code 0? that's what tripleo does | 22:54 |
| *** tkajinam has joined #openstack-nova | 22:54 | |
| melwitt | the status code is a little weird on that command where non-zero means "there's more work to do" and zero means "I'm done" | 22:55 |
| melwitt | and I think that's the review feedback I got on that patch currently is to enhance the doc to explain that | 22:55 |
| openstackgerrit | Merged openstack/nova master: Stop handling cells v1 in '/os-servers' API https://review.openstack.org/651293 | 22:57 |
| openstackgerrit | Merged openstack/nova stable/rocky: Add functional recreate test for bug 1819963 https://review.openstack.org/648409 | 22:57 |
| openstack | bug 1819963 in OpenStack Compute (nova) rocky "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | 22:57 |
| openstackgerrit | Merged openstack/nova stable/rocky: Update instance.availability_zone on revertResize https://review.openstack.org/648410 | 22:57 |
| mnaser | melwitt: we run discover_hosts every time once only on one of the conductors | 22:57 |
| mnaser | I didn't know discover_hosts does work in batches | 22:58 |
| melwitt | oh, so always expect to receive 0 | 22:58 |
| melwitt | I don't think it does. tripleo retries everything | 22:58 |
| mnaser | https://github.com/openstack/openstack-ansible-os_nova/blob/d1aa5839b482c7412404ebb7bf050ee806fbf281/tasks/nova_db_post_setup.yml#L21-L26 | 22:58 |
| *** zigo has quit IRC | 22:58 | |
| mnaser | ya I try to avoid, uh, brute forcing stuff :p | 22:59 |
| melwitt | yeah it doesn't batch. it's just that non-zero means "I couldn't do the work I needed to do" | 22:59 |
| melwitt | ok... so this will be a problem. we had been thinking to still return 1 if a collision happens i.e. not change the behavior | 23:00 |
| mnaser | right, we can adapt our tasks easily then | 23:00 |
| melwitt | but if you happen to run it while your scheduler does a discover_hosts, you will get a fail status code | 23:00 |
| mnaser | yeah, our case is not parallel but racing with scheduler | 23:00 |
| melwitt | yeah | 23:01 |
| melwitt | ok, well if you want/need different behavior than is currently proposed, please add a comment on the patch review | 23:01 |
| mnaser | ill add comments that we hit this | 23:02 |
| melwitt | example: specific non-zero code that means "collision detected" | 23:02 |
| melwitt | ok | 23:02 |
| mnaser | melwitt: let a comment, danke :) | 23:05 |
| melwitt | kewl | 23:06 |
| *** igordc has quit IRC | 23:21 | |
| *** itlinux has quit IRC | 23:26 | |
| *** tosky has quit IRC | 23:38 | |
| *** hongbin has quit IRC | 23:38 | |
| *** itlinux has joined #openstack-nova | 23:43 | |
| *** itlinux has quit IRC | 23:44 | |
| *** artom has joined #openstack-nova | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!