Monday, 2019-04-08

*** tbachman has joined #openstack-nova00:09
*** tetsuro has joined #openstack-nova00:10
*** tetsuro has quit IRC00:14
*** tetsuro has joined #openstack-nova00:17
*** markvoelker has joined #openstack-nova00:42
*** tetsuro has quit IRC00:43
*** markvoelker has quit IRC00:44
*** markvoelker has joined #openstack-nova00:45
*** tetsuro has joined #openstack-nova00:50
*** gbarros has quit IRC00:51
*** stakeda has joined #openstack-nova00:53
*** yaawang has quit IRC00:56
*** yaawang has joined #openstack-nova00:58
*** ricolin has joined #openstack-nova01:00
openstackgerritBhagyashri Shewale proposed openstack/nova master: WIP: Ignore root_gb for BFV in simple tenant usage API  https://review.openstack.org/61262601:05
*** tetsuro has quit IRC01:17
*** tetsuro_ has joined #openstack-nova01:17
*** whoami-rajat has joined #openstack-nova01:19
*** tetsuro_ has quit IRC01:20
*** tetsuro has joined #openstack-nova01:20
openstackgerritTakashi NATSUME proposed openstack/nova stable/stein: doc: Capitalize keystone domain name  https://review.openstack.org/65060001:23
*** tetsuro has quit IRC01:23
*** tetsuro has joined #openstack-nova01:24
*** tetsuro has quit IRC01:29
*** tiendc has joined #openstack-nova01:31
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: doc: Capitalize keystone domain name  https://review.openstack.org/65060101:32
*** tetsuro has joined #openstack-nova01:34
*** tetsuro has quit IRC01:42
*** tetsuro has joined #openstack-nova01:43
*** irclogbot_1 has quit IRC01:44
*** edmondsw_ has quit IRC01:48
*** edleafe has quit IRC01:48
*** Dinesh_Bhor has joined #openstack-nova01:57
*** brinzhang has joined #openstack-nova02:14
*** yaawang has quit IRC02:28
*** yaawang has joined #openstack-nova02:30
openstackgerritMerged openstack/nova stable/queens: prevent common kwargs from glance client failure  https://review.openstack.org/65006502:49
*** ircuser-1 has quit IRC02:49
*** ileixe has joined #openstack-nova02:53
ileixeHi, guys.02:55
ileixeI wonder what's best practice to integrate custom code with Nova.02:56
ileixeSince there is deprecated sign for API like hook / extension which can be builiding block for custom code.02:56
ileixeHow can admin achieve their own busineess logic with VM lifecycle? For example, when VM created, add related metadata to CMDB.02:57
ileixeWe've been used notification events before, I realized it's quite unstable and unexpectable..02:58
*** Nel1x has quit IRC03:02
*** udesale has joined #openstack-nova03:04
*** psachin has joined #openstack-nova03:20
*** Nel1x has joined #openstack-nova03:21
*** lpetrut has joined #openstack-nova03:49
*** psachin has quit IRC03:51
*** imacdonn_ has quit IRC04:02
*** imacdonn_ has joined #openstack-nova04:02
*** Nel1x has quit IRC04:10
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.openstack.org/60395504:15
*** lpetrut has quit IRC04:21
*** ratailor has joined #openstack-nova04:33
*** _alastor_ has joined #openstack-nova04:36
*** pcaruana has joined #openstack-nova04:49
*** pcaruana has quit IRC04:55
*** sidx64 has joined #openstack-nova04:56
*** sidx64 has quit IRC05:00
*** sidx64 has joined #openstack-nova05:02
*** Luzi has joined #openstack-nova05:49
*** bhagyashris_ has joined #openstack-nova05:49
openstackgerritBoxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule  https://review.openstack.org/64995305:50
*** _alastor_ has quit IRC05:55
*** phasespace has quit IRC06:01
*** jaosorior has joined #openstack-nova06:05
*** lpetrut has joined #openstack-nova06:08
*** sridharg has joined #openstack-nova06:13
*** sapd1_x has joined #openstack-nova06:15
*** pcaruana has joined #openstack-nova06:30
openstackgerritBoxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group  https://review.openstack.org/64996306:36
openstackgerritzhufl proposed openstack/nova master: Remove query_client from resource_tracker  https://review.openstack.org/65061606:38
*** zhubx has joined #openstack-nova06:38
*** zhubx has quit IRC06:39
*** zhubx has joined #openstack-nova06:40
*** ivve has joined #openstack-nova06:42
*** markvoelker has quit IRC06:43
*** dpawlik has joined #openstack-nova06:45
*** zhubx has quit IRC06:47
*** zhubx has joined #openstack-nova06:48
*** zhubx has quit IRC06:49
*** boxiang has joined #openstack-nova06:49
*** slaweq has joined #openstack-nova06:53
*** slaweq has quit IRC06:56
*** slaweq has joined #openstack-nova07:01
openstackgerritKunpeng Zhang proposed openstack/nova master: Enhance live-migration progress log for memory  https://review.openstack.org/65062107:03
openstackgerritTushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP  https://review.openstack.org/65018807:09
*** awalende has joined #openstack-nova07:10
openstackgerritKunpeng Zhang proposed openstack/nova master: Enhance live-migration progress log for memory  https://review.openstack.org/65062107:13
*** tesseract has joined #openstack-nova07:13
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: doc: Fix openstack CLI command  https://review.openstack.org/64842507:14
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command  https://review.openstack.org/63706007:15
*** awalende has quit IRC07:19
*** tosky has joined #openstack-nova07:19
*** phasespace has joined #openstack-nova07:19
*** awalende has joined #openstack-nova07:20
*** awalende has quit IRC07:24
*** awalende has joined #openstack-nova07:24
gibi_offileixe: have you reported the problems regarding notifications as bugs? I encurage you to try versioned notifications and report any bugs. Also feel free to ping me if you have questions07:28
*** gibi_off is now known as gibi07:28
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances  https://review.openstack.org/62776507:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation  https://review.openstack.org/64978807:31
ileixegibi: I think I do not choose right word to express my situation. Notification itself is not a problem. What I felt hard is whenver I have small hooking logic, there were too many things to be considered. (e.g. We have to deploy ceilometer for consumer, gnocchi for publisher, aodh for alarm. And even there is no exact API to hook the event)07:34
*** ralonsoh has joined #openstack-nova07:35
ileixeI felt like I'm on the wrong track. T_T07:35
*** igordc has quit IRC07:36
gibiileixe: have you considered simply listening on the notification (or versioned_notification) topic on the message bus? that needs credentials to the message bus but if you can have that then it is couple of lines of code to subscribe to the topic and get the events07:37
ileixeYes acutally we're done to make our 3rd party component to listen messaging07:37
gibiin this case you dont need ceilometer and aodh to interface with your CMDB07:39
ileixebut I thought it's also not a right solution since we have to track messaging format/every event type (I mean unexpectable in this siutation).07:39
*** awalende has quit IRC07:39
ileixeYep..07:39
ileixeSo my question is how others deal with this problem.07:40
gibiileixe: versioned notifications have a well defined format and proper versioning. Have you see the doc https://docs.openstack.org/nova/latest/reference/notifications.html#existing-versioned-notifications ?07:42
*** awalende has joined #openstack-nova07:42
gibiI cannot say how others deal with this, but I think versioned notificatons are capable of solving your problem and if you have feedback how to make them better then that feedback is very much appreciated07:43
*** luksky has joined #openstack-nova07:46
*** helenafm has joined #openstack-nova07:47
*** elod_off is now known as elod07:48
*** rpittau|afk is now known as rpittau07:48
ileixegibi: Thanks, gibi. It's worth to listen your view since I felt maybe I'm not going the wrong way. I will feedback you when I have an better idea to solve the problem.07:49
gibiileixe: feel free to ping me07:49
*** jangutter has joined #openstack-nova07:49
ileixe:)07:49
*** helenafm has quit IRC07:52
*** tssurya has joined #openstack-nova07:59
*** tkajinam has quit IRC08:11
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728908:17
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data  https://review.openstack.org/40751408:17
*** rcernin has quit IRC08:19
*** tetsuro has quit IRC08:20
openstackgerritBoxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule  https://review.openstack.org/64995308:25
*** tetsuro has joined #openstack-nova08:25
*** ccamacho has joined #openstack-nova08:28
openstackgerritBoxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group  https://review.openstack.org/64996308:33
*** derekh has joined #openstack-nova08:33
*** dtantsur|afk is now known as dtantsur08:35
*** sapd1_x has quit IRC08:39
*** markvoelker has joined #openstack-nova08:45
*** zigo_ has joined #openstack-nova08:46
*** zigo_ is now known as zigo08:50
*** tetsuro has quit IRC08:54
*** tetsuro has joined #openstack-nova08:58
*** sidx64 has quit IRC09:10
*** ttsiouts has joined #openstack-nova09:11
openstackgerritAdrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support  https://review.openstack.org/62011509:11
*** tobberydberg has quit IRC09:12
*** sidx64 has joined #openstack-nova09:13
*** tuchopaw has joined #openstack-nova09:18
*** markvoelker has quit IRC09:18
*** zkzmmrc has joined #openstack-nova09:18
*** kuzmlmar has joined #openstack-nova09:19
*** tuchopaw has quit IRC09:19
*** tobberydberg has joined #openstack-nova09:24
openstackgerritMerged openstack/nova master: Do not log a warning about not using compute monitors  https://review.openstack.org/65009209:36
*** cdent has joined #openstack-nova09:39
*** finucannot is now known as stephenfin09:40
kashyapstephenfin: When you get a moment, an rST question: in this rendering: http://logs.openstack.org/14/645814/2/check/openstack-tox-docs/0e76299/html/specs/train/approved/cpu-selection-with-hypervisor-consideration.html09:42
kashyapstephenfin: ... I don't like how the words "or" and "type" are highlighted in the two tables.  (Probably because they're rendered as code blocks.)09:43
kashyapAny ideas to address that?09:43
openstackgerritKashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec  https://review.openstack.org/64581409:45
*** davidsha has joined #openstack-nova09:57
*** stakeda has quit IRC10:00
stephenfinIt's trying to guess the syntax. You can do '.. code-block:: none' before it (instead of '::') to override that, I would say10:00
kashyapOh right!10:02
kashyapstephenfin: I recall the 'none' thingie.  Good idea.10:02
kashyapThanks :-)10:02
stephenfinkashyap: Actually, looks like Sphinx can render complex tables like those. Left comment inline10:03
* kashyap goes to read10:03
kashyapOh, yeah.  I recalled the "+" syntax.  Wonderful rST + Sphinx.  Endless joy :-)10:04
* kashyap goes to tinker10:04
*** kuzmlmar has quit IRC10:04
*** zkzmmrc has quit IRC10:04
kashyapstephenfin: Okay, even with '+', the words "or" and "type" are highlighted in the rendering.10:12
kashyap(NB: Rendering was not the problem;  with +, it rendering was equivalent to the one before.)10:12
* kashyap tries '.. code-block:: none'10:12
stephenfinkashyap: If you switch that to '+', you can dedent it and remove the '::' or '.. code-block'10:13
*** sean-k-mooney has joined #openstack-nova10:13
stephenfinso it'll render as a table instead of a code block10:13
kashyapAh-ha, so after switching it required 'dedenting'...10:14
stephenfinYeah, sorry, I wasn't clear10:14
stephenfinThe reason it's indented is so it'll render as code because I didn't think docutils would handle complex tables like that, but it turns out it can10:15
stephenfinand with gusto, no less10:15
kashyap(No problem.)10:15
kashyapHehe, noted.10:15
*** markvoelker has joined #openstack-nova10:16
*** ttsiouts has quit IRC10:17
openstackgerritBhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API  https://review.openstack.org/61262610:17
*** ttsiouts has joined #openstack-nova10:17
*** bhagyashris_ has quit IRC10:18
*** ttsiouts_ has joined #openstack-nova10:20
cdent"with gusto"10:22
*** ttsiouts has quit IRC10:22
kashyapstephenfin: Hmm, so with "+" (de-dendeted, and no '::' or '.. code-block'), the table rendering is "naked": https://kashyapc.fedorapeople.org/Plain-rendering-of-table-Sphinx.png10:24
kashyap(Assuming if you can even spot the table :D)10:24
* kashyap now tries the '.. code-block:: none'10:26
sean-k-mooneyo/10:26
*** ttsiouts_ has quit IRC10:31
sean-k-mooneystephenfin: efried: gibi: jaypipes: ill send a email about this later but https://review.openstack.org/#/c/650573/ as an fyi i finished setting up my thirdparty ci over the weekend so we have limited capastity to trigger some dpdk and pinning testing manually now.10:31
*** ttsiouts has joined #openstack-nova10:32
*** priteau has joined #openstack-nova10:32
sean-k-mooneyif people comment "seans-nfv-ci: recheck" or "check experimental" on any patch to nova,neutron,os-vif,networking-ovs-dpdk or devstack then it will run10:33
stephenfinsounds good to me10:34
sean-k-mooneyi currently have two singel node jobs running for nova one that tests ovs-dpdk(with hugepages) and another that tests numa+cpu pinning+realtime10:34
sean-k-mooneyim going to convert them to multinode jobs so that migration/resize tests run and add a whitbox plugin job too i think.10:36
*** sidx64 has quit IRC10:36
*** ttsiouts has quit IRC10:36
sean-k-mooneyi also need to enable more tests. ill proably change the trigger to run atomatically once i come up with a sutible file ignore list but i am going to see if i can run some of these test upstream too in the future.10:38
*** sidx64 has joined #openstack-nova10:39
*** tbachman has quit IRC10:49
*** markvoelker has quit IRC10:49
*** tiendc has quit IRC10:55
efriedsean-k-mooney: nice!10:55
*** zkzmmrc has joined #openstack-nova10:57
*** kuzmlmar has joined #openstack-nova10:57
openstackgerritEric Fried proposed openstack/nova-specs master: Re-propose detach root volume spec  https://review.openstack.org/65058011:03
*** sridharg has quit IRC11:04
*** sridharg has joined #openstack-nova11:06
*** udesale has quit IRC11:08
openstackgerritEric Fried proposed openstack/nova-specs master: Re-propose volume backed server rebuild  https://review.openstack.org/65058211:08
*** udesale has joined #openstack-nova11:09
*** ttsiouts has joined #openstack-nova11:13
*** markvoelker has joined #openstack-nova11:15
*** Luzi has quit IRC11:15
openstackgerritEric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string'  https://review.openstack.org/65037011:19
*** sidx64 has quit IRC11:20
*** dtantsur is now known as dtantsur|brb11:20
openstackgerritMerged openstack/nova-specs master: Re-propose detach root volume spec  https://review.openstack.org/65058011:20
openstackgerritMerged openstack/nova-specs master: Re-propose volume backed server rebuild  https://review.openstack.org/65058211:24
*** mvkr has quit IRC11:34
kashyapsean-k-mooney: sfinucan: Remind me again: why are we messing with VNC whe configuring live migration here: http://git.openstack.org/cgit/openstack/nova/tree/doc/source/admin/configuring-migrations.rst11:38
*** bbowen has joined #openstack-nova11:38
sean-k-mooney kashyap by default our install guides did not used to tell people to make vnc listen to 0.0.0.0 i think11:40
sean-k-mooneyas a result if you live migrated without haveing mand that change the console would not work on the new host11:40
sean-k-mooneyas it defaulted to listening to on the ip of the source host and we dont update that in the libvirt xml on migration11:41
sean-k-mooneyso the vnc consle woudl try to bind to a tcp port on a ip that is not on the dstionation and fail11:41
kashyapAh, I see.  I think we should spell that reasoning out in the doc.  (I'll send a patch with "Thanks: Sean Mooney")11:43
*** sridharg has quit IRC11:43
sean-k-mooneywell it says "You must not make the VNC server listen to the IP address of its compute11:43
sean-k-mooney     host, since that addresses changes when the instance is migrated.11:43
sean-k-mooney"11:43
sean-k-mooneybut ya it could be clearer11:44
lyarwoodsean-k-mooney / kashyap ; isn't that out of date now given https://github.com/openstack/nova/blob/65874326404717b58ce4927c21d3502d7e53022b/nova/virt/libvirt/migration.py#L8411:45
kashyapsean-k-mooney: Yeah, the meaning is implicit.  But it can definitely be clearer11:45
* kashyap clicks11:45
lyarwoodI thought we did update the listen address now11:45
sean-k-mooney we do according to that code11:46
sean-k-mooneyso its nolonger requried but it might be desirable anyway11:46
sean-k-mooneyit may not be11:46
sean-k-mooneywhen was that added11:46
sean-k-mooney3 years ago11:47
sean-k-mooneythere is a slight change that the dock is out dated11:47
*** sridharg has joined #openstack-nova11:47
*** pcaruana has quit IRC11:47
kashyapYeah, definitely making sure that is set does not hurt.11:48
kashyaplyarwood: Thanks for the pointer11:48
*** sidx64 has joined #openstack-nova11:55
kashyapsean-k-mooney: Do we always go through VNC proxy?11:56
sean-k-mooneytechnically you can connect directly but typically an enduser will always connect via the vnc proxy11:57
sean-k-mooneywe do not want endusers connecting directly to the hyperviors11:57
sean-k-mooneyhost11:57
*** derekh has quit IRC11:58
*** nicolasbock has joined #openstack-nova12:00
*** brinzhang has quit IRC12:01
*** priteau has quit IRC12:01
kashyapNod; also how about security?  Isn't _always_ listening on 0.0.0.0 insecure?12:02
sean-k-mooneyyes which is why the note is present in the doc.12:03
kashyapWhich note?  /me reads12:03
kashyapAh, this one:12:03
kashyapSince this setting allows VNC clients from any IP address to connect to instance consoles, you must take additional measures like secure networks or firewalls to prevent potential attackers from gaining access to instances.12:03
*** kuzmlmar has quit IRC12:03
*** zkzmmrc has quit IRC12:03
sean-k-mooneyyes12:03
kashyapOkay, thanks again :-)12:04
*** edmondsw has joined #openstack-nova12:04
*** mgariepy has joined #openstack-nova12:11
*** gbarros has joined #openstack-nova12:12
jaypipessean-k-mooney: cool, thanks :)12:21
*** tetsuro has quit IRC12:24
*** zkzmmrc has joined #openstack-nova12:29
*** kuzmlmar has joined #openstack-nova12:29
*** mvkr has joined #openstack-nova12:29
*** tbachman has joined #openstack-nova12:34
*** mchlumsky has joined #openstack-nova12:37
*** mdbooth has quit IRC12:37
*** pcaruana has joined #openstack-nova12:38
*** mchlumsky has quit IRC12:41
*** mrjk has quit IRC12:41
*** mchlumsky has joined #openstack-nova12:42
*** mdbooth has joined #openstack-nova12:44
*** edleafe has joined #openstack-nova12:44
*** ttsiouts has quit IRC12:44
*** ttsiouts has joined #openstack-nova12:45
*** mmethot has joined #openstack-nova12:45
*** dtantsur|brb is now known as dtantsur12:47
*** Luzi has joined #openstack-nova12:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object  https://review.openstack.org/64953412:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement  https://review.openstack.org/64953512:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: WIP: Add get_compute_nodes_by_host_or_node()  https://review.openstack.org/65087712:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree  https://review.openstack.org/65087812:48
*** needssleep is now known as TheJulia12:49
openstackgerritFrançois Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces  https://review.openstack.org/64812312:49
*** derekh has joined #openstack-nova12:50
*** jroll has quit IRC12:50
*** ttsiouts has quit IRC12:50
*** jroll has joined #openstack-nova12:50
*** zkzmmrc has quit IRC12:51
*** kuzmlmar has quit IRC12:51
*** ratailor has quit IRC12:52
*** awalende has quit IRC12:59
*** awalende has joined #openstack-nova12:59
*** ab-a has joined #openstack-nova13:03
*** awalende has quit IRC13:04
*** amodi has quit IRC13:06
*** ttsiouts has joined #openstack-nova13:06
*** lbragstad has joined #openstack-nova13:08
mnaserhttps://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/db/sqlalchemy/api.py#L5508-L553713:10
mnaserso max rows isn't really max rows.. its scanning a full table13:10
*** sidx64 has quit IRC13:24
*** owalsh has quit IRC13:26
*** whoami-rajat has quit IRC13:28
*** mrjk has joined #openstack-nova13:28
*** owalsh has joined #openstack-nova13:29
openstackgerritStephen Finucane proposed openstack/python-novaclient stable/stein: Revert "Fix crashing console-log"  https://review.openstack.org/65036313:29
openstackgerritStephen Finucane proposed openstack/python-novaclient stable/rocky: Revert "Fix crashing console-log"  https://review.openstack.org/65036413:29
*** pcaruana has quit IRC13:31
*** pcaruana has joined #openstack-nova13:36
*** whoami-rajat has joined #openstack-nova13:39
*** liuyulong has joined #openstack-nova13:41
sean-k-mooneycdent: jaypipes dansmith  thanks for your feedback on https://review.openstack.org/#/c/647578/2/specs/train/approved/image-metadata-prefiltering.rst by the way. im gong to rework the spec with your changes today13:41
openstackgerritBoris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train  https://review.openstack.org/64199413:46
openstackgerritBoris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train  https://review.openstack.org/64199413:50
*** mriedem has joined #openstack-nova13:50
*** eharney has joined #openstack-nova13:52
*** jmlowe has quit IRC13:52
*** tetsuro has joined #openstack-nova13:58
*** phasespace has quit IRC14:02
*** awaugama has joined #openstack-nova14:03
*** lpetrut has quit IRC14:09
*** kaisers_ has joined #openstack-nova14:10
*** tetsuro_ has joined #openstack-nova14:12
*** dpawlik has quit IRC14:13
*** tetsuro has quit IRC14:14
*** tetsuro_ has quit IRC14:17
*** mlavalle has joined #openstack-nova14:22
*** amodi has joined #openstack-nova14:24
*** spotz has joined #openstack-nova14:27
*** jmlowe has joined #openstack-nova14:28
*** ivve has quit IRC14:32
*** Luzi has quit IRC14:32
*** kaisers_ is now known as kaisers_away14:36
*** belmoreira has joined #openstack-nova14:42
*** mchlumsky has quit IRC14:43
*** mchlumsky has joined #openstack-nova14:46
*** lbragstad has quit IRC14:46
*** lbragstad has joined #openstack-nova14:47
*** belmorei_ has joined #openstack-nova14:48
*** belmoreira has quit IRC14:52
*** cfriesen has joined #openstack-nova14:54
*** kaisers_away is now known as kaisers_14:54
*** boxiang has quit IRC14:55
*** boxiang has joined #openstack-nova14:55
*** tbachman has quit IRC14:56
*** sidx64 has joined #openstack-nova14:59
*** cfriesen has quit IRC14:59
*** efried has quit IRC15:03
*** tbachman has joined #openstack-nova15:07
*** avolkov has quit IRC15:11
*** efried has joined #openstack-nova15:12
*** burt has quit IRC15:14
*** sidx64 has quit IRC15:14
*** gbarros has quit IRC15:14
*** N3l1x has joined #openstack-nova15:15
*** burt has joined #openstack-nova15:15
*** gbarros has joined #openstack-nova15:15
*** phasespace has joined #openstack-nova15:16
*** gbarros has quit IRC15:17
*** luksky has quit IRC15:18
*** gyee has joined #openstack-nova15:20
*** ttsiouts has quit IRC15:25
*** ttsiouts has joined #openstack-nova15:26
*** tbachman has quit IRC15:26
*** ttsiouts has quit IRC15:30
*** ttsiouts has joined #openstack-nova15:31
*** takashin has quit IRC15:33
*** itlinux_ has quit IRC15:33
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Do not log a warning about not using compute monitors  https://review.openstack.org/65092915:35
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: libvirt: disconnect volume when encryption fails  https://review.openstack.org/65093115:36
*** Sundar has joined #openstack-nova15:43
*** sidx64 has joined #openstack-nova15:44
*** gbarros has joined #openstack-nova15:48
*** gbarros has quit IRC15:50
*** dave-mccowan has joined #openstack-nova15:50
*** sidx64_ has joined #openstack-nova15:51
*** sidx64 has quit IRC15:51
*** sidx64_ has quit IRC15:53
*** tbachman has joined #openstack-nova15:54
*** sidx64 has joined #openstack-nova15:55
*** mlavalle has quit IRC15:56
*** gbarros has joined #openstack-nova15:56
*** kaisers_ is now known as kaisers_away15:57
*** mlavalle has joined #openstack-nova15:57
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370  https://review.openstack.org/65042415:58
openstackbug 1823370 in OpenStack Compute (nova) "Evacuations are not restricted to the source cell during scheduling" [Medium,In progress] https://launchpad.net/bugs/1823370 - Assigned to Matt Riedemann (mriedem)15:58
openstackgerritMatt Riedemann proposed openstack/nova master: Restrict RequestSpec to cell when evacuating  https://review.openstack.org/65042915:58
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Use RequestSpec.requested_destination when rebuilding with new image  https://review.openstack.org/65037615:58
*** tssurya has quit IRC15:59
*** kaisers_away is now known as kaisers_16:00
*** kaisers_ is now known as kaisers_away16:00
*** belmorei_ has quit IRC16:01
openstackgerritsean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering  https://review.openstack.org/64757816:05
*** liuyulong is now known as liuyulong|away16:07
*** igordc has joined #openstack-nova16:07
efriedgibi: Who creates the bw RPs? Nova or neutron?16:09
openstackgerritKashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.openstack.org/64203016:09
*** Sundar has quit IRC16:09
mriedemefried: neutron16:10
efriedthanks16:10
mriedemhttps://docs.openstack.org/neutron/latest/admin/config-qos-min-bw.html16:10
kashyapsean-k-mooney: When you get a moment this week, can you please give the latest iteration a "once-over" -- https://review.openstack.org/#/c/642030/5/specs/train/approved/cpu-model-selection.rst16:10
*** belmoreira has joined #openstack-nova16:11
*** ccamacho has quit IRC16:11
kashyapjackding: ^ You originally proposed it; I made some adjustments.  Might want to take a look at it.16:11
*** igordc has quit IRC16:12
kashyapI noticed a few mistakes in the code, which led me to look at the spec, one thing leads to another ... and suddenly I "inherited" the above spec :D16:13
*** _alastor_ has joined #openstack-nova16:14
*** IvensZambrano has joined #openstack-nova16:14
*** tbachman has quit IRC16:14
*** ttsiouts has quit IRC16:14
*** belmoreira has quit IRC16:16
*** igordc has joined #openstack-nova16:16
*** erlon has joined #openstack-nova16:16
*** manjeets has joined #openstack-nova16:22
*** ircuser-1 has joined #openstack-nova16:26
*** sidx64 has quit IRC16:27
*** dtantsur is now known as dtantsur|afk16:27
*** itlinux has joined #openstack-nova16:28
*** davidsha has quit IRC16:29
stephenfinlyarwood: Mind taking a look at these if you're still about? https://review.openstack.org/650363 https://review.openstack.org/65036416:29
lyarwoodstephenfin: yarp, I'll take a look before I leave16:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations  https://review.openstack.org/63795416:33
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795516:33
stephenfindansmith, jaypipes: Briefly, do you recall any previous examples of us removing a model/table from 'nova/db/sqlalchemy/models.py'. I assume I need a migration?16:33
stephenfinonly example I can see 0951cf3d194edbee213673a525c1291245958264. I assume that's mostly all there is to it?16:33
stephenfin(context is that I want to remove 'nova.db.sqlalchemy.models.Cell' without having the tests b**** at me)16:34
sean-k-mooneystephenfin: quick question16:35
sean-k-mooneyhttp://logs.openstack.org/78/647578/3/check/openstack-tox-docs/38e7bf6/job-output.txt.gz#_2019-04-08_16_20_39_533258 this fails in the gate.16:35
sean-k-mooneyi know how to fix it16:35
sean-k-mooneybut i get the same error locally but the tox command succeeded16:35
stephenfinsean-k-mooney: The gate doesn't run 'tox -e releasenotes', instead calling 'sphinx-build' directly16:36
sean-k-mooneyyou mean it does not run tox -e docs16:36
stephenfinSorry, yeah16:36
*** kaisers_away is now known as kaisers_16:36
sean-k-mooneyok why does the gate not do that16:37
*** kaisers_ is now known as kaisers_away16:37
stephenfinSo I'd say the 'sphinx-build' call in 'tox.ini' is missing a '-W' flag16:37
sean-k-mooneyah16:37
sean-k-mooneyok16:37
sean-k-mooneyany reason i should not fix that in a seperate patch?16:38
stephenfinsean-k-mooney: mordred et al. would have the full context, but I suspect it was to ensure documentation was reproducible. Some projects (including us) use the 'docs' target to do more than simply call 'sphinx-build'16:38
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Avoid using os-brick encryptors when device_path isn't provided  https://review.openstack.org/64995116:38
sean-k-mooneyits really unititive for the docs tox env to pass but the docs job to fail16:38
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing  https://review.openstack.org/63795316:39
stephenfinsean-k-mooney: I _think_ there was a patch from Takashi that fixed that but if not, you should add it, yes16:39
openstackgerritBalazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations  https://review.openstack.org/63795416:39
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795516:39
lyarwoodstephenfin: so regarding the novaclient backports, I'm not even sure that stable/stein is open at the moment16:39
* lyarwood checks ML16:39
sean-k-mooneystephenfin: ok ill look for Takashi's patch and if i dont find it ill add one16:40
*** rpittau is now known as rpittau|afk16:40
mordredstephenfin: I didnm't do it16:40
* mordred reading16:40
mriedemlyarwood: it's not, final release is wednesday16:40
sean-k-mooneymordred: i was just confused by why the docs job on the nova-spec repo did not use the docs tox env16:41
sean-k-mooneythe docs tox env does not treat warnings as errors so i was confused by why it "passed" locally but failed in the gate16:41
stephenfinmriedem, lyarwood: Ah, so any backports to stable/rocky must wait for stable/stein to open first, I guess?16:41
mordredstephenfin: actualy - I believe the gate now runs tox -edocs ... it might be hysterical raisins that nova-specs is using an old job?16:41
lyarwoodYeah I believe so16:41
mordredsean-k-mooney: ^^16:42
mordredstephenfin, sean-k-mooney: the job you want is "openstack-tox-docs"16:42
sean-k-mooneymordred: i can check the gate config and fix it too.16:42
stephenfinmordred++16:42
sean-k-mooneymordred: i just wanted to make sure there wasnt a reason not to do it the normal way before i made any changes16:43
stephenfinHmm, weird, .zuul.yaml says we're using openstack-specs-jobs which uses openstack-tox-docs16:43
jaypipessean-k-mooney: you working on a rebase of https://review.openstack.org/#/c/629589/?16:43
stephenfinand what was introduced by AJaeger over six months ago (openstack/openstack-zuul-jobs@76deef484)16:44
sean-k-mooneyjaypipes: not presently but i will later or tomorow16:44
jaypipesk16:44
sean-k-mooneyjaypipes: oh i see adrianc updated https://review.openstack.org/#/c/620115/16:45
jaypipessean-k-mooney: yeah, and I'm +2 on it.16:45
jaypipessean-k-mooney: thus my question to you :)16:45
sean-k-mooneyother then rebase ontop did you have anything you wanted me to change in https://review.openstack.org/#/c/629589/16:45
jaypipessean-k-mooney: other than fixing some typos I noted in a review previously, I don't think so.16:46
sean-k-mooneyok ill let you know when its done. thanks for review it. im currently working on my imagemetada prefilter spec16:47
jaypipessean-k-mooney: np.16:48
*** sundar has joined #openstack-nova16:50
*** tesseract has quit IRC16:53
mriedemefried: i have done your bidding https://review.openstack.org/#/c/648800/16:54
efriedThanks mriedem16:54
*** ociuhandu has quit IRC16:54
efriedall good points16:54
*** tbachman has joined #openstack-nova16:57
openstackgerritBalazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation  https://review.openstack.org/63820716:57
*** slaweq has quit IRC16:57
*** derekh has quit IRC16:58
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes NUMA affinity for vGPUs  https://review.openstack.org/65096316:58
*** cdent has quit IRC16:59
*** mlavalle has quit IRC16:59
*** tbachman has quit IRC17:02
dansmithstephenfin: I dunno about removing a whole model or table, but should be the same as a column17:04
dansmithstephenfin: i.e. remove the object and db model in this release, then in the next release add a schema migration to drop it17:05
stephenfindansmith: OK, I'll give it a go. Should we still have placeholder migrations or are they not done anymore?17:05
*** udesale has quit IRC17:05
* stephenfin notes we didn't do it for Rocky17:05
dansmithstephenfin: unrelated to this you mean?17:05
dansmithoh wow, okay17:05
stephenfinyeah17:05
dansmithI thought that was on the PTL release checklist17:05
dansmithI mean, there's no new reason why we shouldn't, other than that we haven't really had to use them ever, but I'm not aware of any discussion or decision about it17:06
*** efried is now known as efried_lunch17:06
*** udesale has joined #openstack-nova17:09
openstackgerritStephen Finucane proposed openstack/nova master: Add placeholder migrations for Stein backports  https://review.openstack.org/65096417:09
stephenfindansmith, melwitt, efried_lunch: They're there if we need them anyway ^17:09
*** belmoreira has joined #openstack-nova17:10
*** ralonsoh has quit IRC17:13
*** erlon has quit IRC17:13
*** slaweq has joined #openstack-nova17:14
*** jcosmao has joined #openstack-nova17:15
*** erlon has joined #openstack-nova17:15
*** jcosmao has left #openstack-nova17:16
*** slaweq has quit IRC17:19
bauzasstephenfin: others, FWIW, https://wiki.openstack.org/wiki/Nova/ReleaseChecklist17:23
bauzasblame myself as I'm technically the release czar (heh)17:24
stephenfindansmith: Hmm, the tests are complaining that I'm not allowed to use 'drop' in migration. Is removing the 'cells' table (cells v1) a valid exception?17:24
*** slaweq has joined #openstack-nova17:24
dansmithstephenfin: yep, specifically to catch this case, so you have to add an exception17:24
stephenfindansmith: If I don't do that, I see 'AssertionError: Models and migration scripts aren't in sync:'17:24
dansmithstephenfin: oh right, so I think you have to leave the model too if there's not an exception path for that17:25
dansmith(we've only done this a couple times since some of those modernized tests)17:25
stephenfindansmith: there is not, no17:25
stephenfinso just leave the model with a TODO to remove in a future release?17:26
dansmithyeah, so leave that but you could neuter it in some way, but definitely remove all the *use* of it yeah17:26
stephenfin(y) less work for me17:26
dansmithstephenfin: you could probably rename the model, right? Call it "class CellsThingDONOTUSE(..)"17:26
*** _alastor_ has quit IRC17:27
*** wolverineav has joined #openstack-nova17:27
*** ivve has joined #openstack-nova17:27
stephenfinUm, I guess I could, yeah :D17:27
*** slaweq has quit IRC17:28
*** erlon has quit IRC17:31
*** wolverineav has quit IRC17:39
*** tbachman has joined #openstack-nova17:40
*** udesale has quit IRC17:41
openstackgerritsean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering  https://review.openstack.org/64757817:42
sean-k-mooneystephenfin: the nova-specs docs issue was because i had not rebased against mater where warnings are treated as errors17:44
*** wolverineav has joined #openstack-nova17:44
sean-k-mooneystephenfin: so the tox env and jobs is fine upstream17:44
*** IvensZambrano has quit IRC17:44
*** tbachman_ has joined #openstack-nova17:44
*** tbachman has quit IRC17:45
*** tbachman_ is now known as tbachman17:45
*** wolverineav has quit IRC17:51
*** wolverineav has joined #openstack-nova17:56
*** ricolin has quit IRC18:00
*** kaisers_away is now known as kaisers_18:06
*** Swami has joined #openstack-nova18:10
*** kaisers_ has quit IRC18:11
openstackgerritMerged openstack/nova master: trivial: Remove dead code  https://review.openstack.org/64956218:13
openstackgerritMerged openstack/nova master: hacking: Fix dodgy check  https://review.openstack.org/64956318:13
openstackgerritMerged openstack/nova master: zvm: Remove dead code  https://review.openstack.org/64956418:13
openstackgerritMerged openstack/nova master: trivial: Remove dead 'ALIAS' constant  https://review.openstack.org/64956518:13
openstackgerritMerged openstack/nova master: trivial: Remove unused constants, functions  https://review.openstack.org/64956718:13
openstackgerritMerged openstack/nova master: trivial: Remove dead resource tracker code  https://review.openstack.org/64956918:13
*** itlinux has quit IRC18:19
*** johnsom has quit IRC18:20
*** fyx has quit IRC18:20
*** adrianreza has quit IRC18:20
*** fyx has joined #openstack-nova18:21
*** adrianreza has joined #openstack-nova18:21
*** johnsom has joined #openstack-nova18:21
*** BlackDex has quit IRC18:22
*** BlackDex has joined #openstack-nova18:22
*** tjgresha has quit IRC18:24
*** weshay|ruck is now known as weshay18:24
*** tjgresha has joined #openstack-nova18:24
*** slaweq has joined #openstack-nova18:25
*** cdent has joined #openstack-nova18:27
*** slaweq has quit IRC18:30
*** tjgresha has quit IRC18:30
*** tjgresha has joined #openstack-nova18:31
*** igordc has quit IRC18:31
*** erlon has joined #openstack-nova18:33
*** burt has quit IRC18:35
*** sridharg has quit IRC18:35
mriedemdansmith: a quick hot take if you will on the path to dropping this online data migration added in ocata: https://github.com/openstack/nova/blob/master/nova/objects/build_request.py#L484 - options: (1) drop it and just assume people are ok (2) add a nova-status upgrade check and drop it or (3) add an api migrations script which just does the query and delete (not a blocker migration, just query for those records and delete th18:36
*** burt has joined #openstack-nova18:36
mriedemi'm partial to #3 which if #1 is true, should be a no-op18:36
dansmithsurely we can delete with extreme prejudice18:39
dansmiththe case would be what? something created in mitaka that didn't boot that people still want to be able to see in nova-list?18:39
dansmithmriedem: ^18:43
mriedemyeah i guess, but we're already deleting with prejudice in the online data migration18:43
mriedembecause you literally can't load the thing otherwise18:44
mriedemso nova-list won't work anyway18:44
dansmithmriedem: I mean delete all of the code18:44
*** belmoreira has quit IRC18:44
mriedemso #118:44
dansmithif we really need a delete in a schema migration, then I guess, but I'd rather not create the confusion about why it was okay in this case, personally18:45
mriedemi think the only thing that scares me is people doing skip upgrades from let's say mitaka in this case to train, but we've said time and again we don't support that and you have to roll through,18:46
mriedemso if you do that and hit this, your action would be to just drop those records from your api db manually18:46
*** mlavalle has joined #openstack-nova18:46
dansmithyeah, that's a really long skip18:47
*** mvkr has quit IRC18:51
*** cdent has quit IRC18:54
*** jmlowe has quit IRC18:56
*** eandersson_ is now known as eandersson18:57
*** tbachman_ has joined #openstack-nova19:01
*** tbachman has quit IRC19:02
*** tbachman_ is now known as tbachman19:02
*** igordc has joined #openstack-nova19:04
*** tjgresha has quit IRC19:06
*** slaweq has joined #openstack-nova19:08
*** luksky has joined #openstack-nova19:13
*** igordc has quit IRC19:15
*** igordc has joined #openstack-nova19:15
*** wolverineav has quit IRC19:22
*** wolverineav has joined #openstack-nova19:23
*** wolverineav has quit IRC19:30
*** cfriesen has joined #openstack-nova19:33
*** jbernard has quit IRC19:35
*** jbernard has joined #openstack-nova19:37
*** ceryx has joined #openstack-nova19:46
cfriesenportdirect: thought I'd give you a heads-up on something weird I saw.  was booting up controller nodes and one of them didn't come up due to disk pressure.  The other mariadb nodes were stuck in /tmp/start.py because check_if_cluster_data_is_fresh() kept evaluating to false (because the one node wasn't updating its timestamp)19:50
*** awaugama has quit IRC19:54
*** sundar has quit IRC19:57
*** wolverineav has joined #openstack-nova19:58
*** jmlowe has joined #openstack-nova20:00
cfriesenwhoops...^ was supposed to be in another channel.20:00
*** amodi has quit IRC20:03
*** mriedem has quit IRC20:05
*** dave-mccowan has quit IRC20:05
*** dave-mccowan has joined #openstack-nova20:06
*** mriedem has joined #openstack-nova20:06
*** jaypipes has quit IRC20:07
*** jaypipes has joined #openstack-nova20:07
*** wolverineav has quit IRC20:08
*** whoami-rajat has quit IRC20:08
*** jaypipes_ has joined #openstack-nova20:08
*** jaypipes has quit IRC20:12
mnaserI mentioned this earlier but.. this does a full table scan, even with max rows.. https://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/db/sqlalchemy/api.py#L5508-L553720:12
mnaserI'm not sure what the best way to work around it is..20:12
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.openstack.org/63112320:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.openstack.org/62789220:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.openstack.org/63158120:17
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.openstack.org/63385320:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method  https://review.openstack.org/62131320:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.openstack.org/63329320:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.openstack.org/62789020:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.openstack.org/63483220:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.openstack.org/63760520:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.openstack.org/62789120:17
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection  https://review.openstack.org/64218320:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method  https://review.openstack.org/64259020:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method  https://review.openstack.org/63508020:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask  https://review.openstack.org/63564620:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field  https://review.openstack.org/61403520:17
openstackgerritMatt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask  https://review.openstack.org/63566820:17
openstackgerritMatt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize()  https://review.openstack.org/63568420:18
openstackgerritMatt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.openstack.org/63622420:18
openstackgerritMatt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells  https://review.openstack.org/61403720:18
openstackgerritMatt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize  https://review.openstack.org/63625320:18
mriedemmnaser: are we missing indexes?20:18
mriedemi don't see any indexes on instance_actions_events20:20
mriedembut that does:20:20
mriedemupdate_statement = table.update().values(deleted=table.c.id).\                                   where(table.c.action_id.in_(deleted_actions))20:20
mriedemi don't know if adding an index on instance_actions_events.action_id would help though20:21
mriedemprobably need jaypipes_ to tell us what sucks about those queries20:22
*** pcaruana has quit IRC20:25
*** efried_lunch is now known as efried20:25
mriedemthat's also in the mainline code https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L528820:26
mnaserYeah I don’t know much. I had to kind orchestrate  this outside nova and shortcircuit that code path20:28
*** eharney has quit IRC20:30
mriedemmnaser: do you archive/purge on a cron or just during each upgrade?20:31
mriedemand tbc this just makes that archive/purge slower right?20:31
mnasermriedem: we’ve kinda not done this for a while so we ended up with huge databases.20:33
mnaserso this may be a case of our fault not doing it as often20:33
mriedemok, was just trying to figure out if it's worth opening a bug report, i.e. if archive takes like 5 minutes or something, then maybe20:35
efriedstephenfin, bauzas, dansmith: Do we need to get those placeholder thingies in before the real release? I.e. modify the release patch?20:43
efriedmriedem, melwitt: ^20:45
mriedemno the placeholder migrations are post-release20:49
mriedemso if we needed to add a schema migration in stable/stein, we have a placeholder for it in train20:49
efriedmriedem: Okay, so... is there some reason we couldn't backport placeholder migrations for rocky?20:50
mriedemwe don't backport placeholder migrations,20:51
mriedembut apparently forgot to add them for rocky20:51
mriedem*in* stein20:51
*** jaypipes_ is now known as jaypipes20:51
efriedI'm confused20:51
efriedthen why is https://review.openstack.org/#/c/650964/ in master and not in stable/stein?20:51
mriedemfor example, latest cell db migration in stein is 391 https://github.com/openstack/nova/tree/stable/stein/nova/db/sqlalchemy/migrate_repo/versions so if we needed something in stable/stein, we'd have to add 392 in stable/stein and then copy that to the 392_placeholder in train20:51
mriedemit's essentially a buffer,20:52
mriedembecause otherwise the first schema migration in train is 39220:52
mriedemso if we need something in stein but already used 392 in train, we're stuck20:52
efriedoh, so if we hadn't done any migrations in stein, we could set up the buffer for rocky.20:53
jaypipesmriedem: instance_action_events.action_id will automatically have an index on it since it's an FK to instance_actions20:53
mriedemrocky ended at 390 and there was one cell db migration in stein, 39120:53
mriedemso if we need something on rocky we're f'ed20:53
jaypipesat least for mysql and pgsql it will.20:53
mriedemjaypipes: ah ok, thanks. i seem to remember asking about this same query a year or more ago and came to the same conclusion (or you told me the same at the time)20:54
jaypipesI think :)20:54
jaypipesmight want to have mnaser do a quick SHOW TABLE instance_action_events to verify20:54
mriedemelse i'm thinking action_id/deleted or something20:54
jaypipeshmm, maybe not since we don't use SQLalchemy create_tables()20:55
mnaserbe back in my machine in a sec20:55
jaypipesbut if the FOREIGN KEY .. REFERENCES statement/clause is executed at any time (either by SQLAlchemy's declarative_base or using sqlalchemy-migrate) then there is indeed an index created on action_id20:56
jaypipeslemme log into an ocata prod DB and check...20:56
jaypipesmriedem, mnaser: verified. there is indeed an index on (action_id)20:58
mriedemjaypipes: ok cool20:59
mriedemefried: https://review.openstack.org/#/q/project:openstack/nova+status:open+path:%255Enova/db/sqlalchemy/migrate_repo/versions/.* :)20:59
openstackgerritDustin Cowles proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get  https://review.openstack.org/64289921:02
efrieddustinc: That looks like a sane delta ^21:03
efriedwere you planning to push other patches on top of that at the same time?21:03
dustincnot yet, I have them local but was just pushing that one for now21:03
mnaserjaypipes: so the thing is I think it might be the deleted field21:04
mnaserthe query looked a something like this: UPDATE instance_actions_events SET deleted=instance_action_events.id WHERE action_id IN (SELECT id FROM instance_actions WHERE instance_uuid IN (SELECT uuid FROM instances WHERE deleted!=0))21:05
mnaserso you grab a list of all non deleted instances, then you grab all their instance actions, then you grab all the action ids associated to them21:05
mriedemweeee https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L17421:05
mriedemmnaser: other way around - it's soft-deleting actions and events for deleted instances21:06
mriedemdeleted!=0 == soft-deleted21:06
mriedemarchive is the only thing that actually deletes actions/events21:06
mnaserright, yeah, so it soft deletes them because for some reason we don't soft delete them by default? yeah21:06
mnaserso if you haven't done that in a while, that can be.. a big dataset21:06
mriedemmnaser: corret https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L183221:06
mriedem*correct21:06
mnaseroh neat21:07
mriedemcould be real big if you have lots of pets21:07
mnaseror a cloud with a lot of VMs going up and down21:08
mnaseris there an index on deleted21:08
*** wolverineav has joined #openstack-nova21:09
mnaserinstances_host_deleted_cleaned_idx yes there is21:10
* tbachman looks at the number of nova jobs in the gate :-o21:15
*** ttsiouts has joined #openstack-nova21:18
*** wolverineav has quit IRC21:22
mriedemthat's my fault21:23
*** wolverineav has joined #openstack-nova21:23
mriedemhttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cross-cell-resize21:23
* tbachman wants mriedem’s code-generation/-fixing script21:25
*** gbarros has quit IRC21:27
*** wolverineav has quit IRC21:28
openstackgerritMatt Riedemann proposed openstack/nova master: Delete require_instance_exists_using_uuid  https://review.openstack.org/65099421:33
openstackgerritMatt Riedemann proposed openstack/nova master: Soft delete virtual_interfaces when instance is destroyed  https://review.openstack.org/65099521:33
mriedemvery easy couple of changes ^21:36
*** wolverineav has joined #openstack-nova21:37
*** Sundar has joined #openstack-nova21:39
*** Sundar has quit IRC21:39
*** Sundar has joined #openstack-nova21:40
*** Sundar has quit IRC21:40
*** Sundar has joined #openstack-nova21:42
*** tbachman has quit IRC21:44
*** whoami-rajat has joined #openstack-nova21:45
openstackgerritMatt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration  https://review.openstack.org/65100121:47
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.openstack.org/60396921:48
openstackgerritMatt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration  https://review.openstack.org/65100121:48
*** mchlumsky has quit IRC21:52
*** sambetts_ has quit IRC21:55
*** sambetts_ has joined #openstack-nova21:58
*** ivve has quit IRC21:59
mriedemmordred: i added you to this nova spec https://review.openstack.org/#/c/603969/ about cleaning up old nasty cruft out of the compute API if you want to weigh in on your most hated UX stuff in the compute API21:59
*** wolverineav has quit IRC21:59
mriedemmy personal most hated is the OS-EXT-* prefixes21:59
mriedemi just want do do: server = GET /servers/id; host = server['host'] without looking up the API reference every time22:00
*** wolverineav has joined #openstack-nova22:02
*** erlon has quit IRC22:05
*** wolverineav has quit IRC22:06
*** slaweq has quit IRC22:07
*** Sundar has quit IRC22:07
openstackgerritmelanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide  https://review.openstack.org/65100922:10
*** wolverineav has joined #openstack-nova22:11
openstackgerritmelanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide  https://review.openstack.org/65100922:12
*** tbachman has joined #openstack-nova22:12
dansmithefried: what mriedem said22:12
*** mriedem has quit IRC22:13
*** rcernin has joined #openstack-nova22:14
*** tbachman has quit IRC22:14
*** lbragstad has quit IRC22:14
*** igordc has quit IRC22:18
*** igordc has joined #openstack-nova22:18
*** mlavalle has quit IRC22:19
*** slaweq has joined #openstack-nova22:23
*** slaweq has quit IRC22:27
*** wolverineav has quit IRC22:33
*** luksky has quit IRC22:33
*** ttsiouts has quit IRC22:35
*** ttsiouts has joined #openstack-nova22:36
*** ttsiouts has quit IRC22:40
*** wolverineav has joined #openstack-nova22:43
*** wolverineav has quit IRC22:43
*** wolverineav has joined #openstack-nova22:44
efriedlyarwood, jungleboyj, mdbooth: I moved "Swap volume API woes" to the (shiny new) cinder-nova xproj etherpad22:44
efriedhttps://etherpad.openstack.org/p/ptg-train-xproj-nova-cinder22:44
openstackgerritEric Fried proposed openstack/nova-specs master: DNM: split me  https://review.openstack.org/65102022:50
*** dave-mccowan has quit IRC22:58
*** tkajinam has joined #openstack-nova23:00
*** Sundar has joined #openstack-nova23:01
openstackgerritEric Fried proposed openstack/nova-specs master: Tools & docs for backlog & abandoned spec process  https://review.openstack.org/64880023:11
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec  https://review.openstack.org/64909523:14
*** mgoddard has quit IRC23:14
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec  https://review.openstack.org/64910223:14
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec  https://review.openstack.org/64910123:14
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec  https://review.openstack.org/64910023:14
*** mgoddard has joined #openstack-nova23:15
*** tetsuro has joined #openstack-nova23:15
openstackgerritIvens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f  https://review.openstack.org/65102423:17
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec  https://review.openstack.org/64910023:18
*** wolverineav has quit IRC23:19
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec  https://review.openstack.org/64909523:19
*** wolverineav has joined #openstack-nova23:19
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec  https://review.openstack.org/64910223:20
openstackgerritEric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec  https://review.openstack.org/64910123:20
*** wolverineav has quit IRC23:24
*** wolverineav has joined #openstack-nova23:24
*** wolverineav has quit IRC23:26
*** wolverineav has joined #openstack-nova23:27
eanderssonDoes anyone have a example of using the JsonFilter for the Scheduler? :D23:30
*** wolverineav has quit IRC23:33
eanderssonnvm found an example23:40
openstackgerritIvens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f  https://review.openstack.org/65102423:40
openstackgerritIvens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f  https://review.openstack.org/65102423:47
*** bbowen has quit IRC23:49
*** bbowen has joined #openstack-nova23:49
*** wolverineav has joined #openstack-nova23:50
openstackgerritIvens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f  https://review.openstack.org/65102423:51
*** whoami-rajat has quit IRC23:58
*** tosky has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!