*** slaweq has joined #openstack-nova | 00:00 | |
*** tetsuro has joined #openstack-nova | 00:02 | |
*** tosky has quit IRC | 00:05 | |
*** slaweq has quit IRC | 00:05 | |
*** wolverineav has quit IRC | 00:10 | |
openstackgerrit | Merged openstack/nova master: Delete the obj_as_admin context manager https://review.openstack.org/635351 | 00:14 |
---|---|---|
openstackgerrit | Merged openstack/nova master: Use errors_out_migration decorator on finish_resize https://review.openstack.org/641138 | 00:14 |
*** weshay has quit IRC | 00:19 | |
*** weshay has joined #openstack-nova | 00:20 | |
*** igordc has joined #openstack-nova | 00:22 | |
mlavalle | efried: is this being talked about on your side: https://bugs.launchpad.net/neutron/+bug/1821058? | 00:31 |
openstack | Launchpad bug 1821058 in neutron "[RFE] Port binding event extended information for Nova" [Wishlist,Confirmed] | 00:31 |
mlavalle | here's the spec in neutron: https://review.openstack.org/#/c/645173/2 | 00:31 |
*** wolverineav has joined #openstack-nova | 00:33 | |
*** wolverineav has quit IRC | 00:38 | |
*** wolverineav has joined #openstack-nova | 00:39 | |
*** markvoelker has joined #openstack-nova | 00:40 | |
*** hongbin has joined #openstack-nova | 00:40 | |
*** hamzy has joined #openstack-nova | 00:44 | |
*** stakeda has joined #openstack-nova | 00:46 | |
*** wolverineav has quit IRC | 00:47 | |
*** jistr has quit IRC | 01:00 | |
openstackgerrit | chenker proposed openstack/python-novaclient master: Optimize limit option docs string description for novaclient https://review.openstack.org/643035 | 01:00 |
*** jistr has joined #openstack-nova | 01:00 | |
*** mlavalle has quit IRC | 01:01 | |
*** itlinux has joined #openstack-nova | 01:05 | |
*** slaweq has joined #openstack-nova | 01:11 | |
*** slaweq has quit IRC | 01:16 | |
*** whoami-rajat has joined #openstack-nova | 01:19 | |
*** ricolin has joined #openstack-nova | 01:21 | |
*** gbarros has joined #openstack-nova | 01:23 | |
*** erlon has quit IRC | 01:32 | |
*** wolverineav has joined #openstack-nova | 01:48 | |
*** wolverineav has quit IRC | 01:51 | |
*** wolverineav has joined #openstack-nova | 01:53 | |
*** wolverineav has quit IRC | 02:03 | |
*** slaweq has joined #openstack-nova | 02:11 | |
openstackgerrit | melanie witt proposed openstack/nova master: libvirt: set device address tag only if setting disk unit https://review.openstack.org/611974 | 02:15 |
*** slaweq has quit IRC | 02:16 | |
*** awalende has joined #openstack-nova | 02:29 | |
*** awalende has quit IRC | 02:33 | |
openstackgerrit | Merged openstack/nova master: Reproduce bug #1819460 in functional test https://review.openstack.org/642444 | 02:41 |
openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | 02:41 |
*** psachin has joined #openstack-nova | 02:56 | |
*** slaweq has joined #openstack-nova | 03:12 | |
*** slaweq has quit IRC | 03:16 | |
*** weshay has quit IRC | 03:24 | |
*** weshay has joined #openstack-nova | 03:24 | |
*** weshay has quit IRC | 03:24 | |
*** weshay has joined #openstack-nova | 03:25 | |
*** cfriesen has quit IRC | 03:34 | |
openstackgerrit | chenker proposed openstack/python-novaclient master: Optimize limit option docs string description for novaclient https://review.openstack.org/643035 | 03:45 |
*** hongbin has quit IRC | 03:52 | |
*** udesale has joined #openstack-nova | 03:56 | |
*** jaypipes_ has quit IRC | 04:02 | |
*** jaypipes_ has joined #openstack-nova | 04:02 | |
*** wolverineav has joined #openstack-nova | 04:03 | |
*** wolverineav has quit IRC | 04:08 | |
openstackgerrit | Michael Still proposed openstack/nova master: PrivsepFixture so sys_admin_pctxt methods can be tested https://review.openstack.org/647849 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602 | 04:13 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603 | 04:13 |
openstackgerrit | Alex Xu proposed openstack/nova master: Revert "Reproduce bug #1819460 in functional test" https://review.openstack.org/648605 | 04:21 |
openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | 04:21 |
alex_xu | gibi: efried sounds like _fill_provider_mapping method doesn't raise the exception we test on, so I revert the patch again https://review.openstack.org/#/c/648605/, let me know if I still get the situation clear.... | 04:23 |
*** gbarros has quit IRC | 04:27 | |
*** tetsuro has quit IRC | 04:27 | |
*** tetsuro has joined #openstack-nova | 04:28 | |
*** tetsuro has quit IRC | 04:33 | |
*** tetsuro has joined #openstack-nova | 04:37 | |
*** sridharg has joined #openstack-nova | 04:48 | |
*** tetsuro has quit IRC | 05:07 | |
*** slaweq has joined #openstack-nova | 05:11 | |
*** slaweq has quit IRC | 05:15 | |
*** tetsuro has joined #openstack-nova | 05:19 | |
*** ratailor has joined #openstack-nova | 05:34 | |
*** sidx64 has joined #openstack-nova | 05:42 | |
*** tetsuro has quit IRC | 05:45 | |
*** igordc has quit IRC | 05:50 | |
*** tetsuro has joined #openstack-nova | 06:05 | |
openstackgerrit | Michael Still proposed openstack/nova master: PrivsepFixture so sys_admin_pctxt methods can be tested https://review.openstack.org/647849 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615 | 06:09 |
openstackgerrit | Michael Still proposed openstack/nova master: WIP: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616 | 06:09 |
*** janki has joined #openstack-nova | 06:10 | |
openstackgerrit | ya.wang proposed openstack/nova-specs master: expose auto converge in rest api https://review.openstack.org/648619 | 06:28 |
*** slaweq has joined #openstack-nova | 06:37 | |
*** rcernin has quit IRC | 06:38 | |
*** zhubx has quit IRC | 06:40 | |
*** zhubx has joined #openstack-nova | 06:40 | |
*** udesale has quit IRC | 06:41 | |
*** udesale has joined #openstack-nova | 06:41 | |
*** slaweq has quit IRC | 06:42 | |
*** Luzi has joined #openstack-nova | 06:51 | |
*** tetsuro has quit IRC | 07:00 | |
*** slaweq has joined #openstack-nova | 07:08 | |
*** sidx64 has quit IRC | 07:09 | |
*** sidx64 has joined #openstack-nova | 07:14 | |
*** dpawlik has joined #openstack-nova | 07:17 | |
*** luksky has joined #openstack-nova | 07:35 | |
*** slaweq has quit IRC | 07:36 | |
*** jaosorior has quit IRC | 07:37 | |
*** sidx64 has quit IRC | 07:39 | |
*** rpittau|afk is now known as rpittau | 07:39 | |
*** slaweq has joined #openstack-nova | 07:48 | |
gibi | alex_xu: looking | 07:51 |
*** slaweq has quit IRC | 07:52 | |
*** awalende has joined #openstack-nova | 08:05 | |
*** tkajinam has quit IRC | 08:07 | |
*** ccamacho has joined #openstack-nova | 08:07 | |
*** tesseract has joined #openstack-nova | 08:11 | |
*** tosky has joined #openstack-nova | 08:15 | |
*** rcernin has joined #openstack-nova | 08:22 | |
*** helenaAM has joined #openstack-nova | 08:24 | |
*** tesseract has quit IRC | 08:24 | |
*** ralonsoh has joined #openstack-nova | 08:24 | |
*** sidx64 has joined #openstack-nova | 08:25 | |
*** tesseract has joined #openstack-nova | 08:26 | |
*** sidx64 has quit IRC | 08:26 | |
*** sidx64 has joined #openstack-nova | 08:27 | |
*** ttsiouts has joined #openstack-nova | 08:28 | |
*** jangutter has quit IRC | 08:32 | |
gibi | alex_xu: answered in https://review.openstack.org/#/c/639608 | 08:38 |
gibi | alex_xu: instead of revert and re-add the functional reproduce can I just push a patch that changes what exception we throw in the functiional test? | 08:38 |
*** ttsiouts has quit IRC | 08:40 | |
*** avolkov has joined #openstack-nova | 08:52 | |
*** tssurya has joined #openstack-nova | 08:57 | |
*** rcernin has quit IRC | 08:57 | |
*** udesale has quit IRC | 08:57 | |
*** udesale has joined #openstack-nova | 08:58 | |
*** stakeda has quit IRC | 09:05 | |
*** maciejjozefczyk has quit IRC | 09:06 | |
*** udesale has quit IRC | 09:07 | |
*** maciejjozefczyk has joined #openstack-nova | 09:08 | |
*** chungpht has joined #openstack-nova | 09:08 | |
*** udesale has joined #openstack-nova | 09:10 | |
openstackgerrit | Magnus Bergman proposed openstack/nova master: Adding tests to demonstrate bug #1821824 https://review.openstack.org/647957 | 09:10 |
openstack | bug 1821824 in OpenStack Compute (nova) "Forbidden traits in flavor properties don't work" [Undecided,In progress] https://launchpad.net/bugs/1821824 - Assigned to Magnus Bergman (magnusbe) | 09:10 |
trident | gibi: There. Got stuck in some other work yesterday, but here it is. First commit with new functional and unit tests demonstrating the forbidden traits issue. Next commit will add the fix as well. | 09:13 |
gibi | trident: ack. I will look at it shortly | 09:14 |
*** pcaruana has joined #openstack-nova | 09:15 | |
*** udesale has quit IRC | 09:15 | |
*** sapd1_x has joined #openstack-nova | 09:17 | |
*** ttsiouts has joined #openstack-nova | 09:20 | |
*** jangutter has joined #openstack-nova | 09:21 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 09:23 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix exception type in test_boot_reschedule_fill_provider_mapping_raises https://review.openstack.org/648651 | 09:23 |
gibi | alex_xu: ^^ | 09:25 |
openstackgerrit | Magnus Bergman proposed openstack/nova master: Fix bug preventing forbidden traits from working https://review.openstack.org/648653 | 09:29 |
*** itlinux_ has joined #openstack-nova | 09:29 | |
*** itlinux has quit IRC | 09:31 | |
trident | gibi: I hope I got it right with the commits in series. | 09:31 |
*** sapd1_x has quit IRC | 09:32 | |
gibi | trident: based on a quick look in gerrit you put the patches in a good order. I will review both | 09:32 |
trident | Great, thanks! | 09:32 |
*** priteau has joined #openstack-nova | 09:33 | |
*** dtantsur|afk is now known as dtantsur | 09:43 | |
gibi | trident: left comments in https://review.openstack.org/#/c/647957 | 09:48 |
*** davidsha has joined #openstack-nova | 09:48 | |
gibi | trident: some formal changes needed but the test your created seems good to me | 09:50 |
*** sapd1_x has joined #openstack-nova | 09:55 | |
*** wolverineav has joined #openstack-nova | 10:00 | |
trident | gibi: Thanks! Will look into it shortly! | 10:03 |
*** chungpht has quit IRC | 10:03 | |
*** wolverineav has quit IRC | 10:05 | |
*** maciejjozefczyk has quit IRC | 10:05 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 10:09 |
*** sapd1_x has quit IRC | 10:13 | |
*** sridharg has quit IRC | 10:17 | |
openstackgerrit | sean mooney proposed openstack/nova master: make lower-constratints env use lower-constratins https://review.openstack.org/645392 | 10:23 |
*** sapd1_x has joined #openstack-nova | 10:23 | |
*** sridharg has joined #openstack-nova | 10:30 | |
*** ricolin has quit IRC | 10:33 | |
*** maciejjozefczyk has joined #openstack-nova | 10:36 | |
openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: [WIP] Support adding the reason behind a server lock https://review.openstack.org/648659 | 10:38 |
*** jaosorior has joined #openstack-nova | 10:55 | |
*** tbachman has quit IRC | 10:56 | |
*** slaweq has joined #openstack-nova | 11:00 | |
tssurya | stephenfin: any idea on how to fix http://logs.openstack.org/29/638629/7/check/openstack-tox-docs/f14d940/job-output.txt.gz#_2019-03-29_10_28_35_792167 , seems like the docs CI is failing..not sure if there is a bug already | 11:00 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Support adding the reason behind a server lock https://review.openstack.org/648662 | 11:07 |
openstackgerrit | Merged openstack/nova master: Error out migration when confirm_resize fails https://review.openstack.org/647546 | 11:08 |
*** jaosorior has quit IRC | 11:09 | |
*** slaweq has quit IRC | 11:09 | |
*** ttsiouts has quit IRC | 11:12 | |
openstackgerrit | sean mooney proposed openstack/nova master: make lower-constratints env use lower-constratins https://review.openstack.org/645392 | 11:12 |
*** ttsiouts has joined #openstack-nova | 11:12 | |
*** slaweq has joined #openstack-nova | 11:14 | |
openstackgerrit | sean mooney proposed openstack/nova master: make lower-constratints env use lower-constratins https://review.openstack.org/645392 | 11:17 |
*** ttsiouts has quit IRC | 11:17 | |
sean-k-mooney | by the way i have confimed that cdent's version works too https://review.openstack.org/#/c/622972/14 | 11:19 |
sean-k-mooney | so im fine with abandoning my version in favor of his if people prefer but we should merge one of the two | 11:20 |
stephenfin | tssurya: \o/ Looks like Sphinx 2.0 has broken some stuff | 11:25 |
stephenfin | I think that got released today | 11:25 |
stephenfin | tssurya: What repo is that against? I didn't think we were still using oslosphinx anywhere | 11:26 |
sean-k-mooney | launchpad is broken... | 11:29 |
sean-k-mooney | i should just never file bugs buzilla was broken when i tried yesterday too. | 11:30 |
openstackgerrit | sean mooney proposed openstack/nova master: make lower-constraints env use lower-constraints https://review.openstack.org/645392 | 11:32 |
openstackgerrit | sean mooney proposed openstack/nova master: make lower-constraints env use lower-constraints https://review.openstack.org/645392 | 11:35 |
openstackgerrit | Helena proposed openstack/nova-specs master: Spec for a new nova virt driver to manage an RSD, composable infrastructure deployment https://review.openstack.org/648665 | 11:39 |
*** sapd1_x has quit IRC | 11:40 | |
*** cdent has joined #openstack-nova | 11:41 | |
*** whoami-rajat has quit IRC | 11:42 | |
*** ttsiouts has joined #openstack-nova | 11:48 | |
stephenfin | tssurya: https://review.openstack.org/648666 | 11:50 |
*** tbachman has joined #openstack-nova | 11:53 | |
*** ttsiouts has quit IRC | 11:53 | |
*** tbachman has quit IRC | 11:56 | |
*** wolverineav has joined #openstack-nova | 12:01 | |
*** Luzi has quit IRC | 12:02 | |
*** wolverineav has quit IRC | 12:06 | |
*** weshay is now known as weshay|rover | 12:06 | |
*** tbachman has joined #openstack-nova | 12:08 | |
*** hemna has quit IRC | 12:08 | |
*** hemna has joined #openstack-nova | 12:09 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Remove cruft from 'conf.py' https://review.openstack.org/648670 | 12:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Fix multiple issues with the 'redirect' extension https://review.openstack.org/648671 | 12:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Switch to openstackdocstheme https://review.openstack.org/648672 | 12:11 |
stephenfin | gibi, bauzas: Can you look at those to unblock tssurya/anyone else proposing specs ^ | 12:11 |
stephenfin | (https://review.openstack.org/648666 might be helpful for additional context) | 12:11 |
* stephenfin -> gym | 12:11 | |
*** luksky has quit IRC | 12:17 | |
gibi | stephenfin: on a meeting I will look at it latae | 12:19 |
gibi | later | 12:19 |
*** janki has quit IRC | 12:20 | |
*** ratailor has quit IRC | 12:21 | |
*** ttsiouts has joined #openstack-nova | 12:24 | |
*** jaypipes_ is now known as leakypipes | 12:30 | |
*** markvoelker has quit IRC | 12:32 | |
*** tesseract has quit IRC | 12:35 | |
*** tesseract-rh has joined #openstack-nova | 12:35 | |
*** ttsiouts has quit IRC | 12:46 | |
*** ttsiouts has joined #openstack-nova | 12:47 | |
*** hemna has quit IRC | 12:49 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only call _fill_provider_mapping if claim succeeds https://review.openstack.org/648676 | 12:49 |
*** hemna has joined #openstack-nova | 12:51 | |
*** luksky has joined #openstack-nova | 12:54 | |
*** jaosorior has joined #openstack-nova | 12:56 | |
*** efried is now known as fried_rice | 12:58 | |
*** lbragstad is now known as elbragstad | 13:00 | |
elbragstad | gmann nice - thanks for those | 13:06 |
*** eharney has joined #openstack-nova | 13:07 | |
fried_rice | gibi: Earlier mlavalle asked about https://bugs.launchpad.net/neutron/+bug/1821058 / https://review.openstack.org/#/c/645173/ | 13:09 |
openstack | Launchpad bug 1821058 in neutron "[RFE] Port binding event extended information for Nova" [Wishlist,Confirmed] | 13:09 |
fried_rice | I can see you're already reviewing the latter. | 13:09 |
fried_rice | Any initial thoughts on this work? | 13:09 |
gibi | fried_rice: my position is that the problems listed in the spec are valid, however it is not clear to me how the proposed solution will impact nova (and os-vif) especially how much dependency will be added between nova and the neutron backends | 13:11 |
*** awaugama has joined #openstack-nova | 13:12 | |
gibi | fried_rice: but I haven't read sean-k-mooney's reply in the spec yet | 13:12 |
fried_rice | gibi: Okay. I suppose it will be something for the xproj session at the ptg. But obviously the more we can have resolved before then, the better. | 13:12 |
gibi | fried_rice: totally agree | 13:12 |
gibi | fried_rice: this will be a cross project effort | 13:13 |
sean-k-mooney | fried_rice: so i have been putting of writing the nova side of the spec abit untill i get a vague yes or no form the neutron side | 13:13 |
fried_rice | sean-k-mooney: At some point we'll want it tied to a bp | 13:14 |
sean-k-mooney | there are likely other ways to adress the issues i that were raised | 13:14 |
fried_rice | but I guess there's no point in filing one of those if we're still not sure we want to do it at all. | 13:14 |
sean-k-mooney | fried_rice: i can file that now if you like. | 13:14 |
fried_rice | sean-k-mooney: Or it doesn't exist :P | 13:14 |
sean-k-mooney | well i can file a blueprint for the geneal problem of fix neutron event handleing | 13:15 |
sean-k-mooney | the solution is still open | 13:15 |
*** lpetrut has joined #openstack-nova | 13:15 | |
fried_rice | sean-k-mooney: it will require *something* in nova? | 13:15 |
tssurya | stephenfin: thanks for the fix ! | 13:18 |
sean-k-mooney | fried_rice: yes | 13:20 |
fried_rice | sean-k-mooney: Then yes please, let's get a bp on the docket | 13:21 |
sean-k-mooney | fried_rice: put simplely if we want to ensure that networking is configured correclty for all instance lifecycle operations and not just spawn/power on then we need to wait for the netwrok events in several placees in the code | 13:21 |
fried_rice | several places in the nova code | 13:21 |
sean-k-mooney | fried_rice: we cant today simpley because we dont know what neutron backend is being used and if it will send them | 13:21 |
sean-k-mooney | fried_rice: its all in the virt dirvres | 13:22 |
*** mvkr has joined #openstack-nova | 13:22 | |
fried_rice | interesting problem. | 13:22 |
sean-k-mooney | interesting proablem i have been trinig to fix for 4 years... but yes :) | 13:23 |
sean-k-mooney | fried_rice: we have some comments like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2846-L2855 in the code where we know we would like to wait but cant | 13:24 |
*** hemna has quit IRC | 13:24 | |
sean-k-mooney | but https://bugs.launchpad.net/nova/+bug/1813789 is also jsut another sideffect of the same large problem | 13:24 |
openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | 13:24 |
*** jding1_ has quit IRC | 13:25 | |
*** gbarros has joined #openstack-nova | 13:26 | |
*** jackding has joined #openstack-nova | 13:27 | |
*** hemna has joined #openstack-nova | 13:30 | |
*** jaosorior has quit IRC | 13:30 | |
*** gbarros has quit IRC | 13:34 | |
openstackgerrit | Theodoros Tsioutsias proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/648686 | 13:35 |
openstackgerrit | Theodoros Tsioutsias proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/648687 | 13:36 |
alex_xu | gibi: yea, I'm ok with another fix | 13:37 |
*** priteau has quit IRC | 13:37 | |
gibi | alex_xu: cool, I pushed the test fix below the actual bugfix | 13:38 |
*** whoami-rajat has joined #openstack-nova | 13:38 | |
alex_xu | gibi: thanks, checking now | 13:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete allocations even if _confirm_resize raises https://review.openstack.org/647566 | 13:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: add more details to confirmResize troubleshooting https://review.openstack.org/647741 | 13:38 |
gibi | stephenfin: did you missed a depends-on in https://review.openstack.org/#/c/648670/ ? | 13:39 |
gibi | stephenfin: the doc job fails | 13:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/648688 | 13:41 |
*** cdent has quit IRC | 13:42 | |
*** jaosorior has joined #openstack-nova | 13:43 | |
stephenfin | gibi: Nope, just saw that. It's _another_ dependency that's borked (yasfb) | 13:44 |
stephenfin | working on a fix for that now | 13:44 |
gibi | stephenfin: ack | 13:45 |
*** cfriesen has joined #openstack-nova | 13:46 | |
*** bnemec is now known as beekneemech | 13:47 | |
*** stephenfin is now known as finucannot | 13:48 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Temporarily mutate migration object in finish_revert_resize https://review.openstack.org/648691 | 13:48 |
*** shilpasd has quit IRC | 13:50 | |
*** psachin has quit IRC | 13:52 | |
bauzas | finucannot: the change is broken, right? https://review.openstack.org/#/c/648670/1 | 13:54 |
bauzas | oh, nevermind, haven't seen above | 13:55 |
finucannot | bauzas: See above :) | 13:55 |
*** cdent has joined #openstack-nova | 13:55 | |
*** tbachman has quit IRC | 13:55 | |
bauzas | finucannot: yeah I'm tired | 13:56 |
bauzas | and I'm torn in between using PapaOurs or bauwser for my Friday nick | 13:57 |
bauzas | people should vote | 13:57 |
* artom votes DaddyBear | 13:57 | |
artom | Because of the implication | 13:57 |
*** artom is now known as temka | 13:57 | |
*** mlavalle has joined #openstack-nova | 13:59 | |
*** jaosorior has quit IRC | 14:01 | |
*** jaosorior has joined #openstack-nova | 14:02 | |
*** wolverineav has joined #openstack-nova | 14:02 | |
*** hemna has quit IRC | 14:04 | |
*** sridharg has quit IRC | 14:06 | |
bauzas | temka: DaddyBear has many more implications than PapaOurs | 14:06 |
temka | bauzas, quite | 14:06 |
bauzas | hum, DaddyBear isn't registered | 14:07 |
temka | They tend to be on a different sort of register | 14:08 |
temka | (I'm so sorry) | 14:08 |
*** bauzas is now known as DaddyBear | 14:09 | |
*** wolverineav has quit IRC | 14:09 | |
DaddyBear | there, registered | 14:09 |
*** hemna has joined #openstack-nova | 14:10 | |
DaddyBear | but I'm still the real PapaOurs | 14:10 |
*** DaddyBear is now known as PapaOurs | 14:10 | |
*** hemna has quit IRC | 14:16 | |
*** hemna has joined #openstack-nova | 14:16 | |
Zara | had to check what channel I was in for a sec, there | 14:18 |
dansmith | heh | 14:18 |
dansmith | "different sort of register" .. that was a good one | 14:18 |
*** munimeha1 has joined #openstack-nova | 14:19 | |
dansmith | I normally don't like to encourage temka but that one was worth it | 14:19 |
cdent | temka++ | 14:19 |
temka | I said I was sorry! | 14:19 |
*** cdent has quit IRC | 14:21 | |
*** gbarros has joined #openstack-nova | 14:28 | |
edleafe | temka: I'm just glad I wasn't the only one who thought that! | 14:34 |
temka | \o/ | 14:34 |
*** mrch_ has quit IRC | 14:40 | |
*** hemna has quit IRC | 14:47 | |
*** hemna has joined #openstack-nova | 14:48 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 14:49 |
*** gbarros has quit IRC | 14:53 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only call _fill_provider_mapping if claim succeeds https://review.openstack.org/648676 | 14:57 |
*** ratailor has joined #openstack-nova | 15:00 | |
*** tbachman has joined #openstack-nova | 15:01 | |
*** awalende has quit IRC | 15:06 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 15:06 |
*** tbachman has quit IRC | 15:11 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | 15:11 |
*** eharney has quit IRC | 15:12 | |
*** _alastor_ has quit IRC | 15:14 | |
*** _alastor_ has joined #openstack-nova | 15:14 | |
*** luksky has quit IRC | 15:16 | |
*** dpawlik has quit IRC | 15:16 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | 15:16 |
finucannot | PapaOurs, gibi, gmann: This should fix the nova-specs build issues for good now (I'd to fix an issue with yasfb too) https://review.openstack.org/#/c/648670/ | 15:18 |
openstackgerrit | Magnus Bergman proposed openstack/nova master: Adding tests to demonstrate bug #1821824 https://review.openstack.org/647957 | 15:18 |
openstack | bug 1821824 in OpenStack Compute (nova) "Forbidden traits in flavor properties don't work" [Undecided,In progress] https://launchpad.net/bugs/1821824 - Assigned to Magnus Bergman (magnusbe) | 15:18 |
openstackgerrit | Magnus Bergman proposed openstack/nova master: Fix bug preventing forbidden traits from working https://review.openstack.org/648653 | 15:18 |
gibi | finucannot: ack | 15:18 |
gmann | finucannot: thanks | 15:19 |
*** cdent has joined #openstack-nova | 15:19 | |
*** slaweq has quit IRC | 15:19 | |
trident | gibi: There. Thanks for bearing with me. This is one of my first non-trivial contributions - and my first to nova. | 15:20 |
*** jaosorior has quit IRC | 15:21 | |
gibi | trident: thanks for putting the effort to fix it properly | 15:21 |
gibi | trident: I will look at it shortly | 15:21 |
gibi | trident: and welcome in nova! | 15:21 |
*** gouthamr has quit IRC | 15:24 | |
*** hongbin has joined #openstack-nova | 15:26 | |
trident | gibi: Thanks! | 15:26 |
*** gouthamr has joined #openstack-nova | 15:27 | |
*** slaweq has joined #openstack-nova | 15:28 | |
gibi | fried_rice: trident put together the reproduction and the bugfix as well. I think it is good to go now. So if you have time: https://review.openstack.org/#/c/648653 | 15:29 |
*** gmann is now known as gmann_afk | 15:32 | |
*** slaweq has quit IRC | 15:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | 15:36 |
*** tbachman has joined #openstack-nova | 15:39 | |
*** awaugama has quit IRC | 15:40 | |
*** knikolla is now known as nikrin | 15:41 | |
*** slaweq has joined #openstack-nova | 15:42 | |
*** ricolin has joined #openstack-nova | 15:43 | |
fried_rice | gibi, trident: on it | 15:43 |
finucannot | PapaOurs: CI was happy with https://review.openstack.org/#/c/648670/. I fixed your nit if you want to rehit that | 15:46 |
PapaOurs | finucannot: yup, just sax | 15:46 |
PapaOurs | sa | 15:46 |
PapaOurs | graaah | 15:46 |
PapaOurs | saw* | 15:46 |
*** eharney has joined #openstack-nova | 15:46 | |
*** lpetrut has quit IRC | 15:47 | |
*** slaweq has quit IRC | 15:50 | |
*** psachin has joined #openstack-nova | 15:50 | |
*** sidx64 has quit IRC | 15:52 | |
*** ratailor has quit IRC | 15:56 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Refactor functional base test classes https://review.openstack.org/643101 | 16:02 |
*** zhubx has quit IRC | 16:03 | |
*** zhubx has joined #openstack-nova | 16:03 | |
*** PapaOurs is now known as bauzas | 16:04 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 16:05 |
fried_rice | gibi, trident: responded. Do you agree? | 16:07 |
*** ricolin has quit IRC | 16:07 | |
gibi | fried_rice: do you mean adding another test where we see that the boot succeeds to a host that has the trait? | 16:08 |
*** jangutter has quit IRC | 16:09 | |
gibi | fried_rice: I have to run. I'm not against adding that extra test, just add a note in the test that it can produce false positives | 16:10 |
*** gibi is now known as gibi_off | 16:10 | |
* gibi_off gibi will be pretty off the whole next week | 16:10 | |
fried_rice | gibi_off: sure, that wfm | 16:10 |
fried_rice | trident: ^^ | 16:10 |
fried_rice | gibi_off, trident: In that case, I suggest it would be best to do both paths in a single test method. | 16:11 |
openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | 16:16 |
*** gbarros has joined #openstack-nova | 16:17 | |
*** hongbin has quit IRC | 16:18 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Poison sleep() in tests https://review.openstack.org/643763 | 16:23 |
*** tosky has quit IRC | 16:23 | |
openstackgerrit | Merged openstack/nova master: Fix exception type in test_boot_reschedule_fill_provider_mapping_raises https://review.openstack.org/648651 | 16:26 |
*** mrch_ has joined #openstack-nova | 16:26 | |
openstackgerrit | Merged openstack/nova-specs master: docs: Resolve issues with Sphinx 2.0 https://review.openstack.org/648670 | 16:27 |
*** slaweq has joined #openstack-nova | 16:28 | |
trident | fried_rice: Thanks. Good points. Will take care of it during the weekend or worst case on monday. | 16:33 |
dansmith | fried_rice: how much time does that actually save? | 16:33 |
dansmith | (not sleeping) | 16:33 |
fried_rice | dansmith: In the gate, I don't know, probably not significant, thirty seconds at best is my guess. That would only be for the unit test suites, which run fast anyway. But IIUC each suite runs on its own node, so getting done some amount of time earlier would free that node up for other runs. | 16:37 |
fried_rice | dansmith: It's really for local tox | 16:37 |
dansmith | it saves you a lot locally? | 16:38 |
fried_rice | "a lot", meh. If I'm working on a test or a whole module or class or whatever, and it's got 7-12s worth of sleeps (which is typical for the cases I fixed) and I have to run it 10x while I'm developing whatever, it can save me minutes. | 16:39 |
dansmith | the gate workers are only 4T IIRC, so I would expect it to save you less locally | 16:39 |
dansmith | and what are those sleeps doing? polling a fake cinder or something? | 16:39 |
fried_rice | mostly retries in the actual code. | 16:39 |
fried_rice | the functional tests really need to sleep | 16:40 |
fried_rice | that's like wait_for_state_change stuff | 16:40 |
fried_rice | it's the sleeps in real code that I'm trying to poison | 16:40 |
dansmith | right, I mean what are the real code sleeps doing | 16:40 |
fried_rice | oh, mostly sleeps between retries | 16:40 |
fried_rice | so a unit test that tests retries is eating all that sleep time, when it really doesn't need that; it can just spin the retries immediately. | 16:40 |
fried_rice | adding @mock('sleep') is all you need to get that done, so it's easy. | 16:41 |
dansmith | this just seems kinda crazy invasive to save a few seconds in a few test cases, especially since you have to replace all the calls in the functional tests | 16:41 |
fried_rice | Understood. | 16:41 |
dansmith | not to mention the oslo hack and potential impact to other libraries | 16:41 |
fried_rice | I'm kind of attached to it since I spent a bunch of time on it, but I'll understand if you want to kill it. | 16:42 |
dansmith | would it not be better to just use that poison fixture where we're testing things that do a bunch of retries? | 16:42 |
*** ttsiouts has quit IRC | 16:42 | |
dansmith | or just a short-circuit fixture that collapses them to zero for those cases? | 16:42 |
fried_rice | that's the problem: you don't necessarily know ahead of time which tests are going to need that. | 16:43 |
*** slaweq has quit IRC | 16:43 | |
fried_rice | which is why I made it "global". | 16:43 |
fried_rice | I mean, if you're writing a test that tests retries, you *should* know, but most people don't think about that - which is why those "violations" were there. | 16:43 |
dansmith | you won't catch all the cases, but you should be able to profile the top ten waiting tests and add those | 16:43 |
fried_rice | yes, which is what I was doing when I came up with doing it this way instead. | 16:44 |
dansmith | sure, but... | 16:44 |
fried_rice | dansmith: https://review.openstack.org/#/c/643760/ | 16:44 |
*** wolverineav has joined #openstack-nova | 16:44 | |
fried_rice | dansmith: If you hate it, I'll just kill it and propose a patch that has the @mock(sleep) decorators I added there. Same improvement in the short term. No protection in the long term, but <shrug> I'll still sleep at night. | 16:45 |
fried_rice | Gotta run. | 16:45 |
*** fried_rice is now known as fried_rolls | 16:45 | |
*** helenaAM has quit IRC | 16:45 | |
dansmith | well, I hate it.. doesn't mean everyone will, but yeah. | 16:46 |
*** jmlowe has quit IRC | 16:46 | |
finucannot | dansmith: Seeing as you're on the subject of hating stuff, how do you feel about looking at something silly that Python does? https://review.openstack.org/#/c/647831/ | 16:49 |
dansmith | when am I not? | 16:50 |
dansmith | lemme finish this first | 16:50 |
finucannot | (y) | 16:50 |
*** igordc has joined #openstack-nova | 16:51 | |
* finucannot waves at igordc | 16:51 | |
finucannot | fried_rolls: Think I'm going to steal that poisoning technique of yours for privsep'y stuff | 16:53 |
finucannot | I'm guessing all that should be mocked in functional tests | 16:53 |
finucannot | though I bet sean-k-mooney would disagree | 16:53 |
*** gbarros has quit IRC | 16:53 | |
* igordc looks at finucannot's impressive surname downgrade | 16:54 | |
finucannot | Oh, nvm, we do that already (nova/tests/fixtures.py) but it's silently hidden or something. Odd | 16:54 |
finucannot | igordc: I thought it better captured my general usefulness | 16:54 |
igordc | finucannot, genius | 16:55 |
finucannot | I try ¯\_(ツ)_/¯ | 16:55 |
*** rpittau is now known as rpittau|afk | 16:57 | |
*** tssurya has quit IRC | 16:57 | |
mnaser | is latest python-novaclient broken under py3? | 17:01 |
mnaser | https://www.irccloud.com/pastebin/wuvud4K7/ | 17:01 |
mnaser | looks like its reported here https://bugs.launchpad.net/ubuntu/+source/python-novaclient/+bug/1777482 | 17:05 |
openstack | Launchpad bug 1777482 in python-novaclient (Ubuntu) "console-log ERROR (TypeError): write() argument must be str, not bytes" [Medium,Triaged] | 17:05 |
mnaser | python-openstackclient seems to not use the codec fanciness. https://github.com/openstack/python-openstackclient/blob/4bde9af89251431791fc8d69fe09d5e17a8fba8f/openstackclient/compute/v2/console.py#L64 | 17:06 |
mnaser | I dunno what's the best avenue | 17:06 |
*** dtantsur is now known as dtantsur|afk | 17:06 | |
*** jmlowe has joined #openstack-nova | 17:07 | |
sean-k-mooney | finucannot: of course i disagree. what wat the question so i know what postion i am ment to be taking :) | 17:13 |
*** owalsh has quit IRC | 17:15 | |
sean-k-mooney | finucannot: oh mocking in functional tests. it depends on what you are mocking but in general you shoul dnot mock in functional test but you might use different backend implementations | 17:16 |
sean-k-mooney | or test fixtures | 17:16 |
finucannot | sean-k-mooney: I'm seeing calls through to nova.privsep.utils.supports_direct_io | 17:16 |
*** owalsh has joined #openstack-nova | 17:17 | |
finucannot | from 'File "nova/virt/libvirt/driver.py", line 418, in disk_cachemode' | 17:17 |
finucannot | sean-k-mooney: I'm guessing we shouldn't be modifying system state | 17:17 |
sean-k-mooney | it depends on what the test was trying to assert but proably not | 17:18 |
sean-k-mooney | ah in this case its trying to determin the cache mode default i see | 17:19 |
finucannot | yup | 17:19 |
finucannot | There's another one too | 17:20 |
finucannot | we've got calls to 'nova.pci.utils.get_mac_by_pci_address' | 17:20 |
*** sambetts_ has quit IRC | 17:20 | |
finucannot | and they're failing, resulting in lots of "Could not find the expected sysfs file for determining the MAC address of the PCI device ..." messages in logs | 17:20 |
sean-k-mooney | why are we using the libvir driver here and not the fake one | 17:20 |
finucannot | It's for e.g. the 'test_create_server_with_pci_dev_and_numa_fails' test | 17:21 |
finucannot | that wouldn't make sense outside of libvirt | 17:21 |
sean-k-mooney | right we have sriov support in the fake libvirt driver | 17:21 |
finucannot | yup | 17:21 |
sean-k-mooney | so the fake libfir driver should just overrite the disk_cachemode porperty | 17:22 |
sean-k-mooney | finucannot: hyperv support pci passthough and numa too by the way | 17:23 |
finucannot | True, but I don't know how that works so building up a fake driver for that would be a lot more work :) | 17:24 |
*** sambetts_ has joined #openstack-nova | 17:24 | |
sean-k-mooney | its this test https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_sriov_servers.py#L244 | 17:24 |
sean-k-mooney | so ya you could just add a mock.patch i guess | 17:25 |
sean-k-mooney | finucannot: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L58 | 17:27 |
sean-k-mooney | so those tests are using the real libvirt driver but with a fake connection | 17:28 |
finucannot | Yeah, that's what I mean when I say fakelibvirt drive | 17:28 |
finucannot | fakelibvirt is pretty much a simulator | 17:28 |
finucannot | of libvirt itself | 17:28 |
sean-k-mooney | i tought you ment https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py | 17:29 |
sean-k-mooney | i guess that just impomentes the fake connection | 17:30 |
*** zhubx has quit IRC | 17:44 | |
*** slaweq has joined #openstack-nova | 17:44 | |
*** zhubx has joined #openstack-nova | 17:45 | |
*** jistr is now known as jistr|off | 17:45 | |
*** jistr|off is now known as jistr | 17:45 | |
*** psachin has quit IRC | 17:47 | |
*** Sundar has joined #openstack-nova | 17:52 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Stub out privsep modules https://review.openstack.org/648747 | 17:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Stub out os_vif https://review.openstack.org/648748 | 17:52 |
finucannot | sean-k-mooney: ^ | 17:53 |
finucannot | and with that, I take my leave | 17:53 |
*** finucannot is now known as stephenfin | 17:53 | |
sean-k-mooney | mdbooth: your porbaly sane and have left for the weekend but shoundt https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3945-L3969 use the disk cachemode set in the config https://github.com/openstack/nova/blob/master/nova/conf/libvirt.py#L639-L695 | 17:53 |
*** davidsha has quit IRC | 17:53 | |
sean-k-mooney | mdbooth: becasue im pretty sure it does not | 17:53 |
sean-k-mooney | stephenfin: not sure that returing NONE is what you want there but ill leave a comment in thereview | 17:55 |
*** wolverineav has quit IRC | 18:00 | |
*** wolverineav has joined #openstack-nova | 18:02 | |
*** jmlowe has quit IRC | 18:07 | |
*** mdbooth_ has joined #openstack-nova | 18:11 | |
*** mdbooth has quit IRC | 18:15 | |
*** jmlowe has joined #openstack-nova | 18:16 | |
*** cdent has quit IRC | 18:19 | |
*** ralonsoh has quit IRC | 18:29 | |
*** slaweq has quit IRC | 18:36 | |
*** luksky has joined #openstack-nova | 18:37 | |
*** pcaruana has quit IRC | 18:38 | |
*** avolkov has quit IRC | 18:41 | |
*** kmalloc is now known as needscoffee | 18:41 | |
*** awaugama has joined #openstack-nova | 18:44 | |
*** wolverineav has quit IRC | 18:47 | |
*** wolverineav has joined #openstack-nova | 18:49 | |
*** wolverineav has quit IRC | 18:50 | |
*** wolverineav has joined #openstack-nova | 18:53 | |
*** wolverineav has quit IRC | 18:58 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | 19:14 |
fried_rolls | stephenfin: You may also be interested in PrivsepFixture: https://review.openstack.org/#/c/647849/ | 19:14 |
*** fried_rolls is now known as fried_rice | 19:14 | |
fried_rice | stephenfin: If your test hits an *actual* privsep-wrapped method, it'll blow up on its own. | 19:17 |
*** tesseract-rh has quit IRC | 19:18 | |
*** gmann_afk is now known as gmann | 19:19 | |
*** dpawlik has joined #openstack-nova | 19:20 | |
*** lchabert has quit IRC | 19:29 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Mock time.sleep() in unit tests https://review.openstack.org/648762 | 19:29 |
*** lchabert has joined #openstack-nova | 19:31 | |
*** tbachman has quit IRC | 19:34 | |
mnaser | I've got a really interesting use case where I need to schedule on different GPUs with things like different *steppings*, with the possibility that a host might have different GPUs with different steppings but the *same* vendor id | 19:35 |
mnaser | so my questions are: does placement store records for all gpus? can I use traits to 'decorate' those gpus with those different steppings/etc? is there anything in nova that allows me to schedule based on "find me a gpu that has this trait" | 19:36 |
dansmith | fried_rice: answer my two little questions in there so I can make nice and +2 that | 19:39 |
fried_rice | ack | 19:40 |
fried_rice | mnaser: We don't have support for multiple VGPUs yet... | 19:40 |
fried_rice | and physical GPUs are not tracked in placement yet. | 19:40 |
*** awaugama has quit IRC | 19:40 | |
mnaser | fried_rice: okay, those are physical GPUs.. hmm okay, so this might probably have to be done in some other fashion | 19:41 |
fried_rice | cyborg is working on making the latter happen in Train (<== Sundar) | 19:41 |
fried_rice | mnaser: You should be able to swing it with PCI passthrough as long as you know which PCI IDs are which | 19:41 |
fried_rice | mnaser: make different PCI aliases for each group. | 19:41 |
dansmith | same pci id I think | 19:41 |
mnaser | fried_rice: well in this case, I have devices that identify the same pai id | 19:41 |
dansmith | so you'd need aggregates I think | 19:41 |
mnaser | PCI ID* | 19:41 |
fried_rice | Sorry, not PCI IDs | 19:42 |
fried_rice | PCI *addresses* | 19:42 |
mnaser | oh that's interesting | 19:42 |
mnaser | I didn't know we could do it based on PCI addresses | 19:42 |
* mnaser goes off to read nova code | 19:42 | |
dansmith | that'd be pretty laborious | 19:42 |
fried_rice | almost certain, lmk if you need help finding that. | 19:42 |
mnaser | dansmith: I have automation in place to 'identify' these cards | 19:43 |
fried_rice | Yes, it would be laborious, especially because you now need to do individual confs per compute. | 19:43 |
fried_rice | no more single conf sprayed around on the computes | 19:43 |
dansmith | mnaser: laborious for a script then, but still | 19:43 |
dansmith | much cleaner if you can just arrange to have them all in unified computes and segregate them by aggregate en bulk | 19:43 |
fried_rice | oh, and the aliases have to be on the api node too, IIRC. | 19:44 |
fried_rice | that could be problematic. | 19:44 |
mnaser | yeah. let's just say that there isn't enough of those cards of different steppings to sit on their own groups of computes | 19:44 |
dansmith | mnaser: the group doesn't have to be large :) | 19:44 |
mnaser | I think I can build aliases like card-foo-stepping-a card-foo-stepping-b | 19:44 |
fried_rice | except you want card-foo-stepping-a card-foo-stepless-b, right? | 19:45 |
mnaser | oh I see what you mean | 19:45 |
mnaser | no they're all very explicit | 19:45 |
mnaser | there won't be a "card a, don't care what stepping" likely happening | 19:46 |
mnaser | fried_rice: so I can whitelist things on the compute based on address, but it looks like the alias on the API layer is product/vendor ID only | 19:48 |
*** tosky has joined #openstack-nova | 19:48 | |
fried_rice | mm, that makes sense of course, and would be a problem | 19:48 |
dansmith | and unless we auto tag gpus in placement with steppings, placement support in the future won't help with this | 19:49 |
dansmith | except maybe let _you_ do the tagging, but again, aggregates (however small) are a better plan I think | 19:49 |
mnaser | yeah I was hoping to workaround the limitations of aggregates but it might not be the best | 19:50 |
mnaser | I mean I can manually tag things but if there's nothing in placement.. | 19:50 |
mnaser | I was thinking to avoid aggregates, I'd have all the same GPUs in the same box and have nova ship that out to scheduler as part of it's updates.. in some way | 19:51 |
mnaser | and then add a scheduler filter based on that, at least avoiding aggregates | 19:51 |
dansmith | I sense a pattern here... | 19:51 |
* mnaser really hates trying to be *too efficent* all the time | 19:52 | |
*** tbachman has joined #openstack-nova | 19:54 | |
openstackgerrit | Merged openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | 19:55 |
*** wolverineav has joined #openstack-nova | 19:57 | |
*** wolverineav has quit IRC | 19:57 | |
*** wolverineav has joined #openstack-nova | 19:57 | |
*** dpawlik has quit IRC | 19:57 | |
*** slaweq has joined #openstack-nova | 19:58 | |
fried_rice | dansmith: I'll remove the 0.1->0 bit; do you want me to undo the spelling fix or leave it? | 20:01 |
*** wolverineav has quit IRC | 20:01 | |
dansmith | fried_rice: oh, I was totally seeing things | 20:02 |
*** wolverineav has joined #openstack-nova | 20:02 | |
dansmith | I thought you were converting that _to_ a nodbtestcase | 20:02 |
dansmith | I dunno why | 20:02 |
fried_rice | oh, okay :) | 20:02 |
dansmith | I don't think spelling fixes belong in patches, but I shall look the other way in this case | 20:02 |
openstackgerrit | Eric Fried proposed openstack/nova master: Mock time.sleep() in unit tests https://review.openstack.org/648762 | 20:02 |
fried_rice | your selective blindness is appreciated. | 20:03 |
*** slaweq has quit IRC | 20:05 | |
*** wolverineav has quit IRC | 20:07 | |
*** dpawlik has joined #openstack-nova | 20:09 | |
*** slaweq has joined #openstack-nova | 20:11 | |
*** dpawlik has quit IRC | 20:14 | |
*** slaweq has quit IRC | 20:16 | |
*** wolverineav has joined #openstack-nova | 20:17 | |
*** jmlowe has quit IRC | 20:21 | |
*** owalsh has quit IRC | 20:25 | |
*** wolverineav has quit IRC | 20:26 | |
*** wolverineav has joined #openstack-nova | 20:27 | |
*** wolverineav has quit IRC | 20:32 | |
*** wolverineav has joined #openstack-nova | 20:32 | |
*** awaugama has joined #openstack-nova | 20:34 | |
*** wolverineav has quit IRC | 20:34 | |
*** wolverineav has joined #openstack-nova | 20:35 | |
*** mrhillsman is now known as mrhillsman_away4 | 20:40 | |
*** mrhillsman_away4 is now known as mrhillsman_wkend | 20:41 | |
*** Sundar has quit IRC | 20:45 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Style corrections for privsep usage. https://review.openstack.org/648615 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Improve test coverage of nova.privsep.path. https://review.openstack.org/648601 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Improve test coverage of nova.privsep.fs. https://review.openstack.org/648602 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued. https://review.openstack.org/648603 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 20:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Add test coverage for nova.privsep.libvirt. https://review.openstack.org/648616 | 20:45 |
*** munimeha1 has quit IRC | 20:59 | |
*** owalsh has joined #openstack-nova | 21:06 | |
openstackgerrit | Merged openstack/nova master: Move create of ComputeAPI object in websocketproxy https://review.openstack.org/644998 | 21:06 |
*** wolverineav has quit IRC | 21:08 | |
*** wolverineav has joined #openstack-nova | 21:10 | |
*** slaweq has joined #openstack-nova | 21:11 | |
*** wolverineav has quit IRC | 21:12 | |
*** jmlowe has joined #openstack-nova | 21:14 | |
*** wolverineav has joined #openstack-nova | 21:15 | |
*** slaweq has quit IRC | 21:15 | |
*** awaugama has quit IRC | 21:19 | |
*** owalsh_ has joined #openstack-nova | 21:19 | |
*** wolverineav has quit IRC | 21:20 | |
*** owalsh has quit IRC | 21:21 | |
*** phasespace has joined #openstack-nova | 21:22 | |
*** owalsh has joined #openstack-nova | 21:23 | |
*** owalsh_ has quit IRC | 21:24 | |
*** wolverineav has joined #openstack-nova | 21:31 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | 21:44 |
*** owalsh has quit IRC | 21:45 | |
*** igordc has quit IRC | 22:09 | |
*** slaweq has joined #openstack-nova | 22:11 | |
*** igordc has joined #openstack-nova | 22:13 | |
*** owalsh has joined #openstack-nova | 22:15 | |
*** slaweq has quit IRC | 22:16 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | 22:16 |
*** Vek has joined #openstack-nova | 22:40 | |
*** wolverineav has quit IRC | 22:51 | |
*** wolverineav has joined #openstack-nova | 23:01 | |
*** awalende has joined #openstack-nova | 23:08 | |
*** awalende has quit IRC | 23:13 | |
*** igordc has quit IRC | 23:30 | |
*** igordc has joined #openstack-nova | 23:33 | |
*** wolverineav has quit IRC | 23:45 | |
*** whoami-rajat has quit IRC | 23:47 | |
*** dklyle has quit IRC | 23:48 | |
*** david-lyle has joined #openstack-nova | 23:48 | |
*** tbachman has quit IRC | 23:50 | |
*** needscoffee is now known as kmalloc | 23:53 | |
openstackgerrit | Merged openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!