| *** erlon has joined #openstack-nova | 00:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200 | 00:09 |
|---|---|---|
| *** takashin has joined #openstack-nova | 00:10 | |
| *** stakeda has quit IRC | 00:13 | |
| *** tetsuro has joined #openstack-nova | 00:18 | |
| *** slaweq has joined #openstack-nova | 00:22 | |
| *** dustinc has quit IRC | 00:25 | |
| *** slaweq has quit IRC | 00:27 | |
| *** igordc has quit IRC | 00:48 | |
| *** markvoelker has joined #openstack-nova | 00:51 | |
| *** zhubx has quit IRC | 00:53 | |
| *** zhubx has joined #openstack-nova | 00:53 | |
| *** ileixe has joined #openstack-nova | 00:54 | |
| *** ileixe has quit IRC | 00:54 | |
| *** ileixe has joined #openstack-nova | 00:55 | |
| *** Sundar has quit IRC | 00:56 | |
| openstackgerrit | Magnus Bergman proposed openstack/nova master: Fix bug preventing forbidden traits from working https://review.openstack.org/647957 | 00:59 |
| trident | mriedem: Found the issue with forbidden flavor traits. See bug #1821824 and the proposed fix above ^ | 01:02 |
| openstack | bug 1821824 in OpenStack Compute (nova) "Forbidden traits in flavor properties don't work" [Undecided,In progress] https://launchpad.net/bugs/1821824 - Assigned to Magnus Bergman (magnusbe) | 01:02 |
| *** awalende has joined #openstack-nova | 01:02 | |
| *** markvoelker has quit IRC | 01:03 | |
| *** awalende has quit IRC | 01:07 | |
| *** tiendc has joined #openstack-nova | 01:07 | |
| *** wolverineav has quit IRC | 01:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: Capitalize keystone domain name https://review.openstack.org/647972 | 01:38 |
| openstackgerrit | yenai proposed openstack/nova master: Disconnect volume when encryption is failed https://review.openstack.org/632598 | 01:47 |
| *** rcernin has quit IRC | 01:49 | |
| *** rcernin has joined #openstack-nova | 01:53 | |
| *** erlon has quit IRC | 01:53 | |
| *** hongbin has joined #openstack-nova | 01:54 | |
| *** whoami-rajat has joined #openstack-nova | 02:08 | |
| *** mgagne has quit IRC | 02:15 | |
| *** mgagne has joined #openstack-nova | 02:15 | |
| yonglihe | alex_xu: please mark -1 for me, thanks everyone to stop by. https://review.openstack.org/#/c/627765/ | 02:24 |
| openstackgerrit | Merged openstack/nova master: Add a reference PTL guide to the contributor docs https://review.openstack.org/647854 | 02:25 |
| *** gbarros has joined #openstack-nova | 02:30 | |
| *** wolverineav has joined #openstack-nova | 02:34 | |
| *** psachin has joined #openstack-nova | 02:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Make os-services policies granular https://review.openstack.org/645427 | 02:52 |
| *** gbarros has quit IRC | 03:00 | |
| *** hongbin has quit IRC | 03:06 | |
| *** wolverineav has quit IRC | 03:08 | |
| *** wolverineav has joined #openstack-nova | 03:23 | |
| openstackgerrit | Merged openstack/nova master: Fix JsonFilter query hint examples in docs https://review.openstack.org/647778 | 03:45 |
| openstackgerrit | Merged openstack/nova master: Document a warning about using the JsonFilter https://review.openstack.org/647796 | 03:45 |
| *** udesale has joined #openstack-nova | 03:46 | |
| *** wolverineav has quit IRC | 03:49 | |
| *** wolverineav has joined #openstack-nova | 03:50 | |
| *** wolverineav has quit IRC | 03:54 | |
| *** tetsuro has quit IRC | 03:58 | |
| *** ileixe has quit IRC | 04:11 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 04:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 04:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 04:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 04:39 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 04:39 |
| *** udesale has quit IRC | 04:44 | |
| *** cfriesen has quit IRC | 04:46 | |
| *** udesale has joined #openstack-nova | 04:46 | |
| *** janki has joined #openstack-nova | 04:50 | |
| *** psachin has quit IRC | 04:58 | |
| *** ileixe has joined #openstack-nova | 05:08 | |
| *** tetsuro has joined #openstack-nova | 05:18 | |
| *** psachin has joined #openstack-nova | 05:19 | |
| *** lbragstad has joined #openstack-nova | 05:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200 | 05:38 |
| *** lbragstad has quit IRC | 05:41 | |
| *** ratailor has joined #openstack-nova | 05:41 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Scheduler filters evaluated even forced host https://review.openstack.org/645520 | 05:57 |
| *** alex_xu has quit IRC | 06:23 | |
| *** jaosorior has quit IRC | 06:26 | |
| *** jaosorior has joined #openstack-nova | 06:28 | |
| *** alex_xu has joined #openstack-nova | 06:29 | |
| *** markvoelker has joined #openstack-nova | 06:31 | |
| *** liuyulong has joined #openstack-nova | 06:32 | |
| *** jistr is now known as jistr|doc | 06:33 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Scheduler filters evaluated even forced host https://review.openstack.org/645458 | 06:51 |
| *** avolkov has joined #openstack-nova | 07:18 | |
| *** slaweq has joined #openstack-nova | 07:20 | |
| *** dpawlik has quit IRC | 07:20 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Drop legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/640219 | 07:23 |
| openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | 07:23 |
| openstackgerrit | Boxiang Zhu proposed openstack/python-novaclient master: [WIP] Add force_scheduler in boot instance https://review.openstack.org/647671 | 07:26 |
| *** rpittau|afk is now known as rpittau | 07:35 | |
| *** ivve has joined #openstack-nova | 07:47 | |
| *** liuyulong_ has joined #openstack-nova | 07:51 | |
| *** liuyulong has quit IRC | 07:54 | |
| *** luksky has joined #openstack-nova | 08:03 | |
| *** liuyulong_ has quit IRC | 08:04 | |
| *** takashin has left #openstack-nova | 08:06 | |
| *** tesseract has joined #openstack-nova | 08:13 | |
| *** awalende has joined #openstack-nova | 08:16 | |
| *** tkajinam has quit IRC | 08:16 | |
| *** tosky has joined #openstack-nova | 08:17 | |
| *** dtantsur|afk is now known as dtantsur | 08:32 | |
| *** dpawlik has joined #openstack-nova | 08:37 | |
| *** ccamacho has joined #openstack-nova | 08:38 | |
| *** helenafm has joined #openstack-nova | 08:44 | |
| *** sridharg has quit IRC | 08:54 | |
| *** sridharg has joined #openstack-nova | 08:56 | |
| *** pcaruana has joined #openstack-nova | 08:57 | |
| *** ttsiouts has joined #openstack-nova | 09:00 | |
| openstackgerrit | Boxiang Zhu proposed openstack/python-novaclient master: [WIP] Add force_scheduler in boot instance https://review.openstack.org/647671 | 09:00 |
| openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance https://review.openstack.org/641210 | 09:01 |
| *** ttsiouts has quit IRC | 09:10 | |
| *** tetsuro has quit IRC | 09:12 | |
| *** ttsiouts has joined #openstack-nova | 09:13 | |
| *** jistr|doc is now known as jistr | 09:15 | |
| *** priteau has joined #openstack-nova | 09:16 | |
| *** tssurya has joined #openstack-nova | 09:18 | |
| *** dr_gogeta86 has joined #openstack-nova | 09:38 | |
| *** derekh has joined #openstack-nova | 09:39 | |
| *** davidepanarese_ has joined #openstack-nova | 09:40 | |
| davidepanarese_ | Hello everyone | 09:40 |
| *** ralonsoh has joined #openstack-nova | 09:42 | |
| davidepanarese_ | anyone knows if automatic rescan of cinder external volume using ceph in nova will be implemented? Or better, is already exists a method to rescan virtio drives (ceph volumes) into kvm virtual machine after a live volume resize? | 09:44 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 09:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug #1819460 in functional test https://review.openstack.org/642444 | 09:49 |
| openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | 09:49 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 09:49 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug #1819460 in functional test https://review.openstack.org/642444 | 09:57 |
| openstack | bug 1819460 in OpenStack Compute (nova) "instance stuck in BUILD state due to unhandled exceptions in conductor" [Low,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | 09:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 09:57 |
| openstackgerrit | Merged openstack/nova master: Add functional recreate test for bug 1819963 https://review.openstack.org/643151 | 10:03 |
| openstack | bug 1819963 in OpenStack Compute (nova) "Reverting a resize does not update the instance.availability_zone value to the source az" [Medium,In progress] https://launchpad.net/bugs/1819963 - Assigned to Matt Riedemann (mriedem) | 10:03 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 10:05 |
| *** dpawlik has quit IRC | 10:34 | |
| *** dpawlik has joined #openstack-nova | 10:35 | |
| *** tbachman has quit IRC | 10:41 | |
| frickler | davidepanarese_: there is this recent patch that iiuc should handle your use case https://review.openstack.org/613039 | 10:43 |
| *** kaisers has quit IRC | 10:47 | |
| *** kaisers has joined #openstack-nova | 10:49 | |
| *** mvkr has joined #openstack-nova | 10:51 | |
| *** rcernin has quit IRC | 10:51 | |
| *** tiendc has quit IRC | 10:51 | |
| *** IvensZambrano has joined #openstack-nova | 10:53 | |
| *** hughsaunders has quit IRC | 11:03 | |
| *** zbr|ssbarnea has quit IRC | 11:06 | |
| *** zbr has joined #openstack-nova | 11:08 | |
| *** cdent has joined #openstack-nova | 11:08 | |
| *** IvensZambrano has quit IRC | 11:15 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | 11:18 |
| kaisers | mdbooth_: thanks for looking into https://review.openstack.org/#/c/554195/28 . Could you update your -1 if you're fine with the follow up as proposed? | 11:32 |
| *** ratailor has quit IRC | 11:37 | |
| *** davidepanarese_ has quit IRC | 11:59 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Remove flavor id and name validation code because of jsonschema validation. https://review.openstack.org/638150 | 12:04 |
| *** tbachman has joined #openstack-nova | 12:05 | |
| *** tbachman has quit IRC | 12:09 | |
| *** tbachman has joined #openstack-nova | 12:13 | |
| *** avolkov has quit IRC | 12:18 | |
| *** markvoelker has quit IRC | 12:21 | |
| *** mchlumsky has joined #openstack-nova | 12:22 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: [Stable Only] hardware: Handle races during pinning https://review.openstack.org/647831 | 12:30 |
| *** liuyulong_zzzZ is now known as liuyulong | 12:31 | |
| *** mvkr has quit IRC | 12:37 | |
| *** pcaruana has quit IRC | 12:39 | |
| *** cdent has quit IRC | 12:40 | |
| *** pcaruana has joined #openstack-nova | 12:42 | |
| *** pcaruana has quit IRC | 12:42 | |
| *** pcaruana has joined #openstack-nova | 12:43 | |
| *** mdbooth_ is now known as mdbooth | 12:44 | |
| mdbooth | kaisers: Sure. As I said though, the only thing I was -1 about was the comment. If you stick that in the follow-on I'll happily update, esp as you can keep the +2 from stephenfin. | 12:45 |
| *** lbragstad has joined #openstack-nova | 12:46 | |
| *** udesale has quit IRC | 12:48 | |
| *** udesale has joined #openstack-nova | 12:49 | |
| kaisers | mdbooth: ok, will do :) | 12:50 |
| *** gbarros has joined #openstack-nova | 12:51 | |
| *** gbarros has quit IRC | 12:51 | |
| *** itlinux has quit IRC | 12:57 | |
| *** ileixe has quit IRC | 13:04 | |
| *** jhesketh has quit IRC | 13:10 | |
| *** mvkr has joined #openstack-nova | 13:12 | |
| *** gbarros has joined #openstack-nova | 13:14 | |
| *** eharney has joined #openstack-nova | 13:23 | |
| openstackgerrit | François Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | 13:30 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Adds systemd detection result caching in Quobyte driver https://review.openstack.org/648093 | 13:36 |
| kaisers | mdbooth: done----^ | 13:38 |
| mdbooth | kaisers: Meh, my preference is for long form, but it works | 13:43 |
| mdbooth | kaisers: Updated, thanks! | 13:44 |
| *** priteau has quit IRC | 13:44 | |
| kaisers | mdbooth: thanks for looking into this | 13:52 |
| *** hongbin has joined #openstack-nova | 13:56 | |
| *** mlavalle has joined #openstack-nova | 14:01 | |
| *** igordc has joined #openstack-nova | 14:03 | |
| *** cdent has joined #openstack-nova | 14:19 | |
| *** itlinux has joined #openstack-nova | 14:27 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | 14:27 |
| *** janki has quit IRC | 14:41 | |
| *** munimeha1 has joined #openstack-nova | 14:45 | |
| *** priteau has joined #openstack-nova | 14:46 | |
| *** awaugama has joined #openstack-nova | 14:47 | |
| *** derekh has quit IRC | 14:53 | |
| *** ratailor has joined #openstack-nova | 14:54 | |
| bauzas | cores, https://review.openstack.org/#/c/647519/ is a RC potential https://etherpad.openstack.org/p/nova-stein-rc-potential | 14:54 |
| openstackgerrit | Dan Smith proposed openstack/os-traits master: Add IMAGE_TYPE_SUPPORT_* traits https://review.openstack.org/648147 | 14:56 |
| *** cfriesen has joined #openstack-nova | 15:01 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Refactor CONTRIBUTING.rst https://review.openstack.org/640970 | 15:01 |
| efried | bauzas, dansmith: Should we be cutting an RC2 just for a doc? | 15:03 |
| bauzas | efried: well, maybe not | 15:04 |
| efried | I don't think there's anything else we would be including | 15:04 |
| dansmith | no | 15:04 |
| efried | sean-k-mooney's lower-constraints fix is on the list | 15:04 |
| bauzas | we should be just merging it now for master | 15:04 |
| bauzas | then I'd backport it to stein | 15:04 |
| efried | ++ | 15:04 |
| dansmith | after ga | 15:04 |
| bauzas | but it could be not needing a RC2 | 15:04 |
| efried | ...but the lower-constraints thing has been busted for a while. | 15:04 |
| bauzas | so +W the stein backport after GA | 15:04 |
| bauzas | unless we find other bugs | 15:04 |
| bauzas | and then we could merge it with the other fixes | 15:05 |
| bauzas | but yeah, not needing a RC2 just for it | 15:05 |
| *** awalende has quit IRC | 15:11 | |
| *** artom has quit IRC | 15:11 | |
| *** awalende has joined #openstack-nova | 15:12 | |
| trident | cdent: Are you around to answer a couple of questions about the implementation of forbidden traits? | 15:15 |
| *** awalende has quit IRC | 15:16 | |
| cdent | trident: I am around, either here or in #openstack-placement. Not promising I'll be able to help | 15:16 |
| efried | trident: Is this about https://review.openstack.org/647957 ? | 15:17 |
| trident | cdent: I am working on an issue that prevents forbidden traits in flavors from being acted upon: https://review.openstack.org/#/c/647957/ While working on some tests I found that traits of the trait:CUSTOM_FOO=forbidden in image properties doesn't seem to work either. Is that expected or should they work both for flavors and images? | 15:19 |
| trident | efried: Yup. | 15:19 |
| efried | gibi: if you're around, you may want to join in ^ | 15:19 |
| * gibi is present | 15:19 | |
| cdent | trident: is the issue that the wrong request is built and sent to placement, or that placement is behaving incorrectly with a valid request? | 15:20 |
| efried | Mm, I don't remember whether we have implemented support for traits (positive or negative) coming from image props yet. | 15:20 |
| gibi | efried: did we ever said that forbidden trait support is a thing in nova? in placement I know that it is a thing | 15:20 |
| sean-k-mooney | efried: bauzas well my lower constraitn fix is not complete | 15:20 |
| gibi | efried: similarly placement had support for nested a_c for a while but nova need a lot of adaptation to use it | 15:21 |
| trident | efried: The wrong request is sent to placement. | 15:21 |
| efried | sean-k-mooney: I suspect that would be a clusterf*** to backport in any case, so we may want to consider just fixing it in master and moving on. | 15:21 |
| trident | This is the commit implementing it: https://github.com/openstack/nova/commit/2c51688558504f2e8ce80bac06642772be67b2a9 | 15:21 |
| efried | trident: Yup, that looks like it's pulling from flavor extra_specs; do you have any evidence that we did same for image props? | 15:22 |
| trident | Sorry, cdent: The wrong request is sent to placement. | 15:22 |
| sean-k-mooney | efried: ya. the main thing i need to figure out is where the mocking of rabbitmq is borked so that we use the fake message bus when running the unit tests in all cases | 15:22 |
| efried | sean-k-mooney: I'll ask you about it in tomorrow's meeting, but I'm expecting we won't want to try to put it in stein RC2 even if you do get it all fixed up by then. | 15:23 |
| cdent | trident: that patch is only doing it for flavor extra specs | 15:24 |
| gibi | trident: the linked bp https://blueprints.launchpad.net/nova/+spec/forbidden-traits-in-nova explicitly talks about flavor extra_spec so I think there was no intention to support it from image metadata | 15:24 |
| sean-k-mooney | efried: ya that is fair. we can consider backporting it when i have the final fix. | 15:24 |
| efried | trident: It is something we've discussed doing, for sure, but I don't think we've implemented it yet. | 15:24 |
| sean-k-mooney | efried: actully one thing i might try is fixing it on the stabel branches and see if they pass | 15:24 |
| trident | efried, cdent: I am a little bit of a newbie when it comes to the code base, that's why I am asking. But my understanding from following the code path is that the logic for getting forbidden traits from image props is not there. Just wanted to verify that before putting more time into it. | 15:24 |
| cdent | yes, it's not there | 15:25 |
| efried | We do support positive traits from image props, nah? | 15:25 |
| * efried goes looking... | 15:25 | |
| sean-k-mooney | efried: we do | 15:25 |
| trident | efried: Yes. | 15:25 |
| efried | wherezat code? | 15:25 |
| cdent | it's a thing that ought to exist, I think it just didn't happen yet. Perhaps because we couldn't decide precedence? I can't remember | 15:26 |
| sean-k-mooney | in the schduler uitls i think one sec | 15:26 |
| trident | efried: https://github.com/openstack/nova/blob/771e102654b54d257f437f16be2aeeef51fa0783/nova/scheduler/utils.py#L186 | 15:26 |
| sean-k-mooney | yep ^ which is called by resources_from_request_spec | 15:27 |
| *** eharney has quit IRC | 15:28 | |
| sean-k-mooney | and i think but i woudl have to confim when we build the request spec we grab the image properties form a voluem in the bfv case so it should also work in that case too | 15:28 |
| *** eharney has joined #openstack-nova | 15:29 | |
| sean-k-mooney | there may however be the same issue. the traits are part of the unnumbered request group which is matched agaist the compute node RP but if we did nto requerst any resouces form it that would not work correctly | 15:29 |
| efried | sean-k-mooney: Yup, same issue we've been thrashing in mriedem's multiattach capability patch. | 15:30 |
| gibi | sean-k-mooney: we don't have to solve the empty unnumbered group issue yet. That will happen when NUMA is modelled in placement. And it requires a lot of other changes | 15:30 |
| efried | I think we decided that *right now* we always request resources in the unnumbered group for the root RP. | 15:31 |
| efried | so <sweep under rug> | 15:31 |
| efried | <fingers in ears> | 15:31 |
| sean-k-mooney | gibi: ya that true | 15:31 |
| efried | <problem for future us> | 15:31 |
| trident | So supporting forbidden traits in image props as well seems like a clear case of something that would make sense to implement. But out of scope of what I am working on with this bug. (had it just been a similar bug as with forbidden traits in flavors I might as well just have fixed it while I was at it). | 15:31 |
| sean-k-mooney | efried: easy fix. all compute node have a inventory of instnace which match the max instance per host value that in the nova.conf | 15:31 |
| sean-k-mooney | and all vms in the futre requerst one allocation of an instance resouce class | 15:32 |
| efried | trident: Right. I agree it's something that makes sense to implement, though we would probably want a clear use case / demand before prioritizing the work. | 15:32 |
| sean-k-mooney | efried: we could allso kill one of the filter if we did that | 15:32 |
| sean-k-mooney | specifically we could kill this filter https://github.com/openstack/nova/blob/master/nova/scheduler/filters/num_instances_filter.py | 15:33 |
| efried | sean-k-mooney: that would require us to tack on that "resource" to every request | 15:33 |
| sean-k-mooney | efried: yes | 15:33 |
| efried | because we can't expect it to be in flavors. | 15:33 |
| sean-k-mooney | but i think that would be fine | 15:33 |
| sean-k-mooney | it requires not change to placement | 15:33 |
| sean-k-mooney | and this is really a nova specific issue with a nova specific fix | 15:33 |
| efried | trident: So given that it's *not* supported currently, do you actually have any other way of introducing a forbidden trait that doesn't get picked up by the scheduler? | 15:33 |
| efried | trident: but still conforms to the rules ("you can't have a request group with no resources")? | 15:34 |
| efried | sean-k-mooney: Isn't there a way to set max instances per host to unlimited? | 15:35 |
| *** udesale has quit IRC | 15:35 | |
| sean-k-mooney | yes but i think max int is close enough | 15:35 |
| gibi | famous last words :) | 15:36 |
| trident | efried: Yes. My initial issue and what the bug report / review is about is when introducing it from flavors. So, that still stands. | 15:36 |
| efried | sean-k-mooney: Could work. Seems like a pretty heavy solution, not sure if it's worth it. But we could talk about it at the PTG if you're into it. | 15:36 |
| trident | efried: And that is supposed to be supported. | 15:36 |
| sean-k-mooney | efried: if you think there may be some merrit in it i can write up a short spec proposing how it would work | 15:36 |
| efried | trident: Okay, so the very best thing you could do is what gibi suggested: come up with a functional test case that demonstrates it being broken. | 15:37 |
| sean-k-mooney | we could proably make it opt in via a config and a prefilter. | 15:37 |
| efried | sean-k-mooney: I have no opinion. It seems like a messy solution to something that's not really a problem. | 15:37 |
| efried | (I guess that's an opinion) | 15:37 |
| *** wolverineav has joined #openstack-nova | 15:37 | |
| efried | sean-k-mooney: I just think we have more important things to focus on for train. | 15:38 |
| efried | it would be nice if we had a future/wishlist bucket we could put such things into... | 15:38 |
| sean-k-mooney | sure it was just a taught | 15:38 |
| trident | efried: That, I have done. Looking at unit tests at the moment as well. | 15:38 |
| efried | trident: Sweet. We'll look for that patch. Thanks for working on this! | 15:39 |
| sean-k-mooney | i might just write it up as a way to migrate eh numInstacnefilter to placemetn and we can decide to do it if/when it makes sense | 15:39 |
| efried | sean-k-mooney: ++ | 15:39 |
| gibi | trident: hit me with the patch adding the functional test and I can review it quickly | 15:40 |
| *** ratailor has quit IRC | 15:41 | |
| trident | I have two questions related to the functional tests and the review flow. First, Looking at the test on https://github.com/openstack/nova/blob/771e102654b54d257f437f16be2aeeef51fa0783/nova/tests/functional/test_servers.py#L4524 , wouldn't that one potentially pass around 50% of the times even if the required flavor didn't work? When it ends up on the expected node out of chance? | 15:42 |
| gibi | trident: looking | 15:44 |
| sean-k-mooney | trident yes and no | 15:45 |
| sean-k-mooney | the use of VMX is unfortuete | 15:45 |
| sean-k-mooney | the upsteam ci does not provide nested vert | 15:45 |
| gibi | sean-k-mooney: this is functional test so no virt layer is involved | 15:45 |
| sean-k-mooney | ya just realised that | 15:46 |
| sean-k-mooney | as i was typeing | 15:46 |
| efried | trident: The point of that test is that the flavor (not the image) contains the required trait | 15:46 |
| gibi | trident: I think this test can pass half of the time | 15:46 |
| trident | The second one, how should I submit the functional tests for review? In the same commit or some other way to get it in as a "related change"? I imagine we would like to first see it fail and then not fail with the patch. | 15:46 |
| efried | trident: So it should always land on the host that exposes that trait. | 15:46 |
| efried | trident: A good way to do it is to propose a patch with the test code that demonstrates the broken behavior with a FIXME or TODO comment describing what's supposed to happen, and Related-Bug: #XXXXX in the commit message | 15:47 |
| gibi | trident: I agree with efried ^^ | 15:47 |
| sean-k-mooney | well it depend on if you are fixing a bug or writing a new feature | 15:47 |
| efried | trident: Then propose the fix as a separate commit on top of that one (in a series) which removes the FIXME and demonstrates the correct behavior. This one includes Closes-Bug: #XXXXX in the commit message. | 15:47 |
| efried | sean-k-mooney: We're talking about a bug | 15:47 |
| sean-k-mooney | ah then i think we have a doc for this | 15:48 |
| efried | sean-k-mooney: bug 1821824 | 15:48 |
| openstack | bug 1821824 in OpenStack Compute (nova) "Forbidden traits in flavor properties don't work" [Undecided,In progress] https://launchpad.net/bugs/1821824 - Assigned to Magnus Bergman (magnusbe) | 15:48 |
| trident | efried: Exactly, and it verifies that it ends up on the correct host. But, if traits are not passed it will end up on any one of the two nodes, so the verification will pass when it by chance end up on the host expected by the test. | 15:48 |
| sean-k-mooney | in that case yes two patch one that intoduces the fuctional test that intentonlly assert the broken behavior or has the skip expect fail decortor and the a follow up that fixes it is the best way to go | 15:49 |
| efried | trident: Correct. But we don't (or shouldn't) have a test case that behaven that way. | 15:49 |
| efried | behaves* | 15:49 |
| *** wolverineav has quit IRC | 15:49 | |
| trident | efried: So, I should remove the fix from my branch, add the test cases and re submit for review. And then add the fix and submit again. Right? | 15:52 |
| trident | efried: Yeah, so I am right in my conclusion that the current test that I pointed to is buggy and should be fixed as well? | 15:53 |
| gibi | trident: yes, I think so | 15:53 |
| efried | gibi, trident: I don't see the bug in the test | 15:55 |
| gibi | efried: there are two hosts and only compute1 has the required trait | 15:56 |
| efried | gibi: Right. That's the whole point of the test. | 15:57 |
| efried | the flavor is requiring that trait | 15:57 |
| efried | so we should always land on the host with that trait. | 15:57 |
| gibi | efried: so if the required trait handling is broken then this test only pass by chance | 15:57 |
| efried | oic | 15:57 |
| efried | right | 15:57 |
| efried | but trident wasn't saying the *required* trait handling was broken. | 15:57 |
| efried | He was saying the *forbidden* trait handling was broken. | 15:57 |
| efried | (I thought) | 15:58 |
| efried | so duplicating that test case with forbidden traits would be a good start to the test case. | 15:58 |
| efried | you could implement a weigher that would normally prefer the "wrong" host so you could get consistent results. | 15:58 |
| efried | like this: https://review.openstack.org/#/c/647811/1/nova/tests/functional/test_json_filter.py | 15:59 |
| *** gbarros has quit IRC | 15:59 | |
| openstackgerrit | Dan Smith proposed openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_SUPPORT_* traits https://review.openstack.org/648147 | 15:59 |
| trident | efried: That's my point. If duplicating that test, I'll get a test for forbidden traits that also will pass half of the times even if the forbidden trait is not passed. | 15:59 |
| efried | trident: see above, implement a weigher to make the scheduler behavior deterministic | 15:59 |
| *** tbachman has quit IRC | 16:00 | |
| trident | efried: Ah, nice. That sounds like a good solution. I have already implemented a test that sets the forbidden trait on both hosts and verifies that it gets into error. | 16:00 |
| efried | sweet | 16:01 |
| efried | ...gets into error only after your fix is in place, though? | 16:01 |
| trident | Yes. | 16:01 |
| gibi | efried, trident: I would suggest to disable the host that has the trait and asser that the boot fails | 16:01 |
| efried | that would work too. | 16:01 |
| gibi | it is easier than implementing a weigher, I think | 16:01 |
| efried | trident: So yeah, it's definitely important that we see your test case in "before" and "after" states. | 16:01 |
| trident | Before the fix it doesn't get into error. | 16:02 |
| efried | if you put it all in one patch, we have to pull down the patch and remove your fix manually and run the tests to see that they fail. | 16:02 |
| efried | cool | 16:02 |
| gibi | I agree ^^ | 16:02 |
| efried | ocraplookatthetime | 16:02 |
| * efried gotta run | 16:02 | |
| *** efried is now known as efried_rollin | 16:02 | |
| trident | Great. I'll clean it up a little, get one node disabled and submit something by tomorrow. Thanks everyone for the assistance! | 16:04 |
| gibi | trident: thanks for the effort! | 16:05 |
| *** artom has joined #openstack-nova | 16:06 | |
| *** artom has quit IRC | 16:06 | |
| *** artom has joined #openstack-nova | 16:07 | |
| openstackgerrit | Merged openstack/nova master: Add doc on VGPU allocs and inventories for nrp https://review.openstack.org/647519 | 16:14 |
| *** gyee has joined #openstack-nova | 16:17 | |
| *** imacdonn has quit IRC | 16:22 | |
| *** imacdonn has joined #openstack-nova | 16:23 | |
| *** helenafm has quit IRC | 16:28 | |
| *** mrch_ has quit IRC | 16:32 | |
| *** cdent has quit IRC | 16:34 | |
| *** ttsiouts has quit IRC | 16:34 | |
| *** ttsiouts has joined #openstack-nova | 16:35 | |
| *** tssurya has quit IRC | 16:39 | |
| *** ttsiouts has quit IRC | 16:40 | |
| *** dustinc has joined #openstack-nova | 16:52 | |
| *** wolverineav has joined #openstack-nova | 16:55 | |
| *** wolverineav has quit IRC | 17:00 | |
| *** gbarros has joined #openstack-nova | 17:01 | |
| *** tesseract-rh has joined #openstack-nova | 17:09 | |
| *** tesseract has quit IRC | 17:09 | |
| *** wolverineav has joined #openstack-nova | 17:11 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | 17:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 17:12 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 17:12 |
| *** wolverineav has quit IRC | 17:13 | |
| melwitt | dansmith: do you think there would be any issues with having a module global ComputeAPI instance in console proxy? discussion in this patch of mine https://review.openstack.org/644998 | 17:13 |
| *** wolverineav has joined #openstack-nova | 17:13 | |
| *** rpittau is now known as rpittau|afk | 17:13 | |
| dansmith | melwitt: I think the only state computeapi maintains is the compute rpc instance right? | 17:14 |
| melwitt | dansmith: I believe so | 17:14 |
| dansmith | I don't remember how SIGHUP wires into triggering that to re-calculate the pins, so that would be my only concern I think | 17:14 |
| dansmith | but otherwise probably fine | 17:14 |
| dansmith | oh wait | 17:15 |
| dansmith | you mean rpcapi/ComputeAPI yeah? | 17:15 |
| melwitt | dansmith: ok, I'll look into it. thanks | 17:15 |
| melwitt | yeah, I do. sorry | 17:15 |
| dansmith | I was thinking you meant compute_api/TheThingWhatever | 17:16 |
| melwitt | I was just realizing there's two different ones | 17:16 |
| melwitt | yeah | 17:16 |
| dansmith | so confusing that they're ... confusing | 17:16 |
| dansmith | melwitt: yeah so right now that rpcapi gets created each time, which means it's never stale (but also means it's doing a calculation on every load) | 17:16 |
| dansmith | so I think you'd want to make sure to wire up the sighup like the other services use to bump it | 17:16 |
| dansmith | assuming that oslo.service gets fixed of course :) | 17:17 |
| melwitt | I see, ok | 17:17 |
| *** cdent has joined #openstack-nova | 17:17 | |
| *** dtantsur is now known as dtantsur|afk | 17:21 | |
| *** wolverineav has quit IRC | 17:24 | |
| *** wolverineav has joined #openstack-nova | 17:26 | |
| *** priteau has quit IRC | 17:27 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Change the TODO to NOTE about instance multi-create https://review.openstack.org/638847 | 17:27 |
| *** gbarros has quit IRC | 17:29 | |
| *** wolverineav has quit IRC | 17:30 | |
| *** wolverineav has joined #openstack-nova | 17:30 | |
| *** mdbooth has quit IRC | 17:35 | |
| *** psachin has quit IRC | 17:36 | |
| melwitt | dansmith: hm, the console proxies don't actually use oslo.service. they are websockify servers, and it looks like websockify currently ignores SIGHUP https://github.com/novnc/websockify/blob/master/other/websocket.c#L768 | 17:39 |
| *** priteau has joined #openstack-nova | 17:43 | |
| *** mvkr has quit IRC | 17:44 | |
| dansmith | melwitt: ah, aight then | 17:45 |
| dansmith | melwitt: it still means it's a change from current, but maybe more meh | 17:45 |
| *** eharney has quit IRC | 17:47 | |
| melwitt | dansmith: yeah. in my patch currently, I have rpcapi/ComputeAPI still as a class variable, but I'm relying on knowing the order of calls internally in websockify. making ComputeAPI global would eliminate that, but then I wouldn't be able to handle SIGHUP | 17:49 |
| dansmith | well, it doesn't matter now because it's instantiated per request right? | 17:50 |
| dansmith | meaning, no need for sighup currently, but after your change... | 17:50 |
| melwitt | per connection yeah | 17:50 |
| melwitt | yeah, if I make it global. I didn't make it global yet. maybe it's better to leave it as it is, per connection. because relying on the websockify call ordering seems less bad | 17:51 |
| dansmith | yeah | 17:57 |
| *** wolverineav has quit IRC | 18:08 | |
| *** gbarros has joined #openstack-nova | 18:10 | |
| *** wolverineav has joined #openstack-nova | 18:10 | |
| *** wolverineav has quit IRC | 18:12 | |
| *** wolverineav has joined #openstack-nova | 18:12 | |
| *** ralonsoh has quit IRC | 18:16 | |
| *** tesseract-rh has quit IRC | 18:29 | |
| *** cdent has quit IRC | 18:36 | |
| *** priteau has quit IRC | 18:43 | |
| *** eharney has joined #openstack-nova | 18:47 | |
| *** wolverineav has quit IRC | 18:55 | |
| *** wolverineav has joined #openstack-nova | 18:56 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 18:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 19:00 |
| *** wolverineav has quit IRC | 19:00 | |
| *** artom has quit IRC | 19:06 | |
| sean-k-mooney | so related to ^ i am currently porposing a change to neutron so that they will tell us when network events are sent so we can do that sanely https://review.openstack.org/#/c/645173/2 | 19:08 |
| *** hongbin has quit IRC | 19:15 | |
| *** gbarros has quit IRC | 19:22 | |
| *** hongbin has joined #openstack-nova | 19:28 | |
| *** wolverineav has joined #openstack-nova | 19:29 | |
| *** sridharg has quit IRC | 19:30 | |
| *** wolverineav has quit IRC | 19:34 | |
| *** efried_rollin is now known as efried | 19:45 | |
| *** IvensZambrano has joined #openstack-nova | 19:51 | |
| *** wolverineav has joined #openstack-nova | 19:51 | |
| *** erlon has joined #openstack-nova | 19:53 | |
| *** pcaruana has quit IRC | 19:53 | |
| *** mdbooth has joined #openstack-nova | 19:57 | |
| efried | melwitt: I thought the concern was that we would do a bunch of init on ComputeAPI objects that ended up not being used | 19:59 |
| efried | melwitt: in which case lazy load (but no global/singleton) would work okay, right? | 19:59 |
| *** IvensZambrano has quit IRC | 20:02 | |
| *** lbragstad has quit IRC | 20:05 | |
| *** hongbin has quit IRC | 20:07 | |
| *** erlon has quit IRC | 20:09 | |
| melwitt | efried: oh, you mean in new_websocket_client? hm, I guess that should work. from the pre-existing code comment, I was thinking it needed to be instantiated ahead of new_websocket_client, but I can try that and see if the tempest novnc tests pass | 20:19 |
| melwitt | it = ComputeAPI | 20:20 |
| efried | melwitt: I'm saying, instantiate it in the same place, but through a lazy loader | 20:21 |
| efried | so it only actually initializes if you get down into new_websocket_client | 20:21 |
| efried | but in the code paths that never get there, nothing ever happens to it and you don't waste the... whatever | 20:21 |
| efried | but that way you don't have to worry about if like the code path changes from underneath you | 20:21 |
| melwitt | efried: what is a "lazy loader"? I was thinking in __init__ it's set to None, in new_websocket_client, it's instantiated if None | 20:22 |
| efried | We did a thing with this for the scheduler client at some point (we have since removed it) | 20:22 |
| * efried looks... | 20:22 | |
| melwitt | that's how lazy load works underneath. won't be instantiated until use. I had thought from the pre-existing comment, it was saying it needed to be instantiated before new_websocket_client, but I don't see why it wouldn't work to instantiate it (once, if None) in new_websocket_client | 20:25 |
| efried | melwitt: https://github.com/openstack/nova/blob/stable/queens/nova/scheduler/client/__init__.py | 20:25 |
| melwitt | yeah, that's what I'm already saying I think | 20:26 |
| efried | melwitt: I'm saying we shouldn't rely on new_websocket_client continuing to be the right place to do that init, in case the code flow changes underneath us. | 20:26 |
| melwitt | efried: I get what you're saying, I'm saying I had thought from the existing code comment that it couldn't be that way. but I can try it and see what happens | 20:26 |
| efried | so you keep it in init as | 20:26 |
| efried | compute_api = LazyLoader(...) | 20:26 |
| efried | oh | 20:27 |
| melwitt | because what LazyLoader will do is what I said, construct a ComputeAPI object in new_websocket_client | 20:28 |
| melwitt | I think it will work fine. I probably took the code comment too literally | 20:29 |
| efried | okay, yeah, the way I read the comment is that new_websocket_client needs to use the ComputeAPI, so it had better be instantiated by the time it needs to use it. | 20:29 |
| efried | but if you make it a lazy load, then it gets instantiated dynamically by the thing that needs to use it | 20:29 |
| efried | badabing etc. | 20:29 |
| melwitt | yeah | 20:29 |
| efried | anyway, worth a shot | 20:30 |
| melwitt | yeah, I'll try it | 20:30 |
| *** mdbooth has quit IRC | 20:37 | |
| *** lbragstad has joined #openstack-nova | 20:43 | |
| *** wolverineav has quit IRC | 20:46 | |
| *** itlinux has quit IRC | 20:46 | |
| *** wolverineav has joined #openstack-nova | 20:48 | |
| *** wolverineav has quit IRC | 20:53 | |
| *** mchlumsky has quit IRC | 21:01 | |
| *** wolverineav has joined #openstack-nova | 21:12 | |
| openstackgerrit | François Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | 21:16 |
| *** _alastor_ has quit IRC | 21:16 | |
| *** jmlowe has quit IRC | 21:20 | |
| *** whoami-rajat has quit IRC | 21:28 | |
| *** betherly has joined #openstack-nova | 21:32 | |
| *** erlon has joined #openstack-nova | 21:35 | |
| *** betherly has quit IRC | 21:36 | |
| openstackgerrit | Dan Smith proposed openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_SUPPORT_* traits https://review.openstack.org/648147 | 21:39 |
| *** awaugama has quit IRC | 21:40 | |
| *** betherly has joined #openstack-nova | 21:48 | |
| *** ivve has quit IRC | 21:50 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Move create of ComputeAPI object in websocketproxy https://review.openstack.org/644998 | 21:51 |
| *** betherly has quit IRC | 21:53 | |
| efried | melwitt: ^ Very nice. So are we waiting for test results to prove it? | 22:03 |
| melwitt | efried: yeah, just want to see the result of the tempest novnc tests | 22:04 |
| *** wolverineav has quit IRC | 22:09 | |
| *** betherly has joined #openstack-nova | 22:10 | |
| *** mlavalle has quit IRC | 22:11 | |
| *** wolverineav has joined #openstack-nova | 22:12 | |
| *** itlinux has joined #openstack-nova | 22:14 | |
| *** betherly has quit IRC | 22:15 | |
| *** wolverineav has quit IRC | 22:17 | |
| *** jmlowe has joined #openstack-nova | 22:19 | |
| *** rcernin has joined #openstack-nova | 22:31 | |
| *** wolverineav has joined #openstack-nova | 22:33 | |
| *** zhubx has quit IRC | 22:37 | |
| *** zhubx007 has joined #openstack-nova | 22:37 | |
| *** _alastor_ has joined #openstack-nova | 22:46 | |
| *** erlon has quit IRC | 22:47 | |
| *** munimeha1 has quit IRC | 22:51 | |
| *** _alastor_ has quit IRC | 22:51 | |
| *** betherly has joined #openstack-nova | 22:53 | |
| *** betherly has quit IRC | 22:57 | |
| *** tkajinam has joined #openstack-nova | 23:00 | |
| *** gibi has quit IRC | 23:03 | |
| *** mdbooth has joined #openstack-nova | 23:04 | |
| *** mdbooth has quit IRC | 23:08 | |
| *** wolverineav has quit IRC | 23:19 | |
| *** wolverineav has joined #openstack-nova | 23:19 | |
| *** wolverineav has quit IRC | 23:22 | |
| *** wolverineav has joined #openstack-nova | 23:22 | |
| *** gibi has joined #openstack-nova | 23:22 | |
| *** tosky has quit IRC | 23:27 | |
| *** artom has joined #openstack-nova | 23:32 | |
| *** betherly has joined #openstack-nova | 23:35 | |
| *** betherly has quit IRC | 23:40 | |
| *** dsuper7 has joined #openstack-nova | 23:43 | |
| *** lbragstad has quit IRC | 23:48 | |
| *** takashin has joined #openstack-nova | 23:48 | |
| *** tetsuro has joined #openstack-nova | 23:58 | |
| *** gbarros has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!