Wednesday, 2019-03-20

*** BjoernT has quit IRC00:01
*** wolverineav has quit IRC00:08
*** wolverineav has joined #openstack-nova00:08
*** wolverineav has quit IRC00:13
*** BjoernT has joined #openstack-nova00:16
*** markvoelker has joined #openstack-nova00:17
*** hamzy has joined #openstack-nova00:19
*** markvoelker has quit IRC00:21
*** BjoernT_ has joined #openstack-nova00:21
*** BjoernT has quit IRC00:21
*** BjoernT_ has quit IRC00:38
*** igordc has quit IRC00:42
*** diablo_rojo has quit IRC00:48
*** markvoelker has joined #openstack-nova00:48
*** BjoernT has joined #openstack-nova00:48
*** marst has joined #openstack-nova00:49
*** lbragstad has quit IRC00:49
*** slaweq has joined #openstack-nova00:56
*** ileixe has joined #openstack-nova00:56
*** gyee has quit IRC00:57
*** slaweq has quit IRC01:00
*** tetsuro has joined #openstack-nova01:01
*** cdent has quit IRC01:01
*** awalende has joined #openstack-nova01:12
*** mriedem_away has quit IRC01:15
*** awalende has quit IRC01:17
*** tetsuro has quit IRC01:20
*** marst has quit IRC01:28
*** whoami-rajat has joined #openstack-nova01:29
*** markvoelker has quit IRC01:49
*** zhubx has quit IRC01:53
*** zhubx has joined #openstack-nova01:55
eanderssonWhat is the difference between disk_available_least and disk_free_gb ?01:55
*** cfriesen has quit IRC02:11
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances  https://review.openstack.org/62776502:23
eanderssonIt looks like maybe disk_available_least takes into account the qcow images on the host?02:26
eanderssonbecause the host has 79GB available, the flavor uses 74GB, but the scheduler thinks its out of disk space so refuses to schedule there02:28
eanderssonbut if we schedule there manually using --availability-zone nova:<compute-name>02:28
eanderssonit works02:28
eanderssonand it now has ~4GB disk free according to the nova.compute logs02:29
eandersson> does not have 76800 MB usable disk, it only has 44031.0 MB02:30
eanderssonSo confusing that the disk space used to schedule isn't reported anywhere, or at the very least not the number the scheduler uses to make decisions upon isn't reported.02:31
*** tiendc has joined #openstack-nova02:34
*** tiendc has quit IRC02:35
*** tiendc has joined #openstack-nova02:35
eanderssonAfter scheduling manually I can see that disk_available_least is -3302:40
eanderssonbut free_disk_gb is at 402:41
*** psachin has joined #openstack-nova02:57
*** itlinux has joined #openstack-nova03:04
*** ileixe has quit IRC03:20
*** ileixe has joined #openstack-nova03:23
*** alex_xu has joined #openstack-nova03:30
*** sridharg has joined #openstack-nova03:32
*** dave-mccowan has quit IRC03:39
*** nicolasbock has quit IRC03:45
*** wolverineav has joined #openstack-nova03:47
*** tkajinam has quit IRC03:54
openstackgerritMerged openstack/nova master: Remove "Fixing the Scheduler DB model" from schedule evolution doc  https://review.openstack.org/64361503:56
*** zhubx has quit IRC03:56
*** zhubx has joined #openstack-nova03:56
*** tkajinam has joined #openstack-nova03:57
*** ratailor has joined #openstack-nova03:59
*** udesale has joined #openstack-nova04:00
*** wolverineav has quit IRC04:11
*** ileixe has quit IRC04:32
*** psachin has quit IRC04:34
*** psachin has joined #openstack-nova04:42
*** itlinux has quit IRC04:45
*** janki has joined #openstack-nova04:47
eanderssonmaybe jaypipes ? ^04:55
*** BjoernT has quit IRC05:00
*** BjoernT_ has joined #openstack-nova05:00
*** ileixe has joined #openstack-nova05:04
openstackgerritMerged openstack/nova master: Add docs for compute capabilities as traits  https://review.openstack.org/64429305:09
*** wolverineav has joined #openstack-nova05:15
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances  https://review.openstack.org/62776505:17
*** wolverineav has quit IRC05:18
*** sapd1_x has joined #openstack-nova05:21
*** BjoernT_ has quit IRC05:21
*** markvoelker has joined #openstack-nova05:22
*** tiendc has quit IRC05:26
*** markvoelker has quit IRC05:26
*** ivve has quit IRC05:28
*** BjoernT has joined #openstack-nova05:49
*** janki has quit IRC05:50
*** markvoelker has joined #openstack-nova05:53
*** sapd1_x has quit IRC05:56
*** janki has joined #openstack-nova05:57
*** wolverineav has joined #openstack-nova06:09
*** wolverineav has quit IRC06:13
*** BjoernT has quit IRC06:17
*** sajauddin has joined #openstack-nova06:23
*** ivve has joined #openstack-nova06:30
*** jaosorior has joined #openstack-nova06:33
*** Luzi has joined #openstack-nova06:45
*** phasespace has quit IRC06:55
*** ivve has quit IRC07:07
openstackgerritSeyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner  https://review.openstack.org/64385307:15
*** pcaruana has joined #openstack-nova07:20
*** ivve has joined #openstack-nova07:22
*** tosky has joined #openstack-nova07:29
*** rchurch has joined #openstack-nova07:40
*** phasespace has joined #openstack-nova07:45
*** xek_ has joined #openstack-nova07:49
*** dpawlik_ is now known as dpawlik07:51
*** slaweq has joined #openstack-nova07:55
*** alex_xu has quit IRC08:04
*** ttsiouts has joined #openstack-nova08:05
*** tesseract has joined #openstack-nova08:07
*** awalende has joined #openstack-nova08:11
*** ccamacho has joined #openstack-nova08:11
*** luksky has joined #openstack-nova08:13
*** helenafm has joined #openstack-nova08:18
*** ttsiouts has quit IRC08:26
*** rpittau|afk is now known as rpittau08:27
*** ttsiouts has joined #openstack-nova08:34
*** tkajinam has quit IRC08:35
*** rcernin has quit IRC08:38
*** ttsiouts has quit IRC08:52
*** ttsiouts has joined #openstack-nova08:54
*** ralonsoh has joined #openstack-nova08:58
*** Luzi has quit IRC08:59
*** sridharg has quit IRC09:01
openstackgerritMichael Still proposed openstack/nova master: Complete remove fake_libvirt_utils.  https://review.openstack.org/64389709:02
openstackgerritMichael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing.  https://review.openstack.org/64479309:02
*** sridharg has joined #openstack-nova09:09
*** tstrul has joined #openstack-nova09:11
*** dtantsur|afk is now known as dtantsur09:21
*** SASAA has joined #openstack-nova09:23
*** derekh has joined #openstack-nova09:25
*** IvensZambrano has joined #openstack-nova09:25
openstackgerritBalazs Gibizer proposed openstack/nova master: Add known issue for minimum bandwidth resource leak  https://review.openstack.org/64469409:28
*** jaosorior has quit IRC09:36
openstackgerritStephen Finucane proposed openstack/nova master: docs: Misc cleanups  https://review.openstack.org/64461609:42
*** psachin has quit IRC09:48
mdboothstephenfin: Hey, so it turns out sphinx also imports nova/api/openstack/__init__.py10:08
mdboothstephenfin: My patch is adding monkey patching there, so sphinx is still borked10:09
mdboothstephenfin: I moved monkey patching there for the wsgi entry point because I don't think it can be anywhere else, so I'm a bit stumped.10:10
stephenfinmdbooth: Tried using the mock setting I was on about?10:10
mdboothstephenfin: In sphinx?10:10
stephenfinaye10:11
mdboothIs that a valid thing to do?10:11
mdboothI didn't understand what it did, tbh.10:11
stephenfinhttp://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_mock_imports10:11
mdboothOh, so autodoc_mock_imports = ["nova.monkey_patch"] ?10:12
stephenfintbh, I'm not sure how it works under the hood either. You could try mocking the 'eventlet' module though and see what happens10:12
stephenfinOr that, yeah10:12
mdboothWhere does the sphinx config live again?10:12
stephenfinIf that doesn't help, we're going to have to rip out the stuff that imports code and figure out which one is causing the issue10:13
stephenfinThose modules being 'oslo_config.sphinxext', 'oslo_policy.sphinxext' and 'sphinx.ext.apidoc'10:13
sean-k-mooneymdbooth: i think in docs/sources/conf.py10:13
stephenfinmdbooth: doc/source/conf.py10:13
sean-k-mooneyi was so close :)10:13
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Update Network Bandwidth resource provider spec  https://review.openstack.org/64481010:14
*** luksky has quit IRC10:17
mdboothstephenfin: autodoc_mock_imports = ["nova.monkey_patch"] does not appear to mock nova.monkey_patch10:19
sean-k-mooneymdbooth: whatabout autodoc_mock_imports = ["eventlet"] ?10:20
mdboothJust trying, but I am disappoint10:20
stephenfinmdbooth: Hmm, out of curiosity, doesn't this mean that simply importing 'nova' will trigger the monkey patching so, regardless of whether it's Sphinx importing it or something else?10:21
mdboothThat also appears not to be mocked.10:22
mdboothstephenfin: Well *anything* importing one of these classes will apply monkey patching10:22
mdboothBut this has always been true10:22
mdboothIn this specific instance, I've moved the wsgi entry point, though10:22
stephenfinand what's changed?10:23
sean-k-mooneystephenfin: the classes that triggered the auto monkey patching in the past did not contain any reuable busines loginc10:23
mdboothIt used to be in nova/api/openstack/wsgi_app.py, it's now in nova/api/openstack/__init__.py10:23
mdboothHowever, it has *always* been in nova/cmd/__init__.py10:23
sean-k-mooneyya10:23
sean-k-mooneynova/cmd/__init__.py was done so that when we use setup tools to generate the console scipts10:24
mdboothsean-k-mooney: The reusable aspect of my patch is a side effect10:24
sean-k-mooneythe import of the commands monkey patched it automatically10:24
mdboothPrimarily it *fixes* the non-wsgi and wsgi imports to do monkey patching before importing anything else10:24
mdboothIt's a bugfix, not a cleanup10:24
sean-k-mooneymdbooth: yes10:24
sean-k-mooneybut the point i was try to make was10:25
*** psachin has joined #openstack-nova10:25
* mdbooth isn't on a holy mission of tidiness here10:25
sean-k-mooneyif you wrote a tool that just imported our config definiton10:25
sean-k-mooneysay to do a config migration or to generate the files10:25
sean-k-mooneythen before it would not monkey patch your tool10:25
sean-k-mooneydepending on where you put the call that may or may not change10:26
*** baclawski has joined #openstack-nova10:26
mdboothstephenfin: How would you feel if I set an environment variable in sphinx tox.ini which nova.monkey_patch used to skip monkey patching?10:26
mdboothOr conf.py10:26
*** cdent has joined #openstack-nova10:27
stephenfinmdbooth: I'm all for it10:27
stephenfinWith a giant NOTE explaining why we do this craziness10:29
mdboothstephenfin: Heh, of course10:29
mdboothstephenfin: nova.monkey_patch is itself now a giant NOTE10:29
sean-k-mooneystephenfin: im hoping in train we can remove the need to monkey patch the wsgi api code.10:30
stephenfinU, you mean?10:30
sean-k-mooneyno in trian10:30
stephenfinOh, sorry, just the WSGI piece10:30
sean-k-mooneyit was a regression in the multi cell list feither10:30
mdboothIndeed10:30
sean-k-mooney*feature10:30
sean-k-mooneyya just the wsgi piece10:31
mdboothAlthough, tbh it's flaky as hell and we need to remove the whole thing.10:31
sean-k-mooneydoing it in general is proably not worth it but eventlets and wsgi are not partcally happy bedfellows10:31
mdboothOur entry points are not sufficiently well defined to do this. Specifically, monkey patching on import is a bad idea, but our entry points leave us with no other choice.10:32
sean-k-mooneymdbooth: ya that proably a U thing but futuriest actully has eveything i waned by asyncio form python310:32
sean-k-mooneymdbooth: ya10:32
sean-k-mooneyfortunetly or not depending on your perspective we dont alter those entry points frequently so the sting and ductape we have been using in the past has been enough10:33
*** tstrul has quit IRC10:34
*** jaosorior has joined #openstack-nova10:35
*** wolverineav has joined #openstack-nova10:41
*** wolverineav has quit IRC10:46
*** nicolasbock has joined #openstack-nova10:46
*** dave-mccowan has joined #openstack-nova10:56
aspiersis it just me or is tempest-full-py broken? "The error was: 'gabbi_tempest_path' is undefined\n\nThe error appears to have been in '/var/lib/zuul/builds/42292da2453549e68ae6c1e63bfca00b/untrusted/project_5/git.openstack.org/openstack/tempest/roles/setup-tempest-run-dir/tasks/main.yaml'"10:59
cdentblargh, that sounds like it is at least partially my fault11:00
cdent(because of gabbi in the name) but I haven't changed anything recently11:00
aspierscdent: failure is in https://review.openstack.org/#/c/644554/11:00
cdentthanks11:00
* cdent goes to read the tempest git logs11:01
cdentaspiers: looks like it has already been fixed11:03
aspiersoh nice11:03
* aspiers rechecks11:03
cdenthttps://review.openstack.org/#/c/644699/11:03
cdenthmm, actually I think that may have broken it11:04
* cdent digs more11:04
aspiershaha11:04
* aspiers waits11:04
*** luksky has joined #openstack-nova11:06
cdentaspiers: it is a fix, the reason it wasn't happening before is because it didn't tickle a problem until ansible 2.7 was the default11:06
aspiersah ok11:06
aspiersthanks!11:06
aspiersis it just me or does the browser not cache these horrendously long job-output.txt.gz files?11:06
cdentI think it does not11:07
aspiersI see my Chrome sending Cache-Control: no-cache with the request - wtf?11:07
*** sapd1_x has joined #openstack-nova11:07
aspiersWhy would it do that?11:07
cdentI think it is because the server is not sending good headers11:08
cdentthere's no last-modified or other cache-related header in the headers of the response11:08
aspiersI see Cache-Control in the response11:08
aspiersbut surely it's the Apache index page which should control how the client sends a request for the actual file11:09
aspiershttp://logs.openstack.org/54/644554/2/check/tempest-full-py3/42292da/ <- this one11:09
sean-k-mooneyaspiers: do you have the developer console open11:09
aspierssean-k-mooney: ohhhh, good point11:09
cdentif I do a raw curl of the log file you linked to above and the headers are very limited11:09
sean-k-mooneyaspiers: there is a tick box to disable cache11:09
aspierssean-k-mooney: thanks for the reminder!11:09
aspiersok so unticking "Disable cache" gets rid of no-cache headers, but it's still re-downloading the full file each time11:12
cdentbecause of what I said: the server isn't providing enough info to allow useful caching11:12
*** sajauddin has quit IRC11:13
aspiersso it's missing an Expires: header?11:13
aspiersor Last-Modified11:13
aspiersor Date11:13
cdentor a last-modified, or a cache-control, or an etag or lots of thing11:13
cdentDate is the server date, not the date of the content11:13
mdboothcdent stephenfin: Docs loads oslo policies from nova.api.openstack.placement.policies because it's defined in setup.cfg and I guess it's not unreasonable to document those things. Problem is I moved the monkey patching point to nova/api/openstack/__init__.py, so now that pulls in monkey patching.11:13
* mdbooth blames placement ;)11:13
cdentyeah, fine, I tried to delete that code ! :)11:14
sean-k-mooneyaspiers: that just an issue with the apache config for the instance thats is fronting logs.openstack.org11:14
mdboothcdent: Yeah, if you could move that out of the way...11:14
aspierssean-k-mooney: yeah, I'm gonna ask infra about that11:14
aspiershttps://httpd.apache.org/docs/2.4/caching.html11:14
sean-k-mooneywell in generaly what is the point of allowing cdns to cache logs.openstack.org11:14
sean-k-mooneythe browser sure but i dont hink we can do one without the other11:15
sean-k-mooneymaybe we can11:15
cdentmdbooth: i'll do it on saturday, with a tps repoert11:15
sean-k-mooneyaspiers: actully its proably fine to cache it so if they want to update it it proably wont have any negitive impact11:16
*** janki has quit IRC11:16
aspiersright, because the paths are unique11:16
sean-k-mooneymost logs on logs.openstack.org never get read anyway11:16
cdentthey could relatively easily have a last-modified header11:16
*** janki has joined #openstack-nova11:16
cdentwhich would at least allow a conditional get11:16
* mdbooth shakes his fist at python, and eventlet, and then python again11:16
* aspiers takes this discussion to -infra11:17
sean-k-mooneyyep each run is a new file even for the same patch so you will never get cached old data where the content on the server has changed11:17
*** ileixe has quit IRC11:20
kashyapmdbooth: Want to give your final ACK/NACK on this: https://review.openstack.org/#/c/641981/11:20
*** ttsiouts has quit IRC11:21
mdboothkashyap: "This improves performance without compromising data integrity". You could stick that in a politician's stump speech alongside mom and apple pie.11:22
*** Zara has joined #openstack-nova11:22
kashyapLOL11:22
kashyapmdbooth: If you prefer a different phrasing, I'm open to critique11:23
mdboothkashyap: Absolutely not. It's straight to the point.11:23
kashyapaspiers: (Thanks for your remark on that trade-off of: readability vs. indirection.  I've bookmarked the talk :-))11:23
kashyapmdbooth: Okay, I get lunch then.  Thanks for looking!  Appreciate your time.11:23
kashyapaspiers: (I'm largely with you on it, as I was also feeling uneasy that method becoming longer and longer.)11:24
aspierskashyap: :)11:24
*** ccamacho has quit IRC11:24
*** ccamacho has joined #openstack-nova11:26
*** rcernin has joined #openstack-nova11:27
*** udesale has quit IRC11:28
*** udesale has joined #openstack-nova11:29
*** lpetrut has joined #openstack-nova11:29
*** ttsiouts has joined #openstack-nova11:37
*** pcaruana has quit IRC11:38
*** ttsiouts has quit IRC11:42
*** ratailor has quit IRC11:44
*** tssurya has joined #openstack-nova11:47
*** dave-mccowan has quit IRC11:51
openstackgerritMerged openstack/os-resource-classes master: Update master for stable/stein  https://review.openstack.org/64403012:02
*** ttsiouts has joined #openstack-nova12:04
openstackgerritMerged openstack/os-traits master: Update master for stable/stein  https://review.openstack.org/64403312:05
*** psachin has quit IRC12:11
*** markvoelker has quit IRC12:13
*** sapd1_x has quit IRC12:15
*** pcaruana has joined #openstack-nova12:16
*** psachin has joined #openstack-nova12:19
openstackgerritMerged openstack/os-resource-classes stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64402812:29
openstackgerritMerged openstack/os-traits stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64403112:30
openstackgerritMerged openstack/os-resource-classes stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64402912:30
openstackgerritMerged openstack/os-traits stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64403212:36
*** tbachman has quit IRC12:40
*** eharney has joined #openstack-nova12:42
kashyapmdbooth: You are right.  That whole documentation mess needs fixing.  I'll hold my nose and get that going.12:46
kashyapmdbooth: And on that fated IBM article from the past ... look, I apparently "debunked" it as far as 2014: https://www.redhat.com/archives/libvirt-users/2014-August/msg00060.html ("Behavior of disk caching with qcow2 disks")12:46
*** tesseract has quit IRC12:47
*** tesseract-rh has joined #openstack-nova12:47
*** sapd1_x has joined #openstack-nova12:55
*** jaosorior has quit IRC12:56
*** jmlowe has quit IRC12:58
*** artom has joined #openstack-nova12:58
*** artom has quit IRC13:01
*** artom has joined #openstack-nova13:01
*** yaawang has quit IRC13:02
*** yaawang has joined #openstack-nova13:07
*** lbragstad has joined #openstack-nova13:07
*** marst has joined #openstack-nova13:09
*** mchlumsky has joined #openstack-nova13:13
*** rcernin has quit IRC13:16
*** mriedem has joined #openstack-nova13:17
*** jaosorior has joined #openstack-nova13:21
openstackgerritMerged openstack/nova master: Move slight bonkers IP management to privsep.  https://review.openstack.org/62459213:21
*** ccamacho has quit IRC13:23
*** ccamacho has joined #openstack-nova13:23
bauzasefried: FWIW, I'd have loved to have time for reviewing https://review.openstack.org/#/c/644412/ but fortunately, it's not merged yet13:25
*** ccamacho has quit IRC13:28
*** ccamacho has joined #openstack-nova13:28
efriedbauzas: I knew it was going to hang on in the queue for a while, but we're also a bit tight for time so I didn't want it not to merge because we forgot to +W it.13:29
efriedI didn't mean to cut anyone out, sorry.13:29
bauzasno worries13:29
bauzasjust for the next release, we open the prelude change 2 days before and we leave it there at least some time13:30
*** psachin has quit IRC13:30
efriednoted, thank you.13:30
*** alex_xu has joined #openstack-nova13:32
*** sapd1_x has quit IRC13:35
aspierskashyap: https://review.openstack.org/#/c/644554/ is ready for review13:39
aspiersefried: anyone else I should add to review for that? ^^13:39
openstackgerritMatthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible  https://review.openstack.org/62695213:39
* kashyap clicks13:39
*** shilpasd has joined #openstack-nova13:40
mdboothIt's going to be revised in a second ;)13:43
*** marst has quit IRC13:43
mdboothLine length violations after I indented everything and forgot to rerun pep813:43
efriedaspiers: Dunno. Maybe bauzas would like to look :)13:45
bauzasI can13:45
efriedthanks bauzas. Should be an easy one, just a refactor (and an extra log)13:45
aspiersand extra tests!! \o/13:46
openstackgerritMatthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible  https://review.openstack.org/62695213:46
mdboothOk, ^^^ is the one. Really.13:46
mdboothstephenfin: How do you feel about the sphinx bodge in ^^^ ?13:46
*** BjoernT has joined #openstack-nova13:47
stephenfinmdbooth: It's necessarily awful13:47
mdboothstephenfin: Why thank you13:47
stephenfin:)13:47
kashyapaspiers: Looks good to me.13:47
*** BjoernT has quit IRC13:48
aspierskashyap: thanks13:48
*** tbachman has joined #openstack-nova13:48
*** tbachman has quit IRC13:48
*** helenafm has quit IRC13:48
mdboothIf there's any other way which doesn't involve moving entry points, and therefore impacting deployment tooling, I'd do that instead.13:48
mdboothIt's kinda icky, but it's the best I can think of.13:49
stephenfinmdbooth: It'll do for 6 months, I imagine13:50
stephenfinat which point we should be aiming to rip that all out13:50
* efried googles "bodge"13:51
mdboothstephenfin: Yarp.13:51
efriedthat's a new one on me, thanks mdbooth13:51
mdboothefried: dirty hack that works13:51
mdboothefried: Code I'm not proud of13:51
sean-k-mooneymdbooth: is the bodge hardcoding OS_NOVA_DISABLE_EVENTLET_PATCHING in the conf.py13:51
mdboothsean-k-mooney: Both that, and requiring it at all13:52
*** sapd1_x has joined #openstack-nova13:52
*** jonher has quit IRC13:54
mdboothWait, I think I just did think of a better way13:55
sean-k-mooneyi was going to leave a review comment but honestly my tastae for anyting in this patch can be adressed in train. assuming this works and the gate is happy i think this is good enough for stien13:55
*** BjoernT has joined #openstack-nova13:55
efriedmriedem: Care to re-wordsmith https://review.openstack.org/#/c/644412/4/releasenotes/notes/stein-prelude-b5fe92310e1e725e.yaml@57 ?  Or I can take a stab at it, but you know the reward for good work...13:55
mdboothOk, there's another version coming which eliminates that.13:55
sean-k-mooneycondtionally setining it if not set instead of hardcoding13:55
sean-k-mooneye.g. by usign the defualt valude on the get call13:56
mdboothWe originally did: from nova import utils; utils.monkey_patch()13:56
mdboothOh, wait. I got excited too early.13:56
mdboothIt doesn't work.13:56
sean-k-mooneywell provied v11 which is currently up works that is proably good enough for now13:57
*** awaugama has joined #openstack-nova13:57
mdboothI was thinking that explicitly executing monkey_patch() from the importing module bought us something, but of course it doesn't because it's still executed at import time.13:57
mdbooth...which is why I removed that in the first place.13:57
*** IvensZambrano has quit IRC13:57
sean-k-mooneyah ya13:58
*** marst has joined #openstack-nova13:58
*** mlavalle has joined #openstack-nova14:01
mriedemefried: replied14:02
mriedemtl;dr i don't think it's worth re-writing14:02
*** jonher has joined #openstack-nova14:02
*** eharney has quit IRC14:03
*** Luzi has joined #openstack-nova14:03
efriedmriedem: I seem to be having a hard time conveying what I think the reader is going to care about here. And maybe it's because they really won't care about it.14:07
efriedmriedem: The release notes are about more than the upgrade process itself, aren't they?14:08
mriedemyeah, major new features and such14:08
mriedemand highlighting major upgrade impacts,14:08
efriedI mean,14:08
efriedI guess if you're going to go switch on the QoS feature, you'll read the docs for that and... not be surprised when multiple providers appear.14:09
mriedemsure, but those already using vgpu + libvirt might never enable qos14:09
mriedemso i'd rather not conflate the features14:09
*** ttsiouts has quit IRC14:10
*** ttsiouts has joined #openstack-nova14:10
cdentefried: do people poke placement? is that a thing?14:10
efriedright, so I was focusing not on the specific features and more on the structural change they have in common. A structural change that operators may notice14:11
efriedcdent: Based on conversations overheard with vexxhost and cern folks, it seems like they do.14:11
cdentdunno about vexxhost but my experience with cern it is with regard to what the service is doing, not the count of resource providers14:12
efried...and precisely because the features otherwise seem unrelated, this prelude would be a good place to write about the thing that ties them together.14:12
mriedemcdent: they do when shit goes wrong and they are trying to debug14:12
mriedemso how about,14:12
efriedyeah, so when they do that and oh crap there's suddenly two or more providers for my host, that must be wrong, freak out14:12
cdentyes, and all of that has little to with reading a release notes prelude, I would have thought. that's what I'm trying to understand14:12
efriedif they read the prelude, ever, they might remember in the back of their head that this might possibly be a normal thing, and dig further before pushing the red button.14:13
cdentif you can grep for 'resource provider' anywhere in the release notes then that's enough14:13
cdentyeah, the "ever" is key, and why I think it is to "go back to release notes after something weird happened"14:13
cdent"and grep"14:13
efriedmm14:14
mriedem"Nova now supports nested resource providers in two cases: 1. QoS-enabled ports will have resource allocates created on a nested resource provider from the start. 2. Libvirt compute nodes reporting VGPU inventory will have that VGPU inventory and corresponding allocations moved to a child resource provider on restart of the nova-compute service after upgrading to Stein. - In both cases this means when looking at resource prov14:14
mriedems, depending on scenario, you can see more than one provider where there was initially just a root compute node provider per compute service."14:14
mriedemefried: how is that ^?14:14
efriedmriedem: love it14:14
efrieds/allocates/allocated/14:14
efriedallocations14:14
efriedsed fail14:15
*** ttsiouts has quit IRC14:15
mriedemlike cdent said, if the release notes for the changes themselves were clear in the reno we likely wouldn't need the big prelude, but o-)14:15
mriedemideally, the vgpu reno would have a before and after osc output14:16
mriedemshowing the VCPU/MEMORY_MB/DISK_GB inventory on the root provider and the VGPU inventory on the child provider after the reshape14:16
mriedemor,14:16
mriedemwe can still build that into the docs14:16
mriedemi.e. "if things are working properly, you can expect to see something like this"14:16
mriedemsomewhere in here https://docs.openstack.org/nova/latest/admin/virtual-gpu.html14:17
*** cfriesen has joined #openstack-nova14:17
mriedempersonally i don't love putting a ton of detail in release notes anyway - details should be in docs since those are indexed and don't get lost in the sands of time, and then renos can just link to said docs14:17
mriedempeople FFU past the release notes anyway14:18
mriedemhell https://docs.openstack.org/nova/latest/admin/virtual-gpu.html should probably already say something about nested provider trees starting in stein14:18
efriedmriedem: Right, like I said before, the notes for the changes themselves could (and the docs for said changes certainly should) mention the nrp-ness; but they're tied together by this substantial architectural shift (and basically nothing else), and IMO that's worth mentioning, and this is the place to do it.14:18
mriedemsure, if you want, just take what i proposed above and pretty it up14:19
*** ttsiouts has joined #openstack-nova14:19
*** Kevin_Zheng has quit IRC14:22
efriedmriedem: done, should I edit and repropose or let melwitt do it?14:22
mriedemhttps://bugs.launchpad.net/nova/+bug/182101514:23
openstackLaunchpad bug 1821015 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova - libvirt reshaping" [Medium,Triaged]14:23
mriedemefried: i'd say go ahead and modify yourself14:23
lbragstadat some point this week - i'm wondering if we can sit down and hash out http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003894.html14:26
mriedemlbragstad: you and who's army?14:26
lbragstadjust me, myself, and i14:27
mriedemi didn't read the whole thread but i thought you and melwitt were hashing it out14:27
mriedemdansmith: efried: jaypipes: fyi https://techblog.web.cern.ch/techblog/post/placement-requests/14:27
mriedemnice write up from belmoreira on the refresh associations stuff in their rocky upgrade14:27
mriedemnice to see that feedback loop working ^14:28
lbragstadwell - i think we're going to need to involve the foundation at some point to correct the sessions14:28
lbragstadotherwise we risk splitting the audience with two similar sessions14:28
mriedemare you going to make me read this thread?14:30
*** derekh has quit IRC14:31
mriedemcan you do the general keystone sessions at the forum with an emphasis on what nova is planning to do, and then the nova specific details get hashed out at the ptg?14:31
mriedemi don't even know if johnthetubaguy is going to be attending for https://www.openstack.org/summit/denver-2019/summit-schedule/events/23715/feedback-gathering-for-unified-limits-proposal14:32
mriedemlbragstad: is what i just suggested what you already came to in the ML thread?14:33
mriedemi was really hoping to not have to put my leadership underwear on today14:34
lbragstadwell there are duplicate forum sessions for rbac and unified limits14:34
lbragstadi think melwitt wanted to have the nova session be specific to the unified limit and policy migrations for now - but i expect a lot of other services are going to be in that same boat14:35
lbragstadoriginally, i think we were planning on using the forum sessions to communicate relevant information about what has been done for each initiative to operators, and leave the developer-specific topics for the PTG14:36
mriedemhere you go http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004026.html14:38
*** awaugama has quit IRC14:38
mriedemif a split nova-specific session is just going to be crickets, then i don't think it's worth doing a forum session, just leave it for the ptg if devs want to talk about it14:39
*** itlinux has joined #openstack-nova14:39
mriedemthis is why i didn't actually propose a nova session for unified limits myself14:39
lbragstadack - thanks for responding14:40
mriedemprobably not the response you're looking for, but it's a reason to justify combining sessions14:41
mriedemif jaypipes cares about this (by proxy for verizon) i'm not sure if he's going to be at the forum either14:41
lbragstadi'm fine keeping them separate if there is a reason to14:41
lbragstadbut i'm also fine consolidating them14:42
mriedemlbragstad: is there anything you're not fine with? :)14:42
lbragstadlol - if we keep them separate sessions, i wouldn't be fine with people getting confused over which one to attend ;)14:42
mriedemyou could do like a carnival barker standing outside your session14:43
mriedem"one day only folks, gather round gather round"14:43
lbragstadi'll see if i can recruit someone to do that14:44
lbragstads/recruit/bribe/14:44
mriedemayoung with a sax?14:44
lbragstadonly if smooth jazz gets you in the mood to discuss policy and unified limits14:44
mriedemsmooth jazz gets me in the mood for everything14:45
* artom will start attaching sound files to his patches.14:46
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert"  https://review.openstack.org/63939614:46
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager  https://review.openstack.org/64488114:46
* artom shall wait for CI to tell him what he broke with the second one.14:47
*** sridharg has quit IRC14:47
*** dtantsur is now known as dtantsur|bbl14:51
openstackgerritEric Fried proposed openstack/nova master: Add a prelude release note for the 19.0.0 Stein GA  https://review.openstack.org/64441214:51
efriedmriedem et al ^14:51
mriedembauzas: fyi if you can take a stab at this https://bugs.launchpad.net/nova/+bug/182101514:51
openstackLaunchpad bug 1821015 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova - libvirt reshaping" [Medium,Triaged]14:51
* bauzas looks14:52
bauzasmriedem: no worries, I'll write docs14:52
bauzasI was also planning to talk about reboot issues14:52
mriedemefried: +214:53
jaypipesmriedem: thx for the link, ++. I should have time to get back to the perf improvement patches for CERN in nova-scheduler soon. sorry, between an offsite last week and some other things, been slammed of late.14:59
openstackgerritMatt Riedemann proposed openstack/nova master: Add known issue for minimum bandwidth resource leak  https://review.openstack.org/64469414:59
gibimriedem: thanks for that ^^15:00
mriedemnp15:00
kashyapmriedem: When you get a min, got a question for you (and the other Matt) on PS-11 here: https://review.openstack.org/#/c/641981/1115:00
kashyap(It's a quick one, though.)15:00
*** jmlowe has joined #openstack-nova15:00
*** phasespace has quit IRC15:01
*** lpetrut has quit IRC15:01
*** manjeets_ is now known as manjeets15:02
mriedemkashyap: sure, split the docs kerfuffle out15:04
kashyapmriedem: Thank you, sir15:04
kashyapmriedem: I noted as such in the commit message (but not many read it, besides you :D).  It requires a separate treatment.  And writing high-quality docs take time.  So I didn't wanted to mix it all in one.)15:05
mriedemneed another core for https://review.openstack.org/#/c/642863/15:05
mriedemwhich should probably happen before rc115:05
*** dpawlik is now known as dpawlik_15:06
*** mrch_ has quit IRC15:06
*** phasespace has joined #openstack-nova15:12
*** awalende has quit IRC15:14
*** awalende has joined #openstack-nova15:14
*** Luzi has quit IRC15:17
*** awalende has quit IRC15:19
mriedemlbragstad: mnaser: so based on mnaser's reply in the ML on the policy stuff with a read-only user, that would be something like just changing all GET policies in nova to require a reader role, yeah? rather than admin_or_owner type thing.15:29
mriedemso non-admins could have the reader role, but not admin role, and admins would have both reader and admin role15:29
lbragstadcorrect15:30
*** mvkr has quit IRC15:30
lbragstadfwiw - keystone builds a relationship between the defaults roles we populate15:30
mriedemand that could also be scoped to project, right? so readers in project A can't GET resources from project B15:30
lbragstadright15:30
lbragstadif someone has `reader` on the system, then they can view hypervisor information or whatever15:31
lbragstad(is an example of how that would work outside of project scope)15:31
mriedemok, which is a good use case for support teams15:31
lbragstadexactly15:31
lbragstador auditors15:31
mriedemthey can't delete hypervisors, but they can GET them15:31
lbragstadalso - when nova writes policies for this15:31
lbragstadyou only need to write it for the lower common denominator15:32
lbragstadlowest*15:32
lbragstadfor example, GET /v2/hypervisors would be "role:reader" for the policy check string15:32
*** hongbin has joined #openstack-nova15:32
lbragstadand if a system administrator calls that API, they will actually have `admin`, `member`, and `reader` in their token - since `admin` implies `member` and `member` implies `reader`15:33
mriedemand scope_types has to be set to 'system' for that also?15:33
lbragstadeventually, yet15:33
lbragstadyes*15:33
mriedemso what about the case where people aren't using scope types yet?15:33
mriedembut want reader roles in their policy, but not expose hypervisor details to non-admins15:33
*** tbachman has joined #openstack-nova15:34
mriedemor is that not really an option?15:34
lbragstadin that case, we have to add a little extra to the check string for each policy (only until we can assume the migration is over and we've communicated things to operators)15:34
lbragstad"role:reader and system_scope:all" would solve that15:34
lbragstadwithout having enforce_scope=True15:34
mriedemdo you envision we'd have two policy files for awhile, the existing one for backward compat, and a "this is the new fancy stuff which is here to use if you want, but it's experimental for now" kind of thing?15:35
lbragstadi wouldn't recommend that approach - we tried that in keystone a long time ago and it didn't turn out too well imo15:35
lbragstadinstead, i would evolve the existing policies to account for those cases, like check_str="(role:reader and system_scope:all) or rule:admin_or_owner"15:36
mriedemok i don't have a good grasp on what the proposed migration looks like15:36
mriedemi'm assuming the recommendation is to start migrating piece meal15:36
lbragstadthat's how we're doing it in keystone, yeah15:36
mriedemi'm also assuming there is a summit video somewhere about the migration process?15:37
lbragstadwe're going to resource individually, adding a whole bunch of protection tests so we catch regressions, and then adjusting the policies accordingly15:37
lbragstadgoing through*15:37
lbragstadthere have been forum sessions on the migration approach in the past, but nothing has been recorded afaik15:38
mriedemok, that could also be done with a recorded youtube session like these old ones that sdague used to organize https://wiki.openstack.org/wiki/BootstrappingHour15:40
mriedemi wish we'd start doing more of those again15:40
lbragstadi have done something similar for this work in the past, but not the migration15:40
*** eharney has joined #openstack-nova15:40
openstackgerritDan Smith proposed openstack/nova-specs master: Add request-filter-image-types spec  https://review.openstack.org/64462515:42
*** luksky has quit IRC15:45
*** BjoernT has quit IRC15:50
*** gyee has joined #openstack-nova15:51
*** lpetrut has joined #openstack-nova15:54
*** liuyulong is now known as liuyulong|away15:57
*** itlinux has quit IRC16:00
*** IvensZambrano has joined #openstack-nova16:03
*** efried is now known as efried_rolling16:03
*** BjoernT has joined #openstack-nova16:06
*** mvkr has joined #openstack-nova16:07
bauzasmriedem: efried_rolling: FWIW, I left https://review.openstack.org/#/c/644412/5 waiting for other reviews, we could just +W it tonight EOB if you want16:08
bauzasie. US folks EOB I mean16:08
*** itlinux has joined #openstack-nova16:09
bauzasthat leaves melwitt, dansmith or other West Coast folks to balance if needed16:09
mriedemack16:09
*** igordc has joined #openstack-nova16:10
*** lpetrut has quit IRC16:12
*** itlinux has quit IRC16:14
*** sapd1_x has quit IRC16:14
*** itlinux has joined #openstack-nova16:17
*** jangutter has quit IRC16:20
*** _pewp_ has quit IRC16:20
*** _pewp_ has joined #openstack-nova16:21
*** jmlowe has quit IRC16:21
*** dtantsur|bbl is now known as dtantsur16:22
openstackgerritDan Smith proposed openstack/nova-specs master: Add request-filter-image-types spec  https://review.openstack.org/64462516:23
gmannlbragstad: mriedem do we really need system_scope=all ? until enforce_scope=false scope_type will not be checked just log warning so operator will have time to consume the scope_type things16:24
gmannI mean as we have configuration variable to enable/disable the scope_type then, we can directly do "role:reader", scope_type: 'system'16:25
*** tzumainn has joined #openstack-nova16:26
*** _pewp_ has quit IRC16:26
*** itlinux has quit IRC16:27
*** itlinux has joined #openstack-nova16:29
kashyapWhat are the other volume drivers besides: Quobyte, Virtuozzo, SMBFS?16:29
lbragstadgmann i think we do need "role:reader and system_scope:all", especially in the case where we are applying that to things like hypervisors16:30
lbragstadotherwise we could accidentally open the hypervisor API up to anyone with the reader role on anything16:30
lbragstadsince the check string would be "role:reader or rule:admin_or_owner" instead of "(role:reader and system_scope:all) or rule:admin_or_owner"16:31
*** priteau has joined #openstack-nova16:33
*** igordc has quit IRC16:37
*** itlinux has quit IRC16:37
*** altlogbot_1 has joined #openstack-nova16:40
*** mrch_ has joined #openstack-nova16:40
*** altlogbot_1 has quit IRC16:41
*** igordc has joined #openstack-nova16:42
*** itlinux has joined #openstack-nova16:43
*** awaugama has joined #openstack-nova16:44
*** BjoernT has quit IRC16:47
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable  https://review.openstack.org/64198116:47
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337616:47
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337716:47
*** jmlowe has joined #openstack-nova16:48
kashyapmdbooth: ^ Has the bare-minimum doc update.  For the volume drivers text: the 'vzstorage' and 'smbfs' patch should also merge along with the main patch -- for the "doc to tell the truth"16:48
* kashyap --> needs to run; back later16:49
mdboothkashyap: Thanks16:49
cfriesenkashyap: everything under virt/libvirt/volume?16:49
*** itlinux has quit IRC16:50
gmannlbragstad:  ok. make sense until enforce_scope is not removed or defaulted to True.16:50
mnaserlbragstad, mriedem: late but better than ever, i tried hacking a little bit on what it would look like and i was also unsure of how an ideal transition path might look like16:51
gmannlbragstad: so in that case requested cred will have to add system_scope=all for such request then only they are auth otherwise not16:51
mnaseri think the concern is bob's openstack deployment who hasn't deleted their policy.json file or is currently overriding a few things that finds themselves exposing a lot of things after an upgrade16:52
lbragstadmnaser how so?16:54
gmannmnaser: any policy rule overridden in policy.json file will keep working as it is because we will add old policy rule as deprecated_rule in new rules. But yes if anyone reply on policy in code default thing then they will see this impact16:54
lbragstadbecause their overrides are obsolete?16:54
mnaserlbragstad: if someone had role:support to GET hypervisor list, and now we updated it that they need system scope now for that specific policy16:55
mnaserthey find themselves with a non functional policy at that point i guess16:55
mnaseryeah i think the concern is that it would break existing policies16:55
lbragstadif they have a special role for listing hypervisors and an override for that policy, then it should still work even if we change the default16:56
gmannyeah16:56
gmannif bob reply on GET hypervisor with default policy which is say "admin" currently, we will change this to say "role:reader and system_scope:all" or something which  control it not to expose to non-admin16:59
*** N3l1x has joined #openstack-nova17:00
mnaserlbragstad: if we change the scope to system, wouldn't it stop working then.. because that role is probably project scoped?17:01
mnaserproject scoped to the 'admin' tenant17:01
lbragstadroles aren't scoped to projects per se17:02
lbragstadroles can be associated to actors on targets, actors can be groups or users, and targets can be projects, domains, or system17:02
mnaserright, but bob's openstack cloud probably has it targeting projects right now, as 99% of our docs have always said17:03
mnaser"if you want to give a role for X, create a project and add X role to Y user into it"17:03
gmannalso scope_type will not be enforced until it is explicitly set True by  enforce_scope.  enforce_scope default is false as of now.17:03
*** ivve has quit IRC17:06
mnaserbut if its not enforced then could that not introduce other eissues?17:08
eanderssonMorning17:09
mnaserrole:reader and system_scope:system without it enforced means role:reader can get hypervisor list?17:09
eanderssonWhat is the difference from disk_gb and disk_available_least?17:10
lbragstadmnaser that's why we write the policy like "(role:reader and system_scope:all) or role:admin_or_owner"17:11
gmannno, as lbragstad mentioned we will add a special case of scope_type for that what keystone did - role:reader and system_scope:all17:11
mnaserok so we would have a policy enforcing both .. until we decide to cut it off17:11
gmanntrue17:11
mnaserso maybe a train could be a transitionary release i guess17:11
mnaserand then we can flip the switch17:11
lbragstadwe need to write slightly more complicated policy check_strs to allow for the migration17:12
gmannI suggest to flip in V to give 1 2 cycle of transition phase as this is huger change in policy17:12
mnasercan you enable enforcement of system_scope?17:12
lbragstadthen we can offload more to oslo.policy using enforce_scope=True in the future and simplify the check strings17:12
mnasercould a deployer enable it AND put rule:admin_or_owner set to nothing17:12
mnaserand they'd be using 'the new system'17:13
lbragstadyeah... if a deployer wants to opt into the new system, they just have to maintain a policy file with the *new* defaults, which omits the logical OR with oslo.policy migration17:13
lbragstadit's clunky... but...17:14
openstackgerritMerged openstack/nova master: Add known issue for minimum bandwidth resource leak  https://review.openstack.org/64469417:16
*** udesale has quit IRC17:17
*** IvensZambrano has quit IRC17:20
*** altlogbot_0 has joined #openstack-nova17:26
*** altlogbot_0 has quit IRC17:28
*** altlogbot_2 has joined #openstack-nova17:30
*** mvkr has quit IRC17:31
*** ccamacho has quit IRC17:36
*** NobodyCam has joined #openstack-nova17:40
NobodyCamGood Morning Nova folks17:40
*** tesseract-rh has quit IRC17:40
*** ttsiouts has quit IRC17:40
*** ttsiouts has joined #openstack-nova17:41
*** sridharg has joined #openstack-nova17:42
*** ttsiouts has quit IRC17:46
*** dtantsur is now known as dtantsur|afk17:53
jaypipesNobodyCam: mornin :)17:54
jaypipesor afternoon.17:54
NobodyCamhey hey jaypipes long time!17:54
eanderssonjaypipes, do you happen to know the difference between free_disk_gb and disk_available_least?17:56
eanderssonI assume disk_available_least takes images etc into account?17:56
eanderssonTrying to figure out why a vm that was destroyed and re-created won't fit into the same compute again.17:57
eanderssonfree_disk_gb is large enough to accommodate the vm17:57
eanderssonalso, manually creating the vm on that compute worked (free_disk_gb is now 4, and disk_available_least is -33)17:58
sean-k-mooneyeandersson: disk_available_lest will sometime be the same but it can be wildly different depending on your storage backend17:59
eanderssonso this is probably due to the rocky upgrade18:00
eanderssonwe don't use a specified storage backend18:00
eanderssonso what ever is default18:00
eanderssonbrb18:01
sean-k-mooneyeandersson: google could me this https://gist.github.com/JCallicoat/43505cab0535057ca4fb18:01
sean-k-mooneyi wonder if we have that comment in our code18:02
NobodyCamso dumb question, when creating new project / user it's just the _member_ role that is required to launch instances?18:02
sean-k-mooneyNobodyCam: by defualt yes18:02
NobodyCam:)18:03
sean-k-mooneyalthough you have to also have a default quota of instnaces greater then 018:03
*** priteau has quit IRC18:04
*** luksky has joined #openstack-nova18:05
sean-k-mooneyeandersson: what i ment by storage spefic backedn is it gets a little broken when using shared storage e.g. nfs or rbd18:07
sean-k-mooneyeandersson: if free_gb is positive and disk_available_lest is negitive it means your worst case over commited for the instance that are shduled to the host exceed that allowed by your over commit raitio18:08
klindgrenQuestion re: live migration + configdrive + iso9960.  Instead of scping the file between HV's.  Can why can't we just recreate the config drive on the destination host?18:10
sean-k-mooneyklindgren: i belive there was a libvirt bug that prevented18:10
sean-k-mooneyklindgren: but we could18:10
klindgrenAre files that re passed in via the a boot command, not started as part of the vm data?  So the config drive would be incomplete?18:10
sean-k-mooneyklindgren: i think that depends. i think we store user-data in the db in the instance extra table18:11
klindgrenYea, we changed the code (we have a new enough libvirt) on the scp to look for iso9961 vs iso9960.  And the migration works, it just creates a sparsely populated file with no data in it on the dst.18:12
sean-k-mooneyklindgren: what files are you spscically refering to18:12
klindgrenNova boot --file /seomdest=blah --file /anotherdest=asdf18:13
klindgrenWhich gets put in to config drive under content/000, content/000118:13
sean-k-mooneyklindgren: ya so openstack server create  --user-data < my data> is stored in the db i dont think we store teh contets of files passed with --file18:14
NobodyCamanother dumb question: is there a trick to allowing the admin to launch service instances: I'm seeing Policy check for os_compute_api:os-hide-server-addresses failed with credentials <blah> when attempting to launch Octavia instances18:14
*** ralonsoh has quit IRC18:19
sean-k-mooneyNobodyCam: am the amdin account i think need but admin and _member_ roles18:20
sean-k-mooneybut the admin account still had a quota18:20
sean-k-mooneyin the case of octavir the octavia service account allso has a quota typeiclay it will be set to -1 to have no limit however18:21
*** irclogbot_2 has quit IRC18:21
*** owalsh has quit IRC18:23
*** irclogbot_1 has joined #openstack-nova18:24
*** irclogbot_1 has quit IRC18:27
*** irclogbot_0 has joined #openstack-nova18:29
openstackgerritMerged openstack/nova master: docs: Misc cleanups  https://review.openstack.org/64461618:30
*** icey has quit IRC18:31
*** zhongjun2 has quit IRC18:31
*** NobodyCam has quit IRC18:31
*** pas-ha has quit IRC18:31
*** geekinutah has quit IRC18:32
mriedemklindgren: correct personality files (file injection) are not stored in the db so if they are only in the config drive and you rebuild the config drive on the dest, those will be gone18:32
mriedemsame issue for shelve/unshelve with a config drive + personality files18:32
*** icey has joined #openstack-nova18:33
*** zhongjun2 has joined #openstack-nova18:33
sean-k-mooneymriedem: personality files are also deprecated for removal for 2 release or more right?18:33
mriedemcorrect https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html18:33
mriedembut it's an API so they aren't going to be removed18:33
mriedemjust strongly discouraged18:33
sean-k-mooneymriedem: not even with a microverion?18:34
mriedemalthough, a deployment can simply disable file injection (and that's the default for libvirt) today18:34
mriedemsean-k-mooney: yes we deprecated them by removing them from the API18:34
mriedembut if you use 2.1 then that doesn't matter18:34
*** _pewp_ has joined #openstack-nova18:34
*** pas-ha has joined #openstack-nova18:34
*** NobodyCam has joined #openstack-nova18:34
*** geekinutah has joined #openstack-nova18:34
sean-k-mooneyah that makes sense. that is what i had assed we would do18:35
mriedemwhen you assed you make an ass of u and me18:35
sean-k-mooneytypos all the typos :)18:35
mriedemthis is the libvirt thing https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.inject_partition18:35
_pewp_[ OpenStack Docs: Configuration Options ] - docs.openstack.org18:35
mriedemdisabled by default forever18:35
*** _pewp_ has quit IRC18:36
sean-k-mooneymriedem: i think we reinable it in some of the tempest jobs18:36
sean-k-mooneybut i dont rememebr which one18:36
sean-k-mooneyanyway its not important18:36
mriedemyes it's the ENABLE_FILE_INJECTION var in devstack18:38
mriedemit's in the base tempest job to test personality files18:38
gmannit is enable in tempest-full18:38
*** sridharg has quit IRC18:38
sean-k-mooneymriedem: so related to  klindgren's question if we have disabled file injection is there any reason we cant just recreate the config dirve in that case18:38
mriedemidk, not my area of expertise18:39
mriedemmikal could maybe help18:39
sean-k-mooneymriedem: i mean they are not big so im not sure that is really a big issue anyway18:39
mriedemklindgren: what is the problem with transferring the config drive during live migration?18:39
*** _pewp_ has joined #openstack-nova18:39
mriedemit becomes read-only or what?18:40
klindgrenAllowing ssh between all compute nodes with an ssh key18:40
klindgrenGives an easy vector for an attacker to spread across compute nodes18:40
sean-k-mooneyklindgren: i dont think that is required in all cases18:40
klindgrenIts required in the configdrive + iso9960 use case18:41
sean-k-mooneyif you are using the ssh migration uri for libvrt then it would be18:41
sean-k-mooneybut im not sure if you can tunnel the file data over the libvirt connection when using qemus/libvirst native tls feature18:41
klindgrenwe are using TLS for libvirt but this code does scp's of the config drive18:42
sean-k-mooneykashyap: ^ any idea?18:42
klindgrenBecause even libvirt 4.x can't migrate it/won't18:42
sean-k-mooneyklindgren: oh ok18:42
sean-k-mooneyklindgren: any you need config drive because ye cant use metadata service or just dont want too?18:42
klindgrenWe only use configdrive vs's running metadata, and we have a bunch of stuff from other teams built onto of configdrive18:43
sean-k-mooneyoh wait ye are still support file injection too wich needs config drive18:44
klindgrenWe don't specifically disable file injection, however in our case - no one uses it.18:44
klindgrenBasically In: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8196-L821518:48
_pewp_[ nova/driver.py at master · openstack/nova · GitHub ] - github.com18:48
sean-k-mooneyklindgren: ok. at first glance it sound like we may be able to just recreate the config drive in your sepcific case when file inject is diabled.18:48
*** BjoernT has joined #openstack-nova18:48
klindgrenIf we change iso9660 to iso9661, the live migration works.  The confgdrive file is created on the destination hv.  However, its created as a correctly size, spare file with no data in it18:49
klindgrensean-k-mooney, We would be willing to do the code for this.  Just wanted to make sure that their was some reason why we never did this before and wanted to make sure that we would have some level of support for this.18:50
klindgrenAssuming the file injection stuff was probably the blocker before hand.18:50
mriedemklindgren: dansmith and/or jaypipes might remember other reasons18:51
* jaypipes reads back18:52
dansmiththe configdrive being readonly makes it not migrated by libvirt, IIRC18:52
mriedemfiguring out if file injection is disabled on both the source and dest and telling hosts on both sides during live migration, hey, file injection is disabled so if there is a config drive on the instance, just rebuild it on the dest, would probably be pretty straight-forward18:52
sean-k-mooneydansmith: i think tha thas been fixed18:52
openstackgerritVladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.openstack.org/57141018:53
_pewp_[ Gerrit Code Review ] - review.openstack.org18:53
sean-k-mooneymriedem: ya that is what i was thinking too but i dont know if im missing an edge case18:53
sean-k-mooneyaslo is _pewp_ a new bot?18:53
dansmithsean-k-mooney: I thought it was actually categorically rejected, but I'm sure I'm wrong18:54
mriedemidk wtf _pewp_ is but it looks like it's hemna_'s18:54
sean-k-mooneydansmith: i was jsut taking this config comment on face value https://github.com/openstack/nova/blob/master/nova/conf/configdrive.py#L17-L3318:55
_pewp_[ nova/configdrive.py at master · openstack/nova · GitHub ] - github.com18:55
sean-k-mooneyi dont know wat "resolved in libvirt v1.2.17" actully means18:56
sean-k-mooneythey coudl have document it as wont fix i guess18:56
dansmithwell, that was one reason to have it as vfat, IIRC,18:57
*** ivve has joined #openstack-nova18:58
dansmithbut I thought we actually still need that for other reasons, like being able to host instances with no iso9660 support, and maybe one of the sub-drivers like virtuozzo that needs a regular filesystem or something18:58
sean-k-mooneyya vfat was a woraround for that issue18:58
mriedemsean-k-mooney: stephenfin deprecated the config_drive_format option so you could follow up with him18:58
sean-k-mooneymriedem: ya i was going to check the release notes for libvirt 1.2.1718:59
mriedemthe commit message referenced https://bugzilla.redhat.com/show_bug.cgi?id=120303218:59
openstackbugzilla.redhat.com bug 1203032 in libvirt "Enhancing block/disk migration in libvirt" [Low,Closed: nextrelease] - Assigned to pboldin18:59
_pewp_[ 1203032 – Enhancing block/disk migration in libvirt ] - bugzilla.redhat.com18:59
eanderssonsean-k-mooney, I see19:00
*** altlogbot_2 has quit IRC19:00
eanderssonI think this changed somehow during the upgrade which is why it's weird19:00
eanderssonI mean we went from.. Mitaka to Rocky :D19:00
eanderssonfrom my perspective it looks like base images are taken into account now, and weren't before.19:01
sean-k-mooneyeandersson: do you set allocation raitios in host aggreates?19:01
eanderssonnothing overcommited on these flavors19:01
eanderssonI tried adding disk_all = 1 but did nothing19:01
*** altlogbot_0 has joined #openstack-nova19:02
sean-k-mooneyby disk_all do you mean https://docs.openstack.org/nova/rocky/configuration/config.html#DEFAULT.disk_allocation_ratio19:04
_pewp_[ OpenStack Docs: Configuration Options ] - docs.openstack.org19:04
eanderssonsorry yea disk_allocation_ratio19:04
eanderssonwe don't have it set in the aggregate for non-overprovisioned aggergates19:04
sean-k-mooneyeandersson: in ocata? i think we broke setting allocation ratios via host aggregates when we started using placment for cpu ram and disk19:05
*** tesseract has joined #openstack-nova19:05
sean-k-mooneythere is a mail from melwitt about butthis is proably not the issue.19:06
*** altlogbot_0 has quit IRC19:06
*** _pewp_ has quit IRC19:06
sean-k-mooneyhttp://lists.openstack.org/pipermail/openstack-dev/2018-January/126283.html19:06
*** _pewp_ has joined #openstack-nova19:06
sean-k-mooneyeandersson: in upgading form mitaka to rocky you went form that working to not19:07
*** tssurya has quit IRC19:07
eanderssonSo I would expect that to break for instances that are over-commited19:07
eanderssonnot for instances that are not overcommited right?19:07
*** altlogbot_3 has joined #openstack-nova19:07
sean-k-mooneybut also you nolonger need the AggregateCoreFilter,AggregateRamFilter,AggregateDiskFilter or the core/ram/disk filters19:07
eanderssonI think that would fix it for us19:08
*** lpetrut has joined #openstack-nova19:08
eanderssonbecause placement does that now?19:08
sean-k-mooneyeandersson: yes this is handeled by placement now19:09
sean-k-mooneyor rather form ocata on19:09
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager  https://review.openstack.org/64488119:09
_pewp_[ Gerrit Code Review ] - review.openstack.org19:09
artom_pewp_, what are you?19:09
sean-k-mooneyso you can safely disable the disk filter that is preventing the vm form working19:09
sean-k-mooneyartom: i think a bot of some kind19:10
artomsean-k-mooney, heh, I got that part :)19:10
eanderssonYea - I enabled debug19:10
eanderssonI gotta go, but will be back later. More meeting19:10
*** efried_rolling is now known as efried19:11
*** lpetrut has quit IRC19:12
sean-k-mooneyartom: i think its https://github.com/hemna/sopel-tableflip19:13
*** jmlowe has quit IRC19:15
*** awalende has joined #openstack-nova19:15
*** irclogbot_0 has quit IRC19:16
*** tssurya has joined #openstack-nova19:16
*** irclogbot_3 has joined #openstack-nova19:17
*** awalende has quit IRC19:19
melwittlbragstad, mriedem: well, the parts I thought were relevant to operators/users (and thus forum) are 1) are operators on board with the idea of fixing non-admin policy handling via scope types as a carrot to get operators to adopt different token scopes in their use of nova and 2) if the unified limit migration details in the spec sound OK to operators. 2) is maybe not something operators care too much about19:20
*** _pewp_ has quit IRC19:21
*** _pewp_ has joined #openstack-nova19:21
*** _pewp_ has quit IRC19:22
*** _pewp_ has joined #openstack-nova19:22
efrieddansmith: Sorry if I'm being a dolt here, but where does the request filter get required=COMPUTE_IMAGE_TYPE_FOO from originally? Is it image_meta? Is it translated from the image type somehow? This is the part I'm still missing in https://review.openstack.org/#/c/644625/19:23
_pewp_[ Gerrit Code Review ] - review.openstack.org19:23
efriedYou've mentioned how the compute driver adds COMPUTE_IMAGE_TYPE_FOO into its capabilities19:23
dansmithefried: I haven't worked it all out all the plumbing yet, but we know what image they asked for and we can know what format it's in19:24
efriedOkay. So like if there's an image.type field and we can do "COMPUTE_IMAGE_TYPE_SUPPORT_%s" % image.type kind of thing?19:25
dansmithright19:25
dansmithit's called format I think, but yeah19:25
efriedimage.type.upper().replace("things that aren't legal", "_")19:25
efriedos_traits.normalize something19:25
efriedokay, cool. Thanks.19:25
dansmithefried: | disk_format      | qcow2                                |19:26
sean-k-mooneyam so dumb question before i read your sepc. could we just tag the compute nodes with traits for the image typs they support and then read the image type form glance and add the trait to the placment request19:26
dansmithefried: https://docs.openstack.org/glance/rocky/user/formats.html19:26
_pewp_[ OpenStack Docs: Disk and Container Formats ] - docs.openstack.org19:26
dansmithefried: pretty constrained list there19:27
sean-k-mooneyim thinking of suppoted image types like compute capablites19:27
efrieddansmith: cool. Standard traits to be proposed I assume.19:27
efriedsean-k-mooney: That's what he's doing, yes.19:27
dansmithefried: yep19:27
sean-k-mooneyefried: ok makes sense19:27
dansmithefried: first item in work item list is "add to os-traits"19:28
efriedos_traits.normalize_name is only for custom traits. prolly going to want a map.19:28
efried++19:28
sean-k-mooneyefried: i was going to say we have some code in nova to normalise traits already but maybe we never merged that..19:28
efriedsean-k-mooney: Yeah, we merged it and then moved it to os.traits, but it's only for custom19:29
sean-k-mooneyi was thinking of the traits nomalisation code for the feature based nic schduling that we never finished.19:29
efriedIt's probably okay to hardcode a map for this. Adding a new supported image type, that doesn't happen frequently, does it?19:29
dansmithefried: correct19:30
sean-k-mooneyefried: not really no19:30
*** irclogbot_3 has quit IRC19:30
efriedif a new image type is added, does it require changes in nova anyway?19:30
sean-k-mooneyit happens about as often as adding a new hypervior19:30
sean-k-mooneyam not nessisarly19:31
efriedcause if not, we may want to consider making that translation generic rather than hardcoded19:31
mriedemhttps://etherpad.openstack.org/p/nova-ptg-train19:31
*** jmlowe has joined #openstack-nova19:31
_pewp_[ OpenStack Etherpad ] - etherpad.openstack.org19:31
mriedem"New virt driver for rsd:"19:31
*** _pewp_ has quit IRC19:31
sean-k-mooneywe just pull the image form glance and give it to the hyperviro to use19:31
dansmithefried: likely would.. libvirt can read a lot of stuff, but most of what is covered there19:31
mriedemcome to butthead https://github.com/openstack/rsd-virt-for-nova19:31
dansmithefried: and if it wasn't just a "use this and load it" then it'd break us without nova support19:31
*** _pewp_ has joined #openstack-nova19:31
*** irclogbot_1 has joined #openstack-nova19:31
efriedanyway, I didn't want to get into all the impl details; I just wanted to understand where that bit was coming from.19:31
dansmithefried: like, if it wasn't just a raw file we're copying around, libvirt would need tooling to deal with those files, even if it can read them19:32
efriedokay.19:32
sean-k-mooneydansmith: we have a few other cases that are very similar19:32
sean-k-mooneyfor example im thinkg of suport vif_models or gpu_models(not gpu/vgpu passthough but gpu emulation)19:33
efriedmriedem: I saw that, noticed they didn't have a whole lot of code in their virt driver19:33
sean-k-mooneyi was going to write a spec to enable virt-gpu support by extendign the enum we alredy have but do you think its woth doing somethign similar and reporting supprot vif_models or gpu_models as traits?19:34
*** altlogbot_3 has quit IRC19:34
*** artom has quit IRC19:35
mriedemefried: i'm assuming you'll get all sorts of awesome internal pressure for that rsd driver now19:35
*** altlogbot_1 has joined #openstack-nova19:36
sean-k-mooneymriedem: i have reviewd the code. its more limited then it used to be/could be19:36
sean-k-mooneyit currently relyi on create a 1:1 mapping between compute node and flavor19:36
sean-k-mooneyit previously used to to create 1 hypervior per compute node like the ironic on did so nova could act as a scudler.  so while im happy to see the direver it has good way to go befoer it would be ready to move intree or be used in production19:38
*** _pewp_ has quit IRC19:39
sean-k-mooneyefried: have you looked at the rsd virt dirver at all19:39
efriedI glanced at what was there in github and it appeared to be empty. Beyond that, no.19:39
*** imacdonn has quit IRC19:40
efriedOh, I've been confusing RSD and RDT in my head. (can't imagine why)19:40
efriedso yeah, I've never heard of RSD, internally or otherwise.19:40
*** imacdonn has joined #openstack-nova19:40
sean-k-mooneyefried: its ok you will :P19:40
sean-k-mooneyefried: https://github.com/openstack/rsd-virt-for-nova19:41
efriedohh, there it is.19:41
sean-k-mooneyefried: ya it used to be a lot more powerful but things changed.19:42
sean-k-mooneythat said it still allows you to boot node with out ironic useig rsd via nova so thats kind of cool19:43
*** _pewp_ has joined #openstack-nova19:45
sean-k-mooneybut its currently missusing flavor in a way that will not scale. if you have 1000 RSD nodes it will create 1000 flavors...19:46
*** awaugama has quit IRC19:48
cdentsounds like something I could use at home19:49
*** eharney has quit IRC19:50
sean-k-mooneycdent: the original plan was to create one hypervior per rsd node and 1 flavor per uniqute type of rsd node discovers whcih requried on allcoate of CUSTOM_RSD_NODE_TYPE_WHATEVER19:53
sean-k-mooneyso if you only had two types of rsd system you would get only 2 flavor and to customer resouce classes19:53
sean-k-mooneypretty much how ironic works19:53
*** tesseract has quit IRC19:54
sean-k-mooneycdent: i think helena had some issue wiht modelign things properly in plamcent so this was a temproy fix but i havent talkd to her about it since last ptg so who know why it chaged19:55
cdentthe world moves in mysterious ways19:56
*** igordc has quit IRC19:56
*** eharney has joined #openstack-nova20:02
*** owalsh has joined #openstack-nova20:13
*** awalende has joined #openstack-nova20:20
*** eharney has quit IRC20:22
*** awalende_ has joined #openstack-nova20:23
*** awalende has quit IRC20:26
*** igordc has joined #openstack-nova20:31
openstackgerritmelanie witt proposed openstack/nova master: Move creation of rpcapi.ComputeAPI object from __init__  https://review.openstack.org/64499820:39
_pewp_[ Gerrit Code Review ] - review.openstack.org20:39
*** IvensZambrano has joined #openstack-nova20:41
*** irclogbot_1 has quit IRC20:45
*** mdbooth_ has joined #openstack-nova20:46
*** irclogbot_1 has joined #openstack-nova20:47
*** mdbooth has quit IRC20:50
melwittlbragstad: I re-read the channel log and I think we should just combine sessions20:51
*** igordc has quit IRC20:51
*** igordc has joined #openstack-nova20:52
lbragstadmelwitt both rbac and unified limits?20:52
melwittlbragstad: I think so. I'm going to wager we'll have enough time for both20:52
lbragstadok20:53
mriedemdansmith: alright i've gone through your spec https://review.openstack.org/#/c/644625/20:53
_pewp_[ Gerrit Code Review ] - review.openstack.org20:53
mriedemmostly nits, but wondering what you had in mind for the capabilities-as-traits hook for this20:53
lbragstadi suppose we'll need to get some etherpads rolling then - that way we get the things nova wants to go through written down and generalized if possible20:53
*** altlogbot_1 has quit IRC20:53
melwittlbragstad: yeah, I can create etherpads with the things I was thinking, and then we can work on it. or, you can create them and I'll add. whatever you want20:54
lbragstadmelwitt would you want to follow up the ML thread?20:54
melwittlbragstad: sure, I'll reply20:54
lbragstadthanks20:54
*** altlogbot_3 has joined #openstack-nova20:55
*** eharney has joined #openstack-nova21:19
*** xek_ has quit IRC21:21
*** whoami-rajat has quit IRC21:29
mriedemwelp, this doesn't look good http://logs.openstack.org/63/642863/1/gate/nova-tox-functional/6573680/job-output.txt.gz#_2019-03-20_15_58_21_99325021:30
mriedemcdent: efried: ^21:30
* cdent reads21:30
mriedemthis is the test that uses the PlacementFixture as a context manager21:30
cdentah, that might explain why we don't register log opts21:31
cdentin register_opts21:31
* cdent throws together a quick revert of that to see21:31
mriedemwhat i can't explain is why this would just start failing all of a sudden21:31
dansmithmriedem: okay, since the list of disk formats is such a restricted and static list, it doesn't seem unreasonable to just use capabilities for this, but I don't care that much21:31
cdentthat merged only in the last few ours21:31
efriedmriedem: It's because we landed https://review.openstack.org/#/c/644591/ in placement21:32
_pewp_[ Gerrit Code Review ] - review.openstack.org21:32
cdentwell, some times today (the register opts change)21:32
*** SASAA has quit IRC21:32
efriedhemna_: Not loving _pewp_ - what value is it supposed to add?21:32
hemna_arg21:32
cdentmriedem: there's the revert https://review.openstack.org/#/c/645014/21:32
_pewp_[ Gerrit Code Review ] - review.openstack.org21:32
cdentbut I think there's likely a better fix21:32
hemna_I'll remove the github portion, I thought I already had21:32
cdent(on the nova side)21:33
*** _pewp_ has quit IRC21:33
* cdent will work on the nova side right now21:33
mriedemopening a bug21:33
mriedemhttps://bugs.launchpad.net/nova/+bug/182109221:34
openstackLaunchpad bug 1821092 in OpenStack Compute (nova) "test_local_delete_removes_allocations_after_compute_restart failing since https://review.openstack.org/#/c/644591/" [Critical,Confirmed]21:34
mriedemdansmith: so you were thinking like a capability boolean for each known disk_format?21:35
dansmithmriedem: yeah, I mean, I know that there would be more of those than existing capabilities, but... I don't think the cost is any higher, and we just have to invent a new place to keep that list21:36
klindgrensean-k-mooney, mriedem , dansmith,  I assume based upon earlier discussions that you guys would be ok with a patch on live-migration to regenerate vs's copy an iso9660 config drive under the correct conditions?21:36
efriedcdent: You're just making a blank nova patch that depends-on the revert?21:36
dansmithklindgren: meaning regenerate if we know there aren't files we'd be missing? not sure we can know that currently21:37
mriedemi think we can assume there wouldn't be any personality files if inject_partition is -221:37
mriedemi.e. disabled21:37
dansmithmriedem: they could be in the config drive just not injected into the root image right?21:38
cdentefried: no, I was hoping someone else would make the thing that matt has seen fail depend-on the revert patch. I'm looking into fixing the nova side so we don't have to have the revert on the placement side. It's happening because of a misuse of conf, which would be good to remove21:38
klindgrenI mean - I *know* that on my clouds it's not there, because of the layers that are built onto of it, don't use it.21:38
mriedemdansmith: oh maybe, i'd have to dig into that code21:38
dansmithmriedem: pretty sure they end up in config drive if provided, and then also in the root disk if you inject, but I could be wrong21:38
klindgrenSo I was thinking maybe a config option for scp/rsync to add regenerate?21:38
efriedcdent: ack.21:38
dansmithmriedem: but deciding whether or not to regen based on the config of the (current) source it's coming from seems too loose a restriction21:38
efriedmriedem: you want me to update https://review.openstack.org/#/c/642863/ ?21:39
mriedemefried: to depend on the fix for this blocker bug?21:39
mriedemdansmith: i don't disagree, it would require thought,21:39
*** itlinux has joined #openstack-nova21:39
mriedemso i think the answer to klindgren's question is it's going to require thought, not just a simple single change21:40
klindgrenI just want to avoid a patch that we can  never get merged upstream21:40
efriedmriedem: yes. or create a new blank patch.21:40
mriedemi suspect there would be MigrateData object RPC changes and such to communicate between the dest and source compute21:40
*** awalende has joined #openstack-nova21:40
dansmithmriedem: agree it's non trivial21:40
* cdent has found the problem21:41
mriedemklindgren: are you or your coworker buddies going to be at the ptg?21:41
efriedoo, cdent do tell21:41
klindgrenmriedem, yes we will have 2 people there21:41
mriedemcdent: did someone put potato skins down the drain again?21:41
klindgrenI won't be there21:41
cdentmriedem: twice21:42
klindgrenafaik21:42
mriedemklindgren: at least throw something on here https://etherpad.openstack.org/p/nova-ptg-train21:42
cdentefried: I'm relatively certain the same config is being used twice and it should be. need to confirm21:42
mriedemand if you start coming up with design ideas and have thought through the corner cases and such, it'd be good to dump those thoughts in the ML21:42
dansmithmriedem:         injection_info = InjectionInfo(network_info=network_info,21:42
dansmith                                       files=injected_files,21:42
cdentand I'm not clear why this only matters for logging opts21:42
cdentbut we'll see21:42
dansmithmriedem: ^ is where we pass in the injected files to be written to the configdrive21:42
dansmithmriedem: so I don't think host config disabling injection tells us anything about what is in the configdrive image21:43
mriedemok21:43
mriedemRequestSpec to the rescue!21:43
*** awalende_ has quit IRC21:43
dansmithor system_metadata, a count of injected files we assert to be nonzero or something21:43
dansmithbut still, it's going to be confusing for admins,21:44
dansmithwondering why some instances are migratable and/or don't depend on ssh keys and some do21:44
dansmithbut..yeah.21:44
dansmithif we had the http service integrated into compute for the health check, we could do something better, like allowing one compute to fetch the image via one-time token from the source21:45
dansmithi.e. fetch http://sourcehost/migration_assets/$uuid21:46
dansmiththey have to be able to talk to each other anyway21:46
dansmithand just make that self-destruct as soon as the GET is performed21:46
mriedemhave you changed topics? or in the wrong channel perhaps? :)21:47
dansmithno?21:47
mriedemoh21:47
mriedemheh21:47
mriedemi'm not sure where "if we had the http service integrated into compute for the health check" came from21:48
dansmiththinking of better ways to move bulk data between compute nodes than requiring ssh keys and allowing logins21:48
dansmithbecause that _is_ totally nuts from a security perspective,21:48
dansmithand fixing that with something more secure would be better than just adding a different path (regen) which only works in some cases anyway21:49
dansmithsuch an approach would work for and fix the security holes in cold migration as well21:49
*** wwriverrat has joined #openstack-nova21:50
mriedemwell, it's essentially what i'm doing for cross-cell resize with glance21:50
dansmithusing glance as the intermediary, but yeah21:50
mriedemnoting now that your config drive will have to get rebuilt on the other side...21:50
mriedemdoes config driver already get rebuilt on resize?21:51
mriedem*drive21:51
dansmithI thought it gets copied21:51
dansmithalong with the root disk21:51
mriedemi'm not sure https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L888221:51
dansmithif we had this http endpoint, your cross-cell resize stuff could be much more like regular resize and not have to go through glance21:52
dansmithmriedem: that doesn't run if it already exists21:52
dansmithso yeah, maybe that means it's regen'd but if it's copied then it won't21:52
dansmithhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L362621:53
mriedemhmm yeah so i suppose disk.config gets copied here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L881121:54
mriedemhuh, i guess that's something that needs to be at least documented for the cross-cell stuff as a limitation right now because it's not doing anything with the config drive, so it's going to get regenerated on the dest and you'd lose any personality files21:55
dansmithyou're welcome.21:56
mriedemduly noted in my re-proposed spec https://review.openstack.org/#/c/642807/121:58
mriedemi don't know what the answer is, upload a snapshot of the disk.config to glance?21:58
dansmithno the answer is implement an http server :D22:00
cdentefried, mriedem : the gist of the problem is that you can register other opts multiple times, but not cli opts, and adding oslo_log.log.register_opts() to the common path brings CLI options into the scene of test_local_delete_removes_allocations_after_compute_restart, where config is registered multiple times (3 in fact)22:03
cdentit only shows up in that test because we are doing some wildness with the PlacementFixture that doesn't happen anywhere else22:04
cdentcandidates for fixing it:22:04
cdent1. that revert, worry about it later22:04
cdent2. change that test to do things differently (hard because the reference to the in ram sqlite database needs to be maintained)22:05
cdent3. change the placement fixture (on the placement side) to take a flag to register or not register opts22:05
cdent3 is probably the best choice in the long run, and won't take me long to do22:06
efriedwhy does the placement fixture need to register opts ever?22:06
cdentbecause it has to use opts in order to start placement22:06
efriedI guess when tests go after opts, the defaults need to be there.22:06
efriedand that22:06
cdentunfortunately the way oslo_config works, it has to know about stuff22:07
cdent(good and bads to that)22:07
efried3 today, or should we 1 to unblock and then 3?22:07
cdentthe mode the fixture has now is "don't make the caller think, if possible"22:07
cdentI'm happy with just 3 if everyone else is22:08
cdentbut if you want to unblock quicker, then 1 and then 322:08
efriedyeah, let's merge 1 and you can put 3 on top and include unrevert in it?22:08
cdentI wanted to be able to find a version of 2, but that test is already so hairy I don't think it is worth22:09
cdentsure22:09
cdentfeel free to push the revert through22:09
efriedcdent, mriedem, melwitt: fast-approved https://review.openstack.org/#/c/645014/22:10
efriedand then mriedem respun and did same, neat22:10
mriedemi added the bug tag22:10
efriedyup, ++22:11
*** pcaruana has quit IRC22:11
*** marst has quit IRC22:12
openstackgerritEric Fried proposed openstack/nova master: DNM: Trying a different strategy for tests  https://review.openstack.org/64502622:12
*** mlavalle has quit IRC22:13
*** mvkr has joined #openstack-nova22:16
*** awalende has quit IRC22:18
*** awalende has joined #openstack-nova22:18
melwittefried: ack, thanks22:19
*** BjoernT has quit IRC22:22
*** awalende has quit IRC22:23
mriedemwell now i'm depressed and have a 2 hour call in 3 hours so it's time to leave22:25
*** mriedem is now known as mriedem_away22:25
*** BjoernT has joined #openstack-nova22:27
NobodyCamanyone have any pointers to stacking down instances stuck in scheduling .. I set nova* to debug mode and don't see any errors jumping out22:35
NobodyCams/stracking/tracking22:36
openstackgerritChris Dent proposed openstack/nova master: Don't register placement opts mutiple times in a test  https://review.openstack.org/64503322:36
cdentmriedem_away, efried ^ that fixes the nova side and depends-on the placement side fix22:37
NobodyCamI do see this in the compute log:22:39
NobodyCamInstance 7d8f61e6-155c-47a9-9d35-95939b29d487 has been scheduled to this compute host, the scheduler has made an allocation against this compute node but the instance has yet to start. Skipping heal of allocation: {u'resources': {u'MEMORY_MB': 1024, u'VCPU': 1, u'DISK_GB': 20}}. _remove_deleted_instances_allocations /openstack/venvs/nova-18.1.5.dev5/lib/python2.7/site-packages/nova/compute/resource_tracker.py:135522:39
*** BjoernT has quit IRC22:50
*** IvensZambrano has quit IRC22:52
*** rcernin has joined #openstack-nova22:57
*** rcernin has quit IRC22:58
*** rcernin has joined #openstack-nova22:58
*** itlinux has quit IRC22:59
*** itlinux has joined #openstack-nova23:00
*** itlinux has quit IRC23:08
*** itlinux has joined #openstack-nova23:09
*** tbachman has quit IRC23:15
aspierscdent: OK, now you are not just ahead of me but downright telepathic. I was about to report that placement issue...23:16
cdentaspiers: which one?23:17
aspiersthe option registering23:17
cdentthat's mriedem_away's psychic powers not mine23:17
aspiersOK, so you just fixed it :)23:18
* cdent hopes23:19
aspiersEither way it's nice when things get fixed even before I get a chance to report them23:19
aspiershaha23:19
cdentit's all smoke and mirrors. There's an openstack cabal where people like efried, mriedem_away, me place latent bugs into the code that we can then fix quickly, making ourselves appear heroic and super insightful23:20
*** luksky has quit IRC23:20
aspiersThat's dastardly cunning23:20
cdentthe chaos that you see isn't figuring out the solution for the bug, it's figuring out which bug, of the many that we have caused, is being revealed this time23:21
aspiersI'd hope our govt was doing the same, but alas they're not23:21
cdentheh23:21
*** awalende has joined #openstack-nova23:21
cdentit's...shocking23:22
aspiersdamn right23:22
*** hongbin has quit IRC23:23
* cdent wanders off to not think about that or this for a while23:24
*** mriedem_away has quit IRC23:28
*** mriedem has joined #openstack-nova23:29
*** tosky has quit IRC23:31
mriedemefried: cdent: thanks got both23:32
*** awalende has quit IRC23:41
mriedemsorrison: if you can't make the next nova meeting, you could add https://bugs.launchpad.net/nova/+bug/1819568 to the open discussion agenda as a potential specless blueprint23:55
openstackLaunchpad bug 1819568 in OpenStack Compute (nova) "RFE: network_data.json doesn't contain information about floating IPs" [Wishlist,Opinion]23:55
*** artom has joined #openstack-nova23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!