| *** wolverineav has joined #openstack-nova | 00:07 | |
| *** dpawlik has joined #openstack-nova | 00:10 | |
| *** wolverineav has quit IRC | 00:12 | |
| *** sapd1 has joined #openstack-nova | 00:14 | |
| *** liuyulong_ has quit IRC | 00:14 | |
| *** dpawlik has quit IRC | 00:15 | |
| *** tetsuro has joined #openstack-nova | 00:17 | |
| *** sapd1 has quit IRC | 00:18 | |
| *** dpawlik has joined #openstack-nova | 00:22 | |
| *** hamzy has joined #openstack-nova | 00:22 | |
| *** wolverineav has joined #openstack-nova | 00:22 | |
| *** dpawlik has quit IRC | 00:26 | |
| *** igordc has quit IRC | 00:27 | |
| *** wolverineav has quit IRC | 00:28 | |
| *** markvoelker has joined #openstack-nova | 00:34 | |
| gmann | takashin: ^^ let's just say "- more information about sorting order of response results". mentioned particular field even as example can create confusion. | 00:36 |
|---|---|---|
| *** markvoelker has quit IRC | 00:39 | |
| *** dpawlik has joined #openstack-nova | 00:52 | |
| *** wolverineav has joined #openstack-nova | 00:53 | |
| *** dpawlik has quit IRC | 00:57 | |
| takashin | gmann: Thanks. I will fix it. | 01:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | 01:02 |
| *** markvoelker has joined #openstack-nova | 01:05 | |
| *** whoami-rajat has joined #openstack-nova | 01:17 | |
| openstackgerrit | Fan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration. https://review.openstack.org/612272 | 01:31 |
| *** markvoelker has quit IRC | 01:32 | |
| *** zhubx has quit IRC | 01:33 | |
| *** zhubx has joined #openstack-nova | 01:33 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: [ironic] ignore conflict upon cleaning up node https://review.openstack.org/643484 | 01:35 |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid https://review.openstack.org/642403 | 01:40 |
| *** wolverineav has quit IRC | 01:42 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid https://review.openstack.org/642403 | 01:51 |
| *** hongbin has joined #openstack-nova | 01:54 | |
| *** marst has joined #openstack-nova | 01:54 | |
| *** cfriesen has quit IRC | 02:04 | |
| *** dpawlik has joined #openstack-nova | 02:07 | |
| *** wolverineav has joined #openstack-nova | 02:08 | |
| *** penick has quit IRC | 02:09 | |
| *** lbragstad has quit IRC | 02:09 | |
| *** dpawlik has quit IRC | 02:12 | |
| *** dpawlik has joined #openstack-nova | 02:18 | |
| *** dpawlik has quit IRC | 02:22 | |
| *** lbragstad has joined #openstack-nova | 02:25 | |
| *** wolverineav has quit IRC | 02:39 | |
| *** wolverineav has joined #openstack-nova | 02:39 | |
| *** BjoernT has joined #openstack-nova | 02:40 | |
| openstackgerrit | zhufl proposed openstack/nova master: Pass kwargs to exception to get better format of error message https://review.openstack.org/643501 | 02:45 |
| *** wolverineav has quit IRC | 02:48 | |
| *** ccamacho has quit IRC | 02:50 | |
| *** dpawlik has joined #openstack-nova | 02:52 | |
| openstackgerrit | Merged openstack/nova stable/queens: Fix WeighedHost logging regression https://review.openstack.org/641359 | 02:52 |
| *** dpawlik has quit IRC | 02:56 | |
| *** takashin has left #openstack-nova | 03:01 | |
| *** psachin has joined #openstack-nova | 03:03 | |
| *** wolverineav has joined #openstack-nova | 03:11 | |
| *** zhubx has quit IRC | 03:12 | |
| *** zhubx has joined #openstack-nova | 03:13 | |
| *** BjoernT has quit IRC | 03:29 | |
| *** wolverineav has quit IRC | 03:37 | |
| *** udesale has joined #openstack-nova | 03:50 | |
| openstackgerrit | Merged openstack/nova master: Add functional test to delete a server while in VERIFY_RESIZE https://review.openstack.org/615644 | 04:13 |
| *** wolverineav has joined #openstack-nova | 04:14 | |
| *** hongbin has quit IRC | 04:16 | |
| *** psachin has quit IRC | 04:30 | |
| *** dave-mccowan has quit IRC | 04:30 | |
| *** lbragstad has quit IRC | 04:31 | |
| *** marst has quit IRC | 04:39 | |
| *** marst has joined #openstack-nova | 04:43 | |
| *** lpetrut has joined #openstack-nova | 04:47 | |
| *** janki has joined #openstack-nova | 04:50 | |
| *** dpawlik has joined #openstack-nova | 04:52 | |
| *** dpawlik has quit IRC | 04:57 | |
| *** tssurya has joined #openstack-nova | 04:59 | |
| *** marst has quit IRC | 05:03 | |
| *** dpawlik has joined #openstack-nova | 05:04 | |
| *** dpawlik has quit IRC | 05:08 | |
| *** wolverineav has quit IRC | 05:08 | |
| openstackgerrit | Merged openstack/nova stable/pike: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620579 | 05:09 |
| *** slaweq has joined #openstack-nova | 05:10 | |
| *** wolverineav has joined #openstack-nova | 05:11 | |
| *** wolverineav has quit IRC | 05:17 | |
| *** lpetrut has quit IRC | 05:19 | |
| *** lpetrut has joined #openstack-nova | 05:29 | |
| *** zhubx007 has joined #openstack-nova | 05:34 | |
| *** zhubx has quit IRC | 05:34 | |
| *** dpawlik has joined #openstack-nova | 05:42 | |
| *** lpetrut has quit IRC | 05:43 | |
| *** dpawlik has quit IRC | 05:47 | |
| *** slaweq has quit IRC | 05:56 | |
| *** mtreinish has quit IRC | 05:57 | |
| *** rcernin has quit IRC | 05:58 | |
| *** tetsuro has quit IRC | 06:08 | |
| *** sridharg has joined #openstack-nova | 06:10 | |
| *** rcernin has joined #openstack-nova | 06:13 | |
| *** ivve has joined #openstack-nova | 06:27 | |
| *** mtreinish has joined #openstack-nova | 06:31 | |
| *** Luzi has joined #openstack-nova | 07:00 | |
| *** stakeda has joined #openstack-nova | 07:14 | |
| *** dpawlik has joined #openstack-nova | 07:15 | |
| *** tssurya has quit IRC | 07:17 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid https://review.openstack.org/642403 | 07:17 |
| *** tssurya has joined #openstack-nova | 07:35 | |
| *** pcaruana has joined #openstack-nova | 07:36 | |
| *** tssurya has quit IRC | 07:40 | |
| *** priteau has joined #openstack-nova | 07:40 | |
| *** slaweq has joined #openstack-nova | 07:54 | |
| *** rcernin has quit IRC | 07:59 | |
| kashyap | efried: dansmith: Caught up with the scrollback on #openstack-meeting. And this is the Intel's equivalent for AMD's SEV: "MKTME": https://www.redhat.com/archives/libvir-list/2019-February/msg01730.html | 08:01 |
| kashyap | dansmith: efried: The enablement of "MKTME" (Multikey Total Memory Encryption) is not merged in kernel itself yet. | 08:01 |
| kashyap | Then comes the design and implementation part in QEMU and libvirt (which is what the above libvirt mailing list URL points to). | 08:02 |
| *** tesseract has joined #openstack-nova | 08:04 | |
| *** luksky has joined #openstack-nova | 08:09 | |
| *** dpawlik has quit IRC | 08:10 | |
| *** xek has quit IRC | 08:13 | |
| *** xek has joined #openstack-nova | 08:13 | |
| *** tssurya has joined #openstack-nova | 08:15 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | 08:17 |
| *** rpittau|afk is now known as rpittau | 08:17 | |
| *** tkajinam has quit IRC | 08:18 | |
| *** mcgiggler has joined #openstack-nova | 08:20 | |
| *** pcaruana has quit IRC | 08:24 | |
| *** pcaruana|afk| has joined #openstack-nova | 08:24 | |
| *** markvoelker has joined #openstack-nova | 08:27 | |
| *** awalende has joined #openstack-nova | 08:33 | |
| *** wolverineav has joined #openstack-nova | 08:43 | |
| bauzas | good morning Nova | 08:45 |
| hrw | morning | 08:47 |
| *** derekh has joined #openstack-nova | 08:47 | |
| *** ccamacho has joined #openstack-nova | 08:48 | |
| *** wolverineav has quit IRC | 08:48 | |
| *** ccamacho has quit IRC | 08:52 | |
| *** dpawlik has joined #openstack-nova | 09:13 | |
| *** lpetrut has joined #openstack-nova | 09:20 | |
| *** logan- has quit IRC | 09:23 | |
| *** logan- has joined #openstack-nova | 09:27 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:30 | |
| *** Dinesh__Bhor has joined #openstack-nova | 09:30 | |
| *** Dinesh__Bhor has quit IRC | 09:30 | |
| *** Dinesh_Bhor has quit IRC | 09:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:31 | |
| *** dpawlik has quit IRC | 09:45 | |
| *** dtantsur|afk is now known as dtantsur | 09:47 | |
| *** dpawlik has joined #openstack-nova | 09:48 | |
| * stephenfin should have checked IRC during the week. That's a loooot of mentions | 10:01 | |
| *** lpetrut has quit IRC | 10:02 | |
| *** martinkennelly has joined #openstack-nova | 10:05 | |
| *** stakeda has quit IRC | 10:06 | |
| *** dpawlik has quit IRC | 10:07 | |
| *** ttsiouts has joined #openstack-nova | 10:07 | |
| kashyap | Probably it's OK to not check too. "Distraction is the bane" ;-) | 10:07 |
| *** IvensZambrano has joined #openstack-nova | 10:08 | |
| *** luksky has quit IRC | 10:09 | |
| *** dtantsur is now known as dtantsur|brb | 10:15 | |
| hrw | ;D | 10:18 |
| hrw | zuul -> irc gate would be lovely | 10:18 |
| *** kaiokmo has quit IRC | 10:19 | |
| *** ttsiouts has quit IRC | 10:22 | |
| *** ttsiouts has joined #openstack-nova | 10:23 | |
| *** ttsiouts_ has joined #openstack-nova | 10:23 | |
| *** lpetrut has joined #openstack-nova | 10:27 | |
| *** ttsiouts has quit IRC | 10:27 | |
| *** cdent has joined #openstack-nova | 10:38 | |
| *** wolverineav has joined #openstack-nova | 10:45 | |
| *** dpawlik has joined #openstack-nova | 10:45 | |
| *** wolverineav has quit IRC | 10:49 | |
| *** luksky has joined #openstack-nova | 10:53 | |
| *** mriedem has joined #openstack-nova | 10:53 | |
| *** udesale has quit IRC | 10:56 | |
| *** udesale has joined #openstack-nova | 10:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell https://review.openstack.org/641179 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow https://review.openstack.org/639382 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914 https://review.openstack.org/641521 | 11:11 |
| openstack | bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem) | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type https://review.openstack.org/641792 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.openstack.org/641806 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.openstack.org/638047 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.openstack.org/638048 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 11:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269 | 11:11 |
| mriedem | gibi: bauzas: alex_xu: the bottom 4 changes in the cross-cell-resize series are test-only changes and are generally useful (not directly related to cross-cell but i do need them in that series later) ^ | 11:12 |
| mriedem | it would help to land some of what we can while we can since that series is currently at 44 changes | 11:12 |
| mriedem | dansmith: from when you awaken from your cryochamber ^ | 11:13 |
| mriedem | *for when | 11:13 |
| kashyap | The re-proposed SEV spec needs some further re-design (to take into account a blocker raised by DanPB): https://review.openstack.org/#/c/641994 | 11:20 |
| *** kaiokmo has joined #openstack-nova | 11:24 | |
| *** BlackDex has quit IRC | 11:28 | |
| *** weshay is now known as weshay|rover | 11:31 | |
| *** cdent has quit IRC | 11:31 | |
| *** dpawlik has quit IRC | 11:33 | |
| stephenfin | mriedem: RE: https://bugs.launchpad.net/nova/+bug/1819794, I assume there's still an open to figure out why https://bugs.launchpad.net/nova/+bug/1819794/comments/2 is happening? | 11:35 |
| openstack | Launchpad bug 1819794 in OpenStack Compute (nova) "nova-next job fail on Ubuntu Bionic" [Medium,Confirmed] | 11:35 |
| mriedem | stephenfin: correct, it's not fixed | 11:36 |
| stephenfin | mriedem: Okidok. Won't get to that today but I'll try take a look next week | 11:36 |
| *** cdent has joined #openstack-nova | 11:41 | |
| *** tosky has joined #openstack-nova | 11:43 | |
| efried | kashyap: ack, thanks for the info. dansmith, does the dev stage of that project affect your opinion on landing the SEV work? | 11:44 |
| efried | are you thinking we should perhaps call it something more generic, so that when Intel's answer arrives on the scene, we can implement it under the covers without changing the UI at all? | 11:45 |
| kashyap | stephenfin: I'll look at that Bionic thingie; there are two things there (VMX thing and the misconfig of TLS certs) | 11:45 |
| stephenfin | kashyap: It's all yours | 11:46 |
| kashyap | stephenfin: Nod, first clearing out existing queue of stuff | 11:46 |
| kashyap | efried: On the "calling it more generic", that's what I wanted to plant a flag about -- for us (Nova) to consider _if_ we can work out a generic mechanism | 11:47 |
| kashyap | efried: From a quick chat with DanPB yesterday, he said Intel "MKTME" takes quite a different approach to AMD's SEV -- and what we're going to get in common in the end is up in the air. | 11:48 |
| efried | kashyap: Well, yeah, I would think the outward-facing bits, like the compute capability trait?, would be called <generic>, and then under the covers we | 11:49 |
| efried | if <generic>: | 11:49 |
| efried | if AMD: | 11:49 |
| efried | turn on SEV | 11:49 |
| efried | elif Intel: | 11:49 |
| efried | turn on MKTME | 11:49 |
| efried | oh | 11:49 |
| efried | well then | 11:49 |
| kashyap | efried: On the outward-facing bits like the capability trait (although I don't know an awful lot about it) -- yes, it is worth at least calling out in the spec | 11:52 |
| kashyap | ... that shows we've considered Intel's equivalent, with whatever limited info we have now. | 11:53 |
| kashyap | efried: Might want to add your above pseudo-code comment in the spec | 11:53 |
| efried | kashyap: I suppose I'll have to finally *read* the spec :P | 11:54 |
| kashyap | efried: Haha. I'll admit, I was not paying attention to it at all (as my plate is already overflowing with stuff). | 11:54 |
| kashyap | efried: I slowly got into it, as I was pinged about handling machine types, and then I noticed a few things | 11:55 |
| cdent | wonders how kashyap is managing to have just one plate | 11:56 |
| cdent | I will study | 11:56 |
| efried | kashyap: I'm very new to "caring about libvirt at all", and it seemed to be a fairly simple followon to... some other spec I can't remember where we did a capability trait thing. | 11:56 |
| kashyap | And then I saw things (like adding the wrapper around libvirt's getDomainCapabilities() API) could be split out -- as it can be used for other libvirt driver work | 11:56 |
| kashyap | cdent: Hehe, I split my time b/n Nova (Gerrit-based patch workflow) and low-level virt (mailing-list based patch workflow) | 11:56 |
| cdent | sounds very much like two plates | 11:57 |
| *** BlackDex has joined #openstack-nova | 11:57 | |
| kashyap | Yeah, a bit brain-warping. The joy of applying 40 patches from an e-mail thread :-) | 11:57 |
| efried | but yeah, with the plate full thing, stuff involving the bowels of libvirt tends to be the first to slide off the edge. | 11:57 |
| kashyap | But ... if you're using tools like `mutt`, et al. That makes it blazing fast, though | 11:57 |
| *** dpawlik has joined #openstack-nova | 11:58 | |
| kashyap | efried: Can understand on the "caring about libvirt" thing. The "being simple to follow" depends on what one is looking at, though ;-) | 11:58 |
| efried | kashyap: Well, yes, simple from a "how we used the placement-isms" perspective, mainly because I've been right in the middle of that business for a whiile. | 11:59 |
| *** janki has quit IRC | 12:00 | |
| *** dtantsur|brb is now known as dtantsur | 12:01 | |
| kashyap | Ah, gotcha; in that sense. | 12:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: cleanup driver parity scope section https://review.openstack.org/643566 | 12:02 |
| kashyap | efried: And thanks for reviewing the cache mode change series. | 12:02 |
| efried | kashyap: Sure thing (speaking of bowels of libvirt) | 12:03 |
| kashyap | :-) | 12:03 |
| kashyap | efried: Warning: That SEV spec has _tons_ of hypervisor-related concepts. So expect to sink some 2 hours or more, if you're reading with full concentration | 12:04 |
| efried | this is probably why I never finished it the first time around. | 12:04 |
| efried | I was like, "whoah, this stuff is over my head; I hope kashyap reviews it." | 12:04 |
| kashyap | (And as we speak, there is potentially one more thing to be fixed in libvirt/QEMU; libvirt folks are testing) | 12:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove resize caveat from conductor docs https://review.openstack.org/643567 | 12:05 |
| kashyap | efried: I've commented on parts of it; for now you can ignore and tackle other high-prio stuff. | 12:05 |
| efried | thanks | 12:06 |
| kashyap | I still need to review all the firmware / OVMF and other memory requirements stuff. | 12:06 |
| kashyap | Will get to it next week | 12:06 |
| *** artom has joined #openstack-nova | 12:06 | |
| stephenfin | mriedem: wrt all things docs, there's a nice albeit lengthy of all things metadata here that could benefit from your attention https://review.openstack.org/#/c/640730/ | 12:09 |
| mriedem | christ almighty | 12:09 |
| stephenfin | blame efried for setting me down that path | 12:10 |
| stephenfin | (PS1 comments) | 12:10 |
| mriedem | i don't see efried commenting in PS1 | 12:11 |
| mriedem | i also see dansmith did some review on this... | 12:11 |
| stephenfin | I must have changed the Change-ID at some point (initial version simply added use of :oslo.config:option: to one of the docs) | 12:12 |
| *** abhishekk has joined #openstack-nova | 12:13 | |
| efried | Yeah, I remember you saying this was interesting to me, and glancing at it, and not fully understanding why, and balking at the size of it, and not getting further into it where I might have been able to answer that question. | 12:13 |
| *** derekh has quit IRC | 12:14 | |
| *** FlorianFa has quit IRC | 12:14 | |
| *** panda is now known as panda|lunch | 12:15 | |
| *** sapd1_x has joined #openstack-nova | 12:17 | |
| mriedem | we could benefit from some docs on the object version registry, nova object serializer, how objects are registered into that, how backporting of versioned objects works, conductors role in all that stuff, etc | 12:18 |
| *** mlavalle has joined #openstack-nova | 12:19 | |
| kashyap | stephenfin: Heh, on your docs patch, very dansmith-esque rationale: "Dropped a bunch of random comments in here, surely some of them addd up to a -1" :D | 12:25 |
| *** markvoelker has quit IRC | 12:25 | |
| *** pcaruana has joined #openstack-nova | 12:26 | |
| *** pcaruana|afk| has quit IRC | 12:28 | |
| *** dpawlik has quit IRC | 12:33 | |
| *** mlavalle has quit IRC | 12:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Trivial typo fix for REST API in policy enforcement docs https://review.openstack.org/643569 | 12:34 |
| *** EmilienM is now known as EvilienM | 12:37 | |
| mdbooth | dansmith: You in, yet? | 12:38 |
| *** priteau has quit IRC | 12:38 | |
| kashyap | He should be, it is already 05:40 AM. Too late | 12:38 |
| mdbooth | dansmith: I have confirmed btw that my monkey_patch patch fixes non-wsgi, but not wsgi, and crucially I now understand why | 12:38 |
| mdbooth | It's a good patch, but incomplete. I'm just working on a follow up which I hope should fix everything and bring all our monkey patching hacks into 1 place. I'm happy to keep them separate or merge. Discuss when you get in? | 12:40 |
| *** tobias-urdin has joined #openstack-nova | 12:40 | |
| mdbooth | kashyap: Heh, for anybody else I wouldn't have bothered to ping at this time ;) | 12:40 |
| kashyap | mdbooth: I know :-) Sorry for trolling | 12:40 |
| mriedem | good god this doc needs updating https://docs.openstack.org/nova/latest/reference/scheduler-evolution.html | 12:41 |
| *** ttsiouts_ has quit IRC | 12:41 | |
| kashyap | Does anyone here know if Ubuntu maintains Git repo for their Bionic QEMU packages? | 12:41 |
| *** ttsiouts has joined #openstack-nova | 12:42 | |
| * kashyap goes to look up | 12:42 | |
| kashyap | I ask because of this: it seems like a very Ubuntu might've messed something: https://bugs.launchpad.net/nova/+bug/1819794 | 12:42 |
| openstack | Launchpad bug 1819794 in OpenStack Compute (nova) "nova-next job fail on Ubuntu Bionic" [Medium,Confirmed] | 12:42 |
| edleafe | mriedem: updating or deleting? | 12:42 |
| mriedem | edleafe: some of the stuff in there still applies | 12:43 |
| mriedem | but just stuff like "The recent NUMA features" that was written 3 years ago isn't so recent anymore | 12:43 |
| edleafe | mriedem: it just seems that the bits that are still relevant don't merit a whole page in the docs. It's also a page that needs to be updated frequently | 12:44 |
| *** ttsiouts has quit IRC | 12:46 | |
| *** abhishekk has quit IRC | 12:53 | |
| *** dave-mccowan has joined #openstack-nova | 13:02 | |
| *** ttsiouts has joined #openstack-nova | 13:04 | |
| openstackgerrit | Merged openstack/nova master: Avoid crashing while getting libvirt capabilities with unknown arch names https://review.openstack.org/643458 | 13:13 |
| *** eharney has quit IRC | 13:15 | |
| *** ivve has quit IRC | 13:18 | |
| *** dpawlik has joined #openstack-nova | 13:20 | |
| *** marst has joined #openstack-nova | 13:21 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix SSL infinite recursion https://review.openstack.org/626952 | 13:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Assert that we're monkey patching before importing https://review.openstack.org/643579 | 13:25 |
| efried | mordred: dtantsur asked the question about openstacksdk-in-nova via https://review.openstack.org/#/c/642899/ -- which had to come up again sooner or later. When you have a minute, would you mind summarizing what would be involved in plumbing nova to use it? | 13:25 |
| mordred | yes. happy to | 13:26 |
| mordred | want me to do it on the review? | 13:26 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: DNM: What if we just monkey patched at the top level? https://review.openstack.org/643581 | 13:26 |
| *** sean-k-mooney has joined #openstack-nova | 13:30 | |
| *** BjoernT has joined #openstack-nova | 13:33 | |
| mordred | efried, dtantsur: Also - is this a thing you're wanting to squeeze in to stein? or for train? | 13:33 |
| * dtantsur looks at efried | 13:34 | |
| dtantsur | I'd expect Train to avoid surprises | 13:34 |
| mriedem | edleafe: i just reported a bug so i don't lose track of the issues since i don't have time to work on it - those could all be worked as separate changes by interested contributors https://bugs.launchpad.net/nova/+bug/1820283 | 13:34 |
| openstack | Launchpad bug 1820283 in OpenStack Compute (nova) "Scheduler Evolution in nova - the doc needs updating" [Medium,Confirmed] | 13:34 |
| efried | mordred, dtantsur: Oh, yeah, Train fo sho. This first patch only swaps out one API; the work to hit all of them will be fairly extensive. And possibly warrants a blueprint as well. | 13:35 |
| dtantsur | Which reminds me, I need to implement Baremetal Volume API in openstacksdk.. | 13:35 |
| efried | mordred: Here probably better so I can ask questions (like, "whoah, you're assuming I know way more than I actually do") | 13:35 |
| edleafe | mriedem: thanks for recording that. That page needs either a wholesale rewrite or a proper burial | 13:35 |
| *** pcaruana has quit IRC | 13:36 | |
| mordred | efried: well crap - I just responded to the patch :) | 13:40 |
| mordred | efried: so maybe read that real quick and we can pick it up here | 13:40 |
| *** marst has quit IRC | 13:42 | |
| *** arne_wiebalck has joined #openstack-nova | 13:47 | |
| *** dpawlik has quit IRC | 13:52 | |
| efried | mordred: reading now, thanks. | 13:52 |
| *** dpawlik has joined #openstack-nova | 13:54 | |
| efried | mordred: "translating from service name to service type", like https://github.com/openstack/nova/blob/master/nova/utils.py#L1197-L1202 ? | 13:55 |
| *** cfriesen has joined #openstack-nova | 13:56 | |
| mordred | efried: yes. | 13:57 |
| efried | so - already done \o/ | 13:57 |
| efried | more or less | 13:57 |
| mordred | efried: so - basically what we need is a loop that does what that's doing for all of the service types | 13:57 |
| mordred | efried: and then we need to extract the parameters because the ks_loading.load_auth_from_ ... methods don't make sense in this context | 13:58 |
| mordred | but it would be pretty quick/easy to do | 13:58 |
| mordred | if we're talking train, it should be pretty easy to write the loader method in sdk | 13:58 |
| *** eharney has joined #openstack-nova | 13:59 | |
| *** TheJulia is now known as needssleep | 13:59 | |
| efried | mordred: And as I understand it, the sdk contains "primitives" that will make e.g. https://review.openstack.org/#/c/642899/9/nova/virt/ironic/client_wrapper.py@101 (the node_get method) redundant and unnecessary. | 13:59 |
| mordred | yes, that's right | 13:59 |
| *** rpittau is now known as elfosardo | 13:59 | |
| efried | cool. | 13:59 |
| *** dtantsur is now known as creepy_owlet | 13:59 | |
| *** efried is now known as fried_rice | 14:00 | |
| *** awaugama has joined #openstack-nova | 14:00 | |
| fried_rice | oh yeah ^ | 14:00 |
| fried_rice | mordred: a little more on ks_loading_load_*_from conversion, if you please? | 14:00 |
| mordred | efried: as a concrete example -- once you have a conn - you can either do conn.baremetal.get() for direct rest, or you can do conn.baremetal.chassis() to get a list of chassis | 14:00 |
| fried_rice | mordred: ack, that makes sense (abstractly). | 14:00 |
| mordred | fried_rice: yeah. sdk *needs* to be the one constructing the adapter, so it needs to consume those parameters as config input | 14:01 |
| fried_rice | mordred: so right now we are, for all services (except maybe cinder?), doing this: https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L114-L115 | 14:01 |
| mordred | it would be easier for it to also create the session and auth rather than having the ks_loading code do it | 14:01 |
| mordred | yeah - totally - register_ksa_opts should stay | 14:02 |
| fried_rice | so the ksa opts themselves don't change in the conf? That would be convenient. | 14:02 |
| mordred | we just want to make the sdk be able to get its config from the same opts that ksa is defining | 14:02 |
| mordred | yeah | 14:02 |
| fried_rice | Ah nice. This sounds like a pretty low-surface-area change then, from a plumbing perspective. | 14:02 |
| mordred | I *Think* there is a method call we can use to ask ksa what the opts are - so we should be able to be clever and the method should be pretty small | 14:03 |
| mordred | yeah | 14:03 |
| fried_rice | mordred: Yes, see https://github.com/openstack/nova/blob/master/nova/conf/utils.py#L58 | 14:03 |
| mordred | it should be fairly easy - no noticable impact to deployers - and we should be able to delete a bunch of things from nova eventually | 14:03 |
| fried_rice | i.e. we're already doing that. | 14:03 |
| fried_rice | or rather https://github.com/openstack/nova/blob/master/nova/conf/utils.py#L36 | 14:04 |
| mordred | yeah - awesome | 14:04 |
| mordred | I can start a patch to sdk to add the conf loader function | 14:04 |
| fried_rice | nice. | 14:04 |
| mordred | I'm excited about this actually - I think it'll wind up being really helpful in both directions | 14:06 |
| fried_rice | mordred: btw, in case you think this is all just serendipity, you helped me write all of that stuff. | 14:06 |
| fried_rice | this is where you get to say things like, "I love it when a plan comes together". | 14:06 |
| * bauzas waves after one week away from laptop | 14:07 | |
| bauzas | internal meeting, in case people were looking at me | 14:07 |
| fried_rice | mordred: agreed, there seems to be a lot of support for "get python-*client out of the way", to the point where I almost wonder whether it should be a Train community goal. | 14:07 |
| fried_rice | mordred: I mean, it can be a U community goal, and that shouldn't stop us doing pieces of it in Train | 14:08 |
| fried_rice | but that would get it more attention | 14:08 |
| mordred | fried_rice: yeah - I thnik if we can get the sdk plumbed in and used in the places you're using adapters now (just the adapters on the sdk connection) | 14:09 |
| mordred | then it'll be pretty easy then to pick off transitions one at a time - since the conn will be available and stuff | 14:09 |
| *** awalende has quit IRC | 14:11 | |
| *** awalende has joined #openstack-nova | 14:12 | |
| *** marst has joined #openstack-nova | 14:13 | |
| *** sridharg has quit IRC | 14:15 | |
| openstackgerrit | Merged openstack/nova master: add python 3.7 unit test job https://review.openstack.org/610694 | 14:15 |
| *** tbachman has quit IRC | 14:15 | |
| *** awalende_ has joined #openstack-nova | 14:15 | |
| *** awalende has quit IRC | 14:16 | |
| *** awalende_ has quit IRC | 14:17 | |
| *** pcaruana has joined #openstack-nova | 14:17 | |
| *** pcaruana|afk| has joined #openstack-nova | 14:17 | |
| *** pcaruana|afk| has quit IRC | 14:17 | |
| *** tbachman has joined #openstack-nova | 14:18 | |
| *** stephenfin is now known as finucannot | 14:19 | |
| fried_rice | mordred: Well, tbh, the only place we're *actually* using the adapter that I know of is for talking to placement. | 14:20 |
| *** jhesketh_ has quit IRC | 14:20 | |
| *** sean-k-mooney has quit IRC | 14:20 | |
| fried_rice | mordred: All the other places we retrofitted to get and adapter so we could use its endpoint to pass to the client constructor and then throw the rest away. | 14:20 |
| fried_rice | s/and adapter/an adapter/ | 14:20 |
| *** ttsiouts has quit IRC | 14:21 | |
| fried_rice | mordred: that being the case, perhaps we could use the placement client (known as SchedulerReportClient) to lead the charge of testing the sdk plumbing. <== cdent | 14:21 |
| *** ttsiouts has joined #openstack-nova | 14:22 | |
| cdent | i'd be pro that | 14:22 |
| mordred | ++ | 14:22 |
| fried_rice | mriedem, dansmith: Any foundational/historical/other reasons we shouldn't start doing this? (TLDR Incorporating openstacksdk into nova with the eventual goal of ripping out deps on python-*client and (directly) ksa.) | 14:24 |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-nova | 14:25 | |
| bauzas | fried_rice: CLI is a thing, python bindings is another thing | 14:34 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899 | 14:34 |
| bauzas | having a client that's managed by the project teams sounds more maintainable | 14:34 |
| bauzas | with regards to microversions in particular | 14:35 |
| bauzas | I honestly thought about the OSC gap we have atm | 14:35 |
| bauzas | with sean mooney as well | 14:35 |
| fried_rice | bauzas: Sorry, I don't follow. Are you suggesting we keep python-*client in the mix?? | 14:36 |
| bauzas | and we wonder whether we could just use the plugin interface of OSC for having our microversions support *in-tree* | 14:36 |
| fried_rice | forget CLI for the moment; I'm talking about e.g. nova talking to ironic via openstacksdk rather than through python-ironicclient | 14:37 |
| bauzas | fried_rice: IIRC we said in the past that we could probably one day have an OSC CLI which'd be using novaclient python PAI | 14:37 |
| bauzas | API* | 14:37 |
| bauzas | fried_rice: yup, got it | 14:37 |
| bauzas | the problem is that we don't have support for OSC microversions. In what openstacksdk would change this ? | 14:38 |
| bauzas | pardon my french | 14:38 |
| bauzas | I mean 'we don't have OSC supporting nova API microversions' | 14:38 |
| *** dpawlik has quit IRC | 14:39 | |
| fried_rice | bauzas: forget OSC for the moment. | 14:40 |
| fried_rice | Is there a reason we shouldn't rip out nova's dep on the pythot-ironicclient lib (see nova/virt/ironic/client_wrapper.py) | 14:41 |
| fried_rice | s/pythot/python/ wow | 14:41 |
| *** priteau has joined #openstack-nova | 14:42 | |
| bauzas | fried_rice: is there a feature parity between ironicclient and openstacksdk ? | 14:44 |
| *** tbachman_ has joined #openstack-nova | 14:45 | |
| bauzas | at least for compute, I can't see it https://docs.openstack.org/openstacksdk/latest/user/guides/compute.html | 14:46 |
| fried_rice | bauzas: For many if not all of the APIs - creepy_owlet could answer that - but even if there's a specific API missing, we can use the adapter.get/put/post/delete primitives | 14:46 |
| *** jhesketh_ has joined #openstack-nova | 14:46 | |
| *** tbachman has quit IRC | 14:46 | |
| *** tbachman_ is now known as tbachman | 14:46 | |
| fried_rice | ...which is what I was starting to do (via ksa directly as opposed to sdk) via https://review.openstack.org/642899 which started this discussion. | 14:46 |
| bauzas | I'm confused, I thought we were talking about the potential TC goal for Train | 14:48 |
| bauzas | my sole take on using other clients but the project ones is that we need to make sure those projects take ownerships of their respective parts | 14:49 |
| *** sean-k-mooney has joined #openstack-nova | 14:49 | |
| *** jhesketh has quit IRC | 14:49 | |
| *** jhesketh has joined #openstack-nova | 14:49 | |
| fried_rice | bauzas: Right, we're specifically *not* talking about the current community goal. We're talking about a potential future community goal that's similar, but different. Namely: stop using python-*client from *services* (as opposed to CLIs). | 14:49 |
| mordred | fried_rice: https://review.openstack.org/643601 WIP Make factory for a CloudRegion from CONF objects | 14:50 |
| *** jhesketh_ has quit IRC | 14:51 | |
| fried_rice | mordred: ack | 14:51 |
| mordred | fried_rice: that's probably 95% there - obviously needs tests and whatnot - but that's the overall idea | 14:51 |
| *** dpawlik has joined #openstack-nova | 14:51 | |
| mordred | fried_rice: I think - because nova supports people having different accounts for different services, for now we should keep the existing model and have your nova code load session and auth plugin and pass them in - and we'll do one-connection-per-service - even though that's ultimately a little strange | 14:52 |
| fried_rice | mordred: okay, I was wondering about that. | 14:52 |
| mordred | fried_rice: but fits with the consumption model better so we can keep things as it is | 14:52 |
| mordred | then, later, we can talk about whether it makes sense to think about it differently | 14:53 |
| *** jhesketh has quit IRC | 14:54 | |
| mordred | fried_rice: anyway - I've got a call now, so I'll have to come back to it -but I don't think it'll be super hard to get a working poc based on that | 14:54 |
| fried_rice | ack | 14:55 |
| creepy_owlet | bauzas: there is no feature parity overall, but most of things needed for Nova are there. | 14:56 |
| *** jaosorior has quit IRC | 14:56 | |
| creepy_owlet | One missing is Volume API, but it should be easy to introduce now that we have all basic bits in place. | 14:57 |
| mordred | and it woudl be good all around to get that added to sdk anyway, so the work would be generally useful | 14:57 |
| creepy_owlet | exactly | 14:58 |
| *** cdent has quit IRC | 14:58 | |
| creepy_owlet | FYI I'd like to start Train with replacing ironicclient with openstacksdk in ironic-inspector | 14:58 |
| creepy_owlet | metalsmith is already 100% openstacksdk | 14:58 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove [ironic]api_endpoint option https://review.openstack.org/643483 | 14:59 |
| *** jhesketh has joined #openstack-nova | 15:03 | |
| *** Luzi has quit IRC | 15:14 | |
| *** ttsiouts has quit IRC | 15:14 | |
| melwitt | aspiers: heya, was wondering if you're up for writing up a doc for https://review.openstack.org/538498 for rc1? L38 https://etherpad.openstack.org/p/nova-stein-rc-potential | 15:16 |
| mriedem | fried_rice: i was out, but i have an answer, sec | 15:19 |
| mriedem | fried_rice: i mentioned historical context in the community wide goal about sdk usage in server projects and dtroyer replied https://review.openstack.org/#/c/639376/4/goals/train/osc.rst@33 | 15:20 |
| mriedem | tl;dr is it used to be heavyweight to use the sdk | 15:20 |
| mriedem | now it's not so much so we should be ok to use if we want | 15:20 |
| *** dpawlik has quit IRC | 15:22 | |
| mriedem | but i see dmitry and monty already told you all this | 15:26 |
| * mriedem was doing exterior drainage mandy work | 15:26 | |
| *** zhubx007 has quit IRC | 15:33 | |
| *** zhubx007 has joined #openstack-nova | 15:35 | |
| *** zhubx007 has quit IRC | 15:36 | |
| *** zhubx007 has joined #openstack-nova | 15:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove stale aggregates notes from scheduler evolution doc https://review.openstack.org/643613 | 15:40 |
| mriedem | bauzas: edleafe: ^ | 15:40 |
| edleafe | mriedem: so is the plan for the evolution doc to remove piece-by-piece instead of all at once? | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove "Fixing the Scheduler DB model" from schedule evolution doc https://review.openstack.org/643615 | 15:44 |
| mriedem | edleafe: some of it needs re-wording, | 15:45 |
| mriedem | it's not all removal | 15:45 |
| edleafe | mriedem: ah, ^^ answers that | 15:45 |
| mriedem | and i'd rather not try to bite off re-writing that entire thing in a single change because (1) i don't have the time and (2) people probably don't want to review it | 15:45 |
| mriedem | so i'm just killing some time before lunch by hitting the low hanging fruit | 15:45 |
| *** awaugama has quit IRC | 15:48 | |
| openstackgerrit | Merged openstack/nova stable/queens: Provide a useful error message when trying to update non-compute services https://review.openstack.org/638803 | 15:49 |
| mriedem | melwitt: want to hit this for rocky https://review.openstack.org/#/c/643173/ | 15:51 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix incompatible version handling in BuildRequest https://review.openstack.org/634439 | 15:51 |
| melwitt | mriedem: sure | 15:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix resetting non-persistent fields when saving obj https://review.openstack.org/643215 | 15:52 |
| mriedem | oh right dan is out today and monday, forgot about that | 15:53 |
| *** cdent has joined #openstack-nova | 15:54 | |
| mriedem | https://review.openstack.org/#/c/643215/ is also needed for rocky | 15:55 |
| *** ttsiouts has joined #openstack-nova | 15:55 | |
| *** lpetrut has quit IRC | 15:56 | |
| *** dustinc has joined #openstack-nova | 15:56 | |
| *** lpetrut has joined #openstack-nova | 15:56 | |
| *** jangutter has quit IRC | 15:58 | |
| *** udesale has quit IRC | 15:59 | |
| *** lpetrut has quit IRC | 16:13 | |
| *** wolverineav has joined #openstack-nova | 16:21 | |
| *** gyee has joined #openstack-nova | 16:23 | |
| *** cdent has quit IRC | 16:24 | |
| *** kmalloc is now known as needscoffee | 16:25 | |
| *** wolverineav has quit IRC | 16:29 | |
| *** wolverineav has joined #openstack-nova | 16:30 | |
| *** luksky has quit IRC | 16:35 | |
| *** sapd1_x has quit IRC | 16:35 | |
| *** belmoreira has quit IRC | 16:45 | |
| *** igordc has joined #openstack-nova | 17:01 | |
| *** mcgiggler has quit IRC | 17:01 | |
| *** elfosardo is now known as rpittau|afk | 17:08 | |
| *** wolverineav has quit IRC | 17:18 | |
| *** itlinux has quit IRC | 17:18 | |
| *** ravirjn has joined #openstack-nova | 17:19 | |
| *** creepy_owlet is now known as dtantsur|afk | 17:22 | |
| *** ttsiouts has quit IRC | 17:23 | |
| *** ttsiouts has joined #openstack-nova | 17:24 | |
| *** tssurya has quit IRC | 17:24 | |
| *** luksky has joined #openstack-nova | 17:26 | |
| *** ttsiouts has quit IRC | 17:28 | |
| *** priteau has quit IRC | 17:30 | |
| *** wolverineav has joined #openstack-nova | 17:30 | |
| *** zhubx007 has quit IRC | 17:31 | |
| *** zhubx007 has joined #openstack-nova | 17:32 | |
| *** wolverineav has quit IRC | 17:32 | |
| *** wolverineav has joined #openstack-nova | 17:33 | |
| ravirjn | Hi everyone! We have one running newton trippleo cluster. Just now we added HP MSA storage. Now, we want to migrate all nova instances from compute host to cinder volume. But, we are not sure how to migrate instances to cinder volume. For testing, we created a snapshot of a running instance, and created new instance using this instance-snapshot, but, the problem is, the IP addresses are getting changed. Please help. | 17:33 |
| *** wolverineav has quit IRC | 17:41 | |
| *** wolverineav has joined #openstack-nova | 17:44 | |
| *** jdillaman has quit IRC | 17:47 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Check hosts have no instances for AZ rename https://review.openstack.org/641351 | 17:47 |
| openstackgerrit | Merged openstack/nova master: docs: cleanup driver parity scope section https://review.openstack.org/643566 | 17:47 |
| openstackgerrit | Merged openstack/nova master: Remove resize caveat from conductor docs https://review.openstack.org/643567 | 17:47 |
| openstackgerrit | Merged openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494 | 17:47 |
| openstackgerrit | Merged openstack/nova master: Trivial typo fix for REST API in policy enforcement docs https://review.openstack.org/643569 | 17:48 |
| *** wolverineav has quit IRC | 17:48 | |
| *** wolverineav has joined #openstack-nova | 17:49 | |
| *** diablo_rojo has joined #openstack-nova | 17:50 | |
| mdbooth | melwitt: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003870.html | 17:51 |
| mdbooth | The monkey patching thing | 17:52 |
| *** awaugama has joined #openstack-nova | 17:52 | |
| mdbooth | Incidentally, I clearly don't understand how we bump requirements. | 17:53 |
| mdbooth | I wanted to bump the eventlet version requirement to >=0.21.0. That seems to have failed because we're using 0.18.2, but that seems super old. | 17:53 |
| mdbooth | Hmm, that's the lower constraint | 17:54 |
| sean-k-mooney | mdbooth would bumping the min version be blocked as we are after the non client lib freeze | 17:55 |
| mdbooth | Ah, presumably we only install the old stuff for the lower constraints test | 17:55 |
| sean-k-mooney | mdbooth: in the gate yes. that basically just runs the unit tests | 17:56 |
| mdbooth | sean-k-mooney: No idea. It's not critical, tbh, as I can easily take that out. I was more interested in why we haven't hit this in the gate yet. | 17:56 |
| mdbooth | We have a workaround in the monkey patching which is no longer required after eventlet 0.21.0 | 17:56 |
| sean-k-mooney | mdbooth: ya as i said downstream from looking at what we run in the gate we should | 17:56 |
| mdbooth | So while I was in there with a test patch I bumped the eventlet min version and removed it. | 17:57 |
| mdbooth | I assumed it would go through as we'd be using a newer version already anyway. | 17:57 |
| sean-k-mooney | we should not be useing the lower constraint by the way in the tempest job | 17:58 |
| sean-k-mooney | mdbooth: perhaps this is showing up in osp15 because we are packagin an old eventlet | 17:58 |
| mdbooth | sean-k-mooney: Nope. Latest and greatest. | 17:58 |
| sean-k-mooney | the tempest-full-py3 job will use whatever the uppper-constraits.txt allows | 17:59 |
| melwitt | 0.24.1 is the upper constraint for eventlet, so I'm not sure why 0.18.2 is being installed https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L143 | 17:59 |
| sean-k-mooney | we should be running 0.20.0 | 17:59 |
| sean-k-mooney | https://github.com/openstack/requirements/blob/stable/pike/upper-constraints.txt#L141 | 17:59 |
| sean-k-mooney | oh that was pike | 18:00 |
| mdbooth | 0.24.1 | 18:00 |
| mdbooth | Same as OSP | 18:00 |
| mdbooth | Might be urllib3, then | 18:00 |
| sean-k-mooney | eventlet===0.24.1 on master | 18:00 |
| sean-k-mooney | urllib3===1.24.1 | 18:00 |
| sean-k-mooney | on master | 18:00 |
| mdbooth | OSP: python3-urllib3-1.23-5 | 18:01 |
| mdbooth | Slightly older urllib3 | 18:01 |
| mdbooth | Anyway, as I said in the ML post it's not that important. By not monkey patching first, if it's not this today it will be something else tomorrow. | 18:01 |
| *** priteau has joined #openstack-nova | 18:02 | |
| sean-k-mooney | ya | 18:03 |
| sean-k-mooney | at somepoint maybe we can finally move away form eventlets entriely but it will atleast be U before that becomes possible | 18:03 |
| sean-k-mooney | i.e. we need to drop python2 support first | 18:04 |
| melwitt | sean-k-mooney: you might be able to help triage this bug, looks in your wheelhouse https://bugs.launchpad.net/nova/+bug/1801303 | 18:20 |
| openstack | Launchpad bug 1801303 in OpenStack Compute (nova) "VM send DHCP request before openflow is created in br-int" [Undecided,New] | 18:20 |
| openstackgerrit | Merged openstack/nova stable/rocky: Update instance.availability_zone during live migration https://review.openstack.org/643173 | 18:26 |
| sean-k-mooney | melwitt: sure ill take a look now | 18:32 |
| melwitt | sean-k-mooney: thanks | 18:33 |
| sean-k-mooney | my inital reaction is this shound never happen in any release after we added the vif plugged events as we wait for those on boot | 18:34 |
| *** tbachman has quit IRC | 18:34 | |
| *** tbachman has joined #openstack-nova | 18:34 | |
| melwitt | oh, I see. I think it's been awhile since those were added | 18:34 |
| melwitt | i.e. before queens | 18:35 |
| sean-k-mooney | yes back in like mitaka or so queens should have it | 18:35 |
| sean-k-mooney | im going to ask from mor info on what network backend they are using | 18:35 |
| melwitt | ok, cool | 18:35 |
| sean-k-mooney | if they are using odl then that would explain the behavior | 18:35 |
| melwitt | oh, right. I vaguely remember that from last time I tried to think about vif plug events xD | 18:36 |
| sean-k-mooney | odl sends the event on port bind not when odl wires it up | 18:36 |
| *** eharney has quit IRC | 18:38 | |
| *** wolverineav has quit IRC | 18:42 | |
| *** tesseract has quit IRC | 18:45 | |
| *** wolverineav has joined #openstack-nova | 18:47 | |
| fried_rice | mordred: ! | 18:50 |
| fried_rice | mordred: I pulled down your openstacksdk patch, diddled with it a little bit, added a kwarg to Connection, instantiated it with a CONF and a session/auth established from ks_loading, and succeeded in talking to placement through it. | 18:52 |
| *** wolverineav has quit IRC | 18:52 | |
| mordred | fried_rice: SWEET! | 18:52 |
| fried_rice | mordred: Permission to upload my changes to your patch so I can create one in nova that depends-on it and proceed? | 18:52 |
| mordred | please do | 18:52 |
| mordred | fried_rice: that's super exciting that it worked and stuff | 18:53 |
| mordred | or, you know "worked" well enough for you to make it actually work | 18:53 |
| fried_rice | mordred: FYI, my ipython session looked roughly like this: | 18:53 |
| fried_rice | import openstack | 18:53 |
| fried_rice | from nova import conf | 18:53 |
| fried_rice | conf.CONF(args=['--config-file', '/etc/nova/nova-cpu.conf']) | 18:53 |
| fried_rice | from keystoneauth1 import loading | 18:53 |
| fried_rice | auth = loading.load_auth_from_conf_options(conf.CONF, 'placement') | 18:53 |
| fried_rice | sess = loading.load_session_from_conf_options(conf.CONF, 'placement', auth=auth) | 18:53 |
| fried_rice | from openstack import connection | 18:53 |
| fried_rice | conn = connection.Connection(session=sess, oslo_conf=conf.CONF) | 18:53 |
| fried_rice | conn.placement.get('/resource_providers').json() | 18:53 |
| *** tosky has quit IRC | 18:53 | |
| fried_rice | and obviously the money shot was that last thing producing the expected json payload. | 18:54 |
| mordred | fried_rice: ++ | 18:54 |
| mordred | fried_rice: fwiw, when you stitch it in to nova - pass app_name and app_version to the parameters (app_name of "nova" I think :) ) - it updates the user agent strings | 18:55 |
| fried_rice | mordred: okay, will do. | 18:55 |
| mordred | but does it via appending - so it'll be like nova/blah openstacksdk/blah keystoneauth/blah | 18:55 |
| fried_rice | mordred: um, maybe will add a TODO | 18:55 |
| mordred | ++ | 18:55 |
| mordred | add a todo - I can followup | 18:56 |
| fried_rice | right now I just want to PoC this sucker. | 18:56 |
| mordred | yup | 18:56 |
| fried_rice | mordred: btw, is the above connection-y stuff how you envisioned this tying together from the pov of the openstacksdk consumer (i.e. nova)? | 18:56 |
| fried_rice | awkward that there's already a kwarg called `config`; I figured `oslo_conf` was adequately explicit. | 18:57 |
| mordred | fried_rice: yeah - I think that totally works. I was originally thinking the user might just use the openstack.config.from_conf or whatever I called it to make a CloudRegion that could be passed to Connection's config parameter ... | 18:58 |
| mordred | fried_rice: but your way makes total sense and I think should make it nicer for other openstack projects to follow suit | 18:58 |
| fried_rice | ight | 18:58 |
| mordred | so "yes" | 18:58 |
| fried_rice | ight | 18:58 |
| sean-k-mooney | melwitt: i have marked https://bugs.launchpad.net/nova/+bug/1801303 as incomplet and subsribed my self to the bug. if i get a responce i will retriage but this likely will end up getting moved to invlaide since its been a few months since it was first reported. | 19:02 |
| openstack | Launchpad bug 1801303 in OpenStack Compute (nova) "VM send DHCP request before openflow is created in br-int" [Low,Incomplete] | 19:02 |
| melwitt | sean-k-mooney: thanks for helping with that. yeah, hopefully we'll get a response | 19:03 |
| mordred | fried_rice: it seems like a slight logic error in Connection ... | 19:04 |
| mordred | but you said it worked for you | 19:05 |
| fried_rice | mordred: what seems like a logic error? | 19:05 |
| mordred | if session: is the first thing, then elif oslo_conf: | 19:05 |
| *** martinkennelly has quit IRC | 19:05 | |
| mordred | fried_rice: but you're passing in an oslo_conf and a session | 19:05 |
| fried_rice | hum, maybe that means it's only using the session and I don't need the conf :) | 19:05 |
| fried_rice | iow I'm not hitting your code at all | 19:05 |
| fried_rice | trying... | 19:06 |
| mordred | yeah. it'll totally work just with teh session | 19:06 |
| mordred | but - if there are any adapter level conf settings - like ... interface, region_name or endpoint_override they'll be ignored | 19:06 |
| mordred | (those being teh ones I could imagine are most likely for someone to set in their nova.conf file | 19:07 |
| fried_rice | ack (and confirmed btw). Will twiddle and retry to make sure it still works :) | 19:07 |
| mordred | cool! I left a comment on the review for posterity | 19:08 |
| fried_rice | ...also works fwiw | 19:09 |
| mordred | \o/ | 19:09 |
| fried_rice | I guess I would need to do something nonstandard with adapter-only settings to make sure it's actually excercising the code, but for now... | 19:09 |
| mordred | or just put ina print statement :) | 19:09 |
| mordred | but yeah - I thnk for now that's fine | 19:10 |
| fried_rice | No, I mean *exercising* | 19:10 |
| fried_rice | like, I should remove the public interface from my service catalog and set my conf to private | 19:10 |
| fried_rice | or something. | 19:10 |
| mordred | yeah. totally | 19:10 |
| mordred | fried_rice: if it's ok with you - I'll start updating that with docs | 19:13 |
| fried_rice | mordred: It's all yours. I'll buzz you if I need to diddle with it any further for local testing purposes, but I think I'm done for now. | 19:13 |
| *** priteau has quit IRC | 19:13 | |
| fried_rice | mordred: What happens if I pass kwargs like microversion and headers into primitives like .get? | 19:17 |
| *** gouthamr has quit IRC | 19:17 | |
| fried_rice | I think what I'm asking is, do I have to go around and remove all that shit from my placement client to make it go, or can I do that cleanup later? | 19:18 |
| *** dave-mccowan has quit IRC | 19:18 | |
| mordred | it works exactly like keystoneauth adaptr (it is a subclass of a ksa adapter) | 19:18 |
| fried_rice | okay, so probably redundant, but harmless | 19:18 |
| mordred | nah - I think you should totally pass those thigns in | 19:18 |
| *** IvensZambrano has quit IRC | 19:19 | |
| mordred | conn.placement.get() is pure passthrough ksa.Adapter. it doesn't do anything special with microverions for you - other than doing major version discovery | 19:19 |
| mordred | the higher order methods for other services, like ironic, are where the sdk will be handling microversions and headesr for you | 19:19 |
| mordred | but for placement - just a one-to-one swap should be totally fine | 19:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664 | 19:21 |
| fried_rice | mordred: ^ | 19:22 |
| fried_rice | expect that to fail unit/functional but pass tempest etc. | 19:22 |
| *** wolverineav has joined #openstack-nova | 19:22 | |
| fried_rice | assuming Depends-On chain works here... | 19:22 |
| mordred | probably because unit tests mock ksa somehow? | 19:22 |
| fried_rice | yes | 19:22 |
| fried_rice | um | 19:22 |
| mordred | I mean - to be fair - mocking ksa should still work | 19:22 |
| fried_rice | maybe | 19:22 |
| mordred | since it's still basically ksa | 19:22 |
| fried_rice | yeah, I suppose it's possible most of the unit/functional will still pass. | 19:22 |
| fried_rice | Just the ones that actually mock the get_ksa_adapter utils | 19:23 |
| fried_rice | will fail | 19:23 |
| mordred | yeah | 19:23 |
| fried_rice | we'll see | 19:23 |
| fried_rice | maybe the whole thing will blow up because I effed something. | 19:23 |
| fried_rice | But I'm generally super pleased with how simple this is turning out to be to get off the ground. | 19:23 |
| * fried_rice just cursed self | 19:23 | |
| mordred | fried_rice: yeah - being pleased is almost always the wrong choice :) | 19:24 |
| mordred | fried_rice: but yeah -s ince you already jinxed it - I'm also super pleased :) | 19:25 |
| fried_rice | hah! | 19:25 |
| fried_rice | Drinks tonight. Mourning next week. | 19:25 |
| *** wolverineav has quit IRC | 19:27 | |
| *** dave-mccowan has joined #openstack-nova | 19:32 | |
| *** eharney has joined #openstack-nova | 19:33 | |
| *** mchlumsky_ has quit IRC | 19:34 | |
| *** openstack has joined #openstack-nova | 19:42 | |
| *** ChanServ sets mode: +o openstack | 19:42 | |
| *** dave-mccowan has quit IRC | 19:43 | |
| *** tssurya has joined #openstack-nova | 19:46 | |
| *** ivve has joined #openstack-nova | 19:48 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement https://review.openstack.org/643664 | 19:48 |
| fried_rice | d'oh ^ | 19:48 |
| *** tbachman has quit IRC | 19:49 | |
| *** wolverineav has joined #openstack-nova | 19:50 | |
| *** gouthamr has joined #openstack-nova | 19:53 | |
| *** wolverineav has quit IRC | 19:57 | |
| *** pcaruana has quit IRC | 19:59 | |
| sean-k-mooney | fried_rice: are you going to pivot your ironic clinet patch to similarly use the openstack sdk? | 20:05 |
| fried_rice | sean-k-mooney: yes, was just about to make a start on that, if I can figure out how the baremetal sdk thingies work. | 20:06 |
| *** wolverineav has joined #openstack-nova | 20:06 | |
| sean-k-mooney | cool | 20:06 |
| sean-k-mooney | the openstacksdk has some gaps compared to the python-*client module but converting what can be converted makes sense | 20:07 |
| *** wolverineav has quit IRC | 20:20 | |
| *** wolverineav has joined #openstack-nova | 20:21 | |
| *** wolverineav has quit IRC | 20:25 | |
| *** gouthamr_ has joined #openstack-nova | 20:29 | |
| *** ivve has quit IRC | 20:34 | |
| *** whoami-rajat has quit IRC | 20:46 | |
| cfriesen | sean-k-mooney: https://review.openstack.org/#/c/631363/ and https://review.openstack.org/#/c/639934 seem to be working for me, I would appreciate some eyes on them. | 20:47 |
| *** hongbin has joined #openstack-nova | 20:49 | |
| *** martinkennelly has joined #openstack-nova | 20:50 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899 | 20:52 |
| fried_rice | sean-k-mooney, dtantsur|afk, needssleep, mordred: ^ | 20:53 |
| fried_rice | It seems like the Node object from the SDK has different fields than that of the ironicclient. Like, there's no uuid field! | 20:53 |
| fried_rice | which made that delta rather more of a pain than I wanted it to be. And will need it vetted by someone like dtantsur|afk | 20:54 |
| mordred | fried_rice: woot! and yeah ... there are a few areas where the sdk strives for internal consistency over consistency with actual external resource. id is one of them | 20:55 |
| mordred | so sorry about the patch size there | 20:55 |
| mordred | fried_rice: but it looks completely reasonable that converting that whole file won't be super terrible | 20:58 |
| needssleep | well, it was the lift that would have been the tests with how they are written that pretty much stopped me | 20:59 |
| mordred | needssleep: :) | 21:02 |
| mordred | I know that feeling | 21:02 |
| *** awaugama has quit IRC | 21:03 | |
| *** marst has quit IRC | 21:05 | |
| *** lbragstad has joined #openstack-nova | 21:08 | |
| fried_rice | needssleep: You mean you don't trust the CI to have complete coverage? :P | 21:14 |
| mordred | BLASPHEMY | 21:20 |
| *** gouthamr has quit IRC | 21:22 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove [ironic]api_endpoint option https://review.openstack.org/643483 | 21:22 |
| fried_rice | srsly ^ | 21:22 |
| *** BjoernT has quit IRC | 21:23 | |
| *** BjoernT has joined #openstack-nova | 21:27 | |
| mordred | fried_rice: \o/ | 21:29 |
| mnaser | yes please kill more endpoint config options :--) | 21:59 |
| *** tssurya has quit IRC | 22:10 | |
| *** awalende has joined #openstack-nova | 22:13 | |
| mordred | mnaser: did you see the other fun from fried_rice above? | 22:13 |
| *** awalende has quit IRC | 22:17 | |
| *** BjoernT has quit IRC | 22:18 | |
| *** mlavalle has joined #openstack-nova | 22:19 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix resetting non-persistent fields when saving obj https://review.openstack.org/643215 | 22:32 |
| *** tbachman has joined #openstack-nova | 22:37 | |
| *** tbachman_ has joined #openstack-nova | 22:39 | |
| *** tbachman has quit IRC | 22:42 | |
| *** tbachman_ is now known as tbachman | 22:42 | |
| *** markvoelker has joined #openstack-nova | 22:51 | |
| *** hongbin has quit IRC | 22:57 | |
| *** _alastor_ has quit IRC | 23:09 | |
| *** mriedem has quit IRC | 23:13 | |
| *** _alastor_ has joined #openstack-nova | 23:21 | |
| *** martinkennelly has quit IRC | 23:27 | |
| *** tbachman has quit IRC | 23:27 | |
| openstackgerrit | Merged openstack/nova stable/queens: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/637827 | 23:52 |
| openstackgerrit | Merged openstack/nova stable/pike: Handle missing marker during online data migration https://review.openstack.org/611343 | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!