| *** vishwanathj has joined #openstack-nova | 00:01 | |
| *** tbachman has joined #openstack-nova | 00:02 | |
| *** dave-mccowan has joined #openstack-nova | 00:04 | |
| *** wolverineav has joined #openstack-nova | 00:04 | |
| *** hongbin has quit IRC | 00:06 | |
| *** sdake_ has quit IRC | 00:08 | |
| *** wolverineav has quit IRC | 00:10 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** wolverineav has joined #openstack-nova | 00:12 | |
| openstackgerrit | Merged openstack/nova stable/queens: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/623547 | 00:14 |
|---|---|---|
| *** agopi has joined #openstack-nova | 00:15 | |
| *** slaweq has quit IRC | 00:16 | |
| *** wolverineav has quit IRC | 00:17 | |
| *** s10 has quit IRC | 00:22 | |
| *** sdake has joined #openstack-nova | 00:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline https://review.openstack.org/627282 | 00:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | 00:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated 'os-server-groups' policy https://review.openstack.org/633672 | 00:31 |
| *** tbachman has quit IRC | 00:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove deprecated 'flavors' policy https://review.openstack.org/633664 | 00:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494 | 00:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150 | 00:32 |
| *** lbragstad has quit IRC | 00:35 | |
| *** zhubx007 has quit IRC | 00:37 | |
| *** zhubx007 has joined #openstack-nova | 00:37 | |
| *** lbragstad has joined #openstack-nova | 00:39 | |
| *** igordc has joined #openstack-nova | 00:43 | |
| *** READ10 has quit IRC | 00:49 | |
| *** wolverineav has joined #openstack-nova | 00:50 | |
| *** ileixe has joined #openstack-nova | 00:53 | |
| *** markvoelker has joined #openstack-nova | 00:53 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** gyee has quit IRC | 00:54 | |
| *** macza has quit IRC | 01:04 | |
| *** tbachman has joined #openstack-nova | 01:16 | |
| *** takamatsu_ has joined #openstack-nova | 01:26 | |
| *** markvoelker has quit IRC | 01:26 | |
| *** takamatsu has quit IRC | 01:26 | |
| *** mlavalle has quit IRC | 01:36 | |
| *** sdake has quit IRC | 01:44 | |
| *** sdake has joined #openstack-nova | 01:45 | |
| *** sdake has joined #openstack-nova | 01:46 | |
| *** wolverineav has quit IRC | 02:01 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:04 | |
| *** _fragatina has quit IRC | 02:11 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** hamzy has joined #openstack-nova | 02:15 | |
| *** slaweq has quit IRC | 02:15 | |
| *** erlon__ has quit IRC | 02:19 | |
| *** markvoelker has joined #openstack-nova | 02:23 | |
| *** bhagyashris has joined #openstack-nova | 02:24 | |
| *** wolverineav has joined #openstack-nova | 02:25 | |
| openstackgerrit | YI-JIE,SYU proposed openstack/nova stable/rocky: Remove deprecated nova-consoleauth reference from doc https://review.openstack.org/614055 | 02:25 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 02:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351 | 02:28 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 02:28 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 02:28 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 02:28 |
| openstackgerrit | melanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574 | 02:28 |
| *** wolverineav has quit IRC | 02:29 | |
| *** wolverineav has joined #openstack-nova | 02:31 | |
| *** sdake has quit IRC | 02:32 | |
| *** wolverineav has quit IRC | 02:33 | |
| *** sdake has joined #openstack-nova | 02:34 | |
| *** sdake has quit IRC | 02:38 | |
| *** sdake_ has joined #openstack-nova | 02:39 | |
| *** ccamacho has quit IRC | 02:48 | |
| *** lbragstad_ has joined #openstack-nova | 02:54 | |
| *** lbragstad has quit IRC | 02:55 | |
| *** markvoelker has quit IRC | 02:57 | |
| *** whoami-rajat has joined #openstack-nova | 02:57 | |
| *** takashin has left #openstack-nova | 03:00 | |
| *** sdake_ has quit IRC | 03:03 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| alex_xu | artom: efried sorry, I only can say give a try. probably try to find out a time in weekend | 03:06 |
| *** sdake has joined #openstack-nova | 03:10 | |
| alex_xu | artom: efried and I definitely can't spell the full name of NUMA, so :) | 03:13 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix destination_type attribute in the bdm_v2 documentation https://review.openstack.org/626875 | 03:16 |
| *** Kunpeng has joined #openstack-nova | 03:18 | |
| *** janki has joined #openstack-nova | 03:20 | |
| *** bryan_stephenson has joined #openstack-nova | 03:27 | |
| *** sdake has quit IRC | 03:33 | |
| * bryan_stephenson I have forked the nova repo and am editing /openstack/nova/tree/master/doc/source/user/support-matrix.ini to document a new feature we are adding. How do I test render this to check that it is OK? Simply rendering the companion .rst file does not work. | 03:34 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix destination_type attribute in the bdm_v2 documentation https://review.openstack.org/626876 | 03:34 |
| openstackgerrit | Merged openstack/nova stable/pike: De-dupe subnet IDs when calling neutron /subnets API https://review.openstack.org/632480 | 03:35 |
| *** _fragatina has joined #openstack-nova | 03:40 | |
| alex_xu | bryan_stephenson: tox -e docs | 03:44 |
| *** cfriesen has quit IRC | 03:50 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.openstack.org/631243 | 03:51 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 03:51 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 03:51 |
| *** bryan_stephenson has quit IRC | 03:51 | |
| openstackgerrit | Merged openstack/nova stable/queens: Do not dump all instances in the scheduler https://review.openstack.org/629822 | 03:53 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix os-simple-tenant-usage result order https://review.openstack.org/632516 | 03:53 |
| *** udesale has joined #openstack-nova | 03:53 | |
| *** markvoelker has joined #openstack-nova | 03:54 | |
| *** Dinesh_Bhor has quit IRC | 03:55 | |
| *** _fragatina has quit IRC | 03:57 | |
| *** _fragatina has joined #openstack-nova | 03:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:00 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** ileixe has quit IRC | 04:13 | |
| *** tetsuro has joined #openstack-nova | 04:14 | |
| *** ileixe has joined #openstack-nova | 04:15 | |
| *** slaweq has quit IRC | 04:16 | |
| *** cfriesen has joined #openstack-nova | 04:17 | |
| *** wolverineav has joined #openstack-nova | 04:20 | |
| *** wolverineav has quit IRC | 04:24 | |
| *** markvoelker has quit IRC | 04:27 | |
| *** abhishekk has joined #openstack-nova | 04:43 | |
| *** Dinesh_Bhor has quit IRC | 04:47 | |
| *** lpetrut has joined #openstack-nova | 04:49 | |
| openstackgerrit | Merged openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | 04:54 |
| *** Dinesh_Bhor has joined #openstack-nova | 04:54 | |
| *** _fragatina has quit IRC | 05:05 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** slaweq has quit IRC | 05:15 | |
| *** ratailor has joined #openstack-nova | 05:21 | |
| *** markvoelker has joined #openstack-nova | 05:24 | |
| *** lpetrut has quit IRC | 05:25 | |
| *** gmann has quit IRC | 05:28 | |
| *** pbing19 has joined #openstack-nova | 05:31 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 05:33 |
| *** ociuhandu has joined #openstack-nova | 05:36 | |
| *** ociuhandu has quit IRC | 05:40 | |
| openstackgerrit | Merged openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 05:42 |
| openstackgerrit | Merged openstack/nova stable/rocky: Don't emit warning when ironic properties are zero https://review.openstack.org/608573 | 05:42 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 05:47 |
| *** lpetrut has joined #openstack-nova | 05:54 | |
| *** markvoelker has quit IRC | 05:58 | |
| *** pbing19 has quit IRC | 05:58 | |
| openstackgerrit | Fan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration. https://review.openstack.org/612272 | 05:59 |
| *** pbing19 has joined #openstack-nova | 06:02 | |
| openstackgerrit | Asmita Singh proposed openstack/python-novaclient master: Handle unicode multi-byte characters https://review.openstack.org/632942 | 06:02 |
| *** abhishekk has quit IRC | 06:06 | |
| *** _fragatina has joined #openstack-nova | 06:07 | |
| *** _fragatina has quit IRC | 06:24 | |
| *** pbing19 has quit IRC | 06:26 | |
| *** mdbooth_ has quit IRC | 06:35 | |
| *** pbing19 has joined #openstack-nova | 06:35 | |
| *** Luzi has joined #openstack-nova | 06:41 | |
| *** sridharg has joined #openstack-nova | 06:42 | |
| *** sunnaichuan has quit IRC | 06:51 | |
| *** ratailor has quit IRC | 06:53 | |
| *** ratailor has joined #openstack-nova | 06:53 | |
| *** markvoelker has joined #openstack-nova | 06:55 | |
| *** sdake has joined #openstack-nova | 06:59 | |
| *** pbing19 has quit IRC | 06:59 | |
| *** pbing19 has joined #openstack-nova | 07:00 | |
| openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592 | 07:03 |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** igordc has quit IRC | 07:12 | |
| *** Dinesh_Bhor has quit IRC | 07:13 | |
| *** ivve has joined #openstack-nova | 07:14 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:15 | |
| *** Pbing has joined #openstack-nova | 07:15 | |
| *** slaweq has quit IRC | 07:15 | |
| *** pbing19 has quit IRC | 07:17 | |
| *** stakeda has joined #openstack-nova | 07:20 | |
| *** dpawlik has quit IRC | 07:28 | |
| *** markvoelker has quit IRC | 07:28 | |
| *** sdake has quit IRC | 07:33 | |
| *** dpawlik has joined #openstack-nova | 07:39 | |
| *** ShilpaSD has quit IRC | 07:48 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj https://review.openstack.org/634547 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj https://review.openstack.org/634548 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver https://review.openstack.org/634549 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage https://review.openstack.org/634550 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.openstack.org/634551 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.openstack.org/634552 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group https://review.openstack.org/634553 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems https://review.openstack.org/634554 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.openstack.org/634555 | 07:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.openstack.org/634556 | 07:51 |
| openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | 07:52 |
| *** belmoreira has quit IRC | 07:54 | |
| *** ratailor has quit IRC | 07:57 | |
| *** ratailor has joined #openstack-nova | 07:58 | |
| *** belmoreira has joined #openstack-nova | 08:05 | |
| *** lbragstad_ has quit IRC | 08:07 | |
| *** slaweq has joined #openstack-nova | 08:08 | |
| *** awalende has joined #openstack-nova | 08:12 | |
| *** tkajinam has quit IRC | 08:13 | |
| *** Pbing has quit IRC | 08:13 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 08:17 |
| *** tssurya has joined #openstack-nova | 08:18 | |
| *** sdake has joined #openstack-nova | 08:18 | |
| *** tesseract has joined #openstack-nova | 08:20 | |
| *** yaawang has joined #openstack-nova | 08:24 | |
| *** markvoelker has joined #openstack-nova | 08:25 | |
| *** cdent has joined #openstack-nova | 08:30 | |
| *** mdbooth has joined #openstack-nova | 08:32 | |
| *** jiaopengju has quit IRC | 08:54 | |
| *** dtantsur|afk is now known as dtantsur | 08:58 | |
| *** markvoelker has quit IRC | 08:59 | |
| *** cfriesen has quit IRC | 09:07 | |
| *** ociuhandu has joined #openstack-nova | 09:10 | |
| *** panda|ruck|off is now known as panda|ruck | 09:24 | |
| *** sdake has quit IRC | 09:26 | |
| openstackgerrit | Mark Goddard proposed openstack/nova stable/queens: Don't emit warning when ironic properties are zero https://review.openstack.org/608611 | 09:27 |
| *** cdent has quit IRC | 09:31 | |
| *** tetsuro has quit IRC | 09:33 | |
| *** snevi has joined #openstack-nova | 09:33 | |
| *** jaosorior has quit IRC | 09:33 | |
| *** ivve has quit IRC | 09:34 | |
| *** jaosorior has joined #openstack-nova | 09:35 | |
| *** cdent has joined #openstack-nova | 09:36 | |
| *** yan0s has joined #openstack-nova | 09:41 | |
| *** helenaAM has joined #openstack-nova | 09:46 | |
| *** stakeda has quit IRC | 09:47 | |
| stephenfin | lyarwood: Could you do me the honours? https://review.openstack.org/636918 | 09:47 |
| stephenfin | Honour? | 09:47 |
| stephenfin | Hmm... | 09:47 |
| *** stephenfin is now known as finucannot | 09:48 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 09:50 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 09:50 |
| *** bhagyashris has quit IRC | 09:55 | |
| *** markvoelker has joined #openstack-nova | 09:56 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for I0c764e441993e32aafef0b18049a425c3c832a50 https://review.openstack.org/638517 | 09:57 |
| *** lyarwood is now known as lyaaaaarwood | 09:59 | |
| lyaaaaarwood | finucannot: will do | 09:59 |
| *** dtantsur is now known as dtantsur|brb | 10:01 | |
| *** takamatsu_ has quit IRC | 10:04 | |
| *** gibi is now known as giblet | 10:04 | |
| *** takamatsu has joined #openstack-nova | 10:05 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 10:22 |
| *** Dinesh_Bhor has quit IRC | 10:23 | |
| *** takamatsu_ has joined #openstack-nova | 10:23 | |
| *** ileixe has quit IRC | 10:24 | |
| *** takamatsu has quit IRC | 10:24 | |
| yonglihe | Hi, jaypipes, you might want to comment https://review.openstack.org/#/c/621474/21, you working on that spec so much. And thanks. | 10:25 |
| *** Dinesh_Bhor has joined #openstack-nova | 10:25 | |
| *** markvoelker has quit IRC | 10:28 | |
| *** sridharg has quit IRC | 10:30 | |
| *** rcernin has quit IRC | 10:31 | |
| *** sridharg has joined #openstack-nova | 10:43 | |
| *** moshele has joined #openstack-nova | 10:47 | |
| *** takamatsu_ has quit IRC | 10:48 | |
| *** takamatsu has joined #openstack-nova | 10:49 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj https://review.openstack.org/634547 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj https://review.openstack.org/634548 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver https://review.openstack.org/634549 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage https://review.openstack.org/634550 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.openstack.org/634551 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec https://review.openstack.org/634552 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group https://review.openstack.org/634553 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems https://review.openstack.org/634554 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying https://review.openstack.org/634555 | 10:51 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration https://review.openstack.org/634556 | 10:51 |
| *** ccamacho has joined #openstack-nova | 10:54 | |
| *** erlon has joined #openstack-nova | 10:54 | |
| *** ccamacho has quit IRC | 10:54 | |
| *** takamatsu has quit IRC | 10:54 | |
| *** takamatsu has joined #openstack-nova | 10:58 | |
| *** udesale has quit IRC | 10:59 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 11:04 |
| *** macza has joined #openstack-nova | 11:09 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support adding the reason behind a server lock https://review.openstack.org/638629 | 11:09 |
| *** sdake has joined #openstack-nova | 11:11 | |
| *** tosky has joined #openstack-nova | 11:12 | |
| *** macza has quit IRC | 11:14 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for VIF types https://review.openstack.org/637009 | 11:21 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for profile, datapath offload types https://review.openstack.org/638395 | 11:21 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Start using sphinx.ext.autodoc for VIF types https://review.openstack.org/638404 | 11:21 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: doc: Use sphinx.ext.todo for profile, datapath offload types https://review.openstack.org/638405 | 11:21 |
| *** markvoelker has joined #openstack-nova | 11:25 | |
| *** Dinesh_Bhor has quit IRC | 11:38 | |
| *** priteau has joined #openstack-nova | 11:46 | |
| *** tbachman has quit IRC | 11:48 | |
| *** gmann has joined #openstack-nova | 11:49 | |
| *** Dinesh_Bhor has joined #openstack-nova | 11:55 | |
| *** Dinesh_Bhor has quit IRC | 11:57 | |
| *** erlon_ has joined #openstack-nova | 11:58 | |
| *** markvoelker has quit IRC | 11:59 | |
| *** erlon has quit IRC | 11:59 | |
| *** moshele has quit IRC | 11:59 | |
| *** janki has quit IRC | 12:01 | |
| *** sdake has quit IRC | 12:03 | |
| *** _fragatina has joined #openstack-nova | 12:03 | |
| *** sdake_ has joined #openstack-nova | 12:04 | |
| *** dpawlik has quit IRC | 12:16 | |
| *** udesale has joined #openstack-nova | 12:16 | |
| *** dpawlik has joined #openstack-nova | 12:23 | |
| openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.openstack.org/635220 | 12:26 |
| *** priteau has quit IRC | 12:31 | |
| *** dtantsur|brb is now known as dtantsur | 12:35 | |
| *** ivve has joined #openstack-nova | 12:35 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: Clarify upgrade situation in NUMA live migration https://review.openstack.org/638653 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 12:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Drop MoveClaim in rollback_live_migration_at_destination https://review.openstack.org/638654 | 12:38 |
| *** priteau has joined #openstack-nova | 12:39 | |
| *** ccamacho has joined #openstack-nova | 12:39 | |
| *** ratailor has quit IRC | 12:45 | |
| *** liuyulong has joined #openstack-nova | 12:49 | |
| *** _pewp_ has quit IRC | 12:51 | |
| *** _pewp_ has joined #openstack-nova | 12:52 | |
| *** markvoelker has joined #openstack-nova | 12:56 | |
| *** ociuhandu has quit IRC | 13:01 | |
| *** tbachman has joined #openstack-nova | 13:06 | |
| *** pbing19 has joined #openstack-nova | 13:07 | |
| *** pbing19 has quit IRC | 13:08 | |
| *** pbing19 has joined #openstack-nova | 13:09 | |
| *** mriedem has joined #openstack-nova | 13:10 | |
| *** panda|ruck is now known as panda|lunch | 13:10 | |
| *** dave-mccowan has joined #openstack-nova | 13:18 | |
| *** pbing19 has quit IRC | 13:20 | |
| *** sambetts_ has quit IRC | 13:21 | |
| *** sambetts_ has joined #openstack-nova | 13:24 | |
| *** udesale has quit IRC | 13:25 | |
| *** markvoelker has quit IRC | 13:28 | |
| *** jmlowe has quit IRC | 13:30 | |
| *** moshele has joined #openstack-nova | 13:33 | |
| *** psachin has quit IRC | 13:35 | |
| *** hamzy has quit IRC | 13:35 | |
| mriedem | giblet: some questions in https://review.openstack.org/#/c/569459/ | 13:37 |
| *** cfriesen has joined #openstack-nova | 13:38 | |
| *** hamzy has joined #openstack-nova | 13:40 | |
| *** awaugama has joined #openstack-nova | 13:41 | |
| giblet | mriedem: thanks, I will check it soon | 13:41 |
| *** moshele has quit IRC | 13:41 | |
| *** udesale has joined #openstack-nova | 13:41 | |
| giblet | mriedem: I've also looked into the Selection object usage instead of querying placement about allocations. It is easy so I will push a fup | 13:42 |
| giblet | mriedem: I also thinking about storing the provider_summaries in the Selection object to avoid the trait query as well | 13:42 |
| giblet | it is a bit more code as it needs a version bump on the Selection object | 13:42 |
| *** dave-mccowan has quit IRC | 13:43 | |
| *** artom is now known as temka | 13:43 | |
| *** moshele has joined #openstack-nova | 13:43 | |
| *** agopi has quit IRC | 13:44 | |
| *** dave-mccowan has joined #openstack-nova | 13:44 | |
| mriedem | giblet: yeah that's why in my fup i said short-term optimization (cache) and long-term (provider summary traits -> Selection object) | 13:44 |
| mriedem | giblet: as for reading the allocations off the Selection.allocation_request, jaypipes did warn yesterday that if that request format changes, it could break your code (but we have the version of the format so i guess we could deal with that when the time comes, if it comes) | 13:45 |
| mriedem | today the allocation request mirrors the response, which was a smart move looking back (thanks cdent) | 13:45 |
| *** moshele has quit IRC | 13:45 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 13:46 |
| cdent | don't that me, thank "HTTP API BEST PRACTICES"... or something | 13:46 |
| openstackgerrit | Merged openstack/nova stable/queens: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620578 | 13:46 |
| giblet | mriedem: noted the possible format change. I can put a NOTE to the allocation_request field definition to warn the future developer | 13:46 |
| openstackgerrit | Merged openstack/nova stable/queens: tox: Don't write byte code (maybe) https://review.openstack.org/636918 | 13:46 |
| mriedem | kashyap: this looks like a new one for the gate http://logs.openstack.org/48/631948/9/check/tempest-full-py3/e2ae3fb/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Feb_21_17_24_48_562689 | 13:48 |
| giblet | mriedem: will there be separate Selection object for each instance created in the same multi-create request? or in other words can I use a non ovo field on the Selection object as a trait cache? | 13:48 |
| mriedem | selections are 1:1 with the requested instances we're building yes | 13:49 |
| mriedem | because the 10th instance in the request could have a different primary and alternate hosts b/c the first 9 consumed all of the resources on some other hosts | 13:49 |
| giblet | mriedem: OK, then I need a separate cache | 13:49 |
| *** ccamacho has quit IRC | 13:50 | |
| mriedem | yeah - there are already some caches used in schedule_and_build_instances | 13:50 |
| mriedem | for host mappings and az queries | 13:50 |
| giblet | mriedem: ahh I see. That is a pattern I can follow | 13:50 |
| *** ccamacho has joined #openstack-nova | 13:51 | |
| *** sdake_ has quit IRC | 13:51 | |
| giblet | mriedem: do we handle re-schedule during multi-create in a special way or is it the same re-schedule code path? We have to call _fill_provider_mapping for the re-schedule too | 13:51 |
| mriedem | same as single instance | 13:52 |
| mriedem | the reschedule just gets 1 instance | 13:52 |
| mriedem | a list of 1 i should say | 13:52 |
| mriedem | that is rpc cast from compute here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2024 | 13:53 |
| giblet | mriedem: then the cache would not work for re-schedule but the Selection object based soluton would work as re-schedule gets the Selection object too | 13:53 |
| mriedem | we don't need the cache for reschedule since it's 1 instance | 13:54 |
| mriedem | the cache is more for multi-create | 13:54 |
| *** agopi has joined #openstack-nova | 13:54 | |
| mriedem | but yeah again, short and long term optimizations | 13:54 |
| giblet | if half of a multi-create hit the same faulty compute then we got a bunch of re-schedule at the same time | 13:54 |
| giblet | but anyhow I will do a local cache for Stein as time is sort | 13:55 |
| mriedem | exactly | 13:55 |
| giblet | mriedem: thanks for the help! | 13:55 |
| mriedem | Selection object change to stash the traits will be an rpc change | 13:55 |
| mriedem | np | 13:55 |
| giblet | mriedem: good point about the rpc change. I don't want to start that 2 weeks before FF | 13:56 |
| mriedem | and i dont want to have to think about it right now either :) | 13:56 |
| *** mlavalle has joined #openstack-nova | 13:56 | |
| *** agopi_ has joined #openstack-nova | 13:58 | |
| giblet | mriedem: mentioning RPC change. Does the extension of InstancePCIRequest ovo also needs an rpc bump, here? https://review.openstack.org/#/c/625310/23 | 13:58 |
| mriedem | the object version bump is the rpc change | 13:59 |
| giblet | mriedem: then we still have this rpc change in the bandwidth series unfortunately | 13:59 |
| mriedem | sure i think that's fine - it's at least code you've already tested / demo'ed yeah? | 14:00 |
| *** agopi has quit IRC | 14:00 | |
| mriedem | i'd like to avoid *new* complexity with 2 weeks left | 14:00 |
| giblet | mriedem: I've tested that code in the functional env. Not demoed yet as that code was not ready for the last demo in Berlin | 14:01 |
| giblet | I agree to avoid new complexity added. heal allocation is still not finished and that has its own complexity | 14:02 |
| giblet | I need to run some downstream errands, brb | 14:03 |
| *** dave-mccowan has quit IRC | 14:05 | |
| *** lbragstad_ has joined #openstack-nova | 14:05 | |
| *** lbragstad_ is now known as lbragstad | 14:07 | |
| mriedem | dansmith: you want to make sure this is ok https://review.openstack.org/#/c/636210/ - i think it's just removing dead code at this point | 14:10 |
| *** panda|lunch is now known as panda | 14:13 | |
| aspiers | mriedem, efried: the capabilities patch makes adding an SEV capability extremely easy! in case you're curious: https://github.com/aspiers/nova/commit/sev-trait | 14:15 |
| aspiers | I can't submit to Gerrit yet because it depends on two patches which are not dependent on each other | 14:15 |
| *** sdake has joined #openstack-nova | 14:17 | |
| *** _pewp_ has quit IRC | 14:18 | |
| *** _pewp_ has joined #openstack-nova | 14:20 | |
| *** panda is now known as panda|rcuk | 14:21 | |
| *** panda|rcuk is now known as panda|ruck | 14:21 | |
| *** dpawlik has quit IRC | 14:23 | |
| *** priteau has quit IRC | 14:25 | |
| *** markvoelker has joined #openstack-nova | 14:25 | |
| *** eharney has joined #openstack-nova | 14:25 | |
| mriedem | cool, that's kind of the idea | 14:27 |
| mriedem | you could break that down by moving the capabilities to the driver instance level rather than the class | 14:27 |
| mriedem | i think that would fix an issue i had in libvirt driver tests with the multiattach stuff | 14:27 |
| aspiers | isn't that what I did? | 14:28 |
| * aspiers is confused | 14:28 | |
| mriedem | you did, but in the same patch that adds the amd sev capability | 14:28 |
| mriedem | anyway nvm | 14:28 |
| aspiers | oh, in a separate patch | 14:28 |
| aspiers | yeah, I did wonder about that | 14:28 |
| aspiers | happy to split it out! if you think it's worth it | 14:28 |
| mriedem | it's fine to leave it | 14:29 |
| aspiers | I'll do it :) | 14:29 |
| aspiers | ah, I remember my thinking now | 14:29 |
| aspiers | this is only required for drivers with dynamic capabilities, right? | 14:29 |
| aspiers | but I missed the fact that multiattach is already dynamic | 14:30 |
| aspiers | smaller patches -> easier quicker reviews | 14:30 |
| aspiers | so I'll do it | 14:30 |
| openstackgerrit | Merged openstack/nova master: Follow up for I0c764e441993e32aafef0b18049a425c3c832a50 https://review.openstack.org/638517 | 14:37 |
| *** awalende has quit IRC | 14:37 | |
| *** awalende has joined #openstack-nova | 14:38 | |
| *** dave-mccowan has joined #openstack-nova | 14:38 | |
| *** bnemec is now known as beekneemech | 14:39 | |
| aspiers | mriedem: done https://github.com/aspiers/nova/compare/sev-deps...aspiers:sev-trait | 14:39 |
| *** priteau has joined #openstack-nova | 14:40 | |
| mriedem | aspiers: so why are these in github and not gerrit? | 14:40 |
| aspiers | mriedem: because they depend on two unmerged patches which are not dependent on each other | 14:41 |
| mdbooth | lyaaaaarwood: I think this needs a refactor into a separate test class: https://review.openstack.org/#/c/637527/ | 14:41 |
| aspiers | mriedem: so I can't submit them in a series, because that would introduce an artificial dependency | 14:41 |
| aspiers | and AFAIK Depends-On is only for cross-repo dependencies | 14:42 |
| mriedem | what are the other 2 patches? | 14:42 |
| aspiers | https://review.openstack.org/#/c/538498/ and https://review.openstack.org/#/c/633855/ | 14:43 |
| aspiers | they are mentioned in the commit message | 14:43 |
| *** awalende has quit IRC | 14:43 | |
| sean-k-mooney | aspiers: it works withing the same repo too but when its in teh same repo it makes more sense to rebase on top of the patch | 14:43 |
| mriedem | aspiers: your sev stuff can be rebased on top of https://review.openstack.org/#/c/538498/ yes? | 14:43 |
| aspiers | sean-k-mooney: agreed | 14:43 |
| *** sdake has quit IRC | 14:43 | |
| mdbooth | aspiers: The practical solution is to have the artificial dependency. | 14:43 |
| mriedem | yeah i'd just stack these all up | 14:43 |
| mriedem | with https://review.openstack.org/#/c/538498/ at the bottom | 14:43 |
| aspiers | mriedem, mdbooth: OK I'm totally fine with that if you guys are, thanks | 14:43 |
| mriedem | and then https://review.openstack.org/#/c/633855/ | 14:43 |
| mriedem | and then the stuff that sets the capability | 14:44 |
| aspiers | yup | 14:44 |
| aspiers | will do now | 14:44 |
| dansmith | mriedem: done | 14:45 |
| mdbooth | aspiers: If you find that a patch which isn't on the bottom gets +2s you can always rebase it to the bottom. If it's a clean rebase you'll retain the +2s and it can merge. | 14:45 |
| aspiers | mdbooth: nice tip, thanks | 14:45 |
| mdbooth | aspiers: It's not great, but it's kinda ok and doesn't usually come up that much. | 14:45 |
| aspiers | I suspect Gerrit 2.16 will handle this better, as I mentioned the other day | 14:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Don't emit warning when ironic properties are zero https://review.openstack.org/608611 | 14:46 |
| *** sdake has joined #openstack-nova | 14:46 | |
| aspiers | Oh, that wasn't in this channel | 14:46 |
| *** dklyle has quit IRC | 14:46 | |
| *** david-lyle has joined #openstack-nova | 14:46 | |
| lyaaaaarwood | mdbooth: pretty sure you can migrate between two backends on the same host | 14:46 |
| lyaaaaarwood | mdbooth: that's what I've been testing locally at least | 14:47 |
| lyaaaaarwood | mdbooth: they don't need to be different c-vols | 14:47 |
| aspiers | Ah, it was :-) mdbooth: in case you missed it: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-12.log.html#t2019-02-12T22:08:56 | 14:47 |
| lyaaaaarwood | mdbooth: https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded=migrate-a-volume-detail#migrate-a-volume - when the docs talk about migrating to a host they mean hostname@backend where hostname can be the same host still. | 14:50 |
| mdbooth | lyaaaaarwood: Isn't that retype? | 14:52 |
| kashyap | mriedem: Looking ... my IRC proxy dropped me off of Freenode | 14:53 |
| kashyap | mriedem: Did you file a bug yet? Or shall I? | 14:53 |
| *** hongbin has joined #openstack-nova | 14:54 | |
| lyaaaaarwood | mdbooth: https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded=migrate-a-volume-detail,complete-migration-of-a-volume-detail,retype-a-volume-detail#retype-a-volume - that's a totally different API | 14:54 |
| lyaaaaarwood | mdbooth: where you can do the same thing, just with types that have backends defined in them. | 14:55 |
| lyaaaaarwood | mdbooth: and again they take the form of hostname@backend | 14:55 |
| lyaaaaarwood | mdbooth: so you can migrate between backends on the same host | 14:55 |
| lyaaaaarwood | ^ sorry retype | 14:55 |
| *** efried is now known as fried_rice | 14:56 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Change LibvirtDriver.capabilities to an instance variable https://review.openstack.org/638677 | 14:56 |
| mdbooth | lyaaaaarwood: So retype and migrate are literally identical operations, just with different semantics for specifying the source and dest? | 14:56 |
| mriedem | kashyap: https://bugs.launchpad.net/nova/+bug/1817324 | 14:56 |
| openstack | Launchpad bug 1817324 in OpenStack Compute (nova) "Intermittent "Failed to start libvirt guest: libvirt.libvirtError: monitor socket did not show up: No such file or directory" failures in the gate" [Undecided,Confirmed] | 14:56 |
| lyaaaaarwood | mdbooth: yeah pretty much | 14:57 |
| kashyap | Thanks | 14:57 |
| mdbooth | lyaaaaarwood: I don't understand, tbh. | 14:57 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 14:58 |
| *** markvoelker has quit IRC | 14:59 | |
| kashyap | mriedem: On your comment in the bug; for that failure, the interesting stuff won't be in the QEMU guest log; it would be in the libvirt <-> QEMU interactions log (which the Gate captures) | 14:59 |
| lyaaaaarwood | mdbooth: with migrate you provide the host (hostname@backend) you want to migrate to. With retype you provide a type you'd like to migrate to that can optionally contain a host (hostname@backend) extra spec that moves the volume | 14:59 |
| mriedem | kashyap: i looked in the libvirtd log and didn't really see anything interesting | 15:00 |
| mriedem | kashyap: besides stuff like it created the monitor for that instance and events weren't getting handled, something like that | 15:00 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.openstack.org/638680 | 15:01 |
| kashyap | Nod; /me still downloading the log | 15:01 |
| *** ccamacho has quit IRC | 15:01 | |
| *** jmlowe has joined #openstack-nova | 15:02 | |
| *** _pewp_ has quit IRC | 15:03 | |
| *** _pewp_ has joined #openstack-nova | 15:04 | |
| *** mchlumsky has quit IRC | 15:08 | |
| frickler | mriedem: anything I can do to help with https://bugs.launchpad.net/nova/+bug/1815082 ? | 15:09 |
| openstack | Launchpad bug 1815082 in OpenStack Compute (nova) ""DBNonExistentTable: (sqlite3.OperationalError) no such table: services" when starting nova-metadata under uwsgi" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 15:09 |
| frickler | I'm also wondering whether this may be a duplicate actually https://bugs.launchpad.net/devstack/+bug/1814016 | 15:09 |
| openstack | Launchpad bug 1814016 in devstack "Subnode required CELLSV2_SETUP=superconductor to be explicitly set" [Undecided,New] | 15:09 |
| *** mchlumsky has joined #openstack-nova | 15:10 | |
| mriedem | frickler: ah i forgot about that | 15:15 |
| *** Luzi has quit IRC | 15:16 | |
| *** _pewp_ has quit IRC | 15:17 | |
| frickler | mriedem: o.k., I'm assuming I did my part of the job, then. ;) | 15:17 |
| mriedem | well n-api-meta is hitting conductor http://logs.openstack.org/77/635577/2/check/tempest-full/152e5bc/controller/logs/screen-n-api-meta.txt.gz#_Feb_08_16_53_34_572980 | 15:18 |
| mriedem | i think | 15:18 |
| *** udesale has quit IRC | 15:18 | |
| mriedem | but it seems that the conductor it's hitting isn't up yet | 15:18 |
| *** Sundar has joined #openstack-nova | 15:19 | |
| mriedem | we start n-api-meta here | 15:20 |
| mriedem | http://logs.openstack.org/77/635577/2/check/tempest-full/152e5bc/controller/logs/devstacklog.txt.gz#_2019-02-08_16_52_32_215 | 15:20 |
| frickler | http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n1096 | 15:20 |
| frickler | that's in start_nova_rest, way before _conductor, yes | 15:20 |
| mriedem | yeah n-super-cond is started here: | 15:21 |
| mriedem | http://logs.openstack.org/77/635577/2/check/tempest-full/152e5bc/controller/logs/devstacklog.txt.gz#_2019-02-08_16_52_36_721 | 15:21 |
| frickler | probably n-api-meta should idle a bit and retry | 15:21 |
| *** sdake has quit IRC | 15:21 | |
| frickler | even if we fix the order in devstack, we can't assume deployers will fine tune this everywhere | 15:22 |
| mriedem | start_nova_rest is kind of weird - it starts nova-network as well which has always needed conductor to start first | 15:22 |
| kashyap | mriedem: Oops: I think it is due to two 'pty' consoles getting reated...see lines 87-97 (from the n-cpu log): http://paste.openstack.org/show/745736/ | 15:22 |
| * kashyap will dig further after two meetings | 15:23 | |
| *** sdake has joined #openstack-nova | 15:23 | |
| mriedem | kashyap: would that be due to your recent version bump change? | 15:23 |
| mriedem | which messed with the console code? | 15:23 |
| kashyap | Yes, very much likely :-( | 15:23 |
| kashyap | I fixed the s390x case, and I didn't see this at all in normal runs | 15:23 |
| kashyap | Sigh | 15:23 |
| kashyap | This seems to be 'isa-serial'-related | 15:24 |
| mriedem | something something risk of doing this at the end of a release... | 15:24 |
| *** priteau has quit IRC | 15:27 | |
| *** mrch_ has quit IRC | 15:28 | |
| kashyap | Yeah, I know what you mean. I made at least 3 folks to review, including the last person who reworked that code | 15:28 |
| *** mrch_ has joined #openstack-nova | 15:28 | |
| kashyap | I'll work towards fixing it as quickly as I can. | 15:28 |
| *** jangutter has quit IRC | 15:30 | |
| *** jobewan has joined #openstack-nova | 15:31 | |
| mriedem | frickler: i think we're hitting the wrong conductor maybe | 15:31 |
| mriedem | frickler: conductor is effectively started at 16:52:40 | 15:32 |
| mriedem | n-super-cond that is | 15:32 |
| mriedem | n-api-meta times out at 16:53:34 | 15:32 |
| mriedem | note there is a 60 second rpc_response_timeout on that db query | 15:32 |
| *** david-lyle is now known as dklyle | 15:33 | |
| mriedem | problem is i'm not exactly sure which conductor n-api-meta is trying to hit | 15:33 |
| mriedem | need to push a change to dump the config on startup before trying to hit the db | 15:35 |
| kashyap | mriedem: Okay, one thing eliminated: that XML bit is a red-herring; it's not the cause. | 15:36 |
| kashyap | (And the patch for consoles is still correct.) | 15:36 |
| *** mrch_ has quit IRC | 15:37 | |
| kashyap | (The seemingly two consoles is due to a silly backward compantbiility thing in libvirt) | 15:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set the conductor indirection API when running nova-metadata under uwsgi https://review.openstack.org/635577 | 15:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Dump config options on wsgi startup earlier https://review.openstack.org/638691 | 15:40 |
| *** _pewp_ has joined #openstack-nova | 15:40 | |
| *** dklyle has quit IRC | 15:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: tox: Don't write byte code (maybe) https://review.openstack.org/636919 | 15:43 |
| *** david-lyle has joined #openstack-nova | 15:43 | |
| kashyap | mriedem: Do you know if these Ubuntu machines are using AppArmour? | 15:47 |
| *** lbragstad is now known as elbragstad | 15:47 | |
| sean-k-mooney | kashyap: its installed by default so proably | 15:48 |
| mriedem | kashyap: that's a question for infra | 15:49 |
| *** jmlowe has quit IRC | 15:49 | |
| kashyap | Okay | 15:51 |
| kashyap | Talking to a libvirt dev, the core problem is QEMU failed to start, and consequently failed to create the socket. | 15:51 |
| kashyap | Now trying to determine why | 15:51 |
| *** markvoelker has joined #openstack-nova | 15:56 | |
| kashyap | sean-k-mooney: Thanks | 15:57 |
| *** jmlowe has joined #openstack-nova | 16:02 | |
| *** belmoreira has quit IRC | 16:08 | |
| giblet | mriedem: regarding your comments in https://review.openstack.org/#/c/569459/67/nova/network/neutronv2/api.py | 16:10 |
| giblet | mriedem: i did not consider live-migration or other server move operation there | 16:11 |
| giblet | mriedem: I think _update_port_binding_for_instance() needs to change when we enable server move operations | 16:11 |
| *** hemna has joined #openstack-nova | 16:11 | |
| giblet | mriedem: the RP uuid fulfilling a port's allocation will definitly change when we move the server to another host | 16:12 |
| kashyap | mriedem: BTW, so this kind of completely silent failure is typically caused due to SELinux/AppArmour denials | 16:18 |
| kashyap | But that's rather difficult to debug in OpenStack envs... | 16:19 |
| *** yan0s has quit IRC | 16:19 | |
| kashyap | I'd be interested if this is reproducible at all -- should get to know it is by Monday | 16:19 |
| *** jaypipes is now known as leakypipes | 16:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Log why rescheduling is disabled https://review.openstack.org/638699 | 16:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove misleading comment from _move_operation_alloc_request() https://review.openstack.org/638700 | 16:21 |
| mriedem | leakypipes: dansmith: some fun from the past ^ | 16:21 |
| *** mrch_ has joined #openstack-nova | 16:25 | |
| sean-k-mooney | kashyap: wouldnt that show up in the audit.log | 16:26 |
| kashyap | sean-k-mooney: No idea what AppArmour does; let me see, though | 16:27 |
| kashyap | I know how to troubleshoot SELinuz | 16:27 |
| sean-k-mooney | both used to show up in demesg then they moved to journalctl but were also loged to the audit.log under /var/log i think | 16:28 |
| *** markvoelker has quit IRC | 16:28 | |
| *** agopi_ is now known as agopi | 16:29 | |
| sean-k-mooney | this is also a kernel bug in ubuntu 18.04 that causes nested virt to not work but if that iss the issue the core dump in dmesg telegraphfs the issue rather quirckly. | 16:31 |
| *** macza has joined #openstack-nova | 16:31 | |
| kashyap | sean-k-mooney: Where is the audit.log here: http://logs.openstack.org/48/631948/9/check/tempest-full-py3/e2ae3fb/controller/logs/ | 16:32 |
| sean-k-mooney | kashyap: this is the ubuntu issue https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773184 | 16:32 |
| openstack | Launchpad bug 1773184 in linux (Ubuntu Bionic) "Starting a KVM guest in a guest (nested VM) crash the kernel" [High,Triaged] | 16:32 |
| * kashyap is blnd | 16:32 | |
| dansmith | bland? | 16:32 |
| dansmith | blonde? | 16:32 |
| kashyap | :D | 16:32 |
| kashyap | Got dansmithed ... s/blnd/blind :D | 16:33 |
| sean-k-mooney | i dont think its copied | 16:33 |
| kashyap | Let me check with Clark | 16:33 |
| giblet | mriedem: replied to your question in https://review.openstack.org/#/c/569459 | 16:34 |
| kashyap | sean-k-mooney: BTW, upstream KVM list has a huge nested virt patch series; so no idea if that fixes | 16:35 |
| kashyap | sean-k-mooney: I've seen that stack trace, though | 16:35 |
| sean-k-mooney | kashyap: i have it https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773184 on one of my servers byt the way so i know that iss an issue with the ubunut cloud images. that said i think its realteded to my bios/microcode | 16:35 |
| openstack | Launchpad bug 1773184 in linux (Ubuntu Bionic) "Starting a KVM guest in a guest (nested VM) crash the kernel" [High,Triaged] | 16:35 |
| sean-k-mooney | kashyap: well for me swaping out the vanial 4.20 kernel in the l1 guest allowed the l2 guest to boot | 16:36 |
| sean-k-mooney | if i use centos on the same host for the l1 guest spanwnign the l2 guest crashes the l1 guest and it reboot | 16:36 |
| kashyap | Okay, my cardinal rule when setting up nested virt for dev envs: ensure L0, L1 (and even L2) kernels to be as similiar (and as newer as they can) | 16:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711 | 16:37 |
| sean-k-mooney | i was useing the same kernel for l0 and l1 originally | 16:37 |
| kashyap | sean-k-mooney: The test combination explosion is one of the difficult things | 16:37 |
| sean-k-mooney | with a cirros image for l2 | 16:38 |
| sean-k-mooney | ya | 16:38 |
| *** imacdonn has quit IRC | 16:38 | |
| dansmith | mriedem: got it | 16:38 |
| *** imacdonn has joined #openstack-nova | 16:38 | |
| sean-k-mooney | i honestly have never had issue with nested vert in the past | 16:38 |
| kashyap | sean-k-mooney: The "past" is a fuzzy word. Precisely for these reasons I used to track all the kernel bugs I filed for nVMX: https://kashyapc.fedorapeople.org/kernel-kvm-bugs.txt | 16:40 |
| kashyap | (They're all fixed, though. And it hasn't been updated in ages) | 16:40 |
| *** gyee has joined #openstack-nova | 16:40 | |
| mriedem | the more i dig into https://bugs.launchpad.net/nova/+bug/1790204 the more it's a spec at this point | 16:45 |
| openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | 16:45 |
| mriedem | i imagine this is all dead code since queens or at least rocky https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L140 | 16:47 |
| sean-k-mooney | kashyap: let me rephsase this is the first time i have ever personally it a nested vert bug in the 5-6 years i have used nested virt by defualt | 16:47 |
| mriedem | because we should never have to double up allocations on the same consumer (instance) during scheduling since we moved the allocations on the source node to the migration record, | 16:47 |
| *** itlinux has joined #openstack-nova | 16:47 | |
| mriedem | except maybe evacuate... | 16:47 |
| kashyap | sean-k-mooney: Ah, okay. :-) | 16:48 |
| melwitt | o/ | 16:49 |
| *** mgariepy has joined #openstack-nova | 16:53 | |
| *** agopi is now known as agopi|lunch|trav | 16:54 | |
| *** agopi|lunch|trav has quit IRC | 16:55 | |
| *** evrardjp is now known as gatersaregonnaga | 16:58 | |
| cdent | fried_rice: my turn to ask you for a reminder: | 16:59 |
| *** gatersaregonnaga is now known as evrardjp | 17:00 | |
| cdent | resource provider A represents a compute node, currently idle | 17:00 |
| cdent | third part system makes allocations against that compute node (consuming capacity in placement but not in _reality_) | 17:00 |
| cdent | the compute node will or will not correct that? | 17:01 |
| cdent | I feel like we've gone back and forth on that a bit and I forget where we are now | 17:01 |
| cdent | I'd just test it, but I currently have no cloud | 17:02 |
| fried_rice | cdent: If the allocation is made against a real instance UUID, I think nova will "heal" it at some point. Otherwise, we don't muck with allocations that aren't related to instances afaik. | 17:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe controller install guides https://review.openstack.org/638715 | 17:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Dedupe compute install guides https://review.openstack.org/638716 | 17:03 |
| * cdent nods at fried_rice | 17:04 | |
| fried_rice | cdent: mriedem might have to weigh in on the circumstances under which healing occurs at all. It may be just at the behest of a nova-manage command. | 17:04 |
| cdent | i've managed to make myself curious enough that I'm going to go spin up the devstack | 17:04 |
| fried_rice | cdent: Now, oob inventory/trait/agg changes against providers owned by the compute node will definitely be "healed" next time upt runs. | 17:05 |
| fried_rice | which actually may not be as soon as we would like - was having this conversation with aspiers the other day. | 17:05 |
| cdent | yeah, to inventory/trait stuff | 17:06 |
| cdent | what's the issue on the "soon"? | 17:07 |
| *** erlon_ has quit IRC | 17:07 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** erlon has joined #openstack-nova | 17:08 | |
| *** imacdonn has quit IRC | 17:08 | |
| mriedem | there is no auto-healing of allocations by nova-compute | 17:09 |
| kashyap | mriedem: I think I found the sucker in my case; spent the last hour-ish duking aroud the system. This looks suspicious: | 17:09 |
| kashyap | --- | 17:09 |
| kashyap | Feb 21 17:14:13 ubuntu-bionic-inap-mtl01-0002851272 kernel: traps: qemu-system-x86[31240] general protection ip:5600cbedaf78 sp:7f2dba1ebf00 error:0 in qemu-system-x86_64[5600cb81c000+8d2000] | 17:09 |
| kashyap | --- | 17:09 |
| mriedem | cdent: fried_rice: coincidentally, read the commit message on https://review.openstack.org/#/c/638700/ for a history lesson | 17:10 |
| aspiers | cdent: IIUC, the sync from provider tree to placement is essentially one way, so if something gets removed from placement then it won't get replaced until the provider cache is reset | 17:10 |
| fried_rice | cdent: It came up when aspiers was fixing the "automatic traits from capabilities" patch https://review.openstack.org/#/c/538498/ | 17:10 |
| fried_rice | because one of the test scenarios needs to be: "user" adds or removes a compute-owned capability trait; compute restores it. | 17:10 |
| fried_rice | But we enabled switching off periodic refresh. So that might never happen. | 17:10 |
| cdent | mriedem: I read that a bit earlier today and the aforementioned lack of brain made all the characters move around | 17:10 |
| aspiers | cdent: https://review.openstack.org/#/c/538498/15/nova/tests/functional/test_servers.py@2294 | 17:11 |
| mriedem | tl;dr while we had computes older than pike, the compute service would overwrite instance allocations created by the scheduler | 17:11 |
| *** helenaAM has quit IRC | 17:11 | |
| cdent | I'm confused by this notion of user removes compute-owned capability trait. I'm guessing that "don't do that" is considered insufficient? | 17:12 |
| fried_rice | cdent: yeah :) | 17:12 |
| mriedem | users most often probably don't know what they should and shouldn't do | 17:12 |
| aspiers | cdent: it's due to this optimisation https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1047 | 17:12 |
| *** tbachman_ has joined #openstack-nova | 17:13 | |
| cdent | i guess I was hoping for "most users probably don't know how to delete a trait" | 17:13 |
| aspiers | cdent: see also https://pasteboard.co/I1Tbzp2.png (which is linked from the commit message) | 17:13 |
| mriedem | cdent: if any code is going to mess with your externally mucked allocation stuff, it's like this https://github.com/openstack/nova/blob/27617ee1931b3240dbd0ad4c7d8ffd64cc202bc9/nova/compute/resource_tracker.py#L1241 | 17:13 |
| mriedem | cdent: which would get you an INFO message https://github.com/openstack/nova/blob/27617ee1931b3240dbd0ad4c7d8ffd64cc202bc9/nova/compute/resource_tracker.py#L1293 | 17:14 |
| cdent | mriedem: yeah, was just looking at that method | 17:14 |
| cdent | aspiers: yeah, that's why I was trying to suggest that the os-traits should grow bigger, faster | 17:14 |
| fried_rice | mriedem: we still haven't solved the resize-to-same-host doubling though, right? | 17:14 |
| *** tbachman has quit IRC | 17:15 | |
| *** tbachman_ is now known as tbachman | 17:15 | |
| aspiers | cdent: makes sense | 17:15 |
| fried_rice | mriedem: which is what your last paragraph is talking about | 17:15 |
| fried_rice | cdent: It doesn't matter if they're in os-traits or not. | 17:16 |
| cdent | they can't be deleted if they are in os-traits | 17:16 |
| cdent | (that was all I was getting at, nothing more) | 17:17 |
| fried_rice | not deleted from placement; deleted from the compute node. | 17:17 |
| aspiers | I think they can be deleted from a resource provider | 17:17 |
| fried_rice | yeah | 17:17 |
| fried_rice | aspiers worded it better, "delete from placement" is too vague. | 17:17 |
| aspiers | just not from global traits list | 17:17 |
| cdent | oh, from the rp, I see | 17:17 |
| cdent | yeah, just don't do that :) | 17:18 |
| aspiers | fried_rice: the ambiguity only just became clear in my head ;-/ | 17:18 |
| aspiers | hence why it's still present in that Venn diagram I just linked | 17:18 |
| cdent | I honestly think that we need to make the system break when people break it | 17:18 |
| cdent | not try to fix it for them | 17:18 |
| aspiers | shit, actually that diagram is wrong isn't it :-/ | 17:18 |
| cdent | we want failures to show as soon as possible | 17:19 |
| cdent | not be in a situation where every 5 minutes system a removes a trait and every 7th minute something puts it back | 17:19 |
| aspiers | yeah I'm totally OK with the "if you do that you get to keep all the broken pieces" approach | 17:19 |
| aspiers | good point | 17:19 |
| mriedem | fried_rice: yes, i look at this bug every couple of weeks and then fall into a pit of depression | 17:20 |
| mriedem | because all solutions out of this bug are bad | 17:20 |
| fried_rice | mriedem: Seems like if you're removing that piece of the comment, you should add a TODO to fix that bit. Assume there's a bug associated with it, yah? | 17:21 |
| mriedem | fried_rice: see the related bug at the bottom of the commit message | 17:21 |
| mriedem | i thought about adding something like, NOTE(mriedem): This actually causes bug 1790204. - but the fix for that bug might not actually involve changing that code | 17:22 |
| openstack | bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] https://launchpad.net/bugs/1790204 | 17:22 |
| mriedem | i can add it if it's helpful though | 17:22 |
| mriedem | also, having said that, i don't think we hit that code on resize anymore | 17:22 |
| mriedem | see, "(10:47:20 AM) mriedem: i imagine this is all dead code since queens or at least rocky https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L140" | 17:23 |
| mriedem | that's only called if the instance consumer has allocations prior to scheduling, which it shouldn't for resize https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1595 | 17:23 |
| mriedem | because we swapped those to the migration record in conductor prior to calling the scheduler | 17:23 |
| mriedem | i think _move_operation_alloc_request only happens during evacuate now | 17:24 |
| mriedem | and you thankfully can't evacuate to the same host :) | 17:24 |
| sean-k-mooney | we will proably get a bug request for that at some point | 17:24 |
| sean-k-mooney | but its true | 17:24 |
| sean-k-mooney | and it should never be possible | 17:25 |
| fried_rice | can we prove it and just remove the code path? | 17:25 |
| mriedem | you can't evacuate to a host that is down | 17:25 |
| mriedem | and you can't evacuate while the service is up | 17:25 |
| mriedem | fried_rice: we can't remove it because of evacuate | 17:25 |
| *** markvoelker has joined #openstack-nova | 17:25 | |
| fried_rice | not the method, just that condition, right? | 17:26 |
| fried_rice | maybe I misunderstood what you said. | 17:26 |
| mriedem | current design ideas on the resize to same host bug is in https://bugs.launchpad.net/nova/+bug/1790204/comments/14 | 17:27 |
| openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | 17:27 |
| fried_rice | I thought you said: you can only hit this method during evacuate, and you can't evacuate to same host, so `elif not new_rp_uuids` should never happen | 17:27 |
| mriedem | which is built on an earlier comment from leakypipes | 17:27 |
| mriedem | oh yeah this https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L172 | 17:27 |
| mriedem | umm, i think that's probably true | 17:27 |
| mriedem | so rather than me remove that comment, just remove the code | 17:28 |
| *** tosky has quit IRC | 17:28 | |
| fried_rice | meaning L169-179 can be reduced to L170-171 | 17:28 |
| fried_rice | but only if we can prove that we only call this method for evacuate. | 17:28 |
| mriedem | i'll fart with it | 17:28 |
| mriedem | any opinions on the brain dump in https://bugs.launchpad.net/nova/+bug/1790204/comments/14 are also appreciated | 17:29 |
| openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | 17:29 |
| mriedem | because there have been several "what if we did this?" talking to myselfs in that bug report by now | 17:29 |
| cdent | a) i'm glad mriedem is looking into this and playing the what if game, b) i'm sad that we have some many what ifs in this part of the code, c) let's rewrite the whole thing! | 17:32 |
| mriedem | if we rewrote the whole thing, we'd just (d) regress some other shit corner case we didn't think about | 17:32 |
| mriedem | the retrospective on this is probably that we are not good about testing at-capacity hosts | 17:33 |
| mriedem | our functoinal tests are always building and migrating to hosts with near infinite capacity | 17:33 |
| cdent | regressions is how we create new contributors :D | 17:33 |
| mriedem | our public cloud ops team is super anal about packing as much as possible, so that's how they noticed this | 17:35 |
| melwitt | any new contributors want to write at-capacity test coverage? :P | 17:36 |
| mriedem | well we have https://review.openstack.org/#/c/619123/ for this bug at least | 17:36 |
| melwitt | (either way, we need it) | 17:36 |
| mriedem | not really sure we have new contributors | 17:37 |
| mriedem | we have old grizzled contributors | 17:37 |
| melwitt | yeah. I was just kidding | 17:37 |
| mriedem | aspiers is new i guess | 17:37 |
| mriedem | full of hope | 17:37 |
| mriedem | (new to nova) | 17:37 |
| melwitt | haha (it's true) | 17:37 |
| temka | So you're saying we should break him by making him convert mox to mock? | 17:37 |
| mriedem | no i never suggested anyone do that | 17:38 |
| mriedem | i actively lobbied against that | 17:38 |
| mriedem | to no avail | 17:38 |
| cdent | too old. too grizzled. to no avail. | 17:38 |
| temka | mriedem, btw, I think we need to put the brakes on https://review.openstack.org/#/c/636210/9 for now - the changed unit tests are failing in the patch above it: http://logs.openstack.org/05/634605/16/check/openstack-tox-lower-constraints/83c2d08/testr_results.html.gz | 17:38 |
| temka | Is my -W enough? | 17:38 |
| mriedem | nope | 17:39 |
| mriedem | you'll have to change the commit message or something to pull it from zuul | 17:39 |
| kashyap | mriedem: Since you politely implied `git blame` on the version bump patch ... :-) I'd want to certinly tell you that the failure was _not_ related to it. | 17:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DERP] Remove _legacy_dict methods https://review.openstack.org/636210 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 17:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 17:41 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 17:41 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 17:41 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Drop MoveClaim in rollback_live_migration_at_destination https://review.openstack.org/638654 | 17:41 |
| *** cdent has quit IRC | 17:41 | |
| mriedem | kashyap: ok ok | 17:41 |
| kashyap | I just spent 2 hours talking to the QEMU guys to carefully go through all the logs. I've got a couple of nice action items for DevStack, though :-) | 17:41 |
| kashyap | I'll write a comment from the investigation. And see if a "trend" shows up on Monday. (1 failure is not a trend :D) | 17:42 |
| *** _fragatina has quit IRC | 17:42 | |
| *** takamatsu_ has joined #openstack-nova | 17:48 | |
| *** takamatsu has quit IRC | 17:48 | |
| *** sridharg has quit IRC | 17:48 | |
| aspiers | haha | 17:51 |
| * temka pesters against non-deterministic dict ordering BS | 17:51 | |
| aspiers | mriedem: I wish I could say I'm young and naive but I'm just ... naive | 17:51 |
| mriedem | kashyap: logstash is also behind so i'm not sure if it's rare or new | 17:51 |
| *** jmlowe has quit IRC | 17:51 | |
| melwitt | dansmith: as one of the primary reviewers on the spec, you might fancy reviewing the patch for ironic conductor groups. has one +2 already https://review.openstack.org/635006 | 17:52 |
| dansmith | guhhhh | 17:52 |
| dansmith | it's friday, don't make me work | 17:52 |
| aspiers | OK it's time for the weekend. Thanks all for your help, catch you next week o/ | 17:52 |
| temka | dansmith, don't be so edgy | 17:52 |
| melwitt | haha | 17:52 |
| * dansmith groans | 17:53 | |
| kashyap | mriedem: Yeah, I saw your comment on indexing; I'm really curious now, after all the time I spent tongiht | 17:53 |
| kashyap | mriedem: Monday I should get to know I suppose, if there's a pattern | 17:53 |
| *** snevi has quit IRC | 17:53 | |
| kashyap | dansmith: You'll like this: https://basecamp.com/books/calm | 17:54 |
| *** sdake has quit IRC | 17:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation' spec https://review.openstack.org/638734 | 17:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove misleading code from _move_operation_alloc_request() https://review.openstack.org/638700 | 17:54 |
| mriedem | fried_rice: ^ | 17:54 |
| mriedem | "It Doesn't Have to Be Crazy at Work (if you work in the EU" | 17:55 |
| *** betherly has joined #openstack-nova | 17:56 | |
| *** sdake has joined #openstack-nova | 17:56 | |
| kashyap | LOL | 17:58 |
| *** markvoelker has quit IRC | 17:59 | |
| kashyap | Well ... it is always "hustle" if you make it a hustle :D | 17:59 |
| kashyap | (That book is written by Americans :D) One of them is a Rails co-founder. They _really_ know what they're talking about. | 17:59 |
| *** betherly has quit IRC | 18:01 | |
| *** igordc has joined #openstack-nova | 18:01 | |
| kashyap | ) The Rails part is to note that it's written by a developer, and not some "tech journalist" | 18:01 |
| kashyap | Anyhow, /me --> dinner and air | 18:01 |
| *** wolverineav has joined #openstack-nova | 18:01 | |
| *** takamatsu_ has quit IRC | 18:03 | |
| *** tssurya has quit IRC | 18:05 | |
| *** mriedem is now known as mriedem_lunch | 18:05 | |
| *** takamatsu_ has joined #openstack-nova | 18:06 | |
| *** dave-mccowan has quit IRC | 18:15 | |
| *** whoami-rajat has quit IRC | 18:27 | |
| *** wolverineav has quit IRC | 18:28 | |
| *** wwriverrat has quit IRC | 18:29 | |
| *** wolverineav has joined #openstack-nova | 18:31 | |
| *** wolverineav has quit IRC | 18:32 | |
| *** wolverineav has joined #openstack-nova | 18:32 | |
| *** _fragatina has joined #openstack-nova | 18:32 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 18:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Drop MoveClaim in rollback_live_migration_at_destination https://review.openstack.org/638654 | 18:33 |
| *** mdbooth_ has joined #openstack-nova | 18:33 | |
| temka | mriedem_lunch, fixed https://review.openstack.org/#/c/636210/11 when you're back | 18:34 |
| temka | Or actually dansmith, you wanna handle it? | 18:34 |
| dansmith | temka: what was the issue? | 18:35 |
| *** betherly has joined #openstack-nova | 18:35 | |
| temka | There's a field called connection_info_json that's a string, but was being printed the way a dict would | 18:36 |
| temka | So I was trying and failing to assert equality between two dicts when they were actually strings | 18:36 |
| temka | Or rather, I was asserting about their containing dicts, and sometimes the JSON would be in the wrong order and compare false | 18:37 |
| *** mdbooth has quit IRC | 18:37 | |
| temka | And I was trying to fix it by treating the JSON like a dict, when I should have just loads and compared that | 18:37 |
| *** macza has quit IRC | 18:38 | |
| dansmith | ah, Is ee | 18:38 |
| sean-k-mooney | i have no other context of this but just looking a dmesg after a kernel update i noticed this | 18:39 |
| sean-k-mooney | "capability: warning: `privsep-helper' uses deprecated v2 capabilities in a way that may be insecure" | 18:39 |
| *** betherly has quit IRC | 18:40 | |
| sean-k-mooney | considering this is an an all in one containerised deployment i have no idea which privsep-help that might be but i have never noticed this before | 18:41 |
| temka | dansmith, cheers! | 18:41 |
| *** _alastor_ has quit IRC | 18:43 | |
| *** agopi has joined #openstack-nova | 18:45 | |
| dansmith | fried_rice: I just -1d this that you had +2d.. not sure if you know the answer to my concern, but: https://review.openstack.org/#/c/635006 | 18:48 |
| *** lpetrut has quit IRC | 18:51 | |
| *** markvoelker has joined #openstack-nova | 18:56 | |
| *** lpetrut has joined #openstack-nova | 19:07 | |
| *** macza has joined #openstack-nova | 19:10 | |
| *** macza has quit IRC | 19:10 | |
| *** macza has joined #openstack-nova | 19:11 | |
| dansmith | jroll: ^ | 19:13 |
| jroll | y u so mean | 19:14 |
| dansmith | man, I've deleted like three non-PC joke responses to that | 19:15 |
| jroll | heh | 19:16 |
| jroll | dansmith: even worse, I agree with you | 19:19 |
| jroll | I'll respin monday morning | 19:19 |
| dansmith | YASS | 19:19 |
| *** Kunpeng has quit IRC | 19:22 | |
| *** mriedem_lunch is now known as mriedem | 19:25 | |
| *** tbachman has quit IRC | 19:25 | |
| mriedem | twizzlers really needs to rethink their packaging because the smashed together brick of licorice that you have to destroy the bag to get 1 rope from is frustrating | 19:25 |
| jroll | you need fresher twizzlers yo | 19:26 |
| mriedem | does not exist | 19:26 |
| mriedem | and by destroying the bag, you guarantee staleness within 48 hours | 19:26 |
| temka | Solution: eat the whole bag. | 19:27 |
| mriedem | in progress | 19:27 |
| dansmith | lol | 19:28 |
| *** markvoelker has quit IRC | 19:28 | |
| *** sdake has quit IRC | 19:31 | |
| *** wwriverrat has joined #openstack-nova | 19:36 | |
| melwitt | lol, it's so timely that you said that. I got the SAME problem earlier this week | 19:39 |
| melwitt | and their "resealable" bag design cannot be opened without destroying the bag | 19:39 |
| sean-k-mooney | its a secret conspiacy to get you to get them allin in one go so you have to buy more | 19:40 |
| melwitt | probably | 19:40 |
| melwitt | I put the tattered bag and brick into a gallon size ziplock freezer bag. nailed it | 19:40 |
| *** _fragatina has quit IRC | 19:41 | |
| *** tesseract has quit IRC | 19:41 | |
| *** itlinux has quit IRC | 19:41 | |
| *** dave-mccowan has joined #openstack-nova | 19:43 | |
| *** tbachman has joined #openstack-nova | 19:48 | |
| *** nicolasbock has joined #openstack-nova | 19:50 | |
| nicolasbock | Hi, I am trying to understand the concept of quotas and limits. I don't quite see how they differ. | 19:50 |
| melwitt | nicolasbock: lots of people use the words interchangeably. but there is quota usage (amount of resources being used) and quota limits (configured limit for the amount of a resource) | 19:56 |
| melwitt | when people say "quotas" they usually mean quota limits | 19:56 |
| nicolasbock | Ah, what I was thinking of are `openstack quota list` and `openstack limits show` | 19:57 |
| melwitt | ah, ok. 'openstack limits show' is probably for showing keystone unified limits (which we are not yet leveraging in nova) | 19:58 |
| melwitt | let me double check | 19:58 |
| *** wolverineav has quit IRC | 19:59 | |
| *** wolverineav has joined #openstack-nova | 19:59 | |
| nicolasbock | Ok | 20:00 |
| nicolasbock | So historically, limits came first and is now being unified under Keystone? | 20:00 |
| melwitt | looks like I'm wrong. I'm looking for what it's calling underneath | 20:00 |
| nicolasbock | Ok | 20:00 |
| melwitt | limits show calls a compute api https://github.com/openstack/python-openstackclient/blob/4bde9af89251431791fc8d69fe09d5e17a8fba8f/openstackclient/common/limits.py#L90 | 20:01 |
| fried_rice | dansmith: ack, looking. | 20:02 |
| melwitt | nicolasbock: which is this one, which is the old school rate-limiting api https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/limits.py#L85 | 20:03 |
| mriedem | dansmith: remind me, is a compute node for vcenter still 1:1 with the compute service host? or 1:M like ironic? | 20:03 |
| mriedem | is the compute node the vcenter cluster, or is a compute node an esxi host in that cluster? | 20:03 |
| melwitt | nicolasbock: hah, it's actually for both. nice https://developer.openstack.org/api-ref/compute/?expanded=show-rate-and-absolute-limits-detail#limits-limits | 20:04 |
| *** wolverineav has quit IRC | 20:04 | |
| nicolasbock | Thanks melwitt | 20:04 |
| melwitt | so that's showing quota limits and the old rate limit part is empty | 20:04 |
| melwitt | now, what does 'openstack quota list' do | 20:04 |
| dansmith | mriedem: yeah I think the compute node is a cluster, which is multiple machines | 20:04 |
| *** wolverineav has joined #openstack-nova | 20:04 | |
| *** erlon has quit IRC | 20:05 | |
| mriedem | but all instances on the same compute service host point at the same compute node... | 20:05 |
| dansmith | mriedem: so it looks 1:1 like libvirt, not 1:N like ironic, but the 1 is actually N | 20:05 |
| mriedem | yeah ok | 20:05 |
| melwitt | nicolasbock: ok, so that one does this https://developer.openstack.org/api-ref/compute/?expanded=show-a-quota-detail#show-a-quota | 20:06 |
| melwitt | nicolasbock: two different APIs that do nearly the same thing. the 'openstack limits show' will show the quota limits and quota usage, the 'openstack quota list' will show the quota limits only | 20:07 |
| nicolasbock | Ok | 20:07 |
| nicolasbock | Thanks! | 20:07 |
| melwitt | np | 20:08 |
| nicolasbock | Now to the next question :) | 20:08 |
| *** lpetrut has quit IRC | 20:08 | |
| melwitt | uh oh | 20:08 |
| nicolasbock | If I understand this correctly, then the usage is not updated by default | 20:08 |
| nicolasbock | For Pike I found `max_age` in the `[Quota]` section | 20:08 |
| nicolasbock | Which defaults to `0` | 20:08 |
| melwitt | ok, that's for the old quota syncing mechanism | 20:09 |
| nicolasbock | I also found https://github.com/openstack/nova/blob/c8926feb2675c754048f8c7398747e3c29bfadaf/releasenotes/notes/remove-quota-options-0e407c56ea993f5a.yaml | 20:09 |
| melwitt | in pike, we changed the way we do quota usage and count resources directly instead of tracking them in a separate table | 20:09 |
| nicolasbock | Which suggests that it's deprecated | 20:09 |
| *** wolverineav has quit IRC | 20:09 | |
| nicolasbock | Ok. Does that mean that I don't have to worry about this setting? | 20:09 |
| melwitt | yes, the use of the separate table (which could get out-of-sync with actual resource consumption) and the syncing related options are deprecated and removed | 20:10 |
| nicolasbock | The usage should be updated automatically? | 20:10 |
| melwitt | right | 20:10 |
| nicolasbock | Ok. Let me rephrase this to make sure I understand this correctly: | 20:10 |
| melwitt | actual resource usage is counted per quota check since pike. going out-of-sync is no longer possible, so quota syncing is no longer possible | 20:10 |
| nicolasbock | I should look only at `openstack limits show` | 20:11 |
| nicolasbock | And it should show me the quota and the usage | 20:11 |
| nicolasbock | And it's automatically kept up to date? | 20:11 |
| nicolasbock | Does that summarize the situation somewhat accurately? | 20:11 |
| melwitt | yes, anything the API is showing was accounted for when things were changed | 20:11 |
| nicolasbock | Cool | 20:12 |
| melwitt | you'll always see "reserved=0" because we no longer do the two-step reserve + commit quota dance | 20:12 |
| nicolasbock | Wow, that's a lot easier than I thought :) | 20:12 |
| melwitt | you can look at either 'openstack limits show' or 'openstack quota list'. limits show seems more useful since it shows the usage too | 20:14 |
| melwitt | I notice that quota list has some limits that are not in limits show, but those are all deprecated by now I think | 20:15 |
| nicolasbock | Yes, that's true | 20:15 |
| nicolasbock | I find that listing a quota without also showing usage less helpful ;) | 20:15 |
| melwitt | but they pull data in the same way, so they should match where they are the same | 20:15 |
| *** s10 has joined #openstack-nova | 20:20 | |
| *** itlinux has joined #openstack-nova | 20:24 | |
| *** markvoelker has joined #openstack-nova | 20:25 | |
| *** tbachman has quit IRC | 20:32 | |
| *** wolverineav has joined #openstack-nova | 20:45 | |
| *** wolverineav has quit IRC | 20:50 | |
| *** itlinux has quit IRC | 20:51 | |
| fried_rice | mriedem: Flushing oldymoldys, are you happy with the reno verbiage etc. on https://review.openstack.org/#/c/564193/ at this point? | 20:51 |
| *** wolverineav has joined #openstack-nova | 20:56 | |
| *** markvoelker has quit IRC | 20:59 | |
| mriedem | ech idk | 21:00 |
| mriedem | they should also update the image properties docs https://docs.openstack.org/glance/latest/admin/useful-image-properties.html | 21:00 |
| mriedem | but that's in glance so a follow up | 21:00 |
| mriedem | i haven't looked at that change in forever though | 21:00 |
| mriedem | if you're happy with it go ahead | 21:01 |
| *** itlinux has joined #openstack-nova | 21:01 | |
| fried_rice | well, I was happy with it before you ripped into it. | 21:01 |
| mriedem | you can be happy once again | 21:01 |
| fried_rice | k | 21:01 |
| mriedem | i'm currently very unhappy with most everything so don't hold for me | 21:01 |
| *** itlinux has quit IRC | 21:02 | |
| fried_rice | done, I suppose anything egregious can be handled in a fup. | 21:02 |
| mriedem | so on this same host resize bug, i started down the path of, from conductor, just trying to PUT allocations for the max of the old/new flavor to see if that can fit the host, | 21:05 |
| mriedem | but then remembered, oh yeah the new flavor can have required/forbidden traits which could filter out the same host | 21:06 |
| mriedem | f me right in the eye | 21:06 |
| mriedem | leakypipes: ^ | 21:06 |
| mriedem | i basically have to do a GET /a_c call from conductor and see if the same host provider is in the results | 21:07 |
| mriedem | and then not swap allocations | 21:08 |
| edleafe | mriedem: that sounds like the same problem Watcher had | 21:08 |
| mriedem | the ol scheduler dry run | 21:08 |
| fried_rice | mriedem: You can use ?in_tree with microversion 1.31 | 21:09 |
| mriedem | that's not a thing in stein right | 21:10 |
| fried_rice | Could be | 21:10 |
| fried_rice | I mean, it's not merged yet, and we agreed not to use it from nova if it does merge. | 21:10 |
| mriedem | this change isn't making stein anyway | 21:11 |
| fried_rice | We could end up resizing to same-host-but-different-providers, couldn't we. | 21:11 |
| *** tosky has joined #openstack-nova | 21:11 | |
| mriedem | sure can | 21:11 |
| mriedem | if there are nested providers in the new flavor then it's all f'ed either way | 21:11 |
| fried_rice | I don't know about f'ed. Just have to be pretty careful about which ones we allow to move and which we don't. | 21:12 |
| fried_rice | Like, I can see moving numa nodes, as long as all the affined resources move together. | 21:12 |
| fried_rice | But I can't see moving FPGAs probably. | 21:12 |
| fried_rice | for now I wouldn't remotely object to "fail if any nested/sharing in play". | 21:12 |
| mriedem | i think i would put a big fat "don't go down this side path if you have complex allocations" condition | 21:12 |
| fried_rice | yeah, that. | 21:13 |
| fried_rice | bbiab | 21:13 |
| *** itlinux has joined #openstack-nova | 21:13 | |
| *** jobewan has quit IRC | 21:20 | |
| *** itlinux has quit IRC | 21:20 | |
| mriedem | this would also bypass anything that has limits to claim in the resource tracker, like numa | 21:21 |
| mriedem | so no numa, no complex allocations | 21:21 |
| *** Sundar has quit IRC | 21:25 | |
| *** wolverineav has quit IRC | 21:26 | |
| melwitt | hm, I wonder why we populate the instance mapping with a cell in build_instances when it is _not_ a reschedule. build_instances method + not a reschedule = cells v1, I thought. so why update instance mapping | 21:27 |
| *** wolverineav has joined #openstack-nova | 21:27 | |
| *** itlinux has joined #openstack-nova | 21:27 | |
| mriedem | we do'nt know the cell in that case until the scheduler tells us the host right? | 21:28 |
| leakypipes | mriedem: don't forget ye old aggregate image properties filter too. :) | 21:28 |
| mriedem | leakypipes: image doesn't change on resize | 21:28 |
| mriedem | thank f | 21:28 |
| leakypipes | ah, yes, was thinking rebuild/evac | 21:28 |
| mriedem | image doesn't change on evac either | 21:29 |
| mriedem | silly pants | 21:29 |
| mriedem | we need a jump to conclusions mat for these operations | 21:29 |
| mriedem | new host? yes/no/maybe | 21:29 |
| mriedem | new flavor? yes/no/maybe | 21:29 |
| mriedem | new image? yes/no/maybe | 21:29 |
| mriedem | aneurysm? definitely. | 21:30 |
| melwitt | there's a note in the code saying that if it's a reschedule, it's already been set to a cell on the first schedule attempt https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L717-L718 | 21:30 |
| *** tbachman has joined #openstack-nova | 21:30 | |
| melwitt | so how can the first schedule attempt in a cells v2 env ever be calling build_instances (and not schedule_and_build_instances) | 21:30 |
| mriedem | melwitt: right, so that if is False | 21:30 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L721 is the first time through for cells v1 | 21:31 |
| mriedem | after picking a host, need to update the instance mapping with the cell of the selectd host | 21:31 |
| mriedem | else you are rescheduling https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L738 | 21:31 |
| melwitt | I see that, but we need to update instance mapping for cells v1? | 21:32 |
| mriedem | what we need to do is delete cells v1 | 21:32 |
| *** betherly has joined #openstack-nova | 21:32 | |
| melwitt | yes we do | 21:32 |
| mriedem | for cells v1 i assume the instance mapping is updated for the same reason as v2 - to know where to pull the instance information on a GET | 21:33 |
| mriedem | because if it's not in the mapping, we'd pull from the top level API DB i geuss which has the synced info | 21:33 |
| melwitt | yeah, because code path is the same? yeah, guh | 21:33 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2449 | 21:33 |
| mriedem | we don't look at the mapping in that case | 21:33 |
| mriedem | so idk | 21:34 |
| melwitt | ok. just going through this realizing I'm not going to have a "populate instance mapping user_id" opportunity during a reschedule, at least not from any already existing instance mapping update | 21:34 |
| mriedem | maybe it's for the v1 -> v2 transition | 21:34 |
| mriedem | why would you need to update the user_id during a reschedule? | 21:34 |
| melwitt | yeah, must be | 21:34 |
| mriedem | we only reschedule (from compute) in 2 cases, server create and resize | 21:34 |
| melwitt | I don't have to, but I had been thinking use all the opportunities for setting user_id if it's not set | 21:35 |
| mriedem | in either of those cases, you could have already updated the instance mapping at the top | 21:35 |
| mriedem | i.e. https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L167 | 21:35 |
| melwitt | yeah, once the new host is picked and saved, that should be where. I guess I missed that mapping update | 21:36 |
| mriedem | the host shouldn't have anything to do with the instance mapping... | 21:36 |
| mriedem | you're just looking for places that InstanceMapping.save() happens yes? | 21:36 |
| mriedem | hell you could do it right here and hit all move operations https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L75 | 21:37 |
| melwitt | oh wait no, during a reschedule we wouldn't update the mapping bc that's just for the cell, not the host. gah I am just confusing myself | 21:37 |
| melwitt | yes | 21:37 |
| *** wolverineav has quit IRC | 21:37 | |
| *** betherly has quit IRC | 21:37 | |
| melwitt | yeah, I was piggy backing on any existing save. there won't be a new save for a reschedule, is what I realized | 21:38 |
| mriedem | nor any move as far as i know, unless you add one to ^ | 21:38 |
| melwitt | which I could just punt on, but that code in build_instances made me wonder what it was for | 21:38 |
| melwitt | yeah | 21:39 |
| *** itlinux has joined #openstack-nova | 21:40 | |
| melwitt | initially I thought, since I saw "populate_instance_mapping" in build_instances, that there was a save() to piggy back. but looking closer, there isn't | 21:40 |
| *** temka has quit IRC | 21:40 | |
| melwitt | not a big deal | 21:40 |
| *** artom has joined #openstack-nova | 21:40 | |
| *** macza has quit IRC | 21:44 | |
| *** macza has joined #openstack-nova | 21:45 | |
| *** ivve has quit IRC | 21:47 | |
| *** dave-mccowan has quit IRC | 21:55 | |
| *** markvoelker has joined #openstack-nova | 21:56 | |
| *** awaugama has quit IRC | 22:02 | |
| melwitt | I wonder if I could use request specs to populate user_id instead of looking in cells at all? hmmm | 22:21 |
| *** _fragatina has joined #openstack-nova | 22:21 | |
| *** mchlumsky has quit IRC | 22:21 | |
| sean-k-mooney | melwitt: https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L65-L66 | 22:22 |
| sean-k-mooney | the user and project ides are stored in it | 22:22 |
| melwitt | yeah, I was noticing that in compute_api.get() | 22:23 |
| melwitt | I'm a bit wary if there's any way it couldn't be relied on though. being that request specs are only removed at archive_deleted_rows time, I wonder if it's possible that old, unarchived things could have a null user_id | 22:24 |
| melwitt | maybe best not to chance it | 22:24 |
| sean-k-mooney | i honest taught the scduler depending on this to look up the users limets | 22:25 |
| melwitt | it looks at build requests, in addition to instances | 22:26 |
| melwitt | which are ephemeral (only live until scheduling completes) | 22:26 |
| melwitt | request specs are not looked at for any quota limit checking | 22:27 |
| sean-k-mooney | hum ok | 22:28 |
| sean-k-mooney | are you concured that the user may be delete and we some how have a non archived instance belonving to that user and try to look it up and get an error | 22:29 |
| sean-k-mooney | or are you concured that the request spec will have a null user id | 22:29 |
| *** markvoelker has quit IRC | 22:30 | |
| melwitt | null user_id, or worse, no user_id field. I didn't look at the history of when that field was added | 22:30 |
| melwitt | I guess "no user_id field" isn't a thing, it would be null in that case | 22:30 |
| sean-k-mooney | melwitt: https://github.com/openstack/nova/commit/6e49019fae80586c4bbb8a7281600cf6140c176a | 22:31 |
| *** mchlumsky has joined #openstack-nova | 22:31 | |
| melwitt | request spec has a wild west reputation, so I'm just not sure if I could rely on its user_id field. being that I didn't dig into it yet | 22:31 |
| melwitt | ah, wow. relatively new | 22:32 |
| sean-k-mooney | well its been there since queens? | 22:32 |
| melwitt | and no data migration, so would be null for already existing request specs when that code landed | 22:32 |
| melwitt | yeah, I just expected it would be older than that | 22:33 |
| melwitt | ok, nevermind my request spec flighty idea | 22:33 |
| sean-k-mooney | well looking at the change it look like there are check in the conductor that depend on both the user id and porject id being set | 22:34 |
| mriedem | fried_rice: well, i got something working for the functional regression test at least | 22:34 |
| melwitt | hah, ok | 22:35 |
| mriedem | of course it's rife with TODOs and FIXMEs | 22:35 |
| fried_rice | neat. | 22:35 |
| sean-k-mooney | i wasnt following hte context of what you were working on but it look like it will alway be none none | 22:35 |
| sean-k-mooney | melwitt: you could also get the user_id out of the instance if you have that https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L122-L123 | 22:36 |
| *** sdake has joined #openstack-nova | 22:37 | |
| *** tbachman has quit IRC | 22:37 | |
| melwitt | sean-k-mooney: I'm adding user_id to InstanceMapping and need a reliable way to populate it (data migration of already existing records). and instance was the assumed way. and it occurred to me (from looking at the down cell stuff) that, request spec has user_id too, could I use that? the answer I now know is, no | 22:40 |
| *** tbachman has joined #openstack-nova | 22:40 | |
| melwitt | I already wrote everything to use instance user_id, so this means no change for me | 22:40 |
| sean-k-mooney | ah ok | 22:40 |
| *** mchlumsky has quit IRC | 22:43 | |
| sean-k-mooney | melwitt: you could be checky and look at the allocation for the instacne and get the user id out of the consumers table in the api db | 22:44 |
| sean-k-mooney | the consumer and allocation should have been there since pike | 22:44 |
| sean-k-mooney | melwitt: :) oh look like you added the consumer table in pike https://github.com/openstack/nova/commit/b9eed6a2862d0d72c77706b49d05ea588d2d81f3 | 22:51 |
| melwitt | yeah, I dunno | 23:04 |
| melwitt | that might not work bc I need to migrate soft-deleted instances (the soft-delete API) too, since they could restored theoretically at any point in the future. and I don't think those would have allocations, as they are supposed to be gone from the user perspective and not consuming resources | 23:06 |
| openstackgerrit | Merged openstack/nova stable/pike: Not set instance to ERROR if set_admin_password failed https://review.openstack.org/608180 | 23:07 |
| melwitt | besides that, it seems most reliable to use instances. we had bugs in the past with orphaned allocations in placement and deployments out there might still have some | 23:07 |
| openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1806064 https://review.openstack.org/623935 | 23:07 |
| openstack | bug 1806064 in OpenStack Compute (nova) pike "Volume remains in attaching/reserved status, if the instance is deleted after TooManyInstances exception in nova-conductor" [Medium,In progress] https://launchpad.net/bugs/1806064 - Assigned to Matt Riedemann (mriedem) | 23:07 |
| sean-k-mooney | ya i guess you have to blance the risks. if the cell is donw then using ht user form the instance will fail | 23:07 |
| sean-k-mooney | melwitt: ya the instace is proably the safest whcih is why i said using the consumer recored associated with the instance allocation was a little cheaky | 23:08 |
| melwitt | oh, cheaky? you spelled it "checky" earlier and I didn't get it :) | 23:09 |
| sean-k-mooney | oh ha ya | 23:09 |
| sean-k-mooney | well it shoudl be cheeky if i use the irish/uk spelling | 23:10 |
| sean-k-mooney | anyway i better go. have a good weekend o/ | 23:10 |
| melwitt | have a good weekend o/ | 23:11 |
| openstackgerrit | Merged openstack/nova stable/pike: Create BDMs/tags in cell with instance when over-quota https://review.openstack.org/623937 | 23:21 |
| mriedem | hmm, why do we persist RequestSpec.ignore_hosts | 23:22 |
| mriedem | dansmith: ^ seems dangerous yeah? | 23:22 |
| mriedem | just like why we don't persist retry and requested_destination | 23:22 |
| *** slaweq has quit IRC | 23:23 | |
| mriedem | i.e. resize with allow_resize_to_same_host=false sets ignore_hosts=[instance.host], we save that, then resize again with allow_resize_to_same_host=False will always filter out the same host | 23:23 |
| mriedem | er allow_resize_to_same_host=True the 2nd run | 23:24 |
| mriedem | i know request spec is the thing everyone wants to think about at 3:30 on a friday | 23:24 |
| sean-k-mooney | do we clear it on resize confirm/revert | 23:24 |
| sean-k-mooney | i dont recal if we can retry a resize but perhapse that is why | 23:24 |
| sean-k-mooney | that is just a guess | 23:25 |
| mriedem | well, on the 2nd resize we would overwrite RequestSpec.ignore_hosts again | 23:25 |
| mriedem | looks like the only other move operation that really looks at it is evacuate, and you can't evacuate to the same host anyway so .. | 23:26 |
| mriedem | evacuate ignores instance.host as well | 23:26 |
| mriedem | so i guess this is why it's not a problem | 23:26 |
| *** markvoelker has joined #openstack-nova | 23:27 | |
| mriedem | live migrate also uses it while retrying different hosts in conductor, but doesn't persist those changes (until someone comes along and adds code to the live migration task that saves the request spec for some reason) | 23:27 |
| sean-k-mooney | well it doesnt sound like there is an obvious reason to save it to the db so maybe put up a patch to and see what breaks but form the sounds of it might not be needed and might be a source of a future bug | 23:29 |
| mriedem | no time right now, but yeah i'm sure it would be a future bug, i.e. https://review.openstack.org/#/c/636271/ | 23:30 |
| mriedem | these per-operation fields on request spec keep biting us in our collective asses | 23:30 |
| *** itlinux has quit IRC | 23:35 | |
| *** wolverineav has joined #openstack-nova | 23:38 | |
| *** wolverineav has quit IRC | 23:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Workaround resize to same host doubling allocations bug https://review.openstack.org/638791 | 23:43 |
| mriedem | leakypipes: fried_rice: ^ damn near killed me | 23:44 |
| mriedem | fugly as hell | 23:44 |
| openstackgerrit | sean mooney proposed openstack/nova master: [DNM] stop storing request_spec.ignore_hosts in the db. https://review.openstack.org/638792 | 23:45 |
| sean-k-mooney | i belive ^ is syantaticlly corret python. beyond that its just a reminder | 23:46 |
| sean-k-mooney | but we can see if any of the ci job fall over becase of it | 23:46 |
| sean-k-mooney | ok im actully leaving this time o/ | 23:47 |
| *** mriedem has quit IRC | 23:52 | |
| *** tbachman_ has joined #openstack-nova | 23:52 | |
| *** tbachman has quit IRC | 23:53 | |
| *** tbachman_ is now known as tbachman | 23:53 | |
| *** itlinux has joined #openstack-nova | 23:57 | |
| *** markvoelker has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
