| *** wolverineav has joined #openstack-nova | 00:21 | |
| *** markvoelker has joined #openstack-nova | 00:21 | |
| *** brinzhang has joined #openstack-nova | 00:42 | |
| *** markvoelker has quit IRC | 00:54 | |
| *** ileixe has joined #openstack-nova | 00:55 | |
| *** ileixe has quit IRC | 01:03 | |
| *** yikun has joined #openstack-nova | 01:06 | |
| *** wolverineav has quit IRC | 01:13 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix InstanceMapping to always default queued_for_delete=False https://review.openstack.org/635534 | 01:14 |
|---|---|---|
| *** vishwanathj has quit IRC | 01:22 | |
| *** sapd1 has joined #openstack-nova | 01:38 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Don't change volume status to `in-use` when attach to shelved vm. https://review.openstack.org/627096 | 01:51 |
| *** markvoelker has joined #openstack-nova | 01:51 | |
| *** dave-mccowan has joined #openstack-nova | 01:56 | |
| *** dave-mccowan has quit IRC | 02:00 | |
| *** fried_rice has quit IRC | 02:05 | |
| *** wolverineav has joined #openstack-nova | 02:13 | |
| *** wolverineav has quit IRC | 02:15 | |
| *** wolverineav has joined #openstack-nova | 02:15 | |
| *** markvoelker has quit IRC | 02:24 | |
| *** fried_rice has joined #openstack-nova | 02:42 | |
| *** wolverineav has quit IRC | 02:43 | |
| *** wolverineav has joined #openstack-nova | 02:46 | |
| *** fried_rice has quit IRC | 02:52 | |
| *** fried_rice has joined #openstack-nova | 02:55 | |
| *** wolverineav has quit IRC | 02:58 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| *** sdake has quit IRC | 03:08 | |
| *** yonglihe-holiday is now known as yonglihe | 03:10 | |
| *** sdake has joined #openstack-nova | 03:11 | |
| *** markvoelker has joined #openstack-nova | 03:22 | |
| *** fried_rice has quit IRC | 03:50 | |
| *** markvoelker has quit IRC | 03:54 | |
| *** udesale has joined #openstack-nova | 04:02 | |
| *** wolverineav has joined #openstack-nova | 04:05 | |
| *** wolverineav has quit IRC | 04:10 | |
| *** hongbin has joined #openstack-nova | 04:25 | |
| *** janki has joined #openstack-nova | 04:25 | |
| *** sridharg has joined #openstack-nova | 04:29 | |
| *** markvoelker has joined #openstack-nova | 04:51 | |
| *** hongbin has quit IRC | 04:53 | |
| *** cfriesen has joined #openstack-nova | 05:09 | |
| *** markvoelker has quit IRC | 05:24 | |
| *** ratailor has joined #openstack-nova | 05:52 | |
| *** markvoelker has joined #openstack-nova | 06:22 | |
| *** hoonetorg has joined #openstack-nova | 06:22 | |
| *** moshele has joined #openstack-nova | 06:29 | |
| *** markvoelker has quit IRC | 06:55 | |
| *** Luzi has joined #openstack-nova | 06:55 | |
| *** toabctl has joined #openstack-nova | 07:26 | |
| *** jangutter has joined #openstack-nova | 07:33 | |
| *** psachin has quit IRC | 07:45 | |
| *** slaweq has joined #openstack-nova | 07:49 | |
| *** ociuhandu_ has quit IRC | 07:49 | |
| *** markvoelker has joined #openstack-nova | 07:52 | |
| *** ociuhandu has joined #openstack-nova | 07:54 | |
| *** ociuhandu has quit IRC | 07:58 | |
| *** awalende has joined #openstack-nova | 07:59 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893 | 07:59 |
| *** wolverineav has joined #openstack-nova | 08:01 | |
| *** awalende_ has joined #openstack-nova | 08:02 | |
| *** awalende has quit IRC | 08:03 | |
| *** ccamacho has joined #openstack-nova | 08:06 | |
| *** rpittau has joined #openstack-nova | 08:07 | |
| *** tesseract has joined #openstack-nova | 08:08 | |
| *** ralonsoh has joined #openstack-nova | 08:12 | |
| *** lee1 has joined #openstack-nova | 08:13 | |
| *** awalende_ has quit IRC | 08:16 | |
| *** helenafm has joined #openstack-nova | 08:17 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:22 | |
| *** awalende has joined #openstack-nova | 08:22 | |
| *** jaosorior has joined #openstack-nova | 08:23 | |
| *** markvoelker has quit IRC | 08:24 | |
| *** xek has joined #openstack-nova | 08:30 | |
| *** tssurya has joined #openstack-nova | 08:31 | |
| *** wolverineav has quit IRC | 08:34 | |
| *** wolverineav has joined #openstack-nova | 08:35 | |
| *** finucannot is now known as stephenfin | 08:51 | |
| *** awalende has quit IRC | 08:54 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893 | 08:54 |
| *** bnemec-pto has quit IRC | 08:57 | |
| *** bnemec has joined #openstack-nova | 08:59 | |
| openstackgerrit | yenai proposed openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/632657 | 09:02 |
| *** awalende has joined #openstack-nova | 09:07 | |
| *** wolverineav has quit IRC | 09:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump API microversion to support rebuild bfv instances https://review.openstack.org/627518 | 09:16 |
| *** cdent has joined #openstack-nova | 09:20 | |
| *** markvoelker has joined #openstack-nova | 09:21 | |
| *** derekh has joined #openstack-nova | 09:35 | |
| *** wolverineav has joined #openstack-nova | 09:41 | |
| *** dtantsur|afk is now known as dtantsur | 09:48 | |
| *** markvoelker has quit IRC | 09:54 | |
| *** cfriesen has quit IRC | 10:04 | |
| *** moshele has quit IRC | 10:06 | |
| *** NewBruce has joined #openstack-nova | 10:06 | |
| *** wolverineav has quit IRC | 10:14 | |
| *** NewBruce has quit IRC | 10:17 | |
| *** NewBruce has joined #openstack-nova | 10:19 | |
| *** whoami-rajat has joined #openstack-nova | 10:20 | |
| *** yan0s has joined #openstack-nova | 10:23 | |
| *** ociuhandu has joined #openstack-nova | 10:24 | |
| *** lee1 is now known as lyarwood | 10:51 | |
| *** markvoelker has joined #openstack-nova | 10:52 | |
| *** NewBruce has quit IRC | 10:54 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fixtures: Return a mocked class instead of method within fake_imagebackend https://review.openstack.org/619804 | 10:56 |
| *** moshele has joined #openstack-nova | 10:56 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/628726 | 10:57 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Don't emit warning when ironic properties are zero https://review.openstack.org/608573 | 10:57 |
| *** NewBruce has joined #openstack-nova | 10:59 | |
| *** NewBruce has quit IRC | 11:01 | |
| *** NewBruce has joined #openstack-nova | 11:02 | |
| *** wolverineav has joined #openstack-nova | 11:11 | |
| *** erlon has joined #openstack-nova | 11:14 | |
| *** brinzhang has quit IRC | 11:21 | |
| *** NewBruce has quit IRC | 11:21 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject migration requests when source is down https://review.openstack.org/623489 | 11:23 |
| *** markvoelker has quit IRC | 11:25 | |
| *** sapd1 has quit IRC | 11:37 | |
| *** helenafm has quit IRC | 11:40 | |
| *** wolverineav has quit IRC | 11:44 | |
| *** mdbooth has joined #openstack-nova | 11:46 | |
| *** NewBruce has joined #openstack-nova | 11:50 | |
| *** helenafm has joined #openstack-nova | 11:57 | |
| *** NewBruce_ has joined #openstack-nova | 12:03 | |
| *** NewBruce has quit IRC | 12:04 | |
| *** NewBruce_ is now known as NewBruce | 12:04 | |
| *** udesale has quit IRC | 12:05 | |
| *** udesale has joined #openstack-nova | 12:06 | |
| *** dave-mccowan has joined #openstack-nova | 12:13 | |
| *** markvoelker has joined #openstack-nova | 12:21 | |
| *** fried_rice has joined #openstack-nova | 12:33 | |
| *** whoami-rajat has quit IRC | 12:40 | |
| *** wolverineav has joined #openstack-nova | 12:42 | |
| cdent | I seem to remember this being talked about before: is there a way to weigh the "busy-ness" of an AZ or aggregate? Is the cpuweigher a vague proxy for that? | 12:49 |
| *** ratailor has quit IRC | 12:49 | |
| *** janki has quit IRC | 12:50 | |
| *** jchhatbar has joined #openstack-nova | 12:50 | |
| *** bauwser is now known as bauzas | 12:54 | |
| *** markvoelker has quit IRC | 12:54 | |
| *** yan0s has quit IRC | 12:57 | |
| *** yan0s has joined #openstack-nova | 12:57 | |
| *** derekh has quit IRC | 12:58 | |
| *** Luzi has quit IRC | 13:02 | |
| *** Luzi has joined #openstack-nova | 13:08 | |
| gibi | bauzas: hi! could you help me pushing through two qeens/pike backports? | 13:10 |
| gibi | bauzas: https://review.openstack.org/#/c/623355/1 and https://review.openstack.org/#/c/635897/1, | 13:10 |
| cdent | welcome back gibi ! | 13:11 |
| gibi | cdent: thanks :) | 13:11 |
| *** wolverineav has quit IRC | 13:14 | |
| *** yan0s has quit IRC | 13:21 | |
| *** gbarros has joined #openstack-nova | 13:29 | |
| bauzas | gibi: hola | 13:30 |
| bauzas | gibi: sure, lemme look | 13:30 |
| *** moshele has quit IRC | 13:30 | |
| gibi | bauzas: thanks a lot | 13:30 |
| bauzas | gibi: FWIW, I'm also thinking about your comments like https://review.openstack.org/#/c/599208/12/nova/virt/libvirt/driver.py@6718 | 13:31 |
| gibi | bauzas: so if the TODO means that the operator today can change the config that nova does not handle then I think we have a problem | 13:33 |
| *** sapd1 has joined #openstack-nova | 13:34 | |
| bauzas | gibi: yeah but the problem is that we don't know yet if we need to create a new child RP | 13:34 |
| *** yan0s has joined #openstack-nova | 13:34 | |
| bauzas | we only know about the root RP | 13:35 |
| bauzas | and we don't persist the existing type | 13:35 |
| bauzas | oh and FWIW, it doesn't work also atm | 13:35 |
| gibi | bauzas: so, what will happen if the admin changes the enabled_vgpu_types ? | 13:37 |
| *** mriedem has joined #openstack-nova | 13:43 | |
| bauzas | gibi: for the moment, we create an inventory by calling the number of left mdevs | 13:43 |
| bauzas | gibi: if the operator changes the type, the total would be modified | 13:43 |
| gibi | bauzas: so eventually the gpu inventory will be in sync with the reality? | 13:44 |
| bauzas | if we have allocations, I guess placement verifies that the new total is more than the allocations value | 13:44 |
| bauzas | gibi: every 60 secs, ye | 13:44 |
| gibi | bauzas: so with type X the hypervisor reports 10 available mdev, then a server is created that use up 1 of that 10. Then the operator changes the config to type Y and restart the compute | 13:45 |
| gibi | bauzas: from type Y the hypervisor report 5 mdevs available | 13:45 |
| bauzas | right | 13:46 |
| gibi | bauzas: so the compute changes the inventory from 10 to 5 which still fits, as only 1 allocated | 13:46 |
| bauzas | yup | 13:46 |
| *** edmondsw has quit IRC | 13:46 | |
| bauzas | that said, I have an open question | 13:46 |
| bauzas | what if we have 6 allocs for a type with 10 total | 13:46 |
| bauzas | and then operator uses type Y which only has 5 as a total | 13:47 |
| gibi | I think placement will not allow changing the total to 5 then | 13:47 |
| bauzas | ok, then we're good | 13:47 |
| gibi | but easxy to try | 13:47 |
| bauzas | actually wait | 13:47 |
| bauzas | if you have one pGPU | 13:47 |
| bauzas | with multiple types | 13:47 |
| bauzas | when you first create a mdev, then all of the other types but the one used by the mdev are having total = 0 | 13:48 |
| *** edleafe has quit IRC | 13:48 | |
| bauzas | so, if the operator wants to change a type for the same pGPU when there are instances, then it's litterally not possible to get more instances | 13:48 |
| bauzas | because the total will be the number of existing mdevs | 13:49 |
| *** derekh has joined #openstack-nova | 13:49 | |
| bauzas | unless the operators changes it back to the original type | 13:49 |
| bauzas | so we don't have a problem atm | 13:49 |
| gibi | bauzas: so the operator needs to delete / migrate away the instances first | 13:49 |
| gibi | then change the tyee | 13:49 |
| bauzas | yeah, or change the type back to the original | 13:49 |
| gibi | type | 13:49 |
| gibi | bauzas: OK, that makes it even stricter | 13:49 |
| gibi | bauzas: and here strict is good, I think | 13:50 |
| bauzas | no, he can change without needing to delete | 13:50 |
| gibi | bauzas: yeah, if he want to change back then he can without delete | 13:50 |
| bauzas | that's just only if he really wants to change from one type to the other | 13:50 |
| gibi | bauzas: yeas | 13:50 |
| bauzas | yeah | 13:50 |
| gibi | cool | 13:50 |
| gibi | maybe we want to document this behavior somehow for the deployer | 13:50 |
| bauzas | now, with the change, lemme think | 13:50 |
| gibi | to avoud surprise | 13:50 |
| bauzas | gibi: we did it already | 13:51 |
| *** mgariepy has joined #openstack-nova | 13:51 | |
| gibi | bauzas: then I rest my case | 13:51 |
| gibi | :) | 13:51 |
| bauzas | oh wait, no actually | 13:51 |
| bauzas | https://docs.openstack.org/nova/latest/admin/virtual-gpu.html | 13:51 |
| bauzas | I could add a note in https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#enable-gpu-types-compute | 13:52 |
| *** NewBruce has quit IRC | 13:52 | |
| *** markvoelker has joined #openstack-nova | 13:52 | |
| *** takashin has joined #openstack-nova | 13:52 | |
| *** dklyle has quit IRC | 13:52 | |
| gibi | bauzas: making that note solves my comment in your patch | 13:52 |
| bauzas | gibi: that said, I need to think on how it works with nested RPs | 13:53 |
| bauzas | for the moment, it does work because allocations are made against the same RP | 13:53 |
| bauzas | oh wait | 13:53 |
| bauzas | even if people change types, they won't change the pGPU | 13:54 |
| bauzas | so allocations will still be made against the right pGPUI | 13:54 |
| bauzas | actually, something is missing :( | 13:54 |
| bauzas | holy shit | 13:54 |
| bauzas | we have an allocation against one pGPU | 13:54 |
| fried_rice | n-sch meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
| bauzas | but then libvirt creates the mdev (or uses some mdev) from any pGPU | 13:55 |
| *** fried_rice is now known as efried | 13:55 | |
| bauzas | which is a problem | 13:55 |
| bauzas | for correctly counting allocations | 13:55 |
| bauzas | shit shit shit | 13:55 |
| bauzas | gibi: thanks for making me think of it | 13:55 |
| *** NewBruce has joined #openstack-nova | 13:56 | |
| *** tetsuro has joined #openstack-nova | 13:56 | |
| gibi | bauzas: you are welcome :) | 13:59 |
| *** edleafe has joined #openstack-nova | 13:59 | |
| *** sridharg has quit IRC | 14:07 | |
| *** wolverineav has joined #openstack-nova | 14:11 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Add VIFPortProfileSmartNIC profile https://review.openstack.org/636061 | 14:12 |
| *** cfriesen has joined #openstack-nova | 14:16 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support server power state update through external event https://review.openstack.org/636132 | 14:21 |
| *** markvoelker has quit IRC | 14:24 | |
| *** edmondsw has joined #openstack-nova | 14:27 | |
| *** liuyulong has joined #openstack-nova | 14:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix deps for api-samples tox env https://review.openstack.org/633620 | 14:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make VolumeAttachmentsSampleV249 test other methods https://review.openstack.org/633621 | 14:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | 14:28 |
| *** lbragstad has joined #openstack-nova | 14:31 | |
| *** takashin has left #openstack-nova | 14:33 | |
| *** gbarros has quit IRC | 14:39 | |
| bauzas | mriedem: FWIW, gibi made me think of a problem with the reshape series | 14:39 |
| bauzas | mriedem: that's uncommented yet, but I'll need to respin | 14:39 |
| mriedem | you've yet to respin anyway right? | 14:41 |
| mriedem | so respin your local respin | 14:42 |
| * mriedem is getting dizzy | 14:42 | |
| *** agopi has joined #openstack-nova | 14:42 | |
| mriedem | bauzas: gibi: are you able to summarize the issue? | 14:43 |
| mriedem | so i don't have to read scrollback? | 14:43 |
| *** tetsuro has quit IRC | 14:43 | |
| bauzas | mriedem: tl;dr: | 14:43 |
| bauzas | we will have inventories per pGPU | 14:43 |
| bauzas | placement will choose one child RP and make an allocation to it | 14:43 |
| bauzas | then it goes down to the driver | 14:44 |
| bauzas | which picks randomly at the moment | 14:44 |
| bauzas | the last sentence has to change | 14:44 |
| bauzas | the driver has to pick one of the available mdevs from the pGPU related to the allocation | 14:44 |
| mriedem | driver.spawn() gets the allocations, so we just have to reconcile the local inventory in the driver to what was allocated and pick that mdev yeah? | 14:45 |
| bauzas | or allocations would diverge from actual usage | 14:45 |
| *** wolverineav has quit IRC | 14:45 | |
| bauzas | mriedem: yup that | 14:45 |
| bauzas | mriedem: we need to lookup the child RP from the allocation and find an allocable mdev from it | 14:45 |
| bauzas | not a big deal, but still has to be done | 14:45 |
| *** NewBruce has quit IRC | 14:46 | |
| openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | 14:46 |
| mriedem | does that need to be done separately from the reshaper patch, like as a dependency - even though it won't do anything until the reshape is done? | 14:46 |
| *** awaugama has joined #openstack-nova | 14:46 | |
| mriedem | because that reshaper patch is already big | 14:46 |
| bauzas | yeah I was considering this | 14:46 |
| mriedem | i'd split them if possible | 14:46 |
| bauzas | we could drop a -2 | 14:46 |
| mriedem | 1. handled nested in spawn, 2. do reshapes | 14:46 |
| bauzas | and only +W once all are accepted | 14:46 |
| bauzas | or yeah, that | 14:46 |
| bauzas | whatever | 14:46 |
| mriedem | to remind me, the child RP is a pGPU on the compute node right? | 14:47 |
| mriedem | and len(mdevs) is total VGPU inventory per pGPU child provider | 14:48 |
| openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 14:48 |
| sean-k-mooney | ignore ^ im just testing something | 14:48 |
| *** jchhatbar has quit IRC | 14:49 | |
| * gibi now learned what was the real bug bauzas found while discussing a different comment in the reshaper series | 14:51 | |
| *** moshele has joined #openstack-nova | 14:52 | |
| bauzas | mriedem: correct, with the slight detail that total = len(mdevs) + pGPU.'available_instances' (which changes over the time) | 14:52 |
| bauzas | that's why we need to count mdevs for the inventory | 14:52 |
| bauzas | as "available instances" is a value that has a very different meaning | 14:52 |
| openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 14:54 |
| sean-k-mooney | still ignore ^ needed to fix merge confict to get gate jobs to run. | 14:54 |
| mriedem | gibi: do you want to re-approve https://review.openstack.org/#/c/634767/ since it was rebased? | 14:56 |
| gibi | mriedem: done | 14:57 |
| mriedem | thanks | 14:57 |
| *** awalende has quit IRC | 14:58 | |
| *** awalende has joined #openstack-nova | 14:59 | |
| *** hongbin has joined #openstack-nova | 15:01 | |
| *** awalende has quit IRC | 15:03 | |
| *** mlavalle has joined #openstack-nova | 15:05 | |
| *** hoonetorg has quit IRC | 15:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/632657 | 15:13 |
| *** TxGirlGeek has joined #openstack-nova | 15:13 | |
| *** mdbooth_ has joined #openstack-nova | 15:20 | |
| *** mdbooth has quit IRC | 15:20 | |
| *** jding1_ has quit IRC | 15:21 | |
| *** gbarros has joined #openstack-nova | 15:21 | |
| *** markvoelker has joined #openstack-nova | 15:22 | |
| *** jackding has joined #openstack-nova | 15:22 | |
| *** Luzi has quit IRC | 15:22 | |
| jackding | mdbooth_: Could you please revisit https://review.openstack.org/#/c/616692/ since your last -1? It | 15:24 |
| *** hoonetorg has joined #openstack-nova | 15:27 | |
| gibi | hey cores, can somebody push in https://review.openstack.org/#/c/633776/ it is a follow up and mriedem already +2 on it | 15:32 |
| *** TxGirlGeek has quit IRC | 15:33 | |
| *** agopi has quit IRC | 15:39 | |
| *** wolverineav has joined #openstack-nova | 15:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race in test_volume_swap_server_with_error https://review.openstack.org/634334 | 15:42 |
| sean-k-mooney | gibi: ya that makes sense. it conflict with a tone of patches so it would be good to merge sooner rather then later | 15:43 |
| gibi | sean-k-mooney: exactly | 15:44 |
| *** tbachman has joined #openstack-nova | 15:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | 15:55 |
| *** markvoelker has quit IRC | 15:56 | |
| *** dklyle has joined #openstack-nova | 15:58 | |
| *** sapd1 has quit IRC | 16:01 | |
| *** wwriverrat has joined #openstack-nova | 16:04 | |
| sean-k-mooney | stephenfin: before you hit the sriov migration seires want to quickly look at gibi's patch https://review.openstack.org/634334. its a faily small change | 16:04 |
| *** tbachman has quit IRC | 16:05 | |
| stephenfin | ack | 16:05 |
| gibi | stephenfin: thanks | 16:05 |
| *** macza has joined #openstack-nova | 16:08 | |
| *** macza has quit IRC | 16:08 | |
| stephenfin | sean-k-mooney: Right link? That's mriedem's change you linked | 16:08 |
| stephenfin | wait - I see what you were referring to | 16:09 |
| *** macza has joined #openstack-nova | 16:09 | |
| *** moshele has quit IRC | 16:10 | |
| *** _fragatina has joined #openstack-nova | 16:12 | |
| *** wolverineav has quit IRC | 16:14 | |
| *** udesale has quit IRC | 16:15 | |
| *** TxGirlGeek has joined #openstack-nova | 16:16 | |
| efried | Is there an etherpad for the PTG yet? | 16:16 |
| efried | mriedem, melwitt, cdent, other people who might know. ^ | 16:17 |
| sean-k-mooney | efried: not that im aware of | 16:17 |
| mriedem | https://etherpad.openstack.org/p/nova-ptg-train | 16:18 |
| mriedem | nope | 16:18 |
| efried | ight, thx | 16:18 |
| sean-k-mooney | efried: well i guess you might as well start one with ^ | 16:18 |
| sean-k-mooney | we normally use the location in the name but give this is the third denver ptg swapping to the release name is likely better | 16:19 |
| sean-k-mooney | efried: by the way you will be waiting a while for intel to appove. its always late. | 16:21 |
| efried | :) | 16:22 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 16:35 |
| *** awaugama has quit IRC | 16:36 | |
| *** yan0s has quit IRC | 16:37 | |
| *** tbachman has joined #openstack-nova | 16:37 | |
| *** ircuser-1 has joined #openstack-nova | 16:38 | |
| *** helenafm has quit IRC | 16:51 | |
| mriedem | the location in etherpad name thing is a forum thing, not really the ptg, https://etherpad.openstack.org/p/nova-ptg-queens https://etherpad.openstack.org/p/nova-ptg-rocky https://etherpad.openstack.org/p/nova-ptg-stein | 16:52 |
| *** markvoelker has joined #openstack-nova | 16:52 | |
| * mriedem really enjoyed someone translating the queens etherpad | 16:52 | |
| *** moshele has joined #openstack-nova | 16:54 | |
| dansmith | mriedem: thoughts on my comment here? https://review.openstack.org/#/c/635146/8/nova/api/openstack/compute/views/servers.py | 16:57 |
| *** awaugama has joined #openstack-nova | 16:57 | |
| mriedem | dansmith: commented | 17:03 |
| mriedem | i don't feel the need for the guard i guess | 17:06 |
| sean-k-mooney | mriedem: ya you can get the original version from the timeline but it is annoying | 17:10 |
| mriedem | ? | 17:11 |
| sean-k-mooney | mriedem: the non translated queens etherpad | 17:11 |
| mriedem | i personally don't need the location in the etherpad name since i don't care where it was, i care when it was | 17:11 |
| mriedem | oh yeah - that was annoying | 17:11 |
| *** wolverineav has joined #openstack-nova | 17:12 | |
| sean-k-mooney | it confused the hell out of me in the nova room at the following ptg i spent 20 trying to figure out what was up with my brower just to realise i was looking at the wronge page | 17:12 |
| *** sdake has quit IRC | 17:12 | |
| sean-k-mooney | *20 mins | 17:13 |
| *** moshele has quit IRC | 17:14 | |
| mriedem | pebkac | 17:15 |
| *** sdake has joined #openstack-nova | 17:15 | |
| openstackgerrit | Merged openstack/nova stable/rocky: PCI: do not force remove allocated devices https://review.openstack.org/635071 | 17:17 |
| *** wolverineav has quit IRC | 17:19 | |
| *** gyee has joined #openstack-nova | 17:24 | |
| *** markvoelker has quit IRC | 17:24 | |
| *** _fragatina has quit IRC | 17:31 | |
| *** _fragatina has joined #openstack-nova | 17:31 | |
| *** tssurya has quit IRC | 17:39 | |
| *** panda is now known as panda|off | 17:41 | |
| *** macza has quit IRC | 17:42 | |
| *** macza_ has joined #openstack-nova | 17:42 | |
| *** xek has quit IRC | 17:42 | |
| *** rpittau has quit IRC | 17:44 | |
| *** rpittau has joined #openstack-nova | 17:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 17:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 17:53 |
| mriedem | stephenfin: i have a couple of comments in your novaclient change, was on the fence about -1ing https://review.openstack.org/#/c/635131/ | 17:55 |
| stephenfin | ack | 17:55 |
| *** derekh has quit IRC | 17:58 | |
| dansmith | mriedem: okay, it just seems like we're linking two sentinels somewhat via tribal knowledge and that we're setting this up for breakage later, but it's not a huge deal to me | 17:59 |
| *** sdake has quit IRC | 18:01 | |
| mriedem | sean-k-mooney: i've got some questions in https://review.openstack.org/#/c/624842/ which sound like they mirror things leakypipes was asking about before | 18:03 |
| *** sdake has joined #openstack-nova | 18:03 | |
| sean-k-mooney | looking | 18:03 |
| mriedem | leakypipes must be stuck in friday limbo | 18:04 |
| *** leakypipes is now known as jaypipes | 18:06 | |
| *** dtantsur is now known as dtantsur|afk | 18:07 | |
| mriedem | dansmith: yeah it's definitely tight coupling but i'm not terribly worried about it right now. i wonder if setting an attribute on the instance (not persisted) would help, but idk | 18:07 |
| dansmith | ack | 18:07 |
| *** moshele has joined #openstack-nova | 18:07 | |
| mriedem | instance.from_down_cell = True or something | 18:07 |
| mriedem | but then you have to check if that attribute is set on the object as well | 18:07 |
| mriedem | or we default to False i guess | 18:08 |
| *** mriedem is now known as mriedem_lunch | 18:09 | |
| kukacz | hi, I'm getting "MigrationPreCheckError: ... CPU doesn't have compatibility." while trying to live-migrate between hosts with same model of CPU. Turned out that by mistake I got newer package with /usr/share/libvirt/cpu_map.xml differing between those 2 hosts. downgraded libvirt-bin, restarted libvirt-bin and nova-compute services but still seeing same precheck error. where does the precheck take the cpu model from? | 18:10 |
| kukacz | (had newer package on one of the two hosts) | 18:11 |
| *** rpittau has quit IRC | 18:12 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.68: Remove 'forced' live migrations, evacuations https://review.openstack.org/635131 | 18:13 |
| sean-k-mooney | mriedem_lunch: replied inline https://review.openstack.org/#/c/624842/8//COMMIT_MSG | 18:14 |
| stephenfin | mriedem_lunch: When you're back ^ | 18:14 |
| * stephenfin goes home | 18:14 | |
| *** markvoelker has joined #openstack-nova | 18:21 | |
| *** ralonsoh has quit IRC | 18:22 | |
| *** imacdonn has joined #openstack-nova | 18:24 | |
| *** ociuhandu_ has joined #openstack-nova | 18:25 | |
| *** moshele has quit IRC | 18:25 | |
| *** sdake has quit IRC | 18:27 | |
| *** ociuhandu has quit IRC | 18:28 | |
| *** ociuhandu_ has quit IRC | 18:30 | |
| *** sdake has joined #openstack-nova | 18:30 | |
| artom | Who's our PowerVM guy? cfriesen? | 18:31 |
| *** sdake has quit IRC | 18:32 | |
| artom | I guess efried used to "it" | 18:32 |
| artom | There's a unit test issue with to_legacy_dict() in the PowerVMLiveMigrateData... but as far as I can tell nothing actually calls to_legacy_dict anywhere | 18:36 |
| artom | So I'm wondering if I can just get rid of it | 18:36 |
| *** ociuhandu has joined #openstack-nova | 18:37 | |
| *** wolverineav has joined #openstack-nova | 18:38 | |
| *** gbarros has quit IRC | 18:39 | |
| *** liuyulong has quit IRC | 18:39 | |
| artom | In fact, the only place I can find *any* _legacy_dict methods is in the migrate_data.py objects and a couple of times in the libvirt migration code where we check if we got an ovo | 18:40 |
| cfriesen | artom: I'm x86. :) used to be we called to_legacy_dict() from check_can_live_migrate_source() | 18:40 |
| artom | I feel like that's left over from a long time ago and I can remove all of that | 18:40 |
| *** whoami-rajat has joined #openstack-nova | 18:40 | |
| melwitt | edmondsw ^ | 18:41 |
| artom | cfriesen, ah, sorry got confused about your arch allegiance ;) | 18:41 |
| *** ociuhandu has quit IRC | 18:41 | |
| artom | You know what, I'll propose a thing that gets rid of it all, and we'll see what breaks :) | 18:41 |
| edmondsw | artom in a mtg but will look in a few | 18:41 |
| artom | edmondsw, cheers! I really need to relocate, but leave your reply here and I'll check eavesdrop | 18:43 |
| *** ociuhandu has joined #openstack-nova | 18:43 | |
| *** artom has quit IRC | 18:48 | |
| *** wolverineav has quit IRC | 18:50 | |
| *** xek has joined #openstack-nova | 18:51 | |
| *** openstackgerrit has quit IRC | 18:51 | |
| mriedem_lunch | artom: i think that was dropped when we bumped the compute rpc api version to 5.0 | 18:52 |
| *** mriedem_lunch is now known as mriedem | 18:52 | |
| mriedem | https://github.com/openstack/nova/blob/stable/queens/nova/compute/rpcapi.py#L535 | 18:52 |
| *** efried has quit IRC | 18:53 | |
| *** wolverineav has joined #openstack-nova | 18:53 | |
| *** markvoelker has quit IRC | 18:55 | |
| *** efried has joined #openstack-nova | 18:56 | |
| *** sdake has joined #openstack-nova | 18:56 | |
| *** gbarros has joined #openstack-nova | 18:57 | |
| *** artom has joined #openstack-nova | 19:03 | |
| *** xek_ has joined #openstack-nova | 19:04 | |
| *** hongbin has quit IRC | 19:05 | |
| *** xek has quit IRC | 19:06 | |
| *** hongbin has joined #openstack-nova | 19:08 | |
| *** NewBruce has joined #openstack-nova | 19:08 | |
| *** sdake has quit IRC | 19:09 | |
| *** mvkr has quit IRC | 19:10 | |
| *** jmlowe has joined #openstack-nova | 19:14 | |
| *** efried has quit IRC | 19:15 | |
| *** efried1 has joined #openstack-nova | 19:15 | |
| *** efried1 is now known as efried | 19:17 | |
| *** moshele has joined #openstack-nova | 19:18 | |
| *** efried has quit IRC | 19:22 | |
| *** gbarros has quit IRC | 19:22 | |
| *** artom has quit IRC | 19:23 | |
| *** READ10 has joined #openstack-nova | 19:26 | |
| *** gbarros has joined #openstack-nova | 19:31 | |
| *** openstackgerrit has joined #openstack-nova | 19:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move finish_resize.(start|end) notifications to helper method https://review.openstack.org/635079 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 19:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 19:32 |
| *** wolverineav has quit IRC | 19:33 | |
| *** wolverineav has joined #openstack-nova | 19:34 | |
| *** gbarros has quit IRC | 19:34 | |
| *** wolverineav has quit IRC | 19:34 | |
| *** wolverineav has joined #openstack-nova | 19:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up (#2) for the bw resource provider series https://review.openstack.org/634767 | 19:35 |
| *** wolverineav has quit IRC | 19:40 | |
| *** ociuhandu has quit IRC | 19:40 | |
| *** wolverineav has joined #openstack-nova | 19:41 | |
| *** cdent has quit IRC | 19:41 | |
| *** wolverineav has quit IRC | 19:41 | |
| *** wolverineav has joined #openstack-nova | 19:41 | |
| *** efried has joined #openstack-nova | 19:42 | |
| *** tbachman has quit IRC | 19:43 | |
| *** moshele has quit IRC | 19:50 | |
| *** gbarros has joined #openstack-nova | 19:51 | |
| *** gyee has quit IRC | 19:52 | |
| *** markvoelker has joined #openstack-nova | 19:52 | |
| *** NewBruce has quit IRC | 19:55 | |
| *** wolverineav has quit IRC | 19:58 | |
| *** gyee has joined #openstack-nova | 20:00 | |
| *** artom has joined #openstack-nova | 20:01 | |
| *** artom has quit IRC | 20:01 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.openstack.org/635669 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: generate new NUMA XML on the dest and send it to the source https://review.openstack.org/634828 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 20:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | 20:02 |
| *** artom has joined #openstack-nova | 20:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 20:03 |
| artom | mriedem, ^^ The bottom-most patch there is remove the _to_dict stuff | 20:03 |
| artom | (I assume the bot just spammed the channel with my patches, I wasn't actually connected, and eavesdrop isn't showing anything (yet?)) | 20:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide a useful error message when trying to update non-compute services https://review.openstack.org/620667 | 20:04 |
| *** erlon has quit IRC | 20:05 | |
| *** jmlowe has quit IRC | 20:08 | |
| artom | Wait, so what's the point of default=None in Nova objects if the field doesn't actually get set to None when you init the object without it? | 20:12 |
| artom | Is default just for "actual" values? | 20:12 |
| dansmith | artom: it's the default for if you ask the object to set its defaults | 20:15 |
| dansmith | remember, an object can represent something that is a fraction of the total, | 20:15 |
| artom | dansmith, ah, so not a fallback kind of thing | 20:15 |
| dansmith | like instance if you don't ask for all the stuff to be filled out | 20:15 |
| artom | Fair enough. | 20:15 |
| dansmith | if we took the defaults everywhere, we'd overwrite things in the DB with the defaults because someone didn't query for them and then called .save() to update one little field | 20:16 |
| artom | I still have the omnipresent 'if field in obj and obj.field is not None' construct ;) | 20:16 |
| artom | It makes sense when you explain it that way :) | 20:16 |
| artom | s/still have/still hate/ | 20:17 |
| artom | Or obj_attr_is_set | 20:17 |
| artom | But yeah, I see why we need both "unset" and "None", and having automatic None defaults would clobber the former with the latter | 20:18 |
| artom | And they don't mean the same thing | 20:18 |
| *** markvoelker has quit IRC | 20:24 | |
| *** NewBruce has joined #openstack-nova | 20:27 | |
| sean-k-mooney | artom: i think you can use in or hasattr with ovo too because the baseclass overlods __contains__ | 20:27 |
| sean-k-mooney | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L321 | 20:27 |
| sean-k-mooney | so "if x in my_obj:" will work to test if the field is set | 20:28 |
| artom | sean-k-mooney, yep. I'd hoped to avoid all that by setting a None default, but that won't be possible | 20:29 |
| artom | sean-k-mooney, BTW, going to back to yesterday's discussion on https://review.openstack.org/#/c/634828/9/nova/virt/libvirt/driver.py@6808 | 20:29 |
| artom | When you say "cell in enumerate(instance_numa_toplogy.cells)" | 20:29 |
| artom | That means the guest cells are *ordered* inside i_n_t, and their order represents the guest cell ID? | 20:30 |
| artom | I mean, I know it's a list, and lists are ordered | 20:30 |
| artom | I just didn't think we encoded anything in that order | 20:30 |
| sean-k-mooney | artom: yes i belive so | 20:30 |
| artom | Because the cell.id field is the *host* cell ID, right? | 20:30 |
| sean-k-mooney | ya | 20:30 |
| *** READ10 has quit IRC | 20:31 | |
| artom | OK | 20:31 |
| artom | Hrmpf, yeah, maybe stick with building the LibvirtConfigObjects on the dest? | 20:31 |
| artom | It seems safer :P | 20:31 |
| artom | As a first whack at it, anyays | 20:31 |
| sean-k-mooney | i think we can for now. | 20:31 |
| sean-k-mooney | we really should not have too | 20:31 |
| *** tbachman has joined #openstack-nova | 20:31 | |
| *** wolverineav has joined #openstack-nova | 20:32 | |
| sean-k-mooney | but its is simpler | 20:32 |
| artom | Yeah, I thought the same when I first tried it in Rocky | 20:32 |
| artom | And then went to code the XML update stuff on the source | 20:32 |
| artom | And realized i_n_t isn't enough | 20:32 |
| sean-k-mooney | the problem is the xml generation is mix with the buisness logic | 20:33 |
| sean-k-mooney | they should have been kept seperate but they werent | 20:33 |
| artom | I don't disagree :S | 20:33 |
| artom | A lot of things should have been ;) | 20:33 |
| sean-k-mooney | so for now i think keeping the changes minimal are fro the best adn maybe we should just decuple it fully latter | 20:33 |
| sean-k-mooney | and by later i mean as a sperate activiy in train | 20:34 |
| artom | We'd need a quorum of virt drivers that can support NUMA LM | 20:35 |
| sean-k-mooney | i also hate that that file is like 9000 lines long | 20:35 |
| sean-k-mooney | not really | 20:35 |
| artom | To better understand what we need to encode in the objects/business logic | 20:35 |
| artom | No? I mean, I have no idea what HyperV wants | 20:36 |
| artom | I think it would help me if I had claudiub explain it to me :) | 20:36 |
| artom | (If he's still around) | 20:36 |
| sean-k-mooney | hyperv support numa but does not to cpu pinning the same way | 20:36 |
| *** wolverineav has quit IRC | 20:36 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use tox 3.1.1 fixes https://review.openstack.org/582392 | 20:36 |
| sean-k-mooney | its done in the hyperviors rather then in the nova dirive i think | 20:37 |
| *** wolverineav has joined #openstack-nova | 20:37 | |
| sean-k-mooney | the issue with the libvirt dirver is that neither libvirt or qemu are hyperviors | 20:37 |
| artom | Ah, kvm is the hypervisor | 20:38 |
| sean-k-mooney | qemu is a emulator and libvirt is just an abstraction layer/api. but are totaly dumb and just do what you tell them so nova had to build most of the logic that would normally live in a hypvervisor | 20:38 |
| *** gouthamr has quit IRC | 20:38 | |
| sean-k-mooney | artom: kvm is not a hypervior either | 20:38 |
| artom | sean-k-mooney, heh, OK, define hypervisor then :) | 20:39 |
| sean-k-mooney | its an aclleration driver/kernel module | 20:39 |
| artom | ... allowing the kernel to act as the hypervisor (according to wiki, at any rate_ | 20:40 |
| *** wolverineav has quit IRC | 20:40 | |
| *** wolverineav has joined #openstack-nova | 20:40 | |
| artom | No point in getting bogged down in semantics, I un-WIPed a couple of the patches, working on a third... | 20:40 |
| sean-k-mooney | a hypervior is a set of services that mediates acess to hardware such that multiple kernel can share the hardware | 20:41 |
| *** mriedem has quit IRC | 20:41 | |
| sean-k-mooney | :) true | 20:41 |
| edmondsw | artom you're asking about getting rid of to_legacy_dict just for powervm or in general? I don't see it called for any hypervisor | 20:42 |
| artom | edmondsw, yeah, I thought it as just powervm, but it looked to be pretty generalized | 20:42 |
| artom | Ie, all drivers had _legacy_dict stuff in migrate_data.py | 20:42 |
| edmondsw | yep... and all could go away at this point, right? | 20:42 |
| artom | And I'm proposing to remove all of them: https://review.openstack.org/#/c/636210/ | 20:42 |
| edmondsw | sounds good | 20:43 |
| sean-k-mooney | artom: well as the name suggest its likely a legacy fuction that was kept for handeling mixed compute node versions | 20:43 |
| *** mriedem has joined #openstack-nova | 20:44 | |
| artom | Changing stuff in nova is like a plastic surgeon operating on Joan Rivers's face: you have no idea who else has touched stuff before, so really all you hope for is to do the minimal amount of damage while keeping Joan alive. | 20:44 |
| artom | (RIP Joan) | 20:44 |
| artom | sean-k-mooney, so to answer your point, I'm not touch anything, named "legacy" or not, unless I'm damn sure it can be removed. | 20:45 |
| *** NewBruce has quit IRC | 20:45 | |
| sean-k-mooney | artom: well at least for the base class it was added by dansmith in https://github.com/openstack/nova/commit/038dfd672f5b2be5ebe30d85bd00d09bae2993fc | 20:47 |
| artom | Heh, yeah, saw that. And it occurs nowhere else that I could see. | 20:47 |
| artom | So I figured we're OK to get rid of them all. | 20:47 |
| *** NewBruce has joined #openstack-nova | 20:48 | |
| sean-k-mooney | artom: so based on the conversation with dan earliar are you going to revert the change to https://review.openstack.org/#/c/634827/10/nova/objects/migrate_data.py and ath the if x in y... check | 20:51 |
| sean-k-mooney | e.g. revert the defults | 20:51 |
| artom | sean-k-mooney, yeah | 20:51 |
| artom | And add a proper check | 20:51 |
| openstackgerrit | Merged openstack/nova master: Fup for the bandwidth resource provider series https://review.openstack.org/633776 | 20:51 |
| sean-k-mooney | cool am im going to go to sleep earlish tonight i think. ill redeploy the series in my test vms tomorow. | 20:53 |
| sean-k-mooney | i think it more or less should work at this point as the last version i tested seamed pretty close | 20:54 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 20:55 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 20:55 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 20:55 |
| artom | sean-k-mooney, noice. There ^^ | 20:55 |
| artom | I did the change, will continue adding unit tests where I can without too much trouble, and then I'll start on the automated testing | 20:55 |
| sean-k-mooney | oh cool i am going work on some os-vif stuff for another 30 mins or so. i shold have time to spin up a devstack install and manually live migrate a test vm in the background | 20:57 |
| *** wolverineav has quit IRC | 21:09 | |
| *** artom has quit IRC | 21:11 | |
| *** wolverineav has joined #openstack-nova | 21:11 | |
| *** wolverineav has quit IRC | 21:13 | |
| *** wolverineav has joined #openstack-nova | 21:13 | |
| *** xek_ has quit IRC | 21:21 | |
| *** markvoelker has joined #openstack-nova | 21:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 21:22 |
| *** itlinux has joined #openstack-nova | 21:22 | |
| *** tesseract has quit IRC | 21:25 | |
| *** itlinux has quit IRC | 21:35 | |
| *** wolverineav has quit IRC | 21:38 | |
| *** gouthamr has joined #openstack-nova | 21:39 | |
| *** wolverineav has joined #openstack-nova | 21:40 | |
| *** ociuhandu has joined #openstack-nova | 21:40 | |
| *** ociuhandu has quit IRC | 21:44 | |
| *** wolverineav has quit IRC | 21:45 | |
| *** wolverineav has joined #openstack-nova | 21:49 | |
| *** awaugama has quit IRC | 21:50 | |
| openstackgerrit | Merged openstack/nova stable/queens: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/635897 | 21:53 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1794996 https://review.openstack.org/623354 | 21:53 |
| openstack | bug 1794996 in OpenStack Compute (nova) queens "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem) | 21:53 |
| *** markvoelker has quit IRC | 21:55 | |
| *** NewBruce has quit IRC | 22:07 | |
| *** artom has joined #openstack-nova | 22:11 | |
| mriedem | oh blarg, our NeutronFixture is not a KSA client fixture... | 22:13 |
| *** sdake has joined #openstack-nova | 22:20 | |
| *** markvoelker has joined #openstack-nova | 22:20 | |
| *** slaweq has quit IRC | 22:26 | |
| *** wolverineav has quit IRC | 22:27 | |
| *** wolverineav has joined #openstack-nova | 22:28 | |
| *** wolverineav has quit IRC | 22:31 | |
| *** wolverineav has joined #openstack-nova | 22:31 | |
| *** whoami-rajat has quit IRC | 22:33 | |
| *** sdake has quit IRC | 22:51 | |
| *** sdake has joined #openstack-nova | 22:55 | |
| *** tkajinam has joined #openstack-nova | 22:57 | |
| *** wolverineav has quit IRC | 22:58 | |
| *** sdake has quit IRC | 22:59 | |
| *** wolverineav has joined #openstack-nova | 22:59 | |
| *** wolverineav has quit IRC | 23:01 | |
| *** wolverineav has joined #openstack-nova | 23:01 | |
| mriedem | efried: hmm, i'm hoping this isn't a regression http://paste.openstack.org/show/744898/ | 23:03 |
| mriedem | this is on rollback of a failed resize where conductor reverts the allocation move by trying to swap the allocations back from the migration consumer to the instance consumer | 23:03 |
| mriedem | the GET /allocations/$consumer_id in the code is using placement 1.28 | 23:03 |
| mriedem | which should have project_id in the response | 23:03 |
| mriedem | i wonder if maybe allocations is {} ? | 23:04 |
| efried | That seems possible. | 23:05 |
| efried | reproducible? Stuff in some debug logs? | 23:05 |
| mriedem | OH I KNOW | 23:06 |
| *** sdake has joined #openstack-nova | 23:07 | |
| mriedem | so this is the conductor MigrationTask trying to swap the allocs, but the compute service in this case already reverted them | 23:07 |
| mriedem | so conductor is trying to move something that doesn't exist b/c it's already been moved | 23:07 |
| mriedem | not a regression, just not robust code | 23:07 |
| *** mvkr has joined #openstack-nova | 23:08 | |
| efried | seems like we've seen this before | 23:08 |
| efried | thought we had a fix up that would ignore empty source allocations | 23:09 |
| mriedem | this is a pretty specific part of nova so i'm guessing it's just not been an issue before, | 23:10 |
| mriedem | especially because with normal resize, conductor rpc casts to compute and if something fails in compute, it reverts the allocations and conductor doesn't get a chance (b/c of the cast) | 23:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use placement.inventory.inuse in report client https://review.openstack.org/568639 | 23:11 |
| mriedem | with cross-cell resize it's synchronous | 23:11 |
| mriedem | so compute reverts and then conductor tries to revert as well | 23:11 |
| efried | mriedem: here's the change I was thinking of. Slightly different but similar race https://review.openstack.org/#/c/617040/ | 23:17 |
| *** mlavalle has quit IRC | 23:18 | |
| mriedem | yeah this isn't a race that i'm dealing with now, just new code paths that aren't robustified yet | 23:18 |
| mriedem | laying my old cross-cell resize functional tests on top of my current series and flushing out some bugs | 23:18 |
| *** rchurch_ has joined #openstack-nova | 23:21 | |
| *** macza_ has quit IRC | 23:22 | |
| *** rchurch has quit IRC | 23:23 | |
| *** macza has joined #openstack-nova | 23:26 | |
| *** sdake has quit IRC | 23:31 | |
| *** moshele has joined #openstack-nova | 23:38 | |
| *** jistr_ has joined #openstack-nova | 23:39 | |
| *** dtantsur has joined #openstack-nova | 23:39 | |
| *** BlackDex_ has joined #openstack-nova | 23:42 | |
| *** stephenfin_ has joined #openstack-nova | 23:45 | |
| *** hongbin has quit IRC | 23:45 | |
| *** hemna_ has joined #openstack-nova | 23:45 | |
| *** jmlowe has joined #openstack-nova | 23:46 | |
| *** dtantsur|afk has quit IRC | 23:46 | |
| *** BlackDex has quit IRC | 23:46 | |
| *** jistr has quit IRC | 23:46 | |
| *** icey has quit IRC | 23:46 | |
| *** zioproto has quit IRC | 23:46 | |
| *** mrhillsman has quit IRC | 23:46 | |
| *** rha has quit IRC | 23:46 | |
| *** mnasiadka has quit IRC | 23:46 | |
| *** hemna has quit IRC | 23:46 | |
| *** TheJulia has quit IRC | 23:46 | |
| *** fyx has quit IRC | 23:46 | |
| *** stephenfin has quit IRC | 23:46 | |
| *** coreycb has quit IRC | 23:46 | |
| *** purplerbot has quit IRC | 23:48 | |
| *** moshele has quit IRC | 23:50 | |
| *** macza has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!