| *** tetsuro has joined #openstack-nova | 00:03 | |
| *** whoami-rajat has quit IRC | 00:08 | |
| *** macza has quit IRC | 00:09 | |
| *** tetsuro has quit IRC | 00:16 | |
| *** tetsuro_ has joined #openstack-nova | 00:16 | |
| artom | What takes precedence again? Flavor extra specs or image props? | 00:28 |
|---|---|---|
| sean-k-mooney | that depends we generally now raise an exception if there is a conflict but original flavor took prescedence over image properties | 00:30 |
| sean-k-mooney | im not sure we we have converted all conficts into exections currently but stephenfin did that for several of them | 00:31 |
| artom | How are you still working o_O! | 00:31 |
| artom | I'm happy you're here though :D | 00:31 |
| artom | I'm asking because mem_page_size is in both | 00:32 |
| sean-k-mooney | hehe i often take a few hours away around 7 my time and come back online for an hour or two around 10 ish | 00:32 |
| sean-k-mooney | ya | 00:33 |
| sean-k-mooney | so for mempage size if the flavor has set a spefici page size and the image does not agree its an error | 00:33 |
| sean-k-mooney | if the flavoer was hw:mem_page_size=large or hw:mem_page_size=any and the image had hw_mem_page_size=1G that should be allow but i dont know if we support it or not | 00:34 |
| *** tosky has quit IRC | 00:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 00:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 00:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 00:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 00:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move finish_resize.(start|end) notifications to helper method https://review.openstack.org/635079 | 00:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 00:34 |
| artom | sean-k-mooney, so based on unit tests it looks like mem_page_size in image is outright forbidden... | 00:35 |
| mriedem | artom: i've always though image overrides flavor since the user can sometimes upload their own images | 00:35 |
| mriedem | stephenfin might think otherwise as well since i think he's written something up about this brfeore | 00:35 |
| mriedem | *before | 00:35 |
| sean-k-mooney | well the user should not be able to overide the admin but if ther is no conflict then its fine | 00:36 |
| artom | mriedem, hrmm, doesn't look like that's universally true | 00:36 |
| artom | sean-k-mooney, mriedem, https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/tests/unit/virt/test_hardware.py#L2253-L2264 | 00:36 |
| artom | To me that reads as we bail if there's a page size in image props | 00:36 |
| sean-k-mooney | artom: https://github.com/openstack/glance/blob/master/etc/metadefs/compute-guest-memory-backing.json | 00:36 |
| sean-k-mooney | artom no in test_get_requested_mempages_pagesize_from_image_forbidden | 00:37 |
| sean-k-mooney | the flavor is hw:mem_page_size=small so not hugepages but the image asks for 2m hugepages so that is not allowed because teh admin said no | 00:38 |
| sean-k-mooney | test_get_requested_mempages_pagesize_from_image_forbidden2 fails befause for the image to be allow to ask for hugepages teh flaovr must have hw:mem_page_size=large or any | 00:39 |
| artom | Ah, so https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1120 exists | 00:39 |
| sean-k-mooney | artom: basically you can only aske for a specific page size via the image if the admin said it was ok in the flavor | 00:39 |
| sean-k-mooney | at least that was the intent | 00:39 |
| sean-k-mooney | artom https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1169-L1170 | 00:40 |
| *** mlavalle has quit IRC | 00:41 | |
| sean-k-mooney | artom: the idea wa that if the admin wanted to supprot hugepage guest they would only ever set hw:mem_page_size=large. and if the tenant cared about the size of the hugepage they would then say so in the image | 00:42 |
| artom | sean-k-mooney, aha, that makes sense | 00:42 |
| *** mriedem has quit IRC | 00:43 | |
| *** wolverineav has quit IRC | 00:43 | |
| artom | Concretely, in our live migration claim case, it looks like we'll have to override both with the actual pagesize on the source host | 00:44 |
| artom | Somehow | 00:44 |
| *** wolverineav has joined #openstack-nova | 00:45 | |
| sean-k-mooney | artom: the instance_numa_topology object has the pagesize | 00:46 |
| sean-k-mooney | https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/objects/instance_numa_topology.py#L51 | 00:46 |
| *** wolverineav has quit IRC | 00:46 | |
| sean-k-mooney | so when you are claiming the memory for the instance jsut pull it out of that | 00:46 |
| *** wolverineav has joined #openstack-nova | 00:46 | |
| artom | sean-k-mooney, yeah, that wasn't what I was bugging on | 00:46 |
| *** macza has joined #openstack-nova | 00:47 | |
| artom | So actually, because https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/virt/hardware.py#L1168-L1170, if we set a numerical pagesize in the flavor, it'll override anything in the image | 00:47 |
| artom | OK, I'm good | 00:47 |
| sean-k-mooney | artom: yes but we should not mess with the flavor | 00:47 |
| sean-k-mooney | or the image | 00:47 |
| sean-k-mooney | just keep it as a seperate value | 00:48 |
| artom | sean-k-mooney, not on the original, but if we deepcopy it we can do whatever we want :) | 00:48 |
| artom | I know it's ugly, but I'd rather not dive into the claims code to make it understand a separate pagesize | 00:48 |
| sean-k-mooney | its a nova object wich is a ovo so you all have to reset the fields to make shour it does not get persited back into the db in some cases | 00:48 |
| *** lbragsta_ has joined #openstack-nova | 00:50 | |
| sean-k-mooney | artom: well throw up a poc and then we can see what it looks like | 00:50 |
| artom | sean-k-mooney, yep | 00:50 |
| *** lbragsta_ is now known as lbragstad__ | 00:52 | |
| *** _alastor_ has quit IRC | 00:54 | |
| *** Swami has quit IRC | 00:57 | |
| *** wolverineav has quit IRC | 01:03 | |
| *** wolverineav has joined #openstack-nova | 01:04 | |
| *** hamzy has joined #openstack-nova | 01:06 | |
| *** wolverineav has quit IRC | 01:08 | |
| *** tetsuro_ has quit IRC | 01:08 | |
| *** tetsuro has joined #openstack-nova | 01:09 | |
| *** tbachman has quit IRC | 01:18 | |
| *** tbachman has joined #openstack-nova | 01:20 | |
| *** wolverineav has joined #openstack-nova | 01:24 | |
| *** takashin has joined #openstack-nova | 01:24 | |
| *** tbachman_ has joined #openstack-nova | 01:33 | |
| *** tetsuro has quit IRC | 01:33 | |
| *** tbachman has quit IRC | 01:34 | |
| *** tbachman_ is now known as tbachman | 01:34 | |
| sean-k-mooney | night all o/ | 01:39 |
| *** dims has quit IRC | 01:40 | |
| *** _alastor_ has joined #openstack-nova | 01:42 | |
| *** _alastor_ has quit IRC | 01:47 | |
| *** agopi|off has quit IRC | 01:57 | |
| *** wolverineav has quit IRC | 02:06 | |
| *** wolverineav has joined #openstack-nova | 02:07 | |
| *** TxGirlGeek has quit IRC | 02:08 | |
| *** dims has joined #openstack-nova | 02:11 | |
| *** wolverineav has quit IRC | 02:11 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:15 | |
| *** agopi|off has joined #openstack-nova | 02:16 | |
| *** cfriesen has quit IRC | 02:20 | |
| *** moshele has joined #openstack-nova | 02:20 | |
| openstackgerrit | Merged openstack/nova master: Move retry from _update to _update_to_placement https://review.openstack.org/634252 | 02:21 |
| *** dims has quit IRC | 02:25 | |
| *** tetsuro has joined #openstack-nova | 02:30 | |
| *** dims has joined #openstack-nova | 02:33 | |
| *** TxGirlGeek has joined #openstack-nova | 02:36 | |
| *** sdake has quit IRC | 02:37 | |
| *** wolverineav has joined #openstack-nova | 02:38 | |
| *** sdake has joined #openstack-nova | 02:41 | |
| *** wolverineav has quit IRC | 02:45 | |
| *** tetsuro has quit IRC | 02:46 | |
| *** tetsuro_ has joined #openstack-nova | 02:46 | |
| *** wolverineav has joined #openstack-nova | 02:46 | |
| *** wolverineav has quit IRC | 02:47 | |
| *** lbragstad__ has quit IRC | 02:52 | |
| *** gyee has quit IRC | 03:00 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| *** sdake has quit IRC | 03:23 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606 | 03:26 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 03:26 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | 03:26 |
| *** _hemna has joined #openstack-nova | 03:38 | |
| *** ccamacho has quit IRC | 03:39 | |
| *** itlinux has joined #openstack-nova | 03:41 | |
| *** macza has quit IRC | 03:45 | |
| *** tetsuro_ has quit IRC | 03:53 | |
| *** TxGirlGeek has quit IRC | 03:54 | |
| *** igordc has quit IRC | 04:02 | |
| *** moshele has quit IRC | 04:03 | |
| *** _hemna has quit IRC | 04:09 | |
| *** sdake has joined #openstack-nova | 04:10 | |
| *** macza has joined #openstack-nova | 04:20 | |
| *** udesale has joined #openstack-nova | 04:30 | |
| *** macza has quit IRC | 04:34 | |
| *** itlinux has quit IRC | 04:41 | |
| *** itlinux has joined #openstack-nova | 04:53 | |
| *** janki has joined #openstack-nova | 04:53 | |
| *** macza has joined #openstack-nova | 05:00 | |
| *** macza has quit IRC | 05:05 | |
| *** bhagyashris has joined #openstack-nova | 05:08 | |
| *** wolverineav has joined #openstack-nova | 05:11 | |
| *** wolverineav has quit IRC | 05:16 | |
| *** sdake has quit IRC | 05:25 | |
| *** sdake has joined #openstack-nova | 05:34 | |
| *** tkajinam_ has joined #openstack-nova | 05:41 | |
| *** macza has joined #openstack-nova | 05:42 | |
| *** tkajinam has quit IRC | 05:43 | |
| *** udesale has quit IRC | 05:45 | |
| *** macza has quit IRC | 05:46 | |
| *** udesale has joined #openstack-nova | 05:55 | |
| *** macza has joined #openstack-nova | 06:10 | |
| *** ratailor has joined #openstack-nova | 06:13 | |
| *** macza has quit IRC | 06:15 | |
| *** sdake has quit IRC | 06:20 | |
| *** moshele has joined #openstack-nova | 06:26 | |
| *** tetsuro has joined #openstack-nova | 06:30 | |
| *** tkajinam_ is now known as tkajinam | 06:34 | |
| *** sridharg has joined #openstack-nova | 06:51 | |
| *** dpawlik has joined #openstack-nova | 06:52 | |
| *** whoami-rajat has joined #openstack-nova | 06:53 | |
| *** priteau has joined #openstack-nova | 06:54 | |
| *** tkajinam_ has joined #openstack-nova | 07:03 | |
| *** lpetrut has joined #openstack-nova | 07:03 | |
| *** tkajinam has quit IRC | 07:05 | |
| *** slaweq has joined #openstack-nova | 07:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace glance command with openstack command https://review.openstack.org/635102 | 07:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace glance command with openstack command https://review.openstack.org/635102 | 07:13 |
| *** udesale has quit IRC | 07:15 | |
| *** priteau has quit IRC | 07:18 | |
| *** udesale has joined #openstack-nova | 07:20 | |
| *** pcaruana has joined #openstack-nova | 07:29 | |
| *** abhishekk has joined #openstack-nova | 07:30 | |
| *** takashin has quit IRC | 07:32 | |
| *** markvoelker has joined #openstack-nova | 07:39 | |
| *** bhagyashris has quit IRC | 07:41 | |
| *** takashin has joined #openstack-nova | 07:50 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928 | 07:55 |
| *** takashin has left #openstack-nova | 08:00 | |
| *** _fragatina has joined #openstack-nova | 08:00 | |
| *** belmoreira has joined #openstack-nova | 08:02 | |
| *** rpittau has joined #openstack-nova | 08:06 | |
| *** zul has quit IRC | 08:07 | |
| *** lpetrut has quit IRC | 08:07 | |
| *** dpawlik has quit IRC | 08:07 | |
| *** lpetrut has joined #openstack-nova | 08:08 | |
| *** _fragatina_ has joined #openstack-nova | 08:08 | |
| *** _fragatina_ has quit IRC | 08:10 | |
| *** awalende has joined #openstack-nova | 08:11 | |
| *** _fragatina has quit IRC | 08:11 | |
| *** markvoelker has quit IRC | 08:12 | |
| *** rchurch_ has quit IRC | 08:14 | |
| *** dpawlik has joined #openstack-nova | 08:14 | |
| *** rchurch has joined #openstack-nova | 08:15 | |
| *** tkajinam_ has quit IRC | 08:15 | |
| *** tesseract has joined #openstack-nova | 08:16 | |
| *** _fragatina has joined #openstack-nova | 08:18 | |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Convert hardcoded regexes to raw strings for py36 https://review.openstack.org/635111 | 08:20 |
| *** dpawlik has quit IRC | 08:20 | |
| *** yan0s has joined #openstack-nova | 08:27 | |
| *** panda|off is now known as panda | 08:32 | |
| *** dpawlik has joined #openstack-nova | 08:32 | |
| *** ttsiouts has joined #openstack-nova | 08:33 | |
| *** dpawlik has quit IRC | 08:36 | |
| *** ttsiouts has quit IRC | 08:47 | |
| *** ttsiouts has joined #openstack-nova | 08:48 | |
| *** tetsuro has quit IRC | 08:48 | |
| *** ttsiouts has quit IRC | 08:52 | |
| *** tssurya has joined #openstack-nova | 08:54 | |
| *** Luzi has joined #openstack-nova | 08:54 | |
| *** tosky has joined #openstack-nova | 08:56 | |
| *** xek has joined #openstack-nova | 09:09 | |
| *** ociuhandu has quit IRC | 09:09 | |
| *** ttsiouts has joined #openstack-nova | 09:09 | |
| *** markvoelker has joined #openstack-nova | 09:09 | |
| *** ociuhandu has joined #openstack-nova | 09:10 | |
| *** lpetrut has quit IRC | 09:14 | |
| *** ociuhandu has quit IRC | 09:15 | |
| *** derekh has joined #openstack-nova | 09:34 | |
| *** markvoelker has quit IRC | 09:43 | |
| *** takamatsu_ has joined #openstack-nova | 09:57 | |
| *** takamatsu has quit IRC | 09:57 | |
| *** takamatsu_ has quit IRC | 10:00 | |
| *** ociuhandu has joined #openstack-nova | 10:03 | |
| *** takamatsu_ has joined #openstack-nova | 10:03 | |
| *** ociuhandu has quit IRC | 10:07 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 10:10 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Modify InstanceMappingList.get_not_deleted_by_cell_and_project() https://review.openstack.org/635120 | 10:10 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121 | 10:10 |
| *** psachin has quit IRC | 10:24 | |
| *** cdent has joined #openstack-nova | 10:25 | |
| *** slaweq has quit IRC | 10:40 | |
| *** markvoelker has joined #openstack-nova | 10:40 | |
| *** erlon has joined #openstack-nova | 10:48 | |
| *** psachin has joined #openstack-nova | 10:50 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 10:53 |
| *** erlon_ has joined #openstack-nova | 10:55 | |
| *** abhishekk has quit IRC | 10:55 | |
| *** slaweq has joined #openstack-nova | 10:57 | |
| *** erlon has quit IRC | 10:58 | |
| *** macza has joined #openstack-nova | 10:59 | |
| *** slaweq has quit IRC | 11:01 | |
| *** macza has quit IRC | 11:03 | |
| *** ttsiouts has quit IRC | 11:13 | |
| *** ccamacho has joined #openstack-nova | 11:13 | |
| *** markvoelker has quit IRC | 11:13 | |
| *** udesale has quit IRC | 11:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.68: Remove 'forced' live migrations, evacuations https://review.openstack.org/635131 | 11:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 11:22 |
| *** wolverineav has joined #openstack-nova | 11:36 | |
| *** slaweq has joined #openstack-nova | 11:38 | |
| *** wolverineav has quit IRC | 11:41 | |
| *** tbachman has quit IRC | 11:48 | |
| *** takamatsu_ has quit IRC | 11:48 | |
| *** janki has quit IRC | 11:49 | |
| *** takamatsu_ has joined #openstack-nova | 11:52 | |
| *** janki has joined #openstack-nova | 11:54 | |
| *** ttsiouts has joined #openstack-nova | 11:58 | |
| *** _fragatina has quit IRC | 12:00 | |
| *** _fragatina has joined #openstack-nova | 12:01 | |
| *** ratailor has quit IRC | 12:09 | |
| *** markvoelker has joined #openstack-nova | 12:09 | |
| *** janki has quit IRC | 12:23 | |
| *** Dinesh_Bhor has quit IRC | 12:24 | |
| *** takamatsu_ has quit IRC | 12:24 | |
| *** takamatsu has joined #openstack-nova | 12:24 | |
| *** cdent has quit IRC | 12:26 | |
| *** ociuhandu has joined #openstack-nova | 12:35 | |
| *** ociuhandu has quit IRC | 12:35 | |
| *** ociuhandu has joined #openstack-nova | 12:35 | |
| *** ociuhandu has quit IRC | 12:35 | |
| *** ociuhandu has joined #openstack-nova | 12:36 | |
| *** Luzi has quit IRC | 12:37 | |
| *** Luzi has joined #openstack-nova | 12:37 | |
| *** Luzi has quit IRC | 12:38 | |
| *** _fragatina has quit IRC | 12:41 | |
| *** sdake has joined #openstack-nova | 12:41 | |
| *** _fragatina has joined #openstack-nova | 12:41 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121 | 12:41 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 12:41 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing for allowing the all-tenants filter https://review.openstack.org/635145 | 12:41 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing required in ViewBuilder to construct partial results https://review.openstack.org/635146 | 12:41 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147 | 12:41 |
| *** markvoelker has quit IRC | 12:42 | |
| *** _fragatina has quit IRC | 12:44 | |
| *** _fragatina has joined #openstack-nova | 12:44 | |
| *** _fragatina has quit IRC | 12:45 | |
| *** _fragatina has joined #openstack-nova | 12:46 | |
| *** _fragatina has quit IRC | 12:50 | |
| *** _fragatina has joined #openstack-nova | 12:51 | |
| *** _fragatina has quit IRC | 12:52 | |
| *** _fragatina has joined #openstack-nova | 12:53 | |
| *** _fragatina has quit IRC | 12:59 | |
| *** _fragatina has joined #openstack-nova | 12:59 | |
| *** _fragatina has quit IRC | 13:01 | |
| *** _fragatina has joined #openstack-nova | 13:01 | |
| *** _fragatina has quit IRC | 13:03 | |
| *** _fragatina has joined #openstack-nova | 13:04 | |
| *** _fragatina has quit IRC | 13:05 | |
| *** _fragatina has joined #openstack-nova | 13:06 | |
| *** tbachman has joined #openstack-nova | 13:08 | |
| *** ociuhandu_ has joined #openstack-nova | 13:09 | |
| *** _fragatina has quit IRC | 13:10 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 13:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | 13:10 |
| *** erlon_ has quit IRC | 13:10 | |
| *** _fragatina has joined #openstack-nova | 13:10 | |
| *** mmethot has quit IRC | 13:11 | |
| *** ociuhandu_ has quit IRC | 13:11 | |
| *** ociuhandu_ has joined #openstack-nova | 13:12 | |
| *** ociuhandu has quit IRC | 13:12 | |
| *** mmethot has joined #openstack-nova | 13:14 | |
| *** _fragatina has quit IRC | 13:17 | |
| *** _fragatina has joined #openstack-nova | 13:18 | |
| *** TxGirlGeek has joined #openstack-nova | 13:18 | |
| *** _fragatina has quit IRC | 13:21 | |
| *** sdake has quit IRC | 13:23 | |
| *** sdake has joined #openstack-nova | 13:23 | |
| *** _fragatina has joined #openstack-nova | 13:25 | |
| *** erlon_ has joined #openstack-nova | 13:26 | |
| *** Luzi has joined #openstack-nova | 13:27 | |
| *** sdake has quit IRC | 13:27 | |
| *** tbachman has quit IRC | 13:29 | |
| *** mriedem has joined #openstack-nova | 13:32 | |
| *** TxGirlGeek has quit IRC | 13:33 | |
| *** jamesdenton has quit IRC | 13:33 | |
| *** janki has joined #openstack-nova | 13:35 | |
| *** sdake has joined #openstack-nova | 13:35 | |
| *** slaweq has quit IRC | 13:35 | |
| *** tbachman has joined #openstack-nova | 13:36 | |
| *** sdake has quit IRC | 13:39 | |
| *** markvoelker has joined #openstack-nova | 13:39 | |
| *** tosky has quit IRC | 13:44 | |
| bauzas | good afternoon Nova, now begins my upstream day | 13:45 |
| sean-k-mooney | o/ hello upstream bauzas :) | 13:46 |
| bauzas | sylvainb != bauzas :) | 13:46 |
| bauzas | so 'upstream bauzas' is just a pleonasm | 13:46 |
| *** sdake has joined #openstack-nova | 13:47 | |
| sean-k-mooney | bauzas: the real question is who is the evil one and who is the good one sylvainb or bauzas | 13:47 |
| bauzas | it's schizophrenic, I know | 13:48 |
| bauzas | mwuaaahahahah | 13:48 |
| *** mvkr has quit IRC | 13:48 | |
| mriedem | tssurya: i could be wrong but it seems the commit message and comment in https://review.openstack.org/#/c/635120/ are backward | 13:49 |
| sean-k-mooney | bauzas: the real question is who is the evil one and who is the good one sylvainb or bauzas | 13:50 |
| bauzas | I can't answer this question without the presence of my lawyer | 13:51 |
| *** jamesdenton has joined #openstack-nova | 13:51 | |
| *** cdent has joined #openstack-nova | 13:56 | |
| *** sdake has quit IRC | 14:00 | |
| *** sdake has joined #openstack-nova | 14:02 | |
| *** _fragatina has quit IRC | 14:05 | |
| *** _fragatina has joined #openstack-nova | 14:06 | |
| *** moshele has quit IRC | 14:07 | |
| *** ttsiouts has quit IRC | 14:09 | |
| *** _fragatina has quit IRC | 14:09 | |
| *** _fragatina has joined #openstack-nova | 14:10 | |
| *** psachin has quit IRC | 14:10 | |
| *** sdake has quit IRC | 14:12 | |
| *** _hemna has joined #openstack-nova | 14:12 | |
| *** markvoelker has quit IRC | 14:13 | |
| *** ttsiouts has joined #openstack-nova | 14:17 | |
| *** mvkr has joined #openstack-nova | 14:19 | |
| *** belmoreira has quit IRC | 14:20 | |
| *** belmoreira has joined #openstack-nova | 14:21 | |
| *** moshele has joined #openstack-nova | 14:23 | |
| tssurya | mriedem: um, no I meant for the ones where the data migration is run, it would be False/True while for the new ones its None/NULL at least in the database.. | 14:26 |
| tssurya | I'll update it on the review. | 14:27 |
| *** eharney has joined #openstack-nova | 14:27 | |
| mriedem | i'm not sure what "new ones" means | 14:29 |
| mriedem | new instance mappings should have a default of false | 14:29 |
| mriedem | existing records would have None | 14:29 |
| mriedem | and those are what get migrated | 14:29 |
| tssurya | like fresh instance_mappings from Stein | 14:29 |
| tssurya | that is what I mean by new | 14:29 |
| mriedem | and those should have queued_for_delete=False in the db by default | 14:29 |
| tssurya | which they don't | 14:29 |
| mriedem | ? | 14:30 |
| tssurya | I thought they should have qfd=False by default too | 14:30 |
| tssurya | but in the new devstack in which I tested they are NULL | 14:30 |
| tssurya | by default | 14:30 |
| mriedem | if they don't, then we have a problem because we'd never be able to complete that data migration | 14:30 |
| tssurya | well I am assuming once we run the migration, we would not run it again | 14:30 |
| mriedem | but if you're saying that new instance mappings records don't have queued_for_delete=false in the db, then we'd have to migrate those as well | 14:31 |
| mriedem | b/c the migration is looking for queued_for_delete=None | 14:31 |
| tssurya | would have to ask dansmith | 14:31 |
| tssurya | but I am thinking for the newer ones None also means not queued_for_delete | 14:31 |
| tssurya | and when they get deleted it would become True | 14:32 |
| dansmith | why ask me? :) | 14:32 |
| dansmith | if we're writing the qfd flag on object save, then new records should have =False, if not then it depends on whether or not we have a default in the schema | 14:33 |
| tssurya | https://review.openstack.org/#/c/584504/5//COMMIT_MSG@16 | 14:33 |
| *** zul has joined #openstack-nova | 14:34 | |
| dansmith | oh ;) | 14:34 |
| dansmith | yeah, I remember this being some weird detail when writing that migration but I don't remember why | 14:34 |
| *** sdake has joined #openstack-nova | 14:34 | |
| tssurya | to catch all the None and change them to True/False | 14:35 |
| tssurya | which made sense | 14:35 |
| tssurya | so I am assuming we were ok with have new records that would be None by default right ? | 14:35 |
| tssurya | having* | 14:35 |
| mriedem | no | 14:35 |
| mriedem | because then the data migration will never be complet | 14:35 |
| mriedem | *complete | 14:35 |
| mriedem | new records should have False in the db when we insert the record | 14:36 |
| dansmith | oh right right | 14:36 |
| tssurya | mriedem: yea the data migration will never be complete, but I am assuming it will be removed eventually and the goal of that migration was to update the deleted instances to True | 14:36 |
| dansmith | because they need to be either true or false null means unmigrated | 14:36 |
| *** _alastor_ has joined #openstack-nova | 14:36 | |
| dansmith | tssurya: no, I think the intent is to update them to true or false right? | 14:36 |
| tssurya | heh ok I didn't think it was bug, but maybe it is ? :D | 14:36 |
| tssurya | dansmith: yea for the old instances | 14:37 |
| *** mvkr has quit IRC | 14:37 | |
| mriedem | the data migration also sets queued_for_delete=False on instance mappings for non-deleted instances | 14:37 |
| mriedem | https://review.openstack.org/#/c/584504/5/nova/objects/instance_mapping.py@179 | 14:37 |
| tssurya | but we don't care for the new ones right ? for them None = False () sort of and when they get deleted it would become True() from None that's all | 14:37 |
| *** mvkr has joined #openstack-nova | 14:37 | |
| tssurya | mriedem: yea I understand | 14:38 |
| tssurya | if we feel its a bug for the migration to be always incomplete | 14:38 |
| *** moshele has quit IRC | 14:38 | |
| mriedem | well generally data migrations are something you'd like to have an end state | 14:38 |
| tssurya | then we can fix. | 14:39 |
| tssurya | (anu suggestions ?) | 14:39 |
| tssurya | any* | 14:39 |
| dansmith | I'm confused about what the problem is | 14:39 |
| mriedem | started with my confusion over the commit message and comments in https://review.openstack.org/#/c/635120/ | 14:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471 | 14:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Set bandwidth limits for generic vHost User interfaces https://review.openstack.org/635170 | 14:41 |
| mriedem | and tssurya said that with a new instance mapping in devstack today, the queued_for_delete in the DB is NULL even though we default to False in the object and sqla model code | 14:41 |
| mriedem | which ^ doesn't make sense to me | 14:41 |
| *** _alastor_ has quit IRC | 14:41 | |
| mriedem | i get that we don't set False for the server_default | 14:41 |
| mriedem | but inserting new records should have a default value of False in the DB i'd think | 14:41 |
| stephenfin | mriedem, jaypipes: I've split out that bandwidth limits fix to a separate patch, if you fancy taking a quick look over it again https://review.openstack.org/565471 https://review.openstack.org/635170 | 14:41 |
| mriedem | stephenfin: only if i can raise my pinky while reviewing it | 14:42 |
| tssurya | mriedem: we don't default to false in the api_models code right ? that was changed for the migration | 14:42 |
| tssurya | which is why this is happening I think | 14:42 |
| dansmith | tssurya: right but we should be passing it from the object always | 14:42 |
| *** BjoernT has joined #openstack-nova | 14:42 | |
| dansmith | if not, then that's a problem | 14:42 |
| * stephenfin hands mriedem a tea cup to complete the look | 14:42 | |
| mriedem | ok then i missed https://review.openstack.org/#/c/584504/5/nova/db/sqlalchemy/api_models.py | 14:42 |
| mriedem | we're not passing it from the object b/c the field isn't set | 14:43 |
| mriedem | https://review.openstack.org/#/c/584504/5/nova/objects/instance_mapping.py@102 | 14:43 |
| mriedem | https://review.openstack.org/#/c/584504/5/nova/compute/api.py@938 | 14:43 |
| dansmith | we have a default on the field, but that doesn't mean it gets set, | 14:44 |
| mriedem | right | 14:44 |
| dansmith | so maybe whoever wrote that code thought it would be | 14:44 |
| mriedem | so it's not in the changes | 14:44 |
| mriedem | anyway it's a simple fix | 14:44 |
| dansmith | yeah, so create() should always set that =False and destroy should set it =True | 14:44 |
| mriedem | changes.setdefault('queued_for_delete', False) | 14:44 |
| dansmith | I'll work up a patch | 14:45 |
| *** mchlumsky has joined #openstack-nova | 14:45 | |
| dansmith | mriedem: I think it'd be better to be explicit about it | 14:45 |
| dansmith | because we have to be on delete anyway | 14:45 |
| tssurya | destroy removes the mapping right ? | 14:45 |
| dansmith | tssurya: got a bug for this? | 14:45 |
| tssurya | dansmith: thanks I will open a bug now | 14:45 |
| dansmith | oh right, no soft delete here | 14:45 |
| tssurya | and assign it to you | 14:45 |
| dansmith | when does it get set =True then? | 14:46 |
| mriedem | right, we set qfd = True in the API https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2192 | 14:46 |
| dansmith | I clearly don't remember this | 14:46 |
| dansmith | oh righ on instance deete duh | 14:46 |
| tssurya | during nova delete's | 14:46 |
| *** betherly has joined #openstack-nova | 14:47 | |
| dansmith | ah and we have it in our tests | 14:49 |
| *** wolverineav has joined #openstack-nova | 14:49 | |
| dansmith | like, explicitly setting it =False | 14:49 |
| *** sdake has quit IRC | 14:50 | |
| *** awaugama has joined #openstack-nova | 14:51 | |
| *** betherly has quit IRC | 14:51 | |
| tssurya | damsith: https://bugs.launchpad.net/nova/+bug/1814913 | 14:52 |
| openstack | Launchpad bug 1814913 in OpenStack Compute (nova) "A new instance_mapping record will have queued_for_delete set to NULL" [Undecided,New] - Assigned to Dan Smith (dansmith) | 14:52 |
| tssurya | dansmith * sorry | 14:53 |
| dansmith | thanks, patch shortly | 14:53 |
| *** cdent has quit IRC | 14:53 | |
| mriedem | high fives for team work | 14:53 |
| *** wolverineav has quit IRC | 14:53 | |
| tssurya | I will change the patch then to no longer have to consider "None" values | 14:54 |
| *** macza has joined #openstack-nova | 14:54 | |
| bauzas | mmm, we don't document the reasons why flavors are immutable, neither in https://docs.openstack.org/nova/latest/admin/flavors.html or https://docs.openstack.org/nova/latest/user/flavors.html | 14:54 |
| dansmith | tssurya: your patch? you still need to handle none values | 14:54 |
| dansmith | tssurya: meaning you can't fail if they're there | 14:54 |
| tssurya | dansmith: I mean this one: https://review.openstack.org/#/c/635120/ | 14:55 |
| bauzas | I have a downstream request about modifying the nested flavor by not resizing, so I'd like to explain to the customer why I don't like it | 14:55 |
| sean-k-mooney | bauzas: they are immutable as if they were not existing instaces may exceed available resouces | 14:55 |
| dansmith | tssurya: ah okay | 14:55 |
| tssurya | to get non-deleted I only need to ask for "False()" right ? assuming people ran the migration | 14:55 |
| bauzas | yeah, I know *why*, but I'd like to see the fact that you can't modify a nested flavor to be documented | 14:55 |
| dansmith | tssurya: no | 14:55 |
| openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: rename ScaleIO driver to VxFlex Os https://review.openstack.org/634866 | 14:56 |
| dansmith | tssurya: you can't assume the migration was run until it's forced really | 14:56 |
| sean-k-mooney | bauzas: the downstream issue is related to the flavor extra specs not the flaovr | 14:56 |
| bauzas | yeah | 14:56 |
| *** awaugama has quit IRC | 14:56 | |
| sean-k-mooney | bauzas: but yes it would be nice to have that documented | 14:56 |
| tssurya | dansmith: even then now that you are fixing it, it would be wrong for me to have a logic where I am also querying for the None ones thinking they are non-deleted | 14:57 |
| bauzas | tbh, I don't like to be able to modify the extra specs but... | 14:57 |
| *** sdake has joined #openstack-nova | 14:57 | |
| tssurya | because it could just be that the user has not run the migration | 14:57 |
| dansmith | tssurya: if it's null it means we don't know if it's queued for delete or not, so pick one.. should the user see their instance go away or come back from the dead? it has to be one or the other | 14:57 |
| *** macza has quit IRC | 14:58 | |
| tssurya | dansmith: hah I don't have a strong opinion on that probably "come back from dead" is better | 14:59 |
| tssurya | so I will just leave my change as it is then | 14:59 |
| tssurya | and just edit the commit/comment | 14:59 |
| *** cfriesen has joined #openstack-nova | 14:59 | |
| *** janki has quit IRC | 15:00 | |
| *** agopi|off is now known as agopi | 15:01 | |
| sean-k-mooney | bauzas: we proably should update https://github.com/openstack/nova/blob/master/doc/source/admin/flavors.rst#modify-a-flavor | 15:01 |
| bauzas | I'm out of steam for that but yeah | 15:02 |
| mriedem | bauzas: so add something about that here https://docs.openstack.org/nova/latest/admin/flavors.html#modify-a-flavor | 15:02 |
| *** macza has joined #openstack-nova | 15:03 | |
| sean-k-mooney | bauzas: i can add a note if you like | 15:03 |
| mriedem | you can copy what's in https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/flavor-description.html if you want | 15:04 |
| mriedem | " Note The only field that can be updated is the description field. Nova has historically intentionally not included an API to update a flavor because that would be confusing for instances already created with that flavor. Needing to change any other aspect of a flavor requires deleting and/or creating a new flavor. " | 15:04 |
| sean-k-mooney | mriedem: ya that makes sense. bauzas want me to do it since your busy or will i leave it to you. | 15:05 |
| mriedem | we can also update the osc command note in https://docs.openstack.org/nova/latest/admin/flavors.html#modify-a-flavor to mention that support was added in openstack CLI in 3.16.0: https://review.openstack.org/#/c/575390/ | 15:05 |
| mriedem | or just change the example to use osc | 15:06 |
| mriedem | and drop the nonte | 15:06 |
| mriedem | *note | 15:06 |
| sean-k-mooney | sure | 15:06 |
| bauzas | actually, the spec is a good example | 15:06 |
| sean-k-mooney | ill go do that now | 15:06 |
| bauzas | thanks | 15:06 |
| sean-k-mooney | bauzas: ya you can use the spec as a reference for the customer while i update this | 15:07 |
| bauzas | yeah | 15:07 |
| bauzas | but anyway, I need to provide a hack :( | 15:07 |
| bauzas | and I hate this | 15:07 |
| sean-k-mooney | well you dont | 15:07 |
| sean-k-mooney | we shoud discuss that downstream | 15:07 |
| bauzas | oh yeah, I have to do it | 15:07 |
| bauzas | trust me | 15:08 |
| *** awaugama has joined #openstack-nova | 15:09 | |
| *** macza has quit IRC | 15:09 | |
| *** markvoelker has joined #openstack-nova | 15:10 | |
| *** Luzi has quit IRC | 15:11 | |
| stephenfin | adrianc: Quick question: how does one identify the "OPN" of a ConnectX-3 NIC? | 15:12 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix InstanceMapping to always default queued_for_delete=False https://review.openstack.org/635185 | 15:12 |
| stephenfin | I can find the PSID via 'mstflint query' but can't see the OPN http://www.mellanox.com/page/firmware_table_ConnectX3EN | 15:12 |
| sean-k-mooney | stephenfin: OPN? | 15:12 |
| sean-k-mooney | oh its a vendor id | 15:13 |
| stephenfin | sean-k-mooney: The second column in that firmware download list. I assume it's the part ID | 15:13 |
| sean-k-mooney | ya it like intels etag for there firmware | 15:13 |
| sean-k-mooney | at least it looks like it is anyway | 15:13 |
| stephenfin | sean-k-mooney: I think that's only good to distinguish between e.g. the ConnectX-3 and ConnectX-3 Pro, based on http://www.mellanox.com/page/firmware_HCA_FW_identification | 15:14 |
| stephenfin | and the ID I'm getting, 15b3:1003, doesn't give me any deets on https://www.pcilookup.com/?ven=15b3&dev=1003&action=submit | 15:14 |
| stephenfin | adrianc: I had the PSID and just clicked down through the list of OPNs to find what I was looking for. If there's a better way though, I'd be happy to hear about it | 15:15 |
| stephenfin | sean-k-mooney: ^ | 15:15 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend RequestGroup object for mapping https://review.openstack.org/619527 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 15:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 15:17 |
| jaypipes | stephenfin: ok, will try. (sorry, been out of IRC contact for 6+ days) | 15:17 |
| stephenfin | jaypipes: It's all good. Thanks for even trying | 15:19 |
| *** macza has joined #openstack-nova | 15:19 | |
| *** mrch has joined #openstack-nova | 15:20 | |
| *** awalende has quit IRC | 15:23 | |
| *** erlon__ has joined #openstack-nova | 15:23 | |
| *** awalende has joined #openstack-nova | 15:24 | |
| *** artom has quit IRC | 15:26 | |
| *** erlon_ has quit IRC | 15:26 | |
| *** awalende has quit IRC | 15:28 | |
| *** ociuhandu_ has quit IRC | 15:28 | |
| *** mlavalle has joined #openstack-nova | 15:28 | |
| *** ociuhandu has joined #openstack-nova | 15:29 | |
| mriedem | why oh why doesn't the set -x here https://review.openstack.org/#/c/634962/2/nova/tests/live_migration/hooks/run_tests.sh@12 enable tracing? | 15:30 |
| mriedem | http://logs.openstack.org/62/634962/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/f8f245f/logs/devstack-gate-post_test_hook.txt.gz#_2019-02-05_22_35_09_439 | 15:30 |
| *** mrch has quit IRC | 15:31 | |
| mriedem | oh i bet something downstream unsets it | 15:31 |
| mriedem | aha http://logs.openstack.org/62/634962/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/f8f245f/logs/devstack-gate-post_test_hook.txt.gz#_2019-02-05_22_35_09_525 | 15:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | 15:36 |
| bauzas | gibi_off: would you mind if I was rebasing https://review.openstack.org/#/c/631559/ on top of the new revision I'm working for https://review.openstack.org/#/c/599208/ | 15:36 |
| bauzas | ? | 15:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Allow [pci]alias to take a list https://review.openstack.org/635191 | 15:37 |
| mriedem | bauzas: i'm sure he doesn't mind | 15:37 |
| bauzas | ack | 15:37 |
| *** macza has quit IRC | 15:40 | |
| *** markvoelker has quit IRC | 15:43 | |
| *** moshele has joined #openstack-nova | 15:44 | |
| *** moshele has quit IRC | 15:46 | |
| openstackgerrit | Jack Ding proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 15:46 |
| *** udesale has joined #openstack-nova | 15:48 | |
| *** wwriverrat has quit IRC | 15:54 | |
| stephenfin | sean-k-mooney: https://that.guru/blog/updating-mellanox-connectx-3/ | 15:55 |
| stephenfin | adrianc: ^ if you figure that out, I'll update the above | 15:55 |
| *** awalende has joined #openstack-nova | 15:56 | |
| *** cdent has joined #openstack-nova | 15:56 | |
| openstackgerrit | sean mooney proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | 15:59 |
| *** awalende has quit IRC | 16:00 | |
| *** tbachman has quit IRC | 16:01 | |
| *** _alastor_ has joined #openstack-nova | 16:04 | |
| sean-k-mooney | stephenfin: i assume this should not happen http://paste.openstack.org/show/744632/ | 16:04 |
| stephenfin | sean-k-mooney: You've got left over pyc files | 16:05 |
| openstackgerrit | Merged openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928 | 16:05 |
| stephenfin | and the interpreter is trying to read them | 16:05 |
| sean-k-mooney | oh even after -r | 16:05 |
| stephenfin | 'find . -type f -name "*.pyc" -delete' | 16:05 |
| melwitt | o/ | 16:05 |
| mriedem | sean-k-mooney: stephenfin: we used to have something in tox.ini to delete those on each run to avoid that but someone had an opinion and removed it | 16:06 |
| sean-k-mooney | mriedem: yes i rememebr i was going to check if it was remvoed | 16:07 |
| *** tbachman has joined #openstack-nova | 16:07 | |
| stephenfin | mriedem: It's still there and that sounds rather passive aggressive. If that's intentional, stop it please. No need for that | 16:07 |
| stephenfin | We just don't do it for docs | 16:07 |
| sean-k-mooney | stephenfin: anyway that seams to have partly fixed it. | 16:07 |
| sean-k-mooney | i now get dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting | 16:08 |
| stephenfin | sean-k-mooney: Yup, if you fancy sticking a call to '{[testenv]commands}' in the commands for the 'docs' target, it'd be an easy fix to prevent that recurring | 16:08 |
| stephenfin | sean-k-mooney: Guess you need to install dot? | 16:08 |
| sean-k-mooney | ya i can | 16:08 |
| mriedem | huh? | 16:08 |
| mriedem | we don't delete pyc in the tox docs env | 16:09 |
| mriedem | b/c we override commands | 16:09 |
| mriedem | what am i being passive aggressive about? | 16:09 |
| mriedem | i hit this same thing from time to time and have to remember to delete pycs manually which is annoying | 16:09 |
| sean-k-mooney | ill update the docs tox env but i think we need to add graphviz as a docs dep too | 16:10 |
| mriedem | graphviz is a binary | 16:10 |
| mriedem | it's in bindep | 16:10 |
| sean-k-mooney | you are right but why do we now need it for docs | 16:10 |
| sean-k-mooney | we didnt in the past | 16:10 |
| mriedem | we've needed it for a long time | 16:10 |
| mriedem | are you on a new system? | 16:11 |
| sean-k-mooney | im on a system that has never had devstack run | 16:11 |
| sean-k-mooney | so yes | 16:11 |
| sean-k-mooney | ok ill just install it | 16:11 |
| jackding | mriedem: runway for https://review.openstack.org/#/c/620706/ ends tomorrow. I believe I have addressed your comments. Do you have sometime to revisit? | 16:12 |
| mriedem | stephenfin: this is what i was referring to http://lists.openstack.org/pipermail/openstack-dev/2014-September/045873.html | 16:12 |
| stephenfin | mriedem: "we used to have something in tox.ini to delete those on each run to avoid that but someone had an opinion and removed it" | 16:12 |
| stephenfin | mriedem: I figured that was aimed at me, in which case it seemed like I was being singled out for what was almost certainly a change made for good reasons | 16:12 |
| stephenfin | as opposed to "opinions" | 16:12 |
| mriedem | i was referring to that thread | 16:13 |
| mriedem | which was related to https://review.openstack.org/#/c/338231/ | 16:13 |
| mriedem | which was yours, but that was just "don't create pycs rather than delete them" which as you can see i was +2 on | 16:13 |
| stephenfin | Yeah, we reverted that though 233160644f4f0a17177fffe8a1e6db1341e61ad4 | 16:13 |
| mriedem | i know | 16:13 |
| sean-k-mooney | anyway ill push a patch to add the delete to the docs job if ye feel like reviewing | 16:14 |
| stephenfin | Cool. So this has just been missed is all. Surprised it didn't come up before now, tbh | 16:14 |
| mriedem | sean-k-mooney: just do what stephenfin asked for | 16:14 |
| mriedem | '{[testenv]commands}' | 16:15 |
| sean-k-mooney | ya that was what i was going to do | 16:15 |
| sean-k-mooney | i was looking up the syntax :) | 16:15 |
| *** _fragatina_ has joined #openstack-nova | 16:16 | |
| stephenfin | mriedem: But, crucially, I didn't remove it (or anything else, I'd like to think) the first day because of "opinions". I gave sound reasons in that commit message. I just missed the tox issue, which was the reason for the later revert | 16:16 |
| stephenfin | That is all :) | 16:16 |
| stephenfin | Speaking of, as soon as we support a new enough version of tox, we can revert that revert again | 16:16 |
| stephenfin | https://github.com/tox-dev/tox/commit/336f4f6bd8b53223f940fc5cfc43b1bbd78d4699 | 16:17 |
| *** _fragatina has quit IRC | 16:17 | |
| *** ttsiouts has quit IRC | 16:18 | |
| *** ttsiouts has joined #openstack-nova | 16:18 | |
| melwitt | gibi_off: thank you for the note! I hope you are having a nice recovery | 16:20 |
| *** ttsiouts has quit IRC | 16:23 | |
| *** tbachman has quit IRC | 16:24 | |
| *** agopi is now known as agopi|brb | 16:25 | |
| *** xek has quit IRC | 16:26 | |
| *** xek has joined #openstack-nova | 16:26 | |
| mriedem | stephenfin: question inline https://review.openstack.org/#/c/635170/ | 16:27 |
| * stephenfin clicks | 16:27 | |
| stephenfin | mriedem: Yeah, I am | 16:27 |
| stephenfin | sean-k-mooney, jangutter: You should probably look at the above too | 16:28 |
| sean-k-mooney | stephenfin: for vhostuser i dont think they work | 16:28 |
| sean-k-mooney | stephenfin: that is why we dont set them today | 16:28 |
| sean-k-mooney | stephenfin: libvirt sets tehm on the tap device but vhost user does not have a tap | 16:29 |
| jangutter | sean-k-mooney: yah vhost-user has a socket. | 16:29 |
| sean-k-mooney | stephenfin: jangutter well the main point is that only way to do ratelimiting with vhost-user that im aware of is via dpdk/ovs | 16:30 |
| jangutter | sean-k-mooney: ya, there's no netdev to set nifty options like rxqueuelen, etc. | 16:31 |
| sean-k-mooney | tc cant do ratelimiting on a unix socket escpially since that socket is part of the contol plane not the data plane | 16:31 |
| sean-k-mooney | jangutter: well you can set the queue lenght in the qemu commandline | 16:31 |
| sean-k-mooney | and we do i think | 16:32 |
| *** tbachman has joined #openstack-nova | 16:32 | |
| *** gyee has joined #openstack-nova | 16:32 | |
| sean-k-mooney | but qemu does not do the rate limiting tc did i think | 16:32 |
| *** agopi|brb has quit IRC | 16:32 | |
| openstackgerrit | sean mooney proposed openstack/nova master: cleanup *.pyc files in docs tox envs https://review.openstack.org/635210 | 16:33 |
| jangutter | sean-k-mooney: drat, already running out of caffeine, I'm thinking of txquelen for tc qdiscs (like ip link set txqueuelen 500 dev eth0) | 16:33 |
| jangutter | sean-k-mooney: yah, setting things like number of descriptors in vhost-user is something entirely different and doesn't have to do with rate limiting. | 16:34 |
| mriedem | sean-k-mooney: weren't you +1 on https://review.openstack.org/#/c/565471/ previously? this change for bw was split out from that | 16:34 |
| sean-k-mooney | mriedem: no dont think i had ever left a +1 on that one specifrically but i did remove my -1 | 16:37 |
| sean-k-mooney | i have not reviewed it recently | 16:37 |
| sean-k-mooney | mriedem: stephenfin anyway i dont think it would break vhost-user but i think it would have no effect | 16:38 |
| sean-k-mooney | in anycase we should not set it as it cannot work with vhost-user so its misleading | 16:38 |
| *** markvoelker has joined #openstack-nova | 16:40 | |
| mriedem | sean-k-mooney: ok i remember you asking me to look at it :) | 16:40 |
| mriedem | so maybe i assumed you had | 16:40 |
| *** artom has joined #openstack-nova | 16:41 | |
| sean-k-mooney | mriedem: yes i did sorry i had planned too re review but i didnt get to it yet sorry | 16:42 |
| mriedem | you're forgiven sean | 16:44 |
| melwitt | bauzas: you're not in #openstack-placement, but there's a extraction update meeting at the top of the hour, hangout url to be linked in #openstack-placement | 16:44 |
| bauzas | melwitt: I'll be there | 16:45 |
| melwitt | cool | 16:45 |
| bauzas | melwitt: for some reason, ZNC dropped me from -placement, but I'll rejoin | 16:46 |
| bauzas | melwitt: thanks for the notice :) | 16:46 |
| jangutter | sean-k-mooney, stephenfin: https://github.com/libvirt/libvirt/blob/568a417224e7b4656b9959b03154d45566480d65/src/conf/netdev_bandwidth_conf.h#L38 | 16:47 |
| sean-k-mooney | jangutter right so based on ^ libvirt will ignore it for vhos-user if it is set | 16:49 |
| jangutter | sean-k-mooney, stephenfin: yah, in fact, if that's canonical, it's a nice checklist of "supported" interfaces. | 16:49 |
| openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibilit https://review.openstack.org/635220 | 16:49 |
| openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibility https://review.openstack.org/635220 | 16:50 |
| *** agopi|brb has joined #openstack-nova | 16:52 | |
| *** med_ has joined #openstack-nova | 16:55 | |
| jackding | mriedem: just let you know that https://review.openstack.org/#/c/620706/ and https://review.openstack.org/#/c/603844/ is ready to review, thanks | 16:57 |
| *** agopi|brb is now known as agopi | 16:58 | |
| *** sdake has quit IRC | 17:00 | |
| cdent | for those not in #openstack-placement placement checkin hangout at https://hangouts.google.com/call/C5h9TyVk5BMfSO8vGxZ_AEEE | 17:01 |
| *** udesale has quit IRC | 17:04 | |
| *** _hemna has quit IRC | 17:07 | |
| *** tssurya has quit IRC | 17:09 | |
| *** macza has joined #openstack-nova | 17:09 | |
| stephenfin | jangutter, sean-k-mooney: Right, so we were setting the option for OVS vHost User interfaces but it wasn't doing anything | 17:10 |
| stephenfin | jangutter, sean-k-mooney: In that case, is it fair to fold it back into the following patch and just ignore the fact that it's being set, given that it does nothing? | 17:11 |
| stephenfin | Far as I can see, the only side effect will be this https://review.openstack.org/#/c/565471/7/nova/tests/unit/virt/libvirt/test_vif.py | 17:11 |
| *** macza has quit IRC | 17:13 | |
| *** sdake has joined #openstack-nova | 17:13 | |
| *** markvoelker has quit IRC | 17:13 | |
| sean-k-mooney | stephenfin: we should not set it if its not supported | 17:16 |
| *** ociuhandu_ has joined #openstack-nova | 17:16 | |
| stephenfin | OK,so I guess I should pivot that bug to say "this should *not* be set"? | 17:16 |
| sean-k-mooney | yes i think so | 17:17 |
| *** ociuhandu has quit IRC | 17:17 | |
| *** pcaruana has quit IRC | 17:19 | |
| *** mvkr has quit IRC | 17:22 | |
| *** mdbooth_ is now known as mdbooth | 17:24 | |
| *** macza has joined #openstack-nova | 17:27 | |
| -openstackstatus- NOTICE: Any changes failed around 16:30 UTC today with a review comment from Zuul like "ERROR Unable to find playbook" can be safely rechecked; this was an unanticipated side effect of our work to move base job definitions between configuration repositories. | 17:28 | |
| *** sdake has quit IRC | 17:31 | |
| *** macza has quit IRC | 17:32 | |
| *** rpittau has quit IRC | 17:34 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606 | 17:35 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 17:35 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | 17:35 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [Very WIP] Update NUMA XML during live migration https://review.openstack.org/635229 | 17:35 |
| artom | cfriesen, ^^ I know you wanted to play with early code. So it's still very early, but once that top [Very WIP] patch is just WIP it'll be ready for testing - by which I mean, I'll have enough code written to start actually running it myself in my dev env | 17:36 |
| *** sdake has joined #openstack-nova | 17:36 | |
| artom | So it'll most likely still be broken, actually :) | 17:36 |
| artom | My plan is to write some automated tests with a tempest plugin we have, and iterate running those/fixing bugs until the feature works. Then unit tests will get fixed/written. | 17:36 |
| cfriesen | artom: cool. I'm just finishing up some other downstream stuff, but thanks for the heads-up. | 17:38 |
| *** macza has joined #openstack-nova | 17:41 | |
| *** mdbooth has quit IRC | 17:45 | |
| *** macza has quit IRC | 17:45 | |
| *** mdbooth has joined #openstack-nova | 17:45 | |
| mriedem | speaking of gibi's bw provider series, i'm +2 on the bottom 2 patches https://review.openstack.org/#/c/567268/ | 17:47 |
| mriedem | to help keep that moving | 17:47 |
| *** mvkr has joined #openstack-nova | 17:51 | |
| *** jmlowe has joined #openstack-nova | 17:53 | |
| *** yan0s has quit IRC | 17:58 | |
| *** jobewan has joined #openstack-nova | 18:00 | |
| *** owalsh has quit IRC | 18:01 | |
| *** derekh has quit IRC | 18:01 | |
| *** xek_ has joined #openstack-nova | 18:02 | |
| *** _fragatina_ has quit IRC | 18:03 | |
| *** xek has quit IRC | 18:04 | |
| *** owalsh has joined #openstack-nova | 18:06 | |
| artom | cfriesen, yeah, no huge rush, just an FYI | 18:10 |
| *** markvoelker has joined #openstack-nova | 18:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | 18:16 |
| *** tesseract has quit IRC | 18:16 | |
| *** sdake has quit IRC | 18:17 | |
| *** spatel has joined #openstack-nova | 18:20 | |
| *** sdake has joined #openstack-nova | 18:21 | |
| *** _hemna has joined #openstack-nova | 18:22 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Update the PCI passthrough guides https://review.openstack.org/635243 | 18:31 |
| stephenfin | mriedem: You might have some interest in that little doc patch ^ | 18:31 |
| stephenfin | Inspired by stephenfin's struggles getting a PCI environment set up locally again | 18:32 |
| *** jmlowe has quit IRC | 18:35 | |
| *** sridharg has quit IRC | 18:36 | |
| *** TxGirlGeek has joined #openstack-nova | 18:39 | |
| cdent | mriedem, melwitt, jaypipes: Assuming we all still have jobs and openstack is still a thing come the opening of train, I'd like to work on making shared disk a thing. Do we have anything other than effort that is blocking that? | 18:40 |
| *** markvoelker has quit IRC | 18:43 | |
| *** ociuhandu_ has quit IRC | 18:47 | |
| *** wolverineav has joined #openstack-nova | 18:49 | |
| *** jmlowe has joined #openstack-nova | 18:50 | |
| *** tbachman has quit IRC | 18:52 | |
| *** spatel has quit IRC | 18:58 | |
| *** wolverineav has quit IRC | 19:06 | |
| *** dpawlik has joined #openstack-nova | 19:06 | |
| *** wolverineav has joined #openstack-nova | 19:06 | |
| *** wolverineav has quit IRC | 19:07 | |
| *** wolverineav has joined #openstack-nova | 19:07 | |
| mordred | cdent: I think that also assumes that the rule of law still holds somewhat and the seas haven't risen and swallowed us right? | 19:08 |
| mriedem | cdent: unknown unknowns | 19:08 |
| mriedem | i have a devstack-plugin-ceph patch that sets up a shared DISK_GB provider | 19:08 |
| mriedem | but that job needs to be made multi-node to be interesting | 19:08 |
| mriedem | https://review.openstack.org/#/c/586363/ | 19:09 |
| mriedem | plus that existing bug which enumerates some known issues and the ptg etherpad | 19:09 |
| mriedem | the todo from the ptg was write up a spec with the known issues and how we deal with those so we have a clear picture | 19:09 |
| mriedem | then the rest i guess we find out from integration testing | 19:09 |
| mriedem | cdent: assuming the vmware case is something like multiple vcenters sharing the same datastore? | 19:11 |
| mriedem | or maybe that's already supported albeit poorly in nova | 19:11 |
| cdent | mriedem: that's one. the other is N>1 datastores in the same vcenter | 19:12 |
| cdent | shared can work there too | 19:12 |
| cdent | https://github.com/cdent/placement-disk-models | 19:12 |
| cdent | or a mix of both | 19:12 |
| cdent | the main problem facing vcenters right now is the N>1 situation where it appears like there is a larger free slice than there actually is | 19:13 |
| cdent | right now max_unit is manipulated to cover that, but it is tetchy | 19:13 |
| cdent | mordred: you make a good point. I should have forewarned that I'm unable to enumerate all risks, and past performance is not an indicator | 19:15 |
| mordred | cdent: fair | 19:15 |
| *** jobewan has quit IRC | 19:16 | |
| openstackgerrit | sean mooney proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | 19:26 |
| *** moshele has joined #openstack-nova | 19:26 | |
| mriedem | need another stable core for https://review.openstack.org/#/c/633807/ | 19:28 |
| *** wolverineav has quit IRC | 19:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | 19:39 |
| *** wolverineav has joined #openstack-nova | 19:39 | |
| *** markvoelker has joined #openstack-nova | 19:40 | |
| *** wolverineav has quit IRC | 19:41 | |
| *** wolverineav has joined #openstack-nova | 19:41 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 19:43 |
| sean-k-mooney | mriedem: thanks for adressing the remaining nits. i dont mind respinning for things like that but docs are not really my strong suit. | 19:45 |
| openstackgerrit | sean mooney proposed openstack/nova master: cleanup *.pyc files in docs tox envs https://review.openstack.org/635210 | 19:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix link to flavor extra specs docs https://review.openstack.org/635252 | 19:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix link to flavor extra specs docs https://review.openstack.org/635252 | 19:49 |
| *** jobewan has joined #openstack-nova | 19:50 | |
| openstackgerrit | sean mooney proposed openstack/nova stable/ocata: PCI: do not force remove allocated devices https://review.openstack.org/635075 | 19:59 |
| *** erlon__ has quit IRC | 20:03 | |
| *** wolverineav has quit IRC | 20:04 | |
| *** dpawlik has quit IRC | 20:05 | |
| *** wolverineav has joined #openstack-nova | 20:06 | |
| *** cdent has quit IRC | 20:06 | |
| *** ccamacho has quit IRC | 20:08 | |
| *** wolverineav has quit IRC | 20:10 | |
| *** wolverineav has joined #openstack-nova | 20:11 | |
| *** markvoelker has quit IRC | 20:12 | |
| *** sdake has quit IRC | 20:13 | |
| *** jmlowe has quit IRC | 20:13 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 20:14 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | 20:14 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Update NUMA XML during live migration https://review.openstack.org/635229 | 20:14 |
| *** wolverineav has quit IRC | 20:15 | |
| artom | OK, that's "done". Now to automate some tests. | 20:18 |
| sean-k-mooney | artom: done as in works? | 20:19 |
| artom | sean-k-mooney, no idea :) But I'm at the point there the XML on the dest should be updated. So I can start writing tests that assert stuff about it | 20:19 |
| sean-k-mooney | im planning to pull it down in tommorow anyway but i can try it out later if you think it will work | 20:20 |
| artom | It's an MVP - claims aren't cleaned up where they should be, no rollback handling, etc etc | 20:20 |
| artom | sean-k-mooney, unlikely, I haven't run it myself yet | 20:20 |
| artom | (Unless you count the gate) | 20:20 |
| sean-k-mooney | well it wont hurt to try. ill spin it up on my ci cloud in the backgound and take a look | 20:21 |
| artom | I fully expect it to blow up immediately :D | 20:21 |
| sean-k-mooney | well thats what devstack vms are for | 20:22 |
| *** dpawlik has joined #openstack-nova | 20:22 | |
| *** sdake has joined #openstack-nova | 20:24 | |
| *** dpawlik has quit IRC | 20:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: mention description field in user flavors docs https://review.openstack.org/635263 | 20:29 |
| *** dtantsur is now known as dtantsur|afk | 20:39 | |
| *** panda is now known as panda|off | 20:41 | |
| cfriesen | stephenfin: you around? | 20:41 |
| *** awaugama has quit IRC | 20:42 | |
| sean-k-mooney | stephenfin: he normally finishes about 2 hours before now | 20:43 |
| cfriesen | sean-k-mooney: mriedem: you guys might know this too...we expect both KVM-based and tcg-based qemu to report a hypervisor type of "QEMU", right? | 20:43 |
| sean-k-mooney | yes | 20:43 |
| sean-k-mooney | kvm is just a software/kernel accleration for qemu so it does not change the hypervisor type if used | 20:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | 20:45 |
| cfriesen | I think there's a bug in stephenfin's "fail live migration if instance has numa topologies" commit then. https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L166 | 20:45 |
| sean-k-mooney | similarly if you were to use the tcg multi thread backend "which we dont support yet" it would still be qemu | 20:45 |
| sean-k-mooney | hum maybe lets see if that is the same hypervior type that is in the hyperviors api | 20:46 |
| sean-k-mooney | so that is refering to https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L69 | 20:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set bash xtrace and errexit globally in nova/tests/live_migration/hooks/* https://review.openstack.org/635291 | 20:48 |
| *** wolverineav has joined #openstack-nova | 20:50 | |
| *** xek__ has joined #openstack-nova | 20:50 | |
| sean-k-mooney | so the fact its not a HVTypeField is not promissing but it proably should be https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L379 | 20:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.openstack.org/635308 | 20:51 |
| *** xek_ has quit IRC | 20:52 | |
| sean-k-mooney | cfriesen: so ya when virt tipe is set to kvm it is still qemu i just check on a local devstack. | 20:53 |
| cfriesen | sean-k-mooney: agreed, that's what I was thinking. QEMU rather than KVM | 20:53 |
| *** wolverineav has quit IRC | 20:54 | |
| cfriesen | the tricky bit is that I think qemu with TCG doesn't support numa stuff | 20:54 |
| sean-k-mooney | it does | 20:55 |
| sean-k-mooney | it just does not support per cpu pinning | 20:55 |
| sean-k-mooney | you can create numa nodes and use hugepages | 20:55 |
| cfriesen | ah, okay. | 20:55 |
| cfriesen | should be all right then | 20:55 |
| sean-k-mooney | but nova's implematnion does not work due to the per cpu pinning it adds on top | 20:55 |
| sean-k-mooney | the mttcg backend (multi thread TCG) remvoes the cpu pinning limitation too | 20:56 |
| sean-k-mooney | libvirt will have support for that soon | 20:56 |
| *** sdake has quit IRC | 20:57 | |
| *** sdake has joined #openstack-nova | 20:59 | |
| cfriesen | I'll propose a fix, see what stephen has to say tomorrow. | 21:00 |
| sean-k-mooney | cfriesen: ya looking at the compute node object in the db it does not have the virt type | 21:00 |
| sean-k-mooney | so i guess just update it to qemu | 21:01 |
| *** _hemna has quit IRC | 21:01 | |
| sean-k-mooney | at the moment numa stuff wont work with qemu via nova so its fine that this applies to both | 21:01 |
| sean-k-mooney | if the instance has a numa toplogy and we are migrating it it means it was spawned on a kvm host | 21:02 |
| *** jmlowe has joined #openstack-nova | 21:06 | |
| *** wolverineav has joined #openstack-nova | 21:06 | |
| sean-k-mooney | artom: fyi this is the most imporant comment out of the one i just left on the review https://review.openstack.org/#/c/634606/9/nova/compute/manager.py@6011 | 21:07 |
| artom | sean-k-mooney, that explains so much! | 21:07 |
| artom | I hadn't rebased locally, line numbers in CI output didn't match, and _get_resource_tracker() was clearly present | 21:08 |
| sean-k-mooney | it broke the sriov migrtaion series too | 21:08 |
| artom | Thanks! | 21:08 |
| sean-k-mooney | i fixed it in that yesterday so when i saw the fuction and the filing ci it clicked :) | 21:08 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix port dns_name reset https://review.openstack.org/633807 | 21:08 |
| openstackgerrit | Merged openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | 21:09 |
| artom | Well, CI was going to fail regardless, but I was hoping it'd fail less | 21:09 |
| *** markvoelker has joined #openstack-nova | 21:09 | |
| *** slaweq has joined #openstack-nova | 21:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: warn about changing/unsetting AZ name with instances https://review.openstack.org/635315 | 21:15 |
| *** ociuhandu has joined #openstack-nova | 21:16 | |
| *** xek__ has quit IRC | 21:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: mention policy defaults for aggregates https://review.openstack.org/635317 | 21:18 |
| *** tbachman has joined #openstack-nova | 21:19 | |
| *** moshele has quit IRC | 21:21 | |
| *** sdake has quit IRC | 21:23 | |
| *** tbachman has quit IRC | 21:24 | |
| *** tbachman has joined #openstack-nova | 21:26 | |
| *** wolverineav has quit IRC | 21:27 | |
| *** wolverineav has joined #openstack-nova | 21:28 | |
| *** wolverineav has quit IRC | 21:32 | |
| *** artom has quit IRC | 21:34 | |
| *** _fragatina has joined #openstack-nova | 21:36 | |
| *** ociuhandu has quit IRC | 21:40 | |
| *** markvoelker has quit IRC | 21:42 | |
| mriedem | cfriesen: jackding: https://review.openstack.org/#/c/603844/ | 21:48 |
| mriedem | i like this approach better, but the patch needs work | 21:48 |
| mriedem | and i think we probably don't want to mess with instances whose task_state is not None | 21:49 |
| mriedem | also funny that i was looking at a very similar thing in something i was writing yesterday for cross-cell resize https://review.openstack.org/#/c/635080/1/nova/compute/manager.py@5029 | 21:50 |
| *** takashin has joined #openstack-nova | 21:50 | |
| *** wolverineav has joined #openstack-nova | 21:51 | |
| jackding | mriedem: thanks. Yeh rollback can be messy. | 21:55 |
| *** tbachman_ has joined #openstack-nova | 21:55 | |
| *** slaweq has quit IRC | 21:55 | |
| *** tbachman has quit IRC | 21:56 | |
| *** tbachman_ is now known as tbachman | 21:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343 | 22:15 |
| openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibility https://review.openstack.org/635220 | 22:18 |
| *** TxGirlGeek has quit IRC | 22:34 | |
| openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibility https://review.openstack.org/635220 | 22:36 |
| *** agopi is now known as agopi|brb | 22:36 | |
| *** TxGirlGeek has joined #openstack-nova | 22:36 | |
| *** alex_xu has quit IRC | 22:38 | |
| *** sdake has joined #openstack-nova | 22:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: De-cruftify the finish_resize methods https://review.openstack.org/635349 | 22:39 |
| *** markvoelker has joined #openstack-nova | 22:40 | |
| *** agopi|brb has quit IRC | 22:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use :oslo-config: role in hypervisor-kvm doc https://review.openstack.org/634798 | 22:42 |
| *** kevko has joined #openstack-nova | 22:42 | |
| *** mchlumsky has quit IRC | 22:50 | |
| hogepodge | Hi, someone just asked if there's a way to explicitly disable live migrations, and after looking at the configuration docs I can see why they're stumped. Anyone have some info on how to do that? | 22:50 |
| *** BjoernT has quit IRC | 22:50 | |
| sean-k-mooney | there is a way to do it yes ill have to look it up | 22:50 |
| *** kevko has quit IRC | 22:51 | |
| sean-k-mooney | hogepodge: it is admin only thing so nomally you dont have to expcltly disable it | 22:51 |
| *** tkajinam has joined #openstack-nova | 22:53 | |
| sean-k-mooney | hogepodge: you might have to do it via the polcy.json | 22:53 |
| hogepodge | ok, thanks. I thought that might be the case. I asked for more context | 22:54 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | 22:54 |
| sean-k-mooney | i think the way this is normally done is to block the api request using the policy.json | 22:54 |
| sean-k-mooney | dansmith: do you recall another way to disable live migrations? | 22:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete the obj_as_admin context manager https://review.openstack.org/635351 | 22:55 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/policy.html | 22:55 |
| mriedem | os_compute_api:os-migrate-server:migrate_live | 22:55 |
| mriedem | change that to ! | 22:56 |
| mriedem | to disable it for everyone | 22:56 |
| mriedem | hogepodge: ^ | 22:56 |
| mriedem | oh hey look legacy-grenade-dsvm-neutron-multinode-live-migration is fixed | 22:58 |
| mriedem | https://review.openstack.org/#/c/634962/ | 22:58 |
| mriedem | http://logs.openstack.org/62/634962/5/check/legacy-grenade-dsvm-neutron-multinode-live-migration/982e90b/ | 22:58 |
| *** TxGirlGeek has quit IRC | 22:59 | |
| *** eharney has quit IRC | 22:59 | |
| *** agopi|brb has joined #openstack-nova | 23:01 | |
| hogepodge | mriedem: sean-k-mooney: thanks | 23:01 |
| sean-k-mooney | mriedem: so is that related to the block migration issue where it was complaing it was not on shared shared storage | 23:03 |
| sean-k-mooney | ah it is | 23:03 |
| sean-k-mooney | i was looking for https://bugs.launchpad.net/nova/+bug/1813216 yesterday | 23:03 |
| openstack | Launchpad bug 1813216 in OpenStack Compute (nova) "legacy-grenade-dsvm-neutron-multinode-live-migration failing with "is not on shared storage: Shared storage live-migration requires either shared storage or boot-from-volume with no local disks." since Jan 21" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 23:03 |
| *** agopi|brb is now known as agopi | 23:04 | |
| mriedem | yeah nova-compute during the ceph run didn't have the rbd config in it | 23:05 |
| sean-k-mooney | mriedem: its not really a block migration if you are using the RBD iamge backend | 23:05 |
| sean-k-mooney | its not a bfv instance either but when using RBD it really is a shared filesystem. | 23:07 |
| sean-k-mooney | do we run the block migration tests on any multinode job without ceph/nfs | 23:08 |
| mriedem | yes | 23:08 |
| mriedem | well, i think so, | 23:08 |
| mriedem | neutron multinode or whatever | 23:08 |
| *** ttsiouts has joined #openstack-nova | 23:08 | |
| mriedem | http://logs.openstack.org/44/603844/19/check/tempest-multinode-full/698a95c/job-output.txt.gz#_2019-02-05_22_28_06_654011 | 23:09 |
| sean-k-mooney | ah this one https://github.com/openstack/nova/blob/master/.zuul.yaml#L252-L254 | 23:10 |
| mriedem | we don't have anything that tests the crazy environment lyarwood keeps trying to fix which is rbd shared storage for the root disk but local storage for the instance files | 23:10 |
| sean-k-mooney | ok i was wondering if that came in form one of the templates | 23:10 |
| mriedem | nova, for the most part, assumes that if you're using rbd you're shared everywhere | 23:10 |
| mriedem | which apparently isn't true for some people | 23:10 |
| sean-k-mooney | i dont understand the "local storage for the instance files" bit | 23:11 |
| sean-k-mooney | i can ask lyarwood | 23:11 |
| mriedem | the stuff under $instances_path | 23:11 |
| mriedem | console logs, the image, config drive (i think) | 23:11 |
| mriedem | etc | 23:11 |
| sean-k-mooney | oh the libivt logs and stuff | 23:11 |
| mriedem | yes this crazy thing https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup | 23:12 |
| sean-k-mooney | i assumed if you set then image backend to ceph those where on ceph too well the config drive and swap at least | 23:12 |
| mriedem | that's what the libvirt driver assumes as well in some places | 23:13 |
| mriedem | but the rbd image backend just controls the disks, not the other files associated with the instance on the host | 23:13 |
| *** markvoelker has quit IRC | 23:13 | |
| sean-k-mooney | that explain some of my issue on my old newton cloud... | 23:14 |
| mriedem | it's very fun | 23:14 |
| sean-k-mooney | well the more you know | 23:14 |
| mriedem | could probably add that to the pile-o-problems for cdent to work on shared storage providers... | 23:14 |
| sean-k-mooney | i know the file that is created when you suspend an instace was written to the compute node but ya | 23:15 |
| sean-k-mooney | i wonder how many people over look that as i did | 23:15 |
| sean-k-mooney | oh i was talking to lyarwood about a multi attach live migration bug earlier in the week | 23:16 |
| mriedem | well, we don't really help anyone with no mention of this in the docs really, or config options for that matter | 23:16 |
| mriedem | we should probably have a "things to consider if you plan to use shared storage" section in the admin docs | 23:17 |
| sean-k-mooney | assuming we dont already have a tempest senario test i think im going to write one and add it to the tempest-full-multinode job | 23:17 |
| mriedem | there are no tempest tests for live migration + volume multiattach that i'm aware of | 23:17 |
| mriedem | there are for resize though | 23:18 |
| sean-k-mooney | mriedem: lyarwood was looking at a posibly race. i dont have the context to had but i was thinking a simple test that boots 2 vms with the same multi attach volume and migrate one of the vms back and forth | 23:19 |
| *** TxGirlGeek has joined #openstack-nova | 23:19 | |
| sean-k-mooney | i think it was related to concurent update of the attachnets | 23:21 |
| sean-k-mooney | mriedem: oh lyarwood filled an upstream bug https://bugs.launchpad.net/nova/+bug/1814245 | 23:21 |
| openstack | Launchpad bug 1814245 in OpenStack Compute (nova) "_disconnect_volume incorrectly called for multiattach volumes during post_live_migration" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood) | 23:21 |
| *** mlavalle has quit IRC | 23:22 | |
| mriedem | so it disconnects the volume from the other server that wasn't live migrated | 23:24 |
| mriedem | if both servers start on the same source host | 23:24 |
| mriedem | yeah? | 23:24 |
| sean-k-mooney | ya | 23:24 |
| *** awalende has joined #openstack-nova | 23:25 | |
| mriedem | i guess that bug says https://review.openstack.org/#/c/551302/ fixes it, | 23:25 |
| mriedem | but ^ needs to be updated | 23:25 |
| mriedem | sean-k-mooney: i don't know that a tempest test would catch this unless that test also ssh's into the guest and tries to verify the volume is still connected on the source host | 23:27 |
| mriedem | and and connected to the live migrated server on the dest host | 23:27 |
| sean-k-mooney | mriedem: yes i planned to ssh in touch a file migrate and check i could read the file on both vms | 23:27 |
| mriedem | this is similar to https://review.openstack.org/#/c/548356/ | 23:28 |
| mriedem | maybe you want to work on cleaning up ^ first | 23:28 |
| mriedem | i'm sure steve is long gone by now | 23:28 |
| *** _fragatina has quit IRC | 23:28 | |
| mriedem | he was only on loan from oracle until they got multiattach support in queens | 23:28 |
| *** awalende has quit IRC | 23:29 | |
| sean-k-mooney | am i can take a look. i have not worked with tempest in a while so i kind of wanted to use this to get familar with it again | 23:29 |
| *** wolverineav has quit IRC | 23:29 | |
| *** wolverineav has joined #openstack-nova | 23:30 | |
| sean-k-mooney | if that is isshing into the vm it really should be a senario test not an api test... but that is a different issue | 23:30 |
| sean-k-mooney | the api tests "should" be able to run with the nova fake or libvirt fake driver | 23:31 |
| *** wolverineav has quit IRC | 23:34 | |
| openstackgerrit | Merged openstack/nova master: cleanup *.pyc files in docs tox envs https://review.openstack.org/635210 | 23:42 |
| *** wolverineav has joined #openstack-nova | 23:45 | |
| *** itlinux has quit IRC | 23:48 | |
| *** imacdonn has quit IRC | 23:49 | |
| *** imacdonn has joined #openstack-nova | 23:49 | |
| *** mshaikh99_ has joined #openstack-nova | 23:50 | |
| mshaikh99_ | I am using OpenStack Queens Release and running Ubuntu 16.04 VM on it, The disk IO seems to be very slow with default cache setting as none for Qemu based virt type | 23:51 |
| mshaikh99_ | # time dd if=/dev/zero of=/tmp/test1 bs=20M count=100 conv=fsync;rm /tmp/test1 100+0 records in 100+0 records out 2097152000 bytes (2.1 GB) copied, 296.352 s, 7.1 MB/s real 4m56.559s user 0m0.100s sys 4m19.716s | 23:51 |
| mshaikh99_ | Where is the compute node has the IO as: root@compute1:~# time dd if=/dev/zero of=/tmp/test1 bs=20M count=100 conv=fsync;rm /tmp/test1 100+0 records in 100+0 records out 2097152000 bytes (2.1 GB, 2.0 GiB) copied, 20.724 s, 101 MB/s | 23:51 |
| mshaikh99_ | Based on the openstack forum link, I tried to chagne the default cache from none to writeback as suggested https://ask.openstack.org/en/question/6800/qemu-poor-disk-performance/ but it does not change and after the VM hardreboot I still see it as none | 23:52 |
| mshaikh99_ | http://paste.openstack.org/show/744655/ | 23:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change live_migration_wait_for_vif_plug=True by default https://review.openstack.org/635360 | 23:53 |
| mshaikh99_ | which file and which node? | 23:54 |
| *** mshaikh99_ has quit IRC | 23:55 | |
| sean-k-mooney | mshaikh99_: did you do the hard reboot after restarting nova compute | 23:56 |
| *** mriedem has quit IRC | 23:56 | |
| *** mshaikh99 has joined #openstack-nova | 23:56 | |
| mshaikh99 | Hi | 23:57 |
| mshaikh99 | Is there an update on the question I asked | 23:57 |
| sean-k-mooney | mshaikh99: if the qcow file is not preaccloated that could be part of the problem | 23:57 |
| sean-k-mooney | mshaikh99: https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.preallocate_images | 23:58 |
| mshaikh99 | ok | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!