| *** mmethot has quit IRC | 00:00 | |
| *** mmethot has joined #openstack-nova | 00:00 | |
| *** mmethot has quit IRC | 00:04 | |
| *** macza has quit IRC | 00:05 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** ade_lee has quit IRC | 00:16 | |
| *** breton has joined #openstack-nova | 00:16 | |
| *** ade_lee has joined #openstack-nova | 00:16 | |
| *** rcernin has quit IRC | 00:18 | |
| *** rcernin has joined #openstack-nova | 00:19 | |
| *** markvoelker has quit IRC | 00:20 | |
| *** erlon has quit IRC | 00:29 | |
| *** dklyle has quit IRC | 00:32 | |
| *** macza has joined #openstack-nova | 00:33 | |
| *** macza has quit IRC | 00:34 | |
| *** efried_2dmtg has quit IRC | 00:35 | |
| *** macza has joined #openstack-nova | 00:37 | |
| *** dklyle has joined #openstack-nova | 00:48 | |
| *** wolverineav has quit IRC | 00:50 | |
| *** tstrul has joined #openstack-nova | 00:52 | |
| *** TxGirlGeek has joined #openstack-nova | 00:54 | |
| *** tstrul has quit IRC | 00:55 | |
| *** tstrul has joined #openstack-nova | 00:55 | |
| *** erlon has joined #openstack-nova | 00:56 | |
| *** khomesh|gone is now known as khomesh | 00:57 | |
| *** tstrul has quit IRC | 00:58 | |
| *** tstrul has joined #openstack-nova | 00:59 | |
| *** tstrul has quit IRC | 00:59 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 01:03 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 01:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 01:03 |
| *** wolverineav has joined #openstack-nova | 01:04 | |
| *** whoami-rajat has joined #openstack-nova | 01:06 | |
| *** _fragatina has quit IRC | 01:08 | |
| *** gyee has quit IRC | 01:10 | |
| *** dklyle has quit IRC | 01:10 | |
| *** tbachman has joined #openstack-nova | 01:13 | |
| *** awalende has joined #openstack-nova | 01:15 | |
| *** awalende has quit IRC | 01:19 | |
| *** _fragatina has joined #openstack-nova | 01:28 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Raise 403 instead of 500 error from attach volume API https://review.openstack.org/632904 | 01:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add configuration of maximum disk devices to attach https://review.openstack.org/616777 | 01:29 |
| *** TxGirlGeek has quit IRC | 01:30 | |
| *** moshele has joined #openstack-nova | 01:33 | |
| *** _fragatina has quit IRC | 01:37 | |
| *** moshele has quit IRC | 01:40 | |
| *** moshele has joined #openstack-nova | 01:41 | |
| *** ileixe has joined #openstack-nova | 01:51 | |
| *** lbragstad has quit IRC | 01:52 | |
| *** cfriesen has quit IRC | 01:55 | |
| *** wolverineav has quit IRC | 01:56 | |
| *** igordc has quit IRC | 01:57 | |
| *** wolverineav has joined #openstack-nova | 02:05 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 02:08 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 02:08 |
| *** sapd1 has joined #openstack-nova | 02:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 02:08 |
| *** khomesh is now known as khomesh|afk | 02:08 | |
| *** khomesh|afk is now known as khomesh | 02:10 | |
| *** wolverineav has quit IRC | 02:11 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** moshele has quit IRC | 02:11 | |
| *** slaweq has quit IRC | 02:15 | |
| *** mmethot has joined #openstack-nova | 02:16 | |
| *** bhagyashris has joined #openstack-nova | 02:19 | |
| *** markvoelker has joined #openstack-nova | 02:25 | |
| *** hongbin has joined #openstack-nova | 02:25 | |
| *** lbragstad has joined #openstack-nova | 02:35 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Make quota options deprecated https://review.openstack.org/633102 | 02:44 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 02:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 02:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 02:46 |
| *** wolverineav has joined #openstack-nova | 02:47 | |
| *** artom has quit IRC | 02:50 | |
| *** markvoelker has quit IRC | 02:55 | |
| *** ebbex has quit IRC | 02:55 | |
| *** bhagyashris has quit IRC | 02:57 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| *** sapd1 has quit IRC | 03:04 | |
| *** udesale has joined #openstack-nova | 03:06 | |
| *** khomesh is now known as khomesh|bfst | 03:09 | |
| openstackgerrit | Zhang Hua proposed openstack/nova stable/pike: Refix disk size during live migration with disk over-commit https://review.openstack.org/631372 | 03:09 |
| openstackgerrit | Zhang Hua proposed openstack/nova stable/ocata: Fix disk size during live migration with disk over-commit https://review.openstack.org/530744 | 03:13 |
| *** whoami-rajat has quit IRC | 03:15 | |
| *** hongbin_ has joined #openstack-nova | 03:19 | |
| *** sapd1 has joined #openstack-nova | 03:21 | |
| *** hongbin has quit IRC | 03:21 | |
| openstackgerrit | Zhang Hua proposed openstack/nova stable/ocata: Refix disk size during live migration with disk over-commit https://review.openstack.org/631376 | 03:24 |
| openstackgerrit | Zhang Hua proposed openstack/nova stable/pike: Fix disk size during live migration with disk over-commit https://review.openstack.org/530743 | 03:25 |
| *** khomesh|bfst is now known as khomesh | 03:31 | |
| *** dklyle has joined #openstack-nova | 03:40 | |
| *** whoami-rajat has joined #openstack-nova | 03:45 | |
| *** itlinux has joined #openstack-nova | 03:47 | |
| *** markvoelker has joined #openstack-nova | 03:52 | |
| *** dklyle has quit IRC | 04:02 | |
| *** bhagyashris has joined #openstack-nova | 04:06 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add minimum value in maximum_instance_delete_attempts https://review.openstack.org/633085 | 04:15 |
| *** khomesh is now known as khomesh|afk | 04:16 | |
| *** slaweq has quit IRC | 04:16 | |
| *** khomesh|afk is now known as khomesh | 04:18 | |
| *** markvoelker has quit IRC | 04:25 | |
| *** ileixe has quit IRC | 04:26 | |
| *** sapd1 has quit IRC | 04:32 | |
| *** wolverineav has quit IRC | 04:43 | |
| *** hongbin_ has quit IRC | 04:43 | |
| *** sapd1 has joined #openstack-nova | 04:45 | |
| *** wolverineav has joined #openstack-nova | 04:46 | |
| *** wolverineav has quit IRC | 04:50 | |
| *** khomesh is now known as khomesh|afk | 04:53 | |
| *** wolverineav has joined #openstack-nova | 04:54 | |
| *** macza has quit IRC | 04:55 | |
| *** imacdonn has joined #openstack-nova | 04:57 | |
| *** udesale has quit IRC | 05:01 | |
| *** udesale has joined #openstack-nova | 05:04 | |
| *** ileixe has joined #openstack-nova | 05:08 | |
| *** sapd1 has quit IRC | 05:08 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** khomesh|afk is now known as khomesh | 05:12 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 05:14 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 05:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 05:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 05:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 05:16 |
| *** slaweq has quit IRC | 05:16 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 05:16 |
| *** markvoelker has joined #openstack-nova | 05:22 | |
| *** _fragatina has joined #openstack-nova | 05:27 | |
| *** macza has joined #openstack-nova | 05:39 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 05:40 |
| *** spsurya has joined #openstack-nova | 05:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a warning for max_concurrent_live_migrations https://review.openstack.org/632240 | 05:43 |
| *** udesale has quit IRC | 05:45 | |
| *** sapd1 has joined #openstack-nova | 05:45 | |
| *** udesale has joined #openstack-nova | 05:46 | |
| *** wolverineav has quit IRC | 05:54 | |
| *** markvoelker has quit IRC | 05:54 | |
| *** wolverineav has joined #openstack-nova | 05:55 | |
| *** wolverineav has quit IRC | 05:59 | |
| *** wolverineav has joined #openstack-nova | 06:01 | |
| *** wolverineav has quit IRC | 06:06 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** slaweq has quit IRC | 06:15 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unused quota options https://review.openstack.org/633102 | 06:17 |
| *** macza_ has joined #openstack-nova | 06:24 | |
| *** macza has quit IRC | 06:28 | |
| *** macza_ has quit IRC | 06:28 | |
| *** wolverineav has joined #openstack-nova | 06:35 | |
| *** takashin has left #openstack-nova | 06:45 | |
| *** sridharg has joined #openstack-nova | 07:11 | |
| *** Luzi has joined #openstack-nova | 07:12 | |
| *** ociuhandu has joined #openstack-nova | 07:20 | |
| *** ociuhandu_ has quit IRC | 07:20 | |
| *** Luzi has quit IRC | 07:31 | |
| *** ebbex has joined #openstack-nova | 07:35 | |
| *** Luzi has joined #openstack-nova | 07:45 | |
| *** lbragstad has quit IRC | 07:45 | |
| *** igordc has joined #openstack-nova | 07:48 | |
| *** wolverineav has quit IRC | 07:51 | |
| *** markvoelker has joined #openstack-nova | 07:52 | |
| *** slaweq has joined #openstack-nova | 08:00 | |
| *** panda|off is now known as panda | 08:04 | |
| *** moshele has joined #openstack-nova | 08:06 | |
| *** awalende has joined #openstack-nova | 08:07 | |
| *** igordc has quit IRC | 08:08 | |
| *** ralonsoh has joined #openstack-nova | 08:09 | |
| *** rpittau has joined #openstack-nova | 08:10 | |
| *** helenaAM has joined #openstack-nova | 08:11 | |
| *** ccamacho has joined #openstack-nova | 08:13 | |
| *** tkajinam has quit IRC | 08:15 | |
| *** sapd1 has quit IRC | 08:22 | |
| *** moshele has quit IRC | 08:23 | |
| *** yan0s has joined #openstack-nova | 08:23 | |
| *** markvoelker has quit IRC | 08:25 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/queens: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620578 | 08:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/pike: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620579 | 08:37 |
| openstackgerrit | Dongcan Ye proposed openstack/nova master: Raise BuildAbortException while updating instance task_state conflict https://review.openstack.org/633160 | 08:37 |
| *** sapd1 has joined #openstack-nova | 08:41 | |
| *** tosky has joined #openstack-nova | 08:49 | |
| *** dklyle has joined #openstack-nova | 08:50 | |
| *** s10 has joined #openstack-nova | 08:50 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167 | 08:54 |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607 | 08:54 |
| *** abhishekk has joined #openstack-nova | 09:07 | |
| *** moshele has joined #openstack-nova | 09:10 | |
| *** _fragatina has quit IRC | 09:18 | |
| *** _fragatina has joined #openstack-nova | 09:18 | |
| *** _fragatina has quit IRC | 09:20 | |
| *** _fragatina has joined #openstack-nova | 09:21 | |
| *** markvoelker has joined #openstack-nova | 09:22 | |
| *** rtjure has quit IRC | 09:24 | |
| *** rtjure has joined #openstack-nova | 09:26 | |
| *** udesale has quit IRC | 09:29 | |
| *** udesale has joined #openstack-nova | 09:30 | |
| *** derekh has joined #openstack-nova | 09:31 | |
| *** erlon has quit IRC | 09:32 | |
| *** moshele has quit IRC | 09:37 | |
| *** ondrejme has joined #openstack-nova | 09:41 | |
| *** _fragatina has quit IRC | 09:47 | |
| *** rpittau has quit IRC | 09:51 | |
| *** rpittau has joined #openstack-nova | 09:53 | |
| *** markvoelker has quit IRC | 09:55 | |
| *** bhagyashris has quit IRC | 09:57 | |
| stephenfin | adrianc: Sweet. I have another old ConnectX-3 NIC ordered, so I should be able to test it myself as soon as that arrives | 10:08 |
| sean-k-mooney | stephenfin: the exra docs for sriov that adrianc was working on? | 10:09 |
| sean-k-mooney | or live migration | 10:09 |
| stephenfin | Live migration | 10:09 |
| stephenfin | Also the docs though, I guess? | 10:09 |
| sean-k-mooney | ah | 10:09 |
| sean-k-mooney | stephenfin: https://review.openstack.org/#/c/627312/ | 10:10 |
| sean-k-mooney | stephenfin: hopefully they will help you set up the new card when it arrives | 10:11 |
| *** s10 has quit IRC | 10:11 | |
| stephenfin | sean-k-mooney++ Very useful indeed | 10:13 |
| *** Dinesh_Bhor has quit IRC | 10:19 | |
| *** erlon has joined #openstack-nova | 10:22 | |
| *** erlon has quit IRC | 10:22 | |
| *** erlon has joined #openstack-nova | 10:23 | |
| *** ioni has joined #openstack-nova | 10:23 | |
| *** erlon has quit IRC | 10:24 | |
| *** khomesh is now known as khomesh|afk | 10:24 | |
| *** erlon has joined #openstack-nova | 10:24 | |
| ioni | hello guys | 10:33 |
| *** erlon_ has joined #openstack-nova | 10:33 | |
| ioni | i have a lot of warnings regarding resources not beeing updated after migraton(i think the migration had an error regarding neutron port allocation) but the instance ended up on a new compute node | 10:34 |
| ioni | https://paste.xinu.at/ecVs8/ | 10:34 |
| ioni | is there a way to sync the used resources ? | 10:34 |
| ioni | i'm running queens at this time | 10:35 |
| *** erlon has quit IRC | 10:36 | |
| openstackgerrit | Kevin Rasmussen proposed openstack/nova master: created AggregateSubnetAvailabilityFilter https://review.openstack.org/633178 | 10:38 |
| *** sapd1 has quit IRC | 10:43 | |
| *** khomesh|afk is now known as khomesh | 10:45 | |
| *** macza has joined #openstack-nova | 10:47 | |
| *** khomesh is now known as khomesh|afk | 10:47 | |
| *** macza_ has joined #openstack-nova | 10:48 | |
| *** macza has quit IRC | 10:51 | |
| *** markvoelker has joined #openstack-nova | 10:52 | |
| *** macza_ has quit IRC | 10:52 | |
| *** gibi has quit IRC | 10:54 | |
| *** gibi has joined #openstack-nova | 10:54 | |
| *** khomesh|afk is now known as khomesh | 10:55 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 11:04 |
| *** abhishekk has quit IRC | 11:07 | |
| *** jaosorior has quit IRC | 11:07 | |
| *** ociuhandu has quit IRC | 11:07 | |
| *** ileixe has quit IRC | 11:19 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.openstack.org/631038 | 11:24 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Split '_get_host_numa_topology' function https://review.openstack.org/631237 | 11:24 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.openstack.org/631053 | 11:24 |
| *** markvoelker has quit IRC | 11:25 | |
| *** tbachman has quit IRC | 11:44 | |
| *** khomesh is now known as khomesh|gone | 11:49 | |
| kashyap | sean-k-mooney: Hi, something seems to be off in your line-break formatting in the LP bug comments (https://bugs.launchpad.net/nova/+bug/1811870) | 11:49 |
| openstack | Launchpad bug 1811870 in OpenStack Compute (nova) "libvirt reporting incorrect value of 4k (small) pages" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 11:49 |
| kashyap | In comment#1, the line breaks in a paragraph seem to come in randomly, which slightly impairs readability. :-) | 11:50 |
| sean-k-mooney | that because for longer comment i type them up somewhere else then copy past and the web form messes up the original formating i had | 11:53 |
| ioni | i found that allocation refresh is not requred on compute nodes greater than pike: https://git.openstack.org/cgit/openstack/nova/commit/?id=c3eb6ea3f6f31ae9473d0d2a4fa3f7c3a590d5f2 | 11:54 |
| sean-k-mooney | things like text formating is very unimportant to me so i rarely if ever check if it messed it up before i leave teh comment | 11:54 |
| ioni | is it safe to run refresh allocation on queens if already have resouces that aren't deallocated after a migration? | 11:55 |
| sean-k-mooney | ioni: you mean the placement refresh | 11:55 |
| ioni | sean-k-mooney, i'm not sure: https://paste.xinu.at/ecVs8/ | 11:56 |
| ioni | i have this warnings | 11:56 |
| sean-k-mooney | non of the placement folks seam to be about at the momment. i would ping cdent or efried later when they come online | 11:58 |
| ioni | i guess is about allocations | 11:58 |
| ioni | sean-k-mooney, ok, i'll wait | 12:00 |
| sean-k-mooney | jaypipes: you might know the answer as to how to correct https://paste.xinu.at/ecVs8/ | 12:01 |
| sean-k-mooney | ioni: jaypipes is logged in to irc but its still early for him | 12:01 |
| ioni | it's fine, i can wait | 12:03 |
| ioni | good thing that you guys changed from debug to warning | 12:03 |
| ioni | i had problems in the past scheduling instances on some hypervisors | 12:03 |
| ioni | but now i know why | 12:03 |
| *** artom has joined #openstack-nova | 12:04 | |
| sean-k-mooney | ioni: if you are sure the instance is not running on the host you might be able to manually clean up old allocation safely via the osc placemnet cli | 12:10 |
| sean-k-mooney | i dont know if there is a way to get nova do do it however | 12:10 |
| ioni | sean-k-mooney, pretty sure is not on that hypervisor. openstack server show it's showing the new one and i can see the libvirt file on the node | 12:11 |
| ioni | the only thing is that the resources weren't deallocated from the old one | 12:12 |
| ioni | that warning | 12:12 |
| ioni | i cannot find where in databases i need to update | 12:12 |
| ioni | i tried to find it in the tables without success | 12:12 |
| sean-k-mooney | ya in which case its probaly safe to manually remove the allocation via the placemnt api | 12:12 |
| sean-k-mooney | i would avoid direct db updates unless it cant be fixed via the api | 12:13 |
| sean-k-mooney | ioni: if you ask in #openstack-placement there maybe someone about who can suggest hot to heal the allocations correctly | 12:13 |
| ioni | ok, thanks | 12:13 |
| sean-k-mooney | ioni: looks like edleafe: is logged on but its seams pretty quite | 12:14 |
| ioni | sean-k-mooney, alright, i have asked in the channel | 12:18 |
| *** cdent has joined #openstack-nova | 12:19 | |
| *** wolverineav has joined #openstack-nova | 12:28 | |
| *** tssurya has joined #openstack-nova | 12:30 | |
| openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.openstack.org/608704 | 12:31 |
| *** wolverineav has quit IRC | 12:32 | |
| openstackgerrit | Merged openstack/nova master: Move interface enabling to privsep. https://review.openstack.org/621528 | 12:32 |
| kashyap | sean-k-mooney: Yeah, FWIW, I do that too, just write the comment in `vim`, and wrap the lines to 72 (or your choice) & then copy / paste. | 12:33 |
| sean-k-mooney | kashyap: my choise would be ~150 | 12:33 |
| kashyap | Hehe | 12:33 |
| sean-k-mooney | i hate the 80 colum limit and i hate passionetly that we test for 79 is pep8 for some reason even when we say it should be 80 | 12:34 |
| stephenfin | sean-k-mooney: That's easily fixed, if you were so inclined | 12:37 |
| sean-k-mooney | ya it should be | 12:39 |
| sean-k-mooney | i think its testing <80 instead of <=80 | 12:39 |
| sean-k-mooney | we dont explcitly set it | 12:39 |
| jangutter | sean-k-mooney: 79 is clearly better because it's a prime number. 80 just has too many factors and it's not a pure power of two either. | 12:41 |
| sean-k-mooney | true but in that case i vote for rounding up not down :) | 12:43 |
| jangutter | sean-k-mooney: 80's possibly a holdover from 4:3 aspect ratio, but it still makes sense for people holding their phone in portrait mode. | 12:44 |
| jangutter | sean-k-mooney: that's actually an argument to go for a 60 column limit. | 12:45 |
| sean-k-mooney | there is also an argument to got to 160 or 190 the fortran uses | 12:45 |
| sean-k-mooney | pep8 package doc example seam to encurate 160 indretly https://pep8.readthedocs.io/en/release-1.7.x/intro.html#configuration | 12:47 |
| jangutter | sean-k-mooney: I just had a fringe idea - what if 79 characters is because there's a secret conspiracy to allow CRLF line endings? | 12:48 |
| sean-k-mooney | they are both non pritable chariters so it does not matter | 12:49 |
| sean-k-mooney | anyway i need to go rebase some things and fix some typos :) | 12:49 |
| jangutter | sean-k-mooney: without nits like these to pick on Fridays, the world would be a lot more boring. Good luck! | 12:50 |
| cdent | the world is unable to avoid this conversation isn't it | 12:51 |
| cdent | I get unhappy when code lines are longer than 50 characters or so. | 12:51 |
| * cdent really likes vertical code | 12:51 | |
| cdent | My standards have completely collapsed since joining the openstack scene | 12:52 |
| jangutter | cdent: I notice you didn't specifically say _coding_ standards. | 12:55 |
| *** whoami-rajat has quit IRC | 12:55 | |
| cdent | jangutter: that's correct | 12:56 |
| sean-k-mooney | cdent: i hate wasting vertical space it almost -2 able in my book | 12:56 |
| cdent | sean-k-mooney I WILL FIGHT YOU OVER THIS :) | 12:56 |
| sean-k-mooney | its not but it severly hurts at leas my readablity of the code | 12:56 |
| sean-k-mooney | cdent: :) | 12:57 |
| cdent | I tend to associated wide code with not extracting methods enough | 12:57 |
| jangutter | cdent: one more level of indirection can't hurt, right? | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix typo https://review.openstack.org/633196 | 12:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix overcommit for NUMA-based instances https://review.openstack.org/633197 | 12:58 |
| cdent | but interestingly it also has a lot to do with readability for me too: if I have to go to the right I get confused. sean-k-mooney if we combined our brains we'd either be able to read nothing or everything, not sure | 12:58 |
| sean-k-mooney | cdent: that can be true but when we have function like post_live_migration_at_destination(...) | 12:58 |
| sean-k-mooney | i can sometimes be hard to call them with out it requreing multiple lines | 12:58 |
| stephenfin | lyarwood: Any chance you could you take a look at those two backports today? | 12:59 |
| jangutter | cdent: I tend to notice something's wrong when the member I'm looking up gets to about 50 characters. | 12:59 |
| sean-k-mooney | cdent: it only becomes annoying to me or hard to read when a function has multiple argumetns and i can nolonger clearly see everything returns and accpes at once | 13:00 |
| sean-k-mooney | if the lines are too short or too long it become an issue but its also an issue if we have lost of indetation | 13:00 |
| sean-k-mooney | for example in conditional within a fucntion within a fuction within a class. | 13:01 |
| sean-k-mooney | in which case the satment may be only 30 letters wide but its wrapped because of the nested ness of the code | 13:02 |
| *** avolkov has joined #openstack-nova | 13:02 | |
| * cdent nods | 13:02 | |
| sean-k-mooney | i think the best evolutionin in modern programming was clang-format | 13:03 |
| jangutter | I've seen code (and yonks ago, written) with indents being 2 spaces. Doing it once makes you forever want 4 or more. | 13:03 |
| sean-k-mooney | it inspired go to creat go formate and decide its a tools proplem to make the code consitent and readable | 13:03 |
| *** _fragatina has joined #openstack-nova | 13:03 | |
| *** _fragatina has quit IRC | 13:04 | |
| sean-k-mooney | jangutter: i think the kernel still has an intend of 8 to discurabe deep nesting | 13:04 |
| *** _fragatina has joined #openstack-nova | 13:04 | |
| jangutter | sean-k-mooney: yep, indents shall be 1 tab and tabs are 8 characters wide like $deity intended. | 13:04 |
| sean-k-mooney | yaml uses indentaion of 2 spaces i think by convention | 13:05 |
| *** tbachman has joined #openstack-nova | 13:11 | |
| *** mriedem has joined #openstack-nova | 13:12 | |
| *** ccamacho has quit IRC | 13:14 | |
| *** cdent has quit IRC | 13:14 | |
| *** tbachman has quit IRC | 13:15 | |
| mdbooth | sean-k-mooney: I think 80 is arbitrary these days, but having a width limit around there does make sense even with very wide monitors, as it allows you to put multiple files next to each other. Most lines are not that long, so if you allow the occasional one to be that long you end up with truncation when viewing multiple files. Basically: imposing a (arbitrary) limit makes the code denser on screen, which is good no matter how big | 13:17 |
| mdbooth | your monitor is. | 13:17 |
| mdbooth | My 2c. | 13:17 |
| sean-k-mooney | mdbooth: well im not saying we sure raise it even if i personally would it jsut annoys me that wehn reviewing in gerit or using an ide that set the 80 colum marker that the ci is actully enforice 79 | 13:18 |
| sean-k-mooney | you look at it either locally or in gerrit and it looks like it does not cross the virtical line that is rendered but actully its still rejected | 13:20 |
| mdbooth | sean-k-mooney: I have vim set to show modifications in the margin, so my terminals all have to be 82 chars anyway :) I don't care what the actual value is, tbh, as long as it exists and is consistent. | 13:20 |
| sean-k-mooney | ya its why i have never bother to "fix" it | 13:20 |
| mdbooth | Ok, yeah, I can see that would be annoying if all the tools default to 80. | 13:21 |
| lyarwood | stephenfin: ack will do | 13:21 |
| *** cdent has joined #openstack-nova | 13:21 | |
| *** tbachman has joined #openstack-nova | 13:21 | |
| *** awalende has quit IRC | 13:26 | |
| *** awalende has joined #openstack-nova | 13:27 | |
| *** ccamacho has joined #openstack-nova | 13:29 | |
| *** rcernin has quit IRC | 13:30 | |
| *** sridharg has quit IRC | 13:31 | |
| *** awalende has quit IRC | 13:31 | |
| stephenfin | TIL the 79 character default is in flake8, not tox.ini/setup.cfg | 13:39 |
| stephenfin | sean-k-mooney: Fancy looking at https://review.openstack.org/#/c/631053/ and predecessors again today/early next week? | 13:40 |
| jangutter | And 79 is actually codified in pep8 itself https://www.python.org/dev/peps/pep-0008/#maximum-line-length | 13:40 |
| sean-k-mooney | sure i was just looking at your chages for requiring the plugin atribute for os-vif and the noop plugin | 13:40 |
| sean-k-mooney | jangutter: ya they choose 79 so that if you have emacs in whitespace-newline-mode where it add a $ to mark the end of the line it wont wrap | 13:42 |
| jangutter | think if we type 79 enough, 80 is going to look weird to sean-k-mooney? | 13:42 |
| sean-k-mooney | jangutter: but all modern tools use 80 as teh defulat so its annoying | 13:43 |
| *** eharney has joined #openstack-nova | 13:44 | |
| *** jaypipes is now known as leakypipes | 13:50 | |
| lyarwood | stephenfin: https://review.openstack.org/#/c/633197/1/nova/objects/numa.py - stupid o.vo question in there if you have a second, I assume it's fine just wanted to check. | 13:52 |
| * stephenfin clicks | 13:52 | |
| sean-k-mooney | lyarwood: it should not no | 13:53 |
| sean-k-mooney | lyarwood: the function signitru is part of the class deffinion not the serialised object | 13:54 |
| stephenfin | lyarwood: Yeah, what Sean says. The scheduler, for example, will use its own version of the object | 13:55 |
| lyarwood | sean-k-mooney: right, wasn't sure so it was worth asking. Thanks. | 13:55 |
| stephenfin | *definition | 13:55 |
| sean-k-mooney | lyarwood: its worth asking but no we are fine | 13:55 |
| sean-k-mooney | this would matter for signiture of rpc methods where we are invokeing a remote method but not in this case | 13:58 |
| *** _fragatina has quit IRC | 13:58 | |
| stephenfin | lyarwood: I want tooling to automatically add (and remove, if abandoned) patches submitted to internal Gerrit to their BZ | 13:59 |
| stephenfin | ...and reject the patch if there is no BZ linked | 13:59 |
| sean-k-mooney | stephenfin: sound like a nice proejct. to discuss downstream ... | 13:59 |
| *** mlavalle has joined #openstack-nova | 13:59 | |
| stephenfin | Goddddd damn it | 13:59 |
| stephenfin | Good thing I don't work in finance | 14:00 |
| sean-k-mooney | i mean if someone upstream whats to write that for use tye are wellcome. im sure jangutter has plenty of time to do it:) | 14:00 |
| *** mmethot has quit IRC | 14:02 | |
| jangutter | sean-k-mooney: if someone writes that, EVERYONE's going to pile on stuff to the weirdest BZ's. | 14:03 |
| *** mmethot has joined #openstack-nova | 14:03 | |
| jangutter | stephenfin, sean-k-mooney: the OpenContrail project has something like that. The unintended consequence is that BZ quality goes down :-( | 14:04 |
| * cdent hires stephenfin as his financial adviser | 14:04 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.openstack.org/633212 | 14:05 |
| mriedem | mdbooth: i think you're familiar with _error_out_instance_on_exception - ^ is something that's always bugged me | 14:05 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Don't age swap backing files in the image cache by default https://review.openstack.org/633213 | 14:05 |
| openstackgerrit | Merged openstack/nova master: Kill @safe_connect in _get_provider_traits https://review.openstack.org/613613 | 14:06 |
| mdbooth | mriedem: Looking, but ^^^ while you're here (discussion in bug: thanks for that) | 14:06 |
| mriedem | i didn't really understand what swap disks have to do with the image cache manager | 14:07 |
| mdbooth | mriedem: Right. | 14:07 |
| mriedem | it's blank right? so why does the *image* cache manager worry about it? | 14:07 |
| *** moshele has joined #openstack-nova | 14:07 | |
| mdbooth | mriedem: It's not blank, it's formatted. | 14:08 |
| mdbooth | So it's basically a cache of the output of mkswap. | 14:08 |
| mriedem | i mean there is no glance image in swap disks yeah? | 14:08 |
| mdbooth | No, there's no glance image. | 14:08 |
| mdbooth | It saves a completely inconsequential amount of time during creation, and is likely a performance hit at runtime. | 14:09 |
| mdbooth | And will save essentially no disk space. | 14:09 |
| mdbooth | So we really shouldn't do it all, but cleaning that up would be a significant task. We'd need an upgrade task to rebase disks in use which already use this. | 14:09 |
| mdbooth | However, aging these cached formatted swap files is really unlikely to be of much use to anybody. | 14:10 |
| mdbooth | This user has found it's really expensive, so my suggestion is just don't age them. | 14:10 |
| mdbooth | mriedem: Anyway, gimme a shout if you think ^^^ is an approach you could get behind and I'll fix that patch up properly. | 14:11 |
| mriedem | i just don't really understand the use case for why these are in the image cache | 14:13 |
| mriedem | granted, i'm not super familiar with the image cache manager to begin with | 14:13 |
| mriedem | beyond it's used to cache and (on a timer) age/invalidate images in the cache so new versions can be fetched | 14:13 |
| mriedem | but i thought that was only for root disks | 14:14 |
| mdbooth | mriedem: I don't know the origin, so I can only guess. However ephemeral filesystem are also in there, and there are certain filesystems which *are* expensive to initialise. | 14:14 |
| mdbooth | My guess is swap was simply handled the same way. | 14:14 |
| mdbooth | Although to be clear, I would remove ephemeral filesystems too. We're already not aging them. | 14:14 |
| mriedem | i don't see where ephemerals are in here | 14:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix ComputeNode ovo compatibility code https://review.openstack.org/631199 | 14:18 |
| mdbooth | ext3 vs ext4 fs creation comparison: http://paste.openstack.org/show/743462/ | 14:18 |
| mdbooth | mriedem: I had to check closely, but I'm confident we don't age ephemeral backing files. | 14:19 |
| mdbooth | reasonably confident :) That code is very hard to read. | 14:19 |
| mdbooth | I believe ext3 was the default, might still be, and ext3 fs creation can be slow. | 14:20 |
| mriedem | yeah i remember a ML thread from robert collins several years ago about changing the default to ext4 | 14:20 |
| mdbooth | I suspect that's how this feature came about. But note that we still have to do this for other imagebackends anyway, and ext4 fs creation is really fast anyway. | 14:20 |
| mriedem | looks like ext4 is the default now | 14:22 |
| openstackgerrit | Merged openstack/nova master: Add missing ws seperator between words https://review.openstack.org/632606 | 14:22 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/privsep/fs.py#L258 | 14:22 |
| kashyap | mdbooth: (Our of curiosity, I ran your same test on an NVMe: http://paste.openstack.org/show/743468/) | 14:26 |
| mdbooth | kashyap: That's consistent, although I doubt either of our tests were actually hitting disk. | 14:27 |
| *** BjoernT has joined #openstack-nova | 14:27 | |
| mdbooth | kashyap: Likely due to RAM/CPU speed differences. | 14:27 |
| kashyap | Oh, indeed. I always forget that point | 14:28 |
| kashyap | (I recall that `fio` is the better way to do benchmarks) | 14:28 |
| *** mmethot has quit IRC | 14:28 | |
| kashyap | (Reference: http://blog.vmsplice.net/2017/11/common-disk-benchmarking-mistakes.html) | 14:29 |
| *** mmethot has joined #openstack-nova | 14:29 | |
| *** awaugama has joined #openstack-nova | 14:31 | |
| kashyap | mriedem: Completely unrelated, posted the initial investigation from last night here: https://bugs.launchpad.net/nova/+bug/1813192/comments/1 | 14:33 |
| openstack | Launchpad bug 1813192 in OpenStack Compute (nova) "libvirt: instance delete fails with "Cannot destroy instance, operation time out: libvirt.libvirtError: Timed out during operation: cannot acquire state change lock (held by remoteDispatchDomainBlockJobAbort)" in bionic nodes (libvirt 4.0.0, qemu 2.11)" [Medium,Confirmed] | 14:33 |
| kashyap | I did some more digging this morning for an hour, will write it up today. | 14:33 |
| kashyap | The unsolved problem for me here is: how to get tracebacks ("thread all apply bt") from the hung QEMU (or libvirtd) from the CI hosts. | 14:34 |
| kashyap | The only current awful way for that is to abuse 'rootwrap' to elevate privileges and then upload a debug build of libvirt/QEMU. | 14:35 |
| kashyap | Then you can reproduce the problem, because "Heisenbug". | 14:35 |
| *** liuyulong has joined #openstack-nova | 14:37 | |
| mriedem | :/ | 14:38 |
| mriedem | it's only 3 hits in 7 days in the gate so it's not burning us down like some of the other known bugs in the gate | 14:39 |
| kashyap | Yeah, it's not. But I'd like to track down these gnarly bugs. Because if you recall, we had the same problem with the fated "live snapshot" bug | 14:44 |
| kashyap | ... that made us reap the whirlind. | 14:44 |
| *** moshele has quit IRC | 14:44 | |
| kashyap | (Typo earlier: "Then you can" --> "Then you can't") | 14:45 |
| kashyap | mriedem: Mind pointing me to the "known bugs" in the gate? | 14:45 |
| * kashyap goes to check: http://status.openstack.org/elastic-recheck/ | 14:46 | |
| mriedem | kashyap: http://status.openstack.org/elastic-recheck/ | 14:46 |
| mriedem | http://status.openstack.org/elastic-recheck/#1813198 | 14:46 |
| kashyap | Yep, remembered the URL | 14:46 |
| mriedem | http://status.openstack.org/elastic-recheck/#1813147 | 14:46 |
| mriedem | those are 2 big new ones | 14:46 |
| *** whoami-rajat has joined #openstack-nova | 14:46 | |
| *** dave-mccowan has joined #openstack-nova | 14:47 | |
| kashyap | Thanks | 14:47 |
| *** lbragstad has joined #openstack-nova | 14:49 | |
| *** dave-mccowan has quit IRC | 14:51 | |
| *** psachin has quit IRC | 14:53 | |
| openstackgerrit | Ralf Haferkamp proposed openstack/nova master: compute: reset instance events on reload https://review.openstack.org/633220 | 14:53 |
| *** pelement has left #openstack-nova | 14:55 | |
| mriedem | melwitt: do you expect to start on https://blueprints.launchpad.net/nova/+spec/count-quota-usage-from-placement soon? given you're out next week and we've got 6 weeks left i'm a bit worried about that one | 14:56 |
| *** cfriesen has joined #openstack-nova | 15:00 | |
| *** cdent has quit IRC | 15:00 | |
| *** hongbin has joined #openstack-nova | 15:01 | |
| melwitt | mriedem: yeah, I hope to have something WIP uploaded by late today | 15:02 |
| *** Shilpa has quit IRC | 15:04 | |
| *** spsurya has quit IRC | 15:07 | |
| *** tbachman has quit IRC | 15:12 | |
| *** tbachman has joined #openstack-nova | 15:22 | |
| *** dklyle has quit IRC | 15:22 | |
| *** spsurya has joined #openstack-nova | 15:30 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842 | 15:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | 15:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 15:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 15:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 15:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 15:30 |
| *** moshele has joined #openstack-nova | 15:31 | |
| *** jmlowe has joined #openstack-nova | 15:34 | |
| *** Luzi has quit IRC | 15:35 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Convert vrouter legacy plugging to os-vif https://review.openstack.org/571325 | 15:35 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add support for vrouter HW datapath offloads https://review.openstack.org/572082 | 15:35 |
| *** betherly has joined #openstack-nova | 15:35 | |
| *** READ10 has joined #openstack-nova | 15:36 | |
| *** betherly has quit IRC | 15:36 | |
| *** betherly has joined #openstack-nova | 15:36 | |
| *** cdent has joined #openstack-nova | 15:37 | |
| *** moshele has quit IRC | 15:38 | |
| *** bnemec has quit IRC | 15:43 | |
| *** lbragstad is now known as elbragstad | 15:43 | |
| *** udesale has quit IRC | 15:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | 15:58 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.openstack.org/633212 | 16:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | 16:00 |
| *** efried has joined #openstack-nova | 16:02 | |
| *** TxGirlGeek has joined #openstack-nova | 16:02 | |
| *** dklyle has joined #openstack-nova | 16:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.openstack.org/633212 | 16:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | 16:04 |
| *** wolverineav has joined #openstack-nova | 16:04 | |
| *** efried is now known as efried_mtg | 16:05 | |
| *** elbragstad has quit IRC | 16:06 | |
| *** lbragstad has joined #openstack-nova | 16:07 | |
| *** lbragstad is now known as elbragstad | 16:07 | |
| *** macza has joined #openstack-nova | 16:08 | |
| *** wolverineav has quit IRC | 16:08 | |
| melwitt | mriedem: I got confused by your comments on https://bugs.launchpad.net/nova/+bug/1811235 is it that cold migrate to same host is only valid for the vmware driver? and compute manager should be kicking it out unilaterally? | 16:11 |
| openstack | Launchpad bug 1811235 in OpenStack Compute (nova) "instance's vm-state becomes error when cold-migrate instance to same host failed" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 16:11 |
| mriedem | stephenfin: i'll likely need you to run it up the flagpole with danpb about why libvirt.sysinfo_serial was never guest-specific | 16:11 |
| mriedem | i don't have the history on that and it wasn't found in the original changes | 16:11 |
| stephenfin | mriedem: Can do | 16:11 |
| melwitt | s/should/shouldn't/ | 16:12 |
| mriedem | the compute manager doesn't kick cold migrate to the same host out unilateraly, the api is | 16:12 |
| mriedem | with that 2.56 change to specify host on cold migrate | 16:12 |
| mriedem | that's a different issue from the bug though, which was reported against ocata | 16:12 |
| mriedem | before 2.56 existed | 16:12 |
| *** macza has quit IRC | 16:13 | |
| mriedem | i believe migrate_to_same_host exists for the vmware driver b/c you can have a single nova-compute service in your openstack deployment which is actually managing a vcenter cluster with 1000 ESXi hosts in it | 16:13 |
| mriedem | so your only choice to cold migrate is to the same host | 16:13 |
| melwitt | he says he thinks it exists in ocata too from reading the code. right? I'm having trouble parsing this entire bug :( | 16:13 |
| mriedem | my patches above are working on fixing the bug he's hitting which exists in ocata | 16:14 |
| melwitt | comment #2 | 16:14 |
| mriedem | 2.56 does not | 16:14 |
| mriedem | 2.56 was queens | 16:14 |
| mriedem | comment 2 is saying 2 things | 16:14 |
| mriedem | first is the bug i'm fixing above | 16:14 |
| mriedem | second is the 2.56 issue i think | 16:15 |
| mriedem | which is a different bug imo | 16:15 |
| melwitt | yeah, I think he's not saying he's reporting it for ocata. "First, why the latest version of nova not supports migrating instance to same host event through some drivers support that function..Second, if there is any problem when user migrates instance without migration destination host but there is just one compute node." | 16:15 |
| *** ondrejme has quit IRC | 16:15 | |
| melwitt | eh, I dunno, I think I'm just confused by the wording of these comments | 16:15 |
| *** yan0s has quit IRC | 16:17 | |
| mriedem | i left a comment to try and answer the questions from comment 2 | 16:18 |
| melwitt | thanks. I think I see now, he's saying why go to error status when it "fails" because migrating to self doesn't really do anything | 16:20 |
| melwitt | ok that comment makes it clear. good | 16:21 |
| mriedem | correct, but the rejection in the API is not the same as the bug in the compute that sets the instance to error status | 16:21 |
| mriedem | i've got fixes posted above for the latter, not the former | 16:21 |
| melwitt | gotcha. I've got it starred for review | 16:21 |
| *** panda is now known as panda|off | 16:23 | |
| mriedem | melwitt: if https://blueprints.launchpad.net/openstack/?searchtext=conf-max-attach-volumes is ready for review again you want to queue it up in runways? | 16:29 |
| mriedem | jangutter's can probably go in the open slot as well | 16:29 |
| melwitt | mriedem: sure. I don't know why I didn't think of doing that | 16:30 |
| *** kaliya has joined #openstack-nova | 16:30 | |
| *** wolverineav has joined #openstack-nova | 16:34 | |
| jangutter | melwitt, mriedem: thanks! | 16:34 |
| *** kaliya has quit IRC | 16:35 | |
| mriedem | pretty easy fix here for someone https://review.openstack.org/#/c/624959/ | 16:35 |
| mriedem | needs to be backported to queens as well | 16:35 |
| melwitt | jangutter: the bp dependencies show that vrouter-hw-offloads also depends on the generic-os-vif-offloads too. should I add that patch link in there too for the runway review? | 16:39 |
| sean-k-mooney | melwitt: i think the os-vif stuff was all in the 1.14 release we did this week | 16:40 |
| * melwitt reads note on blueprint tracking etherpad | 16:40 | |
| jangutter | melwitt: the dependency's unblocked on that one (generic-os-vif-offloads has follow-on work) | 16:40 |
| sean-k-mooney | jangutter: more stuff in os-vif "e.g. that i should review" or in nova | 16:41 |
| melwitt | oh, I see, the dependency piece is unblocked but bp still needs more work to be complete | 16:41 |
| sean-k-mooney | which i should proably also review | 16:41 |
| melwitt | ok thank you | 16:41 |
| jangutter | melwitt: the dominoes are all ready to fall... for the vrouter bits though. | 16:41 |
| melwitt | coolness | 16:42 |
| *** tssurya has quit IRC | 16:43 | |
| *** tstrul has joined #openstack-nova | 16:45 | |
| jangutter | sean-k-mooney: for the generic-os-vif-offloads I think there's just one more bit in nova (for Stein) to populate the data. The next os-vif change should really only be appropriate for Train. | 16:45 |
| *** macza has joined #openstack-nova | 16:48 | |
| sean-k-mooney | ok | 16:48 |
| sean-k-mooney | if there is stuff i need to review for stien let me know. the non client lib frezze is in 3-4 weeks so if another os-vif release is need we need to merge the code before then | 16:49 |
| sean-k-mooney | form the non-client-lib freeze untill rc1 os-vif will basically be frozen | 16:50 |
| sean-k-mooney | form rc1/rc2 on it will be reopen for train | 16:50 |
| melwitt | feb 28 is non-client lib freeze | 16:51 |
| jangutter | sean-k-mooney: thanks, the only open one I have for Stein is the serialization cleanup patch, and that kinda-sorta depends on a style choice. | 16:51 |
| sean-k-mooney | ok thats what i had understood | 16:52 |
| jangutter | sean-k-mooney: I _think_ the only affected party to that would be kuryr and not Nova. | 16:52 |
| *** betherly has quit IRC | 16:53 | |
| *** rpittau has quit IRC | 16:54 | |
| *** dklyle has quit IRC | 17:00 | |
| *** helenaAM has quit IRC | 17:04 | |
| *** derekh has quit IRC | 17:05 | |
| *** jangutter has quit IRC | 17:06 | |
| melwitt | leakypipes, mriedem: am I correct in my understanding that because this spec about "how to use initial allocation ratios" got stuck https://review.openstack.org/544683, we don't and will not have support for being able to set allocation ratios per aggregate? | 17:06 |
| *** dklyle has joined #openstack-nova | 17:07 | |
| mriedem | you can do it via placement externally if you want, and could have since forever - and is what we said people could do in dublin | 17:08 |
| mriedem | but no one worked on that, | 17:08 |
| mriedem | or added anything to osc-placement for it | 17:08 |
| mriedem | the nova spec is about mirroring aggregate allocation ratios to placement | 17:09 |
| mriedem | which is a nice to have but less necessary since you can do that directly with placement and we have rbac support in placement now too (which was a previous reason this should go through nova - for rbac) | 17:09 |
| mriedem | so the only sticking point on the nova spec is deciding if nova should do that mirroring / proxy orchestration work | 17:10 |
| mriedem | clearly that isn't going to happen in stein though | 17:10 |
| mriedem | bbiab | 17:10 |
| *** mriedem is now known as mriedem_afk | 17:10 | |
| *** gyee has joined #openstack-nova | 17:11 | |
| *** mmethot_ has joined #openstack-nova | 17:11 | |
| efried_mtg | sean-k-mooney: not sure if you knew about this, but when resubmitting a series, git-review normally re-topics the whole series to match the top patch. You can make it not do that - i.e. leave the topic unchanged (or empty if it's the first time you're uploading it) by using the -T flag. | 17:12 |
| melwitt | mriedem_afk: thanks, I'll make some notes about it on the blueprint tracking etherpad | 17:12 |
| *** mrhillsman is now known as mrhillsman_lunch | 17:13 | |
| sean-k-mooney | efried_mtg: ya it has bitten me in the past | 17:13 |
| *** brault has quit IRC | 17:13 | |
| melwitt | I've had a hard time following what was going on there. didn't realize the only thing left was mirroring, and I agree I'm not sure whether we should | 17:13 |
| sean-k-mooney | efried_mtg: generally its does what i want as if i am working on a patch serise its all for the same bug/blueprint but it can be annoying | 17:14 |
| *** brault has joined #openstack-nova | 17:14 | |
| *** mmethot has quit IRC | 17:14 | |
| sean-k-mooney | efried_mtg: i just like the fact i can "git checkout -b whatever" and then "git revew -f" and have the topic set correctly to "whatever" | 17:15 |
| *** _fragatina has joined #openstack-nova | 17:16 | |
| *** _fragatina has quit IRC | 17:16 | |
| leakypipes | melwitt: I'll abandon that spec. | 17:16 |
| *** _fragatina has joined #openstack-nova | 17:17 | |
| sean-k-mooney | leakypipes: you spec for mirroring nova aggrages as placement aggrates was complete in rocky rigt? seperate form the allcoation ratio stuff | 17:18 |
| melwitt | leakypipes: k. I was only asking because I'm trying to round up things we identified as priority items and that one I had trouble parsing what the second spec was about | 17:18 |
| melwitt | *priority items at the ptg | 17:18 |
| *** dklyle has quit IRC | 17:19 | |
| melwitt | sean-k-mooney: mirroring aggregates was a different thing yeah, and is already in nova | 17:19 |
| leakypipes | sean-k-mooney: yes. | 17:19 |
| leakypipes | melwitt: np | 17:20 |
| sean-k-mooney | cool so in thery you coudl write a scipt/tool to find all the RPs with a specific resouce in an aggrate and set the allocation ratio in the inventory relitivly simply if you wanted too | 17:20 |
| melwitt | yeah, we talked about adding a command to osc-placement CLI to help with that. we should do that. maybe I'll try to do it if I can get my other stuff done | 17:26 |
| *** pelement has joined #openstack-nova | 17:27 | |
| *** _fragatina has quit IRC | 17:32 | |
| *** _fragatina has joined #openstack-nova | 17:32 | |
| *** mmethot_ has quit IRC | 17:34 | |
| *** mmethot_ has joined #openstack-nova | 17:35 | |
| *** mmethot_ has quit IRC | 17:36 | |
| openstackgerrit | Kevin Rasmussen proposed openstack/nova master: created AggregateSubnetAvailabilityFilter https://review.openstack.org/633178 | 17:39 |
| openstackgerrit | Kevin Rasmussen proposed openstack/nova master: created AggregateSubnetAvailabilityFilter https://review.openstack.org/633178 | 17:40 |
| *** _fragatina has quit IRC | 17:41 | |
| *** _fragatina has joined #openstack-nova | 17:41 | |
| *** dklyle has joined #openstack-nova | 18:00 | |
| *** ccamacho has quit IRC | 18:05 | |
| *** _fragatina has quit IRC | 18:12 | |
| *** _fragatina has joined #openstack-nova | 18:13 | |
| *** wolverineav has quit IRC | 18:13 | |
| *** mrhillsman_lunch is now known as mrhillsman | 18:15 | |
| artom | We can just disable the Keystone middleware and run without authentication, right? | 18:17 |
| sean-k-mooney | artom: you can disable auth yes | 18:17 |
| artom | (Asking for a performance thing downstream, suspecting Keystone is the culprit, want to propose testing without it) | 18:17 |
| sean-k-mooney | i guessed. let me see if i can find the config | 18:21 |
| artom | sean-k-mooney, too late, email went out. I'll blame you if people pick me up on it :D | 18:21 |
| cdent | artom, sean-k-mooney: I'm not positive but I think you have to choose a different auth strategy (noauth2) and still set x-auth-token headers so that policy checks still have something to chew on. If that can be avoided too, I'd love to hear about it. | 18:22 |
| sean-k-mooney | artom: i think you set this https://docs.openstack.org/nova/latest/configuration/config.html#keystone_authtoken.auth_type | 18:23 |
| artom | cdent, right, but that avoids the authentication calls to the Keystone API, right? | 18:23 |
| cdent | yes | 18:23 |
| *** _fragatina has quit IRC | 18:23 | |
| artom | OK, because that's what I care about | 18:23 |
| cdent | I do that noauth2 stuff all the time with placement and it seems to work fine with a 'x-auth-token: amdin' header | 18:23 |
| sean-k-mooney | cdent: ya our functional test use noauth2 i think when they spin up apis | 18:24 |
| cdent | except I spell admin correctly... | 18:24 |
| cdent | sigh | 18:24 |
| sean-k-mooney | just alias it it will be fine | 18:24 |
| cdent | :) | 18:24 |
| artom | Am Din. You be? | 18:24 |
| cdent | Me be me | 18:25 |
| sean-k-mooney | i have always beeen temeted to make "suod" and alais of "sudo" | 18:25 |
| artom | And "temeted" an alias of "tempted", and "alais" of "alias" | 18:25 |
| artom | ;) | 18:25 |
| artom | cdent, but will the FCC let you be? | 18:25 |
| sean-k-mooney | hehe the problem is i mispell things inconsitently | 18:26 |
| cdent | artom++ | 18:26 |
| artom | cdent, .... and now I'm listening to it | 18:27 |
| cdent | yeah, I was headed that way too | 18:27 |
| *** wolverineav has joined #openstack-nova | 18:33 | |
| *** whoami-rajat has quit IRC | 18:34 | |
| *** wolverineav has quit IRC | 18:35 | |
| *** wolverineav has joined #openstack-nova | 18:35 | |
| *** mriedem_afk is now known as mriedem | 18:41 | |
| *** sapd1_ has quit IRC | 18:47 | |
| *** sapd1_ has joined #openstack-nova | 18:47 | |
| *** wolverineav has quit IRC | 19:00 | |
| *** wolverineav has joined #openstack-nova | 19:02 | |
| *** erlon_ has quit IRC | 19:02 | |
| *** bnemec has joined #openstack-nova | 19:02 | |
| *** tstrul has quit IRC | 19:08 | |
| *** bnemec is now known as beekneemech | 19:11 | |
| *** igordc has joined #openstack-nova | 19:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Isolate cell-targeting code in MigrationTask https://review.openstack.org/621310 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract compute API _create_image to compute.utils https://review.openstack.org/621311 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add TargetDBSetupTask https://review.openstack.org/627892 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 19:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 19:11 |
| *** cdent has quit IRC | 19:24 | |
| *** wolverineav has quit IRC | 19:33 | |
| *** ralonsoh has quit IRC | 19:33 | |
| *** wolverineav has joined #openstack-nova | 19:34 | |
| *** wolverineav has quit IRC | 19:38 | |
| *** wolverineav has joined #openstack-nova | 19:39 | |
| *** beekneemech has quit IRC | 19:42 | |
| melwitt | is there no way to link to an archived ML post from openstack-dev@? | 19:43 |
| *** _fragatina has joined #openstack-nova | 19:43 | |
| *** mgariepy has joined #openstack-nova | 19:43 | |
| melwitt | from before the switch to the new list | 19:43 |
| melwitt | ok, I found a way. just couldn't get to the root page for openstack-dev anymore | 19:44 |
| *** betherly has joined #openstack-nova | 19:45 | |
| *** wolverineav has quit IRC | 19:45 | |
| *** mmethot has joined #openstack-nova | 19:49 | |
| *** dklyle has quit IRC | 19:51 | |
| sean-k-mooney | are block migrtation broken? | 19:57 |
| sean-k-mooney | http://logs.openstack.org/20/616120/9/check/legacy-grenade-dsvm-neutron-multinode-live-migration/b90819f/logs/testr_results.html.gz | 19:57 |
| sean-k-mooney | test_live_block_migration is presuably ment to you know use a block migrtation so the fact taht it is not on shared storage is well expected | 19:58 |
| artom | sean-k-mooney, multiqueue is an imageprop, right? | 20:06 |
| artom | I can't find it under flavor extra specs | 20:06 |
| artom | (In parallel, is there a guide as to when something's a prop vs an extra spec?) | 20:07 |
| *** avolkov has quit IRC | 20:07 | |
| sean-k-mooney | if its virt dirver specific it an image prop if its generic its in the falvor is one guide the other is should the admin or tenant be able to set it | 20:08 |
| sean-k-mooney | and yes its hw_vif_multiqueue_enabled=true|false | 20:08 |
| sean-k-mooney | in the image meta | 20:08 |
| artom | "is one guide the other is should the admin or tenant be able to set it" Wat. | 20:09 |
| *** tbachman has quit IRC | 20:09 | |
| sean-k-mooney | admin only = flavor, tenant setable = imgage | 20:09 |
| artom | Ah :) Thanks! | 20:10 |
| *** agopi has joined #openstack-nova | 20:10 | |
| sean-k-mooney | o/ | 20:11 |
| *** dklyle has joined #openstack-nova | 20:13 | |
| *** wolverineav has joined #openstack-nova | 20:18 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add a warning for max_concurrent_live_migrations https://review.openstack.org/632240 | 20:19 |
| *** TxGirlGeek has quit IRC | 20:20 | |
| *** tbachman has joined #openstack-nova | 20:21 | |
| *** wolverineav has quit IRC | 20:23 | |
| *** mgariepy has quit IRC | 20:25 | |
| *** zul has quit IRC | 20:26 | |
| *** tbachman has quit IRC | 20:28 | |
| *** mmethot has quit IRC | 20:29 | |
| *** med_ has quit IRC | 20:30 | |
| *** mmethot has joined #openstack-nova | 20:31 | |
| *** efried_mtg has quit IRC | 20:31 | |
| *** READ10 has quit IRC | 20:35 | |
| *** spsurya has quit IRC | 20:37 | |
| openstackgerrit | Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.openstack.org/476642 | 20:38 |
| *** slaweq has quit IRC | 20:49 | |
| *** wolverineav has joined #openstack-nova | 20:50 | |
| *** wolverineav has quit IRC | 20:55 | |
| *** dklyle has quit IRC | 20:55 | |
| *** dklyle has joined #openstack-nova | 20:59 | |
| leakypipes | mriedem, stephenfin: if either of you have a moment, https://review.openstack.org/#/c/631684/ should be an easy one. | 21:08 |
| leakypipes | sean-k-mooney: ^^ you too if you care to have a look. | 21:09 |
| *** tbachman has joined #openstack-nova | 21:12 | |
| *** dklyle has quit IRC | 21:13 | |
| *** wolverineav has joined #openstack-nova | 21:14 | |
| mriedem | sean-k-mooney: i reported a bug for that job failure yesterday | 21:15 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1813216 | 21:15 |
| openstack | Launchpad bug 1813216 in OpenStack Compute (nova) "legacy-grenade-dsvm-neutron-multinode-live-migration failing with "is not on shared storage: Shared storage live-migration requires either shared storage or boot-from-volume with no local disks." since Jan 21" [Undecided,Confirmed] | 21:15 |
| mriedem | it's a recent regression but i don't know what is causing it | 21:15 |
| mriedem | could be a change i made in devstack recently which would impact grenade like jobs | 21:15 |
| mriedem | artom: image properties are doc'ed here https://docs.openstack.org/glance/latest/admin/useful-image-properties.html | 21:16 |
| mriedem | although it's missing quite a few | 21:16 |
| *** slaweq has joined #openstack-nova | 21:16 | |
| *** TxGirlGeek has joined #openstack-nova | 21:17 | |
| openstackgerrit | Alex Kavanagh (tinwood) proposed openstack/nova master: Add LXD to the nova.objects.fields.HypervisorDriver Enum https://review.openstack.org/633279 | 21:18 |
| *** slaweq has quit IRC | 21:21 | |
| *** TxGirlGeek has quit IRC | 21:28 | |
| mriedem | stephenfin: questoins in that dns patch | 21:28 |
| mriedem | oh nvm that was for leakypipes | 21:29 |
| *** wolverineav has quit IRC | 21:29 | |
| *** wolverineav has joined #openstack-nova | 21:30 | |
| *** wolverineav has quit IRC | 21:30 | |
| mriedem | leakypipes: how far back is that change going to go? presumably at least ocata. if so, it would probably be good to do the network caching i mention here https://review.openstack.org/#/c/631684/2/nova/network/neutronv2/api.py@635 | 21:32 |
| mriedem | rather than in a follow up | 21:32 |
| leakypipes | mriedem: ack, though I'm not sure we should ask Hang to do that. Probably better if I do it in a pre-cursor or something? | 21:33 |
| *** jangutter has joined #openstack-nova | 21:33 | |
| mriedem | pre-cursor? | 21:33 |
| mriedem | if you want to make that change to this patch set i'm ok with it - and will honor your +2 | 21:34 |
| leakypipes | mriedem: ftr, that change is being applied to our queens/rocky release, so I'm not entirely concerned about the ocata thing :) but yes, I can make the change you requested on line 635 to that patch. | 21:40 |
| leakypipes | mriedem: and I don't expect you to honor my +2 or anything :) | 21:41 |
| leakypipes | I see no honor in reviews :) | 21:41 |
| mriedem | i mean i think you can still +2 after that, or i'll just proxy your +2 | 21:41 |
| leakypipes | ack | 21:41 |
| mriedem | since you're a southerner honor is a big thing | 21:42 |
| leakypipes | mriedem: indeed. I am SOOOO Southern now. | 21:50 |
| *** wolverineav has joined #openstack-nova | 21:52 | |
| *** pelement has left #openstack-nova | 21:52 | |
| *** awaugama has quit IRC | 21:58 | |
| *** awalende has joined #openstack-nova | 21:58 | |
| *** hongbin has quit IRC | 22:02 | |
| *** hongbin has joined #openstack-nova | 22:03 | |
| *** TxGirlGeek has joined #openstack-nova | 22:07 | |
| *** jangutter has quit IRC | 22:08 | |
| mnaser | hi, just got bit by this -- https://review.openstack.org/#/c/626218/1 -- anyone on stable mind pushing it through? | 22:15 |
| mnaser | patch on top of it has +w too | 22:16 |
| *** awalende has quit IRC | 22:31 | |
| *** awalende has joined #openstack-nova | 22:31 | |
| *** awalende has quit IRC | 22:35 | |
| *** slaweq has joined #openstack-nova | 22:38 | |
| *** jmlowe has quit IRC | 22:41 | |
| *** slaweq has quit IRC | 22:43 | |
| *** KeithMnemonic has quit IRC | 22:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add TargetDBSetupTask https://review.openstack.org/627892 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 22:53 |
| mriedem | smcginnis: can you hit this for mnaser? https://review.openstack.org/#/c/626218/ | 22:54 |
| mriedem | and the one on top | 22:54 |
| mriedem | oh nvm the one on top is +W already | 22:54 |
| mnaser | yup :> | 22:54 |
| *** slaweq has joined #openstack-nova | 22:57 | |
| *** kaliya has joined #openstack-nova | 22:58 | |
| *** kaliya has quit IRC | 23:00 | |
| *** slaweq has quit IRC | 23:05 | |
| *** bnemec has joined #openstack-nova | 23:12 | |
| *** dklyle has joined #openstack-nova | 23:13 | |
| *** BjoernT has quit IRC | 23:16 | |
| *** betherly has quit IRC | 23:16 | |
| *** betherly has joined #openstack-nova | 23:16 | |
| *** dklyle has quit IRC | 23:20 | |
| *** wolverineav has quit IRC | 23:22 | |
| *** wolverineav has joined #openstack-nova | 23:23 | |
| *** efried has joined #openstack-nova | 23:23 | |
| *** wolverineav has quit IRC | 23:27 | |
| *** wolverineav has joined #openstack-nova | 23:27 | |
| *** xek has quit IRC | 23:30 | |
| *** mmethot has quit IRC | 23:32 | |
| *** mmethot has joined #openstack-nova | 23:32 | |
| *** betherly has quit IRC | 23:32 | |
| *** mmethot has quit IRC | 23:33 | |
| *** mmethot has joined #openstack-nova | 23:33 | |
| *** mmethot has quit IRC | 23:34 | |
| *** mmethot has joined #openstack-nova | 23:35 | |
| *** mmethot has quit IRC | 23:41 | |
| *** mmethot has joined #openstack-nova | 23:42 | |
| *** mmethot has quit IRC | 23:43 | |
| *** bnemec has quit IRC | 23:43 | |
| *** mmethot has joined #openstack-nova | 23:44 | |
| *** bnemec has joined #openstack-nova | 23:44 | |
| *** mmethot has quit IRC | 23:44 | |
| *** mmethot has joined #openstack-nova | 23:45 | |
| *** elbragstad has quit IRC | 23:54 | |
| *** bnemec has quit IRC | 23:59 | |
| *** bnemec has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!