Wednesday, 2018-12-12

*** munimeha1 has quit IRC00:06
*** itlinux has joined #openstack-nova00:06
*** wolverineav has quit IRC00:14
*** wolverineav has joined #openstack-nova00:18
*** dklyle has quit IRC00:21
*** macza has quit IRC00:23
*** wolverineav has quit IRC00:23
*** itlinux_ has joined #openstack-nova00:25
*** itlinux has quit IRC00:28
*** dklyle has joined #openstack-nova00:34
*** xek__ has joined #openstack-nova00:37
*** mlavalle has quit IRC00:38
*** xek_ has quit IRC00:39
openstackgerritMerged openstack/nova master: Fix typo  https://review.openstack.org/62444200:40
*** wolverineav has joined #openstack-nova00:48
*** Swami has quit IRC00:49
*** itlinux_ has quit IRC00:49
mriedemdansmith: i think i've figured out why we're getting that ocata api service version warning in the logs - https://review.openstack.org/#/c/624438/ - something is re-entering _get_instance with a cell1-targeted context, so it's failing to find any nova-osapi_compute services in the cell1 db (as expected), i'm just not sure where the re-entry is coming from.00:52
*** dakshina-ilangov has quit IRC00:53
mriedemand that's why we don't get a 404 from the Instance.get_by_uuid call because the context is already targeted00:56
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: add debug logging for bug 1807723  https://review.openstack.org/62418101:04
openstackbug 1807723 in tempest "test_volume_swap_with_multiattach intermittently fails during cleanup" [High,In progress] https://launchpad.net/bugs/1807723 - Assigned to Matt Riedemann (mriedem)01:04
*** dklyle has quit IRC01:04
*** brinzhang has joined #openstack-nova01:09
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: debug old compute API service version lookup  https://review.openstack.org/62443801:14
*** dave-mccowan has joined #openstack-nova01:14
*** mriedem has quit IRC01:23
*** yedongcan has joined #openstack-nova01:34
*** erlon has quit IRC01:35
*** markvoelker has quit IRC01:41
*** cfriesen has quit IRC01:59
*** Dinesh_Bhor has joined #openstack-nova02:01
*** mrsoul has quit IRC02:09
*** brinzhang has quit IRC02:10
*** brinzhang has joined #openstack-nova02:10
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914302:13
*** wolverineav has quit IRC02:17
*** wolverineav has joined #openstack-nova02:18
*** bhagyashris_ has joined #openstack-nova02:21
*** wolverineav has quit IRC02:22
*** Dinesh_Bhor has quit IRC02:27
*** mhen has quit IRC02:28
*** mhen has joined #openstack-nova02:31
*** Dinesh_Bhor has joined #openstack-nova02:33
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914302:41
*** cfriesen has joined #openstack-nova02:44
*** hongbin has joined #openstack-nova02:44
*** igordc has quit IRC03:07
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914203:26
*** psachin has joined #openstack-nova03:27
*** wolverineav has joined #openstack-nova03:30
*** Dinesh_Bhor has quit IRC03:34
openstackgerritMerged openstack/nova master: Only warn about not having computes nodes once in rpcapi  https://review.openstack.org/62328203:35
*** dave-mccowan has quit IRC03:52
openstackgerritMerged openstack/nova master: Handle tags in _bury_in_cell0  https://review.openstack.org/62185603:58
*** udesale has joined #openstack-nova04:17
*** Dinesh_Bhor has joined #openstack-nova04:42
*** hongbin has quit IRC04:55
*** brault has joined #openstack-nova05:09
*** brault has quit IRC05:14
*** wolverineav has quit IRC05:17
*** maciejjozefczyk has quit IRC05:19
*** rtjure has quit IRC05:19
*** maciejjozefczyk has joined #openstack-nova05:19
*** ratailor has joined #openstack-nova05:20
*** itlinux has joined #openstack-nova05:21
*** rtjure has joined #openstack-nova05:22
*** wolverineav has joined #openstack-nova05:24
*** dklyle has joined #openstack-nova05:51
*** itlinux has quit IRC05:51
*** dklyle has quit IRC05:56
*** _alastor_ has joined #openstack-nova06:06
*** wolverineav has quit IRC06:09
*** Dinesh_Bhor has quit IRC06:13
*** sridharg has joined #openstack-nova06:15
*** slaweq has joined #openstack-nova06:29
*** lpetrut has joined #openstack-nova06:30
*** cfriesen has quit IRC06:31
*** _alastor_ has quit IRC06:45
*** Dinesh_Bhor has joined #openstack-nova06:47
*** moshele has joined #openstack-nova07:00
*** Luzi has joined #openstack-nova07:01
openstackgerritMichael Still proposed openstack/nova master: Imagebackend should call processutils.execute directly.  https://review.openstack.org/61970407:09
openstackgerritMichael Still proposed openstack/nova master: Remove final users of utils.execute() in libvirt.  https://review.openstack.org/61970507:09
openstackgerritMichael Still proposed openstack/nova master: Remove the final user of utils.execute() from virt.images  https://review.openstack.org/62000707:09
openstackgerritMichael Still proposed openstack/nova master: Remove utils.execute() from the hyperv driver.  https://review.openstack.org/62000807:09
openstackgerritMichael Still proposed openstack/nova master: Remove utils.execute() from virt.disk.api.  https://review.openstack.org/62000907:09
openstackgerritMichael Still proposed openstack/nova master: Move a generic bridge helper to a linux_net privsep file.  https://review.openstack.org/62001007:09
openstackgerritMichael Still proposed openstack/nova master: Move bridge creation to privsep.  https://review.openstack.org/62018007:09
openstackgerritMichael Still proposed openstack/nova master: Move some linux network helpers to use privsep.  https://review.openstack.org/62139807:09
openstackgerritMichael Still proposed openstack/nova master: Move simple execute call to processutils.  https://review.openstack.org/62152707:09
openstackgerritMichael Still proposed openstack/nova master: Move interface enabling to privsep.  https://review.openstack.org/62152807:09
openstackgerritMichael Still proposed openstack/nova master: Move setting mac addresses for network devices to privsep.  https://review.openstack.org/62152907:09
openstackgerritMichael Still proposed openstack/nova master: Move interface disabling to privsep.  https://review.openstack.org/62215007:09
openstackgerritMichael Still proposed openstack/nova master: Move binding ips to privsep.  https://review.openstack.org/62215107:09
openstackgerritMichael Still proposed openstack/nova master: create_veth_pair is unused, remove it.  https://review.openstack.org/62422607:09
openstackgerritMichael Still proposed openstack/nova master: Create specialist set_macaddr_and_vlan helper.  https://review.openstack.org/62422707:09
openstackgerritMichael Still proposed openstack/nova master: Move create_tap_dev into privsep.  https://review.openstack.org/62422807:09
openstackgerritMichael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller.  https://review.openstack.org/62422907:09
openstackgerritMichael Still proposed openstack/nova master: Move DHCP releasing to privsep.  https://review.openstack.org/62423007:09
*** masayukig[m] has joined #openstack-nova07:13
*** wolverineav has joined #openstack-nova07:25
*** openstackgerrit has quit IRC07:29
*** dklyle has joined #openstack-nova07:29
*** wolverineav has quit IRC07:29
*** rcernin has quit IRC07:30
*** ivve has quit IRC07:30
*** alexchadin has joined #openstack-nova07:31
*** sahid has joined #openstack-nova07:43
*** lpetrut has quit IRC07:46
*** trident has quit IRC07:58
*** trident has joined #openstack-nova08:00
*** imacdonn has quit IRC08:23
*** imacdonn has joined #openstack-nova08:23
*** brault has joined #openstack-nova08:23
*** brault has quit IRC08:24
*** brault has joined #openstack-nova08:24
*** helenafm has joined #openstack-nova08:24
*** dklyle has quit IRC08:32
*** ccamacho has joined #openstack-nova08:37
*** ralonsoh has joined #openstack-nova08:41
*** markvoelker has joined #openstack-nova08:44
*** markvoelker has quit IRC08:49
*** jonher_ has joined #openstack-nova08:57
*** tssurya has joined #openstack-nova08:59
*** jonher has quit IRC09:00
*** jonher_ is now known as jonher09:00
*** ivve has joined #openstack-nova09:04
*** openstackgerrit has joined #openstack-nova09:10
openstackgerritZhenyu Zheng proposed openstack/nova master: WIP run metadata api per cell  https://review.openstack.org/62461209:10
*** mtreinish has quit IRC09:11
*** k_mouza has joined #openstack-nova09:13
*** yan0s has joined #openstack-nova09:15
*** dtantsur|afk is now known as dtantsur09:19
yan0shi all09:19
*** k_mouza has quit IRC09:19
yan0swhy isn't there a "nova quota-class-list" command?09:20
yan0sor "openstack quota list --class"09:20
*** k_mouza has joined #openstack-nova09:20
yan0show can I get list of defined quota classes?09:20
*** psachin is now known as psachin|session09:35
*** markvoelker has joined #openstack-nova09:39
*** lpetrut has joined #openstack-nova09:41
*** moshele has quit IRC09:42
*** derekh has joined #openstack-nova09:44
*** lpetrut has quit IRC09:45
ondrejmeyan0s: nova quota-defaults ?09:51
*** ivve has quit IRC09:52
*** bhagyashris_ has quit IRC09:53
*** ohorecny2 has joined #openstack-nova09:54
*** mtreinish has joined #openstack-nova09:57
*** cdent has joined #openstack-nova10:20
*** Dinesh_Bhor has quit IRC10:24
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir during evac with rbd  https://review.openstack.org/61847810:40
*** Dinesh_Bhor has joined #openstack-nova10:49
*** erlon has joined #openstack-nova10:57
*** rodolof has joined #openstack-nova11:02
*** udesale has quit IRC11:02
*** udesale has joined #openstack-nova11:03
*** lpetrut has joined #openstack-nova11:03
*** moshele has joined #openstack-nova11:13
*** yedongcan has left #openstack-nova11:14
*** markvoelker has quit IRC11:30
*** Eran_Kuris has joined #openstack-nova11:30
*** Dinesh_Bhor has quit IRC11:33
yan0sondrejme: it is possible to set different quota per class11:34
yan0sand it possible to see the quota set in this class if you know the class name11:34
yan0sbut it is not possible to get a list of available classes11:35
yan0sthe command you sent me returns the default quota values11:36
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Only warn about not having computes nodes once in rpcapi  https://review.openstack.org/62467711:42
*** ttsiouts has joined #openstack-nova11:47
*** k_mouza has quit IRC11:51
*** yikun_ has quit IRC11:51
stephenfinlyarwood: I was wondering why nova-api (or was it the conductor?) was spewing all those logs ^11:53
*** jamesdenton has quit IRC11:56
lyarwoodstephenfin: that's dansmith's fix, I'm just pulling it back into stable/rocky11:56
*** dtantsur is now known as dtantsur|brb11:56
*** jamesdenton has joined #openstack-nova12:00
*** moshele has quit IRC12:03
*** moshele has joined #openstack-nova12:04
*** markvoelker has joined #openstack-nova12:05
*** ttsiouts has quit IRC12:07
*** ttsiouts has joined #openstack-nova12:07
*** k_mouza has joined #openstack-nova12:09
*** ttsiouts has quit IRC12:12
openstackgerritChris Dent proposed openstack/os-resource-classes master: Sync STANDARDS with placement/nova rc_fields  https://review.openstack.org/62437012:12
openstackgerritChris Dent proposed openstack/os-resource-classes master: Tune up documentation to be more useful  https://review.openstack.org/62438412:13
*** brault has quit IRC12:34
*** dave-mccowan has joined #openstack-nova12:40
*** ratailor has quit IRC12:54
*** ttsiouts has joined #openstack-nova12:54
openstackgerritBrin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server  https://review.openstack.org/62468912:56
openstackgerritBrin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server  https://review.openstack.org/62468912:58
*** moshele has quit IRC12:59
*** brinzhang has quit IRC13:00
*** Eran_Kuris has quit IRC13:04
*** k_mouza has quit IRC13:19
*** dtantsur|brb is now known as dtantsur13:20
*** k_mouza has joined #openstack-nova13:27
*** markvoelker has quit IRC13:28
*** k_mouza_ has joined #openstack-nova13:30
*** tbachman has joined #openstack-nova13:30
*** k_mouza__ has joined #openstack-nova13:31
*** k_mouza has quit IRC13:32
*** k_mouza_ has quit IRC13:34
adriancsean-k-mooney: Hi, regarding the issue you experienced yesterday with live-migration, ping me when you are here13:39
*** eharney has joined #openstack-nova13:40
sean-k-mooneyadrianc: ping13:46
sean-k-mooney:)13:46
adriancsean-k-mooney: so apparently there is some weird behavior with sriov macvtap when you tear down the VM the VF netdev remains up13:49
adriancso you have a scenario of duplicate macs in the network13:49
adriancdoing ifconfig <VF-netdev> down on the source VF should fix the issue (at least on my setup it did)13:50
adriancsean-k-mooney: i had a discussion with moshele about it, apparently this is an old issue which branches off this mail: https://www.redhat.com/archives/libvir-list/2016-September/msg00075.html13:52
sean-k-mooneyah ok13:53
sean-k-mooneyso i had considered creating an os-vif plugin for sriov this cycle.13:53
adriancsriov netdev mac address will be re-allocated only on driver rebind on the VF13:53
sean-k-mooneywe can do it in the nova tree but we could also jsut create the plugin and have it set the vf down13:54
adriancif you do passthrough then it will be properly cleaned, however on macvtap this is not the case13:54
sean-k-mooneyya13:54
adrianci added a hook in my code to do: interface down in vif.py under unplug_hw_veb()13:54
sean-k-mooneyok cool that should work for now.13:55
sean-k-mooneyi would like to move that into os-vif later i also want to move the trusted vf logic into os-vif which was why i was orignally gong to create the sriov plugin13:56
*** dtantsur is now known as dtantsur|brb13:56
sean-k-mooneyadrianc: do you have a new patchset up with that change. ill redeploy and test13:56
adriancnot yet, i need to deploy the change and make sure it actually does the job. it worked manually.13:58
adriancsean-k-mooney: it should not be tied to the neutron-sriov-live-migration work as it serves as a WA to an existing problem.14:00
*** markvoelker has joined #openstack-nova14:01
adrianclet me know if doing ifconfig <netdev> down on the source vf netdev solves the issue for you. (after migration)14:01
sean-k-mooneythat is true but you could make it the base patch of the series so its easy to test all of them14:01
sean-k-mooneysure i need to restack but ill let you know in an hour or so14:02
adriancsean-k-mooney: you will still need some POC code in neutron for multiple port binding14:02
sean-k-mooneyya i am useing that patch too14:03
sean-k-mooneydevstack can deploy with unmerged patches from gerrit14:04
sean-k-mooneybut it cant combine two sets fo unrelated patches14:04
sean-k-mooneyso to test at the moment i jsut need to point to the top patch on the chain in nova and the neutron patch14:04
adrianccan be applied manually after deploy :)14:05
sean-k-mooneyyep ill just create a branch locally and cherrypick them14:06
sean-k-mooneyits fine14:06
*** mriedem has joined #openstack-nova14:13
*** jonher_ has joined #openstack-nova14:17
*** rodolof has quit IRC14:20
*** jonher has quit IRC14:21
*** jonher_ is now known as jonher14:21
*** rodolof has joined #openstack-nova14:21
mriedemmelwitt: a change of mine hit the same vif plug timeout thing on that test with 7 ports http://logs.openstack.org/46/623246/3/check/nova-multiattach/efa830b/logs/screen-n-cpu.txt.gz?level=TRACE#_Dec_12_00_01_13_17947414:28
mriedembauzas: can you look at this? https://review.openstack.org/#/c/615347/ - it drops old confusing compat which is actually contributing to lots of misleading warnings in the n-api logs and gate race failures14:29
bauzasmriedem: sure14:29
sean-k-mooney mriedem ya i have seen that a few times14:29
*** k_mouza has joined #openstack-nova14:32
*** irclogbot_2 has quit IRC14:32
mriedemit's always the first port that we're missing14:33
mriedemwe get 6 of the 7 network-vif-plugged events14:33
sean-k-mooneymriedem: one edgecase that i am awre of is in some configuration we start waithing for the network events too late14:33
sean-k-mooneywe start waiting for the event just before we call plug on the interface14:34
sean-k-mooneyfor some neutron backend they send that event when we call bind14:34
sean-k-mooneyi assume this is ml2/ovs however correct?14:34
sean-k-mooneythat should not hit the race but i wonde if ther i a missed event in the logs14:35
mriedemyes ovs14:35
*** k_mouza__ has quit IRC14:35
*** k_mouza has quit IRC14:36
*** k_mouza has joined #openstack-nova14:37
sean-k-mooneymriedem: http://logs.openstack.org/46/623246/3/check/nova-multiattach/efa830b/logs/screen-n-cpu.txt.gz?#_Dec_12_00_01_07_48108414:37
mriedemwe plug it here14:37
mriedemDec 11 23:56:11.855811 ubuntu-xenial-inap-mtl01-0001136812 nova-compute[29399]: INFO os_vif [None req-f43f3c35-dc0b-4aa4-bfd0-4046045b315e tempest-TaggedBootDevicesTest-250467933 tempest-TaggedBootDevicesTest-250467933] Successfully plugged vif VIFOpenVSwitch(active=False,address=fa:16:3e:fb:dd:9f,bridge_name='br-int',has_traffic_filtering=True,id=472ab433-bc18-41b5-85ae-009611117b70,network=Network(4988ef3d-6a8f-477f-b0a2-2914:37
mriedem019494),plugin='ovs',port_profile=VIFPortProfileOpenVSwitch,preserve_on_delete=False,vif_name='tap472ab433-bc')14:37
mriedemhmm wtf14:38
mriedemi also see this right before that port is plugged14:38
mriedemDec 11 23:55:46.981194 ubuntu-xenial-inap-mtl01-0001136812 neutron-server[20899]: DEBUG neutron.notifiers.nova [-] Sending events: [{'tag': u'472ab433-bc18-41b5-85ae-009611117b70', 'name': 'network-changed', 'server_uuid': u'18e5987e-a535-4044-84aa-dd8f023cedcc'}] {{(pid=21001) send_events /opt/stack/new/neutron/neutron/notifiers/nova.py:245}}14:38
mriedemsean-k-mooney: that's a different port14:39
mriedemthe unplugged event14:39
sean-k-mooneymriedem: yes i just noticed that14:39
*** irclogbot_2 has joined #openstack-nova14:40
mriedemasking in -neutron14:42
*** moshele has joined #openstack-nova14:42
*** mmethot has quit IRC14:43
*** mmethot has joined #openstack-nova14:46
*** moshele has quit IRC14:47
*** irclogbot_2 has quit IRC14:52
fricklernova stable cores: https://review.openstack.org/619254 is waiting for a second +2, if it gets that, I can start nagging mriedem about stable releases instead ;-)14:53
*** yan0s has quit IRC14:55
*** mlavalle has joined #openstack-nova15:02
*** irclogbot_2 has joined #openstack-nova15:03
janguttermriedem: yonks ago I saw something similar that happened if the neutron-ovsdb linkage got busted.15:07
mriedemjangutter: i did see this in the neutron agent logs15:09
mriedemDec 11 23:56:12.725010 ubuntu-xenial-inap-mtl01-0001136812 neutron-openvswitch-agent[21879]: INFO neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [None req-cc26f856-2521-411e-ae10-34ad96b7c665 None None] Port 472ab433-bc18-41b5-85ae-009611117b70 was not found on the integration bridge and will therefore not be processed15:09
*** awaugama has joined #openstack-nova15:09
janguttermriedem: there's some extra metadata added by libvirt that links the port uuid. years ago I saw neutron triggering off of that.15:10
adriancsean-k-mooney: OK, so apparently on my setup i need to unbind/bind the VF, taking down the interface is not sufficient. this may be NIC vendor specific, let me know if interface down works for you OR you need to rebind the VF to flush out the MAC from the source node15:11
*** awaugama has quit IRC15:14
*** awaugama has joined #openstack-nova15:15
*** markvoelker has quit IRC15:18
*** yan0s has joined #openstack-nova15:20
sean-k-mooneyadrianc: rebinding the vf will be a problem if needed15:21
sean-k-mooneynova doen not always have permissions to do that.15:22
*** alexchadin has quit IRC15:22
*** lpetrut has quit IRC15:22
mriedemhello people - easy fix to get the postgresql job working again https://review.openstack.org/#/c/619061/15:23
mriedemcdent: ^ since you seem to care about pg15:23
mriedemslaweq: you too ^15:23
adriancsean-k-mooney: the fix should be in libvirt imo, once the guest is not on the machine, it should properly clean-up. however for the direct SRIOV you will not have this problem15:23
cdentmriedem: it's less care about pg, more care about not-just-mysql15:24
cdentbut yeah, looking15:24
sean-k-mooneyadrianc: well libvirt or qemu but yes one of the two shoudl notify the pf to reset the vf15:24
sean-k-mooneyadrianc: yes direct mode should work as the vf will be reset when it detached form the guest kernel and released to the host kernel15:25
janguttersean-k-mooney, adrianc: I think qemu does a function-level-reset on the VF when doing iommu passthrough.15:25
sean-k-mooneyjangutter: on a live migration15:25
janguttersean-k-mooney, adrianc: and libvirt does driver binding and unbinding.15:25
*** dtantsur|brb is now known as dtantsur15:25
sean-k-mooneyjangutter: in the macvtap case you do not bind the diriver to vfio-pci15:25
slaweqmriedem: it is this fix which will finally fix neutron pgsql periodic job, right?15:26
sean-k-mooneyjangutter: you leave it bound to the host kernel driver at all times15:26
janguttersean-k-mooney: yep, but permission-wise, libvirt could bind/unbind it as a workaround.15:26
janguttersean-k-mooney: and generally, you _don't_ want to do a FLR on something bound to a driver.15:26
sean-k-mooneyjangutter: it could yes but it wont today meaning we would need a new libvirt release and need to check for it in the code15:26
janguttersean-k-mooney: yep, tell me about it, I know all about people wanting to propagate libvirt "fixes".15:27
sean-k-mooneyi think this would be somthing that the sriov nic agent could resonalby handel too15:28
sean-k-mooneywell maybe not15:28
sean-k-mooneythat could be racy15:28
sean-k-mooneyit would have to be nova/libvirt to avoid races with other vms booting15:29
adriancsean-k-mooney: there is no FLR involved during detach/attach, the driver unbinds from the guest, and binds on the host whether or not it triggers an FLR is something the driver decides AFAIK15:29
jangutteradrianc: yep, FLR is mandatory on iommu passthrough I think, but not for driver bind/unbind15:29
sean-k-mooneywell it depend on if the vf is bound to say ixgbeVf when its detach or if it stays with vfio-pci15:30
janguttersean-k-mooney: yeah.15:30
adriancwould have been easier if setting VF mac address via ip link on the VF idx would have synced the mac address on the corresponding VF netdev :)15:31
sean-k-mooneyin any case however in macvtap mode we aparent dont  update the driver the vf is bound to or trigger a vf reset15:32
sean-k-mooneyadrianc: that silly talk why would a hardware/driver implementer ever do a thing like that :P15:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Add python 3.7 unit and functional tox jobs  https://review.openstack.org/62405515:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Replace ThreadPoolExecutor with GreenThreadPoolExecutor  https://review.openstack.org/62474015:32
gibicdent: ^^15:32
cdentroger15:32
mriedemslaweq: yeah15:33
janguttersean-k-mooney, adrianc: years ago we had looked at how to propagate MAC config from host to the VF and the conclusion we came to was that at the FLR is the safest way to do so. I don't think there was an async event able to propagate that info from the device to the driver without either a reset or rebind.15:33
slaweqmriedem: thx for taking care of it :)15:33
sean-k-mooneyadrianc: speacking of ip link ther eis no way to reset it via ip tools right.15:33
janguttersean-k-mooney, adrianc: the only way I know to trigger an FLR is via setpci...15:34
sean-k-mooneyjangutter: i was hoping there would be a standard sysfs file we could echo too but i guess not15:35
aspiersmriedem: if I understand the code right, the config drive disk mapping is built alongside the other disk mappings prior to instance launch (even though the config drive itself seems to be built late via post_xml_callback). so it's not hotplugged post-launch. Also I think it will either use "ide" or "virtio" bus (depending on whether iso9660 or vfat) and therefore we don't anticipate any problems with15:35
aspiersSEV. Nevertheless we're testing to make sure15:35
janguttersean-k-mooney: there might be these days, though.15:35
sean-k-mooneyjangutter: it would still likely be vendor specific15:35
janguttersean-k-mooney: very, I believe our driver only recently could propagate MAC on rebind. Previously you _had_ to get an FLR.15:36
sean-k-mooneyadrianc: im just getting around to setting up that test env now but i will try a few different things and let you know15:36
sean-k-mooneyshould i put this in the spec by the way. im inclined to say no as this is too technical/hardware specific15:37
adriancsean-k-mooney: ack, let me know if you can find a nicer WA15:37
adriancwell i dont think its related to the spec, its a long existing problem IMO and not related to live-migration15:38
sean-k-mooneywe need to adress this in the code obviously but i think code commetns/dev docs15:38
*** mchlumsky has quit IRC15:38
sean-k-mooneyadrianc: i guess you could consider it a cold migration bug15:38
adriancthere are additional gaps with macVtap like multiple port binding so15:38
*** rodolof has quit IRC15:38
*** rodolof has joined #openstack-nova15:39
*** mchlumsky has joined #openstack-nova15:40
*** maciejjozefczyk has quit IRC15:40
adriancsean-k-mooney: it can happen also without LM being involved, easiest is to boot a VM on node A delete and boot it on node B15:40
adriancthe mac will be reused and you hit the issue15:41
sean-k-mooneyadrianc: reusing the same neutorn port so that the mac and vlan remain the same15:41
adriancadrianc: yes, using the same neutron port15:41
adriancsean-k-mooney: ^15:42
sean-k-mooneyya ok that is proably ground enought to just treat this as a seperate bug and maybe backport the fix15:42
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir during evac with rbd  https://review.openstack.org/61847815:43
lyarwoodmriedem / mdbooth / melwitt ; ^ thanks again for the reviews, I appreciate just how ugly this is but hopefully this is btw but with downstream customers asking for this to be fixed back in Newton I'm being forced into a corner here tbh.15:45
lyarwoodthanks weechat--15:46
sean-k-mooneylyarwood: what wrong with weechat++15:46
lyarwood^ the above mess, I was trying to edit the line and it decided to send it out, fun times.15:47
*** lpetrut has joined #openstack-nova15:48
*** lpetrut has quit IRC15:56
*** tssurya has quit IRC15:57
*** Luzi has quit IRC15:57
mriedemmelwitt: did you see my question in your spec for configurable max volumes? https://review.openstack.org/#/c/597306/1/specs/stein/approved/conf-max-attach-volumes.rst@4416:02
melwittmriedem: I did, sorry. the immediate answer was "not 100% sure, need to check my notes again". it was "fun" tracing it all and I can't remember whether bfv vs attach additional end up using the same code path that leads to the limit of 26. I need to double check it in order to reply and haven't gotten to it yet16:05
mriedemok, but i'm assuming even if it's not the same code path, bfv would need a check somewhere for the config option to limit the number of volumes attached to an instance during spawn16:09
mriedemit might have to be here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L159816:10
mriedemor a new driver method called from _prep_block_devices16:10
mriedembecause you don't want to create or attach more than the limit before you get to driver.spawn just to have it fail and have to roll those all back16:10
*** gyee has joined #openstack-nova16:19
*** udesale has quit IRC16:19
melwittmriedem: yeah, I guess the context is in my WIP patch for the implementation I've put the check at a lower level where all of the code paths end up https://review.openstack.org/616777 there's a default impl in compute/utils that all drivers other than libvirt use, and libvirt has its own override16:20
melwittI don't have any func test coverage yet to verify it all works right, so I'm in process of writing those16:20
melwittbut if you want to take a quick look to point out anything bad that jumps out, I'd appreciate that16:20
mriedemyeah that won't cut it for bfv16:27
mriedemi'll leave a comment16:27
melwittthanks16:28
*** ttsiouts has quit IRC16:29
*** ttsiouts has joined #openstack-nova16:30
*** ttsiouts has quit IRC16:30
*** ttsiouts has joined #openstack-nova16:31
*** _alastor_ has joined #openstack-nova16:32
*** macza has joined #openstack-nova16:34
openstackgerritMerged openstack/nova master: Drop pre-cellsv2 compat in compute API.get()  https://review.openstack.org/61534716:38
*** moshele has joined #openstack-nova16:40
*** _alastor_ has quit IRC16:40
*** cfriesen has joined #openstack-nova16:42
*** cfriesen has quit IRC16:42
*** cfriesen has joined #openstack-nova16:42
*** sahid has quit IRC16:47
*** sahid has joined #openstack-nova16:47
*** tssurya has joined #openstack-nova16:51
*** itlinux has joined #openstack-nova16:53
openstackgerritChris Dent proposed openstack/os-resource-classes master: Sync STANDARDS with placement/nova rc_fields  https://review.openstack.org/62437016:53
openstackgerritChris Dent proposed openstack/os-resource-classes master: Tune up documentation to be more useful  https://review.openstack.org/62438416:53
moshelejangutter: hi16:56
janguttermoshele: hi, long time no chat!16:57
moshelejangutter: yes indeed16:57
moshelejangutter: I am not sure I understand you comments16:58
janguttermoshele: sorry, it's a bit late in the year....16:58
moshelejangutter:  https://review.openstack.org/#/c/619920/16:58
dansmithmriedem: was your lazy-load patch trying to get rid of the billion "Lock placement_client acquired" messages on startup?16:58
*** yan0s has quit IRC16:59
janguttermoshele: the first question is possibly the easiest: on the NIC you have two ports, B and C. I would have thought that it makes sense specifying "connect B and C" to the bridge?17:00
mriedemdansmith: yes17:02
mriedemhttps://review.openstack.org/#/c/623246/17:02
dansmithmriedem: yeah that's pretty bad17:03
mriedemit now removes the lock as well on jay's request17:03
dansmithmriedem: just noticed while reviewing the logs forthis: https://review.openstack.org/#/c/623284/417:06
*** ohorecny2 has quit IRC17:06
dansmithmriedem: which does now select the right rpc version once computes get started17:06
dansmithwhich was not happening before17:06
sean-k-mooneyadrianc: so yes if i just do "sudo ifconfig enp1s17f5 0" i does not fix the issue either17:07
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that allocated PF matches the used PF  https://review.openstack.org/62354317:07
mriedemdansmith: which job was that message from?17:08
mriedembecause on tempest-full nova-api starts up before there are any computes17:08
*** helenafm has quit IRC17:08
dansmithmriedem: tempest-full17:08
sean-k-mooneyadrianc: sorry "sudo ifconfig enp1s17f5 down"17:08
dansmithmriedem: right you see it fail once first, and then once computes are started, it finds the version17:08
dansmithmriedem: before that "all cells" patch, you saw the failure on start and it never finds them after that17:08
mriedemah yeah http://logs.openstack.org/84/623284/4/check/tempest-full/23568c2/controller/logs/screen-n-api.txt.gz#_Dec_11_20_56_12_00286717:09
mriedemhttp://logs.openstack.org/84/623284/4/check/tempest-full/23568c2/controller/logs/screen-n-api.txt.gz#_Dec_11_21_00_06_27432217:09
dansmithyep17:09
mriedemhuh wonder if i made devstack switch upgrade_levels=auto in stein or rocky...17:09
dansmithit's been a while I thought, so I'm surprised this didn't break us17:10
dansmithbut we also haven't had many rpc versions recently17:10
mriedemhttps://review.openstack.org/#/c/550108/17:10
mriedemwe went to auto upgrade levels in rocky17:10
dansmithwell, we'll definitely want to backport this17:11
mriedemhow far back do you think we need this to go?17:11
mriedempike?17:11
dansmithpike was when you could actually have multiple cells right? so yeah, there17:11
mriedemi guess no one is multicell in pike right now, that we know of17:11
mriedembut yeah17:11
mriedemcern would be the only one to have hit this17:11
dansmiththat we know of17:12
mriedemright17:12
mriedemcould be chinese telecoms that have backported this to havana already17:12
dansmithmelwitt: ready to approve this? https://review.openstack.org/#/c/623284/417:12
sean-k-mooneyadrianc: actully this time the vf still had the vm mac for some reason if i changed it with "sudo ip link set enp1s0f1 vf 6 mac 1e:d5:87:7c:6f:b1" i can ping17:12
melwittdansmith: yeah, hang on17:13
dansmithmriedem: why was that thing @synchronized in the first place?17:15
dansmithchanging that makes me more nervous than the mechanical lazy-loading17:15
mriedemdansmith: (1) yes i said the same, i.e. i didn't really want to munge that into the lazy-load patch i had, and (2) looking at the change that added the lock, it was added as a precaution - i linked to that from the commit message17:16
dansmithah sorry17:16
dansmithso you agree it's concerning but changed it anyway?17:17
mriedemjay, chris and eric seemed to think it was fine to remove the lock17:17
mriedemi didn't really want to change it within the same change that does the lazy-load,17:17
melwittI wondered the same. last efried had mentioned about it, I thought he had said the lock was needed. but didn't get into details17:17
mriedembut jay -1ed me over it17:17
melwittbut maybe I missed convo after that17:17
mriedemi don't care if we remove the lock or not really17:17
mriedemi didn't really want to do squash both things into the same patch, but again, the -117:18
mriedemhonestly i just wanted to move forward with it,17:18
mriedembut now jay and eric are gone17:18
dansmithI guess I'd just rather remove it but in a separate patch to avoid co-mingling the effects of these two changes, if we have to revert one, etc17:18
dansmithbut I'm probably over-thinking it17:18
mriedemi thought the same17:19
dansmithheh, your logs are flooded with the rpc thing, while looking for flooding with placement messages17:19
dansmithgetting all these committed would be, like, good17:19
mriedemyes, i'm spinning several gate plates right now17:19
mriedemthought about sending a summary to the ML17:20
melwittI'd want them separate for the potential revert reason too but since you've already been through the wringer on it, so we could just go ahead and do a partial revert if we have to for the lock thing *shrug*17:20
*** psachin|session has quit IRC17:20
mriedemi can also just remove the lock part of this if dansmith and melwitt agree to approve the lazy-load today17:20
mriedemand throw the lock remove at the end17:20
mriedemi will knife someone if i have to redo this again and then wait17:20
dansmithI was about to +2, so I'd definitely +2 two patches instead yeah17:20
dansmithbut whatever17:20
melwittI'm fine with removing the lock since it seems like everyone who knows about it said to just do it. just we're aware there might be fallout and have to revert that piece17:21
mriedemi shall redo it then17:21
sean-k-mooneyadrianc: http://paste.openstack.org/show/737154/ seting the vf mac via the pf fixes the issue17:21
dansmithmriedem: I will stand by for immediate +2age17:21
* melwitt looks at it now17:22
*** sridharg has quit IRC17:26
*** dtantsur is now known as dtantsur|afk17:26
*** ttsiouts has quit IRC17:33
*** ttsiouts has joined #openstack-nova17:34
openstackgerritMatt Riedemann proposed openstack/nova master: Only construct SchedulerReportClient on first access from API  https://review.openstack.org/62324617:35
openstackgerritMatt Riedemann proposed openstack/nova master: DRY up SchedulerReportClient init  https://review.openstack.org/62324717:35
openstackgerritMatt Riedemann proposed openstack/nova master: Remove lock on SchedulerReportClient._create_client  https://review.openstack.org/62477017:35
mriedemdansmith: melwitt: ^17:35
dansmithyou know, thinking about this.. maybe they should be one patch.17:35
openstackgerritStephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology  https://review.openstack.org/61108817:35
mriedemi hope you're just fucking with me17:36
dansmithwell, hear me out here17:36
*** k_mouza_ has joined #openstack-nova17:37
* mriedem sharpens the blade17:37
dansmithheh17:37
*** ttsiouts has quit IRC17:38
mriedemdansmith: remember looking at this? https://bugs.launchpad.net/nova/+bug/179929817:38
openstackLaunchpad bug 1799298 in OpenStack Compute (nova) rocky "Metadata API cross joining instance_metadata and instance_system_metadata" [Medium,Triaged]17:38
mriedemdid anything come of that?17:38
*** sahid has quit IRC17:38
dansmiththe thing that came out of it is I'm not sure it's worth the pain, but I did start on it17:39
mriedemwell, as a simple partial fix, we could just stop joining on system_metadata17:39
mriedemsince as far as i know that's only used if you've got a dynamic vendordata provider17:39
*** spatel has joined #openstack-nova17:40
spatelsean-k-mooney: Hey!17:40
dansmithyeah17:40
mriedemwe likely don't need to join on security_groups either...17:40
*** k_mouza has quit IRC17:41
spatelI have question, i have VLAN 200 in openstack with /24 public IP17:41
*** k_mouza_ has quit IRC17:41
sean-k-mooneysure ok17:41
spatelthat /24 about to get full, is it possible i can add new /24 pool in same VLAN 200?17:41
sean-k-mooneyyes neutron allows you to add multiple subnets to the same network17:41
sean-k-mooneyyou will need to add the second subnet to the router also17:42
*** panda is now known as panda|off17:43
spatelI have VLAN base networking not tenant base..17:43
spatelThis is the command i used to create my first subnet..17:43
spatelneutron subnet-create net_pub_vlan_200 71.xxx.xxx.0/24 --name sub_pub_vlan_200 --allocation-pool start=71.xxx.xxx.2,end=71.xxx.xxx.254 --dns-nameservers 8.8.8.8 --gateway=71.xxx.xxx.117:43
sean-k-mooneyspatel: we should peroably swap to the neutron channel but that is fine17:44
sean-k-mooneyvlan networks are still teant networks the terminology is a littel overloaded17:45
spatelYou are saying i add just add new public IP in same "net_pub_vlan_200" network?17:45
sean-k-mooneyyes you can17:45
spatelSomething like this?17:46
spatelneutron subnet-create net_pub_vlan_200 72.xxx.xxx.0/24 --name new_subnet_vlan_200 --allocation-pool start=72.xxx.xxx.2,end=72.xxx.xxx.254 --dns-nameservers 8.8.8.8 --gateway=72.xxx.xxx.117:46
sean-k-mooneyyep17:46
spatelnet_pub_vlan_200 will be same right?17:46
spatelperfect!! thanks for confirmation :)17:47
sean-k-mooneythe only other thing you need to do is add a new prot to the openstack or phyical router to connect to the new subnet17:47
spatelnew port?17:48
sean-k-mooneyif you are using a phyical provider router you need to asing 72.xxx.xxx.1 to it so it can act as a gatway but if you are using neutron routers then you just need to add a port on the neutron router to connet to n 72 subnet17:49
spateloh! yes i am running HSRP so yes.. i have to setup HSRP on my gateway switches :)17:50
sean-k-mooneyspatel: you can use the openstack router add subnet <route> 72.xxx.xxx.217:50
sean-k-mooneyah ok then ya you  are using phyical routers instead of neutron routers for you public network so you can skip the openstack router add subnet command17:52
*** rodolof has quit IRC17:56
spatelyes!!17:59
spatelsean-k-mooney: quick question, now i am planning to build new Openstack cloud with NATing style floating ip, not VLAN base18:00
spatelhow do i scale that network?  we have super high PPS rate in network... does virtual router can handle that traffic?18:00
spatelI have option for DVR18:00
sean-k-mooneyspatel: lets take the converstation to #openstack-neutron18:01
*** _alastor_ has joined #openstack-nova18:03
*** derekh has quit IRC18:04
spatelsean-k-mooney: thanks :)18:06
mriedemdansmith: can you think of anything besides flavor that we would have data migrated from system_metadata in the meta-api? i was thinking keypairs but that was different i think - it was a separate table and the data was migrated to extras18:07
dansmithyeah, not keypairs18:08
dansmithnothing off the top of my head, but I haven't thought about it much18:08
openstackgerritMatt Riedemann proposed openstack/nova master: Be smarter about DB joins in the metadata API  https://review.openstack.org/62477818:18
mriedemeasy peasy ^18:18
*** mriedem is now known as mriedem_lunch18:21
*** ralonsoh has quit IRC18:25
*** cdent has quit IRC18:31
*** Swami has joined #openstack-nova18:44
*** moshele has quit IRC18:44
*** wolverineav has joined #openstack-nova18:46
*** wolverineav has quit IRC18:46
*** wolverineav has joined #openstack-nova18:47
openstackgerritChris Dent proposed openstack/nova master: Use external placement in functional tests  https://review.openstack.org/61794118:47
openstackgerritChris Dent proposed openstack/nova master: Delete the placement code  https://review.openstack.org/61821518:50
*** tssurya has quit IRC18:51
*** wolverineav has quit IRC18:57
*** wolverineav has joined #openstack-nova19:03
*** spatel has quit IRC19:07
*** wolverineav has quit IRC19:07
*** wolverineav has joined #openstack-nova19:09
*** mriedem_lunch is now known as mriedem19:11
*** tbachman has quit IRC19:23
*** erlon has quit IRC19:33
*** tbachman has joined #openstack-nova19:35
*** rodolof has joined #openstack-nova19:56
*** wolverineav has quit IRC20:05
*** kmalloc is now known as notmorgan20:10
*** notmorgan is now known as morgan20:10
*** itlinux_ has joined #openstack-nova20:14
*** itlinux has quit IRC20:15
*** tbachman has quit IRC20:23
*** _alastor_ has quit IRC20:32
*** dklyle has joined #openstack-nova20:39
*** wolverineav has joined #openstack-nova20:44
*** wolverineav has quit IRC20:52
*** wolverineav has joined #openstack-nova20:55
*** rcernin has joined #openstack-nova21:06
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Handle tags in _bury_in_cell0  https://review.openstack.org/62481321:08
*** jmlowe has quit IRC21:10
*** lchabert2 has joined #openstack-nova21:11
*** jmlowe has joined #openstack-nova21:11
*** jmlowe has quit IRC21:13
*** jmlowe has joined #openstack-nova21:14
*** xek__ has quit IRC21:18
*** tbachman has joined #openstack-nova21:19
*** lchabert2 has quit IRC21:22
*** lchabert has joined #openstack-nova21:22
*** rodolof has quit IRC21:32
*** rodolof has joined #openstack-nova21:32
*** awaugama has quit IRC21:40
*** brandor5 has joined #openstack-nova21:43
brandor5hello everyone: can anyone tell me where I can find the newton nova api reference?21:43
*** lpetrut has joined #openstack-nova21:44
*** _alastor_ has joined #openstack-nova21:46
jonherbrandor5: this? https://developer.openstack.org/api-ref/compute/21:48
brandor5jonher: that's latest, I need the one for newton21:48
brandor5I'm trying to use the api to confirmResize after a migrate and I'm getting an error21:49
brandor5Cannot 'confirmResize' instance e1782f5c-7559-4cac-a628-6d4a75a015f4 while it is in vm_state stopped21:49
*** slaweq has quit IRC21:49
brandor5If i run `nova resize-confirm <instance_id>` it works and I'm running the same curl that it runs...21:50
mriedembrandor5: the api-ref on master should be the same for newton - where there are functional differences they should be called out with notes or microversions21:51
mriedemi.e. the api should be backward compatible21:51
brandor5mriedem: oh cool, thanks... any idea on the error I'm seeing?21:51
brandor5especially that it works when I use the command line client21:51
* mriedem pulls out the ledger21:51
mriedemcan't confirm a resize on a stopped vm in newton https://github.com/openstack/nova/blob/newton-eol/nova/compute/api.py#L292421:52
mriedemnor master https://github.com/openstack/nova/blob/master/nova/compute/api.py#L348921:52
brandor5hmm that's weird because `nova resize-confirm <instance id>` definitely works21:53
mriedemworks works? or just doesn't say it failed?21:53
brandor5works works21:53
mriedemwhich version of novaclient?21:53
brandor510.1.021:53
brandor5and when I run nova in debug I've verified that I'm running the same 'curl' that novaclient is running21:54
*** takashin has joined #openstack-nova21:54
mriedemno magic there https://github.com/openstack/python-novaclient/blob/10.1.0/novaclient/v2/servers.py#L153321:55
mriedemcan you show the server status before doing each (cli and curl) to verify?21:55
brandor5yeah, I'm doing that... I have a watch running `openstack server show <instance_id>`21:56
brandor5if I try to hit the api directly I get a 40921:56
mriedemso you have some script or something that's just auto-confirming a resize as soon as the instance status is VERIFY_RESIZE?21:56
brandor5if I use novaclient it works21:56
brandor5correct21:56
mriedemthere is a config option for auto-confirming migrations21:56
mriedem..21:56
brandor5yeah, that's across the board and the docs say it's not recommended... my script is just for putting a compute into 'maintenance' mode21:57
brandor5It's actually ansible playbook that sets maintenance mode, checks for errored instances, manually moves shutoff instances, and then blasts the active instances'21:58
brandor5unfortunately right now I can't use the command line clients because ansible tower doesn't have them installed... (that's a ticket i have open with redhat)21:59
mriedemgd red hat21:59
mriedemi can't see anything that would be a difference between the client and straight curl21:59
brandor5haha21:59
brandor5i'll keep poking then... double check my headers and whatnot21:59
brandor5thanks for the help21:59
*** wwriverrat_ has joined #openstack-nova21:59
mriedemare you polling on the 'status' field in the server show response or something like vm_state?22:00
*** itlinux_ has quit IRC22:00
*** dklyle has quit IRC22:00
*** itlinux has joined #openstack-nova22:00
brandor5https://pastebin.com/ijVe0J4222:01
melwittmriedem: what's the trick to bfv with more than one --block-device? I keep getting ERROR state saying 'no image supplied' even though the first one I give is bootindex=0 with source=image22:01
mriedembrandor5: that looks ok22:02
mriedemmelwitt: are you trying to attach data volumes or have nova create the volumes?22:02
*** mdbooth_ has joined #openstack-nova22:02
mriedemit's probably easiest to just boot and attach 2 data volumes (so not boot_index=0)22:02
melwittmriedem: I'm consistently trying to have nova create the boot volume, and attach a non-bootable volume I created in cinder ahead22:03
mriedemi.e. pre-existing volumes22:03
mriedemwhat is your source_type and destination_type?22:03
melwittthis was my latest attempt http://paste.openstack.org/show/737169/22:04
mriedem--block-device source=image,id=d7b0d7cb-1373-456d-bcec-29fbec2f84e1,dest=volume,size=1,shutdown=preserve,bootindex=022:04
mriedemis that id an image id?22:04
melwittyes22:04
mriedem--block-device source=volume,id=33550efe-6a7b-4956-a7e0-5bd50004ec30,dest=volume,size=1,shutdown=preserve22:04
mriedemand that id is a volume id?22:04
melwittand that one is a volume id22:04
mriedemyou don't need to specify size on the latter, but nova should ignore that22:05
melwittI think it can be done but I don't know how. I think I've seen launchpad bug reports where people were booting with multiple volumes22:05
*** mdbooth has quit IRC22:05
*** slaweq has joined #openstack-nova22:06
mriedemwhere are you seeing the "no image supplied"?22:06
melwittin the nova show fault field22:06
mriedemhttp://codesearch.openstack.org/?q=no%20image%20supplied&i=nope&files=&repos=22:06
mriedemthat's not in the code that i can see22:06
mriedembesides the show response22:06
mriedemwhich is normal22:06
mriedempaste your fault22:06
melwitthttp://paste.openstack.org/show/737170/22:07
melwittoh sorry22:07
melwittdammmit22:07
melwittthat was the image field22:08
Kevin_Zhengmriedem: just shelve the vm and all the volume will be in reserved status and cannot be detached22:08
mriedemyeah that's normal22:08
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Handle tags in _bury_in_cell0  https://review.openstack.org/62481322:08
mriedemb/c there is no image ref if you bfv22:08
mriedemKevin_Zheng: we have a tempest test that does exactly that22:08
melwittyeah, I am so rusty on this. that's embarrassing22:09
Kevin_ZhengI didn’t check yet but that’s the result I got22:09
mriedemgood thing i don't have a twitter account to let everyone know about this22:09
Kevin_ZhengAnd also the code does it22:09
melwittI was thinking that sentence was the fault field, but the fault field wasn't even showing because I wasn't authed as admin. lots of good stuff going on here22:09
melwitthaha yup22:10
*** slaweq has quit IRC22:10
mriedemKevin_Zheng: is this vanilla devstack or something with your detach boot volume changes applied?22:10
melwittfailure to prep block device, which is probably my conf limit code firing22:10
mriedemmelwitt: yes probably, and we don't reschedule on failures from _prep_block_device i don't think22:11
mriedemso we just crap out22:11
brandor5mriedem: i found the problem, the resize call was firing too fast... I put a "sleep" in for a few seconds and it worked22:11
Kevin_ZhengDevStack22:11
mriedembrandor5: hmm, that's weird, because as soon as the server status is VERIFY_RESIZE is should be ok to call confirmResize22:12
mriedemespecially because i'm sure tempest does exactly the same thing,22:12
mriedempoll for VERIFY_RESIZE and then immediately confirm22:12
brandor5yeah, that's what I'm doing22:13
brandor5if I sleep for 3 seconds after that it works22:13
Kevin_ZhengI did not change the shelve flow, I only change the detach attach flow and it will not affect as it was blocked in the very early stage calling begin-detaching22:13
*** sambetts_ has quit IRC22:13
brandor5unless my polling isn't working the way I think22:13
brandor5I'll double check that really quick22:14
mriedemthis is where nova-compute changes the status https://github.com/openstack/nova/blob/newton-eol/nova/compute/manager.py#L394322:14
mriedemthis is the api code for the status field https://github.com/openstack/nova/blob/newton-eol/nova/api/openstack/common.py#L7922:15
mriedemso once compute does the update to the db, and the api returns VERIFY_RESIZE is should be ok to confirm22:15
*** sambetts_ has joined #openstack-nova22:15
mriedemKevin_Zheng: did you look at the tempest test i pointed out?22:15
*** slaweq has joined #openstack-nova22:15
Kevin_ZhengNot yet, I will check it today22:16
mriedemgood morning btw22:16
mriedem6am what are you doing22:17
Kevin_ZhengMy kid fall down the bed so everyone is up:)22:17
mriedemha22:18
mriedemtime for guard rails22:18
mriedemor strapts22:18
mriedem*straps22:18
brandor5mriedem: found the problem... it was an error on my part... if you look at the paste I linked the register,until, retries, and delay options were indented incorrectly and not being honored....... so it was just running the cehck once and then moving on through22:18
mriedembrandor5: ah ok22:19
mriedemi knew it couldn't be nova's fault, nova is never at fault22:19
brandor5hehe22:19
Kevin_Zheng:) go back to sleep now22:19
brandor5it's dns22:19
mriedemit probably worked in the cli just b/c of a time delay22:19
brandor5or the network22:19
mriedembuilding the client and such22:19
mriedemor that22:19
brandor5those are my favorits :D22:19
*** slaweq has quit IRC22:20
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Handle tags in _bury_in_cell0  https://review.openstack.org/62482422:21
melwittconfirmed, it was my limit code. so it does work for bfv. and it didn't create a new volume before it failed. I will test it more, maybe it's too good to be true22:22
mriedemwe should get that fault message cleaned up to actually have the error message in it22:22
melwittaye22:23
*** mnasiadka_ has joined #openstack-nova22:23
*** s1061123 has joined #openstack-nova22:23
mriedemcould have sworn i did something in that code for that, but might have been logging22:23
*** awestin1_ has joined #openstack-nova22:23
mriedemyeah https://review.openstack.org/#/q/I20a5e8e5e10dd505c1b24c208f919c6550e9d1a422:24
mriedemmaybe "Failure prepping block device" is just your error message22:25
*** obre_ has joined #openstack-nova22:25
melwittindeed in the log: Failure prepping block device: TooManyDiskDevices: The maximum allowed number of disk devices to attach to a single instance has bee22:25
melwittn exceeded22:25
*** _alastor_ has quit IRC22:26
melwittle sigh, newline22:26
*** mnasiadka has quit IRC22:29
*** andreykurilin has quit IRC22:29
*** masayukig[m] has quit IRC22:29
*** obre has quit IRC22:29
*** s1061123_ has quit IRC22:29
*** awestin1 has quit IRC22:29
*** mlavalle has quit IRC22:29
*** smcginnis has quit IRC22:29
*** McNinja has quit IRC22:29
*** logan- has quit IRC22:29
*** awestin1_ is now known as awestin122:29
*** mnasiadka_ is now known as mnasiadka22:29
*** mlavalle has joined #openstack-nova22:30
*** wolverineav has quit IRC22:31
*** logan- has joined #openstack-nova22:31
*** trident has quit IRC22:32
*** gouthamr has quit IRC22:32
*** wolverineav has joined #openstack-nova22:32
*** lpetrut has quit IRC22:32
*** trident has joined #openstack-nova22:34
*** itlinux has quit IRC22:35
*** gouthamr has joined #openstack-nova22:35
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Handle tags in _bury_in_cell0  https://review.openstack.org/62482522:36
*** brandor5 has left #openstack-nova22:37
*** slaweq has joined #openstack-nova22:42
*** slaweq has quit IRC22:47
openstackgerritMatt Riedemann proposed openstack/nova master: Replace ThreadPoolExecutor with GreenThreadPoolExecutor  https://review.openstack.org/62474022:48
openstackgerritMatt Riedemann proposed openstack/nova master: Add python 3.7 unit and functional tox jobs  https://review.openstack.org/62405522:48
openstackgerritMatt Riedemann proposed openstack/nova master: Add py36/py37 functional jobs to the experimental queue  https://review.openstack.org/62482622:48
melwittfound that the error message gets squashed here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2341-L2343 and that's what ends up in the instance fault22:48
melwittfeels like a separate patch for improving the information there, I can try it and see how it looks, going to be a much longer string22:49
*** mchlumsky has quit IRC22:57
*** smcginnis has joined #openstack-nova23:08
*** dtrainor has quit IRC23:09
*** mlavalle has quit IRC23:13
openstackgerritMatt Riedemann proposed openstack/os-resource-classes master: Sync STANDARDS with placement/nova rc_fields  https://review.openstack.org/62437023:15
openstackgerritMatt Riedemann proposed openstack/os-resource-classes master: Tune up documentation to be more useful  https://review.openstack.org/62438423:15
*** dave-mccowan has quit IRC23:19
*** rodolof has quit IRC23:21
mriedemmelwitt: oh ok, we should just do similar in https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2341 then and probably include the underlying reason23:21
mriedemalso, duh duh duh nova-lvm job is busted (privsep) http://logs.openstack.org/43/619143/12/check/nova-lvm/786180c/logs/screen-n-cpu.txt.gz?level=TRACE#_Dec_12_12_35_39_60700223:21
*** rodolof has joined #openstack-nova23:21
melwittmriedem: yeah, doing it now. figured I should write up a bug too23:22
mriedemhttps://bugs.launchpad.net/nova/+bug/180824723:23
openstackLaunchpad bug 1808247 in OpenStack Compute (nova) "nova-lvm job failing with ArgsAlreadyParsedError (privsep)" [Medium,Confirmed]23:23
mriedemif only mikal were on irc23:24
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Create iproute.IPRoute() inside a context  https://review.openstack.org/62483123:28
openstackgerritMerged openstack/nova master: Make compute rpcapi version calculation check all cells  https://review.openstack.org/62328423:29
openstackgerritMerged openstack/nova master: Remove allocations before setting vm_status to SHELVED_OFFLOADED  https://review.openstack.org/62359623:29
openstackgerritmelanie witt proposed openstack/nova master: Propagate exception message from _prep_block_device  https://review.openstack.org/62483223:31
*** dtrainor has joined #openstack-nova23:31
melwittah, I guess I need a test to show it going to the fault message. or maybe just that the message from _prep_block_device gets included23:33
*** rodolof has quit IRC23:35
*** rodolof has joined #openstack-nova23:35
*** dklyle has joined #openstack-nova23:35
*** rodolof has quit IRC23:37
*** rodolof has joined #openstack-nova23:38
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Create iproute.IPRoute() inside a context  https://review.openstack.org/62483123:41
*** dklyle has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!