Friday, 2018-12-07

*** macza has quit IRC00:09
openstackgerritmelanie witt proposed openstack/nova master: Fixed concurrent access to direct io test file  https://review.openstack.org/51509100:11
*** licanwei has quit IRC00:20
*** igordc has quit IRC00:33
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1794996  https://review.openstack.org/62335800:40
openstackbug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem)00:40
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Fix InstanceNotFound during _destroy_evacuated_instances  https://review.openstack.org/62335900:40
*** mriedem has quit IRC00:45
*** rodolof has joined #openstack-nova00:46
*** Swami has quit IRC00:49
*** igordc has joined #openstack-nova01:01
*** gyee has quit IRC01:09
openstackgerritZhenyu Zheng proposed openstack/nova master: Handle tags in _bury_in_cell0  https://review.openstack.org/62185601:11
*** igordc has quit IRC01:16
*** igordc has joined #openstack-nova01:16
*** igordc has quit IRC01:16
*** brinzhang has joined #openstack-nova01:21
*** wolverineav has quit IRC01:55
*** yedongcan has joined #openstack-nova01:58
*** betherly has joined #openstack-nova01:59
*** dave-mccowan has quit IRC02:00
*** betherly has quit IRC02:04
*** mrsoul has joined #openstack-nova02:12
*** Dinesh_Bhor has joined #openstack-nova02:12
*** Sundar has quit IRC02:16
openstackgerritmelanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement and API database  https://review.openstack.org/50904202:26
*** cfriesen has quit IRC02:27
*** takashin has left #openstack-nova02:31
*** mhen has quit IRC02:34
*** mhen has joined #openstack-nova02:38
*** hongbin has joined #openstack-nova02:41
*** psachin has joined #openstack-nova02:53
*** imacdonn has quit IRC02:53
*** imacdonn has joined #openstack-nova02:53
*** awaugama has quit IRC03:00
*** betherly has joined #openstack-nova03:01
*** betherly has quit IRC03:05
*** dave-mccowan has joined #openstack-nova03:10
*** dave-mccowan has quit IRC03:19
*** lbragstad has quit IRC04:23
*** psachin has quit IRC04:41
*** wolverineav has joined #openstack-nova04:44
*** janki has joined #openstack-nova04:46
*** psachin has joined #openstack-nova04:58
*** diga has joined #openstack-nova05:04
*** rodolof has quit IRC05:10
*** licanwei has joined #openstack-nova05:12
openstackgerritMerged openstack/nova master: libvirt: Refactor handling of PCIe root ports  https://review.openstack.org/62032705:20
openstackgerritMerged openstack/nova stable/queens: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61922005:20
openstackgerritMerged openstack/nova stable/queens: Add regression test for bug #1764883  https://review.openstack.org/62119905:20
openstackbug 1764883 in OpenStack Compute (nova) queens "Evacuation fails if the source host returns while the migration is still in progress" [Medium,In progress] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood)05:20
*** wolverineav has quit IRC05:21
*** takashin has joined #openstack-nova05:25
*** rodolof has joined #openstack-nova05:25
*** cfriesen has joined #openstack-nova05:26
*** rodolof has quit IRC05:31
*** wolverineav has joined #openstack-nova05:32
*** wolverineav has quit IRC05:36
*** ratailor has joined #openstack-nova05:57
*** sridharg has joined #openstack-nova05:57
*** Luzi has joined #openstack-nova06:03
*** diga has quit IRC06:04
*** Dinesh_Bhor has quit IRC06:04
*** takashin has left #openstack-nova06:30
*** yikun_ has joined #openstack-nova06:32
*** hongbin has quit IRC06:32
*** ohorecny2 has joined #openstack-nova06:37
openstackgerritMerged openstack/nova stable/queens: compute: Ensure pre-migrating instances are destroyed during init_host  https://review.openstack.org/62120006:37
*** lei-zh has joined #openstack-nova06:38
openstackgerritMerged openstack/nova stable/pike: Update docs for _destroy_evacuated_instances  https://review.openstack.org/62120306:39
*** Dinesh_Bhor has joined #openstack-nova06:53
*** tetsuro has joined #openstack-nova06:55
*** tetsuro_ has joined #openstack-nova06:58
*** tetsuro has quit IRC07:01
*** rcernin has quit IRC07:01
*** betherly has joined #openstack-nova07:08
*** dklyle has quit IRC07:09
*** dklyle has joined #openstack-nova07:10
*** betherly has quit IRC07:13
*** cfriesen has quit IRC07:14
*** tetsuro_ has quit IRC07:18
*** belmoreira has quit IRC07:21
*** tetsuro has joined #openstack-nova07:22
*** trident has quit IRC07:23
*** dpawlik has joined #openstack-nova07:24
*** belmoreira has joined #openstack-nova07:24
*** trident has joined #openstack-nova07:25
*** tetsuro_ has joined #openstack-nova07:28
*** tetsuro has quit IRC07:29
*** alexchadin has joined #openstack-nova07:35
*** tetsuro_ has quit IRC07:37
*** tetsuro has joined #openstack-nova07:40
*** dims has quit IRC07:44
*** dims has joined #openstack-nova07:47
*** awalende has joined #openstack-nova08:11
*** rambo_li has joined #openstack-nova08:12
*** Dinesh_Bhor has quit IRC08:14
*** rambo_li has quit IRC08:19
*** Dinesh_Bhor has joined #openstack-nova08:19
*** rambo_li has joined #openstack-nova08:23
*** awalende has quit IRC08:30
*** mcgiggler has joined #openstack-nova08:35
*** tetsuro_ has joined #openstack-nova08:36
*** tetsuro has quit IRC08:38
*** tetsuro_ has quit IRC08:55
*** yan0s has joined #openstack-nova08:55
*** sahid has joined #openstack-nova08:55
*** ratailor has quit IRC08:56
*** tetsuro has joined #openstack-nova08:58
*** ratailor has joined #openstack-nova08:58
*** KeithMnemonic has quit IRC09:00
*** KeithMnemonic has joined #openstack-nova09:01
*** ccamacho has joined #openstack-nova09:09
*** ccamacho has quit IRC09:09
*** tssurya has joined #openstack-nova09:10
*** Dinesh_Bhor has quit IRC09:11
*** Dinesh_Bhor has joined #openstack-nova09:12
*** sahid has quit IRC09:14
*** sahid has joined #openstack-nova09:14
*** tetsuro_ has joined #openstack-nova09:14
*** ccamacho has joined #openstack-nova09:15
*** tetsuro has quit IRC09:18
*** licanwei has quit IRC09:18
*** alexchadin has quit IRC09:24
*** k_mouza has joined #openstack-nova09:27
*** tetsuro_ has quit IRC09:29
*** tetsuro has joined #openstack-nova09:30
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore MoxStubout deprecation warnings  https://review.openstack.org/62330909:30
*** alex_xu has quit IRC09:30
*** lei-zh has quit IRC09:33
*** Dinesh_Bhor has quit IRC09:40
*** k_mouza has quit IRC09:42
*** tetsuro has quit IRC09:42
*** cdent has joined #openstack-nova09:42
*** tetsuro has joined #openstack-nova09:43
*** k_mouza has joined #openstack-nova09:43
cdentstephenfin: I'm confused and frustrated and stuck on https://review.openstack.org/#/c/622972/ If you have any ideas, or can just fix it, that would be most helpful.09:43
* cdent makes more coffee09:43
*** tetsuro_ has joined #openstack-nova09:54
*** tetsuro has quit IRC09:55
*** tetsuro has joined #openstack-nova10:03
*** tetsuro_ has quit IRC10:04
*** maciejjozefczyk has quit IRC10:05
*** maciejjozefczyk has joined #openstack-nova10:07
*** ttsiouts has joined #openstack-nova10:16
*** trident has quit IRC10:18
mdboothlyarwood: https://review.openstack.org/#/c/618478/ I agree with melwitt's comment that instance.host checking is a risk. Could you audit it? We're hopefully ok.10:20
lyarwoodmdbooth: I've had a look already and I couldn't see a way for us to call cleanup on the source during a failure10:21
*** trident has joined #openstack-nova10:21
lyarwoodmdbooth: we would call it on the dest but the whole point of the workaround is to ensure the directory is cleaned when it _isn't_ shared10:21
lyarwoodmdbooth: so if it's enabled in that situation that's on the operator10:21
mdboothlyarwood: I would personally start by looking at everywhere in ComputeManager which sets instance.host, and work back from there. Don't assume it necessarily makes sense.10:22
lyarwoodmdbooth: there's zero point in looking at that if we don't call cleanup on the source during a failure10:22
*** dpawlik has quit IRC10:23
*** dpawlik has joined #openstack-nova10:23
lyarwoodmdbooth: which we wouldn't do for LM, either post-copy or pre-copy AFAIK10:23
lyarwoodI'll look again at where we are calling cleanup to confirm but I'm sure this isn't an issue10:23
mdboothlyarwood: I strongly suspect it isn't an issue.10:24
*** tetsuro_ has joined #openstack-nova10:24
* mdbooth is +0.8 ;)10:24
* lyarwood files a gerrit RFE for review range sliders10:25
lyarwoodDNM 0 [-------x--] 1 LGTM10:25
mdboothlyarwood: +110:26
*** tetsuro has quit IRC10:27
mdboothlyarwood: Are there any circumstances where we could end up calling cleanup on the source (e.g. init_host, periodic) where instance.host is erroneously set to dest?10:27
openstackgerritStephen Finucane proposed openstack/nova master: Correct lower-constraints.txt and the related tox job  https://review.openstack.org/62297210:28
*** k_mouza has quit IRC10:29
*** ttsiouts has quit IRC10:31
lyarwoodmdbooth: cleaning up evacuations that have failed in a weird way but again with this workaround enabled you'd only see console.log, kernel etc removed10:31
*** ccamacho has quit IRC10:31
*** ttsiouts has joined #openstack-nova10:31
lyarwoodmdbooth: I can't say I've ever seen an evacuation fail in that way however10:31
lyarwoodmdbooth: instance.host updated but the instance is still on the source10:32
mdbooths/still on the source/isn't on the dest/10:32
mdboothalthough we still wouldn't have deleted the actual instance data as you say10:32
mdboothSo probably not the worst.10:33
*** ccamacho has joined #openstack-nova10:41
*** brinzhang has quit IRC10:48
*** mdbooth has quit IRC10:48
*** alex_xu has joined #openstack-nova10:48
* alex_xu is in vacation for next whole week10:49
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells  https://review.openstack.org/59165710:49
gibialex_xu: have a nice vacation10:49
*** sapd1_ has joined #openstack-nova10:50
*** k_mouza has joined #openstack-nova10:52
*** rambo_li has quit IRC10:57
*** wolverineav has joined #openstack-nova11:00
*** cdent has quit IRC11:01
*** tetsuro_ has quit IRC11:02
*** trident has quit IRC11:04
*** wolverineav has quit IRC11:05
*** trident has joined #openstack-nova11:06
*** maciejjozefczyk has quit IRC11:13
*** maciejjozefczyk has joined #openstack-nova11:15
*** sapd1_ has quit IRC11:17
*** sapd1_ has joined #openstack-nova11:20
*** cdent has joined #openstack-nova11:28
*** tbachman has quit IRC11:29
*** sc has joined #openstack-nova11:30
*** sapd1_ has quit IRC11:35
openstackgerritDongcan Ye proposed openstack/nova master: Remove other volume snapshot type  https://review.openstack.org/62345611:36
*** yedongcan has left #openstack-nova11:46
*** sapd1_ has joined #openstack-nova11:51
*** dtantsur|afk is now known as dtantsur\11:54
*** dtantsur\ is now known as dtantsur11:54
*** sapd1_ has quit IRC11:56
*** slaweq has joined #openstack-nova12:03
openstackgerritsean mooney proposed openstack/os-vif master: add isolate_vif config option  https://review.openstack.org/61253412:22
*** mcgiggler has quit IRC12:27
openstackgerritGaudenz Steinlin proposed openstack/nova master: Extend volume for libvirt network volumes (RBD)  https://review.openstack.org/61303912:39
*** trident has quit IRC12:39
*** kaisers has quit IRC12:39
*** trident has joined #openstack-nova12:41
*** psachin has quit IRC12:41
cdentstephenfin: it looks like your change on the constraints job gets things to pass, which suggests that skipsdist is not working in a per-env setting?12:47
stephenfincdent: Yup, I think I called that out in a comment/the commit message?12:47
cdentbut it's also confusing that different behaviors are happening between my box and the gate.12:47
stephenfincdent: It's a global option12:47
*** tbachman has joined #openstack-nova12:47
stephenfinI'd imagine it's the version of tox12:48
cdentthey are the same12:48
cdentthat's why it is confusing12:48
stephenfinHmm. Have you wiped your .tox directory?12:48
cdentnot the whole thing, but the specific env12:49
cdentthe vm I was using is at home, so I cant' look now, but will check when I'm back home12:49
stephenfinI've no idea what's going on, in that case. Might be worth asking the tox devs, in case they've any ideas. The funkiness that pbr introduces could throw even them though12:50
cdentI'll also check to make sure that the job is sitll working as designed12:50
*** Luzi has quit IRC12:51
cdentyeah, pbr...12:51
cdentif it's happy as is, I'm happy to just move ...12:51
cdenton12:51
cdentwasted way more time on this than I wanted12:51
*** tbachman has quit IRC12:52
cdent"wasted way more time on this than I wanted" <- nova, defined12:55
*** kaisers has joined #openstack-nova12:56
*** tbachman has joined #openstack-nova12:58
*** sapd1_ has joined #openstack-nova13:02
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver  https://review.openstack.org/55419513:04
*** sapd1_ has quit IRC13:07
*** artom has quit IRC13:11
*** cdent has quit IRC13:17
*** ratailor has quit IRC13:22
*** mlavalle has joined #openstack-nova13:24
*** janki has quit IRC13:24
openstackgerritMerged openstack/os-vif master: always create ovs port during plug  https://review.openstack.org/60238413:33
openstackgerritLee Yarwood proposed openstack/nova master: WIP compute: reject migration request when source compute is disabled  https://review.openstack.org/62348913:34
openstackgerritMerged openstack/nova master: Use tempest [compute]/build_timeout in evacuate tests  https://review.openstack.org/62301113:39
*** edleafe- has joined #openstack-nova13:42
*** edmondsw has quit IRC13:42
*** edleafe has quit IRC13:43
*** edleafe- is now known as edleafe13:43
*** cfriesen has joined #openstack-nova13:45
*** _pewp_ has quit IRC13:49
scI need some help w/ configuring PCI passthrough in a newton based installation, I followed the newton admin guide but the scheduler returns 0 of 6 hosts.13:50
scwhat do you suggest to look for? In the compute host dmesg reports the iommu as enabled and I see a nice list of PCI cards, including the GPU I would like to pass to my VM13:51
*** tssurya has quit IRC13:59
*** ttsiouts has quit IRC14:01
*** ttsiouts has joined #openstack-nova14:01
*** ttsiouts has quit IRC14:06
*** eharney has quit IRC14:06
*** lbragstad has joined #openstack-nova14:06
*** edmondsw has joined #openstack-nova14:12
*** ttsiouts has joined #openstack-nova14:12
*** _hemna has quit IRC14:13
*** tbachman has quit IRC14:17
*** cdent has joined #openstack-nova14:18
*** ttsiouts has quit IRC14:18
*** mriedem has joined #openstack-nova14:25
*** lbragstad has quit IRC14:25
*** lbragstad has joined #openstack-nova14:29
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver  https://review.openstack.org/55419514:31
*** wolverineav has joined #openstack-nova14:36
*** kaisers_ has quit IRC14:37
*** wolverineav has quit IRC14:41
*** Dinesh_Bhor has joined #openstack-nova14:42
*** mvkr has quit IRC14:42
*** takamatsu has joined #openstack-nova14:43
*** tbachman has joined #openstack-nova14:47
*** ratailor has joined #openstack-nova14:49
openstackgerritMerged openstack/nova master: Update compute API.get() stubs for test_*security_groups  https://review.openstack.org/61534414:49
*** awaugama has joined #openstack-nova14:49
openstackgerritMerged openstack/nova master: Update compute API.get() stubs for test_disk_config  https://review.openstack.org/61534514:49
openstackgerritMerged openstack/nova master: Update compute API.get() stubs in test_access_ips  https://review.openstack.org/61534614:49
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350714:50
*** tssurya has joined #openstack-nova14:50
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350914:51
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62351014:52
*** Dinesh_Bhor has quit IRC14:56
*** ccamacho has quit IRC15:00
openstackgerritDan Smith proposed openstack/nova master: Only warn about not having computes nodes once in rpcapi  https://review.openstack.org/62328215:03
openstackgerritDan Smith proposed openstack/nova master: Make compute rpcapi version calculation check all cells  https://review.openstack.org/62328415:03
openstackgerritDan Smith proposed openstack/nova master: Make service.get_minimum_version_all_cells() cache the results  https://review.openstack.org/62328315:03
dansmithmriedem: melwitt: ^ this should be good now I think. also fixed something in the base patch that was causing a non-deterministic run in the later patches15:04
*** slaweq has quit IRC15:04
melwittcool, thanks15:05
*** eharney has joined #openstack-nova15:05
mriedemon an unrelated note, i propose that we disable snapshot tests in the cells v1 job http://logs.openstack.org/47/623247/2/check/nova-cells-v1/18338f0/job-output.txt.gz15:07
mriedemsnapshot with cells v1 in tempest is historically racy https://bugs.launchpad.net/nova/+bug/162076115:07
openstackLaunchpad bug 1620761 in OpenStack Compute (nova) "test_create_second_image_when_first_image_is_being_saved intermittently times out in teardown in cells v1 job" [Undecided,Invalid]15:07
mriedemgiven the deprecated nature of cells v1 and the state of the gate, the less we can fail on the better15:07
dansmithmriedem: fine with me15:08
mriedemalright then15:08
dansmithI also wouldn't be opposed to making a statement in stein that cellsv1 is deprecated fully, we're not going to test it anymore, and we'll be ripping the code out at whatever pace we feel is achievable15:09
dansmithwe know that the removal of v1 and n-net aren't trivial, so the actual removal will take time, but I think we could go ahead and drive the stake through the heart15:09
*** lei-zh has joined #openstack-nova15:10
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells  https://review.openstack.org/59165715:10
*** ttsiouts has joined #openstack-nova15:12
*** N3l1x has joined #openstack-nova15:12
mriedemshrug. we neutered quite a bit of the n-net specific apis in rocky, there are a couple lingering that i think would be priority to remove first, and maybe the os-cells api15:12
*** dpawlik has quit IRC15:12
mriedemi also wouldn't want that to distract from the other stuff that's already not getting attention, so close to the 2nd milestone15:12
dansmiththat's why I'm saying we don't have to do anything, just remove the test and land a reno15:13
dansmithbut that's just MHO15:13
dansmiththe test job Imean15:13
mriedemremove the entire nova-cells-v1 job you mean?15:13
mriedemyeah15:13
*** Luzi has joined #openstack-nova15:14
mriedemit is using neutron at this point, so it doesn't really help cern as a n-net 50% user to keep it around15:14
mriedemsince cern is cells v2 now15:14
dansmithyeah15:14
dansmithmelwitt is on the worst call evar right now, so maybe just pause until she's done and can opine15:14
* bauzas nods :p15:15
melwitthaha :) yeah....15:15
*** jarodwl has quit IRC15:16
*** jarodwl has joined #openstack-nova15:17
melwittmriedem: definitely ok with me to disable snapshot tests. and no strong opinion about removing the entire job. I think we'd be ok removing the job considering everyone's moved/moving off of it. I think nectar is the only other one? and mgagne_?15:17
mriedemsorrison said they are on pike i think, and v1 but looking at v215:18
mriedemmgagne_ i think is still on mitaka15:18
*** ccamacho has joined #openstack-nova15:18
dansmithremoving the tests several releases ahead of both of those would help send a message that it's time15:18
dansmithas if cern being on it wasn't enough15:18
dansmithcontinuing to whittle away at what it tests is also fine, but looking at how stressed the gate is, one fewer devstack runs for each nova patch seems like a decent win to me15:20
melwittyeah, on one hand I think we could disable the snapshot tests and if all is well after that, then we have some coverage for sorrison and mgagne_ sake. but if the job keeps being a thorn and failing then look again at removing the entire job15:21
mriedemfwiw it's also tempest and devstack that run it15:21
mriedemalternative is, move it to experimental15:22
mriedemso it's run on deman15:22
mriedem*demand15:22
*** _hemna has joined #openstack-nova15:22
dansmithmriedem: yeah, that would be good15:22
melwittyeah, that's a nice alternative I didn't think of15:22
mriedemcaught me with my pants down https://review.openstack.org/#/q/topic:rm-nova-cells-v1-job+(status:open+OR+status:merged)15:22
mriedemok i'll change those15:22
dansmithnova, tempest and devstack is a lot of running a heavy job for something we're just going to disable if any tests fail :/15:22
*** trident has quit IRC15:25
*** trident has joined #openstack-nova15:27
*** artom has joined #openstack-nova15:32
*** Luzi has quit IRC15:32
*** artom has quit IRC15:35
*** ShilpaSD has quit IRC15:36
*** eharney has quit IRC15:37
*** artom has joined #openstack-nova15:40
*** pchavva has joined #openstack-nova15:41
*** dpawlik has joined #openstack-nova15:41
lei-zhHi jaypipes sean-k-mooney, would you take a look at https://review.openstack.org/#/c/601596/ and https://review.openstack.org/#/c/622893/ when you have spare time15:42
sean-k-mooneylei-zh: yes ill add them to my review queue15:44
lei-zhsean-k-mooney: thanks15:44
lei-zhwe have split the original spec into two specs, one general and one specific to libvirt driver implementation, hope this will be helpful for people to understand15:45
sean-k-mooneylei-zh: do you know waht is the state of the code/ci for this is?15:45
sean-k-mooneylei-zh: ok i was wondering why it was split but that makes sense15:45
*** dpawlik has quit IRC15:46
lei-zhsean-k-mooney: we have worked out some poc code and will continue to improve them15:47
sean-k-mooneycool is as part of the poc is there a way to test this without real persitent memory . i belive qemu can fake it with a file backed correct15:48
*** k_mouza has quit IRC15:48
sean-k-mooneyjust wondering how feasibel testing this would be15:48
*** k_mouza has joined #openstack-nova15:49
lei-zhsean-k-mooney: ci is also in the list but we plan to start working on that when the code is more ready15:49
lei-zhsean-k-mooney: currently my colleagues are testing this on real hardware, I'm not sure about qemu simulation, I will ask them about this and sync with you15:51
*** eharney has joined #openstack-nova15:52
sean-k-mooneyya no worries. it would be nice to test this upstream at somepoint but its not a blocker15:52
lei-zhyeah, thanks for pointing out that15:53
*** ohorecny2 has quit IRC15:57
*** ratailor has quit IRC15:57
*** janki has joined #openstack-nova16:00
*** lei-zh has quit IRC16:03
openstackgerritMatt Riedemann proposed openstack/nova master: Move nova-cells-v1 to experimental queue  https://review.openstack.org/62353816:03
mriedemhttps://review.openstack.org/#/q/topic:bug/1807407+(status:open+OR+status:merged)16:04
*** tbachman has quit IRC16:04
*** ttsiouts has quit IRC16:06
openstackgerritMerged openstack/nova stable/rocky: Add description of custom resource classes  https://review.openstack.org/61912216:07
openstackgerritMerged openstack/nova stable/rocky: Mention meta key suffix in tenant isolation with placement docs  https://review.openstack.org/61753516:08
cdentmriedem++ on cellsv1 job experimental16:09
sean-k-mooneyjaypipes: stephenfin hopefully a quick one but can ye look at https://review.openstack.org/#/c/612534/16:10
mriedemcdent: jaypipes: i'm going to need you guys to tell me if we can remove the SchedulerReportClient lock https://review.openstack.org/#/c/623246/2//COMMIT_MSG@1116:12
mriedemsince between you guys and efried_cya_jan it was added16:12
*** ttsiouts has joined #openstack-nova16:13
cdentlooking16:13
jaypipesmriedem: I don't see any reason for it.16:16
jaypipesmriedem: there's no state being fetched on init.16:17
jaypipesmriedem: was more than likely just a copy/pasta from something else.16:17
*** ttsiouts has quit IRC16:18
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that allocated PF matches the used PF  https://review.openstack.org/62354316:18
mriedemjaypipes: did you see the change in which it was added?16:18
mriedemhttps://review.openstack.org/#/c/493536/16:18
mriedemi guess it was added for safety precautions16:19
mriedemif we're meh on that now, then sure we can remove it16:19
cdentmriedem, jaypipes: based on the commit message on https://review.openstack.org/493536 it looks gratuitous16:19
mriedemif i'm going to remove the lock, i might as well also make it a singleton in the api since we don't need 70 of these created when it's used in 3 places16:19
jaypipesmriedem: from the commit message: "I've made the _client method synchronized so that in the unlikely event that the resource tracker is trying to do its update job while some other thing is happening, we won't waste the client. This may not be necessary, but probably doesn't harm anything."16:20
mriedemi know, i read it16:20
cdentgiven that I never synchronize anything, I'm guess somewhere along the way it was suggested as a "maybe you should..." and I just did, without any real data16:20
jaypipescdent: either that, or copy/pasta from somewhere in the resource tracker way back when... not sure, either way, I'm pretty sure it's unnecessary.16:21
cdentwe'll find out soon enough, I reckon16:21
melwittbauzas: reminder that review comments on the reshaper patch await your reply https://review.openstack.org/59920816:22
cdentgenerally speaking, unless we can come up with a really good reason for a lock, we should not16:23
bauzasmelwitt: ok, I was thinking those details were pretty nitty, but I'll then provide a new revision16:23
mriedembauzas: if you thought that, you could have said so weeks ago...16:24
melwittbauzas: ok. you don't necessarily have to push a new revision but could make a comment in response so we know your thoughts16:24
mriedemor talked with artom16:24
*** gyee has joined #openstack-nova16:25
*** mvkr has joined #openstack-nova16:27
*** rodolof has joined #openstack-nova16:30
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Ignore MoxStubout deprecation warnings  https://review.openstack.org/62354516:32
*** tbachman has joined #openstack-nova16:35
*** jaypipes is now known as leakypipes16:39
*** macza has joined #openstack-nova16:39
*** erlon has quit IRC16:42
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Note the aggregate allocation ratio restriction in scheduler docs  https://review.openstack.org/62354616:52
*** erlon has joined #openstack-nova16:54
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Note the aggregate allocation ratio restriction in scheduler docs  https://review.openstack.org/62354716:56
*** sean-k-mooney has quit IRC16:59
*** tssurya has quit IRC17:01
*** nicolasbock has joined #openstack-nova17:04
*** sean-k-mooney has joined #openstack-nova17:05
artommriedem, bauzas, are we seriously OK with the length of those methods? I won't be a pain just for the hell of it, and I understand that sometimes old code grows beyond what we want, but brand new code?17:09
nicolasbockHi, I have a server on Newton that after a migration attempt shows `task_state = resize_finish`, `status = RESIZE`. I can't resize confirm or start the server. I don't see any obvious error messages in the nova-compute logs on either the old nor the new hypervisor.17:09
artomI dunno, I just have trouble with that17:09
nicolasbockThe resized disks have the same md5sum on either hypervisor17:09
artomIf everyone's overruling me there's not much I can do, but I wanted to at least make that point17:09
mriedemartom: i'm not disagreeing with your comments17:09
nicolasbockBasically, I am wondering what the problem could be?17:10
artommriedem, ok, cool, thanks :)17:10
mriedemnicolasbock: looks like something probably failed during the resize (maybe a db change?) where the task_state was not set to None17:10
mriedemso check the compute and conductor logs for errors17:10
nicolasbockthe logs on the destination ?17:11
nicolasbockAnd thanks mriedem17:11
mriedemyeah finish resize happens on the dest machine17:12
*** k_mouza has quit IRC17:12
mriedemdb errors would be in conductor logs though17:13
nicolasbockThe compute only says: `nova-compute.log:2018-12-07 17:08:04.883 26498 INFO nova.compute.manager [-] [instance: 585b884f-29be-4bb1-8f95-8f5e4c02127d] During sync_power_state the instance has a pending task (resize_finish). Skip.`17:13
mriedemthis is where that task_state would be set https://github.com/openstack/nova/blob/newton-eol/nova/compute/manager.py#L391317:14
nicolasbockI am going through the conductor logs now17:14
mriedemand then task_state=None when done https://github.com/openstack/nova/blob/newton-eol/nova/compute/manager.py#L394617:14
mriedemif something blew up in there, this should reset the task_state to None https://github.com/openstack/nova/blob/newton-eol/nova/compute/manager.py#L395417:14
mriedembut if you're having db problems, it's a crapshoot17:14
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Note the aggregate allocation ratio restriction in scheduler docs  https://review.openstack.org/62355217:15
*** k_mouza has joined #openstack-nova17:17
*** mriedem is now known as mriedem_lunch17:19
nicolasbockI don't see any DB errors either. Strange.17:20
*** dims has quit IRC17:21
*** dtantsur is now known as dtantsur|afk17:22
*** wolverineav has joined #openstack-nova17:23
*** wolverineav has quit IRC17:27
*** sahid has quit IRC17:30
*** janki has quit IRC17:33
*** k_mouza_ has joined #openstack-nova17:35
*** k_mouza has quit IRC17:37
*** k_mouza_ has quit IRC17:39
aspiersmriedem_lunch: thanks a lot for the quick reply - will get you those confirmations about volume-backed and config drive ASAP17:50
*** k_mouza has joined #openstack-nova17:55
*** k_mouza has quit IRC17:59
*** pchavva has left #openstack-nova18:00
openstackgerritMerged openstack/nova stable/rocky: Add functional recreate test for bug 1799727  https://review.openstack.org/61456318:10
openstackbug 1799727 in OpenStack Compute (nova) rocky "CPU_Allocation_Ratio from nova.conf doesn't update exisiting providers" [High,In progress] https://launchpad.net/bugs/1799727 - Assigned to Matt Riedemann (mriedem)18:10
*** sridharg has quit IRC18:11
openstackgerritMerged openstack/nova stable/rocky: Provide allocation_ratio/reserved amounts from update_provider_tree()  https://review.openstack.org/61456418:11
openstackgerritMerged openstack/nova stable/rocky: Add regression test for bug 1796737  https://review.openstack.org/61458718:11
openstackbug 1796737 in OpenStack Compute (nova) rocky "resize: hypervisor local_gb_used still reports usage even with volume-backed instances after fix for bug 1469179" [Medium,In progress] https://launchpad.net/bugs/1796737 - Assigned to Matt Riedemann (mriedem)18:11
openstackgerritMerged openstack/nova stable/rocky: Properly track local root disk usage during moves  https://review.openstack.org/61458818:11
openstackgerritMerged openstack/nova stable/rocky: Time how long select_destinations() takes in conductor  https://review.openstack.org/60857518:11
openstackgerritMerged openstack/nova stable/rocky: Refix disk size during live migration with disk over-commit  https://review.openstack.org/60247718:11
openstackgerritMerged openstack/nova stable/rocky: Handle IndexError in _populate_neutron_binding_profile  https://review.openstack.org/61016318:11
melwittstephenfin: been meaning to ask you, the nova-next job stopped testing vnc console with TLS several months ago, see http://logs.openstack.org/92/621692/1/check/nova-next/28869ae/logs/screen-n-novnc-cell1.txt.gz#_Dec_04_01_01_59_749371 I tried digging into it and couldn't find what's going wrong, how it can't find the cert file. wanted to give you a heads up in case you had any clues18:12
*** Swami has joined #openstack-nova18:13
*** wolverineav has joined #openstack-nova18:13
sean-k-mooneymelwitt: i wonder if devstack change its default or something and its not enableing tls anymore18:21
melwittsean-k-mooney: yeah, it's supposed to set everything up so long as the tls-proxy service is enabled https://github.com/openstack-dev/devstack/blob/78a564bb0304b6f930e1491e7e116a0a0f6d9ab6/stack.sh#L84818:23
melwittand in the example log I linked, it is enabled http://logs.openstack.org/92/621692/1/check/nova-next/28869ae/logs/devstacklog.txt.gz#_2018-12-04_00_45_46_47518:24
melwittI looked around devstack months ago looking for a change but didn't find anything. I could have missed it18:24
*** udesale has joined #openstack-nova18:26
*** udesale has quit IRC18:27
*** k_mouza has joined #openstack-nova18:35
*** k_mouza has quit IRC18:39
*** ccamacho has quit IRC18:40
*** yan0s has quit IRC18:43
*** mriedem_lunch is now known as mriedem18:49
*** dims has joined #openstack-nova18:50
openstackgerritLee Yarwood proposed openstack/nova master: WIP Reject migration requests when src compute is down  https://review.openstack.org/62348918:53
openstackgerritJay Pipes proposed openstack/nova master: add InstanceList.get_all_uuids_by_hosts() method  https://review.openstack.org/62355718:57
openstackgerritJay Pipes proposed openstack/nova master: single pass instance info fetch in host manager  https://review.openstack.org/62355818:57
leakypipesbelmoreira: ^^ would be great to get some initial feedback from you on these performance patches to the scheduler. See commit message from https://review.openstack.org/#/c/623558/ for details.18:58
leakypipesmelwitt: ^^18:58
melwittkewl19:00
openstackgerritJack Ding proposed openstack/nova master: Preserve UEFI NVRAM variable store  https://review.openstack.org/62164619:02
*** erlon has quit IRC19:06
*** rodolof has quit IRC19:06
*** rodolof has joined #openstack-nova19:07
* leakypipes hoping mriedem gets the joke on the above patch's git branch name...19:08
leakypipestopic name, that is...19:09
mriedemcall me ishaeml19:09
mriedem*ishmael19:09
mriedemdansmith: you may enjoy https://review.openstack.org/#/c/615347 and it also resolves a functional race bug19:11
mriedemhttp://status.openstack.org/elastic-recheck/#180047219:11
*** wolverineav has quit IRC19:19
*** cdent has quit IRC19:32
*** tbachman has quit IRC19:38
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Drop nova-multiattach job  https://review.openstack.org/62356819:39
openstackgerritMatt Riedemann proposed openstack/nova master: Drop nova-multiattach job  https://review.openstack.org/60698119:45
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Add descriptions about microversions  https://review.openstack.org/61914419:48
*** igordc has joined #openstack-nova19:53
cfriesenis there an equivalent to "nova service-list" in OSC, which would show the state of each compute node's service separately?19:57
cfriesennever mind, found "openstack compute service list"19:58
*** k_mouza has joined #openstack-nova20:05
*** tbachman_ has joined #openstack-nova20:07
*** k_mouza has quit IRC20:09
dansmithmriedem: see comment20:10
dansmith+3 on the code part20:10
*** radez has joined #openstack-nova20:18
radezdansmith: thx, we're working on multi-tenancy with ironic trying to test using networking-ansible to isolate networks20:18
radezthis works fine, though in our CI we're setting up two tenants and trying to deploy an instance using ironic in each of the tenants20:19
dansmithradez: on master or rocky?20:19
radezrocky20:19
radezwhen we schedule the first node it deploys just fine20:19
dansmithokay just to be clear.. nova with compute_driver=ironic, right?20:19
*** sean-k-mooney has quit IRC20:20
radezyes i believe so , let me dousble check that, I've been relying on ooo to setup ironic for me20:20
dansmithjust want to make it clear you're using nova to schedule an instance that will be running on a node in ironic.. the way you worded it above made me first think you were just talking about standalone ironic20:21
radezsry, you're correct we're using nova to schedule and ironic node20:22
dansmithokay, sorry, continue :)20:22
*** mriedem has quit IRC20:25
radezgathering my details here to try and depict this correctly20:25
radezso we deploy the first node and that goes swimmingly. comes active we can connect to it.20:25
radezthis is in one tenant20:25
* dansmith nods20:25
radezin the second tenant we try and deploy another node and the nova logs apprear to indicate that when it goes to get available nodes to deploy to it returns 1 node but it returns the already allocated node instead of the available node20:26
radezlemme gather a few logs that depict this20:27
dansmithare you sure it's selecting the same *node* and not the same nova-compute?20:27
dansmithbecause if you have only one machine running nova-compute, that compute service will be responsible for all the ironic nodes20:27
dansmithI assume that's not the problem because you would likely not even notice and not be here with an issue, but just ... in case it's relevant20:28
*** sean-k-mooney has joined #openstack-nova20:28
dansmithalso, while you're collecting logs, this shouldn't have anything to do with the multi-tenancy part, as the scheduling, picking a node, reserving a node, etc doesn't really factor tenants into the calculus20:28
*** mriedem has joined #openstack-nova20:28
radezI *think* that's not the case because the ironic node uuids and the nova instance uuids match up in the logs20:29
radezfair enough, just laying out the context incase that was helpful20:29
dansmithokay, they should only really line up in the compute log I think, probably not in the scheduling log, fwiw20:29
dansmithack, yep, just letting you know20:29
dansmithradez: my tacos are just about warmed, so keep collecting logs and dumping info here and I'll reply when my fingers are clean :)20:31
dansmithalso, mriedem is here, he's real smart, and he was just telling me he was bored and looking for a good goose to chase :P20:31
radezlol, cool I just got a call I need to take that will distract me for about 30 mins. I'll finish collecting my logs and ping one of you in a bit, sry about that.... I appreciate your help!20:32
mriedemwhat's good for the goose is good for the gander20:33
dansmithradez: okay, also keep in mind it's friday afternoon so probably not many hours left in the day (and I'm sure you're ahead of the rest of us in EST) :D20:34
*** eharney has quit IRC20:39
*** N3l1x has quit IRC20:40
dansmithtaco consumption complete20:42
mriedemdansmith: replied on the reno thing - i'm ok with dropping that if it would just cause more concern than it's worth20:43
mriedemthat compat was really kind of out the window since pike i think20:43
mriedemwhen the api was made cells aware20:43
dansmithmriedem: yeah, so I'd just drop it if you're cool with it20:43
dansmithhah20:44
mriedemi'm very cool20:44
dansmithzuul says 135h remaining on my patch I submitted at like 7am this morning20:44
mriedemhttps://review.openstack.org/#/c/602804/ queued for at least 36 hours, hit a job timeout20:45
dansmithgood lord20:46
dansmithmaybe we should start enacting a french work-week to avoid overloading the gate20:46
openstackgerritMatt Riedemann proposed openstack/nova master: Drop pre-cellsv2 compat in compute API.get()  https://review.openstack.org/61534720:46
openstackgerritMatt Riedemann proposed openstack/nova master: Remove "API Service Version" upgrade check  https://review.openstack.org/61534820:46
*** ralonsoh has quit IRC20:47
* mriedem thinks up a joke about expensive gas20:47
*** amodi has quit IRC20:54
*** N3l1x has joined #openstack-nova20:58
*** macza has quit IRC20:58
radezok, I'm back now, sry about that21:01
radezdansmith: mriedem: http://paste.openstack.org/show/736843/21:02
*** awaugama has quit IRC21:02
radezthis shows the uuids of the bm nodes and the nova instances that seems to be behaving like this21:02
radezand the nova logs where nova seems to assign the already assigned bm node to the new nova instance21:03
radezlet me know if there's more logs I can get to help21:03
dansmithradez: so these nodes should all exist in placement with a single inventory item for the resource/node class,21:04
dansmithwhich means they should never get past the scheduler with two instances on the same node21:04
radeztranslation was helpful thx :)21:05
radez[instance: a840afbc-1314-44d6-83b3-c20b790b9322] Claim successful on node 3c3eb5ee-a358-421a-b2e9-7fd9a017ba1321:05
radezhm, well now I think I've given you the logs that show that the associated ironic node and nova instance are properly associated together21:06
*** brault has quit IRC21:06
*** awaugama has joined #openstack-nova21:07
mriedemdo the flavors have cpu/ram/disk set to anything !0?21:07
radezoh wait, sry I'm getting my self confused... right so does that log line I just pasted here show that nova is trying to21:07
dansmithradez: what log is this? just nova compute?21:07
radezassign ironic node 3c3eb5ee to nova instance a840afbc?21:08
radezyea nova-compute log21:08
dansmithradez: so probably want to look at the scheduler log21:08
dansmithradez: scheduler is what decides which node it is going to tell compute to use for each instance21:09
*** rodolof has quit IRC21:09
radezk lemme find a840afbc in the schedule logs21:10
radezhttp://paste.openstack.org/show/736844/21:13
openstackgerritMerged openstack/os-vif master: add isolate_vif config option  https://review.openstack.org/61253421:13
radezthat also shows a840afbc trying to select 3c3eb5ee21:13
radezhypervisor list incase that's helpful? http://paste.openstack.org/show/736845/21:14
melwittradez: what version of rocky is this? we had a bug around ironic inventory update in the middle of rocky https://review.openstack.org/593678 but as long as you have 18.0.0.0rc2 or later, you should have the fix for that21:14
melwitter, at the end of rocky21:14
dansmithradez: can you show more of the log so we can see both?21:14
radezyea, that was just a quick grep, lemme grab more of the scheduler log and check my version21:15
dansmithmelwitt: that would only affect nodes in cleaning right?21:16
melwittdansmith: I don't know, tbh21:18
melwittI remember there were some ironic driver bugs we fixed near the end of rocky and was curious if those can be ruled out based on what version of rocky they're running21:19
dansmiththe only way this should be happening, AFAIK, is if we're not exposing one inventory per node, or somehow not claiming in placement21:19
melwittyeah, this bug was related to the claiming of a node via setting reserved == total21:20
melwittand one spot where the newer placement api microversion needed to be set was missed21:20
melwittso I was thinking that might possible cause a node to not be claimed when it was supposed to. but as for if it only comes up during cleaning, that I didn't know21:21
melwitt*possibly21:21
mriedemradez: what are the values for cpu/ram/disk for the flavors being used for these baremetal nodes?21:21
melwittI had thought the reserved == total thing was claiming in general and not only for cleaning, but could easily be wrong as I don't know _that_ much about the ironic driver21:21
radezopenstack-nova-scheduler-18.0.321:22
radezok, got hte version, sry fighting with docker :/21:22
*** igordc has quit IRC21:22
melwittthanks radez. so yeah, the thing I wondered can be ruled out21:22
dansmithmelwitt: reserved=total is only for making the node look unschedulable while being cleaned right?21:22
*** igordc has joined #openstack-nova21:22
dansmithmelwitt: reserved=total does't make any sense when the node is actually allocated21:22
mriedemi'm wondering if you're hitting https://bugs.launchpad.net/nova/+bug/179692021:23
openstackLaunchpad bug 1796920 in OpenStack Compute (nova) queens "Baremetal nodes should not be exposing non-custom-resource-class (vcpu, ram, disk)" [High,In progress] - Assigned to Matt Riedemann (mriedem)21:23
radez| properties             | {u'memory_mb': u'4096', u'cpu_arch': u'x86_64', u'local_gb': u'40', u'cpus': u'4', u'capabilities': u'boot_option:local'21:23
radezboth look liek that21:23
mriedemyeah so check that bug21:23
mriedemor https://review.openstack.org/#/c/609043/21:23
radezgetting the logs...21:23
dansmithmriedem: yeah, that's the kind of thing I was thinking of21:23
melwittdansmith: I didn't know that. but what you say makes sense, you're probably right21:24
dansmithmriedem: we consume one CUSTOM_FOO, and then schedule the next one based on there looking like there's ram or something21:24
mriedemi'm very much half assing my involvement here,21:24
mriedembut that's something i'd check out21:24
*** macza has joined #openstack-nova21:24
dansmithI have to leave soon21:25
radezhere's more of the scheduler log http://paste.openstack.org/show/736846/21:28
*** eharney has joined #openstack-nova21:31
dansmithradez: okay but that's still just one instance, right?21:31
dansmithhowever, it looks like whatever host it chose got successfully claimed in placement,21:31
dansmithwhich can't happen if each host is exposing only one inventory item21:31
dansmithradez: can you correlate the "Attempting to claim.." line with the relevant context in the placement log?21:32
radezplacement log is the scheduler log?21:32
mriedemno21:32
dansmithnope, a different service21:33
mriedemplacement-api log21:33
radezoh, sec lemme find that log21:33
dansmiththat should (I think) show you what is being claimed for the instance21:33
dansmithwhich really should be only one resource, something like CUSTOM_IRONIC_FOO=121:33
radezwould that coorelate on the insance uuid?21:34
dansmithI'm not sure what the string looks like, so not sure if it dumps the consumer (instance) uuid or not21:35
mriedemif the flavor has vcpu/ram/disk, and the compute node is reporting vcpu/ram/disk inventory - which it will be still before stein, the claim will be on vcpu/ram/disk as well21:35
dansmithso I would go by date21:35
dansmithmriedem: wait, what?21:35
dansmithI thought it only reported the old resources in some compat situation?21:36
radezkk21:36
mriedemdansmith: no,21:37
mriedemwe didn't neuter the ironic driver until stein, right around the ptg21:37
dansmithI think I recoiled in horror the last time we talked about this21:37
mriedemthat's why we needed https://review.openstack.org/#/c/609043/21:37
dansmithso maybe he just doesn't have the resource class in his flavor?21:37
openstackgerritMatt Riedemann proposed openstack/nova master: Drop pre-cellsv2 compat in compute API.get()  https://review.openstack.org/61534721:39
openstackgerritMatt Riedemann proposed openstack/nova master: Remove "API Service Version" upgrade check  https://review.openstack.org/61534821:39
openstackgerritMatt Riedemann proposed openstack/nova master: Drop old service version check compat from _delete_while_booting  https://review.openstack.org/62358921:39
*** amodi has joined #openstack-nova21:39
mriedem | properties             | {u'memory_mb': u'4096', u'cpu_arch': u'x86_64', u'local_gb': u'40', u'cpus': u'4', u'capabilities': u'boot_option:local'21:39
mriedemthose are extra specs?21:39
dansmithno,21:40
mriedemthen correct the baremetal flavor doesn't have the custom resource class21:40
dansmithnode detaisl Ithink21:40
mriedemradez: have you gone through this? https://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html21:40
mriedemespecially: openstack flavor set --property resources:CUSTOM_BAREMETAL_SMALL=1 my-baremetal-flavor21:41
dansmithand/or.. who created your flavor?21:41
radezhttp://paste.openstack.org/show/736847/21:41
dansmitho.O21:41
openstackgerritMatt Riedemann proposed openstack/nova master: Drop old service version check compat from _delete_while_booting  https://review.openstack.org/62358921:42
radezjlibosvar created the flavor, it looks like that custom baremetal small is not on it21:42
mriedemCUSTOM_BAREMETAL_SMALL is an example21:43
dansmithradez: it needs to be equal to whatever is set on the node21:43
dansmithright21:43
radezhttp://paste.openstack.org/show/736848/21:43
mriedemthe node has a resource_class field21:43
radezyea lemme see what's on the node21:43
mriedemyeah that flavor isn't going to cut it21:43
dansmithyeah21:43
mriedemhttps://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html ftw21:44
radezI don't think there is a resources property on the bm node either21:44
mriedemresource_class21:44
mriedemhttps://developer.openstack.org/api-ref/baremetal/?expanded=show-node-details-detail#show-node-details21:45
dansmithradez: that "how to configure flavors" doc above is probably your ticket out of here, right?21:45
radez| resource_class         | None21:45
mriedemheh "This will be used by the openstack Placement Engine in a future release."21:45
mriedemjroll: maybe we should update the resource_class api-ref parameter description in ironic now...21:45
radezyea maybe he's just missed some of the setup steps. Lemme regroup and try and go back through the steps that have been taken in this env and I'll circle back back next week if we're still haveing trouble21:46
dansmithcool21:46
radezok, thanks for your time!21:47
* mriedem awaits his $2 in the mail21:49
dansmithI need to remember to remember that we only closed that silly loop in stein21:52
dansmithall that discussion at the first denver ptg ...21:52
* dansmith shakes his head21:52
*** wolverineav has joined #openstack-nova21:57
*** wolverineav has quit IRC21:57
*** wolverineav has joined #openstack-nova21:57
*** wolverineav has quit IRC22:04
mriedemmelwitt: thanks for hitting the stable branch reviews22:05
melwittnp22:06
*** wolverineav has joined #openstack-nova22:08
*** slaweq has joined #openstack-nova22:11
*** KeithMnemonic has quit IRC22:16
*** rodolof has joined #openstack-nova22:16
*** trident has quit IRC22:22
*** trident has joined #openstack-nova22:22
*** gouthamr has quit IRC22:23
openstackgerritMatt Riedemann proposed openstack/nova master: Remove allocations before setting vm_status to SHELVED_OFFLOADED  https://review.openstack.org/62359622:29
mriedemgibi: efried_cya_jan: finally got that alternative fix up for that shelve gate race bug ^22:29
cfriesenin compute/api.py in the @check_instance_state() decorator, if we don't specify a task_state does that mean that we don't care what the state is?22:35
mriedemno22:36
mriedemnot specifying a task_state means task_state must be None22:36
cfriesenwhat if we have @check_instance_state(task_state=None) ?22:37
openstackgerritBen Nemec proposed openstack/nova master: Migrate upgrade checks to oslo.upgradecheck  https://review.openstack.org/60349922:38
mriedemcfriesen: if only the source code were freely available...22:38
cfriesenmriedem: yeah, well I'm staring at it and I'm trying to wrap my head around the logic since there are no useful comments. :)22:40
cfriesenI guess if we explicitly set it to None then we don't care, otherwise instance.task_state has to be None to pass.22:42
melwittyeah, was about to say the same thing22:42
melwittif task_state=None it isn't checking state22:43
*** mriedem is now known as mriedem_afk22:46
*** rodolof has quit IRC22:52
*** slaweq has quit IRC22:52
*** N3l1x has quit IRC23:06
*** gouthamr has joined #openstack-nova23:06
*** wolverineav has quit IRC23:08
*** wolverin_ has joined #openstack-nova23:08
*** slaweq has joined #openstack-nova23:09
*** burt has quit IRC23:10
*** slaweq has quit IRC23:14
*** slaweq has joined #openstack-nova23:19
*** slaweq has quit IRC23:24
*** tbachman_ has quit IRC23:27
*** tbachman has joined #openstack-nova23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!