Friday, 2018-11-30

*** wolverineav has quit IRC00:09
*** wolverineav has joined #openstack-nova00:10
*** wolverineav has quit IRC00:12
*** wolverineav has joined #openstack-nova00:13
*** brinzhang has joined #openstack-nova00:18
*** threestrands has joined #openstack-nova00:18
*** frippe75_ has quit IRC00:23
*** tbachman has quit IRC00:25
*** rambo_li has joined #openstack-nova00:35
openstackgerritSurya Seetharaman proposed openstack/nova master: WIP: API microversion bump for handling-down-cell  https://review.openstack.org/59165700:38
*** tssurya has quit IRC00:55
*** hamzy_ has joined #openstack-nova01:07
*** hongda has joined #openstack-nova01:22
*** hshiina has joined #openstack-nova01:36
*** erlon has quit IRC01:38
*** wolverineav has quit IRC01:38
*** dave-mccowan has joined #openstack-nova01:51
*** gyee has quit IRC01:52
*** dklyle has joined #openstack-nova01:59
*** tbachman has joined #openstack-nova02:05
*** dklyle has quit IRC02:05
*** cfriesen has quit IRC02:06
*** tbachman_ has joined #openstack-nova02:08
*** tbachman has quit IRC02:10
*** tbachman_ is now known as tbachman02:10
*** tbachman has quit IRC02:18
*** mriedem_afk has quit IRC02:19
*** mrsoul has quit IRC02:22
*** takashin has joined #openstack-nova02:27
*** Dinesh_Bhor has joined #openstack-nova02:27
*** _hemna has quit IRC02:29
*** mlavalle has quit IRC02:34
*** _hemna has joined #openstack-nova02:35
*** liuyulong_ has joined #openstack-nova02:35
openstackgerritAlex Xu proposed openstack/nova master: Parse the numa topology from the new flavor when resize instance  https://review.openstack.org/62087402:38
*** psachin has joined #openstack-nova02:39
*** mhen has quit IRC02:40
*** mhen has joined #openstack-nova02:43
*** dave-mccowan has quit IRC02:46
*** dave-mccowan has joined #openstack-nova02:56
*** _hemna has quit IRC02:56
*** _hemna has joined #openstack-nova02:57
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Drop pre-cinder 3.44 version compatibility  https://review.openstack.org/62106102:57
*** bhagyashris has joined #openstack-nova03:02
*** hongbin has joined #openstack-nova03:02
*** dklyle has joined #openstack-nova03:11
*** whoami-rajat has joined #openstack-nova03:12
*** _hemna has quit IRC03:13
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.openstack.org/58033603:15
*** dklyle has quit IRC03:17
openstackgerritMerged openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918003:25
openstackgerritMerged openstack/nova stable/pike: Fix NoneType error in _notify_volume_usage_detach  https://review.openstack.org/61487203:25
openstackgerritMerged openstack/nova stable/queens: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61935103:25
*** _hemna has joined #openstack-nova03:30
*** _hemna has quit IRC03:30
*** dave-mccowan has quit IRC03:33
*** dave-mccowan has joined #openstack-nova03:34
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.openstack.org/58033603:39
*** psachin has quit IRC03:43
*** jarodwl has quit IRC03:43
*** jarodwl has joined #openstack-nova03:43
*** _hemna has joined #openstack-nova03:46
*** _hemna has quit IRC03:50
*** _hemna has joined #openstack-nova03:56
*** _hemna has quit IRC03:56
*** hongbin has quit IRC03:56
*** udesale has joined #openstack-nova04:01
*** janki has joined #openstack-nova04:03
*** _hemna has joined #openstack-nova04:11
*** _hemna has quit IRC04:11
*** _hemna has joined #openstack-nova04:21
*** _hemna has quit IRC04:21
*** ivve has joined #openstack-nova04:25
*** rambo_li has quit IRC04:25
*** dave-mccowan has quit IRC04:30
*** markvoelker has quit IRC04:32
*** _hemna has joined #openstack-nova04:40
*** _hemna has quit IRC04:40
*** _hemna has joined #openstack-nova04:42
*** _hemna has quit IRC04:43
*** _hemna has joined #openstack-nova04:45
*** _hemna has quit IRC04:45
*** ratailor has joined #openstack-nova04:50
*** wolverineav has joined #openstack-nova04:52
*** _hemna has joined #openstack-nova04:57
*** _hemna has quit IRC04:57
*** markvoelker has joined #openstack-nova05:02
*** Nel1x has quit IRC05:14
*** wolverineav has quit IRC05:15
*** _hemna has joined #openstack-nova05:17
*** _hemna has quit IRC05:17
*** threestrands has quit IRC05:20
openstackgerritAlex Xu proposed openstack/nova master: Parse the numa topology from the new flavor when resize instance  https://review.openstack.org/62087405:30
*** _hemna has joined #openstack-nova05:31
*** _hemna has quit IRC05:32
*** pcaruana has quit IRC05:35
*** _hemna has joined #openstack-nova05:38
*** _hemna has quit IRC05:39
*** imacdonn has quit IRC05:39
*** imacdonn has joined #openstack-nova05:39
*** _hemna has joined #openstack-nova05:45
*** _hemna has quit IRC05:45
*** _hemna has joined #openstack-nova05:52
*** _hemna has quit IRC05:52
*** _hemna has joined #openstack-nova05:59
*** _hemna has quit IRC05:59
*** rambo_li has joined #openstack-nova06:03
*** _hemna has joined #openstack-nova06:05
*** _hemna has quit IRC06:06
*** _hemna has joined #openstack-nova06:13
*** _hemna has quit IRC06:16
*** sridharg has joined #openstack-nova06:21
*** _hemna has joined #openstack-nova06:21
*** _hemna has quit IRC06:21
*** _hemna has joined #openstack-nova06:29
*** _hemna has quit IRC06:29
*** hoangcx has quit IRC06:29
*** _hemna has joined #openstack-nova06:39
*** ondrejme has quit IRC06:39
*** _hemna has quit IRC06:39
*** _hemna has joined #openstack-nova06:47
*** _hemna has quit IRC06:48
*** noonedeadpunk[h] has joined #openstack-nova06:48
*** noonedeadpunk has quit IRC06:49
openstackgerritAlex Xu proposed openstack/nova master: Parse the numa topology from the new flavor when resize instance  https://review.openstack.org/62087406:53
openstackgerritAlex Xu proposed openstack/nova master: Parse the new PCI request from flavor extra specs when resize  https://review.openstack.org/62107706:53
*** _hemna has joined #openstack-nova06:54
*** _hemna has quit IRC06:54
*** _hemna has joined #openstack-nova07:01
*** _hemna has quit IRC07:02
openstackgerritFilippo Inzaghi proposed openstack/python-novaclient master: Add Python 3.6 classifier to setup.cfg  https://review.openstack.org/62109307:11
*** hamzy__ has joined #openstack-nova07:11
*** hamzy_ has quit IRC07:12
*** ohorecny2 has joined #openstack-nova07:12
*** _hemna has joined #openstack-nova07:13
*** _hemna has quit IRC07:15
*** pooja_jadhav has joined #openstack-nova07:21
*** _hemna has joined #openstack-nova07:21
*** stakeda has joined #openstack-nova07:22
*** pcaruana has joined #openstack-nova07:22
ohorecny2Everyone: Do you know some closer information about this bug: https://bugs.launchpad.net/nova/+bug/1795920 , please? I mean, if anybody is working on it or if you have some proposals how to fix it.07:25
openstackLaunchpad bug 1795920 in OpenStack Compute (nova) "SR-IOV shared PCI numa not working " [Undecided,Confirmed]07:25
*** slaweq has joined #openstack-nova07:34
*** Luzi has joined #openstack-nova07:38
*** jangutter has quit IRC07:41
*** jangutter has joined #openstack-nova07:41
*** takashin has left #openstack-nova07:45
belmoreiramriedem: thanks for ping me. See: https://bugs.launchpad.net/nova/+bug/1805984 https://bugs.launchpad.net/nova/+bug/180598907:53
openstackLaunchpad bug 1805984 in OpenStack Compute (nova) "Placement is not aware of disable compute nodes" [Undecided,New]07:53
openstackLaunchpad bug 1805989 in OpenStack Compute (nova) "Weight policy to stack/spread instances and "max_placement_results"" [Undecided,New]07:54
*** sahid has joined #openstack-nova07:56
*** hshiina has quit IRC08:04
*** rcernin has quit IRC08:06
*** dpawlik has joined #openstack-nova08:07
*** awalende has joined #openstack-nova08:08
*** awalende_ has joined #openstack-nova08:08
*** awalende_ has quit IRC08:10
*** moshele has joined #openstack-nova08:11
*** awalende has quit IRC08:12
*** ralonsoh has joined #openstack-nova08:17
openstackgerritYikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF  https://review.openstack.org/60280408:21
*** helenaAM has joined #openstack-nova08:23
*** ondrejme has joined #openstack-nova08:35
*** xek has joined #openstack-nova08:38
*** maciejjozefczyk has quit IRC08:38
*** maciejjozefczyk has joined #openstack-nova08:39
*** dpawlik has quit IRC08:46
*** ccamacho has joined #openstack-nova08:46
*** pooja_jadhav has quit IRC08:56
*** ileixe has quit IRC09:05
*** noonedeadpunk[h] is now known as noonedeadpunk09:14
*** k_mouza has joined #openstack-nova09:15
*** dpawlik has joined #openstack-nova09:20
kashyapalex_xu: If you're still about: https://review.openstack.org/#/c/620327/09:23
*** dpawlik has quit IRC09:24
*** k_mouza has quit IRC09:28
*** k_mouza has joined #openstack-nova09:28
*** bhagyashris has quit IRC09:32
*** rambo_li has quit IRC09:32
*** stakeda has quit IRC09:33
*** derekh has joined #openstack-nova09:33
*** s10 has joined #openstack-nova09:40
*** takamatsu has quit IRC09:41
*** ttsiouts has joined #openstack-nova09:41
*** ttsiouts has quit IRC09:44
*** ttsiouts has joined #openstack-nova09:44
*** ttsiouts has quit IRC09:49
*** tssurya has joined #openstack-nova10:03
*** pooja_jadhav has joined #openstack-nova10:04
*** erlon has joined #openstack-nova10:04
*** brinzhang has quit IRC10:05
*** k_mouza has quit IRC10:07
openstackgerritYikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF  https://review.openstack.org/60280410:09
openstackgerritYikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349910:09
openstackgerritYikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script  https://review.openstack.org/60999510:09
*** Dinesh_Bhor has quit IRC10:09
openstackgerritMerged openstack/nova-specs master: Re-propose numa-aware-live-migration spec  https://review.openstack.org/59958710:09
*** k_mouza has joined #openstack-nova10:20
gibijackding: hi! the last open patch for the io semaphor work has merged https://review.openstack.org/#/c/609180/ Does it mean that the bp io-semaphore-for-concurrent-disk-ops is done?10:24
*** ttsiouts has joined #openstack-nova10:27
*** maciejjozefczyk has quit IRC10:29
*** maciejjozefczyk has joined #openstack-nova10:31
*** slaweq has quit IRC10:32
*** liuyulong_ has quit IRC10:38
*** pooja_jadhav has quit IRC10:38
*** pcaruana has quit IRC10:44
*** pcaruana has joined #openstack-nova10:50
*** ttsiouts has quit IRC10:55
*** ttsiouts has joined #openstack-nova10:55
*** udesale has quit IRC10:59
*** cdent has joined #openstack-nova10:59
*** ShilpaSD has quit IRC11:00
*** ttsiouts has quit IRC11:00
*** dtantsur|mtg is now known as dtantsur|afk11:00
*** cdent has quit IRC11:20
*** cdent has joined #openstack-nova11:46
*** slaweq has joined #openstack-nova11:51
*** Luzi has quit IRC12:00
*** pcaruana has quit IRC12:11
*** slaweq has quit IRC12:24
*** udesale has joined #openstack-nova12:26
*** eharney has quit IRC12:34
openstackgerritElod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification  https://review.openstack.org/50850612:37
artombauzas, thanks for the +W  on the NUMA migration spec :) What wasn't clear about the table? Matt had come up with some improved wording, so I can reword in a amendment patch12:40
sean-k-mooneyartom you could have just said the new code would only work if both the source and dest node supported it12:41
sean-k-mooneyfor the other 3 cases the old workflow will be used so you dont really need the table but i could follow it in its redered from much easier then in the raw rst doc12:42
sean-k-mooneyi only read the raw rst doc normally so its a little annoying to have to read the rendered version12:43
*** jaypipes is now known as leakypipes12:44
sean-k-mooneyleakypipes: im going to send an email to the list regrading the serialisation of os-vif objects12:45
*** Nel1x has joined #openstack-nova12:46
sean-k-mooneyleakypipes: so that kuryr-kubernetes are aware that this will break in the future https://github.com/openstack/kuryr-kubernetes/commit/7cc187806b42fee5ea660f86d33ad2f59b00975412:46
*** xek has quit IRC12:46
*** xek has joined #openstack-nova12:47
sean-k-mooneyleakypipes: and that everything they are doing in this file is using os-vif out of contract https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/objects/vif.py12:47
sean-k-mooneyi have told them we do not allow external plugins to define there own vif object 3 releases ago but we definetly do support serialising and prestingign between potically differed versions of os-vif12:48
artomsean-k-mooney, yeah, the rst doc is unreadable for the table12:49
sean-k-mooneyartom: anyway the spec is merged and it was more of a nit i think then anything else so i would not worry about it12:50
leakypipessean-k-mooney: ack, thanks for getting that conversation started. if you need a spellcheck before sending out, lemme know :P12:51
sean-k-mooneypeople keep telling me that specs are appreently not documentation so as long as we understand what you ment its all good12:51
leakypipessean-k-mooney: I actually don't understand why kuryr-kubernetes is defining os-vif objects at all (versus just defining the things in os-vif itself)12:52
sean-k-mooneyleakypipes: they did not know that they were not ment too so they did it really early on12:53
leakypipessean-k-mooney: ok12:53
leakypipessean-k-mooney: can we undo that? :)12:53
sean-k-mooneymore recently the have added it to os-vif when i pointed out that it would break going forward if tehy didnt12:53
sean-k-mooneyget rid of there objects yes12:54
sean-k-mooneyi ment to do it in rocky but move from intel to redhat and didnt get around to it12:54
janguttersean-k-mooney, leakypipes: Re: ( https://review.openstack.org/#/c/607610/ ), I left the option open to do the "duelling options" right till the runway engages... mainly to keep progress unblocked, with the idea to update the spec with the decision made.12:55
sean-k-mooneyjangutter: i personally hate updateing spec retroactivly. so im happy to conceed just to avoid that12:56
*** erlon has quit IRC12:56
sean-k-mooneywell almost12:56
janguttersean-k-mooney, leakypipes: I have been selling tickets, but I'm pretty sure I can track down the people and refund them with only a limited loss of kneecaps.12:57
sean-k-mooneyjangutter: if you want to continue the discussion over code review then we can12:58
sean-k-mooneyi would like to see if we can merge the spec soon however and move on to th code as we only have until midle of febuary to release os-vif and i would prefer to have this mered earlier then later.12:59
sean-k-mooneye.g. the code12:59
janguttersean-k-mooney, leakypipes: on that note, do you think the spec is in a good enough shape for a wider review?12:59
janguttersean-k-mooney: agreed on that, want to fixup the code early next week to match the spec in any case.13:00
*** ttsiouts has joined #openstack-nova13:00
sean-k-mooneyjangutter: i would like to see if we can get an os-vif release in the next 2 weeks and alost another one at the end of january to give some time to test it with nova, so sound good.13:01
sean-k-mooneyjangutter: i think the spec i fine for wider review13:02
leakypipesjangutter: I do, which is what I said in the review last night :)13:05
*** tbachman has joined #openstack-nova13:07
jangutterleakypipes, sean-k-mooney: thanks! Any idea who would be sufficiently interested and ... I want to say "still haven't lost hope in all that is good"?13:09
*** ratailor has quit IRC13:11
*** erlon has joined #openstack-nova13:11
leakypipesjangutter: give it a few hours. you'll have lost all faith in humanity by that point.13:15
jangutterleakypipes: you're describing what I call "Monday".13:17
leakypipeshappy Friday.13:17
sean-k-mooneyjangutter: well i woudl recommend starting with the nova specs core team since they are the only people that can give you the remaining +2 and +w13:17
*** ShilpaSD has joined #openstack-nova13:18
sean-k-mooneyjangutter: dansmith might have some input on ovo versionng and the inheritance/compostion element of the rest https://review.openstack.org/#/admin/groups/302,members it does not jump out at me as an area the rest are stongly invovled in13:20
janguttersean-k-mooney: (facepalm, didn't notice that nova-specs and nova have different ACLs)13:21
sean-k-mooneyya nova specs is much smaller13:21
*** jackivanov has quit IRC13:26
*** annp has quit IRC13:29
*** cdent has quit IRC13:37
*** mchlumsky has joined #openstack-nova13:44
s10Hello. We've faced a bug, that is claimed to be fixed by in https://bugs.launchpad.net/nova/+bug/1404867 . I added a comment about conditions, in which it can happen during the bulk instances creation by Heat.13:48
openstackLaunchpad bug 1404867 in OpenStack Compute (nova) queens "Volume remains in-use status, if instance booted from volume is deleted in error state" [Medium,Fix committed] - Assigned to Mohammed Naser (mnaser)13:48
s10When instances are created in parallel, they can fail to build because of the quota.recheck_quota=True in nova.conf, and then it's impossible to remove volumes without admin intervention, because volumes are stuck in 'attaching' state.13:48
s10What will be the right approach to fix this bug?13:48
*** udesale has quit IRC13:48
*** whoami-rajat has quit IRC13:49
*** mlavalle has joined #openstack-nova13:49
*** udesale has joined #openstack-nova13:49
*** ttsiouts has quit IRC13:54
*** takamatsu has joined #openstack-nova13:55
*** ttsiouts has joined #openstack-nova13:55
*** slaweq has joined #openstack-nova13:56
*** ttsiouts has quit IRC14:00
*** nicholas has joined #openstack-nova14:02
s10I can reproduce this bug even without Heat, with small terraform config...14:06
mnasers10: what release?14:08
s10mnaser: I tried it with the Pike.  I can try it with the Queens, if those fixes weren't backported to Pike.14:09
maciejjozefczyksean-k-mooney: Hey, I finally took time to check https://review.openstack.org/#/c/59160714:10
maciejjozefczyksean-k-mooney:  If you have a minute please look also at: https://review.openstack.org/#/c/61416714:12
maciejjozefczykIts related14:12
sean-k-mooneymaciejjozefczyk: hi14:12
sean-k-mooneyyes i saw the follow up patch14:12
sean-k-mooneyi only tested the first one because it was a single node deployment and i did not have to worry about updgrades14:13
maciejjozefczykOk14:14
sean-k-mooneyso just looking at https://review.openstack.org/#/c/591607/9/nova/network/neutronv2/api.py@291414:14
sean-k-mooneythe value of the port id will be a neutron port uuid not an int right14:15
*** ttsiouts has joined #openstack-nova14:15
sean-k-mooneyor is it a nova port id form the nova virtural interface table14:16
maciejjozefczykthis 'id' is a sequence from table14:17
maciejjozefczykso it will always be int14:17
sean-k-mooneyok what i was concerned about really was trying to maintian the order of interface withing the guest if possible14:18
*** etp has quit IRC14:18
sean-k-mooneybut to be honest i dont think there is a good way to do that so the code as written is proably fine14:18
maciejjozefczykhttps://github.com/openstack/nova/blob/master/nova/objects/virtual_interface.py#L3614:18
openstackgerritBalazs Gibizer proposed openstack/nova master: Deprecate the unversioned notifications  https://review.openstack.org/60307914:19
sean-k-mooney ya i assume it was this object14:19
maciejjozefczykFor me its not a ideal solution also, but its only one source of real order of interfaces, that I know in nova14:19
*** mriedem has joined #openstack-nova14:19
maciejjozefczykIt was like first idea how to make it after Vlad comment14:20
s10mnaser: Same thing with Queens. In Pike volumes are stuck in attaching state, in Queens - in reserved.14:20
mnasers10: indeed sounds like a bug14:21
sean-k-mooneymaciejjozefczyk: ya if you are sorting by that id and not the uuid i think the code makes sense14:21
mnaserunfortunately i dont run this setting on and i'm a bit out of cycles to dig in deeper :X14:21
sean-k-mooneyi can leve that feedback on the reivew14:21
s10mnaser: and easy to reproduce. Just set CPU quota for the project to 1 and then create 2 instances with 1vcpu each in parallel.14:22
*** etp has joined #openstack-nova14:22
mnasers10: oh i can see it but digging into solution and all, but out of time for that :)14:22
maciejjozefczyksean-k-mooney: thanks14:23
maciejjozefczyks10:  If you have a minute PTAL https://review.openstack.org/#/c/591607/14:23
sean-k-mooneymaciejjozefczyk: part of my confustion was we also have this object to model vifs in nova https://github.com/openstack/nova/blob/master/nova/network/model.py#L378 and the id field there is the neutron port uuid14:24
gibijackding: ping14:24
maciejjozefczyksean-k-mooney: hmm, idk whats that, but anyway this model is not used there14:26
sean-k-mooneyits how we model neutron port when talking to the virt dirivers.14:27
sean-k-mooneymaciejjozefczyk: it is also the object that is contained in the networkinfo object https://github.com/openstack/nova/blob/master/nova/network/model.py#L485 and i had assuemd in the netwrok info cache14:29
maciejjozefczykok, so its clearly some duplication of data :)14:30
*** janki has quit IRC14:30
mriedemis mdbooth around today?14:30
sean-k-mooneymaciejjozefczyk: VirtualInterface i think is a legacy object we have for nova networks and it is what we persit in the db14:31
mriedemsean-k-mooney: we also create virtualinterfaces in the db for neutron ports since newton14:31
sean-k-mooneymaciejjozefczyk: the other object are the ones we construct form neutron and use for port binding and creating the os-vif objects14:31
maciejjozefczyksean-k-mooney: mriedem said that its about storing 'tag'14:31
sean-k-mooneymriedem: we do  yes14:31
mriedemit is14:31
*** cdent has joined #openstack-nova14:32
sean-k-mooneymaciejjozefczyk: right for the device role tagging spec14:32
sean-k-mooneymriedem: does the netwrok info cache contain the VIF form here https://github.com/openstack/nova/blob/master/nova/network/model.py#L378 or the virtualInterface objecst from here https://github.com/openstack/nova/blob/master/nova/objects/virtual_interface.py#L2814:33
maciejjozefczykI used this field, btw, to store the last port I verified during online_data_migrations, same way as bauzas did for other migrations14:33
bauzasmmm ?14:33
mriedemthe vif14:34
mriedemhttps://github.com/openstack/nova/blob/master/nova/network/model.py#L48814:34
sean-k-mooneythats what i had understood too14:34
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/instance_info_cache.py#L4014:34
sean-k-mooneyso the id filed that is being sorted on here https://review.openstack.org/#/c/591607/9/nova/network/neutronv2/api.py@2914 is the neutron port uuid that is stored in the VIF objects id field14:35
bauzasshit, anyone knows why my nova-specs dashboard doesn't work ?14:36
*** rambo_li has joined #openstack-nova14:36
*** lbragstad is now known as elbragstad14:36
bauzasmy own dashboard goo.gl/MgN7mp14:36
sean-k-mooney maciejjozefczyk so that code is sorting on the uuid in the VIF.id field not the id of the VirtualInterface id field14:37
maciejjozefczykbauzas:  I took your logic from https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py to have a marker, thanks btw14:37
bauzasah ok14:37
bauzashttp://goo.gl/MgN7mp is my own dashboard14:37
maciejjozefczyksean-k-mooney: so how to preserve the order after attaching new interface? if it sorts by VIF.id (that is uuid?)?14:38
*** whoami-rajat has joined #openstack-nova14:38
sean-k-mooneymaciejjozefczyk: actully no you are ok you are build it from the db https://review.openstack.org/#/c/591607/9/nova/network/neutronv2/api.py@235614:39
maciejjozefczyksean-k-mooney: about get_vifs_by_instance: ok14:39
*** eharney has joined #openstack-nova14:42
sean-k-mooneymaciejjozefczyk: so yes _get_ordered_port_list is constuting an orderd port list from the VirtualInterface objects retruned form get_vifs_by_instance and then in _build_network_info_model you are construting a NetworkInfo object containing  VIF objects14:43
sean-k-mooneymaciejjozefczyk: so ya the logic is correct14:44
*** takamatsu has quit IRC14:48
*** brault has quit IRC14:51
maciejjozefczykthats right :)14:53
openstackgerritBalazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule  https://review.openstack.org/61952914:54
*** ttsiouts has quit IRC14:54
openstackgerritBalazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding  https://review.openstack.org/56945914:54
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331714:54
*** ttsiouts has joined #openstack-nova14:55
kashyapIf someone has time, a refactor that makes your brain less warpy: https://review.openstack.org/#/c/620327/ ("libvirt: Refactor handling of PCIe root ports")14:56
*** ttsiouts has quit IRC14:56
*** ttsiouts has joined #openstack-nova14:57
*** ttsiouts has quit IRC14:58
*** awaugama has joined #openstack-nova15:00
gibikashyap: +2, thanks!15:07
openstackgerritMatt Riedemann proposed openstack/nova master: Mention size limit on user data in docs  https://review.openstack.org/62070015:07
kashyapgibi: Sweet, thank you, sir.15:07
kashyapThat means, then I _really_ need to workout the fix to address the more complex TODO item in the comment.15:08
s10mriedem: We've faced a bug, which is related to https://bugs.launchpad.net/nova/+bug/1404867 . I've written about it in last comment, but I'm not sure, if I should open a new bug about this issue. We can't set quota.recheck_quota=False in our deployments, and some users sometimes ends up with volumes in incorrect status.15:08
openstackLaunchpad bug 1404867 in OpenStack Compute (nova) queens "Volume remains in-use status, if instance booted from volume is deleted in error state" [Medium,Fix committed] - Assigned to Mohammed Naser (mnaser)15:08
mriedems10: which release? because i'm pretty sure mnaser already fixed that15:10
s10mriedem: Pike and Queens.15:10
mriedemoh i'm thinking of I64074923fb741fbf5459f66b8ab1a23c16f3303f15:11
mriedemhttps://review.openstack.org/#/c/544748/15:11
s10mriedem: this issue is almost fixed, but still can happen, if this exception happens https://github.com/openstack/nova/blob/stable/rocky/nova/conductor/manager.py#L130815:12
mriedems10: open a new bug, you can refer to ^ as being related but a different failure15:12
s10mriedem: because after this exception instance is not being buried in cell015:12
mriedemlyarwood: bauzas: this upgrade-impacting backport needs review https://review.openstack.org/#/c/610974/15:13
mriedems10: yeah i get it15:13
mriedemjust report a new bug15:13
bauzasmriedem: on a meeting but looking15:13
mriedembauzas: while you're on the call, you want to ask mdbooth if he'll be around the next two weeks to respond to review comments on https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers if it's in a runway?15:14
s10mriedem: ok, I will report.15:14
mriedembecause it's next in the queue15:14
bauzasmriedem: I can try to ask :)15:14
mriedemi know you can do this!15:14
mriedembe strong!15:14
bauzasI'm a weak guy15:15
*** mdbooth has joined #openstack-nova15:15
mriedemyou're a bear15:15
mriedembig ol papa bear15:15
bauzasmaybe more a Winnie the Bear one15:15
bauzason another point, I finally found how to fix my specs dashboard :)15:16
openstackgerritChris Dent proposed openstack/nova master: Remove placement perf check  https://review.openstack.org/62118015:16
mdboothmriedem bauzas: I'm not working Mondays for the next few weeks, but Tuesday->Friday I can prioritise responding to reviews.15:18
bauzasso, #1 I fixed my dashboard, #2 I have less downstream tasks to do, #3 there are a huge number of specs left to review15:19
bauzasgood news, I'll sharpen my pen15:19
mriedemmdbooth: ok. i had some comments at one point on one of the changes in that blueprint which was merged in rocky (i think) and i don't think i ever heard back. i'll try to dig that up.15:21
mriedemi may or may not be grinding an axe because of it15:22
*** moshele has joined #openstack-nova15:22
mriedemanyway, your bp is in the runways queue now15:22
mriedemgood luck15:22
mdboothmriedem: I rebased and addressed all prior feedback a few weeks back, so hopefully all good.15:23
mriedemi meant this i think https://review.openstack.org/#/c/528362/15:23
coreycbsean-k-mooney: do you recall if the stestr change to stable/pike was supposed get reverted?15:27
*** cfriesen has joined #openstack-nova15:28
*** takamatsu has joined #openstack-nova15:29
leakypipesmdbooth: what is "a V2V workflow"?15:29
mdboothleakypipes: Oops, jargon.15:29
mdboothleakypipes: Moving workloads between 2 different hypervisors15:30
mdboothP2V == physical to virtual15:30
s10mriedem: I've written https://bugs.launchpad.net/nova/+bug/180606415:30
openstackLaunchpad bug 1806064 in OpenStack Compute (nova) "Volume remains in attaching/reserved status after TooManyInstances exception in nova-conductor" [Undecided,New]15:30
leakypipesbauzas: there can be only one Winnie the Bear... https://twitter.com/jaypipes/status/101271361509733580915:30
mdboothleakypipes: It's pretty much the definition of not cloudy.15:30
mdboothBut people want to do it, so I ask the question...15:30
bauzasleakypipes: I just can't not heart this15:31
leakypipesmdbooth: by "two different hypervisors", you don't mean migration, you mean like VMWare to KVM or something like that?15:31
bauzas<315:31
leakypipesbauzas: :)15:31
mdboothleakypipes: E.g. Move a legacy workload from a physical server to an openstack Panda.15:31
mdboothleakypipes: Yeah, or moving stuff from (non-openstack) VMware to Openstack.15:32
cdentvast mental resources are being spent on this. it's so weird to me15:32
bauzassomeday, there will be Dogtivities at Summit15:32
cdentmonetary and stuff15:32
cdentdogtivities++15:32
mriedems10: thanks; should be pretty easy to write a functional regression test for that scenario.15:33
jackdinggibi: yes the bp io-semaphore-for-concurrent-disk-ops is done15:33
gibijackding: thank. meanwhile mriedem already marked the bp completed15:33
gibijackding: so the administration is also done :)15:34
leakypipesmdbooth: I think what you're describing sounds a little like Ironic's node import functionality.15:34
jackdinggibi: mriedem: thanks :)15:34
*** bnemec is now known as beekneemech15:34
leakypipesmdbooth: but what mnaser mentioned about just adding the image to glance makes some sense to me.15:34
mnaseralso if you use bfv (this might be a bit more of a specific use case scenario)15:35
mnaseryou can totally do this too15:35
mdboothGlance isn't a great fit, because we never want to create 2 of these things. They're volume backed.15:35
mdboothThing is when you're mass importing 1000 of these things.15:36
kashyapsean-k-mooney: I'm reading this spec that you reviewed, and the "problem description" is not clear to me at all: https://review.openstack.org/#/c/620959/1/specs/stein/approved/cpu-model-selection.rst15:36
mdboothAnd 50 are powered off.15:36
*** moshele has quit IRC15:36
mnasercinder manage volumes and boot the ones that are running only?15:36
leakypipesmdbooth: we have this awful register/import script that does similar things for non-OpenStack baremetal workloads... basically making OpenStack aware of them, creating records in Nova/Ironic, etc and we have this awful hack called "--no-reimage" that prevents Ironic from cleaning/imaging the imported nodes (and prevents nova from trying to schedule to them)15:36
mdboothYou don't want those 50 to be 'special'. You want them to be exactly the same as all the rest, just not running.15:36
leakypipesmdbooth: so, in short, I'm familiar with the ask at least ;)15:36
*** eharney has quit IRC15:36
kashyapsean-k-mooney: I'll respond on that change once I read through it15:37
mdboothleakypipes: We're copying the data into a VM so the physical can be retired.15:37
leakypipesmdbooth: understood. I'm saying we have a similar-ish use case that we've got nasty-hacks for :) so I feel your pain.15:37
mdboothleakypipes: Interesting that we're not the only one creating pandas from legacy workloads.15:38
* mnaser thinks it might be less-than-trivial to do the create-but-dont-start thing15:38
leakypipesmdbooth: having some sort of "register this thing as a VM but don't do anything with it (yet)" would be useful for getting data/systems into OpenStack I think.15:38
mriedempretty sure there are lots of products that have something that does something like this,15:38
leakypipesmdbooth: oh, we have a whole friggin zoo of pandas.15:38
mriedemthere was a lot of chatter in wechat one night about how openstack didn't have this import feature15:38
mriedemespecially for DR scenarios15:38
cdentDR is the context I keep hearing it too15:39
mriedeme.g. operator lost the nova server data, but had the hypervisor/ovs/volume info and just wanted to recreate the records15:39
leakypipeswell, that's just... well, ewww. but yeah I can kinda see that.15:39
mnaseri remember that discussion15:39
mnaserit was in the scope of someone's database blowing up15:40
mriedemyes15:40
mnaserand now everything was running but no records for anything15:40
leakypipes(ewww == "guh, you should have a backup of your data")15:40
mdboothThe way our v2v works is we create an ephemeral conversion instance, create a volume, the instance connects out to tools on the legacy hypervisor/physical and copies data to the volume. Then it does unspeakable hacks to it.15:40
mriedemand the majority of replies were either "openstack should totally be able to fix that for you!" to "why don't you backup your database dummy"15:40
leakypipesmriedem: :)15:40
mdboothThen we throw away the conversion instance and create a new one for the migrated workload, using bfv.15:40
leakypipesmriedem: I think you know where I stand on that. :P15:40
mnaseri mean we can just say keep the volume and boot that when you need it15:41
leakypipesmriedem: then again, there's a reason that the mysql command line client has a --i-am-a-dummy option.15:41
mnaserbut i also dont think that is a really trivial way for users15:41
mnaserleakypipes: hah, except only people who are advanced users know about it... :p15:41
leakypipesmnaser: I know right? :)15:41
*** maciejjozefczyk has quit IRC15:42
mdboothmnaser: Right, but that means you need to keep that metadata around until you want to boot it at some unspecified time. I can understand why they don't like that solution.15:42
mriedembeggars can't be choosers15:42
mnasermdbooth: yeah, that's the only reason that i feel like this might make value i guess15:42
mriedemwell, unless they are beggars with tons of cash15:42
mnaserbut i also dont think it's a trivial change given the whole logic of nova boot is to boot an instance15:43
leakypipes(in case people thought I was joking... https://www.percona.com/blog/2017/03/06/mysql-i-am-a-dummy/)15:43
mdboothmriedem: They have *some* cash :)15:43
mriedemmnaser: +1 to that15:43
*** dansmith is now known as SteelyDan15:43
mriedemthis might be a shocker, but given our current review rate to bp ratio, i won't hold my breath that this is something we're going to seriously consider soon, especially given we're just now getting deployments upgrading to the big changes we've worked on the last 2 years and they are having problems with them that we're trying to solve15:44
mdboothmnaser: It looked technically simple enough if we pass a flag in to not boot. I think the change in the libvirt driver, at least, would be relatively small.15:44
mdboothmriedem: ack. That's exactly why I'm not jumping on this.15:45
mriedemyou're talking about the power_on flag right? we use that to keep a stopped vm shutoff during cold migration15:45
mnaserwould it? dont we have to shortcircuit the whole: plug port, start up paused, wait for notification, resume thing15:45
mriedemwe already have plumbing to not wait for the vif plug if we didn't power on the vm15:46
mnaserah okay15:46
mriedemit was one of my first big bug fixes in nova15:46
mnaserhttps://github.com/openstack/nova/commit/9e7c7706a76ad76612ba75314d436a8ba419a3eb15:47
mnasermy amazing nova start15:47
leakypipes:)15:48
*** mlavalle has quit IRC15:50
*** mriedem has quit IRC15:50
*** mriedem has joined #openstack-nova15:51
*** munimeha1 has joined #openstack-nova15:51
mnaserbtw15:51
mnaserwe have 2 more releases to go15:51
mnaserhttps://review.openstack.org/#/c/619352/15:51
*** eharney has joined #openstack-nova15:51
mnasernot that i run pike but it'd be nice to flush it out15:52
*** mlavalle has joined #openstack-nova15:53
*** takamatsu has quit IRC15:53
*** moshele has joined #openstack-nova15:57
openstackgerritMatt Riedemann proposed openstack/nova master: Default zero disk flavor to RULE_ADMIN_API in Stein  https://review.openstack.org/60391015:59
mriedemmnaser: not sure about your thoughts on a nova-status upgrade check for ^16:00
mriedemto see if (1) you have root_gb=0 flavors and (2) your policy checks out for those16:01
mriedemand dump a warning if not16:01
mriedemi posted to the ML, but likely no one has read it, or grokked it, or cares because they aren't upgraded to that point of caring yet16:01
mriedemchecking the policy would be kind of tough though if there is a custom rule configured16:02
mnasermriedem: i saw it and mentally responded, i should write up a reply16:03
mnaseri'd like to warn against it but also i feel like it might break upgrade tooling in a way16:03
mnaseri guess it's about trying to see it as "behavioural change" vs "bug fix"16:03
mnaseri wouldn't want to see a warning because my cloud is operating as expected.. maybe a warning in stable/rocky though?16:04
*** artom is now known as temka16:08
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Add regression test for bug #1764883  https://review.openstack.org/62119916:08
openstackbug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,Fix released] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood)16:08
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: Ensure pre-migrating instances are destroyed during init_host  https://review.openstack.org/62120016:08
mriedemmnaser: by operating as expected, you mean you have 0 disk flavors but allow non-admins to use them intentionally even if they aren't booting from volume?16:12
mriedembtw, this is another area where https://review.openstack.org/#/c/511965/ would help16:13
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Update docs for _destroy_evacuated_instances  https://review.openstack.org/62120316:13
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Add regression test for bug #1764883  https://review.openstack.org/62120416:13
openstackbug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,Fix released] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood)16:13
openstackgerritLee Yarwood proposed openstack/nova stable/pike: compute: Ensure pre-migrating instances are destroyed during init_host  https://review.openstack.org/62120516:13
lyarwoodtemka: ^ there you go16:14
*** Sundar has joined #openstack-nova16:14
*** erlon has quit IRC16:15
Sundarefried: Please ping me on cyborg channel when you can. Thanks.16:16
mnasermriedem: sorry, i meant i have 0 disk flavors and i am ok with non-admins no longer being able to boot16:16
*** k_mouza has quit IRC16:16
temkalyarwood, ack16:17
mriedemmnaser: yeah in my mind the upgrade check wouldn't warn on that - if the policy is the default, you're ok even with 0-disk flavors. i'd think the check would warn if you have 0-disk flavors and your policy was not the default (admin_api)16:19
mriedembut like i said, the policy rule could be custom so it's hard to say16:19
mnaserah i see what you mean, i could have renamed by admin_api to foo_bar and it would warn anyways16:19
mriedemright16:19
mriedemthat's why i'm hesitant to add something16:19
mnaser+ if someone is actually running their own policy16:20
mnaserits very likely that its custom anyways16:20
*** mriedem has quit IRC16:21
*** s10 has quit IRC16:21
*** mriedem has joined #openstack-nova16:21
*** jangutter has quit IRC16:21
*** mchlumsky has quit IRC16:21
mriedemSteelyDan: before i make this change that leakypipes suggested in my cross-cell resize series, do you agree with it or a meh? https://review.openstack.org/#/c/614012/3/nova/db/sqlalchemy/models.py@79416:22
SteelyDanmriedem: HMM16:24
SteelyDanso,16:25
SteelyDanon the one hand, expanding the schema for a boolean seems kinda silly when we could store something useful16:25
*** tssurya has quit IRC16:25
SteelyDanBUT, the migration lives in the cell db, and I don't like ever telling the cell what cell it is, which it can kinda infer from that data16:25
*** pcaruana has joined #openstack-nova16:26
SteelyDanlike, imagine you do some migrations and then later collapse or split a cell16:26
mriedemas noted in the change, i get the source cell mapping from the host mapping tied to the source_compute in the migration object https://review.openstack.org/#/c/603930/15/nova/conductor/tasks/cross_cell_migrate.py@87116:26
mriedemso i don't *need* the explicit uuid in the migrations table16:26
SteelyDanright16:27
mriedemthe boolean flag is really for flow control16:27
SteelyDanI know16:27
mriedemi don't know if the source/dest cell uuids being in the migration record could be abused later16:27
mriedemi mean, i'm sure they could, i'm just not sure in what case16:27
*** gyee has joined #openstack-nova16:27
SteelyDanwell, it's not a matter of abuse so much as just separation of responsibilities16:28
mriedemonce the migration is done, we shouldn't really care about the record anymore, except reporting16:28
mriedemand if an operator is going to split cells, they had better make sure they don't have migrations going on while doing so16:28
SteelyDanyeah, not a matter of ongoing ones, but just those being wrong later16:29
SteelyDannothing else in the cell db knows about its position in the hierarchy and I think we should keep it that way16:29
SteelyDanso while I was going to argue against just storing a boolean,16:29
mriedemright. i mean, there could be a comment in there saying, "don't trust these after the migration is done"... but that's a bit hokey16:29
SteelyDanI think I'd prefer that over the uuids just for that reason16:29
SteelyDanheh16:29
mriedemSteelyDan: ok care to reply so i can move on?16:29
*** ShilpaSD has quit IRC16:29
SteelyDanyep16:30
mriedemthanks much16:30
mriedem<316:30
*** helenaAM has quit IRC16:31
*** Sundar has quit IRC16:33
*** ccamacho has quit IRC16:35
*** ccamacho has joined #openstack-nova16:35
*** xek has quit IRC16:36
*** k_mouza has joined #openstack-nova16:37
*** ttsiouts has joined #openstack-nova16:38
openstackgerritCorey Bryant proposed openstack/nova stable/pike: Revert "Backport tox.ini to switch to stestr"  https://review.openstack.org/62122716:38
*** ttsiouts has quit IRC16:39
*** ttsiouts has joined #openstack-nova16:40
*** ttsiouts has quit IRC16:44
*** rambo_li has quit IRC16:46
*** _hemna has quit IRC16:47
*** _pewp_ has quit IRC16:47
*** whoami-rajat has quit IRC16:48
*** udesale has quit IRC16:49
*** _pewp_ has joined #openstack-nova16:55
*** whoami-rajat has joined #openstack-nova16:55
*** rnoriega- has quit IRC16:56
*** med_ has quit IRC16:56
*** _hemna has joined #openstack-nova16:57
*** rnoriega has joined #openstack-nova16:58
*** eharney has quit IRC16:59
*** med_ has joined #openstack-nova17:02
*** pcaruana has quit IRC17:04
*** hongda has quit IRC17:04
openstackgerritMatt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid  https://review.openstack.org/61401217:09
openstackgerritMatt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field  https://review.openstack.org/61403517:09
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.openstack.org/61403617:09
openstackgerritMatt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells  https://review.openstack.org/61403717:09
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellWeigher  https://review.openstack.org/61435317:09
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Cross-cell resize  https://review.openstack.org/60393017:09
*** mriedem is now known as mriedem_lunch17:11
openstackgerritMerged openstack/python-novaclient master: Add Python 3.6 classifier to setup.cfg  https://review.openstack.org/62109317:13
*** eharney has joined #openstack-nova17:14
*** moshele has quit IRC17:20
*** mdbooth has quit IRC17:22
*** eharney has quit IRC17:22
*** erlon has joined #openstack-nova17:23
openstackgerritEric Fried proposed openstack/nova master: Reduce calls to placement from _ensure  https://review.openstack.org/61567717:26
openstackgerritEric Fried proposed openstack/nova master: Consolidate inventory refresh  https://review.openstack.org/61569517:26
openstackgerritEric Fried proposed openstack/nova master: Commonize _update code path  https://review.openstack.org/61570517:26
openstackgerritEric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient  https://review.openstack.org/61704217:26
openstackgerritEric Fried proposed openstack/nova master: Rip out the SchedulerClient  https://review.openstack.org/61704917:26
openstackgerritEric Fried proposed openstack/nova master: Use a static resource tracker in compute manager  https://review.openstack.org/62071117:26
efriedleakypipes: This all ought to be ready now ^17:26
leakypipesefried: k17:26
*** efried is now known as fried_rolls17:27
openstackgerritEric Fried proposed openstack/nova master: Turn off rp association refresh in nova-next  https://review.openstack.org/61603317:28
*** moshele has joined #openstack-nova17:30
*** tbachman has quit IRC17:35
*** _hemna has quit IRC17:36
*** _hemna has joined #openstack-nova17:38
*** igordc has joined #openstack-nova17:41
*** k_mouza_ has joined #openstack-nova17:44
*** k_mouza has quit IRC17:47
*** moshele has quit IRC17:48
*** k_mouza_ has quit IRC17:48
*** openstackgerrit has quit IRC17:51
*** derekh has quit IRC18:00
*** munimeha1 has quit IRC18:02
*** sridharg has quit IRC18:04
*** Swami has joined #openstack-nova18:09
*** k_mouza has joined #openstack-nova18:09
*** k_mouza has quit IRC18:14
*** wolverineav has joined #openstack-nova18:17
*** sahid has quit IRC18:34
*** tbachman has joined #openstack-nova18:35
*** ralonsoh has quit IRC18:41
*** wolverineav has quit IRC19:02
*** erlon has quit IRC19:02
*** munimeha1 has joined #openstack-nova19:02
*** wolverineav has joined #openstack-nova19:06
*** mriedem_lunch is now known as mriedem19:13
*** pacharya has joined #openstack-nova19:25
pacharyaHi I ran into weird issue where nova compute received empty port list for an instance during heal instance info cache. This caused the instance info cache for that instance to be set to empty list and now the APIs are not returning any network information. In the subsequent run neutron returned correct port list but nova does not fix the instance info cache so it remains broken. Any ideas on how to fix this?19:35
SteelyDanmriedem: ^19:36
*** wolverineav has quit IRC19:37
mriedempacharya: https://review.openstack.org/#/c/591607/19:40
mriedemwithout ^ the heal_instance_info_cache and network-changed events just refresh the cache from the cache...which is why it doesn't help you19:41
mriedemunfortunately you need to rebuild the cache somehow, and off the top of my head i think that might mean attaching/detaching a port to/from the server,19:41
mriedemif possible,19:41
*** wolverineav has joined #openstack-nova19:41
mriedemcould you just attach a dummy port to the server and then immediately detach it?19:41
mriedemotherwise you might have to try migrating the server, but i'm not sure if that will rebuild the network info cache for the instance19:42
*** wolverineav has quit IRC19:42
*** wolverineav has joined #openstack-nova19:42
*** wolverineav has quit IRC19:42
*** wolverineav has joined #openstack-nova19:43
*** wolverineav has quit IRC19:43
*** wolverineav has joined #openstack-nova19:43
*** wolverineav has quit IRC19:44
mriedemlooking at the code, attaching a new port might just put that port into the cache...19:44
mriedemso i'm not really sure what to tell you beside look at https://review.openstack.org/#/c/591607/19:44
*** wolverineav has joined #openstack-nova19:45
mriedemi know we have https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-reset-network but i don't think that will help19:46
*** noonedeadpunk has quit IRC19:47
*** wolverineav has quit IRC19:52
*** wolverineav has joined #openstack-nova19:53
pacharyaThanks ! @mriedem. I did try detaching and attaching the port but that did not seem to help. Will try it again just to be sure.19:58
*** wolverineav has quit IRC19:59
mriedempacharya: as i said, i think that at most will just refresh the cache for that single port - but if that's the only port attached to the server then that should be enough20:01
*** ivve has quit IRC20:04
pacharyaYeah and you are also correct about reset-network. that does not work either. I will look into the fix that you pointed out20:06
*** eharney has joined #openstack-nova20:07
*** whoami-rajat has quit IRC20:08
*** jistr has quit IRC20:11
*** jistr has joined #openstack-nova20:13
*** xek has joined #openstack-nova20:19
zzzeekcdent: so with https://review.openstack.org/#/c/614350/18, you tried putting the oslo fixtures into placement/tests/fixtures.py and it blew up ?20:20
*** wolverineav has joined #openstack-nova20:33
*** slaweq has quit IRC20:34
pacharyamriedem: will this get backported to queens https://review.openstack.org/#/c/591607/ ?20:34
pacharyajust curious20:34
*** openstackgerrit has joined #openstack-nova20:35
openstackgerritMatt Riedemann proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF  https://review.openstack.org/60280420:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349920:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add compute_node ratio online data migration script  https://review.openstack.org/60999520:35
zzzeekcdent: ummmm....it doesnt' seem to be provisioning anonymously named databases....odd20:36
mriedemleakypipes: i have gone through the first 3 of 5 changes in that series, you might want to start warming up to it sooner than later since it's in a runway slot (for the 2nd time) and you are familiar given it was your spec20:36
zzzeekwonder how it works20:36
mriedempacharya: idk, i haven't looked at it in awhile - maciej has taken it over20:36
mriedempacharya: i would think so though if we can20:36
mriedemjackding: oh boy the io semaphore unit test changes are causing a race http://logs.openstack.org/22/606122/7/check/openstack-tox-py27/d70a4d5/testr_results.html.gz20:40
mriedemlooks like mdbooths new evacuate functional tests are also racy20:48
*** openstackgerrit has quit IRC20:50
*** fried_rolls is now known as fried_rice20:51
*** itlinux has joined #openstack-nova20:51
*** takamatsu has joined #openstack-nova20:53
cdentzzzeek: what's there is the result of much experimentation and it does work: i can witness the databases being created and manipulated (turned on query logging in the database logs)20:56
cdentthe names of things are being overridden20:56
zzzeekcdent: OK so it makes anonymously named databases in PG / MySQL for the migration tests ?20:56
cdentzzzeek: no, it skips that part because it was getting in way of managing multiople databases in the same process. also, as far as I could tell the anonymous naming was only working for mysql, not for postgresql20:57
zzzeekcdent: do you run multiple tests concurrently in a single process?20:58
sean-k-mooneyzzzeek: in the nova tests we have eventlet so maybe20:58
*** itlinux_ has joined #openstack-nova20:58
cdenton the postgres side is was always the same name, so given that worked for postgres, I made it work for mysql and sqlite too, and then locked the tests with an external lock so there aren't concurrency issues between processes. There aren't concurrent tests in the same process but there is concurrency inter-process20:58
*** itlinux has quit IRC20:59
zzzeekcdent: yes that is all normal20:59
cdentsean-k-mooney: we're talking about the placement side right now20:59
zzzeekcdent: OK so the oslo_db way here is good to go, so I will see if i can make it work20:59
zzzeekcdent: also there's just one enginefacade in placement, it seems20:59
zzzeekcdent: which also makes this straightforwad, I see normal create_all() for sqlite then dispose on the end, that's all good20:59
sean-k-mooneycdent: ah ok well im caling it a day anyway.21:00
cdentzzzeek: when we talked about this before (on that review) you said that the existing fixtures wouldn't be quite adequate, which is how what's there ended up the way it did. you said it was "probably good enough|21:00
zzzeekcdent: i belive that's because early on I thougth i was looking at nova :)21:01
cdentzzzeek: but if there are ways it can be made more tidy, that would be great21:01
zzzeekcdent: the oslo_db fixtures should work here fully and if they dont thats a bug in oslo.db i have to fix21:01
cdentbtw: we've got #openstack-placement now for this sort of thing21:01
zzzeekcdent: I had guessed that but was too lazy to try :)21:01
cdentI know how that can be21:01
cdentIf you traverse the several rounds of me trying different things on that review, where it went wrong may be obvious to me21:02
cdentlots of different things were tried so it is entirely possible that multiple factors are making it icky, but it really came down to one issue: trying to have all three of sqlite, postgres and mysql in the same process, in-series21:02
mriedemhttps://bugs.launchpad.net/nova/+bug/180612621:02
openstackLaunchpad bug 1806126 in OpenStack Compute (nova) "LibvirtRbdEvacuateTest and LibvirtFlatEvacuateTest tests race fail" [High,Confirmed]21:02
mriedemwe probably want to revert on that one ^21:03
mriedemhttps://review.openstack.org/#/c/591733/21:03
mriedemany cores around for revert discussoin?21:03
mriedemfriday is the best time for us to fuck the gate over21:03
cdentzzzeek: the in series is what caused the need for the complicated reset business. the situation has probably changed somewhat now that https://review.openstack.org/#/c/619121/ has merged, which changes the Database handling-in-tests21:03
zzzeekcdent: the reset handling here doesn't look that complicated. nova had soemthig much more exotic21:04
cdenti meant the stuff where _started is being manipulated21:04
mriedemzzzeek: unrelated, do you know much about group by and distinct clauses in postgresql?21:04
zzzeekmriedem: sure21:05
mriedemzzzeek: any sort of knowledge on https://review.openstack.org/#/c/619061/ for that would be great21:05
zzzeekmriedem: i would say, it's unusual to be mixing those two things21:05
mriedemmy fix is basically based on internet forums...21:05
zzzeekmriedem: also....i dont follow that often, are we supporting postgresql again in openstack ?21:05
mriedemi believe the official stance is "meh"21:05
zzzeekmriedem: OK so no change21:06
mriedemwe don't turn away fixes21:06
mriedembut we don't bend over backwards to test and support it either21:06
cdentmy understanding is that every now and again mriedem and I try to make it happen21:06
mriedemsome neutron and manila people apparently pay attention to pg also21:06
zzzeekmriedem: um, distinct(col_expr) doesnt work on mysql or sqlite unless I'm deeply confused21:07
zzzeekmriedem: how is that working?21:07
mriedemi assumed the underlying sqla plugins were just nooping or something, idk21:07
mriedemi threw up a fix and it made the pg job work again21:07
zzzeekmriedem: also...i dont see why this query uses group_by21:07
cdentzzzeek: it's late and friday for me, so I'm going to watch bad tv and fall asleep. If you've got thoughts on that placement alembic stuff, please let me know, either on that review or on some wip that you invite me to look at21:07
mriedemas noted in my comments, it might not be the best query to start with21:07
cdenteveryone have a good weekend21:07
mriedemand simply rewriting the query could fix it for both21:07
mriedemo/21:08
* cdent waves21:08
*** wolverineav has quit IRC21:08
zzzeekmriedem: does InstanceMapping have any column_property() that points to like func.max() or func.count() or an aggregate of some kind ?21:10
zzzeekcdent: my plan is to make this work and put up a review21:10
zzzeekcdent: or if oslo_db is broke, do taht first21:10
cdentzzzeek: great, whichever it is point it out to me, will be very curious21:11
mriedemzzzeek: this is the model https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L13121:12
mriedemso i think the answer is "no"21:13
zzzeekmriedem: sure, it would be extremely weird to map an aggregate21:14
*** openstackgerrit has joined #openstack-nova21:15
openstackgerritMatt Riedemann proposed openstack/nova master: Revert "Add regression test for bug 1550919"  https://review.openstack.org/62128921:15
openstackbug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)21:15
*** awaugama has quit IRC21:29
*** pacharya has quit IRC21:31
*** wolverineav has joined #openstack-nova21:35
*** tbachman has quit IRC21:38
*** munimeha1 has quit IRC21:47
mriedemSteelyDan: leakypipes: there is some sage advice on here that i wanted to share with you https://www.siouxfallsshoppingnews.com/publishers-message.html21:50
mriedem"Life is simpler when you plow around the stump."21:51
mriedemi can tell you privately what i think that means21:51
SteelyDanum.21:56
openstackgerritMerged openstack/nova stable/rocky: Don't use private interface in oslo.service  https://review.openstack.org/61936021:57
*** wolverineav has quit IRC21:59
*** wolverineav has joined #openstack-nova22:04
*** wolverineav has quit IRC22:12
*** itlinux_ has quit IRC22:13
*** wolverineav has joined #openstack-nova22:13
*** wolverineav has quit IRC22:18
*** wolverineav has joined #openstack-nova22:19
openstackgerritEric Fried proposed openstack/nova master: Reduce calls to placement from _ensure  https://review.openstack.org/61567722:20
openstackgerritEric Fried proposed openstack/nova master: Consolidate inventory refresh  https://review.openstack.org/61569522:20
openstackgerritEric Fried proposed openstack/nova master: Commonize _update code path  https://review.openstack.org/61570522:20
openstackgerritEric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient  https://review.openstack.org/61704222:20
openstackgerritEric Fried proposed openstack/nova master: Rip out the SchedulerClient  https://review.openstack.org/61704922:20
openstackgerritEric Fried proposed openstack/nova master: Use a static resource tracker in compute manager  https://review.openstack.org/62071122:20
openstackgerritMerged openstack/nova stable/queens: Handle missing marker during online data migration  https://review.openstack.org/61097422:27
*** wolverineav has quit IRC22:28
*** wolverineav has joined #openstack-nova22:29
*** slaweq has joined #openstack-nova22:36
*** xek has quit IRC22:37
*** slaweq has quit IRC22:43
*** slaweq has joined #openstack-nova22:50
openstackgerritMatt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid  https://review.openstack.org/61401222:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field  https://review.openstack.org/61403522:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.openstack.org/61403622:51
openstackgerritMatt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells  https://review.openstack.org/61403722:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellWeigher  https://review.openstack.org/61435322:51
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Cross-cell resize  https://review.openstack.org/60393022:51
openstackgerritMatt Riedemann proposed openstack/nova master: Isolate cell-targeting code in MigrationTask  https://review.openstack.org/62131022:51
openstackgerritMatt Riedemann proposed openstack/nova master: Extract compute API _create_image to compute.utils  https://review.openstack.org/62131122:51
openstackgerritMatt Riedemann proposed openstack/nova master: Extract shelve API logic to compute.utils  https://review.openstack.org/62131222:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method  https://review.openstack.org/62131322:51
mriedemoooo under 2K LOC now22:52
mriedemwinning22:52
*** slaweq has quit IRC22:52
*** mriedem has quit IRC22:54
*** wolverineav has quit IRC22:54
*** slaweq has joined #openstack-nova22:54
*** wolverineav has joined #openstack-nova22:55
*** wolverineav has quit IRC23:00
*** wolverineav has joined #openstack-nova23:00
*** Nel1x has quit IRC23:01
*** burt has quit IRC23:03
*** Miouge- has quit IRC23:05
*** cdent has quit IRC23:07
*** itlinux has joined #openstack-nova23:07
*** Miouge has joined #openstack-nova23:08
*** slaweq has quit IRC23:22
*** Swami has quit IRC23:27
*** threestrands has joined #openstack-nova23:28
*** wolverineav has quit IRC23:42
*** wolverineav has joined #openstack-nova23:45
*** igordc has quit IRC23:48
*** wolverineav has quit IRC23:48
*** wolverineav has joined #openstack-nova23:49
*** slaweq has joined #openstack-nova23:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!