| *** spatel has quit IRC | 00:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1790204 https://review.openstack.org/619123 | 00:06 |
|---|---|---|
| openstack | bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [Medium,Triaged] https://launchpad.net/bugs/1790204 | 00:06 |
| *** tetsuro has quit IRC | 00:07 | |
| *** tetsuro has joined #openstack-nova | 00:10 | |
| *** mriedem has quit IRC | 00:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Add description of custom resource classes https://review.openstack.org/619125 | 00:41 |
| *** hamzy has joined #openstack-nova | 00:44 | |
| *** brinzhang has joined #openstack-nova | 01:22 | |
| *** brinzhang has quit IRC | 01:33 | |
| *** brinzhang has joined #openstack-nova | 01:33 | |
| *** tbachman has quit IRC | 01:55 | |
| openstackgerrit | Merged openstack/nova master: Consider root id is None in the database case https://review.openstack.org/613305 | 02:00 |
| *** Dinesh_Bhor has joined #openstack-nova | 02:02 | |
| *** sambetts_ has quit IRC | 02:02 | |
| *** sambetts_ has joined #openstack-nova | 02:06 | |
| *** tbachman has joined #openstack-nova | 02:10 | |
| *** mtreinish has quit IRC | 02:13 | |
| *** mtreinish has joined #openstack-nova | 02:13 | |
| *** cfriesen has quit IRC | 02:18 | |
| *** mrsoul has joined #openstack-nova | 02:30 | |
| *** jascott1 has joined #openstack-nova | 02:38 | |
| jascott1 | hi, im trying to understand how and under what conditions openstack attaches config-drive to a VM. I have one distro that has the config drive and one that doesnt. Any help appreciated | 02:39 |
| *** Dinesh_Bhor has quit IRC | 02:44 | |
| *** jascott1 has quit IRC | 02:44 | |
| *** mhen has quit IRC | 02:50 | |
| *** yedongcan has joined #openstack-nova | 02:50 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:52 | |
| *** mhen has joined #openstack-nova | 02:52 | |
| *** jascott1 has joined #openstack-nova | 02:56 | |
| *** jmlowe has quit IRC | 02:59 | |
| *** jmlowe has joined #openstack-nova | 03:00 | |
| *** jascott1 has quit IRC | 03:03 | |
| *** tbachman has quit IRC | 03:36 | |
| *** tbachman has joined #openstack-nova | 03:50 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: WIP: Remove live_migration_progress_timeout config https://review.openstack.org/619142 | 03:54 |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: WIP: Add live migration timeout action https://review.openstack.org/619143 | 03:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add descriptions about microversions https://review.openstack.org/619144 | 04:02 |
| *** psachin has joined #openstack-nova | 04:14 | |
| *** udesale has joined #openstack-nova | 04:17 | |
| *** bhagyashris has joined #openstack-nova | 04:18 | |
| bhagyashris | Atom: Hi, | 04:18 |
| bhagyashris | artom: Hi, Sorry for spelling ^ because of auto correction | 04:20 |
| *** itlinux has joined #openstack-nova | 04:33 | |
| *** janki has joined #openstack-nova | 04:42 | |
| *** jascott1 has joined #openstack-nova | 04:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix a type of block_device_mapping_v2 in a comment https://review.openstack.org/619145 | 04:44 |
| *** pooja_jadhav has joined #openstack-nova | 04:49 | |
| *** sridharg has joined #openstack-nova | 04:54 | |
| *** ratailor has joined #openstack-nova | 05:00 | |
| *** bhagyashris has quit IRC | 05:01 | |
| openstackgerrit | Merged openstack/nova master: Remove v1 check in Cinder client version lookup https://review.openstack.org/617927 | 05:35 |
| *** ileixe has joined #openstack-nova | 05:43 | |
| *** sambetts_ has quit IRC | 05:44 | |
| *** sambetts_ has joined #openstack-nova | 05:44 | |
| *** ileixe has quit IRC | 05:55 | |
| *** diga has quit IRC | 06:00 | |
| *** bhagyashris has joined #openstack-nova | 06:08 | |
| *** annp has joined #openstack-nova | 06:17 | |
| *** pooja_jadhav has quit IRC | 06:31 | |
| *** bhagyashris has quit IRC | 06:48 | |
| *** threestrands has joined #openstack-nova | 06:58 | |
| *** ileixe has joined #openstack-nova | 07:04 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config https://review.openstack.org/619142 | 07:05 |
| *** bhagyashris has joined #openstack-nova | 07:09 | |
| *** naichuans has joined #openstack-nova | 07:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform compute_task notifications https://review.openstack.org/482629 | 07:26 |
| *** rcernin has quit IRC | 07:26 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config https://review.openstack.org/619142 | 07:32 |
| *** adrianc has joined #openstack-nova | 07:34 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Amend the detach-boot-volume design https://review.openstack.org/619161 | 07:37 |
| *** sahid has joined #openstack-nova | 07:38 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Make scheduling weight more granular https://review.openstack.org/599308 | 07:38 |
| *** maciejjozefczyk has joined #openstack-nova | 07:44 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config https://review.openstack.org/619142 | 07:53 |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add live migration timeout action https://review.openstack.org/619143 | 07:53 |
| *** ccamacho has joined #openstack-nova | 07:59 | |
| *** sean-k-mooney has quit IRC | 08:06 | |
| *** artom has quit IRC | 08:08 | |
| *** artom has joined #openstack-nova | 08:12 | |
| *** artom has joined #openstack-nova | 08:13 | |
| *** maciejjozefczyk has quit IRC | 08:15 | |
| *** sahid has quit IRC | 08:20 | |
| *** helenafm has joined #openstack-nova | 08:21 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 08:22 |
| *** takashin has left #openstack-nova | 08:30 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow fetch root_volume BDM by instance_uuid https://review.openstack.org/614672 | 08:34 |
| *** dtantsur|afk is now known as dtantsur | 08:42 | |
| *** ralonsoh has joined #openstack-nova | 08:50 | |
| *** sapd1__ has quit IRC | 08:54 | |
| *** sapd1 has joined #openstack-nova | 08:55 | |
| *** ccamacho has quit IRC | 09:02 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add live migration timeout action https://review.openstack.org/619143 | 09:04 |
| *** ccamacho has joined #openstack-nova | 09:04 | |
| *** whoami-rajat has joined #openstack-nova | 09:09 | |
| frickler | melwitt: how long do we need to wait for further reviews on https://review.openstack.org/616580 ? this is a severe issue for us, currently running with a local patch. should I propose stable backports already or wait for the patch being merged in master? | 09:12 |
| *** ratailor has quit IRC | 09:12 | |
| *** tetsuro has quit IRC | 09:12 | |
| *** ratailor has joined #openstack-nova | 09:13 | |
| *** erlon has quit IRC | 09:24 | |
| *** jaosorior has quit IRC | 09:26 | |
| *** ondrejme has quit IRC | 09:28 | |
| *** k_mouza has joined #openstack-nova | 09:28 | |
| *** k_mouza has quit IRC | 09:28 | |
| *** k_mouza has joined #openstack-nova | 09:29 | |
| *** derekh has joined #openstack-nova | 09:30 | |
| *** tssurya has joined #openstack-nova | 09:32 | |
| *** cdent has joined #openstack-nova | 09:37 | |
| kashyap | frickler: Hi, Mel is away on PTO, so a core reviewer can just do +W there, since it already has two +2s | 09:46 |
| *** pcaruana has joined #openstack-nova | 09:48 | |
| cdent | ah yes, Thanskgiving, a time of review drought and dry turkeys. | 09:49 |
| melwitt | frickler: I'm not sure. I would ask mriedem since he left a comment about waiting a bit before approval | 09:50 |
| * cdent checks the time | 09:51 | |
| *** bhagyashris has quit IRC | 09:51 | |
| *** gibi has quit IRC | 10:01 | |
| *** jaosorior has joined #openstack-nova | 10:03 | |
| *** k_mouza has quit IRC | 10:04 | |
| *** gibi has joined #openstack-nova | 10:08 | |
| *** k_mouza has joined #openstack-nova | 10:23 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 10:29 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | 10:29 |
| *** k_mouza has quit IRC | 10:32 | |
| *** jascott1 has quit IRC | 10:33 | |
| *** priteau has joined #openstack-nova | 10:37 | |
| *** erlon has joined #openstack-nova | 10:40 | |
| *** threestrands has quit IRC | 10:43 | |
| *** nehaalhat_ has quit IRC | 10:51 | |
| *** k_mouza has joined #openstack-nova | 10:53 | |
| *** k_mouza has quit IRC | 10:57 | |
| *** k_mouza has joined #openstack-nova | 10:59 | |
| *** yedongcan has left #openstack-nova | 11:03 | |
| *** mvkr has quit IRC | 11:03 | |
| *** sambetts_ is now known as sambetts|afk | 11:21 | |
| *** udesale has quit IRC | 11:28 | |
| *** Dinesh_Bhor has quit IRC | 11:37 | |
| *** xek has quit IRC | 11:39 | |
| *** mvkr has joined #openstack-nova | 11:43 | |
| *** sean-k-mooney has joined #openstack-nova | 11:46 | |
| *** mugsie has joined #openstack-nova | 11:49 | |
| *** janki has quit IRC | 11:50 | |
| *** tssurya has quit IRC | 11:55 | |
| *** janki has joined #openstack-nova | 11:56 | |
| *** psachin has quit IRC | 12:01 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/nova stable/queens: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619220 | 12:01 |
| *** xek has joined #openstack-nova | 12:04 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 12:06 |
| openstackgerrit | Jan Gutter proposed openstack/nova-specs master: Spec to implement os-vif generic datapath offloads https://review.openstack.org/607610 | 12:10 |
| *** janki has quit IRC | 12:12 | |
| *** brinzhang has quit IRC | 12:15 | |
| *** brinzhang has joined #openstack-nova | 12:15 | |
| *** brinzhang has quit IRC | 12:16 | |
| *** brinzhang has joined #openstack-nova | 12:17 | |
| *** phillu has joined #openstack-nova | 12:19 | |
| mnaser | https://review.openstack.org/#/c/615134/ | 12:26 |
| mnaser | this has been sitting for a little while and it's very trivial | 12:26 |
| *** pvradu has joined #openstack-nova | 12:31 | |
| *** pvradu has quit IRC | 12:32 | |
| *** pvradu has joined #openstack-nova | 12:33 | |
| jangutter | ^^ impressive amount of CI checks against that one. | 12:34 |
| sean-k-mooney | mnaser: so the logic is really old flavor could only be plublic so default to public? if that is the case then yes this makes sense | 12:36 |
| mnaser | jangutter: i pride myself in checking my stuff, hah | 12:37 |
| mnaser | sean-k-mooney: well we either have to assume its public or its not. given that we default to public=True, and that field is missing, it probably is true | 12:38 |
| *** brinzhang has quit IRC | 12:38 | |
| sean-k-mooney | ok i can see the logic in that argument. | 12:38 |
| *** dtantsur is now known as dtantsur|brb | 12:47 | |
| sean-k-mooney | jaypipes: https://review.openstack.org/#/c/602384/ responces in line. ill respin once you decide if you would like to see addtional changes but i think the typo was the only thing you wanted adressed in the patch correct | 12:57 |
| jaypipes | sean-k-mooney: yup. was just curious about the other questions... | 13:01 |
| *** tssurya has joined #openstack-nova | 13:02 | |
| *** zul has joined #openstack-nova | 13:13 | |
| sean-k-mooney | cool in that case ill fix the typo. can you cast your eye over the follow up patch when you have a chance | 13:14 |
| *** k_mouza has quit IRC | 13:17 | |
| *** k_mouza has joined #openstack-nova | 13:30 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:46 | |
| *** ratailor has quit IRC | 13:49 | |
| *** mriedem has joined #openstack-nova | 13:49 | |
| mriedem | dansmith: lyarwood: https://review.openstack.org/#/q/topic:bug/1799892+(status:open+OR+status:merged) on stable should be good to go now | 13:49 |
| mriedem | other cores, the hpet change just needs a final +2 https://review.openstack.org/#/c/605902/ | 13:50 |
| openstackgerrit | Hervé Beraud proposed openstack/nova stable/rocky: Stop to mocking oslo.service.loopingcall._ThreadingEvent since this class was removed https://review.openstack.org/619246 | 13:53 |
| *** whoami-rajat has quit IRC | 13:54 | |
| *** maciejjozefczyk has quit IRC | 13:56 | |
| frickler | mriedem: do you want to continue waiting on https://review.openstack.org/616580 ? it would be great if we could get that fix into the next round of stable releases, not sure whether there is something scheduled for that yet | 13:58 |
| *** janki has joined #openstack-nova | 13:59 | |
| mriedem | frickler: i was waiting for more core reviews, but they didn't come, so approved | 14:00 |
| mriedem | you'll need to backport to stable/rocky | 14:00 |
| mriedem | we likely won't be doing a series of stable releases until after the US thanksgiving holiday (which is tomorrow) | 14:00 |
| *** BlackDex has quit IRC | 14:02 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619251 | 14:02 |
| *** peeejayz has joined #openstack-nova | 14:03 | |
| *** pvradu_ has joined #openstack-nova | 14:03 | |
| *** munimeha1 has joined #openstack-nova | 14:03 | |
| frickler | mriedem: stable/rocky is a simple cherry-pick from master, which I did now. stable/queens required editing because the function moved its location, which is why I prepared that patch earlier | 14:04 |
| *** BlackDex has joined #openstack-nova | 14:04 | |
| *** pvradu has quit IRC | 14:07 | |
| *** pvradu_ has quit IRC | 14:07 | |
| *** dtantsur|brb is now known as dtantsur | 14:07 | |
| *** pvradu has joined #openstack-nova | 14:08 | |
| frickler | mriedem: do you think that it should also go into pike and ocata? seems those would require more editing, but the bug is present in those branches, too. | 14:08 |
| openstackgerrit | Hervé Beraud proposed openstack/nova stable/rocky: Stop to mocking oslo.service.loopingcall._ThreadingEvent since this class was removed https://review.openstack.org/619246 | 14:08 |
| mriedem | frickler: can you re-cherry-pick to rocky using the command line? | 14:09 |
| mriedem | with the -x option | 14:09 |
| mriedem | the gerrit UI won't do that until the change you're cherry picking *from* has merged | 14:09 |
| mriedem | frickler: ocata is in extended maintenance mode and i'm not really sure this needs to go that far back upstream | 14:10 |
| *** Sundar has joined #openstack-nova | 14:10 | |
| mriedem | EM means it *could* go that far back, but i'm not sure it's high enough priority | 14:10 |
| mriedem | s/priority/severity/ | 14:10 |
| frickler | mriedem: oh, I was hoping gerrit would be the better option than command-line. but does it do anything other than add the "cherry picked from" line to the commit message? in that case I'd just add that line manually | 14:12 |
| frickler | mriedem: o.k., so I'll do pike but not ocata. pike is the release most of our deployments are currently running on. | 14:13 |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619251 | 14:14 |
| mriedem | stable cores: we have quite a few rocky backports that need a final +2 https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+label:Code-Review=2 | 14:17 |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/nova stable/pike: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619254 | 14:18 |
| *** jaosorior has quit IRC | 14:25 | |
| *** gary_perkins has joined #openstack-nova | 14:30 | |
| gary_perkins | Hi! I'm not sure if this would be the best channel to ask, but I ask anyway :) I have a kolla-ansible deployment of Queens. I have set a nova policy rule "os_compute_api:servers:create:zero_disk_flavor": "rule:admin_api" to stop any image-backed instances with a zero root-disk from being created. I want to only allow cinder-volume backed instances. But, for some reason, this policy change has had no noticable effect. I'm expecting my " | 14:31 |
| gary_perkins | openstack server create" to return an error, but instead it creates an instance consuming local storage. Is there something I'm missing? | 14:31 |
| gary_perkins | TIA | 14:31 |
| *** k_mouza has quit IRC | 14:39 | |
| *** udesale has joined #openstack-nova | 14:39 | |
| *** k_mouza has joined #openstack-nova | 14:42 | |
| *** whoami-rajat has joined #openstack-nova | 14:43 | |
| *** davidsha has joined #openstack-nova | 14:53 | |
| *** cfriesen has joined #openstack-nova | 15:10 | |
| sean-k-mooney | so rather then ask this in the olso changel again.. the stien schdule does not list the nova specs freeze. is it m2 | 15:12 |
| cdent | sean-k-mooney: last I heard, yes, but I don't have a good memory for arbitrary deadlines | 15:15 |
| sean-k-mooney | cdent: ya that i why i check the scduel. m2 is still the first week of january so that means really the dealin is decemebr ish before people evaporate | 15:17 |
| Sundar | Can somebody tell me how to derive a SQLalchemy model (table) from an OVO, or vice versa? | 15:17 |
| dansmith | Sundar: they're not related | 15:18 |
| jangutter | rule of thumb, the spec freeze is about two weeks before the first possible free time of the reviewers who can approve them. | 15:18 |
| dansmith | Sundar: some of our SQLA models match our OVO objects pretty close, but many do not.. but either way, they're not 1:1 | 15:18 |
| Sundar | dansmith: So, we may have to represent the same object in 2 different ways and translate back and forth? | 15:19 |
| dansmith | Sundar: I'm not sure I understand what you mean, but.. yes? In nova at least, the model is how we store it, and the OVO object is how we speak it over RPC.. sometimes they're very similar, but not always | 15:20 |
| Sundar | OK. Thank you. | 15:20 |
| *** jaosorior has joined #openstack-nova | 15:24 | |
| mriedem | sean-k-mooney: https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule | 15:28 |
| mriedem | gary_perkins: you're sure disk=0 on the flavor? | 15:28 |
| sean-k-mooney | mriedem: ah thank you | 15:28 |
| sean-k-mooney | ah and the os-vif frees is listed too perfect | 15:29 |
| mriedem | gary_perkins: and that a bdm isn't being passed on the server create request? | 15:31 |
| gary_perkins | mriedem: yes, disk=0 on the flavor | 15:31 |
| gary_perkins | mriedem: bdm? | 15:32 |
| mriedem | block_device_mapping_v2 | 15:33 |
| gary_perkins | my command line to spin up an instance is: os server create --image bionic-server-cloudimg-arm64 --flavor c2.large --key-name gary-key --nic net-id=2e8281a6-30f4-4cdc-b433-c87137413af7 test-1 | 15:33 |
| mriedem | the dict-o-doom for boot from volume | 15:33 |
| mriedem | ok and that image doesn't have a block_device_mapping_v2 property in it? | 15:33 |
| mriedem | which is the trojan horse way of boot from volume | 15:34 |
| gary_perkins | hmmm.. good point, will check | 15:34 |
| mriedem | fwiw, this is a functional test for exactly what you're trying to see https://github.com/openstack/nova/blob/d74f9d62c5c320539ff5a46f28b0104c3b236633/nova/tests/functional/wsgi/test_servers.py#L385 | 15:34 |
| mriedem | mnaser was trying to switch the default on that rule in stein but it turns out the flavors used in devstack, which tempest uses in our CI, have disk=0 so they explode :) https://review.openstack.org/#/c/603910/ | 15:36 |
| gary_perkins | mriedem: thanks! and no block_device_mapping_v2 property | 15:36 |
| gary_perkins | ha! | 15:37 |
| mnaser | mriedem: ah sorry i never actually got around cleaning that one up | 15:37 |
| mriedem | mnaser: it's going to be non-trivial | 15:37 |
| mriedem | gary_perkins: which policy file did you modify? | 15:37 |
| mriedem | /etc/nova/policy.json? | 15:38 |
| jangutter | something that still shows how much of a noob I am: regarding blueprint and specs. Is there a specific order in which things get approved normally? spec -> blueprint? Or is it not ordered? | 15:38 |
| mriedem | make sure whatever policy file you modified is the one this option points at https://docs.openstack.org/nova/queens/configuration/config.html#oslo_policy.policy_file | 15:38 |
| mnaser | mriedem: because now in tempest we need to use a flavor that is non root_gb=0 first before that can ever work, right? | 15:38 |
| mriedem | jangutter: spec and then blueprint | 15:38 |
| mriedem | mnaser: yeah, and tempest is configured with flavors that devstack sets up in our CI | 15:38 |
| mriedem | https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L191 | 15:39 |
| jangutter | mriedem: thanks! | 15:39 |
| mriedem | tempest is also configured with the cirros images https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L326 | 15:40 |
| mriedem | so maybe we just need to get the image size from glance and use that for the flavor disk size | 15:40 |
| mnaser | mriedem: will we still be able to get coverage for bfv with root_gb=0 then? | 15:40 |
| *** Sundar has quit IRC | 15:41 | |
| mnaser | or that might involve probably adding tempest tests | 15:41 |
| mriedem | not unless you add a specific test to tempest for that | 15:41 |
| mriedem | we have functional tests in nova for it | 15:41 |
| mriedem | but those don't use a real virt driver | 15:41 |
| mriedem | yay min_disk=0 on the image http://logs.openstack.org/34/615134/2/check/tempest-full/f6d351a/controller/logs/devstacklog.txt.gz#_2018-11-02_13_20_26_698 | 15:42 |
| mriedem | that's helpful | 15:42 |
| gary_perkins | mriedem: yes, /etc/nova/policy.json originally copied from https://docs.openstack.org/nova/queens/_downloads/nova.policy.yaml.sample | 15:43 |
| mriedem | gary_perkins: but what is [oslo_policy]/policy_file in nova.conf in the nova-api service pointing at? | 15:43 |
| mriedem | b/c you said policy.json but you linked to a policy.yaml sample | 15:43 |
| gary_perkins | mriedem: oh, sorry. Just trying to find my original sample. That's obviously the wrong one | 15:45 |
| gary_perkins | mriedem: nova.conf: policy_file = policy.json | 15:46 |
| mriedem | hmm, and you shouldn't have to restart nova-api after modifying the policy file, it should be read fresh each time | 15:47 |
| *** ratailor has joined #openstack-nova | 15:48 | |
| gary_perkins | and ofc, policy.json has: "os_compute_api:servers:create:zero_disk_flavor": "rule:admin_api" | 15:49 |
| gary_perkins | amongst may other policies! | 15:49 |
| *** tssurya has quit IRC | 15:50 | |
| *** udesale has quit IRC | 15:58 | |
| *** Sundar has joined #openstack-nova | 16:01 | |
| *** adrianc has quit IRC | 16:09 | |
| *** phillu has quit IRC | 16:15 | |
| mriedem | gary_perkins: i'm not sure. have you tried tweaking any other policy rules to make sure it's not something with the configuration of the policy file? | 16:17 |
| *** ratailor has quit IRC | 16:24 | |
| *** k_mouza has quit IRC | 16:28 | |
| *** ileixe has quit IRC | 16:33 | |
| *** janki has quit IRC | 16:36 | |
| xek | gibi, there are no versioned network.floating_ip.associate network.floating_ip.disassociate notifications? | 16:45 |
| artom | mriedem, hey, so, I'm being told from people who were at summit that you were in the room at the NFV pain points session (https://etherpad.openstack.org/p/BER-nfv-hpc-pain-points). Now, to me, that sounds like nothing could make you happier than reviewing https://review.openstack.org/#/c/599587/, right ;) | 16:46 |
| gibi | xek: is there an unversioned one from nova about those? | 16:46 |
| *** Sundar has quit IRC | 16:47 | |
| gibi | xek: OK I see there is unversioned ones for those | 16:47 |
| xek | gibi, I see they are emitted in nova.network.floating_ips, but I'm not sure if there is an alternative somewhere else? maybe in neutron? | 16:47 |
| mriedem | artom: lots of things could make me happier | 16:48 |
| *** k_mouza has joined #openstack-nova | 16:48 | |
| artom | mriedem, what if I promised ice cream? | 16:48 |
| mriedem | xek: gibi: i don't think we'd port that to versioned notifications since they are nova-network specific and that's deprecated | 16:48 |
| mriedem | artom: i have ice cream like 30 feet away | 16:49 |
| artom | Foiled again! | 16:49 |
| artom | mriedem, in seriousness, I know y'all are overloaded, I'm just trying to get it over the line, so if you have energy/bandwidth, it'd be appreciated | 16:49 |
| *** pcaruana has quit IRC | 16:50 | |
| gibi | xek, mriedem: yeah, I just found that it is only emitted from the nova network code patch, this is why they are not on the todo list for versioned transformation | 16:50 |
| *** efried_back_mon has quit IRC | 16:51 | |
| gibi | xek: I don't know if neturon has a similar notification mechanism | 16:51 |
| xek | gibi, mriedem, it makes sense, thanks for clarifying that. | 16:52 |
| gibi | mlavalle: ^^ do you happen to know if neutron emits notification about floating ips? | 16:52 |
| *** xek_ has joined #openstack-nova | 16:54 | |
| *** xek has quit IRC | 16:57 | |
| *** helenafm has quit IRC | 17:02 | |
| mlavalle | gibi: what kind of notification are we talking about? the code sends notifications like this: https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1408 | 17:05 |
| mlavalle | These are internal notifications. modules subscribe to these notifications to listen to events and process them | 17:06 |
| mriedem | mlavalle: yes same thing | 17:08 |
| mriedem | over rpc | 17:08 |
| *** pvradu has quit IRC | 17:08 | |
| *** sambetts|afk has quit IRC | 17:14 | |
| mriedem | mnaser: let's see what explodes https://review.openstack.org/619319 | 17:14 |
| *** betherly has joined #openstack-nova | 17:15 | |
| mnaser | mriedem: seems reasonable. i'll have to fix the functional tests soon | 17:15 |
| mnaser | ugh the logs have been rotated out already | 17:15 |
| mriedem | yeah one thing at a time | 17:16 |
| mriedem | not urgent | 17:16 |
| *** sambetts_ has joined #openstack-nova | 17:16 | |
| *** k_mouza has quit IRC | 17:17 | |
| *** alex_xu has quit IRC | 17:17 | |
| *** xek_ is now known as xek | 17:18 | |
| *** alex_xu has joined #openstack-nova | 17:19 | |
| *** sridharg has quit IRC | 17:20 | |
| *** k_mouza has joined #openstack-nova | 17:21 | |
| *** betherly has quit IRC | 17:21 | |
| *** davidsha has quit IRC | 17:35 | |
| *** jaosorior has quit IRC | 17:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove NovaException logging from scatter_gather_cells https://review.openstack.org/619110 | 17:44 |
| *** dtantsur is now known as dtantsur|afk | 17:49 | |
| *** derekh has quit IRC | 17:50 | |
| *** k_mouza has quit IRC | 18:12 | |
| dansmith | I think Greg's windows box has a virus | 18:17 |
| *** mriedem has quit IRC | 18:26 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 18:31 |
| *** mriedem has joined #openstack-nova | 18:37 | |
| jangutter | dansmith: please take this as a late night bad joke: isn't that a redundant statement? | 18:39 |
| dansmith | jangutter: yeah, maybe I should say "Greg's windows box has a virus and is proud enough to show off in public" | 18:40 |
| *** ralonsoh has quit IRC | 18:40 | |
| openstackgerrit | Merged openstack/nova stable/queens: De-dupe subnet IDs when calling neutron /subnets API https://review.openstack.org/616551 | 18:45 |
| *** xek has quit IRC | 19:00 | |
| *** xek has joined #openstack-nova | 19:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 19:10 |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 19:14 |
| openstackgerrit | Merged openstack/nova stable/rocky: Add recreate test for bug 1799892 https://review.openstack.org/619075 | 19:15 |
| openstack | bug 1799892 in OpenStack Compute (nova) rocky "Placement API crashes with 500s in Rocky upgrade with downed compute nodes" [Medium,In progress] https://launchpad.net/bugs/1799892 - Assigned to Matt Riedemann (mriedem) | 19:15 |
| mriedem | easy bug fix https://review.openstack.org/#/c/615134/ | 19:24 |
| *** prometheanfire has left #openstack-nova | 19:33 | |
| *** dklyle has quit IRC | 19:38 | |
| *** mvkr has quit IRC | 19:40 | |
| *** whoami-rajat has quit IRC | 19:41 | |
| mriedem | anyone have any bright ideas on how to assert a semaphore context manager is called in unit tests? https://review.openstack.org/#/c/609180/7/nova/tests/unit/virt/libvirt/test_driver.py | 19:46 |
| *** dklyle has joined #openstack-nova | 19:46 | |
| *** erlon has quit IRC | 19:49 | |
| sean-k-mooney | mriedem: as in assert the semaphore was aquired on a partaclar code path? | 19:51 |
| sean-k-mooney | just looking | 19:52 |
| mriedem | http://paste.openstack.org/show/735916/ | 19:57 |
| sean-k-mooney | mriedem: do you want sema.__enter__.assert_called_once() or just assert it is called | 19:58 |
| mriedem | does'nt matter | 19:59 |
| mriedem | point is, i don't really want to add a bunch of mocks all over test code and never assert it's used | 20:00 |
| sean-k-mooney | ah ok | 20:00 |
| sean-k-mooney | im not sure that does what you want | 20:02 |
| sean-k-mooney | you are asserting that the __enter__ metod of the sema context manager is called but will that not always be called by the with statement | 20:03 |
| mriedem | if i remove the code change for that method, the test fails | 20:03 |
| mriedem | which is what i'd expect | 20:03 |
| sean-k-mooney | hum ok this is one of those things in python that i always have to trow in an interpreter to prove to myself it scorrect | 20:04 |
| mriedem | i also don't know why we have nova.privsep.qemu.convert_image but not everything uses it, there are a few places in here that are calling qemu-img convert outside of privsep | 20:06 |
| mriedem | dansmith: do you know anything about that? ^ | 20:06 |
| mriedem | b/c i thought we declared mission accomplished on privsep stuff | 20:06 |
| sean-k-mooney | mriedem: are the fucntion that call it out side of privsep called from function with the prive sep decorator applied | 20:07 |
| mriedem | umm, no | 20:08 |
| mriedem | grep _disk_raw_to_qcow2 in the libvirt driver | 20:08 |
| mriedem | it's using processutils from oslo | 20:08 |
| mriedem | and we're passing through a rootwrap helper | 20:09 |
| dansmith | mriedem: not everything like that needs to run privileged | 20:10 |
| sean-k-mooney | ttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n8361 is using oslo but i dont see a rootwarap helper | 20:10 |
| dansmith | mriedem: might be that we need image convert sometimes when reading from an lvm or something like that, I dunno | 20:10 |
| mriedem | ok i'll pretend this never happene | 20:11 |
| dansmith | good plan | 20:11 |
| sean-k-mooney | assuimg the nova user has the correct permisiosn to read and write the vm images it shoudl be able to execute that command with out elevating | 20:11 |
| mriedem | jackding: so on that io concurrency change, | 20:11 |
| mriedem | i would just like to see that for the functional code paths that add the context manager, | 20:11 |
| mriedem | that at least one corresponding unit test asserts the context manager is called | 20:11 |
| mriedem | like i noted for _disk_raw_to_qcow2 | 20:12 |
| mriedem | then i'm +20 on that change | 20:12 |
| mriedem | the privsep one might not be possible | 20:12 |
| sean-k-mooney | based on code search its only ever called once | 20:12 |
| sean-k-mooney | http://codesearch.openstack.org/?q=_disk_raw_to_qcow2&i=nope&files=&repos=nova | 20:12 |
| jackding | mriedem: I have added asserts for all places where sema is used. running tox now, will push after it's done. | 20:12 |
| sean-k-mooney | here in finish migration http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n8437 | 20:12 |
| mriedem | jackding: sweet | 20:13 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | 20:15 |
| *** cdent has quit IRC | 20:18 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: always create ovs port during plug https://review.openstack.org/602384 | 20:18 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add isolate_vif config option https://review.openstack.org/612534 | 20:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619349 | 20:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619351 | 20:28 |
| *** mvkr has joined #openstack-nova | 20:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619352 | 20:36 |
| openstackgerrit | Merged openstack/nova stable/rocky: Consider root id is None in the database case https://review.openstack.org/619076 | 20:46 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | 20:57 |
| mriedem | there are some assertions made in this change which i'm not sure i agree with https://review.openstack.org/#/c/617927/ | 20:58 |
| mriedem | hopefully that doesn't set some kind of precedent | 20:58 |
| mriedem | saying nova supports cinder v1 is a stretch, but i wouldn't want someone to think, nova stein can't work with cinder from queens | 20:59 |
| mriedem | because it totally should | 20:59 |
| *** manjeets has quit IRC | 21:12 | |
| *** betherly has joined #openstack-nova | 21:13 | |
| openstackgerrit | Merged openstack/nova master: Default embedded instance.flavor.is_public attribute https://review.openstack.org/615134 | 21:20 |
| *** betherly has quit IRC | 21:23 | |
| *** xek has quit IRC | 21:40 | |
| mriedem | stephenfin: artom: i've granted your wish and reviewed the numa aware live migration spec and dumped some questions | 21:41 |
| mriedem | artom: can you tl;dr the diff from the approved spec in rocky to stein? | 21:42 |
| mriedem | because this essentially sounds like, do the RT/claim stuff like cold migration already does (and what nikola's old patch did) | 21:42 |
| mriedem | was the rocky version of the spec much more dependent on actually modeling numa in placement? | 21:42 |
| openstackgerrit | Zane Bitter proposed openstack/nova stable/rocky: Don't use private interface in oslo.service https://review.openstack.org/619360 | 21:44 |
| sean-k-mooney | the stine one has been refined somewhat to not depend on plamcennt at all | 21:44 |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042 | 21:44 |
| sean-k-mooney | mriedem: it will prefrom claims in the RT on the destination node and pass back the topology info as ovo form the dest to the source the same way we did for the multi port bindings spec | 21:45 |
| mriedem | sean-k-mooney: i just read the stein one | 21:47 |
| mriedem | i was looking for the summary on the diff from the rocky spec | 21:47 |
| sean-k-mooney | ah ok stephen just proposed tthe rocky one as is so the delta should just be comparing to v1 of the stein one | 21:48 |
| sean-k-mooney | there was no content change when stepen reproposed it so https://review.openstack.org/#/c/599587/1..6/specs/stein/approved/numa-aware-live-migration.rst will show you the delta | 21:50 |
| sean-k-mooney | basicaly we added detail for the resouce claimes section and how the nume info on the destinaiton woudl be generated | 21:51 |
| artom | mriedem, whoa, thanks dude | 21:53 |
| artom | What sean-k-mooney said. And also how the destination will communicate said NUMA stuff to the source | 21:53 |
| mriedem | right, ok so no placement | 21:54 |
| mriedem | got it | 21:54 |
| artom | And more explicitly spelled out why we can't use just placement (even if it was ready, which it isn't) and still need the resource tracker | 21:54 |
| mriedem | given that, i'm going to f off for thanksgiving now | 21:54 |
| artom | Fair enough, r right off then :) | 21:55 |
| artom | *f | 21:55 |
| sean-k-mooney | mriedem: enjoy the break o/ | 21:55 |
| *** betherly has joined #openstack-nova | 21:55 | |
| artom | I haven't fully parsed your feedback then, but I'll have a new version for you when you're back | 21:55 |
| artom | s/then/yet | 21:55 |
| artom | wtf brain | 21:55 |
| *** mriedem has quit IRC | 21:59 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619366 | 22:00 |
| *** betherly has quit IRC | 22:00 | |
| *** betherly has joined #openstack-nova | 22:02 | |
| *** betherly has quit IRC | 22:06 | |
| *** rcernin has joined #openstack-nova | 22:09 | |
| *** priteau has quit IRC | 22:16 | |
| *** erlon has joined #openstack-nova | 22:26 | |
| *** Dinesh_Bhor has joined #openstack-nova | 22:30 | |
| sean-k-mooney | cfriesen: by the way were you aware we approved a spec for vTPM on hyperv back in liberty https://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/hyper-v-vtpm-devices.html | 22:38 |
| openstackgerrit | Merged openstack/nova master: Make supports_direct_io work on 4096b sector size https://review.openstack.org/616580 | 22:39 |
| sean-k-mooney | cfriesen: it also got appoved in mitaka but i dont think they ever implmented it | 22:42 |
| *** imacdonn has quit IRC | 22:42 | |
| *** imacdonn has joined #openstack-nova | 22:42 | |
| sean-k-mooney | actully they do http://git.openstack.org/cgit/openstack/compute-hyperv/tree/compute_hyperv/nova/vmops.py#n1334 | 22:44 |
| cfriesen | sean-k-mooney: hadn't seen it. now I'm obligated to go check it out. :) | 22:45 |
| cfriesen | what git tree is that? I don't see any use of "vtpm" in nova, so it seems like it was never implemented on the nova side. | 22:48 |
| sean-k-mooney | its in openstack/compute-hyperv | 22:48 |
| sean-k-mooney | https://github.com/openstack/compute-hyperv its still active aparently | 22:49 |
| cfriesen | looks like it was superceded by https://blueprints.launchpad.net/nova/+spec/hyper-v-shielded-vms | 22:50 |
| *** betherly has joined #openstack-nova | 22:51 | |
| sean-k-mooney | im going to add thi to the reply i was sending to fungi on the ml | 22:52 |
| cfriesen | was proposed late for ocata, but doesn't seem to have been re-proposed for pike | 22:53 |
| sean-k-mooney | well hyperv had an out of tree driver just like power so i guess they did not need to reporpose to support it | 22:54 |
| *** betherly has quit IRC | 22:57 | |
| *** betherly has joined #openstack-nova | 23:08 | |
| *** munimeha1 has quit IRC | 23:09 | |
| fungi | thanks for the details, sean-k-mooney! | 23:14 |
| fungi | and yeah, in the future where hosts which have legit tpms can pass them through the hypervisor to guests, as long as it's apparent to the guest whether it's getting an actual tpm or an emulated one i think that's probably fine | 23:18 |
| *** betherly has quit IRC | 23:18 | |
| *** mlavalle has quit IRC | 23:18 | |
| fungi | at least running the emulated tpm on the hypervisor is still a step up from running an emulated tpm inside the guest itself | 23:19 |
| *** Dinesh_Bhor has quit IRC | 23:20 | |
| fungi | certainly an attacker with access to the host can clone and impersonate the tpm (unlike with a proper hardware one) but that's a higher barrier than compromising the guest | 23:22 |
| *** rm_work has quit IRC | 23:33 | |
| *** rm_work has joined #openstack-nova | 23:33 | |
| *** slaweq has quit IRC | 23:45 | |
| *** lbragstad is now known as lbragstad_turkey | 23:46 | |
| *** betherly has joined #openstack-nova | 23:48 | |
| openstackgerrit | Merged openstack/nova master: Use long_rpc_timeout in select_destinations RPC call https://review.openstack.org/607735 | 23:51 |
| *** zul has quit IRC | 23:51 | |
| *** betherly has quit IRC | 23:53 | |
| openstackgerrit | Merged openstack/nova stable/pike: Handle HostMappingNotFound when deleting a compute service https://review.openstack.org/583567 | 23:55 |
| *** lbragstad_turkey has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!