Friday, 2018-10-26

*** betherly has joined #openstack-nova00:11
*** betherly has quit IRC00:15
*** erlon has joined #openstack-nova00:24
openstackgerritMerged openstack/osc-placement stable/queens: Do not depend on jenkins user in devstack gate  https://review.openstack.org/55666600:30
*** betherly has joined #openstack-nova00:31
*** betherly has quit IRC00:36
*** tetsuro has joined #openstack-nova00:40
*** hshiina has joined #openstack-nova00:40
*** itlinux has joined #openstack-nova00:49
*** yingjun has joined #openstack-nova00:50
*** betherly has joined #openstack-nova00:52
*** yingjun has quit IRC00:56
*** betherly has quit IRC00:56
openstackgerritMerged openstack/nova master: Add functional recreate test for bug 1799727  https://review.openstack.org/61311501:02
openstackbug 1799727 in OpenStack Compute (nova) "CPU_Allocation_Ratio from nova.conf doesn't update exisiting providers" [High,In progress] https://launchpad.net/bugs/1799727 - Assigned to Matt Riedemann (mriedem)01:02
sean-k-mooneymelwitt: sorry i needed to go lie down for a bit as i was feeling off (just a headache)01:05
sean-k-mooneymelwitt: i commented on the os-vif release patch01:05
sean-k-mooneyi think its fine but there are two patches i would like to incude in the release if we have time or do a 1.12.1 release before the end of the year if they need future work before november 1st01:06
sean-k-mooneyefried: ill review your provider config yaml spec  https://review.openstack.org/#/c/612497 tomorow if i can. i have abandon mine in favor of your for this release01:08
sean-k-mooneybut with that siad im going to go back to sleep talk to everyone in the morning o/01:08
*** betherly has joined #openstack-nova01:12
*** betherly has quit IRC01:17
*** mrsoul has joined #openstack-nova01:17
*** bhagyashris has joined #openstack-nova01:20
*** betherly has joined #openstack-nova01:33
*** betherly has quit IRC01:37
*** cervigni has joined #openstack-nova01:38
cervignihello everyone, we have a very odd problem in our environment. lauching an instance stucks on scheduling / building. But if I launch more than one from web interface, the first instance always fails, while the other instances (other than the first one) always succeed01:38
openstackgerritYongli He proposed openstack/nova-specs master: add 'show-server-group' spec  https://review.openstack.org/61225501:38
cervigniany idea where I should start looking? I though it was a placement problem but no errors whatsoever01:38
openstackgerritYongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.openstack.org/61225601:38
*** mhen has quit IRC01:40
*** mhen has joined #openstack-nova01:42
*** lbragstad has quit IRC01:49
*** lbragstad has joined #openstack-nova01:49
openstackgerritYongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.openstack.org/61225601:51
*** betherly has joined #openstack-nova01:53
*** rcernin has joined #openstack-nova01:55
*** Dinesh_Bhor has joined #openstack-nova01:55
*** betherly has quit IRC01:58
*** moshele has joined #openstack-nova02:03
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Fixes Python3 issue in decoding password  https://review.openstack.org/60487002:06
*** lei-zh has joined #openstack-nova02:09
openstackgerritYongli He proposed openstack/nova-specs master: add 'show-server-group' spec  https://review.openstack.org/61225502:13
openstackgerritYongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.openstack.org/61225602:13
*** betherly has joined #openstack-nova02:14
*** trungnv has joined #openstack-nova02:18
*** betherly has quit IRC02:19
*** moshele has quit IRC02:31
openstackgerritYikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration  https://review.openstack.org/60999502:34
*** betherly has joined #openstack-nova02:34
*** betherly has quit IRC02:39
*** betherly has joined #openstack-nova02:54
*** Dinesh_Bhor has quit IRC02:58
*** betherly has quit IRC03:00
*** Dinesh_Bhor has joined #openstack-nova03:06
*** cervigni has quit IRC03:17
*** dpawlik has quit IRC03:27
*** cfriesen has quit IRC03:29
*** dpawlik has joined #openstack-nova03:29
*** betherly has joined #openstack-nova03:35
*** betherly has quit IRC03:40
*** brinzhang has quit IRC03:47
*** brinzhang has joined #openstack-nova03:47
*** udesale has joined #openstack-nova03:51
openstackgerritYikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349903:52
*** betherly has joined #openstack-nova03:56
*** lpetrut has joined #openstack-nova03:58
*** betherly has quit IRC04:00
*** jding1_ has joined #openstack-nova04:01
*** tetsuro has quit IRC04:04
*** jackding has quit IRC04:04
*** Dinesh_Bhor has quit IRC04:11
*** dave-mccowan has quit IRC04:14
*** janki has joined #openstack-nova04:22
*** brinzhang has quit IRC04:31
*** brinzhang has joined #openstack-nova04:31
*** lpetrut has quit IRC04:34
openstackgerritmelanie witt proposed openstack/nova master: Add nova-status upgrade check for consoles  https://review.openstack.org/61121404:34
*** dpawlik has quit IRC04:36
*** dpawlik has joined #openstack-nova04:39
*** lei-zh has quit IRC04:49
*** lei-zh has joined #openstack-nova05:09
*** takashin has left #openstack-nova05:31
*** ratailor has joined #openstack-nova05:35
*** Dinesh_Bhor has joined #openstack-nova05:35
*** betherly has joined #openstack-nova05:36
*** betherly has quit IRC05:40
*** Luzi has joined #openstack-nova05:45
*** mdbooth_ has joined #openstack-nova05:46
*** mchlumsky_ has joined #openstack-nova05:46
*** elod_ has joined #openstack-nova05:50
*** jpenag has joined #openstack-nova05:53
*** hemna_ has joined #openstack-nova05:54
*** ianw_ has joined #openstack-nova05:54
*** dims_ has joined #openstack-nova05:54
*** erlon has quit IRC05:55
*** irclogbot_2 has quit IRC05:55
*** mchlumsky has quit IRC05:55
*** liuyulong|away has quit IRC05:55
*** mdbooth has quit IRC05:55
*** dims has quit IRC05:55
*** dulek has quit IRC05:55
*** jpena|off has quit IRC05:55
*** skatsaounis has quit IRC05:55
*** elod has quit IRC05:55
*** gnuoy has quit IRC05:55
*** hemna has quit IRC05:55
*** burt has quit IRC05:55
*** ianw has quit IRC05:55
*** jlvillal has quit IRC05:55
*** mdrabe has quit IRC05:55
*** ianw_ is now known as ianw05:55
*** mhen has quit IRC05:59
*** mdrabe has joined #openstack-nova05:59
*** tetsuro has joined #openstack-nova06:01
*** erlon has joined #openstack-nova06:03
*** burt has joined #openstack-nova06:03
*** mhen has joined #openstack-nova06:07
*** trungnv has quit IRC06:16
*** ccamacho has quit IRC06:20
*** ccamacho has joined #openstack-nova06:41
*** ccamacho has quit IRC06:49
*** ccamacho has joined #openstack-nova06:51
openstackgerritYikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF  https://review.openstack.org/60280407:00
openstackgerritYikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349907:00
openstackgerritYikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration  https://review.openstack.org/60999507:06
*** sahid has joined #openstack-nova07:11
*** erlon has quit IRC07:12
*** helenafm has joined #openstack-nova07:15
*** rcernin has quit IRC07:22
*** bauzas is now known as bauwser07:35
*** Dinesh_Bhor has quit IRC07:39
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add recreate test for bug 1799892  https://review.openstack.org/61330407:42
openstackbug 1799892 in OpenStack Compute (nova) "Placement API crashes with 500s in Rocky upgrade with downed compute nodes" [Undecided,New] https://launchpad.net/bugs/179989207:42
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consider root id is None in the database case  https://review.openstack.org/61330507:42
*** hshiina has quit IRC07:44
openstackgerritmashuting proposed openstack/nova master: VMware: Support volumes backed by VStorageObject  https://review.openstack.org/52169007:46
*** helenafm is now known as mcgiggler07:58
*** binhnd108 has quit IRC08:01
*** binhnd108 has joined #openstack-nova08:01
*** elod_ is now known as elod08:07
*** Dinesh_Bhor has joined #openstack-nova08:18
*** derekh has joined #openstack-nova08:23
*** ccamacho has quit IRC08:32
*** panda|off is now known as panda08:32
*** ttsiouts has joined #openstack-nova08:33
*** ccamacho has joined #openstack-nova08:33
*** ttsiouts has quit IRC08:38
*** tetsuro has quit IRC08:38
openstackgerritChris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest  https://review.openstack.org/61338608:52
*** spatel has joined #openstack-nova08:52
*** cdent has joined #openstack-nova08:52
*** ttsiouts has joined #openstack-nova08:53
*** spatel has quit IRC08:56
*** lei-zh has quit IRC09:05
*** moshele has joined #openstack-nova09:10
*** ttsiouts has quit IRC09:14
*** ttsiouts has joined #openstack-nova09:15
openstackgerritYikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349909:19
*** moshele has quit IRC09:20
*** sapd1 has quit IRC09:25
*** alexchadin has joined #openstack-nova09:36
*** shuquan has joined #openstack-nova09:57
*** brinzhang has quit IRC10:01
*** dpawlik has quit IRC10:03
*** dpawlik_ has joined #openstack-nova10:03
*** erlon has joined #openstack-nova10:07
*** shuquan has quit IRC10:10
*** lpetrut has joined #openstack-nova10:11
*** ttsiouts has quit IRC10:15
*** bhagyashris has quit IRC10:20
*** jpenag is now known as jpena10:36
*** betherly has joined #openstack-nova10:41
*** tbachman has quit IRC10:48
*** dtantsur|afk is now known as dtantsur10:48
openstackgerritChris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest  https://review.openstack.org/61338610:49
openstackgerritChris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest  https://review.openstack.org/61338610:52
*** alexchadin has quit IRC10:52
openstackgerritYikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node  https://review.openstack.org/61349910:53
openstackgerritYikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script  https://review.openstack.org/60999510:53
*** jpena is now known as jpena|lunch11:01
*** tridde is now known as trident11:17
*** Dinesh_Bhor has quit IRC11:22
*** udesale has quit IRC11:28
*** panda is now known as panda|lunch11:29
*** janki has quit IRC11:36
*** ttsiouts has joined #openstack-nova11:48
*** sahid has quit IRC11:48
*** jpena|lunch is now known as jpena11:57
*** ratailor has quit IRC12:04
*** liuyulong has joined #openstack-nova12:09
*** tbachman has joined #openstack-nova12:20
*** panda|lunch is now known as panda12:24
*** eharney has joined #openstack-nova12:25
*** tbachman has quit IRC12:27
*** sahid has joined #openstack-nova12:27
*** cdent has quit IRC12:30
*** tbachman has joined #openstack-nova12:35
jaypipesaspiers: +2 from me.12:39
*** ttsiouts has quit IRC12:51
*** cdent has joined #openstack-nova12:58
*** derekh has quit IRC13:01
jaypipesefried: done13:02
*** derekh has joined #openstack-nova13:04
*** derekh has quit IRC13:04
*** derekh has joined #openstack-nova13:05
*** pooja_jadhav has quit IRC13:14
*** mpasserini has joined #openstack-nova13:17
mpasseriniHi, what is the service which has the task of creating the ephemeral volumes on the compute nodes? Nova-compute?13:18
*** dpawlik_ has quit IRC13:18
*** spatel has joined #openstack-nova13:19
*** mriedem has joined #openstack-nova13:19
*** dpawlik has joined #openstack-nova13:20
*** efried is now known as fried_rice13:23
*** ratailor has joined #openstack-nova13:24
mriedemdansmith: i'd ping tssurya, but she's not around and it seems you're updating the down cell series. i've gone up through https://review.openstack.org/#/c/584829/13:34
dansmithmriedem: just going through my gerrit mail right now13:35
*** ratailor has quit IRC13:35
mriedemi've got comments/questions in the changes with +1s too, so you could look at those as well. like wondering about applying limits when listing from down cells.13:35
mriedemseems we could do that, but we don't.13:35
dansmithroger13:36
mriedemcdent: requests.GET question for you, if i have a call like GET /servers?all_tenants=1&project_id=1&project_id=2, does that result in {'project_id': [1,2]} ?13:48
mriedemwith the all_tenants key in the dict as well, but i care about the double project_id13:49
cdentmriedem: I think it depends on how you are making the call. let me refresh my memory13:49
cdentmriedem: looks like you need getall to get what you want: https://docs.pylonsproject.org/projects/webob/en/stable/reference.html#query-post-variables13:50
cdentGET() will get you both, in tuples13:51
*** spatel has quit IRC13:51
cdentGET[key] gets the second, getall(key) gets both13:51
*** med_ has joined #openstack-nova13:51
mriedemok i forgot about getall(), i think i found the list of tuples while digging through requests code yesterday13:51
* cdent stares blankly at the slow gate13:52
*** med_ has quit IRC13:52
mriedemok and looking at the list servers code, the only param we do getall on is 'status' so you can filter the list of servers on multiple status values, anything else would just be whatever the last entry is in the query string13:53
*** awaugama has joined #openstack-nova13:53
mriedemwe don't document that of course, but that's what i'm seeing13:53
mriedemi just wasn't sure how search_opts.update(req.GET) would work13:53
*** bnemec has joined #openstack-nova13:54
cdentthere are lots of things about the nova-api that are "unique"13:55
*** munimeha1 has joined #openstack-nova13:57
*** mlavalle has joined #openstack-nova14:01
*** Luzi has quit IRC14:03
*** cdent has quit IRC14:05
openstackgerritJay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.openstack.org/55508114:09
jaypipesfried_rice, stephenfin, artom, alex_xu: thx for the reviews. I think I got all of your comments. please check it again. thanks in advance! mriedem, I added a bunch more to the upgrade impact section. ^^14:10
*** jaypipes is now known as leakypipes14:10
fried_riceack14:10
*** artom is now known as temka14:10
*** dave-mccowan has joined #openstack-nova14:11
*** spatel has joined #openstack-nova14:14
*** luksky has joined #openstack-nova14:14
*** dave-mccowan has quit IRC14:15
*** spatel has quit IRC14:18
*** dpawlik has quit IRC14:19
*** ttsiouts has joined #openstack-nova14:20
*** stephenfin is now known as finucannot14:22
*** dpawlik has joined #openstack-nova14:24
finucannotmriedem: This is another one of those changes that I thought would require a microversion but apparently does not. The output is wrong but it doesn't raise a HTTP 5xx https://review.openstack.org/#/c/608685/14:25
finucannotWhat distinguishes a fix from this from, say, modifying the output of os-hypervisor to respect (cpu|ram)_allocation_ratio. Both are currently giving "wrong" output14:26
mriedemi don't have a good answer for that except the os-hypervisors stuff has been around forever and i don't know if including allocation ratios in that calculation would be considered by all to be "right"14:29
*** dpawlik has quit IRC14:29
*** cdent has joined #openstack-nova14:29
finucannotYeah, probably not the best example14:30
finucannotmriedem: Would it be fair to ask for 'bug'-type reno for these kind of changes, in that case?14:30
finucannotI'm thinking of the case where different clouds would give different results for what's supposed to be the same version14:30
mriedemi wouldn't say it's unfair, although this simple tenant usage thing lpetrut is fixing is admin-only by default14:31
mriedemnon-admins can't list usage across all tenants14:31
*** mpasserini has left #openstack-nova14:31
mriedemso that's not really an interop concern14:31
finucannotOhh, I didn't know that. In that case, not an issue here14:32
mriedemwell,14:32
mriedemhis change isn't specific to list (admin), it's also show (non-admin)14:33
mriedemso idk, if you want a "fixes" release note then ask for one14:33
mriedem"paging was broken, now it's fixed"14:33
finucannotYeah, I think I will. Probably makes sense assuming we want to backport this too (and to alert folks who'd want this downstream)14:34
mriedemin general, we don't have a great formula for when a microversion is required. obviously major behavior changes that people need to opt into. and request/response schema changes. but there are so many other behavior-ish and bug fix type things that could be argued require a microversion we'd never do anything14:35
mriedemor we'd have a thousand microversions by now14:35
mriedeme.g. the trusted VFs thing from sahid technically could have required a microversion14:35
*** jackding has joined #openstack-nova14:35
mriedemand your requested networks physnet stuff14:36
finucannotAll good points14:37
finucannotClearly my "must raise HTTP 5xx" rule is too rigid14:37
openstackgerritChris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest  https://review.openstack.org/61338614:37
openstackgerritLucian Petrut proposed openstack/nova master: Fix os-simple-tenant-usage result order  https://review.openstack.org/60868514:45
openstackgerritMatt Riedemann proposed openstack/nova master: Fix os-simple-tenant-usage result order  https://review.openstack.org/60868514:47
mriedemi can't figure out for the life of me why i can't send a RequestSpec object to prep_resize over rpc https://gist.github.com/mriedem/9fce3c68336f8abb5d4753c156d8f96f but we pass RequestSpec objects over rpc in several other places, like build_and_run_instance and select_destinations14:50
mriedemthere is an old oslo.messaging bug for the fake impl rpc driver https://bugs.launchpad.net/oslo.messaging/+bug/1529084 but how does that not break on those other calls?14:51
openstackLaunchpad bug 1529084 in oslo.messaging "RPC fake driver should accept datetime items for data" [Undecided,Invalid]14:51
*** tbachman has quit IRC14:55
*** cfriesen has joined #openstack-nova14:56
*** dansmith is now known as SteelyDan15:01
*** dave-mccowan has joined #openstack-nova15:04
*** dave-mccowan has quit IRC15:10
*** itlinux has quit IRC15:13
openstackgerritEric Fried proposed openstack/nova master: Kill @safe_connect in _get_provider_traits  https://review.openstack.org/61361315:22
fried_riceedmondsw: ^  (and leakypipes and other haters of @safe_connect)15:22
*** gyee has joined #openstack-nova15:23
edmondswfried_rice thanks15:24
*** tbachman has joined #openstack-nova15:24
cdentfried_rice: where does the exception go, now?15:24
* cdent is a broken record15:25
fried_ricecdent: up15:25
fried_riceas it should15:25
cdentindeed15:25
cdentbut then what?15:25
fried_ricewell, it will go the same place as the AttributeError did.15:25
fried_ricehttp://184.172.12.213/04/602804/8/check/nova-in-tree-pvm/9a0e925/logs/n-cpu.txt.gz#_Oct_26_02_24_17_49019615:25
cdentokay, but surely that's not enough15:26
*** moshele has joined #openstack-nova15:26
cdenteither the attributeerror of the keystone error needs to be handled in some approrpriate fashion15:26
cdents/of/or/15:26
fried_riceIt's really just so we can know what actually happened rather than having to rely on the tribal knowledge that when a placement helper method returns None, it's probably because comm failed.15:27
cdent(re that link: my eyes!!!!)15:27
fried_riceGetting rid of @safe_connect is mostly about ^ that, not about doing something more appropriate with the now-not-as-mysterious exception. That would be a separate thing.15:27
fried_ricecdent: hold on, we've got some of my log coloring experimental code on that server, I think there's a secret option to change themes...15:28
*** moshele has quit IRC15:29
cdentsure, but the reason safe_connect existed in the first place was to do some kind of "right thing" when comm's failed. what's wrong here is that safe_connect is broken, not that it exists15:29
cdentsafe_connect was supposed provided away for interactions with the placement api to be correctly retried (or logged) when things went awry15:30
cdentsomewhere along the way it lost that and became simply a bad thing that returned None when it shouldn't15:30
cdentThere's no doubt (at all) that it is a bad thing, now. But the lost of the intention is also a bad thing.15:30
cdentIf we're cool with the idea of removing it (because its masks real things that need to be fixed) will to stuff actually being fixed, cool15:31
fried_ricein this case, the next spin through the periodic will hopefully work.15:31
cdentthat seems an odd approach to take, to me15:31
fried_riceThat's "retry"15:31
fried_riceor if this call happened as the result of an actual operation, we've got retries built in, IIRC. Sec...15:32
cdentbecause the next periodic could be many minutes away if the deployer has chosen to do so15:32
fried_riceYeah, and if an operation isn't happening, who cares15:32
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Pass request_spec from compute to cell conductor on reschedule  https://review.openstack.org/58241715:32
cdentif the failed request was e.g., updating inventory, scheduling will go wrong during that window15:33
cdentWhat I'm trying to get at here is that I suspect (actually, am confident that) the system is more complex than "just let the expceptions rise" can bear15:33
fried_riceSo this is all happening under the umbrella of _update, which has a retry around it for conflicts15:33
cdentbut what about for a network partition?15:34
cdent(or things that look like a network partition (such as the load balance being reconfigured))15:35
fried_riceLook, I'm not disputing that we could do a better job of handling placement comm errors in this whole flow (i.e. the resource tracker). But first we have to know we're having a placement comm error.15:36
fried_riceIf we want to put in retries at some level based on ClientException, I'm all behind that.15:36
fried_riceBut that's not what this patch is for.15:36
cdentOkay, but "handling placement comm errors" is why safe_connect was created, so simply killing it is probably not the right approach. Fixing it probably is.15:38
cdentI'm harping on it because it is clear that the reasson for its existence has now been lost to the sands of time (because somewhere along the way it borked)15:39
cdentBut we seem to want to say "it sucks, let's just kill it" (at least jokingly) and that's not really sufficient in a distributed system.15:39
cdentThese issues will come back around again, after safe_connect has gone, and we'll realize "you know, we need to create this thing that allows us to safely connect"15:41
fried_riceWe have made several assays toward fixing it. It can't be done. Because it's at too low a level in the call stack.15:41
SteelyDancdent: actually safe_connect was really to handle the "have they set up placement or not" situation15:41
SteelyDanwhich is why we've been talking about removing it entirely since placement became required15:41
cdentSteelyDan: that was _one_ of the reasons, and yes, the very first reason, but very quickly it took on "deal with errors from keystoneclient"15:41
SteelyDanyes, it has evolved15:42
openstackgerritEric Fried proposed openstack/nova master: Kill @safe_connect in _get_provider_traits  https://review.openstack.org/61361315:42
cdentwe had: is it in the service catalog, then can I reach it15:42
fried_ricecdent:  added words clarifying intent --^15:42
*** ttsiouts has quit IRC15:43
cdentthanks15:43
openstackgerritsean mooney proposed openstack/nova master: harden placement init under wsgi  https://review.openstack.org/61003415:44
cdentI'm trying really hard to not to think to much about the resource tracker lately but sometimes I get sucked in.15:44
sean-k-mooneycdent: ^ uses the run_once decorator15:45
fried_ricecdent: Anything we would do to @safe_connect, beyond making it essentially a no-op shell (which isn't better than removing it IMO), would also entail a thorough audit of everywhere it is used, which is a nearly impossible task due to how many different ways and in how many layers things get called.15:45
fried_riceFor example, if we decided to make it retry, we would have to restrict the decorator to *only* single primitive API calls. We would have to remove it from all the methods that do more complex things e.g. involving multiple API calls.15:45
cdentsean-k-mooney: yeah, thanks, reading15:46
sean-k-mooneycdent: ill propose the placement version shortly if people are fine with it15:46
cdentfried_rice: yes, I know, thus why I'm trying really hard not to think about the resource tracker lately. It was already really complicated before placement, and we somehow managed to make it worse, not better.15:47
fried_riceI have made a couple of attempts, and I think SteelyDan has as well, to do something to @safe_connect itself to improve it. At some point in a review leakypipes said we should just target one usage at a time and get rid of it. Which so far has been the only approach that has gotten us to actually merge code around this.15:47
SteelyDanyup15:47
fried_ricecdent: I still hope that it will be better in the long run, once we've purged all the legacy stuff from this painful transitional period.15:47
fried_ricelike @safe_connect :P15:48
fried_riceand stuff gibi has been doing lately has cleaned up some of that legacy gorp too.15:48
fried_riceSo we're getting there.15:48
* fried_rice soothes cdent15:48
cdentwell, just to cover my ass here: If I had my druthers we never would have had safe_connect15:48
cdentbut we gots we gots15:49
cdenti'll cope15:49
fried_riceMy dad used to say, "If frogs had wings, they wouldn't bump their asses so much."15:49
fried_rice(I made that sound like he's dead or something. He would still say it, given the slightest opportunity.)15:49
cdentheh15:49
*** sahid has quit IRC15:55
*** spatel has joined #openstack-nova15:55
cdentsean-k-mooney: have you run the functional tests on that change? I think you're going to run into trouble with the databse fixture15:55
*** mcgiggler has quit IRC15:55
spatelsean-k-mooney: is there a way to find real instance hostname using virsh list command?15:55
*** itlinux has joined #openstack-nova15:56
spatelcurrently i am doing "virsh dumpxml instance-00000387 | grep nova:name"15:57
spateli wish it has build it function15:57
sean-k-mooneycdent: am no but i will and see what it does not like15:58
openstackgerritMatt Riedemann proposed openstack/nova master: Fix min config value for shutdown_timeout option  https://review.openstack.org/61302815:58
cdentsean-k-mooney: i'm doing it now, will leave a comment with the reasults15:58
sean-k-mooneyspatel:  no grep is your friend in this case15:59
spatel:) thanks15:59
*** lpetrut has quit IRC16:00
fried_ricecdent: btw, that log server has the ANSI color coding patch (which isn't working 100% properly - some codes don't like to turn off), not the choose-your-theme patch, so you're SOL, sorry.16:01
cdentfair enough, as before, I'll cope16:01
fried_riceif we ever reach a point where you're having to look at PowerVM CI logs more than once a year, I'll take that patch offa there :)16:02
cdent16:03
openstackgerritMartin Midolesov proposed openstack/nova master: vmware:PropertyCollector for caching instance properties  https://review.openstack.org/60827816:06
openstackgerritMartin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack  https://review.openstack.org/61362616:06
*** dtantsur is now known as dtantsur|afk16:07
*** tbachman has quit IRC16:12
*** bnemec is now known as beekneemech16:13
*** tbachman has joined #openstack-nova16:14
openstackgerritMartin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack  https://review.openstack.org/61362616:14
openstackgerritMatt Riedemann proposed openstack/nova master: Migrate "reboot an instance" user guide docs  https://review.openstack.org/61273016:15
mriedemfried_rice: gibi: do you see something here that i don't? https://review.openstack.org/#/c/605785/16/nova/tests/functional/test_servers.py@527516:17
mriedemif i'm wrong, i'll +W16:17
openstackgerritMerged openstack/python-novaclient master: Fixes Python3 issue in decoding password  https://review.openstack.org/60487016:18
*** tbachman has quit IRC16:18
fried_ricemriedem: I didn't scrutinize tbh. If it is a redundant test, I figgered it could be removed in a fup.16:19
*** fried_rice is now known as fried_rolls16:20
mriedembtw, on that safe_connect thing, couldn't all of the same arguments be made for all other services nova talks to if we're worried about network drops? so that would be at least: keystone, glance, cinder, neutron, *barbican16:21
mriedemi think the ironic driver already has it's own retry wrapper16:22
cdentyes?16:22
cdentwe assume a lot that's can to be less easy to assume in this like edge and other blech like that16:23
cdents/can/going/16:23
mriedemoh i'm sure16:23
mriedemksa already has retry stuff in it too right?16:23
mordredyup16:23
melwitt16:24
mordredand in sdk we have a structure for expressing per-service error codes that are safe to do automatic retries on16:24
cdentthis whole day has been a slow setup to allow mordred to do an sdk advertisement16:24
mordredcdent: isn't htat what most days are?16:24
mriedemwe just need to rip and replace all nova's internal client things with the sdk, done!16:24
* cdent takes his cut and goes to buy beer16:24
mordredcoming soon to a gerrit near you!16:25
*** tbachman has joined #openstack-nova16:25
mordred(honestly, I've got one more patch i need to write sdk-side, then I want to make y'all a couple of sake-of-argument patches so we can look at what it might be like and whether it's worth working on in earnest)16:26
mriedemworking on what? sdk in nova?16:27
mriedemback in the first YVR summit i think dean said the service projects shouldn't use the sdk, but that was a long time ago16:27
mriedemi think for perf reasons16:27
mriedembut it seems kinda dumb not to16:27
*** mdbooth_ has quit IRC16:28
leakypipesgibi, mriedem: anyone got the link to gibi's patch series that removes the doubled-up allocation cruft for legacy evacuate code paths?16:29
leakypipescan't find it atm16:29
mriedemhttps://review.openstack.org/#/c/512623/ ?16:30
mriedemotherwise idk what that is16:30
openstackgerritMerged openstack/nova master: Bump os-brick version to 2.6.1  https://review.openstack.org/61110916:30
openstackgerritMerged openstack/nova master: Add API ref guideline for examples  https://review.openstack.org/60406016:31
melwittmriedem: s-1 release review is here. sorry I forgot to do it yesterday https://review.openstack.org/61363616:31
*** dave-mccowan has joined #openstack-nova16:33
mriedemdone16:34
*** mriedem is now known as mriedem_away16:34
melwittthx16:34
melwittmnaser: do you ever use beta releases of nova? as of http://lists.openstack.org/pipermail/openstack-dev/2018-September/135088.html beta releases are optional and I wasn't sure if operators use them or not16:41
melwittI proposed a s-1 release out of habit and release folk asked if anyone needed it and to consider not doing a beta release. so just trying to find out if operators we know use them16:42
*** ShilpaSD has quit IRC16:43
*** luksky has quit IRC16:48
mnaserI haven’t ever really played with them. Only RCs16:49
melwittok, thanks16:49
*** jangutter has quit IRC16:50
*** dave-mccowan has quit IRC16:58
*** derekh has quit IRC16:58
openstackgerritStephen Finucane proposed openstack/nova master: tox: Stop build *all* docs in 'docs'  https://review.openstack.org/61364517:01
*** bauwser is now known as bauzas17:01
finucannotfried_rolls: You'd probably appreciate that ^17:01
openstackgerritStephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology  https://review.openstack.org/61108817:02
*** betherly has quit IRC17:03
*** zul has joined #openstack-nova17:04
*** jpena is now known as jpena|off17:06
*** lpetrut has joined #openstack-nova17:08
*** ralonsoh has quit IRC17:23
*** mlavalle has quit IRC17:23
*** bexigastack has joined #openstack-nova17:28
bexigastackhello all17:28
bexigastacki have a quick question that someone here could possibly answer quickly17:28
bexigastacki've got cinder handling nfs mounts served from a netapp in c-mode17:29
bexigastackeverything is working as expected17:29
bexigastacki am having an issue when launching an instance on a compute node where that nfs share is already mounted17:30
bexigastacknova attempts to mount it before launching a second instance but is hit with:17:30
bexigastackCommand: mount -t nfs nfsserver.dns.name:/OPENSTACK_MOUNT/OPENSTACK_CLOUD_1 /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af3217:31
bexigastackExit code: 3217:31
bexigastackStdout: u''17:31
bexigastackStderr: u'mount.nfs: /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af32 is busy or already mounted\n'17:31
*** mlavalle has joined #openstack-nova17:31
bexigastackoh woops - i think i am in the wrong channel - this is used for development17:32
bexigastackappologies - i will use #openstack17:32
*** lbragstad is now known as elbragstad17:37
*** Swami has joined #openstack-nova17:38
*** jding1_ has quit IRC17:39
*** cdent has quit IRC18:03
*** munimeha1 has quit IRC18:11
*** tbachman has quit IRC18:22
*** mriedem_away is now known as mriedem18:28
openstackgerritMerged openstack/nova master: Reject forced move with nested source allocation  https://review.openstack.org/60578518:31
openstackgerritMerged openstack/nova master: api-ref: Remove unnecessary minimum microversion  https://review.openstack.org/61322618:31
openstackgerritMerged openstack/nova master: Add a hacking rule for deprecated assertion methods  https://review.openstack.org/61318418:31
*** medberry is now known as med_18:31
*** munimeha1 has joined #openstack-nova18:33
melwittSteelyDan, leakypipes: are either of you willing to please review this nova-status upgrade check that warns if the deployment is using consoles to set the [workarounds]enable_consoleauth = True config option if performing a live/rolling upgrade? https://review.openstack.org/611214 we need to backport it to stable/rocky and were hoping to include it in stable/rocky release as soon as we can18:52
melwittmnaser: would you like to have a look at the reno update for the nova-consoleauth thing? https://review.openstack.org/61317418:54
melwittand let me know if you think it's good18:55
leakypipesmelwitt: you see the py3k test failures on that?18:57
openstackgerritDan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_projects()  https://review.openstack.org/60766319:01
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova list when a cell is down  https://review.openstack.org/56778519:01
openstackgerritDan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects  https://review.openstack.org/60793419:01
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova show when a cell is down  https://review.openstack.org/59165819:01
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova service-list when a cell is down  https://review.openstack.org/58482919:01
melwittleakypipes: yes, they are unrelated, ssh timeout19:01
leakypipesmelwitt: sure?19:01
melwittleakypipes: yes, why?19:01
leakypipesmelwitt: ok, lemme take another look19:02
melwittthe code change is in the 'nova-status upgrade check' CLI command which isn't running in either of those tempest tests19:02
*** fried_rolls is now known as efried19:07
*** tbachman has joined #openstack-nova19:08
*** erlon has quit IRC19:09
*** efried is now known as fried_rice19:11
openstackgerritJack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918019:18
*** dave-mccowan has joined #openstack-nova19:18
*** toabctl has quit IRC19:19
*** toabctl has joined #openstack-nova19:21
openstackgerritMerged openstack/nova master: Add more documentation for online_data_migrations CLI  https://review.openstack.org/60583619:32
cfriesenmriedem: sean-k-mooney: gibi: question about the HPET spec.  given that the HPET removal was not for any security reasons, and that HPET is supported by the minimum versions of qemu/libvirt, can we simplify the feature and just specify something like "hw:hpet" in the flavor/image with no way to disable it (since there's no useful reason to prevent it)19:35
cfriesenno way for the operator to disable/block it, I mean19:35
*** lpetrut has quit IRC19:37
openstackgerritDan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_projects()  https://review.openstack.org/60766319:54
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova list when a cell is down  https://review.openstack.org/56778519:54
openstackgerritDan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects  https://review.openstack.org/60793419:54
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova show when a cell is down  https://review.openstack.org/59165819:54
openstackgerritDan Smith proposed openstack/nova master: Minimal construct plumbing for nova service-list when a cell is down  https://review.openstack.org/58482919:54
*** spatel has quit IRC20:19
*** spatel has joined #openstack-nova20:24
*** zul has quit IRC20:25
*** imacdonn has quit IRC20:32
*** imacdonn has joined #openstack-nova20:32
*** spatel has quit IRC20:39
*** openstackstatus has quit IRC20:42
*** openstack has joined #openstack-nova20:44
*** ChanServ sets mode: +o openstack20:44
*** ttsiouts has joined #openstack-nova20:46
*** awaugama has quit IRC20:47
*** munimeha1 has quit IRC20:53
*** spatel has joined #openstack-nova20:58
*** ttsiouts has quit IRC20:58
*** spatel has quit IRC21:02
*** jamesdenton has quit IRC21:11
*** eharney has quit IRC21:12
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Expose virtual device tags in REST API  https://review.openstack.org/39393021:21
mriedemcfriesen: idk, i'd have to context switch the hpet stuff all back into my brain21:29
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Expose virtual device tags in REST API  https://review.openstack.org/39393021:29
mriedemcfriesen: if it's as simple as just adding a new image property b/c it's not some kind of security related issue people would want to disable, and maybe (or maybe not) tied to arch of the guest image, then it seems just having an image property would be OK, expecially since it sounds like it's really just a use case for legacy OSes21:31
mriedemi'm not sure why it would even need to be a flavor extra spec really21:31
mriedemthat would probably be better than doing a bunch of discovery to determine if hpet is possible on a host and exposing that as yet another trait21:34
cfriesenat least for qemu it doesn't seem to have any security implications as there are other more accurate time sources anyway.  I think an image property makes the most sense, and I don't think any discovery is needed21:37
mriedemos_wind_river_special_knob_hpet=true seems ok to me21:37
cfriesenlol21:37
cfriesenokay.  I'll talk to Jack, we'll respin with it as simple as possible and the justification for the simplicity21:38
cfriesenone thing...can we specify the hypervisor type somehow?  because we do need to land on a qemu node21:40
mriedemisn't that an existing image property?21:40
mriedemhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html21:40
mriedemhypervisor_type21:41
mriedem"Note that qemu is used for both QEMU and KVM hypervisor types."21:41
mriedemhmm21:41
mriedemis that a problem?21:41
mriedemi.e. is a kvm node a problem?21:41
cfriesenno, qemu/kvm is fine21:42
mriedemthen i think you're covered21:42
cfriesenyeah, between hypervisor_type and architecture, I think we're good.21:42
cfriesenthanks21:42
mriedemnp21:43
*** mriedem has quit IRC21:52
*** tbachman_ has joined #openstack-nova22:02
*** tbachman has quit IRC22:04
*** tbachman_ is now known as tbachman22:04
*** burt has quit IRC22:04
*** itlinux has quit IRC22:05
*** tbachman_ has joined #openstack-nova22:17
*** tbachman has quit IRC22:17
*** tbachman_ is now known as tbachman22:17
*** pcaruana has quit IRC23:10
*** Swami has quit IRC23:43
*** rcernin has joined #openstack-nova23:43
*** rcernin has quit IRC23:51
*** itlinux has joined #openstack-nova23:51
*** gyee has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!