| *** rpittau has quit IRC | 00:03 | |
| *** rpittau has joined #openstack-nova | 00:03 | |
| mnaser | mnaser | 00:05 |
|---|---|---|
| *** zhanglong has joined #openstack-nova | 00:06 | |
| *** vabada has quit IRC | 00:10 | |
| *** vabada has joined #openstack-nova | 00:10 | |
| *** devananda has quit IRC | 00:12 | |
| *** wznoinsk has quit IRC | 00:12 | |
| *** takashin has quit IRC | 00:13 | |
| *** brinzhang has joined #openstack-nova | 00:13 | |
| *** devananda has joined #openstack-nova | 00:13 | |
| *** panda has quit IRC | 00:13 | |
| *** edleafe has quit IRC | 00:13 | |
| *** gyee has quit IRC | 00:15 | |
| *** panda has joined #openstack-nova | 00:16 | |
| *** tetsuro has joined #openstack-nova | 00:17 | |
| *** artom has quit IRC | 00:19 | |
| *** artom has joined #openstack-nova | 00:19 | |
| *** rcernin has quit IRC | 00:29 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient stable/pike: Redirect the old release note url https://review.openstack.org/609566 | 00:31 |
| *** chenhaw has joined #openstack-nova | 00:36 | |
| *** zhurong has joined #openstack-nova | 00:49 | |
| *** zhurong has quit IRC | 00:50 | |
| *** hshiina has joined #openstack-nova | 00:54 | |
| *** spatel has joined #openstack-nova | 01:10 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** bhagyashris has joined #openstack-nova | 01:13 | |
| *** slaweq has quit IRC | 01:15 | |
| *** spatel has quit IRC | 01:17 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:21 | |
| *** kaisers has quit IRC | 01:27 | |
| *** tiendc has joined #openstack-nova | 01:27 | |
| *** kaisers has joined #openstack-nova | 01:27 | |
| *** tetsuro has quit IRC | 01:30 | |
| *** hongbin has joined #openstack-nova | 01:30 | |
| *** tetsuro has joined #openstack-nova | 01:32 | |
| *** mrsoul has quit IRC | 01:34 | |
| *** s1061123 has quit IRC | 01:35 | |
| *** s1061123 has joined #openstack-nova | 01:35 | |
| *** spatel has joined #openstack-nova | 01:45 | |
| *** erlon has quit IRC | 01:46 | |
| *** hoangcx has quit IRC | 01:50 | |
| *** trungnv has quit IRC | 01:50 | |
| *** trungnv has joined #openstack-nova | 01:51 | |
| *** hoangcx has joined #openstack-nova | 01:51 | |
| openstackgerrit | Merged openstack/nova master: api-ref: Remove a description in servers-actions.inc https://review.openstack.org/608796 | 01:52 |
| openstackgerrit | Merged openstack/nova master: Remove useless TODO section https://review.openstack.org/608802 | 01:52 |
| *** spatel has quit IRC | 01:55 | |
| *** mhen has quit IRC | 01:55 | |
| *** hvvcben has joined #openstack-nova | 01:58 | |
| *** mhen has joined #openstack-nova | 01:59 | |
| *** brinzhang has quit IRC | 02:00 | |
| *** brinzhang has joined #openstack-nova | 02:01 | |
| *** rcernin has joined #openstack-nova | 02:01 | |
| *** spatel has joined #openstack-nova | 02:20 | |
| *** dave-mccowan has joined #openstack-nova | 02:23 | |
| *** stakeda has joined #openstack-nova | 02:28 | |
| *** itlinux_ has joined #openstack-nova | 02:28 | |
| *** itlinux has quit IRC | 02:31 | |
| *** jarodwl has quit IRC | 02:38 | |
| *** aarents has quit IRC | 02:39 | |
| *** lbragstad has quit IRC | 02:40 | |
| openstackgerrit | Merged openstack/nova master: remove commented-out code https://review.openstack.org/605635 | 03:03 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Handle volume API failure in post_live_migration https://review.openstack.org/609517 | 03:06 |
| *** hvvcben has quit IRC | 03:07 | |
| *** psachin has joined #openstack-nova | 03:07 | |
| *** dave-mccowan has quit IRC | 03:16 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Cleanup the instance when MessageDeliveryFailure exception https://review.openstack.org/608500 | 03:19 |
| openstackgerrit | Merged openstack/nova stable/rocky: Imported Translations from Zanata https://review.openstack.org/604260 | 03:24 |
| *** hongbin has quit IRC | 03:34 | |
| *** trungnv has quit IRC | 04:17 | |
| *** tiendc has quit IRC | 04:17 | |
| *** trungnv has joined #openstack-nova | 04:18 | |
| *** tiendc has joined #openstack-nova | 04:18 | |
| *** spatel has quit IRC | 04:18 | |
| *** trungnv has quit IRC | 04:23 | |
| *** hoangcx has quit IRC | 04:23 | |
| *** trungnv has joined #openstack-nova | 04:23 | |
| *** hoangcx has joined #openstack-nova | 04:23 | |
| *** janki has joined #openstack-nova | 04:26 | |
| *** hshiina has quit IRC | 04:30 | |
| *** yikun has quit IRC | 04:44 | |
| *** takashin has joined #openstack-nova | 04:58 | |
| *** hoonetorg has quit IRC | 05:09 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** ratailor has joined #openstack-nova | 05:19 | |
| *** fanzhang has quit IRC | 05:26 | |
| *** tetsuro has quit IRC | 05:38 | |
| *** udesale has joined #openstack-nova | 05:39 | |
| *** jarodwl has joined #openstack-nova | 05:41 | |
| *** hshiina has joined #openstack-nova | 05:51 | |
| openstackgerrit | Sam Morrison proposed openstack/nova master: Allow ability for non admin users to list all flavors. https://review.openstack.org/608474 | 05:53 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove saved_file_rules check from policy https://review.openstack.org/609591 | 05:55 |
| *** cfriesen has quit IRC | 05:56 | |
| *** pcaruana has joined #openstack-nova | 06:01 | |
| *** dims has quit IRC | 06:29 | |
| *** slaweq has joined #openstack-nova | 06:29 | |
| *** bhagyashris has quit IRC | 06:29 | |
| *** dims has joined #openstack-nova | 06:33 | |
| *** janki has quit IRC | 06:34 | |
| *** slaweq has quit IRC | 06:34 | |
| *** jchhatba_ has joined #openstack-nova | 06:35 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 06:37 |
| *** dims has quit IRC | 06:38 | |
| *** dims has joined #openstack-nova | 06:39 | |
| *** slaweq has joined #openstack-nova | 06:41 | |
| *** hoangcx has quit IRC | 06:43 | |
| *** tiendc has quit IRC | 06:43 | |
| *** trungnv has quit IRC | 06:43 | |
| *** trungnv has joined #openstack-nova | 06:43 | |
| *** hoangcx has joined #openstack-nova | 06:43 | |
| *** jchhatba_ has quit IRC | 06:46 | |
| *** slaweq has quit IRC | 06:46 | |
| *** janki has joined #openstack-nova | 06:47 | |
| *** hoangcx has quit IRC | 06:49 | |
| *** slaweq has joined #openstack-nova | 06:50 | |
| *** hoangcx has joined #openstack-nova | 06:50 | |
| *** hoangcx has quit IRC | 06:53 | |
| *** trungnv has quit IRC | 06:53 | |
| *** hoangcx has joined #openstack-nova | 06:54 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 06:59 |
| *** stakeda has quit IRC | 06:59 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update https://review.openstack.org/521041 | 07:00 |
| *** Luzi has joined #openstack-nova | 07:00 | |
| *** rcernin has quit IRC | 07:01 | |
| *** slaweq has quit IRC | 07:03 | |
| *** slaweq has joined #openstack-nova | 07:05 | |
| *** udesale has quit IRC | 07:12 | |
| *** udesale has joined #openstack-nova | 07:13 | |
| *** ttsiouts has joined #openstack-nova | 07:15 | |
| *** udesale has quit IRC | 07:15 | |
| *** ttsiouts has quit IRC | 07:17 | |
| *** helenafm has joined #openstack-nova | 07:19 | |
| *** ralonsoh has joined #openstack-nova | 07:29 | |
| *** takashin has left #openstack-nova | 07:30 | |
| *** ttsiouts has joined #openstack-nova | 07:38 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp https://review.openstack.org/604269 | 07:39 |
| *** maciejjozefczyk has joined #openstack-nova | 07:39 | |
| *** lpetrut has joined #openstack-nova | 07:40 | |
| *** ttsiouts has quit IRC | 07:43 | |
| *** k_mouza has joined #openstack-nova | 07:44 | |
| *** udesale has joined #openstack-nova | 07:51 | |
| *** tetsuro has joined #openstack-nova | 08:02 | |
| *** ttsiouts has joined #openstack-nova | 08:02 | |
| *** Dinesh_Bhor has quit IRC | 08:03 | |
| *** ttsiouts has quit IRC | 08:07 | |
| *** ttsiouts has joined #openstack-nova | 08:13 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove saved_file_rules check from policy https://review.openstack.org/609591 | 08:13 |
| naichuans | bauzas: Hi, Sylvain, any feedback about the vgpu-stein blueprint? | 08:14 |
| bauzas | naichuans: I was trapped by some customer problem for the last 2 days, but you're in my pipe :) | 08:19 |
| *** _pewp_ has quit IRC | 08:20 | |
| *** _hemna has joined #openstack-nova | 08:22 | |
| *** _pewp_ has joined #openstack-nova | 08:22 | |
| naichuans | bauzas: Got it, thank you very much :) | 08:23 |
| bauzas | naichuans: I saw you also provided a reshape change | 08:24 |
| bauzas | naichuans: I guess you looked at mine ? | 08:24 |
| naichuans | bauzas: right, the first verson is completely same with yours~ | 08:24 |
| bauzas | naichuans: okay | 08:24 |
| bauzas | naichuans: just to make it clear, I don't support multiple types in the same change | 08:25 |
| bauzas | it's by decision | 08:25 |
| bauzas | naichuans: people will need first to reshape | 08:25 |
| bauzas | and then once we create a new change for having more than one, we need to make sure that the reshape is done | 08:25 |
| bauzas | but that's a separate change I haven't written yet | 08:26 |
| naichuans | bauzas: s/verson/version. Currently we pending the multiple vgpu type support, too. And the reshape works well on our test environment. | 08:26 |
| bauzas | naichuans: I tested it too on my devstack box | 08:26 |
| naichuans | bauzas: I'm also waiting the reshape works done, which is the reason we pending the multiple vgpu type support :) | 08:28 |
| *** ttsiouts has quit IRC | 08:28 | |
| bauzas | k | 08:28 |
| *** jangutter has quit IRC | 08:31 | |
| *** TuanDA has joined #openstack-nova | 08:31 | |
| *** jangutter has joined #openstack-nova | 08:31 | |
| *** moshele has joined #openstack-nova | 08:34 | |
| *** ttsiouts has joined #openstack-nova | 08:34 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova-specs master: Support initial allocation ratios https://review.openstack.org/552105 | 08:36 |
| *** mvkr has quit IRC | 08:38 | |
| *** derekh has joined #openstack-nova | 08:42 | |
| *** dtantsur|afk is now known as dtantsur| | 08:44 | |
| *** dtantsur| is now known as dtantsur | 08:44 | |
| *** _pewp_ has quit IRC | 08:49 | |
| *** _hemna has quit IRC | 08:50 | |
| *** _pewp_ has joined #openstack-nova | 08:51 | |
| *** _hemna has joined #openstack-nova | 08:51 | |
| *** brinzhang has quit IRC | 08:51 | |
| *** brinzhang has joined #openstack-nova | 08:52 | |
| *** alexchadin has joined #openstack-nova | 09:00 | |
| *** hshiina has quit IRC | 09:01 | |
| *** ttsiouts has quit IRC | 09:05 | |
| *** panda is now known as panda|mtg | 09:05 | |
| BlackDex | Hello there. i have an instance running with just a terminal. And i wonder how i can change the size of the console. Currently it has a small dimension (width&height) is there a way that i can change this? | 09:07 |
| *** mvkr has joined #openstack-nova | 09:09 | |
| *** yikun has joined #openstack-nova | 09:10 | |
| *** spatel has joined #openstack-nova | 09:10 | |
| *** nicolasbock has quit IRC | 09:12 | |
| *** jistr is now known as jistr|call | 09:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:14 | |
| *** spatel has quit IRC | 09:15 | |
| *** zhanglong has quit IRC | 09:16 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Remove force flag from live-migrate and evacuate https://review.openstack.org/609330 | 09:16 |
| *** zhanglong has joined #openstack-nova | 09:18 | |
| *** Dinesh_Bhor has quit IRC | 09:28 | |
| openstackgerrit | Merged openstack/python-novaclient master: doc: Start using openstackdoctheme's extlink extension https://review.openstack.org/608829 | 09:30 |
| *** ttsiouts has joined #openstack-nova | 09:33 | |
| *** brinzh has joined #openstack-nova | 09:40 | |
| *** brinzhang has quit IRC | 09:43 | |
| *** jiapei has left #openstack-nova | 09:45 | |
| *** brinzhang has joined #openstack-nova | 09:46 | |
| *** zhanglong has quit IRC | 09:48 | |
| *** brinzh has quit IRC | 09:48 | |
| *** jangutter has quit IRC | 09:48 | |
| *** jangutter has joined #openstack-nova | 09:48 | |
| *** imacdonn has quit IRC | 09:52 | |
| *** imacdonn has joined #openstack-nova | 09:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge used_limits extension response into limit view builder https://review.openstack.org/606031 | 10:01 |
| *** k_mouza has quit IRC | 10:03 | |
| *** shubham_potale has joined #openstack-nova | 10:05 | |
| *** Dinesh_Bhor has joined #openstack-nova | 10:08 | |
| *** gouthamr has quit IRC | 10:14 | |
| *** s10 has joined #openstack-nova | 10:29 | |
| *** erlon has joined #openstack-nova | 10:29 | |
| s10 | Hello. Should be bug https://bugs.launchpad.net/python-novaclient/+bug/1743532 be reopened because fix was reverted in https://review.openstack.org/#/c/572539 ? | 10:46 |
| openstack | Launchpad bug 1743532 in python-novaclient "nova list doesn't work above api max_limit" [Undecided,Fix released] - Assigned to Jacek Tomasiak (skazi) | 10:46 |
| *** tbachman has quit IRC | 10:47 | |
| *** alexchadin has quit IRC | 10:53 | |
| *** ttsiouts has quit IRC | 10:58 | |
| *** jistr|call is now known as jistr | 11:00 | |
| *** s10 has quit IRC | 11:03 | |
| sean-k-mooney | s10 from the message it looks like you could have passed --limie=-1 before so the change was not needed and intoduced a bug | 11:13 |
| *** belmorei_ has joined #openstack-nova | 11:14 | |
| *** ratailor has quit IRC | 11:15 | |
| lyarwood | ~. | 11:17 |
| *** belmoreira has quit IRC | 11:17 | |
| *** dtantsur is now known as dtantsur|brb | 11:21 | |
| *** owalsh_away has quit IRC | 11:22 | |
| *** ttsiouts has joined #openstack-nova | 11:25 | |
| *** Dinesh_Bhor has quit IRC | 11:26 | |
| *** owalsh has joined #openstack-nova | 11:28 | |
| openstackgerrit | Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.openstack.org/608696 | 11:32 |
| *** belmorei_ has quit IRC | 11:36 | |
| *** udesale has quit IRC | 11:39 | |
| *** janki has quit IRC | 11:41 | |
| *** Dinesh_Bhor has joined #openstack-nova | 11:44 | |
| *** Dinesh_Bhor has quit IRC | 11:45 | |
| *** janki has joined #openstack-nova | 11:51 | |
| *** priteau has joined #openstack-nova | 11:55 | |
| *** alexchadin has joined #openstack-nova | 11:56 | |
| *** derekh has quit IRC | 12:00 | |
| *** derekh has joined #openstack-nova | 12:00 | |
| *** jpena|off has joined #openstack-nova | 12:02 | |
| *** moshele has quit IRC | 12:04 | |
| *** gouthamr has joined #openstack-nova | 12:05 | |
| *** s10 has joined #openstack-nova | 12:07 | |
| s10 | sean-k-mooney: most of novaclient users don't expect, that they should pass limit=-1 to get all nova instances. For example, behaviour of the minderclient is expected - it gets all cinder volume. But for nova we should pass limit=-1, and nobody does it. | 12:10 |
| s10 | sean-k-mooney: examples are https://github.com/openstack/ceilometer/blob/master/ceilometer/nova_client.py#L146 and https://github.com/openstack/watcher/blob/master/watcher/common/nova_helper.py#L76 | 12:11 |
| *** spatel has joined #openstack-nova | 12:11 | |
| sean-k-mooney | s10: sure but the api limit is there to prevent excess load on that api and the operator does not expect that to be bypassed | 12:11 |
| s10 | sean-k-mooney: ceilometer and watcher expects to get all nova instances here. If someone else uses novaclient python library, they also will face this issue | 12:11 |
| *** TuanDA has quit IRC | 12:12 | |
| sean-k-mooney | s10: ceilometer and watcher can easilly jsut pass -1 however | 12:12 |
| s10 | sean-k-mooney: so basically we should open two bug in ceilometer and watcher and mark 1743532 as a feature, not a bug... | 12:12 |
| *** k_mouza has joined #openstack-nova | 12:13 | |
| s10 | sean-k-mooney: and should we open a bug against cinderclient? because it returns full list of volumes and don't honor api max_limit | 12:13 |
| sean-k-mooney | on the cinder side proably unless its doing the paging internally. | 12:14 |
| sean-k-mooney | so this is really a question of what are the expected semantics of the api and the client | 12:14 |
| sean-k-mooney | i understand that users expect nova list to return all instance if invoked form the commandline | 12:15 |
| *** spatel has quit IRC | 12:15 | |
| sean-k-mooney | that is somwhat resonable but that could be supproted by defaulting to --limit=-1 | 12:16 |
| *** k_mouza has quit IRC | 12:17 | |
| sean-k-mooney | s10: to be clear i personally also expect nova list to return all instances but the previous fix was reverted because it actully intoduced a bug so if we want alter teh behavior again it shoudl likely be done as an RFE | 12:18 |
| *** shubham_potale has quit IRC | 12:19 | |
| *** tetsuro has quit IRC | 12:20 | |
| *** mriedem has joined #openstack-nova | 12:21 | |
| sean-k-mooney | s10: what might be the best thing to do is to reopen the old bug and flag it in the next nova meeting | 12:22 |
| *** tbachman has joined #openstack-nova | 12:27 | |
| *** tbachman_ has joined #openstack-nova | 12:28 | |
| gmann | mriedem: added my comment on https://review.openstack.org/#/c/608474/ | 12:28 |
| gmann | this is going to impact other APi also like PUT flavor, POST server, resize server etc. | 12:29 |
| gmann | those i found till now but there might be other which does get flavor by id | 12:30 |
| *** tbachman has quit IRC | 12:31 | |
| *** tbachman_ is now known as tbachman | 12:31 | |
| *** jarodwl has quit IRC | 12:31 | |
| *** gaoyan has joined #openstack-nova | 12:32 | |
| *** gaoyan has quit IRC | 12:33 | |
| *** gaoyan has joined #openstack-nova | 12:33 | |
| mriedem | gmann: i saw, thanks | 12:36 |
| mriedem | left some replies | 12:36 |
| sean-k-mooney | jaypipes: do the questions i just asked on https://review.openstack.org/#/c/609591/ make sense? | 12:37 |
| *** tbachman has quit IRC | 12:43 | |
| *** mriedem is now known as mriedem_afk | 12:54 | |
| *** edleafe has joined #openstack-nova | 12:57 | |
| jaypipes | sean-k-mooney: he mentions in the commit message that oslo.policy now handles that. | 12:57 |
| *** k_mouza has joined #openstack-nova | 12:59 | |
| *** janki has quit IRC | 13:00 | |
| jaypipes | sean-k-mooney: I think I see you point. commented. | 13:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject forced move with nested source allocation https://review.openstack.org/605785 | 13:01 |
| *** ttsiouts has quit IRC | 13:02 | |
| sean-k-mooney | yes i saw that. i had two point really. one i think they missed the removal of _warning_for_deprecated_user_based_rules and second ya i was not sure how usefual init was at this point | 13:03 |
| sean-k-mooney | but as i also said in the review. i normally dont reviwe any of the policy stuff so im very open to being wrong on either point | 13:05 |
| *** ttsiouts has joined #openstack-nova | 13:05 | |
| *** brinzhang has quit IRC | 13:08 | |
| *** spatel has joined #openstack-nova | 13:08 | |
| jaosorior | sean-k-mooney: hey! thanks for your review on my policy patch. | 13:09 |
| *** k_mouza has quit IRC | 13:09 | |
| sean-k-mooney | jaosorior: no worries did it make sense? | 13:09 |
| jaosorior | sean-k-mooney: I'm now quite confused though. something should be caling the init() function, as that's what initializes the Enfocer object, which actually does the policy evaluation. | 13:09 |
| jaosorior | * valling | 13:09 |
| jaosorior | * calling | 13:09 |
| jaosorior | damn, can't type today :D | 13:09 |
| sean-k-mooney | well i was not actully suggesting removing init but i was about to comment that maybe you can change the module level global into a property that would do the init when its first used? | 13:10 |
| jaosorior | that could be an option. But now I really wanna know where this gets initialized in the first place :D | 13:11 |
| *** k_mouza has joined #openstack-nova | 13:11 | |
| sean-k-mooney | jaosorior: haha well as i pointed out in the review thre are like 4 direct calles to init in the file so whatever gets called first i guess | 13:12 |
| sean-k-mooney | arnt global values fun :P | 13:12 |
| *** dims has quit IRC | 13:12 | |
| *** dims has joined #openstack-nova | 13:14 | |
| jaypipes | jaosorior: in oslo.policy, unless I'm mistaken... | 13:14 |
| sean-k-mooney | jaosorior: if set_rules is the first call to init it passes use_conf=false in all other cases init is called with no argument so it used the default | 13:14 |
| jaypipes | jaosorior: though, to be fair, the easiest way to determine if sean-k-mooney's right is just remove all calls to nova.policy.init() in the entire codebase and see if any tests break :) | 13:14 |
| jaosorior | jaypipes: oslo.policy defines the Enforcer object that's being initialized there. It expects someone to actually initialize the object. Which is what happens in the init function. | 13:15 |
| *** dtantsur|brb is now known as dtantsur | 13:15 | |
| jaosorior | sean-k-mooney: I don't find calls to set_rules | 13:16 |
| jaosorior | sean-k-mooney: must be authorize then | 13:16 |
| *** liuyulong has joined #openstack-nova | 13:17 | |
| *** dims has quit IRC | 13:19 | |
| *** mrch_ has joined #openstack-nova | 13:19 | |
| *** mrch has joined #openstack-nova | 13:22 | |
| *** eharney has joined #openstack-nova | 13:25 | |
| Luzi | hey Nova, we've written the Spec for Image Encryption for Nova and would appreciate reviews :) https://review.openstack.org/#/c/608696/ | 13:25 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove saved_file_rules check from policy https://review.openstack.org/609591 | 13:26 |
| *** alexchadin has quit IRC | 13:27 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove dead code from policy module https://review.openstack.org/609591 | 13:28 |
| jaosorior | sean-k-mooney: so... to keep it simple and not mess it up, I just left the init function. But removed the dead code from that module. Now it looks quite similar to what we have in barbican. | 13:28 |
| *** mrch_ has quit IRC | 13:28 | |
| *** udesale has joined #openstack-nova | 13:28 | |
| jaosorior | ah, damn, we needed the get_enforcer function | 13:29 |
| jaosorior | that is used by oslo.policy's generator (to generate sample policies and docs) | 13:31 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove dead code from policy module https://review.openstack.org/609591 | 13:31 |
| *** lbragstad has joined #openstack-nova | 13:31 | |
| sean-k-mooney | jaosorior: ok im going to stop tying to leave comments. once its working agin this all look better to me :) i left a comment on patchset 2 but i dont know you if you really want to refactor more then you already have | 13:33 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove dead code from policy module https://review.openstack.org/609591 | 13:33 |
| jaosorior | sean-k-mooney: checking it out | 13:34 |
| jaosorior | sean-k-mooney: I'll do the middle ground just to be safe | 13:36 |
| sean-k-mooney | jaosorior: ya no worries removing _warning_for_deprecated_user_based_rules was the main thing i wanted you to do and you have so im happy with your change assuming zuul agrees | 13:37 |
| jaosorior | sean-k-mooney: I'll push another patch in a bit | 13:37 |
| jaosorior | running unit tests | 13:37 |
| jaosorior | jaypipes, sean-k-mooney: Thanks for the reviews! | 13:38 |
| *** psachin has quit IRC | 13:38 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Remove dead code from policy module https://review.openstack.org/609591 | 13:39 |
| *** tbachman has joined #openstack-nova | 13:42 | |
| sean-k-mooney | jaypipes: since your about care to take a look at https://review.openstack.org/#/c/584999/ when you have a chance. i know your busy so if you dont get to it its fine | 13:43 |
| *** spatel has quit IRC | 13:44 | |
| jaypipes | Luzi: done | 13:53 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova-specs master: Use conductor groups to partition nova-compute services for Ironic https://review.openstack.org/609709 | 13:54 |
| jroll | dansmith: TheJulia: ^ I think you were both interested in that | 13:54 |
| dansmith | jroll: hmm, doesn't sound like me | 13:54 |
| jroll | heh | 13:54 |
| jroll | I could be wrong, of course :P | 13:55 |
| dansmith | heh | 13:55 |
| *** k_mouza has quit IRC | 13:56 | |
| *** mriedem_afk is now known as mriedem | 13:56 | |
| TheJulia | jroll: <3 | 13:59 |
| jroll | :) | 14:00 |
| jangutter | quick question for the room, what's the policy for reflowing text in .rst docs? I'm editing one where it looks like the column width was set at 60. | 14:01 |
| *** mlavalle has joined #openstack-nova | 14:03 | |
| efried | jangutter: You're going to piss off *somebody* | 14:03 |
| efried | If you do it in the same change with other stuff, folks will complain that it's unrelated. If you do it in a separate patch, folks will complain that it's trivial and unnecessary. | 14:04 |
| efried | But if I had to pick, I would do the latter. | 14:04 |
| jaypipes | sean-k-mooney: done | 14:05 |
| *** mvkr has quit IRC | 14:12 | |
| *** panda|mtg has quit IRC | 14:12 | |
| *** panda has joined #openstack-nova | 14:14 | |
| jangutter | efried: how to make friends and meet people using whitespace.... | 14:16 |
| mriedem | do the latter | 14:17 |
| mriedem | don't mix formatting with content changes | 14:17 |
| mriedem | b/c it becomes a pain in the ass to review | 14:17 |
| mriedem | GOD I'M MAD JUST THINKING ABOUT THIS?!?!?!? | 14:17 |
| aspiers | efried: haha | 14:18 |
| aspiers | mriedem: +1 | 14:18 |
| artom | I think if you manage to make an outline of Batman's silhouette by varying the text width everyone will +2 immediately. | 14:18 |
| *** mchlumsky has joined #openstack-nova | 14:18 | |
| aspiers | or you could embed subliminal messages in the whitespace via http://www.darkside.com.au/snow/ | 14:19 |
| *** dims has joined #openstack-nova | 14:22 | |
| jangutter | I was more thinking of writing my life story with an acrostic, but those suggestions are good too. | 14:22 |
| *** knikolla has joined #openstack-nova | 14:22 | |
| aspiers | X-D | 14:23 |
| *** ttsiouts has quit IRC | 14:26 | |
| *** mhen has quit IRC | 14:27 | |
| *** artom has quit IRC | 14:27 | |
| *** dave-mccowan has joined #openstack-nova | 14:31 | |
| *** mhen has joined #openstack-nova | 14:31 | |
| *** whoami-rajat has quit IRC | 14:38 | |
| *** artom has joined #openstack-nova | 14:42 | |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Reflow docs to 79 columns https://review.openstack.org/609726 | 14:43 |
| *** dims has quit IRC | 14:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | 14:43 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle allocations consuming only from the child RPs https://review.openstack.org/608298 | 14:44 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle allocations consuming only from the child RPs https://review.openstack.org/608298 | 14:45 |
| *** Luzi has quit IRC | 14:47 | |
| *** dims has joined #openstack-nova | 14:48 | |
| *** ttsiouts has joined #openstack-nova | 14:50 | |
| *** Swami has joined #openstack-nova | 14:51 | |
| jangutter | I think the only time formatting and whitespace changes are legit allowed to be mixed is in the IOCCC | 14:57 |
| sean-k-mooney | jangutter: for the record i also hate that we enforce a 79 charater colum limit | 14:57 |
| jangutter | sean-k-mooney: you prefer wider or narrower? | 14:58 |
| sean-k-mooney | well one wider but too the limit was ment to be 80 charaters but someone decided to enforce 79 instead | 14:58 |
| *** openstackgerrit has quit IRC | 14:58 | |
| jangutter | sean-k-mooney: could be worse, could be Fortran. | 14:59 |
| *** openstackgerrit has joined #openstack-nova | 14:59 | |
| sean-k-mooney | frotrans standard is 132 i would be fine with that | 15:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup https://review.openstack.org/606050 | 15:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject forced move with nested source allocation https://review.openstack.org/605785 | 15:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | 15:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle allocations consuming only from the child RPs https://review.openstack.org/608298 | 15:01 |
| *** mriedem has quit IRC | 15:03 | |
| *** lbragstad has quit IRC | 15:04 | |
| *** artom has quit IRC | 15:04 | |
| *** lbragstad has joined #openstack-nova | 15:05 | |
| openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: OVA and StrOpt images as VM templates https://review.openstack.org/609736 | 15:08 |
| *** gyee has joined #openstack-nova | 15:08 | |
| *** artom has joined #openstack-nova | 15:11 | |
| *** artom has quit IRC | 15:16 | |
| *** lbragstad has quit IRC | 15:18 | |
| *** lbragstad has joined #openstack-nova | 15:19 | |
| *** artom has joined #openstack-nova | 15:19 | |
| *** openstackgerrit has quit IRC | 15:22 | |
| *** s10 has quit IRC | 15:23 | |
| *** mugsie has joined #openstack-nova | 15:23 | |
| *** k_mouza has joined #openstack-nova | 15:25 | |
| *** mvkr has joined #openstack-nova | 15:27 | |
| *** k_mouza has quit IRC | 15:27 | |
| *** k_mouza has joined #openstack-nova | 15:28 | |
| *** macza has joined #openstack-nova | 15:28 | |
| artom | So, I'm trying to write a new func tests that boots a server with a volume using the Cinder fixture, and I'm hitting 401 errors: http://paste.openstack.org/show/731904/ | 15:30 |
| artom | As far as I can tell I'm going the same things as other existing tests | 15:31 |
| *** tbachman has quit IRC | 15:31 | |
| *** k_mouza has quit IRC | 15:32 | |
| *** openstackgerrit has joined #openstack-nova | 15:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.67: BDMv2 volume_type https://review.openstack.org/609743 | 15:32 |
| *** mriedem has joined #openstack-nova | 15:32 | |
| *** ttsiouts has quit IRC | 15:34 | |
| *** ttsiouts has joined #openstack-nova | 15:34 | |
| *** ttsiouts has quit IRC | 15:39 | |
| *** k_mouza has joined #openstack-nova | 15:40 | |
| *** macza has quit IRC | 15:43 | |
| *** macza has joined #openstack-nova | 15:43 | |
| *** k_mouza_ has joined #openstack-nova | 15:44 | |
| *** k_mouza has quit IRC | 15:44 | |
| *** macza has quit IRC | 15:45 | |
| *** macza has joined #openstack-nova | 15:45 | |
| mriedem | dansmith: huh, something must have regressed devstack's setup for nova-cpu.conf because it has db setup in it now... http://logs.openstack.org/87/604687/6/check/tempest-full/5e2a539/controller/logs/etc/nova/nova-cpu_conf.txt.gz | 15:47 |
| *** k_mouza has joined #openstack-nova | 15:47 | |
| dansmith | mriedem: hmm, I just installed a fresh devstack the other day and it didn't | 15:47 |
| mriedem | i noticed this on a devstack i just created this morning | 15:47 |
| dansmith | and pointing at cell0 | 15:47 |
| *** k_mouza_ has quit IRC | 15:48 | |
| *** cfriesen has joined #openstack-nova | 15:48 | |
| mriedem | right - not that nova-compute should be trying to hit a db either way, but those shouldn't be in the cpu config | 15:48 |
| dansmith | maybe melwitt's console patch? | 15:49 |
| dansmith | definitely | 15:49 |
| mriedem | https://github.com/openstack-dev/devstack/blob/master/lib/nova#L918 ? | 15:49 |
| mriedem | cell1 conf looks good http://logs.openstack.org/87/604687/6/check/tempest-full/5e2a539/controller/logs/etc/nova/nova_cell1_conf.txt.gz | 15:49 |
| dansmith | that line is old | 15:50 |
| mriedem | yeah, | 15:50 |
| mriedem | it's also wrong in nova-cpu.conf on queens http://logs.openstack.org/55/606155/1/check/tempest-full/dcd0005/controller/logs/etc/nova/nova-cpu_conf.txt.gz | 15:50 |
| mriedem | so it's not mel's console config change | 15:50 |
| mriedem | maybe just always busted? | 15:50 |
| *** helenafm has quit IRC | 15:51 | |
| dansmith | mm, I dunno | 15:51 |
| mriedem | looks like that function is copying nova-cpu.conf from $NOVA_CONF which is nova.conf | 15:51 |
| mriedem | which is the controller config | 15:51 |
| *** k_mouza has quit IRC | 15:51 | |
| mriedem | anywho, not a huge deal since we don't have local conductor | 15:51 |
| mriedem | i was just confused | 15:51 |
| mriedem | b/c i was able to sync the cell db using nova-cpu.conf | 15:51 |
| mriedem | which shouldn't work | 15:52 |
| dansmith | definitely wrong though.. I can't imagine that's been broken like that for so long | 15:52 |
| *** k_mouza has joined #openstack-nova | 15:52 | |
| *** dklyle has quit IRC | 15:53 | |
| dansmith | it's wrong in a result from sep 26 at least | 15:53 |
| *** gaoyan has quit IRC | 15:53 | |
| dansmith | I was probably looking at my subnode cpu conf recently actually | 15:55 |
| dansmith | but surely looks like it's been this way | 15:56 |
| mriedem | yeah, reported a bug anyway https://bugs.launchpad.net/devstack/+bug/1797413 | 15:56 |
| openstack | Launchpad bug 1797413 in devstack "nova-cpu.conf shouldn't have database config in it" [Low,Triaged] | 15:56 |
| mriedem | for an intrepid contributor | 15:56 |
| dansmith | I shall propose a fix | 15:57 |
| *** dpawlik has joined #openstack-nova | 15:57 | |
| mriedem | i just wouldn't want someone new to spin up devstack and look and think "oh nova-compute needs db access" | 15:57 |
| dansmith | well, we also want to make sure we're not cheating on this somehow | 15:57 |
| mriedem | right | 15:57 |
| *** dklyle has joined #openstack-nova | 15:58 | |
| *** dtantsur is now known as dtantsur|afk | 16:00 | |
| *** dpawlik has quit IRC | 16:01 | |
| *** k_mouza has quit IRC | 16:02 | |
| *** k_mouza_ has joined #openstack-nova | 16:02 | |
| *** k_mouza has joined #openstack-nova | 16:03 | |
| *** tbachman has joined #openstack-nova | 16:04 | |
| *** liuyulong has quit IRC | 16:05 | |
| *** k_mouza_ has quit IRC | 16:06 | |
| mriedem | you know, the service catalog clearly needs more cinder entries | 16:08 |
| *** jangutter has quit IRC | 16:15 | |
| *** mvkr has quit IRC | 16:16 | |
| *** jangutter has joined #openstack-nova | 16:17 | |
| *** lpetrut has quit IRC | 16:18 | |
| *** burt has joined #openstack-nova | 16:19 | |
| *** panda has quit IRC | 16:20 | |
| *** jangutter has quit IRC | 16:20 | |
| *** panda has joined #openstack-nova | 16:21 | |
| melwitt | 16:22 | |
| aspiers | melwitt: I should have the spec submitted in the next few hours | 16:25 |
| melwitt | ok, cool | 16:25 |
| mriedem | heh oops http://paste.openstack.org/show/731907/ | 16:32 |
| mriedem | installed new versioned object code, restarted computes to new code but forgot to restart conductor | 16:33 |
| openstackgerrit | Georg Hoesch proposed openstack/nova master: handle logfiles for tcp-based consoles https://review.openstack.org/575735 | 16:33 |
| *** gouthamr has quit IRC | 16:34 | |
| *** k_mouza has quit IRC | 16:35 | |
| *** k_mouza has joined #openstack-nova | 16:37 | |
| mriedem | welp, bfv with volume type works http://paste.openstack.org/show/731908/ | 16:38 |
| * melwitt cues the choral music | 16:38 | |
| mriedem | others might want to start reviewing that series, | 16:43 |
| *** gouthamr has joined #openstack-nova | 16:43 | |
| mriedem | it ends on the 14th | 16:43 |
| melwitt | oof ok | 16:43 |
| *** mriedem is now known as mriedem_afk | 16:43 | |
| sean-k-mooney | mriedem_afk: that is booting with a precreated voluem or you are asking for a new volume to be created? i never do boot from volume via cli just horizon so just interested in understanding how it works | 16:45 |
| *** Swami has quit IRC | 16:45 | |
| sean-k-mooney | im guessin --block-device id=b9cdd407-14fc-42fb-beb9-d53988d866e3,source=image,dest=volume,size=1,bootindex=0,shutdown=remove,volume_type=lvmdriver-1 mean create an volume of 1GB form this image and boot with it | 16:46 |
| melwitt | yes | 16:47 |
| sean-k-mooney | cool the shutdown=remove is sligtly odd. that is so we can swap the root disk when the insance is shutdown im guessing? | 16:48 |
| dansmith | shutdown=remove means delete the volume when you delete the instance, and that's been around a long time | 16:49 |
| melwitt | yeah. it maps to delete_on_termination=True in the code | 16:49 |
| sean-k-mooney | i see delete_on_termination=True convayes that much more cleanly | 16:50 |
| *** dpawlik has joined #openstack-nova | 16:52 | |
| *** dpawlik has quit IRC | 16:53 | |
| *** dpawlik has joined #openstack-nova | 16:53 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Use nova-consoleauth only if workaround enabled https://review.openstack.org/607068 | 16:58 |
| melwitt | mriedem_afk: I added the code comment ^ | 16:59 |
| *** derekh has quit IRC | 16:59 | |
| *** dklyle has quit IRC | 17:04 | |
| *** sapd1_ has joined #openstack-nova | 17:05 | |
| *** k_mouza has quit IRC | 17:09 | |
| *** udesale has quit IRC | 17:11 | |
| *** sayalilunkad has quit IRC | 17:15 | |
| *** Swami has joined #openstack-nova | 17:15 | |
| *** sayalilunkad has joined #openstack-nova | 17:19 | |
| *** macza has quit IRC | 17:20 | |
| *** macza_ has joined #openstack-nova | 17:20 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Handle volume API failure in post_live_migration https://review.openstack.org/609517 | 17:26 |
| *** etp has joined #openstack-nova | 17:31 | |
| *** dklyle has joined #openstack-nova | 17:35 | |
| dansmith | mriedem_afk: I feel like you could probably look at this and judge it quickly: https://review.openstack.org/#/c/609517/4 | 17:35 |
| dansmith | error handling in volume detach during live migration.. two of your favorite things :) | 17:36 |
| *** dpawlik has quit IRC | 17:39 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Handle volume API failure in post_live_migration https://review.openstack.org/609517 | 17:48 |
| *** maciejjozefczyk has quit IRC | 17:49 | |
| *** andreykurilin has quit IRC | 17:50 | |
| *** andreykurilin has joined #openstack-nova | 17:51 | |
| *** mvkr has joined #openstack-nova | 18:00 | |
| aspiers | following up from the whitespace discussion earlier, are typo fixes to documentation more welcomed than hated? | 18:03 |
| melwitt | typo fixes to user-facing documentation are helpful | 18:05 |
| jaypipes | aspiers: I think it depends on the reviewer. Personally, I'm fine with such fixes and encourage them. Increasing the quality of our docs is important to me. | 18:05 |
| aspiers | thanks, submitting :) | 18:05 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: fix "you" typo https://review.openstack.org/609777 | 18:06 |
| *** dpawlik has joined #openstack-nova | 18:07 | |
| jaypipes | aspiers: -3. | 18:08 |
| jaypipes | aspiers: j/k :) | 18:08 |
| aspiers | lol | 18:08 |
| imacdonn | wow .. -3 ... yikes! | 18:08 |
| jaypipes | :) | 18:08 |
| aspiers | thanks, now I have to change my underwear | 18:08 |
| jaypipes | +Wallaby'd | 18:08 |
| aspiers | X-D | 18:08 |
| *** mriedem_afk is now known as mriedem | 18:09 | |
| *** dpawlik has quit IRC | 18:09 | |
| aspiers | that'll push me up from being # 97,381 in the stackalytics rankings to # 97,380 \o/ | 18:09 |
| *** dpawlik has joined #openstack-nova | 18:09 | |
| imacdonn | congrats ;) | 18:10 |
| aspiers | and we all know success in life is defined by stackalytics | 18:10 |
| *** dpawlik has quit IRC | 18:10 | |
| mriedem | dansmith: i'll be the judge of how quickly i can judge something | 18:10 |
| *** dpawlik has joined #openstack-nova | 18:11 | |
| dansmith | aspiers: yeah my last loan officer said "aand, just one more thing, what's your stackalytics ranking?" | 18:11 |
| aspiers | hahaha | 18:11 |
| dansmith | mriedem: I should hope so | 18:11 |
| aspiers | I barely squeaked through CBP at Denver airpor because my stackalytics were so poor | 18:12 |
| *** sapd1_ has quit IRC | 18:12 | |
| * dansmith calls in an anonymous tip for next time | 18:13 | |
| *** dpawlik has quit IRC | 18:13 | |
| imacdonn | dansmith sean-k-mooney mriedem: please rereview ... note that I had to tweak the logic a bit (see comment in review) ... https://review.openstack.org/#/c/608091/ | 18:13 |
| *** dpawlik has joined #openstack-nova | 18:14 | |
| aspiers | dansmith: luckily my UK passport will let me into Berlin for the next few months at least :-/ | 18:14 |
| dansmith | heh | 18:14 |
| imacdonn | you non-european european, you | 18:15 |
| aspiers | actually I'm technically also an Irish citizen, but haven't got around to applying for that passport yet | 18:15 |
| aspiers | (thanks mum) | 18:15 |
| imacdonn | I have both UK and Irish passports .. it's been handy in the past | 18:15 |
| aspiers | oh nice | 18:15 |
| * aspiers is dangerously close to submitting this spec | 18:16 | |
| imacdonn | and a green card, so I have a few bases covered ;) | 18:16 |
| aspiers | wow, good work | 18:16 |
| aspiers | I have Global Entry at least | 18:16 |
| *** dpawlik has quit IRC | 18:19 | |
| *** openstackgerrit has quit IRC | 18:20 | |
| aspiers | hmm, I guess I should submit the blueprint first, otherwise the spec will point to a non-existing bp | 18:20 |
| *** openstackgerrit has joined #openstack-nova | 18:23 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Use nova-consoleauth only if workaround enabled https://review.openstack.org/607068 | 18:23 |
| melwitt | attempt number 29413059 ^ | 18:23 |
| dansmith | aspiers: yeah, which is auto-minus-2-auto-abandon | 18:23 |
| aspiers | uh-oh ... well, that's still better than -3, so I'm improving ;-) | 18:24 |
| artom | As long as it's not -3.14, no one should be without pie | 18:24 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 18:24 |
| * dansmith tries to lie his way to fulfill the "all nova devs are giant dicks" common belief | 18:24 | |
| aspiers | artom: I'm with you on that | 18:24 |
| aspiers | haha | 18:25 |
| artom | dansmith, I mean, I'll take the "giant" as a compliment | 18:25 |
| *** gouthamr_ has joined #openstack-nova | 18:25 | |
| aspiers | melwitt: here it is finally ... https://blueprints.launchpad.net/nova/+spec/amd-sev-libvirt-support | 18:25 |
| * melwitt cues the choral music again | 18:25 | |
| aspiers | my very first nova spec, so I'm prepared for the -3s to roll in | 18:26 |
| dansmith | artom: heh | 18:26 |
| aspiers | artom: ROFL | 18:26 |
| aspiers | melwitt: one of the key questions is whether the built-in trait:HW_CPU_x86_SEV support should be included in this spec, or split off into a separate spec | 18:27 |
| aspiers | melwitt: I'll gratefully take guidance on that | 18:27 |
| melwitt | that's a jaypipes question | 18:27 |
| aspiers | OK thanks | 18:27 |
| melwitt | but I think in this spec would be fine | 18:27 |
| aspiers | also, as a distinct nova newb, I've probably got the wrong end of the stick on a whole bunch of other stuff | 18:27 |
| jaypipes | aspiers: I'll have a gander later today. | 18:28 |
| aspiers | a lot of it is based on reading source code over the last few days | 18:28 |
| aspiers | jaypipes: awesome, thanks! | 18:28 |
| *** openstackstatus has quit IRC | 18:28 | |
| aspiers | intention is for me (and/or maybe colleagues) to do the heavy lifting, so we're not expecting anyone else to come in and do the hard work for us | 18:29 |
| mriedem | dansmith: i left some replies in https://review.openstack.org/#/c/605573/15 | 18:29 |
| aspiers | ... although of course we wouldn't object to that ;-) | 18:29 |
| *** openstackstatus has joined #openstack-nova | 18:30 | |
| *** ChanServ sets mode: +v openstackstatus | 18:30 | |
| aspiers | oh crap, I forgot to finish the work items and dependencies sections | 18:30 |
| * aspiers slaps himself with a wet fish | 18:30 | |
| imacdonn | -4 ? | 18:31 |
| mriedem | ah traits, the new flavor extra spec | 18:32 |
| aspiers | I'm OK with that if I get in the Guinness World Records for lowest Gerrit score | 18:32 |
| *** ralonsoh has quit IRC | 18:32 | |
| mriedem | aspiers: have you read http://lists.openstack.org/pipermail/openstack-dev/2018-October/135446.html ? | 18:32 |
| aspiers | almost certainly not | 18:32 |
| * aspiers reads ... | 18:32 | |
| mriedem | probably answers your trait questoin | 18:33 |
| mriedem | *question | 18:33 |
| aspiers | cool, thanks | 18:33 |
| mriedem | tl;dr is we'll translate a flavor extra spec / image property to a trait for scheduling and the virt driver would use the extra spec/image property | 18:34 |
| aspiers | mriedem: hooray, it seems my proposal accidentally aligns with upstream consensus on this | 18:34 |
| aspiers | wait - doesn't that translation correspond to the first approach listed in that mail, rather than the second? | 18:35 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova-specs master: Use conductor groups to partition nova-compute services for Ironic https://review.openstack.org/609709 | 18:35 |
| *** panda has quit IRC | 18:35 | |
| mriedem | i guess | 18:37 |
| mriedem | i don't remember being around for the decision | 18:37 |
| aspiers | that mail says "Ultimately, the decision was made to go with the second approach." | 18:37 |
| *** panda has joined #openstack-nova | 18:38 | |
| mriedem | yeah i just read it | 18:38 |
| mriedem | hopefully that makes its way into developer docs somewhere at some point | 18:38 |
| aspiers | +1 for that | 18:38 |
| aspiers | but that's super-helpful - I'm gonna link it from the spec. thanks! | 18:39 |
| melwitt | yeah, in the spec https://review.openstack.org/#/c/607989/1/specs/stein/approved/support-hpet-on-guest.rst it's the "explicit trait, implicit config" approach | 18:39 |
| *** dpawlik has joined #openstack-nova | 18:40 | |
| *** dpawlik has quit IRC | 18:41 | |
| *** dpawlik has joined #openstack-nova | 18:41 | |
| mriedem | dansmith: on that cache thing, can we do that in a follow up? | 18:42 |
| *** gouthamr has quit IRC | 18:45 | |
| dansmith | mriedem: I was even going to volunteer to do it as a follow-up, but then you hurt my feelings by calling it excessive | 18:47 |
| mriedem | "all nova devs are giant dicks" | 18:47 |
| mriedem | just trying to stay true to form... | 18:47 |
| dansmith | I would like to appeal to our guidance counselor | 18:48 |
| mriedem | is it still mnaser? | 18:49 |
| mnaser | mriedem: you're on timeout | 18:50 |
| mnaser | 4 hours of typo fixing | 18:50 |
| dansmith | they're drawing new names out of a hat to ensure fairness I think | 18:50 |
| mnaser | be nice >:( | 18:50 |
| mnaser | also now that i've been highlighted | 18:51 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 18:51 |
| mnaser | eyes on https://review.openstack.org/#/c/602384/ would be important/nice considering you can kinda snoop and listen to other vms traffic | 18:51 |
| mnaser | which is kind of a big deal™ | 18:51 |
| mriedem | sean-k-mooney was supposed to be working on backports | 18:51 |
| mriedem | to see if older versions of libvirt had issues with that | 18:52 |
| mnaser | "someone" i know has done extensive testing | 18:53 |
| mnaser | and would be likely happy to do local testing | 18:53 |
| mnaser | so i'll try to ask/get them here to help sean-k-mooney | 18:53 |
| mriedem | mnaser: on https://review.openstack.org/#/c/609330/1/specs/stein/approved/remove-force-flag-from-live-migrate-and-evacuate.rst@93 you don't know of any operators that disable computes and then force live migrations to those hosts to rebalance or during rolling upgrades? | 18:53 |
| *** dave-mccowan has quit IRC | 18:54 | |
| mnaser | mriedem: we do a bit of the opposite. we disable the host being evacuated and then evacuate that one | 18:55 |
| mnaser | that way the scheduler just distributes things the way they're suppoesd to be | 18:55 |
| mnaser | i'll reply to the comment | 18:56 |
| mnaser | mriedem: added my comment | 18:59 |
| mriedem | mnaser: btw, you don't get "on" timeout, you get "in" timeout | 18:59 |
| mriedem | unless on timeout is a canadian thing | 18:59 |
| mriedem | it's like kid jail | 18:59 |
| mnaser | sorry i haven't done the whole raising a kid/pet/thing | 18:59 |
| * mriedem was going to make a subtle kidnapping joke but... | 19:00 | |
| mnaser | whats wrong with kids napping | 19:00 |
| dansmith | mriedem: hmm, does the context we're passing to get_all_volume_types potentially limit the result to what you have available based on who you are? | 19:02 |
| mriedem | dansmith: yes | 19:02 |
| mriedem | so no caching | 19:02 |
| * dansmith runs git checkout -f | 19:02 | |
| mriedem | unless you use cinder admin config and list all volume types | 19:03 |
| mriedem | which we have, but it's optional | 19:03 |
| dansmith | I'll just stop trying to be smart | 19:04 |
| mriedem | that's ok, i apparently don't understand json schema https://review.openstack.org/#/c/606398/10/nova/tests/unit/api/openstack/compute/test_serversV21.py | 19:05 |
| *** dave-mccowan has joined #openstack-nova | 19:05 | |
| melwitt | mriedem: doesn't "null" mean not present at all? I don't think it means None | 19:06 |
| openstackgerrit | Florian Haas proposed openstack/nova master: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609788 | 19:07 |
| mriedem | the "required" entry in the schema should say if the field can be missing | 19:07 |
| melwitt | although, what would None map to then? not string, apparently | 19:07 |
| mriedem | so i'm confused as to what 'null' means here, because it's the same for the trusted cert id and description fields | 19:07 |
| openstackgerrit | Florian Haas proposed openstack/nova stable/rocky: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609789 | 19:07 |
| melwitt | hm, ok. I guess I don't understand it either then. I had thought "null" meant that it could be omitted | 19:07 |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 19:08 |
| openstackgerrit | Florian Haas proposed openstack/nova stable/queens: Explain nested guest support https://review.openstack.org/609790 | 19:08 |
| mriedem | i'm able to create a server with a null description: {"server": {"name": "test-null-desc", "description": null, "imageRef": "b9cdd407-14fc-42fb-beb9-d53988d866e3", "flavorRef": "1", "max_count": 1, "min_count": 1, "networks": "none"}} | 19:10 |
| mriedem | hmm wtf | 19:14 |
| mriedem | curl -g -i -X POST http://199.204.45.149/compute/v2.1/servers -H "Accept: application/json" -H "Content-Type: application/json" -H "OpenStack-API-Version: compute 2.67" -H "X-Auth-Token: $token" -H "X-OpenStack-Nova-API-Version: 2.67" -d '{"server": {"name": "bfv-server-null-vol-type", "imageRef": "", "block_device_mapping_v2": [{"boot_index": "0", "uuid": "b9cdd407-14fc-42fb-beb9-d53988d866e3", "volume_size": "1", "volume_ty | 19:14 |
| mriedem | null, "source_type": "image", "destination_type": "volume", "delete_on_termination": true}], "flavorRef": "1", "max_count": 1, "min_count": 1, "networks": "none"}}' | 19:14 |
| mriedem | HTTP/1.1 202 Accepted | 19:14 |
| mriedem | that's a null volume type | 19:14 |
| melwitt | \:| | 19:16 |
| mriedem | dansmith: you were right about that unset bdm.volume_type thing, wrote a test, will fix | 19:24 |
| dansmith | finally. | 19:24 |
| *** dpawlik has quit IRC | 19:26 | |
| mriedem | i don't know how those functional api samples tests are passing without the cinder fixture either... | 19:33 |
| mriedem | something smells in the tests | 19:33 |
| *** diliprenkila has joined #openstack-nova | 19:37 | |
| artom | mriedem, a while ago I tried making the samples tests run with 2.latest, and realized I needed the CinderFixture (I think - might have been Neutron) | 19:39 |
| * artom digs | 19:39 | |
| *** eharney has quit IRC | 19:43 | |
| artom | Hrmm, my old abandoned patches aren't telling me much. Anyways, it might be microversions, is what I'm saying. | 19:43 |
| * artom hopes that was even a tiny bit useful. | 19:43 | |
| *** manjeets has quit IRC | 20:04 | |
| *** manjeets has joined #openstack-nova | 20:07 | |
| *** _hemna has quit IRC | 20:11 | |
| *** _pewp_ has quit IRC | 20:11 | |
| mriedem | well i think i know why the api samples are busted | 20:11 |
| *** _pewp_ has joined #openstack-nova | 20:12 | |
| mriedem | https://github.com/openstack/nova/blob/7a5d7db7fc6ccfbd97508a1e8cd353ec25cf8ca2/nova/tests/functional/api_sample_tests/test_servers.py#L38 | 20:12 |
| mriedem | it's not using the 2.67 request sample | 20:12 |
| *** _hemna has joined #openstack-nova | 20:13 | |
| artom | Hey, I was right! Time to revive https://review.openstack.org/#/c/430352/ ? | 20:15 |
| mriedem | i'm not sure i understand all that black magic | 20:17 |
| mriedem | common_req_names is definitely f'ed though | 20:18 |
| artom | It's basically a way to automagically load whatever the latest samples in the tree are, and adds a test case that runs with 2.latest | 20:19 |
| openstackgerrit | Merged openstack/os-vif master: Reflow docs to 79 columns https://review.openstack.org/609726 | 20:20 |
| artom | I still kinda want it to happen, but ideally there'd be a really awesome generous intelligent core who would commit to it, because it's loads of tedious work fixing all the samples that break with 2.latest | 20:22 |
| mriedem | i don't see any cores like that around here | 20:23 |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Document Stein review priorities https://review.openstack.org/609807 | 20:24 |
| artom | Giant dicks indeed ;) | 20:24 |
| mriedem | ima need this to fix these tests https://www.youtube.com/watch?v=3sClFZ21oSo | 20:35 |
| * melwitt does last minute bug triage to improve the numbers for the meeting | 20:40 | |
| *** pcaruana has quit IRC | 20:40 | |
| melwitt | I could use the same music to triage a bunch of bugs | 20:40 |
| mriedem | this was on the radio on the way home from lunch with laura today, https://www.youtube.com/watch?v=zNgcYGgtf8M - i threatened to roll the windows down and blast it | 20:41 |
| mriedem | who me?! yes you! | 20:42 |
| melwitt | that's a good one | 20:42 |
| *** tbachman has quit IRC | 20:46 | |
| *** tbachman has joined #openstack-nova | 20:46 | |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Document Stein review priorities https://review.openstack.org/609807 | 20:48 |
| *** tbachman_ has joined #openstack-nova | 20:48 | |
| melwitt | nova meeting in 10 minutes | 20:50 |
| *** tbachman has quit IRC | 20:51 | |
| *** tbachman_ is now known as tbachman | 20:51 | |
| *** takashin has joined #openstack-nova | 20:51 | |
| mriedem | well i figured out the 2.67 unit test failures | 20:58 |
| mriedem | or lack thereof | 20:58 |
| *** takashin has quit IRC | 21:02 | |
| *** erlon has quit IRC | 21:02 | |
| *** takashin has joined #openstack-nova | 21:03 | |
| *** tssurya has joined #openstack-nova | 21:04 | |
| *** takashin has quit IRC | 21:08 | |
| *** takashin has joined #openstack-nova | 21:12 | |
| cfriesen | bauzas: you might find this interesting: https://bugs.launchpad.net/nova/+bug/1797269 | 21:12 |
| openstack | Launchpad bug 1797269 in OpenStack Compute (nova) "Nova fails creating multiple NVIDIA VGPU instances at the same time" [Undecided,New] | 21:12 |
| *** takashin has quit IRC | 21:15 | |
| *** takashin has joined #openstack-nova | 21:15 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add support for generic tap device plug https://review.openstack.org/602384 | 21:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add compute version 36 to support ``volume_type`` https://review.openstack.org/579360 | 21:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add compute API validation for when a volume_type is requested https://review.openstack.org/605573 | 21:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398 | 21:19 |
| *** takashin has quit IRC | 21:20 | |
| openstackgerrit | Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989 | 21:21 |
| *** priteau has quit IRC | 21:22 | |
| mriedem | dansmith: there ^ | 21:23 |
| mriedem | not sure i can +2 those now | 21:23 |
| openstackgerrit | Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989 | 21:24 |
| mriedem | +1 on a couple, and +2 on the others that i didn't touch in non-trivial ways | 21:26 |
| *** dave-mccowan has quit IRC | 21:28 | |
| *** dave-mccowan has joined #openstack-nova | 21:29 | |
| *** panda has quit IRC | 21:34 | |
| sean-k-mooney | melwitt: i have address your momments on https://review.openstack.org/#/c/602384 by the way. ill be starting on the backport tomorrow. | 21:35 |
| sean-k-mooney | /momments/comments/ | 21:35 |
| melwitt | k, will look | 21:35 |
| sean-k-mooney | mriedem: mnaser a different edgecase that will likely need a more invovled fix was flagged to me for that bug earlier today | 21:36 |
| *** panda has joined #openstack-nova | 21:37 | |
| sean-k-mooney | mriedem: mnaser i dont think the current patch or os-vif on its own can address it if i confirm it tommrow and i think will require nova and or neutron change to fix the second vector. | 21:37 |
| mnaser | sounds like a boatload of fun | 21:38 |
| sean-k-mooney | mnaser: yes its one metric "boatload of fun". | 21:39 |
| cfriesen | mriedem: any chance you could take a look at this? It's been sitting around for a while without any real reviews and it's in code you know about. https://review.openstack.org/#/c/603844/ | 21:42 |
| sean-k-mooney | mnaser: what version of openstack are you running by the way. | 21:42 |
| mnaser | sean-k-mooney: queens in process of upgrading to rocky in montreal and rocky in sjc | 21:43 |
| openstackgerrit | Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989 | 21:44 |
| mriedem | code i know about? | 21:46 |
| mriedem | flattery will get you everywhere | 21:46 |
| *** macza has joined #openstack-nova | 21:47 | |
| *** takashin has joined #openstack-nova | 21:47 | |
| *** macza has quit IRC | 21:47 | |
| *** macza has joined #openstack-nova | 21:48 | |
| cfriesen | I figured I'd ping sfinucan tomorrow since he's mucked with the neutron api too | 21:49 |
| *** macza_ has quit IRC | 21:49 | |
| mriedem | this is kind of sledgehammery | 21:50 |
| mriedem | "neutron could be down at some point so let's always check" | 21:50 |
| cfriesen | you mean the call to check if it's unbound/failed is unconditional? | 21:51 |
| *** macza has quit IRC | 21:52 | |
| dansmith | mriedem: just checking that you don't think a local test is necessary here? https://review.openstack.org/#/c/606398/11/nova/tests/unit/api/openstack/compute/test_serversV21.py | 21:53 |
| *** gouthamr_ is now known as gouthamr | 21:53 | |
| dansmith | I know the next file kinda has a little coverage | 21:53 |
| mriedem | yeah that's in the next module | 21:58 |
| mriedem | cfriesen: it seems sort of whack-a-mole to me to have to check if our networking is f'ed up always on rebuild and reboot | 21:59 |
| mriedem | because the argument could be made that we need to do the same thing in lots of other operations right? | 21:59 |
| mriedem | e.g. we don't trust the cache | 21:59 |
| dansmith | aight | 21:59 |
| sean-k-mooney | cfriesen: ill try and review that cahnge also. | 22:01 |
| cfriesen | hard reboot and rebuild are a bit special in that they are used to recover from error scenarios (where the instance is in ERROR status) | 22:01 |
| cfriesen | sean-k-mooney: thanks. | 22:01 |
| cfriesen | so the idea is that we need to deal with scenarios like an evacuation that failed halfway through, | 22:02 |
| mriedem | what about rescue | 22:03 |
| cfriesen | can you rescue an instance in error state? (I don't use rescue much.) | 22:04 |
| mriedem | yeah apparently | 22:04 |
| mriedem | you can also stop/start an error instance but doesn't look like that messes with networking | 22:04 |
| sean-k-mooney | mriedem: well stop/start would be the same as hard reboot right? | 22:05 |
| cfriesen | looks like maybe rescue might make sense to handle as well | 22:05 |
| sean-k-mooney | cfriesen: for evacuate you are refing to the rebuild we do and not nova host-evacuate-live | 22:07 |
| cfriesen | sean-k-mooney: yes | 22:07 |
| sean-k-mooney | ok because if the livemigation fails in the nova host-evacuate-live case it may have the wrong host set in the instance if it fails in the post migration cleanup code | 22:08 |
| openstackgerrit | Merged openstack/nova master: Add scatter-gather-single-cell utility https://review.openstack.org/594947 | 22:09 |
| openstackgerrit | Merged openstack/nova master: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/607650 | 22:10 |
| openstackgerrit | Merged openstack/nova master: fix "you" typo https://review.openstack.org/609777 | 22:10 |
| mriedem | sean-k-mooney: no i don't think so | 22:10 |
| sean-k-mooney | mriedem: ? you dont think you can have the wrong host set on the instace? | 22:11 |
| mriedem | you said "same as" but i guess i don't know what you mean by same as | 22:11 |
| mriedem | cfriesen: comments inline | 22:12 |
| mriedem | it feels heavyweight to have to always check this for every reboot/rebuild | 22:12 |
| cfriesen | is there a way to deal with all these scenarios generically? fundamentally I think we're talking about a mismatch between what nova thinks and what neutron thinks. | 22:12 |
| cfriesen | I agree it's not ideal, just not sure how to handle it more cleanly. | 22:12 |
| mriedem | refreshing the info cache won't help when the port bindings are wrong, we know that | 22:12 |
| cfriesen | checking reveiw | 22:12 |
| *** tssurya has quit IRC | 22:12 | |
| mriedem | the heal instance info cache periodic could be made to deal with failed port bindings and re-bind them | 22:12 |
| mriedem | we could rollback the port bindings on a failed evacaute | 22:13 |
| mriedem | *evacuate | 22:13 |
| mriedem | that's what we do on a failed live migration | 22:13 |
| cfriesen | there's nothing monitoring the evacuate though, is there? | 22:13 |
| sean-k-mooney | mriedem: oh stop/start same as reboot --hard. | 22:14 |
| mriedem | cfriesen: no, but we have try/except | 22:14 |
| mriedem | and we'd know if we're past the point of updating port bindings to point at the dest | 22:14 |
| mriedem | if we fail after that and haven't updated the instance.host, we could change the port bindings back to the source host | 22:14 |
| mriedem | i started something like that here https://review.openstack.org/#/c/588087/1/nova/compute/manager.py | 22:15 |
| mriedem | but gd it gets messy | 22:15 |
| sean-k-mooney | mriedem: we are currently only doing the multiple port binding dance for live migrate right. | 22:15 |
| mriedem | yes | 22:15 |
| sean-k-mooney | we likely should try to convege all move opperation to that flow in the future. that said we have not needed to yet so we havent | 22:17 |
| openstackgerrit | Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989 | 22:17 |
| cfriesen | what about the case where neutron loses messages, leaving the vif_type as binding_failed or unbound? | 22:18 |
| *** openstackgerrit has quit IRC | 22:19 | |
| sean-k-mooney | cfriesen: we had talked about allowing a hard reboot to try and rebind the port in that case | 22:19 |
| *** openstackgerrit has joined #openstack-nova | 22:20 | |
| mriedem | sean-k-mooney: that's what this patch does | 22:20 |
| sean-k-mooney | mriedem: oh i was still reading it. | 22:20 |
| mriedem | on every reboot it checks if the vif type is binding_failed or unbound, or if the binding:host_id doesn't match the current host and re-bindgs | 22:20 |
| mriedem | *binds | 22:20 |
| cfriesen | is there a way to detect that we're in that state without needing to do the check on every reboot/rebuild/rescue? | 22:21 |
| mriedem | cfriesen: if neutron shits the bed, that's hard to handle in any case | 22:21 |
| mriedem | since it could be anywhere | 22:21 |
| mriedem | cfriesen: well the _heal_instance_info_cache periodic could certainly do that right? | 22:21 |
| *** macza has joined #openstack-nova | 22:21 | |
| mriedem | or some sort of heal_failed_port_bindings periodic | 22:21 |
| sean-k-mooney | mriedem: i think that is what we orginially discussed as an option during the RC period | 22:21 |
| cfriesen | okay...but then you end up in a scenario where a failed instance can't be recovered until that periodic task runs | 22:22 |
| sean-k-mooney | on the patch you wrote to stop the network info cache gettin poisioned by binding faild and unbound vif types | 22:22 |
| mriedem | cfriesen: yeah i know | 22:22 |
| mriedem | all options are terrible | 22:22 |
| mriedem | and it's 5:23 | 22:22 |
| mriedem | and i want to leave | 22:23 |
| cfriesen | go. :) | 22:23 |
| *** mriedem is now known as mriedem_gone | 22:23 | |
| *** rcernin has joined #openstack-nova | 22:23 | |
| *** mriedem_gone has quit IRC | 22:24 | |
| *** macza has quit IRC | 22:25 | |
| *** openstackstatus has quit IRC | 22:28 | |
| *** openstackstatus has joined #openstack-nova | 22:29 | |
| *** ChanServ sets mode: +v openstackstatus | 22:29 | |
| *** takashin has left #openstack-nova | 22:31 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add support for generic tap device plug https://review.openstack.org/602384 | 23:00 |
| openstackgerrit | sean mooney proposed openstack/os-vif stable/rocky: add support for generic tap device plug https://review.openstack.org/609850 | 23:09 |
| *** diliprenkila has quit IRC | 23:10 | |
| openstackgerrit | sean mooney proposed openstack/os-vif stable/queens: add support for generic tap device plug https://review.openstack.org/609851 | 23:12 |
| *** owalsh has quit IRC | 23:15 | |
| *** spotz has quit IRC | 23:17 | |
| *** owalsh has joined #openstack-nova | 23:30 | |
| *** mlavalle has quit IRC | 23:30 | |
| openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | 23:40 |
| *** dpawlik has joined #openstack-nova | 23:51 | |
| *** k_mouza has joined #openstack-nova | 23:53 | |
| *** spotz has joined #openstack-nova | 23:55 | |
| *** dpawlik has quit IRC | 23:55 | |
| *** lbragstad has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!