Thursday, 2018-10-04

*** spartakos has quit IRC00:19
*** tristanC has quit IRC00:33
*** tristanC has joined #openstack-nova00:33
*** hshiina has joined #openstack-nova00:34
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7)  https://review.openstack.org/57199200:42
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8)  https://review.openstack.org/57199300:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615300:45
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.openstack.org/60395500:46
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3)  https://review.openstack.org/57410400:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4)  https://review.openstack.org/57410600:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5)  https://review.openstack.org/57411000:51
*** dave-mccowan has quit IRC00:52
*** gyee has quit IRC00:54
*** tetsuro has joined #openstack-nova01:05
*** mhen has quit IRC01:05
*** mhen has joined #openstack-nova01:06
*** mdbooth has quit IRC01:16
*** mdbooth has joined #openstack-nova01:16
*** mdbooth has quit IRC01:18
*** mdbooth has joined #openstack-nova01:19
*** mrsoul has quit IRC01:20
*** mdbooth has quit IRC01:22
*** mdbooth has joined #openstack-nova01:22
*** mdbooth has quit IRC01:25
*** mdbooth has joined #openstack-nova01:26
*** mdbooth has quit IRC01:29
*** bhagyashris has joined #openstack-nova01:29
*** mdbooth has joined #openstack-nova01:29
*** tetsuro has quit IRC01:41
*** tetsuro has joined #openstack-nova01:41
*** tbachman has quit IRC01:51
*** tetsuro has quit IRC01:51
*** takashin has quit IRC01:52
*** tetsuro has joined #openstack-nova01:55
*** hongbin has joined #openstack-nova01:55
*** Dinesh_Bhor has joined #openstack-nova01:57
*** tetsuro has quit IRC02:01
*** tetsuro has joined #openstack-nova02:03
*** mhen has quit IRC02:03
*** Dinesh_Bhor has quit IRC02:05
*** mhen has joined #openstack-nova02:07
*** cfriesen has quit IRC02:09
*** tbachman has joined #openstack-nova02:15
*** Dinesh_Bhor has joined #openstack-nova02:19
*** Bhujay has joined #openstack-nova02:24
*** takashin has joined #openstack-nova02:36
*** pooja-jadhav has joined #openstack-nova02:42
*** pooja_jadhav has quit IRC02:46
*** jding1_ has joined #openstack-nova03:00
*** ircuser-1 has quit IRC03:01
*** Bhujay has quit IRC03:03
*** jackding has quit IRC03:03
*** ircuser-1 has joined #openstack-nova03:06
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.openstack.org/60395503:09
openstackgerritMerged openstack/nova stable/ocata: Fix the help for the disk_weight_multiplier option  https://review.openstack.org/60753703:11
openstackgerritMerged openstack/nova stable/ocata: Fix host validity check for live-migration  https://review.openstack.org/59061103:11
openstackgerritMerged openstack/nova stable/queens: stable-only: fix typo in IVS related privsep method  https://review.openstack.org/60481703:11
*** udesale has joined #openstack-nova03:14
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting migrations  https://review.openstack.org/60779803:14
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Follow up "Fix up userdata argument to rebuild"  https://review.openstack.org/60780003:22
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting instance action records  https://review.openstack.org/60780103:27
*** hongbin has quit IRC03:27
*** Dinesh_Bhor has quit IRC03:30
*** takashin has quit IRC03:30
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting migrations  https://review.openstack.org/60779803:30
*** sapd1_ has quit IRC03:42
*** sapd1 has joined #openstack-nova03:42
*** takashin has joined #openstack-nova03:55
*** tetsuro has quit IRC04:06
*** pooja-jadhav has quit IRC04:14
*** kukacz has quit IRC04:14
*** kukacz has joined #openstack-nova04:16
*** pooja_jadhav has joined #openstack-nova04:16
pooja_jadhavHi team, anyone knows about the api_sample_tests in detail.. I have some doubts in it.04:36
*** Dinesh_Bhor has joined #openstack-nova04:38
*** udesale has quit IRC05:09
*** slaweq has joined #openstack-nova05:11
*** tetsuro has joined #openstack-nova05:14
*** udesale has joined #openstack-nova05:15
*** slaweq has quit IRC05:16
gmannpooja_jadhav: hi, what is doubt05:16
*** sridharg has joined #openstack-nova05:18
openstackgerritJake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows  https://review.openstack.org/55675105:39
*** udesale has quit IRC05:53
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting migrations  https://review.openstack.org/60779805:56
*** Luzi has joined #openstack-nova05:57
*** udesale has joined #openstack-nova05:58
*** ratailor has joined #openstack-nova06:06
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting instance action records  https://review.openstack.org/60780106:12
*** brinzhang has joined #openstack-nova06:15
openstackgerritOpenStack Proposal Bot proposed openstack/nova stable/rocky: Imported Translations from Zanata  https://review.openstack.org/60426006:23
pooja_jadhavgmann: hello, for the simple tenant usage api, if the instance is BFV then local_gb should not consider DISK_GB. that fix I have done. Now I am trying to add functional test for the same. and I am facing issue while creating BFV instance.06:24
pooja_jadhavgmann: In request template i am passing block_device_mappingv2 object. and its trying to cinder from nova and getting Service catelog empty error. Also checked the existing code. they have used stub.out abd CinderFixture and Its not working in my case.06:26
pooja_jadhav*trying to call cinder from nova06:29
*** moshele has joined #openstack-nova06:30
brinzhangWhen create network (https://developer.openstack.org/api-ref/compute/#create-network), What does mean of "injected" and "multi_host"?06:30
pooja_jadhavit should not consider flavor.DISK_GB06:31
*** rcernin has quit IRC06:38
gmannpooja_jadhav: api_sample_tests does not call to actual service, they are being mocked using fixture.06:38
*** moshele has quit IRC06:38
*** rcernin has joined #openstack-nova06:38
gmannpooja_jadhav: so you need to use cinder Fixture and change fixture if needed - https://github.com/openstack/nova/blob/85b36cd2f82ccd740057c1bee08fc722209604ab/nova/tests/fixtures.py#L138006:39
*** pcaruana has joined #openstack-nova06:40
gmannpooja_jadhav: same network test and other cinder test does.06:42
gmannpooja_jadhav: you can write the tempest integration test where all actual services and their behaviour is being tested. but for sample tests you can simply stub the expected things from cinder and check nova expected response/behavior06:43
*** dpawlik has joined #openstack-nova06:46
pooja_jadhavgmann: yes, same point i am able to see that, I need to use Cinder Fixture for the same. Tried same thing which is done at [1]https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_block_device_mapping_boot.py#L23-L2706:50
gmannpooja_jadhav: yeah, any error you are getting?06:51
gmannyou have patch up06:51
pooja_jadhavgmann: I have added same stubs in the https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_simple_tenant_usage.py and trying to add 4th as BFV instance.06:53
*** maciejjozefczyk has joined #openstack-nova06:54
*** sahid has joined #openstack-nova06:55
pooja_jadhavgmann: here is the error log http://paste.openstack.org/show/731449/06:55
*** sahid has quit IRC06:56
*** slaweq has joined #openstack-nova06:57
*** sahid has joined #openstack-nova06:59
*** ttsiouts has joined #openstack-nova06:59
gmannpooja_jadhav: this is going on cinder call? did you use Cinder Fixture ?07:00
gmannpooja_jadhav: if you can push your patch in gerrit (WIP though), i can take a look07:00
pooja_jadhavgmann: yes, In setup method, I have added this line : self.useFixture(nova_fixtures.CinderFixture(self))07:01
pooja_jadhav self.useFixture(nova_fixtures.CinderFixtureNewAttachFlow(self))07:01
gmannpooja_jadhav: ok, and you are just calling server create with bdmv2 right07:01
pooja_jadhavgmann: yes, right07:02
pooja_jadhavgmann: Also I checked, v2.32 and v2.42, in https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_servers.py#L189-L196 they are created BFV instances. they are working perfectly fine. Same things trying to use. but not getting success07:04
bauzasgood morning nova07:04
pooja_jadhavgmann: How to use this Cinder Fixture?? Am I using correctly in the setup method of the class where I need it ??07:06
gibimriedem, efried: I've read back on yesterday's concurrent update. I think one of the goals of the consumer gen patches to make the concurrent update visible and not overwrite allocations so I feel what mriedem saw was a result of that07:07
gibimriedem, efried: also I agree with efried that if the last patch that updates claim_resources is merged then that parallel allocation request case will stop eariler in the claim_resources when the second claim_resources call for the same consumer fails on the assumption that the consumer does not exists07:09
*** rcernin has quit IRC07:10
gmannpooja_jadhav: i think so. but somehow it is not considering it.07:11
gmannpooja_jadhav can you paste the  test_simple_tenant_usage.py  or if you can push patch up in gerrit then it is easy to debug07:12
*** bhagyashris has quit IRC07:16
*** ttsiouts has quit IRC07:16
pooja_jadhavgmann: http://paste.openstack.org/show/731450/07:22
*** helenafm has joined #openstack-nova07:25
gmannpooja_jadhav: you  do not need to use both, use CinderFixture only07:29
*** udesale has quit IRC07:30
pooja_jadhavgmann: I have trued by using used  CinderFixture only. But still no success L(07:31
pooja_jadhav:(07:31
pooja_jadhavtried*07:31
gmannpooja_jadhav: and the sample file path you changed ?07:38
pooja_jadhavgmann: I am adding sample files inside https://github.com/openstack/nova/tree/85b36cd2f82ccd740057c1bee08fc722209604ab/nova/tests/functional/api_sample_tests/api_samples/os-simple-tenant-usage/v2.4007:39
pooja_jadhavand passing use_common_server_api_samples=False to _post_server() method so that, It will get the samples from api_samples/os-simple-tenant-usage/v2.40 only.07:40
gmannpooja_jadhav: that's all you are doing perfectly07:43
pooja_jadhavgmann: yes, I will try my best for this. If anything u think I am missing something then please let me know. :)07:44
gmannpooja_jadhav: ok, but if you can push WIP patch up then it will be easy otherwise, it is difficult to debug07:46
*** hshiina has quit IRC07:47
openstackgerritBalazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup  https://review.openstack.org/60605007:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance  https://review.openstack.org/60611107:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs  https://review.openstack.org/60412507:50
*** udesale has joined #openstack-nova07:53
*** jpena|off is now known as jpena07:53
*** mvkr has quit IRC07:55
*** pcaruana has quit IRC07:55
*** mvkr has joined #openstack-nova07:57
*** pcaruana has joined #openstack-nova07:57
*** ttsiouts has joined #openstack-nova08:00
*** tssurya has joined #openstack-nova08:03
*** Dinesh_Bhor has quit IRC08:05
*** ralonsoh has joined #openstack-nova08:06
*** bhagyashris has joined #openstack-nova08:09
*** Dinesh_Bhor has joined #openstack-nova08:10
*** derekh has joined #openstack-nova08:13
openstackgerritSurya Seetharaman proposed openstack/nova master: Update --max-rows parameter description for archive_deleted_rows  https://review.openstack.org/60699508:16
*** Dinesh_Bhor has quit IRC08:21
*** Dinesh_Bhor has joined #openstack-nova08:26
*** ralonsoh has quit IRC08:30
*** Dinesh_Bhor has quit IRC08:31
*** ralonsoh has joined #openstack-nova08:37
*** Dinesh_Bhor has joined #openstack-nova08:38
openstackgerritSurya Seetharaman proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_qfd_by_cell_and_project()  https://review.openstack.org/60766308:43
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova list when a cell is down  https://review.openstack.org/56778508:43
*** panda|off is now known as panda08:44
*** udesale has quit IRC08:46
*** ttsiouts has quit IRC08:49
*** udesale has joined #openstack-nova08:49
tssuryasean-k-mooney: good morning, around ?08:55
tssuryaits about the exception handling for the scatter utility stuff we discussed yesterday, would you be modifying your existing patch or should I put a new one for the simple approach ? asking just to rebase the series08:58
*** ttsiouts has joined #openstack-nova08:59
*** sapd1 has quit IRC09:02
*** sapd1 has joined #openstack-nova09:03
*** ttsiouts has quit IRC09:04
*** ttsiouts has joined #openstack-nova09:08
gmannpooja_jadhav: seems like you need to override the nova.volume.cinder.create which is not in conderFixture09:08
gmannt i tested with that and it worked fine09:09
*** alexchadin has joined #openstack-nova09:10
*** jangutter has quit IRC09:10
*** alexchadin has quit IRC09:10
gmannpooja_jadhav: i mean stub09:12
tssuryasean-k-mooney: nvm, my bad just saw http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-10-03.log.html#t2018-10-03T19:17:2509:13
*** jangutter has joined #openstack-nova09:14
sean-k-mooneyam i am actully im just making coffee09:16
sean-k-mooneythis is around the time in normally wake up and start being online09:16
sean-k-mooneytssurya: for the simple approch we agreed to just retrun the exception by construction a new copy and leave a comment saying we are doing that because of https://www.python.org/dev/peps/pep-0344/#open-issue-garbage-collection09:18
sean-k-mooneytssurya: so expect execption e: retrun e.class(e.args)09:19
tssuryasean-k-mooney:ack thanks :) sorry for the early ping then09:19
tssuryaI was calculating 1hr from behing here09:19
tssurya1hr behind the time in CEST I mean09:20
sean-k-mooneyhaha no worries. i shift my day to give me more overlap with the us also im not a morning person :)09:20
tssuryaI'll put something up then for the spec's usecase and add you as a reviewer :)09:21
tssuryathanks again09:21
*** brinzhang has quit IRC09:25
*** s10 has joined #openstack-nova09:26
sean-k-mooneybauzas: are you online?09:29
bauzassean-k-mooney: I am, but I'll need to get my daughters in 10 mins09:33
sean-k-mooneyno worries we can chat when you get back its about vgpus09:33
bauzassean-k-mooney: ok, for what ?09:36
sean-k-mooneyi want to know how libvirt/nova detect something is a gpu09:36
sean-k-mooneyalso i have some good news for you09:37
bauzassean-k-mooney: we don't really detect whether it's a gpu09:37
bauzassean-k-mooney: we just say "heh, look, there are some pci devices that support mdevs"09:38
sean-k-mooneybauzas: mnaser: is amazing and is going to provide 1-2 vm instance with gpus for testing in the gate https://review.openstack.org/#/c/607686/09:38
bauzascool09:38
bauzasso I could write a functional test09:38
sean-k-mooneybauzas: ok that is a bug but also cool because i think i konw how to fake them in the gate also09:38
bauzassean-k-mooney: what's a bug ?09:38
bauzasto say a pci device supporting mdevs is a gpu ?09:39
sean-k-mooneynic and acclerator can expose mdevs09:39
bauzassure, but we have a spec fixing this09:39
bauzassean-k-mooney: in this spec, you explicitly say which PCI IDs *are* GPUs09:40
bauzassean-k-mooney: https://review.openstack.org/#/c/602474/09:40
bauzasI need to go, bbiabn09:40
sean-k-mooneybauzas: cool that will work for the terible hack i want to do. ill let you know when you get back09:40
*** Bhujay has joined #openstack-nova09:48
*** priteau has joined #openstack-nova09:49
*** bhagyashris has quit IRC09:50
gmannpooja_jadhav: hope that worked.09:51
*** mdbooth has joined #openstack-nova09:51
*** alexchadin has joined #openstack-nova09:53
*** dtantsur|afk is now known as dtantsur09:55
*** mdbooth_ has joined #openstack-nova09:57
*** moshele has joined #openstack-nova09:59
*** mdbooth has quit IRC09:59
*** alexchadin has quit IRC10:02
*** udesale has quit IRC10:04
*** mdbooth has joined #openstack-nova10:04
*** alexchadin has joined #openstack-nova10:05
*** Bhujay has quit IRC10:06
*** mdbooth_ has quit IRC10:07
*** mdbooth_ has joined #openstack-nova10:07
*** Dinesh_Bhor has quit IRC10:08
*** mdbooth has quit IRC10:10
bauzassean-k-mooney: just able to discuss for 5 mins10:12
bauzassean-k-mooney: but also, without the spec, it also only works for GPU devices10:12
bauzassean-k-mooney: because libvirt provides us all the mdev capable devices, but we look at which supports the provided GPU type10:12
bauzassay 'nvidia-11'10:12
bauzasso, in case you have mdev capable devices that are not GPU devices (say a nic one), they don't support the type10:13
*** mdbooth has joined #openstack-nova10:13
bauzasso we don't use them10:13
*** udesale has joined #openstack-nova10:13
bauzasalso, say you have an Intel GPU not supporting the 'nvidia-11' type, then we don't have inventory for it too10:14
sean-k-mooneyok so your assumeing good nameing of the mdev types without the spec10:15
sean-k-mooneye.g. not small medium large10:15
*** mdbooth_ has quit IRC10:15
sean-k-mooneybut ya i think that is fine10:15
sean-k-mooneybasically i found out that in kernel 4.16 there is a new driver called netdevsim that simulates a nic10:15
sean-k-mooneyit supprots sriov without any hardware and mdevs10:16
sean-k-mooneyso i think i can use it to test pci passhtrouhg, sriov, and other things in the gate10:16
sean-k-mooneyi also may be able to use the mdev support to pretend to be a vgpu10:17
*** mdbooth_ has joined #openstack-nova10:17
sean-k-mooneynot sure about the last point but i was planning to look into it more for sriov testing10:17
*** mdbooth has quit IRC10:17
*** alexchadin has quit IRC10:19
*** ttsiouts has quit IRC10:21
*** Dinesh_Bhor has joined #openstack-nova10:21
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Move the evacuate action to admin action  https://review.openstack.org/60789610:22
*** ttsiouts has joined #openstack-nova10:31
*** slaweq_ has joined #openstack-nova10:38
*** udesale has quit IRC10:39
*** alexchadin has joined #openstack-nova10:39
*** udesale has joined #openstack-nova10:40
*** slaweq has quit IRC10:40
*** tbachman has quit IRC10:44
*** erlon has joined #openstack-nova10:49
*** slaweq__ has joined #openstack-nova10:56
*** slaweq_ has quit IRC10:57
*** pcaruana has quit IRC11:02
*** pcaruana has joined #openstack-nova11:02
*** vivsoni has quit IRC11:03
*** jpena is now known as jpena|lunch11:03
*** janki has joined #openstack-nova11:06
*** mdbooth_ has quit IRC11:13
*** cdent has joined #openstack-nova11:14
*** mdbooth has joined #openstack-nova11:14
*** Dinesh_Bhor has quit IRC11:17
*** alexchadin has quit IRC11:24
*** ttsiouts has quit IRC11:32
openstackgerritBalazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources  https://review.openstack.org/58366711:46
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler  https://review.openstack.org/58567211:46
openstackgerritBalazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver  https://review.openstack.org/60408311:46
gibijaypipes, efried: I replied in https://review.openstack.org/583667 for both of you fixed your comments. The runway slot for this patch ends today so I appreciate any feedback11:49
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP] Refactor scatter-gather utility to return exception objects  https://review.openstack.org/60793411:49
*** slagle has quit IRC11:51
jaypipesgibi: yup, on it.11:52
gibijaypipes: thanks a lot11:52
bauzassean-k-mooney: back there11:54
bauzassean-k-mooney: if you wanna continue to discuss...11:54
bauzasgibi: don't worry about the runway slot, now that I'm done with the reshaper change, your series is my top prio11:54
gibibauzas: cool, thanks11:55
bauzasgibi: so, the above means that I can review it, right?11:55
gibibauzas: it means that tha last patch of consumer gen is updated with fixes based on jaypipes and efried comments, there are patches top of that that also up to date til https://review.openstack.org/604083 I'm fixing comment in the rest as we speak11:56
bauzasgibi: okay, will look later today11:56
bauzasgibi: FWIW I have a machine with GPU devices so I can test most of your series11:57
gibibauzas: sounds cool :)11:57
gibibauzas: so far I relied on functional test cases. Fortunately the resource allocation handling these patches change are possible to cover with functional11:58
gibibauzas: the physical consumpton of VGPUs are something where my functional test case wont be enough11:59
sean-k-mooneyjaypipes: bauzas gibi so in case you missed it earlier i think i figured out a way to test pci passthough, sriov, and some other things like livemigration with the same in the gate using the netdevsim kernel module11:59
gibisean-k-mooney: that is really good news!11:59
bauzasgibi: I mean, I could just test your series with my reshape change11:59
bauzasgibi: so that I could be sure we would be able to boot a flavor asking for VGPUs12:00
bauzas(in a nested worldà12:00
sean-k-mooneyi also think that can be hacked to pretend to be vgpus i need to investgate that futher12:00
gibibauzas: yeah allocate, then rehape, then allocate again is something that needs coverage12:00
bauzasgibi: I tested all of that with my single change12:00
gibibauzas: cool12:00
bauzasgibi: but of course the boot failed12:00
bauzasgibi: since I wasn't using your series12:01
bauzaswhat I could do is just to pick your series, and do the same12:01
gibibauzas: I assume it will work with my series included12:01
bauzasgibi: that's my assumption too12:01
bauzasand the functional test shows it12:01
bauzasbut a real evidence is better, I guess12:01
gibibauzas: totally agree12:01
bauzassean-k-mooney: WDYM by netdevsim module ?12:02
sean-k-mooneyit is a kernel module adding in kernel 4.16 specifcally to allow testing of hardware offloads without hardwar12:02
jaypipessean-k-mooney: you'll excuse my skepticism until I see a real functional test of those items :)12:02
sean-k-mooneybauzas: it allows you to create pci device that support mdevs and sriov12:03
bauzassean-k-mooney: but it requires 4.16, right?12:03
sean-k-mooneyand it support ebpf too12:03
sean-k-mooneyyep so a fedora 28 job12:03
bauzaswhich could be a problem12:03
jaypipessean-k-mooney: that said, I'm still supportive of this netdevsim effort. ANYTHING is better than what we have now, which is pretty much nothing.12:03
sean-k-mooneyfedora comes with 4.1712:03
*** jpena|lunch is now known as jpena12:04
*** tetsuro has quit IRC12:04
bauzassean-k-mooney: but bionic comes with 4.15 https://packages.ubuntu.com/bionic/linux-image-generic12:04
bauzasso it wouldn't be a classic upstream gate job12:04
sean-k-mooneyjaypipes: ya i just learned about it yesterday so still doing reasarch but since i plan on working on sirov livemigration this cycle i would like to try to create an experimental job with this moduel to test it12:05
bauzassean-k-mooney: I was also considering the use of fake libvirt12:05
sean-k-mooneybauzas: we have fedroa 28 images avaliable in the upstream gate for testing12:05
bauzascouldn't that be simplier ?12:05
sean-k-mooneybauzas: it could be this would allow tempest testing not just  functional12:05
bauzassean-k-mooney: for SR-IOV it could be interesting12:06
bauzassean-k-mooney: for VGPU, I just feel it's unnecessary thru tempest12:06
bauzasa functional test in-tree is better IMO12:06
sean-k-mooneyyep it also support things like configring rate limiting on the vf and trusted vfs12:07
bauzassean-k-mooney: just to make it clear, I was considering use of https://libvirt.org/drvtest.html12:07
*** ttsiouts has joined #openstack-nova12:07
*** vivsoni has joined #openstack-nova12:07
*** med_ has joined #openstack-nova12:08
sean-k-mooneyok but i doubt that will support the featue we want to test12:08
sean-k-mooneyon testing with real hardware there is also this change https://review.openstack.org/#/c/607686/ :)12:09
jaypipessean-k-mooney: isn't artom working on that as well? (sriov live migration...)12:09
jaypipessean-k-mooney: or is artom focused on NUMA stuffs?12:09
sean-k-mooneyjaypipes: artom is working on numa12:09
jaypipesah, gotcha12:09
sean-k-mooneyim goning to do the sriov part12:09
jaypipessean-k-mooney: you're both brave men.12:10
sean-k-mooneyor dumb12:10
jaypipessean-k-mooney: I wouldn't touch that stuff with a ten foot pole.12:10
*** erlon has quit IRC12:10
jaypipessean-k-mooney: the closest I'll get is doing some reviews for ya ;)12:10
sean-k-mooneywell i keep finding bugs in livemigration that i have to fix first related to the multiple port bindings on both the  nova and neutron sides12:11
*** mdbooth has quit IRC12:11
sean-k-mooneyso first im going to try and fix all those bugs then sriov live migration. i think neutron forgot to update teh sriovnic agent and driver to support multiple port binding so i have to fix that first12:12
artomjaypipes, since you mentioned it, review pretty please https://review.openstack.org/#/c/599587/ ? ;)12:13
artomBut yeah, there's going to be some overlap/cooperation12:14
artomAlso, the mellanox guys were interested in SRIOV live migration, not sure what happened with that12:14
sean-k-mooneyartom: i talked to moshele last week. ill try and work with them if they want to help.12:14
artomsean-k-mooney, ah, cool12:15
sean-k-mooneyartom: moshele said someone on his team was working on a poc12:15
artomHrmm, I thought they were going to propose a spec first?12:15
sean-k-mooneywell i already wrote one12:15
sean-k-mooneyartom: https://review.openstack.org/#/c/605116/12:15
artomsean-k-mooney, thanks, was about to ask12:16
*** tbachman has joined #openstack-nova12:17
sean-k-mooneyjaypipes: bauzas gibi sorry your conversation got a little derailed by that but i think using the new vexhost physical gpu nodes in an experimental job would also be very valueable for testing both reshaper stuff and vgpus12:19
jaypipessean-k-mooney: but that would require us having to talk to mnaser and we ALL know that's not a good idea!12:20
jaypipesartom: queued that up behind the gibster.12:21
jaypipesgibi: OK, so... question on your response about the microversion 1.29 thing in https://review.openstack.org/#/c/583667/25/nova/scheduler/client/report.py...12:21
sean-k-mooneyjaypipes: :) well you could ignore him and just submit jobs when https://review.openstack.org/#/c/607686/ is merged12:22
gibijaypipes: looking..12:23
jaypipesgibi: what is API 1.29 changing about GET /a_c's return?12:23
jaypipesgibi: you mention this: "So by supporting nested a_c we implicitly force nova to at least support 1.29 >= in claim_resources too."12:23
jaypipesgibi: but I'm wondering what changes in the allocation_request part of the a_c response to warrant a change in this code.12:23
sean-k-mooneyjaypipes: isnt 1.29 the microverion that adds nested allocation candiates?12:24
jaypipessean-k-mooney: but it's not "nested allocation candidates" really... the allocation request part of the response is still just a flat list of providers and the resource amounts being consumed from each.12:24
jaypipesor at least, that's what I thought...12:25
sean-k-mooneyjaypipes: you are  proably right i just have a vague recolection from the demo at the ptg that there was a reson this microverion was need for nested allocations12:25
*** mrch_ has joined #openstack-nova12:26
gibijaypipes: technicall the allocations structure is unchanged in 1.29 but handling the fact that now more than one RP can be in an allocation candidate needs code change in multiple places in nova. Some of them is trivially missed in first patch that enables nested a_c in nova hence the expectedFailures in the functional test12:27
*** mdbooth has joined #openstack-nova12:27
gibijaypipes: for example nova assumes that deleting an instance allocation from a compute is as easy as deleting the allocation from the compute RP12:28
sean-k-mooneygibi: if the allocation candiates are a flat list as jaypipes says above is the provider topology captured in the summery?12:28
gibisean-k-mooney: yes, parent_rp_uuid is in the summary part12:29
gibis/parent_rp_uuid/parent_provider_uuid12:29
jaypipessean-k-mooney: yeah, it's in the provider_summaries part of the response, not the allocation_requests part of the response, which is what I was alluding to above.12:29
*** erlon has joined #openstack-nova12:29
sean-k-mooneyso in the delete case nova now needs to delete the allocation from all resouce providers in the list instead of just one delete12:29
jaypipessean-k-mooney, gibi: and we don't pass the provider_summaries response to the claim_resources() method (only the allocation_request part) which is why I was asking about that comment from gibi on the claim_resources() patch.12:30
*** mdbooth_ has joined #openstack-nova12:30
gibisean-k-mooney: exactly. It is implemented in https://review.openstack.org/#/c/606050/12:30
sean-k-mooneyi assume there is no api to say delete all allocation for this consumer uuid?12:30
jaypipessean-k-mooney: there is, yes.12:30
cdent2 even12:30
jaypipescdent: touche :)12:31
sean-k-mooneyso in that case for a delete cant nova just do that and pass the instance uuid?12:31
gibisean-k-mooney: it is complicated if the consumer has allocations on other computes as well12:31
gibisean-k-mooney: and it is the case for evacuate :/12:31
jaypipessean-k-mooney: sure it can. the issue is edge cases... gibi's func test patch outlines those cases well. lemme grab you a link.12:31
gibijaypipes: I think I'm failing to grasp what is exactly your suggestion for claim_resources() call12:32
mrch_https://bugs.launchpad.net/nova/+bug/1763043  ( Instance not resizing, skipping migration.) well its not unnecessary because 70% of them have locked nova/cinder disk, got around a dozend of them any ideas, excetp "rbd lock remove" till the end of my life?12:32
openstackLaunchpad bug 1763043 in OpenStack Compute (nova) "Unnecessary "Instance not resizing, skipping migration" warning in n-cpu logs during live migration" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)12:32
sean-k-mooneygibi: for evacuate would we not use a migration uuid to hold the dest allocations and then not delete the source allocation and swap it over like we do for cold migrate?12:32
gibisean-k-mooney: that would be ideal, but does not happen today12:33
jaypipessean-k-mooney: see very bottom of this file: https://review.openstack.org/#/c/604084/3/nova/tests/functional/test_servers.py12:33
sean-k-mooneyim really not familar enough with this code unfortuenetly12:33
gibisean-k-mooney: I have a todo from the PTG to improve that as well12:33
*** mdbooth has quit IRC12:33
jaypipessean-k-mooney: those tests and comments from gibi highlight well the issue.12:33
jaypipesissues...12:33
* jaypipes shakes fist at the Gods of Evacuate.12:34
bauzasjaypipes: flush the toilets12:35
sean-k-mooney jaypipes i have no doubt gibi has reasoned about this and the edgecase far better then i :) espcially since i jsut stared looking at the patch but ya just providing my assumtions in case that help with any that might have been made :) my assumetion of how this should work likely diverge hevily form how it does12:35
gibijaypipes: there is stuctural change between 1.12-1.28 but there is no strucutral change when we step from 1.28 to 1.29 in a_c but I don't know what you want to suggest12:36
jaypipesgibi: I was questioning the need to "pin" the claim_resources() API microversion to 1.29 since there was no change to the allocation_request part of the a_c response.12:37
gibijaypipes: sure claim_resources can work with 1.28 even if a_c used 1.29. I think we are not even bumping claim_resources to 1.29 when we bump a_c to 1.2912:39
gibijaypipes: this path bumps a_c to 1.29 https://review.openstack.org/#/c/585672 but not the claim_resources12:39
jaypipesgibi: k, cool.12:41
jaypipesgibi: again, I was just responding to your comments on https://review.openstack.org/#/c/583667/25/nova/scheduler/client/report.py where you said this:12:41
jaypipes"Therefore scheduler passes down >= 1.29 when calling claim_resources with the selected allocation candidate. So by supporting nested a_c we implicitly force nova to at least support 1.29 >= in claim_resources too. "12:41
jaypipesgibi: but, no worries, I'll stop bothering you and get back to reviewing the last revision in that patch :)12:42
gibijaypipes: so you suggets to drop the logic that passes version from a_c to claim_resources?12:42
jaypipesgibi: yeah, might be useful...12:42
gibijaypipes: that logic is the one that forces claim_resources to adapt to 1.2912:42
jaypipesgibi: since technically there's nothing about 1.29 that affects claim_resources.12:43
jaypipesgibi: and the allocation_request_version that gets passed to claim_resources() is all about the structure of the allocation_request part of the payload.12:43
jaypipesgibi: but it's really not a huge deal :)12:43
gibijaypipes: jeah for 1.29 we don't need that but for the bump of 1.12 - 1.28 we need to know that the a_c was used with 1.2812:44
jaypipesgibi: like I said, I'll go back to my last revision review :)12:44
gibijaypipes: I let you review :)12:44
jaypipesgibi: elnézést a zavarásért!12:44
* jaypipes hopes that is even remotely correct...12:45
jaypipesI imagine gibi laughing at Google Translate's poor translation12:45
gibijaypipes: what was the English expression you translated?12:45
gibi:)12:46
jaypipes"Sorry to bother"12:46
jaypipeslol12:46
jaypipeswhat does it mean? :)12:46
jaypipes"Happy cows love coding" or something wacky like that?12:46
*** slagle has joined #openstack-nova12:47
gibino it is not that far12:47
* gibi is now strugling to define the difference he feels12:48
gibijaypipes: what you used is more for the case when you want to approach a stranger, e.g. as a first sentence before you ask for direction12:50
gibiso it is super polite12:51
gibibut yeah you basically asked for forgiveness for the interruption12:51
gibiso the intention is clear12:52
* gibi wonders if google improved the hungarian translation a lot lately12:52
jaypipeshehe12:54
*** moshele has quit IRC12:56
*** med_ has quit IRC12:57
bauzasjaypipes: gibi: https://www.duolingo.com/course/hu/en/12:58
bauzasI did that for German \o/12:58
bauzasund jetzt I spreche Deutch12:59
bauzasIch*12:59
sean-k-mooneybauzas: if you ever want to lean a languge that no one will under stand they have an irish course too13:00
*** mvkr has quit IRC13:02
bauzassean-k-mooney: I saw this13:03
bauzasthere is also High Valeryan and Klingon13:03
sean-k-mooneybauzas: both are  proably more useful then irish that said it was nice to have a language you could use to gossip about people abroad on school trips lol only use of irish i have ever had13:06
efriedjetzt spreche ich <== with an adjective in the mix, you put the verb before the subject. Or something.13:07
efriedor whatever "jetzt" is, not an adjective13:07
*** ratailor has quit IRC13:21
*** slagle has quit IRC13:22
jaypipesgibi: +2 from me on claim_resources(). I will let efried or mriedem +W.13:22
gibijaypipes: thanks a lot. efried had a bunch of comments so I feel he is the one who can +W it13:22
*** erlon_ has joined #openstack-nova13:25
*** tetsuro has joined #openstack-nova13:25
*** erlon has quit IRC13:29
*** mvkr has joined #openstack-nova13:30
*** spatel has joined #openstack-nova13:30
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor allocation checking in functional tests  https://review.openstack.org/60728713:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources  https://review.openstack.org/60408413:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore forcing of live migration for nested instance  https://review.openstack.org/60578513:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup  https://review.openstack.org/60605013:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance  https://review.openstack.org/60611113:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs  https://review.openstack.org/60412513:31
gibibauzas: FYI, the nested series now up to date all the way to the top https://review.openstack.org/#/c/604125/13:33
*** slaweq__ is now known as slaweq13:36
*** slagle has joined #openstack-nova13:41
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP] Refactor scatter-gather utility to return exception objects  https://review.openstack.org/60793413:43
*** eharney has joined #openstack-nova13:43
*** mchlumsky has joined #openstack-nova13:45
*** spatel has quit IRC13:47
*** dpawlik has quit IRC13:47
*** pcaruana has quit IRC13:50
openstackgerritJack Ding proposed openstack/nova master: Handle missing marker during online data migration  https://review.openstack.org/60516413:50
*** oanson has quit IRC13:51
*** alexchadin has joined #openstack-nova13:56
*** alexchadin has quit IRC13:56
*** munimeha1 has joined #openstack-nova13:58
*** tbachman has quit IRC13:58
*** alexchadin has joined #openstack-nova13:58
*** tbachman_ has joined #openstack-nova13:58
*** tbachman_ has quit IRC13:58
*** priteau has quit IRC13:58
*** priteau has joined #openstack-nova13:59
dansmithdid I miss that the meeting this week was canceled or something?14:02
gibidansmith: I think I did not get a request from melwitt to chair it but I can14:03
dansmithmeh14:03
gmannnot sure. I was also checking meeting channel14:03
efriedwe have an important topic to discuss, HPET for libvirt.14:03
bauzashah, I just asked the question in -meeting14:03
efriedthey're expecting it.14:03
bauzasefried: and what about HCATTLE ?14:03
efriedoy vay14:03
sean-k-mooneyefried: so #openstack-meeting time i guess14:04
efriedyup14:04
*** munimeha1 has quit IRC14:05
*** awaugama has joined #openstack-nova14:06
*** hamzy has quit IRC14:10
mrch_can i prevent the nova.compute.resource_tracker spaming this: nova.compute.resource_tracker [req-e23cf459-506f-42d3-ac5d-73d87b1e5ba9 - - - - -] [instance: 8ecbbdb1-bad7-434b-8d09-265964ca9c7e] Instance not resizing, skipping migration. when 5 hosts spam this about one an the same vm, an i got 10 vms of that kind, its annoying as f14:11
efriedmrch_: We're in the nova meeting atm; can you ask again at the top of the hour?14:12
efriedIt looks like this is happening because you have some stale migrations in the database; can you clean those up?14:13
*** awaugama has quit IRC14:14
*** awaugama has joined #openstack-nova14:15
*** mlavalle has joined #openstack-nova14:15
mrch_efried14:15
mrch_efried: shure14:15
*** jaosorior has quit IRC14:16
*** tbachman has joined #openstack-nova14:16
mrch_efried14:18
mrch_efried: concidering db, but i cant wait, i stay in chat just write ill see it tomorrow14:18
efriedmrch_: Okay. I personally don't know how to clean up the db, but hopefully one of the wizards can advise once the meeting is over.14:18
*** munimeha1_ has joined #openstack-nova14:21
*** mdbooth_ is now known as mdbooth14:23
*** Bhujay has joined #openstack-nova14:28
*** s10_ has joined #openstack-nova14:28
*** spatel has joined #openstack-nova14:28
*** cfriesen has joined #openstack-nova14:30
*** s10 has quit IRC14:30
*** pooja_jadhav has quit IRC14:30
*** kukacz has quit IRC14:30
*** kukacz has joined #openstack-nova14:30
*** pooja_jadhav has joined #openstack-nova14:31
*** liuyulong has joined #openstack-nova14:34
*** hamzy has joined #openstack-nova14:45
*** maciejjozefczyk has quit IRC14:46
*** med_ has joined #openstack-nova14:48
*** itlinux has quit IRC14:48
*** jchhatbar has joined #openstack-nova14:50
*** cdent has quit IRC14:53
*** janki has quit IRC14:53
*** med_ has quit IRC14:54
melwittgibi: thank you for running the nova meeting, it completely slipped my mind this time. apologies14:58
gibimelwitt: no worries15:00
*** Swami has joined #openstack-nova15:00
mheno/15:00
* mhen would like to briefly discuss a topic since time in meeting ran out15:00
mrch_can i prevent the nova.compute.resource_tracker spaming this: nova.compute.resource_tracker [req-e23cf459-506f-42d3-ac5d-73d87b1e5ba9 - - - - -] [instance: 8ecbbdb1-bad7-434b-8d09-265964ca9c7e] Instance not resizing, skipping migration. when 5 hosts spam this about one an the same vm, an i got 10 vms of that kind, its annoying as f15:01
*** takashin has left #openstack-nova15:01
mhenas already mentioned in the ML we want to propose the introduction of image encryption in OpenStack15:02
mhen#link ML thread on proposal for image encryption http://lists.openstack.org/pipermail/openstack-dev/2018-September/135167.html15:02
mhenas advised on the ML, we are currently writing individual specs for the components involved, including Nova15:02
mhenin Nova we would like to add the decryption of images, which are converted into servers using ephemeral storage and the encryption of images created from such servers15:03
mhenat first we want to focus on LibVirt and its LVM backend, because it is the only backend for encrypted ephemeral storage in LibVirt (ignoring the ineffectiveness of the encryption due to missing native LUKS support for now)15:03
*** cdent has joined #openstack-nova15:03
mhenwe would be interested in Nova's opinion on whether the conversion from encrypted image to unencrypted ephemeral storage should be allowed15:03
mhenwe don't really like the idea of exposing the image data this way but the Cinder team suggested making this optional for the similarly natured volume use case15:03
efriedjaypipes: Because then the libvirt driver would have to use that (HPET=required) as its cue to turn HPET on in the guest. I.e. using a trait to effect configuration.15:04
efriedjaypipes: I'm writing up the alternatives with their respective cons; stay tuned.15:05
cfriesensean-k-mooney: if we ever wanted to support passthrough of host TPM, then there really would be a finite inventory15:05
cfriesensean-k-mooney: for emulated TPM we could make it a trait if the host supports it15:06
cfriesensean-k-mooney: if we ever wanted to support both emulated and passthrough TPM, what would the placement side look like?  would that be two resource providers, one with the "emulated" trait and one with the "real" trait?15:08
jaypipesmrch_: why would 5 hosts be spamming that same message? does that mean you have the same instance stuck in a migration to multiple hosts?15:09
jaypipescfriesen: and that's the problem with embedding key/value things into a trait string...15:09
*** s10_ has quit IRC15:09
cfriesenjaypipes: maybe no traits are needed....in a sense this would be equivalent to VCPU vs PCPU15:10
cfriesenso maybe it's just two separate resource providers15:11
*** mrch_ has quit IRC15:11
*** ttsiouts has quit IRC15:11
*** mrch_ has joined #openstack-nova15:13
jaypipescfriesen: ack15:13
*** mrch_ has quit IRC15:20
*** jding1_ is now known as jackding15:23
spatelQuick question, i am creating SR-IOV instance and in order to do that i need to create neutron port first. i have created bunch of port during testing but now i need to find out which neutron port is active and non-active how do i find that out?15:23
*** mdbooth has quit IRC15:24
spatelsean-k-mooney: morning15:24
openstackgerritEric Fried proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests  https://review.openstack.org/60798915:24
*** mdbooth has joined #openstack-nova15:24
efriedsean-k-mooney, cdent, jaypipes, cfriesen, dansmith, bauzas, gibi: ^15:24
cdentnoted15:24
*** Luzi has quit IRC15:25
*** slagle has quit IRC15:25
*** macza has joined #openstack-nova15:25
dansmithjaypipes: you around for a hangout in 35 minutes on this hpet thing?15:25
*** mdbooth has quit IRC15:27
*** mdbooth has joined #openstack-nova15:28
*** mdbooth has quit IRC15:28
*** mdbooth has joined #openstack-nova15:29
*** mdbooth has quit IRC15:32
*** mdbooth_ has joined #openstack-nova15:32
cfriesenefried: got it. thanks for writing this up15:32
jaypipesdansmith: unfortunately, no. I would be available in about 1.75 hours though15:36
*** udesale has quit IRC15:36
dansmithefried: cfriesen cdent bauzas gibi ^ ?15:36
bauzassorry I'm trapped in a meeting, trying to catch up15:37
bauzasah15:37
bauzasI'm fine with meeting us later15:37
efriedI can't make it then :(15:37
bauzasthe best for me is after 8pm UTC15:37
cdentdansmith: I will have to pass, but I trust the combo of people involved to work out something sane, especially since you were able to identify what is sacred to me (and remains so)(15:37
dansmithheh okay15:37
efried8pm UTC would wfm15:38
jaypipesthat works for me too15:38
cfriesenso a little over 4hrs from now?15:38
efriedyes15:39
cfriesenworks for me15:39
cfriesenI've never done one of the hangouts....does someone post a URL or send out invites or what?15:40
dansmithurl15:40
jackdingI will have to pass.15:41
efriedcfriesen: dansmith will drop a URL in here, ping all of us, and get spanked by Sigyn15:41
cfriesenI'll cover for jack15:41
*** hamzy_ has joined #openstack-nova15:42
*** hamzy has quit IRC15:44
*** mdbooth_ has quit IRC15:46
*** jchhatbar has quit IRC15:46
*** liuyulong has quit IRC15:51
*** Bhujay has quit IRC15:55
*** itlinux has joined #openstack-nova15:57
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova show when a cell is down  https://review.openstack.org/59165815:58
*** gyee has joined #openstack-nova16:00
efriedgibi: You still around?16:02
gibiefried: yeah for about 10 minutes16:02
gibiefried: but go ahead16:02
efriedokay, that may not be enough. I wanted to walk through the allocation_request_version nonsense a bit.16:03
*** helenafm has quit IRC16:03
gibiefried: even if we figure out that we want to drop allocation_request_version I would like to do that separately as that a surgery again16:03
efriedit's just, I see it as being pretty much unnecessary/unrelated to this patch.16:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore forcing of live migration for nested instance  https://review.openstack.org/60578516:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup  https://review.openstack.org/60605016:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance  https://review.openstack.org/60611116:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs  https://review.openstack.org/60412516:04
efriedI guess that alone isn't worth holding it up since jay is +2 at this point.16:04
efriedAnd I guess I do see that it becomes necessary again for nested.16:04
efriedit's just a weird transition.16:04
gibiefried: totally agree that allocation_request_version is strange but I'm not 100% sure we simply drop it and fix the version in the report client globally16:06
efriedgibi: IIUC, it's necessary whenever there's a possibility of the conductor and the scheduler being at different versions.16:06
efried...versions of nova, leading to them being aware of different versions of placement. Placement ought to always be at least up to date with the later of the two.16:07
*** mdbooth has joined #openstack-nova16:08
efriedI assume that's still a possible scenario, for like rolling upgrades or whatever.16:08
gibiefried: I'm not sure we support that scheduler and conductor on different version. What complicates it is that we send alternates around in RPC messages for reschedule16:08
efriedI'm guessing there's a rule/guideline, like you have to upgrade the computes before the scheduler, or vice versa? dansmith do you know that answer?16:08
gibiefried: controller first is the ruel16:09
gibirule16:09
gibibut I think controller services needs to be updated at once but I'm not sure16:09
gibiI have to run now. talk to you tomorrow16:09
efriedthx gibi16:10
gibiefried: thank you16:10
*** dtantsur is now known as dtantsur|afk16:10
openstackgerritMerged openstack/nova master: Skip test_parallel_evacuate_with_server_group until fixed  https://review.openstack.org/60762016:13
openstackgerritJack Ding proposed openstack/nova master: Handle missing marker during online data migration  https://review.openstack.org/60516416:13
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down  https://review.openstack.org/58482916:17
*** slagle has joined #openstack-nova16:20
dansmithefried: control services first and together, computes last and in any order you want16:23
efrieddansmith: Okay, so the reason for allocation_request_version is in case computes are currently downlevel from controller and/or each other. Thanks.16:23
openstackgerritJack Ding proposed openstack/nova master: Add HPET timer support for x86 guests  https://review.openstack.org/60590216:24
dansmithefried: yeah16:24
bauzasefried: https://docs.openstack.org/nova/latest/user/upgrade.html16:24
bauzasHTH16:24
bauzasanyway, calling it a day16:25
bauzasdo we have some hangout at 8pm UTC so ? if so, efried, could you please ping me on IRC ?16:25
efriedbauzas: Yes, dansmith or I will ping you.16:25
bauzascool cool16:26
bauzassee you later then.16:26
efriedl8r16:26
efriedor "bis später" :)16:26
bauzasheh, I won't finally have opportunity to speak German this year, but okay16:26
*** Bhujay has joined #openstack-nova16:34
*** alexchadin has quit IRC16:34
*** dosaboy has quit IRC16:39
openstackgerritGaudenz Steinlin proposed openstack/nova master: Ignore misleading resource updates from virt driver  https://review.openstack.org/52300616:41
*** dosaboy has joined #openstack-nova16:45
openstackgerritmelanie witt proposed openstack/nova master: Use nova-consoleauth only if workaround enabled  https://review.openstack.org/60706816:48
openstackgerritmelanie witt proposed openstack/nova master: Use nova-consoleauth only if workaround enabled  https://review.openstack.org/60706816:52
*** moshele has joined #openstack-nova16:53
*** sahid has quit IRC16:54
*** dosaboy has quit IRC16:55
*** Bhujay has quit IRC17:01
*** dosaboy has joined #openstack-nova17:01
*** derekh has quit IRC17:04
sean-k-mooneydansmith: did ye have that hangout on hpet extraspec vs trait vs both ?17:04
dansmithsean-k-mooney: in two hours17:04
sean-k-mooneyoh ok cool in that case i have time to read the specs properly17:05
efrieddansmith: three hours?17:10
dansmithefried: 2000 UTC is 1200 PDT no?17:10
dansmithoh sorry, I was looking at dublin time17:11
dansmithyeah three hours17:11
sean-k-mooneyya dublin is currently on irish summer time17:12
sean-k-mooneyhopefully daylight saving will no longer be a thing soon17:12
openstackgerritMerged openstack/nova stable/ocata: nova-manage - fix online_data_migrations counts  https://review.openstack.org/60584217:14
*** pcaruana has joined #openstack-nova17:17
*** mvkr has quit IRC17:20
*** jpena is now known as jpena|off17:21
*** sridharg has quit IRC17:22
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion bump for handling-down-cell  https://review.openstack.org/59165717:29
*** Bhujay has joined #openstack-nova17:30
*** Swami has quit IRC17:36
openstackgerritMerged openstack/nova master: Add attach kwarg to base/nova-net allocate_for_instance methods  https://review.openstack.org/60546417:41
openstackgerritmelanie witt proposed openstack/nova master: De-dupe subnet IDs when calling neutron /subnets API  https://review.openstack.org/60804017:43
*** tbachman has quit IRC17:44
*** tssurya has quit IRC17:48
*** tbachman has joined #openstack-nova17:57
*** pcaruana has quit IRC18:01
*** munimeha1_ has quit IRC18:01
*** tbachman has quit IRC18:03
*** Swami has joined #openstack-nova18:04
*** tbachman has joined #openstack-nova18:05
openstackgerritmelanie witt proposed openstack/nova master: De-dupe subnet IDs when calling neutron /subnets API  https://review.openstack.org/60804018:06
*** mvkr has joined #openstack-nova18:09
openstackgerritMerged openstack/nova master: consumer gen: support claim_resources  https://review.openstack.org/58366718:11
*** mrch_ has joined #openstack-nova18:13
*** Bhujay has quit IRC18:20
*** imacdonn has quit IRC18:22
*** imacdonn has joined #openstack-nova18:22
openstackgerritVlad Gusev proposed openstack/nova master: Not set instance to ERROR if set_admin_password failed  https://review.openstack.org/55516018:25
*** macza has quit IRC18:25
*** macza has joined #openstack-nova18:26
*** s10 has joined #openstack-nova18:34
*** mriedem has joined #openstack-nova18:34
*** tssurya has joined #openstack-nova18:36
*** moshele has quit IRC18:36
jaypipesmelwitt, dansmith, other stable cores... https://review.openstack.org/#/c/607626/ would be great to review. thanks in advance.18:38
*** cdent has quit IRC18:39
s10Please approve back ports for https://review.openstack.org/#/q/I27160140cbccf3e6914aed2dcff54d547e446c1f and https://review.openstack.org/#/q/topic:bug/1785827+(status:open+OR+status:merged)18:40
*** tbachman has quit IRC18:41
melwittjaypipes: +W18:46
melwittmriedem: this backport just needs an upgrade of your +1 to a +2/+W https://review.openstack.org/59233718:52
*** ralonsoh has quit IRC18:52
jaypipesmelwitt: danke18:59
*** tbachman has joined #openstack-nova18:59
jaypipesefried: left a question/thought for you on https://review.openstack.org/#/c/605902/18:59
* efried clicks19:00
efriedjaypipes: For the sake of keeping things together, perhaps we should have that discussion on the spec.19:01
jaypipesefried: or the hangout later...19:02
efriedjaypipes: I agree it makes sense to allow the trait to be in the image. Not sure that means we shouldn't also support it in the flavor, or that we should allow it to be present in the flavor and still hit a non-capable host.19:02
jaypipesefried: ack, totes19:02
jaypipesefried: and it's not like we have the ability to say "this trait can only go in an image metadata k/v and not a flavor extra spec k/v..."19:03
efriedjaypipes: I assume we would support something like hw:hpet=True in image meta.19:03
efriedso really any of the three options in the spec could be applied to both flavor and image19:03
jaypipesefried: I was just pointing out that for *some* of these things, the trait makes more sense as a constraint that is derived from an image, versus a constraint coming from a flavor...19:03
efriedoh, yeah, totally agree with you there.19:03
efriedIf the op wants the flavor to be flexible in terms of which arch it lands on, don't put arch-specific stuff in it.19:04
efriedthat seems like a fair rule of thumb19:04
jaypipesya19:04
jaypipesefried: I guess what I'm saying is I don't think a decision on the traits thing should hold up jding's patch.19:05
efriedjaypipes: no, but the decision about whether to fail if I see the request but can't fulfil it.19:06
efried^ should hold up the patch19:06
jaypipesefried: but again, if the guest/image arch isn't x86, the flavor's HPET extra spec makes no difference...19:06
efriedso that's where I think we disagree.19:06
efriedIf you've asked for a thing in the flavor, you should get the thing, or fail.19:07
efriedunless you want to call it hw:hpet_if_you_can_please19:07
efriedjaypipes: I added a note here: https://review.openstack.org/#/c/607989/1/specs/stein/approved/support-hpet-on-guest.rst@2319:08
dansmithare you guys cheating?19:09
efriedah dammit, I thought you said dansmith wasn't here19:09
dansmithI'm always here.19:09
*** mriedem has quit IRC19:15
*** s10 has quit IRC19:17
jaypipesefried: sorry, standup meetings...19:19
efriedWell, you're a standup kind of guy.19:19
jaypipeslol19:23
*** cdent has joined #openstack-nova19:23
*** mriedem has joined #openstack-nova19:24
*** s10 has joined #openstack-nova19:24
efriedbtw, the irony is not lost on me that standup meetings, which are supposed to be standup so they're short, are consuming your whole day.19:25
mriedemfwiw, translating flavor extra specs that the driver needs to placement traits in a pre-request filter doesn't seem too hair brained, we've talked about the same kind of thing for translating volume multiattach boot requests to query allocation candidates via compute node capabilities19:25
* mriedem read the meeting log19:26
dansmithmriedem: yeah I said that in the meeting19:26
dansmithit's basically what request filters are for19:26
mriedemif we do it generically it should be ok - just don't add one filter per extra spec19:27
mriedemthat would be hair brained19:27
efriedmriedem: FYI we're doing a hangout in ~34min, and there's a spec https://review.openstack.org/#/c/607989/ where the options are laid out and we're collecting thoughts19:27
dansmithmriedem: you are not PTOing well19:27
mriedemi'm T-33 minutes until nephew gets home19:27
mriedemat which point i'll drop off19:27
dansmithnot a good excuse19:27
mriedemafter listening to AM radio for 4 hours in the car i needed something to do19:27
efriedmriedem: Then you may register your vote in the spec, and we'll make up everything else you might have said.19:28
dansmithmriedem: do you have an opinion of not just adding another hw_ spec and making this a trait requirement in the flavor?19:28
dansmithso we get the scheduling for free19:28
mriedembut the driver still needs to know about the thing right?19:30
*** munimeha1 has joined #openstack-nova19:30
dansmithsure, it just looks for the presence of that on the flavor19:30
mriedemwhich we then figure out from the trait on the flavor rather than an extra spec?19:30
dansmithlike we do for gpus today19:30
dansmithright19:30
mriedemis tha twhat we do for gpus today?19:30
mriedemi didn't know19:30
dansmithyeah19:30
*** tbachman has quit IRC19:30
mriedemthen sure19:30
efrieddoes jaypipes know about that ^ ? (the GPU thing)19:30
mriedemthrow it in a method that knows what to look for and it doesn't matter if its extra spec or trait19:30
sean-k-mooneydansmith: today we enable a gpu by addign a trait?19:31
jaypipesefried: still standing...19:31
dansmithsean-k-mooney: no19:31
dansmithsean-k-mooney: it's a resource, but same difference19:31
sean-k-mooneydansmith: not quite19:31
efriedI thought for GPUs we use conf to populate traits to get scheduling, and then the driver looks at the same conf ...19:31
dansmithwe looked at the flavor initially, now I think we just inspect the allocation, but.. same sort of thing19:31
efriedoh, yeah, if it's a resource vs traits that's totally different19:31
sean-k-mooneydansmith: a hpet is not a consumable resouce19:31
efriedwell, according to *some people*19:31
dansmithit seems entirely un-different to me19:31
dansmithsean-k-mooney: I'm aware, thanks :)19:32
dansmiththe mechanism by which the driver knows to configure a thing is the same19:32
efriedftr I have no problem with that, been thinking along those lines since Denver-part-one, but Jay, Ed, and Chris all vetoed the idea pretty hard, then and since.19:32
dansmithI think the difference between your concern and theirs is whether or not the traits are opaque19:33
dansmithcould be wrong, but that seems to be the stumbling block19:33
efriedI'm not talking about key/value encoding at all.19:33
dansmithmaybe we should wait for the hangout?19:34
efriedI think the argument is that the trait is *not* opaque if the driver is doing a string compare to effect some config change on the guest.... sure :)19:34
sean-k-mooneydansmith: i was goint got comment  but your right :)19:34
dansmithefried: I would respond to your comment with an argument, but I will wait19:34
efriedAbove was me being devil's advocate (for several specific values of "devil"). I don't feel that way.19:35
efriedi.e. I think you and I are in agreement, dansmith19:35
* dansmith shudders19:36
efriedikr19:36
efriedSwhy the whole ownership traits thing caused a rift in the continuum.19:36
*** awaugama has quit IRC19:37
sean-k-mooneyefried: ya so did anything come of that?19:37
efriedsean-k-mooney: I think it's dead. Ed and Jay are -1.19:38
sean-k-mooneyi assumed it died on the vine at the ptg but i have not been following19:38
efriedno, it was agreed upon at the ptg19:38
efriedso I put up a patch for it, sec...19:38
efriedsean-k-mooney: https://review.openstack.org/#/c/602160/19:38
sean-k-mooneyhehe i like the doc string19:39
sean-k-mooneytraited is a ajative that is not used often enough19:40
efriedGiven Jay's (albeit reluctant) capitulation on the ML, we *might* still get away with using custom traits for ownership for a little while until we have that represented in some native key/value form (Jay's preference being an actual column in the resource provider table).19:40
efriedbut I don't see the standard traits flying.19:40
jaypipesok, I'm back now.. sorry about that19:41
* jaypipes reads back19:41
sean-k-mooneywas that not the original propsoal. add an owner colume to the resouce providers19:41
dansmithsean-k-mooney: it was, and it was NAKd19:41
dansmithit was for a different reason though19:41
*** munimeha1_ has joined #openstack-nova19:42
dansmiththe consumer type/owner has to not be just "cinder", "nova" if we want to support the multi-service possibility,19:43
dansmithwhich means you really only know "is this mine or not" if you're looking at that field19:43
dansmithwhich is probably okay19:43
*** slagle has quit IRC19:43
sean-k-mooneyoh but that would be an ower of an allocation not an ower of the resouce provider19:43
*** munimeha1 has quit IRC19:43
dansmithah you're right I'm confusing these two things19:44
efriedWe do have to assume well-behaved API client code. And I don't think we want to, like, make the providers only appear to their owners, that would be crazy.19:45
efriedso yeah, load up a provider record, look at the owner field, if it ain't me, don't dork with it.19:45
sean-k-mooneyfor owner of the resouce provder we disucssed 3 options. a trait. a nameing schem or a new db/object filed. the first two did not need placement change and the trait could be standardised  so we suggeted that one19:45
sean-k-mooneyat least i think that was the rough logic19:45
efried++19:46
cdentcould (not saying it is a good idea, just being a completist) also use an aggregate19:46
dansmithyep19:46
efriedBut Jay was out of the room or something.19:46
sean-k-mooneycdent: yes that could also work19:46
dansmithefried: he was there, but doing the "sit in the back of the room looking like he wants to kill everyone" thing he does19:46
sean-k-mooneythat came up in related to neutron and rack scale design before19:47
*** eharney has quit IRC19:47
efriedoh, see, if he had been out of the room actually killing someone, that might have been a good excuse19:47
dansmithdepends on who19:48
efriedcomes back in dripping blood, "Okay, now what decisions did y'all make without me?"19:48
jaypipesdansmith: s/kill someone/kill himself/ .... but yeah. that.19:48
sean-k-mooneyjaypipes: arent you glad you rejoined chat19:49
jaypipesare we ready to hangout?19:49
dansmithhttps://hangouts.google.com/call/7dw4HGf7o0A9UahxcR3ZAAEE19:50
dansmithwe can watch jaypipes make that look until it's time19:50
melwittI'm gonna lurk19:50
efriedcfriesen, sean-k-mooney, jackding:19:53
cdentdansmith, efried, jaypipes: i'm unable to join, but as I said before: the combined might of the brains involved ought to be able to get it right, but I do hope you will be summarizing to email or whatever please and thank you.19:53
* cdent waves goodnight19:54
*** cdent has quit IRC19:54
sean-k-mooneyefried: sorry was making tea. joining19:54
melwittbauzas: it's hangout time ^19:55
bauzasmelwitt: thanks19:58
*** priteau has quit IRC20:15
*** s10 has quit IRC20:16
*** s10 has joined #openstack-nova20:16
*** s10 has quit IRC20:16
*** s10 has joined #openstack-nova20:17
*** s10 has quit IRC20:17
*** s10 has joined #openstack-nova20:18
*** s10 has quit IRC20:18
*** s10 has joined #openstack-nova20:18
*** s10 has quit IRC20:19
*** slagle has joined #openstack-nova20:19
*** s10 has joined #openstack-nova20:19
*** s10 has quit IRC20:20
*** med_ has joined #openstack-nova20:26
*** priteau has joined #openstack-nova20:36
*** devananda has quit IRC20:38
*** slagle has quit IRC20:39
*** macza has quit IRC20:40
*** macza has joined #openstack-nova20:41
*** med_ has quit IRC20:43
*** hamzy_ has quit IRC20:44
*** priteau has quit IRC20:48
*** mchlumsky has quit IRC20:58
*** erlon_ has quit IRC21:05
*** mriedem has quit IRC21:05
*** itlinux has quit IRC21:14
*** itlinux has joined #openstack-nova21:17
*** devananda has joined #openstack-nova21:25
openstackgerritiain MacDonnell proposed openstack/nova master: Handle online_data_migrations exceptions  https://review.openstack.org/60809121:30
imacdonn^ dansmith: please review21:30
openstackgerritMerged openstack/nova stable/ocata: Re-use existing ComputeNode on ironic rebalance  https://review.openstack.org/60762621:32
*** spatel has quit IRC21:34
*** panda is now known as panda|off21:36
*** munimeha1_ has quit IRC21:45
cfriesendansmith: jaypipes: efried: sean-k-mooney: how does this look for a recap email?  http://paste.openstack.org/raw/731538/21:51
cfriesenand now I know what efried meant by getting spanked by Sigyn21:52
efriedcfriesen: You could mention:21:54
efried- This approach only makes sense for simple booleans. Anything requiring more complex configuration will likely need additional extra_spec and/or config and/or unicorn dust.21:54
efried- If we do get down to libvirt, and the trait is set, and the driver for whatever reason determines it's not capable of flipping the switch, it should fail.21:54
efriedand "HPET timer" is redundant :P21:55
efriedotherwise, lgtm.21:55
cfriesenefried: cool, will add that.21:55
efriedcfriesen: And you/jack are going to take over the spec, yah?21:56
cfriesenefried: yep21:57
efriedcoo21:58
efriedimacdonn: Where does the log go when you run that?21:59
imacdonnefried: nova-manage.log21:59
imacdonnefried: or, I guess, wherever logging puts the log named "nova-manage"22:00
efriedhmph. Where is that set up?22:00
imacdonnefried: schema migrations stuff already gets logged there22:00
efriedI mean, I assume you tried this out locally and were able to see those logs22:00
efriedokay22:00
imacdonnefried: affirm22:00
jaypipescfriesen: yes, nice work on that ML post. ++22:01
efriedimacdonn: oic, it gets set up in main()22:01
imacdonnefried: ah, yeah22:02
openstackgerritMerged openstack/nova master: Don't emit warning when ironic properties are zero  https://review.openstack.org/60575422:05
openstackgerritMerged openstack/nova stable/pike: Fix service list for disabled compute using MC driver  https://review.openstack.org/59233722:05
*** itlinux has quit IRC22:05
efriedcfriesen: When you're spiffing up that spec, I forgot to put blueprint: support-hpet-on-guest in the commit message22:06
efriedinterestingly, lp seems to have picked it up anyway. Maybe based on the topic?22:07
cfriesenI noticed that too.  gotta be the topic22:07
cfriesenbut yes, will add it in22:07
efriedokay, folks, I'm done like toast. ō/22:08
imacdonnyou're fried? fnar-fnar22:08
cfriesenjaypipes: so would we need to propose changes in os-traits adding new traits for HPET and TPM?22:10
*** med_ has joined #openstack-nova22:11
jaypipescfriesen: go for it :)22:13
cfriesenjaypipes: just wondering what the "proper" way to do this is22:13
*** tssurya has quit IRC22:14
cfriesenis anything in nova using os-traits yet?22:16
*** itlinux has joined #openstack-nova22:22
*** itlinux has quit IRC22:25
cfriesenwhat do you guys think of using HW_SYSTEM_X86_* and HW_SYSTEM_* for instance traits that aren't cpu/gpu/nic specific, like HPET and TPM?22:26
cfriesenand uefi22:27
*** rcernin has joined #openstack-nova22:27
*** plestang has quit IRC22:28
cfriesenif we have a trait that is requested in the flavor and forbidden in the image, do we error out currently?22:41
*** tbachman has joined #openstack-nova22:57
*** macza has quit IRC22:58
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7)  https://review.openstack.org/57199223:21
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8)  https://review.openstack.org/57199323:22
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615323:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3)  https://review.openstack.org/57410423:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4)  https://review.openstack.org/57410623:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5)  https://review.openstack.org/57411023:23
*** mlavalle has quit IRC23:32
openstackgerritMerged openstack/nova master: Enable nested allocation candidates in scheduler  https://review.openstack.org/58567223:33
*** slagle has joined #openstack-nova23:35
*** edmondsw has quit IRC23:38
openstackgerritMerged openstack/nova master: Use provider tree in virt FakeDriver  https://review.openstack.org/60408323:38
*** edleafe has quit IRC23:39
*** takashin has joined #openstack-nova23:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Add API ref guideline for examples  https://review.openstack.org/60406023:52
openstackgerritTakashi NATSUME proposed openstack/nova master: Add API ref guideline for body text  https://review.openstack.org/60562823:52
*** tetsuro_ has joined #openstack-nova23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!