Thursday, 2018-08-23

*** gouthamr has joined #openstack-nova00:03
openstackgerritSam Morrison proposed openstack/nova master: Allow ability for non admin users to use all filters on server list.  https://review.openstack.org/52655800:04
*** gyee has quit IRC00:13
*** brinzhang has joined #openstack-nova00:14
*** mriedem has quit IRC00:15
*** mriedem has joined #openstack-nova00:19
*** claudiub has quit IRC00:21
*** mmedvede_ has joined #openstack-nova00:24
*** mmedvede has quit IRC00:24
*** gryf has quit IRC00:24
*** mmedvede_ is now known as mmedvede00:24
*** jamesdenton has joined #openstack-nova00:26
openstackgerritMatt Riedemann proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692700:36
*** tetsuro_ has quit IRC00:40
*** Nel1x has joined #openstack-nova00:45
mriedemanyone, off the top of your head, does shelve of a volume-backed server create a snapshot of the root volume like createImage will?00:47
* mriedem looks00:47
mriedemoh we don't even snapshot for volume-backed00:48
mriedemwe just offload00:48
mriedemwell hells to the yeah00:49
mriedemsomething went right with shelve for a change00:49
*** imacdonn has quit IRC00:49
*** imacdonn has joined #openstack-nova00:50
*** cdent has quit IRC00:51
*** tetsuro has joined #openstack-nova00:54
*** gcb_ has quit IRC01:00
*** markvoelker has joined #openstack-nova01:06
*** harlowja has quit IRC01:06
*** tommylikehu has joined #openstack-nova01:11
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728901:12
Kevin_Zheng:)01:16
*** mrsoul has joined #openstack-nova01:21
*** masayukig has joined #openstack-nova01:27
*** Dinesh_Bhor has joined #openstack-nova01:29
*** markvoelker has quit IRC01:40
*** Dinesh_Bhor has quit IRC01:43
*** mriedem has quit IRC01:48
*** Dinesh_Bhor has joined #openstack-nova01:55
*** hongbin has joined #openstack-nova01:57
*** deepak_mourya__ has joined #openstack-nova02:21
*** vishakha_ has joined #openstack-nova02:22
*** BlackDex_ has joined #openstack-nova02:26
*** dave-mccowan has quit IRC02:27
*** alex_xu has joined #openstack-nova02:27
*** Dinesh_Bhor has quit IRC02:27
*** dansmith has joined #openstack-nova02:28
*** BlackDex has quit IRC02:29
*** hemna_ has quit IRC02:29
*** tommylikehu has quit IRC02:29
*** jogo has quit IRC02:29
*** yonglihe has quit IRC02:29
*** whoami-rajat has quit IRC02:29
*** hughsaunders has quit IRC02:29
*** vishakha has quit IRC02:29
*** deepak_mourya_ has quit IRC02:29
*** htimsnad has quit IRC02:29
*** antonym has quit IRC02:29
*** deepak_mourya__ is now known as deepak_mourya_02:29
*** vishakha_ is now known as vishakha02:29
*** hughsaunders has joined #openstack-nova02:31
*** jogo has joined #openstack-nova02:36
*** hemna_ has joined #openstack-nova02:37
openstackgerritzhufl proposed openstack/nova master: Blacklist test_create_server_with_tags for nova-cells-v1  https://review.openstack.org/59539902:37
*** markvoelker has joined #openstack-nova02:37
*** Dinesh_Bhor has joined #openstack-nova02:39
*** psachin has joined #openstack-nova02:46
*** Nel1x has quit IRC02:53
*** Dinesh_Bhor has quit IRC03:01
*** Dinesh_Bhor has joined #openstack-nova03:09
*** masayukig has quit IRC03:09
*** markvoelker has quit IRC03:11
*** masayukig has joined #openstack-nova03:11
*** hongbin_ has joined #openstack-nova03:21
openstackgerritChen proposed openstack/nova master: Normalize dashless 'resource provider create' uuid  https://review.openstack.org/56719103:24
*** hongbin has quit IRC03:24
*** nicolasbock has quit IRC03:44
*** Dinesh_Bhor has quit IRC03:45
*** udesale has joined #openstack-nova03:47
*** markvoelker has joined #openstack-nova04:08
openstackgerritChen proposed openstack/nova master: Fix create_resource_provider docstring  https://review.openstack.org/59545304:12
*** moshele has joined #openstack-nova04:19
*** moshele has quit IRC04:22
*** Dinesh_Bhor has joined #openstack-nova04:30
*** abhishekk has joined #openstack-nova04:38
*** Dinesh_Bhor has quit IRC04:40
*** markvoelker has quit IRC04:41
*** whoami-rajat has joined #openstack-nova04:48
openstackgerritmelanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59545504:57
*** links has joined #openstack-nova05:00
*** Dinesh_Bhor has joined #openstack-nova05:04
*** ccamacho has quit IRC05:11
*** ccamacho has joined #openstack-nova05:12
*** holser_ has joined #openstack-nova05:13
*** Dinesh_Bhor has quit IRC05:17
*** Dinesh_Bhor has joined #openstack-nova05:17
*** ccamacho has quit IRC05:19
*** hongbin_ has quit IRC05:19
*** moshele has joined #openstack-nova05:26
*** moshele has quit IRC05:29
*** liuyulong has joined #openstack-nova05:38
*** markvoelker has joined #openstack-nova05:38
*** holser_ has quit IRC05:40
*** janki has joined #openstack-nova05:40
*** lei-zh has joined #openstack-nova05:40
*** gryf has joined #openstack-nova05:42
*** Cardoe has quit IRC05:48
*** Cardoe has joined #openstack-nova05:49
*** lei-zh1 has joined #openstack-nova05:55
*** lei-zh has quit IRC05:58
*** dpawlik has joined #openstack-nova06:06
*** ccamacho has joined #openstack-nova06:07
*** ratailor has joined #openstack-nova06:09
*** dpawlik has quit IRC06:10
*** markvoelker has quit IRC06:12
*** dpawlik has joined #openstack-nova06:13
*** adrianc has joined #openstack-nova06:17
*** moshele has joined #openstack-nova06:27
*** jchhatbar has joined #openstack-nova06:31
*** janki has quit IRC06:31
*** pcaruana has joined #openstack-nova06:33
openstackgerritzhufl proposed openstack/nova master: Blacklist test_create_server_with_tags for nova-cells-v1  https://review.openstack.org/59539906:50
*** rcernin has quit IRC06:59
*** markvoelker has joined #openstack-nova07:09
*** sahid has joined #openstack-nova07:13
*** hoonetorg has quit IRC07:17
*** lei-zh1 has quit IRC07:22
*** jchhatba_ has joined #openstack-nova07:24
*** jchhatbar has quit IRC07:25
*** hoonetorg has joined #openstack-nova07:29
*** lei-zh1 has joined #openstack-nova07:32
*** Dinesh_Bhor has quit IRC07:33
*** jpena|off is now known as jpena07:36
*** alexchadin has joined #openstack-nova07:38
*** tssurya has joined #openstack-nova07:39
zigohttp://paste.openstack.org/show/728659/ <--- Excuse my french but ... WTF ?!?07:41
*** markvoelker has quit IRC07:42
*** jchhatba_ has quit IRC07:46
*** Dinesh_Bhor has joined #openstack-nova07:47
*** hoonetorg has quit IRC07:48
*** jchhatba_ has joined #openstack-nova07:48
*** ratailor has quit IRC07:49
*** jchhatba_ has quit IRC07:50
*** jchhatba_ has joined #openstack-nova07:50
*** alexchadin has quit IRC07:55
*** hoonetorg has joined #openstack-nova08:00
*** alexchadin has joined #openstack-nova08:01
*** owalsh has quit IRC08:03
*** jaosorior has quit IRC08:10
*** Dinesh_Bhor has quit IRC08:14
*** cdent has joined #openstack-nova08:20
*** Luzi has joined #openstack-nova08:23
openstackgerritZhenyu Zheng proposed openstack/nova master: Only lock when race condition happens in context.set_target_cell  https://review.openstack.org/59553008:25
*** obre has joined #openstack-nova08:30
*** dtantsur|afk is now known as dtantsur08:33
*** markvoelker has joined #openstack-nova08:39
*** davidsha has joined #openstack-nova08:44
*** sean-k-mooney has joined #openstack-nova08:46
*** tetsuro has quit IRC08:47
*** owalsh has joined #openstack-nova08:48
*** owalsh_ has joined #openstack-nova08:50
*** owalsh has quit IRC08:53
*** owalsh has joined #openstack-nova08:55
*** gcb_ has joined #openstack-nova08:55
*** owalsh_ has quit IRC08:56
*** Dinesh_Bhor has joined #openstack-nova08:56
*** jaosorior has joined #openstack-nova09:08
*** mgoddard has joined #openstack-nova09:09
*** markvoelker has quit IRC09:13
*** gcb_ has quit IRC09:13
*** jchhatba_ has quit IRC09:14
*** jchhatba_ has joined #openstack-nova09:14
*** egonzalez has joined #openstack-nova09:15
*** gcb_ has joined #openstack-nova09:19
*** Guest92900 has quit IRC09:19
openstackgerritZhenyu Zheng proposed openstack/nova master: Only lock when race condition happens in context.set_target_cell  https://review.openstack.org/59553009:21
*** sambetts_ has joined #openstack-nova09:22
*** lei-zh1 has quit IRC09:31
*** holser_ has joined #openstack-nova09:34
*** jchhatbar has joined #openstack-nova09:36
openstackgerritChris Dent proposed openstack/nova master: [placement] Add functional test to verify presence of policy  https://review.openstack.org/59555909:39
*** jchhatba_ has quit IRC09:39
*** adrianc has quit IRC09:47
*** sahid has quit IRC09:52
*** jaosorior has quit IRC09:54
*** adrianc has joined #openstack-nova09:54
*** jchhatbar has quit IRC09:58
*** markvoelker has joined #openstack-nova10:10
*** vipul has quit IRC10:10
*** claudiub has joined #openstack-nova10:14
*** Dinesh_Bhor has quit IRC10:25
*** donghm has joined #openstack-nova10:30
*** tetsuro has joined #openstack-nova10:30
*** chason has quit IRC10:39
*** tetsuro has quit IRC10:40
*** tetsuro_ has joined #openstack-nova10:40
*** chason has joined #openstack-nova10:41
*** alexchadin has quit IRC10:41
*** alexchadin has joined #openstack-nova10:41
*** alexchadin has quit IRC10:42
*** markvoelker has quit IRC10:43
*** abhishekk has quit IRC10:43
*** dave-mccowan has joined #openstack-nova10:46
*** jchhatbar has joined #openstack-nova10:46
*** Dinesh_Bhor has joined #openstack-nova10:49
*** tetsuro has joined #openstack-nova10:50
*** tetsuro_ has quit IRC10:50
*** tetsuro has quit IRC10:51
*** tetsuro_ has joined #openstack-nova10:51
*** Dinesh_Bhor has quit IRC10:52
*** tetsuro has joined #openstack-nova10:54
*** tetsuro_ has quit IRC10:54
*** erlon has joined #openstack-nova10:56
*** jpena is now known as jpena|lunch11:03
*** alexchadin has joined #openstack-nova11:13
*** sahid has joined #openstack-nova11:14
*** holser_ has quit IRC11:15
*** alexchadin has quit IRC11:18
*** nicolasbock has joined #openstack-nova11:22
*** udesale has quit IRC11:31
openstackgerritMoshe Levi proposed openstack/nova master: libvirt: set vfio driver in interface hostdev  https://review.openstack.org/59559211:33
*** mriedem has joined #openstack-nova11:33
mriedemahoy mateys!11:34
* kashyap waves11:35
*** markvoelker has joined #openstack-nova11:40
sean-k-mooneymriedem: so i have not got a chance to test your patches for the livemigration issue yet(ill do that today) but i have noticed one other issue.11:42
sean-k-mooneyits not so much a bug just something unfortunate11:42
*** jaypipes has joined #openstack-nova11:42
sean-k-mooneymriedem: when hybrid_plug=false and we are not useing dpdk we hit https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L216-L22311:44
sean-k-mooneyin this config os-vif only creates the bridge and the actual pluggin is done by the hypervior e.g. libvirt11:44
sean-k-mooneyso we dont get the speed up on live migrate11:44
mriedemwhat speed up on live migrate?11:47
sean-k-mooneyi know how to fix this in two way and ill start working on it after i test your changes but ya. i noticed up to a 20 second network outage when using kernel ovs with ovs contrac firewall driver but none when using ip tables as a result.11:47
*** mdrabe has quit IRC11:47
sean-k-mooneyya mriedem  effectivly the plug does not happen untill libvirt creates the vm on the dest.11:47
mriedemok11:48
mriedemi'll take your word for it :)11:48
jaypipesmorning supernovas11:48
mriedemhello jay11:48
sean-k-mooneymriedem: its the same behavior as before multiple port bindings so not a regression or bug just not faster.11:48
sean-k-mooneyjaypipes: enjoy your PTO?11:48
jaypipesmriedem: luckily not much happened or was discussed on the ML while I was away11:48
jaypipessean-k-mooney: very much, thank you Sean. :)11:49
*** moshele has quit IRC11:49
mriedemgibi: can you take a look at this rc3-related bug workaround? https://review.openstack.org/#/c/594508/ - rc3 is supposed to be today11:49
mriedemgibi: but withhold a +W until sean-k-mooney is able to test it in his env11:49
* mriedem assumes gibi will love it immediately and want to +W so hard11:50
gibimriedem: ack, witholding my love but reading the patch ;)11:51
sean-k-mooneymriedem: oh i forgot RC3 was today. i need to restack but i should have the env running in 20 mins or so11:53
*** jaosorior has joined #openstack-nova11:54
mriedemsean-k-mooney: *no pressure!*11:54
*** alexchadin has joined #openstack-nova12:02
*** moshele has joined #openstack-nova12:07
*** alexchadin has quit IRC12:07
*** kosamara has joined #openstack-nova12:08
mriedemmoshele: can you report a bug for https://review.openstack.org/#/c/595592/ ?12:09
mriedemit's a regression in rocky12:09
*** jpena|lunch is now known as jpena12:09
*** alexchadin has joined #openstack-nova12:09
moshelemriedem: sure I will12:11
mriedemmelwitt: ^12:11
mriedemthrow it on the big board donny!12:11
* cdent wonders what it must be like to go bowling with mriedem 12:11
mriedemit's fun12:12
mriedemsahid: you should take a look at moshele's patch12:13
mriedemmoshele: what sets the driver_name to vhost?12:13
*** markvoelker has quit IRC12:14
moshelemriedem: the macvtap port which is virtio tap connected to VF so for that case it should be fine12:14
sahidmriedem ah yes this bug has been reported downstream yesterday i think12:14
sahidmoshele: thanks for your patch12:15
moshelesahid: np :)12:15
mriedemmoshele: sorry i don't understand that statement,12:15
mriedemlooking at your paste12:15
mriedem: libvirtError: unsupported configuration: Unknown PCI device <driver name='vhost'/> has been specified12:15
mriedemand looking at https://review.openstack.org/#/c/595592/1/nova/virt/libvirt/designer.py12:15
mriedemi guess in this case the net_type was 'direct'?12:16
*** pcaruana has quit IRC12:16
mriedemso L12012:16
*** pcaruana has joined #openstack-nova12:16
sahidmriedem: are you sure vfio is a valid driver?12:17
sahidmoshele:12:17
*** ykarel has joined #openstack-nova12:17
ykareljroll, hi12:17
mosheleshaid: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_deployment_and_administration_guide/sect-pci_devices-pci_passthrough12:17
moshelesahid: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_deployment_and_administration_guide/sect-pci_devices-pci_passthrough12:18
ykareljroll, can u check https://bugs.launchpad.net/tripleo/+bug/1787910/comments/1312:19
openstackLaunchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b)12:19
sahidok thanks, because i remeber of a bug in libvirt for vhostuser interface interface, when you basically set it to vhostuser (which is the driver used) libvirt is reaisng an error12:19
moshelemriedem: no the net_type 'direct' is for macvtap port for port direct which is hostdev we don't set the driver name12:19
mriedemmoshele: yeah i figured it out,12:20
mriedemthe comment is busted in the code,12:20
mriedemi left a comment about fixing it :)12:20
moshelemriedem: the problem is with this https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L17612:21
moshelemriedem: driver is not specified it put vhost12:21
ykarelmriedem, or u can check https://bugs.launchpad.net/tripleo/+bug/1787910/comments/1312:21
openstackLaunchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b)12:21
mriedemaha12:22
mriedemmoshele: ok12:22
moshelemriedem: I send the mail because I am not sure about the fix. I know that my fix solve direct port12:23
mriedemi'd ask jangutter but he's not around12:23
sahidmoshele: perhaps it's better to use None, lbvirt might have some kind of fallback, example using vfio but if available on host fallback to uio12:24
mriedemmoshele: vnic_type = 'direct' right?12:24
zigoHi there !12:24
zigoAny idea why I'm getting this when building the Nova Debian package? https://stretch-rocky.infomaniak.ch/job/nova/9/console12:24
zigo(see the end of unit test run...)12:24
sahidit's what is done for vhost, norammy by default, libvirt use vhost but fallback to qemu if vhost module is not loaded on host12:25
mriedemzigo: you'll need to put that in a paste12:25
moshelemriedem: yes12:25
mriedemor give out creds12:25
zigoSure.12:25
zigomriedem: http://paste.openstack.org/show/728679/12:25
zigoFrom where is comming the MIMEAccept object? Is that nova's internal?12:26
zigoA grep in nova shows nothing ...12:27
moshelesahid: but this port will set driver name to vhost if it None https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L17612:27
mriedemykarel: i'll let jroll look at that b/c https://review.openstack.org/#/c/565841 was master only atm which is stein, and today is rocky rc3 so i'm focused on what we need to get done for rc312:27
moshelesahid: s/port/part12:27
ykarelmriedem, no prob, Thanks12:27
ykarelrocky is more priority now12:27
mriedemzigo: i'd guess the wsgi-intercept library12:28
mriedemcdent: ^12:28
mriedemhttp://paste.openstack.org/show/728679/12:28
*** holser_ has joined #openstack-nova12:28
* cdent looks12:28
mriedemwell best_matches = req.accept.acceptable_offers(types) is clearly in placement code12:29
cdentzigo, looks webob12:29
sahidmoshele: hum... it's complicated, because if you set it to None, the LibvirtConfig will not generate the tx/rx args12:29
mriedemyeah12:29
cdentacceptable_offer is new in webob 1.8.x I think12:29
mriedemsahid: but it looks like we default to vhost if rx/tx is configured https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L17612:30
mriedemso driver_name will always be at least vhost?12:30
mriedemwhich doesn't work for net_type == 'hostdev'?12:30
cdentzigo: my guess is that the webob is not up to date with minimum requirements?12:30
zigocdent: Yeah, that should be it, thanks!12:30
mriedemhttps://github.com/openstack/nova/blob/master/lower-constraints.txt#L170 fwiw12:31
mriedem1.8.212:31
zigoDebian version is 1:1.7.3-212:31
cdentzigo: I'm glad it was that easy :)12:31
zigoThanks guys.12:31
zigoWill update it.12:31
sahidyes yes, it's just i don't think we should specically set it to vfio, i think we should not set it at all for hostdev12:31
sahidbut if we do that tx/rx are then ignored12:31
jrollmriedem: ykarel: I'm looking at this, I'm confused what is special about tripleo jobs here, as this works fine in our ironic jobs12:31
sahidhttps://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/config.py#L139012:32
jrolloh wait, it's probably the flavors12:32
mriedemsahid: yup12:32
mriedembut if rx is configured,12:33
mriedemand driver is None,12:33
mriedemwe hard-code to vhost12:33
mriedemhttps://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L16912:33
mriedembut apparently that doesn't work12:33
mriedem: libvirtError: unsupported configuration: Unknown PCI device <driver name='vhost'/> has been specified12:33
mriedemhttp://paste.openstack.org/show/728666/12:33
sahidcan't we do something like that? https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L43212:34
mriedemheh, that TODO is overwriting the thing done in get_base_config which is based on another TODO12:34
mriedemand here https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L51912:35
moshelesahid.mriedem : we can skip it for vnic_type direct in https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L17612:35
mriedemsahid: which vnic_type did you test the rx queue stuff with?12:35
jrollykarel: posted a comment on the bug12:36
moshelesahid, mriedem ^12:36
ykareljroll, checking12:36
mriedemmoshele: but what about the other sriov types? https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/network/model.py#L11112:36
sahidget_config_vhostuser and _set_config_VIFHostUser are the same thing, one is native Nova the other for os-vif12:36
mriedemi know12:36
sahidah sorry i did not have undersdoot the qustion so12:37
mriedemso are direct and macvtap the only supported vnic types for rx/tx queues?12:37
moshelemriedem: they are got beacuse the macvtap is also virtio and also the virtio forwarder12:37
moshelemriedem: s/got/good12:37
*** dims_ is now known as dims12:37
sahidall vnic that are using virtio12:37
sahidcan have rc/tx queues12:37
moshelesahid: SR-IOV passthrough is not virtio12:38
moshelesahid:  meaning vnic_type direct12:38
mriedemalright, i'm clearly in over my head here in the nfv waters. my main concern is today is rc3 and it doesn't sound like we know what the correct solution is. so i'm wondering if we should just release note a known limitation and put something in the rx/tx config option help saying it's only supported by one specifiv vnic_type for now based on the one we know that works12:38
sahidyes, but you are talking about SRIOV+mactap right?12:38
moshelesahid:  also direct_physocal should work12:38
mriedemi would rather release rocky stating *what we know works*12:38
mriedemnot what *should* or *might* work12:39
moshelesahid: not it breack SR-IOV passthoght12:39
moshelemriedem: agree we need more time on this to find a good solution12:39
sahidyes12:39
mriedemso what do we know works? vnic_type='macvtap'?12:40
moshelemriedem: I will check it with Mellanox QA hope to have answer next week12:41
moshelemriedem:  as I see it we need to skip such config for vnic_type direct and physical_direct, but I will check to be sure ...12:41
ykareljroll, flavors created like: https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/legacy-periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/9a25ebd/logs/undercloud/home/zuul/overcloud_prep_images.log.txt.gz#_2018-08-21_13_14_0112:42
ykareljroll, is that wrong ?12:42
moshelesahid, mriedem: I have to go I will update you guys next week12:43
jrollykarel: hm, that looks right. looks like maybe there's a bug in nova that doesn't override flavor.ram with flavor.properties['resources:MEMORY_MB']? this definitely used to work12:44
jrollykarel: I don't have time to dig into that code right now though, sorry12:44
ykareljroll, what can be reason for phys_ram=0:- phys_ram=0MB used_ram=0MB phys_disk=0GB used_disk=0GB total_vcpus=0 used_vcpus=0 pci_stats=[]12:44
openstackgerritMerged openstack/nova master: [placement] Regex consts for placement schema  https://review.openstack.org/59186312:45
ykareljroll, no issue, ^^12:45
jrollykarel: baremetal resources no longer report ram/cpu/disk, we only rely on resource classes12:45
*** moshele has quit IRC12:45
ykareljroll, in devstack ironic i saw phys_ram=38412:45
jrollykarel: on master? I'd like to see that :)12:46
ykareljroll, yes http://logs.openstack.org/42/588942/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/4e2e0d5/logs/subnode-2/screen-n-cpu.txt.gz#_Aug_22_03_30_57_22736712:46
mriedemok so moshele said rx/tx isn't support for vnic_type direct* is what i heard12:47
jrollykarel: that's a stable/pike patch12:47
ykarel:(12:47
sean-k-mooneyjroll: the code works the otherway in nova. we calulate teh resources dictionary from flavor if not set not the other way around12:47
ykareljroll, okk, will check some master one :)12:47
jaypipesmriedem: weird how vif plugging succeeds before the libvirt XML file is even defined...?12:48
jrollsean-k-mooney: we explicitly agreed at some point that those resource classes in the flavor's properties would override the direct flavor properties. so I say it's a bug, if nova agrees that it isn't a bug, then ironic has docs bugs and ironic flavors have a UX problem :(12:48
jrollsean-k-mooney: and the code did work this way in the past12:49
jaypipessean-k-mooney: I trust whatever jroll says and remembers.12:49
jrolljaypipes: I'm putting that on my wall and will remember it in the future :D12:50
sean-k-mooneyim not that familar with the ironic code path so your proably right12:50
ykareljroll, correct in master phys_ram=0, jroll ok will try to understand placement now :) and see i can find anything there12:50
ykarelthen12:50
jaypipesjroll: deal. :)12:50
mriedemi also remember the flavor override thing12:51
ykareljroll, can this be the possible cause:- Details: There are no compute resource providers in the Placement |12:51
ykarel|   service but there are 2 compute nodes in the deployment.        |12:51
ykarel|   This means no compute nodes are reporting into the              |12:51
ykarel|   Placement service and need to be upgraded and/or fixed.         |12:51
ykarel|   See12:51
*** ykarel has quit IRC12:51
mriedemnot sure if it was in a spec though, if not - probably in some old ptg etherpad12:51
jrollwhoops12:51
*** ykarel has joined #openstack-nova12:51
mriedemi'm pretty sure edleafe had included the flavor overwrite stuff in the utility method for this...12:52
jrollykarel: the cause is a bug in the code that does overrides in the flavor, I'm sure of it :)12:52
jrollin the short term you can remove the top-level ram/cpu/disk properties from your flavor to work around it12:52
mriedemi'd be in this path https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L36712:52
jrollwhich is fine for CI, but not awesome for users12:52
ykareljroll, ack will try that12:53
ykareland wait for the fix in nova12:53
mriedemhttps://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/custom-resource-classes-in-flavors.html12:53
mriedemjroll: this isn't regressed in rocky right? it's just a master thing12:54
jrollmriedem: I don't know12:54
jrollmriedem: everything I know about the bug is here in channel12:54
*** udesale has joined #openstack-nova12:54
openstackgerritmelanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59545512:54
jrollmriedem: it could have regressed in rocky, but was masked by the fact we were still reporting cpu/ram/disk for the ironic nodes12:55
mriedemhttps://github.com/openstack/nova/blob/cc436c2b2a2dad974c4d28871851a456ebd80e48/nova/scheduler/utils.py#L22012:55
*** Tomatosoup1 has joined #openstack-nova12:58
jrollman this code is not super easy to understand12:58
mriedemthis is the old code https://review.openstack.org/#/c/515223/12/nova/scheduler/utils.py@a22412:58
mriedemit wasn't before either12:59
*** mdrabe has joined #openstack-nova12:59
Tomatosoup1hello12:59
Tomatosoup1i would like to set up SNAT network on one of the openstack VM, how may i do it? docs are mentioning SNAT but only in theoretical way13:01
jrollmriedem: so that first link, are you saying it should work as advertised?13:01
mriedemw/o a functional test showing it works, idk13:01
mriedemif it was regressed, it's been broken since queens13:02
mriedemwith https://review.openstack.org/#/c/515223/13:02
jrollawesome13:02
mriedem:) this is why i was easing into the "remove the old flavor support for baremetal" pool13:02
jrollyeah, glad we didn't kill it at the tail end of rocky13:03
mriedemyou remember talking about it though right?13:03
mriedemlike 2 weeks ago13:03
jrollabout removing it? or about this bug?13:03
mriedemremoving it13:03
jrollyeah13:03
jrollI can say "you win" if that's what you're looking for :)13:04
mriedemYES13:04
* jroll gives mriedem a cookie13:04
mriedemi would take some eggs and toast13:04
jrollokay, I shall go make them13:05
mriedemthanks babe13:05
openstackgerritMatt Riedemann proposed openstack/nova master: Merge keypair extension response into server view builder  https://review.openstack.org/58474813:06
openstackgerritMatt Riedemann proposed openstack/nova master: Merge server usage extension response into server view builder  https://review.openstack.org/58526213:06
openstackgerritMatt Riedemann proposed openstack/nova master: Merge security groups extension response into server view builder  https://review.openstack.org/58547513:06
openstackgerritMatt Riedemann proposed openstack/nova master: Merge extended_status extension response into server view builder  https://review.openstack.org/59209213:06
mriedemtssurya: fyi ^ i'm trying to keep gmann's series straight and rebased so we can flush it through13:07
mriedemTomatosoup1: see channel topic please13:08
Tomatosoup1mriedem, sorry!13:09
tssuryamriedem: noted thanks :) I need extended_volumes also, probably we will have it when he is back13:09
*** Tomatosoup1 has left #openstack-nova13:09
*** jaosorior has quit IRC13:09
sean-k-mooneyare there any known bugs with pysaml2? my devstack is failing to install it. im wondering do we need a version cap13:09
*** marvin_mhg has quit IRC13:10
*** lennyb has quit IRC13:10
mriedemtssurya: he's out for another week,13:12
mriedemthese changes are pretty mechanical so could probably just do it yourself13:12
mriedemfollowing the pattern,13:12
mriedemthe hardest part would be the unit test stuff13:12
tssuryaah okay, I didn't want to step into his stuff, but if that's okay I can get it up and update them13:12
mriedemsean-k-mooney: upper-constraints should restrict it in devstack13:13
*** mgoddard has quit IRC13:15
*** jdillaman has joined #openstack-nova13:17
edmondswin my devstack I'm seeing a lot of "DEBUG nova.notifications.objects.base [None req-af08f64a-756e-4b43-8357-fd879d3bbbc9 None None] Defaulting the value of the field 'numa_membw_values' to None in MetricPayload due to 'Cannot load 'numa_membw_values' in the base class' {{(pid=145045) populate_schema /opt/stack/nova/nova/notifications/objects/base.py:142}}"13:18
edmondswbut I can't find anything that would ever actually set numa_membw_values, outside of tests13:18
edmondswshould that be removed? What am I missing?13:19
edmondswor set to Null here? https://github.com/openstack/nova/blob/baf858b03d55273f92fc115ea5c8f71c0bbb6582/nova/compute/monitors/cpu/virt_driver.py#L4213:22
edmondswif it's only ever null, though...13:23
sean-k-mooneymriedem: its trying to install 4.6.0 and thats failing on my system.13:24
*** bodgix has quit IRC13:24
sean-k-mooneyill pin locally to 4.5 for now13:25
*** bodgix has joined #openstack-nova13:25
*** bodgix has left #openstack-nova13:25
*** BlackDex_ is now known as BlackDex13:26
sean-k-mooneyedmondsw: numa_membw_values being memory bandwidth? i think that is only supported skylake or newer intel chips and on skylake its broken becaue but memory reand and memory write counters were actully the read value13:29
edmondswsean-k-mooney unclear from the code I've found13:29
*** marvin_mhg has joined #openstack-nova13:30
edmondswI wonder if this was added with the intention of having a followup that used it and maybe that just never happened13:30
sean-k-mooneyperhaps that or there is patch in review that has not landed yet13:31
*** gbarros has joined #openstack-nova13:31
*** tbachman has joined #openstack-nova13:31
*** adrianc has quit IRC13:34
*** adrianc has joined #openstack-nova13:35
*** liuyulong has quit IRC13:35
stephenfinmriedem: Does we need to wait for blueprint approval for [1] or can I start flushing them through? [1] https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+status:open13:37
stephenfinmriedem: Wait, it's specless and approved. Ignore me13:38
zigomriedem: cdent: I now know why I missed the webob version, it's because I forgot the EPOCH ...13:39
zigo1:1.8.2 is what's needed, not 1.8.2 ...13:39
zigo:/13:39
mriedemstephenfin: right some are already approved/merged13:39
stephenfinack13:39
*** alexchadin has quit IRC13:39
*** psachin has quit IRC13:40
mriedemedmondsw: a notification is trying to build a payload from the MonitorMetric object which has unset fields which don't have default values13:41
mriedembut if it's nullable we can just set it to None13:41
mriedemsince 'numa_membw_values': fields.DictOfIntegersField(nullable=True), that's what we do13:42
edmondswmriedem yep, my point is that I think it's always going to be unset and thus DEBUG logs will always have a bunch of these messages filling them because nowhere is it ever set that I can find13:43
mriedemwe also get that a ton for flavor stuff i think13:43
mriedemor used to13:43
edmondswand if that's the case, why does the schema have it in the first place?13:43
mriedemi would be ok with dropping the 'defaulting to None' debug log13:44
mriedembut it's up to gibi13:44
mriedemor change to TRACE if we ever get a TRACE log level13:44
edmondswI can ignore it, it's not a big deal to me... just thought I'd ask13:44
mriedemit bothers me too13:44
* gibi is reading back13:45
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503313:45
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise  https://review.openstack.org/58459813:45
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459913:45
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464813:45
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503413:45
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504913:45
openstackgerritEric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees  https://review.openstack.org/57623613:45
ykareljroll, mriedem openstack flavor unset --property resources:VCPU --property resources:DISK_GB --property resources:MEMORY_MB <flavor> didn't help, or i tried something wrong13:47
*** eharney has joined #openstack-nova13:48
gibimriedem: as the MonitorMetric.numa_membw_values is also nullable I think when nova creates the MonitorMetric object it fails to set the default value of that field13:49
mriedemthere is no default value13:49
mriedembut it is nullable13:49
mriedemi guess you mean fails to initialize the field to None?13:49
gibimriedem: ohh, my bad13:49
gibimriedem: I mixed nullable and default value13:50
*** rnoriega has joined #openstack-nova13:53
gibimriedem: if an ovo is valid with unset fields then I cannot do anything else than remove the debug log13:54
*** rnoriega has quit IRC13:54
mriedemyeah i don' think the debug log adds much besides noise - if the field is unset and can't be lazy-loaded and is nullable and set it to None, great13:55
mriedemthat's what should happen13:55
*** rnoriega has joined #openstack-nova13:55
mriedemif we can't do that - i.e. it's not nullable, then we fail and log an error13:55
*** jchhatbar has quit IRC13:55
mriedemlike that flavor.disabled thing we had to fix13:55
gibimriedem: yeah. Then I will file a bug and propose the removal.13:55
mriedemi can report a "logs are noisy" bug if you want for tracking13:56
mriedemah ok13:56
mriedem:)13:56
*** kosamara has quit IRC13:56
melwittnova meeting in 4 minutes13:56
*** kosamara has joined #openstack-nova13:56
gibimriedem: I'm not fully happy with ovos with unset fields but we use the ovos that way a lot in nova13:56
mdboothmelwitt: We may have to continue that discussion another time, then ;)13:56
*** takashin has joined #openstack-nova13:57
mdboothmelwitt dansmith: Incidentally, were you trying to grok https://review.openstack.org/#/c/578846/7/nova/virt/libvirt/driver.py 1002-> ?13:57
mdboothmelwitt dansmith: Because if so I don't grok that either, but it's not new code.13:57
mdboothIt came from old code line 1066->13:58
mdboothAs I put in the comment, I'm pretty sure it's wrong, though, but I wasn't going to change it in this patch13:59
dansmithmdbooth: I'm not saying I don't grok it, I'm saying it's a lot of change13:59
dansmith"code motion" or not :)13:59
*** awaugama has joined #openstack-nova13:59
dansmithwe have a meeting in 30 seconds and then I can look in more detail,13:59
melwittyeah, it was just me who said I couldn't follow the change so far13:59
mdboothdansmith: It updates _create_image() to return whether or not it created anything13:59
dansmithbut I was saying that mriedem and melwitt and cfriesen at least have context on this and probably can get back up to speed quicker than I can even start13:59
mriedemthis is about the time i muse about an evacuate test in the gate14:00
jrollykarel: what I meant was e.g. openstack flavor set --memory-mb 0 $flavor14:00
jrollor the equivalent14:00
dansmithmdbooth: see? ^14:00
mriedemrun a nova tempest plugin test in serial,14:00
mdboothmriedem: I wrote one :)14:00
mriedem2 node CI14:00
mriedemforce down one host,14:00
mriedemevacuate to the other14:00
ykareljroll, okk my bad, will try that14:00
mriedemrun in both ceph and non-ceph jobs14:00
mdboothmriedem: Ah, that would be better of course. Mine's in functional.14:00
mriedemmdbooth: you wrote a functional test with stubs yes?14:00
mdboothmriedem: right.14:01
mdboothmriedem: It runs quite a lot of code, though. It runs the libvirt driver.14:01
mdboothmriedem: And it tests all 4 combinations of shared/nonshared instance storage and block.14:02
mriedemjohnthetubaguy: since you're around, you've been summoned several times on https://review.openstack.org/#/c/536351/14:02
johnthetubaguyoh sorry, looking14:03
*** mlavalle has joined #openstack-nova14:03
melwittsahid: are you still around? would you be able to advise us on how to document the issue in https://review.openstack.org/#/c/595592/ for the config option help and release notes?14:04
*** dpawlik has quit IRC14:05
sahidmelwitt: yes sure i will try to reply to Matt with the most information that i have14:06
openstackgerritMerged openstack/nova master: Merge extended server attributes extension response  https://review.openstack.org/58459014:06
melwittgreat, thank you sahid14:06
*** r-daneel has joined #openstack-nova14:07
melwittwe're trying to get the information straight to document the situation for RC3 whose deadline is today14:07
*** gbarros has quit IRC14:09
mdboothmriedem: We were discussing https://review.openstack.org/#/c/578846/ btw, which is a completely new approach. Described in the commit message: "This change modifies spawn in the libvirt driver such that it only cleans up resources it created."14:09
mriedemnova meeting, and rc3 fires14:10
mriedemso i'm not looking into that today14:10
mriedemor soon14:10
mdboothmriedem: ack14:10
*** gbarros has joined #openstack-nova14:11
ykareljroll, i tried creating a new flavor as i can't find update command for ram and it says:- Invalid input for field/attribute ram. Value: 0. 0 is less than the minimum of 1 (HTTP 400) (Request-ID: req-1545b718-80c2-4c08-bcba-356a21535b47)14:12
mriedemjohnthetubaguy: thanks14:12
mriedemykarel: ram must be at least 1 per the api schema14:13
mriedemsame for vcpus14:13
mriedemroot_gb can be 014:13
mriedemhttp://eavesdrop.openstack.org/meetings/nova/2018/nova.2018-08-16-21.00.html14:13
mriedemoops14:13
mriedem'required': ['name', 'ram', 'vcpus', 'disk'],14:13
jrollugh14:13
ykarelmriedem, but to avoid that nova bug, jroll suggested to use 014:13
mriedemthe api says otherwise14:13
mriedemfor ironic, the flavor values will likely just be informational,14:14
mriedemand then the extra spec resources: are meant to override i thought14:14
jrollright14:14
jrollwhich isn't working in these tripleo jobs14:14
* jroll wonders how ironic jobs work14:14
jrollhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L208314:14
*** brinzhang has quit IRC14:15
jrollah, we don't enable cpu/ram/disk filters14:15
ykarelhmm in tripleo we have those enabled14:17
ykarelenabled_filters=RetryFilter,AvailabilityZoneFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter14:18
ykarelenabled_filters=RetryFilter,TripleOCapabilitiesFilter,ComputeCapabilitiesFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter14:18
jrollright14:18
jrollare you also using VMs here?14:18
ykarelno, just ironic14:18
ykarelbms14:18
jrollah, I'd kill those filters then, they aren't necessary14:19
jaypipesenabled_filters should not include RamFilter, DiskFilter or ComputeFilter.14:19
jrolland please do file a bug about the override thing, if you would14:19
jaypipesperhaps this is the thing I was referring to when I mentioned triple-o was still relying on non-resource-class world.14:19
jrolljaypipes: oh, we don't need those filters anywhere now, right?14:19
jaypipesjroll: correct.14:19
jrolleven for VMs?14:19
jrollnice14:19
jaypipesyes, even for VMs.14:19
jaypipesactually, lemme verify...14:20
jaypipesthere was a CoreFilter too I think, and I can't remember whether it was that or ComputeFilter which filters out "disabled" nodes.14:20
jaypipesjroll, ykarel: you don't need CoreFilter, DiskFilter and RamFilter. ComputeFilter is still  needed14:21
sean-k-mooneyComuteFilter does the disabled host i think14:21
mriedemcorrection!14:21
jaypipesit filters out "disabled" nodes14:21
mriedemyou need those filters for caching scheduler14:21
mriedemwhich doesn't use placement14:21
jaypipesoh ffs, yes.14:21
mriedemotherwise what jay said14:21
jrollgdi mriedem14:22
mriedemhey, if mgagne_ gives the ok at the ptg that we can drop the caching scheduler, then we can14:23
*** gbarros has quit IRC14:23
sean-k-mooneymriedem: we are deleting the cachingschduler this cycle right?14:23
sean-k-mooneyah ptg topic14:23
mriedemsean-k-mooney: idk, we were going to drop nova-net in rocky ...14:23
sean-k-mooneyya... stein for that?14:23
sean-k-mooneythe caching schduiler could be kicked out of tree like the ec2 api if people really wanted it for some reason. that is still a plug point right?14:24
sean-k-mooneye.g. you can provide your own schduler driver14:24
mriedemyes i think so14:25
mriedemvia stevedore extensions14:25
melwittjohnthetubaguy: I pinged you a long time ago about https://review.openstack.org/533168 that you reviewed in the past, if you can get a chance to look at it14:25
openstackgerritStephen Finucane proposed openstack/nova master: tests: Create functional libvirt test base class  https://review.openstack.org/40705514:25
openstackgerritStephen Finucane proposed openstack/nova master: tests: Move mocking to setUp  https://review.openstack.org/59580214:25
sean-k-mooneymriedem: ya so we could split it out if there was concerns into its own repo but ingeneral not ship it14:25
ykareljaypipes, jroll ack, so those filters are not needed anymore, then any reason to keep them still?14:25
johnthetubaguymelwitt: that does have my name all over it, will try take a look14:25
jrollykarel: the only reason to keep them is if you use the caching scheduler14:26
jaypipesplease tell me triple-o isn't setting up the caching scheduler.14:26
mriedemit's not14:26
sean-k-mooneymriedem: if we did that we could move the filters that are only needed with the cahcein scheduler also14:26
mriedemwell, i assume it's not :)14:26
jaypipesyay. I can step back from the edge.14:26
mriedemThe Edge (tm)?14:27
melwittjohnthetubaguy: sweet, thanks14:27
jaypipesmriedem: touche14:27
ykareljroll, how that's configured, caching scheduler14:27
jrollheh14:28
sean-k-mooneyjaypipes: by default no there is a conf override thing in tripleo so someone could set teh conf values manually but im pretty sure that would make the deployment unsupported  downstream14:28
jrollykarel: conf.scheduler.scheduler_driver14:28
sean-k-mooneyykarel: now that you know. please never set it to anything other then the filter schduler14:29
ykareljroll, driver=filter_scheduler14:29
ykareljroll, sean-k-mooney we have ^^14:29
jrollcue denver: <tripleo> we rely on the caching scheduler, please don't remove it!14:30
sean-k-mooneyjroll: at this point anything we have so much stuff using placement im not even sure you could deploy a fucntional nova with the caching schduler unless you never migrate or resize anything14:31
jrollsean-k-mooney: if anyone can hack it, it's tripleo ;D14:32
jaypipessean-k-mooney: "that would make the deployment unsupported  downstream" wait, what!? but I thought triple-o wasn't a RH product? :P14:33
sean-k-mooneyjaypipes: i was refering to OSP14:33
jaypipessean-k-mooney: ok dokey. :)14:33
sean-k-mooneye.g. osp being the downstream14:33
sean-k-mooneytripplo has too many names14:33
jaypipessean-k-mooney: and you just gave it another ;) "tripplo"14:34
sean-k-mooneyits tripleo, rdo director, osp director and apex14:34
jaypipessean-k-mooney: oh, you mean exactly what RH did with OpenShift?14:34
jaypipessean-k-mooney: or at least, *the current incarnation* of OpenShift.14:34
*** ccamacho has quit IRC14:35
sean-k-mooneyOpenshift is (kubernetes + extentions) and i think its called Openshift container platform or somthing as down stream product. i should proable  know that...14:36
jaypipessean-k-mooney: yes, I'm referring to the evolving meaning of openshift(.com/org) over the last 5 years...14:36
*** r-daneel has quit IRC14:37
*** Bhujay has joined #openstack-nova14:39
mgagne_mriedem: I don't think the caching scheduler will be needed anymore if placement does the job and I can migrate to it easily. we tested that already I think14:41
mriedemmgagne_: i hoped that's what you'd say, based on earlire discussions re heal_allocations14:41
*** Luzi has quit IRC14:41
mgagne_mriedem: if caching scheduler can still be used in a out of tree fashion, there is a plan B if anything goes wrong.14:41
mriedemyes, that's possible14:43
sahidmriedem, melwitt not sure of what you can put in the release note or config doc instead of don't mix rx/tx queue size option if you don't use guests with only virtio devices :/14:45
sahidi commented a think we could have a patch which is limiting the impact14:45
*** sapd1 has quit IRC14:49
gibiedmondsw, mriedem: bug about the noise debug log https://bugs.launchpad.net/nova/+bug/178863414:49
openstackLaunchpad bug 1788634 in OpenStack Compute (nova) "Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload" [Low,Confirmed] - Assigned to Balazs Gibizer (balazs-gibizer)14:49
sean-k-mooneysahid: well enduses can change the interface model by uploading an imagge and setting the vif_modle in the metatdat14:49
*** Swami has joined #openstack-nova14:50
sean-k-mooneysahid: so the nova code needs to handel that correctly and not set the queue lenght in that case14:50
edmondswgibi cool, tx14:50
*** sapd1 has joined #openstack-nova14:50
*** moshele has joined #openstack-nova14:54
sahidsean-k-mooney: yes and only virtio model works with queues, so is user is setting something else, we don't want use queues14:54
sahiddid i miss something?14:55
sean-k-mooneysahid: right, no just makeing sure that is the current behavior. i belive we check for that in the code but if we dont its a bug14:56
sahida even less impacting solution is to reproduce what is done https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L15314:57
sahidfor rx/tx queue block14:57
*** rpittau has quit IRC14:57
kosamaraContinuing from the meeting on https://review.openstack.org/#/c/57989715:00
jaypipesstephenfin: you fixing up https://review.openstack.org/#/c/595802/?15:01
stephenfinjaypipes: as we speak15:01
*** takashin has left #openstack-nova15:01
kosamaradansmith: I don't propose a new knob actually. The same condition that triggers "hide_hypervisor_id" will additionally hide the hyperv signature, if it's a windows guest.15:01
melwittsahid: ack15:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove noisy DEBUG log  https://review.openstack.org/59581015:02
gibiedmondsw, mriedem: ^^15:02
dansmithkosamara: okay I see, my mistaked15:02
kosamarathis is functionality that the "hide_hypervisor_id" feature already promises, but currently doesn't work for Windows guests.15:02
dansmithkosamara: I think that we probably shouldn't have that feature, but that's just MHO and I'm wrong a lot. Also, I'm a terrible person.15:03
jaypipesstephenfin: ack. cuz me likey that series.15:03
kosamaradansmith: Self-sarcasm is usually a sign to the opposite :P15:04
mriedemedmondsw: https://bugs.launchpad.net/nova/+bug/1788634/comments/315:04
openstackLaunchpad bug 1788634 in OpenStack Compute (nova) "Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)15:04
jaypipeskosamara: like dansmith I am also a terrible person.15:04
jaypipeskosamara: and no, we're not being sarcastic, :P15:04
mriedemedmondsw: tl;dr the object changes were added for the numa bw metric but the implementation wasn't15:06
mriedemb/c we decided around the time of the newton midcycle meeting that nova as a stats gatherer was dumb15:06
edmondswmriedem got it15:06
*** itlinux__ has joined #openstack-nova15:06
edmondswtx for the history15:06
mriedemand that field likely shouldn't be in the notification payload15:07
mriedemnow that you mention it15:07
mriedembut dropping it would be a major version bump i think - gibi agree?15:07
edmondswmriedem gibi so should the solution be to remove the log statement or to remove numa_membw_values from the schema?15:07
gibimriedem: yepp, I was in the process of typing this comment15:07
edmondswor to keep it in the schema but start setting it to None explicitly15:07
gibimriedem, edmondsw: I think the notification change should be tight to the cleanup of this half done feature15:08
kosamarajaypipes, dansmith: terrible or not, thanks a lot for the discussion.15:08
mriedemgibi: edmondsw: looking at http://logs.openstack.org/97/579897/4/check/tempest-full/53d05dc/controller/logs/screen-n-cpu.txt.gz15:08
mriedem"Defaulting the value of the field" shows up over 1K times15:08
mriedemso i think the debug log should go away regardless15:08
openstackgerritStephen Finucane proposed openstack/nova master: tests: Move mocking to setUp  https://review.openstack.org/59580215:09
openstackgerritStephen Finucane proposed openstack/nova master: tests: Create functional libvirt test base class  https://review.openstack.org/40705515:09
mriedemFlavor.projects is a huge one15:09
mriedemsince flavor is in all instance payloads15:09
gibimriedem: I agree that we need to drop the debug log15:09
gibimriedem: regardless of the notificaton change15:10
mriedem+215:10
gibimriedem: or more like independently15:10
*** hamzy has quit IRC15:10
edmondsw+1 from me15:11
ykarelmriedem, jaypipes jroll sean-k-mooney Thanks, i commented https://bugs.launchpad.net/tripleo/+bug/1787910/comments/16, please correct if i added something wrong there15:11
openstackLaunchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b)15:11
gibiawesome :)15:11
jrollykarel: thanks! looks good to me15:12
openstackgerritMerged openstack/nova master: Fix nits in resource_provider.py  https://review.openstack.org/58847015:12
sean-k-mooneymriedem: ok i finally got to a point where i could test https://review.openstack.org/#/c/594508/2. the error is still being thrown from qemu  but the newroking on the vm is not broken anymore15:12
sean-k-mooneymriedem: so that looks good to me. ill +1 it upstream15:13
mriedemsean-k-mooney: awesome, can you note in the review so gibi can "put his love on it" or whatever he said earlier?15:13
mriedemsean-k-mooney: thanks15:13
mriedemi'm pretty sure gibi sexually harassed my patch15:13
edmondswefried https://docs.openstack.org/nova/latest/contributor/policies.html#metrics-gathering says there is "not yet a clear replacement"... is that still true, or does the placement service fill that role now?15:13
mriedemplacement doesn't gather metrics15:13
mriedembut you could probably report metrics type things into placement to be used during nova scheduling15:14
gibimriedem: I think you started it ;) "* mriedem assumes gibi will love it immediately and want to +W so hard"15:14
mriedemlike the nw bw stuff gibi is working on15:14
mriedemgibi: ha15:14
*** itlinux__ is now known as itlinux15:15
*** itlinux is now known as 59NAABP8D15:15
efried"report metrics type things into placement"? mind blown15:15
gibiI'm not sure how the available and used nw bw in placement relates to metrics but yeah15:16
sean-k-mooneyefried: metric type things?15:16
efriedsean-k-mooney: Don't look at me. It was mriedem's zany idea15:17
sean-k-mooneyi obvioulsy missed somthing while debuging my devstack setup15:17
*** 59NAABP8D has quit IRC15:17
edmondswefried you can probably blame me there15:17
edmondswI don't know that either of us were suggesting it should be done, just wondering15:18
sean-k-mooneyedmondsw: placement does not store metrics no15:18
*** itlinux has joined #openstack-nova15:18
sean-k-mooneyedmondsw: also it likely never will15:18
edmondswI don't really know why nova ever used metrics for scheduling15:18
mriedemit was an ibm feature15:18
edmondswha15:18
mriedemyou probably should remmeber this15:19
mriedemi'm pretty sure it was powervc relatd15:19
mriedem*related15:19
mriedemsudipta biswas15:19
sean-k-mooneyedmondsw: but bandwidth based schduling is different then metric based suchduling that was keed off network usage15:19
mriedemit was for metrics weighers15:19
jaypipeshold up... somebody said metrics and placement in the same breath... /me perks up15:19
sean-k-mooneyedmondsw: for gibi's bandwith based schduling work we are tracking bandwidth as a consumable resouce which is exactly what placement was designed for15:20
edmondswsean-k-mooney yep, understood15:20
*** dklyle has quit IRC15:20
sean-k-mooneyjaypipes: yep the comment i made was that was not a thing15:20
gibiohh I see the relation between nw bw and metrics. If neutron would report physically used nw bw to placement that would be the metric15:20
efriedjaypipes: I'm going to tag providers with dynamic traits like CUSTOM_CPU_CYCLES_SINCE_LAST_RESET_<NNNN>, updated every periodic via update_provider_tree.15:20
sean-k-mooneygibi: ya but we dont want to contiunally update allocation to model real usage. at would be an abuse of the datamodel in placement15:21
gibisean-k-mooney: totally agree15:21
gibisean-k-mooney: I never wanted to do that15:22
* jaypipes orders straightjacket for efried from Amazon15:22
mriedemdo they sell those?15:23
sean-k-mooneygibi: i have seen a really old poc for bandwidth based schduling using celomiter metrics in the past15:23
efriedI was expecting something along the lines of "over my cooling corpse"15:23
* edmondsw wants to watch jaypipes try to put that on efried15:23
jaypipesmriedem: https://www.amazon.com/Posey-Straight-Jacket-MEDIUM/dp/B001ANOR6E15:23
efriedmriedem: https://www.amazon.com/Freebily-Leather-Straitjacket-Straight-Costume/dp/B07B8KV2NQ/ref=sr_1_2?ie=UTF8&qid=1535037811&sr=8-2&keywords=straightjacket15:23
jaypipesefried: :P15:23
sean-k-mooneyefried: what you do in the privacy of your out of tree virt driver is fine just so long as that never happens in the nova tree :)15:24
jaypipes"Customers also bought..." section is awesome.15:24
mriedemi suggested to my wife last night that while in berlin we should shop for something like that15:24
jaypipesheh15:24
mriedemb/c my german stereotype includes 80s synth music and leather15:24
efriedI like how it's other-legit-restraint other-legit-restraint kinky-s&m-thing other-legit-restraint...15:25
*** macza has joined #openstack-nova15:26
openstackgerritChen proposed openstack/nova master: Fix create_resource_provider docstring  https://review.openstack.org/59545315:31
*** ykarel is now known as ykarel|away15:32
*** hamzy has joined #openstack-nova15:35
*** Bhujay has quit IRC15:35
*** pcaruana has quit IRC15:36
*** dklyle has joined #openstack-nova15:37
mriedemso anyone that cares about this placement extract / governance thing should probably be in the tc channel as of about an hour ago15:43
*** ykarel|away has quit IRC15:51
*** ttsiouts has joined #openstack-nova15:55
*** itlinux is now known as itlinux-away15:58
*** gyee has joined #openstack-nova15:59
*** itlinux-away is now known as itlinux16:00
*** itlinux is now known as itlinux-away16:00
*** ttsiouts has quit IRC16:00
*** links has quit IRC16:02
*** ttsiouts has joined #openstack-nova16:03
*** moshele has quit IRC16:04
*** mriedem is now known as mriedem_sudsy16:04
*** ttsiouts has quit IRC16:04
*** itlinux-away is now known as itlinux16:05
*** itlinux is now known as itlinux-away16:05
*** itlinux-away is now known as itlinux16:06
*** itlinux is now known as itlinux-away16:07
*** ttsiouts has joined #openstack-nova16:08
openstackgerritMerged openstack/nova master: placement: use single-shot INSERT/DELETE agg  https://review.openstack.org/59265416:08
*** icey has quit IRC16:09
*** icey has joined #openstack-nova16:10
*** itlinux-away is now known as itlinux16:13
*** itlinux is now known as itlinux-away16:14
*** harlowja has joined #openstack-nova16:17
*** itlinux-away is now known as itlinux16:18
*** itlinux is now known as itlinux-away16:18
*** Bhujay has joined #openstack-nova16:19
*** itlinux-away is now known as itlinux16:21
*** davidsha has quit IRC16:24
*** jpena is now known as jpena|off16:25
*** mriedem_sudsy is now known as mriedem16:26
*** ttsiouts has quit IRC16:30
*** ttsiouts has joined #openstack-nova16:30
sean-k-mooneymriedem: am im going to drop for dinner. i might be online later. was there anything else you wanted me to take a look at for RC3?16:32
mriedemsean-k-mooney: no i think we're good, thanks again16:35
*** ttsiouts has quit IRC16:35
sean-k-mooneymriedem: no worries.16:35
sean-k-mooneyo/16:35
*** moshele has joined #openstack-nova16:36
*** sahid has quit IRC16:36
*** sean-k-mooney has quit IRC16:36
*** udesale has quit IRC16:40
*** harlowja has quit IRC16:40
*** Swami has quit IRC16:49
mriedemmelwitt: questions in https://review.openstack.org/#/c/595455/16:55
melwittlooking16:56
*** gbarros has joined #openstack-nova16:57
melwittmriedem: replied. I think you answered my question though, I need to call out cells v1 in both places17:02
melwittI was worried about people confusing it with cells v2. maybe I'll say cells v1, legacy cells17:02
*** davidsha has joined #openstack-nova17:03
openstackgerritDan Smith proposed openstack/nova master: Make instance_list perform per-cell batching  https://review.openstack.org/59313117:04
openstackgerritDan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister  https://review.openstack.org/59426517:04
openstackgerritDan Smith proposed openstack/nova master: Optimize global marker re-lookup in multi_cell_list  https://review.openstack.org/59457717:04
*** Bhujay has quit IRC17:08
*** moshele has quit IRC17:09
mriedemat this point, anyone using cells v1 knows what we mean when we say v117:13
mriedemhttps://docs.openstack.org/nova/latest/user/cells.html17:14
mriedemfor people that don't know the difference, ^ i hope they can read17:14
*** sambetts_ is now known as sambetts|afk17:15
melwittmaybe I'll link to that too17:16
melwittwell yeah, I was worried about the inverse. non cells v1 people thinking they have cells v1 because they have "cells"17:16
mriedemi think specifically calling out cells "v1" makes that clear17:24
mriedemif i don't know, i'm likely going to ask, "there are multiple versions?"17:24
*** penick has joined #openstack-nova17:25
*** penick has quit IRC17:27
*** holser_ has quit IRC17:28
mriedemjaypipes: i just want to say, before i go "meet the teacher", that if you hadn't birthed placement from your loins it wouldn't exist, so, you know, thanks and stuff17:35
mriedemthat seems to be lost a bit in this17:36
*** mriedem is now known as mriedem_away17:36
*** holser_ has joined #openstack-nova17:36
jaypipesmriedem_away: there's lots of contributors to placement. but thank you.17:37
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: tests: Create functional libvirt test base class  https://review.openstack.org/40705517:37
*** gbarros has quit IRC17:46
*** dtantsur is now known as dtantsur|afk17:46
*** noonedeadpunk has quit IRC17:49
*** tssurya has quit IRC17:52
*** holser_ has quit IRC17:53
*** N3l1x has joined #openstack-nova18:01
*** adrianc has quit IRC18:08
*** bbbbzhao_ has quit IRC18:14
*** mriedem_away is now known as mriedem18:17
*** r-daneel has joined #openstack-nova18:24
*** penick has joined #openstack-nova18:26
mriedemmelwitt: so i'm not strong on this vif type / virtio stuff in https://review.openstack.org/#/c/595592/18:29
mriedemi can take a crack at a reno, which based on sahid's comment would be, "rx/tx queues only work with vif_model=virtio"18:29
mriedemwhich is (1) configurable per image with the hw_vif_model property or globally in nova.conf via the (2) [libvirt]/use_virtio_for_bridges option18:30
melwittmriedem: ack. did stephenfin give any ideas too or?18:31
mriedembut without someone around that understands this to actually ack my wording it's tough18:31
mriedemnot in the patch18:31
mriedemor ic18:31
mriedem*irc18:31
mriedemso no18:31
melwittdangit18:32
dansmithmriedem: I think that's legit18:33
dansmithsetting the queues only works with certain versions of qemu, libvirt, and on certain vif types18:34
mriedemfrom moshe's paste,18:34
mriedemhe's not using virtio vif model b/c it's not in the interface xml18:34
mriedemso he must have use_virtio_for_bridges=False in nova.conf18:34
dansmithI dunno about the interacton with that config though18:34
mriedemgetting things to work is basically the hellraiser cube18:35
mriedemthe release note for the feature says, "Only supported for vhost/vhostuser interfaces"18:36
mriedemso,18:36
mriedemi think we're probably covered enough here18:37
mriedemi can't really wordsmith this better than what's already in the reno18:37
mriedemor config option help18:37
mriedemand given these options don't have default values, you have to opt into it18:37
mriedemso buyer beware18:37
mriedemhttps://github.com/openstack/nova/blob/e731813796764a1034e7e16a6c154c8831984c9b/releasenotes/notes/bp-libvirt-virtio-set-queue-sizes-6c54a2ce3dc30d18.yaml#L618:38
mriedemhttps://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/conf/libvirt.py#L121318:38
*** r-daneel_ has joined #openstack-nova18:38
*** hemna_ has quit IRC18:39
*** _hemna has quit IRC18:39
*** r-daneel has quit IRC18:40
*** r-daneel_ is now known as r-daneel18:40
*** gcb_ has quit IRC18:41
mriedemmelwitt: so punt on that for rc3 is what i'm saying18:41
melwittthat is ideal. thanks18:42
*** efried is now known as efried_afk18:43
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events  https://review.openstack.org/59586418:44
mriedem^ is the other one you needed18:44
*** pcaruana has joined #openstack-nova18:52
mriedemdansmith: melwitt: btw, our public cloud guy was fine with the option to 500 if users are listing and have servers in down cells18:52
dansmithsweet18:52
melwitt*thumbs up*18:53
*** davidsha has quit IRC18:56
*** cdent has quit IRC19:02
*** tssurya has joined #openstack-nova19:02
*** awaugama has quit IRC19:07
*** pcaruana has quit IRC19:09
*** awaugama has joined #openstack-nova19:10
*** awaugama has joined #openstack-nova19:16
*** gcb_ has joined #openstack-nova19:18
openstackgerritmelanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59545519:21
*** awaugama has quit IRC19:21
*** awaugama has joined #openstack-nova19:22
openstackgerritmelanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59545519:24
*** eharney has quit IRC19:25
melwittmriedem: ^ updated the release note patch19:28
mriedemso the config option help doesn't need to be updated?19:29
melwittoh, sorry. I missed that19:30
mriedemlooks ok otherwise19:32
mriedemjust update the option help and i think we're good19:32
openstackgerritmelanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59545519:37
melwittmriedem ^19:41
*** mdrabe has quit IRC19:41
*** mdrabe has joined #openstack-nova19:43
*** awaugama has quit IRC19:45
*** jaypipes has quit IRC19:46
*** jaypipes has joined #openstack-nova19:47
*** gbarros has joined #openstack-nova19:57
*** holser_ has joined #openstack-nova20:05
*** panda has quit IRC20:05
openstackgerritMerged openstack/nova stable/rocky: block_device: Rollback volumes to in-use on DeviceDetachFailed  https://review.openstack.org/59080120:17
openstackgerritMerged openstack/nova stable/queens: block_device: Rollback volumes to in-use on DeviceDetachFailed  https://review.openstack.org/59080320:17
*** gbarros has quit IRC20:34
mriedemmelwitt: +220:38
mriedemnow to find another core20:38
melwittthanks20:38
melwittjaypipes: are you still around? can you hit this for rc3 please? https://review.openstack.org/59545520:39
melwittgoing to have to wait for APAC folk, methinks20:46
*** holser_ has quit IRC20:47
*** hamzy has quit IRC20:48
mriedemis dansmith around?20:50
*** gbarros has joined #openstack-nova20:50
melwittno, he started his day at 5am today so is off by now20:50
mriedemoh20:51
melwitthad a 5am meeting20:51
mriedemand efried_afk is afk20:51
mriedemhow about i just +W?20:51
melwittcould. I was thinking I have to be around to get stable cores for the stable/rocky backports anyway, so wasn't sure20:52
mriedemtonyb is here for stable20:52
melwitthttps://review.openstack.org/594508 hasn't merged yet, still need review on the backport20:52
melwittonce that merges20:52
mriedemhttps://review.openstack.org/#/c/595455/ approved, can you propose the backport?20:54
melwittyarp. I should have proposed the other one too so you could review it. wasn't thinking20:54
openstackgerritmelanie witt proposed openstack/nova stable/rocky: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59589020:55
melwittdangit, cherry-pick button doesn't do -x20:55
mriedemnot until it's merged20:55
melwittoh ok20:55
melwittthat's what I get for trying buttons20:55
openstackgerritmelanie witt proposed openstack/nova stable/rocky: Correct the release notes related to nova-consoleauth  https://review.openstack.org/59589020:57
dansmithmriedem: melwitt I put another +2 on 59545521:01
dansmithis that all?21:01
mriedemand https://review.openstack.org/#/c/595864/21:02
melwittdansmith: need stable review for this https://review.openstack.org/595864 master change not merged yet, so we'll have to hold till later for the second +221:03
melwittmeaning, I'll ask tonyb after the master change lands21:03
melwittfor the +W21:03
openstackgerritSurya Seetharaman proposed openstack/nova-specs master: Handling a down cell  https://review.openstack.org/59589221:03
dansmithmelwitt: okay I slapped a +2 on there21:04
melwittthx21:05
*** erlon has quit IRC21:05
melwittok, cool. just have to babysit the patches through the gate, get tonyb for the backports, then should be good to go21:06
*** david-lyle has joined #openstack-nova21:15
*** gbarros has quit IRC21:15
openstackgerritMerged openstack/nova master: Normalize dashless 'resource provider create' uuid  https://review.openstack.org/56719121:16
*** dklyle has quit IRC21:17
*** owalsh_ has joined #openstack-nova21:22
*** owalsh has quit IRC21:25
*** dpawlik has joined #openstack-nova21:26
*** owalsh_ has quit IRC21:26
*** owalsh has joined #openstack-nova21:27
openstackgerritMerged openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events  https://review.openstack.org/59450821:30
*** dpawlik has quit IRC21:30
openstackgerritMerged openstack/nova master: Update contributor guide for Stein  https://review.openstack.org/59125821:30
openstackgerritMerged openstack/nova master: [placement] Add functional test to verify presence of policy  https://review.openstack.org/59555921:30
mriedemtonyb: can you hit this for RC3? https://review.openstack.org/#/c/595864/21:34
*** panda has joined #openstack-nova21:34
tonybmriedem: done21:37
tonybanything else you need for RC3 you knwo where I am21:38
mriedemthe bottom of the world?21:40
*** dpawlik has joined #openstack-nova21:40
*** tssurya has quit IRC21:42
*** tssurya has joined #openstack-nova21:42
*** mriedem is now known as mriedem_afk21:43
*** tssurya has quit IRC21:43
*** dpawlik has quit IRC21:45
*** rcernin has joined #openstack-nova21:46
* melwitt will bbl22:08
*** r-daneel_ has joined #openstack-nova22:08
*** r-daneel has quit IRC22:10
*** r-daneel_ is now known as r-daneel22:10
*** owalsh has quit IRC22:18
*** owalsh has joined #openstack-nova22:22
*** N3l1x has quit IRC22:35
openstackgerritMerged openstack/nova master: Add functional test for affinity with multiple cells  https://review.openstack.org/58507322:50
*** threestrands has joined #openstack-nova22:53
*** hamzy has joined #openstack-nova23:18
*** macza has quit IRC23:21
*** mlavalle has quit IRC23:28
*** jaypipes has quit IRC23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!