| *** shaohe_feng has quit IRC | 00:01 | |
| *** shaohe_feng has joined #openstack-nova | 00:02 | |
| *** moshele has joined #openstack-nova | 00:04 | |
| *** shaohe_feng has quit IRC | 00:12 | |
| *** shaohe_feng has joined #openstack-nova | 00:12 | |
| *** phuongnh has joined #openstack-nova | 00:12 | |
| *** shaohe_feng has quit IRC | 00:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | 00:23 |
|---|---|---|
| openstackgerrit | Merged openstack/os-vif master: Remove unnecessary pyNN testenv sections https://review.openstack.org/577686 | 00:24 |
| *** shaohe_feng has joined #openstack-nova | 00:24 | |
| openstackgerrit | Merged openstack/os-vif master: Remove [tox:jenkins] section from tox.ini https://review.openstack.org/580886 | 00:30 |
| *** shaohe_feng has quit IRC | 00:32 | |
| *** shaohe_feng has joined #openstack-nova | 00:33 | |
| *** vivsoni has joined #openstack-nova | 00:37 | |
| *** yamamoto has joined #openstack-nova | 00:40 | |
| *** vivsoni_ has quit IRC | 00:40 | |
| *** shaohe_feng has quit IRC | 00:42 | |
| *** shaohe_feng has joined #openstack-nova | 00:43 | |
| *** yamamoto has quit IRC | 00:45 | |
| *** phuongnh has quit IRC | 00:45 | |
| gmann | mriedem: alex_xu yeah, those are being ignored as per additionalProporties=True | 00:48 |
| gmann | mriedem: alex_xu same legacy issue we had to keep about --all-tenant which i tired to fix but its more UX tradeoff and where we should fix in APi or on client side - https://review.openstack.org/#/c/198184/ | 00:49 |
| gmann | mriedem: alex_xu how about doing additionalProperties=False with microversion in stein so that user can get clear 400 instead of confusing ignore things. | 00:50 |
| gmann | and we can include more API fixes in that as mriedem said. i can start a etherpad for that and then we choose appropriate issues to fix in single version bump | 00:50 |
| gmann | if you guys have not started that yet | 00:51 |
| *** chyka has joined #openstack-nova | 00:51 | |
| *** shaohe_feng has quit IRC | 00:53 | |
| openstackgerrit | Merged openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | 00:53 |
| *** shaohe_feng has joined #openstack-nova | 00:54 | |
| *** moshele has quit IRC | 00:55 | |
| *** chyka has quit IRC | 00:56 | |
| *** hongbin has joined #openstack-nova | 00:59 | |
| mriedem | gmann: no one has started an etherpad yet | 01:02 |
| *** rnoriega has quit IRC | 01:02 | |
| gmann | mriedem: ok. | 01:03 |
| *** shaohe_feng has quit IRC | 01:03 | |
| *** shaohe_feng has joined #openstack-nova | 01:04 | |
| *** stakeda has joined #openstack-nova | 01:04 | |
| *** edmondsw has joined #openstack-nova | 01:05 | |
| Kevin_Zheng | mriedem Hi, thanks for the review on my patch, I have one question and I left a comment on yikun's patch yesterday, | 01:05 |
| mriedem | ok | 01:06 |
| Kevin_Zheng | on what scenario should I bump compute version to 5.1 and what scenario to 5.0? | 01:06 |
| Kevin_Zheng | like the last 3 bump was still 5.0 but added 3 versions | 01:06 |
| mriedem | those were for behavioral changes | 01:07 |
| mriedem | the rpc api version itself changes if the rpc api changes | 01:07 |
| mriedem | like adding/changing parameters in an rpc api method | 01:07 |
| mriedem | like you did in live_migration_abort | 01:07 |
| mriedem | e.g. # Version 31: The compute manager checks if 'trusted_certs' are supported | 01:07 |
| Kevin_Zheng | OK, I got it, that also what I thought | 01:07 |
| mriedem | there is a version check for minimum nova-compute >= 31 if trying to create a server with trusted_certs | 01:08 |
| Kevin_Zheng | ok, so it checks for 31 instead of 5.0 | 01:08 |
| *** yamahata has quit IRC | 01:08 | |
| mriedem | yeah because 5.0 doesn't really tell us if trusted_certs is supported in the compute or not | 01:08 |
| Kevin_Zheng | got it | 01:09 |
| Kevin_Zheng | I think I will reply other comments in the patch :) | 01:09 |
| mriedem | similar to yikun's late affinity check policy change | 01:09 |
| *** edmondsw has quit IRC | 01:09 | |
| mriedem | it's a behavior change in how we check late affinity on the compute | 01:09 |
| mriedem | not an actual interface change in the rpc api | 01:09 |
| *** BrinZhang has joined #openstack-nova | 01:13 | |
| *** shaohe_feng has quit IRC | 01:13 | |
| *** shaohe_feng has joined #openstack-nova | 01:14 | |
| *** rnoriega has joined #openstack-nova | 01:16 | |
| *** shaohe_feng has quit IRC | 01:23 | |
| *** luzC has quit IRC | 01:24 | |
| *** shaohe_feng has joined #openstack-nova | 01:25 | |
| *** luzC has joined #openstack-nova | 01:28 | |
| Kevin_Zheng | mriedem replied on https://review.openstack.org/#/c/573136/ about why 2.24 sample files were added | 01:28 |
| Kevin_Zheng | I will try to be more clear about this, tring to remember all the details, has been a long time :) | 01:29 |
| *** mrsoul has joined #openstack-nova | 01:30 | |
| *** mrsoul`` has joined #openstack-nova | 01:30 | |
| *** jdillaman has quit IRC | 01:33 | |
| *** mrsoul` has quit IRC | 01:33 | |
| *** mschuppert has quit IRC | 01:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update some placement docs to reflect modern times https://review.openstack.org/581151 | 01:33 |
| *** shaohe_feng has quit IRC | 01:34 | |
| openstackgerrit | Merged openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | 01:34 |
| *** shaohe_feng has joined #openstack-nova | 01:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | 01:34 |
| mriedem | Kevin_Zheng: i saw the inheritance but i still don't really understand it | 01:34 |
| Kevin_Zheng | mriedem, yeah, I'm trying to remember it but forgot some of the details. | 01:36 |
| mriedem | i see that we don't have any api samples for ServerMigrationsSampleJsonTestV2_24 | 01:37 |
| Kevin_Zheng | yeah, because it dont have microversion | 01:37 |
| mriedem | i think it's the _read_template method | 01:38 |
| mriedem | Kevin_Zheng: can you fix that separately? | 01:38 |
| Kevin_Zheng | it has api.microversion and read_template uses self.microversion | 01:38 |
| mriedem | fix the 2.24 api samples tests in a separate change before your new microversion | 01:38 |
| mriedem | hell push that up outside of the series now and i'll approve it | 01:39 |
| Kevin_Zheng | I don't know, because it was correct before my adding | 01:39 |
| Kevin_Zheng | OK | 01:39 |
| Kevin_Zheng | I still want to tell you the root cause though :) | 01:39 |
| mriedem | i see the root issue, | 01:39 |
| Kevin_Zheng | it is something in the setup | 01:39 |
| mriedem | yeah i see that | 01:39 |
| mriedem | ServerMigrationsSamplesJsonTestV2_23 is doing it correctly | 01:40 |
| Kevin_Zheng | OK then I will make it a seperate patch | 01:40 |
| Kevin_Zheng | I have to rebase anyway | 01:40 |
| mriedem | the 2.24 api sample test is posting the live migration and deleting it with 2.24 but using the 2.1 sample | 01:41 |
| mriedem | because the actual request didn't change between then it works | 01:41 |
| *** yamamoto has joined #openstack-nova | 01:42 | |
| Kevin_Zheng | Ah, I got it | 01:42 |
| Kevin_Zheng | if we inherent 2.24 | 01:42 |
| Kevin_Zheng | it was setup first | 01:43 |
| Kevin_Zheng | and then again self.api.microversion was assigned to be 2.25 | 01:43 |
| Kevin_Zheng | 2.24 | 01:43 |
| Kevin_Zheng | because self.api.microversion=2.24 is after super.setup() | 01:44 |
| *** shaohe_feng has quit IRC | 01:44 | |
| *** tiendc has joined #openstack-nova | 01:44 | |
| *** shaohe_feng has joined #openstack-nova | 01:45 | |
| Kevin_Zheng | and since it is wrpped in setUp, I can do nothing | 01:45 |
| mriedem | yup | 01:46 |
| Kevin_Zheng | yeah, I'm still young, I can remember things | 01:47 |
| *** yamamoto has quit IRC | 01:47 | |
| mriedem | what were we talking about again? | 01:48 |
| Kevin_Zheng | I cant remember | 01:48 |
| *** yamamoto has joined #openstack-nova | 01:51 | |
| *** yikun has joined #openstack-nova | 01:52 | |
| *** shaohe_feng has quit IRC | 01:54 | |
| *** shaohe_feng has joined #openstack-nova | 01:55 | |
| *** jichen has joined #openstack-nova | 01:59 | |
| *** mriedem has quit IRC | 02:00 | |
| *** mriedem has joined #openstack-nova | 02:01 | |
| *** shaohe_feng has quit IRC | 02:04 | |
| *** shaohe_feng has joined #openstack-nova | 02:05 | |
| *** hshiina has joined #openstack-nova | 02:06 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 02:07 |
| *** yamamoto has quit IRC | 02:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581548 | 02:13 |
| *** yamamoto has joined #openstack-nova | 02:15 | |
| *** shaohe_feng has quit IRC | 02:15 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 02:15 |
| *** tetsuro has joined #openstack-nova | 02:15 | |
| *** shaohe_feng has joined #openstack-nova | 02:15 | |
| jichen | alex_xu: API meeting 2pm today ? | 02:17 |
| yikun | mriedem: hi, a question on policy notification, should we also do type convert in notification? | 02:18 |
| openstackgerrit | Merged openstack/os-vif master: Fix docstrings to work with Sphinx 1.7.4 https://review.openstack.org/577028 | 02:18 |
| yikun | ^ https://review.openstack.org/#/c/563401/28/nova/tests/unit/compute/test_compute_utils.py@1181 | 02:18 |
| yikun | I mean should we change {"max_server_per_host": "3"} to {"max_server_per_host": 3} in notification | 02:19 |
| mriedem | yikun: i don't think it's necessary to duplicate that type conversion for the notifications | 02:19 |
| yikun | ok, got it, I just thought should keep same format in obj and notification-obj. | 02:22 |
| yikun | and also if user create a group with {"max_server_per_host": 3}, but notification is {"max_server_per_host": "3"} | 02:23 |
| yikun | just not sure it's okay for user or not. | 02:23 |
| mriedem | it doesn't matter too much to me either way, i just don't really like the duplicate code | 02:23 |
| mriedem | you could ask gibi for his opinion when he's up | 02:24 |
| *** shaohe_feng has quit IRC | 02:25 | |
| yikun | gibi: fortunately, gibi is online, could you give me some suggestion on it? | 02:25 |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 02:25 |
| mriedem | it's about 4:30am for gibi | 02:26 |
| mriedem | so he's online but not relaly | 02:26 |
| mriedem | *really | 02:26 |
| mriedem | he's in budapest | 02:26 |
| *** shaohe_feng has joined #openstack-nova | 02:28 | |
| mriedem | i on the other hand need to go to bed | 02:28 |
| mriedem | o/ | 02:28 |
| *** mriedem has quit IRC | 02:28 | |
| yikun | ha, have a good night. | 02:29 |
| *** blkart has quit IRC | 02:31 | |
| *** armaan has quit IRC | 02:31 | |
| *** armaan has joined #openstack-nova | 02:32 | |
| *** blkart has joined #openstack-nova | 02:33 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 02:33 |
| *** bkopilov has quit IRC | 02:35 | |
| *** shaohe_feng has quit IRC | 02:35 | |
| *** shaohe_feng has joined #openstack-nova | 02:38 | |
| gmann | jichen: yes, 2 PM for you. | 02:43 |
| jichen | gmann: got it , thank you, I will arrange my time to join, in this channel, right? | 02:43 |
| gmann | jichen: if you are in china :) its 6 UTC though | 02:43 |
| gmann | jichen: yes, on nova channel only | 02:43 |
| jichen | gmann: yes, I am in china :) | 02:44 |
| *** phuongnh has joined #openstack-nova | 02:44 | |
| *** shaohe_feng has quit IRC | 02:45 | |
| *** shaohe_feng has joined #openstack-nova | 02:47 | |
| *** edmondsw has joined #openstack-nova | 02:53 | |
| *** shaohe_feng has quit IRC | 02:56 | |
| openstackgerrit | Merged openstack/nova master: Remove unused variable in migration https://review.openstack.org/581464 | 02:56 |
| *** shaohe_feng has joined #openstack-nova | 02:56 | |
| *** edmondsw has quit IRC | 02:57 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | 02:58 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 03:00 |
| dansmith | yikun: if you get the .rules from the object, it will be type converted, so you don't need to convert again right? | 03:06 |
| *** shaohe_feng has quit IRC | 03:06 | |
| *** shaohe_feng has joined #openstack-nova | 03:06 | |
| yikun | I think no, because 'rules': fields.DictOfStringsField(nullable=True), it will convert back to orignal by default. | 03:07 |
| yikun | https://review.openstack.org/#/c/563401/29/nova/notifications/objects/server_group.py@46 | 03:07 |
| gmann | dansmith: yikun should we rename 'rules' to 'policy_rules' in REST API - https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 | 03:10 |
| gmann | otherwise it is confusing for users | 03:11 |
| dansmith | yikun: ah you're right I forgot the notification field was typed | 03:11 |
| gmann | in object and notification object 'rules' as it is ok. | 03:11 |
| dansmith | gmann: is it confusing? I guess we should do policy_name and policy_rules? | 03:12 |
| dansmith | personally, I'm okay with policy and rules but if you think it needs scoping, then okay | 03:12 |
| gmann | dansmith: yeah, it was ok under policy dict but if we make out of it then scoping with policy_* is much clear | 03:13 |
| dansmith | gmann: okay | 03:13 |
| dansmith | I've got to go now too, before I turn into a pumpkin | 03:13 |
| gmann | :) gn | 03:13 |
| * dansmith leaves that reference hanging for gmann and yikun to google | 03:13 | |
| *** jichen_ has joined #openstack-nova | 03:15 | |
| gmann | yikun: REST API change need spec update also (as it is nested dict in current version). i can quickly update that after my lunch if you busy with code things? and we can discuss in today API office hour also with alex_xu and feedback from matt and dansmith on gerrit . | 03:16 |
| *** shaohe_feng has quit IRC | 03:16 | |
| *** jichen has quit IRC | 03:17 | |
| *** jichen_ is now known as jichen | 03:17 | |
| *** shaohe_feng has joined #openstack-nova | 03:18 | |
| yikun | gmann: sure, thanks for your help, and I will change api from nest to flat fist. and if we decided change policy_* I will append the change. :) | 03:19 |
| *** shaohe_feng has quit IRC | 03:26 | |
| *** shaohe_feng has joined #openstack-nova | 03:28 | |
| *** shaohe_feng has quit IRC | 03:37 | |
| *** med_ has quit IRC | 03:38 | |
| *** shaohe_feng has joined #openstack-nova | 03:39 | |
| *** hongbin has quit IRC | 03:40 | |
| *** lpetrut_ has joined #openstack-nova | 03:45 | |
| *** shaohe_feng has quit IRC | 03:47 | |
| *** shaohe_feng has joined #openstack-nova | 03:47 | |
| *** sridharg has joined #openstack-nova | 03:48 | |
| *** udesale has joined #openstack-nova | 03:49 | |
| *** bkopilov has joined #openstack-nova | 03:55 | |
| *** david-lyle has joined #openstack-nova | 03:57 | |
| *** shaohe_feng has quit IRC | 03:57 | |
| *** dklyle has quit IRC | 03:58 | |
| *** mlavalle has quit IRC | 03:59 | |
| *** shaohe_feng has joined #openstack-nova | 03:59 | |
| *** dklyle has joined #openstack-nova | 04:00 | |
| *** david-lyle has quit IRC | 04:01 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 04:05 |
| *** shaohe_feng has quit IRC | 04:07 | |
| *** shaohe_feng has joined #openstack-nova | 04:09 | |
| *** jogo has joined #openstack-nova | 04:13 | |
| *** jogo has quit IRC | 04:13 | |
| *** jogo has joined #openstack-nova | 04:13 | |
| *** dklyle has quit IRC | 04:14 | |
| *** dklyle has joined #openstack-nova | 04:14 | |
| *** mdnadeem has joined #openstack-nova | 04:16 | |
| *** shaohe_feng has quit IRC | 04:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 04:18 |
| *** chyka has joined #openstack-nova | 04:18 | |
| *** shaohe_feng has joined #openstack-nova | 04:18 | |
| *** david-lyle has joined #openstack-nova | 04:20 | |
| *** dklyle has quit IRC | 04:21 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 04:22 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 04:22 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 04:22 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 04:22 |
| *** chyka has quit IRC | 04:22 | |
| *** david-lyle has quit IRC | 04:23 | |
| *** dklyle has joined #openstack-nova | 04:23 | |
| *** phuongnh has quit IRC | 04:25 | |
| *** phuongnh has joined #openstack-nova | 04:26 | |
| *** lpetrut_ has quit IRC | 04:27 | |
| *** shaohe_feng has quit IRC | 04:28 | |
| gmann | yikun: sounds good. we can get the consensus on patch first and then update spec for process. | 04:29 |
| *** shaohe_feng has joined #openstack-nova | 04:31 | |
| *** phuongnh has quit IRC | 04:37 | |
| *** phuongnh has joined #openstack-nova | 04:38 | |
| *** shaohe_feng has quit IRC | 04:38 | |
| *** shaohe_feng has joined #openstack-nova | 04:40 | |
| *** shaohe_feng has quit IRC | 04:48 | |
| *** shaohe_feng has joined #openstack-nova | 04:49 | |
| *** abhishekk has joined #openstack-nova | 04:52 | |
| *** Bhujay has joined #openstack-nova | 04:53 | |
| *** flwang1 has quit IRC | 04:55 | |
| *** shaohe_feng has quit IRC | 04:59 | |
| *** Eran_Kuris has quit IRC | 05:00 | |
| *** shaohe_feng has joined #openstack-nova | 05:00 | |
| *** sahid has joined #openstack-nova | 05:01 | |
| *** links has joined #openstack-nova | 05:03 | |
| *** deepak_mourya has joined #openstack-nova | 05:05 | |
| *** shaohe_feng has quit IRC | 05:09 | |
| *** shaohe_feng has joined #openstack-nova | 05:09 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 05:11 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 05:11 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 05:11 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 05:11 |
| *** hamzy has quit IRC | 05:17 | |
| *** ratailor has joined #openstack-nova | 05:18 | |
| *** shaohe_feng has quit IRC | 05:19 | |
| *** shaohe_feng has joined #openstack-nova | 05:19 | |
| *** rodolof has quit IRC | 05:22 | |
| *** moshele has joined #openstack-nova | 05:23 | |
| *** myrat has joined #openstack-nova | 05:26 | |
| openstackgerrit | Merged openstack/nova master: Update some placement docs to reflect modern times https://review.openstack.org/581151 | 05:28 |
| *** shaohe_feng has quit IRC | 05:29 | |
| *** takashin has left #openstack-nova | 05:30 | |
| *** shaohe_feng has joined #openstack-nova | 05:30 | |
| *** janki has joined #openstack-nova | 05:37 | |
| *** shaohe_feng has quit IRC | 05:40 | |
| *** shaohe_feng has joined #openstack-nova | 05:40 | |
| *** hamzy has joined #openstack-nova | 05:40 | |
| *** moshele has quit IRC | 05:41 | |
| *** shaohe_feng has quit IRC | 05:50 | |
| *** stelucz has joined #openstack-nova | 05:51 | |
| stelucz | Hi, I just found in our cluster one nova aggregate with one host. It was probably created by temptest/benchmark in the past. Is it safe to delete this aggregate? or it will have some impact on running VMs at host? | 05:52 |
| *** shaohe_feng has joined #openstack-nova | 05:53 | |
| *** brault has quit IRC | 05:57 | |
| gmann | API office hour time | 05:59 |
| gmann | #startmeeting nova api | 06:00 |
| openstack | Meeting started Wed Jul 11 06:00:01 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:00 |
| *** openstack changes topic to " (Meeting topic: nova api)" | 06:00 | |
| openstack | The meeting name has been set to 'nova_api' | 06:00 |
| gmann | PING List: gmann, alex_xu | 06:00 |
| gmann | who all here today | 06:00 |
| alex_xu | o/ | 06:00 |
| gmann | alex_xu: hi | 06:00 |
| alex_xu | gmann: good afternoon | 06:00 |
| *** shaohe_feng has quit IRC | 06:00 | |
| *** ianw is now known as ianw_pto | 06:00 | |
| gmann | good afternoon | 06:00 |
| jichen | o/ | 06:01 |
| Kevin_Zheng | o/ | 06:01 |
| gmann | jichen: Kevin_Zheng : hi | 06:01 |
| *** shaohe_feng has joined #openstack-nova | 06:01 | |
| gmann | let's start | 06:01 |
| gmann | #link https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda_for_next_Office_hours | 06:01 |
| gmann | ^^ generic agenda for this office hour | 06:02 |
| yikun | o/ | 06:02 |
| gmann | yikun: hi | 06:02 |
| gmann | #topic Priorities | 06:02 |
| *** openstack changes topic to "Priorities (Meeting topic: nova api)" | 06:02 | |
| gmann | #link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | 06:02 |
| gmann | we will go through the API section in above etherpad | 06:02 |
| jichen | ok | 06:03 |
| gmann | line 57 | 06:03 |
| gmann | 1. Servers Ips non-unique network names | 06:03 |
| gmann | spec update is merged last week. #link https://review.openstack.org/#/c/558125/ | 06:03 |
| *** jichen_ has joined #openstack-nova | 06:05 | |
| gmann | Maciej Kucia started code also but month back | 06:05 |
| jichen_ | Is there code patch ? I only saw a doc patch | 06:06 |
| gmann | i do not irc nick and changes should be straight forwards. if no updated since week, may be i can update the code for this BP | 06:06 |
| gmann | yea, that patch only. in same patch code needs to be updated. | 06:06 |
| gmann | i will check with Maciej about progress. | 06:06 |
| gmann | 2.Abort live migration in queued state: | 06:07 |
| jichen_ | ok, got it | 06:07 |
| gmann | this is from Kevin_Zheng and i think good to review from us. i have added this in my today list. | 06:07 |
| *** jichen has quit IRC | 06:07 | |
| Kevin_Zheng | I got a question about this one | 06:08 |
| gmann | Kevin_Zheng: anything you want to discuss on this then review | 06:08 |
| Kevin_Zheng | API related | 06:08 |
| gmann | yeah go head | 06:08 |
| *** jichen has joined #openstack-nova | 06:08 | |
| Kevin_Zheng | in the patch, I have a rpc version check | 06:08 |
| Kevin_Zheng | like if the compute can do 5.1 then it can abort migration in queued status | 06:09 |
| Kevin_Zheng | if cannot do 5.1 | 06:09 |
| Kevin_Zheng | then I trough an exception | 06:09 |
| *** jichen__ has joined #openstack-nova | 06:09 | |
| Kevin_Zheng | my question is, should I mention that compute is not new enoguh? | 06:09 |
| Kevin_Zheng | enough | 06:09 |
| gmann | you mean this - | 06:10 |
| gmann | #link https://review.openstack.org/#/c/568542 | 06:10 |
| Kevin_Zheng | will that be too much admin details for normal user? | 06:10 |
| *** Eran_Kuris has joined #openstack-nova | 06:10 | |
| *** shaohe_feng has quit IRC | 06:10 | |
| Kevin_Zheng | yeah | 06:10 |
| *** jichen___ has joined #openstack-nova | 06:11 | |
| Kevin_Zheng | if it is like what I did in the current patch | 06:11 |
| *** shaohe_feng has joined #openstack-nova | 06:11 | |
| *** jichen___ has quit IRC | 06:11 | |
| Kevin_Zheng | it seems a little wierd, as an user I requested 2.64 and then nova replied to me that migration is not in correct status | 06:11 |
| alex_xu | I think we have some example in the before | 06:11 |
| *** jichen___ has joined #openstack-nova | 06:12 | |
| *** jichen_ has quit IRC | 06:12 | |
| Kevin_Zheng | seems not correct with the mircorversion | 06:12 |
| gmann | yeah i am searching for that | 06:12 |
| Kevin_Zheng | Yeah, we have some, yikun is also working on one with this kind of server version check | 06:12 |
| *** jichen has quit IRC | 06:12 | |
| Kevin_Zheng | just wondering if it is good to let normal user know that some of the node is not new enough | 06:13 |
| *** jichen has joined #openstack-nova | 06:13 | |
| yikun | ^ https://review.openstack.org/#/c/567534/30/nova/api/openstack/compute/server_groups.py@190 | 06:13 |
| gmann | this one - | 06:13 |
| gmann | #link https://github.com/openstack/nova/blob/d3fa585f5e2d11a91ee62744a0cf0c78921a47e4/nova/compute/api.py#L1033 | 06:13 |
| *** myrat has quit IRC | 06:14 | |
| gmann | you can add new exception like this - #link https://github.com/openstack/nova/blob/c8b93fa2493dce82ef4c0b1e7a503ba9b81c2e86/nova/exception.py#L2294 | 06:14 |
| *** jichen__ has quit IRC | 06:14 | |
| *** myrat has joined #openstack-nova | 06:14 | |
| *** jchhatbar has joined #openstack-nova | 06:14 | |
| Kevin_Zheng | hmm that seems better | 06:14 |
| Kevin_Zheng | Yikun, maybe you should do something similar? | 06:15 |
| yikun | yeah, so we should NOT expose something like "all compute services needs upgrade to Rocky" | 06:15 |
| gmann | Kevin_Zheng: we will tell node is old we will just say this feature not supported so that user will contact admin for details | 06:15 |
| Kevin_Zheng | yeah | 06:15 |
| alex_xu | also this one #link https://github.com/openstack/nova/blob/stable/ocata/nova/compute/rpcapi.py#L1114 | 06:15 |
| Kevin_Zheng | maybe the version thing should be appare in the log? | 06:15 |
| gmann | yeah crash dump one alaos | 06:15 |
| *** myrat has quit IRC | 06:15 | |
| gmann | Kevin_Zheng: i think no. | 06:16 |
| *** myrat has joined #openstack-nova | 06:16 | |
| *** jichen___ has quit IRC | 06:16 | |
| Kevin_Zheng | why not, seems better for operators | 06:17 |
| jichen | yes, logs are only viewable to operators... | 06:17 |
| alex_xu | why we didn't check service version instead of rpc version? | 06:17 |
| *** janki has quit IRC | 06:18 | |
| Kevin_Zheng | they are different cases | 06:18 |
| gmann | for which case | 06:18 |
| Kevin_Zheng | yikun's case we check service version | 06:18 |
| *** lpetrut has joined #openstack-nova | 06:18 | |
| Kevin_Zheng | my case check for rpc version | 06:18 |
| Kevin_Zheng | for log, I mean both version | 06:18 |
| Kevin_Zheng | both case | 06:18 |
| gmann | but operator knows features support from reno and microversions info. | 06:19 |
| alex_xu | Kevin_Zheng: I mean your case can be done by the service version check also? | 06:19 |
| *** mrsoul is now known as mschuppert | 06:20 | |
| *** shaohe_feng has quit IRC | 06:21 | |
| Kevin_Zheng | yeah, but this way is similar, I also did some negotiation in rpc | 06:21 |
| gmann | alex_xu: you mean in compute.api.py only like thrust certificate | 06:21 |
| alex_xu | gmann: yea | 06:22 |
| *** shaohe_feng has joined #openstack-nova | 06:22 | |
| gmann | ok, that seems better for me too | 06:22 |
| alex_xu | we can stop the API early, and it is more clear in the code | 06:22 |
| Kevin_Zheng | I don't think so | 06:22 |
| *** andreas_s has joined #openstack-nova | 06:22 | |
| Kevin_Zheng | it is not the same with the certificate one | 06:23 |
| Kevin_Zheng | my patch is depend on the migration status | 06:23 |
| Kevin_Zheng | and it changes | 06:23 |
| Kevin_Zheng | maybe when we check at api, it is not running | 06:23 |
| Kevin_Zheng | but if we check again at rpc, which is the last step before we go to compute | 06:24 |
| Kevin_Zheng | it changed to running | 06:24 |
| Kevin_Zheng | and the API call will be success | 06:24 |
| Kevin_Zheng | it is not like certificate that if it is not supported, it will be always not supported | 06:25 |
| alex_xu | that is very short window... | 06:25 |
| alex_xu | I just feel the rpc version check is very low level. we should have consistent check by the service version in the future. | 06:26 |
| Kevin_Zheng | also | 06:26 |
| Kevin_Zheng | Dan have a comment about this in | 06:27 |
| *** med__ has joined #openstack-nova | 06:27 | |
| *** hamzy has quit IRC | 06:27 | |
| *** hamzy_ has joined #openstack-nova | 06:27 | |
| Kevin_Zheng | https://review.openstack.org/#/c/568542/15/nova/compute/rpcapi.py | 06:27 |
| *** medberry has quit IRC | 06:27 | |
| alex_xu | ah, sounds like similar question, I will read it | 06:28 |
| alex_xu | I think we can move on, continue this discussion on the patch | 06:28 |
| Kevin_Zheng | NP | 06:29 |
| gmann | yeah, let's have discussion on patch and what dansmith is saying. | 06:29 |
| gmann | let's move next | 06:29 |
| gmann | 3. Complex anti-affinity policies: | 06:29 |
| gmann | #link https://review.openstack.org/#/q/topic:bp/complex-anti-affinity-policies+(status:open+OR+status:merged) | 06:29 |
| gmann | this if yikun is working and seems good amount of review | 06:30 |
| gmann | during discussion on falt vs dict representation of policy, REST API response is changing here than what was approved ins epc | 06:31 |
| gmann | which seem better way | 06:31 |
| *** shaohe_feng has quit IRC | 06:31 | |
| *** brault has joined #openstack-nova | 06:31 | |
| gmann | #link https://review.openstack.org/#/c/567534/ | 06:31 |
| gmann | my concern is to make the same for reqeust also | 06:31 |
| *** shaohe_feng has joined #openstack-nova | 06:31 | |
| yikun | yeah, and some question we have: | 06:32 |
| gmann | yikun: any objection on that ^^ and alex_xu what you say about new format of 'policy' in request and response | 06:32 |
| yikun | 1. should we change api response and req to flat policy? | 06:32 |
| yikun | https://review.openstack.org/#/c/546925/18/specs/rocky/approved/complex-anti-affinity-policies.rst@130 | 06:32 |
| yikun | 2. if we change these to flat, should we change to policy_* | 06:33 |
| gmann | i am fine for changing in both. | 06:33 |
| gmann | #link https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 | 06:34 |
| gmann | ^^ this is original discussion | 06:34 |
| gmann | for me flat representation in both request and response with policy_name as string, policy_rules as dict seems good idea | 06:35 |
| yikun | flat vs nest example in here: http://paste.openstack.org/show/725526/ | 06:35 |
| alex_xu | I need to read those discussion | 06:35 |
| gmann | sure, | 06:35 |
| gmann | plan is once we get agreement on thsoe, then yikun can update the spec also to reflect those changes | 06:36 |
| *** alexchadin has joined #openstack-nova | 06:36 | |
| gmann | yikun: anything else you want to discuss or we cna move next | 06:36 |
| alex_xu | yikun: for "rules": {"max_server_per_host": 3}, do you mean "rules": "{"max_server_per_host": 3}" | 06:37 |
| alex_xu | the value of rules is a string? | 06:37 |
| alex_xu | yikun: sorry, I missed understand that, just ignore me | 06:37 |
| yikun | don't worry, you could take a look on example http://paste.openstack.org/show/725526/ | 06:38 |
| *** blkart has quit IRC | 06:38 | |
| yikun | gmann: only these 2 questions for me. :) | 06:39 |
| *** ispp has joined #openstack-nova | 06:39 | |
| gmann | flat2 should have policy_rules than rules_name | 06:39 |
| gmann | like you doing in gerrit | 06:39 |
| *** udesale has quit IRC | 06:40 | |
| yikun | ha,yeah, typo | 06:40 |
| gmann | ok | 06:40 |
| *** cfriesen has quit IRC | 06:41 | |
| *** shaohe_feng has quit IRC | 06:41 | |
| gmann | alex_xu: you want to reply on patch. and we move next ? | 06:41 |
| yikun | http://paste.openstack.org/show/725528/ | 06:41 |
| yikun | new one | 06:41 |
| alex_xu | gmann: yea, I will try to review the patch first | 06:41 |
| gmann | yikun: thanks | 06:42 |
| yikun | alex_xu: gmann ok, thanks | 06:42 |
| gmann | alex_xu: ok | 06:42 |
| *** shaohe_feng has joined #openstack-nova | 06:42 | |
| gmann | only things with new flat format is we need to do validation in code for policy_rules only requested for "anti-affinity" otherwise 400 | 06:42 |
| gmann | but that should be ok. | 06:42 |
| *** udesale has joined #openstack-nova | 06:42 | |
| gmann | let's move next | 06:42 |
| gmann | 4. Volume multiattach enhancements: | 06:43 |
| gmann | matt mentoined in ML that he will be working on this. | 06:43 |
| gmann | once it is ready we can add in our review list | 06:43 |
| *** jichen_ has joined #openstack-nova | 06:44 | |
| gmann | i forgot to mention that yikun BP in in nova runway this week and good to get this in | 06:44 |
| gmann | Kevin_Zheng BP is in for next week so good to review it early and make it in good shape | 06:44 |
| gmann | 5. API Extensions merge work | 06:45 |
| gmann | #link https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/api-extensions-merge-rocky | 06:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:45 |
| gmann | i do not have progress in this BP during this week. | 06:45 |
| *** jichen has quit IRC | 06:45 | |
| gmann | i will update current patch and push more during end of week | 06:46 |
| *** jichen_ is now known as jichen | 06:46 | |
| gmann | last one matt mentioned in ML is handling cell down | 06:46 |
| gmann | #link https://review.openstack.org/#/c/557369/ | 06:46 |
| gmann | i have note read the spec yet but if any of you want to give more feedback there | 06:47 |
| gmann | note->not | 06:47 |
| gmann | anything else on priority item otherwise we move to bug triage things | 06:48 |
| gmann | let' move then | 06:49 |
| gmann | #topic Bug Triage/Discussion | 06:49 |
| *** openstack changes topic to "Bug Triage/Discussion (Meeting topic: nova api)" | 06:49 | |
| gmann | #link https://etherpad.openstack.org/p/nova-api-weekly-bug-report | 06:49 |
| gmann | i updated the weekly bug report | 06:49 |
| gmann | there is not much change in that except i triaged 1 bug. | 06:49 |
| *** moshele has joined #openstack-nova | 06:49 | |
| *** armaan has quit IRC | 06:49 | |
| *** armaan has joined #openstack-nova | 06:50 | |
| gmann | we discussed to keep reviewing 2-3 in-progress bugs patches every week. | 06:50 |
| gmann | which i did not do. :( | 06:50 |
| alex_xu | hah | 06:50 |
| gmann | alex_xu: how about you ? | 06:50 |
| alex_xu | I only review one, and not finish yet | 06:50 |
| alex_xu | #link https://review.openstack.org/#/c/486850/6 | 06:50 |
| alex_xu | thinking of we can make this move on | 06:50 |
| gmann | ohk. | 06:51 |
| *** blkart has joined #openstack-nova | 06:51 | |
| alex_xu | Kevin_Zheng: it is your patch, I'm still thinking we should use environ variable to build a correct url instead of strip the url | 06:51 |
| * gmann forget about this | 06:51 | |
| alex_xu | strip the url is too hacky | 06:51 |
| *** shaohe_feng has quit IRC | 06:51 | |
| Kevin_Zheng | already forgot details about that one :) | 06:52 |
| *** shaohe_feng has joined #openstack-nova | 06:52 | |
| alex_xu | hah | 06:52 |
| alex_xu | use the bug report example. the req.environ['PATH_INFO'] can get '/v2.0', and the req.environ['SCRIPT_NAME'] can get '/compute'. | 06:53 |
| * gmann our home work of cleaning up the in-progress patches is good idea to keep reminding the old work :) | 06:53 | |
| alex_xu | we should be able to figure which part of url is base url | 06:55 |
| *** blkart has quit IRC | 06:56 | |
| alex_xu | Kevin_Zheng: it is ok we can continue the discussion in the patch, since you need remember the detail | 06:56 |
| Kevin_Zheng | yeah, I have to read it again | 06:57 |
| gmann | yea, i think we can recall on patch and continue | 06:57 |
| *** moshele has quit IRC | 06:57 | |
| gmann | i will do more in-progress review before next office hour | 06:57 |
| gmann | 3 min left | 06:58 |
| gmann | anything on bug discussion? | 06:58 |
| gmann | let's move to open in case of anything else | 06:59 |
| gmann | #topic Open Discussion | 06:59 |
| *** openstack changes topic to "Open Discussion (Meeting topic: nova api)" | 06:59 | |
| *** Bhujay has quit IRC | 06:59 | |
| gmann | any more things to bring up ? | 06:59 |
| *** hshiina has quit IRC | 06:59 | |
| Kevin_Zheng | nope | 06:59 |
| gmann | ok let's close the meeting then . | 07:00 |
| gmann | thanks everyone for joining. good to see more people in API discussion :) | 07:00 |
| gmann | #endmeeting | 07:00 |
| *** openstack changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 07:00 | |
| openstack | Meeting ended Wed Jul 11 07:00:40 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 07:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-11-06.00.html | 07:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-11-06.00.txt | 07:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-11-06.00.log.html | 07:00 |
| *** shaohe_feng has quit IRC | 07:02 | |
| alex_xu | gmann: yea, good see a lot of people again :) thanks for leading the meeting | 07:02 |
| *** shaohe_feng has joined #openstack-nova | 07:02 | |
| *** ccamacho has joined #openstack-nova | 07:02 | |
| gmann | alex_xu: np! | 07:03 |
| *** Bhujay has joined #openstack-nova | 07:05 | |
| *** myrat has quit IRC | 07:08 | |
| *** Bhujay has quit IRC | 07:09 | |
| *** tssurya has joined #openstack-nova | 07:12 | |
| *** tesseract has joined #openstack-nova | 07:12 | |
| *** bhagyashri_s has quit IRC | 07:12 | |
| *** shaohe_feng has quit IRC | 07:12 | |
| *** shaohe_feng has joined #openstack-nova | 07:13 | |
| *** Bhujay has joined #openstack-nova | 07:13 | |
| *** blkart has joined #openstack-nova | 07:13 | |
| *** jmlowe has quit IRC | 07:17 | |
| *** peereb has joined #openstack-nova | 07:17 | |
| *** ispp has quit IRC | 07:21 | |
| *** alexchadin has quit IRC | 07:22 | |
| *** shaohe_feng has quit IRC | 07:22 | |
| *** shaohe_feng has joined #openstack-nova | 07:23 | |
| *** ispp has joined #openstack-nova | 07:25 | |
| gmann | alex_xu: scheduler would not come into pic in case of single host right ? i mean anti-affinity will always pass when only single host. | 07:29 |
| *** alexchadin has joined #openstack-nova | 07:31 | |
| gmann | i mean schd will return same single host always | 07:31 |
| *** shaohe_feng has quit IRC | 07:32 | |
| *** shaohe_feng has joined #openstack-nova | 07:33 | |
| *** rodolof has joined #openstack-nova | 07:34 | |
| *** amoralej|off is now known as amoralej | 07:34 | |
| openstackgerrit | huanhongda proposed openstack/nova-specs master: Add .idea folder to .gitignore https://review.openstack.org/581611 | 07:37 |
| *** jichen_ has joined #openstack-nova | 07:40 | |
| *** myrat has joined #openstack-nova | 07:40 | |
| *** jchhatbar has quit IRC | 07:40 | |
| gmann | alex_xu: currently i can boot 2 server on same host in case of anti-affinity policy on my single node env | 07:40 |
| *** janki has joined #openstack-nova | 07:40 | |
| *** jichen has quit IRC | 07:41 | |
| alex_xu | gmann: that is bug? | 07:42 |
| *** jichen_ is now known as jichen | 07:42 | |
| *** shaohe_feng has quit IRC | 07:43 | |
| gmann | alex_xu: donot know, i feel that should fail like it does when i use different_host filter on my single node env | 07:43 |
| *** shaohe_feng has joined #openstack-nova | 07:43 | |
| alex_xu | gmann: I also think so | 07:43 |
| *** rodolof has quit IRC | 07:44 | |
| gmann | bauzas: ^^ | 07:46 |
| *** mago_ has joined #openstack-nova | 07:48 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 07:50 |
| *** shaohe_feng has quit IRC | 07:53 | |
| *** chyka has joined #openstack-nova | 07:54 | |
| *** shaohe_feng has joined #openstack-nova | 07:54 | |
| *** flwang1 has joined #openstack-nova | 07:55 | |
| *** blkart has quit IRC | 07:56 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nit in afc7650e64753ab7687ae2c4f2714d4bb78a4e5a https://review.openstack.org/581616 | 07:58 |
| *** chyka has quit IRC | 07:59 | |
| *** s10 has joined #openstack-nova | 07:59 | |
| *** ttsiouts has joined #openstack-nova | 08:01 | |
| *** rcernin has quit IRC | 08:03 | |
| *** shaohe_feng has quit IRC | 08:03 | |
| *** flwang1 has quit IRC | 08:03 | |
| *** rodolof has joined #openstack-nova | 08:04 | |
| *** bbock has joined #openstack-nova | 08:05 | |
| *** itlinux has joined #openstack-nova | 08:05 | |
| *** shaohe_feng has joined #openstack-nova | 08:05 | |
| *** markvoelker has quit IRC | 08:07 | |
| *** blkart has joined #openstack-nova | 08:09 | |
| *** Bhujay has quit IRC | 08:11 | |
| *** belmoreira has joined #openstack-nova | 08:12 | |
| *** shaohe_feng has quit IRC | 08:13 | |
| *** shaohe_feng has joined #openstack-nova | 08:14 | |
| *** armaan has quit IRC | 08:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 08:16 |
| *** derekh has joined #openstack-nova | 08:21 | |
| *** shaohe_feng has quit IRC | 08:24 | |
| *** shaohe_feng has joined #openstack-nova | 08:25 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | 08:26 |
| *** belmoreira has quit IRC | 08:26 | |
| *** bhagyashris has joined #openstack-nova | 08:29 | |
| *** ragiman has joined #openstack-nova | 08:31 | |
| *** belmoreira has joined #openstack-nova | 08:33 | |
| *** shaohe_feng has quit IRC | 08:34 | |
| *** shaohe_feng has joined #openstack-nova | 08:36 | |
| *** ivve has quit IRC | 08:37 | |
| *** itlinux has quit IRC | 08:37 | |
| *** Luzi has joined #openstack-nova | 08:39 | |
| *** bkopilov has quit IRC | 08:44 | |
| *** armaan has joined #openstack-nova | 08:44 | |
| *** shaohe_feng has quit IRC | 08:44 | |
| *** Luzi has quit IRC | 08:46 | |
| *** shaohe_feng has joined #openstack-nova | 08:46 | |
| *** flwang1 has joined #openstack-nova | 08:50 | |
| *** _pewp_ has quit IRC | 08:53 | |
| *** bbock has left #openstack-nova | 08:53 | |
| *** bbock has joined #openstack-nova | 08:53 | |
| *** _pewp_ has joined #openstack-nova | 08:53 | |
| *** shaohe_feng has quit IRC | 08:54 | |
| *** itlinux has joined #openstack-nova | 08:55 | |
| *** shaohe_feng has joined #openstack-nova | 08:56 | |
| *** alexchadin has quit IRC | 08:57 | |
| *** andreas_s has quit IRC | 08:59 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261 | 08:59 |
| *** andreas_s has joined #openstack-nova | 08:59 | |
| *** andreas_s_ has joined #openstack-nova | 09:00 | |
| *** alexchadin has joined #openstack-nova | 09:00 | |
| *** andreas_s_ has quit IRC | 09:00 | |
| *** andreas_s_ has joined #openstack-nova | 09:01 | |
| *** myrat has quit IRC | 09:01 | |
| *** andreas_s_ has quit IRC | 09:01 | |
| *** s10 has quit IRC | 09:02 | |
| gibi | gmann: I think you see this https://bugs.launchpad.net/nova/+bug/1746863 | 09:03 |
| openstack | Launchpad bug 1746863 in OpenStack Compute (nova) "scheduler affinity doesn't work with multiple cells" [High,In progress] - Assigned to melanie witt (melwitt) | 09:03 |
| *** andreas_s has quit IRC | 09:04 | |
| *** shaohe_feng has quit IRC | 09:05 | |
| gmann | gibi: but i have only single compute node no multi cell. | 09:05 |
| *** shaohe_feng has joined #openstack-nova | 09:05 | |
| gibi | gmann: do you have superconductor? | 09:06 |
| gibi | gmann: for example devstack by default starts with super conductor and cell1 conductor | 09:06 |
| *** alexchadin has quit IRC | 09:08 | |
| *** mgoddard has joined #openstack-nova | 09:09 | |
| gmann | gibi: yeah its superconductor | 09:10 |
| *** alexchadin has joined #openstack-nova | 09:11 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/559034 | 09:12 |
| openstackgerrit | huanhongda proposed openstack/nova-specs master: Return "deleted" time of instance when vm_state is SOFT-DELETED https://review.openstack.org/581638 | 09:13 |
| lyarwood | sahid: ^ can you take a look at that rebase, I can't seem to run tox against stable/ocata on F28 at the moment. | 09:13 |
| gmann | gibi: thanks. | 09:13 |
| *** shaohe_feng has quit IRC | 09:15 | |
| *** shaohe_feng has joined #openstack-nova | 09:16 | |
| gibi | gmann: I have a tempest modification that reproduces the problem https://review.openstack.org/#/c/581349 | 09:16 |
| gibi | gmann: regardin that change I acutally wondering how can I test in tempest that booting in an affinity group goes to NoValid host due to a) the compute having a memeber from the group is full b) the compute is unavailable | 09:20 |
| gibi | gmann: I think I cannot make a compute full or disable in tempest without breaking otuer parallel tempest cases | 09:20 |
| gibi | s/otuer/other/ | 09:21 |
| gmann | gibi: yeah, it is difficult to generate that scenario as we cannot disable compute service or full | 09:25 |
| *** shaohe_feng has quit IRC | 09:25 | |
| gmann | i was thinking with help of quota things but that would generate the scenario you want | 09:25 |
| *** shaohe_feng has joined #openstack-nova | 09:26 | |
| *** Bhujay has joined #openstack-nova | 09:29 | |
| *** tetsuro has quit IRC | 09:29 | |
| *** andreas_s has joined #openstack-nova | 09:30 | |
| *** mgoddard has quit IRC | 09:30 | |
| gibi | gmann: but quota is not per compute so it wont remove a single compute from scheduling | 09:31 |
| gmann | yeah | 09:31 |
| gibi | gmann: another way would be to create a flavor that is bigger than the remaining space on the compute the affinity group members are | 09:31 |
| gmann | but how we would know how big flavor needs to be | 09:32 |
| *** myrat has joined #openstack-nova | 09:32 | |
| gibi | gmann: are the multi node computes has fixed size or it depends on the node they are running? | 09:32 |
| gmann | gibi: it depends on node they are running. | 09:32 |
| gmann | gibi: and it can be any size on non-gate env | 09:33 |
| gibi | gmann: than I would have to ask nova/placement about the available resources to create a big enough flavor | 09:33 |
| gibi | gmann: ahh it is not good | 09:35 |
| *** shaohe_feng has quit IRC | 09:35 | |
| gibi | gmann: I would need a flavor that requests more than available on the group's compute but still fits on the other compute (in multinode) | 09:36 |
| *** shaohe_feng has joined #openstack-nova | 09:36 | |
| gmann | gibi: another idea is to keep booting the server with same_host hint on anti-affinity compute till No-host | 09:37 |
| gmann | but it can be very long scenario tests and need exact enabled_filter on setup | 09:37 |
| gibi | gmann: and that could potentially interfere with test running in paralell | 09:38 |
| *** issp has joined #openstack-nova | 09:38 | |
| gmann | yeah. not good | 09:39 |
| *** alexchadin has quit IRC | 09:39 | |
| *** ispp has quit IRC | 09:41 | |
| gibi | gmann: OK, I conclude that this cannot be covered in tempest. So we need to cover that in nova functional | 09:42 |
| *** belmoreira has quit IRC | 09:43 | |
| *** andreas_s has quit IRC | 09:43 | |
| gmann | gibi: yeah, functional tests is the way | 09:43 |
| gmann | gibi: but for this bug, your patch is ok right? -https://bugs.launchpad.net/nova/+bug/1770434 | 09:43 |
| openstack | Launchpad bug 1746863 in OpenStack Compute (nova) "duplicate for #1770434 scheduler affinity doesn't work with multiple cells" [High,In progress] - Assigned to melanie witt (melwitt) | 09:43 |
| gmann | gibi: i mean doing multiple request not single | 09:44 |
| gibi | gmann: yeah, that seems doable. I will push a new PS soon fixing the TODO and mriedem's comments | 09:44 |
| *** cdent has joined #openstack-nova | 09:44 | |
| gibi | gmann: it won't cover affinity + NoValid host case but that I will describe in the commit message | 09:45 |
| gmann | gibi: yeah, because at least covering that scenario is good | 09:45 |
| gmann | yeah | 09:45 |
| gibi | gmann: thanks | 09:45 |
| * gibi heading for lunch | 09:45 | |
| gmann | gibi: i will check that tomorrow. added in my list | 09:45 |
| gibi | gmann: thank you | 09:46 |
| *** shaohe_feng has quit IRC | 09:46 | |
| gmann | time to go home, have good lunch | 09:46 |
| gibi | have a good afternoon | 09:46 |
| *** shaohe_feng has joined #openstack-nova | 09:47 | |
| *** belmoreira has joined #openstack-nova | 09:48 | |
| *** mgoddard has joined #openstack-nova | 09:49 | |
| *** mago_ has quit IRC | 09:50 | |
| *** jmlowe has joined #openstack-nova | 09:50 | |
| *** andreas_s has joined #openstack-nova | 09:52 | |
| yikun | gibi: hi | 09:53 |
| yikun | could you take a look on | 09:53 |
| yikun | https://review.openstack.org/#/c/563401/31/nova/tests/unit/compute/test_compute_utils.py@1179 | 09:53 |
| yikun | should we change {"max_server_per_host": "3"} to {"max_server_per_host": 3} keep same use user passed? | 09:55 |
| *** shaohe_feng has quit IRC | 09:56 | |
| yikun | we do conversion thing in group obj, see https://review.openstack.org/#/c/563375/39/nova/objects/instance_group.py@140 | 09:56 |
| *** belmoreira has quit IRC | 09:57 | |
| *** alexchadin has joined #openstack-nova | 09:57 | |
| *** shaohe_feng has joined #openstack-nova | 09:58 | |
| yikun | I'm not sure should we keep same with it. | 10:00 |
| *** alexchadin has quit IRC | 10:00 | |
| yikun | and here is some message history: | 10:00 |
| yikun | http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-07-11.log.html#t2018-07-11T02:18:53 | 10:00 |
| *** sambetts|afk is now known as sambetts | 10:00 | |
| yikun | ^ gibi | 10:00 |
| *** andreas_s has quit IRC | 10:01 | |
| *** andreas_s has joined #openstack-nova | 10:01 | |
| *** ttsiouts has quit IRC | 10:04 | |
| *** andreas_s has quit IRC | 10:05 | |
| *** ttsiouts has joined #openstack-nova | 10:06 | |
| *** shaohe_feng has quit IRC | 10:06 | |
| *** shaohe_feng has joined #openstack-nova | 10:08 | |
| *** markvoelker has joined #openstack-nova | 10:08 | |
| *** spsurya_ has joined #openstack-nova | 10:08 | |
| *** andreas_s has joined #openstack-nova | 10:09 | |
| *** ttsiouts has quit IRC | 10:10 | |
| *** jmlowe has quit IRC | 10:11 | |
| *** damien_r has quit IRC | 10:12 | |
| *** andreas_s_ has joined #openstack-nova | 10:16 | |
| *** shaohe_feng has quit IRC | 10:16 | |
| *** moshele has joined #openstack-nova | 10:18 | |
| *** shaohe_feng has joined #openstack-nova | 10:18 | |
| *** andreas_s has quit IRC | 10:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | 10:19 |
| *** andreas_s_ has quit IRC | 10:20 | |
| *** moshele has quit IRC | 10:21 | |
| *** alexchadin has joined #openstack-nova | 10:24 | |
| *** andreas_s has joined #openstack-nova | 10:26 | |
| *** shaohe_feng has quit IRC | 10:27 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/559034 | 10:28 |
| *** shaohe_feng has joined #openstack-nova | 10:28 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 10:28 |
| *** bkopilov has joined #openstack-nova | 10:31 | |
| *** psachin has joined #openstack-nova | 10:35 | |
| *** andreas_s has quit IRC | 10:35 | |
| *** Guest88425 has joined #openstack-nova | 10:36 | |
| *** shaohe_feng has quit IRC | 10:37 | |
| *** shaohe_feng has joined #openstack-nova | 10:39 | |
| *** wwriverrat has joined #openstack-nova | 10:39 | |
| *** andreas_s has joined #openstack-nova | 10:40 | |
| *** mago_ has joined #openstack-nova | 10:40 | |
| *** markvoelker has quit IRC | 10:42 | |
| *** wwriverr_ has quit IRC | 10:43 | |
| openstackgerrit | Van Hung Pham proposed openstack/nova master: convert py35 jobs to py3 https://review.openstack.org/581663 | 10:44 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion. https://review.openstack.org/566813 | 10:46 |
| *** shaohe_feng has quit IRC | 10:47 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration https://review.openstack.org/566813 | 10:48 |
| *** blkart has quit IRC | 10:48 | |
| *** shaohe_feng has joined #openstack-nova | 10:48 | |
| *** andreas_s has quit IRC | 10:53 | |
| *** jichen has quit IRC | 10:55 | |
| gibi | yikun: it is on my list | 10:55 |
| *** stelucz has quit IRC | 10:56 | |
| *** cnf has joined #openstack-nova | 10:56 | |
| cnf | hi, anyone know what would cause the creation of a new instance to give me "Block Device Mapping is Invalid" ? | 10:57 |
| cnf | on -cinder, someone said it looks like a nova issue | 10:57 |
| *** shaohe_feng has quit IRC | 10:57 | |
| *** shaohe_feng has joined #openstack-nova | 10:58 | |
| *** yamamoto has quit IRC | 11:01 | |
| *** ttsiouts has joined #openstack-nova | 11:04 | |
| *** blkart has joined #openstack-nova | 11:05 | |
| *** andreas_s has joined #openstack-nova | 11:07 | |
| *** shaohe_feng has quit IRC | 11:08 | |
| *** shaohe_feng has joined #openstack-nova | 11:11 | |
| yikun | gibi: ok, thanks :) | 11:11 |
| *** andreas_s has quit IRC | 11:13 | |
| *** andreas_s has joined #openstack-nova | 11:13 | |
| *** lpetrut has quit IRC | 11:17 | |
| *** shaohe_feng has quit IRC | 11:18 | |
| *** shaohe_feng has joined #openstack-nova | 11:22 | |
| *** Guest88425 has quit IRC | 11:22 | |
| *** blkart has quit IRC | 11:23 | |
| *** blkart has joined #openstack-nova | 11:23 | |
| *** Bhujay has quit IRC | 11:24 | |
| *** shaohe_feng has quit IRC | 11:28 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 11:28 |
| *** chyka has joined #openstack-nova | 11:29 | |
| *** udesale has quit IRC | 11:29 | |
| *** shaohe_feng has joined #openstack-nova | 11:32 | |
| *** chyka has quit IRC | 11:35 | |
| *** EvilienM is now known as EmilienM | 11:36 | |
| *** aloga has quit IRC | 11:37 | |
| *** shaohe_feng has quit IRC | 11:38 | |
| *** shaohe_feng has joined #openstack-nova | 11:39 | |
| *** markvoelker has joined #openstack-nova | 11:40 | |
| *** pchavva has joined #openstack-nova | 11:48 | |
| *** shaohe_feng has quit IRC | 11:49 | |
| *** shaohe_feng has joined #openstack-nova | 11:49 | |
| *** damien_r has joined #openstack-nova | 11:51 | |
| *** alexchadin has quit IRC | 11:56 | |
| *** alexchadin has joined #openstack-nova | 11:57 | |
| *** alexchadin has quit IRC | 11:57 | |
| *** alexchadin has joined #openstack-nova | 11:58 | |
| *** alexchadin has quit IRC | 11:58 | |
| *** alexchadin has joined #openstack-nova | 11:59 | |
| *** alexchadin has quit IRC | 11:59 | |
| *** shaohe_feng has quit IRC | 11:59 | |
| *** alexchadin has joined #openstack-nova | 11:59 | |
| *** shaohe_feng has joined #openstack-nova | 12:00 | |
| *** alexchadin has quit IRC | 12:00 | |
| *** yamamoto has joined #openstack-nova | 12:02 | |
| *** lyan has joined #openstack-nova | 12:05 | |
| *** lyan is now known as Guest92142 | 12:05 | |
| *** alexchadin has joined #openstack-nova | 12:07 | |
| *** BrinZhang has quit IRC | 12:07 | |
| *** shaohe_feng has quit IRC | 12:09 | |
| *** shaohe_feng has joined #openstack-nova | 12:10 | |
| *** markvoelker has quit IRC | 12:12 | |
| *** tianhui has quit IRC | 12:13 | |
| *** yamamoto has quit IRC | 12:15 | |
| *** jmlowe has joined #openstack-nova | 12:16 | |
| *** shaohe_feng has quit IRC | 12:19 | |
| *** amoralej is now known as amoralej|lunch | 12:20 | |
| *** shaohe_feng has joined #openstack-nova | 12:21 | |
| *** markvoelker has joined #openstack-nova | 12:22 | |
| *** ragiman has quit IRC | 12:24 | |
| gibi | yikun: did I expressed my opininon in every open issue in https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 or did I missed something? | 12:26 |
| gibi | yikun: ahh the conversion thing | 12:27 |
| gibi | yikun: i missed that | 12:27 |
| yikun | yep, : ) | 12:27 |
| yikun | conversion | 12:27 |
| gibi | yikun: would it be hard to make the int conversion in the notification body as well? | 12:27 |
| *** edmondsw has joined #openstack-nova | 12:27 | |
| yikun | No, just need put some duplicate code into notification obj. | 12:28 |
| yikun | like https://review.openstack.org/#/c/563375/39/nova/objects/instance_group.py@140 | 12:29 |
| *** alexchadin has quit IRC | 12:29 | |
| *** shaohe_feng has quit IRC | 12:30 | |
| gibi | yikun: I see. We can only store a DictOfString even if your values will be in different types in the future | 12:30 |
| *** shaohe_feng has joined #openstack-nova | 12:30 | |
| gibi | yikun: can we call the rules property from the notification payload generation? let me look a bit deeper in the code... | 12:31 |
| *** udesale has joined #openstack-nova | 12:31 | |
| *** maciejjozefczyk has quit IRC | 12:31 | |
| gibi | yikun: I guess we call the rules property but then we store the result in a DictOfString in the payload as well | 12:32 |
| gibi | yikun: which converts it back to string | 12:32 |
| *** eharney has joined #openstack-nova | 12:32 | |
| yikun | yes, so if we don't do convert, we will get back a "3" | 12:32 |
| gibi | yikun: as we don't have a Dict type with variable value type | 12:32 |
| gibi | yikun: we cannot define a proper field in the payload class | 12:33 |
| *** mriedem has joined #openstack-nova | 12:33 | |
| gibi | yikun: and the payload class is something we think about as a contract for the consumers | 12:33 |
| yikun | yes, at least I can't see a DictField type in ovo. :) | 12:33 |
| gibi | yikun: let's keep it as "3" | 12:34 |
| *** tiendc has quit IRC | 12:34 | |
| gibi | yikun: I would not like to have a DictOfString defined in the class but we would emit an int as a value | 12:34 |
| gibi | in the notification | 12:34 |
| *** udesale_ has joined #openstack-nova | 12:35 | |
| gibi | yikun: commenting it in the review... | 12:35 |
| *** phuongnh has quit IRC | 12:35 | |
| *** udesale_ has quit IRC | 12:36 | |
| *** ttsiouts has quit IRC | 12:36 | |
| *** udesale has quit IRC | 12:36 | |
| *** alexchadin has joined #openstack-nova | 12:37 | |
| gibi | yikun: done | 12:37 |
| gibi | yikun: thanks for your patientes | 12:38 |
| yikun | OK, I see, much thanks for your time and help. :) | 12:38 |
| gibi | s/patientes/patience | 12:38 |
| yikun | :), ha, I know | 12:39 |
| gibi | :) | 12:39 |
| *** ragiman has joined #openstack-nova | 12:39 | |
| *** shaohe_feng has quit IRC | 12:40 | |
| yikun | and it time to leave and back home, have a good day. | 12:40 |
| gibi | good day to you too | 12:40 |
| *** shaohe_feng has joined #openstack-nova | 12:41 | |
| mriedem | gibi: so we're leaving it as a string in the notification payload? | 12:41 |
| gibi | mriedem: yes | 12:41 |
| gibi | mriedem: because the field type is DictOfString and when we finally generate json schemas for notification classes then that will also created from the field typw | 12:42 |
| gibi | type | 12:42 |
| *** med_ has joined #openstack-nova | 12:43 | |
| mriedem | i'm assuming yikun pointed out that for InstanceGroup.rules we coerce the known max_server_per_host field value to an int | 12:44 |
| *** armaan has quit IRC | 12:45 | |
| gibi | mriedem: yes, I saw that. gmann also pointed out that can be lead to some json validation inconvenience | 12:47 |
| gibi | mriedem: if we flatten the API | 12:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip ServerShowV257Test.test_rebuild_server for cells v1 job https://review.openstack.org/581717 | 12:49 |
| *** yamamoto has joined #openstack-nova | 12:50 | |
| *** shaohe_feng has quit IRC | 12:50 | |
| mriedem | for the rest api, we accept strings or ints apparently | 12:51 |
| *** ragiman has quit IRC | 12:51 | |
| *** ttsiouts has joined #openstack-nova | 12:51 | |
| mriedem | which was news to me | 12:51 |
| mriedem | for the positive_integer type | 12:51 |
| *** shaohe_feng has joined #openstack-nova | 12:51 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L238 | 12:51 |
| gibi | mriedem: and we patternmatch, I see | 12:51 |
| mriedem | so i'm not sure why {'max_server_per_host': 3} vs {'max_server_per_host': '3'} | 12:52 |
| mriedem | will make a difference | 12:52 |
| mriedem | tbc, the InstanceGroup.rules doing the cast to int for that value is for internal convenience more than anything, | 12:52 |
| mriedem | so we don't have to remember to cast the value in all of the code that uses it, like the view builder in the api, the scheduler filter and the late affinity check in the compute | 12:52 |
| *** jchhatbar has joined #openstack-nova | 12:53 | |
| gibi | mriedem: I think the api accepts strings for historical reasons | 12:54 |
| *** janki has quit IRC | 12:55 | |
| gibi | mriedem: I sure I'm OK to cast it to int internally for counting and comparison | 12:55 |
| *** med_ has quit IRC | 12:56 | |
| *** myrat has quit IRC | 12:57 | |
| mriedem | ok. i just don't understand the json schema validation concern | 12:57 |
| mriedem | is that a concern for the consumer of the notification? | 12:57 |
| *** belmoreira has joined #openstack-nova | 12:57 | |
| gibi | mriedem: no it is not. I refer to gmann's comment in https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 about the need to move the validation from json to code | 12:59 |
| *** belmoreira has quit IRC | 12:59 | |
| *** shaohe_feng has quit IRC | 13:00 | |
| mriedem | oy | 13:01 |
| mriedem | there is only 1 policy per group, and the rules are applied to that policy on that group, | 13:01 |
| mriedem | we've already named the InstanceGroup.rules field | 13:01 |
| *** openstack has joined #openstack-nova | 13:03 | |
| *** ChanServ sets mode: +o openstack | 13:03 | |
| gibi | yeah that is gmann's point | 13:03 |
| mriedem | which i think is ok, it's like a 2 line validator | 13:03 |
| gibi | I agree | 13:04 |
| mriedem | if group.policy == 'anti-affinity' and group.rules: raise HTTPBadRequest | 13:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Revert "docs: Disable smartquotes" https://review.openstack.org/578841 | 13:04 |
| mriedem | oops | 13:04 |
| mriedem | != 'anti-affinity' | 13:04 |
| *** lifeless has quit IRC | 13:04 | |
| gibi | sure | 13:05 |
| gibi | policy_rule feels a better name for me but I accept rule with a good api doc | 13:05 |
| openstackgerrit | sahid proposed openstack/nova stable/queens: hardware: fix hugepages memory usage per intances https://review.openstack.org/581736 | 13:06 |
| openstack | mriedem: Error: "=" is not a valid command. | 13:08 |
| *** abhishekk has quit IRC | 13:09 | |
| *** janki has joined #openstack-nova | 13:09 | |
| *** jchhatbar has quit IRC | 13:09 | |
| *** shaohe_feng has quit IRC | 13:11 | |
| *** shaohe_feng has joined #openstack-nova | 13:11 | |
| *** amoralej|lunch is now known as amoralej | 13:13 | |
| *** itlinux has quit IRC | 13:14 | |
| *** med_ has joined #openstack-nova | 13:14 | |
| *** med_ has quit IRC | 13:14 | |
| *** med_ has joined #openstack-nova | 13:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581741 | 13:17 |
| mriedem | gibi: i think you might have officially made yourself the other core to review https://review.openstack.org/#/c/563375/ | 13:17 |
| mriedem | dansmith would +2 it but he made some non-trivial changes to it | 13:17 |
| *** spsurya_ has quit IRC | 13:18 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] add error.code on a ConcurrentUpdateDetected https://review.openstack.org/581742 | 13:19 |
| *** aarents1 has joined #openstack-nova | 13:21 | |
| *** shaohe_feng has quit IRC | 13:21 | |
| mriedem | gibi: btw, you've been quite about reviews on the bw resource provider series - what's the status on that? are you looking for reviews on incremental things? is it done end to end or still working on changes for the full stack in nova (and maybe deps in neutron)? | 13:21 |
| mriedem | my giant port binding live migration series is basically blocked on neutron dependencies | 13:21 |
| *** shaohe_feng has joined #openstack-nova | 13:21 | |
| *** burt has joined #openstack-nova | 13:22 | |
| *** aarents has quit IRC | 13:22 | |
| *** alexpilotti has quit IRC | 13:23 | |
| *** armaan has joined #openstack-nova | 13:23 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Test for unsanitized consumer UUID https://review.openstack.org/581137 | 13:24 |
| gibi | mriedem: I will go through the remainings of https://review.openstack.org/#/c/563375/ soon | 13:28 |
| gibi | mriedem: the status of bandwidth is that the code up on review stopped working after the official support for nested allocation_candidate support is merged | 13:29 |
| gibi | mriedem: the solution is to support the new placement API versions from the scheduler report client | 13:29 |
| gibi | mriedem: for that I started with a failing functional test here https://review.openstack.org/#/c/527728/ | 13:30 |
| mriedem | yikun: gmann: alex_xu: so i see there must have been some discussion on https://review.openstack.org/#/c/567534/ and the request format wasn't changed but the response fields were changed...but no comments in the review about that decision? | 13:31 |
| *** shaohe_feng has quit IRC | 13:31 | |
| *** hongbin has joined #openstack-nova | 13:32 | |
| *** shaohe_feng has joined #openstack-nova | 13:34 | |
| alex_xu | mriedem: no decision yet, I will try to go through the review | 13:37 |
| alex_xu | mriedem: do you remember whether we discuss what should we do if the image traits check failed for rebuild https://review.openstack.org/#/c/569498/ ? | 13:38 |
| *** ratailor has quit IRC | 13:39 | |
| *** ttsiouts has quit IRC | 13:41 | |
| *** shaohe_feng has quit IRC | 13:41 | |
| *** shaohe_feng has joined #openstack-nova | 13:42 | |
| mriedem | alex_xu: glancing at the comments, the question is if the instance should be in ACTIVE or ERROR state? | 13:43 |
| alex_xu | mriedem: yea, that is the question | 13:43 |
| mriedem | if we hit the scheduler during rebuild today because the image changes, and we get NoValidHost, we put the instance into ERROR state | 13:43 |
| mriedem | so i'd expect we do the same if the new image traits are invalid for the instance.host - which is essentially the same thing as a NoValidHost we'd get from the scheduler | 13:44 |
| mriedem | you can rebuild an instance in ERROR state btw | 13:45 |
| alex_xu | oh, we can rebuild an instance in error, that sounds better | 13:45 |
| *** ttsiouts has joined #openstack-nova | 13:46 | |
| mriedem | https://review.openstack.org/#/q/Ibb7bee15a3d4ee6f0ef53ba12e8b41f65a1fe999 | 13:46 |
| mriedem | setting the instance to ERROR is a relatively new change | 13:46 |
| *** ragiman has quit IRC | 13:46 | |
| alex_xu | otherwise I feel the user just chocie a wrong image, then his instance get into error, he only can get help from admin | 13:46 |
| *** mdnadeem has quit IRC | 13:46 | |
| mriedem | they can rebuild with a good image | 13:47 |
| mriedem | i remember this change and brought it up during the ptg in dublin | 13:47 |
| mriedem | discussing maybe re-architecting how rebuild works, | 13:47 |
| mriedem | the reason we set it to ERROR state is not just because scheduling failed, | 13:47 |
| *** lifeless has joined #openstack-nova | 13:47 | |
| mriedem | but also because we've changed values on the instance itself in the api before casting to conductor, | 13:47 |
| mriedem | so at that point, we can't rollback those changes | 13:47 |
| mriedem | see my comments in https://review.openstack.org/#/c/536268/ | 13:48 |
| *** Eran_Kuris has quit IRC | 13:50 | |
| alex_xu | mriedem: ah, i see now, that problem is out of the scope https://review.openstack.org/#/c/569498/ | 13:50 |
| *** psachin has quit IRC | 13:51 | |
| mriedem | yup | 13:51 |
| mriedem | i need to review that rebuild + image traits change too | 13:51 |
| mriedem | since i'm the one that got it stuck in committee during spec review | 13:51 |
| *** shaohe_feng has quit IRC | 13:52 | |
| mriedem | dansmith: so you don't see a need to name the new fields in the server group API policy_name and policy_rules right? | 13:52 |
| alex_xu | mriedem: yea | 13:52 |
| *** shaohe_feng has joined #openstack-nova | 13:52 | |
| mriedem | because yikun re-wrote the api change to do that, which makes it inconsistent with both the notification payload and the internal object modeling | 13:52 |
| dansmith | mriedem: I don't, but gmann said he thought it was important | 13:52 |
| mriedem | i don't think it's important or really confusing | 13:53 |
| dansmith | me either | 13:53 |
| mriedem | i think it's more important that we have consistency up and down the stack | 13:53 |
| mriedem | internal and external | 13:53 |
| *** jistr is now known as jistr|mtg | 13:56 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Delete orphan compute nodes before updating resources https://review.openstack.org/579922 | 13:57 |
| *** rmart04 has joined #openstack-nova | 13:57 | |
| *** eharney has quit IRC | 13:58 | |
| *** mriedem has quit IRC | 14:01 | |
| *** shaohe_feng has quit IRC | 14:02 | |
| *** mriedem has joined #openstack-nova | 14:02 | |
| mriedem | gibi: just ping me if / when you need reviews on the bw provider changes | 14:03 |
| *** shaohe_feng has joined #openstack-nova | 14:03 | |
| *** awaugama has joined #openstack-nova | 14:04 | |
| *** armaan has quit IRC | 14:07 | |
| *** armaan has joined #openstack-nova | 14:07 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:08 | |
| openstackgerrit | Merged openstack/nova master: Remove irrelevant comment https://review.openstack.org/578821 | 14:12 |
| *** shaohe_feng has quit IRC | 14:12 | |
| *** shaohe_feng has joined #openstack-nova | 14:13 | |
| *** janki has quit IRC | 14:15 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration https://review.openstack.org/566813 | 14:16 |
| *** alexpilotti has joined #openstack-nova | 14:16 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:16 | |
| *** cfriesen has joined #openstack-nova | 14:18 | |
| *** felipemonteiro_ has quit IRC | 14:20 | |
| *** tidwellr has joined #openstack-nova | 14:20 | |
| *** alexpilotti has quit IRC | 14:21 | |
| *** alexpilotti has joined #openstack-nova | 14:22 | |
| *** shaohe_feng has quit IRC | 14:22 | |
| *** mlavalle has joined #openstack-nova | 14:23 | |
| *** shaohe_feng has joined #openstack-nova | 14:23 | |
| *** Bhujay has joined #openstack-nova | 14:25 | |
| *** alexpilotti has quit IRC | 14:26 | |
| *** linkmark has joined #openstack-nova | 14:28 | |
| *** alexpilotti has joined #openstack-nova | 14:28 | |
| *** Bhujay has quit IRC | 14:30 | |
| *** armaan has quit IRC | 14:31 | |
| *** armaan has joined #openstack-nova | 14:31 | |
| gibi | mriedem: thanks. | 14:33 |
| *** shaohe_feng has quit IRC | 14:33 | |
| efried | alex_xu: Are you still -1 on that change? Given that we've concluded NoValidHost is the right thing, having those logs be ERROR seems appropriate, 对吧 | 14:34 |
| *** shaohe_feng has joined #openstack-nova | 14:34 | |
| *** antosh has joined #openstack-nova | 14:36 | |
| *** spsurya_ has joined #openstack-nova | 14:37 | |
| mriedem | efried: we don't ERROR for NoValidHost in the scheduler | 14:37 |
| mriedem | ERROR means the operator needs to investigate b/c there is a problem in the system, | 14:37 |
| mriedem | in this case, it's really a user error like a 400 | 14:37 |
| mriedem | we don't log errors for that | 14:37 |
| mriedem | debug at most | 14:37 |
| efried | mriedem: So in this case, how would the user know what went wrong? | 14:38 |
| mriedem | do they get a fault recorded? | 14:39 |
| mriedem | set_vm_state_and_notify will record a fault on the instance for the NoValidHost, | 14:39 |
| *** amrith has joined #openstack-nova | 14:40 | |
| mriedem | and the user should be able to see the fault message for the error | 14:40 |
| *** Guest2110 has quit IRC | 14:40 | |
| *** amrith is now known as Guest48940 | 14:40 | |
| mriedem | https://developer.openstack.org/api-guide/compute/faults.html#instance-faults | 14:40 |
| mriedem | which reminds me, you can only see faults for ERROR or DELETED servers, so that's another reason to set the server to ERROR in this case so they can see the fault | 14:41 |
| mriedem | so as long as the NoValidHost has a reasonable message we should be fine | 14:41 |
| mriedem | that would be a good wrinkle for the functional test though right? | 14:42 |
| openstackgerrit | do3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation https://review.openstack.org/578040 | 14:43 |
| *** shaohe_feng has quit IRC | 14:43 | |
| *** markvoelker has quit IRC | 14:44 | |
| mriedem | why is all this shared provider stuff in this change? https://review.openstack.org/#/c/569498/12/nova/tests/functional/libvirt/test_shared_resource_provider.py | 14:44 |
| *** markvoelker has joined #openstack-nova | 14:44 | |
| efried | mriedem: I asked for it. | 14:44 |
| *** shaohe_feng has joined #openstack-nova | 14:45 | |
| efried | mriedem: Because it's important that we're checking all and only providers involved in the allocation. | 14:45 |
| efried | mriedem: So we should also be checking nested, but letting that slide for now because we don't have any scenarios that actually use nested yet. | 14:45 |
| mriedem | hmm, ok. | 14:46 |
| mriedem | and those unit tests look to be completely redundant for conductor | 14:46 |
| mriedem | redundant with the functional tests | 14:46 |
| mriedem | we don't need both for the same scenarios | 14:46 |
| mriedem | https://review.openstack.org/#/c/569498/12/nova/tests/functional/libvirt/test_shared_resource_provider.py is just a really weird location for rebuild tests... | 14:47 |
| efried | if it's testing how shared resource providers are handled by rebuild by libvirt, it seems as good as anything. | 14:48 |
| *** ttsiouts has quit IRC | 14:48 | |
| *** markvoelker has quit IRC | 14:49 | |
| mriedem | the validation being added to conductor is virt-agnostic | 14:49 |
| mriedem | so it's a weird place to have those tests | 14:49 |
| mriedem | is all | 14:49 |
| efried | but libvirt is the only driver that's doing shared providers (properly) at the moment. | 14:50 |
| mriedem | yeah i know, but that doesn't really matter here does it? | 14:50 |
| mriedem | it's just a convenient place to put the tests given the setUp | 14:50 |
| mriedem | we could have just as easily written a functional test that populate providers and allocations in placement and then run rebuild | 14:51 |
| mriedem | anyway, i'm not -1 on it, it's just weird | 14:51 |
| efried | Agree the main motivator was probably convenience as you say. | 14:51 |
| *** shaohe_feng has quit IRC | 14:53 | |
| *** rodolof has quit IRC | 14:53 | |
| *** shaohe_feng has joined #openstack-nova | 14:54 | |
| *** jistr|mtg is now known as jistr | 14:54 | |
| *** ttsiouts has joined #openstack-nova | 14:55 | |
| mriedem | i'd like to nuke all of these checks http://codesearch.openstack.org/?q=We%20need%20to%20mock%20that%20the%20old%20way&i=nope&files=&repos= | 14:57 |
| mriedem | seems we can do that now right? | 14:57 |
| mriedem | oh nvm, we haven't dropped the migrate_instances_add_request_spec online data migration yet | 14:58 |
| *** eharney has joined #openstack-nova | 14:58 | |
| *** alexpilotti has quit IRC | 14:59 | |
| mriedem | dansmith: it's probably not very possible to do a blocker migration for the request spec migration is it? | 14:59 |
| mriedem | since it's api db + multi-cell | 14:59 |
| *** ivve has joined #openstack-nova | 14:59 | |
| mriedem | we could add a nova-status check pretty easily | 14:59 |
| mriedem | iterate all cells and make sure all non-deleted instances have a request spec | 14:59 |
| dansmith | for which migration? | 15:00 |
| dansmith | ah | 15:00 |
| *** alexpilotti has joined #openstack-nova | 15:00 | |
| dansmith | yeah | 15:00 |
| mriedem | migrate_instances_add_request_spec | 15:00 |
| *** alexpilotti has quit IRC | 15:00 | |
| mriedem | yeah - i want to kill all of these "if not request_spec: populate from garbage" in the code | 15:00 |
| dansmith | hah yeah | 15:00 |
| mriedem | we can't do a blocker db migration in db sync | 15:00 |
| *** rodolof has joined #openstack-nova | 15:00 | |
| mriedem | well, shouldn't | 15:00 |
| mriedem | ? | 15:00 |
| mriedem | but nova-status could do the job, i mean this migration has been around since newton | 15:01 |
| dansmith | I think people have also expressed displeasure with the blocker migrations, so any time we're not enforcing some really structural thing (like a column being non-null or something) a nova-status would be better | 15:01 |
| mriedem | so nova-status in rocky and drop in stein | 15:01 |
| mriedem | drop compat in stein i mean | 15:01 |
| dansmith | aye | 15:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add placement.concurrent_udpate to generation pre-checks https://review.openstack.org/581771 | 15:02 |
| *** shaohe_feng has quit IRC | 15:03 | |
| *** TxGirlGeek has joined #openstack-nova | 15:05 | |
| *** shaohe_feng has joined #openstack-nova | 15:05 | |
| *** rodolof has quit IRC | 15:07 | |
| *** shaohe_feng has quit IRC | 15:14 | |
| *** markvoelker has joined #openstack-nova | 15:14 | |
| *** alexchadin has quit IRC | 15:14 | |
| *** shaohe_feng has joined #openstack-nova | 15:14 | |
| *** rmart04 has left #openstack-nova | 15:15 | |
| *** links has quit IRC | 15:16 | |
| tssurya | mriedem: I was trying to understand the marker logic you have in _heal_instances_in_cell (want to do something similar for the migration tool for updating queued_for_delete), wanted to confirm something: every time the command is run it will loop through all the instances which might have been processed before as well right ? like there is no way to check and skip the ones we have already covered. All we can ensure is each time it does m | 15:20 |
| *** yamahata has joined #openstack-nova | 15:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Fix nits in the handling down cell spec https://review.openstack.org/581243 | 15:21 |
| mriedem | tssurya: heal_allocations doesn't use a global marker like map_instances | 15:22 |
| mriedem | so yes today it will hit all instances, | 15:22 |
| tssurya | mriedem: hmm yea | 15:22 |
| mriedem | it's only using a per-cell marker while iterating instances in the cell when we have a limit specified (default of 50) | 15:23 |
| tssurya | because I have two online migration tools which are like this needing a marker logic | 15:23 |
| mriedem | migrate_instances_add_request_spec uses a global marker | 15:23 |
| * tssurya looking | 15:24 | |
| mriedem | so i'd follow that pattern | 15:24 |
| *** shaohe_feng has quit IRC | 15:24 | |
| mriedem | map_instances is slightly different | 15:25 |
| mriedem | it uses a sentinel project_id and munges the last real instance mapping uuid | 15:25 |
| tssurya | yea that I am aware , but I don't want to insert a new row and all | 15:26 |
| mriedem | you're going to have to either way | 15:26 |
| mriedem | otherwise how would you find the marker record between runs of the command? | 15:27 |
| tssurya | ah just looked at migrate_instances_add_request_spec; it is using the same logic | 15:27 |
| tssurya | with a FAKE_UUID | 15:27 |
| mriedem | yes | 15:27 |
| tssurya | what if more than 1 tool has this FAKE_UUID ? | 15:28 |
| mriedem | i don't care about out of tree tools | 15:28 |
| *** jmlowe has quit IRC | 15:28 | |
| mriedem | the alternative is you do like map_instances and use a fake project_id and munge the uuid from an existing mapping | 15:28 |
| mriedem | but some people hate that too | 15:29 |
| mriedem | since it's not a real uuid | 15:29 |
| *** shaohe_feng has joined #openstack-nova | 15:29 | |
| tssurya | uh-huh yea, well I guess it might be better than starting a series of FAKE_UUIDs | 15:29 |
| mriedem | the sentinel uuid is always the same 00000000-0000-0000-0000-000000000000 | 15:30 |
| mriedem | we don't have anything else in nova, as far as i know, that inserts instance mappings with that uuid | 15:30 |
| tssurya | oh okay | 15:31 |
| mriedem | between migrate_instances_add_request_spec and map_instances i'd just personally follow what was done in migrate_instances_add_request_spec | 15:31 |
| mriedem | it's nearly the same thing you need | 15:31 |
| mriedem | minus creating a request spec and all that - so your thing will be much lighter | 15:32 |
| mriedem | one thing about migrate_instances_add_request_spec is that it's not multi-cell aware | 15:32 |
| mriedem | but i think we said in vancouver that running db sync and online data migrations per cell is not a big deal | 15:33 |
| *** yamamoto has quit IRC | 15:33 | |
| tssurya | mriedem: I was just getting to that actually | 15:33 |
| tssurya | thinking if my marker should be in instance_mappings or instances | 15:33 |
| mriedem | L39 https://etherpad.openstack.org/p/YVR18-cellsv2-migration-sync-with-operators | 15:34 |
| tssurya | as I will be fetching deleted (or soft_deleted) instances and then updating only those instance_mappings to true | 15:34 |
| *** shaohe_feng has quit IRC | 15:34 | |
| mriedem | migrate_instances_add_request_spec puts the marker in the request_specs table | 15:34 |
| mriedem | so again, i'd just follow that pattern :) | 15:34 |
| mriedem | since i will assume people thought about all of this when migrate_instances_add_request_spec was written | 15:34 |
| *** kaisers__ has joined #openstack-nova | 15:34 | |
| tssurya | mriedem: okay then! I will go for the same consistency and follow the migrate_instances_add_request_spec stuff | 15:35 |
| *** shaohe_feng has joined #openstack-nova | 15:35 | |
| tssurya | dansmith: are we having cells meeting today ? (I don't have anything new we haven't discussed and have the needed feedback for the spec to work on) | 15:37 |
| dansmith | tssurya: I don't have anything either, mriedem, melwitt ? | 15:38 |
| *** felipemonteiro__ has quit IRC | 15:40 | |
| *** med_ has quit IRC | 15:42 | |
| *** sapd1 has joined #openstack-nova | 15:42 | |
| sapd1 | Hi everyone, How can I remove an object from BlockDeviceMappingList object. | 15:43 |
| *** bbock has quit IRC | 15:43 | |
| *** chyka has joined #openstack-nova | 15:44 | |
| *** tssurya has quit IRC | 15:44 | |
| *** shaohe_feng has quit IRC | 15:44 | |
| mriedem | dansmith: nothing pressing, just starting reviews on tssurya's changes and need reviews on this bug fix which is related to cells v2 (build requests and quota counting): https://review.openstack.org/#/q/topic:bug/1780373+(status:open+OR+status:merged) | 15:45 |
| *** shaohe_feng has joined #openstack-nova | 15:45 | |
| dansmith | ack\ | 15:46 |
| mriedem | sapd1: can you provide more context? | 15:46 |
| *** peereb has quit IRC | 15:46 | |
| openstackgerrit | do3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation https://review.openstack.org/578040 | 15:47 |
| sapd1 | mriedem: I would like to customize bdms list. In this function: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2752 | 15:48 |
| mriedem | sapd1: because you're trying to rebuild a volume-backed instance? | 15:50 |
| mriedem | sapd1: if so, you should read this spec first https://review.openstack.org/#/c/532407/ | 15:51 |
| sapd1 | mriedem: I'm trying, I don't find any change which can work, So I'm trying to make it run. | 15:52 |
| mriedem | well read the spec and discussion in there | 15:54 |
| mriedem | or if you're going to fork it anyway, you could look at https://review.openstack.org/#/c/528740/ but i wouldn't use that method | 15:54 |
| *** andreas_s has quit IRC | 15:54 | |
| *** shaohe_feng has quit IRC | 15:55 | |
| *** andreas_s has joined #openstack-nova | 15:55 | |
| mriedem | there are in fact several attempts at this in https://bugs.launchpad.net/nova/+bug/1378689 | 15:55 |
| openstack | Launchpad bug 1378689 in OpenStack Compute (nova) "error when rebuilding a instance booted from volume" [Undecided,In progress] - Assigned to Jie Li (ramboman) | 15:55 |
| *** issp has quit IRC | 15:55 | |
| *** shaohe_feng has joined #openstack-nova | 15:56 | |
| *** andreas_s has quit IRC | 15:59 | |
| *** tesseract has quit IRC | 16:01 | |
| *** wwriverrat has quit IRC | 16:02 | |
| sapd1 | mriedem: This feature is sound like have too many bugs :D | 16:02 |
| mriedem | well, that's what happens when we add features without thinking about implications to existing APIs | 16:04 |
| mriedem | i'd like to see https://review.openstack.org/#/c/532407/ get agreement on a direction in stein so we can finally fix this | 16:04 |
| *** shaohe_feng has quit IRC | 16:05 | |
| sapd1 | mriedem: Yep, Because attach/detach flow in cinder has changed. So the rebuild process will be failed. | 16:05 |
| mriedem | i'm not sure i follow | 16:05 |
| mriedem | are you talking about the volume attachments API in cinder? | 16:06 |
| *** shaohe_feng has joined #openstack-nova | 16:06 | |
| sapd1 | mriedem: Could you tell me how to remove an item in BlockDeviceMappingList in the function? | 16:06 |
| mriedem | that doesn't really have anything to do with the fact nova has never supported rebuilding a volume-backed server with a new image | 16:06 |
| sapd1 | mriedem: Yep. Because multi-attach was introduced. So attach/detach flow have to change. | 16:07 |
| mriedem | sapd1: those are backward compatible changes and nova opts into using those apis | 16:07 |
| mriedem | so it doesn't really mean anything for what you're trying to do | 16:07 |
| sapd1 | I want to remove old root disk block device mapping in that list. | 16:08 |
| mriedem | we added a change to the api in queens such that you literally cannot rebuild a volume-backed server with a new image | 16:08 |
| mriedem | the user gets an error | 16:08 |
| *** jamesdenton has joined #openstack-nova | 16:08 | |
| mriedem | https://review.openstack.org/#/c/520660/ | 16:09 |
| *** ttsiouts has quit IRC | 16:09 | |
| sapd1 | Use this patch I can bypass https://review.openstack.org/#/c/528740/8/nova/compute/api.py | 16:10 |
| sapd1 | :D | 16:10 |
| mriedem | if you want to fork a hack into your product that's up to you | 16:11 |
| mriedem | but i'm not going to spend time helping you do it, sorry | 16:11 |
| mriedem | i'm only interested in https://review.openstack.org/#/c/532407/ | 16:11 |
| sapd1 | mriedem: So Has anyone implemented this spec yet? | 16:12 |
| mriedem | sapd1: no, see my -1 on the spec | 16:13 |
| mriedem | need to agree on the design first | 16:13 |
| mriedem | which is why the 20 other hack fixes for this problem have been rejected in the past | 16:13 |
| sapd1 | mriedem: I'm trying :D thanks | 16:14 |
| mriedem | my comment from march 27 is where i think it stalled | 16:15 |
| mriedem | "The cleanest / best solution to this is to add a volume action API to cinder for re-imaging the volume. Once that is available in a new cinder v3 microversion, nova can use it. The reason I think this should be done in Cinder with re-imaging the volume there is (1) it's cleaner from the nova side and (2) then Cinder is in control of how that re-image should happen, along with any details it needs to update, e.g. the volume's | 16:15 |
| mriedem | lume_image_metadata" information would need to be updated.We really don't want to do the volume create/delete/swap orchestration thing since that entails issues with the volume type being gone, going over quota, what to do about deleting the old volume, etc.So please propose a spec to Cinder and start working the API changes there and then nova can depend on a new Cinder API." | 16:15 |
| *** maciejjozefczyk has joined #openstack-nova | 16:15 | |
| *** shaohe_feng has quit IRC | 16:15 | |
| mriedem | i think of this like shelve offloading and unshelving a volume-backed server but with a new image | 16:15 |
| mriedem | and i'd like cinder to control the api for re-imaging the volume | 16:16 |
| mriedem | because cinder owns the volume | 16:16 |
| *** shaohe_feng has joined #openstack-nova | 16:16 | |
| mriedem | maybe i need to work with tommylikehu on this in stein | 16:17 |
| mriedem | melwitt: it might not be too early to start a stein ptg etherpad for random items | 16:18 |
| *** mgoddard has quit IRC | 16:18 | |
| *** armaan has quit IRC | 16:21 | |
| *** armaan has joined #openstack-nova | 16:21 | |
| *** efried is now known as efried_off | 16:23 | |
| sapd1 | mriedem: Yep. I think It can work. with this patch. | 16:24 |
| sapd1 | mriedem: http://paste.ubuntu.com/p/V3MhY7Hp3X/ | 16:24 |
| sapd1 | I change flow to detach old root disk device and create attachment ID for new rootdisk device | 16:25 |
| *** shaohe_feng has quit IRC | 16:25 | |
| *** armaan has quit IRC | 16:25 | |
| *** shaohe_feng has joined #openstack-nova | 16:26 | |
| openstackgerrit | Merged openstack/nova master: Test for unsanitized consumer UUID https://review.openstack.org/581137 | 16:27 |
| gibi | mriedem: left comments in the complex-anti-affinity-policies series but I haven't finished yet. I run out of time. I can check the API patch tomorrow if needed | 16:30 |
| *** efried_off has quit IRC | 16:31 | |
| *** efried_off has joined #openstack-nova | 16:31 | |
| *** yamamoto has joined #openstack-nova | 16:33 | |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data https://review.openstack.org/579676 | 16:33 |
| *** shaohe_feng has quit IRC | 16:36 | |
| *** yamahata has quit IRC | 16:39 | |
| *** yamamoto has quit IRC | 16:39 | |
| *** yamahata has joined #openstack-nova | 16:39 | |
| *** shaohe_feng has joined #openstack-nova | 16:39 | |
| *** arvindn05 has quit IRC | 16:45 | |
| *** shaohe_feng has quit IRC | 16:46 | |
| *** shaohe_feng has joined #openstack-nova | 16:47 | |
| *** felipemonteiro has joined #openstack-nova | 16:50 | |
| *** markvoelker has quit IRC | 16:52 | |
| *** shaohe_feng has quit IRC | 16:56 | |
| *** shaohe_feng has joined #openstack-nova | 16:57 | |
| *** derekh has quit IRC | 17:00 | |
| *** yamahata has quit IRC | 17:03 | |
| *** imacdonn has quit IRC | 17:03 | |
| *** imacdonn has joined #openstack-nova | 17:03 | |
| *** sapd1 has quit IRC | 17:04 | |
| *** amoralej is now known as amoralej|off | 17:05 | |
| *** jdillaman has joined #openstack-nova | 17:06 | |
| *** shaohe_feng has quit IRC | 17:06 | |
| *** shaohe_feng has joined #openstack-nova | 17:07 | |
| *** _pewp_ has quit IRC | 17:08 | |
| *** _pewp_ has joined #openstack-nova | 17:09 | |
| *** mago_ has quit IRC | 17:16 | |
| *** shaohe_feng has quit IRC | 17:17 | |
| *** shaohe_feng has joined #openstack-nova | 17:17 | |
| *** moshele has joined #openstack-nova | 17:18 | |
| *** gyee has joined #openstack-nova | 17:21 | |
| *** markvoelker has joined #openstack-nova | 17:24 | |
| melwitt | mriedem: yeah, probably a good idea to start one. I've seen others posted to the ML already, at least for cinder | 17:25 |
| *** shaohe_feng has quit IRC | 17:27 | |
| *** armaan has joined #openstack-nova | 17:27 | |
| *** shaohe_feng has joined #openstack-nova | 17:28 | |
| *** sambetts is now known as sambetts|afk | 17:29 | |
| *** armaan has quit IRC | 17:31 | |
| *** armaan has joined #openstack-nova | 17:32 | |
| *** sahid has quit IRC | 17:32 | |
| *** damien_r1 has joined #openstack-nova | 17:34 | |
| *** damien_r has quit IRC | 17:34 | |
| *** yamamoto has joined #openstack-nova | 17:35 | |
| *** kaisers__ has quit IRC | 17:37 | |
| *** shaohe_feng has quit IRC | 17:37 | |
| *** yamahata has joined #openstack-nova | 17:37 | |
| *** belmoreira has joined #openstack-nova | 17:39 | |
| *** shaohe_feng has joined #openstack-nova | 17:39 | |
| *** yamamoto has quit IRC | 17:41 | |
| *** med_ has joined #openstack-nova | 17:41 | |
| *** moshele has quit IRC | 17:42 | |
| *** felipemonteiro has quit IRC | 17:42 | |
| melwitt | dansmith: I don't have anything for a cells meeting | 17:45 |
| dansmith | ack | 17:45 |
| *** shaohe_feng has quit IRC | 17:47 | |
| *** shaohe_feng has joined #openstack-nova | 17:48 | |
| melwitt | mriedem: comment on https://review.openstack.org/580755 , I've wondered why we don't use the CastAsCall fixture anymore in functional tests where we want to GET servers after we create them. everything else looks good in the tests | 17:50 |
| *** armaan has quit IRC | 17:54 | |
| mriedem | melwitt: because CastAsCall isn't what you'd really get as a real user | 17:56 |
| mriedem | so unless there is a good reason to use, it don't know why we would | 17:56 |
| *** shaohe_feng has quit IRC | 17:58 | |
| mriedem | melwitt: replied inline | 17:58 |
| melwitt | mriedem: I was thinking because of the assumption of the servers before they're active, but in this case "active" is not needed or relevant in the test | 17:58 |
| *** shaohe_feng has joined #openstack-nova | 17:58 | |
| mriedem | right we don't care about status in these tests | 17:59 |
| melwitt | I was thinking POST followed by GET without waiting for the status, but if you don't care about the status, then it doesn't matter. maybe that's the difference. none of the assertions you're doing depend on the boot process being further along | 17:59 |
| melwitt | a few weeks ago I was working on a test that kept failing until I used CastAsCall, but it must have been that an assertion I had depended on the boot process getting to a certain point. sorry for the noise | 18:00 |
| mriedem | we have utilities for waiting for the server to be a certain status as well | 18:01 |
| mriedem | so if i needed to wait, i'd use that instead of CastAsCall | 18:01 |
| * mriedem moves rooms | 18:01 | |
| melwitt | true, I'll keep that in mind for next time | 18:01 |
| *** mriedem1 has joined #openstack-nova | 18:02 | |
| *** maciejjozefczyk has quit IRC | 18:03 | |
| *** maciejjozefczyk has joined #openstack-nova | 18:03 | |
| *** maciejjozefczyk has quit IRC | 18:04 | |
| *** mriedem has quit IRC | 18:05 | |
| *** edmondsw has quit IRC | 18:07 | |
| *** edmondsw has joined #openstack-nova | 18:07 | |
| *** shaohe_feng has quit IRC | 18:08 | |
| *** sridharg has quit IRC | 18:08 | |
| *** shaohe_feng has joined #openstack-nova | 18:09 | |
| *** mriedem1 is now known as mriedem | 18:12 | |
| *** shaohe_feng has quit IRC | 18:18 | |
| *** kuzko has quit IRC | 18:18 | |
| *** shaohe_feng has joined #openstack-nova | 18:20 | |
| openstackgerrit | Merged openstack/nova master: [placement] add error.code on a ConcurrentUpdateDetected https://review.openstack.org/581742 | 18:20 |
| *** shaohe_feng has quit IRC | 18:28 | |
| *** felipemonteiro has joined #openstack-nova | 18:29 | |
| *** shaohe_feng has joined #openstack-nova | 18:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status upgrade check for request spec migrations https://review.openstack.org/581813 | 18:34 |
| *** yamamoto has joined #openstack-nova | 18:37 | |
| *** shaohe_feng has quit IRC | 18:39 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:39 | |
| *** shaohe_feng has joined #openstack-nova | 18:39 | |
| melwitt | mriedem: ptg etherpad if you had some topic(s) you wanted to jot down https://etherpad.openstack.org/p/nova-ptg-stein | 18:41 |
| mriedem | thanks | 18:42 |
| *** felipemonteiro has quit IRC | 18:42 | |
| *** yamamoto has quit IRC | 18:43 | |
| *** tssurya has joined #openstack-nova | 18:48 | |
| *** shaohe_feng has quit IRC | 18:49 | |
| *** itlinux has joined #openstack-nova | 18:49 | |
| *** shaohe_feng has joined #openstack-nova | 18:50 | |
| *** cdent has quit IRC | 18:52 | |
| *** kuzko has joined #openstack-nova | 18:59 | |
| *** shaohe_feng has quit IRC | 18:59 | |
| *** harlowja has joined #openstack-nova | 19:00 | |
| *** itlinux has quit IRC | 19:02 | |
| *** shaohe_feng has joined #openstack-nova | 19:04 | |
| *** tidwellr has quit IRC | 19:05 | |
| *** antosh has quit IRC | 19:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/581845 | 19:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix server_group_members quota check https://review.openstack.org/581846 | 19:06 |
| *** tidwellr has joined #openstack-nova | 19:06 | |
| *** shaohe_feng has quit IRC | 19:09 | |
| *** shaohe_feng has joined #openstack-nova | 19:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/581866 | 19:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix server_group_members quota check https://review.openstack.org/581867 | 19:17 |
| *** antosh has joined #openstack-nova | 19:19 | |
| *** shaohe_feng has quit IRC | 19:20 | |
| *** antosh has quit IRC | 19:20 | |
| *** belmoreira has quit IRC | 19:21 | |
| *** shaohe_feng has joined #openstack-nova | 19:22 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:24 | |
| mriedem | crazy croats | 19:25 |
| *** jmlowe has joined #openstack-nova | 19:29 | |
| *** shaohe_feng has quit IRC | 19:30 | |
| *** flwang1 has quit IRC | 19:30 | |
| *** shaohe_feng has joined #openstack-nova | 19:31 | |
| *** tidwellr has quit IRC | 19:35 | |
| *** mgoddard has joined #openstack-nova | 19:36 | |
| *** tidwellr has joined #openstack-nova | 19:39 | |
| *** maciejjozefczyk has quit IRC | 19:40 | |
| *** yamamoto has joined #openstack-nova | 19:40 | |
| *** shaohe_feng has quit IRC | 19:40 | |
| *** mgoddard has quit IRC | 19:40 | |
| *** mdbooth has quit IRC | 19:41 | |
| *** shaohe_feng has joined #openstack-nova | 19:41 | |
| *** edmondsw has quit IRC | 19:42 | |
| *** edmondsw has joined #openstack-nova | 19:43 | |
| *** yamamoto has quit IRC | 19:45 | |
| *** tidwellr has joined #openstack-nova | 19:46 | |
| *** shaohe_feng has quit IRC | 19:50 | |
| *** shaohe_feng has joined #openstack-nova | 19:51 | |
| *** awaugama has quit IRC | 19:51 | |
| mriedem | dansmith: comments on your bfv req spec change https://review.openstack.org/#/c/580720/ | 19:54 |
| *** itlinux has joined #openstack-nova | 19:55 | |
| *** itlinux has quit IRC | 19:57 | |
| *** TxGirlGeek has quit IRC | 19:59 | |
| *** tidwellr has quit IRC | 20:00 | |
| *** shaohe_feng has quit IRC | 20:01 | |
| dansmith | ooh | 20:02 |
| *** shaohe_feng has joined #openstack-nova | 20:02 | |
| *** pchavva has quit IRC | 20:04 | |
| *** antosh has joined #openstack-nova | 20:04 | |
| *** alexpilotti has joined #openstack-nova | 20:05 | |
| *** TxGirlGeek has joined #openstack-nova | 20:06 | |
| mriedem | so this isn't backportable b/c of the version change, but in thinking about this more - persisting the is_bfv flag is good b/c for any new instances created after this, moving them also benefits from the flag being set | 20:10 |
| mriedem | the only gap is existing instances that don't have is_bfv set in the request spec, as noted in the commit message | 20:10 |
| mriedem | which we can easily detect and heal during a move | 20:10 |
| mriedem | there are a few comments in the bug report about how once people got to ocata the allocations for volume-backed instances were fixed, and that's because the resource tracker had the is_bfv logic to not account for flavor.root_gb, | 20:11 |
| *** shaohe_feng has quit IRC | 20:11 | |
| mriedem | but then in pike we stopped creating allocations in the RT and based the allocations of the request spec, so we regressed that.... | 20:11 |
| mriedem | so this (re)fixes that | 20:12 |
| mriedem | but we'd have a gap in pike and queens | 20:12 |
| dansmith | sorry, was looking at the review window | 20:12 |
| dansmith | I just replied, | 20:12 |
| dansmith | but basically I didn't even consider this as backportable since it changes what we allocate and stuff and thought it wasn't worth the risk | 20:13 |
| mriedem | almost seems like we could do a hybrid of https://review.openstack.org/#/c/428481/ and your new patch which could be backportable | 20:13 |
| dansmith | I'd rather just roll forward and heal | 20:13 |
| mriedem | i get that, | 20:14 |
| *** shaohe_feng has joined #openstack-nova | 20:14 | |
| mriedem | but this is a pretty high flame count bug or whatever | 20:14 |
| mriedem | so backportability seems worth at least thinking through | 20:14 |
| dansmith | our downstream requirement for stuff like this is that you have to be able to yum update components in any order on any machine, and having things starting to claim differently because you updated one conductor and didn't do another until a month later | 20:14 |
| dansmith | even still, the scheduler is the thing that needs to know, not conductor like you said, | 20:14 |
| dansmith | so I'm not sure how we could do it without an object or rpc change | 20:15 |
| dansmith | if this was a regression in the last release then I'd care more I guess, but this has _always_ been this way, which makes it nearly a feature | 20:15 |
| mriedem | well, it was fixed in ocata and then regressed again in pike | 20:16 |
| dansmith | eh? this has never worked that I know of | 20:16 |
| mriedem | i think anyway | 20:16 |
| dansmith | pretty sure not, | 20:16 |
| mriedem | in ocata the computes would create the allocations right? | 20:16 |
| dansmith | ah, but, it has always been broken in RT :) | 20:16 |
| *** tojuvone has quit IRC | 20:16 | |
| mriedem | the RT / report client code that created the allocations in ocata took bfv into account for DISK_GB | 20:16 |
| dansmith | so before we were doing allocations wrong, we were doing RT claiming wrong and failing super late | 20:16 |
| mriedem | RT == claim? | 20:16 |
| mriedem | well, | 20:16 |
| dansmith | I mean old school claims | 20:16 |
| *** tojuvone has joined #openstack-nova | 20:17 | |
| mriedem | if you dropped the DiskFilter you wouldn't hit the claim | 20:17 |
| dansmith | pfft :) | 20:17 |
| mriedem | so in ocata, if you're using placement and remove DiskFilter, | 20:17 |
| mriedem | fixed | 20:17 |
| dansmith | where did we not allocate for volume-backed disks in RT? | 20:17 |
| *** tidwellr has joined #openstack-nova | 20:18 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L169 | 20:18 |
| mriedem | this comment in the bug is a pretty good one https://bugs.launchpad.net/nova/+bug/1469179/comments/37 | 20:18 |
| openstack | Launchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Dan Smith (danms) | 20:18 |
| *** arvindn05 has joined #openstack-nova | 20:18 | |
| mriedem | "After disabling the RamFilter and DiskFilter, and instead relying on the Placement API for scheduling, most of the "scheduling" aspect of this problem has been addressed. I was able to drop a local patch to handle this root_gb!=0 for EBS volumes, and for most real-life use cases it is working. The placement API is not recording disk allocations for EBS volumes." | 20:19 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L351 | 20:19 |
| dansmith | so it kinda worked almost by accident for a release? | 20:20 |
| mriedem | so in ocata we wouldn't report root_gb for bfv instance allocations, you could still fail scheduling due to the old school RT disk claim if DiskFilter was enabled | 20:20 |
| * dansmith isn't convinced | 20:20 | |
| mriedem | i agree with the 'by accident' part | 20:20 |
| mriedem | and i don't think it was until at least pike that we said to disable the DiskFilter if you're using placement and remove it from the default enabled filters | 20:21 |
| *** eharney has quit IRC | 20:21 | |
| dansmith | right, I was thinking ocata still required that | 20:21 |
| dansmith | well, | 20:21 |
| *** shaohe_feng has quit IRC | 20:21 | |
| dansmith | didn't recommend placement as a complete replacement | 20:21 |
| *** shaohe_feng has joined #openstack-nova | 20:22 | |
| mriedem | yeah dropped CPU/Ram/DiskFilters from default enabled filters in pike | 20:22 |
| mriedem | we'd been saying since at least newton that placement was the eventual fix for this problem :) that's why we kept putting off melwitt's workaround / RT patch | 20:23 |
| mriedem | and sure now it is | 20:23 |
| dansmith | aye | 20:23 |
| dansmith | well, to be fair, we could have done this in queens at least too | 20:24 |
| dansmith | meaning, it could have been the fix already | 20:24 |
| mriedem | sure | 20:24 |
| mriedem | and people could hack in a point-of-scheduling time fix in conductor if they need it.. | 20:24 |
| melwitt | does all of the "fixed" situations require that a flavor with root_gb=0 has been used? I'm reading through the comments trying to understand | 20:27 |
| dansmith | no, the right fix does not | 20:27 |
| melwitt | because I thought, as of ocata, if flavor has root_gb > 0 placement would filter it out of consideration and removing DiskFilter would not help you | 20:28 |
| dansmith | the middle solution requires sending a hacked flavor with root=0 to the scheduler as the signal to avoid a real signal | 20:28 |
| dansmith | right I think mriedem is saying that if you align all the planets on ocata, including set root=0, you can get it to kinda work if you don't sneeze near it | 20:29 |
| melwitt | got it | 20:29 |
| mriedem | we actually don't want people using root_gb=0 in flavors | 20:29 |
| dansmith | right | 20:29 |
| mriedem | there is a security issue for that | 20:29 |
| dansmith | and it's broken because it requires using specific flavors for bfv | 20:30 |
| mriedem | https://github.com/openstack/nova/commit/763fd62464e9a0753e061171cc1fd826055bbc01 | 20:30 |
| melwitt | yeah, just wanted to make sure I understood what the definition of "fixed" was in the convo | 20:30 |
| mriedem | i have to run, be back in a few | 20:30 |
| mriedem | dansmith: let's add the release note and change related-bug to partial-bug (for my ocd) and then i'm +2 | 20:30 |
| dansmith | ack | 20:30 |
| *** shaohe_feng has quit IRC | 20:31 | |
| dansmith | mriedem: I'll remind you I added related-bug for you :) | 20:33 |
| *** shaohe_feng has joined #openstack-nova | 20:35 | |
| *** spsurya_ has quit IRC | 20:36 | |
| dansmith | damn, you said "link" not specifically related | 20:36 |
| dansmith | I' | 20:36 |
| dansmith | I'll get you next time | 20:36 |
| *** itlinux has joined #openstack-nova | 20:38 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid requesting DISK_GB allocation for root_gb on BFV instances https://review.openstack.org/580720 | 20:39 |
| *** yamamoto has joined #openstack-nova | 20:41 | |
| *** shaohe_feng has quit IRC | 20:42 | |
| *** shaohe_feng has joined #openstack-nova | 20:45 | |
| *** yamamoto has quit IRC | 20:47 | |
| *** tidwellr has quit IRC | 20:48 | |
| *** tidwellr has joined #openstack-nova | 20:49 | |
| *** SpamapS has joined #openstack-nova | 20:49 | |
| *** itlinux has quit IRC | 20:50 | |
| *** shaohe_feng has quit IRC | 20:52 | |
| *** shaohe_feng has joined #openstack-nova | 20:55 | |
| *** flwang1 has joined #openstack-nova | 21:02 | |
| mriedem | muwahahaha | 21:02 |
| *** shaohe_feng has quit IRC | 21:02 | |
| *** wwriverrat has joined #openstack-nova | 21:04 | |
| *** shaohe_feng has joined #openstack-nova | 21:04 | |
| *** antosh has quit IRC | 21:05 | |
| *** tidwellr has quit IRC | 21:07 | |
| mriedem | dansmith: see my hedge in the release note | 21:08 |
| mriedem | i wonder if we should be clear that if you're not using the FilterScheduler (and/or using the DiskFilter) this is still a problem | 21:08 |
| dansmith | sure makes sense | 21:08 |
| mriedem | but, CachingScheduler is deprecated and DiskFilter should be disabled if using FilterScheduler | 21:08 |
| *** jaypipes has quit IRC | 21:09 | |
| dansmith | how's this: | 21:10 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid requesting DISK_GB allocation for root_gb on BFV instances https://review.openstack.org/580720 | 21:10 |
| mriedem | lgtm | 21:11 |
| mriedem | pew pew | 21:11 |
| mriedem | at some point we should drop the ironic flavor migration stuff, since then we can drop the remaining allocation stuff in the report client for the RT | 21:12 |
| *** shaohe_feng has quit IRC | 21:12 | |
| mriedem | the only driver that reports allocations in the compute is the ironic driver | 21:13 |
| *** shaohe_feng has joined #openstack-nova | 21:14 | |
| mriedem | # TODO(johngarbutt) we should remove this once the resource class | 21:14 |
| mriedem | # migration has been completed. | 21:14 |
| mriedem | requires_allocation_refresh = True | 21:14 |
| mriedem | what's our signal that the resource class migration has been completed? | 21:14 |
| dansmith | time and I think it's passed now | 21:15 |
| mriedem | we do have a nova-status check for the ironic instance embedded flavor migration | 21:15 |
| mriedem | and the online data migration | 21:15 |
| mriedem | online/offline | 21:15 |
| mriedem | and | 21:15 |
| mriedem | # TODO(jaypipes): Completely remove the reporting of VCPU, MEMORY_MB, | 21:15 |
| mriedem | # and DISK_GB resource classes in early Queens when Ironic nodes will | 21:15 |
| mriedem | # *always* return the custom resource class that represents the | 21:15 |
| mriedem | # baremetal node class in an atomic, singular unit. | 21:15 |
| mriedem | so we could dump all of that now, or wait until early stein | 21:16 |
| mriedem | i'd like to start dropping compat code that's hung around since newton/ocata times | 21:16 |
| mriedem | jroll: penick: do you guys have your ironic/nova deployment fully migrated to using resource classes? | 21:17 |
| jroll | mriedem: I did that patch already: https://review.openstack.org/#/c/565841/ | 21:17 |
| jroll | just haven't taken the time to rebase | 21:17 |
| jroll | we're still on juno, so... no. but will do in ocata afaik | 21:17 |
| mriedem | the bm cloud is juno and the vm cloud is ocata? | 21:18 |
| jroll | yeah | 21:18 |
| jroll | still working on ocata for bm | 21:18 |
| mriedem | ok, | 21:18 |
| mriedem | would be nice to know people have rolled bm deployments through this transition and there aren't any major issues | 21:18 |
| mriedem | before we drop all of that code | 21:18 |
| *** ccamacho has quit IRC | 21:19 | |
| mriedem | everyone seems to want an 18-24+ month window of support on transition code... | 21:19 |
| jroll | TheJulia or dtantsur|afk might have people that have been through that | 21:20 |
| mriedem | cern has bm and they are on queens now, | 21:20 |
| * TheJulia raises an eyebrow | 21:20 | |
| mriedem | tssurya: do you know if the cern baremetal deployment has gone through the custom resource class transition for ironic flavors? | 21:20 |
| tssurya | mriedem: yes | 21:21 |
| jroll | \o/ | 21:21 |
| jroll | mriedem: I can get back to 565841 next week maybe, or someone can take it over if they want | 21:22 |
| tssurya | meaning we use resource classes for ironic flavors (reading the convo to find out what transition) | 21:22 |
| *** shaohe_feng has quit IRC | 21:23 | |
| jroll | tssurya: there's an online data migration for existing instances | 21:23 |
| edmondsw | mriedem I think your changes in https://review.openstack.org/#/c/528835/ are related to a bug I just opened... take a look when you get a chance? https://bugs.launchpad.net/nova/+bug/1781286 | 21:23 |
| openstack | Launchpad bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during rebuild" [Undecided,New] | 21:23 |
| TheJulia | jroll: mriedem: I'm sure some folks have in our org... That being said unless it is a stated policy I've noticed people upstream tend to try and push the envelope... and downstream seems to pay for it... I guess I'm just rambling that long, but not too long is preferable to short windows | 21:23 |
| *** shaohe_feng has joined #openstack-nova | 21:24 | |
| jroll | TheJulia: dropping it now would be two cycles | 21:24 |
| mriedem | TheJulia: downstream consumers would have upstream maintain everything forever if possible | 21:25 |
| TheJulia | to support skip-leveling, two would be necessary, right now most people seem to be focused on fast forwarding since that is essentially what we end up testing | 21:25 |
| TheJulia | mriedem: :( | 21:25 |
| TheJulia | mriedem: I do not disagree | 21:25 |
| mriedem | one release is necessary for FFU | 21:25 |
| mriedem | there is no skip level | 21:25 |
| *** antosh has joined #openstack-nova | 21:25 | |
| jroll | oh there is skip level :P | 21:25 |
| mriedem | FFU means rolling through each release, not going directly from ocata to queens | 21:26 |
| TheJulia | jroll: heh | 21:26 |
| mriedem | sure, there is, but it's totally undefined | 21:26 |
| mriedem | and therefore impossible to support | 21:26 |
| jroll | right | 21:26 |
| jroll | and having to deal with online data migrations gone missing in skip level is already an issue | 21:26 |
| mriedem | given we're close to the end of rocky, i don't know if we just punt until early stein for the big drop or do it now | 21:27 |
| TheJulia | Anyway folks, I'm going to go like... enjoy... the big blue room. | 21:27 |
| jroll | at any rate, there's a patch up that needs rebasing, I'm fine either way | 21:27 |
| mriedem | we might as well just wait | 21:27 |
| TheJulia | +1 to punting | 21:27 |
| jroll | mmmkay | 21:28 |
| * TheJulia really goes to the big blue room now | 21:28 | |
| * jroll waits for eavesdrop to update so he can link this in a gerrit comment | 21:28 | |
| TheJulia | lol | 21:28 |
| *** jmlowe has quit IRC | 21:29 | |
| openstackgerrit | Merged openstack/nova master: Add queued for delete to instance_mappings table. https://review.openstack.org/566788 | 21:32 |
| openstackgerrit | Merged openstack/nova master: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581548 | 21:32 |
| mriedem | jroll: ok added to https://etherpad.openstack.org/p/nova-ptg-stein | 21:32 |
| openstackgerrit | Merged openstack/nova master: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/580755 | 21:33 |
| openstackgerrit | Merged openstack/nova master: Fix server_group_members quota check https://review.openstack.org/580684 | 21:33 |
| *** shaohe_feng has quit IRC | 21:33 | |
| mriedem | i have no idea what the big blue room is | 21:33 |
| *** shaohe_feng has joined #openstack-nova | 21:34 | |
| mriedem | oh i see, the cool way to say go outside | 21:34 |
| mriedem | edmondsw: "The nova_cell1.conf does have [database]connection set:" - that's not the db we're failing on | 21:37 |
| mriedem | edmondsw: build requests are in the api db, which devstack won't configure for n-cond-cell1 | 21:37 |
| mriedem | since the cell shouldn't be able to reach the api db | 21:37 |
| mriedem | edmondsw: if you have a recreate, | 21:38 |
| *** felipemonteiro_ has quit IRC | 21:38 | |
| mriedem | can you add a debug line to dump filter_properties? | 21:38 |
| edmondsw | yeah, I thought it might be the api db from a comment in your other change | 21:38 |
| mriedem | because | 21:38 |
| mriedem | num_attempts = filter_properties.get( | 21:38 |
| mriedem | 'retry', {}).get('num_attempts', 1) | 21:38 |
| edmondsw | otp right now, will check back in a min | 21:38 |
| mriedem | is it a rolm phone? | 21:38 |
| *** takashin has joined #openstack-nova | 21:39 | |
| *** oomichi has joined #openstack-nova | 21:40 | |
| *** shaohe_feng has quit IRC | 21:43 | |
| *** yamamoto has joined #openstack-nova | 21:43 | |
| *** Guest92142 has quit IRC | 21:43 | |
| *** shaohe_feng has joined #openstack-nova | 21:44 | |
| *** brault has quit IRC | 21:45 | |
| *** jmlowe has joined #openstack-nova | 21:45 | |
| *** yamamoto has quit IRC | 21:49 | |
| edmondsw | mriedem rolm? | 21:51 |
| edmondsw | I think I can get the data you asked for | 21:52 |
| mriedem | http://www.wikicu.com/ROLM_Phone | 21:52 |
| mriedem | edmondsw: are you by chance forcing the host/node during server create | 21:52 |
| mriedem | using --availability-zone nova:host:node? | 21:52 |
| mriedem | something like that? | 21:52 |
| edmondsw | not that I know of, but I'm not sure | 21:52 |
| edmondsw | this is in the PowerVM CI environment | 21:53 |
| mriedem | well, are you issuing a nova boot? | 21:53 |
| mriedem | oh... | 21:53 |
| edmondsw | so it's all automatated (hit this while redeploying it) | 21:53 |
| edmondsw | so I'm not sure what it's doing without digging into the automation | 21:53 |
| edmondsw | this is the undercloud | 21:53 |
| *** shaohe_feng has quit IRC | 21:53 | |
| mriedem | ok i guess check to see if it's forcing a host/node | 21:54 |
| edmondsw | will do | 21:54 |
| mriedem | or if CONF.scheduler.max_attempts = 1 | 21:54 |
| *** shaohe_feng has joined #openstack-nova | 21:54 | |
| edmondsw | max_attempts is the default (3) | 21:55 |
| mriedem | ok | 21:55 |
| edmondsw | mriedem I think these instances are being created by nodepool, if that tells you anything | 21:59 |
| *** mchlumsky has quit IRC | 22:00 | |
| mriedem | i'm going to see if i can recreate with a functional test quick | 22:00 |
| edmondsw | I doubt we're specifying a specific host/node but I'm looking | 22:00 |
| mriedem | but no nodepool doesn't tell me anything | 22:00 |
| *** brault has joined #openstack-nova | 22:00 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Stein https://review.openstack.org/573602 | 22:00 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 22:01 |
| edmondsw | and whether we do or not, I don't know whether nodepool would | 22:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | 22:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | 22:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | 22:02 |
| *** shaohe_feng has quit IRC | 22:04 | |
| *** brault has quit IRC | 22:05 | |
| *** shaohe_feng has joined #openstack-nova | 22:05 | |
| *** tssurya has quit IRC | 22:05 | |
| edmondsw | mriedem I think this is an example request body: body: {"server": {"name": "PowerVM_CI-PowerVM_DevStacked-440", "imageRef": "0dd943fd-ae60-4cdf-85fb-709d00f87db1", "flavorRef": "55b0569d-4f51-47fd-a326-8b333fedcce3", "max_count": 1, "min_count": 1, "networks": [{"uuid": "a4a8157c-da2f-462f-aa73-5c97fc7e17f1"}], "metadata": {"nodepool": "{\"provider_name\": \"PowerVM_DevStacked\", \"node_id\": 440, \"image_name\": \" | 22:06 |
| edmondsw | PowerVM_Ubuntu_Base\"}", "groups": "[\"PowerVM_DevStacked\", \"PowerVM_Ubuntu_Base\"]"}}} {{(pid=31995) _process_stack /opt/stack/nova/nova/api/openstack/wsgi.py:604}} | 22:06 |
| edmondsw | no availability zone specified | 22:07 |
| mriedem | i don't know what \"node_id\": 440 is | 22:11 |
| edmondsw | mriedem I think that's just something nodepool wants to remember, not important to nova | 22:13 |
| edmondsw | mriedem the Exception block you pasted in comment 1 is not entered | 22:14 |
| *** shaohe_feng has quit IRC | 22:14 | |
| edmondsw | the error isn't until after that | 22:14 |
| *** shaohe_feng has joined #openstack-nova | 22:14 | |
| *** rcernin has joined #openstack-nova | 22:15 | |
| *** antosh_ has joined #openstack-nova | 22:18 | |
| mriedem | ok log local_filter_props before the other instance of calling _destroy_build_request | 22:18 |
| *** antosh has quit IRC | 22:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 22:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 22:22 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 22:22 |
| mriedem | edmondsw: what is the devstack env like? a single host but with multiple nova-compute services running the powervm driver? | 22:23 |
| mriedem | so a 1:M host:node setup? | 22:23 |
| edmondsw | local_filter_props isn't set until a few lines after the error | 22:23 |
| edmondsw | the environment is a controller that runs most things (api, single conductor, etc.) and then multiple compute nodes | 22:24 |
| *** shaohe_feng has quit IRC | 22:24 | |
| edmondsw | the multiple compute nodes are all on actual physical nodes | 22:24 |
| edmondsw | since this is the undercloud | 22:25 |
| *** shaohe_feng has joined #openstack-nova | 22:25 | |
| mriedem | oh shite i see, | 22:25 |
| mriedem | get_host_availability_zone | 22:25 |
| mriedem | that's an up-call to get aggregates for the host | 22:25 |
| mriedem | to find the az | 22:25 |
| mriedem | so we reschedule, pop another host off the selection list, | 22:27 |
| mriedem | and then call host | 22:28 |
| mriedem | oops | 22:28 |
| mriedem | instance.availability_zone = ( | 22:28 |
| mriedem | availability_zones.get_host_availability_zone(context, | 22:28 |
| mriedem | host.service_host)) | 22:28 |
| mriedem | which is an up-call to get aggregates in the api db | 22:28 |
| mriedem | dansmith: ^ add it to the list :) | 22:28 |
| *** med_ has quit IRC | 22:28 | |
| mriedem | hmm, i wouldn't think it's possible to reschedule out of an az once you're initially scheduled into one | 22:28 |
| melwitt | you can if you never requested a specific AZ and went to the default AZ. you won't necessarily stay in the default AZ during a move | 22:29 |
| mriedem | i have a patch to test that.. | 22:30 |
| mriedem | https://review.openstack.org/#/c/567701/ | 22:30 |
| melwitt | so while a 'nova show' will show you're in the default AZ, your requested AZ is actually "None" aka I don't care what AZ I'm in | 22:30 |
| melwitt | (this came up recently on our bug call) | 22:30 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1771860 | 22:31 |
| openstack | Launchpad bug 1771860 in OpenStack Compute (nova) "instance.availability_zone reports wrong az after live migration" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 22:31 |
| mriedem | so if you don't specify an az during server create, you can freely move across azs, | 22:32 |
| mriedem | but if you do specify an az during server create, you must be restricted to that az during moves | 22:32 |
| melwitt | right | 22:32 |
| edmondsw | that's what I'd expect | 22:32 |
| mriedem | for live migration if you don't specify an az on create and are live migrated to another one, we aren't updating the instance az | 22:32 |
| mriedem | which is that bug fix | 22:32 |
| *** felipemonteiro_ has joined #openstack-nova | 22:32 | |
| melwitt | k, that makes sense | 22:33 |
| *** felipemonteiro__ has joined #openstack-nova | 22:34 | |
| *** shaohe_feng has quit IRC | 22:34 | |
| *** shaohe_feng has joined #openstack-nova | 22:35 | |
| mriedem | edmondsw: ok updated comments in your bug | 22:36 |
| edmondsw | mriedem tx | 22:36 |
| mriedem | hmm, | 22:37 |
| *** hongbin has quit IRC | 22:37 | |
| mriedem | so we could put the az on the Selection object for a given host while we're in the controller and pass that down to the cell, | 22:37 |
| mriedem | but there would be a window of time where the host could be moved into / out of an aggregate / AZ during the reschedule loop | 22:37 |
| *** yassine has joined #openstack-nova | 22:37 | |
| *** felipemonteiro_ has quit IRC | 22:37 | |
| mriedem | not likely, and kind of tough luck if that happens... | 22:37 |
| *** yassine is now known as Guest44289 | 22:38 | |
| mriedem | this might also help us resolve up-call #5 at https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#operations-requiring-upcalls | 22:38 |
| mriedem | when [cinder]/cross_az_attach=False | 22:38 |
| mriedem | because the compute could get the host az off the Selection object | 22:38 |
| *** owalsh_ has joined #openstack-nova | 22:39 | |
| mriedem | we really need a way to do split mq fixturization in our functional testes | 22:41 |
| mriedem | *tests | 22:41 |
| edmondsw | why does the AZ have to be set if the user didn't specify one? I assume it's to fill that on a later GET, but couldn't it just be populated dynamically there? | 22:41 |
| mriedem | https://review.openstack.org/#/c/446053/ | 22:41 |
| edmondsw | so that's what caused it | 22:43 |
| mriedem | yes, | 22:43 |
| mriedem | i believe the reason is, | 22:43 |
| mriedem | set the az on the instance at the top where we can reach aggregates in the api db, | 22:43 |
| mriedem | so we don't need to do that in the computes | 22:43 |
| *** owalsh has quit IRC | 22:43 | |
| mriedem | where we can't reach the api db | 22:43 |
| mriedem | but dansmith would have to confirm that | 22:43 |
| mriedem | "which isn't as useful to the things that need to consider what AZ the instance is actually in (without doing all the aggregate math to determine it on the fly)." | 22:44 |
| mriedem | that reads "up call" to me ^ | 22:44 |
| edmondsw | but what needs to consider the AZ if the user didn't specify? | 22:44 |
| edmondsw | e.g. we just said migrate wouldn't care about the AZ in that case | 22:44 |
| *** shaohe_feng has quit IRC | 22:45 | |
| mriedem | not sure off the top of my head honestly | 22:45 |
| *** yamamoto has joined #openstack-nova | 22:45 | |
| *** shaohe_feng has joined #openstack-nova | 22:45 | |
| mriedem | maybe [cinder]/cross_az_attach=False ? | 22:46 |
| mriedem | but as far as i know that is still broken | 22:47 |
| *** owalsh has joined #openstack-nova | 22:47 | |
| *** owalsh_ has quit IRC | 22:48 | |
| mriedem | ugh, so we have a cache in nova.availability_zones, | 22:49 |
| mriedem | but we don't populate it when calling get_host_availability_zone at the top | 22:49 |
| mriedem | so when we get to the compute and check the instance.az (set at the top) against the host az from the cache, the latter is None and we say, 'the cache is invalid, so fetch the host az again' | 22:49 |
| edmondsw | mriedem, actually git blame shows this was introduced with https://github.com/openstack/nova/commit/03b4c67b22f49d325386bc3ebd2ade79b44fa699 | 22:49 |
| mriedem | which is the up-call that fails | 22:49 |
| mriedem | edmondsw: that's the same change | 22:50 |
| *** TxGirlGeek has quit IRC | 22:50 | |
| mriedem | oh but the cache on the compute won't have the az set in it anyway | 22:50 |
| edmondsw | oh, dang it it is... I saw "Updated 9 weeks ago" in that review and thought it was new, whereas the commit was old, and assumed they were different | 22:50 |
| mriedem | b/c we get the host az at in a different process | 22:51 |
| mriedem | unless you have a distributed cache... | 22:51 |
| *** yamamoto has quit IRC | 22:51 | |
| *** shaohe_feng has quit IRC | 22:55 | |
| *** TxGirlGeek has joined #openstack-nova | 22:56 | |
| *** shaohe_feng has joined #openstack-nova | 22:57 | |
| *** TxGirlGeek has quit IRC | 22:58 | |
| *** harlowja has quit IRC | 23:05 | |
| *** shaohe_feng has quit IRC | 23:05 | |
| *** shaohe_feng has joined #openstack-nova | 23:06 | |
| *** antosh_ has quit IRC | 23:06 | |
| *** felipemonteiro__ has quit IRC | 23:08 | |
| *** edmondsw has quit IRC | 23:12 | |
| *** edmondsw has joined #openstack-nova | 23:13 | |
| mriedem | edmondsw: fyi, your bug is also a problem for resize reschedules | 23:14 |
| *** shaohe_feng has quit IRC | 23:15 | |
| *** shaohe_feng has joined #openstack-nova | 23:16 | |
| *** edmondsw has quit IRC | 23:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add another up-call to the cells v2 caveats list https://review.openstack.org/581910 | 23:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 23:24 |
| oomichi | takashin: hi, can you check my comment on https://review.openstack.org/#/c/570842 ? | 23:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 23:25 |
| takashin | oomichi: okay. Thanks. | 23:25 |
| *** shaohe_feng has quit IRC | 23:26 | |
| mriedem | ha, just found another one | 23:26 |
| mriedem | during a resize reschedule, compute casts to cell conductor's migrate_server method, | 23:27 |
| mriedem | which has the targets_cell decorator on it which gets an instance mapping, | 23:27 |
| mriedem | if you don't have access to the api db, kablammo | 23:27 |
| mriedem | http://logs.openstack.org/27/581727/1/check/tempest-full-py3/15d7fdc/controller/logs/screen-n-cpu.txt#_Jul_11_13_32_54_822996 | 23:27 |
| *** shaohe_feng has joined #openstack-nova | 23:27 | |
| * melwitt keels over | 23:27 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 23:29 |
| *** chyka has quit IRC | 23:30 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1781300 | 23:31 |
| openstack | Launchpad bug 1781300 in OpenStack Compute (nova) "resize reschedule results in CantStartEngineError during up-call to InstanceMappings table" [Medium,Triaged] | 23:31 |
| *** shaohe_feng has quit IRC | 23:36 | |
| *** shaohe_feng has joined #openstack-nova | 23:36 | |
| *** shaohe_feng has quit IRC | 23:46 | |
| *** yamamoto has joined #openstack-nova | 23:47 | |
| *** med_ has joined #openstack-nova | 23:47 | |
| *** shaohe_feng has joined #openstack-nova | 23:47 | |
| *** gyee has quit IRC | 23:48 | |
| *** yamamoto has quit IRC | 23:52 | |
| *** shaohe_feng has quit IRC | 23:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Short-circuit targets_cell if already targeted https://review.openstack.org/581912 | 23:57 |
| mriedem | melwitt: dansmith: ^ | 23:57 |
| *** shaohe_feng has joined #openstack-nova | 23:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Short-circuit targets_cell if already targeted https://review.openstack.org/581912 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!