Wednesday, 2018-05-02

*** yamamoto has quit IRC00:00
*** armaan has quit IRC00:03
*** armaan has joined #openstack-nova00:04
*** armaan has quit IRC00:05
*** armaan has joined #openstack-nova00:05
*** Swami has quit IRC00:11
*** mriedem has quit IRC00:18
*** tbachman has joined #openstack-nova00:19
*** Dinesh_Bhor has joined #openstack-nova00:22
*** markvoelker has quit IRC00:25
openstackgerritMerged openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags`  https://review.openstack.org/56392600:26
*** yingjun has joined #openstack-nova00:31
*** hoangcx has joined #openstack-nova00:35
openstackgerritkarim proposed openstack/nova master: Pushing image traits to ironic node  https://review.openstack.org/56562000:37
*** liuzz has joined #openstack-nova00:40
*** yingjun has quit IRC00:50
*** yingjun has joined #openstack-nova00:53
*** yamamoto has joined #openstack-nova00:57
*** fragatina has quit IRC00:57
*** jichen has joined #openstack-nova00:58
*** Guest72284 has quit IRC01:01
*** yamamoto has quit IRC01:03
*** zhaochao has joined #openstack-nova01:05
*** bzhao__ has joined #openstack-nova01:07
*** tiendc has joined #openstack-nova01:08
*** Zames_ has joined #openstack-nova01:11
*** dpawlik has joined #openstack-nova01:11
*** Zames_ has quit IRC01:13
*** dpawlik has quit IRC01:15
*** Guest72284 has joined #openstack-nova01:16
*** hongbin has joined #openstack-nova01:17
*** trungnv has joined #openstack-nova01:25
openstackgerritjichenjc proposed openstack/nova master: Avoid live migrate to same host  https://review.openstack.org/54268901:25
*** gjayavelu has quit IRC01:40
*** Tom-Tom has quit IRC01:41
*** tbachman has quit IRC01:46
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518101:47
*** tbachman has joined #openstack-nova01:48
*** felipemonteiro has joined #openstack-nova01:50
*** liverpooler has joined #openstack-nova01:50
*** Nel1x has joined #openstack-nova01:51
*** vic-wu has joined #openstack-nova01:55
*** felipemonteiro has quit IRC01:56
*** dklyle has quit IRC01:57
*** david-lyle has joined #openstack-nova01:57
*** yamamoto has joined #openstack-nova01:59
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data  https://review.openstack.org/40751402:00
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728902:00
*** Tom-Tom has joined #openstack-nova02:02
*** yamahata has quit IRC02:02
*** yamamoto has quit IRC02:03
*** dougshelley66 has quit IRC02:04
*** yamamoto has joined #openstack-nova02:05
*** lei-zh has joined #openstack-nova02:06
*** dougshelley66 has joined #openstack-nova02:07
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518102:08
*** masber has joined #openstack-nova02:09
*** yamamoto has quit IRC02:09
*** spsurya has joined #openstack-nova02:10
*** tinwood has quit IRC02:10
*** tinwood has joined #openstack-nova02:11
*** dave-mccowan has quit IRC02:13
*** mingyu has joined #openstack-nova02:16
*** psachin has joined #openstack-nova02:16
*** gyee has quit IRC02:17
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518102:17
*** yamamoto has joined #openstack-nova02:20
openstackgerritZhenyu Zheng proposed openstack/nova master: WIP new migration threads control  https://review.openstack.org/56350502:22
*** dpawlik has joined #openstack-nova02:25
*** mikal_ has quit IRC02:26
*** mikal has joined #openstack-nova02:26
*** markvoelker has joined #openstack-nova02:26
*** felipemonteiro has joined #openstack-nova02:29
*** dpawlik has quit IRC02:29
*** liverpooler has quit IRC02:31
*** dougshelley66 has quit IRC02:33
*** sdeath has joined #openstack-nova02:36
*** dougshelley66 has joined #openstack-nova02:36
*** felipemonteiro has quit IRC02:37
*** yingjun has quit IRC02:39
*** mikal has quit IRC02:41
*** david-lyle has quit IRC02:45
*** blkart has quit IRC02:45
*** mikal has joined #openstack-nova02:49
*** masuberu has joined #openstack-nova02:52
*** masber has quit IRC02:52
openstackgerritMerged openstack/nova master: libvirt: fix setting tx_queue_size when rx_queue_size is not set  https://review.openstack.org/56557302:54
*** dougshelley66 has quit IRC02:55
*** tuanla____ has joined #openstack-nova02:55
*** markvoelker has quit IRC02:56
*** markvoelker has joined #openstack-nova02:57
*** blkart has joined #openstack-nova03:02
*** lei-zh has quit IRC03:02
*** lei-zh has joined #openstack-nova03:03
*** armaan has quit IRC03:03
*** armaan_ has joined #openstack-nova03:03
*** yingjun has joined #openstack-nova03:05
*** BrinZhang has joined #openstack-nova03:07
*** sapd has quit IRC03:08
*** slaweq has joined #openstack-nova03:11
*** namnh has joined #openstack-nova03:14
*** slaweq has quit IRC03:16
*** moshele has joined #openstack-nova03:17
*** moshele has quit IRC03:19
*** hongbin has quit IRC03:19
*** READ10 has quit IRC03:24
*** takashin has quit IRC03:25
*** yingjun has quit IRC03:27
*** nicolasbock has quit IRC03:31
*** vivsoni_ has quit IRC03:33
*** slaweq has joined #openstack-nova03:35
*** armaan_ has quit IRC03:39
*** hamzy has joined #openstack-nova03:40
*** fragatina has joined #openstack-nova03:42
*** fragatin_ has joined #openstack-nova03:44
*** fragatina has quit IRC03:47
*** slaweq has quit IRC03:49
*** slaweq has joined #openstack-nova03:50
*** takashin has joined #openstack-nova03:54
*** slaweq has quit IRC03:55
*** vivsoni has joined #openstack-nova03:55
*** slaweq has joined #openstack-nova03:55
*** slaweq has quit IRC03:59
*** lei-zh has quit IRC04:00
*** vivsoni has quit IRC04:01
*** slaweq has joined #openstack-nova04:05
*** slaweq has quit IRC04:10
*** vivsoni has joined #openstack-nova04:10
*** slaweq has joined #openstack-nova04:15
*** slaweq has quit IRC04:20
*** slaweq has joined #openstack-nova04:20
*** lei-zh has joined #openstack-nova04:22
*** armaan has joined #openstack-nova04:23
*** janki has joined #openstack-nova04:29
*** slaweq has quit IRC04:30
*** trozet has quit IRC04:30
*** lei-zh has quit IRC04:30
*** moshele has joined #openstack-nova04:32
*** udesale has joined #openstack-nova04:33
*** slaweq has joined #openstack-nova04:35
*** masuberu has quit IRC04:47
*** abhishekk has joined #openstack-nova04:48
*** links has joined #openstack-nova04:50
*** moshele has quit IRC04:55
*** yingjun has joined #openstack-nova04:56
*** slaweq has quit IRC05:00
*** Nel1x has quit IRC05:00
*** slaweq has joined #openstack-nova05:05
*** phuongnh has joined #openstack-nova05:14
*** slaweq has quit IRC05:15
*** ratailor has joined #openstack-nova05:17
*** yamahata has joined #openstack-nova05:17
*** mikal_ has joined #openstack-nova05:20
*** yingjun has quit IRC05:22
*** belmoreira has joined #openstack-nova05:22
*** mikal has quit IRC05:22
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared  https://review.openstack.org/55645005:23
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651405:23
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands without shared RPs  https://review.openstack.org/56184205:23
*** vic-wu has quit IRC05:34
*** Eran_Kuris_ has joined #openstack-nova05:34
*** sridharg has joined #openstack-nova05:36
*** bhujay has joined #openstack-nova05:46
*** moshele has joined #openstack-nova05:47
*** dklyle has joined #openstack-nova05:47
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518105:48
*** yingjun has joined #openstack-nova05:48
*** moshele has quit IRC05:51
*** Taseer has joined #openstack-nova06:00
*** udesale_ has joined #openstack-nova06:03
*** udesale_ has quit IRC06:04
*** udesale_ has joined #openstack-nova06:05
*** udesale has quit IRC06:05
*** udesale__ has joined #openstack-nova06:07
*** jaosorior has joined #openstack-nova06:07
*** udesale_ has quit IRC06:09
*** hjensas has quit IRC06:11
*** sapd has joined #openstack-nova06:16
*** armaan has quit IRC06:20
*** armaan has joined #openstack-nova06:21
*** fragatina has joined #openstack-nova06:25
*** tiendc has quit IRC06:27
*** fragatin_ has quit IRC06:27
*** do3meli has joined #openstack-nova06:27
openstackgerritjichenjc proposed openstack/nova master: [doc] Add soft_deleted flag  https://review.openstack.org/56289706:28
*** dklyle has quit IRC06:29
*** moshele has joined #openstack-nova06:34
openstackgerritjichenjc proposed openstack/nova master: remove ec2 object definitions  https://review.openstack.org/55715006:39
openstackgerritjichenjc proposed openstack/nova master: remove ec2 db functions  https://review.openstack.org/55757206:39
*** jaosorior has quit IRC06:41
*** udesale_ has joined #openstack-nova06:43
*** udesale_ has quit IRC06:43
*** udesale has joined #openstack-nova06:44
*** udesale__ has quit IRC06:45
*** annp has joined #openstack-nova06:48
*** rcernin_ has joined #openstack-nova06:50
*** rcernin has quit IRC06:51
openstackgerritjichenjc proposed openstack/nova master: Enhance api-guide general info some updates  https://review.openstack.org/56177306:52
*** MasterofJOKers_ has joined #openstack-nova06:55
*** MasterofJOKers has quit IRC06:57
*** MasterofJOKers_ is now known as MasterofJOKers06:57
*** slaweq has joined #openstack-nova06:58
*** slaweq has quit IRC06:58
*** slaweq has joined #openstack-nova06:58
*** slaweq has quit IRC06:58
*** slaweq has joined #openstack-nova06:58
openstackgerritinspurericzhang proposed openstack/nova master: Replace Chinese punctuation with English punctuation  https://review.openstack.org/56565506:59
*** yamahata has quit IRC07:02
openstackgerritjichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception  https://review.openstack.org/54115207:04
*** hjensas has joined #openstack-nova07:04
*** rcernin_ has quit IRC07:05
*** sahid has joined #openstack-nova07:06
*** dpawlik has joined #openstack-nova07:06
*** dpawlik has quit IRC07:11
*** armaan has quit IRC07:12
*** armaan has joined #openstack-nova07:13
*** yamahata has joined #openstack-nova07:14
*** dpawlik has joined #openstack-nova07:15
*** armaan has quit IRC07:18
*** armaan has joined #openstack-nova07:18
*** giblet is now known as gibi07:20
gibigood morning nova07:22
*** tesseract has joined #openstack-nova07:25
*** armaan has quit IRC07:25
*** armaan has joined #openstack-nova07:26
*** yingjun has quit IRC07:26
*** armaan has quit IRC07:27
*** armaan has joined #openstack-nova07:28
*** ragiman_ has joined #openstack-nova07:32
*** armaan has quit IRC07:33
*** dklyle has joined #openstack-nova07:34
*** damien_r has joined #openstack-nova07:34
*** armaan has joined #openstack-nova07:34
*** belmoreira has quit IRC07:37
*** damien_r has quit IRC07:38
*** damien_r has joined #openstack-nova07:38
*** yingjun has joined #openstack-nova07:41
*** armaan has quit IRC07:41
*** ccamacho has joined #openstack-nova07:48
*** aloga has quit IRC07:52
*** aloga has joined #openstack-nova07:52
*** hemna_ has quit IRC07:56
*** mgoddard has joined #openstack-nova07:56
*** takashin has left #openstack-nova08:00
*** belmoreira has joined #openstack-nova08:01
*** tssurya has joined #openstack-nova08:04
*** bhujay has quit IRC08:05
*** sam_nowitzki has joined #openstack-nova08:05
*** bhujay has joined #openstack-nova08:08
*** pcaruana has joined #openstack-nova08:08
lyarwoodrandomhack: https://review.openstack.org/#/c/460243/ fixed this during Queens08:09
*** belmoreira has quit IRC08:10
lyarwoodrandomhack: it's the same underlying failure as this swap volume bug https://bugs.launchpad.net/nova/+bug/173959308:10
openstackLaunchpad bug 1739593 in OpenStack Compute (nova) pike "[OSSA-2018-001] Swapping encrypted volumes can lead to data loss and a possible compute host DOS attack (CVE-2017-18191)" [High,Fix committed] - Assigned to Lee Yarwood (lyarwood)08:10
*** mdnadeem has joined #openstack-nova08:10
lyarwoodI can't mark it as a dup for some reason08:11
*** andreas_s has joined #openstack-nova08:11
*** belmoreira has joined #openstack-nova08:11
*** salv-orlando has joined #openstack-nova08:12
*** bhujay has quit IRC08:13
*** yamahata has quit IRC08:16
*** mdbooth has joined #openstack-nova08:18
kashyapstephenfin: Yes, I intend to handle those two clean-ups08:19
kashyapNoted here: https://review.openstack.org/#/c/564012/4/nova/virt/libvirt/driver.py08:19
*** lucas-afk is now known as lucasagomes08:19
openstackgerritKashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Make `cpu_model_extra_flags` case-insensitive for real  https://review.openstack.org/56566808:20
*** aloga has quit IRC08:21
openstackgerritKashyap Chamarthy proposed openstack/nova stable/pike: libvirt: Make `cpu_model_extra_flags` case-insensitive for real  https://review.openstack.org/56567008:21
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create  https://review.openstack.org/52031308:22
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create  https://review.openstack.org/52031308:24
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518108:25
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations`  https://review.openstack.org/52171708:27
openstackgerritKashyap Chamarthy proposed openstack/nova stable/ocata: libvirt: Make `cpu_model_extra_flags` case-insensitive for real  https://review.openstack.org/56567208:27
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518108:29
*** bhujay has joined #openstack-nova08:32
*** abhishekk has quit IRC08:35
*** abhishekk has joined #openstack-nova08:38
*** derekh has joined #openstack-nova08:39
*** lei-zh has joined #openstack-nova08:41
*** xinliang has quit IRC08:42
*** xinliang has joined #openstack-nova08:42
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338708:43
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765808:43
*** bhujay has quit IRC08:43
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424008:43
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334008:43
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334408:43
*** sree_ has joined #openstack-nova08:46
*** sree_ is now known as Guest6708708:46
*** salv-orlando has quit IRC08:47
*** salv-orlando has joined #openstack-nova08:48
*** Dinesh_Bhor has quit IRC08:48
*** namnh has quit IRC08:50
*** phuongnh has quit IRC08:50
*** trungnv has quit IRC08:50
*** tuanla____ has quit IRC08:50
*** hoangcx has quit IRC08:50
*** phuongnh has joined #openstack-nova08:51
*** tuanla____ has joined #openstack-nova08:51
*** namnh has joined #openstack-nova08:51
*** hoangcx has joined #openstack-nova08:51
*** trungnv has joined #openstack-nova08:51
*** salv-orlando has quit IRC08:52
kashyapstephenfin: Ah, you've already posted those two08:55
*** dklyle has quit IRC08:56
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create  https://review.openstack.org/52104108:56
kashyapdansmith: We need to backport "libvirt: Make `cpu_model_extra_flags` case-insensitive for real  https://review.openstack.org/565043" back to Ocata, or else the existing documention would be a "lie".09:01
lyarwoodkashyap: argh my bad, I did mean to review these on Monday09:02
kashyaplyarwood: No problem; I only _just_ backported that09:03
kashyapAs the main change got merged while I was asleep09:03
kashyapSo you're right on time09:03
kashyapThanks!09:03
lyarwoodkashyap: huh, maybe you just said they'd be coming soon then :)09:03
lyarwoodkashyap: and ack, I'll get to them today09:03
kashyaplyarwood: Thanks; you'll see the changes needing reviews here: https://review.openstack.org/#/q/topic:bug/1750829+(status:open+OR+status:merged)09:04
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create  https://review.openstack.org/52104109:07
*** sam_nowitzki has quit IRC09:10
*** rmart04 has joined #openstack-nova09:12
*** dklyle has joined #openstack-nova09:15
*** belmoreira has quit IRC09:16
*** armaan has joined #openstack-nova09:23
*** dklyle has quit IRC09:26
*** lei-zh1 has joined #openstack-nova09:33
*** lei-zh has quit IRC09:35
*** rmart04_ has joined #openstack-nova09:36
*** rmart04 has quit IRC09:36
*** rmart04_ is now known as rmart0409:36
sahidjaypipes: if you have a moment, I have a fix here, it's about how we compute memory we could be in situation where guests get oomkilled09:39
sahidhttps://review.openstack.org/#/c/532168/09:39
*** lei-zh1 has quit IRC09:41
*** lei-zh1 has joined #openstack-nova09:41
*** armaan has quit IRC09:43
*** yingjun has quit IRC09:45
*** Tom-Tom has quit IRC09:47
*** Tom-Tom has joined #openstack-nova09:48
openstackgerritMichael Still proposed openstack/nova master: Convert fping API to processutils.execute()  https://review.openstack.org/56414409:48
openstackgerritMichael Still proposed openstack/nova master: Convert xenapi's xvp console to processutils.  https://review.openstack.org/56414509:48
openstackgerritMichael Still proposed openstack/nova master: Convert certificate generation to processutils.  https://review.openstack.org/56414609:48
*** rmart04 has quit IRC09:50
*** dtantsur|afk is now known as dtantsur09:50
*** rmart04 has joined #openstack-nova09:52
*** Tom-Tom has quit IRC09:52
*** phuongnh has quit IRC09:55
*** tuanla____ has quit IRC09:55
*** namnh has quit IRC09:55
*** tuanla____ has joined #openstack-nova09:56
*** namnh has joined #openstack-nova09:56
*** phuongnh has joined #openstack-nova09:56
*** Guest72284 has quit IRC09:57
*** jichen has quit IRC09:58
*** namnh has quit IRC09:59
*** andreas_s has quit IRC09:59
*** BobBall has joined #openstack-nova10:02
*** armaan has joined #openstack-nova10:03
*** jmccarthy has joined #openstack-nova10:04
*** lei-zh1 has quit IRC10:06
*** Tom-Tom has joined #openstack-nova10:07
*** lei-zh1 has joined #openstack-nova10:07
*** andreas_s has joined #openstack-nova10:09
*** hoangcx has quit IRC10:09
*** andreas_s_ has joined #openstack-nova10:11
*** Tom-Tom has quit IRC10:11
*** andreas_s has quit IRC10:14
openstackgerritsahid proposed openstack/nova master: compute: introduce cpu_shared_set option  https://review.openstack.org/56191210:15
openstackgerritsahid proposed openstack/nova master: libvirt: always pass emulator threads policy  https://review.openstack.org/56191310:15
openstackgerritsahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set  https://review.openstack.org/51089710:15
*** salv-orlando has joined #openstack-nova10:15
*** andreas_s_ has quit IRC10:15
*** swamireddy has quit IRC10:17
*** andreas_s has joined #openstack-nova10:19
*** andreas_s has quit IRC10:19
*** andreas_s has joined #openstack-nova10:19
*** armaan has quit IRC10:21
*** andreas_s has quit IRC10:21
*** andreas_s has joined #openstack-nova10:22
*** salv-orlando has quit IRC10:22
*** andreas_s has quit IRC10:23
*** andreas_s has joined #openstack-nova10:25
*** rmart04 has quit IRC10:31
*** mikal has joined #openstack-nova10:32
*** sree_ has joined #openstack-nova10:32
*** abhishekk has quit IRC10:32
*** sree_ is now known as Guest1502710:32
*** lei-zh1 has quit IRC10:33
*** mikal_ has quit IRC10:33
openstackgerritMichael Still proposed openstack/nova master: Move image conversion to privsep.  https://review.openstack.org/55443710:35
openstackgerritMichael Still proposed openstack/nova master: We don't need utils.trycmd any more.  https://review.openstack.org/55443910:35
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443810:35
*** Guest67087 has quit IRC10:35
*** annp has quit IRC10:37
openstackgerritMichael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module.  https://review.openstack.org/55755210:37
openstackgerritMichael Still proposed openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783510:37
openstackgerritMichael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848710:37
*** nicolasbock has joined #openstack-nova10:42
*** rmart04 has joined #openstack-nova10:45
*** stephenfin has quit IRC10:47
*** tbachman has quit IRC10:49
*** stephenfin has joined #openstack-nova10:51
*** tuanla____ has quit IRC10:51
*** wolverineav has joined #openstack-nova10:54
*** phuongnh has quit IRC10:56
*** dougshelley66 has joined #openstack-nova10:57
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message in test assert  https://review.openstack.org/56569410:58
*** andreas_s has quit IRC11:00
*** andreas_s has joined #openstack-nova11:02
*** belmoreira has joined #openstack-nova11:02
*** r-daneel has quit IRC11:04
*** sdeath has quit IRC11:05
*** andreas_s has quit IRC11:07
*** xinliang has quit IRC11:08
*** jaosorior has joined #openstack-nova11:08
openstackgerritSurya Seetharaman proposed openstack/nova master: Make association_refresh configurable  https://review.openstack.org/56552611:09
jbernardmelwitt: re the patch (yesterday, rbd busy snapshots), it's a valid rbd state, but tempest does not tolerate it11:11
moshelestephenfin: hi can you review the pike backport https://review.openstack.org/#/c/563501/ ?11:11
*** r-daneel has joined #openstack-nova11:11
jbernardmelwitt: the order of operations during teardown is non-deterministic11:12
openstackgerritVladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed  https://review.openstack.org/51792111:13
*** hjensas has quit IRC11:13
*** randomhack_ has joined #openstack-nova11:13
*** Tom-Tom has joined #openstack-nova11:14
*** andreas_s has joined #openstack-nova11:15
*** sdeath has joined #openstack-nova11:15
*** jaosorior has quit IRC11:16
openstackgerritVishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder  https://review.openstack.org/56570311:17
*** andreas_s_ has joined #openstack-nova11:19
*** janki has quit IRC11:19
*** sdeath has quit IRC11:20
*** andreas_s has quit IRC11:20
*** swamireddy has joined #openstack-nova11:20
*** andreas_s_ has quit IRC11:20
*** armaan has joined #openstack-nova11:20
*** andreas_s has joined #openstack-nova11:20
*** yassine has joined #openstack-nova11:20
*** yassine is now known as Guest8028111:21
*** jmccarthy has quit IRC11:22
*** Tom-Tom has quit IRC11:23
*** Tom-Tom has joined #openstack-nova11:24
kashyapmelwitt: When you're back, mriedem is right about that extraCPU flags blueprint: a future patch needs to add the ability to remove specific CPU flags.11:24
*** jmccarthy has joined #openstack-nova11:25
*** dklyle has joined #openstack-nova11:25
*** sdeath has joined #openstack-nova11:26
*** Tom-Tom has quit IRC11:28
*** andreas_s has quit IRC11:29
*** udesale has quit IRC11:30
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_CPU_POLICY_VERSIONS  https://review.openstack.org/56401211:30
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_REALTIME_VERSION  https://review.openstack.org/56570711:30
*** andreas_s has joined #openstack-nova11:30
*** lucasagomes is now known as lucas-hungry11:32
kashyapstephenfin: sahid: ^ On the last commit above (on REALTIME), can you double-confirm what I wrote in the commit message?  (I.e. no tests need to cleaned-up.)11:33
*** dougshelley66 has quit IRC11:35
kashyap(Also the one before it, 'CPU_POLICY' one, lost +W due to rebase.)11:35
*** bhujay has joined #openstack-nova11:39
*** mvk has quit IRC11:40
*** salv-orlando has joined #openstack-nova11:46
*** dklyle has quit IRC11:50
*** Guest80281 has quit IRC11:52
*** salv-orlando has quit IRC11:52
*** salv-orlando has joined #openstack-nova11:53
*** yassine_ has joined #openstack-nova11:53
*** Guest15027 has quit IRC11:53
*** sree has joined #openstack-nova11:54
openstackgerritMichael Still proposed openstack/nova master: Convert configdrive to use processutils.  https://review.openstack.org/56572311:55
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_QEMU_POSTCOPY_VERSION  https://review.openstack.org/56572411:55
*** andreas_s has quit IRC11:56
*** salv-orlando has quit IRC11:57
*** andreas_s has joined #openstack-nova11:57
*** sree has quit IRC11:59
*** andreas_s has quit IRC11:59
*** andreas_s has joined #openstack-nova12:00
*** bhujay has quit IRC12:00
*** bhujay has joined #openstack-nova12:02
*** Taseer has quit IRC12:02
*** tbachman has joined #openstack-nova12:04
*** rmart04 has quit IRC12:05
*** bhujay has quit IRC12:08
*** tbachman has quit IRC12:09
*** dougshelley66 has joined #openstack-nova12:09
openstackgerritMartin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed.  https://review.openstack.org/56419312:10
*** edmondsw has joined #openstack-nova12:13
*** edmondsw has quit IRC12:13
*** edmondsw has joined #openstack-nova12:13
*** rmart04 has joined #openstack-nova12:13
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Placement: any traits in allocation_candidate query  https://review.openstack.org/56573012:13
*** andreas_s has quit IRC12:14
*** tbachman has joined #openstack-nova12:15
*** andreas_s has joined #openstack-nova12:16
*** dtantsur is now known as dtantsur|brb12:23
*** fragatina has quit IRC12:24
*** eharney has quit IRC12:24
*** fragatina has joined #openstack-nova12:24
*** yamamoto has quit IRC12:25
*** yamamoto has joined #openstack-nova12:25
*** andreas_s has quit IRC12:26
*** moshele has quit IRC12:26
*** moshele has joined #openstack-nova12:26
*** andreas_s_ has joined #openstack-nova12:27
*** alex_xu has quit IRC12:29
*** andreas__ has joined #openstack-nova12:29
*** pcaruana has quit IRC12:30
*** Tom-Tom has joined #openstack-nova12:31
*** andreas_s_ has quit IRC12:32
*** liverpooler has joined #openstack-nova12:33
*** janki has joined #openstack-nova12:35
*** Tom-Tom has quit IRC12:36
*** alex_xu has joined #openstack-nova12:36
*** vladikr has joined #openstack-nova12:38
stephenfinkashyap: Can do12:39
*** randomhack has quit IRC12:40
*** salv-orlando has joined #openstack-nova12:43
*** armaan has quit IRC12:44
*** lucas-hungry is now known as lucasagomes12:44
*** rmart04_ has joined #openstack-nova12:44
jmccarthyHmm anyone try cold migrate an instance (cinder/lvm backed) with master ? I'm not sure what is the story - but I have this /var/lib/nova/instances/<id>/disk.info left behind on the source host afterwards (after resize verify) and I think it shouldn't be ?12:45
*** belmoreira has quit IRC12:45
*** salv-orl_ has joined #openstack-nova12:45
*** rmart04 has quit IRC12:45
*** rmart04_ is now known as rmart0412:45
*** salv-orlando has quit IRC12:46
*** psachin has quit IRC12:47
kashyapstephenfin: Gracias12:48
*** andreas__ has quit IRC12:48
*** mvk has joined #openstack-nova12:50
jmccarthySeems like it's related to this, which is fixed .. https://bugs.launchpad.net/nova/+bug/1666831 - where can one check whether tests for this bug are currently passing ?12:52
openstackLaunchpad bug 1666831 in OpenStack Compute (nova) ocata "Nova recreates instance directory after migration/resize" [Low,Fix committed] - Assigned to Lee Yarwood (lyarwood)12:52
*** andreas_s has joined #openstack-nova12:53
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804512:54
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948012:54
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories  https://review.openstack.org/55955412:54
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement  https://review.openstack.org/56548712:54
*** trozet has joined #openstack-nova12:55
*** andreas_s has quit IRC12:56
*** andreas_s has joined #openstack-nova12:57
*** andreas_s has quit IRC12:57
*** andreas_s has joined #openstack-nova12:59
*** lyan has joined #openstack-nova13:01
*** lyan is now known as Guest2765813:01
*** READ10 has joined #openstack-nova13:02
*** salv-orl_ has quit IRC13:03
*** salv-orlando has joined #openstack-nova13:03
*** mriedem has joined #openstack-nova13:03
*** udesale has joined #openstack-nova13:03
mriedemstephenfin: i know it's past it's runway slot now, but the console objects series from mel is ready to go i think if you have some time to go through it, i know you've been through the earlier patches in the series so you have some context: https://review.openstack.org/#/q/topic:bp/convert-consoles-to-objects+status:open13:04
stephenfinmriedem: Sure, I'd be happy to13:05
mriedemthanks13:06
mriedemkashyap: is there going to be more to https://blueprints.launchpad.net/nova/+spec/libvirt-cpu-model-extra-flags ?13:06
mriedemor is the bp complete?13:06
kashyapmriedem: Your comment on Friday was right13:06
kashyapmriedem: There is the one last item13:06
kashyapThat you quoted to Mel on IRC13:07
mriedemkashyap: even though the last patch says "(A future Nova patch will also allow ability to remove CPU flags.)"13:07
kashyapmriedem: We need ability to remove flags as well.  That's one more item13:07
kashyapIndeed13:07
mriedemok13:07
*** pchavva has joined #openstack-nova13:07
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Placement: Support mixing required traits with any traits  https://review.openstack.org/56574113:07
kashyapmriedem: If you are wondering why we need that.  Here is one case I wrote up:13:08
*** salv-orlando has quit IRC13:08
kashyapYou might ask: "Why would you want to remove a CPU flag though?" One13:08
kashyapscenario for that is: An Operator wants to generate a baseline CPU13:08
kashyapconfig. And a certain CPU flag is causing performance issue or other13:08
kashyapnuisance, and if the Operator isolated the problem to _that_ specific13:08
kashyapCPU flag, then she may want to remove the flag.13:08
*** pcaruana has joined #openstack-nova13:08
kashyapmriedem: And thanks for shepherding through the minor nits and merging!13:09
*** Tom-Tom has joined #openstack-nova13:09
gibimriedem: hi! regarding having one bp with two specs. Jay asked me to split the spec. Does it automatically means I have to have two bp?13:10
*** Tom-Tom has quit IRC13:12
mriedemyes13:12
*** Tom-Tom has joined #openstack-nova13:12
gibimriedem: OK, then I will file a separate bp too13:12
*** dave-mccowan has joined #openstack-nova13:12
*** zz9pzza has quit IRC13:13
*** Shilpa has joined #openstack-nova13:14
kashyapmriedem: When you get a minute, I have a different topic, which needs a opinion.  It's quick:13:16
kashyapIt's about this: https://review.openstack.org/#/c/565242/ -- libvirt: Remove support for Intel CMT `perf` events13:16
kashyapmriedem: At PTG, we agreed (based on info at that time) to log a warning when Nova's `enabled_perf_events` config is used that it is deprecated, and remove it later13:16
*** yassine_ has quit IRC13:17
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Placement: support mixing required traits with any traits  https://review.openstack.org/56574113:17
*** yassine has joined #openstack-nova13:17
gibimriedem: fixed ^^13:17
kashyapmriedem: However ... upon closer code inspection, we cannot deprecate the config itself, as there are *other* `perf` events besides Intel's CMT events.13:17
*** yassine is now known as Guest2537713:17
stephenfinmriedem, kashyap: I've just left a +1 on this because I think we should take the opportunity to clarify things a little while we're here https://review.openstack.org/#/c/565724/113:17
kashyapSo here comes my change: What i am proposing is to _remove_ the support for those three Intel CMT events, which is encoded in a dict13:17
*** dave-mcc_ has joined #openstack-nova13:17
stephenfinHowever, it's not totally related so I can bump to a +2 if you disagree13:17
kashyap(And retain the config itself)13:17
kashyapstephenfin: Let me take a quick look13:18
*** eharney has joined #openstack-nova13:19
*** mingyu has quit IRC13:19
*** dave-mccowan has quit IRC13:19
kashyapstephenfin: Your point is right about it not being clear; but it's a separate change.13:20
kashyapstephenfin: However,13:20
kashyapstephenfin: ... your nit to clean-up _is_post_copy_available() is reasonable, and I should make it in this change.13:20
kashyapIt's not a functional change, but just making it like the one below.13:21
*** bkopilov_ has quit IRC13:22
*** bkopilov has quit IRC13:22
kashyap(Even the test change, it still is maybe reasonable to adjust in the current patch.)13:22
kashyap(On a call; will look once done.)13:22
*** randomhack_ has quit IRC13:23
mriedemkashyap: i don't know why PERF_EVENTS_CPU_FLAG_MAPPING are special; you should also probably ask alex_xu about this since he helped work on this getting in13:24
kashyapmriedem: Yep, I actually meant to "Cc" alex_xu on the comment above.13:24
kashyapmriedem: The original config `enabled_perf_events` was added to monitor the flags noted in the CPU_FLAG_MAPPING13:24
kashyapThat dict has the three `perf` events for Intel CMT13:24
dansmithkashyap: I know, I just don't think it's worth it.. just MHO13:25
kashyapThe way I'm proposing is: (a) remove the broken-by-design Intel CMT (PERF_EVENTS_CPU_FLAG_MAPPING); (b) retain support for other events for `enabled_perf_events`13:25
kashyapdansmith: Hmm, it is a strict improvment, and is correcting a misleading lie that can impact instance boot13:26
kashyapSeems all the worth to me13:26
kashyapAnyway, the backports are done13:26
kashyapAnd they all pass too13:26
kashyap(It's just a couple of simple lines, FWIW)13:27
kashyapBut otherwise, in general I agree with you that minor things shouldn't be backported all the way back like that.13:27
*** belmoreira has joined #openstack-nova13:33
*** bkopilov_ has joined #openstack-nova13:34
*** awaugama has joined #openstack-nova13:34
*** bkopilov has joined #openstack-nova13:34
bauzasfolks, for those who don't know yet what I call the French May-hem, we're entering a month where a lot of French folks are out13:37
dansmithbauzas: so may is different how then?13:37
alex_xukashyap: mriedem will check that tomorrow13:38
bauzasdansmith: yesterday was a holiday, plus 3 days13:38
kashyapalex_xu: I still need to fix unit tests; I proposed it just get the core change discussion going13:38
* alex_xu is working on the family health problem, have limit bandwidth this week13:38
dansmithbauzas: that was thinly veiled sarcasm13:38
kashyapalex_xu: No worries; take care of that.  It's more important than this.13:39
bauzasyup :(13:39
alex_xukashyap: thanks13:39
bauzasanyway, just trying to explain that if people want to discuss with me, ping me directly13:40
* kashyap notices thin-veiling from dansmith 13:40
bauzashttp://www.completefrance.com/home/news/national-holidays-in-france-in-may-1-405058713:40
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider  https://review.openstack.org/50230613:43
jaypipessahid: looking at your patch now.13:49
sahidthanks jaypipes, let me know if you need any clarifications13:52
*** ratailor has quit IRC13:53
*** Eran_Kuris_ has quit IRC13:56
*** yamamoto has quit IRC13:57
*** belmoreira has quit IRC13:59
jaypipessahid: did this bug pop up in a RH customer recently or something?14:02
*** abalutoiu__ has joined #openstack-nova14:04
*** mlavalle has joined #openstack-nova14:06
*** abalutoiu_ has quit IRC14:07
*** felipemonteiro has joined #openstack-nova14:07
mriedemarvindn05: efried: jaypipes: bauzas: alex_xu: i've replied on the rebuild + image-defined traits thread; at this point i basically need to detach myself from the issue and ask melwitt or dansmith or others with fresh perspective to weigh in14:07
sahidjaypipes: yes BZ#1519540, basically two issues, one on Nova and the other in libvirt14:08
sahidhttps://bugzilla.redhat.com/show_bug.cgi?id=151954014:08
openstackbugzilla.redhat.com bug 1519540 in openstack-nova "nova reporting incorrect available memory" [High,On_dev] - Assigned to sferdjao14:08
efriedmriedem: ack14:08
*** alex_xu has quit IRC14:11
*** yamamoto has joined #openstack-nova14:11
jaypipessahid: k, reviewed.14:15
jaypipessahid: I'd be interested in getting stephenfin's eye on that too.14:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_QEMU_POSTCOPY_VERSION  https://review.openstack.org/56572414:17
kashyapstephenfin: Alright, rewrote the unit test the above way. ^  Clearer?14:17
*** alex_xu has joined #openstack-nova14:17
mriedemmdbooth: looks like it's time for https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers to go into a runway slot, are you going to be around for the next 2 weeks to respond to reviews?14:17
mdboothmriedem: Yes indeed!14:18
*** hongbin has joined #openstack-nova14:18
mdboothI'm out for the next 2 Mondays, but around apart from that and able to work on this.14:19
mriedemdone, you've got until the 16th14:19
mdboothThanks14:19
artomWhat would cause a devstack-installed compute to not report to placement?14:21
artomI see it in both hypervisor-list and service list, so it's "in" the cloud14:21
jaypipesartom: spite.14:21
mriedemmisconfig14:21
artomBut can't boot VMs on it because I see no resource provider for it14:21
mriedemnova-compute can't talk to placement api maybe14:21
mriedemcheck [placement] section of nova-cpu.conf14:21
mriedemor just read the n-cpu logs14:21
mriedemsee channel topic14:22
artomBut this is devstack ;)14:22
*** sambetts|afk is now known as sambetts14:23
artomHrmm, there's *no* [placement] in nova-cpu.conf14:23
artomThat would explain things14:23
*** Nil_ has joined #openstack-nova14:24
jaypipesartom: like I said... spite ;P14:24
artomjaypipes, against me or against placement?14:24
* artom fully expects "yes" as an answer.14:24
jaypipesartom: 4214:25
*** hemna_ has joined #openstack-nova14:26
*** rmart04_ has joined #openstack-nova14:26
*** rmart04 has quit IRC14:26
*** rmart04_ is now known as rmart0414:26
artommriedem, thanks for the pointers, I copied the controller's [placement] to nova-cpu.conf on the compute and fixed it14:28
artomSo nova-cpu.conf is new-ish? I haven't actually looked at a devstack in a while. It's for the compute service, presumably?14:29
*** alex_xu has quit IRC14:29
sahidjaypipes: yep i think you are right on your review. thanks14:30
*** felipemonteiro_ has joined #openstack-nova14:30
*** esberglu has joined #openstack-nova14:30
*** belmoreira has joined #openstack-nova14:31
mriedemartom: been around since pike14:32
artommriedem, shows how up to date I am :/14:32
jrollmriedem: gdi, this is why you need a bouncer, meant to ping you on this: https://review.openstack.org/#/c/565736/14:33
jrolls/meant/tried/14:33
mriedemartom: i don't know why you'd not have placement configured properly, devstack should have set that all up for you14:33
mriedemgfdi jim, i'm a doctor not a guy that sits up all night waiting for irc pings14:34
jrollheh14:34
*** felipemonteiro has quit IRC14:34
*** openstackgerrit has quit IRC14:34
artommriedem, I followed https://docs.openstack.org/devstack/latest/guides/neutron.html, maybe it's out of date for placement? Specifically, ENABLED_SERVICES on the compute14:34
*** links has quit IRC14:34
mriedemyes definitely14:35
mriedemplacement-client should be in that list14:35
mriedemlike https://docs.openstack.org/devstack/latest/guides/multinode-lab.html#configure-compute-nodes14:36
artommriedem, aha, indeed14:36
artomShall I apply force to a change in the textual representation of the documentation?14:37
mriedemyes14:37
mriedembe a good citizen14:37
artomService guarantees citizenship!14:37
jaypipessahid: ok, cool. test cases should be identical, though, so that's a plus :)14:38
*** jmlowe has quit IRC14:39
*** felipemonteiro_ has quit IRC14:42
Shilpastephenfin: Hi14:42
*** felipemonteiro_ has joined #openstack-nova14:42
stephenfinShilpa: o/14:43
kashyapartom: Also, do post your renewed multi-node configs somewhere14:43
jaypipesmriedem, stephenfin, dansmith: your reviews on https://review.openstack.org/#/c/561315/ would be appreciated. thx in advance :)14:43
kashyapartom: For that poor soul who has to later setup to debug an "urgent" issue14:44
Shilpastephenfin: i have verified tempest failure for https://review.openstack.org/#/c/550172/3 locally, and added few observations at http://paste.openstack.org/show/720231/, kindly go through the same.14:44
kashyapMine are here: https://kashyapc.fedorapeople.org/virt/openstack/multi-node-configs/  (But they should be revamped)14:44
stephenfinShilpa: Can do14:44
stephenfinkashyap: Yup, v2 of that looks much better. Thanks for addressing that.14:45
stephenfinStill have comments on the preceding patch, fyi14:45
kashyapstephenfin: No problem.  Thanks for _spotting_ it.14:45
*** vladikr has quit IRC14:45
kashyapstephenfin: Oh, I see.  Let me look14:46
*** dtantsur|brb is now known as dtantsur14:46
*** dpawlik has quit IRC14:46
artomkashyap, sure. The "tricky" bit was the hardware setup14:46
*** felipemonteiro__ has joined #openstack-nova14:46
artomSince I need to run on baremetal and don't control the network, I ended up cross-connecting the two machines on a second NIC and setting that as PUBLIC_INTERFACE14:47
kashyapNested Virt for the win!14:47
artomkashyap, for NUMA live migration? Suuure ;)14:47
kashyapstephenfin: Okido, addressing that too14:47
kashyapartom: For testing PCI device assignment & NUMA, it is possible to an extent: https://www.berrange.com/posts/2017/02/16/setting-up-a-nested-kvm-guest-for-developing-testing-pci-device-assignment-with-numa/14:48
artomBtw, I spent way too much setting up a thing where I could snapshot my entire devstack OS and revert, in case devstack failed and I needed to go back without having to reinstall from a USB key, but then my stack run essentially worked the first time, so :/14:49
jmccarthyHmm I seem to have some behaviour where disk.info shows up on the source host after a resize/cold migrate sort of like this review/bug: https://review.openstack.org/#/c/437356/14:50
jmccarthyAlthough I have my nova repo checked out and 'tox -e py27 -- test_cleanup_resize' tests all pass locally, should these also cover cinder for the case: volume_driver = cinder.volume.drivers.lvm.LVMVolumeDriver ?14:50
*** felipemonteiro_ has quit IRC14:50
*** vladikr has joined #openstack-nova14:50
*** mvk has quit IRC14:52
Shilpastephenfin: if you are busy elsewhere we can discuss the same tomorrow.14:57
stephenfinShilpa: Yeah, if you wouldn't mind. Have a lot on my plate today14:57
Shilpastephenfin: no issues, bye for now14:58
*** openstackgerrit has joined #openstack-nova14:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_CPU_POLICY_VERSIONS  https://review.openstack.org/56401214:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_QEMU_POSTCOPY_VERSION  https://review.openstack.org/56572414:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_REALTIME_VERSION  https://review.openstack.org/56570714:58
jmccarthys/these also cover cinder/these also cover nova/14:59
*** bhujay has joined #openstack-nova15:01
*** rmart04 has quit IRC15:01
*** jmlowe has joined #openstack-nova15:01
*** tbachman has quit IRC15:01
*** jmlowe has quit IRC15:03
*** udesale has quit IRC15:03
*** jmlowe has joined #openstack-nova15:04
melwittmriedem: I'll wade through the rebuild thread later15:05
melwittmriedem: also, thanks for swapping the runway blueprint. I forgot to do it last night15:05
*** gjayavelu has joined #openstack-nova15:05
mriedemmelwitt: re the rebuild + required image traits thing, at this point for simplicitly i'd probably just concede to the idea of failing in the api if the new image has required traits which aren't in the original image used to create the server15:06
*** vladikr has quit IRC15:06
mriedemand then hope that no one ever asks to support that later15:06
mriedemand if they do, you're no longer working on nova15:06
*** alex_xu has joined #openstack-nova15:07
melwittbased on my limited understanding of traits, I don't immediately see why the original image is tied to rebuilding with a new image and why it would need to reject it. so I shall read the thread to learn why :P15:07
*** belmoreira has quit IRC15:09
cfriesen__sean-k-m1: sean-k-mooney[m]: do you know the current status of https://blueprints.launchpad.net/nova/+spec/sriov-physical-function-passthrough (where a device can be allocated as either a VF or the full PF)15:10
*** germs has joined #openstack-nova15:10
*** germs has quit IRC15:10
*** germs has joined #openstack-nova15:10
*** moshele has quit IRC15:11
mriedemmelwitt: b/c the host the instance is running on during rebuild is filtered using the original image and it's required traits15:11
melwittoh, right, because rebuild can't move15:12
melwittI see15:13
*** cfriesen__ is now known as cfriesen15:14
*** vladikr has joined #openstack-nova15:14
*** zhaochao has quit IRC15:16
*** vladikr_ has joined #openstack-nova15:20
*** yamamoto has quit IRC15:21
*** vladikr has quit IRC15:21
*** salv-orlando has joined #openstack-nova15:23
*** jaosorior has joined #openstack-nova15:23
*** dpawlik has joined #openstack-nova15:24
*** mingyu has joined #openstack-nova15:24
openstackgerritStephen Finucane proposed openstack/nova master: Deprecate the nova-consoleauth service  https://review.openstack.org/56536715:26
*** shewless has joined #openstack-nova15:27
efriedstephenfin: You gonna go around and change all the other deprecations in the docs?  There were about a dozen I counted yesterday.15:28
*** dpawlik has quit IRC15:29
stephenfinefried: I can but where?15:31
efriedstephenfin: I went and looked for them yesterday.  I can go find 'em again.15:31
efriedstephenfin: But I guess if I'm gonna do that, I may as well fix 'em myself :)15:32
shewlessHi there. I have an instance which is allocated 2GB of RAM but when I look at the qemu process it looks like it's comsuming closer to 8GB of RAM.  This is a huge discrepency.  Can anyone help me figure out what's going on?15:33
shewlessIt kind of looks like we are seeing an extra 6GB of memory usage (over what's been allocated) PER instance?15:33
stephenfinefried: That...would make sense, yes :)15:35
shewlessI thought that in general a qemu process would use less or equal to what's been provisioned for that instance. Is that wrong?15:36
efriedstephenfin: This produced 29 results, which will need to be inspected manually to see if a .. deprecated:: marker is actually appropriate:15:38
efried# rgrep -i deprecated doc/source | awk -F: '$1 ~ /rst$/'15:38
*** felipemonteiro__ has quit IRC15:39
*** tbachman has joined #openstack-nova15:41
openstackgerritMatt Riedemann proposed openstack/nova master: Remove IronicHostManager and baremetal scheduling options  https://review.openstack.org/56580515:42
openstackgerritMatt Riedemann proposed openstack/nova master: Remove [scheduler]/host_manager config option  https://review.openstack.org/56580615:42
mriedemjroll: ^15:42
jrollwoot15:42
sahidshewless: we know that there are some kind of overheads depending of the number of vCPUs, devices... but 6GB looks crazy, perhaps you should ask #virt in OFTC servers with the exact arguments you are passing to QEMU15:43
*** salv-orlando has quit IRC15:43
*** salv-orlando has joined #openstack-nova15:43
shewlesssahid thanks I'll check there15:43
*** mingyu has quit IRC15:43
*** salv-orlando has quit IRC15:44
openstackgerritsahid proposed openstack/nova master: network: update pci request spec to handle trusted tags  https://review.openstack.org/45882015:45
openstackgerritsahid proposed openstack/nova master: libvirt: configure trust mode for vfs  https://review.openstack.org/45851415:45
openstackgerritsahid proposed openstack/nova master: pci: don't consider case when match tags specs  https://review.openstack.org/56580815:45
*** tbachman_ has joined #openstack-nova15:45
*** andreas_s has quit IRC15:45
*** tbachman has quit IRC15:46
*** tbachman_ is now known as tbachman15:46
*** andreas_s has joined #openstack-nova15:46
*** mingyu has joined #openstack-nova15:47
*** lucasagomes is now known as lucas-afk15:47
*** jmccarthy has quit IRC15:48
*** vladikr_ has quit IRC15:48
*** jaosorior has quit IRC15:49
efriedstephenfin: That deprecated role ain't especially pretty IMO.15:50
*** andreas_s has quit IRC15:51
stephenfinIn what regard?15:51
*** ragiman_ has quit IRC15:51
efriedlet's see if your delta has rendered yet...15:51
efriedstephenfin: http://logs.openstack.org/67/565367/9/check/build-openstack-sphinx-docs/c46fab1/html/cli/nova-consoleauth.html15:53
efriedstephenfin: I guess I was expecting a box, like .. note::15:53
openstackgerritJay Pipes proposed openstack/nova-specs master: update add-consumer-generation to focus on API  https://review.openstack.org/56556515:53
sahidcfriesen__ it's implemented15:53
efriedstephenfin: It's aight, I suppose.15:53
stephenfinefried: Yeah, that's openstackdocstheme. Wonder what the reasoning for that was15:56
efriedstephenfin: I'm sure it's related to it never being used, but I wonder if it's cause or effect :)15:57
*** tssurya has quit IRC15:57
*** hamzy has quit IRC15:58
stephenfinefried: Could be. I thought oslo.config used it but it actually uses '.. warning' too. I should fix that https://docs.openstack.org/nova/queens/configuration/config.html15:59
openstackgerritAditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin  https://review.openstack.org/53437115:59
*** gyee has joined #openstack-nova15:59
*** sahid has quit IRC15:59
*** damien_r has quit IRC16:02
*** janki has quit IRC16:02
*** dpawlik has joined #openstack-nova16:04
openstackgerritEric Fried proposed openstack/nova master: Use .. deprecated:: theme for deprecations  https://review.openstack.org/56582216:05
efriedstephenfin: Here it is ^ but I'll probably abandon it, unless we want to fix the theme to make it prettier.16:05
*** efried is now known as efried_rollin16:05
*** dpawlik has quit IRC16:09
jrolljaypipes: do you know if we need to report these as zero, or can we just drop them all? https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L76416:10
*** vladikr has joined #openstack-nova16:10
evrardjpmriedem: thanks for the patch in OSA :)16:13
*** do3meli has quit IRC16:13
jrolljaypipes: ah, I think unit tests answered that for me, never mind. :)16:14
mriedemevrardjp: np16:16
*** tesseract has quit IRC16:18
arvindn05mriedem: replied back to the thread on rebuild with image traits. Will look for further update from melwitt or dansmith16:20
*** felipemonteiro has joined #openstack-nova16:20
mriedemevrardjp: s/OSA/literally everything/ +(status:open+OR+status:merged)16:20
mriedemhttps://review.openstack.org/#/q/topic:exact-filters+(status:open+OR+status:merged)16:20
*** yamamoto has joined #openstack-nova16:21
evrardjpmriedem: I haved guessed that ;)16:22
evrardjpmriedem: but still thank you.16:22
evrardjp:D16:22
arvindn05mriedem: i think we are on the same page in case we choose to reject the request at the API layer. the spec had the same intent16:22
EmilienMmriedem: thanks for https://review.openstack.org/#/c/565824/ - I took over, just see my comment for the FYI16:23
arvindn05> If the image's required traits have changed from the original image, we can reject the rebuild request. Effectively, since the qualitative requirements have changed the user should create a new instance.16:24
arvindn05https://review.openstack.org/#/c/560718/6/specs/rocky/approved/glance-image-traits.rst - line 100. I will make it more clear like i did in the ML16:24
mriedemEmilienM: ack thanks16:25
*** salv-orlando has joined #openstack-nova16:26
mriedemEmilienM: i suspect the depends-on is backward anyway for any of these deployment projects that gate on ironic, which tripleo does?16:26
mriedembut i didn't want the nova change depending on 20 random other deployment projects16:26
EmilienMmriedem: yeah it's fine16:27
*** yamamoto has quit IRC16:27
*** salv-orlando has quit IRC16:29
*** salv-orlando has joined #openstack-nova16:30
*** Guest25377 has quit IRC16:33
*** salv-orlando has quit IRC16:34
openstackgerritArvind Nadendla proposed openstack/nova master: update scheduler to use image-traits  https://review.openstack.org/56059616:38
*** bhujay has quit IRC16:41
*** tbachman has quit IRC16:41
*** tbachman has joined #openstack-nova16:46
openstackgerritJim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources  https://review.openstack.org/56584116:46
jrollmriedem: one more in your ironic chain for you ^16:46
mriedemquestion inline16:51
jrollah thanks16:53
mriedemdansmith: so for this CLI to fix allocations in placement for instances scheduled using the CachingScheduler, i'm trying to think where that should live, since none of the nova-manage subcommands really fit that; we could do something like,16:56
mriedema) nova-manage placement ...16:56
mriedemb) placement-manage ...16:56
mriedemc) throw it in osc-placement16:56
mriedemalthough (c) isn't really meant for something like this16:57
*** tssurya has joined #openstack-nova16:57
dansmithyeah, it's a pretty oddball thing16:57
mriedemwe're fixing allocations for nova instances,16:57
dansmithit's also a placement client sort of thing, so it's weird to have it in nova-manage,16:57
mriedemso thinking: nova-manage placement fix_allocations16:57
dansmithbut placement-manage would be the opposite16:57
mriedemright, we need the instance uuid to find it's host/node to get the node uuid to find the resource provider it should have allocations against16:58
dansmithmriedem: maybe we need a generic nova-manage group, like "nova-manage fix-our-mess" or "nova-manage maintenance ..."16:58
mriedemso doing instance lookups from a placement-manage is weird16:58
*** mingyu has quit IRC16:58
dansmithcould use that generic group for syncing aggregate membership, fixing cinder attachments (historically)16:58
mriedemjaypipes: where were you going to throw the nova-manage sync CLI for aggregates?16:59
dansmithmriedem: wherever you tell him to16:59
dansmith:P16:59
mriedemwas just wondering if his gears were grinding on that yet17:00
*** derekh has quit IRC17:00
*** weshay|ruck is now known as weshay17:00
*** mgoddard has quit IRC17:00
*** mingyu has joined #openstack-nova17:02
*** tbachman has quit IRC17:02
openstackgerritMatt Riedemann proposed openstack/nova master: Remove [scheduler]/host_manager config option  https://review.openstack.org/56580617:03
mriedemi'm partial to 'nova-manage placement ...'17:03
mriedembut don't care too much17:03
mriedemgonna get lunch17:04
dansmithmelwitt: mriedem: tssurya: I've been completely covered up in other stuff for the last week.. I have nothing cellsy to talk about, unless the cern peeps have things to report?17:04
dansmithmriedem: well, I just don't know that we'll have enough in there to justify the group, but whatever you want17:04
*** openstackgerrit has quit IRC17:04
mriedemdansmith: we'll have at least 2 things, this and jay's sync aggs thing17:05
mriedemi don't have any cells stuff to talk about17:05
*** moshele has joined #openstack-nova17:06
tssuryadansmith: not really except that we moved to cellsv2, and basic operations take more time than for cellsv1 , we are trying to optimize whatever possible, but since belmiro won't be around today as its a Euro unfriendly meeting timing, we can give the overall experience in the next week's meeting17:07
*** hamzy has joined #openstack-nova17:07
dansmithtssurya: okay, yeah would be good to hear an analysis of what takes longer so we can think about what to do17:07
*** yamahata has joined #openstack-nova17:08
tssuryadansmith: yep17:08
*** dpawlik has joined #openstack-nova17:08
*** Swami has joined #openstack-nova17:08
dansmithcellsv1 cheated with cache coherency, so not surprising that some things will take longer to be correct ;)17:09
tssuryadansmith: haha, yea I get it but querying to all 70 DBs versus top cell having all info is also the toll maybe17:09
dansmithtssurya: you guys are on pike yeah?17:09
tssuryadansmith: skipped pike, moved straight to queens :)17:10
tssuryafrom ocata17:10
*** felipemonteiro_ has joined #openstack-nova17:10
dansmithoh17:10
dansmithyeah, so you should have the parallel instance listing,17:11
dansmithalthough we do iterate the cells in other places where we could optimize17:11
dansmithtssurya: https://review.openstack.org/#/c/509003/17:11
dansmiththat would help you more than most17:11
jaypipesmriedem: nova-manage placement ... works for me.17:11
tssuryadansmith: exactly, we are trying to optimize such things, however we also had some DB side issues, some being slower than the others,17:11
tssuryadansmith: oh I have never come across that patch17:12
tssuryathanks17:12
*** dpawlik has quit IRC17:12
*** gjayavelu has quit IRC17:12
dansmithtssurya: that would make us only query the cells a particular tenant has instances in, which I think in your case would be a big win.. like going from 70 to 2 or something17:13
*** germs has quit IRC17:14
*** sdeath has quit IRC17:14
tssuryadansmith: wow, too bad we did not know about this patch being there all along17:14
dansmithtssurya: well, my fault for letting it languish17:15
*** felipemonteiro has quit IRC17:15
tssuryaI didn't even know CellMappingList.get_by_project_id existed17:15
dansmithtssurya: it doesn't, look below :)17:15
tssuryawhat we did was to go through InstanceMappings17:15
dansmithtssurya: could be an easy backport17:15
tssuryaand nova list became fast,17:15
dansmithtssurya: yeah that's what it does17:15
tssuryadansmith: yes this is exactly what we did, we patched it the same way17:17
dansmithcool17:17
tssuryaexcept if I had known you had this we would have backported :D17:17
dansmithheh17:17
dansmithI will get this rebased today17:17
*** germs has joined #openstack-nova17:17
*** germs has quit IRC17:17
*** germs has joined #openstack-nova17:17
*** dtantsur is now known as dtantsur|afk17:17
tssuryadansmith: thanks ! would be really nice to have this upstream17:17
*** gjayavelu has joined #openstack-nova17:18
*** germs has quit IRC17:18
*** germs has joined #openstack-nova17:19
*** germs has quit IRC17:19
*** germs has joined #openstack-nova17:19
melwitttssurya: so even with the all cell query executed in parallel, you saw it being slow to list instances?17:20
dansmithmelwitt: they have some very slow databases, which will hold up the query unnecessarily17:20
*** gjayavelu has quit IRC17:20
melwittI see17:20
tssuryamelwitt: once we had the list using InstanceMapping it was fast, but yes even with parallel querying under the current master code it is slow than cellsv117:21
tssuryadue to DB issues like dan said17:21
melwittgotcha17:21
dansmithit makes it as slow as the slowest db, of course17:22
dansmithwhich isn't really avoidable in general, but since they have lots of cells, but few per tenant, they will get more gain from this than people that don't do that17:22
dansmithtssurya: some of your cell dbs are far away from the controller too right?17:23
tssuryadansmith: eys17:23
tssuryayes*17:23
*** tbachman has joined #openstack-nova17:23
dansmithyeah, so that's related17:23
dansmithpunishes everyone17:23
dansmithtssurya: since the beginning we've said we will probably have to do some caching at the top for situations like that,17:23
dansmithbut we also always said we'd wait until we had something to measure17:23
*** yamamoto has joined #openstack-nova17:23
dansmithso that bill may be coming due soon17:23
tssuryadansmith: yea we are measuring stuff, belmiro will give a upgrade talk at the summit17:24
dansmithcool17:24
*** gjayavelu has joined #openstack-nova17:25
melwittto the earlier question about the cells meeting, I don't have anything other than a request for review on this patch to make affinity work with multiple cells https://review.openstack.org/54025817:25
tssuryafor instance another point I wanted to know was this : https://bugs.launchpad.net/nova/+bug/1767303, we filed a new bug to only go through cells that are needed now that we have disabled the host_state cache. I will put a POC once we test the performance in our envo.17:26
openstackLaunchpad bug 1767303 in OpenStack Compute (nova) "Scheduler connects to all cells DBs to gather compute nodes info" [Undecided,New] - Assigned to Surya Seetharaman (tssurya)17:26
tssuryabut yea, we can also talk in the next week's meeting after we see if scheduling time improves17:27
mgagnetssurya: is there a blog post or something I can read about your migration to CellsV2? Or should I wait until summit to hear it first-hand at one of the talk?17:27
tssuryamgagne: we will try to put up one soon :) we are still putting out fires17:28
mgagnetssurya: all fine, I'm currently sitting in a fire too =)17:28
dansmithtssurya: cool, makes sense17:28
tssuryamgagne: your also on cellsv2 ?17:28
dansmithmgagne: how many cells do you have?17:28
tssuryayou are*17:29
mgagnetssurya: running CellsV1 Mitaka17:29
tssuryamgagne: ack17:29
mgagnedansmith: more than 1 =)17:29
*** gjayavelu has quit IRC17:29
*** yamamoto has quit IRC17:29
mgagnedansmith: I'm not (yet) concerned with performance, only the migration process with multiple cells17:29
*** mgoddard has joined #openstack-nova17:36
*** mdnadeem has quit IRC17:38
mriedemtssurya: do you know if cern was/is using the CachingScheduler before upgrading to ocata+?17:38
tssuryamriedem: no we weren't and aren't17:39
mriedemok17:39
*** shewless has quit IRC17:39
tssuryadansmith: not urgent, but whenever you get the time could you re-instate the +2 on https://review.openstack.org/#/c/559299/ , its the clean up on the bp which has been held up for some time.17:41
*** sambetts is now known as sambetts|afk17:41
*** mdbooth has quit IRC17:41
dansmithtssurya: done, sorry17:42
tssuryadansmith: thank you! :)17:42
*** dpawlik has joined #openstack-nova17:46
*** hjensas has joined #openstack-nova17:47
*** hjensas has quit IRC17:47
*** hjensas has joined #openstack-nova17:47
*** dpawlik has quit IRC17:50
*** moshele has quit IRC17:51
*** moshele has joined #openstack-nova18:08
*** mgariepy has quit IRC18:09
mriedemjroll: is oath using the CachingScheduler for baremetal scheduling?18:10
*** moshele has quit IRC18:13
*** mgariepy has joined #openstack-nova18:15
jrollmriedem: no, that would be insane, we wrote our own scheduler driver of course :|18:16
jrollmriedem: (it's subclassed from filter scheduler and we're likely dropping it in ocata, so carry on with the config drops and such)18:16
mriedemjroll: was more about the ML thread on this wrt caching scheduler18:17
mriedemand mgagne replies about performance of baremetal scheduling with the caching scheduler18:18
jrollmriedem: we'll find out soon about performance on the filter scheduler in ocata. in juno we did this crazy claims thing I proposed upstream and then dropped a while back18:18
jrollhttps://review.openstack.org/#/c/204641/18:19
mgagneI guess I'm alone going at ludicrous speed with CachingScheduler =)18:20
jrollheh18:20
jrollwith racing fixed with the resource classes stuff, I'm not sure the scheduler performance matters so much18:20
mgagneit was impossible to boot like 100 baremetal at the same time with FilterScheduler, now it's possible with CachingScheduler.18:21
jrollas baremetal machines take minimum 5 minutes to deploy and boot anyway18:21
jrollright18:21
jrollmgagne: what version are you on?18:21
mriedemmitaka18:21
mgagnejroll: the best and greatest Mitaka ;)18:21
mriedemmgagne: do you see a fair number of reschedules?18:22
jrollah yeah. I suspect in master, a bunch of concurrent boots are just fine18:22
mgagneafaik, no. we run only one scheduler as cache is done in-memory and not shared18:22
* jroll assumes you're running into collisions, not slow selection18:23
mgagnewe used to see a lot of rescheduling with FilterScheduler IIRC18:23
mriedemwell, CachingScheduler is FilterScheduler18:23
mriedemexcept with the cache18:23
mgagnejroll: remember that OOM issue you had with scheduler with ironic? ;)18:23
jrollheh18:23
jrollthat was loading instances and such18:24
*** ccamacho has quit IRC18:24
mgagnescheduler taking a gazillion bytes of ram18:24
mgagnejroll: yea, great stuff18:24
jrollidk, I'd like to see some benchmarking on master before we make decisions about CachingScheduler being useful on master18:24
mriedemi've asked for benchmarking between placement + filterscheduler and cachingscheduler since at least ocata/pike at every summit18:25
mgagnejroll: being useful is not really the issue, it's more that a migration path is not ready yet for those using CachingScheduler18:25
mriedemmgagne: i'm working on that CLI right now18:25
*** yamamoto has joined #openstack-nova18:25
jrollright, if we backport that CLI we should be all good18:25
mriedemand i did remember when replying to the ML that newton and ocata computes will write allocations to placement,18:25
mriedemit was only in pike when we disabled that because the filter scheduler creates the allocations now18:26
mgagnemriedem: tyvm for working on it. IMO, if it's not merged, it's not done. hence my concern with removing stuff that could break my use case.18:26
mriedemmgagne: sure, but also, if you're on mitaka, you have plenty of time for this to land before you're ready to roll to it18:26
mriedemi.e. the cachingscheduler and ironic_host_manager removal18:27
mgagnemriedem: I'm more on a defensive stance with that regard, can never be too careful18:27
*** eharney has quit IRC18:27
*** mingyu has quit IRC18:27
mriedemi understand :)18:28
mgagneon principal, I can't agree with someone suggesting a new feature/fix not yet merged to replace something that is going to be removed.18:28
*** fragatina has quit IRC18:30
*** READ10 has quit IRC18:30
mgagneor principle?18:30
*** yamamoto has quit IRC18:31
artomThe latter18:31
*** openstackgerrit has joined #openstack-nova18:35
openstackgerritDan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method  https://review.openstack.org/50900218:35
openstackgerritDan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells  https://review.openstack.org/50900318:35
dansmithtssurya: ^18:35
tssuryadansmith: ack, and thanks18:35
dansmithI think we may want to consider a flag to let you choose between "always scatter to all cells" and "only hit cells for which you have instances"18:35
dansmithfor your case, the latter will be a big improvement, but for people that spread across cells, doing the extra mapping lookup will be a waste18:36
tssuryadansmith: sounds good, yea makes sense18:36
mgagneartom: :)18:37
tssuryabut are you talking about doing this in the listing context alone ? or a generic flag for the scatter-gather utility18:37
*** gjayavelu has joined #openstack-nova18:37
dansmithscatter-gather can't do it generically,18:37
dansmithbecause it only applies to instances18:37
dansmithso it would just be instance listing that would honor that18:38
jrollhow ready for primetime is cells v2 in ocata?18:38
tssuryayea I mean scatter-gather already has the selected cells querying option, what I mean was this "only hit cells for which you have instances" sounds really appealing in a lot of places18:38
tssuryalike quota calculating while booting18:39
tssuryacalculation*18:39
tssuryameant*18:39
tssuryaso was wondering if there was a way to flag this more generically18:39
dansmithtssurya: sure, it makes sense to do it in those sorts of places, I just think it has to be baked into each one that is tenant-scoped18:39
tssuryadansmith: hmm, yea18:39
dansmithtssurya: anywhere we can do tenant-scoped lookups should look at that flag, if that's what you mean18:40
dansmithjroll: not very18:40
jrollwhomp whomp18:40
tssuryadansmith: yes,18:40
melwittjroll: multi cell is not a thing in ocata, I'd say18:41
jrollmelwitt: yeah, that was my actual question, thanks18:42
melwittand, affinity scheduling doesn't work with multi cell yet, there's a bug (I have a patch up to fix it) https://review.openstack.org/54025818:43
melwittI know that's something y'all need18:43
jrolltis, thanks for that18:45
*** sridharg has quit IRC18:46
*** mgoddard has quit IRC18:49
*** imacdonn has quit IRC18:54
*** imacdonn has joined #openstack-nova18:54
*** felipemonteiro__ has joined #openstack-nova18:59
*** felipemonteiro_ has quit IRC18:59
melwitthm, seeing an issue where a BFV instance being deleted fails to detach the volume because attachment_id = None http://logs.openstack.org/01/565601/2/check/tempest-full/f1004d9/controller/logs/screen-n-cpu.txt.gz#_May_02_03_50_00_95805019:02
cfriesenanyone know offhand what's causing this failure when running tox against newton? http://paste.openstack.org/show/720243/19:03
melwittdid you do a tox -e<whatevs> -r first?19:04
melwittusually have to do that when you switch branches19:04
cfriesenwill try that, thanks19:05
melwittusually you'll have different deps versions required per branch and that's where those errors come from. if the env has a module version missing an attribute that another branch needs19:06
*** spsurya has quit IRC19:09
melwittso for the BFV volume detach, it's using the old attach API, that means bdm.attachment_id was not set or None19:11
melwittand then the old os-detach API is called with attachment_id = null and that yields a 400 from cinder19:11
*** efried_rollin is now known as efried19:13
*** fragatina has joined #openstack-nova19:13
melwittnow to figure out why attachment_id isn't set for a BFV instance created from a snapshot19:13
*** fragatina has quit IRC19:14
*** fragatina has joined #openstack-nova19:15
*** fragatina has quit IRC19:16
*** fragatina has joined #openstack-nova19:18
*** fragatina has quit IRC19:18
*** fragatina has joined #openstack-nova19:19
*** fragatina has quit IRC19:19
*** fragatin_ has joined #openstack-nova19:21
mriedemmelwitt: i know exactly why19:22
arvindn05efried: thanks for the review :). For the comment on the commit message, i just squash my individual commits to create the single commit that gerrit requires..hence the Added unit and functional tests19:22
mriedemmelwitt: https://review.openstack.org/#/c/541420/19:22
melwittyesss, I was hoping there was already a patch for dat19:22
mriedemmelwitt: either way, when detaching we should know if we're doing new style detach (attachment_id is not None) or old style detach19:22
efriedarvindn05: You mean in your sandbox you had multiple commits, one that did the code and one that did the test, and you squashed them together before proposing them to gerrit?19:23
arvindn05yup19:23
efriedarvindn05: Yeah, that doesn't change my opinion :)  There's no need for a commit message on a change that clearly has unit and functional tests to say that it has unit and functional tests.19:23
melwittmriedem: right. we're doing old style because attachment_id is None but, attachment_id sent over to cinder in the old style os-detach action call is also None which gets a 400 response19:23
efriedarvindn05: But you notice I'm not blocking on it either.19:23
melwittso old style detach fails19:24
mriedemwe don't send an attachment_id to os-detach in cinder19:24
mriedemit's not a parameter for that api19:24
mriedemwell, i don't think it is19:24
melwittit's in the log here http://logs.openstack.org/01/565601/2/check/tempest-full/f1004d9/controller/logs/screen-n-cpu.txt.gz#_May_02_03_50_00_95805019:24
mriedemfor new style detach, we'd call attachment_delete19:24
mriedemlog schmog, that's fake news19:25
melwittit's the only thing we're sending19:25
arvindn05efried: cool....i dont like the gerrit workflow...more used to github which allows individual commits and lets the maintainer decide on squash vs rebase vs commit as is19:25
arvindn05but going with the flow :)19:25
melwittWHAT SAY YOU19:25
efriedarvindn05: You're welcome (even encouraged) to split up reviews in gerrit, though generally if along test/impl lines the test should come first.19:26
efriedarvindn05: Me, I've never used github, so no basis for comparison there.19:26
mriedemoh yeah i guess os-detach does take an attachment_id parameter, which is optional19:26
melwittit's weird that of all the params, that's the only thing we're sending. seems wrong19:27
mriedemmelwitt: we can't detach the volume on a volume-backed instance, is that what you're trying to do?19:27
mriedem*root volume19:27
*** yamamoto has joined #openstack-nova19:27
melwittmriedem: maybe. this is a delete_on_termination=True instance created from a snapshot (the tempest test) and when we delete the instance, it tries to detach the volume and delete it. and it fails to detach it19:28
mriedemthis schema check looks wrong19:28
mriedemInvalidInput: Invalid input received: Invalid input for field/attribute attachment_id. Value: None. None is not of type 'string'19:28
melwitta BFV instance, that is19:28
mriedemthis schema doesn't say attachment_id is required https://github.com/openstack/cinder/blob/master/cinder/api/schemas/volume_actions.py#L7319:29
mriedemand it allows null19:29
mriedemoh no sorry19:29
mriedemthat says you don't have to put a body in it19:29
melwittso what's the correct flow for deleting a BFV instance with delete_on_termination=True? has to detach and then delete the volume, the volume can't be deleted if it's in-use19:30
arvindn05efried: in gerrit, subsequent changes are always amends for a single review which means on the git side, you do lose history.  If you wanted to say revert changes back to commit #2, we would need to download the code from gerrit for PS#2...anyway just my rant from using both github and gerrit :)19:31
efriedarvindn05: You can do commits in series, which means you use a different change-id for the second commit but set the first commit as its parent.19:32
mriedemmelwitt: the attachment_id getting passed to cinder isn't from the bdm, it's from the volume['attachments'] information, which is a thing that existed before the new style attach flow https://github.com/openstack/nova/blob/master/nova/compute/api.py#L402619:32
*** rmart04 has joined #openstack-nova19:33
*** yamamoto has quit IRC19:33
efriedarvindn05: example: https://review.openstack.org/#/c/565279/2 is first, https://review.openstack.org/#/c/564351/5 is second, https://review.openstack.org/#/c/517757/33 is third in the series.19:33
mriedemthis code is likely all old and busted and should be removed https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L537-L55919:34
mriedemsince we don't support multiattach volumes with old style attachments19:34
openstackgerritMerged openstack/nova master: Remove ExactCoreFilter ExactDiskFilter ExactRamFilter  https://review.openstack.org/50888619:34
mriedemthat was all prep work written in mitaka https://review.openstack.org/#/c/193134/19:35
melwittarvindn05: yeah, with gerrit, you can't have multiple commits in one "review". so to do that, you have to make a stack of gerrit reviews (one review per commit) and then upload them together. you just do all of your commits as usual, then 'git review' will upload all of them as separate reviews that depend on each other19:35
*** linkmark has joined #openstack-nova19:35
mriedemmelwitt: so it looks like we have a bug that we still pass an attachment_id to os-detach even if we don't have an attachment_id19:36
-openstackstatus- NOTICE: The Gerrit service at review.openstack.org will be offline starting at 20:00 (in roughly 25 minutes) for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html19:36
*** damien_r has joined #openstack-nova19:36
melwittmriedem: okay, so an empty body os-detach will still do the right thing and detach the volume19:36
mriedemmaybe, not really sure, we don't have tests that try to detach a root volume19:37
melwittI'll try depends-on your patch and see if it makes the tempest test change work (I added an assert that the volume was gone and that failed because the volume couldn't be detached and thus deleted)19:37
mriedemmelwitt: ok, but you need this to get ceph working on stable branches?19:38
melwittmriedem: on master. I don't know why it's failing 100% now over this "volume dependent on snapshot" issue when it didn't use to, but that's what's going on19:39
mriedemok deps-on my patch and then we'll go from there19:39
arvindn05melwitt: efried: ahh...k. will keep that in mind. Good workflow to use when all of your commits are complete...if the last one  is WIP, we will have to mark it in gerrit review i guess19:39
melwittbut because the test does not first remove the volume snapshot, the second instance can't be deleted. I Don't Know How This Ever Worked(tm) for ceph19:40
arvindn05learn something new about gerrit everyday :)19:40
efriedarvindn05: Happens all the time.  Even ones that *aren't* the last one get marked WIPs.19:40
efriedarvindn05: And the whole series doesn't merge at once; they merge bottom up like you would expect.19:40
efriedeach is a dependency of the next.19:40
melwittarvindn05: yeah, the usual way is to just prepend your commit message subject line on the WIP one with "WIP"19:40
mriedemmelwitt: the test wasn't skipped for the ceph job before was it?19:41
arvindn05thanks!19:41
melwittmriedem: it might have been. I can't think of any other way this makes sense but I didn't find that yet. tbh I don't remember where to find the skip list for ceph19:42
*** eharney has joined #openstack-nova19:42
mriedemi don't think it ever landed, i remember cleaning up something about this recently19:43
mriedemhttps://review.openstack.org/#/c/550497/19:43
*** mvk has joined #openstack-nova19:45
melwittso both skip list changes are abandoned ... does that mean there's no skip list? I'm confused19:46
*** linkmark has quit IRC19:46
melwittso that implies that test is new? *looks*19:47
mriedemit's not new19:47
mriedemit's only recently been renamed19:47
mriedembut the idempotent id hasn't changed19:47
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add nova-manage placement heal_allocations CLI  https://review.openstack.org/56588619:47
melwitthrm19:47
mriedemmgagne: dansmith: ^ here is my start, sans tests and docs and lots of todos/notes19:47
mriedemmelwitt: this is the job definition, and no it doesn't have a skip list http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/playbooks/legacy/tempest-dsvm-py35-full-devstack-plugin-ceph/run.yaml#n219:48
mriedemjbernard was working on one but as you can see those patches were all abandoned19:48
melwittdoubleyew tee eff19:48
mriedemso for awhile the job was just totally broken19:48
melwittI don't know how this test could ever pass with ceph19:48
melwittand the job hasn't been broken for _that_ long, I didn't think19:49
melwittanywho19:49
mriedemmelwitt: could be that it wasn't using DEVSTACK_GATE_TEMPEST_FULL19:50
*** lpetrut has joined #openstack-nova19:50
mriedemtempest tox -e full runs tempest api tests concurrently and then scenario tests serially19:51
mriedemand this is a scenario tes19:51
mriedem*test19:51
efriedarvindn05: Do we always have access to the old image metadata during a rebuild?19:51
melwittokay, I'll take a look for that19:51
*** felipemonteiro_ has joined #openstack-nova19:51
mriedemif DEVSTACK_GATE_TEMPEST_* isn't specified, it looks like it should just be running smoke tests19:51
*** slaweq has quit IRC19:52
arvindn05nope...we have the old image ref though....we can load the image meta from that19:52
*** mingyu has joined #openstack-nova19:52
*** slaweq has joined #openstack-nova19:52
*** slaweq has quit IRC19:52
mriedemefried: arvindn05: you should, it's in the request spec19:52
efriedokay19:52
*** slaweq has joined #openstack-nova19:52
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L4919:53
mriedemmelwitt: maybe this https://github.com/openstack/devstack-plugin-ceph/commit/430fff8313a364f951423768d9ee8fdba4e79a2719:53
mriedemnvm that's just manila19:53
arvindn05for rebuild at the api level a request spec is not created yet i think19:54
arvindn05compute.api.API#rebuild19:54
arvindn05i am looking at that method to add the validation...is it the right place?19:54
mriedemthe request spec is from when the instance was created19:54
*** felipemonteiro__ has quit IRC19:55
mriedemalso, instance.image_meta is the current instance image meta for the instance19:55
mriedemso you don't even need the request spec19:56
arvindn05great19:56
arvindn05i would just need to load the new image meta then to compare each other19:57
*** lpetrut has quit IRC19:57
*** rmart04 has quit IRC19:57
mriedemyou have the new image here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L301319:58
*** slaweq has quit IRC19:59
arvindn05btw is there an instance.image_meta? i dont see it under objects.instance.Instance20:00
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/instance.py#L23820:02
arvindn05ahh..its not a field...but a property got it20:03
-openstackstatus- NOTICE: The Gerrit service at review.openstack.org will be offline over the next 1-2 hours for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html20:05
*** ChanServ changes topic to "The Gerrit service at review.openstack.org will be offline over the next 1-2 hours for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html"20:05
*** mingyu has quit IRC20:06
melwittmriedem: indeed, here's a job pass on stable/queens from today http://logs.openstack.org/68/565668/1/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/b6047e4/job-output.txt.gz#_2018-05-02_09_46_32_68058220:07
mriedemhmm, tempest and devstack-plugin-ceph are branchless,20:08
mriedemso whatever is broken must be in master only for nova or cinder20:08
melwittyeah, exactly. odd. going to see if I can find what's different20:08
*** felipemonteiro_ has quit IRC20:09
*** felipemonteiro_ has joined #openstack-nova20:10
mriedemmelwitt: my money is on that schema change in the cinder api which is queens only, merged in march20:10
melwittyou mean rocky only?20:10
mriedembefore that, the api would just pass attachment_id=None down to the volume manager which handled it https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L129620:10
mriedemyeah, i'll never adapt to rocky20:10
melwittQueensMan20:10
melwittokay, I think I missed where you pointed out the schema change. *scrolls back*20:11
melwittah yep, so there used to be no schema validation I guess? agreed that has to be the reason for the failure now20:13
mriedemmelwitt: https://bugs.launchpad.net/cinder/+bug/176865020:15
openstackLaunchpad bug 1768650 in Cinder "POST /volumes/{volume_id}/action os-detach incorrectly requires attachment_id is not None" [Undecided,New]20:15
mriedemi'll push a patch to cinder20:15
melwittsounds great20:16
*** damien_r has quit IRC20:17
*** slaweq has joined #openstack-nova20:26
*** spsurya has joined #openstack-nova20:27
*** openstackgerrit has quit IRC20:27
*** yamamoto has joined #openstack-nova20:29
*** tssurya has quit IRC20:32
*** tssurya has joined #openstack-nova20:33
*** pcaruana has quit IRC20:34
*** moshele has joined #openstack-nova20:34
*** damien_r has joined #openstack-nova20:34
*** yamamoto has quit IRC20:34
mriedemyeehaw http://paste.openstack.org/show/720250/20:41
melwittold school, email it20:42
mriedemheh, i thought about it20:42
*** tssurya has quit IRC20:43
*** damien_r has quit IRC20:46
*** jmlowe has quit IRC20:53
*** dougshelley66 has quit IRC20:55
*** vladikr_ has joined #openstack-nova20:59
*** awaugama has quit IRC21:00
*** vladikr has quit IRC21:01
*** moshele has quit IRC21:02
*** felipemonteiro__ has joined #openstack-nova21:06
*** felipemonteiro_ has quit IRC21:09
*** wolverineav has quit IRC21:10
*** wolverineav has joined #openstack-nova21:11
*** moshele has joined #openstack-nova21:14
*** pchavva has quit IRC21:14
*** wolverineav has quit IRC21:15
*** linkmark has joined #openstack-nova21:16
*** dougshelley66 has joined #openstack-nova21:23
*** r-daneel has quit IRC21:25
cfriesenhas anyone ever looked at supporting "-cpu host,migratable=no,+invtsc" in order to get the "nonstop_tsc" flag in the guest?  The tricky bit seems to be that nova might want to block attempts to migrate or snapshot the instance if it's enabled since it's going to fail down in qemu.21:29
*** hamzy has quit IRC21:29
*** yamamoto has joined #openstack-nova21:31
*** jmlowe has joined #openstack-nova21:31
*** moshele has quit IRC21:32
*** yamamoto has quit IRC21:37
*** dpawlik has joined #openstack-nova21:42
*** jmlowe has quit IRC21:45
*** dpawlik has quit IRC21:47
*** tssurya has joined #openstack-nova21:49
*** sdeath has joined #openstack-nova21:51
*** sdeath has joined #openstack-nova21:51
*** tssurya has quit IRC21:53
*** jmlowe has joined #openstack-nova21:57
*** pchavva has joined #openstack-nova22:01
*** felipemonteiro_ has joined #openstack-nova22:01
*** felipemonteiro__ has quit IRC22:01
*** esberglu has quit IRC22:06
dansmithmelwitt: HEY. This country was built with patch-on-ML!22:07
melwitt;D22:08
*** ChanServ changes topic to "Current runways: xenapi-image-handler-option-improvement / convert-consoles-to-objects / add-zvm-driver-rocky -- This channel is for Nova development. For support of Nova deployments, please use #openstack."22:10
-openstackstatus- NOTICE: Gerrit maintenance has concluded successfully22:10
lbragstadmelwitt: o/ johnthetubaguy was telling me that you are a quota expert22:12
*** Guest27658 has quit IRC22:14
*** mlavalle has quit IRC22:14
melwittlbragstad: o/ an accidental one, maybe22:14
*** slaweq has quit IRC22:15
lbragstad:) i was working with john on documenting CERN's usecase for hierarchical quotas/limit with the unified limit approach22:15
lbragstadi think i got it all out on paper now, https://review.openstack.org/#/c/565412/22:15
*** slaweq has joined #openstack-nova22:16
lbragstadbut figured you'd be pretty good at poking holes in what we have so far22:16
lbragstad(there are a ton of diagrams, but the rendered version isn't bad- http://logs.openstack.org/12/565412/3/check/build-openstack-sphinx-docs/22ea042/html/specs/keystone/rocky/strict-two-level-enforcement-model.html )22:16
melwitta-ha, very cool. I will definitely take a look22:17
* lbragstad just realized the code formatting failed22:17
lbragstadthanks melwitt22:17
melwittoh, heh, so failed == excluded from the output entirely. that's helpful of it :P22:18
melwittlbragstad: np, thanks for linking me22:19
lbragstadno problem - latest patch set should render the python example for service to incorporate the limit usage22:20
melwittexcellent22:20
*** openstackgerrit has joined #openstack-nova22:22
openstackgerritEric Fried proposed openstack/nova master: Get anchors for sharing providers  https://review.openstack.org/56527922:22
openstackgerritEric Fried proposed openstack/nova master: placement: Object changes for granular  https://review.openstack.org/56435122:22
openstackgerritEric Fried proposed openstack/nova master: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775722:22
*** sdeath has quit IRC22:23
openstackgerritkarim proposed openstack/nova master: Pushing image traits to ironic node  https://review.openstack.org/56562022:25
*** edmondsw has quit IRC22:29
*** edmondsw has joined #openstack-nova22:30
*** yamamoto has joined #openstack-nova22:32
*** edmondsw has quit IRC22:35
*** edmondsw has joined #openstack-nova22:35
*** rcernin has joined #openstack-nova22:36
*** yamamoto has quit IRC22:38
*** edmondsw has quit IRC22:39
efriedmriedem: Good job distancing yourself from the image traits rebuild issue.22:51
efriedThat lasted, what, four hours?22:52
mriedemalmost 922:52
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add nova-manage placement heal_allocations CLI  https://review.openstack.org/56588622:55
mriedemmgagne: now with functional tests ^22:55
mgagnemriedem: cool stuff! are there multiple cells in the test?22:56
mriedemyes, except that doesn't currently work b/c there is a bug in our fixtures, i need to test it with https://review.openstack.org/#/c/524264/ or https://review.openstack.org/#/c/558160/ underneath22:57
mriedembut, in-laws are here and i'm going to get yelled at soon22:57
*** mriedem is now known as mriedem_inlaws22:58
mgagnemriedem: there is no rush, have a good one ;)22:58
*** spsurya has quit IRC23:04
*** redondo-mk_ has joined #openstack-nova23:09
*** andrewbogott_ has joined #openstack-nova23:09
*** mnaser_ has joined #openstack-nova23:09
*** andreaf has quit IRC23:09
openstackgerritHongbin Lu proposed openstack/nova master: Use revision_number on adding/removing security group  https://review.openstack.org/53551023:11
*** Anticime1 has joined #openstack-nova23:12
*** hongbin has quit IRC23:12
*** jlvillal_ has joined #openstack-nova23:15
*** afazekas_ has joined #openstack-nova23:15
*** MrWatson has joined #openstack-nova23:15
*** _d34dh0r53_ has joined #openstack-nova23:15
melwittguh, all that hacking on CellDatabases that I was trying to fix with https://review.openstack.org/508432 makes me sad23:15
*** rnoriega_ has joined #openstack-nova23:16
*** lbragstad[m] has quit IRC23:16
*** rmk has quit IRC23:16
*** redondo-mk has quit IRC23:16
*** andrewbogott has quit IRC23:16
*** mnaser has quit IRC23:16
*** NostawRm has quit IRC23:16
*** rnoriega has quit IRC23:16
*** afazekas has quit IRC23:16
*** jlvillal has quit IRC23:16
*** Anticimex has quit IRC23:16
*** d34dh0r53 has quit IRC23:16
*** andrewbogott_ is now known as andrewbogott23:16
*** redondo-mk_ is now known as redondo-mk23:16
*** mnaser_ is now known as mnaser23:16
*** rmk has joined #openstack-nova23:17
*** rmk has quit IRC23:17
*** rmk has joined #openstack-nova23:17
*** jlvillal_ is now known as jlvillal23:19
*** jlvillal is now known as Guest1001423:19
arvindn05melwitt: thanks for the reply on the rebuild thread....wanted to get your thoughts on whether the approach is easy to maintain going forward23:21
arvindn05melwitt: my main concern is if we decide to support forbidden/granular traits etc for images at some point, this part of the logic will need to be updated23:21
melwittwell, rejecting a valid request doesn't seem correct and would likely require later maintenance too23:22
arvindn05aand maintained going forward...23:22
melwittmeaning, the placement queries would have to be updated?23:22
*** lbragstad[m] has joined #openstack-nova23:23
arvindn05not just that....the current approach is to get allocations for current instance and then match them in the conductor23:24
*** andreaf has joined #openstack-nova23:25
arvindn05the matching happens in the conductor for required traits for now...but if we need to handle granular/forbidden traits etc this matching logic will need to be updated23:25
melwittcan you point me to the code you're referring to?23:27
arvindn05my point is that since required traits are qualitative requirements, if they change its better to ask the scheduler rather than try to duplicate logic in placement and in conductor23:27
arvindn05there is not code yet....but eric summarized in this post http://lists.openstack.org/pipermail/openstack-dev/2018-April/129740.html23:27
melwittokay. well, I'm just saying verifying the traits in placement seems like the only correct thing to do23:28
arvindn05ideally yes, but a rebuild request never gets to placement api with any of the options described in the thread i think23:30
arvindn05is there an different alternative where verifying the traits can happen in placement code in case of rebuild?23:31
*** dave-mcc_ has quit IRC23:32
melwittwhat? some of the options involve calling placement23:32
*** yamamoto has joined #openstack-nova23:34
arvindn05sorry if its unclear...i meant if there is way to utilize  the matching logic of placement instead of trying to duplicate that in the conductor/schedulers23:35
*** dave-mccowan has joined #openstack-nova23:36
melwittif there's a way to ask placement "do these providers have these traits?" then that's what we need right? we need to ask if the providers hosting our current allocations have the traits requested in the image23:39
*** yamamoto has quit IRC23:40
melwittif we could ask it that way, placement would do the matching. but I don't have deep knowledge the placement APIs23:40
melwittthat is, I don't know if there's an available API like that23:41
arvindn05As i understand it its not just "do these providers have these traits?"...its also "do we have allocations from these providers for those traits?"23:41
arvindn05since we cannot do allocations during rebuild...we need to make sure our existing allocations satisfy all the trait requirements23:42
melwittit is, and that's what I tried to say. we have to 1) know our allocations 2) know what providers are hosting our allocations 3) know what traits the providers in 2) have23:42
*** dpawlik has joined #openstack-nova23:43
melwittso I guess it would be 1) query for own allocations by consumer == our instance 2) use the providers returned by that to ask 2) do these providers have these traits. again, I'm making up the second query, I don't know if one like that exists23:44
melwittmaybe I made up the first one too, but you get the idea23:44
arvindn05yea...that was what efried had...23:45
*** Swami has quit IRC23:46
*** vladikr__ has joined #openstack-nova23:46
*** dpawlik has quit IRC23:47
arvindn05the only 2 cons for this approach23:47
arvindn051.the rebuild may or may not succeed, depending on how well the original allocations match up with the new requirements.23:47
arvindn052. we need to need to account for handling preferred traits or granular resource traits if we decide to implement them for images at some point...23:47
arvindn05see http://lists.openstack.org/pipermail/openstack-dev/2018-May/130087.html23:47
arvindn05to see why 1 may occur....23:48
*** vladikr_ has quit IRC23:48
melwittare traits the same as properties? do they replace properties or?23:51
melwitt*image properties23:51
arvindn05they are an addition to image properties...23:53
arvindn05maybe long term they can start to replace some of the image properties....23:53
melwittokay. was just thinking about whether 1. would be a regression on how it behaves today. you can rebuild with a new image with new image properties if they pass scheduler filtering23:53
melwittif image property == image trait then if you reject any rebuild with new traits, then that's a step backward from what's possible today23:54
arvindn05nope traits are independent of image properties...they use the same key:value and are expressed as such in the image properties...but not the same23:56
*** pchavva has quit IRC23:57
*** vladikr_ has joined #openstack-nova23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!