| *** dpawlik has joined #openstack-nova | 00:06 | |
| *** dpawlik has quit IRC | 00:10 | |
| *** dpawlik has joined #openstack-nova | 00:11 | |
| *** dpawlik has quit IRC | 00:21 | |
| *** salv-orlando has joined #openstack-nova | 00:23 | |
| *** dpawlik has joined #openstack-nova | 00:26 | |
| *** salv-orlando has quit IRC | 00:27 | |
| *** edmondsw has joined #openstack-nova | 00:28 | |
| *** edmondsw has quit IRC | 00:33 | |
| *** vic-wu has quit IRC | 00:50 | |
| *** dpawlik has quit IRC | 00:50 | |
| *** dpawlik has joined #openstack-nova | 00:51 | |
| *** yamamoto has joined #openstack-nova | 00:59 | |
| *** yamamoto has quit IRC | 01:04 | |
| *** dtantsur|afk has quit IRC | 01:08 | |
| *** dtantsur has joined #openstack-nova | 01:08 | |
| *** dpawlik has quit IRC | 01:10 | |
| *** dpawlik has joined #openstack-nova | 01:11 | |
| *** dpawlik has quit IRC | 01:15 | |
| *** liverpooler has joined #openstack-nova | 01:16 | |
| *** dpawlik has joined #openstack-nova | 01:21 | |
| *** salv-orlando has joined #openstack-nova | 01:23 | |
| *** dpawlik has quit IRC | 01:25 | |
| *** yamahata has joined #openstack-nova | 01:26 | |
| *** dpawlik has joined #openstack-nova | 01:26 | |
| *** salv-orlando has quit IRC | 01:28 | |
| *** krtaylor has quit IRC | 01:32 | |
| *** hongbin has joined #openstack-nova | 01:41 | |
| *** dpawlik has quit IRC | 01:50 | |
| *** dpawlik has joined #openstack-nova | 01:56 | |
| *** dpawlik has quit IRC | 02:00 | |
| *** yamamoto has joined #openstack-nova | 02:00 | |
| *** dpawlik has joined #openstack-nova | 02:01 | |
| *** yamamoto has quit IRC | 02:05 | |
| *** liverpooler has quit IRC | 02:05 | |
| *** dpawlik has quit IRC | 02:10 | |
| *** dpawlik has joined #openstack-nova | 02:11 | |
| *** edmondsw has joined #openstack-nova | 02:16 | |
| *** edmondsw has quit IRC | 02:21 | |
| *** dougshelley66 has quit IRC | 02:23 | |
| *** salv-orlando has joined #openstack-nova | 02:24 | |
| *** dpawlik has quit IRC | 02:25 | |
| *** dpawlik has joined #openstack-nova | 02:26 | |
| *** hongbin_ has joined #openstack-nova | 02:28 | |
| *** salv-orlando has quit IRC | 02:28 | |
| *** dpawlik has quit IRC | 02:30 | |
| *** hongbin has quit IRC | 02:31 | |
| *** dpawlik has joined #openstack-nova | 02:31 | |
| *** spsurya has joined #openstack-nova | 02:38 | |
| *** dpawlik has quit IRC | 02:40 | |
| *** dpawlik has joined #openstack-nova | 02:41 | |
| *** vivsoni__ has quit IRC | 02:47 | |
| *** namnh has joined #openstack-nova | 02:55 | |
| *** armaan has joined #openstack-nova | 03:00 | |
| *** dpawlik has quit IRC | 03:00 | |
| *** dpawlik has joined #openstack-nova | 03:01 | |
| *** yamamoto has joined #openstack-nova | 03:01 | |
| *** namnh has quit IRC | 03:02 | |
| *** yamamoto has quit IRC | 03:06 | |
| *** slaweq has joined #openstack-nova | 03:08 | |
| *** slaweq has quit IRC | 03:12 | |
| *** vivsoni has joined #openstack-nova | 03:15 | |
| *** salv-orlando has joined #openstack-nova | 03:25 | |
| *** sree has joined #openstack-nova | 03:26 | |
| *** dpawlik has quit IRC | 03:30 | |
| *** salv-orlando has quit IRC | 03:30 | |
| *** dpawlik has joined #openstack-nova | 03:31 | |
| *** dpawlik has quit IRC | 03:41 | |
| *** dpawlik has joined #openstack-nova | 03:41 | |
| *** udesale has joined #openstack-nova | 03:41 | |
| *** vivsoni has quit IRC | 03:46 | |
| *** dpawlik has quit IRC | 03:50 | |
| *** dikonoor has joined #openstack-nova | 03:51 | |
| *** dpawlik has joined #openstack-nova | 03:56 | |
| *** dpawlik has quit IRC | 04:00 | |
| *** dpawlik has joined #openstack-nova | 04:01 | |
| *** yamamoto has joined #openstack-nova | 04:02 | |
| *** dpawlik has quit IRC | 04:05 | |
| *** armaan has quit IRC | 04:05 | |
| *** dpawlik has joined #openstack-nova | 04:06 | |
| *** vivsoni has joined #openstack-nova | 04:07 | |
| *** yamamoto has quit IRC | 04:08 | |
| *** yamahata has quit IRC | 04:18 | |
| *** hongbin_ has quit IRC | 04:22 | |
| *** sridharg has joined #openstack-nova | 04:23 | |
| *** ratailor has joined #openstack-nova | 04:23 | |
| *** dpawlik has quit IRC | 04:25 | |
| *** salv-orlando has joined #openstack-nova | 04:26 | |
| *** dpawlik has joined #openstack-nova | 04:26 | |
| *** FoXMaN has quit IRC | 04:27 | |
| *** pooja_jadhav has joined #openstack-nova | 04:30 | |
| *** salv-orlando has quit IRC | 04:30 | |
| *** FoXMaN has joined #openstack-nova | 04:33 | |
| *** dpawlik has quit IRC | 04:35 | |
| *** dpawlik has joined #openstack-nova | 04:36 | |
| *** namnh has joined #openstack-nova | 04:36 | |
| *** namnh has quit IRC | 04:36 | |
| *** namnh has joined #openstack-nova | 04:37 | |
| *** links has joined #openstack-nova | 04:39 | |
| *** dpawlik has quit IRC | 04:40 | |
| *** dpawlik has joined #openstack-nova | 04:41 | |
| *** namnh has quit IRC | 04:41 | |
| *** dpawlik has quit IRC | 04:45 | |
| *** dpawlik has joined #openstack-nova | 04:46 | |
| *** dpawlik has quit IRC | 04:50 | |
| *** dpawlik has joined #openstack-nova | 04:51 | |
| *** namnh has joined #openstack-nova | 04:52 | |
| *** namnh has quit IRC | 04:56 | |
| *** dpawlik has quit IRC | 05:00 | |
| *** dpawlik has joined #openstack-nova | 05:01 | |
| *** Eran_Kuris has joined #openstack-nova | 05:04 | |
| *** yamamoto has joined #openstack-nova | 05:04 | |
| *** yamamoto has quit IRC | 05:08 | |
| *** cfriesen has joined #openstack-nova | 05:09 | |
| *** _pewp_ has quit IRC | 05:10 | |
| *** dpawlik has quit IRC | 05:10 | |
| *** _pewp_ has joined #openstack-nova | 05:11 | |
| *** jaosorior has joined #openstack-nova | 05:12 | |
| *** Eran_Kuris has quit IRC | 05:13 | |
| *** dpawlik has joined #openstack-nova | 05:16 | |
| *** Eran_Kuris has joined #openstack-nova | 05:17 | |
| *** dpawlik has quit IRC | 05:20 | |
| *** dpawlik has joined #openstack-nova | 05:21 | |
| *** dpawlik has quit IRC | 05:25 | |
| *** dpawlik has joined #openstack-nova | 05:26 | |
| *** salv-orlando has joined #openstack-nova | 05:26 | |
| *** cfriesen has quit IRC | 05:30 | |
| *** salv-orlando has quit IRC | 05:31 | |
| *** namnh has joined #openstack-nova | 05:33 | |
| *** belmoreira has joined #openstack-nova | 05:36 | |
| *** namnh has quit IRC | 05:38 | |
| *** masber has joined #openstack-nova | 05:41 | |
| *** dpawlik has quit IRC | 05:45 | |
| *** janki has joined #openstack-nova | 05:51 | |
| *** evin has quit IRC | 05:51 | |
| *** masuberu has joined #openstack-nova | 05:51 | |
| *** edmondsw has joined #openstack-nova | 05:53 | |
| *** masber has quit IRC | 05:55 | |
| *** cfriesen has joined #openstack-nova | 05:56 | |
| *** edmondsw has quit IRC | 05:58 | |
| *** masuberu has quit IRC | 06:02 | |
| *** yamamoto has joined #openstack-nova | 06:05 | |
| *** moshele has joined #openstack-nova | 06:06 | |
| *** slaweq has joined #openstack-nova | 06:08 | |
| *** yamamoto has quit IRC | 06:11 | |
| *** dpawlik has joined #openstack-nova | 06:11 | |
| *** cfriesen has quit IRC | 06:14 | |
| *** cfriesen has joined #openstack-nova | 06:14 | |
| *** cfriesen_ has joined #openstack-nova | 06:15 | |
| *** cfriesen has quit IRC | 06:15 | |
| *** cfriesen__ has joined #openstack-nova | 06:15 | |
| *** cfriesen_ has quit IRC | 06:20 | |
| *** evin has joined #openstack-nova | 06:20 | |
| *** cfriesen has joined #openstack-nova | 06:22 | |
| *** cfriesen__ has quit IRC | 06:22 | |
| *** salv-orlando has joined #openstack-nova | 06:27 | |
| *** cfriesen has quit IRC | 06:30 | |
| *** salv-orlando has quit IRC | 06:32 | |
| *** namnh has joined #openstack-nova | 06:35 | |
| *** dpawlik has quit IRC | 06:36 | |
| *** namnh has quit IRC | 06:41 | |
| *** dpawlik has joined #openstack-nova | 06:41 | |
| *** dpawlik has quit IRC | 06:45 | |
| *** dpawlik has joined #openstack-nova | 06:46 | |
| *** do3meli has joined #openstack-nova | 06:48 | |
| *** dpawlik has quit IRC | 06:50 | |
| *** dpawlik has joined #openstack-nova | 06:51 | |
| *** namnh has joined #openstack-nova | 06:57 | |
| *** armaan has joined #openstack-nova | 06:59 | |
| *** bkopilov_ has joined #openstack-nova | 07:01 | |
| *** namnh has quit IRC | 07:02 | |
| *** yamamoto has joined #openstack-nova | 07:06 | |
| *** Guest1988 has joined #openstack-nova | 07:11 | |
| *** ccamacho has joined #openstack-nova | 07:11 | |
| *** yamamoto has quit IRC | 07:13 | |
| *** spsurya has quit IRC | 07:14 | |
| *** Guest1988 has quit IRC | 07:17 | |
| *** namnh has joined #openstack-nova | 07:17 | |
| *** namnh has quit IRC | 07:21 | |
| *** bkopilov_ has quit IRC | 07:26 | |
| *** salv-orlando has joined #openstack-nova | 07:28 | |
| *** ragiman_ has joined #openstack-nova | 07:32 | |
| *** salv-orlando has quit IRC | 07:33 | |
| *** amoralej|off is now known as amoralej | 07:38 | |
| *** hoonetorg has quit IRC | 07:41 | |
| *** sree has quit IRC | 07:41 | |
| *** edmondsw has joined #openstack-nova | 07:42 | |
| *** sree has joined #openstack-nova | 07:42 | |
| *** sree has quit IRC | 07:47 | |
| *** edmondsw has quit IRC | 07:47 | |
| *** lucas-afk is now known as lucasagomes | 07:54 | |
| *** hoonetorg has joined #openstack-nova | 07:55 | |
| *** moshele has quit IRC | 08:00 | |
| *** moshele has joined #openstack-nova | 08:02 | |
| *** namnh has joined #openstack-nova | 08:05 | |
| *** moshele has quit IRC | 08:06 | |
| *** yamamoto has joined #openstack-nova | 08:08 | |
| *** namnh has quit IRC | 08:09 | |
| *** sree has joined #openstack-nova | 08:12 | |
| *** yamamoto has quit IRC | 08:14 | |
| *** mdbooth has joined #openstack-nova | 08:14 | |
| *** sree has quit IRC | 08:17 | |
| *** mdnadeem has joined #openstack-nova | 08:24 | |
| *** sree has joined #openstack-nova | 08:27 | |
| *** derekh has joined #openstack-nova | 08:29 | |
| *** salv-orlando has joined #openstack-nova | 08:29 | |
| *** sree has quit IRC | 08:31 | |
| *** salv-orlando has quit IRC | 08:33 | |
| *** namnh has joined #openstack-nova | 08:35 | |
| *** jogo has quit IRC | 08:35 | |
| *** namnh has quit IRC | 08:39 | |
| *** nmathew has joined #openstack-nova | 08:41 | |
| *** sree has joined #openstack-nova | 08:48 | |
| *** salv-orlando has joined #openstack-nova | 08:51 | |
| *** sree has quit IRC | 08:52 | |
| *** moshele has joined #openstack-nova | 08:55 | |
| *** moshele has quit IRC | 08:56 | |
| *** namnh has joined #openstack-nova | 08:56 | |
| *** moshele has joined #openstack-nova | 08:56 | |
| *** sree has joined #openstack-nova | 08:58 | |
| *** jogo has joined #openstack-nova | 09:00 | |
| *** namnh has quit IRC | 09:01 | |
| *** spsurya has joined #openstack-nova | 09:01 | |
| *** sree has quit IRC | 09:02 | |
| *** ratailor has quit IRC | 09:07 | |
| *** sree has joined #openstack-nova | 09:08 | |
| *** yamamoto has joined #openstack-nova | 09:10 | |
| *** namnh has joined #openstack-nova | 09:10 | |
| *** ratailor has joined #openstack-nova | 09:12 | |
| *** tssurya has joined #openstack-nova | 09:12 | |
| *** sree has quit IRC | 09:13 | |
| *** namnh has quit IRC | 09:15 | |
| *** ratailor_ has joined #openstack-nova | 09:15 | |
| *** yamamoto has quit IRC | 09:16 | |
| *** ratailor has quit IRC | 09:17 | |
| *** sree has joined #openstack-nova | 09:19 | |
| *** namnh has joined #openstack-nova | 09:25 | |
| *** sree has quit IRC | 09:28 | |
| *** tianhui has quit IRC | 09:28 | |
| *** tianhui has joined #openstack-nova | 09:28 | |
| *** nmathew has quit IRC | 09:29 | |
| *** owalsh_ is now known as owalsh | 09:33 | |
| *** sree has joined #openstack-nova | 09:37 | |
| *** sdague has joined #openstack-nova | 09:39 | |
| *** sree has quit IRC | 09:41 | |
| *** sree has joined #openstack-nova | 09:48 | |
| *** sree has quit IRC | 09:52 | |
| *** sridharg has quit IRC | 09:55 | |
| *** sridharg has joined #openstack-nova | 09:57 | |
| *** tobasco is now known as tobasco-afk | 10:11 | |
| *** armaan has quit IRC | 10:12 | |
| *** yamamoto has joined #openstack-nova | 10:12 | |
| *** armaan has joined #openstack-nova | 10:12 | |
| *** armaan has quit IRC | 10:12 | |
| *** moshele has quit IRC | 10:13 | |
| openstackgerrit | fupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment https://review.openstack.org/565181 | 10:14 |
|---|---|---|
| *** salv-orlando has quit IRC | 10:17 | |
| *** salv-orlando has joined #openstack-nova | 10:17 | |
| *** yamamoto has quit IRC | 10:17 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Handle PortNotFoundClient exception when getting ports https://review.openstack.org/565183 | 10:20 |
| *** salv-orlando has quit IRC | 10:22 | |
| *** wolverineav has joined #openstack-nova | 10:27 | |
| *** nicolasbock has joined #openstack-nova | 10:30 | |
| kashyap | lyarwood: Et al, we also need this to be backported (all the way to Ocata) -- https://review.openstack.org/#/c/565043/ | 10:30 |
| kashyap | (The upstream change is not merged yet; but it's straightfoward) | 10:30 |
| *** mdbooth has quit IRC | 10:32 | |
| openstackgerrit | Merged openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | 10:36 |
| lyarwood | kashyap: kk, why are you using the bp/ topic for these bug fixes and a bug/ topic for the original change? | 10:36 |
| openstackgerrit | Merged openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | 10:36 |
| kashyap | lyarwood: Right, I'll rename it; so that it's all under the same topic | 10:36 |
| kashyap | lyarwood: Do you have a minute more? | 10:36 |
| kashyap | lyarwood: I think I messed up something (unrelated to branch naming) :-( | 10:37 |
| kashyap | See here: https://review.openstack.org/#/q/topic:bp/libvirt-cpu-model-extra-flags+(status:open+OR+status:merged) | 10:37 |
| lyarwood | kashyap: https://review.openstack.org/#/c/563926/ & https://review.openstack.org/#/c/565044/ are duplicates right? | 10:37 |
| lyarwood | kashyap: yeah | 10:37 |
| kashyap | lyarwood: Allow me to explain how I arrived there: | 10:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec https://review.openstack.org/541290 | 10:38 |
| kashyap | lyarwood: I made the casing patch, and on *top* of it, applied the "lift restrictions" patch. | 10:38 |
| kashyap | lyarwood: Could I have done anything cleaner? | 10:38 |
| kashyap | lyarwood: The first variant https://review.openstack.org/#/c/563926/ had 8 revisions. Now I will "lose" them (or I'll simply link to it from the other) | 10:39 |
| lyarwood | kashyap: AFAICT you changed the change-id causing gerrit to create a new review | 10:39 |
| lyarwood | kashyap: you can close out the new review and just rebase the case-insensitive change on top of the old one | 10:40 |
| kashyap | lyarwood: Right | 10:40 |
| kashyap | I'm doing to do that now | 10:40 |
| kashyap | Thanks! | 10:40 |
| *** namnh has quit IRC | 10:44 | |
| *** dougshelley66 has joined #openstack-nova | 10:52 | |
| kashyap | lyarwood: Pease remind me again, I think it's okay to include "Closes-Bug" tag on two Gerrit patches, right? | 10:52 |
| kashyap | (I often see "Related-Bug" on several patches, though | 10:52 |
| kashyap | ) | 10:52 |
| lyarwood | kashyap: I *think* that's okay yeah | 10:53 |
| lyarwood | kashyap: maybe Related-Bug on the first? | 10:53 |
| *** tbachman has quit IRC | 10:53 | |
| kashyap | lyarwood: You mean, add the Related-Bug on the casing patch? | 10:53 |
| kashyap | (Which is the "first" patch in this 2-patch series) | 10:54 |
| lyarwood | kashyap: yeah | 10:54 |
| *** ratailor__ has joined #openstack-nova | 10:54 | |
| kashyap | lyarwood: Okido; I'll do that. Gracias | 10:54 |
| *** ratailor__ has quit IRC | 10:54 | |
| *** ratailor has joined #openstack-nova | 10:55 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Make `cpu_model_extra_flags` case-insensitive for real https://review.openstack.org/565043 | 10:55 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926 | 10:55 |
| *** ratailor_ has quit IRC | 10:56 | |
| *** ratailor_ has joined #openstack-nova | 10:58 | |
| *** tobasco-afk is now known as tobasco | 10:58 | |
| *** ratailor has quit IRC | 11:00 | |
| kashyap | lyarwood: Done. Mind ACKing this, since you have context too: https://review.openstack.org/#/c/565043/ | 11:01 |
| *** mdbooth has joined #openstack-nova | 11:03 | |
| *** lucasagomes is now known as lucas-hungry | 11:04 | |
| *** namnh has joined #openstack-nova | 11:05 | |
| *** armaan has joined #openstack-nova | 11:09 | |
| *** namnh has quit IRC | 11:09 | |
| *** moshele has joined #openstack-nova | 11:10 | |
| *** Eran_Kuris has quit IRC | 11:10 | |
| *** mdbooth has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-nova | 11:14 | |
| *** aloga has quit IRC | 11:14 | |
| *** yamamoto has quit IRC | 11:19 | |
| *** namnh has joined #openstack-nova | 11:26 | |
| *** dave-mccowan has joined #openstack-nova | 11:27 | |
| *** namnh has quit IRC | 11:30 | |
| *** dave-mccowan has quit IRC | 11:31 | |
| *** dave-mcc_ has joined #openstack-nova | 11:31 | |
| *** mvk has quit IRC | 11:32 | |
| *** dougshelley66 has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-nova | 11:39 | |
| *** sridharg has quit IRC | 11:40 | |
| *** namnh has joined #openstack-nova | 11:42 | |
| *** ratailor__ has joined #openstack-nova | 11:43 | |
| *** ratailor_ has quit IRC | 11:46 | |
| *** artom has quit IRC | 11:51 | |
| *** amoralej is now known as amoralej|lunch | 11:55 | |
| *** lucas-hungry is now known as lucasagomes | 11:57 | |
| *** Eran_Kuris has joined #openstack-nova | 11:58 | |
| *** sridharg has joined #openstack-nova | 11:59 | |
| *** sdeath has quit IRC | 12:02 | |
| *** Eran_Kuris has quit IRC | 12:03 | |
| *** bhujay has joined #openstack-nova | 12:04 | |
| *** edmondsw has joined #openstack-nova | 12:07 | |
| *** dougshelley66 has joined #openstack-nova | 12:10 | |
| *** liverpooler has joined #openstack-nova | 12:16 | |
| *** liverpooler has quit IRC | 12:16 | |
| *** liverpooler has joined #openstack-nova | 12:16 | |
| *** mdbooth has joined #openstack-nova | 12:21 | |
| *** Eran_Kuris has joined #openstack-nova | 12:21 | |
| *** namnh has quit IRC | 12:22 | |
| *** namnh has joined #openstack-nova | 12:24 | |
| efried | ō/ | 12:24 |
| *** yamamoto has quit IRC | 12:25 | |
| *** yamamoto has joined #openstack-nova | 12:26 | |
| *** mvk has joined #openstack-nova | 12:28 | |
| *** namnh has quit IRC | 12:28 | |
| *** sdeath has joined #openstack-nova | 12:31 | |
| *** pchavva has joined #openstack-nova | 12:31 | |
| *** tbachman has joined #openstack-nova | 12:34 | |
| *** amoralej|lunch is now known as amoralej | 12:36 | |
| bauzas | efried: you can remove your hat | 12:38 |
| efried | bauzas: It's my crew cut | 12:38 |
| bauzas | well, I'm 37 and my hairs become to leave me, so should I do something like °o/ ? | 12:39 |
| *** jaosorior has quit IRC | 12:43 | |
| *** mchlumsky has joined #openstack-nova | 12:44 | |
| *** vladikr has joined #openstack-nova | 12:49 | |
| *** finucannot is now known as stephenfin | 12:54 | |
| zzzeek_ | jaypipes: mysql question. does SELECT * FROM (SELECT x, y FROM a) AS a_alias JOIN b ON a_alias.x=b.y FOR UPDATE , lock both "a", and "b" ? | 12:55 |
| jaypipes | zzzeek_: it will lock all the rows in a and b that join on x = y, yes | 12:58 |
| zzzeek_ | jaypipes: that's great news got a user claims it is not | 12:58 |
| jaypipes | zzzeek_: what version of MySQL? | 12:59 |
| zzzeek_ | jaypipes: hmm | 12:59 |
| *** gouthamr has quit IRC | 12:59 | |
| zzzeek_ | jaypipes: would have to ask | 12:59 |
| jaypipes | zzzeek_: not that that should matter... I think that is the behaviour for at least since 4.0 | 12:59 |
| zzzeek_ | jaypipes: OK he says "I noticed a different issue when using joinedload and with_for_update in Mysql with a REPEATABLE READ isolation level. In my case, it seems that the with_for_update only locked the joinedtable because the FOR UPDATE statement is only applied to the joinedtable - the root table is not locked because it is queried via the subselect. " but I'm going to ask him to further define how he knows this is the case | 13:00 |
| zzzeek_ | jaypipes: if i had to move the FOR UPDATE around in the query it would really ruin my day :) | 13:00 |
| jaypipes | zzzeek_: ask if both sides of the join condition are indexed. | 13:01 |
| zzzeek_ | jaypipes: ok | 13:01 |
| zzzeek_ | jaypipes: does it only lock indexed rows ? | 13:01 |
| jaypipes | "For index records the search encounters, locks the rows and any associated index entries, the same as if you issued an UPDATE statement for those rows. Other transactions are blocked from updating those rows" | 13:02 |
| jaypipes | zzzeek_: seems so, yes. | 13:02 |
| *** gouthamr has joined #openstack-nova | 13:02 | |
| jaypipes | zzzeek_: though that wording is a tad vague, would you agree? | 13:03 |
| zzzeek_ | jaypipes: yes, what is an "index record"? does that mean the WHERE clause has to refer to an indexed column ? | 13:03 |
| zzzeek_ | jaypipes: seems like it means, for any row that is part of an index. which is every row if you have a primary key | 13:03 |
| jaypipes | zzzeek_: sounds to me like it means that the columns referenced in the JOIN condition (ON clause or WHERE <join table references>) need to be indexed. | 13:04 |
| zzzeek_ | jaypipes: hmmmmm | 13:05 |
| jaypipes | zzzeek_: but it's vague. it almost sounds like it's just saying that reads of both data (clustered index) and index pages (secondary indexes) are locked | 13:05 |
| zzzeek_ | jaypipes: otherwise you think we are getting rows back where not all tables are locked? that seems so unintuitive b.c. you would think it locks everthing thats in the row | 13:05 |
| *** READ10 has joined #openstack-nova | 13:05 | |
| zzzeek_ | guess we'd have to test it. blah | 13:05 |
| jaypipes | :) | 13:06 |
| zzzeek_ | how you do even test locking on MySQL :) it has such wierd behavior | 13:06 |
| *** eharney has joined #openstack-nova | 13:06 | |
| kashyap | zzzeek_: I think jaypipes just tries it on production users ;-) | 13:06 |
| * kashyap ducks | 13:06 | |
| zzzeek_ | well, repeatable read. guess i can try a concurrent update against "a" selecvted alone, vs "a" selected in the subquery | 13:06 |
| kashyap | But more seriously, /me is glad with all these *SQL experts, self can't do beyond 101 stuff | 13:06 |
| zzzeek_ | can't beat a job that pays me to just sit around and know things | 13:07 |
| *** mchlumsky has quit IRC | 13:07 | |
| jaypipes | zzzeek_: for the record, postgresql's select for update docs are virtually identical. | 13:07 |
| zzzeek_ | jaypipes: yes, but w/ pg we dont get shenanigans like this | 13:07 |
| jaypipes | zzzeek_: how do you know? :) | 13:07 |
| zzzeek_ | jaypipes: its postgresql! it's a crystalline structure of timeless perfection! | 13:08 |
| jaypipes | hehe | 13:08 |
| zzzeek_ | when you find an ingenious feature of postgresql, and ask, "when was this developed?", the answer is: never. all PGs features exist outside of time-space | 13:08 |
| *** mchlumsky has joined #openstack-nova | 13:09 | |
| *** salv-orlando has joined #openstack-nova | 13:09 | |
| jaypipes | lol :) | 13:09 |
| zzzeek_ | like in "Interstellar" | 13:09 |
| jaypipes | it does actually seem like PG has a similar behaviour with regards to indexing. | 13:09 |
| zzzeek_ | jaypipes: meaning, you can't lock a row that doesnt refer to index columns? | 13:10 |
| *** salv-orlando has quit IRC | 13:10 | |
| *** salv-orlando has joined #openstack-nova | 13:10 | |
| jaypipes | zzzeek_: "FOR UPDATE and FOR SHARE cannot be used in contexts where returned rows cannot be clearly identified with individual table rows;" | 13:10 |
| jaypipes | zzzeek_: which makes sense, kinda. | 13:10 |
| jaypipes | zzzeek_: if you can't identify a particular record with a condition, then you shouldn't be able to lock it. | 13:10 |
| zzzeek_ | jaypipes: oh. that may be it then, is mysql making a virtual table out of the subquery? | 13:11 |
| jaypipes | zzzeek_: could be? really would need to chat with this guy and find out what data is in the two tables | 13:11 |
| jaypipes | zzzeek_: could be a weird edge case of some sort. | 13:11 |
| zzzeek_ | jaypipes: https://bugs.mysql.com/bug.php?id=34182 | 13:12 |
| zzzeek_ | jaypipes: oh this is falcon storage engine | 13:12 |
| jaypipes | oh ffs | 13:12 |
| zzzeek_ | jaypipes: that bug. let me ask user | 13:12 |
| jaypipes | zzzeek_: note that that bug is describing a different behaviour. that bug is describing when the FOR UPDATE clause appears within the subquery. | 13:15 |
| zzzeek_ | jaypipes: ah | 13:15 |
| jaypipes | zzzeek_: and it's also 10 years old :) and the (now irrelevant) falcon storage engine | 13:15 |
| zzzeek_ | jaypipes: yep | 13:15 |
| jaypipes | zzzeek_: what's the bug link for SA? | 13:16 |
| *** mriedem has joined #openstack-nova | 13:17 | |
| zzzeek_ | jaypipes: https://bitbucket.org/zzzeek/sqlalchemy/issues/4246/compound-query-select-apply-for-update-to | 13:17 |
| *** awaugama has joined #openstack-nova | 13:20 | |
| *** rmart04 has joined #openstack-nova | 13:20 | |
| *** links has quit IRC | 13:22 | |
| *** ratailor__ has quit IRC | 13:22 | |
| *** jmccarthy has joined #openstack-nova | 13:23 | |
| jaypipes | zzzeek_: I wholeheartedly disagree with the Diggsey user in the original 4100 bug. | 13:24 |
| zzzeek_ | jaypipes: :) so did I ! | 13:24 |
| zzzeek_ | jaypipes: this is my life. non DB folks just complaining all day | 13:25 |
| jaypipes | zzzeek_: heh. yeah, but you're used to it by now. | 13:26 |
| jmccarthy | Hi folks ! I believe I'm hitting this here .. but not at all sure where to go with it .. https://bugs.launchpad.net/nova/+bug/1592015 | 13:27 |
| openstack | Launchpad bug 1592015 in OpenStack Compute (nova) "libvirt: cleanup of a volume backed instance resize leaves behind the instance directory" [Medium,In progress] - Assigned to Feodor Tersin (ftersin) | 13:27 |
| jmccarthy | Be nice ;) | 13:28 |
| *** superdan is now known as dansmith | 13:29 | |
| *** evin has quit IRC | 13:29 | |
| jmccarthy | In my case, after cold migration, a disk.info is left behind in old instance dir which doesn't get cleaned up (after verify resize) | 13:29 |
| jaypipes | zzzeek_: aha! | 13:30 |
| jaypipes | zzzeek_: I think I might have found a reason why Julien's particular query is doing what it's doing. | 13:30 |
| zzzeek_ | jaypipes: oh yeah | 13:30 |
| *** armaan has quit IRC | 13:31 | |
| *** esberglu has joined #openstack-nova | 13:31 | |
| *** armaan has joined #openstack-nova | 13:31 | |
| *** belmorei_ has joined #openstack-nova | 13:31 | |
| *** sree has joined #openstack-nova | 13:31 | |
| *** belmoreira has quit IRC | 13:34 | |
| jaypipes | zzzeek_: added a comment on the bug above. | 13:35 |
| mriedem | jmccarthy: if you want to take over https://review.openstack.org/#/c/414710/ i could restore it and you could rebase it | 13:35 |
| mriedem | if it fixes the bug | 13:35 |
| zzzeek_ | jaypipes: see that's some mysql guru shit right there | 13:35 |
| *** jroll has quit IRC | 13:36 | |
| mriedem | jmccarthy: although it looks like a series https://review.openstack.org/#/q/status:abandoned+topic:disk_snapshots | 13:36 |
| jaypipes | zzzeek_: I believe postgresql will return an error when it sees an expression like that which it knows it cannot determine an effective join condition that can be applied in the read view protection. | 13:36 |
| mriedem | jmccarthy: comment 8 also says this was fixed with an alternative bug https://bugs.launchpad.net/nova/+bug/1666831 in ocata | 13:37 |
| openstack | Launchpad bug 1666831 in OpenStack Compute (nova) ocata "Nova recreates instance directory after migration/resize" [Low,Fix committed] - Assigned to Lee Yarwood (lyarwood) | 13:37 |
| mriedem | jmccarthy: which release are you on? | 13:37 |
| zzzeek_ | jaypipes: not sure about that. that's a standard SQLAlhcemy query | 13:37 |
| *** lbragstad has joined #openstack-nova | 13:37 | |
| jaypipes | zzzeek_: note that the way InnoDB works, the ORDER BY clause is required to generate the gap locks that would act as the read view protection for other transactions. | 13:38 |
| *** jroll has joined #openstack-nova | 13:38 | |
| zzzeek_ | jaypipes: ok....well if true this means we'd still need to change the query, but im doing some local testing and not sure if im replicating yet | 13:38 |
| jaypipes | zzzeek_: we should change channel, though :) mriedem will surely be getting antsy :) | 13:39 |
| zzzeek_ | jaypipes: sure. | 13:39 |
| *** armaan has quit IRC | 13:39 | |
| *** armaan has joined #openstack-nova | 13:39 | |
| *** armaan has joined #openstack-nova | 13:40 | |
| jmccarthy | mriedem: I'm using kolla images built off master | 13:41 |
| zzzeek_ | jaypipes: the test script I'm running so far is confirming what he is seeing | 13:41 |
| *** gouthamr has quit IRC | 13:42 | |
| mriedem | jmccarthy: then that sounds like a regression and would be a new bug where you'd have to provide your details, and probably refer to that other bug for context | 13:42 |
| jmccarthy | mriedem: Ok, I can look into raising a new bug, I'll check out that alternate - thanks ! | 13:43 |
| jaypipes | zzzeek_: moved to #sqlalchemy | 13:44 |
| jmccarthy | Ohh ok missed the # in comment 8 | 13:45 |
| *** gouthamr has joined #openstack-nova | 13:45 | |
| *** jmlowe_ has quit IRC | 13:45 | |
| *** r-daneel has joined #openstack-nova | 13:47 | |
| *** evin has joined #openstack-nova | 13:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Implement granular policy rules for placement https://review.openstack.org/524425 | 13:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup placement policy generator docs https://review.openstack.org/565225 | 13:51 |
| kashyap | mriedem: Morning; when you can, want to put this through? -- https://review.openstack.org/#/c/565043/ (libvirt: Make `cpu_model_extra_flags` case-insensitive for real) | 13:53 |
| jaypipes | mriedem: mornin. you ready for a proper review on ^^ or are you still WIP'ing? | 13:53 |
| kashyap | (It needs to be backported all the way back to Ocata) | 13:53 |
| edleafe | Scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
| *** armaan has quit IRC | 13:55 | |
| *** armaan has joined #openstack-nova | 13:56 | |
| *** burt has joined #openstack-nova | 13:56 | |
| mriedem | jaypipes: i need to split it up and add tests yet | 13:58 |
| *** tomtom001 has quit IRC | 13:58 | |
| *** tomtom001 has joined #openstack-nova | 13:59 | |
| *** ragiman_ has quit IRC | 14:03 | |
| jaypipes | mriedem: k. so hold off? | 14:04 |
| *** ttsiouts_ has joined #openstack-nova | 14:04 | |
| *** hongbin has joined #openstack-nova | 14:05 | |
| mriedem | jaypipes: yeah, unless you want to skim, it's mostly mechanical | 14:05 |
| *** felipemonteiro has joined #openstack-nova | 14:05 | |
| jaypipes | mriedem: ack | 14:06 |
| bauzas | efried: jaypipes: hola | 14:06 |
| *** aloga has joined #openstack-nova | 14:06 | |
| efried | bauzas: yeaux | 14:06 |
| bauzas | efried: jaypipes: looks like we have some transition problem for Pike https://bugs.launchpad.net/tripleo/+bug/1767076 | 14:06 |
| openstack | Launchpad bug 1767076 in tripleo "Creating pingtest_sack fails: Failed to schedule instances: NoValidHost_Remote: No valid host was found" [High,Triaged] - Assigned to Quique Llorente (quiquell) | 14:06 |
| *** sree has quit IRC | 14:06 | |
| bauzas | transitive* | 14:06 |
| bauzas | efried: jaypipes: see https://logs.rdoproject.org/openstack-periodic-24hr/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-pike-upload/7dadafb/overcloud-novacompute-0/var/log/nova/nova-compute.log.txt.gz#_2018-04-25_06_00_40_809 | 14:07 |
| *** felipemonteiro_ has joined #openstack-nova | 14:07 | |
| bauzas | efried: jaypipes: I wonder if that's related to https://review.openstack.org/#/c/524263/ | 14:07 |
| *** namnh has joined #openstack-nova | 14:09 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Handle PortNotFoundClient exception when getting ports https://review.openstack.org/565183 | 14:10 |
| *** felipemonteiro has quit IRC | 14:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | 14:11 |
| *** namnh has quit IRC | 14:13 | |
| *** moshele has quit IRC | 14:13 | |
| jaypipes | bauzas: looks like triple-o isn't upgrading placement first. | 14:15 |
| bauzas | how do you know that ? | 14:15 |
| bauzas | I mean, I understand you, I just want to know how to check that | 14:15 |
| *** cfriesen has joined #openstack-nova | 14:16 | |
| *** janki has quit IRC | 14:16 | |
| *** jchhatbar has joined #openstack-nova | 14:16 | |
| *** jchhatbar has quit IRC | 14:17 | |
| *** jchhatbar has joined #openstack-nova | 14:17 | |
| bauzas | jaypipes: mmm, when comparing pike and master, we make now the fact to not see correct aggregates and RPs a blocking stuff https://github.com/openstack/nova/commit/b214dfc41928d9e05199263301f8e5b23555c170 | 14:18 |
| bauzas | owalsh: ^ | 14:18 |
| bauzas | shit, I need to go find my daughters | 14:19 |
| *** ragiman_ has joined #openstack-nova | 14:19 | |
| owalsh | bauzas, jaypipes: don't believe that's an upgrade job | 14:20 |
| *** sridharg has quit IRC | 14:20 | |
| *** jmlowe has joined #openstack-nova | 14:21 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | 14:21 |
| jaypipes | bauzas: having trouble understanding you... I don't see what that patch has to do with a KeyError | 14:21 |
| *** eharney has quit IRC | 14:22 | |
| bauzas | jaypipes: nevermind https://review.openstack.org/#/c/524263/ | 14:22 |
| jaypipes | owalsh, bauzas: the reportclient is bombing because it has been upgraded to expect the generation field in the return from placement API. but placement hasn't been upgraded first and so isn't returning the generation field. | 14:23 |
| bauzas | anyway, /me needs to leave | 14:23 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION https://review.openstack.org/563984 | 14:23 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_NUMA_VERSION_PPC https://review.openstack.org/564010 | 14:23 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_NUMA_VERSIONS https://review.openstack.org/564011 | 14:23 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_CPU_POLICY_VERSIONS https://review.openstack.org/564012 | 14:23 |
| *** dougshelley66 has quit IRC | 14:28 | |
| *** rajinir has joined #openstack-nova | 14:28 | |
| *** mlavalle has joined #openstack-nova | 14:28 | |
| kashyap | stephenfin: Since you asked, ^^^ if you want to queue them up. Two patches already have +2 from MattR; and just addrressed two minor things in the other two patches. | 14:29 |
| *** armaan has quit IRC | 14:30 | |
| *** armaan has joined #openstack-nova | 14:31 | |
| *** dougshelley66 has joined #openstack-nova | 14:31 | |
| *** hemna_ has joined #openstack-nova | 14:31 | |
| stephenfin | kashyap: Can do | 14:32 |
| kashyap | Gracias. I've got 3 more in that same vein, will post them soon. | 14:33 |
| owalsh | jaypipes: not sure how that could be, there is no upgrade... | 14:33 |
| *** Spazmotic has joined #openstack-nova | 14:34 | |
| *** ragiman_ has quit IRC | 14:35 | |
| *** dpawlik has quit IRC | 14:35 | |
| owalsh | jaypipes: also wouldn't that result in a KeyError? | 14:35 |
| *** armaan has quit IRC | 14:35 | |
| jaypipes | owalsh: sec, on standup | 14:36 |
| jaypipes | owalsh: this is occurring: | 14:38 |
| jaypipes | 2018-04-25 05:40:18.617 21167 WARNING nova.scheduler.client.report [req-6b36b888-fa33-4301-aedf-3389020fe8d8 - - - - -] Discovering suitable URL for placement API failed.: DiscoveryFailure: Could not determine a suitable URL for the plugin | 14:38 |
| jaypipes | owalsh: that is the root of the issue, I believe. | 14:39 |
| jaypipes | owalsh: something up with the service catalog discovery of placement maybe? | 14:39 |
| owalsh | jaypipes: not up yet... | 14:39 |
| owalsh | jaypipes: returning 404s later https://logs.rdoproject.org/openstack-periodic-24hr/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-pike-upload/7dadafb/overcloud-controller-0/var/log/nova/nova-placement-api.log.txt.gz#_2018-04-25_05_48_32_956 | 14:39 |
| * jaypipes wonders if this is just @safe_connect hiding problems. | 14:40 | |
| *** Spazmotic has quit IRC | 14:41 | |
| jaypipes | owalsh: just realized something... | 14:43 |
| jaypipes | owalsh: there is no self._resource_providers object any more. That has been replaced by self._provider_tree. | 14:43 |
| jaypipes | owalsh: lemme look further into this. This is Pike, yeah? | 14:44 |
| owalsh | jaypipes: yea, pike | 14:44 |
| owalsh | jaypipes: thanks! | 14:44 |
| jaypipes | owalsh: k, thx. gimme a few to track down. | 14:44 |
| *** jchhatbar has quit IRC | 14:45 | |
| jaypipes | owalsh: no, that's not it... we switched to provider_tree in Queens. must be something else. :( | 14:45 |
| *** ragiman_ has joined #openstack-nova | 14:47 | |
| bauzas | jaypipes: owalsh: sorry, I'm back | 14:50 |
| *** namnh has joined #openstack-nova | 14:50 | |
| bauzas | owalsh: jaypipes: I wonder if the root cause is https://logs.rdoproject.org/openstack-periodic-24hr/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-pike-upload/7dadafb/overcloud-novacompute-0/var/log/nova/nova-compute.log.txt.gz#_2018-04-25_05_40_03_801 | 14:53 |
| bauzas | if so, we're not registering the root RP | 14:53 |
| jaypipes | bauzas: https://github.com/openstack/nova/blob/stable/pike/nova/scheduler/client/report.py#L514-L523 | 14:54 |
| jaypipes | bauzas: for some reason, we're either not creating or not getting the rp record for the compute node. | 14:55 |
| *** namnh has quit IRC | 14:55 | |
| jaypipes | bauzas: maybe a check for whether rp is None is needed before line 518. | 14:55 |
| jaypipes | bauzas: and raise some exception. | 14:55 |
| openstackgerrit | Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371 | 14:55 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Fix misleading debug msg "Instance is running" https://review.openstack.org/565234 | 14:57 |
| bauzas | jaypipes: tbh, I think that if https://github.com/openstack/nova/blob/stable/pike/nova/scheduler/client/report.py#L516 is not working, it's an operator issue | 14:58 |
| *** zz9pzza has quit IRC | 14:58 | |
| bauzas | owalsh: ^ | 14:58 |
| owalsh | bauzas: ack, yea... don't see any POST requests getting through to placement | 14:59 |
| bauzas | owalsh: see also https://logs.rdoproject.org/openstack-periodic-24hr/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-pike-upload/7dadafb/overcloud-novacompute-0/var/log/nova/nova-compute.log.txt.gz#_2018-04-25_05_40_03_854 | 15:00 |
| bauzas | owalsh: looks like it's a keystone issue | 15:00 |
| *** beekneemech is now known as bnemec | 15:00 | |
| jaypipes | bauzas: @safe_connect is hiding the connection issue. | 15:00 |
| bauzas | owalsh: jaypipes: so, IMHO, when we try to register the root RP (by creating it using the Placement API), we have a keystone problem | 15:01 |
| bauzas | at least a connection problem | 15:01 |
| bauzas | that's why the root RP is None | 15:01 |
| jaypipes | bauzas: right. and @safe_connect's "only do something if X number of warnings happened" is hiding issues with connectivity. that's what I think at l;east. | 15:02 |
| bauzas | yup | 15:02 |
| bauzas | jaypipes: anyway, thanks for the help | 15:02 |
| bauzas | owalsh: like I said, I think it's not a nova problem | 15:02 |
| jaypipes | not sure I helped much :) | 15:02 |
| bauzas | owalsh: rather a configuration issue because of the HTTP503 | 15:03 |
| bauzas | jaypipes: you did, dude ,) | 15:03 |
| bauzas | jaypipes: I'm a bit said to no longer be a Placement expert | 15:03 |
| bauzas | jaypipes: so having you telling me if I'm right is definitely helping me :) | 15:04 |
| *** namnh has joined #openstack-nova | 15:04 | |
| *** tbachman has quit IRC | 15:04 | |
| owalsh | jaypipes, bauzas: thanks guys, helps me a lot if we can rule out placement as the root cause :-) | 15:05 |
| bauzas | owalsh: I think Placement is a canary | 15:05 |
| *** artom has joined #openstack-nova | 15:05 | |
| bauzas | like we had NoValidHost for something else | 15:06 |
| owalsh | bauzas: yea, was just about to say... NoValidHost is the canary | 15:06 |
| bauzas | fortunately, we now have a separate exception | 15:06 |
| bauzas | efried: jaypipes: stephenfin: oh btw. thanks for having reviewed my vGPU series. FWIW, https://twitter.com/sylvainbauza/status/990884997010685953 :) | 15:07 |
| *** ttsiouts_ has quit IRC | 15:08 | |
| melwitt | mriedem: I noticed the novaclient change on "Add host/hostId to instance action events API" https://review.openstack.org/#/c/564667 has merged. is everything done for that bp now and time to remove from runway? | 15:10 |
| mriedem | melwitt: yeah, i marked the bp complete on friday i think, but forgot to remove it from runways | 15:11 |
| *** zz9pzza has joined #openstack-nova | 15:11 | |
| melwitt | mriedem: k, cool | 15:11 |
| *** moshele has joined #openstack-nova | 15:13 | |
| *** tbachman has joined #openstack-nova | 15:13 | |
| *** rmart04 has quit IRC | 15:15 | |
| *** zz9pzza has quit IRC | 15:15 | |
| *** xinliang has quit IRC | 15:17 | |
| *** xinliang has joined #openstack-nova | 15:17 | |
| stephenfin | bauzas: :) | 15:19 |
| *** felipemonteiro_ has quit IRC | 15:19 | |
| *** dpawlik has joined #openstack-nova | 15:20 | |
| *** janki has joined #openstack-nova | 15:22 | |
| *** armaan has joined #openstack-nova | 15:23 | |
| dansmith | jaypipes: why are we not migrating the records for allocations that were created before user/project were required? | 15:23 |
| *** armaan has quit IRC | 15:24 | |
| melwitt | dansmith: those should be auto-healed right, by compute updates | 15:24 |
| *** armaan has joined #openstack-nova | 15:24 | |
| dansmith | melwitt: I don't think so | 15:24 |
| *** dpawlik has quit IRC | 15:24 | |
| melwitt | dansmith: that was the thinking as to why no migration was added when user/project were added | 15:25 |
| dansmith | making them auto-heal is what I mean by migrating | 15:25 |
| melwitt | any update to allocations should add user/project if not already existing | 15:25 |
| dansmith | right, but does the reportclient re-write the allocation if just project/user is missing/ | 15:25 |
| dansmith | I thought it just counted resources | 15:25 |
| *** dpawlik has joined #openstack-nova | 15:26 | |
| dansmith | reportclient has become too complicated for me to be able to reasonably look I think | 15:26 |
| jaypipes | dansmith: cdent doesn't think user and project should be NOT NULL... | 15:26 |
| *** dpawlik has quit IRC | 15:26 | |
| dansmith | jaypipes: because why? | 15:26 |
| melwitt | I'm gonna look again | 15:27 |
| dansmith | jaypipes: I was asking because we're making things nullable to add the consumer generation, | 15:27 |
| jaypipes | dansmith: I'm not sure. he thinks that consumers in placement shouldn't need a project or user. so that placement can be used "for more things than just nova" was his answer. | 15:27 |
| *** dpawlik has joined #openstack-nova | 15:27 | |
| dansmith | jaypipes: but I guess unless we bump the minimum microversion we have to support those continuing to be created | 15:27 |
| *** dpawlik has quit IRC | 15:27 | |
| jaypipes | dansmith: yes, I would like to see those be NOT NULL, but there was stiff resistance from both cdent and edleafe | 15:27 |
| dansmith | jaypipes: user/project is required in later microversions right? | 15:28 |
| dansmith | if clients use older microversions just to get themselves an allocation without user/project, things are going to fall apart pretty quick | 15:28 |
| jaypipes | dansmith: 1.8 added them. 1.12 made them required for allocations. | 15:29 |
| *** salv-orlando has quit IRC | 15:29 | |
| jaypipes | dansmith: yes, I've argued this with both cdent and edleafe. | 15:29 |
| *** salv-orlando has joined #openstack-nova | 15:29 | |
| dansmith | jaypipes: yeah, so not enforcing them in schema because people could be using older microversions is valid, but expecting people to use 1.5 going forward just because the want to create non-multitenant allocations is crazypants | 15:30 |
| *** fishbone_ has joined #openstack-nova | 15:32 | |
| *** ragiman_ has quit IRC | 15:33 | |
| *** tbachman has quit IRC | 15:33 | |
| jaypipes | dansmith: I agree with you. | 15:33 |
| *** salv-orlando has quit IRC | 15:34 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | 15:34 |
| fishbone_ | hello all, I receive an error in the instance log when loading windows instances: pywintypes.com_error: (-2147352567, 'Exception occurred.', (0, 'Session', 'Access is denied. ', None, 0, -2147024891), None) | 15:35 |
| fishbone_ | My first assumption is updating the cloudbase-init package on the images but would anyone know another possible cause? | 15:36 |
| *** tbachman has joined #openstack-nova | 15:37 | |
| melwitt | dansmith: looks like any update of allocations will delete the already existing allocations, so because user/project is required >= 1.8, compute updates should result in ensuring user/project exist for allocations https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L2065 | 15:37 |
| dansmith | melwitt: right, but computes don't just update allocations all the time | 15:38 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove support for Intel CMT `perf` events https://review.openstack.org/565242 | 15:38 |
| melwitt | okay, I had thought there was a periodic update, but that was temporary right? I think that was happening back when microversion 1.8 was added | 15:38 |
| *** janki has quit IRC | 15:39 | |
| dansmith | melwitt: we don't heal active instances since ocata | 15:39 |
| melwitt | dansmith: okay, I think 1.8 was added in pike. so it sounds like we are missing a migration of already existing instances | 15:41 |
| *** janki has joined #openstack-nova | 15:41 | |
| dansmith | melwitt: well, it doesn't matter if we're not going to do the needful on the placement side | 15:41 |
| dansmith | I mean, doesn't matter for my question above | 15:41 |
| dansmith | matters for us using that data for quotas later, but not what I was asking about | 15:41 |
| * melwitt nods | 15:42 | |
| dansmith | hmm, I have op for some reason.. do we need a topic update before I drop it? | 15:42 |
| *** tbachman has quit IRC | 15:42 | |
| melwitt | yeah, need to swap a runway | 15:42 |
| melwitt | one of them has merged as of friday | 15:42 |
| dansmith | it would help if you could make sure the actual blueprint tag is in the runway description somewhere | 15:43 |
| dansmith | so I can just copy that in and not have to look it up | 15:43 |
| melwitt | okay, can do | 15:43 |
| dansmith | s/you/whoever is doing the runway jostling/ | 15:43 |
| *** burt has quit IRC | 15:43 | |
| *** Eran_Kuris has quit IRC | 15:43 | |
| *** janki has quit IRC | 15:44 | |
| *** eharney has joined #openstack-nova | 15:44 | |
| *** janki has joined #openstack-nova | 15:45 | |
| *** dansmith changes topic to "Current runways: xenapi-image-handler-option-improvement / convert-consoles-to-objects / add-zvm-driver-rocky -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 15:46 | |
| *** ChanServ sets mode: -o dansmith | 15:46 | |
| melwitt | thanks | 15:46 |
| dansmith | aye | 15:47 |
| *** ircuser-1 has joined #openstack-nova | 15:48 | |
| *** tbachman has joined #openstack-nova | 15:48 | |
| melwitt | yikun: fyi, your blueprint add-host-to-instance-action-events has been removed from the review runway as all the related code has merged. please feel free to add feedback about your experience with review runways at L186 https://etherpad.openstack.org/p/nova-runways-rocky | 15:50 |
| *** tssurya has quit IRC | 15:52 | |
| *** janki has quit IRC | 15:52 | |
| *** sdague has quit IRC | 15:53 | |
| *** janki has joined #openstack-nova | 15:59 | |
| *** moshele has quit IRC | 16:02 | |
| *** dtantsur is now known as dtantsur|afk | 16:02 | |
| *** belmorei_ has quit IRC | 16:03 | |
| *** namnh has quit IRC | 16:04 | |
| *** do3meli has quit IRC | 16:05 | |
| *** namnh has joined #openstack-nova | 16:06 | |
| *** namnh_ has joined #openstack-nova | 16:07 | |
| *** lucasagomes is now known as lucas-hungry | 16:08 | |
| *** namnh has quit IRC | 16:11 | |
| *** felipemonteiro has joined #openstack-nova | 16:12 | |
| *** sree has joined #openstack-nova | 16:18 | |
| *** udesale has quit IRC | 16:18 | |
| *** namnh_ has quit IRC | 16:22 | |
| *** armaan has quit IRC | 16:22 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:26 | |
| *** felipemonteiro has quit IRC | 16:29 | |
| *** itlinux has joined #openstack-nova | 16:34 | |
| openstackgerrit | Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371 | 16:38 |
| *** sree_ has joined #openstack-nova | 16:41 | |
| *** sree_ is now known as Guest43034 | 16:41 | |
| *** bhujay has quit IRC | 16:42 | |
| *** sree has quit IRC | 16:44 | |
| *** sree has joined #openstack-nova | 16:45 | |
| *** sdeath has quit IRC | 16:46 | |
| *** felipemonteiro_ has quit IRC | 16:46 | |
| *** Guest43034 has quit IRC | 16:46 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:46 | |
| *** burt has joined #openstack-nova | 16:54 | |
| *** mdnadeem has quit IRC | 16:55 | |
| *** evin has quit IRC | 16:55 | |
| *** mchlumsky has quit IRC | 16:56 | |
| *** armaan has joined #openstack-nova | 16:57 | |
| *** mchlumsky has joined #openstack-nova | 16:58 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 17:00 |
| *** derekh has quit IRC | 17:02 | |
| *** mchlumsky_ has joined #openstack-nova | 17:02 | |
| *** mchlumsky has quit IRC | 17:03 | |
| *** spsurya has quit IRC | 17:04 | |
| *** mchlumsky has joined #openstack-nova | 17:07 | |
| *** mchlumsky_ has quit IRC | 17:07 | |
| *** salv-orlando has joined #openstack-nova | 17:08 | |
| jaypipes | stephenfin: you there? do you see "(provider network" clipped to "rovider network)" on the graphics in http://logs.openstack.org/90/541290/9/check/build-openstack-sphinx-docs/0278227/html/specs/rocky/approved/numa-aware-vswitches.html? | 17:11 |
| jaypipes | not sure if I'm the only one that sees it because of my browser or something | 17:12 |
| artom | jaypipes, FWIW, I see it too | 17:15 |
| artom | Both FF and Chrome | 17:15 |
| * artom tries links ;) | 17:15 | |
| *** jmccarthy has left #openstack-nova | 17:18 | |
| *** dikonoor has quit IRC | 17:18 | |
| *** mdbooth has quit IRC | 17:22 | |
| jaypipes | mriedem, dansmith: mgagne mentioned on the ML that the latest Nova no longer includes user_id in the request spec. Is that true? Did we remove user_id from the request spec somehow? I don't see user_id in the request spec object, but I also don't see a major object version bump so I'm unsure if user_id was ever there? | 17:27 |
| *** sree has quit IRC | 17:27 | |
| mgagne | jaypipes: could be that when RequestSpec was created/used, user_id was dropped without mention | 17:27 |
| *** sree has joined #openstack-nova | 17:27 | |
| dansmith | jaypipes: pretty sure it wasn't dropped | 17:28 |
| mgagne | I think there are no filter using it so maybe people saw no need to still support it | 17:29 |
| *** itlinux has quit IRC | 17:29 | |
| mgagne | I know it used to be available in filter_properties['instance_properties']['user_id'] | 17:30 |
| mgagne | in fact | 17:30 |
| mgagne | filter_properties['request_spec']['instance_properties']['user_id'] | 17:30 |
| jaypipes | hmm.. | 17:31 |
| dansmith | oh in filter_properties | 17:31 |
| dansmith | that wouldn't require a bump | 17:31 |
| dansmith | mgagne: this is an internal nova object, what are you concerned about it being missing for? | 17:31 |
| dansmith | because of scheduling? | 17:31 |
| mgagne | dropped -> forgot to reimplement it | 17:31 |
| *** sree has quit IRC | 17:32 | |
| mgagne | dansmith: for a custom filter http://lists.openstack.org/pipermail/openstack-dev/2018-April/130022.html | 17:32 |
| dansmith | okay so you care that it's not coming to your filter | 17:33 |
| mgagne | yes | 17:33 |
| dansmith | is this where I say it's bad that we say we have a plugin interface we know is not stable because we don't test it and pass internal data structures to it? :) | 17:33 |
| mgagne | ¯\_(ツ)_/¯ don't care much, it fits my need ;) | 17:34 |
| *** gjayavelu has joined #openstack-nova | 17:37 | |
| *** sambetts is now known as sambetts|afk | 17:37 | |
| *** yamahata has joined #openstack-nova | 17:39 | |
| *** salv-orlando has quit IRC | 17:39 | |
| *** amoralej is now known as amoralej|off | 17:40 | |
| *** salv-orlando has joined #openstack-nova | 17:40 | |
| *** fragatin_ has quit IRC | 17:41 | |
| mgagne | If there is a defined object/interface, I will use it. Otherwise I will find a way to make it work. No much I can do to avoid that when the business I work for needs it. | 17:44 |
| mgagne | If I can contribute something back (and don't forget about it), I will. If it's too much work/time, it's gonna go in the backlog and will try to contribute when time is available. | 17:44 |
| *** salv-orlando has quit IRC | 17:44 | |
| mriedem | i don't see anything specific to instance_properties['user_id'], the request spec 'instance_properties' looks like it's getting built from build_request_spec in certain flows, but that's using the instance object, which should have user_id on it | 17:47 |
| mriedem | build_request_spec is also used when a really old instance is moved and doesn't have a request spec | 17:48 |
| mriedem | mgagne: i think i know what you're probably hitting | 17:48 |
| mriedem | mnaser hit it too | 17:49 |
| mriedem | and reported it | 17:49 |
| mriedem | https://review.openstack.org/#/c/529185/ | 17:49 |
| mgagne | I already have an internal patch I can contribute: https://gist.github.com/mgagne/ed1fd3251997b2e60564fed43f47d96f | 17:49 |
| mgagne | just need to port it for master, currently against mitaka | 17:50 |
| mriedem | mgagne: my guess is you are hitting a symptom of the same bug that ^ is working around | 17:51 |
| mriedem | in that data migrations for instances that didn't have request specs used an admin context, which doesn't have project_id or user_id set | 17:51 |
| mgagne | project_id is available for me | 17:51 |
| mgagne | but the object just doesn't have the user_id attribute | 17:51 |
| mriedem | because that workaround puts it into the request spec | 17:51 |
| mriedem | are you hitting this on a move operation? | 17:52 |
| mgagne | no, new instances | 17:52 |
| mriedem | and you're going from which release (working) to which release (broken)? | 17:52 |
| mgagne | user_id is not available because it's not in the RequestSpec class | 17:52 |
| mriedem | mgagne: yeah, that's because you should be using reqspec.instance.user_id no? | 17:53 |
| mgagne | kilo -> mitaka. I lost the user_id when moving from filter_properties to spec_obj | 17:53 |
| mriedem | ok mitaka is definitely not "latest" nova | 17:53 |
| mgagne | =) | 17:53 |
| mriedem | why can't you use reqspec.instance.user_id? | 17:53 |
| mriedem | oh nvm | 17:53 |
| mgagne | spec_obj.project_id is available, not spec_obj.user_id | 17:53 |
| mriedem | RequestSpec.from_primitives uses filter_properties to build the RequestSpec from the instance, and doesn't save off the user_id | 17:54 |
| mgagne | I didn't look much into it, I saw that spec_obj.project_id was available and used elsewhere and tried spec_obj.user_id | 17:54 |
| mriedem | so https://review.openstack.org/#/c/197912/ was the regression for you in mitaka | 17:56 |
| mgagne | yes | 17:57 |
| mgagne | I'm just gonna contribute my patch and see where it goes from there | 17:57 |
| *** tbachman has quit IRC | 17:57 | |
| *** liverpooler has quit IRC | 17:57 | |
| *** armaan has quit IRC | 17:58 | |
| mriedem | wfm, should probably report a bug as well | 17:59 |
| *** fragatina has joined #openstack-nova | 17:59 | |
| mgagne | bug is enough? will open then | 17:59 |
| mriedem | regardless of the custom out of tree scheduler filter dependency, it makes sense to have user_id to know the user that originally requested to create the instance vs another user (in the same project) to move an instance | 17:59 |
| mriedem | especially if we already have project_id in RequestSpec | 17:59 |
| melwitt | fwiw, I agree. we have the same mismatch (project_id but no user_id) in InstanceMapping too | 18:00 |
| mriedem | maybe others feel differently, but this seems ok to me as a regression fix, albeit for out of tree things | 18:00 |
| mriedem | instance mappings are pretty special purpose though, | 18:00 |
| mriedem | and not tied to any pluggable interfaces as far as i know | 18:01 |
| melwitt | no, but it was weird to see part of the owner info there and not the other when I looked at it for counting instances. I don't know what it uses project_id for currently | 18:03 |
| *** liverpooler has joined #openstack-nova | 18:03 | |
| mriedem | allocation claims in placement at least | 18:03 |
| mriedem | AggregateMultiTenancyIsolation also uses it | 18:04 |
| mgagne | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/aggregate_multitenancy_isolation.py#L41 | 18:04 |
| mgagne | yes | 18:04 |
| mgagne | that's where I found spec_obj.project_id was available | 18:04 |
| melwitt | I mean I don't know what the InstanceMapping.project_id is used for currently | 18:04 |
| melwitt | i.e. why it needed project_id but not user_id | 18:05 |
| dansmith | melwitt: so you can list instances :) | 18:05 |
| *** r-daneel has quit IRC | 18:06 | |
| *** r-daneel has joined #openstack-nova | 18:06 | |
| dansmith | melwitt: for this: https://review.openstack.org/#/c/509003/8 | 18:08 |
| melwitt | oh okay, so it doesn't just do a scatter-gather query instances by project_id and instead does separate queries per InstanceMapping? I didn't realize that | 18:08 |
| dansmith | well, it was to avoid hitting cells you don't need during list.. I don't remember if we ever implemented that before my list thing, | 18:09 |
| dansmith | but we never merged that bit of my newer thing either | 18:09 |
| dansmith | because of the BR thing I never finished | 18:09 |
| *** moshele has joined #openstack-nova | 18:09 | |
| melwitt | oh, I see | 18:09 |
| melwitt | so it could pre-check if there are any cells that do not contain that project_id | 18:10 |
| dansmith | it just got a unique list of cells that you have mappings for | 18:11 |
| dansmith | https://review.openstack.org/#/c/509002/8/nova/objects/cell_mapping.py | 18:11 |
| dansmith | we never implemented that before (I just checked) with the old stuff because we were just using the global cell mapping list | 18:12 |
| dansmith | it's a perf tradeoff | 18:12 |
| dansmith | for two cells and even distribution, it's faster to just use the global list, | 18:12 |
| dansmith | if you're cern, it makes sense to figure out which cells we should even ask during list | 18:13 |
| dansmith | might should have a perf tunable in that last patch | 18:13 |
| *** mvk has quit IRC | 18:14 | |
| mgagne | I opened the bug, I'm currently working on it https://bugs.launchpad.net/nova/+bug/1768107 | 18:14 |
| openstack | Launchpad bug 1768107 in OpenStack Compute (nova) "The user_id field is missing from RequestSpec" [Undecided,In progress] - Assigned to Mathieu Gagné (mgagne) | 18:14 |
| melwitt | yeah, understood | 18:15 |
| *** itlinux has joined #openstack-nova | 18:18 | |
| *** tbachman has joined #openstack-nova | 18:18 | |
| *** dave-mcc_ has quit IRC | 18:21 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:29 | |
| *** dave-mccowan has joined #openstack-nova | 18:29 | |
| *** evin has joined #openstack-nova | 18:31 | |
| *** felipemonteiro_ has quit IRC | 18:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement granular policy rules for placement https://review.openstack.org/524425 | 18:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup placement policy generator docs https://review.openstack.org/565225 | 18:37 |
| *** salv-orlando has joined #openstack-nova | 18:40 | |
| *** xinliang has quit IRC | 18:45 | |
| *** salv-orlando has quit IRC | 18:45 | |
| *** eharney has quit IRC | 18:46 | |
| *** mvk has joined #openstack-nova | 18:47 | |
| *** janki has quit IRC | 18:52 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351 | 18:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 18:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Get anchors for sharing providers https://review.openstack.org/565279 | 18:55 |
| *** xinliang has joined #openstack-nova | 18:57 | |
| *** eharney has joined #openstack-nova | 18:59 | |
| *** moshele has quit IRC | 19:02 | |
| *** jmlowe has quit IRC | 19:07 | |
| *** itlinux has quit IRC | 19:07 | |
| *** bpoulos has joined #openstack-nova | 19:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | 19:17 |
| *** hemna_ has quit IRC | 19:22 | |
| *** jmlowe has joined #openstack-nova | 19:23 | |
| *** wolverineav has quit IRC | 19:31 | |
| *** wolverineav has joined #openstack-nova | 19:31 | |
| *** eharney has quit IRC | 19:34 | |
| *** wolverineav has quit IRC | 19:35 | |
| *** READ10 has quit IRC | 19:37 | |
| *** randomhack has joined #openstack-nova | 19:38 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova stable/pike: conf: Do not inherit image signature props with snapshots https://review.openstack.org/565288 | 19:39 |
| *** tlb has quit IRC | 19:40 | |
| *** salv-orlando has joined #openstack-nova | 19:41 | |
| *** moshele has joined #openstack-nova | 19:41 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova stable/pike: conf: Do not inherit image signature props with snapshots https://review.openstack.org/565288 | 19:42 |
| *** moshele has quit IRC | 19:44 | |
| *** salv-orlando has quit IRC | 19:46 | |
| *** armaan has joined #openstack-nova | 19:48 | |
| *** fragatina has quit IRC | 19:51 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269 | 19:52 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Get anchors for sharing providers https://review.openstack.org/565279 | 19:58 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351 | 19:58 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 19:58 |
| *** dave-mccowan has quit IRC | 20:02 | |
| *** sree has joined #openstack-nova | 20:03 | |
| *** itlinux has joined #openstack-nova | 20:06 | |
| *** rmart04 has joined #openstack-nova | 20:06 | |
| *** sree has quit IRC | 20:08 | |
| *** liverpooler has quit IRC | 20:10 | |
| *** felipemonteiro__ has quit IRC | 20:12 | |
| *** dave-mccowan has joined #openstack-nova | 20:17 | |
| *** itlinux has quit IRC | 20:17 | |
| *** hemna_ has joined #openstack-nova | 20:18 | |
| *** rmart04 has quit IRC | 20:18 | |
| *** itlinux has joined #openstack-nova | 20:19 | |
| *** fragatina has joined #openstack-nova | 20:19 | |
| *** fragatina has quit IRC | 20:20 | |
| *** jmlowe has quit IRC | 20:21 | |
| *** fragatina has joined #openstack-nova | 20:22 | |
| *** rmart04 has joined #openstack-nova | 20:23 | |
| *** slaweq_ has joined #openstack-nova | 20:27 | |
| *** rmart04 has quit IRC | 20:28 | |
| *** artom has quit IRC | 20:34 | |
| *** itlinux has quit IRC | 20:36 | |
| *** eharney has joined #openstack-nova | 20:37 | |
| *** salv-orlando has joined #openstack-nova | 20:42 | |
| *** salv-orlando has quit IRC | 20:46 | |
| *** slaweq has quit IRC | 20:50 | |
| *** slaweq_ is now known as slaweq | 20:54 | |
| *** dave-mccowan has quit IRC | 20:55 | |
| *** awaugama has quit IRC | 20:57 | |
| *** pchavva has quit IRC | 20:57 | |
| mriedem | dansmith: i think https://review.openstack.org/#/c/325414/ (bottom patch in the console auth token series) is ready to go, comments up the stack on the other changes though | 20:59 |
| mriedem | dansmith: this is also likely a question for you https://review.openstack.org/#/c/333990/32/nova/console/websocketproxy.py@43 | 20:59 |
| *** vladikr has quit IRC | 21:01 | |
| *** vladikr has joined #openstack-nova | 21:03 | |
| dansmith | mriedem: answered that question.. not sure I'll get to much more before EOD | 21:03 |
| mriedem | melwitt: fyi, comments in your console auth token series | 21:05 |
| mriedem | i see the runway slot ends tomorrow | 21:05 |
| mriedem | sorry for being late on those | 21:05 |
| melwitt | mriedem: replies in progress | 21:06 |
| melwitt | no worries | 21:06 |
| mriedem | fwiw i think it's mostly easy stuff | 21:06 |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add user_id to RequestSpec https://review.openstack.org/565340 | 21:06 |
| melwitt | thanks for the reviews | 21:06 |
| *** tbachman has quit IRC | 21:06 | |
| *** dougshelley66 has quit IRC | 21:07 | |
| *** edmondsw has quit IRC | 21:07 | |
| *** bpoulos has quit IRC | 21:08 | |
| *** tbachman has joined #openstack-nova | 21:10 | |
| *** armaan has quit IRC | 21:10 | |
| *** tbachman has quit IRC | 21:10 | |
| *** edmondsw_ has joined #openstack-nova | 21:11 | |
| *** armaan has joined #openstack-nova | 21:11 | |
| *** armaan_ has joined #openstack-nova | 21:12 | |
| *** armaan has quit IRC | 21:12 | |
| *** edmondsw_ has quit IRC | 21:15 | |
| *** fishbone_ has quit IRC | 21:15 | |
| *** armaan_ has quit IRC | 21:22 | |
| *** esberglu has quit IRC | 21:22 | |
| melwitt | mriedem: do you happen to know what's the process for moving methods into os-vif plugins for plug/unplug? does there have to be a deprecation period or requirement for how the plugin has to be able to be installed? this is a change for moving bigswitch methods to a plugin: https://review.openstack.org/534371 | 21:29 |
| mriedem | last time i looked at that patch i asked some questions https://review.openstack.org/#/c/534371/4//COMMIT_MSG@12 | 21:30 |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add user_id to RequestSpec https://review.openstack.org/565340 | 21:30 |
| melwitt | oh, I'm blind | 21:31 |
| mriedem | as for what the process is, i don't think we really have one, but if we have some vif type impl in tree and then it moves to an out of tree neutron plugin, operators would obviously need to make sure the neutron agent is using that new package to provide that vif type support before they upgrade nova-compute | 21:32 |
| mgagne | mriedem: just to make sure, I'm looking at above test for user_id and they don't cover use case you are suggesting. so I'm a bit confused about why in that case, I should test for it. | 21:32 |
| mriedem | mgagne: see my latest reply? | 21:32 |
| mgagne | mriedem: yes, hence my question | 21:33 |
| mriedem | mgagne: because we have unit tests with false positives i think for some object compat tests | 21:33 |
| mriedem | so asserting that something is still in the primitive after the compat conversion is just good practice to make sure the test is not asserting a false positive | 21:33 |
| mgagne | ok so it's a new use case we should add that doesn't exist currently | 21:34 |
| mriedem | mgagne: here is one example https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_migrate_data.py#L74 | 21:34 |
| mgagne | because there is no way I could have guess that this kind of test was a good idea by looking at previous tests above. | 21:34 |
| melwitt | mriedem: okay, makes sense | 21:35 |
| mgagne | yes, I know the principle just wondering why now it's important and not before | 21:35 |
| mriedem | i think this test might be broken https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_migrate_data.py#L226 | 21:35 |
| mriedem | mgagne: because reviewers might not have thought about it before when reviewing these types of tests, | 21:35 |
| mriedem | and dansmith busted me on making the same mistake once in something i was adding that did the same thing, so now i'm conscious of it | 21:36 |
| mgagne | mriedem: ok, will add those tests. In that case, I suggest we retrofit the other tests too | 21:36 |
| mriedem | mgagne: i don't think that needs to happen in your change - retrofitting the existing tests i mean | 21:36 |
| mgagne | ok | 21:36 |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add user_id to RequestSpec https://review.openstack.org/565340 | 21:38 |
| *** felipemonteiro has joined #openstack-nova | 21:42 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Make `cpu_model_extra_flags` case-insensitive for real https://review.openstack.org/565043 | 21:43 |
| *** salv-orlando has joined #openstack-nova | 21:43 | |
| *** dougshelley66 has joined #openstack-nova | 21:44 | |
| *** felipemonteiro_ has joined #openstack-nova | 21:46 | |
| *** tbachman has joined #openstack-nova | 21:47 | |
| arvindn05 | i need to add a patch method to the client under tests.functional.api.client.TestOpenStackClient | 21:47 |
| *** salv-orlando has quit IRC | 21:48 | |
| arvindn05 | methods like tests.functional.api.client.TestOpenStackClient#post_image invoke tests.unit.image.fake._FakeImageService | 21:48 |
| arvindn05 | how is this mapping made? | 21:48 |
| *** felipemonteiro has quit IRC | 21:50 | |
| *** tbachman_ has joined #openstack-nova | 21:51 | |
| *** tbachman has quit IRC | 21:51 | |
| *** tbachman_ is now known as tbachman | 21:51 | |
| arvindn05 | in other words, how can i ensure a specific method is called when PATCH is called on the FakeImageService? | 21:51 |
| mriedem | why do you need to add a patch method? | 21:52 |
| mriedem | to update an existing fake image with required traits? | 21:53 |
| arvindn05 | yup | 21:53 |
| mriedem | just add a new fake image in the 'registry' with the required traits, hard-code the uuid and refer to that image id in your tests | 21:53 |
| mriedem | done! | 21:53 |
| arvindn05 | mriedem: glad you said that...i did exactly that i think....alex didnt want adding the image with required traits to the registry | 21:54 |
| arvindn05 | https://review.openstack.org/#/c/560596/ | 21:54 |
| arvindn05 | :( | 21:54 |
| arvindn05 | it kindof makes sense....we dont want the registry to grow big with each of these changes | 21:54 |
| arvindn05 | so wanted to do the same as how you guys handled flavor in the same tests....basically update a fake image with required traits | 21:55 |
| mriedem | we don't need a fake service for flavors | 21:55 |
| mriedem | _FakeImageService implements update() so why can't you just rely on that? | 21:56 |
| mriedem | you should be able to just use this https://developer.openstack.org/api-ref/compute/#update-image-metadata | 21:56 |
| mriedem | however, you have to make sure to use microversion < 2.39 | 21:56 |
| mriedem | which is pretty easy though | 21:57 |
| mriedem | with nova.utils.temporary_mutation(self.api.microversion, '2.1'): | 21:57 |
| mriedem | ... update image metadata | 21:57 |
| arvindn05 | you mean >2.39 right? | 21:58 |
| *** slaweq has quit IRC | 21:58 | |
| mriedem | no | 21:58 |
| mriedem | see the warning https://developer.openstack.org/api-ref/compute/#images-deprecated | 21:58 |
| mriedem | also, i don't see where alex says to not create a new fake image in https://review.openstack.org/#/c/560596/ | 21:59 |
| arvindn05 | oh...how d | 21:59 |
| arvindn05 | he said not to update the registry | 21:59 |
| mriedem | where? | 21:59 |
| mriedem | link please | 21:59 |
| arvindn05 | looking at this one of the alternatives | 21:59 |
| arvindn05 | The API sample tests are for verify the API change, not sure we should use API sample test for other function/feature test. | 22:00 |
| arvindn05 | on PS9 | 22:01 |
| mriedem | left a comment in the patch | 22:02 |
| arvindn05 | also is it a good idea to use deprecated api? | 22:03 |
| arvindn05 | will check the comment | 22:03 |
| *** jmlowe has joined #openstack-nova | 22:05 | |
| arvindn05 | patch seems to be a more longer term fix IMO | 22:06 |
| arvindn05 | i will attempt to use the API mentioned for now....thanks mriedem | 22:06 |
| arvindn05 | might be harder to implement the patch api i guess, to parse the operation, the path and value etc... | 22:07 |
| arvindn05 | mriedem: from where does tests.unit.image.fake._FakeImageService#update get called in case of the fake image service | 22:11 |
| mriedem | PATCH is if you're calling the image service API directly, which you wouldn't be within nova functional tests | 22:11 |
| mriedem | you're calling the compute image API proxy, which doesn't use PATCH | 22:11 |
| mriedem | it's a stub for the nova.image.glance api code | 22:12 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | 22:12 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add consumer generation checking logic https://review.openstack.org/564641 | 22:12 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/562000 | 22:12 |
| mriedem | anyway, i have to run | 22:12 |
| *** mriedem is now known as mriedem_away | 22:12 | |
| arvindn05 | thanks...will dig deeper | 22:12 |
| *** dklyle has joined #openstack-nova | 22:13 | |
| *** rcernin has joined #openstack-nova | 22:13 | |
| mriedem_away | stephenfin: for your morrow, are you good with https://review.openstack.org/#/c/534371/ now? it's holding up mikal's https://review.openstack.org/#/c/557552/ | 22:14 |
| *** tbachman has quit IRC | 22:14 | |
| *** slaweq has joined #openstack-nova | 22:26 | |
| *** slaweq_ has joined #openstack-nova | 22:26 | |
| *** moshele has joined #openstack-nova | 22:27 | |
| *** slaweq_ has quit IRC | 22:28 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add user_id to RequestSpec https://review.openstack.org/565340 | 22:29 |
| *** moshele has quit IRC | 22:33 | |
| *** salv-orlando has joined #openstack-nova | 22:36 | |
| *** jmlowe has quit IRC | 22:37 | |
| *** abalutoiu_ has joined #openstack-nova | 22:51 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 22:51 |
| *** jmlowe has joined #openstack-nova | 22:53 | |
| *** abalutoiu__ has quit IRC | 22:54 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 22:56 |
| *** felipemonteiro_ has quit IRC | 22:56 | |
| *** slaweq has quit IRC | 22:56 | |
| *** slaweq has joined #openstack-nova | 22:56 | |
| *** hongbin has quit IRC | 22:59 | |
| *** slaweq has quit IRC | 23:01 | |
| *** felipemonteiro has joined #openstack-nova | 23:02 | |
| *** felipemonteiro_ has joined #openstack-nova | 23:02 | |
| *** purplerbot has quit IRC | 23:03 | |
| *** lbragstad has quit IRC | 23:05 | |
| *** felipemonteiro has quit IRC | 23:06 | |
| *** rajinir has quit IRC | 23:08 | |
| *** r-daneel has quit IRC | 23:09 | |
| *** purplerbot has joined #openstack-nova | 23:11 | |
| *** jmlowe has quit IRC | 23:13 | |
| *** sree has joined #openstack-nova | 23:14 | |
| *** jmlowe has joined #openstack-nova | 23:15 | |
| *** sree has quit IRC | 23:19 | |
| *** felipemonteiro__ has joined #openstack-nova | 23:23 | |
| *** felipemonteiro_ has quit IRC | 23:23 | |
| *** slaweq has joined #openstack-nova | 23:26 | |
| *** salv-orlando has quit IRC | 23:28 | |
| *** salv-orlando has joined #openstack-nova | 23:29 | |
| *** salv-orlando has quit IRC | 23:33 | |
| *** sree has joined #openstack-nova | 23:35 | |
| *** slaweq has quit IRC | 23:36 | |
| *** slaweq has joined #openstack-nova | 23:37 | |
| *** sree has quit IRC | 23:40 | |
| *** slaweq has quit IRC | 23:41 | |
| *** Lingwu has quit IRC | 23:47 | |
| *** hemna_ has quit IRC | 23:48 | |
| *** liverpooler has joined #openstack-nova | 23:48 | |
| *** cfriesen has quit IRC | 23:57 | |
| *** cfriesen has joined #openstack-nova | 23:57 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 23:59 |
| openstackgerrit | melanie witt proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | 23:59 |
| openstackgerrit | melanie witt proposed openstack/nova master: Deprecate the nova-consoleauth service https://review.openstack.org/565367 | 23:59 |
| *** imacdonn has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!