| *** moetunes0B2646 has joined #openstack-nova | 00:00 | |
| *** salv-orlando has joined #openstack-nova | 00:01 | |
| *** dillaman has quit IRC | 00:01 | |
| *** hamzy_ has joined #openstack-nova | 00:02 | |
| *** itlinux has quit IRC | 00:03 | |
| *** fragatina has quit IRC | 00:04 | |
| *** fragatina has joined #openstack-nova | 00:05 | |
| *** liverpooler has joined #openstack-nova | 00:06 | |
| *** salv-orlando has quit IRC | 00:06 | |
| *** itlinux has joined #openstack-nova | 00:06 | |
| *** liverpooler has quit IRC | 00:07 | |
| melwitt | mriedem_afk: alright, thanks | 00:08 |
|---|---|---|
| *** hamzy has joined #openstack-nova | 00:08 | |
| *** fragatina has quit IRC | 00:09 | |
| *** gyee has quit IRC | 00:10 | |
| *** hamzy_ has quit IRC | 00:10 | |
| *** Sukhdev has quit IRC | 00:10 | |
| *** moetunes0B2646 has quit IRC | 00:12 | |
| *** didelspk has quit IRC | 00:15 | |
| *** r-daneel has quit IRC | 00:21 | |
| *** stakeda has joined #openstack-nova | 00:33 | |
| *** _ix has joined #openstack-nova | 00:36 | |
| *** felipemonteiro_ has quit IRC | 00:38 | |
| *** liuzz_ has quit IRC | 00:39 | |
| *** liuzz has joined #openstack-nova | 00:40 | |
| *** itlinux has quit IRC | 00:41 | |
| *** yingjun has joined #openstack-nova | 00:42 | |
| *** hshiina has joined #openstack-nova | 00:45 | |
| *** itlinux has joined #openstack-nova | 00:46 | |
| *** jichen has joined #openstack-nova | 00:48 | |
| *** harlowja has quit IRC | 00:52 | |
| *** hoangcx has joined #openstack-nova | 00:56 | |
| *** yangyape_ has quit IRC | 00:57 | |
| *** itlinux has quit IRC | 00:58 | |
| *** _ix has quit IRC | 00:59 | |
| *** gouthamr has quit IRC | 00:59 | |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| *** salv-orlando has joined #openstack-nova | 01:02 | |
| *** artom has joined #openstack-nova | 01:04 | |
| *** hongbin has joined #openstack-nova | 01:05 | |
| *** gouthamr has joined #openstack-nova | 01:05 | |
| openstackgerrit | Merged openstack/nova master: Move get_stashed_volume_connector to compute.utils https://review.openstack.org/557810 | 01:05 |
| *** salv-orlando has quit IRC | 01:06 | |
| *** itlinux has joined #openstack-nova | 01:08 | |
| *** tiendc has joined #openstack-nova | 01:10 | |
| *** itlinux has quit IRC | 01:10 | |
| *** zhaochao has joined #openstack-nova | 01:13 | |
| openstackgerrit | Merged openstack/nova master: ProviderTree.{add|remove}_{traits|aggregates} https://review.openstack.org/553475 | 01:14 |
| *** moshele has joined #openstack-nova | 01:14 | |
| *** caisan has joined #openstack-nova | 01:15 | |
| *** hemna_ has quit IRC | 01:16 | |
| *** moshele has quit IRC | 01:16 | |
| *** wolverineav has quit IRC | 01:17 | |
| *** wolverineav has joined #openstack-nova | 01:17 | |
| *** itlinux has joined #openstack-nova | 01:20 | |
| *** wolverineav has quit IRC | 01:21 | |
| *** chenyb4 has joined #openstack-nova | 01:27 | |
| *** r-daneel has joined #openstack-nova | 01:29 | |
| *** phuongnh has quit IRC | 01:33 | |
| *** yangyapeng has joined #openstack-nova | 01:33 | |
| *** phuongnh has joined #openstack-nova | 01:33 | |
| *** yamahata has quit IRC | 01:35 | |
| *** itlinux has quit IRC | 01:35 | |
| *** gouthamr_ has joined #openstack-nova | 01:37 | |
| *** gouthamr has quit IRC | 01:37 | |
| *** gouthamr_ is now known as gouthamr | 01:37 | |
| *** yangyapeng has quit IRC | 01:39 | |
| *** yingjun has quit IRC | 01:43 | |
| *** swamireddy has joined #openstack-nova | 01:43 | |
| *** mriedem_afk has quit IRC | 01:50 | |
| *** yingjun has joined #openstack-nova | 01:55 | |
| *** ssurana has quit IRC | 01:55 | |
| *** yangyapeng has joined #openstack-nova | 01:56 | |
| *** yangyapeng has quit IRC | 01:58 | |
| *** phuongnh has quit IRC | 02:02 | |
| *** salv-orlando has joined #openstack-nova | 02:02 | |
| *** gjayavelu has quit IRC | 02:06 | |
| *** salv-orlando has quit IRC | 02:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (2) https://review.openstack.org/560829 | 02:10 |
| *** gaoyan has joined #openstack-nova | 02:13 | |
| *** phuongnh has joined #openstack-nova | 02:16 | |
| *** phuongnh has quit IRC | 02:21 | |
| *** phuongnh has joined #openstack-nova | 02:22 | |
| *** Spaz-Work has quit IRC | 02:25 | |
| *** Spazmotic has joined #openstack-nova | 02:25 | |
| *** armaan has quit IRC | 02:25 | |
| *** armaan has joined #openstack-nova | 02:26 | |
| *** READ10 has quit IRC | 02:29 | |
| *** gongysh has joined #openstack-nova | 02:30 | |
| *** germs has quit IRC | 02:34 | |
| *** germs has joined #openstack-nova | 02:35 | |
| *** germs has quit IRC | 02:35 | |
| *** germs has joined #openstack-nova | 02:35 | |
| *** vivsoni has joined #openstack-nova | 02:41 | |
| *** xinliang has quit IRC | 02:47 | |
| *** nicolasbock has quit IRC | 02:47 | |
| *** xinliang has joined #openstack-nova | 02:58 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in test_neutron_security_groups.py https://review.openstack.org/560267 | 03:01 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 03:02 |
| *** salv-orlando has joined #openstack-nova | 03:03 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| *** salv-orlando has quit IRC | 03:07 | |
| *** imacdonn has quit IRC | 03:09 | |
| *** imacdonn has joined #openstack-nova | 03:09 | |
| *** Tom-Tom has joined #openstack-nova | 03:10 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add config drive link to api-guide https://review.openstack.org/561113 | 03:13 |
| *** fragatina has joined #openstack-nova | 03:16 | |
| *** fragatina has quit IRC | 03:17 | |
| *** fragatina has joined #openstack-nova | 03:17 | |
| *** sdeath has joined #openstack-nova | 03:19 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Update link of metadata https://review.openstack.org/561114 | 03:21 |
| *** annp has joined #openstack-nova | 03:21 | |
| *** sree has joined #openstack-nova | 03:25 | |
| *** sree has quit IRC | 03:26 | |
| phuongnh | hi all, I would like to add one more line in file https://review.openstack.org/#/c/462759/3/os_traits/hw/cpu/x86.py for CPU_FPGA | 03:33 |
| phuongnh | the link to this is: https://en.wikipedia.org/wiki/Field-programmable_gate_array | 03:33 |
| phuongnh | Do I need to propose a blueprint in launchpad? | 03:33 |
| *** yingjun has quit IRC | 03:39 | |
| *** otih_T89NZ8 has joined #openstack-nova | 03:40 | |
| *** fragatina has quit IRC | 03:42 | |
| *** sree has joined #openstack-nova | 03:45 | |
| *** otih_T89NZ8 has quit IRC | 03:47 | |
| *** gaoyan has quit IRC | 03:48 | |
| *** itlinux has joined #openstack-nova | 03:49 | |
| *** sidx64 has joined #openstack-nova | 03:50 | |
| *** gaoyan has joined #openstack-nova | 03:51 | |
| *** caisan has quit IRC | 03:57 | |
| *** aqScotteh has joined #openstack-nova | 03:57 | |
| *** aqScotteh has quit IRC | 03:59 | |
| *** gjayavelu has joined #openstack-nova | 03:59 | |
| *** udesale has joined #openstack-nova | 04:01 | |
| *** liusheng has quit IRC | 04:01 | |
| *** liusheng has joined #openstack-nova | 04:01 | |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/os-traits master: [WIP] add fpga cpu for the future https://review.openstack.org/561117 | 04:02 |
| *** salv-orlando has joined #openstack-nova | 04:04 | |
| sapd_ | Hi guys, I want to pass volume_type to block_device_mapping_v2, I saw this specs: https://review.openstack.org/#/c/362698/5/specs/ocata/approved/add-volume-type-when-boot-instances.rst , but have it implemented yet? | 04:07 |
| *** salv-orlando has quit IRC | 04:08 | |
| *** gouthamr_ has joined #openstack-nova | 04:09 | |
| *** sapd has joined #openstack-nova | 04:10 | |
| *** hongbin has quit IRC | 04:11 | |
| *** gouthamr has quit IRC | 04:11 | |
| *** gouthamr_ is now known as gouthamr | 04:12 | |
| *** gouthamr_ has joined #openstack-nova | 04:12 | |
| *** rajinir has quit IRC | 04:14 | |
| *** gouthamr has quit IRC | 04:20 | |
| *** gouthamr_ has quit IRC | 04:20 | |
| *** gouthamr has joined #openstack-nova | 04:21 | |
| *** blkart has quit IRC | 04:23 | |
| *** itlinux has quit IRC | 04:23 | |
| *** namnh has joined #openstack-nova | 04:24 | |
| *** yamahata has joined #openstack-nova | 04:24 | |
| *** lbragstad has joined #openstack-nova | 04:26 | |
| *** lbragstad has quit IRC | 04:28 | |
| *** gongysh has quit IRC | 04:30 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776 | 04:32 |
| *** gongysh has joined #openstack-nova | 04:37 | |
| *** ssurana has joined #openstack-nova | 04:41 | |
| *** gaoyan has quit IRC | 04:41 | |
| *** gongysh has quit IRC | 04:42 | |
| *** harlowja has joined #openstack-nova | 04:44 | |
| *** sapd has quit IRC | 04:44 | |
| *** abhishekk has joined #openstack-nova | 04:45 | |
| *** diga has joined #openstack-nova | 04:46 | |
| *** sapd has joined #openstack-nova | 04:47 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Partially revert "Remove mox in unit/virt/xenapi/test_vm_utils.py (3)" https://review.openstack.org/561121 | 04:47 |
| *** ssurana has quit IRC | 04:50 | |
| *** caisan has joined #openstack-nova | 04:50 | |
| openstackgerrit | jichenjc proposed openstack/nova master: [libvirt] Avoid create swap definition in xml https://review.openstack.org/561122 | 04:51 |
| *** liuzz_ has joined #openstack-nova | 04:56 | |
| *** liuzz has quit IRC | 04:59 | |
| *** andreas_s has joined #openstack-nova | 05:01 | |
| *** salv-orlando has joined #openstack-nova | 05:05 | |
| *** andreas_s has quit IRC | 05:06 | |
| *** caisan has quit IRC | 05:06 | |
| *** salv-orlando has quit IRC | 05:09 | |
| *** links has joined #openstack-nova | 05:12 | |
| *** lpetrut has joined #openstack-nova | 05:12 | |
| openstackgerrit | Merged openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 05:14 |
| *** ratailor has joined #openstack-nova | 05:15 | |
| *** salv-orlando has joined #openstack-nova | 05:17 | |
| *** sridharg has joined #openstack-nova | 05:24 | |
| *** gongysh has joined #openstack-nova | 05:26 | |
| *** mordred has quit IRC | 05:29 | |
| *** harlowja has quit IRC | 05:39 | |
| *** gaoyan has joined #openstack-nova | 05:39 | |
| *** mordred has joined #openstack-nova | 05:41 | |
| *** sidx64 has quit IRC | 05:42 | |
| *** fragatina has joined #openstack-nova | 05:44 | |
| *** sapd has quit IRC | 05:45 | |
| *** caisan has joined #openstack-nova | 05:48 | |
| *** andreas_s has joined #openstack-nova | 05:48 | |
| *** andreas_s has quit IRC | 05:48 | |
| *** andreas_s has joined #openstack-nova | 05:48 | |
| *** claudiub|2 has joined #openstack-nova | 05:48 | |
| *** sidx64 has joined #openstack-nova | 05:49 | |
| gmann | sapd_: this is not implemented and idea is not to implement. you can check the details in that spec | 05:53 |
| *** lajoskatona has joined #openstack-nova | 05:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 05:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 05:58 |
| *** lpetrut has quit IRC | 06:03 | |
| *** gjayavelu has quit IRC | 06:04 | |
| *** gjayavelu has joined #openstack-nova | 06:05 | |
| *** gongysh has quit IRC | 06:14 | |
| *** armaan has quit IRC | 06:14 | |
| *** armaan has joined #openstack-nova | 06:14 | |
| *** stvnoyes has joined #openstack-nova | 06:15 | |
| *** gjayavelu has quit IRC | 06:16 | |
| *** stvnoyes1 has quit IRC | 06:17 | |
| *** sahid has joined #openstack-nova | 06:17 | |
| *** evin has joined #openstack-nova | 06:18 | |
| *** do3meli has joined #openstack-nova | 06:19 | |
| openstackgerrit | Merged openstack/nova master: Get rid of 406 paths in report client https://review.openstack.org/556633 | 06:19 |
| *** ssurana has joined #openstack-nova | 06:20 | |
| *** sambetts_ is now known as sambetts | 06:21 | |
| *** jaosorior has joined #openstack-nova | 06:21 | |
| *** hshiina2 has joined #openstack-nova | 06:29 | |
| *** hshiina has quit IRC | 06:32 | |
| *** phuongnh has quit IRC | 06:32 | |
| *** phuongnh has joined #openstack-nova | 06:33 | |
| *** liuzz has joined #openstack-nova | 06:35 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:37 | |
| *** liuzz_ has quit IRC | 06:37 | |
| alex_xu | johnthetubaguy_: here is something about policy, want to hear your idea https://review.openstack.org/#/c/554159/ | 06:38 |
| *** yikun_ has joined #openstack-nova | 06:39 | |
| *** yikun has quit IRC | 06:39 | |
| *** evin has quit IRC | 06:43 | |
| *** gongysh has joined #openstack-nova | 06:43 | |
| *** phuongnh has quit IRC | 06:45 | |
| *** mdnadeem has joined #openstack-nova | 06:47 | |
| *** phuongnh has joined #openstack-nova | 06:47 | |
| *** janki has joined #openstack-nova | 06:49 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 06:52 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | 06:52 |
| *** evin has joined #openstack-nova | 06:53 | |
| *** slaweq has joined #openstack-nova | 06:54 | |
| *** tetsuro has joined #openstack-nova | 06:54 | |
| *** ygl has joined #openstack-nova | 06:55 | |
| *** phuongnh has quit IRC | 06:57 | |
| *** AlexeyAbashkin has quit IRC | 06:58 | |
| *** tetsuro has left #openstack-nova | 07:00 | |
| *** tetsuro has joined #openstack-nova | 07:01 | |
| *** phuongnh has joined #openstack-nova | 07:01 | |
| *** armaan has quit IRC | 07:01 | |
| *** armaan has joined #openstack-nova | 07:02 | |
| tetsuro | ^ rebased to avoid merge conflict and to let them be independent from return-all-resources stuff. | 07:02 |
| *** jchhatbar has joined #openstack-nova | 07:09 | |
| *** hshiina2 has quit IRC | 07:10 | |
| *** janki has quit IRC | 07:12 | |
| *** sidx64 has quit IRC | 07:14 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: move version to string in utils https://review.openstack.org/560455 | 07:16 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: refactor get_base_config to accept host arg https://review.openstack.org/560456 | 07:16 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 07:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | 07:17 |
| *** tesseract has joined #openstack-nova | 07:17 | |
| *** alexchadin has joined #openstack-nova | 07:19 | |
| *** sidx64 has joined #openstack-nova | 07:21 | |
| *** ttsiouts has quit IRC | 07:22 | |
| *** ttsiouts has joined #openstack-nova | 07:23 | |
| *** bingqianglin has joined #openstack-nova | 07:24 | |
| *** rcernin has quit IRC | 07:33 | |
| *** namnh_ has joined #openstack-nova | 07:33 | |
| *** dpawlik has joined #openstack-nova | 07:34 | |
| *** namnh has quit IRC | 07:35 | |
| *** damien_r has joined #openstack-nova | 07:35 | |
| *** mdnadeem has quit IRC | 07:36 | |
| *** amoralej|off is now known as amoralej | 07:40 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:41 | |
| *** lajoskatona has quit IRC | 07:41 | |
| *** lpetrut has joined #openstack-nova | 07:41 | |
| *** ygl has left #openstack-nova | 07:41 | |
| *** gcb has joined #openstack-nova | 07:43 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 07:46 |
| *** AlexeyAbashkin has quit IRC | 07:46 | |
| *** bingqianglin has quit IRC | 07:47 | |
| *** bingqianglin has joined #openstack-nova | 07:48 | |
| *** jpena|off is now known as jpena | 07:49 | |
| *** lpetrut has quit IRC | 07:51 | |
| *** namnh_ has quit IRC | 07:53 | |
| *** lajoskatona has joined #openstack-nova | 07:57 | |
| *** sree_ has joined #openstack-nova | 08:01 | |
| *** sree_ is now known as Guest25866 | 08:01 | |
| *** sree has quit IRC | 08:03 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup patch for the cell-disable series https://review.openstack.org/559299 | 08:04 |
| *** hshiina has joined #openstack-nova | 08:07 | |
| *** armaan has quit IRC | 08:07 | |
| *** armaan has joined #openstack-nova | 08:07 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add config drive link to api-guide https://review.openstack.org/561113 | 08:07 |
| *** tssurya has joined #openstack-nova | 08:09 | |
| *** mgoddard has joined #openstack-nova | 08:09 | |
| *** gcb has quit IRC | 08:11 | |
| *** kalyan has quit IRC | 08:12 | |
| *** alexchad_ has joined #openstack-nova | 08:15 | |
| *** ktibi has joined #openstack-nova | 08:16 | |
| *** gcb has joined #openstack-nova | 08:17 | |
| *** lucas-afk is now known as lucasagomes | 08:17 | |
| *** alexchadin has quit IRC | 08:18 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 08:19 |
| *** gcb has quit IRC | 08:21 | |
| *** evin has quit IRC | 08:23 | |
| *** ktibi_ has joined #openstack-nova | 08:23 | |
| *** ktibi_ has quit IRC | 08:23 | |
| *** lajoskatona has quit IRC | 08:23 | |
| *** ktibi_ has joined #openstack-nova | 08:24 | |
| *** Zames has joined #openstack-nova | 08:25 | |
| *** QianYu has joined #openstack-nova | 08:26 | |
| *** ktibi has quit IRC | 08:26 | |
| *** Zames has quit IRC | 08:27 | |
| *** gcb has joined #openstack-nova | 08:28 | |
| *** lpetrut has joined #openstack-nova | 08:28 | |
| *** yamamoto has quit IRC | 08:33 | |
| *** moshele has joined #openstack-nova | 08:34 | |
| *** derekh has joined #openstack-nova | 08:41 | |
| *** gcb has quit IRC | 08:44 | |
| *** yamamoto has joined #openstack-nova | 08:44 | |
| *** gcb has joined #openstack-nova | 08:48 | |
| *** yamamoto has quit IRC | 08:51 | |
| *** moshele has quit IRC | 08:53 | |
| *** lpetrut has quit IRC | 08:54 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | 08:55 |
| *** sar has joined #openstack-nova | 08:57 | |
| *** mdbooth has joined #openstack-nova | 08:59 | |
| *** alexchad_ has quit IRC | 09:00 | |
| *** elmaciej has joined #openstack-nova | 09:02 | |
| *** gcb has quit IRC | 09:02 | |
| *** gcb has joined #openstack-nova | 09:03 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Amend allow abort live migrations in queued status spec https://review.openstack.org/560872 | 09:03 |
| *** tetsuro has left #openstack-nova | 09:04 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/561168 | 09:05 |
| *** QianYu is now known as Roger_ | 09:06 | |
| kashyap | lyarwood: Hmm, forgot for Ocata; thanks :-0 | 09:07 |
| lyarwood | kashyap: np | 09:07 |
| *** ktibi_ is now known as ktibi | 09:07 | |
| kashyap | lyarwood: I actually thought about it; but given where Ocata is, thought upstream would reject it anyway | 09:08 |
| kashyap | But this is a special circumstance, though | 09:08 |
| lyarwood | kashyap: yeah and we have recently changed stable policy FWIW so this is valid | 09:09 |
| *** jogo has quit IRC | 09:10 | |
| kashyap | lyarwood: Got a link to the policy? | 09:10 |
| *** hshiina has quit IRC | 09:11 | |
| lyarwood | kashyap: https://docs.openstack.org/project-team-guide/stable-branches.html | 09:11 |
| kashyap | Thanks. | 09:12 |
| *** pcaruana has joined #openstack-nova | 09:12 | |
| *** ralonsoh has joined #openstack-nova | 09:14 | |
| *** jogo has joined #openstack-nova | 09:14 | |
| *** sdague has joined #openstack-nova | 09:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 09:14 |
| *** liusheng has quit IRC | 09:18 | |
| *** liusheng has joined #openstack-nova | 09:18 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201 | 09:25 |
| *** sridharg has quit IRC | 09:29 | |
| *** udesale_ has joined #openstack-nova | 09:30 | |
| *** gcb has quit IRC | 09:31 | |
| *** ssurana has quit IRC | 09:31 | |
| *** liuzz has quit IRC | 09:32 | |
| takashin | Core reviwers, would you review https://review.openstack.org/#/c/561121/ ? It is a temporaly fix for gate failure ( https://bugs.launchpad.net/nova/+bug/1763535 ) . | 09:33 |
| openstack | Launchpad bug 1763535 in OpenStack Compute (nova) "nova.tests.unit.virt.xenapi.test_vm_utils.StreamDiskTestCase.test_non_ami intermittently fails" [High,Confirmed] | 09:33 |
| *** udesale has quit IRC | 09:33 | |
| stephenfin | takashin: You've no idea what's causing that, I assume? | 09:36 |
| takashin | stephenfin: I have no ideas. | 09:37 |
| takashin | stephenfin: I could not reproduce failure in my local environment. | 09:37 |
| sapd_ | gmann: I think this is a important feature when want to create instance use volume based instead of create volume after launch instance | 09:37 |
| *** mdbooth has quit IRC | 09:37 | |
| *** mdbooth has joined #openstack-nova | 09:38 | |
| *** sridharg has joined #openstack-nova | 09:38 | |
| *** tojuvone has quit IRC | 09:38 | |
| stephenfin | takashin: I'm guessing there's some kind of race going on. Let me see if I can reproduce quickly | 09:38 |
| takashin | stephenfin: Thank you. | 09:39 |
| sahid | stephenfin: can you re-ACK 2 first patches here: https://review.openstack.org/#/c/560455/? | 09:41 |
| sahid | they lost the bit because of a rebase | 09:41 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 09:43 |
| *** xinliang has quit IRC | 09:45 | |
| *** gcb has joined #openstack-nova | 09:45 | |
| *** takashin has left #openstack-nova | 09:46 | |
| *** Tom-Tom has quit IRC | 09:49 | |
| *** armaan has quit IRC | 09:55 | |
| *** xinliang has joined #openstack-nova | 09:57 | |
| *** xinliang has quit IRC | 09:57 | |
| *** xinliang has joined #openstack-nova | 09:57 | |
| *** elmaciej has quit IRC | 09:59 | |
| *** _ix has joined #openstack-nova | 09:59 | |
| *** elmaciej has joined #openstack-nova | 10:00 | |
| *** Roger_ has quit IRC | 10:00 | |
| *** elmaciej_ has joined #openstack-nova | 10:03 | |
| *** _ix_ has joined #openstack-nova | 10:04 | |
| *** _ix has quit IRC | 10:05 | |
| *** elmaciej has quit IRC | 10:05 | |
| *** gaoyan has quit IRC | 10:05 | |
| *** jichen has quit IRC | 10:11 | |
| *** Guest25866 has quit IRC | 10:12 | |
| *** sree has joined #openstack-nova | 10:12 | |
| *** hoangcx has quit IRC | 10:13 | |
| *** phuongnh has quit IRC | 10:14 | |
| *** sree has quit IRC | 10:16 | |
| *** caisan has quit IRC | 10:17 | |
| *** elmaciej_ has quit IRC | 10:17 | |
| *** elmaciej has joined #openstack-nova | 10:19 | |
| *** gongysh has quit IRC | 10:23 | |
| *** lpetrut has joined #openstack-nova | 10:27 | |
| *** annp has quit IRC | 10:29 | |
| *** nicolasbock has joined #openstack-nova | 10:31 | |
| *** chenyb4 has quit IRC | 10:36 | |
| *** bingqianglin has quit IRC | 10:38 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Fix how context managers are mocked https://review.openstack.org/561190 | 10:39 |
| stephenfin | takashin: That should do the trick ^ | 10:39 |
| openstackgerrit | Merged openstack/nova master: only increment disk address unit for scsi devices https://review.openstack.org/538310 | 10:42 |
| *** udesale__ has joined #openstack-nova | 10:42 | |
| *** diga has quit IRC | 10:43 | |
| *** _ix_ has quit IRC | 10:44 | |
| *** oanson has quit IRC | 10:44 | |
| *** udesale_ has quit IRC | 10:45 | |
| openstackgerrit | Merged openstack/nova master: trivial: fix a comment typo https://review.openstack.org/560349 | 10:47 |
| kashyap | I wonder if Gerrit can be tweaked to retain the +2 post-rebase | 10:49 |
| kashyap | (Post-successful rebase) | 10:49 |
| odyssey4me | kashyap it already does, assuming the only thing changing in the rebase is the parent commit and date/time | 10:50 |
| *** _ix has joined #openstack-nova | 10:50 | |
| kashyap | lyarwood: Seems like 'pep8' failures on that Ocata backport; will look post meetings | 10:51 |
| kashyap | odyssey4me: Ah, I meant +W | 10:51 |
| lyarwood | kashyap: yeah sorting it out now | 10:51 |
| odyssey4me | ah no, workflow is lost | 10:51 |
| *** xinliang has quit IRC | 10:51 | |
| *** stakeda has quit IRC | 10:52 | |
| *** cdent has joined #openstack-nova | 10:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/561168 | 10:57 |
| lyarwood | kashyap: ^ just a missing _LW | 10:57 |
| *** alexchadin has joined #openstack-nova | 10:58 | |
| kashyap | lyarwood: Ah-ha; /me quickly takes a peek | 10:58 |
| *** abhishekk has quit IRC | 10:58 | |
| *** rodolof has joined #openstack-nova | 11:02 | |
| *** lpetrut has quit IRC | 11:04 | |
| *** xinliang has joined #openstack-nova | 11:05 | |
| *** bhagyashris has quit IRC | 11:05 | |
| *** pooja_jadhav has quit IRC | 11:05 | |
| *** Shilpa has quit IRC | 11:05 | |
| *** pooja_jadhav has joined #openstack-nova | 11:06 | |
| *** Shilpa has joined #openstack-nova | 11:06 | |
| *** bhagyashris has joined #openstack-nova | 11:06 | |
| *** tiendc has quit IRC | 11:07 | |
| openstackgerrit | sahid proposed openstack/nova stable/queens: only increment disk address unit for scsi devices https://review.openstack.org/561196 | 11:08 |
| *** ccamacho is now known as ccamacho|hungy | 11:10 | |
| *** dave-mccowan has joined #openstack-nova | 11:17 | |
| *** armaan has joined #openstack-nova | 11:17 | |
| *** vivsoni has quit IRC | 11:19 | |
| *** rodolof has quit IRC | 11:24 | |
| *** rodolof has joined #openstack-nova | 11:25 | |
| *** lucasagomes is now known as lucas-hungry | 11:27 | |
| *** udesale_ has joined #openstack-nova | 11:30 | |
| *** damien_r has quit IRC | 11:30 | |
| *** udesale__ has quit IRC | 11:32 | |
| *** cdent has quit IRC | 11:33 | |
| *** udesale_ has quit IRC | 11:35 | |
| *** lpetrut has joined #openstack-nova | 11:40 | |
| *** jpena is now known as jpena|lunch | 11:41 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Record the host info in EventReporter https://review.openstack.org/556746 | 11:47 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract generate_hostid method into utils.py https://review.openstack.org/555282 | 11:47 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 11:47 |
| *** sar has quit IRC | 11:47 | |
| *** damien_r has joined #openstack-nova | 11:48 | |
| *** salv-orlando has quit IRC | 11:48 | |
| *** salv-orlando has joined #openstack-nova | 11:49 | |
| *** aloga has quit IRC | 11:49 | |
| *** aloga has joined #openstack-nova | 11:50 | |
| *** salv-orlando has quit IRC | 11:53 | |
| *** bhujay has joined #openstack-nova | 11:53 | |
| *** Roger_ has joined #openstack-nova | 11:55 | |
| *** armaan has quit IRC | 11:57 | |
| *** sar has joined #openstack-nova | 11:58 | |
| *** armaan has joined #openstack-nova | 11:59 | |
| *** Roger_ has quit IRC | 12:00 | |
| *** salv-orlando has joined #openstack-nova | 12:02 | |
| sahid | dansmith: in case you have a moment to look at this today https://review.openstack.org/#/c/484997/ | 12:03 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nits in Idf57fb5fbc611abb83943bd7e36d3cebf03b3977 https://review.openstack.org/561205 | 12:14 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nits in Idf57fb5fbc611abb83943bd7e36d3cebf03b3977 https://review.openstack.org/561205 | 12:15 |
| *** ccamacho|hungy is now known as ccamacho | 12:17 | |
| *** liverpooler has joined #openstack-nova | 12:20 | |
| bhujay | Hello everybody , would be grateful if someone can give me a hint why my openstack environment timestamp is not showing localtime that is set in operating system /etc/timezone | 12:23 |
| bhujay | nova vm create , key create or any such creation date is showing utc time and i cant figure out how to change this to localtime | 12:24 |
| *** edleafe is now known as figleaf | 12:26 | |
| *** cdent has joined #openstack-nova | 12:26 | |
| *** armaan has quit IRC | 12:26 | |
| *** lucas-hungry is now known as lucasagomes | 12:27 | |
| *** _ix has quit IRC | 12:29 | |
| *** jpena|lunch is now known as jpena | 12:29 | |
| *** alexchadin has quit IRC | 12:31 | |
| *** eharney has joined #openstack-nova | 12:34 | |
| *** alexchadin has joined #openstack-nova | 12:35 | |
| *** gcb has quit IRC | 12:36 | |
| *** pchavva has joined #openstack-nova | 12:38 | |
| *** gaoyan has joined #openstack-nova | 12:41 | |
| *** gaoyan has quit IRC | 12:42 | |
| *** edmondsw_ has joined #openstack-nova | 12:46 | |
| *** Roger_ has joined #openstack-nova | 12:47 | |
| *** edmonds__ has joined #openstack-nova | 12:47 | |
| *** ratailor has quit IRC | 12:49 | |
| *** gaoyan has joined #openstack-nova | 12:49 | |
| *** xinliang has quit IRC | 12:49 | |
| *** damien_r has left #openstack-nova | 12:49 | |
| *** edmondsw has quit IRC | 12:50 | |
| *** xinliang has joined #openstack-nova | 12:50 | |
| *** edmondsw_ has quit IRC | 12:51 | |
| *** chenyb4 has joined #openstack-nova | 12:51 | |
| *** udesale has joined #openstack-nova | 12:53 | |
| *** edmondsw has joined #openstack-nova | 12:54 | |
| *** efried is now known as fried_rice | 12:55 | |
| *** jmlowe has joined #openstack-nova | 12:55 | |
| fried_rice | ö/ | 12:55 |
| *** edmondsw_ has joined #openstack-nova | 12:56 | |
| *** edmonds__ has quit IRC | 12:56 | |
| *** mchlumsky has joined #openstack-nova | 12:57 | |
| *** jmlowe_ has quit IRC | 12:58 | |
| fried_rice | stephenfin: is https://review.openstack.org/561190 intended to fix test_non_ami? | 12:59 |
| fried_rice | (Which is French for "No, friend") | 12:59 |
| stephenfin | fried_rice: That's the intention, yup | 12:59 |
| *** edmondsw has quit IRC | 12:59 | |
| *** stephenfin is now known as finucannot | 12:59 | |
| *** pchavva has quit IRC | 13:00 | |
| *** amoralej is now known as amoralej|lunch | 13:02 | |
| *** psachin has quit IRC | 13:02 | |
| fried_rice | finucannot: +A (which is French for "Oui, ami") | 13:04 |
| *** jaypipes is now known as leakypipes | 13:05 | |
| *** Tom-Tom has joined #openstack-nova | 13:07 | |
| *** r-daneel has quit IRC | 13:09 | |
| *** Tom-Tom has quit IRC | 13:12 | |
| *** pchavva has joined #openstack-nova | 13:17 | |
| *** mriedem has joined #openstack-nova | 13:18 | |
| *** chenyb4 has quit IRC | 13:18 | |
| Spaz-Home | Happy friday folks.. time for me to call it an ight | 13:22 |
| *** Roger_ has quit IRC | 13:23 | |
| *** salv-orlando has quit IRC | 13:24 | |
| *** salv-orlando has joined #openstack-nova | 13:24 | |
| *** jaosorior has quit IRC | 13:27 | |
| *** Roger_ has joined #openstack-nova | 13:27 | |
| *** felipemonteiro_ has joined #openstack-nova | 13:28 | |
| *** salv-orlando has quit IRC | 13:28 | |
| *** alexchadin has quit IRC | 13:29 | |
| *** sar has quit IRC | 13:29 | |
| *** r-daneel has joined #openstack-nova | 13:30 | |
| *** dansmith is now known as superdan | 13:31 | |
| *** caisan has joined #openstack-nova | 13:31 | |
| *** mchlumsky has quit IRC | 13:33 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/559987 | 13:34 |
| *** alexchadin has joined #openstack-nova | 13:34 | |
| *** mlavalle has joined #openstack-nova | 13:34 | |
| *** mchlumsky has joined #openstack-nova | 13:35 | |
| *** lbragstad has joined #openstack-nova | 13:36 | |
| *** edmondsw_ is now known as edmondsw | 13:39 | |
| *** Roger_ has quit IRC | 13:40 | |
| mriedem | finucannot: thanks for https://review.openstack.org/#/c/561190/ | 13:42 |
| finucannot | mriedem: np | 13:44 |
| *** hoonetorg has quit IRC | 13:48 | |
| *** Roger_ has joined #openstack-nova | 13:49 | |
| *** caisan_ has joined #openstack-nova | 13:50 | |
| *** caisan has quit IRC | 13:50 | |
| *** amoralej|lunch is now known as amoralej | 13:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup API guide about instance faults https://review.openstack.org/560178 | 13:52 |
| *** _ix has joined #openstack-nova | 13:53 | |
| mriedem | that would have been merged by now except with the zuulv3 reswizzle on irrelevant_files we're running tempest jobs on unit test only changes still | 13:54 |
| *** awaugama has joined #openstack-nova | 13:55 | |
| mriedem | finucannot: can't we define our own nova-tox-py27 and then define our own irrelevant-files list? | 13:55 |
| mriedem | gmann: ^? | 13:55 |
| mriedem | i remember gibi asking about this in the ML | 13:55 |
| finucannot | mriedem: IIRC, we can't override the global state | 13:56 |
| finucannot | for that one anyway | 13:56 |
| mriedem | we can't just define our own job that doesn't extend openstack-tox-py27? | 13:57 |
| mriedem | like, copy openstack-tox-py27 and tweak but not extend | 13:57 |
| finucannot | Ohh, I guess we could do that, yeah | 13:57 |
| *** cdent has quit IRC | 13:58 | |
| finucannot | I think openstack-tox-py27 is run by default though. I'm not sure how/if we can disable that | 13:58 |
| mriedem | it's run because of the "openstack-python-jobs" usage in project-config | 13:59 |
| finucannot | i.e. it's defined in openstack/project-config or the likes | 13:59 |
| finucannot | yup | 13:59 |
| mriedem | which runs: | 13:59 |
| finucannot | *openstack-infra/project-config | 13:59 |
| mriedem | - openstack-tox-pep8 | 13:59 |
| mriedem | - openstack-tox-py27 | 13:59 |
| *** Roger_ has quit IRC | 13:59 | |
| *** esberglu has joined #openstack-nova | 14:00 | |
| mriedem | yeah so if we defined our own job, we'd have to list openstack-tox-pep8 in our own .zuul.yaml along with nova-tox-py27, but that seems ok, | 14:00 |
| mriedem | and we'd have to backport it to all stable branches before removing the template usage from project-config | 14:00 |
| mriedem | trivial but time consuming | 14:00 |
| finucannot | Hmm. Can zuulv3 not support this use case? | 14:01 |
| mriedem | i don't know why you can't extend an existing job and override attributes of it, like irrelevant-files | 14:01 |
| mriedem | if we could do that, we'd be set | 14:01 |
| finucannot | That sounds like a more effective use of time, if we can do it. I wonder if mordred is around? | 14:02 |
| mriedem | i'm asking again in -infra, | 14:02 |
| mriedem | but last time this came up there were lots of words in the ML | 14:02 |
| mriedem | my head exploded, and i moved on | 14:02 |
| *** sidx64 has quit IRC | 14:03 | |
| *** alexchadin has quit IRC | 14:03 | |
| mriedem | just sucks that we have to wait 2+ hours for a 15 min job | 14:03 |
| mriedem | heh, maybe i should be asking, why is this taking nearly 2 hours | 14:04 |
| mriedem | tempest-full-py3SUCCESS in 1h 50m 17s | 14:04 |
| fried_rice | mriedem: How long does it take when you run it locally? Did you say you can run the whole thing in 15m? | 14:04 |
| mriedem | fried_rice: i just mean the unit test job takes 15 minutes | 14:05 |
| *** archit has joined #openstack-nova | 14:05 | |
| mriedem | and that's all we care about in this unit test only patch | 14:05 |
| fried_rice | ah, I see. | 14:05 |
| fried_rice | Well, I know I've seen special cases where what you've changed influences which jobs are run. | 14:05 |
| fried_rice | Can't remember specifically for sure, but I think e.g. if you only change docs, only docs jobs are run. | 14:05 |
| fried_rice | So there's a precedent for it. | 14:06 |
| mriedem | yes that's how things used to all work when the jobs were centralized in project-config, pre-zuulv3 | 14:06 |
| mriedem | looking at http://logs.openstack.org/90/561190/1/check/tempest-full-py3/41adeca/controller/logs/stackviz/#/stdin/timeline some of the tempest tests are taking over 7 minutes | 14:06 |
| mriedem | maybe that's all related to meltdown/spectre fallout... | 14:07 |
| mriedem | slow nodes | 14:07 |
| mriedem | alright, i'll take my cup o coffee and go back into my old man hole now | 14:07 |
| *** zhaochao has quit IRC | 14:08 | |
| *** armaan has joined #openstack-nova | 14:10 | |
| *** archit has quit IRC | 14:11 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:16 | |
| *** rajinir has joined #openstack-nova | 14:17 | |
| *** felipemonteiro_ has quit IRC | 14:19 | |
| *** sahid has quit IRC | 14:20 | |
| *** bnemec is now known as beekneemech | 14:23 | |
| *** Spazmotic has quit IRC | 14:23 | |
| *** Roger_ has joined #openstack-nova | 14:24 | |
| *** felipemonteiro__ has quit IRC | 14:25 | |
| mordred | finucannot: uhoh | 14:25 |
| mordred | finucannot: what did I do this time? | 14:25 |
| mriedem | alex_xu: bauzas: per https://review.openstack.org/#/c/554159/ - this is doing the same thing that 2.47 does with showing embedded flavors with extra specs in GET /servers/{server_id} | 14:26 |
| *** felipemonteiro__ has joined #openstack-nova | 14:26 | |
| *** Spazmotic has joined #openstack-nova | 14:26 | |
| fried_rice | mordred: Da boyz were noodling whether/how we could make certain jobs conditional. | 14:26 |
| finucannot | mordred: It's mriedem you've to worry about. He's mad about not being able to override 'irrelevant-files' on our tox-py27 job | 14:27 |
| *** lyan has joined #openstack-nova | 14:27 | |
| fried_rice | mordred: E.g. https://review.openstack.org/#/c/561190/ changed only a UT file, so it would be nice if we didn't bother running all the tempest suites, and we could merge the sucker in 15 minutes instead of 2h. | 14:27 |
| *** lyan is now known as Guest78769 | 14:27 | |
| mordred | totallly understand | 14:27 |
| bauzas | mriedem: so it's using a same policy rule for that ? | 14:27 |
| mriedem | bauzas: see my reply to alex_xu in https://review.openstack.org/#/c/554159/ just now | 14:28 |
| bauzas | lemme check the code but I need to disappear in like 2 mins | 14:28 |
| bauzas | mriedem: okay, lemme change my vote, but it'll require a docfix | 14:29 |
| bauzas | that's the other option I had in mind, so it was a soft -1 | 14:29 |
| mordred | I would actually think that just adding a nova-specific openstack-tox-py35 variant with some additional irrelevant-files added would work | 14:29 |
| mordred | I'm assuming y'all have tried that already? | 14:29 |
| bauzas | mriedem: +W'd with a comment asking for a followup | 14:30 |
| mriedem | bauzas: thanks | 14:32 |
| mriedem | i replied to more of the inline stuff too | 14:33 |
| *** germs has quit IRC | 14:35 | |
| * bauzas disappears | 14:35 | |
| *** germs has joined #openstack-nova | 14:35 | |
| *** germs has quit IRC | 14:35 | |
| *** germs has joined #openstack-nova | 14:35 | |
| *** psachin has joined #openstack-nova | 14:36 | |
| *** READ10 has joined #openstack-nova | 14:37 | |
| mriedem | mordred: already talked about that above, and the implications of doing so | 14:38 |
| mriedem | mordred: tl;dr is i know it's trivial to do, just time consuming | 14:39 |
| mriedem | given backports to stable and changes to project-config | 14:39 |
| *** sar has joined #openstack-nova | 14:39 | |
| mriedem | it would help e-r to have project-specific tox jobs again http://status.openstack.org/elastic-recheck/data/integrated_gate.html#openstack-tox-py35 | 14:39 |
| *** elmaciej has quit IRC | 14:39 | |
| *** tssurya has quit IRC | 14:40 | |
| *** Roger_ has quit IRC | 14:41 | |
| *** Roger_ has joined #openstack-nova | 14:41 | |
| Shilpa | mriedem: Hi, i was going thorugh https://review.openstack.org/#/c/511965/1 >> Spec for volume-backed flavors, any reason why workflow is -1 here | 14:42 |
| mordred | mriedem: I tink we're collecting enough metadata so that elastic recheck could know job + project - we sohuld probably update it to use the data | 14:43 |
| *** elmaciej has joined #openstack-nova | 14:44 | |
| *** idlemind has joined #openstack-nova | 14:44 | |
| *** AlexeyAbashkin has joined #openstack-nova | 14:45 | |
| mriedem | Shilpa: because it's complicated and mostly a brain dump to docs for something we've talked about sporadically when we have meetups (PTG, Forum, etc) | 14:46 |
| mriedem | it's not something i'm actively pursuing for Rocky | 14:46 |
| leakypipes | mriedem, mdbooth, superdan: so, question coming from one of our ops teams... is it possible to (live) migrate from a host using ceph for ephemeral disk storage to a host that uses local disk storage (this is temporarily during an upgrade procedure) | 14:47 |
| superdan | leakypipes: with block migration maybe | 14:47 |
| superdan | I'm not an expert there, I'd ask mdbooth when he gets off a call in 13 mins | 14:48 |
| leakypipes | superdan: cool, thx | 14:48 |
| superdan | leakypipes: also please see channel topic | 14:48 |
| mriedem | it's going from an ephemeral ceph to a non-ceph ephemeral? | 14:48 |
| Shilpa | mriedem: ok, one more thing pl confirm, specs not talikng @ to have root_gb=0 for flavor `volume_backed=True` | 14:48 |
| mriedem | i know our live migration job tests ceph with ephemeral imagebackend and with volume-backed | 14:49 |
| mriedem | but it's ceph on both sides, not changing image types for the ephemeral case | 14:49 |
| mriedem | Shilpa: can you rephrase the question? | 14:49 |
| *** gaoyan has quit IRC | 14:49 | |
| *** AlexeyAbashkin has quit IRC | 14:49 | |
| melwitt | mriedem, superdan, leakypipes: just remembered we need to propose forum topics today (deadline is sunday april 15) https://etherpad.openstack.org/p/YVR-nova-brainstorming | 14:50 |
| *** openstackgerrit has quit IRC | 14:50 | |
| melwitt | I see cdent already proposed a couple of placement-related ones | 14:50 |
| superdan | mdbooth: I added a thing in there | 14:50 |
| leakypipes | melwitt: ack. (I won't be at the forum, but will try to add items) | 14:51 |
| mriedem | Shilpa: based on https://review.openstack.org/#/c/511965/1/specs/queens/approved/volume-backed-flavors.rst@74 - you couldn't have volume_backed=True and root_gb=0 | 14:51 |
| mriedem | because that would result in creating a 0gb vlume | 14:51 |
| mriedem | *volume | 14:51 |
| melwitt | leakypipes: :( to not being there, k thanks | 14:51 |
| mriedem | which i'm pretty sure cinder doesn't allow, volumes have to be at least size>=1 | 14:51 |
| Shilpa | mriedem: actually root_gb should be 0 for volume-backed instances (LP bug https://bugs.launchpad.net/nova/+bug/1469179), so here in specs we are marking ``volume_backed=True` for volume-backed instance | 14:51 |
| openstack | Launchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Dan Smith (danms) | 14:51 |
| leakypipes | melwitt: a certain money-lending institution isn't getting their Friday dues. | 14:53 |
| melwitt | lol | 14:53 |
| mriedem | Shilpa: then i think you're looking for https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged) | 14:53 |
| *** melwitt is now known as jgwentworth | 14:53 | |
| leakypipes | there she is :) | 14:53 |
| *** germs has quit IRC | 14:53 | |
| mriedem | Shilpa: feel free to comment on the spec as a reminder, but as noted, it's not something i'm actively pursuing | 14:54 |
| *** germs has joined #openstack-nova | 14:54 | |
| Shilpa | mriedem: yes iam looking for https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged) , is spec resolves this? | 14:56 |
| *** links has quit IRC | 14:58 | |
| *** germs has quit IRC | 14:58 | |
| *** amodi has joined #openstack-nova | 14:59 | |
| *** germs has joined #openstack-nova | 14:59 | |
| *** germs has quit IRC | 14:59 | |
| *** germs has joined #openstack-nova | 14:59 | |
| mriedem | Shilpa: no, it's unrelated | 14:59 |
| mriedem | Shilpa: think of that spec basically like the 'get me a network' feature in the 2.37 microversion, but like 'get me a volume-backed instance' | 15:00 |
| mriedem | simply the bdm_v2 stuff the user has to do | 15:00 |
| mriedem | *simplify | 15:00 |
| mriedem | and allow operators to easily define volume-backed flavors globally | 15:00 |
| *** rodolof has quit IRC | 15:00 | |
| mriedem | Shilpa: btw, root_gb=0 doesn't mean volume-backed per se, https://developer.openstack.org/api-ref/compute/#create-flavor | 15:01 |
| mriedem | "The size of the root disk that will be created in GiB. If 0 the root disk will be set to exactly the size of the image used to deploy the instance. However, in this case filter scheduler cannot select the compute host based on the virtual image size. Therefore, 0 should only be used for volume booted instances or for testing purposes." | 15:01 |
| mriedem | root_gb=0 and server.image_id = '' would definitely indicate volume-backed | 15:02 |
| jgwentworth | oh, that reminds me of a bug I wanted to ask people about | 15:02 |
| *** amodi has quit IRC | 15:03 | |
| mriedem | superdan: heh you'll like this https://bugs.launchpad.net/nova/+bug/1763039 | 15:03 |
| openstack | Launchpad bug 1763039 in OpenStack Compute (nova) "evacuate instance documentation not mentioning host-evacuate" [Undecided,New] | 15:03 |
| jgwentworth | this one, issues with 0 GB disk flavor + image-based instance https://bugs.launchpad.net/nova/+bug/1758278 | 15:04 |
| openstack | Launchpad bug 1758278 in OpenStack Compute (nova) "disk_available_least become a negative value unexpectedly" [Undecided,New] | 15:04 |
| *** germs has quit IRC | 15:04 | |
| superdan | mriedem: guh | 15:05 |
| mriedem | jgwentworth: i think that might be a duplicate of one that mnaser reported, looking | 15:05 |
| *** felipemonteiro_ has joined #openstack-nova | 15:05 | |
| jgwentworth | does anyone understand that? ^ I keep getting confused about what actually happens when you do image-based + 0 GB disk | 15:05 |
| corvus | mriedem: how about you just stop using the template that adds the unit test jobs and just add them to your project stanza in repo with your own irrelevant file matchers. done. | 15:05 |
| mriedem | corvus: that's what i said we could do above | 15:06 |
| jgwentworth | mriedem: I saw that too a second ago and wondered if it's the same thing | 15:06 |
| corvus | mriedem: i missed what's complicated about that | 15:06 |
| mriedem | corvus: it's not complicated, | 15:07 |
| corvus | ok i'm poor at reading scrollback :) | 15:07 |
| *** openstackgerrit has joined #openstack-nova | 15:07 | |
| openstackgerrit | Merged openstack/nova master: tests: Fix how context managers are mocked https://review.openstack.org/561190 | 15:07 |
| mriedem | it's just we also have to backport that to all stable branches before we can remove the openstack-python-jobs template usage from project-config | 15:07 |
| mriedem | again, not complicated, just tedious | 15:07 |
| openstackgerrit | Merged openstack/nova master: Update link of metadata https://review.openstack.org/561114 | 15:07 |
| *** amodi has joined #openstack-nova | 15:07 | |
| corvus | mriedem: okay, yeah. maybe worth the effort though? :) it's a one-time cost. | 15:08 |
| *** felipemonteiro__ has quit IRC | 15:09 | |
| Shilpa | mriedem: thank you for clarification, earlier thought that volume-backed flavors spec and https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged) has relation. | 15:09 |
| *** READ10 has quit IRC | 15:10 | |
| corvus | mriedem: we did come up with some ways of maybe doing something sensible with irrelevant-files and project-templates, but it's probably going to be a while till we can implement them. | 15:10 |
| *** Roger_ has quit IRC | 15:12 | |
| *** pcaruana has quit IRC | 15:12 | |
| *** sahid has joined #openstack-nova | 15:12 | |
| *** slaweq has quit IRC | 15:12 | |
| *** amodi has quit IRC | 15:13 | |
| mriedem | corvus: yeah, i've likely already spent more time complaining about this than what it would take to just fix it | 15:14 |
| *** dpawlik has quit IRC | 15:17 | |
| mdbooth | leakypipes superdan: re live migration non-ceph->ceph there's no fundamental reason it can't work that I can think of. As was mentioned, though, it's not tested, so it's probably broken for reasons I can't think of, which are probably fixable. | 15:18 |
| openstackgerrit | Merged openstack/nova master: Test case: ResourceClass.normalize_name with ß https://review.openstack.org/560092 | 15:19 |
| superdan | I would assume that our driver probably tries to do smart things assuming it is shared, which might defeat other things like block migration if it doesn't account for the possibility | 15:19 |
| *** slaweq has joined #openstack-nova | 15:19 | |
| mriedem | live migration should try to see if it can talk to the dest host over a shared filesystem though, | 15:20 |
| mriedem | which if you're going ceph to non-ceph, will say you can't do that | 15:20 |
| mriedem | so block migration would be required | 15:20 |
| mdbooth | I think the shared test is only for shared instance directory | 15:21 |
| superdan | right | 15:21 |
| mdbooth | The shared block iirc is in imagebackend at the class level | 15:21 |
| mdbooth | So super-hacky | 15:21 |
| openstackgerrit | Merged openstack/nova master: Make ResourceClass.normalize_name handle sharp S https://review.openstack.org/560093 | 15:21 |
| mdbooth | So yeah, that could potentially break it. | 15:21 |
| mdbooth | But fundamentally, if we wired it up correctly there's no reason you can't block migration from non-ceph to ceph, or vice versa. | 15:22 |
| mriedem | right i think it should work, | 15:22 |
| mriedem | but there are probably assumptions in the code | 15:22 |
| superdan | yep and that's what I'm saying | 15:22 |
| *** amodi has joined #openstack-nova | 15:22 | |
| superdan | I bet it doesn't work.. for stupid reasons | 15:22 |
| mriedem | this is where i'd look https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L80 | 15:23 |
| mriedem | that updates the guest xml on the source host, but updates the xml intended for the dest host | 15:23 |
| leakypipes | well, they're going to test it. I'll let you know if/what blows up :) | 15:23 |
| mriedem | nothing in ^ indicates it cares about non-volume disks | 15:23 |
| mriedem | this would be the other place to look https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7562 | 15:24 |
| mriedem | run on the dest, get the info to pass back to the source to tell it how to migrate it | 15:24 |
| *** Roger_ has joined #openstack-nova | 15:25 | |
| *** salv-orlando has joined #openstack-nova | 15:26 | |
| * mnaser reads buffer | 15:27 | |
| mdbooth | mriedem: Yeah, that's broken for at least the first reason (disk xml isn't updated) | 15:27 |
| *** amodi has quit IRC | 15:28 | |
| *** Roger_ has quit IRC | 15:29 | |
| openstackgerrit | Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | 15:29 |
| *** slaweq has quit IRC | 15:30 | |
| mriedem | corvus: finucannot: mordred: heh now i realize the flaw in my logic - the problem isn't in defining our own py27 job for unit tests, | 15:30 |
| mdbooth | mriedem: This came up today: https://review.openstack.org/#/c/533249/ tl;dr support for ip_allocation='none'. By any chance are you aware of any other existing work on this? | 15:30 |
| mriedem | it's that the tempest-full jobs get run on unit test-only patches in nova | 15:30 |
| superdan | kashyap: finucannot: do you guys understand the vhostuser override stuff in this? https://review.openstack.org/#/c/484997/16/nova/virt/libvirt/vif.py line 171 | 15:30 |
| mriedem | so we'd have to write our own tempest-full... | 15:30 |
| mriedem | mdbooth: yes, carl_baldwin added that in newton | 15:31 |
| *** salv-orlando has quit IRC | 15:31 | |
| mdbooth | mriedem: That was ip_allocation='deferred' | 15:31 |
| mriedem | mdbooth: https://blueprints.launchpad.net/nova/+spec/neutron-routed-networks | 15:31 |
| mriedem | oh | 15:31 |
| corvus | mriedem: wait, no don't write your own unit test or tempest jobs | 15:31 |
| *** Shilpa has quit IRC | 15:31 | |
| mdbooth | mriedem: This is for when the user literally never wants an ip | 15:31 |
| corvus | mriedem: when you attach a job to a project, you can specify the irrelevant files. so if you do that in-repo, as opposed to using the templates, you can specify your own irrelevant files. | 15:32 |
| cfriesen | leakypipes: try it and see? :) | 15:32 |
| mriedem | mdbooth: then they should use networks='none' with 2.37 | 15:32 |
| leakypipes | cfriesen: yeah, they are :) | 15:32 |
| mdbooth | Can they still attach the port without an ip? | 15:33 |
| leakypipes | will report back with my findings from the field. | 15:33 |
| mriedem | corvus: i think nova gets tempest-full via the integrated-gate template https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L10316 | 15:33 |
| corvus | mriedem: (the complication is that andreaf would like you to please use the project template for tempest jobs for the time being so can can adjust it centrally. so until we come up with a way to support overriding the matchers of a project-template in-repo, we have to choose between local or central control) | 15:33 |
| mriedem | right, | 15:34 |
| *** andreas_s has quit IRC | 15:34 | |
| mriedem | so i'm not sure if nova would have to drop using the integrated-gate template or what | 15:34 |
| andreaf | mriedem yeah that's the conclusion we came to at the PTG | 15:35 |
| corvus | mriedem: yes. options are: drop that template and add the jobs it has directly; or wait until i (or someone) can get around to implementing some way to alter the irrelevant-files matchers on jobs in that template in your repo (probably wont happen for weeks at least) | 15:35 |
| mriedem | i choose not to make a choice, like geddy said | 15:36 |
| mriedem | https://www.youtube.com/watch?v=hX9VGUaIpds | 15:37 |
| mriedem | where are all my rush fans?! | 15:37 |
| *** salv-orlando has joined #openstack-nova | 15:37 | |
| mriedem | cfriesen: surely you ^ | 15:37 |
| corvus | everone take the day off and listen to rush | 15:37 |
| jgwentworth | geddy, I wonder if he speaks like an ordinary guy | 15:38 |
| *** Roger_ has joined #openstack-nova | 15:38 | |
| leakypipes | cfriesen: ? for you on https://bugs.launchpad.net/nova/+bug/1750623 | 15:39 |
| openstack | Launchpad bug 1750623 in OpenStack Compute (nova) queens "rebuild to same host with different image shouldn't check with placement" [Medium,In progress] - Assigned to Hongbin Lu (hongbin.lu) | 15:39 |
| cfriesen | mriedem: I don't think you can avoid it up here. :) | 15:40 |
| mdbooth | mriedem: Just reading the get-me-a-network stuff. I think networks='none' is different. They *do* want to attach the port to a network, it's just that the network has no subnets, will never be associated with an IP, and therefore can't have a security group (iiuc). | 15:40 |
| cfriesen | leakypipes: yes? | 15:40 |
| cfriesen | leakypipes: ah, checking. | 15:41 |
| mdbooth | mriedem: Don't worry if it doesn't ring any bells, btw. Just wanted to check if you knew of any work going on in this area other than the above review. | 15:41 |
| *** cdent has joined #openstack-nova | 15:42 | |
| *** Roger_ has quit IRC | 15:43 | |
| *** beekneemech has quit IRC | 15:45 | |
| cfriesen | leakypipes: yep, good catch. that just opened a huge can of worms I think. | 15:46 |
| *** armaan has quit IRC | 15:46 | |
| leakypipes | cfriesen: well, shit. I didn't intend it to. :) | 15:46 |
| leakypipes | cfriesen: you mean *more* than the can of worms that rebuild already is? ;) | 15:46 |
| mriedem | leakypipes: we still run the new image through the image properties filter and numa topology filter | 15:47 |
| mriedem | but we won't claim on the compute, in the case of numa | 15:47 |
| cfriesen | mriedem: yeah, but if the numa topology changes then placement allocations need to change | 15:47 |
| mriedem | so we probably need some filter that says you can't rebuild with a new image that has new numa topo | 15:48 |
| mriedem | can you specify numa topo via image props? https://docs.openstack.org/python-glanceclient/latest/cli/property-keys.html | 15:48 |
| *** itlinux has joined #openstack-nova | 15:48 | |
| cfriesen | mriedem: and that additional restriction would be a behaviour change | 15:48 |
| cfriesen | mriedem: yeah, hw_numa_nodes=2 | 15:48 |
| *** dpawlik has joined #openstack-nova | 15:48 | |
| mriedem | not really, it's a bug fix | 15:48 |
| mriedem | huh, ok that's not in that doc... | 15:49 |
| *** bnemec has joined #openstack-nova | 15:49 | |
| mriedem | or https://docs.openstack.org/nova/latest/admin/cpu-topologies.html#smp-numa-and-smt for that matter | 15:49 |
| cfriesen | also hw_numa_cpus.1=2, hw_numa_mem.1=512 | 15:49 |
| *** bnemec is now known as beekneemech | 15:50 | |
| mriedem | yeah i see it in ImageMetaProps now | 15:50 |
| *** elmaciej has quit IRC | 15:50 | |
| cfriesen | you can even specify pagesize in the image if the flavor specifies "any" or "large" | 15:51 |
| jgwentworth | anyone know if this is a known gate bug? I find some hits in logstash http://logs.openstack.org/78/554078/12/gate/legacy-tempest-dsvm-multinode-live-migration/cc18c8c/logs/testr_results.html.gz | 15:52 |
| *** amodi has joined #openstack-nova | 15:52 | |
| mriedem | cfriesen: if you're so inclined, you could dump other image props in https://bugs.launchpad.net/nova/+bug/1763761 | 15:52 |
| openstack | Launchpad bug 1763761 in OpenStack Compute (nova) "CPU topologies in nova - doesn't mention numa specific image properties" [Medium,Confirmed] | 15:52 |
| mriedem | jgwentworth: likely yes, but you have to find the qemu guest log to see what the actual failure was | 15:53 |
| jgwentworth | ah okay | 15:53 |
| *** dpawlik has quit IRC | 15:53 | |
| mriedem | http://logs.openstack.org/78/554078/12/gate/legacy-tempest-dsvm-multinode-live-migration/cc18c8c/logs/subnode-2/libvirt/qemu/instance-0000000a.txt.gz | 15:54 |
| mriedem | VQ 1 size 0x100 Guest index 0x4 inconsistent with Host index 0x5: delta 0xffff | 15:54 |
| superdan | hmm, jackie_truong not around on irc today eh? | 15:54 |
| mriedem | jgwentworth: http://status.openstack.org/elastic-recheck/#1761798 | 15:54 |
| jgwentworth | ahoy | 15:54 |
| mriedem | jgwentworth: that fingerprint needs to be updated | 15:54 |
| mriedem | it relies on VQ 0 only | 15:55 |
| mriedem | but this has "VQ 1 size" | 15:55 |
| mriedem | jgwentworth: can you push an update to the query in e-r? | 15:55 |
| jgwentworth | mriedem: yis | 15:55 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22VQ%5C%22%20AND%20message%3A%5C%22size%5C%22%20AND%20message%3A%5C%22Guest%20index%5C%22%20AND%20message%3A%5C%22inconsistent%20with%20Host%20index%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22%20AND%20voting%3A1&from=7d | 15:55 |
| mriedem | that should handle it | 15:55 |
| mriedem | cfriesen: leakypipes: so yeah, sounds like we should fail rebuild if you attempt to use a new image that has any different numa/cpu/hw stuff in it | 15:57 |
| jgwentworth | thankee | 15:57 |
| mriedem | which would be a bug since....juno? | 15:57 |
| *** sc has left #openstack-nova | 15:57 | |
| *** amodi has quit IRC | 15:58 | |
| mriedem | johnthetubaguy_: i added you to https://review.openstack.org/#/c/552078/ in case you can give any feedback before i rev it | 15:59 |
| *** do3meli has quit IRC | 15:59 | |
| *** caisan_ has quit IRC | 16:00 | |
| johnthetubaguy_ | mriedem: will try take a peak at that, been out at a conference-ey thing all week, so miles behind the curve right now | 16:00 |
| *** Spazmotic has quit IRC | 16:00 | |
| *** lpetrut has quit IRC | 16:00 | |
| *** Spazmotic has joined #openstack-nova | 16:01 | |
| mriedem | ack thanks | 16:01 |
| *** slaweq has joined #openstack-nova | 16:01 | |
| cfriesen | mriedem: I think the issue is more that we don't recalculate the numa topology on a rebuild....we actually used to do a claim on a rebuild | 16:01 |
| mriedem | johnthetubaguy_: were these guys there? https://i.ytimg.com/vi/sVw0i5Rd_Is/maxresdefault.jpg | 16:02 |
| mriedem | cfriesen: when did we ever do a claim on a rebuild? | 16:02 |
| mriedem | and don't confuse rebuild with evacuate | 16:02 |
| cfriesen | mriedem: yeah, you're right it was for the evac case. | 16:02 |
| johnthetubaguy_ | mriedem: I hadn't noticed the resemblance till just now, but yes they were | 16:02 |
| johnthetubaguy_ | mriedem: although it probably makes me scooter | 16:03 |
| *** diga has joined #openstack-nova | 16:03 | |
| mriedem | ha | 16:04 |
| jgwentworth | mriedem: https://review.openstack.org/#/c/561261 | 16:04 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 16:04 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 16:04 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262 | 16:04 |
| cfriesen | mriedem: you going to raise a bug report for the image validation on rebuild? | 16:04 |
| mriedem | cfriesen: no, can you please? | 16:04 |
| cfriesen | sure | 16:04 |
| mriedem | thanks | 16:04 |
| jgwentworth | superdan, mriedem, leakypipes, alex_xu, johnthetubaguy_, finucannot, bauzas, fried_rice: been meaning to ask for review on the rocky priorities doc page https://review.openstack.org/#/c/557796 | 16:06 |
| *** r-daneel has quit IRC | 16:06 | |
| mriedem | ack | 16:06 |
| fried_rice | jgwentworth: There was a typo it looked like Mel wanted to fix. Otherwise I'm +1 (discussion inline leading to possible external actions, not in the patch) | 16:07 |
| fried_rice | jgwentworth: ...a typo and a link | 16:07 |
| jgwentworth | oh, right. I forgot | 16:07 |
| jgwentworth | I don't think there's a way to filter only Approved blueprints in launchpad, which sucks | 16:08 |
| jgwentworth | for linking | 16:08 |
| *** lucasagomes is now known as lucas-afk | 16:08 | |
| fried_rice | jgwentworth: There is some mystical querystring syntax that only mriedem knows how to use. | 16:09 |
| jgwentworth | I thought I've asked him about that before. maybe he's holding out on me | 16:10 |
| mriedem | not in the UI that i know of, | 16:10 |
| mriedem | via the REST API yes | 16:10 |
| superdan | I think LP has a bunch of inaccessible query strings you can use | 16:11 |
| mriedem | right | 16:11 |
| mriedem | https://github.com/openstack/nova-specs/blob/master/tools/move_implemented_specs.py | 16:11 |
| *** jchhatbar has quit IRC | 16:12 | |
| sahid | superdan: i saw your comments and questioning on the tx/rx queue size patch. I tried to give more details I hope that is going to help | 16:12 |
| superdan | sahid: okay the thing I'm worried about is I thought that the guest had to support vhost (or is it vhostuser?) in a specific way, and I haven't gone to chase down all the places where we choose between those different types of virtio backends | 16:15 |
| jgwentworth | mriedem: cool script | 16:15 |
| *** pcaruana has joined #openstack-nova | 16:15 | |
| *** amodi has joined #openstack-nova | 16:17 | |
| *** amodi has quit IRC | 16:18 | |
| cfriesen | mriedem: here's the bug: | 16:18 |
| cfriesen | LOG.info("Device %s not found in instance.", | 16:18 |
| cfriesen | disk_dev, instance=instance | 16:18 |
| cfriesen | grr......https://bugs.launchpad.net/nova/+bug/1763766 | 16:18 |
| openstack | Launchpad bug 1763766 in OpenStack Compute (nova) "nova needs to disallow topology changes on image rebuild" [Undecided,New] | 16:18 |
| *** sree has joined #openstack-nova | 16:19 | |
| *** jchhatbar has joined #openstack-nova | 16:20 | |
| superdan | sahid: okay re-reading this with your context I have a little better idea on what to look at | 16:20 |
| sahid | superdan: the driver are on the guest OS. that is your question? | 16:20 |
| superdan | sahid: I'll try to do that while you wor on your unit test | 16:20 |
| superdan | sahid: yeah, the guest | 16:20 |
| superdan | sahid: I thought that if we specify one of those (I think vhostuser) the guest _has_ to have something new enough to support it? | 16:21 |
| superdan | although maybe that doesn't matter since you're only overriding back to vhost/ | 16:21 |
| superdan | sahid: I guess it would be less confusing if you did your refactor of get_base_config() first | 16:22 |
| mriedem | jgwentworth: one thing i've always meant to do with that is move the validation that the spec filename matches the blueprint in LP into the doc/test validation code that runs on each patch | 16:23 |
| sahid | well for vhostuser the virtio driver needs to be recent enough and for vhost the kernel recent enough | 16:23 |
| superdan | sahid: can/do we validate some of these types in upstream CI? | 16:23 |
| mriedem | since people frequently make that mistake and then we have to fix it up later | 16:23 |
| *** mdbooth has quit IRC | 16:23 | |
| jgwentworth | mriedem: you mean in the tox run of nova-specs | 16:24 |
| mriedem | yeah | 16:24 |
| sahid | superdan: yes probably i was thinking about to refactor that method first... | 16:24 |
| superdan | sahid: yeah, I'm just trying to make sure we're not ever selecting something different after this patch, or at least, selecting something different than what would work today | 16:24 |
| sahid | oh i see | 16:24 |
| jgwentworth | makes sense | 16:24 |
| sahid | normally no :) | 16:24 |
| superdan | sahid: if you did that first, then if we have a problem with this later, it would point to the refactor patch instead of your queues patch which would be better I think | 16:24 |
| *** r-daneel has joined #openstack-nova | 16:24 | |
| superdan | sahid: "if we had a problem" meaning.. we selected vhostuser when we should/would have selected vhost or something | 16:25 |
| jgwentworth | mriedem: I think the only wrinkle there could be the LP timeouts that I've run into a fair bit blocking people's specs from passing the tox check | 16:26 |
| sahid | superdan: the thing is the refactor could be big i wanted to limit the scope | 16:26 |
| sahid | i will have to touch lot of thing like the multiqueue support | 16:27 |
| superdan | sahid: so we call all of this from a block that says "if os_vif, do _get_config_os_vif(), otherwise call these per-type methods" | 16:27 |
| superdan | sahid: do we call the os_vif path in this case or not? | 16:28 |
| *** ktibi has quit IRC | 16:28 | |
| sahid | superdan: yes for bridge | 16:28 |
| sahid | and actually for vhostuser | 16:29 |
| superdan | okay, so, vif_type could be bridge, where we end up with driver as qemu or vhost, and then vif_type could be vhostuser where we always have driver as vhostuser, is that right? | 16:29 |
| sahid | yes that is the point | 16:30 |
| superdan | any other types that would have driver=vhost | 16:30 |
| superdan | / | 16:30 |
| superdan | ? | 16:30 |
| sahid | yes except if the virt_type is qemu | 16:30 |
| mriedem | jgwentworth: yeah good point | 16:31 |
| *** sree has quit IRC | 16:31 | |
| superdan | sahid: I'm not sure I know what you mean.. bridge can be vhost or qemu, are there things other than bridge that can use vhost as the driver? | 16:31 |
| *** sree has joined #openstack-nova | 16:32 | |
| *** sar has quit IRC | 16:32 | |
| superdan | oh, virt-type you meant parallels being the alternative I guess | 16:32 |
| sahid | i mean we always want driver=vhost except when virt-type!=kvm | 16:32 |
| sahid | i need to check my thinking is other driver may use vhost | 16:33 |
| sahid | other vif | 16:34 |
| openstackgerrit | ayoung proposed openstack/nova master: Set scope_types for admin password policies https://review.openstack.org/553613 | 16:34 |
| superdan | sahid: did you say that vhostuser would go through os_vif now too? | 16:34 |
| sahid | i'm not sure i understand what you mean by go throught os_vif | 16:36 |
| *** sree has quit IRC | 16:36 | |
| sahid | all ovs and linux bridge vifs pass go through os_vif | 16:37 |
| sahid | here we are configuring guest xml | 16:37 |
| sahid | os vif is configuring the network on host | 16:37 |
| superdan | sahid: this: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L554-L559 | 16:38 |
| superdan | because if we take that path, we never call get_config_vhostuser() | 16:38 |
| sahid | get_base_config is called anytime, and yes we have a specific class in os-vif for vhostuser | 16:39 |
| sahid | everytime | 16:39 |
| superdan | sahid: right, so will this ever get run? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L420 | 16:39 |
| sahid | but no real relation is just about to pass some metadata which will be used by ovs | 16:39 |
| sahid | hum that is why i said i need to double check i think vrouter is using that method | 16:40 |
| sahid | but perhaps they now have a plugin in os_vif | 16:40 |
| superdan | okay I'm not sure how that would get called | 16:41 |
| *** damien_r has joined #openstack-nova | 16:41 | |
| *** salv-orlando has quit IRC | 16:41 | |
| *** salv-orlando has joined #openstack-nova | 16:41 | |
| *** fried_rice is now known as fried_rolls | 16:41 | |
| *** damien_r has quit IRC | 16:42 | |
| *** damien_r has joined #openstack-nova | 16:42 | |
| sahid | superdan: i just check, you think we sould remove it? | 16:42 |
| superdan | sahid: well, your patch modifies it, and it's one of the things I was trying to verify, so if it's dead code then we should remove it so I don't have to ask questions about whether or not your changes are correct :) | 16:43 |
| *** yamahata has quit IRC | 16:43 | |
| *** salv-orlando has quit IRC | 16:44 | |
| *** salv-orlando has joined #openstack-nova | 16:44 | |
| sahid | i'm just asking myself why we don't have removed it when we have introduced it in os_vif | 16:45 |
| sahid | i will try to find the git commit log | 16:45 |
| superdan | it looks like we do have a vhostuser conversion in that utils moduke, | 16:46 |
| superdan | but it can raise NotImplemented, so maybe there are cases where it isn't covered? | 16:46 |
| *** ssurana has joined #openstack-nova | 16:47 | |
| *** damien_r has quit IRC | 16:48 | |
| sahid | i can't see when it can raise a NotImplemented, can yu point me the line? | 16:49 |
| superdan | yep, sec | 16:49 |
| *** damien_r has joined #openstack-nova | 16:49 | |
| superdan | https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L408-L408 | 16:49 |
| *** hongbin has joined #openstack-nova | 16:50 | |
| superdan | other methods in there don't raise it in a final else | 16:50 |
| superdan | but maybe you can tell that that should never happen? | 16:50 |
| sahid | superdan: i can't :/ | 16:50 |
| sahid | let see what it blame is saying | 16:51 |
| *** gyee has joined #openstack-nova | 16:51 | |
| *** esberglu has quit IRC | 16:52 | |
| *** ssurana has quit IRC | 16:53 | |
| *** links has joined #openstack-nova | 16:53 | |
| superdan | the set_config_VIFVHostUser method is only used from the os_vif path | 16:54 |
| superdan | so that covers us for the os_vif vif_types I guess | 16:55 |
| *** damien_r has quit IRC | 16:57 | |
| sahid | superdan: so what is your thinking? | 16:59 |
| superdan | sahid: I just added some more comments to the review, | 16:59 |
| superdan | but you're only setting the queue sizes if we do _not_ convert the vif in os_vif_util, | 17:00 |
| superdan | meaning only if it raises NotImplementedError, | 17:00 |
| *** germs has joined #openstack-nova | 17:00 | |
| *** germs has quit IRC | 17:00 | |
| *** germs has joined #openstack-nova | 17:00 | |
| superdan | which would mean we're not setting queue sizes for the more common types of VIFs right? | 17:00 |
| superdan | i.e. you're only setting the sizes if we _fail_ the os_vif test and fall back to this method that we think might actually be dead code | 17:00 |
| *** derekh has quit IRC | 17:00 | |
| sahid | superdan: for you first question, get_base_config is called even when we build os_vif object | 17:04 |
| superdan | sahid: ah wait, nevermind that last point | 17:04 |
| *** germs has quit IRC | 17:05 | |
| *** jpena is now known as jpena|off | 17:07 | |
| superdan | sahid: okay, I think I've got this more in my head now, | 17:08 |
| superdan | so this is what I think I want to see: | 17:08 |
| superdan | 1. I want to know if we're ever really calling the non-os_vif path (i.e. get_config_vhostuser). If we're not, we should just nuke that in a patch before this and then remove from this | 17:08 |
| *** jchhatbar has quit IRC | 17:09 | |
| superdan | 2. I'd really like it if we could avoid setting driver in get_base_config and then re-setting it for the vhostuser cases | 17:09 |
| superdan | for #2, we need an answer to the question I had before of whether or not things other than bridge use driver=vhost | 17:09 |
| *** amoralej is now known as amoralej|off | 17:09 | |
| superdan | if we don't then I think we could set driver=vhost in set_config_VIFBridge (right?) and then set driver=vhostuser for _set_config_VIFHostUser() (right?) | 17:10 |
| *** mgoddard has quit IRC | 17:10 | |
| superdan | for #1, who can we ask that would know the answer to how we could get to the NotImplementedError in os_vif_util | 17:10 |
| superdan | ? | 17:10 |
| sahid | for #1 I think sean-k-mooney can help | 17:11 |
| superdan | okay that would have been my first thought | 17:11 |
| sahid | for #2 we are using vhost for more that bridge | 17:11 |
| sahid | i was confusing | 17:11 |
| sahid | but basicallt for every net device type virtio | 17:12 |
| sahid | which is always the case | 17:12 |
| sahid | we use vhost user if the host support it | 17:12 |
| sahid | basically to plug a tap device in qemu we always use a device virtio-net | 17:12 |
| superdan | okay and that gets set in get_base_config() today because of _get_virtio_mq_settings() ? | 17:13 |
| *** sambetts is now known as sambetts|afk | 17:13 | |
| sahid | yes, we specically set it because we want the driver node to pass the attirbute queues | 17:14 |
| superdan | okay, so today before your patch, how do we get driver=vhostuser in the vhostuser case? | 17:14 |
| sahid | that was the point of the TODOs i added | 17:15 |
| superdan | meaning, why didn't we need L549 in your patch before? | 17:15 |
| sahid | before of my patch we where setting vhost even for a vhostuser interface | 17:16 |
| *** jackie-truong has joined #openstack-nova | 17:16 | |
| *** wolverineav has joined #openstack-nova | 17:16 | |
| superdan | ah, okay and you were saying that was just getting ignored? | 17:16 |
| sahid | exactly | 17:16 |
| superdan | "since QEMU ignores the driver | 17:16 |
| superdan | # argument for vhostuser " | 17:16 |
| superdan | okay | 17:16 |
| superdan | there are waaaay too many things in here with almost the same name :) | 17:17 |
| sahid | yes that is what i meant | 17:17 |
| sahid | it's really confusing yes | 17:17 |
| superdan | okay, so, | 17:17 |
| superdan | this seems silly, but can we remove L549 from this patch and put it either before or after? | 17:17 |
| superdan | I think it's super confusing because I thought you were changing something, | 17:17 |
| superdan | but really you're just correcting something that is ignored | 17:18 |
| sahid | yes :) | 17:18 |
| sahid | but... | 17:18 |
| sahid | no, ok I can provide a patch to set driver_name = vhostuser for set_config_VIFHostUser | 17:19 |
| *** slaweq has quit IRC | 17:19 | |
| sahid | and then provide the queue sizes change | 17:19 |
| sahid | looks good for you? | 17:19 |
| superdan | yeah, do that | 17:19 |
| sahid | ok | 17:19 |
| superdan | but also, | 17:19 |
| superdan | I want to know that answer to #1 | 17:19 |
| sahid | yea, i think that will be diffuclt to response for example i'm sure before of the update for vrouter they were using that | 17:20 |
| sahid | so i imagine it might have other kind of switch which are using it | 17:20 |
| sahid | but let see with sean | 17:20 |
| superdan | okay, one other thing: | 17:21 |
| superdan | the L171 override, | 17:21 |
| superdan | er, nevermind | 17:22 |
| superdan | I forgot about setting the rx_queue_size for the frontend | 17:22 |
| sahid | ok cool | 17:23 |
| sahid | thanks for you time superdan. time for me to take a break | 17:23 |
| superdan | sahid: yeah, thanks for your patience, I will summarize in the review (again :P) | 17:23 |
| sahid | :) | 17:24 |
| *** sahid has quit IRC | 17:25 | |
| *** felipemonteiro_ has quit IRC | 17:27 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:27 | |
| *** ssurana has joined #openstack-nova | 17:28 | |
| *** yamahata has joined #openstack-nova | 17:29 | |
| *** ssurana1 has joined #openstack-nova | 17:32 | |
| *** ssurana has quit IRC | 17:32 | |
| *** ssurana1 has quit IRC | 17:34 | |
| superdan | jgwentworth: you wanna take a trip through this? https://review.openstack.org/#/c/479949/57 | 17:38 |
| superdan | now that it's split into a smaller piece I think it's close to reasonable but I'm getting a little blind to it at this point | 17:39 |
| *** felipemonteiro_ has quit IRC | 17:39 | |
| jgwentworth | superdan: yes, will do that today | 17:40 |
| superdan | thanks | 17:41 |
| superdan | I bet jackie-truong thanks you too | 17:41 |
| jgwentworth | :) | 17:41 |
| *** lpetrut has joined #openstack-nova | 17:41 | |
| jackie-truong | Yes, please :-) Thanks, jgwentworth and superdan | 17:42 |
| superdan | jackie-truong: I was looking for you on here earlier today to ask forgiveness for asking to split the patch so late | 17:42 |
| superdan | you not being here led to guilt and me splitting it for you | 17:42 |
| superdan | so, good job. | 17:42 |
| kashyap | superdan: Was AFK; just re-launched IRC client, /me scrolls back | 17:43 |
| jackie-truong | superdan: Sorry I wasn't around. Friday meetings suck. Thanks for splitting the patch - I think it makes a lot more sense that way | 17:43 |
| superdan | kashyap: not a thing anymore | 17:44 |
| kashyap | superdan: Ah, noted. | 17:45 |
| superdan | kashyap: I spent an epic hour or so with sahid getting it all figured out myself | 17:45 |
| * kashyap bows | 17:45 | |
| kashyap | lyarwood: or any "Stable People": Want to put this out of its misery: https://review.openstack.org/#/c/561168/ | 17:45 |
| kashyap | superdan: FWIW, so many TODOs in already one patch: https://review.openstack.org/#/c/484997/16/nova/virt/libvirt/vif.py? | 17:47 |
| kashyap | A bit moderation would be nice | 17:47 |
| superdan | kashyap: yeah, he's going to move some of the stuff out to another patch, which will pull some TODOs with it | 17:48 |
| superdan | kashyap: they're not TODOs about the patch itself, but some stupid stuff that was in the file before this | 17:48 |
| superdan | like "I noticed this was already wrong when I was in here" | 17:48 |
| kashyap | Ah, I see. | 17:48 |
| superdan | which should be in another patch, | 17:48 |
| superdan | especially because it took me days to suss that out :) | 17:48 |
| kashyap | Right. "One logical change per patch" | 17:48 |
| jgwentworth | jackie-truong: is this the tempest test where we can see the cert validation working end-to-end? https://review.openstack.org/#/c/526485 | 17:49 |
| *** psachin has quit IRC | 17:49 | |
| superdan | jgwentworth: it's linked in the bottom patch | 17:50 |
| superdan | I don't think that's it | 17:50 |
| superdan | jgwentworth: https://review.openstack.org/#/c/515210/ | 17:50 |
| jgwentworth | linked in the comments? cause I don't see anything in the commit message | 17:50 |
| superdan | yeah comments | 17:50 |
| jgwentworth | k, thanks | 17:50 |
| kashyap | superdan: Also, it's never a "mess" (as you put it there) to do connsciousness stream write-ups on reviews are perfectly "legal", as you know :P | 17:50 |
| superdan | I just rechecked it a bit ago after pushing up the split, but it wasn't a change, so the last run of that should be fine for validation | 17:51 |
| jgwentworth | oh, k. I did see that patch but missed that it's tempest via pluginness | 17:51 |
| superdan | kashyap: it's a total mess | 17:51 |
| kashyap | If you say so... | 17:51 |
| cfriesen | do we do anything to prevent a port deletion of a port that is connected to an instance? or should I be asking the neutron folks? | 17:52 |
| *** tesseract has quit IRC | 17:53 | |
| kashyap | Unrelated: Are Gerrit review comments look-up-able? As in: I know that dansmith said $unique-phrase on a change, putting that phrase in double quotes in Google will yield the right URL? | 17:53 |
| *** udesale has quit IRC | 17:53 | |
| superdan | what did I say? | 17:53 |
| jgwentworth | yes they are. can't remember how off the top of my head | 17:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add config option to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284 | 17:54 |
| mriedem | jgwentworth: mnaser: ^ | 17:54 |
| *** burt has joined #openstack-nova | 17:54 | |
| jgwentworth | kashyap: https://review.openstack.org/Documentation/user-search.html#comment | 17:54 |
| kashyap | superdan: Heh, not what you said, but I just took you as an example. Any unique phrase that I know of | 17:54 |
| mriedem | 95% of that patch is test and docs | 17:54 |
| jgwentworth | mriedem: whew, thanks | 17:55 |
| *** mgoddard has joined #openstack-nova | 17:55 | |
| kashyap | jgwentworth: Thanks. So that is searching in review.openstack.org itself. | 17:55 |
| arvindn05 | mriedem: morning :) | 17:55 |
| jgwentworth | kashyap: yeah, like in the serach box you do comment:"unique phrase" | 17:56 |
| jgwentworth | *search | 17:56 |
| kashyap | Thanks. That's useful | 17:56 |
| arvindn05 | mriedem: looks like bauza does not like special case logic in scheduler :( | 17:56 |
| *** ralonsoh has quit IRC | 17:56 | |
| *** esberglu has joined #openstack-nova | 17:56 | |
| arvindn05 | mriedem: i did mention to him that we plan to have the logic in the scheduler already as part of the bug fix for https://bugs.launchpad.net/nova/+bug/1750623 | 17:57 |
| openstack | Launchpad bug 1750623 in OpenStack Compute (nova) queens "rebuild to same host with different image shouldn't check with placement" [Medium,In progress] - Assigned to Hongbin Lu (hongbin.lu) | 17:57 |
| *** Sukhdev has joined #openstack-nova | 17:57 | |
| arvindn05 | bauzas: can we discuss your comments on https://review.openstack.org/#/c/560718/ - Handle rebuild of instance with new image? | 18:00 |
| *** links has quit IRC | 18:02 | |
| mriedem | arvindn05: bauzas is in france so probably done for the day (it's 8pm there) | 18:03 |
| mriedem | jgwentworth: mnaser: as soon as i pushed that up for review and stepped away for a minute, i thought that is probably better as a policy rule rather than a config option... | 18:03 |
| mnaser | thats an interesting approach | 18:04 |
| mriedem | because if you don't allow users to upload images, then you don't need the warning spam in the nova-api logs, | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 18:04 |
| jgwentworth | I could see that | 18:04 |
| mriedem | and if you want to play with this feature but only for admins, then you can do that with policy but the config option is either on or off | 18:04 |
| jgwentworth | ah, for the dev/test scenario. yeah | 18:05 |
| mriedem | well, we might have the warning in the logs either way since we don't know if glance is configured to allow image uploads | 18:05 |
| mriedem | for tenants | 18:05 |
| mriedem | the warning is really my way of trying to get people to realize this is a thing if they aren't reading release notes | 18:05 |
| mnaser | i like the idea of making it a policy flag thing, in case you want to allow specific tenants that rely on old behaviour (but you know won't be breaking things) | 18:11 |
| mriedem | yeah me too, it's more flexible | 18:12 |
| mriedem | i'll wait a bit before making changes | 18:12 |
| openstackgerrit | Merged openstack/nova master: Remove the branch specifier from the nova-multiattach job https://review.openstack.org/560930 | 18:14 |
| openstackgerrit | Merged openstack/nova master: libvirt: move version to string in utils https://review.openstack.org/560455 | 18:15 |
| *** links has joined #openstack-nova | 18:15 | |
| openstackgerrit | Merged openstack/nova master: libvirt: refactor get_base_config to accept host arg https://review.openstack.org/560456 | 18:15 |
| mriedem | superdan: can you fast approve this on stable? https://review.openstack.org/#/c/560931/ | 18:15 |
| mriedem | need that to get the multiattach job voting again on master | 18:16 |
| superdan | can I or will I? | 18:16 |
| mriedem | can you will it | 18:16 |
| *** bhujay has quit IRC | 18:16 | |
| *** stvnoyes has quit IRC | 18:19 | |
| kashyap | superdan: I know you did a more robust review, I hope my -1 here is still in the spirit of it: https://review.openstack.org/#/c/484997/16/nova/conf/libvirt.py | 18:21 |
| * kashyap winds up for the night | 18:21 | |
| *** gjayavelu has joined #openstack-nova | 18:23 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 18:24 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 18:24 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 18:24 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 18:24 |
| mriedem | jgwentworth: mlavalle: posted http://forumtopics.openstack.org/cfp/details/124 | 18:28 |
| jgwentworth | coolness. thanks. superdan, want to post the cells one? | 18:29 |
| mlavalle | mriedem: thanks | 18:29 |
| openstackgerrit | Hongbin Lu proposed openstack/nova stable/pike: Skip placement on rebuild in same host https://review.openstack.org/561015 | 18:30 |
| *** bkopilov has quit IRC | 18:30 | |
| mriedem | mlavalle: ops might want to ask about routed networsk too, i don't know how much you get for questions about that | 18:31 |
| *** links has quit IRC | 18:31 | |
| mlavalle | mriedem: I am not getting many questions lately | 18:32 |
| *** lpetrut has quit IRC | 18:34 | |
| *** lpetrut has joined #openstack-nova | 18:34 | |
| superdan | jgwentworth: okay | 18:38 |
| *** Guest35063 has quit IRC | 18:44 | |
| jgwentworth | thankee | 18:45 |
| superdan | jgwentworth: http://forumtopics.openstack.org/cfp/details/125 | 18:46 |
| jgwentworth | woot | 18:46 |
| cfriesen | got a weird setup. we had in instance on a host in Newton, then deleted the host, then upgraded to Pike (which added uuids to the Service records but apparently not deleted ones), then created the compute node again with the same name. Now when we try to get that instance from the db it chokes, I suspect because it pulls in the deleted host record which has no uuid. | 18:49 |
| cfriesen | should we have applied UUIDs to deleted hosts as well in the Pike online data migration? | 18:49 |
| jgwentworth | there's a bug for that | 18:49 |
| * jgwentworth rummages through bag of bugs | 18:49 | |
| jgwentworth | cfriesen: https://bugs.launchpad.net/nova/+bug/1746509 | 18:50 |
| openstack | Launchpad bug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,Fix committed] - Assigned to melanie witt (melwitt) | 18:50 |
| jgwentworth | did you do your pike upgrade before that merged or was released? | 18:51 |
| openstackgerrit | Merged openstack/nova master: Add host field to InstanceActionEvent https://review.openstack.org/555146 | 18:51 |
| cfriesen | jgwentworth: cool, looks interesting. I need to dig into this a bit more to get the details. | 18:53 |
| jgwentworth | k. yeah, this was specifically having to do with an upgrade scenario where there were already existing service records with no UUID | 18:54 |
| jgwentworth | and instance list failed | 18:54 |
| cfriesen | jgwentworth: do you know why we didn't just apply uuids to deleted services for consistency? | 18:54 |
| jgwentworth | cfriesen: we were but on-the-fly upon access. so the bug unfortunately was shown *during* the generation of service UUID for one that did not yet have a UUID :/ | 18:55 |
| cfriesen | ah, got it. | 18:55 |
| jgwentworth | because of nested database transaction contexts. unrelated to the generation but nothing hit the path until the generation was added to the instance read flow | 18:56 |
| *** dklyle has quit IRC | 18:56 | |
| cfriesen | jg: I was thinking in service_uuids_online_data_migration() | 18:56 |
| cfriesen | jgwentworth: ^ | 18:56 |
| jgwentworth | yeah, I figured that's what you meant. was not done in a batch like that and I don't know why not | 18:57 |
| *** dklyle has joined #openstack-nova | 18:57 | |
| jgwentworth | superdan might know. why we didn't do service UUID as a batch online data migration? | 18:57 |
| superdan | did we not? | 18:59 |
| superdan | we did | 18:59 |
| superdan | we normally skip deleted records for expediency, which is what he's asking right? | 18:59 |
| jgwentworth | hm, okay. so that means they didn't run nova-manage online_data_migrations? | 19:00 |
| jgwentworth | no, not deleted records | 19:00 |
| cfriesen | jgwentworth: pretty sure we ran it but it would have skipped the deleted records | 19:00 |
| superdan | [11:54:35] <cfriesen>jgwentworth: do you know why we didn't just apply uuids to deleted services for consistency? | 19:00 |
| jgwentworth | existing non-deleted service records that lacked a service UUID | 19:00 |
| jgwentworth | oh, I missed that | 19:00 |
| *** germs has joined #openstack-nova | 19:01 | |
| *** germs has quit IRC | 19:01 | |
| *** germs has joined #openstack-nova | 19:01 | |
| cfriesen | jgwentworth: we'll try that fix you pointed me at...hopefully that solves the on-demand issue | 19:01 |
| superdan | cfriesen: for instance-related things, skipping deleted saves us a ton of work of course | 19:01 |
| superdan | maybe less on services, but .. if there's no way to undelete a service there's not much point | 19:01 |
| jgwentworth | okay, yeah if they service was in the deleted state then it could be skipped. but how could an active instance have a deleted service record? | 19:01 |
| cfriesen | superdan: yeah, I get that. just bad luck that it triggered another bug | 19:01 |
| jgwentworth | I guess that goes back to our discussion from the other day | 19:02 |
| superdan | jgwentworth: we just went over that you can delete services even when instances are on it right? :) | 19:02 |
| superdan | yeah that | 19:02 |
| jgwentworth | we allow service delete while instances are alive | 19:02 |
| cfriesen | jgwentworth: boot instance, migrate it, delete service, upgrade, add new service with same name, migrate instance | 19:02 |
| superdan | or just boot instance, delete service | 19:02 |
| jgwentworth | okay, I didn't realize that was a thing | 19:02 |
| superdan | jgwentworth: remember me saying I thought it was probably bad to allow this anyway? :P | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | 19:03 |
| jgwentworth | cfriesen: so you would have a problem if we made it so services can't be deleted if they have running instances? | 19:03 |
| mriedem | superdan: i've got a patch up for that, testing it in devstack atm | 19:03 |
| jgwentworth | superdan: yes | 19:03 |
| mriedem | https://review.openstack.org/#/c/560674/1 | 19:03 |
| * jgwentworth opens a billionth tab | 19:04 | |
| cfriesen | jgwentworth: I wouldn't, no. In our case we did the sequence I described...the issue is that the back reference from instance to service is by host name | 19:04 |
| cfriesen | so if you delete a service then make another with the same name, they'll both get matched | 19:04 |
| superdan | which is another reason why that hostname-based keying is kinda bad | 19:04 |
| jgwentworth | oh, okay, so because you migrated the instance already the service delete would be okay with you as no running instances left on it | 19:05 |
| cfriesen | yep | 19:05 |
| jgwentworth | k, cool | 19:05 |
| *** germs has quit IRC | 19:06 | |
| *** Tom-Tom has joined #openstack-nova | 19:07 | |
| *** claudiub|2 has quit IRC | 19:09 | |
| *** harlowja has joined #openstack-nova | 19:10 | |
| *** Tom-Tom has quit IRC | 19:11 | |
| *** idlemind has quit IRC | 19:15 | |
| *** idlemind has joined #openstack-nova | 19:16 | |
| *** lpetrut has quit IRC | 19:19 | |
| *** sidx64_ has joined #openstack-nova | 19:20 | |
| *** jackie-truong has quit IRC | 19:20 | |
| *** mgoddard has quit IRC | 19:21 | |
| *** fried_rolls is now known as fried_rice | 19:26 | |
| *** Sukhdev has quit IRC | 19:28 | |
| jgwentworth | superdan: on this patch about multi-cell query for instance group members, mriedem and I had some discussion over whether or not I should make changes to limit the query to the cell we're already in, if it's a move operation. we wanted to get your opinion if there's some reason not to do that, that we might have missed https://review.openstack.org/#/c/540258 | 19:29 |
| mriedem | nice http://paste.openstack.org/show/719188/ shows that n-api doesn't barf when trying to delete allocations during server delete if the n-cpu is down and [placement] isn't configured | 19:29 |
| *** pchavva has quit IRC | 19:34 | |
| imacdonn | mriedem: FYI, in case you run into it somewhere .... after re-enabling UCA for Oracle ZFSSA CI, I hit this - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891315 - 'apt-get upgrade' installed a 'libnettle6 amd64 3.4-1~cloud0' (from the UCA), and i'm hoping that'll fix it | 19:42 |
| openstack | Debian bug 891315 in dnsmasq "[dnsmasq] libnettle6 dependency" [Normal,Fixed] | 19:42 |
| *** liverpooler has quit IRC | 19:42 | |
| *** slaweq has joined #openstack-nova | 19:43 | |
| mriedem | jgwentworth: https://review.openstack.org/#/c/557796/ lgtm, i'll +2 once you fix that typo | 19:43 |
| jgwentworth | mriedem: thanks | 19:44 |
| mriedem | imacdonn: which UCA? | 19:44 |
| mriedem | pike or queens? | 19:44 |
| imacdonn | mriedem: queens ... it's devstack master | 19:44 |
| mriedem | imacdonn: haven't had any issues like that here https://review.openstack.org/#/c/554317/ | 19:45 |
| imacdonn | mriedem: perhaps you got the new libnettle6 by some other means | 19:45 |
| mriedem | idk, infra builds the images | 19:45 |
| imacdonn | mriedem: OK, well, just a heads-up in case you see it | 19:45 |
| mriedem | ack | 19:46 |
| imacdonn | other than that, ZFSSA CI seems to work (with multiattach) with the UCA | 19:46 |
| mriedem | outstanding | 19:46 |
| *** dklyle has quit IRC | 19:47 | |
| superdan | jgwentworth: sure seems reasonable | 19:47 |
| jgwentworth | k, thanks | 19:48 |
| *** wolverineav has quit IRC | 19:49 | |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Document Rocky review priorities https://review.openstack.org/557796 | 19:49 |
| *** wolverineav has joined #openstack-nova | 19:49 | |
| *** dklyle has joined #openstack-nova | 19:50 | |
| *** wolverineav has quit IRC | 19:53 | |
| mriedem | any opinions on removing the redundant unit tests from tssurya's patch here? https://review.openstack.org/#/c/554920/10/nova/tests/unit/compute/test_host_api.py@439 the functional test in that change will now cover that | 19:56 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps https://review.openstack.org/561315 | 19:57 |
| leakypipes | superdan: that should help when we need >1 placement req filters... | 19:58 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps https://review.openstack.org/561315 | 20:00 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps https://review.openstack.org/561315 | 20:02 |
| jgwentworth | mriedem: yeah, seems like that unit test can go | 20:08 |
| *** wolverineav has joined #openstack-nova | 20:08 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:09 | |
| jgwentworth | I don't see it covering anything additional unless I'm missing something | 20:09 |
| *** wolverineav has quit IRC | 20:09 | |
| superdan | leakypipes: that's implementing what we said int the spec revision right? | 20:09 |
| *** wolverineav has joined #openstack-nova | 20:09 | |
| leakypipes | superdan: yessir | 20:10 |
| superdan | cools | 20:10 |
| *** felipemonteiro__ has joined #openstack-nova | 20:13 | |
| jgwentworth | wow, assert_called_once() is a thing. *mind blown* | 20:16 |
| *** felipemonteiro_ has quit IRC | 20:16 | |
| *** jackie-truong has joined #openstack-nova | 20:17 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:18 | |
| *** felipemonteiro__ has quit IRC | 20:18 | |
| *** jmlowe_ has joined #openstack-nova | 20:22 | |
| *** jmlowe has quit IRC | 20:23 | |
| *** sridharg has quit IRC | 20:27 | |
| *** sar has joined #openstack-nova | 20:28 | |
| *** tbachman has joined #openstack-nova | 20:30 | |
| *** claudiub|2 has joined #openstack-nova | 20:30 | |
| *** wolverineav has quit IRC | 20:40 | |
| mriedem | using fixtures as context managers - put that in your bag of tricks too for when a test needs to conditionally use a fixture | 20:42 |
| jgwentworth | I think I've done that before already with MonkeyPatch fixture | 20:43 |
| jgwentworth | cause I'm cool like that | 20:43 |
| mriedem | unfortunately our api fixtures might not be setup properly to handle running them as fixtures... | 20:49 |
| mriedem | dagnabbit | 20:49 |
| *** r-daneel has quit IRC | 20:49 | |
| *** ccamacho has quit IRC | 20:49 | |
| *** wolverineav has joined #openstack-nova | 20:50 | |
| *** fragatina has quit IRC | 20:50 | |
| mriedem | cdent: i know you probably want to figure this out on your friday night, but it's not clear to me that we stop the wsgi app when PlacementFixture or OSAPIFixture tear down | 20:55 |
| mriedem | specifically, i get a timeout b/c the request seems to hang on a connection error at L77 http://paste.openstack.org/show/719198/ | 20:56 |
| mriedem | http://paste.openstack.org/show/719199/ | 20:57 |
| *** sdeath has quit IRC | 20:57 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:01 |
| *** germs has joined #openstack-nova | 21:01 | |
| *** germs has quit IRC | 21:01 | |
| *** germs has joined #openstack-nova | 21:01 | |
| *** awaugama has quit IRC | 21:02 | |
| jgwentworth | jackie-truong: hey, thanks for the quick update :) I'm going through the last patch now and to peruse the tempest test logs. sorry for the delay on review | 21:05 |
| jackie-truong | jgwentworth: np! thanks :-) | 21:06 |
| *** ccamacho has joined #openstack-nova | 21:06 | |
| *** germs has quit IRC | 21:06 | |
| *** sidx64_ has quit IRC | 21:13 | |
| *** sree has joined #openstack-nova | 21:14 | |
| *** esberglu has quit IRC | 21:15 | |
| *** sree has quit IRC | 21:19 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 21:21 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 21:22 |
| *** felipemonteiro_ has quit IRC | 21:22 | |
| *** arvindn05 has quit IRC | 21:30 | |
| *** sdeath has joined #openstack-nova | 21:33 | |
| *** jackie-truong has quit IRC | 21:34 | |
| cdent | mriedem: Imma gonna need you to parse that a bit more for me, or I can think harder about it some other time, but at the moment, I don't get what you're saying supposed to be happening there | 21:34 |
| mriedem | i'm just going to leave it as a note in my test for now, | 21:35 |
| mriedem | but in that test i'm using the placement fixture and the compute api fixture, | 21:35 |
| *** dave-mccowan has quit IRC | 21:36 | |
| mriedem | but i need the placement fixture to be used conditionally based on what i'm doing, | 21:36 |
| *** arvindn05 has joined #openstack-nova | 21:36 | |
| mriedem | so i use it when i'm creating a server because the compute service needs it, but then i don't want placement fixture in place when i delete the server | 21:36 |
| mriedem | but when i go to delete the server i get this weird connection error, | 21:36 |
| mriedem | so i'm not sure if/why the placement fixture is messing with the osapifixture | 21:36 |
| mriedem | i figured maybe the placement fixture isn't cleaning up after itself properly | 21:37 |
| cdent | that a url for the compute api though? | 21:37 |
| mriedem | yeah | 21:38 |
| mriedem | Max retries exceeded with url: /v2.1/6f70656e737461636b20342065766572//servers/ee29ce1f-ca1e-4466-84cd-23d57bb70206 | 21:38 |
| *** slaweq has quit IRC | 21:38 | |
| cdent | is there a check behind that compute api call for the placement api? that is, at that step of the game, how is placement involved? | 21:38 |
| mriedem | wsgi-intercept is working on unique endpoints between placement and osapifixture so i'm not sure how things could overlap | 21:38 |
| *** slaweq has joined #openstack-nova | 21:39 | |
| cdent | is there any asynchrony/eventlet/similar magic going on? | 21:39 |
| mriedem | the delete flow in this patch now adds a call to the scheduler report client to delete allocations for the instance | 21:39 |
| mriedem | which i was hoping would bomb out and @safe_connect would handle it | 21:39 |
| mriedem | since placement fixture wouldn't be in place when the server delete call happens | 21:39 |
| mriedem | but...it's likely trying to hit ksa...? | 21:40 |
| *** evrardjp has quit IRC | 21:40 | |
| cdent | if you push the code up somewhere and add me to the review I'll look at it tomorrow (eagerly even, because I'm curious) | 21:40 |
| mriedem | ok; i might know how to do this w/o the ugly stub i've got in place too, will test | 21:41 |
| cdent | it's entirely possible there are some global bits in wsgi-intercept being naughty (it is old and gross) | 21:41 |
| cdent | and if we can find them that would be a nice fix | 21:41 |
| cdent | if nothing else, I'll play with the paste tomorrow | 21:42 |
| mriedem | it's bugging me so i'll have something up tonight most likely and just add yo uto the review | 21:43 |
| cdent | I'm going to not get sucked in for of fear of being glared at by family | 21:43 |
| *** slaweq has quit IRC | 21:44 | |
| *** slaweq has joined #openstack-nova | 21:44 | |
| *** fragatina has joined #openstack-nova | 21:45 | |
| *** r-daneel has joined #openstack-nova | 21:46 | |
| * cdent waves goodnight | 21:47 | |
| *** cdent has quit IRC | 21:47 | |
| *** Tom-Tom has joined #openstack-nova | 21:50 | |
| *** mchlumsky has quit IRC | 21:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Block deleting compute services which are hosting instances https://review.openstack.org/560674 | 21:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete allocations from API if nova-compute is down https://review.openstack.org/560706 | 21:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 21:54 |
| *** Tom-Tom has quit IRC | 21:55 | |
| *** burt has quit IRC | 22:04 | |
| *** icRobby has joined #openstack-nova | 22:04 | |
| *** avolkov has quit IRC | 22:05 | |
| *** r-daneel has quit IRC | 22:05 | |
| *** icRobby has quit IRC | 22:05 | |
| *** sdeath has quit IRC | 22:07 | |
| *** r-daneel has joined #openstack-nova | 22:09 | |
| *** slaweq has quit IRC | 22:10 | |
| *** linkmark has quit IRC | 22:12 | |
| *** esberglu has joined #openstack-nova | 22:20 | |
| *** esberglu has quit IRC | 22:21 | |
| *** vladikr_ has quit IRC | 22:25 | |
| *** itlinux has quit IRC | 22:27 | |
| *** sdague has quit IRC | 22:31 | |
| *** Guest78769 has quit IRC | 22:39 | |
| *** figleaf is now known as edleafe | 22:46 | |
| openstackgerrit | Merged openstack/nova master: Rename network.utils to network.linux_utils. https://review.openstack.org/559197 | 22:47 |
| openstackgerrit | Merged openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 22:47 |
| openstackgerrit | Merged openstack/nova stable/queens: Remove the branch specifier from the nova-multiattach job https://review.openstack.org/560931 | 22:47 |
| openstackgerrit | Merged openstack/nova master: Skip placement on rebuild in same host https://review.openstack.org/546357 | 22:47 |
| *** Sukhdev has joined #openstack-nova | 22:52 | |
| *** sar has quit IRC | 22:58 | |
| jgwentworth | mriedem: fyi I see the ceph job on master is busted, looking into what's going on http://logs.openstack.org/49/479949/58/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/eecfbb1/logs/devstacklog.txt.gz#_2018-04-13_21_24_31_947 | 23:00 |
| jgwentworth | I don't see anything wrong with that identity URL | 23:00 |
| *** germs has joined #openstack-nova | 23:02 | |
| *** germs has quit IRC | 23:02 | |
| *** germs has joined #openstack-nova | 23:02 | |
| *** _ix has quit IRC | 23:04 | |
| *** germs has quit IRC | 23:06 | |
| *** hongbin has quit IRC | 23:13 | |
| *** Zames has joined #openstack-nova | 23:15 | |
| *** jgwentworth is now known as melwitt | 23:22 | |
| *** Zames has quit IRC | 23:23 | |
| lbragstad | leakypipes: thanks for the review on https://review.openstack.org/#/c/553613/2 | 23:27 |
| lbragstad | i tried to answer some of your comments, but let me know if bits are still unclear | 23:28 |
| *** wolverineav has quit IRC | 23:31 | |
| *** wolverineav has joined #openstack-nova | 23:32 | |
| lbragstad | melwitt: http://logs.openstack.org/49/479949/58/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/eecfbb1/logs/screen-keystone.txt.gz#_Apr_13_21_24_28_551060 looks new | 23:34 |
| lbragstad | looks like a missing dependency of paste | 23:36 |
| *** wolverineav has quit IRC | 23:36 | |
| *** bhagyashris has quit IRC | 23:40 | |
| *** hoonetorg has joined #openstack-nova | 23:45 | |
| *** gjayavelu has quit IRC | 23:45 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 23:47 |
| *** wolverineav has joined #openstack-nova | 23:47 | |
| *** wolverineav has quit IRC | 23:51 | |
| *** wolverin_ has joined #openstack-nova | 23:52 | |
| *** claudiub|2 has quit IRC | 23:52 | |
| melwitt | lbragstad: oh, thank you! | 23:53 |
| melwitt | for whatever reason, I didn't think to look in the keystone log. my bad | 23:54 |
| lbragstad | melwitt: yep - not sure what would have caused that though? | 23:54 |
| melwitt | yeah, that I don't know. it's really recent, started within the last couple of days I think | 23:54 |
| *** Sukhdev has quit IRC | 23:54 | |
| lbragstad | huh | 23:54 |
| lbragstad | sounds like it's consistent? | 23:54 |
| melwitt | I think it is, yeah. I've seen a few examples so far | 23:55 |
| melwitt | I feel like something like this has happened before too and I can't remember what it was, of course | 23:55 |
| melwitt | at least I have something to go on now, so I'll find it eventually | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
