| cfriesen | mriedem: aww, shucks. | 00:00 |
|---|---|---|
| mriedem | Kevin_Zheng: i tested it out and invalidated the bug, details are in the bug - looks like we handle it appropriately by default; it's ignored as a query parameter, and you get a 400 if you try to sort on 'fault' | 00:02 |
| *** priteau has joined #openstack-nova | 00:03 | |
| *** priteau has quit IRC | 00:03 | |
| *** tetsuro has joined #openstack-nova | 00:04 | |
| *** yamahata has joined #openstack-nova | 00:07 | |
| *** itlinux has joined #openstack-nova | 00:07 | |
| tetsuro | good morning | 00:12 |
| *** zhurong has joined #openstack-nova | 00:21 | |
| *** liuzz has joined #openstack-nova | 00:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_virt_drivers.py https://review.openstack.org/559878 | 00:27 |
| gmann | mriedem: yea, it is not in valid sort key as well as in ignore list also so this gives 400 - https://github.com/openstack/nova/blob/94b150bd79e5dfb4bdbb1aa9437c103ad5b80543/nova/api/openstack/compute/schemas/servers.py#L379 | 00:28 |
| gmann | tetsuro: morning | 00:30 |
| *** dpawlik has joined #openstack-nova | 00:33 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:33 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (2/3) https://review.openstack.org/550648 | 00:33 |
| *** gyee has quit IRC | 00:33 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (3/3) https://review.openstack.org/550659 | 00:33 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 00:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in tests/unit/test_utils.py https://review.openstack.org/557883 | 00:34 |
| *** dpawlik has quit IRC | 00:37 | |
| *** yamamoto has joined #openstack-nova | 00:43 | |
| *** artom has joined #openstack-nova | 00:45 | |
| *** dave-mccowan has joined #openstack-nova | 00:47 | |
| *** odyssey4me has quit IRC | 00:47 | |
| *** odyssey4me has joined #openstack-nova | 00:47 | |
| *** yamamoto has quit IRC | 00:48 | |
| mriedem | if anyone wants to chase down a functional test race bug over breakfast https://bugs.launchpad.net/nova/+bug/1762876 | 00:49 |
| openstack | Launchpad bug 1762876 in OpenStack Compute (nova) "KeyError during move operation functional tests" [Medium,Confirmed] | 00:49 |
| *** mriedem has quit IRC | 00:49 | |
| *** felipemonteiro__ has joined #openstack-nova | 00:50 | |
| *** germs has quit IRC | 00:51 | |
| *** germs has joined #openstack-nova | 00:52 | |
| *** germs has quit IRC | 00:52 | |
| *** germs has joined #openstack-nova | 00:52 | |
| naichuans | mriedem: Hi, Matt. Currently we have no test environments about live-migration in citrix CI, but we do have test jobs about it in Citrix XenRT, it is a internal test environment. And all the test related with the two patches are passed.https://review.openstack.org/#/c/489451/ and https://review.openstack.org/#/c/554154/ | 00:55 |
| *** jichen has joined #openstack-nova | 00:55 | |
| *** germs has quit IRC | 00:56 | |
| naichuans | efried: Thank you for the feedback. Will follow up blueprint nested-resource-providers-allocation-candidates | 00:56 |
| *** Dinesh__Bhor has joined #openstack-nova | 00:58 | |
| *** Dinesh_Bhor has quit IRC | 01:00 | |
| *** jackie-truong has joined #openstack-nova | 01:06 | |
| *** licanwei has joined #openstack-nova | 01:11 | |
| *** sahid has quit IRC | 01:11 | |
| *** zhaochao has joined #openstack-nova | 01:12 | |
| *** sahid has joined #openstack-nova | 01:13 | |
| *** wolverineav has quit IRC | 01:13 | |
| *** wolverin_ has joined #openstack-nova | 01:13 | |
| *** fragatina has quit IRC | 01:13 | |
| *** harlowja has quit IRC | 01:14 | |
| *** salv-orl_ has joined #openstack-nova | 01:14 | |
| *** fragatina has joined #openstack-nova | 01:14 | |
| *** fragatin_ has joined #openstack-nova | 01:16 | |
| *** salv-orlando has quit IRC | 01:17 | |
| *** fragatina has quit IRC | 01:18 | |
| *** gjayavelu has quit IRC | 01:19 | |
| *** fragatin_ has quit IRC | 01:20 | |
| *** tiendc has joined #openstack-nova | 01:21 | |
| *** takashin has quit IRC | 01:23 | |
| *** felipemonteiro__ has quit IRC | 01:25 | |
| *** suresh12 has quit IRC | 01:29 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 01:31 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 01:31 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 01:31 |
| Kevin_Zheng | mriedem strange, I thought that one went well.. | 01:31 |
| *** wolverin_ has quit IRC | 01:32 | |
| *** wolverineav has joined #openstack-nova | 01:32 | |
| *** wolverin_ has joined #openstack-nova | 01:35 | |
| *** wolverineav has quit IRC | 01:36 | |
| *** huanxie has joined #openstack-nova | 01:37 | |
| *** hongbin has joined #openstack-nova | 01:40 | |
| *** wolverin_ has quit IRC | 01:40 | |
| *** phuongnh has joined #openstack-nova | 01:42 | |
| *** germs has joined #openstack-nova | 01:44 | |
| *** germs has quit IRC | 01:44 | |
| *** germs has joined #openstack-nova | 01:44 | |
| *** yamamoto has joined #openstack-nova | 01:44 | |
| *** yamamoto has quit IRC | 01:50 | |
| *** wolverineav has joined #openstack-nova | 01:54 | |
| *** wolverineav has quit IRC | 01:58 | |
| *** dougshel_ has quit IRC | 01:59 | |
| *** zhurong has quit IRC | 02:00 | |
| *** wolverineav has joined #openstack-nova | 02:01 | |
| eandersson | How does database pools work with workers? Does the conductor have one db pool per proccess? | 02:08 |
| eandersson | and is the nova_api different? | 02:08 |
| *** hiro-kobayashi has joined #openstack-nova | 02:10 | |
| *** nicolasbock has quit IRC | 02:14 | |
| *** Dinesh__Bhor has quit IRC | 02:18 | |
| *** claudiub has quit IRC | 02:19 | |
| *** Dinesh__Bhor has joined #openstack-nova | 02:20 | |
| *** sdague has quit IRC | 02:23 | |
| *** bingqianglin has joined #openstack-nova | 02:32 | |
| *** germs has quit IRC | 02:32 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | 02:33 |
| *** takashin has joined #openstack-nova | 02:43 | |
| *** yamamoto has joined #openstack-nova | 02:47 | |
| *** tiendc has quit IRC | 02:47 | |
| *** r-daneel has joined #openstack-nova | 02:47 | |
| *** andreas_s has joined #openstack-nova | 02:49 | |
| *** yamamoto has quit IRC | 02:52 | |
| *** sambetts|afk has quit IRC | 02:53 | |
| *** andreas_s has quit IRC | 02:54 | |
| *** sambetts_ has joined #openstack-nova | 02:54 | |
| *** dave-mccowan has quit IRC | 02:56 | |
| *** juggsmcb has joined #openstack-nova | 02:56 | |
| *** tiendc has joined #openstack-nova | 02:57 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 02:57 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 02:57 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 02:57 |
| *** psachin has joined #openstack-nova | 03:00 | |
| *** juggsmcb has quit IRC | 03:03 | |
| *** imacdonn has quit IRC | 03:08 | |
| *** imacdonn has joined #openstack-nova | 03:08 | |
| *** psachin has quit IRC | 03:09 | |
| *** madhaviy has joined #openstack-nova | 03:10 | |
| *** fragatina has joined #openstack-nova | 03:20 | |
| openstackgerrit | Merged openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 03:21 |
| *** fragatina has quit IRC | 03:22 | |
| *** fragatina has joined #openstack-nova | 03:23 | |
| *** psachin has joined #openstack-nova | 03:26 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo https://review.openstack.org/551802 | 03:30 |
| *** tuanla____ has joined #openstack-nova | 03:31 | |
| *** tuanla____ has quit IRC | 03:33 | |
| *** tuanla____ has joined #openstack-nova | 03:33 | |
| *** vipul has quit IRC | 03:33 | |
| *** udesale has joined #openstack-nova | 03:34 | |
| *** suresh12 has joined #openstack-nova | 03:39 | |
| *** dikonoor has joined #openstack-nova | 03:48 | |
| *** yamamoto has joined #openstack-nova | 03:48 | |
| *** suresh12 has quit IRC | 03:49 | |
| *** yamamoto has quit IRC | 03:53 | |
| *** hongbin has quit IRC | 03:59 | |
| *** hiro-kobayashi has quit IRC | 04:02 | |
| *** fragatina has quit IRC | 04:06 | |
| *** fragatina has joined #openstack-nova | 04:06 | |
| *** hshiina has joined #openstack-nova | 04:09 | |
| *** madhaviy has quit IRC | 04:11 | |
| *** felipemonteiro__ has joined #openstack-nova | 04:13 | |
| *** takashin has quit IRC | 04:17 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 04:21 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 04:21 |
| *** jaosorior has joined #openstack-nova | 04:21 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 04:21 |
| *** harlowja has joined #openstack-nova | 04:23 | |
| *** sree has joined #openstack-nova | 04:26 | |
| *** udesale has quit IRC | 04:26 | |
| *** jackie-truong has quit IRC | 04:29 | |
| *** dpawlik has joined #openstack-nova | 04:33 | |
| *** suresh12 has joined #openstack-nova | 04:36 | |
| *** abhishekk has joined #openstack-nova | 04:37 | |
| *** vladikr has quit IRC | 04:37 | |
| *** dpawlik has quit IRC | 04:38 | |
| *** ssurana has joined #openstack-nova | 04:40 | |
| *** udesale has joined #openstack-nova | 04:45 | |
| *** stakeda has joined #openstack-nova | 04:46 | |
| openstackgerrit | Nakanishi Tomotaka proposed openstack/nova master: Test Compute API in multiple cells https://review.openstack.org/560260 | 04:46 |
| *** udesale has quit IRC | 04:46 | |
| *** madhaviy has joined #openstack-nova | 04:47 | |
| *** udesale has joined #openstack-nova | 04:47 | |
| *** yamamoto has joined #openstack-nova | 04:50 | |
| *** felipemonteiro_ has joined #openstack-nova | 04:51 | |
| *** felipemonteiro__ has quit IRC | 04:54 | |
| *** trinaths has joined #openstack-nova | 04:55 | |
| *** yamamoto has quit IRC | 04:55 | |
| *** zhaochao has quit IRC | 04:58 | |
| *** gjayavelu has joined #openstack-nova | 04:58 | |
| *** dineshbhor__ has joined #openstack-nova | 04:58 | |
| *** Dinesh__Bhor has quit IRC | 04:59 | |
| *** felipemonteiro_ has quit IRC | 05:02 | |
| *** dineshbhor__ has quit IRC | 05:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:12 | |
| *** sridharg has joined #openstack-nova | 05:15 | |
| *** zhaochao has joined #openstack-nova | 05:17 | |
| *** dikonoor has quit IRC | 05:24 | |
| *** tbachman has quit IRC | 05:25 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 05:25 |
| *** links has joined #openstack-nova | 05:29 | |
| *** suresh12 has quit IRC | 05:34 | |
| *** Eran_Kuris has joined #openstack-nova | 05:35 | |
| *** harlowja has quit IRC | 05:35 | |
| *** ratailor has joined #openstack-nova | 05:35 | |
| *** sidx64 has joined #openstack-nova | 05:36 | |
| *** markvoelker_ has quit IRC | 05:39 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 05:40 |
| *** takashin has joined #openstack-nova | 05:40 | |
| *** armaan has quit IRC | 05:42 | |
| *** armaan has joined #openstack-nova | 05:44 | |
| *** wolverineav has quit IRC | 05:46 | |
| *** trinaths has quit IRC | 05:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_neutron_security_groups.py https://review.openstack.org/560267 | 05:48 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | 05:49 |
| *** yamamoto has joined #openstack-nova | 05:52 | |
| *** yamamoto has quit IRC | 05:57 | |
| *** tbachman has joined #openstack-nova | 05:58 | |
| *** rodolof has joined #openstack-nova | 06:01 | |
| *** kholkina has joined #openstack-nova | 06:02 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 06:03 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 06:03 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 06:03 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 06:03 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 06:03 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 06:04 |
| *** suresh12 has joined #openstack-nova | 06:06 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | 06:07 |
| *** rodolof has quit IRC | 06:08 | |
| *** rodolof has joined #openstack-nova | 06:09 | |
| *** suresh12 has quit IRC | 06:11 | |
| *** sree has quit IRC | 06:11 | |
| *** sree has joined #openstack-nova | 06:12 | |
| *** sree has quit IRC | 06:13 | |
| *** sree has joined #openstack-nova | 06:13 | |
| *** sahid has quit IRC | 06:14 | |
| *** sahid has joined #openstack-nova | 06:15 | |
| *** hiro-kobayashi has joined #openstack-nova | 06:15 | |
| *** tbachman has quit IRC | 06:16 | |
| *** evin has joined #openstack-nova | 06:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 06:18 |
| *** dikonoor has joined #openstack-nova | 06:18 | |
| *** trinaths has joined #openstack-nova | 06:18 | |
| *** armaan has quit IRC | 06:19 | |
| *** tbachman has joined #openstack-nova | 06:19 | |
| *** armaan has joined #openstack-nova | 06:20 | |
| *** sree has quit IRC | 06:22 | |
| *** sree has joined #openstack-nova | 06:22 | |
| *** sree has quit IRC | 06:24 | |
| *** armaan has quit IRC | 06:24 | |
| *** dikonoor has quit IRC | 06:24 | |
| *** sree has joined #openstack-nova | 06:25 | |
| *** armaan has joined #openstack-nova | 06:25 | |
| *** sree has quit IRC | 06:26 | |
| *** sree has joined #openstack-nova | 06:27 | |
| *** hemna_ has quit IRC | 06:29 | |
| *** jhesketh_ is now known as jhesketh | 06:29 | |
| *** sree has quit IRC | 06:31 | |
| *** priteau has joined #openstack-nova | 06:32 | |
| *** belmoreira has joined #openstack-nova | 06:33 | |
| *** Dinesh__Bhor has joined #openstack-nova | 06:35 | |
| *** Dinesh_Bhor has quit IRC | 06:36 | |
| *** sidx64_ has joined #openstack-nova | 06:38 | |
| *** dpawlik has joined #openstack-nova | 06:39 | |
| *** sidx64 has quit IRC | 06:40 | |
| *** trinaths has quit IRC | 06:40 | |
| *** ragiman has joined #openstack-nova | 06:41 | |
| *** sree has joined #openstack-nova | 06:43 | |
| *** sidx64 has joined #openstack-nova | 06:43 | |
| *** sidx64_ has quit IRC | 06:43 | |
| *** dpawlik has quit IRC | 06:44 | |
| *** slaweq has joined #openstack-nova | 06:47 | |
| *** sree has quit IRC | 06:48 | |
| *** yamamoto has joined #openstack-nova | 06:53 | |
| *** alexchadin has joined #openstack-nova | 06:53 | |
| *** janki has joined #openstack-nova | 06:54 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:54 | |
| *** AlexeyAbashkin has quit IRC | 06:55 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:56 | |
| *** AlexeyAbashkin has quit IRC | 06:57 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 06:57 |
| *** AlexeyAbashkin has joined #openstack-nova | 06:57 | |
| *** yamamoto has quit IRC | 06:59 | |
| *** dpawlik has joined #openstack-nova | 06:59 | |
| *** sree has joined #openstack-nova | 07:05 | |
| *** trinaths has joined #openstack-nova | 07:06 | |
| *** rcernin has quit IRC | 07:06 | |
| *** trinaths has quit IRC | 07:06 | |
| *** yamamoto has joined #openstack-nova | 07:08 | |
| *** amoralej|off is now known as amoralej | 07:08 | |
| *** damien_r has joined #openstack-nova | 07:08 | |
| *** bingqianglin has quit IRC | 07:09 | |
| *** damien_r has quit IRC | 07:09 | |
| *** damien_r has joined #openstack-nova | 07:09 | |
| *** trinaths has joined #openstack-nova | 07:10 | |
| *** maciejjozefczyk has quit IRC | 07:10 | |
| *** ccamacho has joined #openstack-nova | 07:10 | |
| *** sree has quit IRC | 07:10 | |
| *** Dinesh__Bhor has quit IRC | 07:12 | |
| *** zhurong has joined #openstack-nova | 07:12 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 07:12 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 07:13 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 07:18 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | 07:19 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | 07:19 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | 07:19 |
| *** ssurana has quit IRC | 07:21 | |
| *** Dinesh__Bhor has joined #openstack-nova | 07:22 | |
| *** avolkov has joined #openstack-nova | 07:24 | |
| *** trinaths has quit IRC | 07:25 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296 | 07:27 |
| *** tesseract has joined #openstack-nova | 07:28 | |
| *** claudiub has joined #openstack-nova | 07:29 | |
| *** gcb has joined #openstack-nova | 07:30 | |
| *** andreas_s has joined #openstack-nova | 07:34 | |
| *** liuzz_ has joined #openstack-nova | 07:35 | |
| *** liuzz has quit IRC | 07:35 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299 | 07:38 |
| *** mgoddard has joined #openstack-nova | 07:40 | |
| *** belmoreira has quit IRC | 07:42 | |
| *** xinliang has quit IRC | 07:42 | |
| *** xinliang has joined #openstack-nova | 07:43 | |
| takashin | mriedem: Are you around? | 07:44 |
| takashin | mriedem: Could you look https://bugs.launchpad.net/nova/+bug/1762941 ? | 07:44 |
| openstack | Launchpad bug 1762941 in OpenStack Compute (nova) "testtools.matchers._impl.MismatchError: 'completed' != u'running' in test_bug_1718512.TestRequestSpecRetryReschedule.test_resize_with_reschedule_then_live_migrate" [Undecided,New] | 07:44 |
| *** belmoreira has joined #openstack-nova | 07:46 | |
| *** caisan_ has joined #openstack-nova | 07:47 | |
| *** yamamoto has quit IRC | 07:49 | |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** tssurya has joined #openstack-nova | 07:54 | |
| *** jpena|off is now known as jpena | 07:55 | |
| *** sree has joined #openstack-nova | 07:58 | |
| *** ktibi has joined #openstack-nova | 08:01 | |
| *** markvoelker has joined #openstack-nova | 08:01 | |
| *** tianhui_ has joined #openstack-nova | 08:03 | |
| *** tianhui has quit IRC | 08:05 | |
| *** takashin has left #openstack-nova | 08:05 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299 | 08:06 |
| *** sree has quit IRC | 08:08 | |
| *** zhurong has quit IRC | 08:08 | |
| *** trinaths has joined #openstack-nova | 08:09 | |
| *** lucas-afk is now known as lucasagomes | 08:11 | |
| *** pcaruana has joined #openstack-nova | 08:13 | |
| *** yamamoto has joined #openstack-nova | 08:13 | |
| *** yamamoto has quit IRC | 08:15 | |
| *** mdbooth has joined #openstack-nova | 08:16 | |
| *** belmoreira has quit IRC | 08:17 | |
| *** yamamoto has joined #openstack-nova | 08:19 | |
| *** mdnadeem has joined #openstack-nova | 08:20 | |
| *** belmoreira has joined #openstack-nova | 08:21 | |
| *** aloga_ has joined #openstack-nova | 08:22 | |
| *** ratailor has quit IRC | 08:24 | |
| *** ratailor has joined #openstack-nova | 08:27 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 08:28 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296 | 08:28 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 08:28 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299 | 08:34 |
| *** annp has quit IRC | 08:35 | |
| *** madhaviy has quit IRC | 08:36 | |
| *** trinaths has quit IRC | 08:38 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for traits (v1.6) https://review.openstack.org/514643 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | 08:39 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | 08:39 |
| *** derekh has joined #openstack-nova | 08:40 | |
| *** annp has joined #openstack-nova | 08:42 | |
| *** ratailor is now known as rtailor | 08:44 | |
| *** zhurong has joined #openstack-nova | 08:50 | |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 08:52 |
| *** yamamoto has quit IRC | 08:54 | |
| *** madhaviy has joined #openstack-nova | 08:54 | |
| *** yamamoto has joined #openstack-nova | 08:56 | |
| *** yamamoto has quit IRC | 08:58 | |
| *** yamamoto has joined #openstack-nova | 08:58 | |
| *** stakeda has quit IRC | 08:59 | |
| *** ttsiouts has joined #openstack-nova | 09:00 | |
| *** licanwei has left #openstack-nova | 09:01 | |
| *** madhaviy has quit IRC | 09:03 | |
| *** madhaviy has joined #openstack-nova | 09:04 | |
| *** hiro-kobayashi has quit IRC | 09:05 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 09:06 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:06 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 09:06 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 09:06 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 09:06 |
| *** tuanla____ has quit IRC | 09:14 | |
| *** phuongnh has quit IRC | 09:14 | |
| *** tiendc has quit IRC | 09:14 | |
| *** phuongnh has joined #openstack-nova | 09:15 | |
| *** tuanla____ has joined #openstack-nova | 09:15 | |
| *** tiendc has joined #openstack-nova | 09:15 | |
| *** lpetrut has joined #openstack-nova | 09:16 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296 | 09:19 |
| *** aloga_ has quit IRC | 09:20 | |
| *** Dinesh__Bhor has quit IRC | 09:24 | |
| *** gjayavelu has quit IRC | 09:35 | |
| kashyap | mdbooth: Hi, would you happen to have a minute to debug a unit test failure that's driving me nuts? | 09:38 |
| kashyap | mdbooth: That's the one: http://paste.openstack.org/show/718887/ | 09:39 |
| *** dpawlik has quit IRC | 09:39 | |
| mdbooth | kashyap: Not this morning I'm afraid | 09:39 |
| kashyap | mdbooth: Ah, no problem. | 09:39 |
| * kashyap is stepping through PDB, disregard me | 09:39 | |
| *** cdent has joined #openstack-nova | 09:40 | |
| *** tuanla____ has quit IRC | 09:40 | |
| *** annp has quit IRC | 09:40 | |
| *** dpawlik has joined #openstack-nova | 09:40 | |
| *** tuanla____ has joined #openstack-nova | 09:40 | |
| *** annp has joined #openstack-nova | 09:40 | |
| mdbooth | kashyap: Without any kind of in depth look, and assuming you're just seeing teeth-gnashing weirdness, I suggest either: | 09:43 |
| mdbooth | * You're not mocking what you think you're mocking | 09:43 |
| *** yamamoto has quit IRC | 09:43 | |
| mdbooth | * self._host.has_min_version returns something disgustingly pythonic with obtuse notions of true and false | 09:43 |
| *** yamamoto has joined #openstack-nova | 09:44 | |
| *** AlexeyAbashkin has quit IRC | 09:44 | |
| *** mgoddard has quit IRC | 09:44 | |
| kashyap | mdbooth: I think it's the former; the "mock" thing. | 09:45 |
| kashyap | I ran through PDB, and both: libvirt_driver.MIN_VIRTUOZZO_VERSION (from the test) and the MIN_VIRTUOZZO_VERSION from driver.py print the same version | 09:45 |
| kashyap | Anyway; thanks for the look. | 09:47 |
| *** alexchadin has quit IRC | 09:47 | |
| *** alexchadin has joined #openstack-nova | 09:48 | |
| *** alexchadin has quit IRC | 09:48 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 09:48 |
| *** alexchadin has joined #openstack-nova | 09:49 | |
| *** alexchadin has quit IRC | 09:49 | |
| mdbooth | kashyap: You're mocking driver._conn btw | 09:49 |
| mdbooth | But the test uses driver._host | 09:49 |
| mdbooth | s/test/code/ | 09:49 |
| * kashyap looks | 09:49 | |
| *** alexchadin has joined #openstack-nova | 09:50 | |
| *** alexchadin has quit IRC | 09:50 | |
| *** alexchadin has joined #openstack-nova | 09:50 | |
| *** sahid has quit IRC | 09:50 | |
| *** alexchadin has quit IRC | 09:51 | |
| *** alexchadin has joined #openstack-nova | 09:51 | |
| mdbooth | kashyap: Unfortunately your problem is vastly more interesting than what I'm actually supposed to be doing. | 09:51 |
| *** alexchadin has quit IRC | 09:51 | |
| * mdbooth tries to ignore it | 09:51 | |
| kashyap | :-) | 09:51 |
| *** alexchadin has joined #openstack-nova | 09:52 | |
| * kashyap is trying to fix the unit test fallout of bumping versions | 09:52 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299 | 09:52 |
| mdbooth | kashyap: Don't assume that the previous unit test was correct. It may have worked only by coincidence. This isn't uncommon. | 09:53 |
| kashyap | This doesn't fly either: | 09:54 |
| kashyap | + with mock.patch.object(driver.init_host, 'getVersion') \ | 09:54 |
| kashyap | + as mock_getver: | 09:54 |
| kashyap | mdbooth: Sigh, yeah, I recall johnthetubaguy saying our MIN_VERSIONS testing has been a "joke" | 09:54 |
| mdbooth | driver.init_host is a function | 09:54 |
| mdbooth | That doesn't really make sense | 09:54 |
| * kashyap tries to stop being stupid | 09:55 | |
| mdbooth | If you look at Host.has_min_version | 09:55 |
| mdbooth | See that _version_check gets version from conn.getLibVersion | 09:56 |
| kashyap | Aah, I remove that: | 09:56 |
| mdbooth | Where conn is returned by Host.get_connection() | 09:56 |
| *** alexchadin has quit IRC | 09:56 | |
| *** tetsuro has quit IRC | 09:57 | |
| * kashyap looks closer | 09:57 | |
| mdbooth | You need the return value of Host.get_connection() to return an object whose getLibVersion() method returns your test value | 09:58 |
| mdbooth | You can do that with Mock | 09:58 |
| mdbooth | I wonder if you can also do it with FakeVirtAPI | 09:59 |
| kashyap | (Hmm, yeah: host.has_min_version --> _version_check --> getLibVersion) | 09:59 |
| kashyap | mdbooth: Yeah, if we can do it with the FakeVirtAPI, shouldn't I go that route, instead? | 09:59 |
| mdbooth | It looks like you can just mock fakelibvirt.FAKE_LIBVIRT_VERSION | 10:00 |
| mdbooth | And it will do what you want | 10:00 |
| * mdbooth gets back to work | 10:00 | |
| kashyap | mdbooth: NOte that we'd like to check: MIN_VIRTUOZZO_VERSION is OK. | 10:00 |
| kashyap | But thanks for the walk through | 10:00 |
| kashyap | Hey, this is also "work", but yeah, "someone else's work", though :P | 10:01 |
| mdbooth | ^^^ is how to change the value it's testing against | 10:01 |
| kashyap | mdbooth: Noted; will play a bit more and see where I arrive | 10:02 |
| *** mgoddard has joined #openstack-nova | 10:02 | |
| *** tuanla____ has quit IRC | 10:03 | |
| *** phuongnh has quit IRC | 10:03 | |
| *** tuanla____ has joined #openstack-nova | 10:03 | |
| *** phuongnh has joined #openstack-nova | 10:04 | |
| *** sree has joined #openstack-nova | 10:05 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: trivial: fix a comment typo https://review.openstack.org/560349 | 10:08 |
| *** tiendc has quit IRC | 10:09 | |
| *** sree has quit IRC | 10:09 | |
| *** tiendc has joined #openstack-nova | 10:10 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Add lower-constraints job https://review.openstack.org/556056 | 10:11 |
| *** tuanla____ has quit IRC | 10:14 | |
| *** annp has quit IRC | 10:14 | |
| *** tuanla____ has joined #openstack-nova | 10:14 | |
| *** annp has joined #openstack-nova | 10:15 | |
| *** sree has joined #openstack-nova | 10:15 | |
| *** haha1 has joined #openstack-nova | 10:16 | |
| *** alexchadin has joined #openstack-nova | 10:23 | |
| *** rajinir has quit IRC | 10:25 | |
| *** lpetrut has quit IRC | 10:27 | |
| *** lpetrut has joined #openstack-nova | 10:30 | |
| kashyap | mdbooth: Thanks for the idea! It seemed to have worked. | 10:32 |
| *** caisan_ has quit IRC | 10:35 | |
| *** armaan has quit IRC | 10:36 | |
| *** annp has quit IRC | 10:36 | |
| *** armaan has joined #openstack-nova | 10:36 | |
| *** nicolasbock has joined #openstack-nova | 10:37 | |
| *** abhishekk has quit IRC | 10:38 | |
| *** haha1 has quit IRC | 10:39 | |
| *** haha1 has joined #openstack-nova | 10:39 | |
| *** AlexeyAbashkin has joined #openstack-nova | 10:40 | |
| *** madhaviy has quit IRC | 10:43 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 10:44 |
| *** madhaviy has joined #openstack-nova | 10:44 | |
| *** moshele has joined #openstack-nova | 10:45 | |
| *** alexchadin has quit IRC | 10:45 | |
| *** ccamacho has quit IRC | 10:46 | |
| *** ccamacho has joined #openstack-nova | 10:48 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 10:50 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_{LIBVIRT_KVM,QEMU}_S390_VERSION https://review.openstack.org/560363 | 10:50 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_KVM_PPC64_VERSION https://review.openstack.org/560364 | 10:50 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365 | 10:50 |
| *** alexchadin has joined #openstack-nova | 10:50 | |
| *** dougshelley66 has joined #openstack-nova | 10:52 | |
| *** sdague has joined #openstack-nova | 10:58 | |
| *** phuongnh has quit IRC | 11:02 | |
| *** madhaviy has quit IRC | 11:03 | |
| *** alexchadin has quit IRC | 11:03 | |
| *** madhaviy has joined #openstack-nova | 11:04 | |
| *** tuanla____ has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/nova master: make metadata doc up to date https://review.openstack.org/559613 | 11:10 |
| openstackgerrit | Merged openstack/nova master: Log a more useful error when neutron isn't configured https://review.openstack.org/559111 | 11:10 |
| openstackgerrit | Merged openstack/nova master: doc: add a link in the install guides about configuring neutron https://review.openstack.org/559115 | 11:10 |
| openstackgerrit | Merged openstack/nova master: Log a more useful error when cinder auth isn't configured https://review.openstack.org/559399 | 11:11 |
| *** xinliang has quit IRC | 11:11 | |
| openstackgerrit | Merged openstack/nova master: Move test_report_client out of placement namespace https://review.openstack.org/558911 | 11:11 |
| openstackgerrit | Merged openstack/nova master: Update the Cell filters section of the scheduler docs https://review.openstack.org/559108 | 11:11 |
| *** dpawlik_ has joined #openstack-nova | 11:13 | |
| *** dpawlik has quit IRC | 11:13 | |
| *** yamamoto has quit IRC | 11:18 | |
| *** sahid has joined #openstack-nova | 11:21 | |
| *** xinliang has joined #openstack-nova | 11:22 | |
| *** yamamoto has joined #openstack-nova | 11:25 | |
| *** sahid has quit IRC | 11:26 | |
| *** sahid has joined #openstack-nova | 11:28 | |
| *** sambetts_ is now known as sambetts | 11:28 | |
| *** yamamoto has quit IRC | 11:30 | |
| *** madhaviy has quit IRC | 11:33 | |
| *** yamamoto has joined #openstack-nova | 11:34 | |
| *** tbachman has quit IRC | 11:35 | |
| *** mdbooth has quit IRC | 11:37 | |
| *** dougshel_ has joined #openstack-nova | 11:38 | |
| *** armaan has quit IRC | 11:39 | |
| *** yamamoto has quit IRC | 11:39 | |
| *** armaan has joined #openstack-nova | 11:39 | |
| *** dougshelley66 has quit IRC | 11:41 | |
| *** tbachman has joined #openstack-nova | 11:43 | |
| *** jpena is now known as jpena|lunch | 11:46 | |
| *** tbachman has quit IRC | 11:47 | |
| *** QianYu has joined #openstack-nova | 11:51 | |
| *** QianYu_ has joined #openstack-nova | 11:54 | |
| *** QianYu has quit IRC | 11:54 | |
| *** madhaviy has joined #openstack-nova | 12:01 | |
| *** amoralej is now known as amoralej|lunch | 12:01 | |
| *** QianYu_ has quit IRC | 12:02 | |
| *** edmondsw has joined #openstack-nova | 12:08 | |
| *** QianYu has joined #openstack-nova | 12:10 | |
| *** QianYu has quit IRC | 12:12 | |
| *** liverpooler has joined #openstack-nova | 12:12 | |
| *** odyssey4me has quit IRC | 12:14 | |
| *** odyssey4me has joined #openstack-nova | 12:14 | |
| *** alexchadin has joined #openstack-nova | 12:15 | |
| *** QianYu has joined #openstack-nova | 12:16 | |
| *** QianYu has quit IRC | 12:16 | |
| *** yamamoto has joined #openstack-nova | 12:21 | |
| *** sean-k-mooney has joined #openstack-nova | 12:23 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** AlexeyAbashkin has quit IRC | 12:25 | |
| *** dougshelley66 has joined #openstack-nova | 12:25 | |
| *** AlexeyAbashkin has joined #openstack-nova | 12:25 | |
| *** gcb has quit IRC | 12:27 | |
| *** AlexeyAbashkin has quit IRC | 12:30 | |
| efried | mikal: Are you satisfied with the response/rework at https://review.openstack.org/#/c/527658/31/nova/virt/zvm/configdrive.py@44 ? | 12:31 |
| efried | It looks to me like the (guest) format is indeed iso9660, which I think is what you wanted to make sure of. | 12:31 |
| *** yamamoto has joined #openstack-nova | 12:34 | |
| *** AlexeyAbashkin has joined #openstack-nova | 12:34 | |
| *** madhaviy has quit IRC | 12:35 | |
| *** dave-mccowan has joined #openstack-nova | 12:35 | |
| *** mdbooth has joined #openstack-nova | 12:37 | |
| *** liverpooler has quit IRC | 12:37 | |
| *** liverpooler has joined #openstack-nova | 12:37 | |
| *** burt has joined #openstack-nova | 12:40 | |
| *** tiendc has quit IRC | 12:40 | |
| *** mvk has quit IRC | 12:40 | |
| *** hshiina is now known as hshiina|afk | 12:41 | |
| *** tbachman has joined #openstack-nova | 12:43 | |
| *** vladikr has joined #openstack-nova | 12:45 | |
| *** tbachman_ has joined #openstack-nova | 12:46 | |
| *** tbachman has quit IRC | 12:47 | |
| *** tbachman_ is now known as tbachman | 12:47 | |
| *** READ10 has joined #openstack-nova | 12:49 | |
| *** dpawlik_ has quit IRC | 12:50 | |
| jichen | efried: thanks for raising this question to mikal, yes, as mentioned in the patch, we use tgz as is09660 and consume it later by mounting it to VM as iso9660 format before cloud-init take action | 12:50 |
| *** jpena|lunch is now known as jpena | 12:50 | |
| *** _ix has joined #openstack-nova | 12:53 | |
| *** dpawlik has joined #openstack-nova | 12:53 | |
| *** pchavva has joined #openstack-nova | 12:54 | |
| *** salv-orl_ has quit IRC | 12:54 | |
| *** felipemonteiro has joined #openstack-nova | 12:54 | |
| *** ccamacho is now known as ccamacho|lunch | 12:57 | |
| *** tbachman_ has joined #openstack-nova | 12:57 | |
| *** dpawlik has quit IRC | 12:57 | |
| *** armaan has quit IRC | 12:58 | |
| *** lyan has joined #openstack-nova | 12:58 | |
| *** lyan is now known as Guest25648 | 12:58 | |
| *** armaan has joined #openstack-nova | 12:58 | |
| *** jaypipes has joined #openstack-nova | 12:59 | |
| *** tbachman has quit IRC | 12:59 | |
| *** tbachman_ is now known as tbachman | 12:59 | |
| *** amoralej|lunch is now known as amoralej | 13:01 | |
| *** armaan has quit IRC | 13:03 | |
| openstackgerrit | Merged openstack/nova master: Cleanup tempest-dsvm-cells-rc blacklist https://review.openstack.org/553401 | 13:05 |
| *** psachin has quit IRC | 13:05 | |
| *** mriedem has joined #openstack-nova | 13:06 | |
| *** felipemonteiro_ has joined #openstack-nova | 13:07 | |
| *** rtailor has quit IRC | 13:07 | |
| *** _ix has quit IRC | 13:09 | |
| *** felipemonteiro has quit IRC | 13:10 | |
| *** _ix has joined #openstack-nova | 13:11 | |
| *** mvk has joined #openstack-nova | 13:11 | |
| openstackgerrit | Merged openstack/nova master: Cleanup _get_request_spec_for_select_destinations for live migrate https://review.openstack.org/559381 | 13:15 |
| *** felipemonteiro_ has quit IRC | 13:15 | |
| *** felipemonteiro__ has joined #openstack-nova | 13:15 | |
| *** _ix has quit IRC | 13:16 | |
| *** _ix has joined #openstack-nova | 13:16 | |
| *** READ10 has quit IRC | 13:16 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:17 | |
| *** jbernard has quit IRC | 13:18 | |
| *** caisan has joined #openstack-nova | 13:20 | |
| *** READ10 has joined #openstack-nova | 13:21 | |
| *** jbernard has joined #openstack-nova | 13:23 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 13:24 |
| *** dpawlik has joined #openstack-nova | 13:25 | |
| *** dillaman has joined #openstack-nova | 13:26 | |
| *** maciejjozefczyk has quit IRC | 13:26 | |
| *** _ix has quit IRC | 13:29 | |
| *** sidx64 has quit IRC | 13:30 | |
| *** gcb has joined #openstack-nova | 13:33 | |
| *** esberglu has joined #openstack-nova | 13:35 | |
| *** sidx64 has joined #openstack-nova | 13:35 | |
| openstackgerrit | jichenjc proposed openstack/nova master: uncap eventlet in nova https://review.openstack.org/560420 | 13:36 |
| bhagyashris | jaypipes: Hi, | 13:41 |
| *** david-lyle has joined #openstack-nova | 13:41 | |
| mriedem | sahid: are you also working on the metadata api changes for https://review.openstack.org/#/q/topic:bp/sriov-trusted-vfs+(status:open+OR+status:merged) ? i don't want to merge too much of that series before the metadata api patch is up | 13:41 |
| jichen | mriedem: not sure https://review.openstack.org/560420 is the right way to do ... but my previous zvm patches failed due to requirement.txt . or we need wait for the automatic process of requirements update? | 13:42 |
| mriedem | jichen: i didn't think there was an automated reqs update anymore | 13:44 |
| mriedem | i haven't tried to follow that thread | 13:44 |
| *** alexchadin has quit IRC | 13:44 | |
| sahid | mriedem: i'm a bit under pressure with the specs i have to work on and my downstream work... I need to build an on a SRIOV to test what you have indicated on the review then I will work on the metadata thing | 13:44 |
| sahid | but yes it's my plan | 13:44 |
| mriedem | sahid: ok thanks | 13:44 |
| jichen | mriedem: ok , I don't have too much background on that stuff, anyway, I followed their patch and updated nova accordingly | 13:45 |
| jichen | hopefully anyone can take a look | 13:45 |
| *** dklyle has quit IRC | 13:45 | |
| mriedem | jichen: https://review.openstack.org/#/c/559367/ is merged | 13:46 |
| mriedem | so it seems we don't need this in nova? | 13:46 |
| *** hongbin has joined #openstack-nova | 13:47 | |
| jichen | mriedem , no , I guess that's the reason caused my issue http://logs.openstack.org/87/523387/32/check/requirements-check/408e28c/job-output.txt.gz, Doug replied in ML and say that's a correct error ... | 13:47 |
| *** david-lyle has quit IRC | 13:47 | |
| *** zz9pzza has quit IRC | 13:48 | |
| jichen | so I assume we need some changes but not too much experience here | 13:48 |
| mriedem | ok that's a different change https://review.openstack.org/#/c/523387/ | 13:48 |
| *** madhaviy has joined #openstack-nova | 13:48 | |
| mriedem | ok i can try to sort this out, i know it's late for you | 13:48 |
| jichen | ok, thank you for your help | 13:48 |
| openstackgerrit | Merged openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | 13:50 |
| openstackgerrit | Merged openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 13:50 |
| jaypipes | bhagyashris: did you need something? | 13:51 |
| *** udesale has quit IRC | 13:51 | |
| *** armaan has joined #openstack-nova | 13:51 | |
| efried | mriedem: I noticed your reference to https://wiki.openstack.org/wiki/NovaAPIRef#Parameter_Verification in a patch. I have to say I don't agree that the ordering (required=>optional=>by-microversion) should be strictly followed where it doesn't make sense. For example, here https://review.openstack.org/#/c/517757/7/placement-api-ref/source/allocation_candidates.inc it makes more logical sense to order them this way. If I | 13:52 |
| efried | would be after limits, the granulars would be after member_of... IMO it's better if it's in the most sensible logical order for users of the latest microversion. | 13:52 |
| *** jichen has quit IRC | 13:53 | |
| bhagyashris | jaypipes: Jus want to inform few thing regarding the shared resource provider that we have discussed earlier, I have done some testing and analysis. | 13:53 |
| bhagyashris | jaypipes: s/Jus/just | 13:54 |
| *** felipemonteiro_ has joined #openstack-nova | 13:54 | |
| mriedem | efried: you'll have to debate that with sdague | 13:54 |
| mriedem | i assume microversions come last in order because we are trying to write api ref docs for the lowest common denominator | 13:55 |
| efried | mriedem: Maybe placement is different. | 13:55 |
| mriedem | placement is always different | 13:55 |
| *** ttx has quit IRC | 13:55 | |
| *** caisan has quit IRC | 13:55 | |
| efried | mriedem: I'm not necessarily suggesting action (like an edit of the guidelines). Just something I noticed and wanted to get off my chest. | 13:56 |
| efried | Thanks for listening :) | 13:56 |
| *** ttx has joined #openstack-nova | 13:57 | |
| *** tbachman has quit IRC | 13:57 | |
| bhagyashris | jaypipes: I have tested the scenario and here are the observation http://paste.openstack.org/show/718936/ | 13:57 |
| *** sdague has quit IRC | 13:57 | |
| *** tbachman has joined #openstack-nova | 13:58 | |
| *** links has quit IRC | 13:58 | |
| *** felipemonteiro__ has quit IRC | 13:58 | |
| efried | bhagyashris: Woot! That looks just like it should! | 13:58 |
| jaypipes | efried: indeed, after commenting out the "compute node sets DISK_GB inventory item automatically" code. | 13:59 |
| bhagyashris | efried, jaypipes: Based on the current analysis, it appears that compute node shouldn't report it's own resources in inventory if it's configured to use it from shared resource providers but currently, compute node doesn't have any mechanism to report selective resources in inventory. | 13:59 |
| *** eharney has joined #openstack-nova | 14:00 | |
| *** udesale has joined #openstack-nova | 14:00 | |
| jaypipes | bhagyashris: correct. the original idea was to use the aggregates information in the ProviderTree to determine whether to report "local disk" or not. | 14:00 |
| openstackgerrit | Steve Noyes proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643 | 14:00 |
| jaypipes | bhagyashris: efried can share some information with you about the aggregate tracking in the ProviderTree object | 14:00 |
| efried | jaypipes: You're saying that if we find a sharing provider for a given RC, we should *remove* that RC from the compute node's inventory?? | 14:01 |
| jaypipes | efried: I'm saying that was my original idea, yeah. | 14:01 |
| bhagyashris | efried, jaypipes: There is a TODO note here : https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L212-L216 that the first allocation request object is use to claim resources | 14:01 |
| jaypipes | (that's why I originally added the aggregate tracking in the reportclient to begin with) | 14:01 |
| efried | bhagyashris: jaypipes: Do we have any evidence that the virt driver actually *used* the shared storage to make the disk? | 14:02 |
| *** jistr is now known as jistr|mtg | 14:02 | |
| jaypipes | bhagyashris: yes, but that's more about the use case where we have both shared and local disk and can't decide which to consume from. what efried and I are discussing is how to signal to the compute node not to report local disk if it sees a sharing provider of disk. | 14:02 |
| efried | or has that piece not been hooked up yet? | 14:02 |
| bhagyashris | efried, jaypipes: yeah that is the best idea and that will not need to make any change at sch side | 14:02 |
| *** ccamacho|lunch is now known as ccamacho | 14:02 | |
| jaypipes | efried: well, that's an entirely different question :) | 14:02 |
| efried | But an important one, you'll agree. | 14:03 |
| jaypipes | efried: and I see no reason why it wouldn't. | 14:03 |
| bhagyashris | jaypipes: yeah totally agree with you point | 14:03 |
| efried | Doesn't do us much good to have the alloc come from the right place if the storage still comes from the wrong place. | 14:03 |
| jaypipes | efried: it's the same reason why pinning of CPU resources still works even though VCPU is tracked in placement. | 14:03 |
| jaypipes | efried: in other words, assignment != allocation | 14:03 |
| efried | jaypipes: So you're saying that by virtue of whatever existing code recognized the flavor request as wanting the storage to come from shared... is still working. | 14:04 |
| efried | I don't know what that mechanism is, but if that's the case... fine. | 14:04 |
| jaypipes | efried: don't confuse a request for 10TB of disk with block device configuration information. | 14:04 |
| efried | ah, the bdm somehow identifies the source of the disk space? | 14:05 |
| *** caisan has joined #openstack-nova | 14:05 | |
| jaypipes | efried: no. nothing really knows whether the source of the disk space is shared. it's just that /var/lib/instances is on mounted shared storage. | 14:05 |
| jaypipes | efried: that's pretty much the reason why shared storage resource accounting has been so wonky. | 14:06 |
| efried | ohh. | 14:06 |
| efried | So in this setup, there really *is* no local storage. | 14:06 |
| jaypipes | efried: there totally *could* be. no way to know other than manually commenting out that code right now. | 14:06 |
| openstackgerrit | Merged openstack/nova master: Update wording in @safe_connect placement warnings https://review.openstack.org/560039 | 14:06 |
| bhagyashris | jaypipes: yeah that way I have tested | 14:07 |
| *** madhaviy has quit IRC | 14:07 | |
| jaypipes | efried: for the record, we used to determine if "the node was on shared storage" by literally attempting to write a file from two different compute hosts to a single location and checking if each node could read it. | 14:07 |
| jaypipes | efried: IIRC, this was during live migration setup. | 14:08 |
| efried | jaypipes: So here's where the virt driver would need to recognize whether the storage is shared or not, and if so, create* the sharing provider and put the DISK_GB inventory there instead of the compute node RP. | 14:08 |
| efried | (*create, co-create, make sure it exists, etc.) | 14:08 |
| jaypipes | efried: not sure if we still do that, but that's how it used to be. | 14:08 |
| *** diga has joined #openstack-nova | 14:08 | |
| jaypipes | efried: no, the idea was never to have a compute node create the sharing provider. | 14:08 |
| efried | don't focus on that bit. | 14:08 |
| jaypipes | efried: the admin would do that, since they know they are setting up shared storage for a set of nodes. | 14:09 |
| efried | well, okay; I'm also thinking about the PowerVM case, where we *do* want the driver to co-manage creation of the sharing provider. | 14:09 |
| efried | because that would also be a non-hacky way to get rid of the compute node RP's DISK_GB inventory :) | 14:10 |
| efried | Because we can't just blindly remove it (outside of the virt driver) based on the presence of an aggregated provider of the same RC. | 14:10 |
| jaypipes | efried: I don't understand that last sentence. | 14:11 |
| efried | We may legitimately have both shared and local at the same time. We may legitimately want the virt driver to do that management, etc. | 14:11 |
| *** tbachman has quit IRC | 14:11 | |
| jaypipes | efried: why would you want the virt driver on a single compute node managing disk resources for multiple compute nodes? | 14:11 |
| efried | jaypipes: I'm just saying if we're going to fiddle with the compute RP's DISK_GB inventory based on existence of sharing DISK_GB providers, that logic needs to be fully owned by the virt driver. We can't assume things outside of that scope. | 14:11 |
| jaypipes | efried: sure. the process of fiddling with any resources that are owned by that compute node (and its children) should of course be controlled by the virt driver. | 14:12 |
| efried | jaypipes: In the PowerVM case, it's because we can; and because we can, it means we don't need any outside agent (human or code) manitaining that sharing RP. | 14:13 |
| jaypipes | efried: I don't agree that a single compute node should control inventory on shared disk providers, though. | 14:13 |
| jaypipes | efried: then powervm can do that I guess. | 14:13 |
| jaypipes | efried: obviously libvirt won't :) | 14:13 |
| efried | It won't be a single compute node; it'll all the compute nodes attached to that sharing provider. | 14:13 |
| *** salv-orlando has joined #openstack-nova | 14:13 | |
| efried | co-managing the SSP. | 14:13 |
| jaypipes | efried: right, because it's a clustered hypervisor manager. | 14:13 |
| efried | ...because they already co-manage the SSP (outside of the auspices of openstack) | 14:13 |
| efried | yeah, that. | 14:14 |
| jaypipes | in any case... | 14:14 |
| efried | So anyway, I'm saying I'm on board with the idea if we state it like this: | 14:14 |
| efried | Because libvirt (somehow) knows that the storage it's looking at is shared, libvirt's impl of update_provider_tree shall remove the DISK_GB inventory from the compute node RP. | 14:15 |
| efried | Perhaps the (somehow) is signalled by the operator having created the sharing provider and associated it via aggregate with the compute node. | 14:15 |
| efried | libvirt's u_p_t will look for that and, if found, nix the compute RP's DISK_GB inventory. | 14:16 |
| efried | Does that gel with your thinking? | 14:16 |
| *** kholkina has quit IRC | 14:16 | |
| efried | zero part of this involves nova code outside of the libvirt driver. | 14:16 |
| jaypipes | efried: that is precisely my thinking, yes. | 14:17 |
| *** cristicalin has joined #openstack-nova | 14:17 | |
| *** tbachman has joined #openstack-nova | 14:17 | |
| efried | jaypipes: Cool beans. bhagyashris, are you on the hook for proposing that code? I can help you understand how to make it work. | 14:18 |
| bhagyashris | efried: ok means the CN RP DISK_GB inventory will be remove if the shared resource provider is configured | 14:19 |
| efried | bhagyashris: Yes. The part I was unclear on at first was that that would be done within the libvirt compute driver's implementation of update_provider_tree. | 14:19 |
| *** jobewan has joined #openstack-nova | 14:19 | |
| efried | ...which I bet hasn't been proposed yet. | 14:20 |
| mriedem | fyi if you see test_resize_with_reschedule_then_live_migrate failing in functional tests, it's https://bugs.launchpad.net/nova/+bug/1762876 | 14:21 |
| openstack | Launchpad bug 1762876 in OpenStack Compute (nova) "test_resize_with_reschedule_then_live_migrate intermittently failing; migration is not yet complete" [High,Confirmed] - Assigned to Matt Riedemann (mriedem) | 14:21 |
| mriedem | i'm working on a fix | 14:21 |
| mriedem | apparently the instance status goes to ACTIVE before the migration is completed | 14:22 |
| bhagyashris | efried: ok. so for this is there any bp or bug reported? Actually i am not fully aware about update_provider_tree part but i will start to understand that part and will get to know | 14:24 |
| bhagyashris | efried: I just tested few things and put my observations and analysis | 14:24 |
| efried | bhagyashris: There's a blueprint around update_provider_tree. It's substantially completed, and ready for virt drivers to start using it. | 14:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Make NetworkAPI an abstract base class https://review.openstack.org/560440 | 14:25 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove :return from update_provider_tree docstring https://review.openstack.org/560442 | 14:25 |
| efried | jaypipes: Fast approve-worthy ^ | 14:25 |
| jaypipes | efried: done | 14:27 |
| efried | jaypipes: Thanks. Not sure how I missed that. | 14:27 |
| jaypipes | efried: you didn't. I did. | 14:27 |
| efried | :) | 14:28 |
| *** mlavalle has joined #openstack-nova | 14:30 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: libvirt: get_inventory => update_provider_tree https://review.openstack.org/560444 | 14:30 |
| efried | jaypipes, bhagyashris: ^ | 14:30 |
| efried | That would go under 'co-authorship candidate' in our fancy etherpad, cause I don't know from libvirt. | 14:31 |
| efried | But now it can be used as the basis for what we discussed above. | 14:31 |
| *** tianhui_ has quit IRC | 14:32 | |
| *** tianhui has joined #openstack-nova | 14:33 | |
| *** vladikr has quit IRC | 14:33 | |
| mriedem | gibi_awa1: my wedding gift to you is going to be bugs to discuss during the notifications meeting :) https://wiki.openstack.org/wiki/Meetings/NovaNotification#Agenda | 14:33 |
| *** itlinux has quit IRC | 14:34 | |
| *** vladikr has joined #openstack-nova | 14:34 | |
| *** dklyle has joined #openstack-nova | 14:35 | |
| *** dklyle has quit IRC | 14:36 | |
| *** david-lyle has joined #openstack-nova | 14:36 | |
| *** hemna_ has joined #openstack-nova | 14:39 | |
| *** amodi has joined #openstack-nova | 14:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race fail in test_resize_with_reschedule_then_live_migrate https://review.openstack.org/560454 | 14:45 |
| mriedem | dansmith: efried: ^ fixes a regression i introduced | 14:45 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 14:47 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: move version to string in utils https://review.openstack.org/560455 | 14:47 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: refactor get_base_config to accept host arg https://review.openstack.org/560456 | 14:47 |
| efried | mriedem: Reviewed. | 14:47 |
| *** sdague has joined #openstack-nova | 14:47 | |
| *** dklyle has joined #openstack-nova | 14:47 | |
| *** david-lyle has quit IRC | 14:47 | |
| *** evin has quit IRC | 14:47 | |
| mriedem | thanks | 14:48 |
| efried | bhagyashris, jaypipes: Is there a bug for the double-reporting of DISK_GB? | 14:48 |
| bhagyashris | efried: Don't know exactly. I have just fetch your patch https://review.openstack.org/560444 and checked inventory table records | 14:50 |
| *** felipemonteiro_ has quit IRC | 14:50 | |
| efried | bhagyashris: Oh - does it work?? | 14:50 |
| *** felipemonteiro_ has joined #openstack-nova | 14:50 | |
| bhagyashris | efried: but still it showing the DISK_GB record in inventory table as i configured the shared resource provider | 14:51 |
| efried | bhagyashris: Yup, that's expected. The above patch should have been a straight swap. | 14:51 |
| efried | bhagyashris: But this one.... | 14:51 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459 | 14:51 |
| efried | jaypipes: bhagyashris ^ | 14:51 |
| *** rajinir has joined #openstack-nova | 14:51 | |
| efried | ...should do the thing we were talking about. | 14:51 |
| efried | bhagyashris: Since you seem to be set up to try this easily, would you mind...? | 14:51 |
| openstackgerrit | Merged openstack/nova master: api-ref: Parameter verification for servers.inc (2/3) https://review.openstack.org/550648 | 14:51 |
| openstackgerrit | Merged openstack/nova master: api-ref: Parameter verification for servers.inc (3/3) https://review.openstack.org/550659 | 14:55 |
| *** moshele has quit IRC | 14:55 | |
| *** markvoelker has quit IRC | 14:55 | |
| *** markvoelker has joined #openstack-nova | 14:56 | |
| bhagyashris | efried: so it's not working so don't know why it's not | 14:56 |
| *** Eran_Kuris has quit IRC | 14:56 | |
| bhagyashris | efried: let me check with this patch change https://review.openstack.org/560459 | 14:57 |
| *** zz9pzza has joined #openstack-nova | 14:58 | |
| openstackgerrit | Merged openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 14:58 |
| *** markvoelker has quit IRC | 15:00 | |
| *** _ix has joined #openstack-nova | 15:01 | |
| *** armaan has quit IRC | 15:08 | |
| *** Guest25648 has quit IRC | 15:08 | |
| *** Guest25648 has joined #openstack-nova | 15:08 | |
| *** ratailor has joined #openstack-nova | 15:08 | |
| *** armaan has joined #openstack-nova | 15:09 | |
| *** jistr|mtg is now known as jistr | 15:10 | |
| bhagyashris | efried: we will need to use that update_provider_tree() method in https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L890 | 15:11 |
| *** germs has joined #openstack-nova | 15:11 | |
| *** germs has quit IRC | 15:11 | |
| *** germs has joined #openstack-nova | 15:11 | |
| efried | bhagyashris: Yup, see https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L881 | 15:11 |
| bhagyashris | efried: so that it will get the proper inv_data and will update here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L892 | 15:11 |
| efried | bhagyashris: Is it not getting invoked? | 15:12 |
| efried | (Did you remember to restart your compute service? :) | 15:12 |
| bhagyashris | yes i restart n-cpu | 15:13 |
| *** Spazmotic1 has joined #openstack-nova | 15:13 | |
| bhagyashris | but it's giving problem in second patch now that the provider_tree has no attribute data | 15:14 |
| efried | bhagyashris: Well, there *is* no get_inventory in the libvirt driver anymore, so if you're seeing inventory at all, it must have come from here. | 15:14 |
| efried | bhagyashris: I didn't run any of this code, even in a unit test context, so I very well may have effed something up. Are you seeing an exception? | 15:15 |
| *** germs has quit IRC | 15:16 | |
| bauzas | efried: jaypipes: thanks for the early reviews of https://review.openstack.org/#/c/552924/7 | 15:16 |
| bauzas | efried: jaypipes: I think I need to understand more how numbered request groups would work | 15:17 |
| *** Spaz-Home has quit IRC | 15:17 | |
| bhagyashris | efried: I saw this exception at n-cpu Apr 11 20:46:08 openstack-VirtualBox nova-compute[5703]: ERROR nova.compute.manager [None req-b17184a8-7d31-4c3d-9b8b-d1f1ddb6860e None None] Error updating resources for node openstack-VirtualBox.: AttributeError: 'ProviderData' object has no attribute 'data' | 15:17 |
| bhagyashris | Apr 11 20:46:08 openstack-VirtualBox nova-compute[5703]: ERROR nova.compute.manager Traceback (most recent call last): | 15:17 |
| bhagyashris | Apr 11 20:46:08 openstack-VirtualBox nova-compute[5703]: ERROR nova.compute.manager File "/opt/stack/nova/nova/compute/manager.py", line 7311, in update_available_resource_for_node | 15:17 |
| bhagyashris | Apr 11 20:46:08 openstack-VirtualBox nova-compute[5703]: ERROR nova.compute.manager rt.update_available_resource(context, nodename) | 15:17 |
| efried | bhagyashris: okay, fixing... | 15:17 |
| *** germs has joined #openstack-nova | 15:17 | |
| *** germs has quit IRC | 15:17 | |
| *** germs has joined #openstack-nova | 15:17 | |
| efried | whoops, that was a flub | 15:17 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459 | 15:18 |
| efried | bhagyashris: ^ | 15:18 |
| efried | bauzas: Have you memorized the granular spec? | 15:20 |
| bauzas | efried: tbh, I need to look at it again | 15:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: RT: replace _instance_in_resize_state with _is_trackable_migration https://review.openstack.org/560467 | 15:21 |
| mriedem | this was a fun bit of history ^ | 15:21 |
| efried | bauzas: Numbered request groups work like this: | 15:21 |
| efried | Resources specified *within* a single numbered request group are *guaranteed* to land on the *same* provider. | 15:21 |
| efried | Resources specified in *different* numbered request groups may or may not land on same/different providers. | 15:21 |
| bauzas | efried: I thought asking resources1:STH=1&resources2:STH_ELSE=2 would make those two things on separate RPs | 15:21 |
| efried | bauzas: That has been a source of confusion, but no. | 15:21 |
| bauzas | ok, that's the second assumption I made | 15:21 |
| bauzas | I made wrong | 15:22 |
| bauzas | but may or may not is not really a big deal to me | 15:22 |
| efried | bauzas: We will eventually need that semantic - and "deliberate sharding" would be a use case driving it - but we don't have it with the spec as currently written. | 15:22 |
| bauzas | the first assumption is crucial to me | 15:22 |
| bauzas | the second one (different groups leading or not on same RP) is not really important to me | 15:22 |
| bauzas | what I want is affinity, not anti-affinity | 15:23 |
| *** evin has joined #openstack-nova | 15:23 | |
| efried | bauzas: Perfect. | 15:23 |
| efried | bauzas: In case you missed it, I summarized four use cases and what we can/can't do about them. It's at the top part of my review. | 15:23 |
| bauzas | either customers care about NUMA specifics and then numbered req groups is the perfect answer | 15:23 |
| bauzas | or, they don't care about NUMA specifics, and then they don't care where the resources land | 15:23 |
| efried | (I know sometimes those don't get seen because folks dive right into the comments within the file) | 15:23 |
| *** belmoreira has quit IRC | 15:23 | |
| efried | bauzas: Good | 15:24 |
| bauzas | efried: I saw your top-level comment, yup | 15:24 |
| bauzas | thanks for that, appreciated | 15:24 |
| *** andreas_s has quit IRC | 15:24 | |
| bauzas | I sometimes do that to justify a -1 | 15:24 |
| bauzas | when for example there are 30 comments but only one means -1 to me | 15:24 |
| efried | bauzas: So the use case you *don't* care about is my third bullet. | 15:24 |
| *** andreas_s has joined #openstack-nova | 15:24 | |
| bauzas | correct | 15:25 |
| bauzas | efried: I gave one example of NUMA affinity for vGPUs | 15:25 |
| bauzas | https://devblogs.nvidia.com/performance-portability-gpus-cpus-openacc/ | 15:25 |
| bauzas | efried: just for your context understanding ^ | 15:25 |
| kashyap | mriedem: When you get a moment, a small update on this: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bump_min_libvirt_and_qemu | 15:25 |
| efried | bauzas: Right; that's my second bullet. If that's a critical use case, then we need to invent something more. | 15:25 |
| kashyap | mriedem: There's about 14 patches that I need to queue in that drop the compat code. Right now there are only 4 | 15:25 |
| efried | bauzas: Concept of "same subtree" | 15:26 |
| kashyap | mriedem: I am resolving broken tests as I find them. 4 more to go (that are bit more involved, noted them here: https://review.openstack.org/#/c/558783/7) | 15:26 |
| kashyap | mriedem: Finally, a question on unit tests for you here: https://review.openstack.org/#/c/560365/ | 15:26 |
| bauzas | efried: why ? | 15:26 |
| bauzas | efried: VGPU is a standard class | 15:26 |
| bauzas | like VCPU and MEMORY_MB | 15:27 |
| efried | Because VGPU and VCPU are in different resource providers. | 15:27 |
| efried | bauzas: So you can't put them in the same numbered request group. | 15:27 |
| bauzas | efried: that will depend on the operator | 15:27 |
| kashyap | mriedem: Also, I can understand if you are of the view of: "I won't touch them until Zuul is +1 on them, and you've dropped all no-more-relevant compat code" :-) | 15:27 |
| efried | bauzas: And if you put them in different request groups, they aren't guaranteed to land on the same NUMA node. | 15:27 |
| bhagyashris | efried: it's working now :) | 15:27 |
| efried | bhagyashris: Like, fully working? Like the DISK_GB is being reported by the sharing provider and not by the compute node provider? | 15:28 |
| bauzas | efried: but if they want NUMA affinity for VGPUs, then the doc will say : enable the conf opt saying "I want VCPU and VGPU to be NUMA specific" | 15:28 |
| bauzas | efried: in that case, they will be on the same RP | 15:28 |
| bauzas | efried: which will make the thing work | 15:28 |
| mriedem | kashyap: i'd prefer to not dig into those until tests are passing | 15:28 |
| bauzas | efried: we could later add a new param that specifically request the notion of the "subtree" parenting, but I leave that out of that spec then | 15:29 |
| efried | bauzas: It would. But saying that the VGPU inventory has to be on the same RP as the VCPU inventory - that's not a restriction that's going to remain viable for very long. | 15:29 |
| kashyap | mriedem: Sure, that's perfectly fine. I will be able to full spend time on it only from Friday afternoon onwards. | 15:29 |
| bauzas | efried: sure, but I don't want to boil the ocean and keep the NUMA spec minimalist | 15:29 |
| bhagyashris | efried: yes it removes the CN RP DISK_GB inventory from inventory table and now it's reporting the resource against the CN and shared RP :) | 15:29 |
| efried | bhagyashris: WOHOO! jaypipes ^^ | 15:29 |
| bauzas | efried: I can leave a note explaining the caveat, and someone in the future (possibly being me) could write another spec describing the problem and the solution | 15:30 |
| efried | bauzas: Okay, then the spec needs to state that restriction, for sure, cause that's significant. | 15:30 |
| bauzas | efried: that's correct, I'll amend the spec accordingly and explicitely state the limitation, exactly like I did for huge pages | 15:30 |
| bauzas | efried: thanks for your help! | 15:30 |
| bhagyashris | efried: thanks for your inputs :) Now it's EOD for me leaving... | 15:31 |
| efried | bauzas: TBC: the restriction means that the ascii diagram you've shown on L125 (where the VGPU and VF inventories are separated from the VCPU/PCUP/MEMORY_MB) will *not* work. | 15:31 |
| *** sridharg has quit IRC | 15:31 | |
| bauzas | that's right, I need to amend the diagram too | 15:31 |
| efried | bauzas: Cool cool. | 15:31 |
| *** ratailor has quit IRC | 15:31 | |
| efried | bhagyashris: Thank you very much for working this. | 15:31 |
| *** rodolof has quit IRC | 15:32 | |
| efried | jaypipes: To summarize, bhagyashris validated that these two patches DTRT wrt sharing DISK_GB for libvirt: https://review.openstack.org/560444 https://review.openstack.org/560459 | 15:32 |
| jaypipes | efried: DTRT? | 15:33 |
| jaypipes | do the right thign? | 15:33 |
| efried | yes | 15:33 |
| jaypipes | you kids... | 15:33 |
| *** yamahata has quit IRC | 15:33 | |
| jaypipes | efried, bhagyashris: ok, cool. that's kind of exactly what I expected. :) | 15:33 |
| *** lpetrut_ has joined #openstack-nova | 15:34 | |
| efried | jaypipes: Now somebody ought to finish up the tests on those patches and put 'em to bed. | 15:35 |
| *** lpetrut has quit IRC | 15:36 | |
| *** andreas_s has quit IRC | 15:38 | |
| *** zhaochao has quit IRC | 15:38 | |
| *** edmondsw has quit IRC | 15:39 | |
| *** idlemind has quit IRC | 15:41 | |
| *** idlemind has joined #openstack-nova | 15:42 | |
| jaypipes | bauzas: you realize that https://devblogs.nvidia.com/performance-portability-gpus-cpus-openacc/ is not talking about CPU and GPU sharing memory, right? | 15:42 |
| bauzas | right | 15:42 |
| bauzas | it's about portability | 15:43 |
| *** andreas_s has joined #openstack-nova | 15:43 | |
| bauzas | memory isn't shared on a SOC for a nvidia card | 15:43 |
| bauzas | so you're right, that's a separate memory map | 15:43 |
| *** r-daneel has quit IRC | 15:44 | |
| jaypipes | bauzas: you wrote "I have many internal customers that are actually very interested in having NUMA affinity for having the GPU memory close as possible to the NUMA memory controller used by the virtual CPU" <-- that is just not the case. | 15:44 |
| jaypipes | bauzas: either that, or your internal customers don't actually know what they're asking for. | 15:45 |
| bauzas | jaypipes: I can certainly ask them for clarification about their needs | 15:45 |
| jaypipes | bauzas: in any case, that wasn't the reason for the -1 :) was just mentioning the use case could have been tighter. | 15:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove RequestContext.instance_lock_checked https://review.openstack.org/554378 | 15:46 |
| bauzas | jaypipes: yeah, no worries, I got it | 15:47 |
| bauzas | jaypipes: and tbh, I appreciate you challenging me on the need | 15:47 |
| bauzas | because it helps me understand why my customers are pushing for it | 15:47 |
| bauzas | instead of just be a typey typey box | 15:48 |
| *** suresh12 has joined #openstack-nova | 15:48 | |
| jaypipes | bauzas: yeah, the checkboxy thing is a big problem. | 15:49 |
| *** itlinux has joined #openstack-nova | 15:50 | |
| *** moshele has joined #openstack-nova | 15:53 | |
| *** ragiman has quit IRC | 15:54 | |
| mriedem | mikal: i'm sure this pains you, but apparently the nova-net refactoring broke nova-lxd https://review.openstack.org/#/c/559190/ which apparently also broke openstack-ansible https://review.openstack.org/#/c/559354/ | 15:55 |
| *** suresh12 has quit IRC | 15:55 | |
| mriedem | :( | 15:55 |
| *** hamzy has quit IRC | 15:55 | |
| *** gyee has joined #openstack-nova | 15:56 | |
| jaypipes | tssurya: you need any assistance on writing the func test asked for by dansmith on https://review.openstack.org/#/c/554920/? | 15:57 |
| melwitt | dansmith: for the runways end dates, were you thinking they include the end date? that is, would we remove things *on* the end date or the day after? I was thinking the day after | 15:57 |
| *** caisan has quit IRC | 15:57 | |
| tssurya | jaypipes: I have been working on it for sometime with not much luck | 15:57 |
| *** andreas_s has quit IRC | 15:57 | |
| dansmith | melwitt: shrug, probably EOD on the day yeah | 15:58 |
| dansmith | which is today I know | 15:58 |
| jaypipes | tssurya: feel free to push what you've got and I can help out. | 15:58 |
| tssurya | jaypipes : so if you have some time, help appreciated | 15:58 |
| jaypipes | np | 15:58 |
| melwitt | dansmith: yeah, okay. I was thinking similar, that the end date should include that day. I'll move things after EOD | 15:58 |
| dansmith | melwitt: your EOD is pretty late, so I think that'll work nice | 15:58 |
| melwitt | agreed | 15:59 |
| *** lucasagomes is now known as lucas-afk | 15:59 | |
| *** patriciadomin has quit IRC | 16:00 | |
| *** patriciadomin has joined #openstack-nova | 16:01 | |
| *** yamahata has joined #openstack-nova | 16:05 | |
| *** cristicalin has quit IRC | 16:05 | |
| *** ktibi has quit IRC | 16:05 | |
| *** harlowja has joined #openstack-nova | 16:05 | |
| *** fragatina has quit IRC | 16:05 | |
| *** fragatina has joined #openstack-nova | 16:06 | |
| mriedem | ooo i broke nova-lxd too https://review.openstack.org/#/q/I751fcb7532679905c4279744919c6cce84a11eb4 | 16:09 |
| mriedem | odyssey4me: that's awesome that nova can unwittingly break nova-lxd and other out of tree virt drivers, which then in turn breaks OSA | 16:10 |
| mriedem | odyssey4me: i'm sort of surprised that OSA's voting jobs don't exclude out of tree drivers | 16:11 |
| sean-k-mooney | mriedem: isnt there a thirdpart ci for nova-lxd | 16:11 |
| mriedem | sean-k-mooney: no, nova-lxd is not in tree | 16:11 |
| sean-k-mooney | mriedem: yes but i would have expected there to be a non gating thrid party ci to test it even when its out of tree | 16:12 |
| *** andreas_s has joined #openstack-nova | 16:12 | |
| *** armaan has quit IRC | 16:12 | |
| mriedem | why would we care? | 16:12 |
| *** armaan has joined #openstack-nova | 16:12 | |
| mriedem | if you're out of tree, you're out of tree, and we don't block in-tree changes because of that | 16:12 |
| mriedem | best we do at times is put something in the ML as a heads up for known internal interface changes | 16:12 |
| bauzas | that remembers me some pg discussion... | 16:14 |
| sean-k-mooney | not run by nova run by the maintiners of nova-lxd e.g. canonical | 16:14 |
| bauzas | which I think we cleary made the statement that non-supported things for a project are potentially subject to break | 16:15 |
| mriedem | bauzas: we have jobs we can run for pg testing if we ant | 16:15 |
| mriedem | *want | 16:15 |
| bauzas | hence other projects gating on that project shouldn't really support that too | 16:15 |
| sean-k-mooney | mriedem: oh im not expecting nova to block in tree change i just expcting that nova-lxd team could benifit form know that its broken | 16:15 |
| *** damien_r has quit IRC | 16:15 | |
| mriedem | there is a neutron job in the experimental queue that runs with pg | 16:15 |
| mriedem | sean-k-mooney: nova-lxd team can listen on nova changes, run jobs and post results for failures somewhere if they want to detect them early | 16:16 |
| bauzas | mriedem: I'm not saying it's impossible | 16:17 |
| bauzas | mriedem: just that we broke ceilometer once | 16:17 |
| bauzas | because ceilo was gating something we don't test | 16:17 |
| mriedem | sure, i'm sure ceilometer broke us once indirectly too when they were part of tempest, 3 years ago | 16:17 |
| bauzas | and the result was like a best-effort fix and a summit discussion that led to "come and help us make pg first-grade if your production runs on something we don't test" | 16:18 |
| mriedem | there is nothing 2nd grade about pg wrt nova | 16:18 |
| bauzas | I think we're diverting anyway | 16:18 |
| *** mgoddard has quit IRC | 16:19 | |
| bauzas | I just tried to explain that I feel you shouldn't blame yourself for breaking ansible if they gate on something we don't test | 16:19 |
| dansmith | mriedem: this seems like a legit "stop the bleeding" patch for stable.. I saw you reviewed it once, but.. are you cool with it? https://review.openstack.org/#/c/543569 | 16:19 |
| bauzas | we can certainly fix that tho | 16:19 |
| mriedem | bauzas: i don't really blame myself :) | 16:19 |
| sahid | mriedem: if you have a moment that one looks ready and important enough for some use-cases https://review.openstack.org/#/c/553072/ | 16:19 |
| mriedem | sucks for odyssey4me though | 16:19 |
| mriedem | jesus, did the red hat team bug meeting just end? | 16:20 |
| bauzas | mriedem: I agree, and that requires a fix | 16:20 |
| bauzas | mriedem: nah, not bugs | 16:20 |
| bauzas | but yes, meeting ended | 16:20 |
| *** Eran_Kuris has joined #openstack-nova | 16:21 | |
| mriedem | dansmith: i've just been putting off going through it again because it's hairy on stable | 16:21 |
| mriedem | i'm not opposed to it no | 16:21 |
| dansmith | it's big, | 16:21 |
| dansmith | but it doesn't seem that hairy | 16:21 |
| mriedem | the fact it was re-introducing a regression in the earlier PS indicates to me it's hairy | 16:21 |
| dansmith | it's checking a thing and raising an exception to avoid you killing data puppies | 16:22 |
| *** AlexeyAbashkin has quit IRC | 16:22 | |
| dansmith | okay I guess I don't quite know what that means | 16:22 |
| mriedem | https://review.openstack.org/#/c/543569/1/nova/virt/libvirt/driver.py@1216 | 16:22 |
| mriedem | meaning it's easy to break stuff | 16:23 |
| dansmith | ah I see | 16:23 |
| mriedem | anyway, i told lyarwood i'd go through it again last week and forgot | 16:23 |
| dansmith | weyall.. data corruption seems more bad | 16:23 |
| *** janki has quit IRC | 16:23 | |
| mriedem | and with no more eol, we have time to fix it if breaks something | 16:23 |
| dansmith | by "time" you mean "forever and ever" right? | 16:24 |
| odyssey4me | mriedem eh? what sucks for me? :) | 16:24 |
| *** andreas_s has quit IRC | 16:25 | |
| *** masayukig has joined #openstack-nova | 16:29 | |
| *** sree has quit IRC | 16:29 | |
| *** dikonoor has joined #openstack-nova | 16:30 | |
| *** andreas_s has joined #openstack-nova | 16:30 | |
| *** cristicalin has joined #openstack-nova | 16:31 | |
| *** mgoddard has joined #openstack-nova | 16:34 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: move version to string in utils https://review.openstack.org/560455 | 16:35 |
| *** udesale has quit IRC | 16:35 | |
| mriedem | dansmith: i'll trade you https://review.openstack.org/#/c/536722/ | 16:35 |
| dansmith | mriedem: seems a little lopsided | 16:36 |
| *** felipemonteiro_ has quit IRC | 16:36 | |
| *** Spaz-Home has joined #openstack-nova | 16:36 | |
| *** r-daneel has joined #openstack-nova | 16:37 | |
| mriedem | sahid: comments inline | 16:39 |
| *** Spazmotic1 has quit IRC | 16:40 | |
| *** wolverineav has joined #openstack-nova | 16:40 | |
| openstackgerrit | Merged openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483 | 16:41 |
| dansmith | mriedem: you okay with this? https://review.openstack.org/#/c/484997/14/nova/conf/libvirt.py | 16:44 |
| dansmith | I suggested something similar, but not exactly this.. although this works and is easier than what I suggested | 16:44 |
| dansmith | it gets us config load-time verification of that parameter | 16:44 |
| dansmith | instead of at runtime | 16:44 |
| dansmith | but I don't think we have anywhere else that we subclass an opt (even though that's suggested by the oslo docs AFAICT) | 16:45 |
| mriedem | you just pulled me out of https://review.openstack.org/#/c/543569/ | 16:45 |
| dansmith | it needs only a glance | 16:46 |
| mriedem | so does https://review.openstack.org/#/c/560454/ | 16:46 |
| mriedem | agree with load-time config validation | 16:47 |
| mriedem | wouldn't it be simple to do a subclass inline in that module | 16:47 |
| mriedem | ? | 16:47 |
| *** sahid has quit IRC | 16:49 | |
| dansmith | mriedem: wrong link? | 16:49 |
| *** andreas_s has quit IRC | 16:49 | |
| *** suresh12 has joined #openstack-nova | 16:49 | |
| *** suresh12 has quit IRC | 16:50 | |
| mriedem | no, i asked for a review on that earlier - since it's kicking things out of CI on master | 16:50 |
| *** lpetrut has joined #openstack-nova | 16:51 | |
| dansmith | I'm confused | 16:51 |
| *** lpetrut_ has quit IRC | 16:51 | |
| dansmith | mriedem: melwitt tssurya: do we need a cells meeting today? I have nothing new | 16:51 |
| mriedem | you asked me to review lee's thing, then while i was doing that, you asked me to look at sahid's thing, so in kind i threw that bug fix at you while you were reviewing sahid's thing :) | 16:51 |
| dansmith | and I reviewed some of tssurya's patches to make myself feel better this morning | 16:52 |
| mriedem | i dont think i have anything | 16:52 |
| tssurya | me niether | 16:52 |
| melwitt | I was just about to ask that. I don't think I have anything either | 16:52 |
| tssurya | dansmith: thanks for the reviews | 16:52 |
| mriedem | i reviewed tssurya's patch to delete RPs and host mappings when we delete compute services but my comments weren't controversial | 16:52 |
| dansmith | sweet, cancelled thusly | 16:52 |
| tssurya | jaypipes: I am still working on the func test, haven't got very far (dangling between understanding service fixtures) , however I will try again tomorrow and ping you if it becomes too much for me | 16:53 |
| *** andreas_s has joined #openstack-nova | 16:54 | |
| mriedem | tssurya: i can probably help with that, | 16:54 |
| mriedem | could be a patch before yours in the series to show that we didn't delete HMs and RPs when we deleted a compute service, and then yours could build on top to assert that we do | 16:54 |
| dansmith | yeah I like that | 16:55 |
| dansmith | I would call that "mriedem style" | 16:55 |
| mriedem | it would also keep the fix patch smaller | 16:55 |
| mriedem | like gangham style? | 16:55 |
| imacdonn | I can certainly related to getting all tangled up in fixtures :/ | 16:55 |
| imacdonn | relate* | 16:55 |
| dansmith | mriedem: similar, yeah | 16:55 |
| tssurya | mriedem: that would be really awesome for me, writing the test_services from stratch is causing me a headache because its my first go | 16:55 |
| *** _pewp_ has quit IRC | 16:56 | |
| tssurya | imacdonn: :) | 16:56 |
| *** lpetrut has quit IRC | 16:57 | |
| *** tesseract has quit IRC | 16:59 | |
| imacdonn | mriedem dansmith speaking of which ... I tried to implement that compute-is-configured-to-use-placement check based on auth_type, but I'm back in unit-test hell ... 27 tests that start a compute service trip on it .. and if I set auth_type in the conf fixture, a bazillion other tests fail ... some due to auth_url not set | 16:59 |
| *** gjayavelu has joined #openstack-nova | 17:00 | |
| *** _pewp_ has joined #openstack-nova | 17:01 | |
| *** sree has joined #openstack-nova | 17:03 | |
| *** andreas_s has quit IRC | 17:03 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 17:04 |
| *** jdillaman has quit IRC | 17:05 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:07 | |
| *** harlowja has quit IRC | 17:07 | |
| *** tssurya has quit IRC | 17:07 | |
| *** sree has quit IRC | 17:07 | |
| mriedem | dansmith: lyarwood: done https://review.openstack.org/#/c/543569/ | 17:08 |
| *** andreas_s has joined #openstack-nova | 17:08 | |
| *** mgoddard has quit IRC | 17:08 | |
| * mriedem goes to brush off all that hair | 17:09 | |
| *** diga has quit IRC | 17:10 | |
| mriedem | dansmith: you should hit https://review.openstack.org/#/c/559987/ while we wait for lee to fix that up | 17:10 |
| dansmith | ya | 17:11 |
| *** cristicalin has quit IRC | 17:13 | |
| *** mdnadeem has quit IRC | 17:13 | |
| *** ssurana has joined #openstack-nova | 17:13 | |
| *** sidx64 has quit IRC | 17:14 | |
| *** jpena is now known as jpena|off | 17:16 | |
| *** hamzy has joined #openstack-nova | 17:18 | |
| mriedem | dansmith: left some replies in https://review.openstack.org/#/c/536722/ based on earlier discussions | 17:19 |
| mriedem | as for the cleanup routine, i think some of that is going to have to just be impl trial and error, but i left some ideas | 17:19 |
| dansmith | mriedem: how is it not a new rpc call? | 17:20 |
| dansmith | oh because live_migration_abort() I guess? | 17:20 |
| mriedem | yes | 17:20 |
| mriedem | read the rest of my comment :) | 17:20 |
| mriedem | there is one thing i'm not totally sure about, and it's that http://pythonhosted.org/futures/#concurrent.futures.Executor.shutdown says "If wait is False then this method will return immediately and the resources associated with the executor will be freed when all pending futures are done executing. Regardless of the value of wait, the entire Python program will not exit until all pending futures are done executing." | 17:21 |
| cfriesen | melwitt: lyarwood: I'm seeing something weird on Pike: http://paste.openstack.org/show/718967/ Basically heat creates an instance and attaches volumes to it, then on stack teardown it runs into problems detaching the volume from the instance. Eventually the token times out and it retries, only this time libvirt doesn't actually recognize the specified device (making me wonder whether it had actually been detached at this | 17:21 |
| cfriesen | point.) | 17:21 |
| mriedem | however, if we do the done callback and Futures.cancel() thing i laid out, i think the pool will exit once we cancel those futures | 17:21 |
| dansmith | mriedem: so the thing that sucks about that, IMHO, | 17:22 |
| dansmith | is it's a cast, and we could check the status of the migration before we make that call, but it might be different when it would land on the compute and do its thing | 17:22 |
| dansmith | which maybe isn't a problem because it's just less permissive not more | 17:22 |
| *** andreas_s has quit IRC | 17:22 | |
| mriedem | dansmith: yeah, worst case is the api races and then the compute ignores the abort request, because i think it's ultimately the libvirt driver that has to ack the abort request | 17:23 |
| dansmith | mriedem: and we'd have to have the migration in rpcapi in order to know the status and whether or not we need to abort based on theversion we're pinned to | 17:23 |
| mriedem | oh because we don't pass the migration record itself to live_migration_abort, just the id | 17:24 |
| dansmith | right | 17:24 |
| mriedem | hmm, well, we have to bump the compute service version anyway, so we can do that in the same version bump | 17:25 |
| *** hemna_ has quit IRC | 17:25 | |
| *** hemna_ has joined #openstack-nova | 17:25 | |
| melwitt | cfriesen: I think you might need this https://review.openstack.org/#/c/515008 | 17:25 |
| mriedem | i was just looking that up :) | 17:25 |
| dansmith | mriedem: well you don't actually have to change the rpc call, you just have to change the interface to the rpcapi method | 17:25 |
| dansmith | mriedem: or you do it based on service version in compute/api before you get that far | 17:26 |
| cfriesen | melwitt: looks promising, thanks | 17:26 |
| mriedem | dansmith: right so pass migration object to rpcapi method, if can't send new version, send migration.id | 17:26 |
| mriedem | right? | 17:26 |
| mriedem | and if it can't send the new version and the migration status is not 'running' it should blow up | 17:26 |
| mriedem | which i think avoids us needing to do an explicit service version check in the API method | 17:27 |
| *** gjayavelu has quit IRC | 17:27 | |
| dansmith | mriedem: no, pass migration to rpcapi, and it always sends migration id, but raises if the version is old and state is not "running" or whatever | 17:27 |
| mriedem | ah yeah | 17:27 |
| mriedem | ok | 17:27 |
| *** dillaman has quit IRC | 17:27 | |
| mriedem | but these are impl details right? does the spec need this level of detail? | 17:27 |
| mriedem | i assume it will be me and you reviewing the code | 17:27 |
| *** andreas_s has joined #openstack-nova | 17:27 | |
| dansmith | mriedem: well, I dunno, it papered over a lot of this | 17:28 |
| mriedem | ok, up to you if you want to ask for more detail | 17:28 |
| mriedem | if you do, i'd say link this irc conversation in there so Kevin_Zheng has it | 17:28 |
| *** sree has joined #openstack-nova | 17:29 | |
| *** hemna__ has joined #openstack-nova | 17:29 | |
| *** hemna__ has quit IRC | 17:29 | |
| dansmith | well, since it's not as big of a change as I was thinking (just clarifying we're re-using the same) I guess I can just go ahead and approve it and see if he'll come back around to add some stuff | 17:29 |
| *** abhishekk has joined #openstack-nova | 17:29 | |
| *** yamamoto has quit IRC | 17:29 | |
| *** wolverineav has quit IRC | 17:29 | |
| *** wolverineav has joined #openstack-nova | 17:30 | |
| melwitt | cfriesen: this is the redhat bz where we ran into the problem. I think it was during a similar thing, a heat stack delete failing at the detach step for "not found" https://bugzilla.redhat.com/show_bug.cgi?id=1505595 | 17:30 |
| openstack | bugzilla.redhat.com bug 1505595 in openstack-nova "Nova assumes that a volume is fully detached from the compute if the volume is not defined in the instance's libvirt definition" [High,Modified] - Assigned to sferdjao | 17:30 |
| *** jdillaman has joined #openstack-nova | 17:31 | |
| *** sree has quit IRC | 17:33 | |
| cfriesen | melwitt: sounds even more promising. what do you think of the idea of heat detecting the failure-to-detach by polling the instance action events? | 17:33 |
| *** wolverineav has quit IRC | 17:34 | |
| mriedem | cfriesen: that's how i implemented the tempest test for extend volume - pool instance action events until the extend volume action is complete | 17:35 |
| mriedem | *poll | 17:35 |
| mriedem | https://github.com/openstack/tempest/blob/e5d343178334f9d7630e77289e3945e7ccd06cc1/tempest/api/volume/test_volumes_extend.py#L90 | 17:36 |
| melwitt | hm, I was thinking it might be simpler to poll the presence of the attachments by GET to os-volume_attachments and don't proceed to the next step until they are gone | 17:36 |
| *** mdbooth has quit IRC | 17:36 | |
| melwitt | but I guess that wouldn't tell you detail about the status | 17:36 |
| mriedem | yeah you could end up polling for a long time | 17:37 |
| mriedem | you'd have to build in a timeout | 17:37 |
| cfriesen | currently it seems to keep polling until the token times out | 17:37 |
| mriedem | you likely need a timeout either way https://github.com/openstack/tempest/blob/e5d343178334f9d7630e77289e3945e7ccd06cc1/tempest/api/volume/test_volumes_extend.py#L160 | 17:37 |
| mriedem | some cloud providers have 24 hour token timeouts don't they? | 17:38 |
| mriedem | or maybe that was years ago | 17:38 |
| cfriesen | in this case it was an hour | 17:38 |
| mriedem | if a volume detach isn't done in 5 minutes something is fubar | 17:38 |
| cfriesen | but then it naively retries and hits the other failure that I think will be adresssed by the commit melwitt pointed out | 17:38 |
| mriedem | even a minute really | 17:38 |
| *** dikonoor has quit IRC | 17:38 | |
| *** XueFeng has quit IRC | 17:38 | |
| *** ralonsoh has quit IRC | 17:39 | |
| *** lpetrut has joined #openstack-nova | 17:40 | |
| cfriesen | melwitt: the method you describe is what it seems to be doing currently, it's calling self.client().volumes.get_server_volume(server_id, attach_id) and looking for the "not found" exception. | 17:41 |
| *** andreas_s has quit IRC | 17:42 | |
| mriedem | cfriesen: if sahid's patch fixes your issue in pike, you can propose https://review.openstack.org/#/c/546655/ for stable/pike | 17:42 |
| melwitt | I see | 17:42 |
| cfriesen | mriedem: ack | 17:42 |
| openstackgerrit | Merged openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 17:42 |
| *** dtruong_ has joined #openstack-nova | 17:45 | |
| *** dtruong_ has quit IRC | 17:45 | |
| *** dtruong_ has joined #openstack-nova | 17:46 | |
| *** dtruong_ has joined #openstack-nova | 17:47 | |
| *** suresh12 has joined #openstack-nova | 17:47 | |
| *** dtruong_ has joined #openstack-nova | 17:48 | |
| *** dtruong has quit IRC | 17:48 | |
| *** yamamoto has joined #openstack-nova | 17:49 | |
| *** yamamoto has quit IRC | 17:50 | |
| *** yamamoto has joined #openstack-nova | 17:50 | |
| *** harlowja has joined #openstack-nova | 17:52 | |
| *** armaan has quit IRC | 17:54 | |
| *** armaan has joined #openstack-nova | 17:54 | |
| *** andreas_s has joined #openstack-nova | 17:55 | |
| *** sambetts is now known as sambetts|afk | 17:55 | |
| openstackgerrit | Merged openstack/nova master: Marker reset option for nova-manage map_instances https://review.openstack.org/539501 | 17:57 |
| openstackgerrit | Merged openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 17:57 |
| *** yamamoto has quit IRC | 17:57 | |
| *** wolverineav has joined #openstack-nova | 17:58 | |
| *** edmondsw has joined #openstack-nova | 17:59 | |
| *** jdillaman has quit IRC | 18:01 | |
| *** dillaman has joined #openstack-nova | 18:03 | |
| *** dklyle has quit IRC | 18:06 | |
| *** andreas_s has quit IRC | 18:10 | |
| *** dillaman has quit IRC | 18:12 | |
| *** cburgess_ is now known as cburgess | 18:13 | |
| *** andreas_s has joined #openstack-nova | 18:14 | |
| *** sree has joined #openstack-nova | 18:14 | |
| *** yamamoto has joined #openstack-nova | 18:16 | |
| *** yamamoto has quit IRC | 18:18 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:18 | |
| *** sree has quit IRC | 18:19 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: libvirt: refactor get_base_config to accept host arg https://review.openstack.org/560456 | 18:21 |
| *** huanxie has quit IRC | 18:23 | |
| *** huanxie has joined #openstack-nova | 18:23 | |
| *** yamamoto has joined #openstack-nova | 18:25 | |
| *** andreas_s has quit IRC | 18:28 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 18:30 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 18:30 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 18:30 |
| *** claudiub has quit IRC | 18:31 | |
| *** armaan has quit IRC | 18:31 | |
| *** armaan has joined #openstack-nova | 18:31 | |
| *** yamamoto has quit IRC | 18:34 | |
| *** gjayavelu has joined #openstack-nova | 18:34 | |
| *** cz2 has quit IRC | 18:35 | |
| *** yamamoto has joined #openstack-nova | 18:38 | |
| *** armaan has quit IRC | 18:38 | |
| *** armaan has joined #openstack-nova | 18:39 | |
| *** yamamoto has quit IRC | 18:40 | |
| *** dustfalling has joined #openstack-nova | 18:42 | |
| dustfalling | Does anyone knows if it possible for nova to pass individual local drives as block device to VM, for use cases like big data? | 18:43 |
| *** abhishekk has quit IRC | 18:46 | |
| *** mvk has quit IRC | 18:46 | |
| dansmith | dustfalling: see channel topic, but using the LVM ephemeral driver is about as close as you can get | 18:54 |
| dustfalling | thank you, dansmith | 18:55 |
| *** dklyle has joined #openstack-nova | 18:55 | |
| *** pcaruana has quit IRC | 18:55 | |
| *** moshele has quit IRC | 18:59 | |
| *** priteau has quit IRC | 19:00 | |
| *** cz2 has joined #openstack-nova | 19:02 | |
| *** salv-orlando has quit IRC | 19:07 | |
| *** salv-orlando has joined #openstack-nova | 19:07 | |
| *** tssurya has joined #openstack-nova | 19:07 | |
| *** tbachman has quit IRC | 19:09 | |
| *** salv-orlando has quit IRC | 19:11 | |
| *** mdbooth has joined #openstack-nova | 19:15 | |
| *** moshele has joined #openstack-nova | 19:16 | |
| *** tbachman has joined #openstack-nova | 19:19 | |
| cfriesen | was there ever a concensus reached about how to deal with https://bugs.launchpad.net/nova/+bug/1558880 ? It seems to have been stalled for a long time now without any clear path forward. | 19:20 |
| openstack | Launchpad bug 1558880 in OpenStack Compute (nova) "instance can not resize ephemeral in mitaka" [Medium,In progress] - Assigned to Nazeema Begum (nazeema123) | 19:20 |
| *** mvk has joined #openstack-nova | 19:23 | |
| *** tbachman_ has joined #openstack-nova | 19:24 | |
| melwitt | cfriesen: doesn't look like it. mdbooth had some ideas in comment 15. I hadn't seen the bug before you mentioned it | 19:25 |
| *** tbachman_ has quit IRC | 19:25 | |
| *** wolverineav has quit IRC | 19:25 | |
| *** avolkov has quit IRC | 19:25 | |
| *** tbachman has quit IRC | 19:25 | |
| *** tbachman has joined #openstack-nova | 19:28 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559702 | 19:28 |
| *** tbachman has quit IRC | 19:29 | |
| *** wolverineav has joined #openstack-nova | 19:31 | |
| *** READ10 has quit IRC | 19:31 | |
| *** fragatina has quit IRC | 19:37 | |
| *** fragatina has joined #openstack-nova | 19:37 | |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | 19:40 |
| *** moshele has quit IRC | 19:41 | |
| *** fragatina has quit IRC | 19:42 | |
| *** sidx64 has joined #openstack-nova | 19:44 | |
| *** sidx64_ has joined #openstack-nova | 19:46 | |
| *** edmondsw has quit IRC | 19:47 | |
| *** QianYu has joined #openstack-nova | 19:47 | |
| *** QianYu has quit IRC | 19:48 | |
| *** sidx64 has quit IRC | 19:49 | |
| *** eharney has quit IRC | 19:49 | |
| *** mdbooth has quit IRC | 19:49 | |
| *** tssurya has quit IRC | 19:51 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 19:55 |
| *** suresh12 has quit IRC | 19:56 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize https://review.openstack.org/553583 | 19:56 |
| *** salv-orlando has joined #openstack-nova | 19:56 | |
| *** tssurya has joined #openstack-nova | 19:57 | |
| mriedem | dansmith: fyi, for https://review.openstack.org/#/c/560596/ we'll have to think about rebuild + new image with required traits... | 19:58 |
| mriedem | as much as no one wants to think about that | 19:58 |
| *** mdbooth has joined #openstack-nova | 19:58 | |
| *** claudiub has joined #openstack-nova | 20:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for deleting a compute service https://review.openstack.org/560626 | 20:02 |
| mriedem | tssurya: ^ i'll rebase your change on top of it | 20:02 |
| *** jafeha has joined #openstack-nova | 20:04 | |
| *** suresh12 has joined #openstack-nova | 20:04 | |
| *** jafeha__ has quit IRC | 20:05 | |
| *** suresh12 has quit IRC | 20:08 | |
| *** jobewan has quit IRC | 20:10 | |
| *** suresh12 has joined #openstack-nova | 20:12 | |
| tssurya | mriedem: thanks a lot, oh nice I wasted so much of time in trying to see if the service fixture could return the service object also,, not sure why I didn't think of just querying it using get_services after the compute service is creeated | 20:13 |
| *** fragatina has joined #openstack-nova | 20:13 | |
| mriedem | for the most part, we want functional tests to interact with the REST API | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for deleting a compute service https://review.openstack.org/560626 | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 20:14 |
| tssurya | mriedem: yea makes sense, I am completely naive :( will practise writing these things more | 20:14 |
| efried | mriedem: test_resize_with_reschedule_then_live_migrate is that bug you fixed earlier with the waiting for migration to complete? | 20:15 |
| mriedem | efried: yes | 20:15 |
| mriedem | http://status.openstack.org/elastic-recheck/#1762876 | 20:16 |
| efried | mriedem: was gonna ask if it merged, but I see it's trying to get through the gate. | 20:16 |
| efried | I rechecked it. | 20:16 |
| mriedem | ok looks like test_parallel_evacuate_with_server_group is also racy | 20:17 |
| efried | whee | 20:17 |
| tssurya | mriedem: totally appreciate the detailed comments on why you are doing what you are doing specially the fixtures . | 20:19 |
| *** markvoelker has joined #openstack-nova | 20:20 | |
| mriedem | the setUp is mostly copy/paste from other similar functional tests | 20:20 |
| mriedem | but thanks, i'll take all that credit | 20:20 |
| tssurya | mriedem: I know, that's what I did took most of it from test_servers like Dan said | 20:21 |
| *** wolsen_ has joined #openstack-nova | 20:21 | |
| *** zioproto_ has joined #openstack-nova | 20:21 | |
| *** geekinutah_ has joined #openstack-nova | 20:21 | |
| *** NobodyCam_ has joined #openstack-nova | 20:21 | |
| tssurya | however I got tangled up | 20:21 |
| *** ameade_ has joined #openstack-nova | 20:21 | |
| *** icey_ has joined #openstack-nova | 20:21 | |
| arvindn05 | mriedem: incase of rebuild, can we make a allocation request to placement without resources and only traits(will require API behaviour change, new microversion?) and make sure the host list returned contains the host we are currently doing a rebuild of? | 20:21 |
| *** kmalloc_ has joined #openstack-nova | 20:21 | |
| mriedem | orangutangled? https://www.amazon.com/Orangutangled-Sudipta-Bardhan-Quallen/dp/1477847170 | 20:22 |
| arvindn05 | mriedem: if that sounds like a good startergy...i can pursure the code changes required while that other patch is being merged.... | 20:22 |
| tssurya | mriedem: :P | 20:22 |
| mriedem | arvindn05: i think that is over-complicating things | 20:23 |
| mriedem | to modify the allocation_candidates API to ignore resources | 20:23 |
| arvindn05 | hmm....ok...any suggestions? | 20:24 |
| mriedem | if anything, we'd want to change GET /allocation_candidates to pass in a specific root provider uuid | 20:24 |
| mriedem | however....placement might say, "sorry no more room" | 20:24 |
| *** toanster has joined #openstack-nova | 20:24 | |
| arvindn05 | i though it could be useful for other cases where the user might want to take an inventory of RP's with specific traits etc | 20:24 |
| *** dtruong_ has quit IRC | 20:24 | |
| mriedem | the user can do that via GET /resource_providers | 20:24 |
| *** dtruong has joined #openstack-nova | 20:25 | |
| *** kmalloc_ has quit IRC | 20:25 | |
| mriedem | hmm, i'm not sure how allocation_candidates is going to work here, since i guess it would have to make resources optional, | 20:25 |
| mriedem | otherwise you can hit the bug that hongbin is fixing | 20:25 |
| mriedem | if the compute is full | 20:25 |
| *** kmalloc_ has joined #openstack-nova | 20:25 | |
| arvindn05 | exactly... | 20:25 |
| *** kmalloc_ is now known as notmorgan | 20:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for deleting a compute service https://review.openstack.org/560626 | 20:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 20:26 |
| mriedem | arvindn05: well, this is why your spec needs to be amended like i asked for | 20:26 |
| *** notmorgan has quit IRC | 20:26 | |
| *** notmorgan has joined #openstack-nova | 20:26 | |
| *** notmorgan has quit IRC | 20:26 | |
| *** notmorgan has joined #openstack-nova | 20:26 | |
| *** fanzhang_ has joined #openstack-nova | 20:27 | |
| *** kmalloc has quit IRC | 20:27 | |
| *** andreaf_ has joined #openstack-nova | 20:27 | |
| arvindn05 | oh...didnt realize you were asking for ammending the spec...my assumption was to use the code review phase for addressing since it was a bug fix | 20:27 |
| *** notmorgan is now known as kmalloc | 20:27 | |
| mriedem | what is a bug fix? | 20:28 |
| *** johnthetubaguy_ has joined #openstack-nova | 20:28 | |
| *** fanzhang has quit IRC | 20:28 | |
| *** mordred has quit IRC | 20:28 | |
| *** toan has quit IRC | 20:28 | |
| *** icey has quit IRC | 20:28 | |
| *** andreaf has quit IRC | 20:28 | |
| *** NobodyCam has quit IRC | 20:28 | |
| *** wolsen has quit IRC | 20:28 | |
| *** zioproto has quit IRC | 20:28 | |
| *** geekinutah has quit IRC | 20:28 | |
| *** johnsom has quit IRC | 20:28 | |
| *** ameade has quit IRC | 20:28 | |
| *** ArchiFleKs has quit IRC | 20:28 | |
| *** johnthetubaguy has quit IRC | 20:28 | |
| mriedem | hongbin's patch is a bug fix | 20:28 |
| *** geekinutah_ is now known as geekinutah | 20:28 | |
| *** icey_ is now known as icey | 20:28 | |
| *** zioproto_ is now known as zioproto | 20:28 | |
| mriedem | you're adding a new feature | 20:28 |
| *** NobodyCam_ is now known as NobodyCam | 20:28 | |
| *** ameade_ is now known as ameade | 20:28 | |
| *** wolsen_ is now known as wolsen | 20:28 | |
| *** johnsom has joined #openstack-nova | 20:29 | |
| *** andreaf_ is now known as andreaf | 20:29 | |
| *** ArchiFleKs has joined #openstack-nova | 20:29 | |
| *** mordred has joined #openstack-nova | 20:30 | |
| arvindn05 | got it. Thanks for letting me know...i thought specs need to be ammended for larger changes....i can propose an amendment to the spec | 20:30 |
| *** jackie-truong has joined #openstack-nova | 20:30 | |
| mriedem | arvindn05: if we have to make an API change to GET /allocation_candidates, then it's a larger change, and all API changes require a spec anyway | 20:31 |
| *** bandini has quit IRC | 20:31 | |
| mriedem | dansmith: melwitt: i would like to phone a friend on https://review.openstack.org/#/c/554920/6/nova/api/openstack/compute/services.py@226 | 20:32 |
| dansmith | hah | 20:32 |
| melwitt | heh, awesome reference | 20:32 |
| *** bandini has joined #openstack-nova | 20:33 | |
| *** mdbooth has quit IRC | 20:33 | |
| mriedem | re: is it ok to cascade delete the resource provider while the service has instances on it | 20:33 |
| arvindn05 | mriedem: API change is just my first proposal...i would really like to avoid it if i can with a much more localized fix...but you are right its better to be discussed on the spec in case we need to make that API change | 20:33 |
| dansmith | mriedem: we currently allow them to do this anyway right? | 20:33 |
| dansmith | mriedem: deleting the resource provider doesn't affect the quota | 20:33 |
| dansmith | mriedem: it just avoids us leaking data in placement | 20:34 |
| melwitt | well, thinking ahead where we want to ask placement for cores/ram allocation usage | 20:34 |
| *** liverpooler has quit IRC | 20:34 | |
| mriedem | dansmith: we currently allow admins to delete compute services that have instances running on them, yes | 20:34 |
| melwitt | it seems like we shouldn't nuke allocations if instances are still alive, right? | 20:34 |
| dansmith | so that creates the quota issue | 20:34 |
| mriedem | but we don't currently delete the resource provider (and allocations) | 20:34 |
| mriedem | and since the compute doesn't heal allocations, | 20:35 |
| mriedem | even if you bring the compute back up, those instances are screwed and the resource provider for that node isn't going to report proper inventory | 20:35 |
| mriedem | s/inventory/consumption/ | 20:35 |
| melwitt | like, instances are still consuming resources from placement | 20:35 |
| dansmith | instances don't consume from placement, | 20:35 |
| dansmith | but yes, they'll be consuming from a provider that is no longer present | 20:36 |
| mriedem | it seems to me that if the node has instances with allocations in placement, we shouldn't delete the resource provider in that case | 20:36 |
| dansmith | mriedem: that's still true today right? if you delete it, you'll end up with a compute node that looks to be empty in placement | 20:36 |
| mriedem | dansmith: i guess the node uuid would change wouldn't it | 20:36 |
| melwitt | well, this cascade is talking about deleting the allocations too right? I thought we need to keep the allocations as long as the instance is alive, no? | 20:36 |
| mriedem | so you'd have a new provider | 20:36 |
| dansmith | so you just leak data today | 20:36 |
| dansmith | you still get out of sync the same way, but with leaked data you can never clean up | 20:37 |
| dansmith | so maybe we should block the service delete, but that's separate from if we're deleting the service, we should delete the RP I think | 20:37 |
| *** liverpooler has joined #openstack-nova | 20:38 | |
| mriedem | i can't parse that sentence | 20:39 |
| dansmith | meaning, | 20:39 |
| dansmith | if we're going to delete the service (and thus compute node), we should delete the RP in placement | 20:39 |
| dansmith | but | 20:39 |
| dansmith | if we want to block deleting the service because of instances, then that's fine and it would also block the RP | 20:39 |
| melwitt | if we want to be able to count quota usage for cores and ram from placement allocations (which we do, so we can handle cell down, and that's the right place to count cores and ram anyway), then deleting allocations when a service is deleted if instances are still running associated with that service is going to mess that up | 20:39 |
| tssurya | so we should allow a service delete only if doesn't have any living instances on that compute node ? | 20:40 |
| dansmith | melwitt: that's the same concern as deleting instances before the service for today's counting method | 20:40 |
| *** evin has quit IRC | 20:40 | |
| dansmith | melwitt: and if we don't delete the RP when we delete the service, you have no way of going back to delete the allocations you leaked later, | 20:41 |
| mriedem | well, you have ways, but not fun ways | 20:41 |
| dansmith | well, maybe you can by instance uuid, but you can't delete them by compute node uuid in bulk | 20:41 |
| dansmith | yeah | 20:41 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 20:41 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 20:41 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 20:41 |
| mriedem | you'd have to take all instances that were running on that host, find their allocations, and then remove any against RPs that no longer exist | 20:41 |
| melwitt | okay, I'm not getting the "same concern with today's counting method" part yet | 20:42 |
| dansmith | so I guess the question is.. why do we allow you to delete the service today with instances on it? | 20:42 |
| *** liverpooler has quit IRC | 20:42 | |
| mriedem | yeah i'm trying to get there | 20:42 |
| dansmith | because that would cause accounting trouble in the RT the way it was when that was added | 20:42 |
| melwitt | if you delete instances before the service today, the allocations will be deleted when you delete the instances, which is fine | 20:42 |
| dansmith | if you just delete the service, then we'll still count those instances for quota, yes, is that what you mean? | 20:43 |
| mriedem | excluding placement, if you delete the service and later restart it, we'll create a new service, but the RT will still look up instances on that service via host and nodename yeah? | 20:43 |
| efried | johnthetubaguy_: I think your -1 on https://review.openstack.org/#/c/553605/ is moot now, yes? The flag changes are being done in the previous patch, and what you were seeing in PS6 was a bad rebase. | 20:44 |
| dansmith | but you've broken things now, like you can't find the cell that the instance's host is in anymore | 20:44 |
| dansmith | so you might not be able to delete instances | 20:44 |
| melwitt | I think you meant the opposite, deleting the service before the instances. with counting today, we count from the instances table so it works. but it would break if we were counting from placement | 20:44 |
| efried | johnthetubaguy_: That delta is no longer there (that file is unchanged by this patch) | 20:44 |
| dansmith | sure, what I mean is, other things will break if you delete the service before the instances I think | 20:44 |
| melwitt | I see | 20:44 |
| mriedem | quota counting uses instance mappings right? | 20:44 |
| mriedem | to find the cell they are in | 20:44 |
| melwitt | yes | 20:45 |
| dansmith | I guess delete will as well, not host mapping | 20:45 |
| mriedem | i'm not sure what other things will break for the instance if the host mapping is gone | 20:45 |
| dansmith | alright maybe not | 20:45 |
| dansmith | that said, | 20:45 |
| dansmith | I don't think that we should not delete in placement if we're deleting our record of what those allocations are, | 20:45 |
| dansmith | because then they're leaked | 20:46 |
| dansmith | and my point being, | 20:46 |
| dansmith | we should tie the deleting of those to deleting of our service (and thus our record of how to find them) | 20:46 |
| dansmith | it seems weird to me to let people delete the service with instances on it, | 20:46 |
| dansmith | but I guess it might not fail anything today because we use the hostname as they key | 20:46 |
| mriedem | i'm totally fine with deleting the resource provider if we're going to delete the service and compute node | 20:47 |
| dansmith | we kindof have to | 20:47 |
| mriedem | i'm trying to parse if you're confirming what tssurya asked, "so we should allow a service delete only if doesn't have any living instances on that compute node ?" | 20:47 |
| melwitt | yeah, I agree we can't be leaking the allocations. but so far I'm leaning to we should block service delete if there are instances. I'm concerned about losing allocation records for instances in that case | 20:47 |
| mriedem | the easy thing to do here is not delete anything if there are instances on the node | 20:48 |
| dansmith | melwitt: yeah, I'm saying I think that makes the most sense, I'd just like to figure out why that wasn't done way back when | 20:48 |
| dansmith | maybe because it would re-heal and so meh, | 20:48 |
| dansmith | but today that's not the case | 20:48 |
| melwitt | yeah, okay. I'd also like to know | 20:48 |
| mriedem | dansmith: right, because "if you delete the service and later restart it, we'll create a new service, but the RT will still look up instances on that service via host and nodename yeah?" | 20:48 |
| dansmith | yes, I mean, | 20:49 |
| tssurya | melwitt: umm another doubt on quota counting - we don't use inst_mappings right ? we just query through all the cells DBs instances tables ? -> https://github.com/openstack/nova/blob/master/nova/quota.py#L1325 | 20:49 |
| mriedem | https://github.com/openstack/nova/blob/2c5da2212c3fa3e589c4af171486a2097fd8c54e/nova/compute/resource_tracker.py#L714 | 20:49 |
| dansmith | deleting the service today which deletes the compute node will break all manner of stuff, if not deleting instances and quotas, because we'll get a new compute node uuid | 20:49 |
| dansmith | but likely just placement-forward things where the uuid started to be a thing | 20:50 |
| mriedem | yeah. if we block the service delete, you have options to not f*ck yourself, | 20:50 |
| mriedem | like migrate the instance | 20:50 |
| melwitt | tssurya: oh, yep, you're right. I forgot ... cause we have to be able to get all instances for a project/user combo and we can't know that from instance_mappings (because it lacks user_id). but we could have done a pruning by project_id based on instance_mappings | 20:50 |
| tssurya | melwitt: which is what we plan to do once we have your spec in :D | 20:50 |
| mriedem | this is sort of like the "should we allow AZ renames for aggregates with hosts that have instances on them" | 20:51 |
| mriedem | knowing that if you do ^ you'll likely break some stuff | 20:51 |
| dansmith | yeah | 20:51 |
| melwitt | tssurya: heh, yeah :) | 20:51 |
| *** QianYu has joined #openstack-nova | 20:51 | |
| mriedem | ok so is this considered a separate bug? | 20:51 |
| *** mdbooth has joined #openstack-nova | 20:51 | |
| mriedem | or do we roll it into the same fix? | 20:52 |
| dansmith | it's a separate patch IMHO | 20:52 |
| *** yamamoto has joined #openstack-nova | 20:52 | |
| *** pchavva has quit IRC | 20:52 | |
| dansmith | which is why I was saying they're two different concerns | 20:52 |
| mriedem | that's kind of what i was thinking, it would be easier that way anyway | 20:52 |
| melwitt | +1 to separate patches | 20:52 |
| mriedem | we can build on the same functional test base i started | 20:52 |
| tssurya | sure | 20:53 |
| dansmith | yeah | 20:53 |
| mriedem | tssurya: you want me to open a separate bug? | 20:53 |
| tssurya | mriedem: yea | 20:53 |
| mriedem | also, it's 11pm there right? | 20:54 |
| tssurya | I will put up a patch tomorrow | 20:54 |
| mriedem | do you get to bill belmiro for overtime? | 20:54 |
| tssurya | mriedem: yes its 11pm :) | 20:54 |
| tssurya | haha no | 20:54 |
| *** edmondsw has joined #openstack-nova | 20:54 | |
| tssurya | this is me learning stuff from the veterans :P | 20:55 |
| *** sree has joined #openstack-nova | 20:55 | |
| *** QianYu has quit IRC | 20:55 | |
| *** dougshelley66 has quit IRC | 20:55 | |
| *** yamamoto has quit IRC | 20:56 | |
| *** edmondsw has quit IRC | 20:59 | |
| *** sree has quit IRC | 21:00 | |
| *** jackie-truong has quit IRC | 21:00 | |
| *** slaweq has quit IRC | 21:08 | |
| *** slaweq has joined #openstack-nova | 21:09 | |
| *** AlexeyAbashkin has quit IRC | 21:10 | |
| *** sidx64_ has quit IRC | 21:11 | |
| *** slaweq has quit IRC | 21:13 | |
| *** r-daneel has quit IRC | 21:15 | |
| *** r-daneel has joined #openstack-nova | 21:15 | |
| *** tssurya has quit IRC | 21:16 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in tests/unit/test_utils.py https://review.openstack.org/557883 | 21:22 |
| *** jackie-truong has joined #openstack-nova | 21:25 | |
| *** dougshelley66 has joined #openstack-nova | 21:25 | |
| *** mdbooth has quit IRC | 21:25 | |
| *** salv-orlando has quit IRC | 21:38 | |
| *** jackie-truong has quit IRC | 21:38 | |
| *** salv-orlando has joined #openstack-nova | 21:38 | |
| *** salv-orlando has quit IRC | 21:43 | |
| *** esberglu has quit IRC | 21:47 | |
| *** rcernin has joined #openstack-nova | 21:49 | |
| *** idlemind has quit IRC | 21:49 | |
| mriedem | cdent: edleafe: oh seers of http status code wisdom, hear my call, shall thou return a 400 or 409 for https://bugs.launchpad.net/nova/+bug/1763183 ? | 21:52 |
| openstack | Launchpad bug 1763183 in OpenStack Compute (nova) "DELETE /os-services/{service_id} does not block for hosted instances" [High,Triaged] - Assigned to Matt Riedemann (mriedem) | 21:52 |
| mriedem | i think 409 | 21:52 |
| cdent | i feel like I should have some kind of a 409phone | 21:53 |
| * cdent reads | 21:53 | |
| mriedem | oh and if 409, guess what, @wsgi.expected_errors((400, 404)) | 21:53 |
| mriedem | we get to have a microversion debate | 21:53 |
| mriedem | alex_xu: ^ | 21:53 |
| *** mdbooth has joined #openstack-nova | 21:53 | |
| mriedem | although, it's an admin api... | 21:54 |
| edleafe | mriedem: 400 usually means that you can make the call succeed by fixing the parameters, etc | 21:54 |
| cdent | mriedem: yes 409 | 21:54 |
| cdent | because of what edleafe just said | 21:54 |
| cdent | the server has to change to make things work, not the request | 21:55 |
| cdent | but if the server does change, then things might work when you try later | 21:55 |
| mriedem | yeah 409 is correct, but need to figure out if i can get by the existing expected errors decorator | 21:55 |
| mriedem | but i think with the legal caveat in https://docs.openstack.org/nova/latest/contributor/microversions.html#when-a-microversion-is-not-needed 3rd bullet | 21:55 |
| mriedem | we maybe can | 21:55 |
| *** lpetrut has quit IRC | 21:56 | |
| *** Guest25648 has quit IRC | 21:57 | |
| *** _ix has quit IRC | 21:57 | |
| *** felipemonteiro_ has quit IRC | 22:02 | |
| *** itlinux has quit IRC | 22:03 | |
| *** gjayavelu has quit IRC | 22:05 | |
| *** itlinux has joined #openstack-nova | 22:06 | |
| *** cdent has quit IRC | 22:07 | |
| *** hamzy has quit IRC | 22:07 | |
| *** itlinux has quit IRC | 22:07 | |
| mriedem | oh my | 22:08 |
| mriedem | this is the issue that keeps on giving | 22:08 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1679750 | 22:10 |
| openstack | Launchpad bug 1679750 in OpenStack Compute (nova) queens "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Confirmed] | 22:10 |
| mriedem | efried: seems delete_resource_provider should fail if delete_allocation_for_instance returns False... | 22:17 |
| efried | ... | 22:18 |
| efried | mriedem: 404 means there were no allocations for that consumer. Which is fine in the context of delete_resource_provider. Am I misunderstanding something? | 22:19 |
| *** mlavalle has quit IRC | 22:19 | |
| mriedem | getting a 409 | 22:19 |
| mriedem | and now i know why | 22:19 |
| efried | 409 is gonna mean generation conflict. | 22:19 |
| mriedem | no it's not that | 22:19 |
| efried | And sorry, I missed that we return False for any 4xx | 22:19 |
| efried | mriedem: I think 404 should return True (or somehow otherwise be ignorable) and any other 4xx should be a failure in delete_resource_provider - agreed. | 22:20 |
| mriedem | so i'm not actually calling this https://github.com/openstack/nova/blob/fe976dcc559d059589a9ccf953a28e855abf50fb/nova/scheduler/client/report.py#L1920 | 22:20 |
| mriedem | because the list of instances is empty, because the compute service is down so when i delete the instance, the api removes it 'locally' but doesn't cleanup allocations | 22:20 |
| mriedem | because of bug 1679750 | 22:20 |
| openstack | bug 1679750 in OpenStack Compute (nova) queens "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Confirmed] https://launchpad.net/bugs/1679750 | 22:20 |
| mriedem | then https://github.com/openstack/nova/blob/fe976dcc559d059589a9ccf953a28e855abf50fb/nova/scheduler/client/report.py#L1922 fails with ResourceProviderInUse and we pass | 22:21 |
| efried | noyce | 22:21 |
| efried | mriedem: Me, I would rewrite a cascading RP deletion routine that doesn't rely on nova-isms. | 22:22 |
| efried | You pass it a provider name/UUID and it goes after all related records, period. | 22:22 |
| efried | I thought we had that somewhere already. | 22:22 |
| mriedem | i just need to fix that bug | 22:22 |
| mriedem | which has been around forever | 22:22 |
| mriedem | i'm actually happy my test fails here, because the cascade silent fail means we're not doing something right | 22:23 |
| efried | mriedem: Do you need help writing a real cascading delete in report client? | 22:23 |
| mriedem | no | 22:23 |
| mriedem | i need to fix that bug in the api local delete case to cleanup allocations in placement when the compute service is down | 22:24 |
| mriedem | will be more clear when i post this code | 22:24 |
| efried | Which you're going to need to do by getting placement to delete allocations based on the resource providers, not the instances. | 22:24 |
| mriedem | no | 22:24 |
| mriedem | we're deleting the instance | 22:24 |
| mriedem | we know the consume | 22:24 |
| mriedem | *consumer, so we get the allocations to delete | 22:25 |
| mriedem | https://developer.openstack.org/api-ref/placement/#delete-allocations | 22:25 |
| cfriesen | when doing a "git cherry-pick -x" do we generally preserve any conflicts or remove them from the commit message? | 22:25 |
| cfriesen | for backporting | 22:25 |
| efried | cfriesen: preserve (and explain if necessary) | 22:26 |
| mriedem | cfriesen: i leave the conflicts in the commit message and make a note about what they are to help reviewers | 22:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for deleting a compute service https://review.openstack.org/560626 | 22:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 22:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Block deleting compute services which are hosting instances https://review.openstack.org/560674 | 22:26 |
| mriedem | efried: ^ should make it more clear | 22:26 |
| efried | mriedem: ack, will look mañana | 22:26 |
| *** andreas_s has joined #openstack-nova | 22:26 | |
| mriedem | manana iguana? https://www.amazon.com/Manana-Iguana-Ann-Whitford-Paul/dp/0823419800 | 22:26 |
| mriedem | 2 childrens books references in one day | 22:27 |
| mriedem | those are for dansmith and jaypipes btw | 22:27 |
| *** mdbooth has quit IRC | 22:27 | |
| *** tbachman has joined #openstack-nova | 22:30 | |
| -openstackstatus- NOTICE: zuul was restarted to updated to the latest code; you may need to recheck changes uploaded or approvals added between 21:30 and 21:45 | 22:30 | |
| *** andreas_s has quit IRC | 22:31 | |
| jaypipes | ewww | 22:35 |
| mriedem | there goes a gate reset so that functional test fix is going to be awhile yet | 22:36 |
| *** mriedem is now known as mriedem_afk | 22:36 | |
| *** salv-orlando has joined #openstack-nova | 22:39 | |
| *** derekh has quit IRC | 22:40 | |
| *** jafeha__ has joined #openstack-nova | 22:41 | |
| *** jafeha has quit IRC | 22:42 | |
| *** felipemonteiro_ has joined #openstack-nova | 22:42 | |
| *** edmondsw has joined #openstack-nova | 22:43 | |
| *** salv-orlando has quit IRC | 22:43 | |
| *** yamamoto has joined #openstack-nova | 22:46 | |
| *** edmondsw has quit IRC | 22:48 | |
| *** yamamoto has quit IRC | 22:50 | |
| *** tobasco has quit IRC | 22:50 | |
| *** yamamoto has joined #openstack-nova | 22:51 | |
| *** hongbin has quit IRC | 22:53 | |
| *** _ix has joined #openstack-nova | 22:54 | |
| *** yamamoto has quit IRC | 22:56 | |
| *** mdbooth has joined #openstack-nova | 22:56 | |
| *** yamamoto has joined #openstack-nova | 22:57 | |
| *** tobasco has joined #openstack-nova | 22:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: test.stub_object https://review.openstack.org/560683 | 23:01 |
| *** yamamoto has quit IRC | 23:01 | |
| *** gjayavelu has joined #openstack-nova | 23:03 | |
| *** yamamoto has joined #openstack-nova | 23:03 | |
| *** slaweq has joined #openstack-nova | 23:09 | |
| *** sree has joined #openstack-nova | 23:11 | |
| *** slaweq has quit IRC | 23:14 | |
| *** sree has quit IRC | 23:16 | |
| *** randomhack has joined #openstack-nova | 23:18 | |
| *** pchavva has joined #openstack-nova | 23:19 | |
| *** suresh12 has quit IRC | 23:19 | |
| *** suresh12 has joined #openstack-nova | 23:20 | |
| *** suresh12 has quit IRC | 23:24 | |
| *** _ix has quit IRC | 23:29 | |
| openstackgerrit | Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | 23:30 |
| *** mdbooth has quit IRC | 23:31 | |
| *** pchavva has quit IRC | 23:31 | |
| *** gjayavelu has quit IRC | 23:34 | |
| *** claudiub has quit IRC | 23:35 | |
| *** takashin has joined #openstack-nova | 23:38 | |
| *** salv-orlando has joined #openstack-nova | 23:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 23:42 |
| *** felipemonteiro_ has quit IRC | 23:42 | |
| *** suresh12 has joined #openstack-nova | 23:45 | |
| *** salv-orlando has quit IRC | 23:45 | |
| *** yamamoto has quit IRC | 23:47 | |
| *** owalsh is now known as owalsh_afk | 23:47 | |
| *** mdbooth has joined #openstack-nova | 23:48 | |
| gmann | sdague: can you feedback on this comment (one of TODO from you) - https://review.openstack.org/#/c/529520/18/api-ref/source/servers.inc@765 | 23:50 |
| gmann | sdague: i feel single latest sample response file is good enough instead of separate sample files per request attribute for update | 23:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_neutron_security_groups.py https://review.openstack.org/560267 | 23:51 |
| *** moshele has joined #openstack-nova | 23:54 | |
| *** haha1 has quit IRC | 23:57 | |
| *** yinxq has joined #openstack-nova | 23:58 | |
| *** moshele has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!