| *** elmaciej has joined #openstack-nova | 00:06 | |
| *** danpawlik has quit IRC | 00:07 | |
| *** edmondsw has joined #openstack-nova | 00:09 | |
| *** edmondsw has quit IRC | 00:14 | |
| *** elmaciej has quit IRC | 00:20 | |
| *** odyssey4me has quit IRC | 00:23 | |
| *** odyssey4me has joined #openstack-nova | 00:23 | |
| *** danpawlik has joined #openstack-nova | 00:38 | |
| *** tbachman has joined #openstack-nova | 00:43 | |
| *** danpawlik has quit IRC | 00:47 | |
| *** danpawlik has joined #openstack-nova | 00:48 | |
| *** danpawlik has quit IRC | 00:57 | |
| *** hemna_ has joined #openstack-nova | 01:01 | |
| openstackgerrit | jichenjc proposed openstack/nova stable/queens: Avoid showing password in log https://review.openstack.org/559603 | 01:05 |
|---|---|---|
| *** hemna_ has quit IRC | 01:05 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 01:06 |
| *** zhaochao has joined #openstack-nova | 01:09 | |
| *** suresh12 has joined #openstack-nova | 01:11 | |
| *** Zames has joined #openstack-nova | 01:16 | |
| *** salv-orlando has quit IRC | 01:16 | |
| *** suresh12 has quit IRC | 01:16 | |
| *** salv-orlando has joined #openstack-nova | 01:16 | |
| *** Zames has quit IRC | 01:18 | |
| *** QianYu has joined #openstack-nova | 01:26 | |
| *** hongbin has joined #openstack-nova | 01:27 | |
| *** danpawlik has joined #openstack-nova | 01:28 | |
| *** vladikr has joined #openstack-nova | 01:31 | |
| *** Guest35063 has quit IRC | 01:37 | |
| *** danpawlik has quit IRC | 01:37 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid live migrate to same host https://review.openstack.org/542689 | 01:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152 | 01:38 |
| *** blkart has quit IRC | 01:45 | |
| *** ssurana has joined #openstack-nova | 01:46 | |
| *** AlexeyAbashkin has joined #openstack-nova | 01:50 | |
| *** tonyb has joined #openstack-nova | 01:50 | |
| *** blkart has joined #openstack-nova | 01:51 | |
| *** Guest35063 has joined #openstack-nova | 01:53 | |
| *** AlexeyAbashkin has quit IRC | 01:54 | |
| *** tiendc has joined #openstack-nova | 01:54 | |
| *** edmondsw has joined #openstack-nova | 01:57 | |
| *** alex_xu has joined #openstack-nova | 01:58 | |
| *** vladikr has quit IRC | 02:01 | |
| *** stakeda has quit IRC | 02:01 | |
| *** edmondsw has quit IRC | 02:02 | |
| *** vladikr has joined #openstack-nova | 02:02 | |
| *** stakeda has joined #openstack-nova | 02:04 | |
| *** danpawlik has joined #openstack-nova | 02:08 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 02:10 |
| *** edleafe- has joined #openstack-nova | 02:10 | |
| *** ssurana1 has joined #openstack-nova | 02:10 | |
| *** edleafe has quit IRC | 02:10 | |
| *** edleafe- is now known as edleafe | 02:10 | |
| *** slaweq has joined #openstack-nova | 02:10 | |
| *** ssurana has quit IRC | 02:14 | |
| *** slaweq has quit IRC | 02:15 | |
| *** danpawlik has quit IRC | 02:22 | |
| *** sapd_ has joined #openstack-nova | 02:23 | |
| *** suresh12 has joined #openstack-nova | 02:26 | |
| *** sapd has quit IRC | 02:26 | |
| *** markvoelker has quit IRC | 02:28 | |
| *** markvoelker has joined #openstack-nova | 02:29 | |
| *** markvoelker has quit IRC | 02:34 | |
| *** mikal_ has quit IRC | 02:36 | |
| *** mikal has joined #openstack-nova | 02:36 | |
| *** QianYu has quit IRC | 02:37 | |
| *** tetsuro has joined #openstack-nova | 02:38 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 02:44 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 02:46 |
| *** AlexeyAbashkin has joined #openstack-nova | 02:50 | |
| *** danpawlik has joined #openstack-nova | 02:53 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | 02:55 |
| *** AlexeyAbashkin has quit IRC | 02:55 | |
| openstackgerrit | jichenjc proposed openstack/nova master: make metadata doc up to date https://review.openstack.org/559613 | 02:56 |
| *** suresh12 has quit IRC | 02:57 | |
| *** danpawlik has quit IRC | 03:02 | |
| *** QianYu has joined #openstack-nova | 03:02 | |
| *** danpawlik has joined #openstack-nova | 03:03 | |
| *** mdnadeem has joined #openstack-nova | 03:05 | |
| *** imacdonn has joined #openstack-nova | 03:08 | |
| *** suresh12 has joined #openstack-nova | 03:09 | |
| *** danpawlik has quit IRC | 03:12 | |
| *** danpawlik has joined #openstack-nova | 03:13 | |
| *** QianYu has quit IRC | 03:19 | |
| *** suresh12 has quit IRC | 03:19 | |
| *** sree has joined #openstack-nova | 03:19 | |
| *** QianYu has joined #openstack-nova | 03:21 | |
| *** danpawlik has quit IRC | 03:22 | |
| *** suresh12 has joined #openstack-nova | 03:23 | |
| *** vipul has quit IRC | 03:29 | |
| *** Kevin_Zheng has joined #openstack-nova | 03:30 | |
| *** vipul has joined #openstack-nova | 03:41 | |
| *** edmondsw has joined #openstack-nova | 03:45 | |
| *** annp has joined #openstack-nova | 03:46 | |
| *** edmondsw has quit IRC | 03:50 | |
| *** danpawlik has joined #openstack-nova | 03:53 | |
| *** vipul has quit IRC | 03:53 | |
| *** janki has joined #openstack-nova | 03:53 | |
| *** vipul has joined #openstack-nova | 03:54 | |
| *** tiendc has quit IRC | 03:57 | |
| *** tiendc has joined #openstack-nova | 03:58 | |
| *** danpawlik has quit IRC | 04:02 | |
| *** mdnadeem has quit IRC | 04:04 | |
| *** hongbin has quit IRC | 04:05 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:07 | |
| *** Zames has joined #openstack-nova | 04:09 | |
| *** Zames has quit IRC | 04:12 | |
| *** udesale has joined #openstack-nova | 04:17 | |
| *** psachin has joined #openstack-nova | 04:20 | |
| *** vladikr has quit IRC | 04:21 | |
| *** vladikr has joined #openstack-nova | 04:22 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates https://review.openstack.org/556514 | 04:24 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | 04:24 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554 | 04:24 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consult the dictionary for root provider ids https://review.openstack.org/559555 | 04:24 |
| *** links has joined #openstack-nova | 04:25 | |
| *** andreas_s has joined #openstack-nova | 04:30 | |
| *** jchhatbar has joined #openstack-nova | 04:30 | |
| *** danpawlik has joined #openstack-nova | 04:33 | |
| *** janki has quit IRC | 04:33 | |
| *** abhishekk has joined #openstack-nova | 04:35 | |
| *** andreas_s has quit IRC | 04:35 | |
| *** fragatina has quit IRC | 04:35 | |
| *** ssurana1 has quit IRC | 04:40 | |
| *** ssurana has joined #openstack-nova | 04:41 | |
| *** danpawlik has quit IRC | 04:42 | |
| *** fragatina has joined #openstack-nova | 04:42 | |
| *** dikonoor has joined #openstack-nova | 04:47 | |
| *** tianhui_ has joined #openstack-nova | 04:48 | |
| *** Zames has joined #openstack-nova | 04:48 | |
| *** tianhui has quit IRC | 04:50 | |
| *** Zames has quit IRC | 04:55 | |
| *** Dinesh__Bhor has joined #openstack-nova | 04:56 | |
| *** Dinesh_Bhor has quit IRC | 04:57 | |
| *** artom has quit IRC | 05:02 | |
| *** artom has joined #openstack-nova | 05:02 | |
| *** hemna_ has joined #openstack-nova | 05:03 | |
| *** phuongnh has joined #openstack-nova | 05:03 | |
| *** hemna_ has quit IRC | 05:08 | |
| *** ratailor has joined #openstack-nova | 05:09 | |
| *** danpawlik has joined #openstack-nova | 05:13 | |
| *** danpawlik has quit IRC | 05:22 | |
| *** danpawlik has joined #openstack-nova | 05:23 | |
| *** vivsoni has joined #openstack-nova | 05:26 | |
| *** suresh12 has quit IRC | 05:28 | |
| *** suresh12 has joined #openstack-nova | 05:28 | |
| *** trinaths has joined #openstack-nova | 05:30 | |
| *** udesale_ has joined #openstack-nova | 05:30 | |
| *** sar has quit IRC | 05:32 | |
| *** udesale has quit IRC | 05:33 | |
| *** edmondsw has joined #openstack-nova | 05:33 | |
| *** edmondsw has quit IRC | 05:38 | |
| *** suresh12 has quit IRC | 05:39 | |
| *** suresh12 has joined #openstack-nova | 05:39 | |
| *** suresh12 has quit IRC | 05:44 | |
| *** zhurong has joined #openstack-nova | 05:44 | |
| *** sridharg has joined #openstack-nova | 05:47 | |
| *** danpawlik has quit IRC | 05:52 | |
| *** lajoskatona has joined #openstack-nova | 05:57 | |
| *** takedakn has joined #openstack-nova | 05:58 | |
| *** vipul has quit IRC | 06:07 | |
| *** takedakn has quit IRC | 06:08 | |
| *** shaohe_feng has quit IRC | 06:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704 | 06:12 |
| *** slaweq has joined #openstack-nova | 06:12 | |
| *** shaohe_feng has joined #openstack-nova | 06:13 | |
| *** vipul has joined #openstack-nova | 06:14 | |
| *** slaweq has quit IRC | 06:17 | |
| *** lpetrut has joined #openstack-nova | 06:18 | |
| *** sar has joined #openstack-nova | 06:19 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Improve getting nested providers with capacity https://review.openstack.org/559638 | 06:22 |
| *** danpawlik has joined #openstack-nova | 06:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2) https://review.openstack.org/558993 | 06:28 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3) https://review.openstack.org/559258 | 06:28 |
| *** namnh has joined #openstack-nova | 06:29 | |
| *** armaan has joined #openstack-nova | 06:32 | |
| *** andreas_s has joined #openstack-nova | 06:33 | |
| *** pcaruana has joined #openstack-nova | 06:35 | |
| *** sahid has joined #openstack-nova | 06:39 | |
| *** ejat_ is now known as ejat | 06:39 | |
| *** ejat has quit IRC | 06:39 | |
| *** ejat has joined #openstack-nova | 06:39 | |
| *** armaan has quit IRC | 06:41 | |
| *** armaan has joined #openstack-nova | 06:41 | |
| *** andreas_s has quit IRC | 06:42 | |
| *** oanson has quit IRC | 06:42 | |
| *** oanson has joined #openstack-nova | 06:44 | |
| *** namnh has quit IRC | 06:46 | |
| *** udesale__ has joined #openstack-nova | 06:46 | |
| *** namnh has joined #openstack-nova | 06:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_user_data.py https://review.openstack.org/559264 | 06:47 |
| *** belmoreira has joined #openstack-nova | 06:49 | |
| *** udesale_ has quit IRC | 06:49 | |
| *** ralonsoh has joined #openstack-nova | 06:54 | |
| *** slaweq has joined #openstack-nova | 06:56 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_instance_actions.py https://review.openstack.org/559269 | 06:58 |
| *** rodolof has joined #openstack-nova | 07:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture https://review.openstack.org/558160 | 07:09 |
| *** tianhui_ has quit IRC | 07:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py https://review.openstack.org/558685 | 07:09 |
| *** Dinesh__Bhor has quit IRC | 07:09 | |
| *** yikun_ has joined #openstack-nova | 07:11 | |
| *** Dinesh__Bhor has joined #openstack-nova | 07:11 | |
| *** tianhui has joined #openstack-nova | 07:12 | |
| *** zhurong has quit IRC | 07:13 | |
| *** kholkina has joined #openstack-nova | 07:14 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| *** namnh has quit IRC | 07:14 | |
| *** tiendc has quit IRC | 07:14 | |
| *** tiendc has joined #openstack-nova | 07:14 | |
| *** namnh has joined #openstack-nova | 07:14 | |
| *** vipul has quit IRC | 07:16 | |
| *** rcernin has quit IRC | 07:16 | |
| *** vipul has joined #openstack-nova | 07:17 | |
| *** trinaths has quit IRC | 07:20 | |
| *** edmondsw has joined #openstack-nova | 07:21 | |
| *** zz9pzza has quit IRC | 07:22 | |
| *** lpetrut has quit IRC | 07:25 | |
| *** andreas_s has joined #openstack-nova | 07:26 | |
| *** edmondsw has quit IRC | 07:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_password.py https://review.openstack.org/559649 | 07:29 |
| *** jistr is now known as jistr|dentist | 07:34 | |
| *** aloga has quit IRC | 07:34 | |
| *** aloga has joined #openstack-nova | 07:34 | |
| *** amoralej|off is now known as amoralej | 07:37 | |
| *** damien_r has joined #openstack-nova | 07:39 | |
| *** tssurya has joined #openstack-nova | 07:39 | |
| *** ccamacho has joined #openstack-nova | 07:41 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity. https://review.openstack.org/556762 | 07:41 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Add nodes to group hosts to be checked against aggregation https://review.openstack.org/559651 | 07:41 |
| *** yikun has joined #openstack-nova | 07:44 | |
| *** damien_r has quit IRC | 07:50 | |
| *** jpena|off is now known as jpena | 07:50 | |
| *** damien_r has joined #openstack-nova | 07:51 | |
| *** lpetrut has joined #openstack-nova | 07:51 | |
| *** zz9pzza has joined #openstack-nova | 07:52 | |
| *** lucas-afk is now known as lucasagomes | 07:56 | |
| bauzas | good morning Stackers | 07:57 |
| *** hoonetorg has quit IRC | 07:59 | |
| *** trinaths has joined #openstack-nova | 08:01 | |
| *** lpetrut has quit IRC | 08:02 | |
| tssurya | good morning bauzas | 08:08 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 08:11 |
| *** hoonetorg has joined #openstack-nova | 08:12 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 08:12 |
| *** suresh12 has joined #openstack-nova | 08:16 | |
| *** danpawlik has quit IRC | 08:19 | |
| *** suresh12 has quit IRC | 08:21 | |
| tetsuro | good morning | 08:24 |
| *** derekh has joined #openstack-nova | 08:32 | |
| *** elmaciej has joined #openstack-nova | 08:32 | |
| *** avolkov has joined #openstack-nova | 08:33 | |
| *** mdnadeem has joined #openstack-nova | 08:33 | |
| *** dikonoor has quit IRC | 08:36 | |
| *** cdent has joined #openstack-nova | 08:39 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 08:40 |
| *** elmaciej has quit IRC | 08:42 | |
| *** danpawlik has joined #openstack-nova | 08:44 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 08:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 08:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 08:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 08:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 08:47 |
| *** danpawlik has quit IRC | 08:54 | |
| *** sambetts|afk is now known as sambetts | 08:55 | |
| lyarwood | Morning all - https://review.openstack.org/#/c/544238/ +2'd by Matt last week, any additional core reviews would be appreciated. | 08:57 |
| *** trinaths has quit IRC | 08:58 | |
| *** Sasikiran has joined #openstack-nova | 09:00 | |
| Sasikiran | Hi All, Is there any steps to recover a vm in error state ("Unexpected vif_type=baremetal", "code": 500, "details": " File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 375, in decorated_function ) | 09:00 |
| *** jogo has quit IRC | 09:01 | |
| *** jistr|dentist is now known as jistr | 09:02 | |
| *** alex_xu has quit IRC | 09:03 | |
| *** Sasikiran has quit IRC | 09:03 | |
| *** hemna_ has joined #openstack-nova | 09:05 | |
| *** alex_xu has joined #openstack-nova | 09:08 | |
| *** hemna_ has quit IRC | 09:09 | |
| *** edmondsw has joined #openstack-nova | 09:10 | |
| *** dikonoor has joined #openstack-nova | 09:10 | |
| *** edmondsw has quit IRC | 09:14 | |
| *** jogo has joined #openstack-nova | 09:20 | |
| *** armaan has quit IRC | 09:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_metadata.py https://review.openstack.org/559673 | 09:25 |
| *** rabel has left #openstack-nova | 09:25 | |
| *** ygl has joined #openstack-nova | 09:30 | |
| *** armaan has joined #openstack-nova | 09:30 | |
| *** ygl has left #openstack-nova | 09:31 | |
| *** Dinesh__Bhor has quit IRC | 09:31 | |
| *** gyankum has joined #openstack-nova | 09:34 | |
| *** armaan has quit IRC | 09:35 | |
| *** takashin has left #openstack-nova | 09:36 | |
| *** ragiman has joined #openstack-nova | 09:37 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 09:38 |
| *** andreas_s has quit IRC | 09:40 | |
| *** lpetrut has joined #openstack-nova | 09:42 | |
| *** tianhui has quit IRC | 09:44 | |
| *** tianhui_ has joined #openstack-nova | 09:45 | |
| *** dikonoor has quit IRC | 09:48 | |
| *** yikun_ has quit IRC | 09:50 | |
| *** ssurana has quit IRC | 09:55 | |
| *** jchhatbar has quit IRC | 09:55 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 09:58 |
| *** tiendc has quit IRC | 09:58 | |
| *** namnh has quit IRC | 09:58 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171 | 09:58 |
| *** mgoddard has joined #openstack-nova | 09:58 | |
| *** tiendc has joined #openstack-nova | 09:58 | |
| *** namnh has joined #openstack-nova | 09:58 | |
| *** maciejjozefczyk has joined #openstack-nova | 10:01 | |
| *** namnh has quit IRC | 10:08 | |
| *** stakeda has quit IRC | 10:08 | |
| *** dikonoor has joined #openstack-nova | 10:10 | |
| *** QianYu has quit IRC | 10:12 | |
| *** andreas_s has joined #openstack-nova | 10:16 | |
| *** sridharg has quit IRC | 10:20 | |
| *** gyankum has quit IRC | 10:27 | |
| *** slaweq has quit IRC | 10:32 | |
| *** nicolasbock has joined #openstack-nova | 10:34 | |
| *** slaweq has joined #openstack-nova | 10:35 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 10:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 10:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 10:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 10:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 10:38 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 10:38 |
| *** elmaciej has joined #openstack-nova | 10:39 | |
| *** lpetrut has quit IRC | 10:40 | |
| *** sree has quit IRC | 10:43 | |
| *** tbachman has quit IRC | 10:46 | |
| *** dikonoor has quit IRC | 10:49 | |
| *** lpetrut has joined #openstack-nova | 10:52 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700 | 10:53 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559702 | 10:53 |
| *** abhishekk has quit IRC | 10:54 | |
| *** dikonoor has joined #openstack-nova | 10:57 | |
| *** edmondsw has joined #openstack-nova | 10:58 | |
| *** trinaths has joined #openstack-nova | 10:59 | |
| kashyap | johnthetubaguy: As agreed on the list, bumped the NEXT_MIN versions to whats on Debian Stretch: https://review.openstack.org/558783 | 11:00 |
| *** edmondsw has quit IRC | 11:03 | |
| *** lpetrut has quit IRC | 11:04 | |
| *** lucasagomes is now known as lucas-hungry | 11:05 | |
| *** armaan has joined #openstack-nova | 11:05 | |
| *** phuongnh has quit IRC | 11:06 | |
| *** xinliang has quit IRC | 11:16 | |
| *** fragatina has quit IRC | 11:17 | |
| *** tetsuro has left #openstack-nova | 11:20 | |
| *** udesale__ has quit IRC | 11:20 | |
| *** vladikr has quit IRC | 11:21 | |
| *** vladikr has joined #openstack-nova | 11:22 | |
| *** xinliang has joined #openstack-nova | 11:27 | |
| *** sridharg has joined #openstack-nova | 11:29 | |
| *** sridharg has quit IRC | 11:29 | |
| *** sridharg has joined #openstack-nova | 11:30 | |
| *** elod has quit IRC | 11:36 | |
| *** elod has joined #openstack-nova | 11:38 | |
| *** trinaths has quit IRC | 11:41 | |
| *** jpena is now known as jpena|lunch | 11:42 | |
| *** gyankum has joined #openstack-nova | 11:45 | |
| *** artom has quit IRC | 11:46 | |
| *** tiendc has quit IRC | 11:46 | |
| *** lajoskatona has quit IRC | 11:46 | |
| openstackgerrit | Merged openstack/nova master: conf: Remove 'db_driver' config opt https://review.openstack.org/508487 | 11:46 |
| *** psachin has quit IRC | 11:53 | |
| *** lajoskatona has joined #openstack-nova | 11:55 | |
| *** lucas-hungry is now known as lucasagomes | 11:56 | |
| *** edmondsw has joined #openstack-nova | 12:04 | |
| *** gyankum has quit IRC | 12:04 | |
| *** tbachman has joined #openstack-nova | 12:04 | |
| *** tbachman_ has joined #openstack-nova | 12:07 | |
| *** tbachman has quit IRC | 12:09 | |
| *** tbachman_ is now known as tbachman | 12:09 | |
| *** takashin has joined #openstack-nova | 12:11 | |
| *** psachin has joined #openstack-nova | 12:14 | |
| *** sree_ has joined #openstack-nova | 12:14 | |
| *** sree_ is now known as Guest87354 | 12:14 | |
| *** suresh12 has joined #openstack-nova | 12:17 | |
| *** sdague has joined #openstack-nova | 12:17 | |
| *** Guest87354 has quit IRC | 12:19 | |
| *** suresh12 has quit IRC | 12:21 | |
| *** Eran_Kuris has quit IRC | 12:26 | |
| *** udesale has joined #openstack-nova | 12:28 | |
| *** udesale has quit IRC | 12:31 | |
| *** udesale has joined #openstack-nova | 12:32 | |
| *** jpena|lunch is now known as jpena | 12:32 | |
| *** nicolasbock has quit IRC | 12:33 | |
| *** armaan has quit IRC | 12:36 | |
| *** armaan has joined #openstack-nova | 12:36 | |
| *** nicolasbock has joined #openstack-nova | 12:37 | |
| *** odyssey4me has quit IRC | 12:38 | |
| *** odyssey4me has joined #openstack-nova | 12:38 | |
| *** Eran_Kuris has joined #openstack-nova | 12:39 | |
| *** ratailor has quit IRC | 12:39 | |
| *** dave-mccowan has joined #openstack-nova | 12:40 | |
| openstackgerrit | sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820 | 12:41 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514 | 12:41 |
| *** liverpooler has joined #openstack-nova | 12:42 | |
| *** dpawlik has joined #openstack-nova | 12:43 | |
| openstackgerrit | Merged openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 12:44 |
| *** dave-mcc_ has joined #openstack-nova | 12:44 | |
| *** dave-mccowan has quit IRC | 12:45 | |
| *** pcaruana has quit IRC | 12:46 | |
| *** gouthamr has joined #openstack-nova | 12:49 | |
| efried | lyarwood: I theeeenk there's a bug in your test cases. | 12:51 |
| *** gouthamr has quit IRC | 12:52 | |
| *** ktibi has joined #openstack-nova | 12:52 | |
| ktibi | Hi nova, Anyone have already see this issue : when I add a second NIC on my instance, instance hang on reboot, just after random: crng init done :/ | 12:52 |
| *** _ix has joined #openstack-nova | 12:53 | |
| lyarwood | efried: do I need to reset the mock_get_encryption mock? | 12:55 |
| efried | lyarwood: I'm commenting it up. But 1) .side_effects isn't a thing (it's spelled .side_effect); and 2) when you have .side_effect set, .return_value is ignored. | 12:56 |
| efried | lyarwood: I confirmed by removing those two .side_effects lines (the test still passes) | 12:56 |
| lyarwood | gah, nice catch | 12:57 |
| *** pchavva has joined #openstack-nova | 12:57 | |
| efried | lyarwood: Okay, commented. Care to fix the formatting since you're respinning anyway? :) | 12:59 |
| lyarwood | efried: sure if you could elaborate a little on why the current style is an issue | 13:01 |
| *** lyan has joined #openstack-nova | 13:01 | |
| *** lajoskatona has left #openstack-nova | 13:01 | |
| efried | lyarwood: What I would do is set the side_effect to [{}, {}] and make sure you *don't* raise. | 13:01 |
| *** lyan is now known as Guest64304 | 13:01 | |
| *** AlexeyAbashkin has joined #openstack-nova | 13:01 | |
| *** dikonoo has joined #openstack-nova | 13:02 | |
| lyarwood | efried: right, sorry I was asking about L1553 in driver.py | 13:02 |
| efried | lyarwood: Oh, because a) backslashes are icky, and b) having the second line of the condition at the same indent level as the interior of the condition is icky. | 13:02 |
| *** gouthamr has joined #openstack-nova | 13:02 | |
| efried | For the latter, we have a pep rule... disabled in the nova project. (Couldn't tell you why) | 13:02 |
| *** sree has joined #openstack-nova | 13:02 | |
| lyarwood | efried: kk, right I didn't know there was a pep rule for that, I'll sort that out now as well. | 13:02 |
| lyarwood | efried: thanks :) | 13:03 |
| efried | lyarwood: Thank you | 13:03 |
| *** mriedem has joined #openstack-nova | 13:03 | |
| *** psachin has quit IRC | 13:04 | |
| *** READ10 has joined #openstack-nova | 13:05 | |
| *** dikonoor has quit IRC | 13:06 | |
| *** _ix has quit IRC | 13:07 | |
| *** AlexeyAbashkin has quit IRC | 13:10 | |
| *** AlexeyAbashkin has joined #openstack-nova | 13:10 | |
| *** pcaruana has joined #openstack-nova | 13:11 | |
| *** udesale has quit IRC | 13:12 | |
| *** udesale has joined #openstack-nova | 13:13 | |
| openstackgerrit | Merged openstack/nova-specs master: Fix typos in NUMA-aware live migration https://review.openstack.org/558842 | 13:13 |
| *** gouthamr has quit IRC | 13:15 | |
| *** AlexeyAbashkin has quit IRC | 13:17 | |
| *** gouthamr has joined #openstack-nova | 13:17 | |
| *** Zames has joined #openstack-nova | 13:17 | |
| *** AlexeyAbashkin has joined #openstack-nova | 13:17 | |
| sean-k-mooney | o/ | 13:18 |
| sean-k-mooney | finucannot: are you about? | 13:19 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | 13:20 |
| lyarwood | efried: ^ sorry was interrupted, the [{}, {}] case is tested by all of the other swap_volume tests FWIW | 13:21 |
| lyarwood | efried: but I can add it if you really want it in there | 13:21 |
| efried | lyarwood: I figured it was; it would just be a way to make sure your mocks are doing the right thing. | 13:22 |
| *** Zames has quit IRC | 13:22 | |
| efried | lyarwood: Not necessary to add it here. | 13:22 |
| *** tetsuro has joined #openstack-nova | 13:22 | |
| *** tblakes has joined #openstack-nova | 13:22 | |
| *** janki has joined #openstack-nova | 13:22 | |
| efried | lyarwood: Just sayin, if it had been in there, with .side_effects, it wouldn't have worked as expected, and after some head scratching, you would have found the other bug that everybody missed :) | 13:22 |
| tblakes | mriedem: Does https://review.openstack.org/#/c/555812/ still require the patch you suggested? The review comments at https://review.openstack.org/#/c/559169/ seem to indicate not. If it doesn't require the patch, is https://review.openstack.org/#/c/559158/ then ready to be cherry-picked in to stable/queens? | 13:24 |
| lyarwood | efried: yeah true, I'd need to move this into a seperate method to make testing a little easier, otherwise I'll end up mocking all of swap_volume again. | 13:25 |
| efried | lyarwood: Yeah, I figured that was probably the case. It's fine this way. | 13:25 |
| *** gouthamr has quit IRC | 13:26 | |
| *** lbragstad has joined #openstack-nova | 13:27 | |
| efried | lyarwood: +2 (with some optional formatting nits) | 13:29 |
| kholkina | Hi! Could you please explain why free_ram_mb + memory_mb_used != memory_mb? How does it calculated? | 13:30 |
| kholkina | I mean values in 'nova hypervisor-show' | 13:31 |
| lyarwood | efried: thanks, can't say I agree with the nit but if others also call it out I'll respin :) | 13:31 |
| *** david-lyle has quit IRC | 13:31 | |
| * lyarwood didn't see the test nits | 13:31 | |
| lyarwood | urgh sorry that's not good | 13:32 |
| efried | lyarwood: Yeah, I'm sure there's a reason we've got those peps switched off - it must be because the ptb don't care. | 13:32 |
| efried | lyarwood: FYI, this excerpt from tox.ini explains to some extent: | 13:33 |
| efried | # Most of the whitespace related rules (E12* and E131) are excluded | 13:33 |
| efried | # because while they are often useful guidelines, strict adherence to | 13:33 |
| efried | # them ends up causing some really odd code formatting and forced | 13:33 |
| efried | # extra line breaks. Updating code to enforce these will be a hard sell. | 13:33 |
| *** markvoelker has joined #openstack-nova | 13:34 | |
| efried | If I may paraphrase: "Follow these rules unless it results in really odd code formatting or forced extra line breaks" | 13:34 |
| efried | ...which is of course difficult without OCD reviewers (or being OCD yourself) | 13:34 |
| efried | ...which is why the peps exist. | 13:34 |
| *** AlexeyAbashkin has quit IRC | 13:34 | |
| *** markvoelker_ has joined #openstack-nova | 13:36 | |
| *** AlexeyAbashkin has joined #openstack-nova | 13:37 | |
| *** belmoreira has quit IRC | 13:38 | |
| *** rodolof has quit IRC | 13:39 | |
| *** rodolof has joined #openstack-nova | 13:39 | |
| *** markvoelker has quit IRC | 13:39 | |
| *** esberglu has joined #openstack-nova | 13:39 | |
| *** idlemind has joined #openstack-nova | 13:40 | |
| efried | mikal: yt? | 13:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | 13:42 |
| mriedem | tblakes: if jgwentworth says she can't reproduce the problem on master then i guess it's not an issue, especially if we can't recreate with a test | 13:42 |
| *** dikonoo has quit IRC | 13:42 | |
| *** mvk has quit IRC | 13:42 | |
| *** sree has quit IRC | 13:42 | |
| *** dikonoo has joined #openstack-nova | 13:42 | |
| *** leakypipes has joined #openstack-nova | 13:42 | |
| *** sree has joined #openstack-nova | 13:43 | |
| *** leakypipes has quit IRC | 13:43 | |
| efried | mriedem: Quick re-approval for lyarwood: https://review.openstack.org/#/c/544238/ | 13:44 |
| tblakes | mriedem: Thanks! I'll abandon https://review.openstack.org/#/c/559169/ and recheck https://review.openstack.org/#/c/559158/. | 13:44 |
| *** dikonoor has joined #openstack-nova | 13:45 | |
| openstackgerrit | Raoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483 | 13:45 |
| *** jaypipes has joined #openstack-nova | 13:46 | |
| *** QianYu has joined #openstack-nova | 13:46 | |
| *** sree has quit IRC | 13:47 | |
| *** amodi has joined #openstack-nova | 13:49 | |
| *** dikonoo has quit IRC | 13:49 | |
| *** jchhatbar has joined #openstack-nova | 13:50 | |
| *** yikun has quit IRC | 13:50 | |
| *** QianYu has quit IRC | 13:50 | |
| *** yikun has joined #openstack-nova | 13:50 | |
| *** QianYu has joined #openstack-nova | 13:50 | |
| dansmith | mriedem: were you going to look at this? https://review.openstack.org/#/c/558059/ | 13:52 |
| *** burt has joined #openstack-nova | 13:52 | |
| *** janki has quit IRC | 13:52 | |
| *** r-daneel has joined #openstack-nova | 13:54 | |
| *** QianYu has quit IRC | 13:54 | |
| mriedem | dansmith: yes, i now have an excellent sized queue after starting about 20 minutes ago | 13:55 |
| edleafe | Scheduler subteam meeting in 4 minutes in #openstack-meeting-alt | 13:56 |
| *** awaugama has joined #openstack-nova | 13:57 | |
| dansmith | mriedem: you're welcome | 13:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix comments at the 'save' method of objects.Instance https://review.openstack.org/559743 | 14:00 |
| *** felipemonteiro has joined #openstack-nova | 14:00 | |
| jaypipes | 4/join #openstack-meeting-alt | 14:01 |
| jaypipes | ffs | 14:01 |
| *** tblakes has quit IRC | 14:02 | |
| *** liverpooler has quit IRC | 14:02 | |
| *** markvoelker_ has quit IRC | 14:03 | |
| *** liverpooler has joined #openstack-nova | 14:04 | |
| *** dikonoo has joined #openstack-nova | 14:04 | |
| *** bnemec has joined #openstack-nova | 14:05 | |
| *** Eran_Kuris has quit IRC | 14:06 | |
| *** dougshelley66 has joined #openstack-nova | 14:06 | |
| *** eharney has joined #openstack-nova | 14:08 | |
| *** dikonoor has quit IRC | 14:09 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:09 | |
| *** felipemonteiro has quit IRC | 14:12 | |
| mriedem | efried: lyarwood: +W | 14:13 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171 | 14:13 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 14:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | 14:14 |
| jaypipes | mriedem: ^ done. | 14:14 |
| *** mlavalle has joined #openstack-nova | 14:16 | |
| *** r-daneel_ has joined #openstack-nova | 14:16 | |
| *** dikonoor has joined #openstack-nova | 14:18 | |
| *** r-daneel has quit IRC | 14:18 | |
| *** r-daneel_ is now known as r-daneel | 14:18 | |
| *** dikonoor has quit IRC | 14:18 | |
| *** dikonoor has joined #openstack-nova | 14:19 | |
| *** dpawlik has quit IRC | 14:19 | |
| *** dikonoo has quit IRC | 14:19 | |
| *** krtaylor has quit IRC | 14:19 | |
| *** takashin_ has joined #openstack-nova | 14:20 | |
| *** rodolof has quit IRC | 14:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | 14:20 |
| *** artom has joined #openstack-nova | 14:20 | |
| mriedem | jaypipes: tweaked the alternative section, but +2 | 14:20 |
| mriedem | thanks | 14:20 |
| *** mvk has joined #openstack-nova | 14:21 | |
| *** rodolof has joined #openstack-nova | 14:21 | |
| *** jroll has quit IRC | 14:22 | |
| *** takashin has quit IRC | 14:22 | |
| *** jroll has joined #openstack-nova | 14:23 | |
| *** artom_ has joined #openstack-nova | 14:23 | |
| jaypipes | mriedem: thx | 14:23 |
| *** liverpooler has quit IRC | 14:24 | |
| *** liverpooler has joined #openstack-nova | 14:26 | |
| *** artom has quit IRC | 14:26 | |
| *** r-daneel has quit IRC | 14:27 | |
| *** armaan has quit IRC | 14:28 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid dumping stack on BuildAbortException https://review.openstack.org/559751 | 14:29 |
| dansmith | mriedem: ^ | 14:29 |
| *** gouthamr has joined #openstack-nova | 14:29 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 14:29 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 14:29 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 14:29 |
| *** belmoreira has joined #openstack-nova | 14:30 | |
| *** sar has quit IRC | 14:30 | |
| *** gouthamr has quit IRC | 14:31 | |
| kashyap | alex_xu: Hi, when you're around -- maybe you'd know the answer to my question on `enabled_pef_events`: | 14:32 |
| kashyap | alex_xu: As it stands, seems like Nova accepts far beyond three events (cmt, mbmt, mbml). Isn't it? | 14:32 |
| kashyap | alex_xu: Because the source for that config attributes shows it accepts a string list -- so all values that are supported by libvirt are accepted by Nova | 14:33 |
| *** kholkina has quit IRC | 14:33 | |
| kashyap | (At least that's what the doc says) | 14:33 |
| * kashyap looks at actual source to see what it supports | 14:33 | |
| *** _ix has joined #openstack-nova | 14:34 | |
| *** r-daneel has joined #openstack-nova | 14:35 | |
| kashyap | alex_xu: Disregard me, answered my question -- yes, it supports broader set of events besides those tree | 14:36 |
| kashyap | s/tree/three/ | 14:36 |
| mriedem | esberglu: why is https://review.openstack.org/#/c/554688/ in the runways etherpad? | 14:37 |
| mriedem | it's not tied to a blueprint, but is just powervm driver specific, | 14:37 |
| mriedem | if it's not a bp, please just include it in the powervm driver section of the other priority review etherpad https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | 14:38 |
| esberglu | mriedem: Will do | 14:38 |
| mriedem | thanks | 14:38 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 14:45 |
| mriedem | sahid: bauzas: this spec tracking is really odd https://review.openstack.org/#/c/511188/ - that's for rocky, for a blueprint which is closed | 14:46 |
| mriedem | why isn't there a "overhead-pin-set" spec for rocky? | 14:47 |
| bauzas | mriedem: shit, you're right | 14:48 |
| bauzas | mriedem: the URL is wrong | 14:48 |
| mriedem | and the name of the spec is wrong | 14:49 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 14:49 |
| bauzas | I haven't looked at the related BP, my bad | 14:49 |
| mriedem | sahid: can you fix that up please? | 14:49 |
| bauzas | I think sahid didn't changed the spec when we asked him to create that BP | 14:49 |
| mriedem | finucannot: you can remove the -2 on https://review.openstack.org/#/c/510897/ - the spec is approved | 14:50 |
| bauzas | mriedem: thanks for that btw. | 14:50 |
| bauzas | honestly, I should also look at the BP | 14:50 |
| *** dklyle has joined #openstack-nova | 14:51 | |
| *** sar has joined #openstack-nova | 14:51 | |
| *** dikonoor has quit IRC | 14:52 | |
| *** dikonoor has joined #openstack-nova | 14:53 | |
| *** AlexeyAbashkin has quit IRC | 14:54 | |
| *** namnh has joined #openstack-nova | 14:55 | |
| *** tbachman has quit IRC | 14:56 | |
| sahid | mriedem: at the beginning it was just an update of the already approved spec, that is why we did not have really noticed the issue | 14:58 |
| *** dougshel_ has joined #openstack-nova | 14:58 | |
| *** sapd has joined #openstack-nova | 14:59 | |
| bauzas | sahid: ping me when you're done with the new change and I'll +2 | 14:59 |
| *** takashin_ has left #openstack-nova | 14:59 | |
| bauzas | for renaming I mean | 14:59 |
| *** takashin has joined #openstack-nova | 14:59 | |
| sahid | yes i will | 14:59 |
| *** tetsuro has quit IRC | 15:00 | |
| *** dikonoo has joined #openstack-nova | 15:00 | |
| *** takashin has left #openstack-nova | 15:01 | |
| *** chyka has joined #openstack-nova | 15:01 | |
| *** dougshelley66 has quit IRC | 15:02 | |
| *** armaan has joined #openstack-nova | 15:03 | |
| *** dikonoor has quit IRC | 15:04 | |
| *** dikonoor has joined #openstack-nova | 15:04 | |
| *** dikonoo has quit IRC | 15:06 | |
| *** rodolof has quit IRC | 15:07 | |
| mriedem | dansmith: replied in https://review.openstack.org/#/c/558059/ | 15:11 |
| *** gouthamr has joined #openstack-nova | 15:13 | |
| *** Zames has joined #openstack-nova | 15:16 | |
| jaypipes | cdent: ok, everyone gone | 15:17 |
| cdent | roger | 15:17 |
| openstackgerrit | Merged openstack/nova master: Support extending attached ScaleIO volumes https://review.openstack.org/554679 | 15:18 |
| *** sree has joined #openstack-nova | 15:19 | |
| *** felipemonteiro_ has quit IRC | 15:19 | |
| *** xinliang has quit IRC | 15:19 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:19 | |
| mriedem | jaypipes: efried: -1 on tetsuro's spec https://review.openstack.org/#/c/559466/ - the bp link is wrong for one, but i'm also wondering if this is just to enable out of tree filters/weighters, or if he actually wants to add a vGPU weighter to nova | 15:20 |
| mriedem | i'd be supportive of that if so | 15:20 |
| mriedem | question inline about the slippery slope of including provider trees in the response also | 15:20 |
| mriedem | bauzas: you would probably be interested in that idea ^ | 15:21 |
| *** xinliang has joined #openstack-nova | 15:21 | |
| mriedem | jgwentworth: dansmith: i guess we were supposed to be actively brainstorming for the forum https://etherpad.openstack.org/p/YVR-nova-brainstorming | 15:24 |
| *** armaan_ has joined #openstack-nova | 15:25 | |
| *** armaan has quit IRC | 15:25 | |
| mriedem | efried: jaypipes: cdent: edleafe: i'm sure there are placement things that could be at the forum | 15:25 |
| mriedem | e.g. cinder talking about maybe leveraging it in their scheduler | 15:26 |
| *** slaweq has quit IRC | 15:26 | |
| cdent | mriedem: yes, it's on y list | 15:26 |
| * efried doesn't really know what the forum is. | 15:26 | |
| cdent | got a couple things, including the cinder thing | 15:26 |
| mriedem | efried: design sessions at the summit | 15:26 |
| *** slaweq has joined #openstack-nova | 15:26 | |
| bauzas | mriedem: ack, I'll look | 15:26 |
| bauzas | -ETOOMANYPLACEMENTSPECS | 15:27 |
| bauzas | should we stop feeding the placement mogwaï after midnight ? | 15:27 |
| *** tbachman has joined #openstack-nova | 15:28 | |
| *** chyka has quit IRC | 15:28 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971 | 15:28 |
| *** andreas_s has quit IRC | 15:28 | |
| efried | bauzas: It's water that makes 'em multiply. Feeding after midnight turns 'em evil. | 15:29 |
| edleafe | efried: ^^ addressed your concerns | 15:29 |
| *** andreas_s has joined #openstack-nova | 15:29 | |
| * efried clicks... | 15:29 | |
| *** Eran_Kuris has joined #openstack-nova | 15:30 | |
| bauzas | efried: ha, right. So, people, stop hydrating your specs | 15:30 |
| *** slaweq has quit IRC | 15:30 | |
| * efried <== '80s nerd | 15:31 | |
| jaypipes | mriedem: it's not to enable anything in particular. it's just to remove a restriction in the returned results of allocation candidates' provider_summaries section that wasn't necessary to restrict. | 15:31 |
| bauzas | and don't give'em a review after midnight or they'll turn into something bad | 15:31 |
| bauzas | efried: technically, growing mogwais is good | 15:31 |
| *** purplerbot has quit IRC | 15:31 | |
| bauzas | if you respect the 3 rules | 15:32 |
| *** purplerbot has joined #openstack-nova | 15:32 | |
| * bauzas was born on 1980 | 15:32 | |
| bauzas | jaypipes: what's up with the placement channel ? can I rejoin it ? | 15:33 |
| cdent | bauzas: yes, it's ready | 15:33 |
| * bauzas was kicked for the first time since he's on IRC | 15:33 | |
| bauzas | :'( | 15:33 |
| jaypipes | bauzas: I warned you to leave the channel :) | 15:34 |
| *** germs has joined #openstack-nova | 15:34 | |
| *** germs has quit IRC | 15:34 | |
| *** germs has joined #openstack-nova | 15:34 | |
| bauzas | jaypipes: well, you kick after the first warning, I hope your pugs behave correctly :p | 15:34 |
| *** germs has quit IRC | 15:35 | |
| *** germs has joined #openstack-nova | 15:36 | |
| *** germs has quit IRC | 15:36 | |
| *** germs has joined #openstack-nova | 15:36 | |
| *** links has quit IRC | 15:37 | |
| *** andreas_s has quit IRC | 15:38 | |
| *** andreas_s has joined #openstack-nova | 15:38 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Return all resources in provider_summaries spec https://review.openstack.org/559466 | 15:39 |
| efried | mriedem, jaypipes: I went ahead and made those edits ^ | 15:39 |
| efried | tetsuro ^ | 15:39 |
| *** dikonoo has joined #openstack-nova | 15:39 | |
| *** jpena is now known as jpena|brb | 15:41 | |
| bauzas | efried: see my comment on the spec | 15:42 |
| bauzas | efried: about interop | 15:42 |
| *** andreas_s has quit IRC | 15:43 | |
| bauzas | efried: if people wanna add some query related to inventories, they should add it to Placement, not by a filter | 15:43 |
| efried | bauzas: Responding. | 15:43 |
| bauzas | efried: because the Placement logic needs to be interoperable for the same query | 15:43 |
| *** dikonoor has quit IRC | 15:43 | |
| mriedem | i just don't want to spend time making this change if nothing is going to leverage it in-tree right now | 15:44 |
| *** gyee has joined #openstack-nova | 15:45 | |
| bauzas | if we accept to pass back the inventories, then you'll be sure that one day or later, people will just use placement for basic checks, and will do python filtering for their specific calls | 15:45 |
| mriedem | if out of tree filters/weighters want to get full provider tree and inventory information, they can query placement directly | 15:45 |
| bauzas | and then, we're done with claims | 15:45 |
| bauzas | what mriedem said | 15:45 |
| *** andreas_s has joined #openstack-nova | 15:48 | |
| jaypipes | what? | 15:48 |
| efried | jaypipes: Help me out here. What's the reason we want to include non-requested resources and other-RPs-in-same-tree in provider summaries? | 15:49 |
| *** namnh has quit IRC | 15:49 | |
| edleafe | filters/weighers? | 15:49 |
| jaypipes | efried: so that filters like the NUMATopologyFilter and ComputeCapabilitiesFilter can use the inventory usage and trait information. | 15:50 |
| mriedem | if you need to filter on a resource class, that should be part of the requested resource in the query which puts it in the response, right? | 15:50 |
| mriedem | this spec doesn't say anything about returning a full view of the resource provider traits either, only what was requested | 15:51 |
| mriedem | or do you already get the full set of traits back in provider summaries? | 15:51 |
| efried | mriedem: As I tried to explain, we have no syntax to talk about resource classes we're *not* requesting. | 15:51 |
| jaypipes | mriedem: not if you want to know that a sibling NUMA node is "more packed" than another. | 15:51 |
| efried | yeah, and that. | 15:51 |
| *** nicolasbock has left #openstack-nova | 15:52 | |
| mriedem | sure i get the weighing thing here | 15:52 |
| mriedem | i'm basically -1 until something in-tree is going to leverage this | 15:53 |
| mriedem | because provider 'summary' is not going to be a summary anymore, it's going to be a full blown view of the provider, it sounds like anyway | 15:53 |
| efried | mriedem: That's really what was intended from the start, I believe. It was an artifact of the impl that it wound up being a subset. | 15:53 |
| jaypipes | mriedem: we already return all the rp traits, not just the ones requested. https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L3426 | 15:54 |
| efried | mriedem: Surely you're not suggesting that "something in-tree is going to leverage this" is necessary in the Rocky timeframe? | 15:54 |
| mriedem | efried: why would that be shocking? | 15:54 |
| jaypipes | mriedem: summary only referred to the aggregation of usage counts. | 15:54 |
| efried | mriedem: Because especially with placement stuff, we've got a long history of implementing enablement before implementing the thing that exploits it. | 15:55 |
| mriedem | efried: if a thing were queued up to exploit this, then it's a different story | 15:55 |
| efried | mriedem: So you want a bp/spec for how NUMATopologyFilter is going to leverage this before you'll approve it? | 15:55 |
| *** sree has quit IRC | 15:56 | |
| mriedem | depending on what that thing is, we might want to instead of just *always* returning the full inventory including the tree, maybe it's a parameter on the API to return something in addition to what we get today, based on config in nova which is based on which filters/weighters you're enabling | 15:56 |
| efried | mriedem: Or is it enough to add more words to the use case paragraph? | 15:56 |
| *** ragiman has quit IRC | 15:56 | |
| *** ktibi has quit IRC | 15:56 | |
| *** gouthamr has quit IRC | 15:56 | |
| *** sree has joined #openstack-nova | 15:56 | |
| * efried notes this would be a great topic for the #openstack-placement channel | 15:56 | |
| mriedem | efried: i just think this is getting the cart before the hose | 15:56 |
| mriedem | *horse | 15:57 |
| mriedem | and not something we should be spending time on given all of the other stuff that is actually planned to be used in this release | 15:57 |
| *** mrjk has joined #openstack-nova | 15:57 | |
| jaypipes | mriedem: as I mentioned on the spec, I see this more of correcting an earlier mistake of not returning all resource class inventories/usage summaries in the provider_summaries section when we should have been doing that from the start. | 15:57 |
| *** yikun has quit IRC | 15:57 | |
| efried | ++ | 15:57 |
| *** yikun has joined #openstack-nova | 15:57 | |
| efried | Also, the code is already done | 15:58 |
| *** belmoreira has quit IRC | 15:58 | |
| mriedem | we never told anyone they should fully implement something before the bp is approved | 15:58 |
| mriedem | code being done doesn't mean anything to me | 15:58 |
| efried | from the perspective of spending time on it. | 15:58 |
| mriedem | volume multiattach was 'done' in havana | 15:58 |
| efried | Already has one core reviewer ready to +2, just holding up on spec approval. | 15:59 |
| mriedem | and there is absolutely no unnecessary performance penalty on scheduling by returning full provider trees and inventory for all providers in a given request, even though we have nothing lined up to leverage it? | 16:00 |
| mriedem | even if i get back 1000 of these things now? | 16:00 |
| *** sree has quit IRC | 16:01 | |
| efried | For the back-end retrieval, no. As far as wire traffic, in the common case we have today, there will be *almost* no difference in the payloads anyway. | 16:01 |
| efried | cfriesen_: You feel like writing something up about how NUMATopologyFilter will exploit provider_summary data? | 16:02 |
| *** ssurana has joined #openstack-nova | 16:03 | |
| *** dpawlik has joined #openstack-nova | 16:03 | |
| *** dpawlik has quit IRC | 16:04 | |
| *** Eran_Kuris has quit IRC | 16:04 | |
| *** dpawlik has joined #openstack-nova | 16:04 | |
| *** lpetrut has joined #openstack-nova | 16:05 | |
| edleafe | Can anyone with more sqla-fu explain why the migration [0] and the model here [1] are not in sync? | 16:06 |
| edleafe | [0] https://review.openstack.org/#/c/557958/4/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/059_add_consumer_generation.py | 16:06 |
| edleafe | [1] https://review.openstack.org/#/c/557958/4/nova/db/sqlalchemy/api_models.py | 16:06 |
| efried | jaypipes: ^ I couldn't tell at a glance either edleafe | 16:06 |
| *** andreas_s has quit IRC | 16:06 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 16:07 |
| *** ssurana has quit IRC | 16:07 | |
| *** andreas_s has joined #openstack-nova | 16:07 | |
| *** fragatina has joined #openstack-nova | 16:09 | |
| *** jchhatbar has quit IRC | 16:10 | |
| jaypipes | edleafe: maybe try removing all of the server_default stuff. | 16:11 |
| efried | esberglu: As takashin mentioned, ^ needs a reno | 16:11 |
| esberglu | efried: Yep, posted a comment saying the same | 16:11 |
| jaypipes | edleafe: perhaps it's a thing where the difference between sqlalchemy-migrate and sqlalchemy's models are weird. | 16:11 |
| efried | esberglu: Oh, see it now. | 16:11 |
| *** lpetrut has quit IRC | 16:11 | |
| esberglu | Didn't see it before | 16:11 |
| *** lpetrut has joined #openstack-nova | 16:12 | |
| *** artom_ is now known as artom | 16:12 | |
| *** dpawlik_ has joined #openstack-nova | 16:12 | |
| *** dpawlik has quit IRC | 16:12 | |
| *** dpawlik_ has quit IRC | 16:13 | |
| *** dpawlik has joined #openstack-nova | 16:13 | |
| *** Zames has quit IRC | 16:15 | |
| *** Zames_ has joined #openstack-nova | 16:15 | |
| *** zhaochao has quit IRC | 16:15 | |
| *** amodi has quit IRC | 16:16 | |
| *** madhaviy has joined #openstack-nova | 16:17 | |
| *** felipemonteiro_ has quit IRC | 16:17 | |
| *** dpawlik_ has joined #openstack-nova | 16:18 | |
| *** damien_r has quit IRC | 16:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 16:18 | |
| *** lucasagomes is now known as lucas-afk | 16:19 | |
| *** andreas_s has quit IRC | 16:20 | |
| *** lpetrut has quit IRC | 16:20 | |
| edleafe | jaypipes: I'll give it a try | 16:21 |
| *** dpawlik has quit IRC | 16:21 | |
| *** dpawlik has joined #openstack-nova | 16:22 | |
| *** dpawlik_ has quit IRC | 16:22 | |
| jaypipes | edleafe: step 2: yell at jaypipes about even mentioning server_default. ;) | 16:22 |
| *** jpena|brb is now known as jpena | 16:24 | |
| edleafe | jaypipes: only if the test passes now :) | 16:25 |
| jaypipes | hehe | 16:25 |
| *** andreas_s has joined #openstack-nova | 16:26 | |
| *** sambetts is now known as sambetts|afk | 16:26 | |
| *** dpawlik_ has joined #openstack-nova | 16:27 | |
| *** dpawlik_ has quit IRC | 16:27 | |
| edleafe | jaypipes: you're lucky. The test failed | 16:27 |
| jaypipes | hehe | 16:27 |
| *** dpawlik_ has joined #openstack-nova | 16:27 | |
| edleafe | jaypipes: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) Cannot add a NOT NULL column with default value NULL [SQL: u'\nALTER TABLE consumers ADD generation INTEGER NOT NULL'] (Background on this error at: http://sqlalche.me/e/e3q8) | 16:27 |
| *** dpawlik has quit IRC | 16:27 | |
| jaypipes | ahhh | 16:28 |
| *** germs has quit IRC | 16:28 | |
| *** germs has joined #openstack-nova | 16:28 | |
| *** germs has quit IRC | 16:28 | |
| *** germs has joined #openstack-nova | 16:28 | |
| *** germs has quit IRC | 16:28 | |
| *** germs has joined #openstack-nova | 16:28 | |
| *** germs has quit IRC | 16:28 | |
| *** germs has joined #openstack-nova | 16:28 | |
| jaypipes | edleafe: this is ringing a bell... I think dansmith ran into a similar issue in the past. | 16:29 |
| jaypipes | edleafe: I think it's a sqlite-ism | 16:30 |
| jaypipes | edleafe: one sec | 16:30 |
| dansmith | doesn't ring for me | 16:30 |
| cdent | mriedem: I added a couple of placement-related things to http://forumtopics.openstack.org/ | 16:30 |
| cdent | just sos you're aware | 16:30 |
| *** liverpooler has quit IRC | 16:31 | |
| *** germs has quit IRC | 16:31 | |
| jaypipes | edleafe: sqlite doesn't support full alter table. | 16:31 |
| jaypipes | edleafe: so you will need to do a funky script for sqlite :( | 16:31 |
| *** hongbin has joined #openstack-nova | 16:32 | |
| edleafe | orly? | 16:32 |
| jaypipes | edleafe: I can try to give it a shot if you'd like, but wouldn't be able to get to it until tomorrow likely | 16:32 |
| jaypipes | edleafe: yeah, lemme grab an example | 16:32 |
| edleafe | ok, let me do some googling | 16:32 |
| *** germs has joined #openstack-nova | 16:33 | |
| *** germs has quit IRC | 16:33 | |
| *** germs has joined #openstack-nova | 16:33 | |
| *** lpetrut has joined #openstack-nova | 16:33 | |
| edleafe | so it's not the server_default stuff; it's changing the nullable for the project_id and user_id fields that sqlite doesn't support | 16:35 |
| *** germs has quit IRC | 16:35 | |
| *** andreas_s has quit IRC | 16:35 | |
| *** yamamoto has joined #openstack-nova | 16:37 | |
| jaypipes | edleafe: no | 16:37 |
| *** yamamoto has quit IRC | 16:38 | |
| jaypipes | edleafe: it's the addition of the generation column to the consumers table as a NOT NULL field that fails. | 16:38 |
| jaypipes | edleafe: because that create_column() ends up being translated to an ALTER TABLE consumers ADD COLUMN generation NOT NULL | 16:38 |
| jaypipes | edleafe: and SQLite's ALTER TABLE ... ADD COLUMN doesn't support a DEFAULT clause :( | 16:39 |
| jaypipes | edleafe: so you need to do a CREATE TABLE consumers_new with the new schema, then do a SELECT into the new table, then do a DROP TABLE consumers; RENAME TABLE consumers_new TO consumers | 16:39 |
| jaypipes | edleafe: like I said, it's a pain in the ass. | 16:39 |
| jaypipes | edleafe: and I'm wondering if we need to do it for SQLite anyway since it's dev-only DB. | 16:40 |
| edleafe | from the sqlite docs: "Only the RENAME TABLE and ADD COLUMN variants of the ALTER TABLE command are supported. Other kinds of ALTER TABLE operations such as DROP COLUMN, ALTER COLUMN, ADD CONSTRAINT, and so forth are omitted." | 16:40 |
| *** andreas_s has joined #openstack-nova | 16:40 | |
| jaypipes | edleafe: yes, but the DEFAULT clause of ADD COLUMN isn't supported, IIRC | 16:40 |
| edleafe | jaypipes: sure, but neither would the ALTER COLUMN calls for those other two fields, right? | 16:41 |
| jaypipes | so you can't do: ALTER TABLE consumers ADD COLUMN generation INTEGER NOT NULL DEFAULT 0 | 16:41 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 16:41 |
| jaypipes | edleafe: yes, likely. it's probably that those errors haven't (yet) come up due to the failure of the consumers.generation thing first. | 16:41 |
| edleafe | jaypipes: ok, I'll give it a shot. It would be *so* much easier in SQL than sqla. | 16:42 |
| *** elmaciej has quit IRC | 16:42 | |
| edleafe | jaypipes: although I did lift the nullable change from nova/db/sqlalchemy/migrate_repo/versions/267_instance_uuid_non_nullable.py | 16:42 |
| jaypipes | edleafe: so you'll need to add a file in the migrate_repo called 059_add_consumer_generation.sql I believe. | 16:42 |
| edleafe | and that made it in | 16:43 |
| jaypipes | edleafe: and then guard the 059_add_consumer_generation.py file with the whole dialect != 'sqlite' thing | 16:43 |
| jaypipes | edleafe: alternately, you could just execute raw sql statements like is done here: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/044_placement_add_projects_users.py#L63-L77 | 16:44 |
| edleafe | jaypipes: so the .sql file will be executed automatically? Or do I call it from the .py? | 16:44 |
| jaypipes | edleafe: pretty sure it would get executed automatically, but lemme check | 16:45 |
| edleafe | ah, I like that better | 16:45 |
| *** udesale has quit IRC | 16:46 | |
| *** mikal has quit IRC | 16:46 | |
| *** mikal has joined #openstack-nova | 16:47 | |
| jaypipes | edleafe: so apparently ALTER TABLE ... ADD COLUMN in SQLite *does* support the DEFAULT clause. | 16:48 |
| jaypipes | edleafe: so I'm not sure why it's not being generated here. | 16:48 |
| *** tesseract has quit IRC | 16:48 | |
| *** armaan_ has quit IRC | 16:49 | |
| *** andreas_s has quit IRC | 16:49 | |
| *** armaan has joined #openstack-nova | 16:50 | |
| *** jgwentworth is now known as melwitt | 16:51 | |
| -openstackstatus- NOTICE: zuul was restarted to update to the latest code; please recheck any changes uploaded within the past 10 minutes | 16:52 | |
| *** sahid has quit IRC | 16:53 | |
| *** dpawlik_ has quit IRC | 16:53 | |
| *** krtaylor has joined #openstack-nova | 16:54 | |
| *** armaan has quit IRC | 16:54 | |
| *** andreas_s has joined #openstack-nova | 16:54 | |
| jaypipes | edleafe: ok, I'm a bit stumped... may need to reach out to zzzeek_ on this one. can you try setting default="0" instead of default=0 in both the migration and models? | 16:57 |
| jaypipes | edleafe: from the error message it kinda seems like the difference that oslo.db's test_models_in_sync thing is seeing has to do with '0' vs. a sqlalchemy.sql.elements.TextClause objectTextClause | 16:58 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 16:58 |
| *** derekh has quit IRC | 16:59 | |
| *** hemna_ has joined #openstack-nova | 17:02 | |
| dansmith | mriedem: I think we already have a place where we need placement configured for nova-api | 17:02 |
| dansmith | although I think we're not actually doing the thing that would require it | 17:02 |
| dansmith | which is local delete nuking allocations | 17:02 |
| *** ralonsoh has quit IRC | 17:02 | |
| *** AlexeyAbashkin has quit IRC | 17:02 | |
| *** mgoddard has quit IRC | 17:03 | |
| *** david-lyle has joined #openstack-nova | 17:04 | |
| edleafe | jaypipes: no dice on default="0" | 17:04 |
| edleafe | jaypipes: same error | 17:04 |
| jaypipes | :( | 17:05 |
| *** germs has joined #openstack-nova | 17:06 | |
| *** germs has quit IRC | 17:06 | |
| *** germs has joined #openstack-nova | 17:06 | |
| *** dklyle has quit IRC | 17:07 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:09 | |
| *** andreas_s has quit IRC | 17:09 | |
| *** germs has quit IRC | 17:09 | |
| *** germs has joined #openstack-nova | 17:10 | |
| *** germs has quit IRC | 17:10 | |
| *** germs has joined #openstack-nova | 17:10 | |
| *** suresh12 has joined #openstack-nova | 17:11 | |
| *** germs has quit IRC | 17:12 | |
| mriedem | dansmith: yeah that's a latent bug, which i've had sitting in my todo list, | 17:12 |
| mriedem | i'll tackle it at 3pm on friday :) | 17:12 |
| dansmith | that's fine, just don't expect me to be around for it :) | 17:12 |
| mriedem | you said you'd always be there for me | 17:13 |
| mriedem | avolkov: some easy changes to make in https://review.openstack.org/#/c/511183/ - just got feedback from dtroyer too | 17:14 |
| mriedem | although i know it's late in the day for you | 17:14 |
| *** yamamoto has joined #openstack-nova | 17:16 | |
| *** jpena is now known as jpena|away | 17:18 | |
| *** madhaviy has quit IRC | 17:18 | |
| *** ssurana has joined #openstack-nova | 17:19 | |
| *** gjayavelu has joined #openstack-nova | 17:19 | |
| mriedem | dansmith: when you get a sec, there is a mini debate in my patch to wait for vif plugged events before starting live migration that could use your input https://review.openstack.org/#/c/558001/ - some of it around whether or not we should even fail if we timeout, which thinking back on sahid's recent patch for linuxbridge, that doesn't fail on timout, it just logs a warning and continues | 17:23 |
| openstackgerrit | Merged openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | 17:23 |
| dansmith | mriedem: no, I made him fail if it times out | 17:23 |
| mriedem | yeah i see that now https://github.com/openstack/nova/blob/e2d5dc4e2c5f69fcbcb04c29b2ed469725122787/nova/virt/libvirt/driver.py#L7429 | 17:24 |
| mriedem | so it's totally unconditional based on the CONF.vif_plugging_is_fatal option | 17:24 |
| *** felipemonteiro has joined #openstack-nova | 17:24 | |
| dansmith | if we're expecting an event and don't get it, we should fail just about anything, IMHO, except if we're waiting during delete or something | 17:24 |
| mriedem | that was basically my reply in my patch | 17:25 |
| mriedem | if i set this, i expect an event | 17:25 |
| mriedem | fail if it doesn't happen | 17:25 |
| dansmith | totes | 17:25 |
| *** amodi has joined #openstack-nova | 17:25 | |
| *** gouthamr has joined #openstack-nova | 17:27 | |
| *** andreas_s has joined #openstack-nova | 17:28 | |
| *** sapd has quit IRC | 17:32 | |
| *** andreas_s has quit IRC | 17:32 | |
| *** r-daneel has quit IRC | 17:33 | |
| mriedem | dansmith: on https://review.openstack.org/#/c/558059/4/nova/compute/manager.py@368 did you want to update that and add yourself as co-author? | 17:33 |
| mriedem | otherwise the change lgtm | 17:33 |
| mriedem | ill leave it up to efried and jaypipes to love up on it otherwise | 17:33 |
| dansmith | mriedem: I don't care, but if you want blame-sharing I'll be glad to | 17:35 |
| *** gouthamr has quit IRC | 17:35 | |
| mriedem | updated that comment, event.key is probably ok | 17:35 |
| mriedem | so just drop the wip if you don't want co-blame | 17:36 |
| dansmith | done | 17:36 |
| *** mdnadeem has quit IRC | 17:38 | |
| *** tssurya has quit IRC | 17:39 | |
| efried | mriedem, dansmith: +2. Who's gonna be the second +2? | 17:41 |
| mriedem | i only mentioned two people to love up on it | 17:42 |
| *** felipemonteiro_ has joined #openstack-nova | 17:42 | |
| *** mgoddard has joined #openstack-nova | 17:42 | |
| *** READ10 has quit IRC | 17:43 | |
| *** mvk has quit IRC | 17:44 | |
| *** felipemonteiro has quit IRC | 17:46 | |
| *** yikun has quit IRC | 17:46 | |
| *** yikun has joined #openstack-nova | 17:46 | |
| zzzeek_ | jaypipes: server_default in SQLAlchemy for a DEFAULT clause | 17:50 |
| *** eharney has quit IRC | 17:50 | |
| *** yikun has quit IRC | 17:50 | |
| dansmith | ah, now that does sound familiar | 17:50 |
| *** yikun has joined #openstack-nova | 17:50 | |
| *** dklyle has joined #openstack-nova | 17:52 | |
| *** david-lyle has quit IRC | 17:53 | |
| *** fragatina has quit IRC | 17:53 | |
| *** eharney has joined #openstack-nova | 17:56 | |
| *** yamamoto has quit IRC | 17:57 | |
| *** liverpooler has joined #openstack-nova | 17:58 | |
| *** andreas_s has joined #openstack-nova | 18:00 | |
| *** AlexeyAbashkin has quit IRC | 18:01 | |
| *** amoralej is now known as amoralej|off | 18:03 | |
| *** sridharg has quit IRC | 18:07 | |
| edleafe | zzzeek_: Hey, can you take a look at a migration issue I'm having? | 18:09 |
| jaypipes | zzzeek_: we've tried adding and removing server_default with no luck... | 18:09 |
| edleafe | jaypipes: I tried the recreate, import, drop, rename dance, but it seems to have a problem with the autoincrement | 18:10 |
| mriedem | dansmith: just need a simple unit test add to https://review.openstack.org/#/c/539590/ and i'm +2 | 18:11 |
| mriedem | i know that's an older series | 18:11 |
| dansmith | oh yeah, forgot about that | 18:14 |
| *** andreas_s has quit IRC | 18:15 | |
| *** hanish_ has joined #openstack-nova | 18:15 | |
| hanish_ | hi all, i am trying to launch vm, but i am facing timed out error in nova conductor, can someone help me on thos | 18:16 |
| esberglu | mriedem: Should I put the new powervm conf group in the features category or upgrade category in the release note? | 18:20 |
| esberglu | All the other conf related stuff is in upgrade, but I haven't found any adding new group, just moving existing groups | 18:20 |
| esberglu | Feature seems more accurate to me | 18:20 |
| *** lpetrut has quit IRC | 18:22 | |
| *** Zames_ has quit IRC | 18:23 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | 18:24 |
| *** pchavva has quit IRC | 18:25 | |
| mriedem | esberglu: let me check to see what this is actually doing | 18:27 |
| *** jpena|away is now known as jpena|off | 18:27 | |
| *** READ10 has joined #openstack-nova | 18:27 | |
| esberglu | mriedem: Allows a user to specify how much of a physical proc to assign each vCPU | 18:28 |
| *** Zames has joined #openstack-nova | 18:28 | |
| *** slaweq has joined #openstack-nova | 18:28 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:28 | |
| *** mvk has joined #openstack-nova | 18:29 | |
| mriedem | yeah, don't worry, i've got the fine toothed comb out now | 18:29 |
| *** avolkov has quit IRC | 18:31 | |
| *** Zames has quit IRC | 18:33 | |
| openstackgerrit | Merged openstack/nova master: Avoid dumping stack on BuildAbortException https://review.openstack.org/559751 | 18:33 |
| mriedem | esberglu: comments inline | 18:34 |
| mriedem | esberglu: what's with the flavor extra spec mention? | 18:35 |
| mriedem | is that something yet to be added? | 18:35 |
| esberglu | mriedem: Added that flavor extra spec mention after comments from edmondsw | 18:40 |
| *** cdent has quit IRC | 18:40 | |
| edmondsw | what commit? | 18:40 |
| esberglu | edmondsw: https://review.openstack.org/#/c/554688/3/nova/conf/powervm.py@30 | 18:41 |
| *** tianhui_ has quit IRC | 18:41 | |
| *** tianhui has joined #openstack-nova | 18:41 | |
| mriedem | i'm ok with blaming things on edmondsw | 18:42 |
| edmondsw | works for me :) | 18:42 |
| edmondsw | yeah, we shouldn't mention that if it's only an OOT thing | 18:43 |
| mriedem | i don't even see it in the out of tree driver | 18:43 |
| edmondsw | I didn't realize that was only OOT | 18:43 |
| edmondsw | looking... | 18:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506 | 18:44 |
| mriedem | https://github.com/openstack/nova-powervm/search?utf8=%E2%9C%93&q=proc_unit_factor&type= | 18:44 |
| zzzeek_ | jaypipes edleafe I can look later, though Im not sure SQLite even supports ALTER TABLE for a server default if that's your target DB | 18:44 |
| mriedem | i found https://github.com/openstack/nova-powervm/commit/4bad1ec1654b757c70100fbcc6f51505719d79d9 - and this setting is in the pypowervm lib | 18:44 |
| *** mgoddard has quit IRC | 18:44 | |
| esberglu | proc_units_factor not proc_unit_factor | 18:45 |
| zzzeek_ | jaypipes edleafe oh but if this is nova / sqlalchemy-migrate then that's another wrinkle | 18:45 |
| edleafe | zzzeek_: it's in one of the functional tests | 18:46 |
| edmondsw | mriedem esberglu misnamed: https://github.com/openstack/nova-powervm/blob/1dc302b7198ad749dc14cc69cf8f2e45e929d132/nova_powervm/virt/powervm/vm.py#L248-L250 | 18:46 |
| zzzeek_ | edleafe: add me to the review and ill try to look later | 18:46 |
| edleafe | zzzeek_: k - thanks | 18:46 |
| mriedem | edmondsw: esberglu: ok, so... | 18:46 |
| mriedem | you're upstreaming a thing from the out of tree driver, | 18:47 |
| edmondsw | and those are in nova as well as nova-powervm | 18:47 |
| edmondsw | no | 18:47 |
| mriedem | for a flavor extra spec that's not part of the same series | 18:47 |
| edmondsw | is is already in nova | 18:47 |
| mriedem | ok powervm:proc_units is in nova yeah i see | 18:47 |
| *** dikonoo has quit IRC | 18:47 | |
| mriedem | ok can we unclusterfudge the commit message on this along with the config option help and such? | 18:47 |
| *** cdent has joined #openstack-nova | 18:47 | |
| edmondsw | https://github.com/openstack/nova/blob/master/nova/virt/powervm/vm.py#L379-L381 | 18:47 |
| edmondsw | yeah, we'll get the right extraspec(s) mentioned | 18:48 |
| edmondsw | good catch, tx | 18:48 |
| mriedem | the default matches what's in the out of tree driver, | 18:48 |
| mriedem | but not what you'd get today with the in-tree driver | 18:48 |
| mriedem | i don't know how you want to resolve that | 18:48 |
| mriedem | i'm inclined to not care about the out of tree default | 18:48 |
| edmondsw | mriedem that's part of the reason for this change | 18:48 |
| edmondsw | the default in the nova driver was not great... and we definitely want it to be consistent | 18:49 |
| edmondsw | it was always meant to be 0.1 by default | 18:49 |
| mriedem | why not change the default in the library? | 18:49 |
| edmondsw | mriedem because pypowervm is used by folks, whereas the powervm driver in nova isn't yet | 18:51 |
| mriedem | if folks are using the out of tree driver, they are getting the out of tree default config opt value, not what's in the library | 18:51 |
| mriedem | yeah? | 18:51 |
| mriedem | but lowly in-tree driver is | 18:52 |
| edmondsw | I mean folks are using pypowervm directly, not only via the oot driver | 18:52 |
| mriedem | folks == powervm? | 18:53 |
| mriedem | *powervc | 18:53 |
| edmondsw | not powervc... it uses nova-powervm | 18:53 |
| edmondsw | but others | 18:53 |
| mriedem | oVirt on Power | 18:53 |
| mriedem | got it :) | 18:53 |
| edmondsw | non-OpenStack folks | 18:53 |
| edmondsw | basically, this is a goof, we release changing the default in nova is lousy, but it was just the best solution in this case | 18:54 |
| edmondsw | s/release/realize/ | 18:54 |
| mriedem | ok, so you don't want to change the default in the library, i get it. then esberglu it's an upgrade release note, not feature | 18:54 |
| edmondsw | yep | 18:54 |
| *** dpawlik has joined #openstack-nova | 18:54 | |
| mriedem | well, it's honestly probably both | 18:55 |
| mriedem | both a new option (feature) and an upgrade since the default for that new option changes the default | 18:56 |
| mriedem | on an existing extra spec | 18:56 |
| mriedem | just do both in a single reno file | 18:56 |
| esberglu | mriedem: Sounds good | 18:56 |
| esberglu | edmondsw: tx for the help, I didn't have as much context, just wanted to fix CI :) | 18:56 |
| edmondsw | anytime :) | 18:58 |
| *** tssurya has joined #openstack-nova | 19:04 | |
| *** dpawlik has quit IRC | 19:05 | |
| *** AlexeyAbashkin has quit IRC | 19:09 | |
| *** hanish_ has quit IRC | 19:10 | |
| mriedem | huh, it probably surprises no one that when we shelve offload a server, we null out the host but not it's AZ value | 19:11 |
| mriedem | this is the time where cfriesen_ is supposed to ask if anyone uses shelve | 19:12 |
| *** suresh12 has quit IRC | 19:14 | |
| *** suresh12 has joined #openstack-nova | 19:14 | |
| mriedem | jmlowe_: hey i'm trying to recreate https://bugs.launchpad.net/nova/+bug/1759924/ on a single node devstack system | 19:16 |
| openstack | Launchpad bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem) | 19:16 |
| mriedem | jmlowe_: and things are find until i shelve, rename the az from az1 to az2, and then try to unshelve the instance | 19:16 |
| mriedem | it blows up because the AZ filter is looking for az1 which is now gone | 19:17 |
| jmlowe_ | yes | 19:17 |
| mriedem | oh in yours you unshelved to a different az/host | 19:17 |
| jmlowe_ | unshelve will put it anywhere if the original spec doesn't have an az | 19:17 |
| jmlowe_ | correct | 19:17 |
| mriedem | oh yeah, i created this instance with az1 specifically, so it's in the request spec, yeah i'll fix that and retry | 19:17 |
| *** yamamoto has joined #openstack-nova | 19:18 | |
| mriedem | this kind of seems like a bug of it's own, but not sure what we'd do about it | 19:18 |
| *** claudiub has quit IRC | 19:18 | |
| *** suresh12 has quit IRC | 19:19 | |
| mriedem | we'd have to update any shelved instances in an az if we rename that az | 19:19 |
| *** claudiub has joined #openstack-nova | 19:19 | |
| jmlowe_ | if nothing else, where ever an instance is unshelved it needs to update the device_owner because it is there and that is truth | 19:20 |
| mriedem | jmlowe_: yeah i'm trying to get to that part | 19:20 |
| mriedem | jmlowe_: while you've got az renames on the brain, maybe you'd like to reply to http://lists.openstack.org/pipermail/openstack-operators/2018-March/015029.html with your thoughts | 19:21 |
| jmlowe_ | oh, I effectively did that by putting all my computes into rackwise az | 19:22 |
| jmlowe_ | to get migration to work again I wound up editing the specs | 19:22 |
| mriedem | i bet updating json blobs in the db is super fun | 19:22 |
| *** READ10 has quit IRC | 19:22 | |
| mriedem | jmlowe_: ack confirmed http://paste.openstack.org/show/718769/ | 19:28 |
| *** yamamoto has quit IRC | 19:33 | |
| *** armaan has joined #openstack-nova | 19:34 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 19:36 |
| jmlowe_ | mriedem: it was all the fun you might imagine it to be and then some | 19:36 |
| jmlowe_ | if you could never change the az name because you could never change the spec then az's really become a nightmare for operators and should be avoided at all costs, probably not what people really want | 19:38 |
| *** mriedem has quit IRC | 19:41 | |
| *** mriedem has joined #openstack-nova | 19:45 | |
| *** cdent has quit IRC | 19:45 | |
| mriedem | jmlowe_: what if, for starters, as mentioned in that ML thread, we just didn't allow az renames while there were (alive) instances in those AZs? | 19:45 |
| mriedem | so operators can't shoot themselves in the foot that way? | 19:45 |
| *** yamahata has quit IRC | 19:47 | |
| *** Roamer` has quit IRC | 19:48 | |
| *** Roamer` has joined #openstack-nova | 19:48 | |
| jmlowe_ | Lets say you start with the default "nova", specs wind up with nova in it, how to you create any AZ if you didn't plan on it from the beginning? Do you have to get this right before any people start using your cloud and make sure your guesses never having run a cloud before were correct for all time? | 19:49 |
| mriedem | is nova put into the request spec? | 19:49 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L895 | 19:50 |
| mriedem | 'nova' shouldn't be in the request spec unless the user specifically requested --availability-zone nova | 19:50 |
| jmlowe_ | Maybe not anymore, but my "no free hosts" live migration problems were because nova az was in the specs | 19:51 |
| jmlowe_ | Fixes you didn't know you needed but always wanted | 19:51 |
| mriedem | hmm, i'm not saying users couldn't wedge themselves, | 19:51 |
| mriedem | the server create API does say to not specify 'nova' here https://developer.openstack.org/api-ref/compute/#id10 | 19:51 |
| jmlowe_ | I think I would make more mistakes with renames disallowed than I would with it allowed | 19:52 |
| mriedem | huh, this inconsistency in the CLI for non-admins isn't good either http://paste.openstack.org/show/718771/ | 19:53 |
| jmlowe_ | it's kind of bad data modeling to have it all based on name and not id | 19:53 |
| mriedem | jmlowe_: yeah that's jaypipes' point in the ML thread, | 19:53 |
| mriedem | but is also a bigger hairier change | 19:53 |
| jmlowe_ | I really don't have any answers over here, just the ability to create more problems for myself | 19:54 |
| mriedem | heh, fair enough | 19:54 |
| jmlowe_ | I'm looking at the possibility of going all in on host aggregates to keep certain customers on hardware they bought sometime later this summer | 19:55 |
| openstackgerrit | Merged openstack/nova master: Fix comments at the 'save' method of objects.Instance https://review.openstack.org/559743 | 19:56 |
| jmlowe_ | none of this is going to get easier for me | 19:56 |
| jmlowe_ | I've observed that cli behavior before | 19:57 |
| mriedem | https://bugs.launchpad.net/python-openstackclient/+bug/1762534 | 19:57 |
| openstack | Launchpad bug 1762534 in python-openstackclient "openstack availability zone list shows default 'nova' AZ to non-admin users" [Undecided,New] | 19:57 |
| mriedem | i'll have to dig into that later | 19:57 |
| *** pchavva has joined #openstack-nova | 20:02 | |
| *** yamamoto has joined #openstack-nova | 20:09 | |
| openstackgerrit | Merged openstack/nova master: Fix cancel_all_events event name parsing https://review.openstack.org/558059 | 20:09 |
| *** yamamoto has quit IRC | 20:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update port device_owner when unshelving https://review.openstack.org/559828 | 20:18 |
| mriedem | jmlowe_: ^ | 20:18 |
| *** yamamoto has joined #openstack-nova | 20:19 | |
| jmlowe_ | That looks pretty good | 20:20 |
| *** yamamoto has quit IRC | 20:22 | |
| *** suresh12 has joined #openstack-nova | 20:22 | |
| *** yikun has quit IRC | 20:24 | |
| *** yikun has joined #openstack-nova | 20:24 | |
| *** yikun has quit IRC | 20:25 | |
| *** yikun has joined #openstack-nova | 20:25 | |
| *** suresh12 has quit IRC | 20:26 | |
| *** esberglu has quit IRC | 20:27 | |
| *** esberglu has joined #openstack-nova | 20:28 | |
| mriedem | oh it doesn't fix the bug in the single node devstack case... | 20:29 |
| mriedem | because on shelve offload, we don't clear the port binding host id, so the conditional on unshelve isn't true | 20:29 |
| jmlowe_ | really? looks like it should work | 20:29 |
| mriedem | it would work in a >1 compute env :) | 20:29 |
| jmlowe_ | oh, that's what somebody was on about when I first reported it | 20:29 |
| jmlowe_ | clearing the port on shelve | 20:29 |
| mriedem | that was me :) | 20:29 |
| mriedem | and that's the todo i left in the code | 20:30 |
| jmlowe_ | how convenient | 20:30 |
| *** esberglu_ has joined #openstack-nova | 20:30 | |
| *** esbergl__ has joined #openstack-nova | 20:31 | |
| *** esbergl__ is now known as esberglu__ | 20:32 | |
| mriedem | i wanted to avoid fixing the shelve / clear case in the same patch since that gets slightly more complicated, and not really needed to fix this bug | 20:32 |
| mriedem | unless your production env is 1 compute host... | 20:32 |
| mriedem | maybe it's a mainframe | 20:33 |
| *** esberglu has quit IRC | 20:33 | |
| *** vladikr has quit IRC | 20:34 | |
| *** esberglu_ has quit IRC | 20:34 | |
| *** vladikr has joined #openstack-nova | 20:35 | |
| *** salv-orlando has quit IRC | 20:36 | |
| *** pcaruana has quit IRC | 20:36 | |
| *** salv-orlando has joined #openstack-nova | 20:36 | |
| *** esberglu__ is now known as esberglu | 20:37 | |
| *** yikun has quit IRC | 20:45 | |
| *** yikun has joined #openstack-nova | 20:46 | |
| *** vladikr has quit IRC | 20:47 | |
| *** vladikr has joined #openstack-nova | 20:47 | |
| *** fragatina has joined #openstack-nova | 20:47 | |
| *** fragatina has quit IRC | 20:48 | |
| *** fragatina has joined #openstack-nova | 20:49 | |
| *** pchavva has quit IRC | 20:52 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: mirror nova host aggregate members to placement https://review.openstack.org/553597 | 20:53 |
| *** yamamoto has joined #openstack-nova | 20:54 | |
| *** liverpooler has quit IRC | 20:55 | |
| *** yamamoto has quit IRC | 20:58 | |
| *** r-daneel has joined #openstack-nova | 21:00 | |
| *** slaweq has quit IRC | 21:01 | |
| *** slaweq has joined #openstack-nova | 21:02 | |
| *** harlowja has joined #openstack-nova | 21:03 | |
| *** yikun has quit IRC | 21:06 | |
| *** yikun has joined #openstack-nova | 21:06 | |
| *** slaweq has quit IRC | 21:06 | |
| *** tblakes has joined #openstack-nova | 21:10 | |
| *** awaugama has quit IRC | 21:11 | |
| *** eharney has quit IRC | 21:12 | |
| tblakes | dansmith: Could you please take a look at https://review.openstack.org/#/c/559158/ if you have a chance. It's gotten a +2 from Matt Riedemann but still needs to get a +1 on workflow. It's a cherry pick from master to stable/queens. | 21:12 |
| *** arvindn05 has quit IRC | 21:13 | |
| *** dpawlik has joined #openstack-nova | 21:14 | |
| *** r-daneel has quit IRC | 21:15 | |
| *** artom has quit IRC | 21:15 | |
| *** tssurya has quit IRC | 21:16 | |
| *** r-daneel has joined #openstack-nova | 21:16 | |
| *** dpawlik has quit IRC | 21:18 | |
| *** dougshel_ has quit IRC | 21:20 | |
| *** gouthamr has joined #openstack-nova | 21:20 | |
| *** edmondsw has quit IRC | 21:22 | |
| *** edmondsw has joined #openstack-nova | 21:24 | |
| *** edmondsw has quit IRC | 21:29 | |
| *** abalutoiu__ has quit IRC | 21:29 | |
| *** tblakes has quit IRC | 21:30 | |
| *** Guest64304 has quit IRC | 21:34 | |
| imacdonn | dansmith: if you have a moment, could you evaluate https://review.openstack.org/#/c/558089/ , please? | 21:51 |
| *** dougshelley66 has joined #openstack-nova | 21:57 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 22:00 |
| dansmith | imacdonn: mriedem: sorry, I just can't get on board with that | 22:04 |
| imacdonn | dansmith: OK.... do you have another idea ? | 22:04 |
| dansmith | imacdonn: I don't think it's something we need to do at all, TBH, but if we're going to, we should make it useful | 22:05 |
| imacdonn | efried: heads-up | 22:05 |
| dansmith | imacdonn: we're going to hork out the resource provider a couple seconds later, so do that early or something | 22:05 |
| dansmith | but really, | 22:05 |
| dansmith | we should be fine to just log the problem, explain the issue and whatever | 22:06 |
| imacdonn | dansmith: my original idea was to do away with the check completely ... but mriedem was concerned about the case where the scheduler doesn't require placement, but we want to force it anyway, for reporting purposes | 22:06 |
| dansmith | imacdonn: okay I'm not sure why the current config-based check doesn't support that scenario | 22:07 |
| imacdonn | dansmith: the issue is that the current check uses an option that's not required .. so it barfs on a perfectly valid config | 22:07 |
| imacdonn | dansmith: I suppose an alternative would be to check for auth_type instead of region_name | 22:08 |
| dansmith | imacdonn: ah, right, well, then no check at startup like I was saying I guess | 22:08 |
| imacdonn | dansmith: if auth_type is always going to be required ............. | 22:08 |
| dansmith | imacdonn: catch it when we go to fetch our RP record the first time, log the bejeezus out of it | 22:08 |
| efried | IMO it would be nice to fail early with a nice message rather than let it fail "naturally" somewhere down the line. | 22:09 |
| imacdonn | dansmith: I believe that there's a case where there would be no request for RP (depending on scheduler config) | 22:09 |
| efried | right, and in ^ that case, "down the line" could be way later. | 22:09 |
| dansmith | efried: we don't check all of config on startup, but also, isn't this a thing that could be fixed at runtime in the service catalog | 22:09 |
| dansmith | ? | 22:09 |
| dansmith | imacdonn: efried: no, the RP setup will happen just a few seconds after startup, when listing the nodes and running the resource tracker stuff | 22:10 |
| efried | For this code path, you have to fix it by editing conf. | 22:10 |
| efried | which I hear is going to be able to be picked up dynamically across the board soon anyway, so... | 22:11 |
| dansmith | efried: it already can be | 22:11 |
| dansmith | efried: if you mark these things as reloadable and they are, | 22:11 |
| dansmith | then done deal | 22:11 |
| efried | cool cool. | 22:11 |
| efried | dansmith: So you're advocating removing the check entirely and letting it fail organically down the line | 22:11 |
| dansmith | efried: if we can't do a legit check then yeah | 22:12 |
| efried | Just so you're aware, @safe_connect has the potential to make that somewhat... unclean. | 22:12 |
| efried | Wait, how is this check not legit? | 22:12 |
| dansmith | "why the fsck are my computes requesting /foo/?bogus" would be high on my list | 22:12 |
| dansmith | efried: I mean a legit check without spamming the logs in placement | 22:12 |
| dansmith | a legit config-only check | 22:12 |
| efried | one entry on startup is hardly spamming, but okay. auth_type it is, I guess. | 22:13 |
| dansmith | I just restarted 1000 computes | 22:13 |
| imacdonn | can we say (with reasonable confidence) that auth_type will always be a required option? TBH, I'm not sure why it doesn't default to 'password' | 22:13 |
| dansmith | that's a lot of spam | 22:13 |
| efried | This I cannot answer. | 22:14 |
| dansmith | if I didn't, and I'm auditing logs, I find some /?bogus queries to placement and wonder who the fsck is on my network | 22:14 |
| *** rcernin has joined #openstack-nova | 22:14 | |
| dansmith | and then realize it's ... mah compute nodes | 22:14 |
| dansmith | I don't want to be on that customer call | 22:14 |
| efried | imacdonn: In other places we go to load the auth from conf and error if it comes back None. | 22:15 |
| *** r-daneel has quit IRC | 22:15 | |
| dansmith | we call pre_start_hook before we even listen to RPC, and that calls update_available_resource, which will pull our RPs from placement | 22:15 |
| efried | Which in this case might look a little bit like publicizing (bits of) SchedulerReportClient._create_client. | 22:15 |
| *** r-daneel has joined #openstack-nova | 22:16 | |
| efried | Nope, forget that. | 22:17 |
| efried | So we could check for auth_type, and if not set, log a helpful warning, but not raise, and then let the failure happen organically down the line. | 22:18 |
| *** mlavalle has quit IRC | 22:18 | |
| efried | that's future-proof in the case where auth_type becomes not required. | 22:18 |
| dansmith | so, we'd get the first failure before we even listen to RPC, run our first periodic, etc | 22:18 |
| imacdonn | dansmith: so are you still advocating just removing the check entirely? I'd be cool with that, but mriedem may not be | 22:24 |
| dansmith | imacdonn: if we can't do the check reliably based just what is in config, then yeah I think we should remove it | 22:25 |
| dansmith | imacdonn: I also think that we're doing legit talking to placement so early in service startup, that we could mangle up some of that code to make it fail really hard if you really wanted to | 22:25 |
| dansmith | but I also think that heavy logging of what we found when we reliably found it is completely legit | 22:26 |
| imacdonn | dansmith: I guess my perception is that we want to fail hard, not just log something and continue anyway ..... perhaps because people only check logs if something is obviously not working (e.g. nova-compute service not coming up) | 22:27 |
| dansmith | imacdonn: if compute can't report to placement, then things won't work | 22:27 |
| *** esberglu has quit IRC | 22:27 | |
| dansmith | imacdonn: we do a similar thing because we're dependent on conductor.. we check at startup and log in a loop that we can't do anything | 22:28 |
| *** esberglu has joined #openstack-nova | 22:28 | |
| imacdonn | dansmith: I've been led to believe that there's a scheduler config where it would work OK for the most part, but not report into placement | 22:28 |
| dansmith | we have to do that late because we need RPC to be up before we can reliably know if conductor is up, just like this situation | 22:28 |
| dansmith | imacdonn: if you're using cachingscheduler then you can avoid hitting placement in the scheduler | 22:28 |
| dansmith | imacdonn: and you could argue that computes being misconfigured for placement would be "okay" in that situation | 22:28 |
| dansmith | imacdonn: however, going forward, we *have* to migrate those people to having data in placement so we can get rid of that situation | 22:29 |
| imacdonn | dansmith: right, I believe that that's the case that mriedem was concerned about | 22:29 |
| *** esberglu_ has joined #openstack-nova | 22:29 | |
| dansmith | so that's a reason to hard fail, but again, if we can't reliably detect that except at runtime, then..we don't have much choice | 22:29 |
| dansmith | imacdonn: what about this.. make the compute service self-disable if we fail to update our RPs in placement? | 22:30 |
| imacdonn | I guess we can use auth_type ... It just feels a bit like making the same mistake a second time | 22:30 |
| dansmith | we do that now for transient issues we find out about late, like libvirt stopping | 22:30 |
| dansmith | we self-disable so that no new builds will come to us, | 22:30 |
| dansmith | which is a big fat "I need help" to the operator | 22:30 |
| imacdonn | interesting | 22:30 |
| dansmith | and there's a reason field | 22:30 |
| dansmith | self.disable(reason="you dun fscked up") | 22:30 |
| imacdonn | heh | 22:31 |
| imacdonn | I think I like that idea better | 22:31 |
| *** r-daneel has quit IRC | 22:32 | |
| dansmith | we also self-disable if too many builds fail for unknown reasons | 22:32 |
| *** r-daneel has joined #openstack-nova | 22:32 | |
| imacdonn | unit-testing for that could be "fun" ... | 22:32 |
| dansmith | nah, 's easy | 22:32 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1701-L1709 | 22:32 |
| *** esberglu has quit IRC | 22:33 | |
| dansmith | imacdonn: https://review.openstack.org/#/c/463597/ | 22:34 |
| *** esberglu_ has quit IRC | 22:34 | |
| dansmith | lots of test examples in there | 22:34 |
| mriedem | just rely on auth_type https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1761487 | 22:34 |
| mriedem | we are doing that for neutron and cinder too | 22:34 |
| dansmith | if that's legit, then sure | 22:34 |
| *** felipemonteiro_ has quit IRC | 22:36 | |
| mriedem | let me also state, for the record, that i don't care too much about this and said so awhile back http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-03-30.log.html#t2018-03-30T21:39:06 | 22:36 |
| mriedem | i definitely didn't think about the compute restart storm | 22:37 |
| * dansmith -> & | 22:38 | |
| mriedem | and now i must attend to 1st grade homework | 22:38 |
| *** mriedem is now known as mriedem_afk | 22:38 | |
| imacdonn | efried: any objection to using auth_type ? | 22:38 |
| efried | imacdonn: No. If they ever make that non-optional, I suspect many unintended side effects will result. | 22:39 |
| efried | s/non-// | 22:39 |
| imacdonn | yeah, and it seems like it'd probably become non-optional for neutron at the same time | 22:39 |
| efried | Oh, it would be a ksa thing, so it would become optional for the world | 22:41 |
| imacdonn | right, that's what I meant | 22:41 |
| imacdonn | so if we do the same for placement as we do for neutron, such a change would break both at the same type | 22:42 |
| efried | more or less. more or less. | 22:43 |
| *** gouthamr has quit IRC | 22:43 | |
| *** gouthamr has joined #openstack-nova | 22:44 | |
| *** sdague has quit IRC | 22:45 | |
| *** hongbin has quit IRC | 22:45 | |
| imacdonn | OK, I'll work on a new PS with that | 22:45 |
| imacdonn | dansmith: thanks for the review | 22:46 |
| *** dave-mcc_ has quit IRC | 22:49 | |
| *** esberglu has joined #openstack-nova | 22:50 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 23:00 |
| *** yamahata has joined #openstack-nova | 23:01 | |
| *** slaweq has joined #openstack-nova | 23:02 | |
| *** _ix has quit IRC | 23:03 | |
| openstackgerrit | Merged openstack/nova stable/queens: Add __repr__ for NovaException https://review.openstack.org/559158 | 23:04 |
| *** patriciadomin has quit IRC | 23:04 | |
| *** ssurana has quit IRC | 23:04 | |
| *** patriciadomin has joined #openstack-nova | 23:05 | |
| *** r-daneel has quit IRC | 23:07 | |
| *** slaweq has quit IRC | 23:07 | |
| *** jaypipes has quit IRC | 23:08 | |
| *** lbragstad has quit IRC | 23:17 | |
| *** yamamoto has joined #openstack-nova | 23:22 | |
| *** gouthamr has quit IRC | 23:23 | |
| *** yamamoto has quit IRC | 23:26 | |
| *** yikun has quit IRC | 23:29 | |
| *** yikun has joined #openstack-nova | 23:29 | |
| *** lbragstad has joined #openstack-nova | 23:36 | |
| *** sapcc-bot has quit IRC | 23:39 | |
| *** sapcc-bot has joined #openstack-nova | 23:39 | |
| *** lbragstad has quit IRC | 23:47 | |
| *** mdurrant has quit IRC | 23:52 | |
| *** takashin has joined #openstack-nova | 23:52 | |
| *** yamamoto has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!