Monday, 2018-04-02

*** EmilienM_ has joined #openstack-nova00:04
*** odyssey4me has quit IRC00:11
*** odyssey4me has joined #openstack-nova00:11
*** markvoelker has joined #openstack-nova00:24
*** hongbin has joined #openstack-nova00:24
*** edmondsw has joined #openstack-nova00:25
*** edmondsw has quit IRC00:29
*** yingjun has joined #openstack-nova00:30
*** itlinux has quit IRC00:32
*** fragatina has joined #openstack-nova00:34
*** takashin has joined #openstack-nova00:34
openstackgerritTetsuro Nakamura proposed openstack/nova master: [placement] Add test for provider summaries  https://review.openstack.org/55804400:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add unrequested resources to provider_summaries  https://review.openstack.org/55804500:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960100:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates  https://review.openstack.org/53343700:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return anchor providers in a_r and p_s  https://review.openstack.org/55801400:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix nits in return-anchor-providers series  https://review.openstack.org/55813300:40
*** markvoelker has quit IRC00:42
*** markvoelker has joined #openstack-nova00:42
openstackgerritTetsuro Nakamura proposed openstack/nova master: Complement tests in allocation candidates  https://review.openstack.org/55813500:43
*** tetsuro has joined #openstack-nova00:43
*** EmilienM_ is now known as EmilienM00:48
*** EmilienM has joined #openstack-nova00:48
tetsurogood morning!00:50
*** hoangcx has joined #openstack-nova00:55
fried_bunnytetsuro: Hi there.01:06
fried_bunnyI won't get a chance to look at the series again until my morning (~12h from now).01:06
fried_bunnyAny major disruptions I should know about?01:07
fried_bunnyOh, I see, you did the microversion paperwork, cool.  I'll look in the morning.  TTFN!01:09
*** phuongnh has joined #openstack-nova01:12
*** fragatina has quit IRC01:17
*** tiendc has joined #openstack-nova01:17
*** yangyapeng has joined #openstack-nova01:21
*** zhaochao has joined #openstack-nova01:23
*** salv-orl_ has joined #openstack-nova01:24
*** salv-orlando has quit IRC01:26
*** itlinux has joined #openstack-nova01:31
*** namnh has joined #openstack-nova01:37
*** Tom-Tom has joined #openstack-nova01:40
*** david-lyle has quit IRC01:40
*** dklyle has joined #openstack-nova01:40
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations`  https://review.openstack.org/52171701:43
*** itlinux has quit IRC01:44
*** germs has quit IRC01:47
openstackgerritZhenyu Zheng proposed openstack/nova master: [WIP] Send out notification when instance metadata updated  https://review.openstack.org/55814001:52
*** yamahata has joined #openstack-nova02:02
*** dklyle has quit IRC02:05
*** david-lyle has joined #openstack-nova02:05
*** tuanla____ has joined #openstack-nova02:08
*** edmondsw has joined #openstack-nova02:13
*** edmondsw has quit IRC02:17
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] api-ref: Fix parameters  https://review.openstack.org/55814202:19
*** Dinesh_Bhor has joined #openstack-nova02:21
*** janki has joined #openstack-nova02:29
*** psachin` has joined #openstack-nova02:33
*** gcb has joined #openstack-nova02:40
*** andreas_s has joined #openstack-nova02:42
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations`  https://review.openstack.org/52171702:42
*** vladikr has quit IRC02:45
*** vladikr has joined #openstack-nova02:45
tetsuro@fired_bunny: Oh, I realized your message just now. Thanks in advance! I’m going to look into your patch on the top of the branch after lunch. Anyway, Good night!02:47
*** andreas_s has quit IRC02:47
*** janki has quit IRC02:57
*** Jeffrey4l_ has joined #openstack-nova02:59
*** Jeffrey4l_ has quit IRC03:22
*** l4yerffej_ has joined #openstack-nova03:22
*** janki has joined #openstack-nova03:22
*** janki has quit IRC03:23
*** l4yerffej_ has quit IRC03:23
*** janki has joined #openstack-nova03:23
*** l4yerffej has joined #openstack-nova03:23
*** yamamoto has joined #openstack-nova03:26
*** itlinux has joined #openstack-nova03:32
*** Tom-Tom has quit IRC03:41
*** andreas_s has joined #openstack-nova03:41
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415403:47
*** andreas_s has quit IRC03:47
*** germs has joined #openstack-nova03:47
*** germs has quit IRC03:47
*** germs has joined #openstack-nova03:47
*** Zames has joined #openstack-nova03:49
*** hongbin has quit IRC03:49
*** ratailor has joined #openstack-nova03:49
*** ratailor has quit IRC03:50
*** Zames has quit IRC03:51
*** germs has quit IRC03:53
*** Tom-Tom has joined #openstack-nova03:58
*** Tom-Tom has quit IRC04:02
*** abhishekk has joined #openstack-nova04:03
*** yingjun has quit IRC04:10
*** sree has joined #openstack-nova04:26
*** psachin` has quit IRC04:27
*** psachin has joined #openstack-nova04:28
*** sree has quit IRC04:29
*** sree has joined #openstack-nova04:29
*** yingjun has joined #openstack-nova04:32
*** yingjun has quit IRC04:35
*** Kumar has joined #openstack-nova04:41
*** Sukhdev has joined #openstack-nova04:43
*** links has joined #openstack-nova04:46
*** jchhatbar has joined #openstack-nova04:51
*** jchhatbar has quit IRC04:51
*** jchhatbar has joined #openstack-nova04:52
*** janki has quit IRC04:54
*** Dinesh_Bhor has quit IRC04:59
*** Dinesh_Bhor has joined #openstack-nova05:01
*** abhishekk_ has joined #openstack-nova05:03
*** links has quit IRC05:04
*** abhishekk has quit IRC05:04
*** links has joined #openstack-nova05:05
*** abhishekk_ has quit IRC05:08
*** abhishekk_ has joined #openstack-nova05:09
*** ratailor has joined #openstack-nova05:10
*** Sukhdev has quit IRC05:13
*** eandersson has quit IRC05:16
*** eandersson has joined #openstack-nova05:17
*** yangyapeng has quit IRC05:23
*** moshele has joined #openstack-nova05:25
*** moshele has quit IRC05:27
*** Tom-Tom has joined #openstack-nova05:35
*** trinaths has joined #openstack-nova05:40
*** jchhatbar has quit IRC05:43
*** jchhatbar has joined #openstack-nova05:43
openstackgerritMaciej Kucia proposed openstack/nova-specs master: Fix Non-unique network names in Servers IPs API response  https://review.openstack.org/55812505:47
*** germs has joined #openstack-nova05:49
*** germs has quit IRC05:49
*** germs has joined #openstack-nova05:49
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture  https://review.openstack.org/55816005:50
*** germs has quit IRC05:53
*** lpetrut has joined #openstack-nova06:09
*** kholkina has joined #openstack-nova06:09
openstackgerritNguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo  https://review.openstack.org/55180206:15
*** yamamoto_ has joined #openstack-nova06:18
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment  https://review.openstack.org/48945106:18
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415406:20
*** yamamoto has quit IRC06:21
*** takashin has quit IRC06:21
*** Qian has joined #openstack-nova06:27
*** yuqian has joined #openstack-nova06:28
*** yamamoto has joined #openstack-nova06:29
*** Qian has quit IRC06:29
*** yamamoto_ has quit IRC06:32
*** Kumar has quit IRC06:33
*** Kumar has joined #openstack-nova06:34
yuqian#openstack-ceilometer06:35
*** moshele has joined #openstack-nova06:42
*** armaan has joined #openstack-nova06:44
*** ratailor has quit IRC06:49
*** ratailor_ has joined #openstack-nova06:49
*** ratailor has joined #openstack-nova06:55
*** ratailor_ has quit IRC06:56
*** ratailor has quit IRC07:00
*** andreas_s has joined #openstack-nova07:01
*** imacdonn has quit IRC07:04
*** imacdonn has joined #openstack-nova07:04
*** ratailor has joined #openstack-nova07:05
*** andreas_s has quit IRC07:05
*** alexchadin has joined #openstack-nova07:07
*** udesale has joined #openstack-nova07:08
*** tesseract has joined #openstack-nova07:12
*** jchhatba_ has joined #openstack-nova07:12
*** ratailor_ has joined #openstack-nova07:13
*** ccamacho has joined #openstack-nova07:14
*** jchhatba_ has quit IRC07:15
*** jchhatbar has quit IRC07:15
*** ratailor has quit IRC07:15
*** jchhatba_ has joined #openstack-nova07:15
*** takashin has joined #openstack-nova07:16
*** jchhatba_ has quit IRC07:17
*** phuongnh has quit IRC07:18
*** tuanla____ has quit IRC07:18
*** phuongnh has joined #openstack-nova07:19
*** tuanla____ has joined #openstack-nova07:19
*** annp has joined #openstack-nova07:19
openstackgerritChen Hanxiao proposed openstack/nova master: libvirt: guest: introduce blockStats instead of domain.blockStats  https://review.openstack.org/52683307:19
*** sridharg has joined #openstack-nova07:23
*** xinliang_ has joined #openstack-nova07:27
*** yuqian has quit IRC07:29
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in tests/unit/test_utils.py  https://review.openstack.org/55788307:29
*** itlinux has quit IRC07:30
*** Kumar has quit IRC07:30
*** QianYu has joined #openstack-nova07:31
*** mdnadeem has joined #openstack-nova07:37
*** amoralej|off is now known as amoralej07:40
*** andreas_s has joined #openstack-nova07:41
*** ragiman has joined #openstack-nova07:44
*** andreas_s has quit IRC07:46
*** andreas_s has joined #openstack-nova07:48
*** xinliang_ has quit IRC07:49
*** xinliang_ has joined #openstack-nova07:49
*** AlexeyAbashkin has joined #openstack-nova07:50
*** xinliang_ has quit IRC07:51
*** andreas_s has quit IRC07:53
*** xinliang has joined #openstack-nova07:54
*** xinliang has quit IRC07:54
*** xinliang has joined #openstack-nova07:54
*** Dinesh_Bhor has quit IRC07:55
*** Dinesh__Bhor has joined #openstack-nova07:55
*** armaan has quit IRC07:59
openstackgerritKashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein"  https://review.openstack.org/55817107:59
*** zhurong has joined #openstack-nova08:02
*** gcb has quit IRC08:03
*** armaan has joined #openstack-nova08:15
*** gcb has joined #openstack-nova08:17
*** alexchadin has quit IRC08:22
*** alexchadin has joined #openstack-nova08:25
*** mdnadeem has quit IRC08:27
*** mdnadeem has joined #openstack-nova08:27
*** moshele has quit IRC08:28
*** dineshbhor__ has joined #openstack-nova08:34
*** Dinesh__Bhor has quit IRC08:36
*** andreas_s has joined #openstack-nova08:36
openstackgerritNaichuan Sun proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree  https://review.openstack.org/53382108:38
openstackgerritNaichuan Sun proposed openstack/nova master: Use update_provider_tree from resource tracker  https://review.openstack.org/52024608:38
openstackgerritNaichuan Sun proposed openstack/nova master: Fix nits in update_provider_tree series  https://review.openstack.org/53126008:38
openstackgerritNaichuan Sun proposed openstack/nova master: Make generation optional in ProviderTree  https://review.openstack.org/53932408:38
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create  https://review.openstack.org/52031308:38
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations`  https://review.openstack.org/52171708:38
openstackgerritNaichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create  https://review.openstack.org/52104108:38
*** andreas_s has quit IRC08:42
*** yamamoto has quit IRC08:51
*** dineshbhor__ has quit IRC08:54
*** yamamoto has joined #openstack-nova09:00
*** Kumar has joined #openstack-nova09:01
*** ratailor_ has quit IRC09:01
*** ratailor_ has joined #openstack-nova09:02
*** zhurong has quit IRC09:02
*** ratailor_ has quit IRC09:06
*** ratailor_ has joined #openstack-nova09:06
*** ratailor_ has quit IRC09:13
*** ratailor_ has joined #openstack-nova09:13
*** ratailor_ has quit IRC09:14
*** ratailor_ has joined #openstack-nova09:15
*** sdague has joined #openstack-nova09:26
*** mdnadeem has quit IRC09:32
*** sree_ has joined #openstack-nova09:35
*** sree_ is now known as Guest7359109:35
*** ratailor_ has quit IRC09:35
*** alexchadin has quit IRC09:36
*** sree has quit IRC09:37
*** alexchadin has joined #openstack-nova09:38
*** armaan has quit IRC09:40
*** armaan has joined #openstack-nova09:40
*** Tom-Tom has quit IRC09:41
*** Guest73591 has quit IRC09:41
*** Zames_ has joined #openstack-nova09:41
*** Tom-Tom has joined #openstack-nova09:41
*** andreas_s has joined #openstack-nova09:44
*** sree has joined #openstack-nova09:44
*** Tom-Tom_ has joined #openstack-nova09:44
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix a missing white space in exception message  https://review.openstack.org/55818309:46
*** Tom-Tom has quit IRC09:46
*** Tom-Tom_ has quit IRC09:48
*** andreas_s has quit IRC09:48
*** sree has quit IRC09:48
*** alexchadin has quit IRC09:51
*** Zames_ has quit IRC09:52
*** Zames_ has joined #openstack-nova09:53
*** Zames_ has quit IRC09:53
*** ccamacho1 has joined #openstack-nova09:55
*** tiendc has quit IRC09:55
*** ccamacho has quit IRC09:55
*** Zames_ has joined #openstack-nova09:55
*** Zames_ has quit IRC09:55
*** Zames_ has joined #openstack-nova09:55
*** armaan has quit IRC09:56
*** armaan has joined #openstack-nova09:56
*** trinaths has quit IRC09:57
*** ccamacho1 has quit IRC09:57
*** ratailor has joined #openstack-nova09:58
*** ccamacho has joined #openstack-nova09:58
*** takashin has left #openstack-nova10:00
*** Zames_ has quit IRC10:08
*** phuongnh has quit IRC10:11
*** ejat has quit IRC10:11
*** armaan has quit IRC10:15
*** armaan has joined #openstack-nova10:16
*** ejat has joined #openstack-nova10:17
*** ejat has quit IRC10:17
*** ejat has joined #openstack-nova10:17
*** Kumar has quit IRC10:28
*** sar has joined #openstack-nova10:31
*** nicolasbock has joined #openstack-nova10:32
openstackgerritWonil Choi proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled  https://review.openstack.org/47664210:35
*** ratailor_ has joined #openstack-nova10:35
*** ratailor has quit IRC10:37
*** namnh has quit IRC10:39
*** abhishekk_ has quit IRC10:40
*** andreas_s has joined #openstack-nova10:41
*** QianYu has quit IRC10:42
*** AlexeyAbashkin has quit IRC10:43
*** andreas_s has quit IRC10:46
*** sapd__ has quit IRC10:51
*** damien_r has joined #openstack-nova10:54
*** ratailor__ has joined #openstack-nova11:03
*** alexchadin has joined #openstack-nova11:04
*** ratailor_ has quit IRC11:04
*** links has quit IRC11:04
*** damien_r has quit IRC11:05
*** links has joined #openstack-nova11:05
*** ratailor_ has joined #openstack-nova11:06
*** ratailor__ has quit IRC11:08
*** trinaths has joined #openstack-nova11:10
*** ccamacho1 has joined #openstack-nova11:18
*** zhurong has joined #openstack-nova11:19
*** ccamacho has quit IRC11:20
*** ccamacho has joined #openstack-nova11:26
*** jmlowe_ has quit IRC11:28
*** tetsuro has left #openstack-nova11:31
*** AlexeyAbashkin has joined #openstack-nova11:31
*** mdnadeem has joined #openstack-nova11:45
*** evrardjp_ has joined #openstack-nova11:45
*** yingjun has joined #openstack-nova11:59
*** jaypipes has joined #openstack-nova12:01
*** tuanla____ has quit IRC12:02
*** ccamacho has quit IRC12:02
*** lbragstad has joined #openstack-nova12:03
*** oanson has quit IRC12:04
jaypipesmorning supernovas12:04
*** udesale has quit IRC12:04
*** udesale has joined #openstack-nova12:05
*** weshay_mod is now known as weshay12:12
*** odyssey4me has quit IRC12:17
*** odyssey4me has joined #openstack-nova12:17
*** ejat has quit IRC12:19
*** ejat has joined #openstack-nova12:19
*** ejat has quit IRC12:19
*** ejat has joined #openstack-nova12:19
*** alexchadin has quit IRC12:20
*** Eran_Kuris has quit IRC12:21
*** lyan has joined #openstack-nova12:22
*** lyan is now known as Guest5535912:22
*** udesale has quit IRC12:23
*** udesale has joined #openstack-nova12:23
*** liverpooler has joined #openstack-nova12:23
*** ccamacho has joined #openstack-nova12:24
*** liverpooler has quit IRC12:28
*** amoralej is now known as amoralej|lunch12:29
*** liverpooler has joined #openstack-nova12:30
*** sapcc-bot has quit IRC12:30
*** sapcc-bot has joined #openstack-nova12:30
*** zhurong has quit IRC12:34
*** sapcc-bot has quit IRC12:35
*** sapcc-bot has joined #openstack-nova12:36
*** Eran_Kuris has joined #openstack-nova12:37
*** sapcc-bot has quit IRC12:38
*** sapcc-bot4 has joined #openstack-nova12:38
*** sapcc-bot has joined #openstack-nova12:39
*** sapcc-bot4 has quit IRC12:40
*** sapcc-bot has quit IRC12:42
*** sapcc-bot has joined #openstack-nova12:42
*** edmondsw has joined #openstack-nova12:43
*** trinaths has quit IRC12:43
*** gouthamr has joined #openstack-nova12:47
*** eharney has joined #openstack-nova12:55
*** READ10 has joined #openstack-nova12:57
*** david-lyle has quit IRC12:58
*** david-lyle has joined #openstack-nova12:59
Spaz-HomeMorning folks13:03
*** david-lyle has quit IRC13:09
* fried_bunny waves a bit late13:10
*** tbachman has quit IRC13:10
*** sree has joined #openstack-nova13:12
*** eharney has quit IRC13:17
*** sree has quit IRC13:17
*** jroll has quit IRC13:19
*** jroll has joined #openstack-nova13:20
*** ratailor_ has quit IRC13:21
*** sree has joined #openstack-nova13:21
*** evrardjp_ has quit IRC13:22
*** evrardjp_ has joined #openstack-nova13:24
*** eharney has joined #openstack-nova13:31
*** Eran_Kuris has quit IRC13:32
*** felipemonteiro__ has joined #openstack-nova13:32
Spaz-HomeWhew nerve wracking day13:35
*** udesale has quit IRC13:35
*** udesale has joined #openstack-nova13:35
*** awaugama has joined #openstack-nova13:36
*** tbachman has joined #openstack-nova13:37
*** yamamoto has quit IRC13:37
*** yamamoto has joined #openstack-nova13:37
*** _pewp_ has quit IRC13:39
*** felipemonteiro_ has joined #openstack-nova13:39
*** burt has joined #openstack-nova13:40
*** tbachman has quit IRC13:41
*** tbachman has joined #openstack-nova13:42
*** felipemonteiro__ has quit IRC13:42
*** oanson has joined #openstack-nova13:45
*** sree has quit IRC13:46
*** amoralej|lunch is now known as amoralej13:47
*** sree has joined #openstack-nova13:48
*** links has quit IRC13:48
*** esberglu has joined #openstack-nova13:52
*** evrardjp has quit IRC13:52
*** yangyapeng has joined #openstack-nova13:52
*** gouthamr has quit IRC13:53
*** gouthamr has joined #openstack-nova13:54
*** psachin has quit IRC13:55
edleafeScheduler subteam meeting in 5 minutes in #openstack-meeting-alt13:55
*** takashin has joined #openstack-nova13:56
*** yangyapeng has quit IRC13:56
*** sree has quit IRC13:58
*** Tom-Tom has joined #openstack-nova13:58
*** gouthamr has quit IRC14:00
*** gouthamr has joined #openstack-nova14:00
*** sree has joined #openstack-nova14:01
*** sree has quit IRC14:01
*** Tom-Tom has quit IRC14:02
*** sree has joined #openstack-nova14:03
*** amodi has joined #openstack-nova14:04
*** hongbin has joined #openstack-nova14:04
*** lpetrut has quit IRC14:05
*** sree has quit IRC14:08
*** gouthamr has quit IRC14:09
*** gouthamr has joined #openstack-nova14:09
*** _ix has joined #openstack-nova14:11
*** sree has joined #openstack-nova14:12
*** gouthamr has quit IRC14:14
*** kholkina has quit IRC14:14
*** gouthamr has joined #openstack-nova14:18
*** sree has quit IRC14:19
*** gouthamr has quit IRC14:19
TahvokHey guys! I've changes a flavor to more cpus, which resulted many of instances to have not available flavor. I've changed back the cpu to what it was on the flavor, and now I want to attach back the flavor to the instances.14:20
TahvokIs there way to just re-attache the flavor to the instances, without actually doing a full resize?14:20
*** gouthamr has joined #openstack-nova14:21
*** mlavalle has joined #openstack-nova14:23
*** yingjun has quit IRC14:25
*** evrardjp_ is now known as evrardjp14:29
*** yangyapeng has joined #openstack-nova14:29
*** tbachman has quit IRC14:29
*** tbachman has joined #openstack-nova14:33
*** gouthamr has quit IRC14:34
*** gouthamr has joined #openstack-nova14:35
*** avolkov has joined #openstack-nova14:38
bhagyashrismelwitt: Hi, Could you please review https://review.openstack.org/#/c/511825/ ? addressed review comments thank you :)14:39
*** david-lyle has joined #openstack-nova14:40
*** namnh has joined #openstack-nova14:41
*** tesseract has quit IRC14:42
*** tbachman has quit IRC14:42
*** tesseract-RH has joined #openstack-nova14:42
*** pooja_jadhav has joined #openstack-nova14:43
*** david-lyle is now known as dklyle14:44
bhagyashrisjaypipes: Hi, As per our dicussion on friday i have followed the steps and test it but still it's taking the compute node DISK_GB inventory  and not shared RP disk_gb inventory to boot the instance14:45
jaypipesbhagyashris: so your compute node is not reporting any DISK_GB inventory?14:47
bhagyashrisjaypipes: yesh i have removed the DISK_GB inventory for CN RP14:48
bhagyashrisyeah*14:48
*** tbachman has joined #openstack-nova14:48
jaypipesbhagyashris: if that is the case, an instance cannot possibly be consuming inventory of DISK_GB against the compute node...14:49
bhagyashrisjaypipes: and one more point that I have observed is after booting the instance I show the DISK_GB inventory record for CN RP14:49
*** takashin has quit IRC14:50
jaypipesbhagyashris: so the compute node resource tracker must be automatically re-adding the DISK_GB inventory to the compute node provider...14:51
jaypipeshmmm14:51
bhagyashrisjaypipes: yeah so it seems like patch: https://review.openstack.org/#/c/533396/8 is not reporting issue14:51
*** Sukhdev_ has joined #openstack-nova14:53
jaypipesbhagyashris: ok, thanks for that. looks like we are going to need some method of indicating to a compute node not to automatically inventory local disk space14:55
jaypipesfried_bunny: ^^14:55
fried_bunnynoted14:55
* jaypipes once again points to his provider-config-file proposal...14:55
jaypipesbut first... I must eat something.14:55
*** spotz_ has joined #openstack-nova14:55
jaypipesbhagyashris: I'll have a think on this today.14:55
fried_bunnyGuess we'll have to figure out where that inventory is coming from.  bhagyashris Which driver?  libvirt?14:56
bhagyashrisfried_bunny: yes14:56
fried_bunnybhagyashris: code level?14:57
bhagyashrisi am using libvirt driver14:57
*** lpetrut has joined #openstack-nova14:57
bhagyashrisyes14:57
fried_bunnyWhat level of code?  Queens release?  Master?14:58
bhagyashrisfried_bunny: on current master14:58
fried_bunnyjaypipes, bhagyashris: It should be noted that we don't officially support shared providers yet.  So I'm not sure how broken this really is.14:59
bhagyashris fried_bunny: commit: 02e357e7c2d2ccbab0a1f6b5a807d11f1ef72d4614:59
*** spotz_ is now known as spotz14:59
*** Zames has joined #openstack-nova14:59
fried_bunnyThe DISK_GB inventory that's showing up in your CN RP - is it the inventory you expected from your sharing RP, or is it actually the system's local disk?15:00
bhagyashrisfried_bunny: not getting clearly you mean to say the shared RP is not supported on current master?15:00
fried_bunnyThat's correct.15:00
fried_bunnyWe were just talking about this in the sched meeting.15:01
*** gjayavelu has joined #openstack-nova15:01
fried_bunnyWe could "fix" this "problem", but it's part of a larger thing that we've been carrying from release to release for quite a while.15:01
*** takashin has joined #openstack-nova15:02
fried_bunnyjaypipes will have to answer whether there's some aspect of this that counts as a regression.15:02
fried_bunnyotherwise... I suspect we may have to wait to fix this properly.15:02
*** Zames has quit IRC15:02
bhagyashrisfried_bunny: currently in inventory table the CN RP and shared RP DISK_GB value as same but what i expect is when i boot instance at that time it should take DISK_GB from shared Rp and VPCU and MEMoR_MB from CN RP15:04
fried_bunnybhagyashris: What I'm trying to find out is whether we're reporting the inventory from the sharing provider as if it was local; or if we're reporting the local inventory itself and ignoring the shared.  Can you perhaps resize one of those disks so that we can tell which is happening?15:05
*** takashin has left #openstack-nova15:07
edleafeugh, yeah I see 'em15:10
edleafefried_bunny: ^^15:10
bhagyashrisfried_bunny: it still taking the CN RP inventory and ignores the shareed RP inventory15:11
*** jdillaman has joined #openstack-nova15:11
fried_bunnybhagyashris: Okay.  Like I said, unless we can declare this to be a regression, it's probably not going to be something we "fix" right now.  Let's ask jaypipes when he gets back from breakfast.15:17
bhagyashrisfried_bunny: ok thank you for your inputs as i am working on IST time zone so it's almost EOD so i will discuss tomorrow :)15:18
*** itlinux has joined #openstack-nova15:19
fried_bunnybhagyashris: Roger that.  I'll try to follow up with jaypipes and one or the other of us will let you know tomorrow (either in IRC or we'll send an email)15:20
*** _pewp_ has joined #openstack-nova15:21
*** gouthamr has quit IRC15:23
*** gouthamr has joined #openstack-nova15:27
*** armaan has quit IRC15:28
*** armaan has joined #openstack-nova15:29
*** tblakes has joined #openstack-nova15:32
*** tbachman has quit IRC15:32
*** ircuser-1 has quit IRC15:34
openstackgerritEric Fried proposed openstack/nova master: Test case: traits don't sync if first access fails  https://review.openstack.org/55806615:39
openstackgerritEric Fried proposed openstack/nova master: Don't declare traits synced if they ain't  https://review.openstack.org/55806815:39
*** Tom-Tom has joined #openstack-nova15:40
*** ragiman has quit IRC15:42
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize  https://review.openstack.org/55358315:46
*** hemna_ has joined #openstack-nova15:47
*** burt has quit IRC15:47
*** armaan has quit IRC15:47
fried_bunnyjaypipes, edleafe: https://review.openstack.org/#/c/558068/1/nova/api/openstack/placement/objects/resource_provider.py@14215:48
*** gouthamr has quit IRC15:48
* fried_bunny needs db help ^15:48
*** gouthamr has joined #openstack-nova15:49
*** tblakes has quit IRC15:50
*** felipemonteiro_ has quit IRC15:50
*** ccamacho has quit IRC15:50
edleafefried_bunny: in the middle of my own rabbit hole :) Will look soon15:54
fried_bunnyoy vay15:54
jaypipeszzzeek: hey, what is the magic incantation to allow an enginefacade-managed session to start and close its own transaction?15:55
*** felipemonteiro has joined #openstack-nova15:55
zzzeekjaypipes: do you mean, you want to explicitly do that part yourself?15:55
zzzeekjaypipes: the enginefacade ohhh15:55
jaypipeszzzeek: allowing the transaction to be committed and exceptions raised in "outer" enginefacade sessions won't roll the inner one back15:55
zzzeekjaypipes: you mean indepdendent of the rest15:55
jaypipesya15:55
zzzeekjaypipes: yeah writer.independent15:56
*** Tom-Tom_ has joined #openstack-nova15:56
jaypipesoh crap, why can't I ever remember it. thanks zzzeek :)15:56
zzzeekjaypipes: that means whole new DB connection for that block15:56
fried_bunnyjaypipes: Okay, so I decorate _trait_sync with that, and we're good?15:56
*** patriciadomin has quit IRC15:56
zzzeekjaypipes fried_bunny well use .independent sparingly if it's in a tight loop you are putting a lot more load on things15:57
jaypipesfried_bunny: yes.15:57
*** felipemonteiro_ has joined #openstack-nova15:57
fried_bunnyzzzeek: Cool man, it should only get run once, ever.15:57
zzzeekthen again before enginefacade *all* of nova was like that :)15:57
zzzeekfried_bunny: then you're golden15:57
fried_bunnyzzzeek, jaypipes: works.  Thanks!15:57
*** yangyapeng has quit IRC15:58
jaypipesnp (all hail zzzeek)15:58
zzzeekjaypipes: so true! :)15:58
*** patriciadomin has joined #openstack-nova15:58
*** Tom-Tom has quit IRC15:58
*** felipemonteiro has quit IRC16:01
openstackgerritEric Fried proposed openstack/nova master: Use an independent transaction for _trait_sync  https://review.openstack.org/55806816:02
fried_bunnyjaypipes, zzzeek: ^16:02
fried_bunnyThanks for the help.16:02
*** fragatina has joined #openstack-nova16:03
*** armaan has joined #openstack-nova16:06
*** gouthamr has quit IRC16:07
*** fragatina has quit IRC16:08
*** lpetrut has quit IRC16:08
*** fragatina has joined #openstack-nova16:09
*** gouthamr has joined #openstack-nova16:09
*** gjayavelu has quit IRC16:14
*** Sukhdev has joined #openstack-nova16:23
*** felipemonteiro_ has quit IRC16:29
*** felipemonteiro__ has joined #openstack-nova16:29
*** esberglu has quit IRC16:31
*** esberglu has joined #openstack-nova16:31
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver  https://review.openstack.org/52609416:32
*** gouthamr has quit IRC16:33
*** yamamoto has quit IRC16:33
*** armaan has quit IRC16:35
*** AlexeyAbashkin has quit IRC16:37
*** yamamoto has joined #openstack-nova16:42
*** eharney has quit IRC16:43
*** zhaochao has quit IRC16:44
edleafeIs there some reason you can't add columns to two different tables in a single migration? IOW, do they have to be done separately?16:47
edleafeoh, nvm - stupid typo16:49
*** itlinux has quit IRC16:49
*** udesale has quit IRC16:50
*** david-lyle has joined #openstack-nova16:51
*** dklyle has quit IRC16:51
*** tbachman has joined #openstack-nova16:52
*** eharney has joined #openstack-nova16:56
*** itlinux has joined #openstack-nova16:57
*** yamamoto has quit IRC16:59
*** Tom-Tom_ has quit IRC17:05
*** Tom-Tom has joined #openstack-nova17:06
*** david-lyle has quit IRC17:06
*** david-lyle has joined #openstack-nova17:06
*** david-lyle has quit IRC17:07
*** david-lyle has joined #openstack-nova17:07
*** mdnadeem has quit IRC17:08
*** Tom-Tom has quit IRC17:10
*** namnh has quit IRC17:12
*** david-lyle has quit IRC17:13
*** moshele has joined #openstack-nova17:17
*** david-lyle has joined #openstack-nova17:18
*** burt has joined #openstack-nova17:18
*** felipemonteiro_ has joined #openstack-nova17:18
*** lpetrut has joined #openstack-nova17:19
*** liverpooler has quit IRC17:20
*** liverpooler has joined #openstack-nova17:20
*** felipemonteiro__ has quit IRC17:22
*** itlinux has quit IRC17:23
*** david-lyle has quit IRC17:23
*** itlinux has joined #openstack-nova17:24
*** lpetrut has quit IRC17:26
*** lpetrut has joined #openstack-nova17:26
*** moshele has quit IRC17:29
*** gjayavelu has joined #openstack-nova17:38
*** liuzz has quit IRC17:39
*** liuzz has joined #openstack-nova17:40
*** felipemonteiro_ has quit IRC17:41
*** felipemonteiro_ has joined #openstack-nova17:41
*** Sukhdev has quit IRC17:46
*** lpetrut has quit IRC17:52
openstackgerritVladyslav Drok proposed openstack/nova master: Ignore some updates from virt driver  https://review.openstack.org/52300617:53
*** lpetrut has joined #openstack-nova17:54
*** eharney has quit IRC17:55
openstackgerritEd Leafe proposed openstack/nova master: Add columns for generation to consumers and allocations  https://review.openstack.org/55795818:00
openstackgerritEd Leafe proposed openstack/nova master: Add handlers for consumer_generation  https://review.openstack.org/55795918:00
*** yamamoto has joined #openstack-nova18:00
*** amodi has quit IRC18:01
*** jackie-truong has joined #openstack-nova18:04
*** yamamoto has quit IRC18:06
*** _ix has quit IRC18:07
openstackgerritDan Smith proposed openstack/nova master: Fix cancel_all_events event name parsing  https://review.openstack.org/55805918:08
*** eharney has joined #openstack-nova18:10
*** hemna_ has quit IRC18:11
*** arvindn05 has quit IRC18:14
*** armaan has joined #openstack-nova18:18
*** arvindn05 has joined #openstack-nova18:24
*** sree has joined #openstack-nova18:26
*** armaan has quit IRC18:27
*** armaan has joined #openstack-nova18:28
*** sree has quit IRC18:30
*** yamamoto has joined #openstack-nova18:37
jaypipesoh so quiet today...18:39
openstackgerritEric Berglund proposed openstack/nova master: Move pypowervm requirement to 1.1.12  https://review.openstack.org/55825418:39
edleafea lotta people are eating their easter candy methinks18:40
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver  https://review.openstack.org/52609418:41
*** Swami has joined #openstack-nova18:42
*** idlemind has quit IRC18:42
*** yamamoto has quit IRC18:45
*** idlemind has joined #openstack-nova18:45
arvindn05spring break week as well in the US i think18:48
fried_bunnyfor some, possibly.  Ours was a couple weeks ago.18:48
*** AlexeyAbashkin has joined #openstack-nova18:49
arvindn05ahh...atleast in the west coast CA area it might be this week then...lots of folks are out on vac18:50
*** AlexeyAbashkin has quit IRC18:53
*** idlemind has quit IRC18:54
*** idlemind has joined #openstack-nova18:55
*** avolkov has quit IRC18:58
*** sridharg has quit IRC18:58
openstackgerritEd Leafe proposed openstack/nova master: Add columns for generation to consumers and allocations  https://review.openstack.org/55795818:59
openstackgerritEd Leafe proposed openstack/nova master: Add handlers for consumer_generation  https://review.openstack.org/55795918:59
fried_bunnyjaypipes: did you catch up on the shared provider stuff we were discussing with bhagyashris?19:01
*** tesseract-RH has quit IRC19:01
*** amoralej is now known as amoralej|off19:02
fried_bunnyjaypipes: I wanted to get a sense for whether that constitutes a regression we need to fix, or whether it figures into the whole "we don't support shared yet" picture.19:02
*** AlexeyAbashkin has joined #openstack-nova19:04
*** amodi has joined #openstack-nova19:09
*** AlexeyAbashkin has quit IRC19:09
*** namnh has joined #openstack-nova19:13
*** READ10 has quit IRC19:14
*** david-lyle has joined #openstack-nova19:14
*** david-lyle is now known as dklyle19:16
*** namnh has quit IRC19:17
*** _ix has joined #openstack-nova19:19
openstackgerritVladyslav Drok proposed openstack/nova master: Ignore some updates from virt driver  https://review.openstack.org/52300619:24
*** eharney_ has joined #openstack-nova19:26
*** eharney has quit IRC19:26
*** eharney_ is now known as eharney19:26
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot  https://review.openstack.org/54302319:32
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905319:32
openstackgerritJay Pipes proposed openstack/nova master: Get rid of 406 paths in report client  https://review.openstack.org/55663319:35
jaypipesfried_bunny: was a simple rebase ^19:35
*** andreas_s has joined #openstack-nova19:35
fried_bunnyjaypipes: Roger.  Why was it needed?19:36
fried_bunnybecause I forgot to do it after editing the previous in gerrit?19:36
jaypipesfried_bunny: the previous version was based on an old patch.19:36
jaypipesfried_bunny: yep19:36
fried_bunnyight19:36
*** vladikr has quit IRC19:38
*** vladikr has joined #openstack-nova19:38
*** harlowja has joined #openstack-nova19:38
*** gouthamr has joined #openstack-nova19:42
*** andreas_s has quit IRC19:42
*** armaan has quit IRC19:43
*** sdeath has joined #openstack-nova19:43
*** armaan has joined #openstack-nova19:43
*** sdeath has quit IRC19:43
*** yamamoto has joined #openstack-nova19:45
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905319:45
*** HW-Peter has joined #openstack-nova19:46
*** HW-Peter has quit IRC19:46
*** HW-Peter has joined #openstack-nova19:47
fried_bunnyedleafe: jaypipes: How does a consumer get created?  Implicitly when you create allocations for it?19:48
jaypipesfried_bunny: yes19:49
fried_bunnyThen what do you send down as your generation value the first time you create such an allocation?  I guess None has to be legal at that point.19:49
jaypipesfried_bunny: yeah19:49
fried_bunnyedleafe: ^ how is this handled?19:50
fried_bunnyUnder the new microversion, None has to be special19:50
*** yamamoto has quit IRC19:51
*** lpetrut has quit IRC19:51
fried_bunnyspecial-cased to mean "Fail 409 if the consumer exists"19:51
* fried_bunny looks at spec...19:51
jaypipesfried_bunny: the previous behaviour is essentially an implicit consumer_generation of None.19:52
fried_bunnyjaypipes: Not the same thing at all, though.19:52
jaypipesfried_bunny: how so?19:52
fried_bunnyWith the new code in place, you can still use the old microversion, which is consumer_generation of None, and it'll increment the existing generation, whatever it happens to be.19:53
fried_bunnyIf you use the *new* microversion and send None, we can't do that.19:53
*** armaan has quit IRC19:54
jaypipesfried_bunny: why would you send the new microversion and send None, though?>19:54
*** armaan has joined #openstack-nova19:54
edleafefried_bunny: that's how it's supposed to work19:55
fried_bunnyjaypipes: Because you *have* to do that when the consumer doesn't exist yet.19:55
fried_bunnyCause we had the discussion about opacity - made sure *that* was in the spec.  So you can't send 0.  But if you do a GET, you'll get 404 cause the consumer doesn't exist yet.19:56
fried_bunnyso you don't have an existing generation to populate your payload with.19:56
*** armaan has quit IRC19:56
edleafefried_bunny: you will have gotten the generation from GETting existing allocations19:56
*** armaan_ has joined #openstack-nova19:56
openstackgerritDan Smith proposed openstack/nova master: Fix cancel_all_events event name parsing  https://review.openstack.org/55805919:56
edleafeif there is no consumer, you would get None19:56
fried_bunnyedleafe: Not when there ain't none yet.19:56
fried_bunnyyou would get 40419:56
fried_bunnynot so?19:56
jaypipesfried_bunny: but the only reason to have this consumer generation at all was for the PUT /allocations/{consumer_uuid} when you wanted to modify an existing allocation.19:56
edleafeyou would get an empty list19:56
fried_bunnyjaypipes: But how do you know whether you're modifying an existing or creating a new?19:57
jaypipesfried_bunny: when you're trying to modify an existing allocation, it's a totally different call point than when you're creating a new allocation for a new instance.19:57
jaypipesfried_bunny: the scheduler always does claim_resources() which is new consumer (new instance). the conductor will be the only thing modifying existing allocations.19:58
fried_bunnyjaypipes: Maybe for Nova it is.19:58
edleafeeither way, you're calling set_allocations, no?19:58
fried_bunny^19:58
jaypipesedleafe: claim_resources() vs. some new modify_allocations() call.19:58
jaypipesthe only reason we need consumer generation is when we're modifying existing allocations.19:59
jaypipesthere's no need for it anywhere else.19:59
fried_bunnyFrom an API perspective, though, you're calling PUT /allocations/{c}19:59
*** dtruong has quit IRC19:59
fried_bunny(or POST, same-same)19:59
edleafeok, I think I see the case fried_bunny is talking about19:59
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot  https://review.openstack.org/54302319:59
fried_bunnyedleafe: confirmed you get 200 empty list when calling on a consumer that doesn't exist.20:00
jaypipesfried_bunny: then have claim_resources() use microversion 2.11 and have modify_allocations() use microversion 2.42 (or whatever microversion this new change gets)20:00
edleafeit would happen if you created an instance, and then somehow un-allocated all its resources, and then re-allocated them.20:00
edleafeI don't think that's possible20:00
fried_bunnyor a race where two agents attempt to create the first alloc for a consumer ID.20:01
fried_bunnySure, we can say it'll never happen in nova (maybe).20:01
edleafefried_bunny: yeah, and the second will fail that race20:01
edleafeas designed20:01
fried_bunnyBut from a pure API perspective, the point of this exercise is to protect against clients racing to PUT /allocations/{c} - whether it's the first or not.20:01
fried_bunnyedleafe: That's what I'm saying.  If the consumer doesn't exist yet, we *must* have a special case for consumer_generation=None which fails 409 if the consumer exists at all.20:02
fried_bunnyWe *can't* have it just increment the generation in that case.  Or the *first* guy will lose the race, and not know why.20:02
edleafefried_bunny: let's walk through the race20:02
fried_bunnyAnd, this is a weird behavior, so it needs the shite documented out of it.20:02
fried_bunnyokay.20:02
fried_bunnyme or you?20:03
edleafeboth agents get the current state for the allocations, which is empty20:03
edleafeme20:03
edleafeBoth try to PUT their allocations with con_gen=None20:03
edleafeOne succeeds, and the generation is then set at 020:03
edleafeThe second fails with a 409 response.20:03
edleafeThe second then refreshes its view, and gets allocations this time, with con_gen=020:04
edleafeThe second adds its allocations to that, and PUTs with a con_gen of 020:04
fried_bunnyyeah, the behavior you describe is what needs to happen.20:04
fried_bunnyBut I don't think that's the way it's coded up.20:04
fried_bunnycould be wrong.20:04
edleafeThe second succeeds this time, and now con_gen=120:04
fried_bunnyI think the way it's coded up, you're assuming None means "old microversion, so just increment"20:05
edleafeWhat I worry about is the second agent posting to an old microversion20:05
fried_bunnyThat's his fault.20:05
edleafeWhich means "preserve the existing behavior"20:05
edleafewhich means overwriting20:05
fried_bunnyAs far as that guy is concerned, the generation field doesn't exist.  For the sanity of the first guy, we have to increment it.  But if you're trying to use allocations from multiple clients and you're not using the generation-supporting microversion, you're toast anyway.20:06
edleafeIt's (very) possible that I missed a case in the code. But the approach is what was designed20:06
edleafeagree that even if there is a post with an old microversion, the generation should be incremented20:07
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905320:08
*** liverpooler has quit IRC20:08
fried_bunnyedleafe: I'm going through the spec again, but I don't recall this case being covered.20:08
fried_bunnyIt needs to be described explicitly, because it's weird.20:09
fried_bunny"Here's a new microversion where you have to send generation to ensure consistency.  Oh, except the first time, when you have to send None (or leave it empty??).  But if you do that when the consumer already exists, you'll fail.20:10
fried_bunny"20:10
*** dtruong has joined #openstack-nova20:11
edleafeit might not be in the spec20:11
edleafeBut it's not that weird. Standard practice is to get existing allocations before adding any new ones20:12
edleafeI know it was discussed20:12
*** Sukhdev_ has quit IRC20:12
fried_bunnyokay, so what will you return?20:12
fried_bunnyin that first one?20:12
fried_bunnyRight now you get {}20:13
edleafebut those discussions happened in several places at various times20:13
fried_bunnyWill you return { "consumer_generation": None } ?20:13
fried_bunnyor am I responsible for doing result.get('consumer_generation', None) ?20:13
edleafeIf there are no allocations for a consumer, then there is no consumer20:13
fried_bunnyCool.  So when I do my PUT, do I say "consumer_generation": None, or do I exclude the "consumer_generation" field entirely?20:14
edleafeIf you're PUTting to the new microversion, you would have to pass the generation, so the former20:14
fried_bunnyIn which case the schema needs to tolerate [int or null]20:15
edleafeguess it will have to :)20:15
edleafeI'm just starting the patch that adds the microversion. I think these cases will make for excellent functional tests20:16
fried_bunnyI'm gonna mark up the spec review.20:16
edleafegood idea20:16
*** yamahata has quit IRC20:17
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930020:18
*** eharney_ has joined #openstack-nova20:21
melwittfried_bunny: replied to your comments. this is my remaining open question https://review.openstack.org/#/c/533821/25/nova/tests/functional/api/openstack/placement/test_report_client.py@81220:21
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize  https://review.openstack.org/55358320:21
fried_bunnymelwitt: Roger that, looking...20:21
fried_bunny(thought you were bunnying today, melwitt)20:21
melwittunfortunately no20:22
*** eharney has quit IRC20:23
fried_bunnyedleafe: https://review.openstack.org/#/c/556971/ done been marked up.20:26
*** eharney_ is now known as eharney20:28
fried_bunnymelwitt: Responded.20:31
*** rcernin has joined #openstack-nova20:31
*** namnh has joined #openstack-nova20:35
fried_bunnyedleafe: tbc, you're not intending to do the microversion bump in https://review.openstack.org/#/c/557959/ right?20:37
edleafefried_bunny: yeah, it will be the next one in that series20:38
fried_bunnyrgr20:38
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930020:39
*** namnh has quit IRC20:40
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize  https://review.openstack.org/55358320:41
*** tbachman has quit IRC20:42
fried_bunnyedleafe: Hum, we need to change the POST /allocations and PUT /allocations/{c} responses to 200 with payload.20:45
fried_bunnythey're 204 right now.20:46
*** tbachman has joined #openstack-nova20:46
*** namnh has joined #openstack-nova20:46
*** yamahata has joined #openstack-nova20:46
*** tbachman has quit IRC20:47
*** yamamoto has joined #openstack-nova20:47
fried_bunnystarting to look like a mriedem commentary - three separate comment-leavings in a row on the same patch.20:49
*** fragatina has quit IRC20:49
*** namnh has quit IRC20:50
*** yamamoto has quit IRC20:52
edleafefried_bunny: not sure I get the reasoning behind changing the 204 from PUT/POST20:56
fried_bunnyedleafe: It's the same reason we did http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/generation-from-create-provider.html20:57
*** itlinux has quit IRC20:58
fried_bunnyedleafe: So clients don't have to do GET, PUT, GET, PUT -- can just do PUT, PUT instead.20:58
edleafeBut for a consumer? RPs are long-lived and frequently changed. Consumers rarely get changed, and I can't think of a use case where you would create allocs, and then create some more right away20:58
fried_bunnyeh?21:01
fried_bunnyHold on, processing that...21:01
melwittdansmith: is this your comment on L45? https://etherpad.openstack.org/p/nova-runways-rocky if all non-WIP changes are merged, I think we can bump the blueprint out of the runway and put the next in line in the runway. does that sound cool?21:01
*** AlexeyAbashkin has joined #openstack-nova21:02
dansmithmelwitt: bope not mine21:02
dansmither, nope21:02
fried_bunnyedleafe: But instinctive reaction is: We need to avoid focusing on Nova as the only consumer (again/still).21:02
dansmithmelwitt: but yes, the WIP bits are waiting on pieces of placement that don't exist yet, so it's "done"21:02
melwittoh, guh. I'm really bad at remembering what author color people are21:02
fried_bunnyit changes, too :(21:03
dansmithmelwitt: maybe want to, at least initially, copy things out of a runway to a log area and put some comments about how it went?21:03
edleafefried_bunny: I'm not thinking of Nova21:03
melwittdansmith: sounds like a good idea21:03
dansmithmelwitt: for that set, very little review was had for about a month and then it got review, iteration, and then merged quickly whilst in that slot21:03
fried_bunnydansmith, melwitt: ++ to that21:03
*** damien_r has joined #openstack-nova21:03
*** esberglu has quit IRC21:03
fried_bunny(the keeping-logs-of-runways)21:03
edleafefor any placement user: if you are making allocations, you would GET the current state, modify those allocations to add/remove what is needed, and then PUT that back21:04
*** sree has joined #openstack-nova21:04
fried_bunnyedleafe: And cache that, so that next time, you don't have to reGET.21:04
fried_bunnyexactly like we're doing for RPs.21:04
edleafefried_bunny: you'll have to come up with a scenario where that is at all plausible21:05
fried_bunnyresize21:05
fried_bunnyand21:05
fried_bunnysymmetry with the RP API21:05
fried_bunny:P21:05
melwittjackie-truong: hi, your blueprint https://blueprints.launchpad.net/nova/+spec/nova-validate-certificates is next in line for a review runway that we're looking to fill. is now a good time to iterate quickly on code review for the next two weeks in a runway?21:05
fried_bunnyIs it possible to GET before PUT every time?  Sure.  But so easy to avoid, so why?21:05
edleafewith resize you'd only change the consumer once21:05
*** AlexeyAbashkin has quit IRC21:06
edleafeSymmetry is only important if the things are similar enough21:06
fried_bunnyedleafe: per resize21:06
edleafe??21:06
fried_bunnyedleafe: or maybe not.  Maybe we're passing the allocation around to cinder to change storage allocs, cyborg to change dev allocs, neutron to change net allocs....21:06
fried_bunnySo it's half a dozen times per spawn, per resize, per whatever.21:07
edleafefried_bunny: that's the case for adding a generation. These will be presumably done in parallel, so it is racy by desing21:07
edleafedesign, even21:07
fried_bunnyBut what's the resistance?  Just that it's more code?21:07
edleafeno, because it doesn't fit how allocations should work21:08
fried_bunnywell, that I disagree with.21:08
fried_bunnyIf you had said it's because we don't have an immediate use case for reusing the allocation, I would still argue it's easier to do it now than in a new microversion later.21:09
*** sree has quit IRC21:09
edleafeLet's put this on hold and bring in jaypipes and cdent. One of us is not seeing things correctly21:10
*** ChanServ sets mode: +o dansmith21:10
fried_bunnyrgr21:11
fried_bunnyI commented in the spec.  We can discuss there.21:11
*** tbachman has joined #openstack-nova21:14
jackie-truongmelwitt: Yes, we can be available for the next two weeks to respond to code reviews21:15
melwittjackie-truong: sweet, I shall add the blueprint to the runway then. thanks21:16
*** dansmith changes topic to "Current runways: update-provider-tree / hurrah-for-privsep-again / nova-validate-certificates -- This channel is for Nova development. For support of Nova deployments, please use #openstack."21:17
*** ChanServ sets mode: -o dansmith21:17
jackie-truongmelwitt: Thanks!21:17
arvindn05are there any guidelines for initialization of datastructures in nova specifically? I have an object with a dictionary which may or may not be populated...21:18
*** jbryce has quit IRC21:18
arvindn05should we always initialize instead of making it None?21:18
*** jbryce has joined #openstack-nova21:19
dansmitharvindn05: that's probably too vague to answer without seeing what you're talking about21:20
arvindn05https://review.openstack.org/#/c/557795/21:20
arvindn05sorry...here is the review for context. https://review.openstack.org/#/c/557795/7/nova/objects/image_meta.py21:21
arvindn05i was trying to follow the pattern within the file where complex fields like ListOfSetsOfIntegersField are not initialized if there are no properties21:22
*** eharney has quit IRC21:24
dansmitharvindn05: I commented21:25
dansmitharvindn05: you should look at other patches to that object in recent history and see the pattern they use.. it doesn't matter that this is a "complex field"21:25
arvindn05ok...but was wondering if  there were guideline documented somewhere on passing None vs initialized objects...21:27
dansmitharvindn05: as I commented there, it makes no sense to be concerned that someone would pass None there21:27
arvindn05so you propose removing the if? I think the if is guarding against both empty properties as well as None21:29
dansmitharvindn05: did you read my comment?21:30
dansmithI'm proposing you remove the entire function21:30
*** gouthamr has quit IRC21:30
arvindn05yup getting to that :)21:30
arvindn05Also on the second comment, The method is to initialize/create the image meta props object from the dict21:31
arvindn05we are adding new attributes in the dict as per the blueprint https://blueprints.launchpad.net/openstack/?searchtext=glance-image-traits21:32
dansmitharvindn05: none of the other methods called before yours handle that parameter being None, so it will never get to your if condition if the thing is None21:33
*** awaugama has quit IRC21:34
arvindn05yup...but they do handle empty dict...in case of an empty dict, they do not initialize the fields21:35
arvindn05the if condition there is handling the empty dict case21:36
dansmitharvindn05: none of this matters since you shouldn't be setting that from from_dict() anyway, per my comment21:37
dansmither, wait wait, maybe I'm confused21:37
arvindn05dansmith: yup...i got that...can we discuss the comment?21:38
arvindn05http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/glance-image-traits.html#proposed-change21:39
arvindn05we are adding attributes like below to the image dict to support filtering based on traits expressed in images21:40
arvindn05trait:HW_CPU_X86_AVX2=required21:40
arvindn05trait:CUSTOM_TRUSTED_HOST=required21:40
dansmitharvindn05: yeah I know that part21:40
*** jackie-truong has quit IRC21:41
dansmithokay, sorry I had this all tangled in my head21:42
dansmithI was thinking this was the path in for the legacy dict, but this is actually the path in for image meta itself, which calls the name mapping stuff inside here21:42
arvindn05no problem...sorry i just threw it over the wall21:42
arvindn05yes...i think. the methods parses all the properties expressed in the image meta data(as a key:value strings) both legacy and non-legacy and creates the ImageMetaProps out of it21:45
dansmitharvindn05: replying to try to clean up my mess, hang on21:46
*** yamamoto has joined #openstack-nova21:48
dansmitharvindn05: see if that makes sense21:52
*** damien_r has quit IRC21:52
arvindn05thx..looking at it now21:52
dansmithsomething he said about none-ness sent me down the wrong path in thinking what this was about21:52
*** yamamoto has quit IRC21:54
*** sar has quit IRC21:54
*** germs has joined #openstack-nova21:55
*** germs has quit IRC21:55
*** germs has joined #openstack-nova21:55
arvindn05got it...makes sense21:55
arvindn05dansmith: thanks...will make the update21:55
dansmithack21:56
*** germs has quit IRC22:00
*** mlavalle has quit IRC22:15
openstackgerritEric Fried proposed openstack/nova master: Remove deprecated [placement] opts  https://review.openstack.org/55708622:27
*** Guest55359 has quit IRC22:28
*** yassine has joined #openstack-nova22:36
*** gouthamr has joined #openstack-nova22:37
openstackgerritArvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits  https://review.openstack.org/55779522:39
*** felipemonteiro_ has quit IRC22:39
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize  https://review.openstack.org/55358322:40
*** namnh has joined #openstack-nova22:42
openstackgerritArvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits  https://review.openstack.org/55779522:46
*** yamamoto has joined #openstack-nova22:50
*** yamamoto has quit IRC22:56
*** namnh has quit IRC23:01
*** namnh has joined #openstack-nova23:05
*** fragatina has joined #openstack-nova23:15
*** namnh has quit IRC23:17
*** hongbin has quit IRC23:17
*** yamahata has quit IRC23:19
*** namnh has joined #openstack-nova23:29
*** sdague has quit IRC23:31
*** lbragstad has quit IRC23:31
*** _ix has quit IRC23:31
*** jmlowe has joined #openstack-nova23:34
*** gouthamr has quit IRC23:41
*** namnh has quit IRC23:43
*** takashin has joined #openstack-nova23:45
*** namnh has joined #openstack-nova23:45
*** namnh has quit IRC23:45
*** Swami has quit IRC23:51
*** yamamoto has joined #openstack-nova23:52
*** yamahata has joined #openstack-nova23:55
*** germs has joined #openstack-nova23:56
*** germs has quit IRC23:56
*** germs has joined #openstack-nova23:56
*** yamamoto has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!